7bca9f8923f57c71585aa78f5b6652eef31e57bf
[WebKit-https.git] / Tools / ChangeLog
1 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
2
3         check-webkit-style fails due to system pylint
4         https://bugs.webkit.org/show_bug.cgi?id=144360
5
6         Reviewed by Darin Adler.
7
8         Make sure that the directory containing third party autoinstalled modules
9         is at the beginning of the search path, to avoid conflicts with other
10         versions of the same modules installed in the system (e.g. pylint).
11
12         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
13         modules directory to sys.path, instead of appending it.
14
15 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
16
17         Unreviewed, updated my list of email addresses.
18
19         * Scripts/webkitpy/common/config/contributors.json: Updated.
20
21 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
22
23         USE(...) macro should expect unprefixed variables
24         https://bugs.webkit.org/show_bug.cgi?id=144454
25
26         Reviewed by Daniel Bates.
27
28         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
29         * DumpRenderTree/config.h: Ditto.
30         * TestWebKitAPI/config.h: Ditto.
31
32 2015-05-01  Basile Clement  <basile_clement@apple.com>
33
34         Unreviewed. Add myself as a commiter in contributors.json.
35
36         * Scripts/webkitpy/common/config/contributors.json:
37
38 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
39
40         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
41         https://bugs.webkit.org/show_bug.cgi?id=144487
42
43         Reviewed by Ryosuke Niwa.
44
45         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
46         (BenchmarkRunner.merge): Fix bug.
47         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
48
49 2015-05-01  Brady Eidson  <beidson@apple.com>
50
51         Add API to disable meta refreshes.
52         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
53
54         Reviewed by Alexey Proskuryakov.
55
56         * DumpRenderTree/mac/DumpRenderTree.mm:
57         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
58
59 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
60
61         Provide a runtime flag to run-webkit-tests that shows the test view
62         https://bugs.webkit.org/show_bug.cgi?id=144079.
63
64         Unreviewed correction to r183651.
65
66         * WebKitTestRunner/TestController.cpp:
67         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
68         flag is included in the options dictionary passed to the PlatformWebView.
69
70 2015-05-01  Antti Koivisto  <antti@apple.com>
71
72         Remove network process load serialization code
73         https://bugs.webkit.org/show_bug.cgi?id=144448
74
75         Reviewed by Alexey Proskuryakov.
76
77         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
78         (WTR::InjectedBundle::beginTesting):
79         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
80         (WTR::TestRunner::setSerializeHTTPLoads):
81         (WTR::TestRunner::dispatchPendingLoadRequests):
82
83 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
84
85         [GTK] Add libhyphen-dev to the build dependencies
86         https://bugs.webkit.org/show_bug.cgi?id=144452
87
88         Reviewed by Martin Robinson.
89
90         * gtk/install-dependencies: Added hyphen as Fedora and Arch
91         dependencies.
92
93 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
94
95         Provide a runtime flag to run-webkit-tests that shows the test view
96         https://bugs.webkit.org/show_bug.cgi?id=144079.
97
98         Reviewed by Dean Jackson.
99
100         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
101         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
102         option:
103         
104         --additional-drt-flag="--show-webview"
105
106         * DumpRenderTree/mac/DumpRenderTree.mm:
107         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
108         '--show-webview' flag.
109         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
110         * WebKitTestRunner/Options.cpp:
111         (WTR::Options::Options):
112         (WTR::handleOptionShowWebView):
113         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
114         * WebKitTestRunner/Options.h:
115         * WebKitTestRunner/TestController.cpp:
116         (WTR::TestController::TestController):
117         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
118         * WebKitTestRunner/TestController.h:
119         (WTR::TestController::shouldShowWebView):
120         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
121         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
122         options dictionary. If it is true, display the web view while running the test.
123
124 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
125
126         r183355 didn't trigger Mac tests
127         https://bugs.webkit.org/show_bug.cgi?id=144464
128
129         Reviewed by Simon Fraser.
130
131         Update badly neglected filters and unit tests.
132
133         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
134         (_should_file_trigger_build):
135         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
136         (ShouldBuildTest):
137         (ShouldBuildTest.test_should_build):
138
139 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
140
141         [GTK] Add libhyphen-dev to the build dependencies
142         https://bugs.webkit.org/show_bug.cgi?id=144452
143
144         Reviewed by Martin Robinson.
145
146         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
147         build dependencies.
148
149 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
150
151         [GTK] Testing dictionaries are not installed automatically
152         https://bugs.webkit.org/show_bug.cgi?id=144460
153
154         Reviewed by Carlos Garcia Campos.
155
156         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
157
158 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
159
160         Fix return code issue, check return code of safari process and dump results to log
161         https://bugs.webkit.org/show_bug.cgi?id=144436
162
163         Reviewed by Ryosuke Niwa.
164
165         * Scripts/run-benchmark:
166         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
167         (BenchmarkRunner.dump): Correct typo.
168         (BenchmarkRunner.wrap): Add results to console.
169         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
170         (OSXSafariDriver.prepareEnv):
171         (OSXSafariDriver.launchUrl):
172         (OSXSafariDriver.closeBrowsers):
173
174 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
175
176         Should no longer need to worry about very old versions of Xcode
177         https://bugs.webkit.org/show_bug.cgi?id=144437
178
179         Reviewed by Dan Bernstein.
180
181         * Scripts/check-for-exit-time-destructors:
182         * Scripts/check-for-global-initializers:
183         * Scripts/check-for-weak-vtables-and-externals:
184
185 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
186
187         REGRESSION(183583): [Mac] make without SDKROOT has issues
188         https://bugs.webkit.org/show_bug.cgi?id=144431
189
190         Reviewed by Dan Bernstein.
191
192         * Makefile:
193         * WebKitTestRunner/Makefile:
194         Assume an empty SDKROOT means an macosx variant, so only
195         enable settings if the SDKROOT is not empty and does not
196         contain "macosx".
197
198 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
199
200         Expand test infrastructure to support scrolling tests
201         https://bugs.webkit.org/show_bug.cgi?id=143684
202         <rdar://problem/20375516>
203
204         Reviewed by Simon Fraser.
205
206         * DumpRenderTree/mac/DumpRenderTree.mm:
207         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
208         reset before the next test run.
209         * WebKitTestRunner/TestController.cpp:
210         (WTR::TestController::resetStateToConsistentValues): Ditto."
211
212 2015-04-29  Alex Christensen  <achristensen@webkit.org>
213
214         Run javascriptcore tests on Windows without cygwin
215         https://bugs.webkit.org/show_bug.cgi?id=144419
216
217         Reviewed by Brent Fulgham.
218
219         * Scripts/run-javascriptcore-tests:
220         (runJSCStressTests):
221         Just call ruby, not /usr/bin/env ruby.
222
223 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
224
225         [GTK] Add --enable-shared option to LLVM to build mesa
226         https://bugs.webkit.org/show_bug.cgi?id=144393
227
228         Reviewed by Martin Robinson.
229
230         The updated mesa requires the shared LLVM libraries.
231         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
232         to LLVM configure script. It will provide shared libraries in addition to static libraries.
233
234         * gtk/jhbuild-optional.modules:
235
236 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
237
238         [GTK] Add support for automatic hyphenation
239         https://bugs.webkit.org/show_bug.cgi?id=44478
240
241         Reviewed by Carlos Garcia Campos.
242
243         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
244         all systems will use the same dictionaries for testing purposes.
245
246 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
247
248         Failure when building WebKit for appletvsimulator.
249         https://bugs.webkit.org/show_bug.cgi?id=144356
250
251         Reviewed by Alexey Proskuryakov.
252
253         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
254         make TVOS and WatchOS behave correctly.
255
256         * Makefile:
257         * WebKitTestRunner/Makefile:
258
259 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
260
261         Use-after-free when invalidating WKPageForceRepaint callback
262         https://bugs.webkit.org/show_bug.cgi?id=144401
263         rdar://problem/20741111
264
265         Reviewed by Tim Horton.
266
267         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
268
269         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
270         Don't do anything on error, because the context may be a stale pointer now.
271
272 2015-04-29  David Kilzer  <ddkilzer@apple.com>
273
274         check-webkit-style: Don't complain about returning value from Objective-C method call in header
275         <http://webkit.org/b/144395>
276
277         Reviewed by Andy Estes.
278
279         * Scripts/webkitpy/style/checkers/cpp.py:
280         (check_spacing): Update regex so 'return' is ignored if it
281         precedes the whitespace and bracket.  Change category name to
282         'whitespace/brackets'.  Add period to error message.
283         (CppChecker): Add 'whitespace/brackets' as a category.
284         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
285         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
286         'CppChecker.categories' since that's where the list lives now.
287         (CppStyleTest.test_spacing_before_brackets): Add tests for
288         'whitespace/brackets' issues and non-issues.
289
290 2015-04-29  Alex Christensen  <achristensen@webkit.org>
291
292         Fix WinCairo bot.
293
294         * Scripts/webkitdirs.pm:
295         (determinePassedConfiguration):
296         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
297
298 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
299
300         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
301         https://bugs.webkit.org/show_bug.cgi?id=132159
302
303         Reviewed by Darin Adler.
304
305         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
306         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
307
308         * DumpRenderTree/mac/DumpRenderTree.mm:
309         (fontWhitelist):
310         (adjustFonts):
311         (createWebViewAndOffscreenWindow):
312         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
313         (WTR::activateFonts):
314         * WebKitTestRunner/mac/TestControllerMac.mm:
315         (WTR::allowedFontFamilySet):
316         (WTR::systemHiddenFontFamilySet):
317         (WTR::generateWhitelist):
318         (WTR::TestController::platformInitializeContext):
319
320 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
321
322         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
323         https://bugs.webkit.org/show_bug.cgi?id=144155
324
325         Reviewed by Andreas Kling.
326
327         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
328         Make sure that test window is "visible" before each test. While there is no concrete
329         evidence that this is the problem indeed, the behavior is consistent with what would
330         happen for an invisible window. Also, WKTR obviously needs to do this to protect
331         against potential buggy tests that hide the window and don't show it.
332
333 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
334
335         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
336
337         Latest changes in the inspector UI made this test fail. We were
338         relying that the sidebar was always visible and the first 'li'
339         element of the inspector was the one containing the title. This is
340         no longer true, so better use document title that is not likely
341         to change.
342
343         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
344         (openRemoteDebuggingSession):
345
346 2015-04-29  Andres Gomez  <agomez@igalia.com>
347
348         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
349
350         * Scripts/webkitpy/common/config/contributors.json:
351
352 2015-04-29  Andres Gomez  <agomez@igalia.com>
353
354         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
355
356         * Scripts/webkitpy/common/config/watchlist:
357
358 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
359
360         [EFL] Allow to run the tests on the native X display
361         https://bugs.webkit.org/show_bug.cgi?id=144247
362
363         Reviewed by Gyuyoung Kim.
364
365         Added the USE_NATIVE_XDISPLAY option for the WTR.
366         We can select the Xorg driver if environment variable is set up before running the tests.
367
368         * Scripts/webkitpy/port/efl.py:
369         (EflPort._driver_class):
370
371 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
372
373         [GTK] Add libnotify-dev in gtk install-dependencies
374         https://bugs.webkit.org/show_bug.cgi?id=144379
375
376         Reviewed by Žan Doberšek.
377
378         * gtk/install-dependencies:
379
380 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
381
382         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
383         https://bugs.webkit.org/show_bug.cgi?id=143001
384
385         Reviewed by Gyuyoung Kim.
386
387         * WebKitTestRunner/TestController.cpp:
388         (WTR::shouldUseFixedLayout):
389
390 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
391
392         Increase stablility of run-benchmark script
393         https://bugs.webkit.org/show_bug.cgi?id=144361
394
395         Reviewed by Ryosuke Niwa.
396
397         * Scripts/run-benchmark:
398         (main):
399         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
400         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
401         (GenericBenchmarkBuilder.clean):
402         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
403         (BenchmarkRunner.__init__):
404         (BenchmarkRunner.execute):
405         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
406         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
407         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
408         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
409         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
410         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
411         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
412         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
413         (HTTPServerDriver.fetchResult):
414         (HTTPServerDriver):
415         (HTTPServerDriver.killServer): Add kill server interface.
416         (HTTPServerDriver.getReturnCode): Add get return code interface.
417         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
418         (SimpleHTTPServerDriver.serve):
419         (SimpleHTTPServerDriver.fetchResult):
420         (SimpleHTTPServerDriver):
421         (SimpleHTTPServerDriver.killServer):
422         (SimpleHTTPServerDriver.getReturnCode):
423         * Scripts/webkitpy/benchmark_runner/utils.py:
424         (forceRemove): Provide python version of 'rm -rf'.
425
426 2015-04-28  Sam Weinig  <sam@webkit.org>
427
428         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
429         https://bugs.webkit.org/show_bug.cgi?id=144363
430
431         Reviewed by Alex Christensen.
432
433         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
434         (TestWebKitAPI::createNFAs):
435         (TestWebKitAPI::TEST_F):
436         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
437         (TestWebKitAPI::countLiveNodes):
438         (TestWebKitAPI::createNFAs):
439         (TestWebKitAPI::buildDFAFromPatterns):
440         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
441
442 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
443
444         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
445         https://bugs.webkit.org/show_bug.cgi?id=144304
446
447         Reviewed by Geoffrey Garen.
448
449         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
450         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
451         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
452
453 2015-04-28  Commit Queue  <commit-queue@webkit.org>
454
455         Unreviewed, rolling out r183514.
456         https://bugs.webkit.org/show_bug.cgi?id=144359
457
458         It broke cloop test bots (Requested by mcatanzaro on #webkit).
459
460         Reverted changeset:
461
462         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
463         https://bugs.webkit.org/show_bug.cgi?id=144304
464         http://trac.webkit.org/changeset/183514
465
466 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
467
468         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
469         https://bugs.webkit.org/show_bug.cgi?id=144304
470
471         Reviewed by Geoffrey Garen.
472
473         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
474         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
475         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
476         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
477
478 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
479
480         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
481         https://bugs.webkit.org/show_bug.cgi?id=144319
482
483         Reviewed by Csaba Osztrogonác.
484
485         * TestWebKitAPI/CMakeLists.txt:
486         * TestWebKitAPI/PlatformEfl.cmake:
487
488 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
489
490         Fix common typo "targetting" => "targeting"
491         https://bugs.webkit.org/show_bug.cgi?id=144349
492
493         Reviewed by Daniel Bates.
494
495         * Scripts/webkitdirs.pm:
496         (execMacWebKitAppForDebugging):
497
498 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
499
500         [GTK][jhbuild] Mesa build failure with llvm 3.6
501         https://bugs.webkit.org/show_bug.cgi?id=144250
502
503         Reviewed by Žan Doberšek.
504
505         Bump the version of Mesa to 10.5.4
506
507         * gtk/jhbuild.modules:
508
509 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
510
511         Disable App Nap in WebKitTestRunner UI process
512         https://bugs.webkit.org/show_bug.cgi?id=144308
513
514         Reviewed by Daniel Bates.
515
516         * WebKitTestRunner/mac/main.mm:
517         (disableAppNapInUIProcess):
518         (main):
519
520 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
521
522         [GTK] Update JHBuild Mesa download directory
523         https://bugs.webkit.org/show_bug.cgi?id=144318
524
525         Update the download directory of Mesa module since the previous one
526         doesn't exist any more.
527
528         Reviewed by Žan Doberšek.
529
530         * gtk/jhbuild.modules:
531
532 2015-04-28  Commit Queue  <commit-queue@webkit.org>
533
534         Unreviewed, rolling out r183477.
535         https://bugs.webkit.org/show_bug.cgi?id=144334
536
537         Roll back the Mesa dependency bump in fear of uncaught
538         regressions while the testing bots are no-op. (Requested by
539         zdobersek on #webkit).
540
541         Reverted changeset:
542
543         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
544         https://bugs.webkit.org/show_bug.cgi?id=144250
545         http://trac.webkit.org/changeset/183477
546
547 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
548
549         [GTK][jhbuild] Mesa build failure with llvm 3.6
550         https://bugs.webkit.org/show_bug.cgi?id=144250
551
552         Reviewed by Žan Doberšek.
553
554         Bump the version of Mesa to 10.5.4
555
556         * gtk/jhbuild.modules:
557
558 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
559
560         Add '__init__.py' and fix known bug in benchmark runner.
561         https://bugs.webkit.org/show_bug.cgi?id=144296
562
563         Reviewed by Ryosuke Niwa
564
565         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
566         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
567         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
568         (BenchmarkRunner.__init__):
569         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
570         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
571         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
572
573 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
574
575         More build fix.
576
577         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
578         (-[AccessibilityNotificationHandler _notificationReceived:]):
579         Use -objectForKey:, not array subscript.
580
581 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
582
583         Catch unexpected exits in DumpRenderTree
584         https://bugs.webkit.org/show_bug.cgi?id=144288
585
586         Reviewed by Tim Horton.
587
588         * DumpRenderTree/mac/DumpRenderTree.mm:
589         (atexitFunction):
590         (DumpRenderTreeMain):
591
592 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
593
594         Build fix
595
596         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
597         (-[AccessibilityNotificationHandler _notificationReceived:]):
598         Use -objectForKey:, not array subscript.
599
600 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
601
602         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
603         https://bugs.webkit.org/show_bug.cgi?id=144155
604
605         Reviewed by Tim Horton.
606
607         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
608         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
609         and we clearly don't want App Nap while testing.
610
611 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
612
613         [CMake] Autogenerate cmakeconfig.h.cmake
614         https://bugs.webkit.org/show_bug.cgi?id=143997
615
616         Reviewed by Csaba Osztrogonác.
617
618         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
619         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
620
621 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
622
623         REGRESSION(r182879): Images and video can no longer be downloaded
624         https://bugs.webkit.org/show_bug.cgi?id=144267
625         <rdar://problem/20702844>
626
627         Reviewed by Simon Fraser.
628
629         Revise tests to check for proper download menu state.
630         1. Downloading a loal image should be disabled.
631         2. Downloading a local media file should be disabled.
632         3. Downloading non-downloadable media should be disabled.
633
634         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
635         (TestWebKitAPI::TEST):
636
637 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
638
639         Merge run-launcher into run-minibrowser
640         https://bugs.webkit.org/show_bug.cgi?id=141928
641
642         Reviewed by Darin Adler.
643
644         * Scripts/run-iexploder-tests:
645         (runSafariWithIExploder):
646         * Scripts/run-launcher: Removed.
647         * Scripts/run-minibrowser:
648         * Scripts/webkitdirs.pm:
649         (launcherPath):
650         * Scripts/webkitpy/port/efl.py:
651         (EflPort.show_results_html_file):
652         * Scripts/webkitpy/port/efl_unittest.py:
653         (EflPortTest.test_show_results_html_file):
654         * Scripts/webkitpy/port/gtk.py:
655         (GtkPort.print_leaks_summary):
656         (GtkPort.show_results_html_file):
657         (GtkPort): Deleted.
658         * Scripts/webkitpy/port/gtk_unittest.py:
659         (GtkPortTest.test_show_results_html_file):
660
661 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
662
663         [buildbot] Fix the output of perf-test buildstep on timeout
664         https://bugs.webkit.org/show_bug.cgi?id=144097
665
666         Reviewed by Ryosuke Niwa.
667
668         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
669         (RunAndUploadPerfTests.getText2):
670         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
671         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
672         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
673
674 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
675
676         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
677         https://bugs.webkit.org/show_bug.cgi?id=143874
678
679         Reviewed by Gyuyoung Kim.
680
681         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
682
683 2015-04-24  Philippe Normand  <pnormand@igalia.com>
684
685         [JHBuild] Move to upstream OpenWebRTC
686         https://bugs.webkit.org/show_bug.cgi?id=144145
687
688         Reviewed by Carlos Garcia Campos.
689
690         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
691         and add a new simple patch to gst-plugins-base, required for
692         OpenWebRTC build.
693         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
694         * gtk/jhbuild.modules: Ditto.
695         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
696
697 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
698
699         [ES6] Implement ES6 template literals
700         https://bugs.webkit.org/show_bug.cgi?id=142691
701
702         Reviewed by Darin Adler.
703
704         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
705
706         * Scripts/webkitperl/FeatureList.pm:
707
708 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
709
710         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
711         https://bugs.webkit.org/show_bug.cgi?id=144217
712
713         Reviewed by Darin Adler.
714
715         * WebKitTestRunner/PlatformEfl.cmake:
716
717 2015-04-26  Doug Russell  <d_russell@apple.com>
718
719         AX: richer text change notifications (142719)
720         https://bugs.webkit.org/show_bug.cgi?id=142719
721
722         Reviewed by Darin Adler.
723
724         Richer accessibility value change notifications. Introduce AXTextEditType,
725         postTextStateChangeNotification and postTextReplacementNotification to give assistive
726         tech apps more reliable context for responding to changes in web content. Also implement
727         a mechanism to post value changes in password form fields in coalesced ticks to thwart
728         analyzing the cadence of changes.
729
730         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
731         and an overload of postTextReplacementNotification to give assistive tech apps more
732         reliable context for responding to changes in web content selection. Also block posting
733         selection changes on password fields.
734
735         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
736         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
737         (-[AccessibilityNotificationHandler stopObserving]):
738         (-[AccessibilityNotificationHandler _notificationReceived:]):
739         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
740         (AccessibilityUIElement::removeNotificationListener):
741         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
742         (-[AccessibilityNotificationHandler _notificationReceived:]):
743         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
744         (WTR::AccessibilityUIElement::removeNotificationListener):
745
746 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
747
748         Add myself to contributors.json
749         https://bugs.webkit.org/show_bug.cgi?id=144204
750
751         Reviewed by Darin Adler.
752
753         * Scripts/webkitpy/common/config/contributors.json:
754
755 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
756
757         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
758         https://bugs.webkit.org/show_bug.cgi?id=144182
759
760         Reviewed by Simon Fraser.
761
762         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
763
764 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
765
766         https://bugs.webkit.org/show_bug.cgi?id=144038
767
768         Reviewed by Ryosuke Niwa
769
770         Add a script to run Speedometer and JetStream on a browser.
771
772         * Scripts/run-benchmark: Wrapper script to run benchmark.
773         (main):
774         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
775         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
776         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
777         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
778         (BenchmarkBuilderFactory):
779         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
780         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
781         (GenericBenchmarkBuilder):
782         (GenericBenchmarkBuilder.prepare):
783         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
784         (GenericBenchmarkBuilder._applyPatch):
785         (GenericBenchmarkBuilder.clean):
786         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
787         (JetStreamBenchmarkBuilder):
788         (JetStreamBenchmarkBuilder.prepare):
789         (JetStreamBenchmarkBuilder._runCreateScript):
790         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
791         (BenchmarkRunner):
792         (BenchmarkRunner.__init__):
793         (BenchmarkRunner.execute):
794         (BenchmarkRunner.dump):
795         (BenchmarkRunner.wrap):
796         (BenchmarkRunner.merge):
797         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
798         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
799         (BrowserDriver):
800         (BrowserDriver.prepareEnv):
801         (BrowserDriver.launchUrl):
802         (BrowserDriver.closeBrowser):
803         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
804         (BrowserDriverFactory):
805         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
806         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
807         (OSXChromeDriver):
808         (OSXChromeDriver.prepareEnv):
809         (OSXChromeDriver.launchUrl):
810         (OSXChromeDriver.closeBrowsers):
811         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
812         (OSXSafariDriver):
813         (OSXSafariDriver.prepareEnv):
814         (OSXSafariDriver.launchUrl):
815         (OSXSafariDriver.closeBrowsers):
816         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
817         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
818         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
819         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
820         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
821         (GenericFactory):
822         (GenericFactory.iterateGetItem):
823         (GenericFactory.create):
824         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
825         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
826         (ServerControl):
827         (ServerControl.render_GET):
828         (ServerControl.render_POST):
829         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
830         (HTTPServerDriver):
831         (HTTPServerDriver.serve):
832         (HTTPServerDriver.fetchResult):
833         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
834         (HTTPServerDriverFactory):
835         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
836         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
837         (SimpleHTTPServerDriver):
838         (SimpleHTTPServerDriver.depends):
839         (SimpleHTTPServerDriver.__init__):
840         (SimpleHTTPServerDriver.serve):
841         (SimpleHTTPServerDriver.baseUrl):
842         (SimpleHTTPServerDriver.fetchResult):
843         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
844         (ModuleNotFoundError):
845         (loadModule):
846         (getPathFromProjectRoot):
847         (loadJSONFromFile):
848         (TimeoutError):
849         (timeout):
850         (timeout.__init__):
851         (timeout.handle_timeout):
852         (timeout.__enter__):
853         (timeout.__exit__):
854
855 2015-04-24  Commit Queue  <commit-queue@webkit.org>
856
857         Unreviewed, rolling out r183303.
858         https://bugs.webkit.org/show_bug.cgi?id=144181
859
860         Change was incorrect, broke builds (Requested by smfr on
861         #webkit).
862
863         Reverted changeset:
864
865         "Fix the build."
866         http://trac.webkit.org/changeset/183303
867
868 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
869
870         Fix the build.
871
872         * MiniBrowser/mac/WK2BrowserWindowController.m:
873         (-[WK2BrowserWindowController initWithConfiguration:]):
874
875 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
876
877         Disable ActionMenusPDFTest due to timeout on test bot
878
879         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
880         (TestWebKitAPI::TEST):
881
882 2015-04-24  Commit Queue  <commit-queue@webkit.org>
883
884         Unreviewed, rolling out r183266.
885         https://bugs.webkit.org/show_bug.cgi?id=144164
886
887         Broke 32-bit build and a test. (Requested by ap on #webkit).
888
889         Reverted changeset:
890
891         "AX: richer text change notifications (142719)"
892         https://bugs.webkit.org/show_bug.cgi?id=142719
893         http://trac.webkit.org/changeset/183266
894
895 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
896
897         REGRESSION: WebKit2.ActionMenusTest API test fails
898         https://bugs.webkit.org/show_bug.cgi?id=144149
899         <rdar://problem/20677770>
900
901         Reviewed by Tim Horton.
902
903         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
904         as the 'ActionMenusPDFTest'.
905         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
906         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
907         to match the hit test on the 'action-menu-target.pdf' test file.
908
909 2015-04-24  Daniel Bates  <dabates@apple.com>
910
911         Cleanup: Use @memoized for property IOSSimulator.testing_device
912         https://bugs.webkit.org/show_bug.cgi?id=141715
913
914         Reviewed by Darin Adler.
915
916         Simplify the caching of the result of IOSSimulator.testing_device
917         and make the code more readable by making use of the @memoized declarator
918         instead of explicitly managing a private instance variable,
919         IOSSimulator._testing_device, for the cached result.
920
921         * Scripts/webkitpy/port/ios.py:
922         (IOSPort.determine_full_port_name):
923         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
924         (IOSSimulatorPort):
925         (IOSSimulatorPort.testing_device): No need to cache the created device object in
926         IOSSimulatorPort._testing_device since we are marking this function @memoized.
927         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
928         of caching in local variable since we only make use of this value exactly once in this function.
929         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
930         been used since being added in r178622. So, we can remove this constructor since
931         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
932
933 2015-04-24  Anders Carlsson  <andersca@apple.com>
934
935         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
936         https://bugs.webkit.org/show_bug.cgi?id=144158
937
938         Reviewed by Beth Dakin.
939
940         * MiniBrowser/mac/WK2BrowserWindowController.m:
941         (-[WK2BrowserWindowController initWithConfiguration:]):
942
943 2015-04-24  Doug Russell  <d_russell@apple.com>
944
945         AX: richer text change notifications (142719)
946         https://bugs.webkit.org/show_bug.cgi?id=142719
947
948         Reviewed by Darin Adler.
949
950         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
951
952         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
953
954         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
955         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
956         (-[AccessibilityNotificationHandler stopObserving]):
957         (-[AccessibilityNotificationHandler _notificationReceived:]):
958         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
959         (AccessibilityUIElement::removeNotificationListener):
960         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
961         (-[AccessibilityNotificationHandler _notificationReceived:]):
962         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
963         (WTR::AccessibilityUIElement::removeNotificationListener):
964
965 2015-04-24  Darin Adler  <darin@apple.com>
966
967         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
968         https://bugs.webkit.org/show_bug.cgi?id=128007
969
970         Reviewed by Anders Carlsson.
971
972         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
973         * DumpRenderTree/win/UIDelegate.h: Ditto.
974
975         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
976         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
977
978         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
979
980         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
981         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
982         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
983         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
984         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
985         (WebKitDOMDOMWindowTest::create): Ditto.
986         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
987         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
988         of smart pointers to DelayedSIgnal objects.
989         (uriChangedCallback): Ditto.
990
991 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
992
993         [Mac] Unreviewed test fix.
994         https://bugs.webkit.org/show_bug.cgi?id=144149
995
996         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
997         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
998         test.
999
1000 2015-04-23  Darin Adler  <darin@apple.com>
1001
1002         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
1003         https://bugs.webkit.org/show_bug.cgi?id=144090
1004
1005         Reviewed by Anders Carlsson.
1006
1007         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
1008
1009 2015-04-23  Michael Saboff  <msaboff@apple.com>
1010
1011         lldb macro btjs sometimes can't get a frame description
1012         https://bugs.webkit.org/show_bug.cgi?id=144130
1013
1014         Reviewed by Filip Pizlo.
1015
1016         We look to execute ExecState::describeFrame().  It appears that in some contexts the
1017         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
1018         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
1019
1020         * lldb/lldb_webkit.py:
1021         (btjs):
1022
1023 2015-04-23  Alex Christensen  <achristensen@webkit.org>
1024
1025         Use less memory when compiling content extensions.
1026         https://bugs.webkit.org/show_bug.cgi?id=144051
1027
1028         Reviewed by Darin Adler and Benjamin Poulain.
1029
1030         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1031         (TestWebKitAPI::TEST_F):
1032         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1033         (TestWebKitAPI::countLiveNodes):
1034
1035 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1036
1037         [CMake] Clean up JSC JIT options
1038         https://bugs.webkit.org/show_bug.cgi?id=143998
1039
1040         Reviewed by Filip Pizlo.
1041
1042         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
1043         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
1044
1045 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
1046
1047         [Mac] Extend action menus to support PDF
1048         https://bugs.webkit.org/show_bug.cgi?id=143895
1049         <rdar://problem/19003333>
1050
1051         Reviewed by Tim Horton.
1052
1053         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
1054         of PDF content works.
1055
1056         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
1057         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
1058         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
1059         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1060         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1061         Update to support PDF tests.
1062         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
1063         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
1064
1065 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1066
1067         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
1068
1069         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1070         (beforeAll):
1071         (testWebViewAudioOnlyUserMediaPermissionRequests):
1072
1073 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1074
1075         Add myself to watchlist
1076         https://bugs.webkit.org/show_bug.cgi?id=144041
1077
1078         Reviewed by Alex Christensen.
1079
1080         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
1081
1082         * Scripts/webkitpy/common/config/watchlist:
1083
1084 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1085
1086         [GTK] MiniBrowser should use NetworkProcess by default
1087         https://bugs.webkit.org/show_bug.cgi?id=143948
1088
1089         Reviewed by Sergio Villar Senin.
1090
1091         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
1092         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
1093
1094         * MiniBrowser/gtk/main.c:
1095         (main):
1096
1097 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
1098
1099         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
1100
1101         Unreviewed build fix.
1102
1103         * Scripts/prepare-ChangeLog:
1104         (get_function_line_ranges_for_cpp):
1105         Use grep instead of any to determine if a string is an element of an array.
1106
1107 2015-04-21  Anders Carlsson  <andersca@apple.com>
1108
1109         Fix block signatures
1110         https://bugs.webkit.org/show_bug.cgi?id=144002
1111
1112         Reviewed by Andreas Kling.
1113
1114         * MiniBrowser/mac/WK2BrowserWindowController.m:
1115         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1116
1117 2015-04-21  Philippe Normand  <pnormand@igalia.com>
1118
1119         [GTK] jhbuild should not use a branch for openwebrtc
1120         https://bugs.webkit.org/show_bug.cgi?id=143981
1121
1122         Reviewed by Carlos Garcia Campos.
1123
1124         * gtk/jhbuild.modules:
1125
1126 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
1127
1128         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
1129
1130         Unreviewed build fix.
1131
1132         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
1133         However, it has been exposed by List::MoreUtils since its inception. This patch uses
1134         the any function exposed by List::MoreUtils for greater compatibility.
1135
1136         * Scripts/prepare-ChangeLog:
1137         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
1138         the any function in all of versions of Perl used by our infrastructure.
1139
1140 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1141
1142         Remove unnecessary logs when resetting tests.
1143
1144         * WebKitTestRunner/mac/TestControllerMac.mm:
1145         (WTR::TestController::platformResetPreferencesToConsistentValues):
1146         In r183020 I added some logs when compiling or removing content extensions fails.
1147         We often try to remove a content extension that does not exist, and that is not a problem.
1148
1149 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1150
1151         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
1152         https://bugs.webkit.org/show_bug.cgi?id=143897
1153
1154         Reviewed by David Kilzer.
1155
1156         This is a speculative fix that addresses two issues:
1157
1158         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
1159         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
1160
1161         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
1162         Before: (723, 729)
1163         After: (721, 720)
1164
1165         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
1166         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
1167
1168         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
1169         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
1170
1171         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
1172
1173         2. Creating git diffs from HEAD and not origin/master by default.
1174
1175         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
1176         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
1177
1178         * Scripts/prepare-ChangeLog:
1179         (originalFile):
1180         Use HEAD instead of origin/master in default Git case.
1181
1182         (generateFunctionLists):
1183         Ensure that the end line is not less than the start line.
1184
1185         (extractLineRangeAfterChange):
1186         Set the end line to the start line if the end line is less than the start line.
1187
1188         (extractLineRangeBeforeChange):
1189         Ditto.
1190
1191 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1192
1193         Suppress warning in prepare-ChangeLog.
1194         https://bugs.webkit.org/show_bug.cgi?id=143882
1195
1196         Reviewed by David Kilzer.
1197
1198         Prune noisy prepare-ChangeLog output by using the List::Util::any function
1199         instead of the deprecated smartmatch operator.
1200
1201         * Scripts/prepare-ChangeLog:
1202         Import the List::Util::any function.
1203
1204         (get_function_line_ranges_for_cpp):
1205         Use the any function instead of smartmatch.
1206
1207 2015-04-20  Anders Carlsson  <andersca@apple.com>
1208
1209         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
1210         https://bugs.webkit.org/show_bug.cgi?id=143966
1211
1212         Reviewed by Dan Bernstein.
1213
1214         * MiniBrowser/mac/WK2BrowserWindowController.m:
1215         (dataTypes):
1216         (-[WK2BrowserWindowController fetchWebsiteData:]):
1217         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1218         (-[WK2BrowserWindowController clearWebsiteData:]):
1219
1220 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1221
1222         Fix content extension test flakiness.
1223         https://bugs.webkit.org/show_bug.cgi?id=143950
1224
1225         Reviewed by Brady Eidson.
1226
1227         * WebKitTestRunner/mac/TestControllerMac.mm:
1228         (WTR::TestController::platformResetPreferencesToConsistentValues):
1229         Remove the TestContentExtensions if it exists.
1230         (WTR::TestController::platformConfigureViewForTest):
1231         Log errors in case there are any.
1232
1233 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1234
1235         Properly report errors from _WKUserContentExtensionStore.
1236         https://bugs.webkit.org/show_bug.cgi?id=143808
1237
1238         Reviewed by Darin Adler.
1239
1240         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1241         (TEST_F):
1242
1243 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1244
1245         Add a rule for NetworkCache to watchlist file
1246         https://bugs.webkit.org/show_bug.cgi?id=143945
1247
1248         Reviewed by Sergio Villar Senin.
1249
1250         And add myself to the list of watchers.
1251
1252         * Scripts/webkitpy/common/config/watchlist:
1253
1254 2015-04-19  Darin Adler  <darin@apple.com>
1255
1256         Update RefPtr documentation and deprecation
1257         https://bugs.webkit.org/show_bug.cgi?id=143936
1258
1259         Reviewed by Andreas Kling.
1260
1261         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
1262
1263 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1264
1265         Introduce bytecode intrinsics
1266         https://bugs.webkit.org/show_bug.cgi?id=143926
1267
1268         Reviewed by Filip Pizlo.
1269
1270         Change cpplint to accept emit_intrinsic_XXX.
1271
1272         * Scripts/webkitpy/style/checkers/cpp.py:
1273         (check_identifier_name_in_declaration):
1274
1275 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
1276
1277         Fix lldb_webkit.py to show StringImpls correctly
1278         https://bugs.webkit.org/show_bug.cgi?id=143920
1279
1280         Reviewed by Andreas Kling.
1281         
1282         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
1283
1284         * lldb/lldb_webkit.py:
1285         (WTFStringImplProvider.is_8bit):
1286
1287 2015-04-17  Daniel Bates  <dabates@apple.com>
1288
1289         Not able to build WebKit against iOS Simulator 8.3 SDK
1290         https://bugs.webkit.org/show_bug.cgi?id=143883
1291
1292         Reviewed by David Kilzer.
1293
1294         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
1295         so that Xcode uses them.
1296
1297         * Scripts/copy-webkitlibraries-to-product-directory:
1298
1299 2015-04-17  Beth Dakin  <bdakin@apple.com>
1300
1301         Force mouse events should go through normal mouse event handling code paths
1302         https://bugs.webkit.org/show_bug.cgi?id=143749
1303         -and corresponding-
1304         rdar://problem/20472895
1305
1306         Reviewed by Dean Jackson.
1307
1308         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
1309         Since there is not a way to create an NSEventTypePressure from scratch, we 
1310         subclass NSEvent and override all of the critical methods.
1311
1312         * WebKitTestRunner/EventSenderProxy.h:
1313         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1314         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1315         (WTR::EventSendingController::mouseForceDown):
1316         (WTR::EventSendingController::mouseForceUp):
1317         (WTR::EventSendingController::mouseForceChanged):
1318         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1319         * WebKitTestRunner/TestController.cpp:
1320         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1321         * WebKitTestRunner/mac/EventSenderProxy.mm:
1322         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1323         (-[EventSenderPressureEvent timestamp]):
1324         (-[EventSenderPressureEvent type]):
1325         (-[EventSenderPressureEvent locationInWindow]):
1326         (-[EventSenderPressureEvent location]):
1327         (-[EventSenderPressureEvent stage]):
1328         (-[EventSenderPressureEvent pressure]):
1329         (-[EventSenderPressureEvent phase]):
1330         (-[EventSenderPressureEvent eventNumber]):
1331         (WTR::EventSenderProxy::mouseForceDown):
1332         (WTR::EventSenderProxy::mouseForceUp):
1333         (WTR::EventSenderProxy::mouseForceChanged):
1334
1335 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
1336
1337         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
1338         https://bugs.webkit.org/show_bug.cgi?id=143885
1339
1340         Reviewed by Tim Horton.
1341
1342         Fixed a case where we have two builds with the same revision(s). An in order build
1343         is one for which the revision is strictly higher.
1344
1345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1346         (BuildbotQueue.prototype._checkForInOrderResult):
1347         (BuildbotQueue.prototype.compareIterationsByRevisions):
1348
1349 2015-04-17  Commit Queue  <commit-queue@webkit.org>
1350
1351         Unreviewed, rolling out r182912 and r182920.
1352         https://bugs.webkit.org/show_bug.cgi?id=143881
1353
1354         Build breakage in some configurations (Requested by ap on
1355         #webkit).
1356
1357         Reverted changesets:
1358
1359         "Force mouse events should go through normal mouse event
1360         handling code paths"
1361         https://bugs.webkit.org/show_bug.cgi?id=143749
1362         http://trac.webkit.org/changeset/182912
1363
1364         http://trac.webkit.org/changeset/182920
1365
1366 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
1367
1368         [GTK] One more unreviewed fix after r182882.
1369
1370         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
1371
1372 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
1373
1374         [GTK] Unreviewed speculative clean build fix after r182882.
1375
1376         TestWebKitAPI's forwarding header generator depended on WeKit2's
1377         which generated SOUP related forwarding headers too.
1378
1379         This dependency isn't necessary and was removed by r182882 to make
1380         forwarding header generators parallelizable. But in this case
1381         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
1382         should generate SOUP related forwarding headers too similar to EFL.
1383
1384         * TestWebKitAPI/PlatformGTK.cmake:
1385         * WebKitTestRunner/PlatformGTK.cmake:
1386
1387 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1388
1389         [SOUP] Redirect to non HTTP destination is broken
1390         https://bugs.webkit.org/show_bug.cgi?id=143866
1391
1392         Reviewed by Sergio Villar Senin.
1393
1394         Add a unit test to check that redirect to a data URI works.
1395
1396         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1397         (testRedirectToDataURI):
1398         (serverCallback):
1399         (beforeAll):
1400
1401 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
1402
1403         Changes method of quitting iOS Simulator to be more correct.
1404         https://bugs.webkit.org/show_bug.cgi?id=143847
1405         <rdar://problem/20530344>
1406
1407         Reviewed by Darin Adler.
1408
1409         Fixes by addressing the app by ID rather than by name.
1410
1411         * Scripts/webkitdirs.pm:
1412         (quitIOSSimulator):
1413         * Scripts/webkitpy/port/ios.py:
1414         (IOSSimulatorPort.check_sys_deps):
1415
1416 2015-04-16  Anders Carlsson  <andersca@apple.com>
1417
1418         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
1419         https://bugs.webkit.org/show_bug.cgi?id=143844
1420
1421         Reviewed by Dan Bernstein.
1422
1423         * MiniBrowser/mac/AppDelegate.m:
1424         (-[BrowserAppDelegate newPrivateWindow:]):
1425         * MiniBrowser/mac/WK2BrowserWindowController.m:
1426         (-[WK2BrowserWindowController initWithConfiguration:]):
1427         (-[WK2BrowserWindowController fetchWebsiteData:]):
1428         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1429         (-[WK2BrowserWindowController clearWebsiteData:]):
1430
1431 2015-04-16  Alex Christensen  <achristensen@webkit.org>
1432
1433         32-bit build fix.
1434
1435         * WebKitTestRunner/mac/TestControllerMac.mm:
1436         (WTR::TestController::platformResetPreferencesToConsistentValues):
1437         (WTR::TestController::platformConfigureViewForTest):
1438         Added WK_API_ENABLED.
1439
1440 2015-04-16  Alex Christensen  <achristensen@webkit.org>
1441
1442         Removed unused WKUserContentFilterRef.
1443         https://bugs.webkit.org/show_bug.cgi?id=143852
1444
1445         Reviewed by Sam Weinig.
1446
1447         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1448         * WebKitTestRunner/mac/TestControllerMac.mm:
1449         (WTR::TestController::platformResetPreferencesToConsistentValues):
1450         (WTR::TestController::platformConfigureViewForTest):
1451
1452 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
1453
1454         Unreviewed. Adding myself as a commiter in contributers.json.
1455
1456         * Scripts/webkitpy/common/config/contributors.json:
1457
1458 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
1459
1460         It is very hard to attach a debugger to WebProcess to debug tests
1461         https://bugs.webkit.org/show_bug.cgi?id=143837
1462
1463         Reviewed by Chris Dumez.
1464
1465         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
1466         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
1467
1468         Now it disables all timeouts in tools, as is best for debugging tests.
1469
1470         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
1471         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
1472
1473         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
1474         now has the same functionality.
1475
1476 2015-04-16  Beth Dakin  <bdakin@apple.com>
1477
1478         Force mouse events should go through normal mouse event handling code paths
1479         https://bugs.webkit.org/show_bug.cgi?id=143749
1480         -and corresponding-
1481         rdar://problem/20472895
1482
1483         Reviewed by Dean Jackson.
1484
1485         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
1486         Since there is not a way to create an NSEventTypePressure from scratch, we 
1487         subclass NSEvent and override all of the critical methods.
1488
1489         * WebKitTestRunner/EventSenderProxy.h:
1490         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1491         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1492         (WTR::EventSendingController::mouseForceDown):
1493         (WTR::EventSendingController::mouseForceUp):
1494         (WTR::EventSendingController::mouseForceChanged):
1495         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1496         * WebKitTestRunner/TestController.cpp:
1497         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1498         * WebKitTestRunner/mac/EventSenderProxy.mm:
1499         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1500         (-[EventSenderPressureEvent timestamp]):
1501         (-[EventSenderPressureEvent type]):
1502         (-[EventSenderPressureEvent locationInWindow]):
1503         (-[EventSenderPressureEvent location]):
1504         (-[EventSenderPressureEvent stage]):
1505         (-[EventSenderPressureEvent pressure]):
1506         (-[EventSenderPressureEvent phase]):
1507         (-[EventSenderPressureEvent eventNumber]):
1508         (WTR::EventSenderProxy::mouseForceDown):
1509         (WTR::EventSenderProxy::mouseForceUp):
1510         (WTR::EventSenderProxy::mouseForceChanged):
1511
1512 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
1513
1514         [EFL] Bump LLVM to version 3.6.0 on X86_64
1515         https://bugs.webkit.org/show_bug.cgi?id=143604
1516
1517         Reviewed by Gyuyoung Kim.
1518
1519         * efl/jhbuild.modules:
1520         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
1521         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
1522         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
1523         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
1524
1525 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
1526
1527         [EFL] Remove an unnecessary workaround from jhbuildrc
1528         https://bugs.webkit.org/show_bug.cgi?id=143823
1529
1530         Reviewed by Gyuyoung Kim.
1531
1532         * efl/jhbuildrc:
1533
1534 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
1535
1536         [GTK] Run forwarding headers generator unconditionally
1537         https://bugs.webkit.org/show_bug.cgi?id=143819
1538
1539         Reviewed by Carlos Garcia Campos.
1540
1541         * TestWebKitAPI/PlatformGTK.cmake:
1542         * WebKitTestRunner/PlatformGTK.cmake:
1543
1544 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1545
1546         [EFL] Add gnutls to jhbuild.module
1547         https://bugs.webkit.org/show_bug.cgi?id=143777
1548
1549         Reviewed by Csaba Osztrogonác.
1550
1551         EFL port has required at least 3.0.0 version of gnutls since r176712.
1552         However some old linux distributions don't support 3.0.0 version. Besides
1553         other projects sometimes need to use lower version of gnutls.
1554
1555         This patch supports to download gnutls through jhbuild, and use it.
1556
1557         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
1558         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
1559
1560 2015-04-15  Mark Lam  <mark.lam@apple.com>
1561
1562         Remove obsolete VMInspector debugging tool.
1563         https://bugs.webkit.org/show_bug.cgi?id=143798
1564
1565         Reviewed by Michael Saboff.
1566
1567         * TestWebKitAPI/CMakeLists.txt:
1568         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1569         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1571         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
1572
1573 2015-04-15  Jer Noble  <jer.noble@apple.com>
1574
1575         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
1576
1577         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1578
1579 2015-04-15  Jer Noble  <jer.noble@apple.com>
1580
1581         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
1582
1583         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1584         (TestWebKitAPI::TEST_F):
1585
1586 2015-04-15  Chris Dumez  <cdumez@apple.com>
1587
1588         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
1589         https://bugs.webkit.org/show_bug.cgi?id=143779
1590
1591         Reviewed by Brent Fulgham.
1592
1593         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
1594         similarly to what is done on Mac / WK1. Without this, PageCache could
1595         stay enabled after page cache tests and cause weird behaviors.
1596
1597         * DumpRenderTree/win/DumpRenderTree.cpp:
1598         (resetWebPreferencesToConsistentValues):
1599
1600 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
1601
1602         Re-enable custom dilation for antialiased fonts
1603         https://bugs.webkit.org/show_bug.cgi?id=143738
1604
1605         Reviewed by Tim Horton.
1606         
1607         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
1608         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
1609         a private WebKit pref. This pref defaults to YES, enabling the feature by default
1610         in WK1 as we do for WK2.
1611
1612         * DumpRenderTree/mac/DumpRenderTree.mm:
1613         (resetWebPreferencesToConsistentValues):
1614         * WebKitTestRunner/TestController.cpp:
1615         (WTR::TestController::resetPreferencesToConsistentValues):
1616
1617 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
1618
1619         Correct layering violation in DumpRenderTree Build
1620         https://bugs.webkit.org/show_bug.cgi?id=143732
1621
1622         Reviewed by Simon Fraser.
1623
1624         Correct a layering violation in DumpRenderTree by calling functions on the
1625         WebCoreTestSupport library, rather than attempting to work with WebCore
1626         types directly.
1627
1628         * DumpRenderTree/mac/EventSendingController.mm:
1629         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
1630         than WebCore itself.,
1631         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
1632
1633 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
1634
1635         Add a conservative DFA minimizer for the content extension matcher
1636         https://bugs.webkit.org/show_bug.cgi?id=143501
1637
1638         Reviewed by Alex Christensen.
1639
1640         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1641         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1642
1643 2015-04-14  Daniel Bates  <dabates@apple.com>
1644
1645         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
1646         https://bugs.webkit.org/show_bug.cgi?id=143693
1647         <rdar://problem/20530316>
1648
1649         Reviewed by Tim Horton.
1650
1651         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
1652         to use the fixed layout code on iOS at this time.
1653
1654         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
1655
1656 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1657
1658         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
1659         https://bugs.webkit.org/show_bug.cgi?id=143705
1660
1661         Unreviewed change to watchlist file.
1662
1663         * Scripts/webkitpy/common/config/watchlist:
1664
1665 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
1666
1667         [EFL] favicon wasn't updated for google.com sometimes.
1668         https://bugs.webkit.org/show_bug.cgi?id=141940
1669
1670         Reviewed by Gyuyoung Kim.
1671
1672         As elm_entry_utf8_to_markup can include additional characters, parameter for the
1673         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
1674
1675         * MiniBrowser/efl/main.c:
1676         (on_url_changed):
1677
1678 2015-04-13  Tim Horton  <timothy_horton@apple.com>
1679
1680         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
1681         https://bugs.webkit.org/show_bug.cgi?id=143560
1682         <rdar://problem/16302047>
1683
1684         Reviewed by Darin Adler.
1685
1686         * MiniBrowser/mac/BrowserWindowController.h:
1687         * MiniBrowser/mac/MainMenu.xib:
1688         * MiniBrowser/mac/WK1BrowserWindowController.m:
1689         (-[WK1BrowserWindowController setScale:]):
1690         * MiniBrowser/mac/WK2BrowserWindowController.m:
1691         (viewScaleForMenuItemTag):
1692         (-[WK2BrowserWindowController setScale:]):
1693         (-[WK2BrowserWindowController validateMenuItem:]):
1694         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
1695         When in use, we resize the window so that the view fits correctly, and
1696         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
1697         layout size will not change when scaling down (but will update appropriately
1698         when the view is resized).
1699
1700 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
1701
1702         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
1703         https://bugs.webkit.org/show_bug.cgi?id=138630
1704
1705         Reviewed by Tim Horton.
1706
1707         Make sure that we always load at least one in order productive iteration.
1708
1709         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1710         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
1711         is done loading at least one iteration that wasn't an out of order build.
1712         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
1713         when that's needed to check for out of order builds.
1714         (BuildbotQueue.prototype.update): Ditto.
1715         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
1716         result, and if it does not, load more iterations.
1717         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
1718         an in order iteration loaded too.
1719         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
1720         corrected to always sort loaded iterations before unloaded ones.
1721
1722 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
1723
1724         Expand test infrastructure to support scrolling tests
1725         https://bugs.webkit.org/show_bug.cgi?id=143286
1726         <rdar://problem/20375516>
1727
1728         Reviewed by Simon Fraser.
1729
1730         Extend the WK1 and WK2 test programs to support two new EventSender commands:
1731         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
1732         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
1733         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
1734         relevant rubberband, scroll, and scroll-snap animations are finished.
1735
1736         * DumpRenderTree/mac/EventSendingController.mm:
1737         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
1738         and 'monitorWheelEvents'.
1739         (+[EventSendingController webScriptNameForSelector:]): Ditto.
1740         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
1741         debugging test failures.
1742         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
1743         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
1744         function, then passes it to WebCore to be called once the test deferrals have been cleared.
1745         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
1746         'callAfterScrollingCompletes' method.
1747         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
1748         and 'monitorWheelEvents'.
1749         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1750         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
1751         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
1752         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
1753         'callAfterScrollingComplates' method.
1754         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1755
1756 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
1757
1758         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
1759         https://bugs.webkit.org/show_bug.cgi?id=143656
1760
1761         Reviewed by Darin Adler.
1762
1763         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1764         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1765
1766 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
1767
1768         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
1769         https://bugs.webkit.org/show_bug.cgi?id=142387
1770
1771         Reviewed by Carlos Garcia Campos.
1772
1773         Running mixed content is blocked by default since r181134. Updated
1774         the test case to reflect the new default settings.
1775
1776         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1777         (testInsecureContent):
1778
1779 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1780
1781         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
1782         https://bugs.webkit.org/show_bug.cgi?id=143667
1783
1784         Reviewed by Csaba Osztrogonác.
1785
1786         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
1787         since r169017. Added $hardwareConcurrencySupport for it.
1788
1789         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
1790
1791         * Scripts/webkitperl/FeatureList.pm:
1792
1793 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
1794
1795         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
1796         https://bugs.webkit.org/show_bug.cgi?id=143664
1797
1798         Reviewed by Gyuyoung Kim.
1799
1800         * Scripts/webkitperl/FeatureList.pm:
1801
1802 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1803
1804         [EFL] Enable Media Source
1805         https://bugs.webkit.org/show_bug.cgi?id=143635
1806
1807         Reviewed by Csaba Osztrogonác.
1808
1809         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
1810
1811 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
1812
1813         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
1814         https://bugs.webkit.org/show_bug.cgi?id=143646
1815
1816         Reviewed by David Kilzer.
1817
1818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1819         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1820
1821 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
1822
1823         Use en_US spell checker for tests on Mac instead of Multilingual
1824         https://bugs.webkit.org/show_bug.cgi?id=143641
1825
1826         Reviewed by Dan Bernstein.
1827
1828         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1829         While at it, override NSUserDictionaryReplacementItems, so that user replacements
1830         cannot affect tests.
1831
1832         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
1833         Made this more like WebKit1 version.
1834
1835 2015-04-10  Tim Horton  <timothy_horton@apple.com>
1836
1837         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
1838         https://bugs.webkit.org/show_bug.cgi?id=143576
1839
1840         Reviewed by Simon Fraser.
1841
1842         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
1843         (TEST):
1844         Adopt.
1845
1846 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1847
1848         Update my email address and expertise.
1849         https://bugs.webkit.org/show_bug.cgi?id=143586
1850
1851         Unreviewed, just update my info.
1852
1853         * Scripts/webkitpy/common/config/contributors.json:
1854
1855 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
1856
1857         Flakiness Dashboard not loading insecure content if loaded with https URL
1858         https://bugs.webkit.org/show_bug.cgi?id=143570
1859
1860         Reviewed by Alexey Proskuryakov.
1861
1862         * TestResultServer/app.yaml:
1863         * TestResultServer/static-dashboards/loader.js:
1864         Switch to https scheme.
1865
1866 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
1867
1868         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
1869         https://bugs.webkit.org/show_bug.cgi?id=142907
1870
1871         Reviewed by Carlos Garcia Campos.
1872
1873         * TestWebKitAPI/PlatformEfl.cmake:
1874         * TestWebKitAPI/PlatformGTK.cmake:
1875         * WebKitTestRunner/PlatformEfl.cmake:
1876         * WebKitTestRunner/PlatformGTK.cmake:
1877
1878 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1879
1880         [Mac] Unreviewed test fix after r182584
1881         https://bugs.webkit.org/show_bug.cgi?id=143452
1882
1883         Put both of these tests back to their original state now that the underlying
1884         problem is fixed.
1885
1886         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1887         (TestWebKitAPI::TEST):
1888         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1889         (TestWebKitAPI::TEST):
1890
1891 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
1892
1893         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
1894         https://bugs.webkit.org/show_bug.cgi?id=143553
1895
1896         Reviewed by Ryosuke Niwa.
1897         
1898         Remove the spurious printVMs left over from an earlier change.
1899
1900         * Scripts/run-jsc-benchmarks:
1901
1902 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1903
1904         [Mac] Unreviewed test fix after r182581
1905
1906         The behavior of control-left-click is controlled by a system preference.
1907         Our test bots have this turned off.
1908
1909         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1910         (TestWebKitAPI::TEST):
1911         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1912         (TestWebKitAPI::TEST):
1913
1914 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1915
1916         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
1917         https://bugs.webkit.org/show_bug.cgi?id=143452
1918         <rdar://problem/20437483>
1919
1920         Reviewed by Tim Horton.
1921
1922         Add a new API test to confirm that Cocoa mouse button press events are properly
1923         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
1924
1925         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
1926         some registered event handlers that the expected button press and context menu
1927         events are received.
1928
1929         The WK1 unit test creates an NSEvent with the desired button press state, and then
1930         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
1931         We check the resulting PlatformMouseEvent for proper state.
1932
1933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
1934         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
1935         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1936         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
1937         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
1938         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
1939         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1940         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1941         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
1942         mouse down events.
1943         * TestWebKitAPI/mac/PlatformWebViewMac.h:
1944
1945 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1946
1947         [GTK] Add pango to jhbuild-optional.modules
1948         https://bugs.webkit.org/show_bug.cgi?id=143537
1949
1950         Reviewed by Martin Robinson.
1951
1952         * gtk/jhbuild-optional.modules: Add pango.
1953
1954 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1955
1956         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
1957         https://bugs.webkit.org/show_bug.cgi?id=143530
1958
1959         Reviewed by Žan Doberšek.
1960
1961         Assume that the default value for display (:0) is reserved and start checking on :1
1962         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
1963         and for X server named Xorg.bin (previous bug 1376599)
1964
1965         * Scripts/webkitpy/port/xvfbdriver.py:
1966         (XvfbDriver._next_free_display)
1967         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1968         (XvfbDriverTest.test_start_no_pixel_tests):
1969         (XvfbDriverTest.test_start_pixel_tests):
1970         (XvfbDriverTest.test_start_arbitrary_worker_number):
1971         (XvfbDriverTest.test_next_free_display):
1972         (XvfbDriverTest.test_start_next_worker):
1973 2015-04-08  Alex Christensen  <achristensen@webkit.org>
1974
1975         Block popups from content extensions.
1976         https://bugs.webkit.org/show_bug.cgi?id=143497
1977
1978         Reviewed by Brady Eidson.
1979
1980         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1981         (TestWebKitAPI::TEST_F):
1982         Added popup test.
1983
1984 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
1985
1986         Add CMake build system for WinCairo port.
1987         https://bugs.webkit.org/show_bug.cgi?id=115944
1988
1989         Reviewed by Chris Dumez.
1990
1991         * CMakeLists.txt:
1992         * WinLauncher/CMakeLists.txt: Added.
1993
1994 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1995
1996         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
1997         https://bugs.webkit.org/show_bug.cgi?id=143521
1998
1999         Reviewed by Martin Robinson.
2000
2001         Add a way to detect unexpected web process crashes to WebViewTest,
2002         and a test case to testDOMCache to trigger the crash.
2003
2004         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2005         (WebKitDOMNodeTest::testDOMCache):
2006         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2007         (testWebKitWebViewProcessCrashed):
2008         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2009         (WebViewTest::WebViewTest):
2010         (WebViewTest::webProcessCrashed):
2011         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2012
2013 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
2014
2015         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
2016         rdar://problem/20461342
2017
2018         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2019
2020 2015-04-07  Commit Queue  <commit-queue@webkit.org>
2021
2022         Unreviewed, rolling out r182511.
2023         https://bugs.webkit.org/show_bug.cgi?id=143507
2024
2025         caused debug test failures (Requested by alexchristensen on
2026         #webkit).
2027
2028         Reverted changeset:
2029
2030         "Block popups from content extensions."
2031         https://bugs.webkit.org/show_bug.cgi?id=143497
2032         http://trac.webkit.org/changeset/182511
2033
2034 2015-04-07  Alex Christensen  <achristensen@webkit.org>
2035
2036         Block popups from content extensions.
2037         https://bugs.webkit.org/show_bug.cgi?id=143497
2038
2039         Reviewed by Brady Eidson.
2040
2041         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2042         (TestWebKitAPI::TEST_F):
2043         Added popup test.
2044
2045 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
2046
2047         Get the features.json files ready for open contributions
2048         https://bugs.webkit.org/show_bug.cgi?id=143436
2049
2050         Reviewed by Darin Adler.
2051
2052         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2053         (JSONFeaturesChecker.check):
2054         Extend the syntax checking a bit, but leave everything non-mandatory
2055         very loose until we figure what fields are important.
2056
2057 2015-04-07  Tim Horton  <timothy_horton@apple.com>
2058
2059         Expose and test fixedLayoutSize via modern WebKit SPI
2060         https://bugs.webkit.org/show_bug.cgi?id=143500
2061
2062         Reviewed by Simon Fraser.
2063
2064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2065         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
2066         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
2067         (TEST):
2068         Add a test that verifies that fixedLayoutSize works at all, that
2069         it persists through a navigation, and that turning it back off reverts to
2070         laying out at the size of the view.
2071
2072 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2073
2074         Unreviewed. Add myself as a committer.
2075
2076         * Scripts/webkitpy/common/config/contributors.json:
2077
2078 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
2079
2080         [Win] Bots complain about missing /etc/catalog
2081         https://bugs.webkit.org/show_bug.cgi?id=143484
2082
2083         Reviewed by Chris Dumez.
2084
2085         The libxml2 build on Mac, iOS, and Windows does not provide the set
2086         of default catalog files. We do not actually need these for our
2087         purposes, but we get warnings and some bot flakiness because they
2088         are not present.
2089
2090         We can avoid both problems the same way the Mac and iOS ports do,
2091         by setting the XML_CATALOG_FILES environment variable to 'empty string',
2092         which avoid the warnings and bot problems.
2093
2094         * Scripts/webkitpy/port/win.py:
2095         (WinPort.setup_environ_for_server): Added.
2096
2097 2015-04-06  Sam Weinig  <sam@webkit.org>
2098
2099         Use content extensions in MiniBrowser.
2100         https://bugs.webkit.org/show_bug.cgi?id=143446
2101
2102         Reviewed by Alex Christensen.
2103
2104         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2105         * MiniBrowser/mac/AppDelegate.h:
2106         * MiniBrowser/mac/AppDelegate.m:
2107         (-[BrowserAppDelegate init]):
2108         (-[BrowserAppDelegate showExtensionsManager:]):
2109         (-[BrowserAppDelegate userContentContoller]):
2110         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2111         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2112         (-[ExtensionManagerWindowController init]):
2113         (-[ExtensionManagerWindowController windowDidLoad]):
2114         (-[ExtensionManagerWindowController add:]):
2115         (-[ExtensionManagerWindowController remove:]):
2116         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2117         * MiniBrowser/mac/MainMenu.xib:
2118
2119 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2120
2121         web-platform-tests server should retrieve the modules file relatively to its docroot path
2122         https://bugs.webkit.org/show_bug.cgi?id=142742
2123
2124         Reviewed by Darin Adler.
2125
2126         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2127         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
2128
2129 2015-04-06  Commit Queue  <commit-queue@webkit.org>
2130
2131         Unreviewed, rolling out r182445.
2132         https://bugs.webkit.org/show_bug.cgi?id=143459
2133
2134         broke 32 bit build (Requested by alexchristensen on #webkit).
2135
2136         Reverted changeset:
2137
2138         "Use content extensions in MiniBrowser."
2139         https://bugs.webkit.org/show_bug.cgi?id=143446
2140         http://trac.webkit.org/changeset/182445
2141
2142 2015-04-06  Sam Weinig  <sam@webkit.org>
2143
2144         Use content extensions in MiniBrowser.
2145         https://bugs.webkit.org/show_bug.cgi?id=143446
2146
2147         Reviewed by Alex Christensen.
2148
2149         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2150         * MiniBrowser/mac/AppDelegate.h:
2151         * MiniBrowser/mac/AppDelegate.m:
2152         (-[BrowserAppDelegate init]):
2153         (-[BrowserAppDelegate showExtensionsManager:]):
2154         (-[BrowserAppDelegate userContentContoller]):
2155         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2156         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2157         (-[ExtensionManagerWindowController init]):
2158         (-[ExtensionManagerWindowController windowDidLoad]):
2159         (-[ExtensionManagerWindowController add:]):
2160         (-[ExtensionManagerWindowController remove:]):
2161         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2162         * MiniBrowser/mac/MainMenu.xib:
2163
2164 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
2165
2166         [GTK] install-dependencies should prefer dnf to yum
2167         https://bugs.webkit.org/show_bug.cgi?id=143441
2168
2169         Reviewed by Martin Robinson.
2170
2171         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
2172
2173         * gtk/install-dependencies:
2174
2175 2015-04-06  Andy Estes  <aestes@apple.com>
2176
2177         [iOS] 'make clean' fails in Tools/WebKitTestRunner
2178         https://bugs.webkit.org/show_bug.cgi?id=143455
2179
2180         Reviewed by Dan Bernstein.
2181
2182         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
2183         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
2184
2185         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
2186
2187 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
2188
2189         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
2190         https://bugs.webkit.org/show_bug.cgi?id=143450
2191
2192         Reviewed by Anders Carlsson.
2193
2194         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
2195         Make sure that the view is actually closed, regardless of anything else that happens beneath.
2196         Also, removed unnecessary get() calls.
2197
2198 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
2199
2200         Reduce the dependency on Flash in regression tests
2201         https://bugs.webkit.org/show_bug.cgi?id=143391
2202
2203         Reviewed by Anders Carlsson.
2204
2205         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
2206         Only allow QuickTime and the test plug-in.
2207
2208 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2209
2210         W3C test importer should generate the modules installed dynamically to run wpt tests
2211         https://bugs.webkit.org/show_bug.cgi?id=142738
2212
2213         Reviewed by Ryosuke Niwa.
2214
2215         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
2216         The implementation is done within TestDownloader and it is activated for the WPT repository.
2217         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
2218
2219         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2220         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
2221         * Scripts/webkitpy/w3c/test_downloader.py:
2222         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
2223         (TestDownloader):
2224         (TestDownloader._git_submodules_description): Computes submodule description.
2225         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
2226         * Scripts/webkitpy/w3c/test_importer.py:
2227         (TestImporter.do_import): Added the possibility to post process the tests.
2228         (TestImporter):
2229         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
2230         (TestImporter.should_convert_test_harness_links): Updated according new options format.
2231         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2232         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
2233         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
2234         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
2235         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
2236         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
2237
2238 2015-04-05  Antti Koivisto  <antti@apple.com>
2239
2240         Bloom filter should support longer hashes
2241         https://bugs.webkit.org/show_bug.cgi?id=143419
2242
2243         Reviewed by Dan Bernstein.
2244
2245         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
2246         (TestWebKitAPI::generateRandomDigests):
2247         (TestWebKitAPI::TEST):
2248
2249 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2250
2251         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
2252         https://bugs.webkit.org/show_bug.cgi?id=143372
2253
2254         Reviewed by Darin Adler.
2255
2256         * Scripts/run-jsc-stress-tests:
2257
2258 2015-04-03  Antti Koivisto  <antti@apple.com>
2259
2260         Add non-counting bloom filter class
2261         https://bugs.webkit.org/show_bug.cgi?id=143366
2262
2263         Reviewed by Sam Weinig.
2264
2265         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2266         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
2267         (TestWebKitAPI::generateRandomHashes):
2268         (TestWebKitAPI::TEST):
2269
2270 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2271
2272         FTL JIT tests should fail if LLVM library isn't available
2273         https://bugs.webkit.org/show_bug.cgi?id=143374
2274
2275         Reviewed by Mark Lam.
2276
2277         * Scripts/run-jsc-stress-tests:
2278
2279 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2280
2281         [EFL] Speedup jhbuild with disable running autogen.sh
2282         https://bugs.webkit.org/show_bug.cgi?id=143369
2283
2284         Reviewed by Gyuyoung Kim.
2285
2286         * efl/jhbuild.modules:
2287
2288 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
2289
2290         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
2291         https://bugs.webkit.org/show_bug.cgi?id=143282
2292
2293         Reviewed by Daniel Bates.
2294
2295         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
2296
2297 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
2298
2299         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
2300         https://bugs.webkit.org/show_bug.cgi?id=143240
2301         rdar://problem/19990425
2302
2303         Reviewed by Tim Horton.
2304
2305         * DumpRenderTree/mac/LayoutTestHelper.m:
2306         (colorProfileURLForDisplay):
2307         (saveDisplayColorProfiles):
2308         Gracefully handle it when the current profile cannot be retrieved, fixing at
2309         least one case when LayoutTestHelper couldn't start.
2310
2311         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2312         (Manager._set_up_run):
2313         (Manager._force_pixel_tests_if_needed):
2314         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
2315         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
2316         Return and check an error from start_helper().
2317
2318 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
2319
2320         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
2321         https://bugs.webkit.org/show_bug.cgi?id=143321
2322
2323         Reviewed by Alexey Proskuryakov.
2324
2325         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
2326
2327 2015-04-01  Enrica Casucci  <enrica@apple.com>
2328
2329         Injected bundle messages should be at the page level.
2330         https://bugs.webkit.org/show_bug.cgi?id=143283
2331
2332         Reviewed by Alexey Proskuryakov.
2333
2334         Updating WebKitTestRunner to use the new page level messaging.
2335         The author of this patch is Tim Horton, I just finished it.
2336
2337         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2338         (WTR::EventSendingController::mouseDown):
2339         (WTR::EventSendingController::mouseUp):
2340         (WTR::EventSendingController::mouseMoveTo):
2341         (WTR::EventSendingController::leapForward):
2342         (WTR::EventSendingController::scheduleAsynchronousClick):
2343         (WTR::EventSendingController::keyDown):
2344         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2345         (WTR::EventSendingController::mouseScrollBy):
2346         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2347         (WTR::EventSendingController::continuousMouseScrollBy):
2348         (WTR::EventSendingController::addTouchPoint):
2349         (WTR::EventSendingController::updateTouchPoint):
2350         (WTR::EventSendingController::setTouchModifier):
2351         (WTR::EventSendingController::setTouchPointRadius):
2352         (WTR::EventSendingController::touchStart):
2353         (WTR::EventSendingController::touchMove):
2354         (WTR::EventSendingController::touchEnd):
2355         (WTR::EventSendingController::touchCancel):
2356         (WTR::EventSendingController::clearTouchPoints):
2357         (WTR::EventSendingController::releaseTouchPoint):
2358         (WTR::EventSendingController::cancelTouchPoint):
2359         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2360         (WTR::InjectedBundle::didReceiveMessage):
2361         (WTR::InjectedBundle::didReceiveMessageToPage):
2362         (WTR::InjectedBundle::done):
2363         (WTR::InjectedBundle::outputText):
2364         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2365         (WTR::InjectedBundle::postAddChromeInputField):
2366         (WTR::InjectedBundle::postRemoveChromeInputField):
2367         (WTR::InjectedBundle::postFocusWebView):
2368         (WTR::InjectedBundle::postSetBackingScaleFactor):
2369         (WTR::InjectedBundle::postSetWindowIsKey):
2370         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2371         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2372         (WTR::InjectedBundle::setGeolocationPermission):
2373         (WTR::InjectedBundle::setMockGeolocationPosition):
2374         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2375         (WTR::InjectedBundle::setUserMediaPermission):
2376         (WTR::InjectedBundle::setCustomPolicyDelegate):
2377         (WTR::InjectedBundle::setHidden):
2378         (WTR::InjectedBundle::setCacheModel):
2379         (WTR::InjectedBundle::shouldProcessWorkQueue):
2380         (WTR::InjectedBundle::processWorkQueue):
2381         (WTR::InjectedBundle::queueBackNavigation):
2382         (WTR::InjectedBundle::queueForwardNavigation):
2383         (WTR::InjectedBundle::queueLoad):
2384         (WTR::InjectedBundle::queueLoadHTMLString):
2385         (WTR::InjectedBundle::queueReload):
2386         (WTR::InjectedBundle::queueLoadingScript):
2387         (WTR::InjectedBundle::queueNonLoadingScript):
2388         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2389         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2390         (WTR::TestRunner::setAuthenticationUsername):
2391         (WTR::TestRunner::setAuthenticationPassword):
2392         (WTR::TestRunner::secureEventInputIsEnabled):
2393         (WTR::TestRunner::setBlockAllPlugins):
2394         * WebKitTestRunner/TestController.cpp:
2395         (WTR::TestController::createWebViewWithOptions):
2396         (WTR::TestController::resetStateToConsistentValues):
2397         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
2398         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
2399         * WebKitTestRunner/TestController.h:
2400         * WebKitTestRunner/TestInvocation.cpp:
2401         (WTR::TestInvocation::invoke):
2402         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2403
2404 2015-04-01  Commit Queue  <commit-queue@webkit.org>
2405
2406         Unreviewed, rolling out r182174 and r182177.
2407         https://bugs.webkit.org/show_bug.cgi?id=143314
2408
2409         Try to correct EWS failures (Requested by bfulgham on
2410         #webkit).
2411
2412         Reverted changesets:
2413
2414         "Python SCM should be able to retrieve untracked files"
2415         https://bugs.webkit.org/show_bug.cgi?id=143135
2416         http://trac.webkit.org/changeset/182174
2417
2418         "[buildbot] clean-build script should remove untracked files
2419         and revert local changes too"
2420         https://bugs.webkit.org/show_bug.cgi?id=142400
2421         http://trac.webkit.org/changeset/182177
2422
2423 2015-04-01  Alex Christensen  <achristensen@webkit.org>
2424
2425         [Content Extensions] Properly handle regexes that match everything.
2426         https://bugs.webkit.org/show_bug.cgi?id=143281
2427
2428         Reviewed by Benjamin Poulain.
2429
2430         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2431         (TestWebKitAPI::testRequest):
2432         (TestWebKitAPI::makeBackend):
2433         (TestWebKitAPI::TEST_F):
2434         Removed duplicate code and added test.
2435
2436 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
2437
2438         Content Extensions: split the state machines to minimize prefix states
2439         https://bugs.webkit.org/show_bug.cgi?id=143253
2440
2441         Reviewed by Alex Christensen.
2442
2443         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2444         (TestWebKitAPI::TEST_F):
2445         (TestWebKitAPI::testPatternStatus):
2446
2447 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
2448
2449         Clean up Identifier factories to clarify the meaning of StringImpl*
2450         https://bugs.webkit.org/show_bug.cgi?id=143146
2451
2452         Reviewed by Filip Pizlo.
2453
2454         Simple API tests for StringImpl are added.
2455
2456         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2457         (TestWebKitAPI::TEST):
2458
2459 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
2460
2461         [EFL] Add AArch64 builder and tester bot to build.webkit.org
2462         https://bugs.webkit.org/show_bug.cgi?id=143092
2463
2464         Reviewed by Gyuyoung Kim.
2465
2466         * BuildSlaveSupport/build.webkit.org-config/config.json:
2467         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2468         (Factory.__init__):
2469         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2470
2471 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2472
2473         [buildbot] clean-build script should remove untracked files and revert local changes too
2474         https://bugs.webkit.org/show_bug.cgi?id=142400
2475
2476         Reviewed by Ryosuke Niwa.
2477
2478         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
2479         A helper routine SCM.discard_untracked_files is added for that purpose.
2480
2481         * BuildSlaveSupport/clean-build:
2482         (main): Making call to Scripts/clean-webkit
2483         * Scripts/clean-webkit: Added.
2484         (main): Revert changes and delete untracked files.
2485         * Scripts/webkitpy/common/checkout/scm/scm.py:
2486         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
2487         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2488         (SCMTest._shared_test_discard_untracked_files):
2489         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
2490
2491 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2492
2493         Python SCM should be able to retrieve untracked files
2494         https://bugs.webkit.org/show_bug.cgi?id=143135
2495
2496         Reviewed by Ryosuke Niwa.
2497
2498         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
2499         Ignored files may be included or not in this list according boolean passed to the function.
2500
2501         * Scripts/webkitpy/common/checkout/scm/git.py:
2502         (Git.untracked_files):
2503         * Scripts/webkitpy/common/checkout/scm/scm.py:
2504         (SCM.untracked_files):
2505         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2506         (SCMTest._shared_test_untracked_files):
2507         (test_untracked_files):
2508         (GitSVNTest.test_untracked_files):
2509         * Scripts/webkitpy/common/checkout/scm/svn.py:
2510         (SVN.untracked_files):
2511
2512 2015-03-30  Alex Christensen  <achristensen@webkit.org>
2513
2514         [Content Extensions] Correctly handle regular expressions matching everything
2515         https://bugs.webkit.org/show_bug.cgi?id=143235
2516
2517         Reviewed by Benjamin Poulain.
2518
2519         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2520         (TestWebKitAPI::checkCompilerError):
2521         (TestWebKitAPI::TEST_F):
2522         Test ContentExtensionErrors.
2523
2524 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
2525
2526         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
2527         https://bugs.webkit.org/show_bug.cgi?id=143241
2528         rdar://problem/20351297
2529
2530         Reviewed by Mark Lam.
2531
2532         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2533
2534 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2535
2536         [CMake][EFL] Remove redundant library link and include path
2537         https://bugs.webkit.org/show_bug.cgi?id=143221
2538
2539         Reviewed by Csaba Osztrogonác.
2540
2541         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
2542
2543 2015-03-30  Sam Weinig  <sam@webkit.org>
2544
2545         [Content Extensions] Flesh out the UserContentExtensionStore
2546         https://bugs.webkit.org/show_bug.cgi?id=143123
2547
2548         Reviewed by Benjamin Poulain.
2549
2550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2551         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
2552         Add tests for _WKUserContentExtensionStore.
2553
2554 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2555
2556         Update install-dependencies Fedora packages after r181624
2557         https://bugs.webkit.org/show_bug.cgi?id=143215
2558
2559         Add json-glib, libv4l, openssl and pulseaudio development packages to
2560         the Fedora list providing we need them to build WebKit dependencies
2561         for this distribution.
2562
2563         Reviewed by Philippe Normand.
2564
2565         * gtk/install-dependencies:
2566
2567 2015-03-30  Commit Queue  <commit-queue@webkit.org>
2568
2569         Unreviewed, rolling out r182119.
2570         https://bugs.webkit.org/show_bug.cgi?id=143196
2571
2572         problem with syntax (Requested by youenn on #webkit).
2573
2574         Reverted changeset:
2575
2576         "[buildbot] clean-build script should remove untracked files
2577         and revert local changes too"
2578         https://bugs.webkit.org/show_bug.cgi?id=142400
2579         http://trac.webkit.org/changeset/182119
2580
2581 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
2582
2583         Start the features.json files
2584         https://bugs.webkit.org/show_bug.cgi?id=143207
2585
2586         Reviewed by Darin Adler.
2587
2588         I kept the style checking light. We'll have to figure
2589         what is the best format for each field.
2590
2591         * Scripts/webkitpy/style/checker.py:
2592         (CheckerDispatcher._create_checker):
2593         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2594         (JSONContributorsChecker.check):
2595         (JSONFeaturesChecker):
2596         (JSONFeaturesChecker.check):
2597
2598 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2599
2600         [buildbot] clean-build script should remove untracked files and revert local changes too
2601         https://bugs.webkit.org/show_bug.cgi?id=142400
2602
2603         Reviewed by Ryosuke Niwa.
2604
2605         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
2606
2607         * BuildSlaveSupport/clean-build:
2608         (main): Adding call to Tools/Scripts/clean-webkit.
2609         * Scripts/clean-webkit: Added.
2610         (main): Removes untracked and changed files.
2611         * Scripts/webkitpy/common/checkout/scm/git.py:
2612         (Git.untracked_files): Retrieves GIT untracked files.
2613         * Scripts/webkitpy/common/checkout/scm/scm.py:
2614         (SCM.untracked_files): Retrieves SVN untracked files.
2615         (SCM):
2616         (SCM.discard_untracked_files): Deletes untracked files/folders.
2617         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2618         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
2619         (test_untracked_files):
2620         (GitSVNTest.test_untracked_files):
2621         * Scripts/webkitpy/common/checkout/scm/svn.py:
2622         (SVN.untracked_files):
2623
2624 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2625
2626         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
2627         https://bugs.webkit.org/show_bug.cgi?id=143138
2628
2629         Reviewed by Csaba Osztrogonác.
2630
2631         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
2632         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
2633
2634         * ImageDiff/CMakeLists.txt:
2635         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
2636         * WebKitTestRunner/CMakeLists.txt: ditto.
2637
2638 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
2639
2640         Support building WTF on Windows without Cygwin
2641         https://bugs.webkit.org/show_bug.cgi?id=143084
2642
2643         Reviewed by Brent Fulgham.
2644
2645         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
2646         This patch also migrates to using File::Spec->catfile() for directory separators.
2647
2648         * Scripts/update-webkit-dependency:
2649         (wanted):
2650         * Scripts/update-webkit-support-libs:
2651         (wanted):
2652         (downloadExpectedVersionNumber):
2653         (zipFileVersion):
2654         (toUnixPath): Deleted.
2655         * Scripts/webkitdirs.pm:
2656         (determineSourceDir):
2657         (windowsSourceSourceDir):
2658         (windowsLibrariesDir):
2659         (windowsOutputDir):
2660         (checkInstalledTools):
2661         (buildVisualStudioProject):
2662
2663 2015-03-27  Alex Christensen  <achristensen@webkit.org>
2664
2665         Fix WinCairo bot.
2666         https://bugs.webkit.org/show_bug.cgi?id=143086
2667
2668         Reviewed by Brent Fulgham.
2669
2670         * Scripts/webkitdirs.pm:
2671         (buildVisualStudioProject):
2672         (runSvnUpdateAndResolveChangeLogs):
2673         Use ActivePerl-friendly perl.
2674
2675 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2676
2677         URTBF after r182059 to fix the EFL build.
2678
2679         * TestWebKitAPI/CMakeLists.txt:
2680
2681 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
2682
2683         Layout test results URL loads in WK1 but not WK2 minibrowser
2684         https://bugs.webkit.org/show_bug.cgi?id=143117
2685
2686         Reviewed by Tim Horton.
2687
2688         * MiniBrowser/mac/WK2BrowserWindowController.m:
2689         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
2690         everything.
2691         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
2692
2693 2015-03-26  Jer Noble  <jer.noble@apple.com>
2694
2695         Add --allowed-host support to run-webkit-tests
2696         https://bugs.webkit.org/show_bug.cgi?id=142938
2697
2698         Reviewed by Brent Fulgham.
2699
2700         Accept --allowed-host arguments from run-webkit-tests and pass them through to
2701         DumpRenderTree and WebKitTestRunner.
2702
2703         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
2704         are placed in the wrong location. The argument is compared with each tests's path, and if a
2705         relative path or a path with '..' was used, results are placed alongside the test. Take the
2706         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
2707
2708         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2709         (parse_args):
2710         * Scripts/webkitpy/port/base.py:
2711         (Port.__init__):
2712         (Port.allowed_hosts):
2713         * Scripts/webkitpy/port/driver.py:
2714         (Driver.cmd_line):
2715
2716 2015-03-26  Jer Noble  <jer.noble@apple.com>
2717
2718         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
2719         https://bugs.webkit.org/show_bug.cgi?id=142931
2720
2721         Reviewed by Brent Fulgham.
2722
2723         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
2724         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
2725         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
2726         runtime.
2727
2728         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
2729         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
2730
2731         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
2732         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
2733         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
2734         the top loading frame from the page, as we do elsewhere in this class.
2735
2736         * DumpRenderTree/TestRunner.h:
2737         (TestRunner::allowedHosts):
2738         (TestRunner::setAllowedHosts):
2739         * DumpRenderTree/mac/DumpRenderTree.mm:
2740         (initializeGlobalsFromCommandLineOptions):
2741         (runTest):
2742         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2743         (isAllowedHost):
2744         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2745         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2746         (WTR::InjectedBundle::didReceiveMessage):
2747         (WTR::InjectedBundle::isAllowedHost):
2748         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2749         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2750         (WTR::isAllowedHost):
2751         (WTR::InjectedBundlePage::willSendRequestForFrame):
2752         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2753         * WebKitTestRunner/Options.cpp:
2754         (WTR::handleOptionAllowedHost):
2755         (WTR::OptionsHandler::OptionsHandler):
2756         * WebKitTestRunner/Options.h:
2757         * WebKitTestRunner/TestController.cpp:
2758         (WTR::TestController::initialize):
2759         (WTR::TestController::resetStateToConsistentValues):
2760         * WebKitTestRunner/TestController.h:
2761
2762 2015-03-26  Brady Eidson  <beidson@apple.com>
2763
2764         Apply ContentExtension actions after redirects.
2765         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
2766
2767         Reviewed by Alex Christensen.
2768
2769         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2770         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
2771           which is specifically interesting to a new test.
2772
2773 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2774
2775         [EFL] Disable building libseccomp on AArch64
2776         https://bugs.webkit.org/show_bug.cgi?id=143094
2777
2778         Reviewed by Gyuyoung Kim.
2779
2780         * efl/jhbuildrc:
2781
2782 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2783
2784         [jhbuild] git should use only 1 thread for cloning jhbuild
2785         https://bugs.webkit.org/show_bug.cgi?id=143095
2786
2787         Reviewed by Gyuyoung Kim.
2788
2789         * jhbuild/jhbuild-wrapper:
2790         (clone_jhbuild):
2791
2792 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
2793
2794         Update prepare-ChangeLog to work with ES6 Class syntax
2795         https://bugs.webkit.org/show_bug.cgi?id=143069
2796
2797         Reviewed by Timothy Hatcher.
2798
2799         * Scripts/prepare-ChangeLog:
2800         (get_function_line_ranges_for_javascript):
2801         Better handle ES6 Class syntax.
2802
2803         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2804         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2805         (BaseClass):
2806         (DerivedClass):
2807         (DerivedClass.staticMethod):
2808         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
2809         (DerivedClass.prototype.method):
2810         (DerivedClass.prototype.get getter):
2811         (namespace.MyClass):
2812         (namespace.MyClass.staticMethod):
2813         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
2814         (namespace.MyClass.prototype.method):
2815         (namespace.MyClass.prototype.get getter):
2816         Proof!
2817
2818 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
2819
2820         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
2821         https://bugs.webkit.org/show_bug.cgi?id=142993
2822
2823         Reviewed by Mark Lam.
2824         
2825         Bunch of support for testing executable allocation failure.
2826
2827         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
2828         (fail):
2829         * Scripts/run-javascriptcore-tests:
2830         (runJSCStressTests):
2831         * Scripts/run-jsc-stress-tests:
2832
2833 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
2834
2835         Fix Windows build from r181977.
2836
2837         Unreviewed.
2838
2839         * Scripts/update-webkit-dependency:
2840
2841 2015-03-25  Sam Weinig  <sam@webkit.org>
2842
2843         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
2844
2845         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2846         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2847
2848 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
2849
2850         Migrate update-webkit for Windows to not require Cygwin
2851         https://bugs.webkit.org/show_bug.cgi?id=143040
2852
2853         Reviewed by Brent Fulgham.
2854
2855         * Scripts/update-webkit-dependency:
2856         (wanted):
2857         (toUnixPath): Deleted.
2858         * Scripts/webkitdirs.pm:
2859         (fontExists):
2860         (checkInstalledTools):
2861         (setupAppleWinEnv):
2862
2863 2015-03-25  Sam Weinig  <sam@webkit.org>
2864
2865         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
2866         https://bugs.webkit.org/show_bug.cgi?id=143059
2867
2868         Reviewed by Alex Christensen.
2869
2870         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2871         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2872         Update for new interface of compileRuleList().
2873
2874 2015-03-25  Alex Christensen  <achristensen@webkit.org>
2875
2876         [Content Extensions] Add multi-DFA compiling and interpreting.
2877         https://bugs.webkit.org/show_bug.cgi?id=143010
2878
2879         Reviewed by Benjamin Poulain.
2880
2881         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2882         (TestWebKitAPI::testRequest):
2883         (TestWebKitAPI::TEST_F):
2884         Add some tests for ignore-previous-rules and large rulesets.
2885
2886 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
2887
2888         Mavericks WK1 still runs JSC tests
2889         https://bugs.webkit.org/show_bug.cgi?id=143035
2890
2891         Reviewed by Csaba Osztrogonác.
2892
2893         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
2894         with other bots.
2895
2896         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
2897         accordingly.
2898
2899 2015-03-25  Commit Queue  <commit-queue@webkit.org>
2900
2901         Unreviewed, rolling out r181932.
2902         https://bugs.webkit.org/show_bug.cgi?id=143041
2903
2904         The test fails most of the time on bots (Requested by ap on
2905         #webkit).
2906
2907         Reverted changeset:
2908
2909         "[Content Extensions] Add multi-DFA compiling and
2910         interpreting."
2911         https://bugs.webkit.org/show_bug.cgi?id=143010
2912         http://trac.webkit.org/changeset/181932
2913
2914 2015-03-24  Alex Christensen  <achristensen@webkit.org>
2915
2916         [Content Extensions] Add multi-DFA compiling and interpreting.
2917         https://bugs.webkit.org/show_bug.cgi?id=143010
2918
2919         Reviewed by Benjamin Poulain.
2920
2921         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2922         (TestWebKitAPI::testRequest):
2923         (TestWebKitAPI::TEST_F):
2924         Add some tests for ignore-previous-rules and large rulesets.
2925
2926 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
2927
2928         Make URL filter patterns matching consistent and add a simple canonicalization step
2929         https://bugs.webkit.org/show_bug.cgi?id=142998
2930
2931         Reviewed by Alex Christensen.
2932
2933         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2934
2935 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
2936
2937         [EFL] Add OpenWebRTC in jhbuild
2938         https://bugs.webkit.org/show_bug.cgi?id=142778
2939
2940         Reviewed by Gyuyoung Kim.
2941
2942         Original patch by Philippe Normand <pnormand@igalia.com>
2943
2944         * efl/install-dependencies: Dependencies for OpenWebRTC.
2945         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
2946         the openwebrtc gst plugins.
2947
2948 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
2949
2950         Regression(r181257): WTF_WorkQueue.Simple is flaky
2951         https://bugs.webkit.org/show_bug.cgi?id=142560
2952
2953         Remove the check that the refCount has returned to one after the
2954         individual tasks have completed. It's too nondeterministic when
2955         the reference count will be reduced.
2956
2957         Reviewed by Alexey Proskuryakov
2958
2959         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2960         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
2961
2962 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2963
2964         [CMake][EFL] Put failure API test excutables into failure directory
2965         https://bugs.webkit.org/show_bug.cgi?id=142965
2966
2967         Reviewed by Csaba Osztrogonác.
2968
2969         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
2970
2971         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
2972         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
2973
2974 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
2975
2976         CSS Selectors: fix attribute case-insensitive matching of Contain and List
2977         https://bugs.webkit.org/show_bug.cgi?id=142932
2978
2979         Reviewed by Darin Adler.
2980
2981         Add tests for the new features and fix some existing tests using the 
2982         stringFromUTF8() utility recently added by Dhi.
2983
2984         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2985         (TestWebKitAPI::stringFromUTF8):
2986         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2987
2988 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2989
2990         [GTK] install-dependencies should install orc
2991         https://bugs.webkit.org/show_bug.cgi?id=142955
2992
2993         Reviewed by Martin Robinson.
2994
2995         Install orc, needed by openwebrtc
2996
2997         * gtk/install-dependencies:
2998
2999 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
3000
3001         Detect when url filter pattern with groups match the empty string
3002         https://bugs.webkit.org/show_bug.cgi?id=142930
3003
3004         Reviewed by Sam Weinig.
3005
3006         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3007
3008 2015-03-22  Anders Carlsson  <andersca@apple.com>
3009
3010         _WKWebsiteDataStore should clear WebSQL databases
3011         https://bugs.webkit.org/show_bug.cgi?id=142947
3012
3013         Reviewed by Sam Weinig.
3014
3015         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
3016
3017         * MiniBrowser/mac/WK2BrowserWindowController.m:
3018         (-[WK2BrowserWindowController fetchWebsiteData:]):
3019         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3020         (-[WK2BrowserWindowController clearWebsiteData:]):
3021
3022 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
3023
3024         GCTimer should know keep track of nested GC phases
3025         https://bugs.webkit.org/show_bug.cgi?id=142675
3026
3027         Reviewed by Darin Adler.
3028
3029         Adds a tool to aid in parsing the GC phase timing output into a
3030         tree-like structure based on the parent-child relationships
3031         of nested GC phases.
3032
3033         * Scripts/parse-gc-phase-timings: Added.
3034         (Timing):
3035         (Timing.__init__):
3036         (Timing.__unicode__):
3037         (Timing.__str__):
3038         (Timing.__repr__):
3039         (parse_input):
3040         (print_timing_node):
3041         (print_timing_tree):
3042         (link_parents):
3043         (main):
3044
3045 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
3046
3047         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
3048
3049         * Scripts/webkitpy/common/config/ews.json:
3050
3051 2015-03-20  Philippe Normand  <pnormand@igalia.com>
3052
3053         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
3054         https://bugs.webkit.org/show_bug.cgi?id=142867
3055
3056         Rubber-stamped by Csaba Osztrogon.
3057
3058         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
3059         a fixed revision for the openwebrtc-gst-plugins.
3060
3061 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3062
3063         Unreviewed build fix. Don't try to report stats for all benchmarks.
3064         Just report the geometric mean of preferred means.
3065
3066         * Scripts/run-jsc-benchmarks:
3067
3068 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3069
3070         run-jsc-benchmarks should only report preferred mean
3071         https://bugs.webkit.org/show_bug.cgi?id=142874
3072
3073         Reviewed by Geoffrey Garen.
3074
3075         Just collect statistics for the preferred mean.
3076
3077         * Scripts/run-jsc-benchmarks:
3078
3079 2015-03-19  Alex Christensen  <achristensen@webkit.org>
3080
3081         [Content Extensions] Test regular expression parse failures.
3082         https://bugs.webkit.org/show_bug.cgi?id=142872
3083
3084         Reviewed by Benjamin Poulain.
3085
3086         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3087         (TestWebKitAPI::testPatternStatus):
3088         (TestWebKitAPI::TEST_F):
3089         Added tests for each parsing status.
3090
3091 2015-03-19  Alex Christensen  <achristensen@webkit.org>
3092
3093         Fix API tests after r181754.
3094
3095         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3096         (TestWebKitAPI::testRequest):
3097
3098 2015-03-19  Brady Eidson  <beidson@apple.com>
3099
3100         Part of content extensions should apply css selectors
3101         https://bugs.webkit.org/show_bug.cgi?id=142604
3102
3103         Reviewed by Alex Christensen.
3104
3105         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3106         (WebCore::ContentExtensions::operator<<):
3107
3108 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
3109
3110         [Win] Activate tests on EWS
3111         https://bugs.webkit.org/show_bug.cgi?id=142850
3112
3113         Reviewed by Alexey Proskuryakov.
3114
3115         * Scripts/webkitpy/common/config/ews.json: Add me as
3116         the EWS bot watcher, and activate tests.
3117
3118 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
3119
3120         [GTK] Fix inspector userinterface related incremental build issue
3121         https://bugs.webkit.org/show_bug.cgi?id=142849
3122
3123         Reviewed by Carlos Garcia Campos.
3124
3125         * Scripts/webkitdirs.pm:
3126         (shouldRemoveCMakeCache):
3127
3128 2015-03-18  Alex Christensen  <achristensen@webkit.org>
3129
3130         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
3131         https://bugs.webkit.org/show_bug.cgi?id=142799
3132
3133         Reviewed by Brady Eidson.
3134
3135         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3136         (TestWebKitAPI::testPattern):
3137         (TestWebKitAPI::TEST_F):
3138         Start testing regex failures.
3139
3140 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
3141
3142         Fix StringView typos after r181525 and r181558
3143         https://bugs.webkit.org/show_bug.cgi?id=142772
3144
3145         Reviewed by Darin Adler.
3146
3147         Add some tests in [1] to cover the StringView::startsWith, 
3148         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
3149         StringView::endsWithIgnoringASCIICase implementations.
3150
3151         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3152         (TestWebKitAPI::TEST):
3153
3154 2015-03-18  Dana Burkart  <dburkart@apple.com>
3155
3156         Remove extraneous import to fix the build.
3157
3158         Unreviewed.
3159
3160         * Scripts/webkitpy/port/driver.py:
3161
3162 2015-03-18  Dana Burkart  <dburkart@apple.com>
3163
3164         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
3165         https://bugs.webkit.org/show_bug.cgi?id=142547
3166
3167         Reviewed by Alexey Proskuryakov.
3168
3169         * Scripts/webkitpy/port/driver.py:
3170         (Driver._setup_environ_for_driver):
3171
3172 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
3173
3174         Tweak how AppleSystemFontOSSubversion default is added
3175         https://bugs.webkit.org/show_bug.cgi?id=142835
3176
3177         Reviewed by Dan Bernstein.
3178
3179         * DumpRenderTree/mac/DumpRenderTree.mm:
3180         (setDefaultsToConsistentValuesForTesting):
3181
3182 2015-03-18  Dan Bernstein  <mitz@apple.com>
3183
3184         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
3185         https://bugs.webkit.org/show_bug.cgi?id=142815
3186
3187         Reviewed by Darin Adler.
3188
3189         * Scripts/prepare-ChangeLog:
3190         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
3191         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
3192         keep consuming the quoted text until the matching quotation mark is reached. Emit the
3193         warning only if a line ends without a backslash before the matching quotation mark was found.
3194
3195 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3196
3197         Remove unused "preprocessor" parameter to sub-CodeGenerators
3198         https://bugs.webkit.org/show_bug.cgi?id=142793
3199
3200         Reviewed by Darin Adler.
3201
3202         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3203         (new):
3204
3205 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
3206
3207         [EFL] Bump gstreamer version to 1.4.4
3208         https://bugs.webkit.org/show_bug.cgi?id=142782
3209
3210         Reviewed by Philippe Normand.
3211
3212         * efl/jhbuild.modules:
3213         * efl/patches/gst-libav.patch:
3214         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
3215         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3216
3217 2015-03-17  Tim Horton  <timothy_horton@apple.com>
3218
3219         Fix the iOS build.
3220
3221         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3222         (WTR::InjectedBundle::platformInitialize):
3223
3224 2015-03-17  Dean Jackson  <dino@apple.com>
3225
3226         check-webkit-style should allow "bool a : 1"
3227         https://bugs.webkit.org/show_bug.cgi?id=142794
3228
3229         Reviewed by Brent Fulgham.
3230
3231         We should allow member bitfields of the form:
3232
3233         bool m_var : 1;
3234
3235         It seems that Visual Studio 8 was the last compiler that
3236         wasn't happy about not using unsigned here. We already have
3237         about 500 cases (in WebCore) where people were ignoring this rule.
3238
3239         * Scripts/webkitpy/style/checkers/cpp.py:
3240         (check_language): Allow "bool".
3241         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
3242         (CppStyleTest.test_enum_bitfields):
3243         (CppStyleTest.test_plain_integral_bitfields):
3244
3245 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
3246
3247         Compile character ranges targeting the same state as range check in the bytecode
3248         https://bugs.webkit.org/show_bug.cgi?id=142759
3249
3250         Reviewed by Alex Christensen.
3251
3252         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3253         (TestWebKitAPI::TEST_F):
3254
3255 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3256
3257         W3C test parser and converter should use test importer host
3258         https://bugs.webkit.org/show_bug.cgi?id=142729
3259
3260         Reviewed by Bem Jones-Bey.
3261
3262         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
3263         This enables adding more TestImporter unit testing.
3264         This patch also ensures that the git object instantiated by TestDownloader is using the
3265         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
3266
3267         * Scripts/webkitpy/common/system/filesystem_mock.py:
3268         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
3269         * Scripts/webkitpy/w3c/test_downloader.py:
3270         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
3271         (TestDownloader.checkout_test_repository): Making use of the new git function.
3272         * Scripts/webkitpy/w3c/test_importer.py:
3273         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
3274         (TestImporter.import_tests): Adding host as parameter to the converter.
3275         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3276         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
3277         (TestImporterTest):
3278         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
3279         * Scripts/webkitpy/w3c/test_parser.py:
3280         (TestParser.__init__): Adding host as parameter constructor.
3281
3282 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3283
3284         [GTK] WebKitDOM objects leaking
3285         https://bugs.webkit.org/show_bug.cgi?id=118788
3286
3287         Reviewed by Darin Adler and Sergio Villar Senin.
3288
3289         Update DOMObjectCache unit test to check that DOM objects are also
3290         released when new contents are loaded in the web view, and the old
3291         document is detached from the frame.
3292
3293         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3294         (testWebKitDOMObjectCache):
3295         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3296         (runTest):
3297
3298 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3299
3300         W3C test importer default import folder should be LayoutTests/imported/w3c
3301         https://bugs.webkit.org/show_bug.cgi?id=142728
3302
3303         Reviewed by Bem Jones-Bey.
3304
3305         * Scripts/webkitpy/w3c/test_importer.py:
3306         (parse_args): Updating the default destination option value to 'imported/w3c'.
3307
3308 2015-03-17  Philippe Normand  <pnormand@igalia.com>
3309
3310         [GTK] basic OpenWebRTC build support
3311         https://bugs.webkit.org/show_bug.cgi?id=142393
3312
3313         Reviewed by Carlos Garcia Campos.
3314
3315         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
3316         is not the upstream OpenWebRTC repository. This temporary fork
3317         contains a few patches needed by WebKit for audio/video rendering.
3318
3319 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3320
3321         [CMake][EFL] Build test tools only for developer mode
3322         https://bugs.webkit.org/show_bug.cgi?id=142761
3323
3324         Reviewed by Csaba Osztrogonác.
3325
3326         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
3327
3328         * CMakeLists.txt:
3329
3330 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
3331
3332         Remove never used "useLayerOnTop" bindings generator argument
3333         https://bugs.webkit.org/show_bug.cgi?id=142773
3334
3335         Reviewed by Darin Adler.
3336
3337         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3338         (new):
3339
3340 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
3341
3342         Enable ES6 classes by default
3343         https://bugs.webkit.org/show_bug.cgi?id=142774
3344
3345         Reviewed by Gavin Barraclough.
3346
3347         * Scripts/webkitperl/FeatureList.pm:
3348
3349 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3350
3351         Fix webkitpy tests after r181585.
3352
3353         Looks like "me" cannot be anyone's email, it's a special case.
3354
3355         * Scripts/webkitpy/common/config/contributors.json:
3356
3357 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3358
3359         Add tolerance to WebAudio tests
3360         https://bugs.webkit.org/show_bug.cgi?id=142676
3361
3362         Reviewed by Tim Horton.
3363
3364         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
3365
3366         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3367         (TestResultWriter.create_audio_diff_and_write_result):
3368         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3369         (FailureAudio.write_failure):
3370         * Scripts/webkitpy/port/base.py:
3371         (Port.do_audio_results_differ):
3372         Diff audio failures.
3373
3374         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
3375         tests to use real parseable WAV data, and got rid of base64, which there didn't
3376         seem to have been any reason for.
3377
3378 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3379
3380         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
3381         https://bugs.webkit.org/show_bug.cgi?id=142720
3382
3383         Reviewed by Myles C. Maxfield.
3384
3385         Activate system copies of Microsoft fonts for the current process, thus overriding
3386         any other ones that could be preferred by the system otherwise.
3387
3388         * DumpRenderTree/mac/DumpRenderTree.mm:
3389         (activateSystemCoreWebFonts):
3390         (adjustFonts):
3391         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3392         (WTR::activateSystemCoreWebFonts):
3393         (WTR::activateFonts):
3394
3395 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3396
3397         Created Streams API watchlist
3398         https://bugs.webkit.org/show_bug.cgi?id=142684
3399
3400         Reviewed by Benjamin Poulain.
3401
3402         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
3403         watchlist and added Benjamin, Youenn and me to it.
3404
3405 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
3406
3407         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
3408         https://bugs.webkit.org/show_bug.cgi?id=142715
3409
3410         Reviewed by Brent Fulgham.
3411
3412         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3413         (TestWebKitAPI::TEST):
3414
3415 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
3416
3417         Change the exact attribute matching to be ASCII case-insensitive
3418         https://bugs.webkit.org/show_bug.cgi?id=142609
3419
3420         Reviewed by Darin Adler.
3421
3422         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3423         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3424
3425 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3426
3427         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
3428         https://bugs.webkit.org/show_bug.cgi?id=134764
3429
3430         Reviewed by Ryosuke Niwa.
3431
3432         TestDownloader is introduced to download W3C tests from the official
3433         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
3434         and https://github.com/w3c/csswg-test.git).
3435         TestDownloader clones the repositories and checkouts revisions of the tests
3436         defined in LayoutTests/imported/w3c/resources/TestRepositories.
3437
3438         Similarly to https://codereview.chromium.org/148173016,
3439         TestDownloader copies part of the files based on the rules
3440         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
3441
3442         TestDownloader is used by TestImporter when no source directory is provided.
3443
3444         * Scripts/webkitpy/w3c/test_downloader.py: Added.
3445         (TestDownloader):
3446         (TestDownloader.default_options):
3447         (TestDownloader.load_test_repositories):
3448         (TestDownloader.__init__):
3449         (TestDownloader.checkout_test_repository):
3450         (TestDownloader._init_paths_from_expectations):
3451         (TestDownloader._add_test_suite_paths):
3452         (TestDownloader._empty_directory):
3453         (TestDownloader.copy_tests):
3454         (TestDownloader.download_tests):
3455         * Scripts/webkitpy/w3c/test_importer.py:
3456         (main):
3457         (parse_args):
3458         (TestImporter.__init__):
3459         (TestImporter.do_import):
3460         (TestImporter.test_downloader):
3461         (TestImporter.find_importable_tests.should_keep_subdir):
3462         (TestImporter.should_convert_test_harness_links):
3463         (TestImporter.import_tests):
3464         (TestImporter.write_import_log):
3465
3466 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
3467
3468         [Mavericks] Test snapshots are 1600x1200 on Retina devices
3469         https://bugs.webkit.org/show_bug.cgi?id=142630
3470
3471         Reviewed by Tim Horton.
3472
3473         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
3474         Removed an ifdef that disabled the fix on Mavericks.
3475
3476 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
3477
3478         Remove isWK2 cruft from webkitdirs.pm after r170426
3479         https://bugs.webkit.org/show_bug.cgi?id=142618
3480
3481         Reviewed by Daniel Bates.
3482
3483         * Scripts/webkitdirs.pm:
3484         (isWK2): Deleted.
3485
3486 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
3487
3488         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
3489         https://bugs.webkit.org/show_bug.cgi?id=138687
3490
3491         Reviewed by Carlos Garcia Campos.
3492
3493         Always change cookie policy from UI process, as changing it from WebProcess doesn't
3494         affect other processes.
3495
3496         The implementation is imperfect, because the change happens asynchronously, but I
3497         don't expect it to be a problem in practice.
3498
3499         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3500         (WTR::InjectedBundle::beginTesting):
3501         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3502         (WTR::TestRunner::setAlwaysAcceptCookies):
3503         * WebKitTestRunner/TestInvocation.cpp:
3504         (WTR::TestInvocation::invoke):
3505         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3506
3507 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
3508
3509         [EFL] Enable building EFL 1.13 with NEON support
3510         https://bugs.webkit.org/show_bug.cgi?id=142619
3511
3512         Reviewed by Gyuyoung Kim.
3513
3514         * efl/jhbuild.modules:
3515
3516 2015-03-11  Alex Christensen  <achristensen@webkit.org>
3517
3518         [Content Extensions] Add resource type and load type triggers.
3519         https://bugs.webkit.org/show_bug.cgi?id=142422
3520
3521         Reviewed by Benjamin Poulain.
3522
3523         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3524         (TestWebKitAPI::testRequest):
3525         (TestWebKitAPI::mainDocumentRequest):
3526         (TestWebKitAPI::TEST_F):
3527         (TestWebKitAPI::testURL): Deleted.
3528
3529 2015-03-10  Sam Weinig  <sam@webkit.org>
3530
3531         Allow adding a button in input elements for auto fill related functionality
3532         <rdar://problem/19782066>
3533         https://bugs.webkit.org/show_bug.cgi?id=142564
3534
3535         Reviewed by Anders Carlsson.
3536
3537         * WebKitTestRunner/TestController.cpp:
3538         (WTR::TestController::createOtherPage):
3539         (WTR::TestController::createWebViewWithOptions):
3540         Update for new callback.
3541
3542 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
3543
3544         Add basic support for BOL and EOL assertions to the URL Filter parser
3545         https://bugs.webkit.org/show_bug.cgi?id=142568
3546
3547         Reviewed by Alex Christensen.
3548
3549         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3550         (TestWebKitAPI::TEST_F):
3551
3552 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3553
3554         [GTK] Add support for handling TLS errors to MiniBrowser
3555         https://bugs.webkit.org/show_bug.cgi?id=142576
3556
3557         Reviewed by Sergio Villar Senin.
3558
3559         It's useful for testing TLS errors handling itself, but also to
3560         allow ignoring TLS errors when testing.
3561
3562         * MiniBrowser/gtk/BrowserWindow.c:
3563         (webViewLoadFailedWithTLSerrors):
3564         (browserWindowConstructed):
3565
3566 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3567
3568         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
3569         https://bugs.webkit.org/show_bug.cgi?id=142569
3570
3571         Reviewed by David Hyatt.
3572
3573         Test Optional::valueOrCompute().
3574
3575         * TestWebKitAPI/Tests/WTF/Optional.cpp:
3576         (TestWebKitAPI::TEST):
3577
3578 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3579
3580         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
3581         https://bugs.webkit.org/show_bug.cgi?id=126688
3582
3583         Reviewed by Gustavo Noronha Silva.
3584
3585         * CMakeLists.txt: Build testing tools only for developer builds,
3586         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
3587         * MiniBrowser/gtk/CMakeLists.txt: Only add
3588         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
3589         and add a rule to install the MiniBrowser.
3590         * MiniBrowser/gtk/main.c:
3591         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
3592         builds.
3593
3594 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
3595
3596         Add some DateMath tests to TestWebKitAPI
3597         https://bugs.webkit.org/show_bug.cgi?id=142565
3598
3599         Reviewed by Alexey Proskuryakov.
3600
3601         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
3602         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
3603         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
3604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
3605         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
3606
3607 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
3608
3609         Regression(r181257): WTF_WorkQueue.Simple is flaky
3610         https://bugs.webkit.org/show_bug.cgi?id=142560
3611
3612         Unreviewed attempt to improve test stability.
3613
3614         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
3615         the WorkQueue a little later to redue flakiness.
3616
3617 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3618
3619         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
3620         https://bugs.webkit.org/show_bug.cgi?id=142555
3621
3622         Reviewed by Simon Fraser.
3623
3624         * DumpRenderTree/mac/DumpRenderTree.mm:
3625         (setDefaultsToConsistentValuesForTesting):
3626         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3627         (WTR::InjectedBundle::platformInitialize):
3628
3629 2015-03-10  Alex Christensen  <achristensen@webkit.org>
3630
3631         Use unsigned for HashSet size.
3632         https://bugs.webkit.org/show_bug.cgi?id=142518
3633
3634         Reviewed by Benjamin Poulain.
3635
3636         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3637         (TestWebKitAPI::TEST):
3638         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3639         (TestWebKitAPI::testInitialCapacity):
3640         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3641         (TestWebKitAPI::TEST):
3642
3643 2015-03-10  Daniel Bates  <dabates@apple.com>
3644
3645         [iOS] Add WebKitSystemInterface for iOS 8.2
3646         https://bugs.webkit.org/show_bug.cgi?id=142505
3647
3648         Rubber-stamped by Anders Carlsson.
3649
3650         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
3651         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
3652         copy-webkitlibraries-to-product-directory in r181286.
3653
3654         * Scripts/copy-webkitlibraries-to-product-directory:
3655
3656 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
3657
3658         Extend URL filter's Term definition to support groups/subpatterns
3659         https://bugs.webkit.org/show_bug.cgi?id=142519
3660
3661         Reviewed by Alex Christensen.
3662
3663         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3664         (TestWebKitAPI::testURL):
3665
3666 2015-03-06  Jer Noble  <jer.noble@apple.com>
3667
3668         Add an option to run-webkit-tests to override the LayoutTests/ directory
3669         https://bugs.webkit.org/show_bug.cgi?id=142418
3670
3671         Reviewed by David Kilzer.
3672
3673         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
3674         directory. The base port will parse the options during initialization and store the override
3675         location if present. layout_tests_dir() will return this overridden location if set.
3676
3677         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3678         (parse_args):
3679         * Scripts/webkitpy/port/base.py:
3680         (Port.__init__):
3681         (Port.layout_tests_dir):
3682
3683 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
3684
3685         [CMake] Enable WorkQueue tests for CMake ports
3686         https://bugs.webkit.org/show_bug.cgi?id=142473
3687
3688         Reviewed by Darin Adler.
3689
3690         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
3691         the list of source files.
3692         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
3693         to the list of include directories for EFL.
3694
3695 2015-03-09  David Kilzer  <ddkilzer@apple.com>
3696
3697         Attempt to fix timeouts on iOS Simulator layout tests
3698
3699         * Scripts/webkitpy/port/ios.py:
3700         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
3701         Simulator end after the first 50 tests time out.  Some analysis
3702         this past weekend shows that the 'Booted' status in the output
3703         of `xcrun simctl list` is not sufficient (and watching the test
3704         run shows that SpringBoard hasn't fully started to the point
3705         where it's displaying icons on the home screen).  The workaround
3706         until we have a better fix is to add an arbitrary timeout to let
3707         SpringBoard finish launching.  In practice, 15 seconds is
3708         probably enough, but 30 seconds should nearly always work.
3709
3710 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
3711
3712         Unreviewed. Add myself as a committer.
3713
3714         * Scripts/webkitpy/common/config/contributors.json:
3715
3716 2015-03-09  David Kilzer  <ddkilzer@apple.com>
3717
3718         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
3719
3720         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3721         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
3722         an expectation that will fail if we hit the race condition.
3723         This test is inherently racy and will deadlock if the first job
3724         for queue2 takes the mutex lock before the second job for
3725         queue1.
3726
3727 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3728
3729         [Win] WTF::WorkQueue does not balance ref/deref properly
3730         https://bugs.webkit.org/show_bug.cgi?id=142471
3731
3732         Reviewed by Antti Koivisto.
3733
3734         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3735         (TestWebKitAPI::TEST): Check that the refcount is correct.
3736
3737 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3738
3739         Do not show passing test result on output of EFL layout test
3740         https://bugs.webkit.org/show_bug.cgi?id=142380
3741
3742         Reviewed by Darin Adler.
3743
3744         To show passing tests has caused inconvenience when we detect problem tests
3745         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
3746         in order not to show passing tests in the output of EFL layout test.
3747
3748         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3749         (RunWebKitTests.start):
3750
3751 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3752
3753         Unreviewed build fix.
3754
3755         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3756         (TestWebKitAPI::TEST): Remove two unused variables.
3757
3758 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3759
3760         Add some WorkQueue tests to TestWebKitAPI
3761         https://bugs.webkit.org/show_bug.cgi?id=142447
3762
3763         Reviewed by Sam Weinig.
3764
3765         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3766         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3768         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
3769         (TestWebKitAPI::simpleTest):
3770         (TestWebKitAPI::longTest):
3771         (TestWebKitAPI::thirdTest):
3772         (TestWebKitAPI::finishedTests):
3773         (TestWebKitAPI::TEST):
3774         (TestWebKitAPI::longTest2):
3775
3776 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3777
3778         Remove willDestroyFrame in WKBundlePageLoaderClient
3779         https://bugs.webkit.org/show_bug.cgi?id=142389
3780
3781         Reviewed by Anders Carlsson.
3782
3783         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3784         (WTR::InjectedBundlePage::InjectedBundlePage):
3785
3786 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
3787
3788         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
3789         https://bugs.webkit.org/show_bug.cgi?id=142433
3790
3791         Reviewed by Darin Adler.
3792
3793         Include more TestWebKitAPI tests when building for Windows. Also
3794         fix a build error in MetaAllocator.cpp caused by one of the
3795         Microsoft headers #defining 'small'.
3796
3797         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3798         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3799         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3800
3801 2015-03-06  Sam Weinig  <sam@webkit.org>
3802
3803         [Content Extensions] Move compiling of content extensions to the UIProcess
3804         https://bugs.webkit.org/show_bug.cgi?id=142402
3805
3806         Reviewed by Benjamin Poulain.
3807
3808         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3809         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
3810         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
3811         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
3812         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
3813         (TestWebKitAPI::TEST_F):
3814         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
3815         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
3816         is now abstract).
3817
3818 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
3819
3820         [Win] Correct Windows build.
3821
3822         Rubberstamped by Michael Saboff
3823
3824         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
3825         in the GOTO labels.
3826
3827 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3828
3829         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
3830         https://bugs.webkit.org/show_bug.cgi?id=142385
3831
3832         Reviewed by Sergio Villar Senin.
3833
3834         Use stack allocated GMainLoopSources to make sure they are
3835         cancelled automatically if the test finishes before they have
3836         been processed.
3837
3838         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3839         (testWebViewSyncRequestOnMaxConns):
3840
3841 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3842
3843         Remove Mountain Lion libraries since ML isn't supported
3844         https://bugs.webkit.org/show_bug.cgi?id=142332
3845
3846         Reviewed by Darin Adler.
3847
3848         * Scripts/copy-webkitlibraries-to-product-directory:
3849
3850 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
3851
3852         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
3853         https://bugs.webkit.org/show_bug.cgi?id=142083
3854
3855         Reviewed by Simon Fraser.
3856
3857         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
3858
3859         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3860         (WebPlatformTestServer._copy_webkit_test_files):
3861
3862 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3863
3864         setup-git-clone fails due to the failure to download python-irclib-0.4.8
3865         https://bugs.webkit.org/show_bug.cgi?id=141946
3866
3867         Reviewed by Ryosuke Niwa.
3868
3869         Check in ircbot.py and irclib.py to avoid network problems in the future.
3870
3871         * Scripts/webkitpy/common/net/irc/ircbot.py:
3872         * Scripts/webkitpy/thirdparty/__init__.py:
3873         (AutoinstallImportHook.find_module):
3874         (AutoinstallImportHook._install_irc): Deleted.
3875         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3876         (ThirdpartyTest.test_imports):
3877         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
3878         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
3879         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
3880
3881 2015-03-06  David Kilzer  <ddkilzer@apple.com>
3882
3883         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
3884
3885         See also fix to config.json in r181097.
3886
3887         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3888         (WebKitBuildbot): Add missing "WK2" to the names of the perf
3889         bots.
3890
3891 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3892
3893         run-jsc-stress-tests should determine the architecture from ELF binaries
3894         https://bugs.webkit.org/show_bug.cgi?id=142335
3895
3896         Reviewed by Darin Adler.
3897
3898         * Scripts/run-jsc-stress-tests:
3899
3900 2015-03-05  David Kilzer  <ddkilzer@apple.com>
3901
3902         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
3903         <http://webkit.org/b/142226>
3904
3905         Reviewed by Darin Adler.
3906
3907         * Scripts/webkitpy/port/ios.py:
3908         (IOSSimulatorPort.default_baseline_search_path): Switch the
3909         TestExpectations order of ios-simulator-wk2 from this:
3910           ios-simulator-wk2, wk2, ios-simulator
3911         To this:
3912           ios-simulator-wk2, ios-simualtor, wk2
3913
3914 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3915
3916         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
3917         https://bugs.webkit.org/show_bug.cgi?id=142370
3918
3919         Reviewed by Dean Jackson.
3920
3921         * Scripts/webkitdirs.pm:
3922         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
3923         logs, one for warnings, the other for errors.
3924         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
3925         into the standard BuildOutput.htm document.
3926
3927 2015-03-05  David Kilzer  <ddkilzer@apple.com>
3928
3929         Dashboard has trouble parsing iOS test output
3930         <http://webkit.org/b/142364>
3931
3932         Reviewed by Alex Christensen.
3933
3934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3935         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
3936         Add fallback path to build a regex using 'matchString' so that
3937         it matches anywhere in the line.  In practice, 'matchString' is
3938         a prefix for the label following the number.
3939
3940 2015-03-05  Alex Christensen  <achristensen@webkit.org>
3941
3942         Fix linker warnings in TestWebKitAPI.
3943         https://bugs.webkit.org/show_bug.cgi?id=141912
3944
3945         Reviewed by David Kilzer.
3946
3947         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3948         Do not export TearDownTestCase or SetUpTestCase symbols.
3949
3950 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3951
3952         [Win] Unreviewed EWS fix.
3953
3954         * Scripts/webkitdirs.pm:
3955         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
3956         the EWS output more usable.
3957
3958 2015-03-05  Chris Dumez  <cdumez@apple.com>
3959
3960         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
3961         https://bugs.webkit.org/show_bug.cgi?id=142350
3962
3963         Reviewed by Michael Saboff and Benjamin Poulain.
3964
3965         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
3966         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
3967
3968         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3969         (TestWebKitAPI::TEST):
3970
3971 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3972
3973         [Win] Ensure build target directory exists when launching MSBuild
3974         https://bugs.webkit.org/show_bug.cgi?id=142360
3975
3976         Reviewed by Dean Jackson.
3977
3978         Create the build output directory (if it doesn't exist) before
3979         launching MSBuild so that it can immediately begin writing logs.
3980
3981         * Scripts/webkitdirs.pm:
3982         (buildVisualStudioProject):
3983
3984 2015-03-05  Chris Dumez  <cdumez@apple.com>
3985
3986         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
3987         https://bugs.webkit.org/show_bug.cgi?id=142325
3988
3989         Reviewed by Csaba Osztrogonác.
3990
3991         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
3992         As a result, "--webkit-test-runner / -2" parameters are replaced by
3993         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
3994         than WebKitTestRunner.
3995
3996         * BuildSlaveSupport/build.webkit.org-config/config.json:
3997         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3998         (RunWebKit1Tests):
3999         (RunWebKit1Tests.start):
4000         (RunWebKit1LeakTests):
4001         (RunWebKit1LeakTests.start):
4002         (RunAndUploadPerfTestsWebKit1):
4003         (RunAndUploadPerfTestsWebKit1.start):
4004         (TestFactory):
4005         (TestWebKit1LeaksFactory):
4006         (TestWebKit1LeaksFactory.__init__):
4007         (TestWebKit1Factory):
4008         (TestWebKit1AllButJSCFactory):
4009         (TestAllButJSCFactory):
4010         (BuildAndPerfTestWebKit1Factory):
4011         (BuildAndPerfTestWebKit1Factory.__init__):
4012         (BuildAndPerfTestFactory):
4013         (BuildAndPerfTestFactory.__init__):
4014         (DownloadAndPerfTestWebKit1Factory):
4015         (DownloadAndPerfTestWebKit1Factory.__init__):
4016         (DownloadAndPerfTestFactory):
4017         (DownloadAndPerfTestFactory.__init__):
4018         (RunWebKitLeakTests): Deleted.
4019         (RunWebKitLeakTests.start): Deleted.
4020         (RunWebKit2Tests): Deleted.
4021         (RunWebKit2Tests.start): Deleted.
4022         (RunAndUploadPerfTestsWebKit2): Deleted.
4023         (RunAndUploadPerfTestsWebKit2.start): Deleted.
4024         (TestLeaksFactory): Deleted.
4025         (TestLeaksFactory.__init__): Deleted.
4026         (TestWebKit2Factory): Deleted.
4027         (TestWebKit2AndJSCFactory): Deleted.
4028         (BuildAndPerfTestWebKit2Factory): Deleted.
4029         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
4030         (DownloadAndPerfTestWebKit2Factory): Deleted.
4031         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
4032         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4033         (parse_args):
4034         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4035         (PerfTestsRunner._parse_args):
4036         * Scripts/webkitpy/port/port_testcase.py:
4037         (PortTestCase.test_build_driver):
4038
4039 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
4040
4041         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
4042         https://bugs.webkit.org/show_bug.cgi?id=140845
4043
4044         Reviewed by David Kilzer.
4045
4046         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
4047         and generate suitable build commands to drive a full build from our
4048         existing solution files.
4049
4050         * Scripts/webkitdirs.pm:
4051         (msBuildInstallDir): Added.
4052         (determineConfigurationForVisualStudio): Revise to use MSBuild command
4053         line arguments to drive the build.
4054         (setupCygwinEnv): Warn user if MSBuild cannot be located.
4055         (buildVisualStudioProject): Revise to use MSBuild command line arguments
4056         to specify build architecture.
4057         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
4058         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
4059         bother looking for CoreUI or SafariTheme build logs.
4060
4061 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
4062
4063         [buildbot] mastercfg_unittest.py should be runnable easily
4064         https://bugs.webkit.org/show_bug.cgi?id=142219
4065
4066         Reviewed by Chris Dumez.
4067
4068         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
4069         the last Twisted version works together with this buildbot version.
4070
4071         * Scripts/webkitpy/common/system/autoinstall.py:
4072         (AutoInstaller): Added prepend_to_search_path argument to be able
4073         to prefer autoinstalled package to system package.
4074         (AutoInstaller.__init__):
4075         (AutoInstaller._set_up_target_dir):
4076         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
4077         (AutoInstaller._prepare_package):
4078         (AutoInstaller._extract_targz): Renamed to _extract_tar.
4079         * Scripts/webkitpy/thirdparty/__init__.py:
4080         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
4081
4082 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
4083
4084         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
4085         https://bugs.webkit.org/show_bug.cgi?id=131162
4086
4087         Reviewed by Gyuyoung Kim.
4088
4089         * MiniBrowser/efl/main.c:
4090         (on_download_request):
4091         (on_download_finished):
4092         (on_download_failed):
4093         (window_create):
4094         Adapt download callbacks to new callback mechanism
4095
4096 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4097
4098         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
4099
4100         In r180927 we updated the libsoup version used by the jhbuild. In
4101         this new version the sniffer uses image/x-icon instead of
4102         image/vnd.microsoft.icon for blank.ico resource.
4103
4104         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
4105         (testWebResourceMimeType):
4106
4107 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4108
4109         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
4110         https://bugs.webkit.org/show_bug.cgi?id=142244
4111
4112         Reviewed by Sergio Villar Senin.
4113
4114         Check that the SSL server doesn't process any request in case of
4115         TLS errors when the policy is set to FAIL.
4116
4117         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
4118         (testTLSErrorsPolicy):
4119         (testTLSErrorsRedirect):
4120         (testTLSErrorsHTTPAuth):
4121         (testLoadFailedWithTLSErrors):
4122         (testSubresourceLoadFailedWithTLSErrors):
4123         (httpsServerCallback):
4124
4125 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
4126
4127         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
4128         https://bugs.webkit.org/show_bug.cgi?id=141154
4129
4130         Reviewed by Jer Noble.
4131
4132         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
4133
4134         For the sake of completeness WebKitTestRunner should specify temporary
4135         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
4136
4137         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
4138         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
4139         to get data storage paths. Only Mac port has an actual implementation of it.
4140         However, WebKitTestRunner overrides them in favour of unique temporary dir
4141         which is taken from libraryPathForTesting().
4142
4143         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
4144         is not implemented for EFL and GTK ports it returns an empty string.
4145         All default data folders besides MediaKeys are overridden in TestRunner
4146         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
4147         env variable.
4148
4149         GTK port does not enable encrypted keys by default so
4150         WebMediaKeyStorageManager::initialize() code path is never triggered.
4151
4152         * WebKitTestRunner/TestController.cpp:
4153         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
4154         WebKit ports.
4155
4156 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
4157
4158         [buildbot] Add regression test to check which builder runs which tests
4159         https://bugs.webkit.org/show_bug.cgi?id=142166
4160
4161         Reviewed by Alexey Proskuryakov.
4162
4163         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4164         (BuildStepsConstructorTest.createTest):
4165         (BuildStepsTest):
4166         (BuildStepsTest.generateTests):
4167         (BuildStepsTest.createTest):
4168         (BuildStepsTest.createTest.doTest):
4169         (BuildStepsTest.test_unnecessary_expected_results):
4170
4171 2015-03-04  Commit Queue  <commit-queue@webkit.org>
4172
4173         Unreviewed, rolling out r181054.
4174         https://bugs.webkit.org/show_bug.cgi?id=142320
4175
4176         Broke the api tests (Requested by sundiamonde on #webkit).
4177
4178         Reverted changeset:
4179
4180         "Fix linker warnings in TestWebKitAPI."
4181         https://bugs.webkit.org/show_bug.cgi?id=141912
4182         http://trac.webkit.org/changeset/181054
4183
4184 2015-03-04  Alex Christensen  <achristensen@webkit.org>
4185
4186         Fix linker warnings in TestWebKitAPI.
4187         https://bugs.webkit.org/show_bug.cgi?id=141912
4188
4189         Reviewed by David Kilzer.
4190
4191         * TestWebKitAPI/Configurations/Base.xcconfig:
4192         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
4193
4194 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
4195
4196         [Mac] Set SystemUIFontSelect in DRT and WKTR
4197         https://bugs.webkit.org/show_bug.cgi?id=142303
4198
4199         Reviewed by Myles C. Maxfield.
4200
4201         * DumpRenderTree/mac/DumpRenderTree.mm:
4202         (setDefaultsToConsistentValuesForTesting):
4203         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4204         (WTR::InjectedBundle::platformInitialize):
4205
4206 2015-03-04  Chris Dumez  <cdumez@apple.com>
4207
4208         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
4209         https://bugs.webkit.org/show_bug.cgi?id=142314
4210         <rdar://problem/20046835>
4211
4212         Reviewed by Ryosuke Niwa.
4213
4214         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
4215         to get WK2 code coverage.
4216
4217         * BuildSlaveSupport/build.webkit.org-config/config.json:
4218
4219 2015-03-04  Alex Christensen  <achristensen@webkit.org>
4220
4221         Move content extensions test to properly named directory.
4222         https://bugs.webkit.org/show_bug.cgi?id=142299
4223
4224         Reviewed by Tim Horton.
4225
4226         * WebKitTestRunner/mac/TestControllerMac.mm:
4227         (WTR::TestController::platformConfigureViewForTest):
4228
4229 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4230
4231         W3C test importer should use filesystem instead of os.walk
4232         https://bugs.webkit.org/show_bug.cgi?id=142085
4233
4234         Reviewed by Bem Jones-Bey.
4235
4236         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
4237         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
4238         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
4239
4240         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
4241         Added a unit test to check that test importer is now black-box testable using a Mock system.
4242
4243         * Scripts/webkitpy/common/system/filesystem.py:
4244         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
4245         (FileSystem.dirs_under.filter_all):
4246         * Scripts/webkitpy/common/system/filesystem_mock.py:
4247         (MockFileSystem.dirs_under):
4248         (MockFileSystem.dirs_under.filter_all):
4249         (MockFileSystem.getsize):
4250         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
4251         (MockFileSystemTest.test_dirs_under):
4252         (MockFileSystemTest.test_dirs_under.filter_dir):
4253         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4254         (RealFileSystemTest.test_sep):
4255         (RealFileSystemTest):
4256         (RealFileSystemTest.test_dirs_under):
4257         (RealFileSystemTest.test_dirs_under.filter_this_dir):
4258         * Scripts/webkitpy/w3c/test_importer.py:
4259         (TestImporter.do_import):
4260         (TestImporter.find_importable_tests.should_keep_subdir):
4261         (TestImporter.find_importable_tests):
4262         (TestImporter.should_keep_subdir): Deleted.
4263         (TestImporter.should_skip_file): Deleted.
4264         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4265         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
4266
4267 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
4268
4269         [WebEditingTester] Add support for the find and replace bar
4270         https://bugs.webkit.org/show_bug.cgi?id=142247
4271
4272         Reviewed by Enrica Casucci.
4273
4274         While it's not hooked up yet in WKWebView, adding support for the
4275         find bar to WebEditingTester will help us implement that functionality.
4276
4277         * WebEditingTester/AppDelegate.h:
4278         * WebEditingTester/AppDelegate.m:
4279         (-[WebEditingAppDelegate performTextFinderAction:]):
4280         * WebEditingTester/MainMenu.xib:
4281         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
4282
4283         * WebEditingTester/WK2WebDocumentController.m:
4284         (-[WK2WebDocumentController awakeFromNib]):
4285         (-[WK2WebDocumentController performTextFinderAction:]):
4286         (-[WK2WebDocumentController findBarView]):
4287         (-[WK2WebDocumentController setFindBarView:]):
4288         (-[WK2WebDocumentController isFindBarVisible]):
4289         (-[WK2WebDocumentController setFindBarVisible:]):
4290         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
4291         (-[WK2WebDocumentController layout]):
4292         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
4293         pointing at the WKWebView (currently nothing will work, but the bar will
4294         show up). Install and uninstall the bar as needed.
4295
4296         * WebEditingTester/WebDocument.xib:
4297         Don't use a full-size content view. There's no need, and it makes find
4298         bar layout harder.
4299
4300         * WebEditingTester/WebDocumentController.h:
4301         * WebEditingTester/WebDocumentController.m:
4302         (-[WebDocumentController performTextFinderAction:]):
4303
4304 2015-03-03  Sam Weinig  <sam@webkit.org>
4305
4306         [Content Extensions] Split parsing and compiling of content extensions into their own files
4307         https://bugs.webkit.org/show_bug.cgi?id=142259
4308
4309         Reviewed by Anders Carlsson.
4310
4311         Add basic unit test for the content filter compiler.
4312
4313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4314         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
4315         (WebCore::ContentExtensions::operator<<):
4316         (TestWebKitAPI::ContentFilterTest::SetUp):
4317         (TestWebKitAPI::TEST_F):
4318
4319 2015-03-04  Matthew Mirman  <mmirman@apple.com>
4320
4321         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
4322         https://bugs.webkit.org/show_bug.cgi?id=142230
4323
4324         Reviewed by Csaba Osztrogonác.
4325
4326         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4327         (TestFactory):
4328         (TestFactory.getProduct): Added
4329         (TestFactory.__init__): moved downloader to getProduct
4330         (BuildAndTestFactory):        
4331         (BuildAndTestFactory.getProduct): Added
4332         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
4333         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
4334
4335 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
4336
4337         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
4338         https://bugs.webkit.org/show_bug.cgi?id=142225
4339
4340         Reviewed by Carlos Garcia Campos.
4341
4342         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
4343         (testWebViewWebContextLifetime):
4344         (beforeAll):
4345
4346 2015-03-03  David Kilzer  <ddkilzer@apple.com>
4347
4348         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
4349         <http://webkit.org/b/142243>
4350
4351         Reviewed by Alexey Proskuryakov.
4352
4353         * WebKitTestRunner/TestController.cpp:
4354         (WTR::TestController::webProcessName):
4355         (WTR::TestController::networkProcessName):
4356         - Return the same process name on iOS and Mac because they both
4357           use the same process name for local engineering builds.
4358
4359 2015-03-03  David Kilzer  <ddkilzer@apple.com>
4360
4361         check-webkit-style: Add exception for FrameworkSoftLink.h header order
4362         <http://webkit.org/b/141872>
4363
4364         Reviewed by Alex Christensen.
4365
4366         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
4367         semi-colons in various places and fix whitespace.
4368         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
4369         constants.
4370         (_IncludeState.__init__): Add self._visited_soft_link_section