7af581d7d47712b79806e597661061e1ace2c15d
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         DataInteractionTests.ExternalSourceAttributedStringToContentEditable hits a debug assertion
4         https://bugs.webkit.org/show_bug.cgi?id=175787
5         <rdar://problem/33996612>
6
7         Reviewed by Wenson Hsieh.
8
9         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
10         (TestWebKitAPI::TEST):
11
12 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
13
14         Typo in "webkit-patch land"
15         https://bugs.webkit.org/show_bug.cgi?id=175788
16
17         Reviewed by Tim Horton.
18
19         * Scripts/webkitpy/tool/steps/commit.py:
20         (Commit._commit_warning):
21
22 2017-08-20  Sam Weinig  <sam@webkit.org>
23
24         StringView could use a function to strip leading/trailing characters without allocation
25         https://bugs.webkit.org/show_bug.cgi?id=175757
26
27         Reviewed by Darin Adler.
28
29         * TestWebKitAPI/Tests/WTF/StringView.cpp:
30         Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().
31
32 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
33
34         [PAL] Move spi/mac directory into PAL
35         https://bugs.webkit.org/show_bug.cgi?id=175649
36
37         Reviewed by Myles C. Maxfield.
38
39         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
40
41 2017-08-21  Per Arne Vollan  <pvollan@apple.com>
42
43         [Win] DRT should only allow any https certificate for localhost.
44         https://bugs.webkit.org/show_bug.cgi?id=175147
45
46         Reviewed by Brent Fulgham.
47
48         Add check to make sure only localhost requests allow any https certificate.
49
50         * DumpRenderTree/win/DumpRenderTree.cpp:
51         (runTest):
52
53 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
54
55         Add WTFLogChannel level to allow runtime log filtering
56         https://bugs.webkit.org/show_bug.cgi?id=175731
57         <rdar://problem/33967234>
58
59         Unreviewed build fix.
60
61         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
62         (TestWebKitAPI::LoggingTest::output): Disable testing output by default because it 
63         fails on some of the bots.
64
65 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
66
67         Add WTFLogChannel level to allow runtime log filtering
68         https://bugs.webkit.org/show_bug.cgi?id=175731
69         <rdar://problem/33967234>
70
71         Reviewed by Jer Noble.
72
73         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
74         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
75         (TestWebKitAPI::LoggingTest::output):
76         (TestWebKitAPI::TEST_F):
77
78 2017-08-19  Wenson Hsieh  <wenson_hsieh@apple.com>
79
80         [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
81         https://bugs.webkit.org/show_bug.cgi?id=175509
82         <rdar://problem/33728169>
83
84         Reviewed by Ryosuke Niwa.
85
86         Removes ExternalSourceAttributedStringToContentEditable and adds
87         ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
88         text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
89         original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
90         debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
91         that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
92         other style attribute, such as color, carries over from the NSAttributedString to the DOM.
93
94         Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.
95
96         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
97         (TestWebKitAPI::TEST):
98
99 2017-08-18  Ryan Haddad  <ryanhaddad@apple.com>
100
101         Unreviewed, rolling out r220938.
102
103         The API tests added with this change are failing.
104
105         Reverted changeset:
106
107         "Add WTFLogChannel level to allow runtime log filtering"
108         https://bugs.webkit.org/show_bug.cgi?id=175731
109         http://trac.webkit.org/changeset/220938
110
111 2017-08-18  Devin Rousso  <webkit@devinrousso.com>
112
113         Unreviewed, change my email.
114
115         * Scripts/webkitpy/common/config/contributors.json:
116
117 2017-08-18  Jonathan Bedard  <jbedard@apple.com>
118
119         Fix leak-checking for iOS Simulators
120         https://bugs.webkit.org/show_bug.cgi?id=175735
121
122         Reviewed by Darin Adler.
123
124         If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
125         Simulator (or device) because the process will have already been killed by the time we
126         check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.
127
128         * Scripts/webkitpy/port/server_process.py:
129         (ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
130         (ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
131         and SimulatorProcess.
132         * Scripts/webkitpy/port/simulator_process.py:
133         (SimulatorProcess.stop): Before closing the process, check for leaks.
134
135 2017-08-18  Eric Carlson  <eric.carlson@apple.com>
136
137         Add WTFLogChannel level to allow runtime log filtering
138         https://bugs.webkit.org/show_bug.cgi?id=175731
139         <rdar://problem/33967234>
140
141         Reviewed by Jer Noble.
142
143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
144         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
145         (TestWebKitAPI::LoggingTest::output):
146         (TestWebKitAPI::TEST_F):
147
148 2017-08-18  Alexey Proskuryakov  <ap@apple.com>
149
150         Add Dean Johnson to contributors.json for Bugzilla autocomplete.
151
152         * Scripts/webkitpy/common/config/contributors.json:
153
154 2017-08-18  Ross Kirsling  <ross.kirsling@sony.com>
155
156         [Tools] Add script to download a GitHub release
157         https://bugs.webkit.org/show_bug.cgi?id=175279
158
159         Reviewed by Brent Fulgham.
160
161         * Scripts/download-latest-github-release.py: Added.
162
163 2017-08-18  Commit Queue  <commit-queue@webkit.org>
164
165         Unreviewed, rolling out r220854.
166         https://bugs.webkit.org/show_bug.cgi?id=175716
167
168         I'm not sure we really need this (Requested by KaL on
169         #webkit).
170
171         Reverted changeset:
172
173         "[GTK][WPE] Add NTLM authentication enabled API"
174         https://bugs.webkit.org/show_bug.cgi?id=122952
175         http://trac.webkit.org/changeset/220854
176
177 2017-08-17  Michael Catanzaro  <mcatanzaro@igalia.com>
178
179         [GTK] Make TestContextMenu work on Fedora
180         https://bugs.webkit.org/show_bug.cgi?id=175708
181
182         Reviewed by Carlos Garcia Campos.
183
184         TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
185         and my student last summer who was trying to work on a context menu API. It's trying to load
186         an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
187         entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
188         don't care to investigate. Let's switch it to WebM so I can move on.
189
190         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
191         (prepareContextMenuTestView):
192         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
193         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
194
195 2017-08-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
196
197         check-webkit-style shouldn't check spacing in #elif preprocessor lines
198         https://bugs.webkit.org/show_bug.cgi?id=175652
199
200         Reviewed by Alex Christensen.
201
202         * Scripts/webkitpy/style/checkers/cpp.py:
203         (check_spacing):
204         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
205         (CppStyleTest.test_spacing_for_binary_ops):
206
207 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
208
209         Fix the build on other platforms after r220865
210         https://bugs.webkit.org/show_bug.cgi?id=175683
211
212         Reviewed by Tim Horton.
213
214         Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
215         availability is determined by SDK version rather than deployment version.
216
217         * TestWebKitAPI/ios/UIKitSPI.h:
218
219 2017-08-17  Andreas Kling  <akling@apple.com>
220
221         Disable CSS regions at compile time
222         https://bugs.webkit.org/show_bug.cgi?id=175630
223
224         Reviewed by Antti Koivisto.
225
226         * Scripts/webkitperl/FeatureList.pm:
227         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
228
229 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
230
231         Unreviewed, try to fix the internal iOS 10 build after r220865.
232
233         * TestWebKitAPI/ios/UIKitSPI.h:
234
235         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
236         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
237         this compiler guard.
238
239 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
240
241         [iOS] Respect type fidelities when copying image elements to the pasteboard
242         https://bugs.webkit.org/show_bug.cgi?id=175638
243         <rdar://problem/26556043>
244
245         Reviewed by Ryosuke Niwa.
246
247         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
248         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
249         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
250
251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
252         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
253         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
254         (TestWebKitAPI::TEST):
255         (TestWebKitAPI::presentActionSheetAndChooseAction):
256         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
257         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
258         (checkEstimatedSize):
259         (checkSuggestedNameAndEstimatedSize):
260
261         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
262
263         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
264         (TestWebKitAPI::TEST):
265         * TestWebKitAPI/ios/DataInteractionSimulator.h:
266         * TestWebKitAPI/ios/UIKitSPI.h: Added.
267
268 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
269
270         Recursively create resource load statistics folder for testing
271         https://bugs.webkit.org/show_bug.cgi?id=175676
272
273         Reviewed by Brady Eidson.
274
275         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
276         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
277
278 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
279
280         [GTK][WPE] Add NTLM authentication enabled API
281         https://bugs.webkit.org/show_bug.cgi?id=122952
282
283         Reviewed by Michael Catanzaro.
284
285         Add a test case to check we can enable/disable NTLM.
286
287         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
288         (testWebViewAuthenticationNTLM):
289         (beforeAll):
290
291 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
292
293         [PAL] Move spi/ios and spi/win directories into PAL
294         https://bugs.webkit.org/show_bug.cgi?id=175171
295
296         Reviewed by Antti Koivisto.
297
298         * DumpRenderTree/mac/EventSendingController.mm:
299
300 2017-08-16  Andy Estes  <aestes@apple.com>
301
302         [Payment Request] Add an ENABLE flag and an experimental feature preference
303         https://bugs.webkit.org/show_bug.cgi?id=175622
304
305         Reviewed by Tim Horton.
306
307         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
308         * WebKitTestRunner/TestController.cpp:
309         (WTR::TestController::resetPreferencesToConsistentValues):
310
311 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
312
313         undefined URL in PopoverTracker for failed step
314         https://bugs.webkit.org/show_bug.cgi?id=175593
315         <rdar://problem/33898769>
316
317         Reviewed by Daniel Bates.
318
319         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
320         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
321
322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
323         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
324         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
325         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
326         (BuildbotTestResults): Accept URL in constructor.
327
328 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
329
330         Remove Proximity Events and related code
331         https://bugs.webkit.org/show_bug.cgi?id=175545
332
333         Reviewed by Daniel Bates.
334
335         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
336         and other related code.
337
338         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
339
340 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
341
342         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
343         https://bugs.webkit.org/show_bug.cgi?id=175504
344
345         Reviewed by Sam Weinig.
346
347         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
348
349 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
350
351         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
352         https://bugs.webkit.org/show_bug.cgi?id=175557
353
354         Reviewed by Jon Lee.
355         
356         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
357
358         * DumpRenderTree/TestRunner.cpp:
359         (TestRunner::staticFunctions):
360         (setViewModeMediaFeatureCallback): Deleted.
361         * DumpRenderTree/TestRunner.h:
362         * DumpRenderTree/mac/TestRunnerMac.mm:
363         (TestRunner::setViewModeMediaFeature): Deleted.
364         * DumpRenderTree/win/TestRunnerWin.cpp:
365         (TestRunner::setViewModeMediaFeature): Deleted.
366         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
367
368 2017-08-14  Andy Estes  <aestes@apple.com>
369
370         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
371         https://bugs.webkit.org/show_bug.cgi?id=175548
372         <rdar://problem/33866206>
373
374         Reviewed by Brady Eidson.
375
376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
377         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
378         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
379
380 2017-08-14  Youenn Fablet  <youenn@apple.com>
381
382         WPT server should be able to do logging even if its output folder is not created at launch time
383         https://bugs.webkit.org/show_bug.cgi?id=175543
384
385         Reviewed by Alexey Proskuryakov.
386
387         Removing no longer used stdout/stderr member variables.
388         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
389
390         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
391         (WebPlatformTestServer.__init__):
392         (WebPlatformTestServer._prepare_config):
393         (WebPlatformTestServer._spawn_process):
394         (WebPlatformTestServer._stop_running_server):
395
396 2017-08-14  Daniel Bates  <dabates@apple.com>
397
398         webkit-patch: Passing --no-review should submit patch to EWS by default
399         https://bugs.webkit.org/show_bug.cgi?id=148899
400
401         Reviewed by David Kilzer.
402
403         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
404         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
405         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
406
407         Frequently I want to post a draft of a patch without review to have the EWS bots process
408         it to catch build and test breakage before I clean it up and post it for formal review.
409         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
410         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
411         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
412
413         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
414         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
415         parse the attachment id from the response page after adding an attachment to the bug.
416         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
417         HTTP response after uploading the patch.
418         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
419         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
420         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
421         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
422         * Scripts/webkitpy/tool/commands/upload.py:
423         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
424         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
425         this command.
426         (PostCommits.execute): Submit the patch to EWS, if applicable.
427         * Scripts/webkitpy/tool/commands/upload_unittest.py:
428         (test_upload): Set options.ews to False as the upload command expects this option
429         to be specified.
430         (test_upload_with_no_review_and_ews): Added.
431         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
432         * Scripts/webkitpy/tool/steps/options.py:
433         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
434         * Scripts/webkitpy/tool/steps/postdiff.py:
435         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
436         this command.
437         (PostDiff.run): Submit the patch to EWS, if applicable.
438         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
439         (SubmitToEWS):
440         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
441         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
442
443 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
444
445         Disable two flaky VideoControlsManager API tests.
446
447         Unreviewed test gardening.
448
449         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
450         (TestWebKitAPI::TEST):
451
452 2017-08-14  Tim Horton  <timothy_horton@apple.com>
453
454         Only create directory and sandbox extension handle for storage directories if they are set
455         https://bugs.webkit.org/show_bug.cgi?id=175522
456
457         Reviewed by Brady Eidson.
458
459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
460         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
461         (TEST):
462         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
463         doesn't log anything to stderr.
464
465 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
466
467         sub-categorize Sandbox violation logs
468         https://bugs.webkit.org/show_bug.cgi?id=175536
469         <rdar://problem/33834416>
470
471         Reviewed by David Kilzer.
472
473         * Scripts/webkitpy/common/system/crashlogs.py:
474         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
475         a Sandbox violation.
476         (CrashLogs._find_all_logs_darwin): Update comment.
477         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
478         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
479         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
480         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
481         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
482         * Scripts/webkitpy/port/darwin.py:
483         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
484
485 2017-08-14  Daniel Bates  <dabates@apple.com>
486
487         Add Automator service to copy permalink to Clipboard
488         https://bugs.webkit.org/show_bug.cgi?id=170978
489
490         Reviewed by Joseph Pecoraro.
491
492         It is helpful to reference using a hyperlink a particular line of code when having
493         a discussion on IRC or in a bug. You can get such a link by navigating to the file
494         in the Trac Browse Source viewer and selecting the line your are interested in.
495         I found myself doing this often enough that I wrote an Automator service to do it
496         for me.
497
498         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
499
500         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
501         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
502         * CopyPermalink/README: Added.
503
504 2017-08-14  Chris Dumez  <cdumez@apple.com>
505
506         Address flakiness related to download tests
507         https://bugs.webkit.org/show_bug.cgi?id=175338
508         <rdar://problem/33865119>
509
510         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
511         between tests.
512
513         * WebKitTestRunner/TestController.cpp:
514         (WTR::TestController::resetStateToConsistentValues):
515
516 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
517
518         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
519         https://bugs.webkit.org/show_bug.cgi?id=175474
520         <rdar://problem/33844628>
521
522         Reviewed by Wenson Hsieh.
523
524         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
525
526         * DumpRenderTree/mac/DumpRenderTree.mm:
527         (resetWebPreferencesToConsistentValues):
528         * WebKitTestRunner/TestController.cpp:
529         (WTR::TestController::resetPreferencesToConsistentValues):
530
531 2017-08-12  Chris Dumez  <cdumez@apple.com>
532
533         Address flakiness related to download tests
534         https://bugs.webkit.org/show_bug.cgi?id=175338
535
536         Reviewed by Ryosuke Niwa.
537
538         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
539           is actually queried when a download completes. Previously, this would be
540           identical to a call to testRunner.waitUntilDone() because any download
541           completion would call testRunner.notifyDone().
542         - Disable logging of download callbacks by default and add a
543           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
544           enable such logging.
545
546         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
547         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
548         (WTR::InjectedBundle::didReceiveMessageToPage):
549         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
550         (WTR::TestRunner::setShouldLogDownloadCallbacks):
551         * WebKitTestRunner/InjectedBundle/TestRunner.h:
552         * WebKitTestRunner/TestController.cpp:
553         (WTR::TestController::downloadDidStart):
554         (WTR::TestController::decideDestinationWithSuggestedFilename):
555         (WTR::TestController::downloadDidFinish):
556         (WTR::TestController::downloadDidFail):
557         (WTR::TestController::downloadDidCancel):
558         * WebKitTestRunner/TestController.h:
559         (WTR::TestController::setShouldLogDownloadCallbacks):
560         * WebKitTestRunner/TestInvocation.cpp:
561         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
562
563 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
564
565         Create mock ITP data in testing to prevent grandfathering
566         https://bugs.webkit.org/show_bug.cgi?id=174720
567
568         Unreviewed follow-up fix for r220604.
569
570         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
571         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
572
573 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
574
575         Create mock ITP data in testing to prevent grandfathering
576         https://bugs.webkit.org/show_bug.cgi?id=174720
577         <rdar://problem/33457779>
578
579         Reviewed by Brent Fulgham.
580
581         We don't need to be triggering grandfathering when each test runner starts. On Mac,
582         this may launch plugins which can cause layout tests to fail later if the test
583         runner does not shut-down before the plugins unload.
584
585         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
586         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
587         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
588         prevent grandfathering from being triggered.
589         * WebKitTestRunner/ios/TestControllerIOS.mm:
590         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
591         * WebKitTestRunner/mac/TestControllerMac.mm:
592         (WTR::TestController::platformInitialize): Ditto.
593
594 2017-08-11  Sam Weinig  <sam@webkit.org>
595
596         WTF::Function does not allow for reference / non-default constructible return types
597         https://bugs.webkit.org/show_bug.cgi?id=175244
598         <rdar://problem/33801582>
599
600         Reviewed by Chris Dumez.
601
602         * TestWebKitAPI/Tests/WTF/Function.cpp:
603         (TestWebKitAPI::TEST):
604
605 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
606
607         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
608         https://bugs.webkit.org/show_bug.cgi?id=175378
609
610         Reviewed by Sergio Villar Senin.
611
612         Add two test cases to check proxy authentication.
613
614         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
615         (Tunnel::Tunnel):
616         (Tunnel::~Tunnel):
617         (Tunnel::connect):
618         (Tunnel::connected):
619         (serverCallback):
620         (ProxyAuthenticationTest::ProxyAuthenticationTest):
621         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
622         (ProxyAuthenticationTest::proxyServerPortAsString):
623         (testWebViewAuthenticationProxy):
624         (testWebViewAuthenticationProxyHTTPS):
625         (beforeAll):
626
627 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
628
629         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
630         https://bugs.webkit.org/show_bug.cgi?id=175428
631
632         Both ports share the GStreamer code as multimedia backend and till
633         not so long they were using different versions. Now they do use
634         the same versions and it does not make any sense anymore (and
635         neither had sense before) to have differences in the modulesets.
636
637         In this patch I created a GStreamer moduleset and referenced it
638         from both GTK+'s and WPE's. GStreamer patches were also moved there.
639
640         Reviewed by Žan Doberšek.
641
642         * gstreamer/jhbuild.modules: Added.
643         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
644         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
645         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
646         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
647         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
648         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
649         * gtk/jhbuild.modules:
650         * wpe/jhbuild.modules:
651         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
652         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
653         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
654         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
655         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
656
657 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
658
659         Unreviewed, adding Ross Kirsling to contributors.json
660
661         * Scripts/webkitpy/common/config/contributors.json:
662
663 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
664
665         Unreviewed, attempt to fix build failure with VC2017
666
667         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
668         (TEST):
669
670 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
671
672         Unreviewed, suppress warnings on GCC
673
674         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
675         (TestWebKitAPI::CheckedArithmeticTester::run):
676
677 2017-08-10  Dan Bernstein  <mitz@apple.com>
678
679         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
680         https://bugs.webkit.org/show_bug.cgi?id=173223
681
682         Reviewed by Tim Horton.
683
684         The rebuilds were happening due to a difference in the compiler options that the IDE and
685         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
686         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
687         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
688         Advanced when a Custom Absolute path is selected.
689
690         * Scripts/webkitdirs.pm:
691         (determineBaseProductDir):
692
693 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
694
695         Run more WTF tests
696         https://bugs.webkit.org/show_bug.cgi?id=174970
697
698         Reviewed by Michael Catanzaro.
699
700         Some of WTF tests are not executed in non Apple ports while they are generic ones.
701         This patch adds these tests to non-Apple port TestWebKitAPI.
702         Currently, we do not add Signals.cpp since it depends on signal functionality.
703
704         * TestWebKitAPI/CMakeLists.txt:
705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
706         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
707         (isHigherPriority):
708         (TEST):
709         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
710         (TEST):
711         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
712         (TEST):
713
714 2017-08-10  obinna obike  <oobike@apple.com>
715
716         Remove obsolete link from webkit-queues status page
717         https://bugs.webkit.org/show_bug.cgi?id=175337
718
719         Reviewed by Aakash Jain.
720
721         * QueueStatusServer/templates/recentstatus.html:
722         Removed the link to the ews-watcher server.
723
724 2017-08-10  Brian Burg  <bburg@apple.com>
725
726         WKPreferences should conform to NSCopying
727         https://bugs.webkit.org/show_bug.cgi?id=175303
728         <rdar://problem/33764939>
729
730         Reviewed by Dan Bernstein.
731
732         Add unit test to make sure a WKPreference and its copy are
733         not aliased to each other or affect each other's properties.
734
735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
736         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
737         (TEST):
738
739 2017-08-10  Tim Horton  <timothy_horton@apple.com>
740
741         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
742         https://bugs.webkit.org/show_bug.cgi?id=175436
743         <rdar://problem/33667497>
744
745         Reviewed by Simon Fraser.
746
747         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
748         (TestWebKitAPI::TEST_F):
749
750 2017-08-10  Lucas Forschler  <lforschler@apple.com>
751
752         Fix duplicated code in r220534.
753
754         Unreviewed cleanup.
755
756         * Scripts/bisect-builds:
757
758 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
759
760         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
761         https://bugs.webkit.org/show_bug.cgi?id=175344
762         <rdar://problem/28507240>
763
764         Reviewed by Alexey Proskuryakov.
765
766         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
767         Finally enable the existing tests for iOS.
768
769         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
770         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
772         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
773
774 2017-08-10  Lucas Forschler  <lforschler@apple.com>
775
776         Write a tool to bisect WebKit builds
777         https://bugs.webkit.org/show_bug.cgi?id=174596
778
779         Reviewed by Dean Johnson and Kocsen Chung.
780
781         * Scripts/bisect-builds: Added.
782         (bisect_builds): main bisection algorithm
783         (download_archive):download an archive from S3 using existing tools
784         (extract_archive):extract an archive using existing tools
785         (find_le):Find rightmost value less than or equal to x
786         (find_ge):Find leftmost item greater than or equal to x
787         (get_api_url):generate url for the rest api/database
788         (get_indices_from_revisions):convert revisions to list indexes for bisection
789         (get_sorted_revisions):retrieve sorted revision list
790         (get_s3_location_for_revision):calculate the S3 archive storage location
791         (parse_args):parse command line arguments
792         (pick_next_build):compute the next build to bisect
793         (prompt_did_reproduce):prompt user for direction for bisection
794         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
795         (test_archive):Platform specific logic to test downloaded archive
796         (minified_platforms):return a list of minified platforms in the database
797         (unminified_platforms):return a list of full platforms in the database
798         (is_supported_platform):check if platform is supported
799         (validate_options):validate command line options
800         (main):
801
802 2017-08-10  Lucas Forschler  <lforschler@apple.com>
803
804         Remove bisect-builds script.
805         https://bugs.webkit.org/show_bug.cgi?id=175433
806         
807         Reviewed by Aakash Jain.
808
809         * Scripts/bisect-builds: Removed.
810
811 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
812
813         Remove ENABLE_GAMEPAD_DEPRECATED
814         https://bugs.webkit.org/show_bug.cgi?id=175361
815
816         Reviewed by Carlos Garcia Campos.
817
818         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
819
820 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
821
822         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
823         https://bugs.webkit.org/show_bug.cgi?id=175426
824
825         Reviewed by Carlos Garcia Campos.
826
827         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
828
829 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
830
831         Add Ms2ger as contributor.
832         https://bugs.webkit.org/show_bug.cgi?id=175325
833
834         Reviewed by Carlos Alberto Lopez Perez.
835
836         * Scripts/webkitpy/common/config/contributors.json:
837
838 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
839
840         Fix run-benchmark after r220483.
841         https://bugs.webkit.org/show_bug.cgi?id=175415
842         <rdar://problem/33803003>
843
844         Reviewed by Ryosuke Niwa.
845
846         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
847
848         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
849         (WebServerBenchmarkRunner._run_one_test):
850
851 2017-08-09  Chris Dumez  <cdumez@apple.com>
852
853         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
854         https://bugs.webkit.org/show_bug.cgi?id=175401
855
856         Reviewed by Brady Eidson.
857
858         * DumpRenderTree/mac/DumpRenderTree.mm:
859         (enableExperimentalFeatures):
860
861 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
862
863         [PAL] Move spi/cocoa and spi/cg directories into PAL
864         https://bugs.webkit.org/show_bug.cgi?id=175175
865
866         Reviewed by Myles C. Maxfield.
867
868         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
869         * DumpRenderTree/mac/DumpRenderTree.mm:
870         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
871         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
872
873         * Scripts/webkitpy/style/checker.py:
874         * Scripts/webkitpy/style/checker_unittest.py:
875         (GlobalVariablesTest.test_path_rules_specifier):
876
877         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
878
879         * Scripts/webkitpy/style/checkers/cpp.py:
880         (check_braces):
881         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
882         (WebKitStyleTest.test_braces.CF_OPTIONS):
883         (WebKitStyleTest.test_braces):
884
885         Prevent CF_OPTIONS() from being handled as funtion definition.
886
887 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
888
889         [WTF] Move TextStream into WTF
890         https://bugs.webkit.org/show_bug.cgi?id=175211
891
892         Reviewed by Myles C. Maxfield.
893
894         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
895
896 2017-08-09  Andy Estes  <aestes@apple.com>
897
898         Part 3 of: Rename DatabaseProcess to StorageProcess
899         https://bugs.webkit.org/show_bug.cgi?id=175034
900
901         Reviewed by Brady Eidson.
902
903         * WebKitTestRunner/TestController.cpp:
904         (WTR::TestController::databaseProcessName): Updated to return
905         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
906
907 2017-08-09  Commit Queue  <commit-queue@webkit.org>
908
909         Unreviewed, rolling out r220466, r220477, and r220487.
910         https://bugs.webkit.org/show_bug.cgi?id=175411
911
912         This change broke existing API tests and follow up fixes did
913         not resolve all the issues. (Requested by ryanhaddad on
914         #webkit).
915
916         Reverted changesets:
917
918         https://bugs.webkit.org/show_bug.cgi?id=175244
919         http://trac.webkit.org/changeset/220466
920
921         "WTF::Function does not allow for reference / non-default
922         constructible return types"
923         https://bugs.webkit.org/show_bug.cgi?id=175244
924         http://trac.webkit.org/changeset/220477
925
926         https://bugs.webkit.org/show_bug.cgi?id=175244
927         http://trac.webkit.org/changeset/220487
928
929 2017-08-09  Sam Weinig  <sam@webkit.org>
930
931         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
932
933         Remove one addition of null Function test.
934
935 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
936
937         Allow nested timeouts in webkitpy
938         https://bugs.webkit.org/show_bug.cgi?id=175390
939         <rdar://problem/33803003>
940
941         Reviewed by David Kilzer.
942
943         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
944         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
945         the executive to detect and recover from any issues connecting with devices.
946
947         * Scripts/webkitpy/benchmark_runner/utils.py:
948         (TimeoutError): Deleted.
949         (timeout): Deleted.
950         * Scripts/webkitpy/common/timeout_context.py: Added.
951         (Timeout): A timeout context designed to be nested.
952         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
953         (Timeout.TimeoutData.__init__):
954         (Timeout.default_handler): Timeout handler used if none is specified.
955         (Timeout.current): Access data about the most urgent timeout.
956         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
957         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
958         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
959         urgent timeout data.
960         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
961         most urgent timeout data, if such data exists.
962         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
963         (TimeoutContextTests):
964         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
965         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
966         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
967         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
968         over a less urgent outer timeout.
969         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
970         over a less urgent inner timeout.
971         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
972         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
973         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
974         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
975         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
976         * Scripts/webkitpy/port/simulator_process.py:
977         (SimulatorProcess._start): Use Timeout class.
978         * Scripts/webkitpy/xcode/simulated_device.py:
979         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
980         (SimulatedDevice.launch_app): Ditto.
981         (SimulatedDevice.launch_app._install_timeout): Deleted.
982         * Scripts/webkitpy/xcode/simulator.py:
983         (Simulator.wait_until_device_is_booted):Use Timeout class.
984         (Simulator.wait_until_device_is_in_state): Ditto.
985
986 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
987
988         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
989         https://bugs.webkit.org/show_bug.cgi?id=175392
990         <rdar://problem/33783207>
991
992         Reviewed by Tim Horton and Megan Gardner.
993
994         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
995
996         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
997
998 2017-08-09  Sam Weinig  <sam@webkit.org>
999
1000         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
1001
1002         * TestWebKitAPI/Tests/WTF/Function.cpp:
1003         Remove tests of null Functions, as they are no longer supported.
1004
1005 2017-08-09  Daniel Bates  <dabates@apple.com>
1006
1007         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1008         https://bugs.webkit.org/show_bug.cgi?id=175247
1009         <rdar://problem/33679804>
1010
1011         Reviewed by Brady Eidson.
1012
1013         Add tests for redirects.
1014
1015         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1016         (TEST):
1017         * TestWebKitAPI/cocoa/TestProtocol.mm:
1018         (createRedirectURL):
1019         (-[TestProtocol startLoading]):
1020
1021 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1022
1023         Unreviewed, rolling out r220393.
1024
1025         This patch regresses the performance of WebPage::editorState.
1026
1027         Reverted changeset:
1028
1029         "[iOS WK2] WKWebView schedules nonstop layout after pressing
1030         cmb+b,i,u inside a contenteditable div"
1031         https://bugs.webkit.org/show_bug.cgi?id=175116
1032         http://trac.webkit.org/changeset/220393
1033
1034 2017-08-08  obinna obike  <oobike@apple.com>
1035
1036         Created Individual EWS Pages
1037         https://bugs.webkit.org/show_bug.cgi?id=174477
1038
1039         Reviewed by Aakash Jain.
1040
1041         Created individual pages for each EWS. Changed the link within each status bubble
1042         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
1043
1044         * QueueStatusServer/handlers/patch.py:
1045         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
1046         * QueueStatusServer/handlers/statusbubble.py:
1047         (StatusBubble._build_bubble): Updated url for specific EWS.
1048         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
1049         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
1050         all ews queues.
1051         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
1052         takes you directly to the individual ews page.
1053
1054 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
1055
1056         Separate jsc stress test script writer from run-jsc-stress-tests
1057         https://bugs.webkit.org/show_bug.cgi?id=175216
1058
1059         Reviewed by Mark Lam.
1060
1061         * Scripts/run-jsc-stress-tests:
1062         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
1063
1064 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1065
1066         Unreviewed, fix Ubuntu LTS build
1067         https://bugs.webkit.org/show_bug.cgi?id=174490
1068
1069         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1070
1071 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1072
1073         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
1074         https://bugs.webkit.org/show_bug.cgi?id=175302
1075         <rdar://problem/33762116>
1076
1077         Reviewed by Tim Horton.
1078
1079         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
1080         See WebKit ChangeLog for more details.
1081
1082         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1083         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
1084         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
1085         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
1086         (-[SlowTextInputContext handleEvent:completionHandler:]):
1087         (-[SlowInputWebView inputContext]):
1088         (-[SlowInputWebView _web_superInputContext]):
1089         (TEST):
1090
1091 2017-08-08  John Wilander  <wilander@apple.com>
1092
1093         Resource Load Statistics: Clear web processes' state on history removal
1094         https://bugs.webkit.org/show_bug.cgi?id=175271
1095         <rdar://problem/33756560>
1096
1097         Reviewed by Chris Dumez.
1098
1099         Test infrastructure for asynchronous tests of website data
1100         removal for _WKWebsiteDataTypeResourceLoadStatistics.
1101
1102         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1103         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1104         (WTR::InjectedBundle::didReceiveMessageToPage):
1105         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1106         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1107         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
1108         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1109         * WebKitTestRunner/TestController.cpp:
1110         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1111         * WebKitTestRunner/TestController.h:
1112         * WebKitTestRunner/TestInvocation.cpp:
1113         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1114         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
1115         * WebKitTestRunner/TestInvocation.h:
1116         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1117         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1118
1119 2017-08-08  Alicia Boya García  <aboya@igalia.com>
1120
1121         Add Alicia Boya García as contributor
1122         https://bugs.webkit.org/show_bug.cgi?id=175326
1123
1124         Reviewed by Michael Catanzaro.
1125
1126         * Scripts/webkitpy/common/config/contributors.json:
1127
1128 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1129
1130         [CMake] Properly test if compiler supports compiler flags
1131         https://bugs.webkit.org/show_bug.cgi?id=174490
1132
1133         Reviewed by Konstantin Tokarev.
1134
1135         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1136         * MiniBrowser/gtk/CMakeLists.txt:
1137         * TestRunnerShared/Bindings/JSWrapper.cpp:
1138         (WTR::JSWrapper::initialize):
1139         * TestWebKitAPI/CMakeLists.txt:
1140         * TestWebKitAPI/PlatformGTK.cmake:
1141         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1142         (TestWebKitAPI::CheckedArithmeticTester::run):
1143         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1144         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1145         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1146         (formControlsAssociatedCallback):
1147         * TestWebKitAPI/glib/CMakeLists.txt:
1148         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1149         (Test::getResourcesDir):
1150         * WebKitTestRunner/CMakeLists.txt:
1151         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1152         (WTR::menuItemClickCallback):
1153         (WTR::staticConvertMenuItemToType):
1154         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1155         (WTR::TestRunner::setUseDashboardCompatibilityMode):
1156         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1157         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1158         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1159         (WTR::AccessibilityUIElement::helpText const):
1160         (WTR::AccessibilityUIElement::attributedStringForRange):
1161         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1162         (WTR::EventSenderProxy::updateTouchPoint):
1163         (WTR::EventSenderProxy::releaseTouchPoint):
1164
1165 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1166
1167         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
1168         https://bugs.webkit.org/show_bug.cgi?id=175116
1169         <rdar://problem/28279301>
1170
1171         Reviewed by Darin Adler and Ryosuke Niwa.
1172
1173         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
1174         EditorStateTests run on both iOS and Mac.
1175
1176         * TestWebKitAPI/EditingTestHarness.h: Added.
1177         * TestWebKitAPI/EditingTestHarness.mm: Added.
1178
1179         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
1180         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
1181         the state of the latest observed EditorState.
1182
1183         (-[EditingTestHarness initWithWebView:]):
1184         (-[EditingTestHarness dealloc]):
1185         (-[EditingTestHarness webView]):
1186         (-[EditingTestHarness latestEditorState]):
1187         (-[EditingTestHarness editorStateHistory]):
1188         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
1189         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
1190         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
1191         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
1192         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
1193         (-[EditingTestHarness toggleBold]):
1194         (-[EditingTestHarness toggleItalic]):
1195         (-[EditingTestHarness toggleUnderline]):
1196         (-[EditingTestHarness setForegroundColor:]):
1197         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
1198         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
1199         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
1200         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
1201         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
1202         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
1203         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
1204
1205         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
1206         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
1207         keys and values.
1208
1209         (-[EditingTestHarness latestEditorStateContains:]):
1210         (-[EditingTestHarness _webView:editorStateDidChange:]):
1211         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1212         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
1213         (TestWebKitAPI::setUpEditorStateTestHarness):
1214         (TestWebKitAPI::TEST):
1215         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
1216
1217 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
1218
1219         Prevent domain from being set to a TLD
1220         https://bugs.webkit.org/show_bug.cgi?id=175226
1221         <rdar://problem/11079948>
1222
1223         Reviewed by Chris Dumez.
1224
1225         Extend the public suffix tests to include cases used by the
1226         Public Domain 'Public Suffix List'.
1227
1228         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
1229         (TestWebKitAPI::TEST):
1230
1231 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
1232
1233         [XCode] webkit-patch should run sort-Xcode-project-file
1234         https://bugs.webkit.org/show_bug.cgi?id=174036
1235         <rdar://problem/33732709>
1236
1237         Reviewed by Simon Fraser.
1238
1239         * Scripts/webkitpy/common/config/ports.py:
1240         * Scripts/webkitpy/tool/commands/download.py:
1241         * Scripts/webkitpy/tool/commands/download_unittest.py:
1242         * Scripts/webkitpy/tool/commands/upload.py:
1243         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1244         * Scripts/webkitpy/tool/steps/__init__.py:
1245         * Scripts/webkitpy/tool/steps/options.py:
1246         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1247
1248 2017-08-07  Devin Rousso  <drousso@apple.com>
1249
1250         Web Inspector: Preview Canvas path when viewing a recording
1251         https://bugs.webkit.org/show_bug.cgi?id=174967
1252
1253         Reviewed by Brian Burg.
1254
1255         * DumpRenderTree/TestOptions.h:
1256         * DumpRenderTree/TestOptions.mm:
1257         (TestOptions::TestOptions):
1258         * DumpRenderTree/mac/DumpRenderTree.mm:
1259         (setWebPreferencesForTestOptions):
1260         * WebKitTestRunner/TestController.cpp:
1261         (WTR::TestController::resetPreferencesToConsistentValues):
1262         (WTR::updateTestOptionsFromTestHeader):
1263         * WebKitTestRunner/TestOptions.h:
1264         (WTR::TestOptions::hasSameInitializationOptions const):
1265         Add plumbing for new InspectorAdditions runtime flag.
1266
1267 2017-08-07  obinna obike  <oobike@apple.com>
1268
1269         Sorted EWS Queues on Patch page
1270         https://bugs.webkit.org/show_bug.cgi?id=173667
1271
1272         Reviewed by Aakash Jain.
1273
1274         * QueueStatusServer/handlers/patch.py:
1275         (Patch.get): Sorted queue_status.
1276         * QueueStatusServer/templates/patch.html:
1277         Changed queue_status.items to queue_status because it's a list.
1278
1279 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1280
1281         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
1282         https://bugs.webkit.org/show_bug.cgi?id=175286
1283
1284         Reviewed by Myles C. Maxfield.
1285
1286         * Scripts/webkitpy/style/checkers/cpp.py:
1287         (check_braces):
1288         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1289         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
1290         (WebKitStyleTest.test_braces):
1291         (WebKitStyleTest.test_braces.NS_OPTIONS):
1292
1293 2017-08-07  Brian Burg  <bburg@apple.com>
1294
1295         Remove CANVAS_PATH compilation guard
1296         https://bugs.webkit.org/show_bug.cgi?id=175207
1297
1298         Reviewed by Sam Weinig.
1299
1300         * Scripts/webkitperl/FeatureList.pm:
1301         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1302
1303 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
1304
1305         [Win] Use Visual Studio 2017 if installed.
1306         https://bugs.webkit.org/show_bug.cgi?id=175188
1307
1308         Reviewed by Sam Weinig.
1309
1310         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
1311
1312         * Scripts/webkitdirs.pm:
1313         (visualStudioInstallDir):
1314         (msBuildInstallDir):
1315
1316 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1317
1318         [GTK][WPE] Add API to provide browser information required by automation
1319         https://bugs.webkit.org/show_bug.cgi?id=175130
1320
1321         Reviewed by Michael Catanzaro.
1322
1323         * MiniBrowser/gtk/main.c:
1324         (automationStartedCallback): Set browser information when a new automation session is started.
1325         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1326         (testAutomationSessionApplicationInfo):
1327         (beforeAll):
1328
1329 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
1330
1331         Unreviewed, rolling out r220295.
1332
1333         This change introduced 4 errors in webkitpy tests.
1334
1335         Reverted changeset:
1336
1337         "[XCode] webkit-patch should run sort-Xcode-project-file"
1338         https://bugs.webkit.org/show_bug.cgi?id=174036
1339         http://trac.webkit.org/changeset/220295
1340
1341 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1342
1343         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
1344
1345         Unreviewed test gardening.
1346
1347         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1348         (TestWebKitAPI::TEST):
1349
1350 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
1351
1352         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
1353         https://bugs.webkit.org/show_bug.cgi?id=175083
1354
1355         Reviewed by Oliver Hunt.
1356         
1357         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
1358         to wait for VM destructions to finish before running the next test. This makes it easier to 
1359         understand leaks results from workers tests, and leads to fewer reported leaks.
1360
1361         * DumpRenderTree/mac/DumpRenderTree.mm:
1362         (runTest):
1363
1364 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1365
1366         check-webkit-style: fix path-specific rules for WebKit2 rename
1367         https://bugs.webkit.org/show_bug.cgi?id=175182
1368
1369         Reviewed by David Kilzer.
1370
1371         * Scripts/webkitpy/style/checker.py:
1372
1373 2017-08-04  Youenn Fablet  <youenn@apple.com>
1374
1375         [Cache API] Add Cache and CacheStorage IDL definitions
1376         https://bugs.webkit.org/show_bug.cgi?id=175201
1377
1378         Reviewed by Brady Eidson.
1379
1380         * DumpRenderTree/mac/DumpRenderTree.mm:
1381         (enableExperimentalFeatures):
1382         (resetWebPreferencesToConsistentValues):
1383         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1384         (WTR::InjectedBundle::beginTesting):
1385         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1386         (WTR::TestRunner::setCacheAPIEnabled):
1387         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1388
1389 2017-08-04  John Wilander  <wilander@apple.com>
1390
1391         Resource Load Statistics: Report user interaction immediately, but only when needed
1392         https://bugs.webkit.org/show_bug.cgi?id=175090
1393         <rdar://problem/33685546>
1394
1395         Reviewed by Chris Dumez.
1396
1397         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1398         (WTR::InjectedBundle::beginTesting):
1399             Now calls WebCore::ResourceLoadObserver::clearState().
1400
1401 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1402
1403         Add an API test for r220286
1404         https://bugs.webkit.org/show_bug.cgi?id=175206
1405
1406         Reviewed by Simon Fraser.
1407
1408         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1409         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1410         (createAnimatedResizeWebView):
1411         (TEST):
1412         Add a test to ensure that we don't call
1413         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1414         animated resize.
1415
1416 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1417
1418         [XCode] webkit-patch should run sort-Xcode-project-file
1419         https://bugs.webkit.org/show_bug.cgi?id=174036
1420
1421         Reviewed by Simon Fraser.
1422
1423         * Scripts/webkitpy/common/config/ports.py:
1424         * Scripts/webkitpy/tool/commands/download.py:
1425         * Scripts/webkitpy/tool/commands/upload.py:
1426         * Scripts/webkitpy/tool/steps/__init__.py:
1427         * Scripts/webkitpy/tool/steps/options.py:
1428         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1429
1430 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1431
1432         REGRESSION(r219857): run-benchmark --allplans broken
1433         https://bugs.webkit.org/show_bug.cgi?id=175186
1434
1435         Reviewed by Saam Barati.
1436
1437         r219857 forgot to update also the calls to BenchmarkRunner() that
1438         is done when the script is run with --allplans.
1439
1440         To fix this (and avoid future issues like this), let's factorize
1441         the calls to the benchhmark runner in a run_benchmark_plan()
1442         function.
1443
1444         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1445         (run_benchmark_plan):
1446         (start):
1447
1448 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1449
1450         Dashboard bubbles sometimes show failure count instead of crash count
1451         https://bugs.webkit.org/show_bug.cgi?id=175157
1452         <rdar://problem/33709009>
1453
1454         Reviewed by Alexey Proskuryakov.
1455
1456         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1457         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1458
1459 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1460
1461         Add tests for NeverDestroyed
1462         https://bugs.webkit.org/show_bug.cgi?id=175146
1463
1464         Reviewed by Darin Adler.
1465
1466         * CMakeLists.txt:
1467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1468         New files and sort.
1469
1470         * TestWebKitAPI/Tests/WTF/Logger.h:
1471         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1472         (TestWebKitAPI::log):
1473         (TestWebKitAPI::takeLogStr):
1474         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1475         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1476         (TestWebKitAPI::log): Deleted.
1477         (TestWebKitAPI::takeLogStr): Deleted.
1478         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1479
1480         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1481         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1482         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1483         (TestWebKitAPI::LifecycleLogger::operator=):
1484         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1485         (TestWebKitAPI::LifecycleLogger::setName):
1486         (TestWebKitAPI::TEST):
1487         Add a class that logs construction / assignment / modifications.
1488
1489         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1490         (TestWebKitAPI::TEST):
1491         (TestWebKitAPI::list):
1492         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1493
1494 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1495
1496         minification logic is not implemented for ios builds
1497         <rdar://problem/33726561>
1498
1499         Reviewed by Dean Johnson
1500
1501         * BuildSlaveSupport/built-product-archive:
1502         (minifyDirectory): refactor minifySource -> minifyDirectory
1503         (archiveBuiltProduct): add ios minification logic
1504         (minifySource): Deleted.
1505
1506 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1507
1508         Unreviewed, rolling out r220271.
1509
1510         Rolling out due to Layout Test failing on iOS Simulator.
1511
1512         Reverted changeset:
1513
1514         "Remove STREAMS_API compilation guard"
1515         https://bugs.webkit.org/show_bug.cgi?id=175165
1516         http://trac.webkit.org/changeset/220271
1517
1518 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1519
1520         Unreviewed, rolling out r220268.
1521
1522         This change caused assertion failures on macOS and iOS Debug
1523         WK2.
1524
1525         Reverted changeset:
1526
1527         "Resource Load Statistics: Report user interaction
1528         immediately, but only when needed"
1529         https://bugs.webkit.org/show_bug.cgi?id=175090
1530         http://trac.webkit.org/changeset/220268
1531
1532 2017-08-04  Youenn Fablet  <youenn@apple.com>
1533
1534         Remove STREAMS_API compilation guard
1535         https://bugs.webkit.org/show_bug.cgi?id=175165
1536
1537         Reviewed by Darin Adler.
1538
1539         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1540
1541 2017-08-04  John Wilander  <wilander@apple.com>
1542
1543         Resource Load Statistics: Report user interaction immediately, but only when needed
1544         https://bugs.webkit.org/show_bug.cgi?id=175090
1545         <rdar://problem/33685546>
1546
1547         Reviewed by Chris Dumez.
1548
1549         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1550         (WTR::InjectedBundle::beginTesting):
1551             Now calls WebCore::ResourceLoadObserver::clearState().
1552
1553 2017-08-03  Brian Burg  <bburg@apple.com>
1554
1555         Remove ENABLE(WEB_SOCKET) guards
1556         https://bugs.webkit.org/show_bug.cgi?id=167044
1557
1558         Reviewed by Joseph Pecoraro.
1559
1560         * Scripts/webkitperl/FeatureList.pm:
1561         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1562
1563 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1564
1565         REGRESSION(r219850): run-benchmark script broken on Linux
1566         https://bugs.webkit.org/show_bug.cgi?id=175126
1567
1568         Reviewed by Stephanie Lewis.
1569
1570         The run-benchmark script dynamically generates the list of supported
1571         browsers and platforms (currently Linux and OSX) by loading all
1572         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1573         and getting the browser_name and platform variables from the
1574         classes defined there.
1575
1576         This means that this classes should not raise an exception when
1577         loaded on other platforms or otherwise they will broke the whole
1578         script. Its fine if they raise an exception when executing any of
1579         the methods they implement, but not when just loading/importing
1580         the class.
1581
1582         Move the argument variable definitions that call on the platform
1583         specific OSXBrowserDriver._screen_size() function from beeing
1584         variables that are evaluated when loading the file, to be functions
1585         that are only evaluated when the actual functionality needs to be
1586         executed.
1587
1588         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1589         (OSXChromeDriver.launch_url):
1590         (OSXChromeCanaryDriver.launch_url):
1591         (create_args):
1592         (create_chrome_options):
1593         (create_window_size_arg):
1594         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1595         (OSXFirefoxDriver.launch_url):
1596         (OSXFirefoxNightlyDriver.launch_url):
1597         (OSXFirefoxNightlyDriver.launch_driver):
1598         (create_args):
1599
1600 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1601
1602         [PAL] Move spi/cf directory into PAL
1603         https://bugs.webkit.org/show_bug.cgi?id=175057
1604
1605         Reviewed by Antti Koivisto.
1606
1607         * Scripts/webkitpy/style/checker.py:
1608         * Scripts/webkitpy/style/checker_unittest.py:
1609         (GlobalVariablesTest.test_path_rules_specifier):
1610
1611         Ignore "readability/naming/underscores" style errors for sources
1612         under the WebCore/PAL/pal/spi directory.
1613
1614         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1615
1616 2017-08-03  Youenn Fablet  <youenn@apple.com>
1617
1618         Remove FETCH_API compilation guard
1619         https://bugs.webkit.org/show_bug.cgi?id=175154
1620
1621         Reviewed by Chris Dumez.
1622
1623         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1624
1625 2017-08-03  Lucas Forschler  <lforschler@apple.com>
1626
1627         Enable archive minification on iOS builds
1628         https://bugs.webkit.org/show_bug.cgi?id=174718
1629         
1630         Reviewed by Aakash Jain.
1631
1632         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1633         (BuildFactory.__init__):
1634
1635 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1636
1637         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
1638         https://bugs.webkit.org/show_bug.cgi?id=175140
1639
1640         Reviewed by Alexey Proskuryakov.
1641
1642         We are having lately issues with JSC tests causing problems on
1643         the GTK+ and WPE bots due to the high amount of memory some tests
1644         need to run.
1645
1646         The best thing we can do now is to workaround this by disabling
1647         all the tests marked as memoryLimited on the GTK and WPE bots.
1648         We may revise this on the future.
1649
1650         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1651         (RunJavaScriptCoreTests.start):
1652
1653 2017-08-03  Brady Eidson  <beidson@apple.com>
1654
1655         Add SW IDLs and stub out basic functionality.
1656         https://bugs.webkit.org/show_bug.cgi?id=175115
1657
1658         Reviewed by Chris Dumez.
1659
1660         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1661
1662         * Scripts/webkitpy/bindings/main.py:
1663
1664 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
1665
1666         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
1667         https://bugs.webkit.org/show_bug.cgi?id=159510
1668
1669         Reviewed by Daniel Bates.
1670
1671         Allow any https certificate when running tests.
1672
1673         * DumpRenderTree/win/DumpRenderTree.cpp:
1674         (runTest):
1675
1676 2017-08-02  Youenn Fablet  <youenn@apple.com>
1677
1678         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
1679         https://bugs.webkit.org/show_bug.cgi?id=175089
1680
1681         Reviewed by Chris Dumez.
1682
1683         * DumpRenderTree/TestOptions.mm:
1684         (TestOptions::TestOptions): Using absolutePath if available.
1685         * DumpRenderTree/mac/DumpRenderTree.mm:
1686         (computeTestURL): Removing http/tests/ specific URL computation.
1687         * Scripts/webkitpy/port/driver.py:
1688         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
1689
1690 2017-08-02  Lucas Forschler  <lforschler@apple.com>
1691
1692         download-built-product should allow for a proxy option
1693         https://bugs.webkit.org/show_bug.cgi?id=174875
1694
1695         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
1696
1697         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1698         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
1699         
1700
1701 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1702
1703         check-webkit-style: deleting lines in a file runs the linter on the whole file
1704         https://bugs.webkit.org/show_bug.cgi?id=175078
1705
1706         Reviewed by David Kilzer.
1707
1708         Deleting lines in a file should not cause linter errors to be blamed on the patch.
1709         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
1710
1711         * Scripts/webkitpy/style/checkers/test_expectations.py:
1712         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
1713         * Scripts/webkitpy/style/main_unittest.py:
1714         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
1715         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
1716         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
1717
1718 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1719
1720         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
1721         https://bugs.webkit.org/show_bug.cgi?id=175075
1722
1723         Reviewed by David Kilzer.
1724
1725         We have no way of handling text files with illegal unicode characters. Allow the callers of
1726         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
1727         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
1728
1729         * Scripts/webkitpy/common/system/filesystem.py:
1730         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
1731         (FileSystem.write_text_file): Ditto.
1732         * Scripts/webkitpy/common/system/filesystem_mock.py:
1733         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
1734         (MockFileSystem.write_text_file): Ditto.
1735         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1736         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
1737         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
1738
1739 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
1740
1741         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
1742         https://bugs.webkit.org/show_bug.cgi?id=175072
1743
1744         Reviewed by Alexey Proskuryakov.
1745
1746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1747         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
1748
1749 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1750
1751         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
1752         https://bugs.webkit.org/show_bug.cgi?id=175019
1753
1754         Reviewed by Darin Adler.
1755
1756         * TestWebKitAPI/CMakeLists.txt:
1757
1758 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1759
1760         Enabling uploading archives to S3
1761         https://bugs.webkit.org/show_bug.cgi?id=174198
1762
1763         Unreviewed unit test fix after r219235.
1764
1765         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1766
1767 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1768
1769         Fix JSCOnly ARM buildbots after r220047
1770         https://bugs.webkit.org/show_bug.cgi?id=174993
1771
1772         Unreviewed fix after r220087.
1773
1774         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1775         (BuildAndRemoteJSCTestsFactory.__init__):
1776
1777 2017-08-01  Chris Dumez  <cdumez@apple.com>
1778
1779         Add initial support for navigator.sendBeacon
1780         https://bugs.webkit.org/show_bug.cgi?id=175007
1781         <rdar://problem/33547728>
1782
1783         Reviewed by Sam Weinig.
1784
1785         Enable the Beacon API at runtime in the context of layout tests since the
1786         feature is currently disabled by default.
1787
1788         * DumpRenderTree/mac/DumpRenderTree.mm:
1789         (enableExperimentalFeatures):
1790         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1791         (WTR::InjectedBundle::beginTesting):
1792         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1793         (WTR::TestRunner::setModernMediaControlsEnabled):
1794         (WTR::TestRunner::setBeaconAPIEnabled):
1795         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1796
1797 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
1798
1799         Update Bot Watcher's Dashboard for Buildbot 0.9
1800         https://bugs.webkit.org/show_bug.cgi?id=174777
1801
1802         Reviewed by Daniel Bates.
1803
1804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1805         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
1806         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
1807         in a dictionary.
1808         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
1809         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
1810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1811         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
1812         (parseRevisionProperty): Ditto.
1813         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
1814         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
1815         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
1816         have changed in Buildbot 0.9.
1817         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
1818         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
1819         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
1820         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
1821         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
1822         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
1823         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
1824         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
1825         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
1826         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
1827         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1828         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
1829         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
1830         (BuildbotQueue.prototype.get overviewURL): Ditto.
1831         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
1832         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
1833         Buildbot 0.8 or 0.9.
1834         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
1835         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
1836         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
1837         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
1838         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
1839         Therefore we are fetching information for fixed number of build. 
1840         Also iterating the loop incrementally since the build data is already reverse sorted.
1841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1842         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
1843         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
1844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1845         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
1846
1847 2017-08-01  Devin Rousso  <drousso@apple.com>
1848
1849         Web Inspector: simplify WebInspector with WI
1850         https://bugs.webkit.org/show_bug.cgi?id=175058
1851
1852         Reviewed by Joseph Pecoraro.
1853
1854         * Scripts/check-inspector-strings:
1855         (extract_ui_strings):
1856         * Scripts/extract-localizable-js-strings:
1857
1858 2017-08-01  Youenn Fablet  <youenn@apple.com>
1859
1860         Layout tests with 'https' suffix should be run over HTTPS
1861         https://bugs.webkit.org/show_bug.cgi?id=174992
1862
1863         Reviewed by Chris Dumez.
1864
1865         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
1866         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
1867         Covered by corresponding unit tests.
1868
1869         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1870         (run_server):
1871         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1872         (base_http_url):
1873         (base_https_url):
1874         (base_url): Deleted.
1875         * Scripts/webkitpy/port/base.py:
1876         (Port.to.web_platform_test_server_base_http_url):
1877         (Port.to):
1878         (Port.to.web_platform_test_server_base_https_url):
1879         (Port.to.web_platform_test_server_base_url): Deleted.
1880         * Scripts/webkitpy/port/driver.py:
1881         (Driver.__init__):
1882         (Driver.wpt_test_path_to_uri):
1883         (Driver):
1884         (Driver.http_test_path_to_uri):
1885         (Driver.test_to_uri):
1886         (Driver.uri_to_test):
1887         * Scripts/webkitpy/port/driver_unittest.py:
1888         (DriverTest.test_test_to_uri):
1889         (DriverTest.test_uri_to_test):
1890
1891 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1892
1893         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
1894         https://bugs.webkit.org/show_bug.cgi?id=173998
1895
1896         Reviewed by Darin Adler.
1897
1898         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
1899         detect mistakes in backward compatibility in the future when we change it.
1900
1901         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
1902         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
1903         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
1904         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
1905         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
1906         internal key data slot.
1907
1908         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1909         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
1910         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
1911         (getNextMessage):
1912         (TEST):
1913         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
1914         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
1915         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
1916         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
1917         These are the pre-baked databases.
1918         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
1919         This is the actual test that do all the reads and comparisons.
1920         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
1921         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
1922         IndexedDB new stuffs. Then it can be used to bake the database again.
1923
1924 2017-08-01  Brady Eidson  <beidson@apple.com>
1925
1926         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
1927         https://bugs.webkit.org/show_bug.cgi?id=175030
1928
1929         Reviewed by Andy Estes.
1930
1931         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1932         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
1933
1934 2017-08-01  Brady Eidson  <beidson@apple.com>
1935
1936         Part 2 of: Rename DatabaseProcess to StorageProcess.
1937         https://bugs.webkit.org/show_bug.cgi?id=174880
1938
1939         Reviewed by Andy Estes.
1940
1941         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1942         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1943         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1944         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1945         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1946         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1947         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1948         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1949
1950 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
1951
1952         Fix JSCOnly ARM buildbots after r220047
1953         https://bugs.webkit.org/show_bug.cgi?id=174993
1954
1955         Reviewed by Saam Barati.
1956
1957         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1958         (BuildAndRemoteJSCTestsFactory.__init__):
1959
1960 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1961
1962         [WTF] Introduce Private Symbols
1963         https://bugs.webkit.org/show_bug.cgi?id=174935
1964
1965         Reviewed by Darin Adler.
1966
1967         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1968         (TestWebKitAPI::TEST):
1969
1970 2017-07-30  Darin Adler  <darin@apple.com>
1971
1972         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
1973         https://bugs.webkit.org/show_bug.cgi?id=130653
1974
1975         Reviewed by Antti Koivisto.
1976
1977         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1978         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
1979         when calling frameDidChangeLocation.
1980         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
1981         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
1982         thus causing mysterious failures of a couple of tests. There are two remaining issues:
1983         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
1984         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
1985         same logic flaw that causes "top loading frame" to get set to one of the subframes in
1986         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
1987         loading, subframe starts loading. It would be good to clean that up some day, but for now
1988         this patch makes the two work identically rather than changing both.
1989         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
1990
1991 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1992
1993         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
1994         https://bugs.webkit.org/show_bug.cgi?id=174963
1995
1996         Reviewed by Darin Adler.
1997
1998         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
1999         RetainPtr<>. This patch changes them to all use auto.
2000
2001         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2002         (TestWebKitAPI::TEST):
2003
2004 2017-07-30  Brady Eidson  <beidson@apple.com>
2005
2006         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
2007         https://bugs.webkit.org/show_bug.cgi?id=174958
2008
2009         Reviewed by Darin Adler.
2010
2011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2012         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
2013         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
2014         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
2015         (runUntilTasksInFlight):
2016         (TEST):
2017
2018 2017-07-28  Commit Queue  <commit-queue@webkit.org>
2019
2020         Unreviewed, rolling out r219990.
2021         https://bugs.webkit.org/show_bug.cgi?id=174961
2022
2023         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
2024         estes on #webkit).
2025
2026         Reverted changeset:
2027
2028         "Part 2 of: Rename DatabaseProcess to StorageProcess."
2029         https://bugs.webkit.org/show_bug.cgi?id=174880
2030         http://trac.webkit.org/changeset/219990
2031
2032 2017-07-28  Brady Eidson  <beidson@apple.com>
2033
2034         API tests that use URLSchemeHandler are failing.
2035         https://bugs.webkit.org/show_bug.cgi?id=174950
2036
2037         Reviewed by Alex Christensen.
2038
2039         Fix the NoMIMEType test to be correct.
2040
2041         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2042         (-[SchemeHandler initWithData:mimeType:]):
2043         (-[SchemeHandler webView:startURLSchemeTask:]):
2044         (TEST):
2045
2046 2017-07-28  Daniel Bates  <dabates@apple.com>
2047
2048         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
2049         https://bugs.webkit.org/show_bug.cgi?id=174876
2050
2051         Reviewed by Alex Christensen.
2052
2053         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
2054         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
2055         they provide a more direct way to test the platform abstraction.
2056
2057         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
2058
2059         * Scripts/prepare-ChangeLog:
2060         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
2061         of the current working directory.
2062
2063 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
2064
2065         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2066         https://bugs.webkit.org/show_bug.cgi?id=174930
2067
2068         Unreviewed test fix.
2069
2070         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
2071
2072         * Scripts/prepare-ChangeLog:
2073         (get_function_line_ranges_for_cpp):
2074
2075 2017-07-28  JF Bastien  <jfbastien@apple.com>
2076
2077         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2078         https://bugs.webkit.org/show_bug.cgi?id=174930
2079
2080         Reviewed by Daniel Bates.
2081
2082         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
2083         here also teach it about const and volatile overloads. I didn't do
2084         reference and rvalue reference overloads because we don't really
2085         use them, and the current parser throws away those characters and
2086         it doesn't seem worth making it more complex.
2087
2088         * Scripts/prepare-ChangeLog:
2089         (get_function_line_ranges_for_cpp):
2090         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2091         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2092         (Foo::Arrow::arrow):
2093         (Foo::Arrow::otherArrow):
2094         (Foo::Arrow::otherArrow const):
2095         (Foo::Arrow::otherArrow volatile):
2096         (Foo::Arrow::otherArrow const volatile):
2097
2098 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
2099
2100         [GTK] Building with ENABLE_VIDEO=OFF fails
2101         https://bugs.webkit.org/show_bug.cgi?id=174940
2102
2103         Reviewed by Alex Christensen.
2104
2105         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
2106         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
2107
2108         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2109         (methodCallCallback): Add missing USE(GSTREAMER) guard.
2110
2111 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
2112
2113         [WPE] Implement EventSenderProxy in WTR
2114         https://bugs.webkit.org/show_bug.cgi?id=173419
2115
2116         Reviewed by Žan Doberšek.
2117
2118         Add the implementation of EventSenderProxy to the WTR. This
2119         allows us to extend the coverage of the test suite in WKWPE.
2120
2121         * WebKitTestRunner/EventSenderProxy.h:
2122         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
2123         libxkbcommon needed to deal with key events.
2124         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2125         (WTR::EventSenderProxy::EventSenderProxy):
2126         (WTR::senderButtonToWPEButton):
2127         (WTR::EventSenderProxy::mouseDown):
2128         (WTR::EventSenderProxy::mouseUp):
2129         (WTR::EventSenderProxy::mouseMoveTo):
2130         (WTR::EventSenderProxy::mouseScrollBy):
2131         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2132         (WTR::EventSenderProxy::leapForward):
2133         (WTR::wkEventModifiersToWPE):
2134         (WTR::getXKBKeySymForKeyRef):
2135         (WTR::EventSenderProxy::keyDown):
2136         (WTR::EventSenderProxy::addTouchPoint):
2137         (WTR::EventSenderProxy::updateTouchPoint):
2138         (WTR::EventSenderProxy::setTouchModifier):
2139         (WTR::EventSenderProxy::setTouchPointRadius):
2140         (WTR::EventSenderProxy::getUpdatedTouchEvents):
2141         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
2142         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2143         (WTR::EventSenderProxy::touchStart):
2144         (WTR::EventSenderProxy::touchMove):
2145         (WTR::EventSenderProxy::touchEnd):
2146         (WTR::EventSenderProxy::touchCancel):
2147         (WTR::EventSenderProxy::clearTouchPoints):
2148         (WTR::EventSenderProxy::releaseTouchPoint):
2149         (WTR::EventSenderProxy::cancelTouchPoint):
2150
2151 2017-07-27  Brady Eidson  <beidson@apple.com>
2152
2153         Part 2 of: Rename DatabaseProcess to StorageProcess.
2154         https://bugs.webkit.org/show_bug.cgi?id=174880
2155
2156         Reviewed by Andy Estes.
2157
2158         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2159         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2160         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2161         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2162         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2163         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2164         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2165         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2166
2167 2017-07-26  Mark Lam  <mark.lam@apple.com>
2168
2169         Add ability to only run specific tests in run-javascriptcore-tests.
2170         https://bugs.webkit.org/show_bug.cgi?id=174884
2171
2172         Reviewed by Saam Barati.
2173
2174         For example, if we only want to run testapi, we can do so as follows:
2175             $ run-javascriptcore-tests --testapi
2176
2177         Previously, specifying --testapi effectively does nothing because we run all tests
2178         by default.  Only --no-testapi had the effect of disabling the test set.  This
2179         old behavior for --testapi is not very useful or meaningful.  We're now changing
2180         it to mean that we will only run that test.
2181
2182         With this change, we can also run more than one set of tests.  For example, if we
2183         only want to run testmasm and testair, we can do so as follows:
2184             $ run-javascriptcore-tests --testmasm --testair
2185
2186         By default, if no specific test option is specified, run-javascriptcore-tests will
2187         run all tests.
2188
2189         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
2190         the mozilla tests (--mozilla-tests) even though both are run via the lower level
2191         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
2192         the other set will not run.  For example, the following only runs the mozilla tests:
2193             $ run-javascriptcore-tests --mozilla-tests
2194
2195         Note also that --jit-stress-tests is not for choosing a different set of tests.
2196         Instead, it is used for determining whether we run JIT'ed test configurations
2197         on the jsc stress tests and mozilla tests.  As a result, specifying
2198         --jit-stress-tests will not omit other tests.  For example, the following still
2199         runs all tests:
2200             $ run-javascriptcore-tests --jit-stress-tests
2201
2202         * Scripts/run-javascriptcore-tests:
2203         (defaultStringForTestState):
2204         (enableTestOrNot):
2205         (runJSCStressTests):
2206
2207 2017-07-26  Mark Lam  <mark.lam@apple.com>
2208
2209         Make run-javascriptcore-test run testair, testb3, and testmasm.
2210         https://bugs.webkit.org/show_bug.cgi?id=174837
2211         <rdar://problem/33522927>
2212
2213         Reviewed by Saam Barati and Filip Pizlo.
2214
2215         1. Refactors code for running testapi so that we can use it to run other tests.
2216         2. Added running of testmasm, testair, testb3.
2217
2218         Note: the existing testapi invocation code does not support remote invocation of
2219         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
2220         and testb3 also do not support remote invocation.  If we wish to add remote
2221         invocation support, we should do that in a separate patch.
2222
2223         * Scripts/run-javascriptcore-tests:
2224         (testPath):
2225         (runTest):
2226         (testapiPath): Deleted.
2227
2228 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2229
2230         Remove duplicate code from Buildbot.js in dashboard
2231         https://bugs.webkit.org/show_bug.cgi?id=174870
2232
2233         Reviewed by Daniel Bates.
2234
2235         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2236         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
2237         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
2238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
2239         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
2240
2241 2017-07-26  Brady Eidson  <beidson@apple.com>
2242
2243         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
2244         https://bugs.webkit.org/show_bug.cgi?id=174851
2245
2246         Reviewed by Chris Dumez.
2247
2248         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2249         (TEST):
2250
2251 2017-07-26  Brian Burg  <bburg@apple.com>
2252
2253         Remove WEB_TIMING feature flag
2254         https://bugs.webkit.org/show_bug.cgi?id=174795
2255
2256         Reviewed by Alex Christensen.
2257
2258         * Scripts/webkitperl/FeatureList.pm:
2259         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2260
2261 2017-07-26  Chris Dumez  <cdumez@apple.com>
2262
2263         Pressing the Escape key should not be a valid user gesture to enter fullscreen
2264         https://bugs.webkit.org/show_bug.cgi?id=174864
2265         <rdar://problem/33009088>
2266
2267         Reviewed by Geoffrey Garen.
2268
2269         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
2270         WKTR.
2271
2272         * DumpRenderTree/mac/EventSendingController.mm:
2273         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2274
2275 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2276
2277         Unreviewed, added Romain Bellessort to contributors.json.
2278
2279         * Scripts/webkitpy/common/config/contributors.json:
2280
2281 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
2282
2283         [WPE] WebGL2 support
2284         https://bugs.webkit.org/show_bug.cgi?id=174249
2285
2286         Reviewed by Alex Christensen.
2287
2288         * Scripts/webkitperl/FeatureList.pm:
2289         Enable WebGL2 for WPE when building through build-webkit.
2290
2291 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2292
2293         Unreviewed. Fix GTK distcheck.
2294
2295         * gtk/make-dist.py:
2296         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
2297
2298 2017-07-25  Brady Eidson  <beidson@apple.com>
2299
2300         ResourceLoadStatistics grandfathering happens much too often.
2301         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
2302
2303         Reviewed by Chris Dumez.
2304
2305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2306         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
2307         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
2308         (TEST):
2309
2310 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2311
2312         Fix autoinstaller failing on autoinstall_everything
2313         https://bugs.webkit.org/show_bug.cgi?id=174830
2314
2315         Reviewed by Joseph Pecoraro.
2316
2317         * Scripts/webkitpy/thirdparty/__init__.py:
2318         (AutoinstallImportHook.find_module):
2319         (AutoinstallImportHook.install_chromedriver):
2320         (AutoinstallImportHook.install_geckodriver):
2321         (AutoinstallImportHook._install_chromedriver): Deleted.
2322         (AutoinstallImportHook._install_geckodriver): Deleted.
2323
2324 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
2325
2326         Replace --runtime with something for both ios-simulator and ios-device
2327         https://bugs.webkit.org/show_bug.cgi?id=173775
2328         <rdar://problem/32952164>
2329
2330         Reviewed by Aakash Jain.
2331
2332         Add --version flag for both iOS simulator and iOS device.
2333
2334         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2335         (parse_args): Add --version flag and move --no-install.
2336         * Scripts/webkitpy/port/factory.py:
2337         (platform_options): Move --no-intall to run_webkit_tests.py.
2338         * Scripts/webkitpy/port/ios.py:
2339         (IOSPort):
2340         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
2341         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
2342         * Scripts/webkitpy/port/ios_device.py:
2343         (IOSDevicePort.ios_version): Consult --version flag before checking connected
2344         devices for iOS version.
2345         * Scripts/webkitpy/port/ios_device_unittest.py:
2346         (IOSDeviceTest.make_port): Set --version option so that we can generate test
2347         expectation paths without devices connected.
2348         (IOSDeviceTest.test_additional_platform_directory): Deleted.
2349         (IOSDeviceTest.test_baseline_searchpath): Deleted.
2350         (IOSDeviceTest.test_expectations_ordering): Deleted.
2351         * Scripts/webkitpy/port/ios_simulator.py:
2352         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
2353         flag to specify a runtime.
2354         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
2355         flag and then use the default runtime.
2356
2357 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2358
2359         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
2360         https://bugs.webkit.org/show_bug.cgi?id=174815
2361
2362         Reviewed by Carlos Alberto Lopez Perez.
2363
2364         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
2365         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
2366         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
2367         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
2368         think), probably because of a newer CMake version.
2369
2370         * CMakeLists.txt:
2371         * TestWebKitAPI/CMakeLists.txt:
2372         * TestWebKitAPI/PlatformGTK.cmake:
2373
2374 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2375
2376         Fix BenchmarkRunner to only import selenium when needed
2377         https://bugs.webkit.org/show_bug.cgi?id=174808
2378
2379         Reviewed by Stephanie Lewis.
2380
2381         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2382         (LinuxChromeDriver.launch_driver):
2383         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2384         (LinuxFirefoxDriver.launch_driver):
2385         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2386         (OSXChromeDriver.launch_driver):
2387         (OSXChromeCanaryDriver.launch_driver):
2388         (create_chrome_options):
2389         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2390         (OSXFirefoxDriver.launch_driver):
2391         (OSXFirefoxNightlyDriver.launch_driver):
2392         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2393         (OSXSafariDriver.launch_driver):
2394         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2395         (WebDriverBenchmarkRunner._run_one_test):
2396
2397 2017-07-23  Darin Adler  <darin@apple.com>
2398
2399         More NeverDestroyed and related cleanup
2400         https://bugs.webkit.org/show_bug.cgi?id=174745
2401
2402         Reviewed by Alex Christensen.
2403
2404         * DumpRenderTree/JavaScriptThreading.cpp:
2405         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2406         DEPRECATED_DEFINE_STATIC_LOCAL.
2407         (javaScriptThreads): Ditto.
2408
2409 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2410
2411         Subclass Benchmark Runner script for WebDriver support
2412         https://bugs.webkit.org/show_bug.cgi?id=174390
2413
2414         Reviewed by Dewei Zhu, Stephanie Lewis.
2415
2416         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2417
2418         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2419         (BenchmarkBuilder.__init__):
2420         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2421         (BenchmarkRunner.__init__):
2422         (BenchmarkRunner._find_plan_file):
2423         (BenchmarkRunner._run_one_test.and):
2424         (BenchmarkRunner.execute):
2425         (BenchmarkRunner._get_result): Deleted.
2426         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2427         (parse_args):
2428         (start):
2429         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2430         (WebDriverBenchmarkRunner):
2431         (WebDriverBenchmarkRunner._get_result):
2432         (WebDriverBenchmarkRunner._run_one_test):
2433         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2434         (WebServerBenchmarkRunner):
2435         (WebServerBenchmarkRunner.__init__):
2436         (WebServerBenchmarkRunner._get_result):
2437         (WebServerBenchmarkRunner._run_one_test):
2438
2439 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2440
2441         Add BenchmarkRunner patches with WebDriver support for each testing plan
2442         https://bugs.webkit.org/show_bug.cgi?id=174443
2443
2444         Reviewed by Dewei Zhu, Stephanie Lewis.
2445
2446         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2447         (BenchmarkBuilder.__enter__):
2448         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2449         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2450         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2451         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2452         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2453         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2454         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2455         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2456         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2457         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2458         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2459         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2460         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2461         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2462         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2463         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2464         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2465         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2466         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2467         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2468         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2469         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2470         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2471         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2472         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2473         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2474         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2475         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2476         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2477         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2478         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2479         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2480         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2481
2482 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2483
2484         Add functions to autoinstaller needed for Benchmark Runner script
2485         https://bugs.webkit.org/show_bug.cgi?id=174331
2486
2487         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2488
2489         Adds autoinstaller functions to install selenium and webdriver binaries
2490         which will be used by the browser driver part of Benchmark Runner.
2491
2492         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2493         (BrowserDriver.restore_env):
2494         (BrowserDriver):
2495         (BrowserDriver.get_webdriver_binary_path):
2496         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2497         (LinuxChromeDriver.launch_driver):
2498         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2499         (LinuxFirefoxDriver.launch_driver):
2500         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2501         (OSXChromeDriver.launch_driver):
2502         (OSXChromeCanaryDriver.launch_driver):
2503         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2504         (OSXFirefoxDriver.launch_driver):
2505         (OSXFirefoxNightlyDriver.launch_driver):
2506         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2507         * Scripts/webkitpy/benchmark_runner/utils.py:
2508         (get_driver_binary_path):
2509         * Scripts/webkitpy/common/system/autoinstall.py:
2510         (AutoInstaller._unzip):
2511         * Scripts/webkitpy/thirdparty/__init__.py:
2512         (AutoinstallImportHook.find_module):
2513         (AutoinstallImportHook._install_selenium):
2514         (AutoinstallImportHook):
2515         (AutoinstallImportHook._install_chromedriver):
2516         (AutoinstallImportHook._install_geckodriver):
2517         (AutoinstallImportHook.get_latest_pypi_url):
2518         (AutoinstallImportHook.install_binary):
2519         (autoinstall_everything):
2520         (get_driver_filename):
2521         (get_os_info):
2522
2523 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2524
2525         Add WebDriver support in browser driver part of BenchmarkRunner
2526         https://bugs.webkit.org/show_bug.cgi?id=174445
2527
2528         Reviewed by Stephanie Lewis.
2529
2530         Adds a launch_driver function to each BrowserDriver subclass. This
2531         function sets up the arguments for the webdriver and launches the
2532         webdriver specific to that browser.
2533
2534         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2535         (BrowserDriver.launch_webdriver):
2536         (BrowserDriver):
2537         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2538         (LinuxBrowserDriver.launch_webdriver):
2539         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2540         (LinuxChromeDriver.launch_url):
2541         (LinuxChromeDriver):
2542         (LinuxChromeDriver.launch_driver):
2543         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2544         (EpiphanyBrowserDriver.launch_url):
2545         (EpiphanyBrowserDriver):
2546         (EpiphanyBrowserDriver.launch_driver):
2547         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2548         (LinuxFirefoxDriver):
2549         (LinuxFirefoxDriver.launch_url):
2550         (LinuxFirefoxDriver.launch_driver):
2551         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2552         (GTKMiniBrowserDriver.launch_url):
2553         (GTKMiniBrowserDriver):
2554         (GTKMiniBrowserDriver.launch_driver):
2555         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2556         (OSXBrowserDriver._launch_webdriver):
2557         (OSXBrowserDriver):
2558         (OSXBrowserDriver._screen_size):
2559         (OSXBrowserDriver._insert_url):
2560         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2561         (OSXChromeDriver):
2562         (OSXChromeDriver.launch_url):
2563         (OSXChromeDriver.launch_driver):
2564         (OSXChromeCanaryDriver):
2565         (OSXChromeCanaryDriver.launch_url):
2566         (OSXChromeCanaryDriver.launch_driver):
2567         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2568         (OSXFirefoxDriver):
2569         (OSXFirefoxDriver.launch_url):
2570         (OSXFirefoxDriver.launch_driver):
2571         (OSXFirefoxNightlyDriver):
2572         (OSXFirefoxNightlyDriver.launch_url):
2573         (OSXFirefoxNightlyDriver.launch_driver):
2574         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2575         (OSXSafariDriver.launch_driver):
2576
2577 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2578
2579         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
2580         https://bugs.webkit.org/show_bug.cgi?id=174793
2581
2582         Reviewed by Tim Horton.
2583
2584         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
2585         down. Without r219765, this test will dereference null and crash.
2586
2587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2588         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
2589         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
2590         (TEST):
2591
2592 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2593
2594         [Win] Implement Authentication dialog in MiniBrowser
2595         https://bugs.webkit.org/show_bug.cgi?id=174662
2596
2597         Reviewed by Alex Christensen.
2598
2599         * MiniBrowser/win/Common.cpp:
2600         (CustomUserAgent):
2601         (DisplayAuthDialog):
2602         (AuthDialogProc):
2603         * MiniBrowser/win/MiniBrowserLib.rc:
2604         * MiniBrowser/win/MiniBrowserLibResource.h:
2605         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2606         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2607
2608 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
2609
2610         Handle case where line_numbers is None instead of an array of line numbers
2611         https://bugs.webkit.org/show_bug.cgi?id=174775
2612
2613         Reviewed by Aakash Jain.
2614
2615         Added files set line_numbers to None in process_file.
2616
2617         * Scripts/webkitpy/style/filereader.py:
2618         (TextFileReader.process_file): Handle case where line_number is set to None.
2619         * Scripts/webkitpy/style/main_unittest.py:
2620         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
2621
2622 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2623
2624         [WPE] Add libepoxy to the Jhbuild moduleset
2625         https://bugs.webkit.org/show_bug.cgi?id=174711
2626
2627         Reviewed by Carlos Alberto Lopez Perez.
2628
2629         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
2630
2631 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2632
2633         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
2634         https://bugs.webkit.org/show_bug.cgi?id=174780
2635
2636         Reviewed by Carlos Garcia Campos.
2637
2638         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2639         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
2640         in case the eglplatform.h header doesn't provide that macro. This replicates
2641         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
2642
2643 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2644
2645         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
2646         https://bugs.webkit.org/show_bug.cgi?id=174758
2647
2648         Reviewed by Dan Bernstein.
2649
2650         Migrate position-information-related unit tests from the PositionInformationTests suite to
2651         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
2652
2653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2654         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2655         (TestWebKitAPI::checkElementTypeAndBoundingRect):
2656         (TestWebKitAPI::TEST):
2657         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
2658         * TestWebKitAPI/cocoa/TestWKWebView.h:
2659         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2660         (-[TestWKWebView activatedElementAtPosition:]):
2661
2662 2017-07-22  Chris Dumez  <cdumez@apple.com>
2663
2664         REGRESSION(r204565): WKObject is broken
2665         https://bugs.webkit.org/show_bug.cgi?id=174736
2666         <rdar://problem/33246169>
2667
2668         Reviewed by Dan Bernstein.
2669
2670         Add API test that used to crash.
2671
2672         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2673         (TestWebKitAPI::TEST):
2674
2675 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2676
2677         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
2678         https://bugs.webkit.org/show_bug.cgi?id=174705
2679
2680         Reviewed by Mark Lam.
2681
2682         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2683         (TestWebKitAPI::testThreadGroup):
2684         (TestWebKitAPI::TEST):
2685
2686 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
2687
2688         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
2689         https://bugs.webkit.org/show_bug.cgi?id=174724
2690
2691         Reviewed by Aakash Jain.
2692
2693         * Scripts/webkitpy/port/ios_simulator.py:
2694         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
2695         simulator. Errors here should be treated the same as no simulators found.
2696
2697 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
2698
2699         [CMake] Add an option to stop build after generating project files
2700         https://bugs.webkit.org/show_bug.cgi?id=174664
2701
2702         Reviewed by Konstantin Tokarev.
2703
2704         Add "--generate-project-only" to stop build after generating project files.
2705
2706         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
2707         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
2708         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
2709         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
2710         (isGenerateProjectOnly): ditto
2711
2712 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2713
2714         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2715         https://bugs.webkit.org/show_bug.cgi?id=174501
2716
2717         Reviewed by Darin Adler.
2718
2719         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2720         (TestWebKitAPI::TEST):
2721
2722 2017-07-20  David Quesada  <david_quesada@apple.com>
2723
2724         Add SPI to notify WKNavigationDelegate about client redirects
2725         https://bugs.webkit.org/show_bug.cgi?id=174680
2726         rdar://problem/33184886
2727
2728         Reviewed by Brady Eidson.
2729
2730         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2731         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
2732         (TEST):
2733         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
2734
2735 2017-07-20  Brady Eidson  <beidson@apple.com>
2736
2737         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
2738         https://bugs.webkit.org/show_bug.cgi?id=174685
2739
2740         Reviewed by Andy Estes.
2741
2742         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2743         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
2744
2745 2017-07-20  Brady Eidson  <beidson@apple.com>
2746
2747         Deprecate WebIconDatabase in WebKitLegacy/mac.
2748         https://bugs.webkit.org/show_bug.cgi?id=174607
2749
2750         Reviewed by Alex Christensen.
2751
2752         * DumpRenderTree/mac/TestRunnerMac.mm:
2753
2754 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2755
2756         lint-test-expectations should be run during style checking
2757         https://bugs.webkit.org/show_bug.cgi?id=173559
2758         <rdar://problem/32854941>
2759
2760         Reviewed by Aakash Jain.
2761
2762         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2763         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
2764         prevents identifying errors on specific lines in a file.
2765         * Scripts/webkitpy/style/main_unittest.py:
2766         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
2767         case where a linter error is in the file modified, but the line modified is not related to
2768         the linter error.
2769
2770 2017-07-20  Brady Eidson  <beidson@apple.com>
2771
2772         Remove WebIconDatabase from WebKitLegacy/win.
2773         https://bugs.webkit.org/show_bug.cgi?id=174608
2774
2775         Reviewed by Alex Christensen.
2776
2777         * DumpRenderTree/win/DumpRenderTree.cpp:
2778         (main):
2779         * DumpRenderTree/win/TestRunnerWin.cpp:
2780         (TestRunner::setIconDatabaseEnabled):
2781
2782 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
2783
2784         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
2785         https://bugs.webkit.org/show_bug.cgi?id=174671
2786
2787         Reviewed by Carlos Garcia Campos.
2788
2789         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2790         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
2791         priority for this source in order to have it dispatched on the same
2792         priority as the other WebKit-controlled GSource objects.
2793
2794 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2795
2796         lint-test-expectations should be run during style checking
2797         https://bugs.webkit.org/show_bug.cgi?id=173559
2798         <rdar://problem/32854941>
2799
2800         Reviewed by Daniel Bates.
2801
2802         Follow up fix addressing style and a few minor bugs.
2803
2804         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2805         (TestExpectationParser.__init__): Use lambda x: x instead of str
2806         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
2807         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
2808         reduce the calls of _shorten_filename, fix minor bug in appending the current
2809         expectation's line number instead of the previous ones, clarify treatment of None
2810         in file-to-line-number mapping.
2811         (TestExpectations._report_warnings): Collapse call.
2812         * Scripts/webkitpy/style/checkers/test_expectations.py:
2813         (TestExpectationsChecker.lint_test_expectations):
2814         * Scripts/webkitpy/style/filereader.py: Re-write comment.
2815         (TextFileReader.process_file): Add comment explaining treatment of None in
2816         file-to-line-number mapping.
2817         (TextFileReader.delete_file): Collapse call.
2818
2819 2017-07-19  Chris Dumez  <cdumez@apple.com>
2820
2821         Unreviewed attempt to fix API test failure after r219663.
2822
2823         The test was hard-coding an exception string and the string has changed slightly
2824         in r219663.
2825
2826         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2827         (TEST):
2828
2829 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
2830
2831         Don't write file URLs to iOS Pasteboard
2832         https://bugs.webkit.org/show_bug.cgi?id=174647
2833         <rdar://problem/33199730>
2834
2835         Reviewed by Wenson Hsieh.
2836
2837         Updating tests to reflect the lack of file URLs for images.
2838
2839         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2840         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
2841         (checkEstimatedSize):
2842         (TestWebKitAPI::TEST):
2843
2844 2017-07-19  Brady Eidson  <beidson@apple.com>
2845
2846         iBooks sometimes crashes when closing a book.
2847         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
2848
2849         Reviewed by Oliver Hunt.
2850
2851         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2852         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
2853         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
2854         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
2855         (TestWebKitAPI::TEST):
2856
2857         Add a "spin the runloop X number of times" utility:
2858         * TestWebKitAPI/Utilities.h:
2859         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2860         (TestWebKitAPI::Util::spinRunLoop):
2861
2862 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2863
2864         lint-test-expectations should be run during style checking
2865         https://bugs.webkit.org/show_bug.cgi?id=173559
2866         <rdar://problem/32854941>
2867
2868         Reviewed by David Kilzer.
2869
2870         Running the test expectation linter requires reading both files and lines not in the
2871         patch because, for example, deletion of a test can cause a lint failure even though
2872         no test expectations where modified. This means that the linter will occasionally warn
2873         about lines which were not changed in a given patch but whose error is related to a
2874         change made in that patch.
2875
2876         * Scripts/webkitpy/common/system/filesystem_mock.py:
2877         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
2878         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2879         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
2880         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
2881         content, description of the error and the name of the associated test.
2882         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
2883         (TestExpectationParser.__init__): Pass shorten_filename function to
2884         TestExpectationsParser to add a deleted file to the related_files dictionary.
2885         (TestExpectationParser._check_test_exists): If the test does not exist, add the
2886         missing path to the related_files dictionary.
2887         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
2888         files and line numbers related to this test expectation line. This will allow
2889         tracking linter errors in the style checker occurring across multiple files.
2890         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
2891         lines to related_files dictionary.
2892         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
2893         (TestExpectations._report_warnings): Construct warning object instead of string
2894         when adding to warnings list.
2895         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
2896         clean-up log.
2897         * Scripts/webkitpy/style/checker.py:
2898         (ProcessorBase.do_association_check): Add required function for processor classes.
2899         (StyleProcessor):
2900         (StyleProcessor.do_association_check): Run the TestExpectations linter when
2901         checking for errors between associated files.
2902         * Scripts/webkitpy/style/checkers/test_expectations.py:
2903         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
2904         (TestExpectationsChecker):
2905         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
2906         of modified files, the current working directory and the host, determine if the linter
2907         warning is associated with the changes.
2908         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
2909         style checker.
2910         * Scripts/webkitpy/style/filereader.py:
2911         (TextFileReader):
2912         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
2913         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
2914         (TextFileReader.process_file): Track both the number of files changed and which lines
2915         in those files were changed.
2916         (TextFileReader.do_association_check): Run the processor's association check on all
2917         modified or deleted files processed by TextFileReader.
2918         (TextFileReader.delete_file): Track deleted files in _files dictionary.
2919         (TextFileReader.count_delete_only_file): Deleted.
2920         * Scripts/webkitpy/style/filereader_unittest.py:
2921         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
2922         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
2923         * Scripts/webkitpy/style/main.py:
2924         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
2925         explicitly run the association check on the file reader.
2926         * Scripts/webkitpy/style/main_unittest.py:
2927         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
2928         embedded in the style checker.
2929         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
2930         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
2931         construct the TextFileReader object with a StyleProcessor used to run style checks on
2932         specific files.
2933         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
2934         testing the test expectation linter inside the style checker. This host must contain a
2935         mock file system with the basic structure of test expectations.
2936         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
2937         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
2938         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
2939         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
2940         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
2941         * Scripts/webkitpy/style/patchreader.py:
2942         (PatchReader.check): Specify which file was deleted, run the association check.
2943         * Scripts/webkitpy/style/patchreader_unittest.py:
2944         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
2945         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
2946         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
2947
2948 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2949
2950         [WTF] Implement WTF::ThreadGroup
2951         https://bugs.webkit.org/show_bug.cgi?id=174081
2952
2953         Reviewed by Mark Lam.
2954
2955         Add WTF::ThreadGroup tests.
2956
2957         * TestWebKitAPI/CMakeLists.txt:
2958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2959         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2960         (TestWebKitAPI::testThreadGroup):
2961         (TestWebKitAPI::TEST):
2962
2963 2017-07-18  Andy Estes  <aestes@apple.com>
2964
2965         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2966         https://bugs.webkit.org/show_bug.cgi?id=174631
2967
2968         Reviewed by Tim Horton.
2969
2970         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2971         * MiniBrowser/Configurations/Base.xcconfig:
2972         * MobileMiniBrowser/Configurations/Base.xcconfig:
2973         * TestWebKitAPI/Configurations/Base.xcconfig:
2974         * WebKitTestRunner/Configurations/Base.xcconfig:
2975
2976 2017-07-18  Andy Estes  <aestes@apple.com>
2977
2978         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2979         https://bugs.webkit.org/show_bug.cgi?id=174631
2980
2981         Reviewed by Sam Weinig.
2982
2983         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2984         * MiniBrowser/Configurations/Base.xcconfig:
2985         * MobileMiniBrowser/Configurations/Base.xcconfig:
2986         * TestWebKitAPI/Configurations/Base.xcconfig:
2987         * WebKitTestRunner/Configurations/Base.xcconfig:
2988
2989 2017-07-18  Daniel Bates  <dabates@apple.com>
2990
2991         lldb: Add type summary for StringView
2992         https://bugs.webkit.org/show_bug.cgi?id=174637
2993
2994         Reviewed by Sam Weinig.
2995
2996         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
2997         StringView object will print output that has the form:
2998
2999             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
3000               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
3001               m_length = 2
3002               m_is8Bit = true
3003               m_underlyingString = 0x0000614000000a90
3004             }
3005
3006         * lldb/lldb_webkit.py:
3007         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
3008         (WTFStringView_SummaryProvider):
3009         (WTFStringViewProvider):
3010         (WTFStringViewProvider.__init__):
3011         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
3012         (WTFStringViewProvider.get_length): Access field StringView.m_length.
3013         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
3014         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
3015
3016 2017-07-18  Andy Estes  <aestes@apple.com>
3017
3018         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3019         https://bugs.webkit.org/show_bug.cgi?id=174631
3020
3021         Reviewed by Dan Bernstein.
3022
3023         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3024         * MiniBrowser/Configurations/Base.xcconfig:
3025         * MobileMiniBrowser/Configurations/Base.xcconfig:
3026         * TestWebKitAPI/Configurations/Base.xcconfig:
3027         * WebKitTestRunner/Configurations/Base.xcconfig:
3028
3029 2017-07-18  Devin Rousso  <drousso@apple.com>
3030
3031         Web Inspector: Add memoryCost to Inspector Protocol objects
3032         https://bugs.webkit.org/show_bug.cgi?id=174478
3033
3034         Reviewed by Joseph Pecoraro.
3035
3036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3037         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
3038         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
3039         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
3040         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
3041         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
3042         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
3043         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
3044         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
3045         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
3046         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
3047         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
3048         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
3049         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
3050         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
3051         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
3052         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
3053
3054 2017-07-18  Andy Estes  <aestes@apple.com>
3055
3056         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3057         https://bugs.webkit.org/show_bug.cgi?id=174631
3058
3059         Reviewed by Darin Adler.
3060
3061         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3062         * MiniBrowser/Configurations/Base.xcconfig:
3063         * MobileMiniBrowser/Configurations/Base.xcconfig:
3064         * TestWebKitAPI/Configurations/Base.xcconfig:
3065         * WebKitTestRunner/Configurations/Base.xcconfig:
3066
3067 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3068
3069         Unreviewed, fix the iOS build.
3070
3071         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
3072
3073         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3074         (TestWebKitAPI::TEST):
3075
3076 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3077
3078         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
3079         https://bugs.webkit.org/show_bug.cgi?id=174585
3080         <rdar://problem/33302541>
3081
3082         Reviewed by Tim Horton.
3083
3084         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
3085         being dragged when initiating a drag.
3086
3087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3088         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
3089         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3090         (TestWebKitAPI::TEST):
3091         * TestWebKitAPI/cocoa/TestWKWebView.h:
3092
3093         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
3094
3095         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3096         (-[TestWKWebView synchronouslyLoadHTMLString:]):
3097
3098 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3099
3100         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
3101         https://bugs.webkit.org/show_bug.cgi?id=174547
3102
3103         Reviewed by Alex Christensen.
3104
3105         * DumpRenderTree/PlatformWin.cmake:
3106         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3107
3108 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3109
3110         Update style checker to deal with "final"
3111         https://bugs.webkit.org/show_bug.cgi?id=174528
3112
3113         Reviewed by Alex Christensen.
3114         
3115         check-webkit-style shouldn't complain about an open brace to start a
3116         line after a function definition with "final" or "const final".
3117
3118         * Scripts/webkitpy/style/checkers/cpp.py:
3119         (check_braces):
3120         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3121         (CppStyleTest.test_brace_at_begin_of_line):
3122
3123 2017-07-17  Alex Christensen  <achristensen@webkit.org>
3124
3125         Modernize content extension code
3126         https://bugs.webkit.org/show_bug.cgi?id=174588
3127
3128         Reviewed by Sam Weinig.
3129
3130         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3131         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3132         (TestWebKitAPI::testRequest):
3133         (TestWebKitAPI::makeBackend):
3134         (TestWebKitAPI::TEST_F):
3135
3136 2017-07-17  Brady Eidson  <beidson@apple.com>
3137
3138         WKHTTPCookieStore observing only works on the default cookie store.
3139         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
3140
3141         Reviewed by Sam Weinig.
3142
3143         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3144         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
3145           called for the default store, a non-persistent store, and a custom store.
3146         (TEST):
3147
3148 2017-07-16  Sam Weinig  <sam@webkit.org>
3149
3150         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
3151         https://bugs.webkit.org/show_bug.cgi?id=174575
3152
3153         Reviewed by Brady Eidson.
3154
3155         * Scripts/svn-create-patch:
3156         (findModificationType):
3157         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
3158         default value of "unknown".
3159
3160         (generateFileList):
3161         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
3162         for untracked, which matches our old behavior.
3163
3164 2017-07-17  Charlie Turner  <cturner@igalia.com>
3165
3166         Add some missing build dependencies on Fedora
3167         https://bugs.webkit.org/show_bug.cgi?id=174578
3168
3169         Unreviewed dependency update.
3170
3171         * gtk/install-dependencies:
3172
3173 2017-07-16  Brady Eidson  <beidson@apple.com>
3174
3175         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
3176         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
3177
3178         Reviewed by Tim Horton.
3179
3180         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3181         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
3182         (TEST):
3183
3184 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
3185
3186         [GTK] Sort inspector GResource manifest to ensure reproducible builds
3187         https://bugs.webkit.org/show_bug.cgi?id=174540
3188
3189         Reviewed by Michael Catanzaro.
3190
3191         * gtk/generate-inspector-gresource-manifest.py:
3192         (get_filenames): sort list of input files
3193
3194 2017-07-15  Brady Eidson  <beidson@apple.com>
3195
3196         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
3197         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
3198
3199         Reviewed by Tim Horton.
3200
3201         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3202         (TEST): Make this test more reliable by clearing everything beforehand.
3203
3204 2017-07-15  David Kilzer  <ddkilzer@apple.com>
3205
3206         Make it possible to extend check-webkit-style with Apple-internal checkers
3207         <https://webkit.org/b/174464>
3208         <rdar://problem/25564402>
3209
3210         Reviewed by Darin Adler.
3211
3212         * Scripts/webkitpy/style/checker.py: Import apple_additions.
3213         (_all_categories): Add categories from apple_additions() if it
3214         exists.
3215         (CheckerDispatcher._create_checker): Create python checker
3216         from apple_additions() if it exists.
3217
3218 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3219
3220         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
3221         https://bugs.webkit.org/show_bug.cgi?id=174539
3222         <rdar://problem/33307395>
3223
3224         Reviewed by Darin Adler.
3225
3226         Adds a new unit test suite to cover action sheet popover presentation.
3227
3228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3229         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
3230         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
3231         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
3232
3233         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
3234
3235         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
3236         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3237
3238         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
3239
3240         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3241         (TestWebKitAPI::TEST):
3242
3243 2017-07-15  Sam Weinig  <sam@webkit.org>
3244
3245         [Scripts] Make svn-create-patch work better when called in sub directories
3246         https://bugs.webkit.org/show_bug.cgi?id=174551
3247
3248         Reviewed by Darin Adler.
3249
3250         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
3251           by ensuring that the prefix is applied as is done in generateDiff.
3252         - Silence output of explanatory lines from svn stat (" > move to ...")
3253           that show up in STDERR when running svn-create-patch.
3254         - Add verbose logging that I found useful while debugging this issue.
3255
3256         * Scripts/svn-create-patch:
3257         (findBaseUrl):
3258         (findMimeType):
3259         (findSourceFileAndRevision):
3260         (generateDiff):
3261         (generateFileList):
3262         (manufacturePatchForAdditionWithHistory):
3263
3264 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
3265
3266         Unreviewed build fix after r219537.
3267
3268         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3269
3270 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3271
3272         Add iOS 11 SPI
3273         https://bugs.webkit.org/show_bug.cgi?id=174430
3274         <rdar://problem/33269288>
3275
3276         Reviewed by Tim Horton.
3277
3278         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
3279         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
3280         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
3281
3282 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3283
3284         Failing to install on iPad simulators
3285         https://bugs.webkit.org/show_bug.cgi?id=174532
3286         <rdar://problem/33328347>
3287
3288         Reviewed by Stephanie Lewis.
3289
3290         * Scripts/webkitpy/xcode/simulated_device.py:
3291         (SimulatedDevice.install_app): Place install command in retry try-except block.
3292
3293 2017-07-14  Jeff Miller  <jeffm@apple.com>
3294
3295         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3296         https://bugs.webkit.org/show_bug.cgi?id=174524
3297
3298         Reviewed by Sam Weinig.
3299
3300         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
3301         (TEST):
3302         Renamed TestParameter to TestParameter1.
3303         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3304
3305         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3306         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3307         Observe changes for two bundle parameters.
3308
3309         (-[BundleParametersPlugIn dealloc]):
3310         Remove observers for two bundle parameters.
3311
3312 2017-07-14  Commit Queue  <commit-queue@webkit.org>
3313
3314         Unreviewed, rolling out r219510.
3315         https://bugs.webkit.org/show_bug.cgi?id=174525
3316
3317         Need to revert length() == 0 check for null string (Requested
3318         by yusukesuzuki on #webkit).
3319
3320         Reverted changeset:
3321
3322         "[WTF] Newly added AtomicStringImpl should use BufferInternal
3323         static string if StringImpl is static"
3324         https://bugs.webkit.org/show_bug.cgi?id=174501
3325         http://trac.webkit.org/changeset/219510
3326
3327 2017-07-14  Jer Noble  <jer.noble@apple.com>
3328
3329         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
3330         https://bugs.webkit.org/show_bug.cgi?id=174514
3331
3332         Reviewed by Sam Weinig.
3333
3334         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
3335         (TestWebKitAPI::TEST_F):
3336
3337 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3338
3339         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3340         https://bugs.webkit.org/show_bug.cgi?id=174501
3341
3342         Reviewed by Darin Adler.
3343
3344         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3345         (TestWebKitAPI::TEST):
3346
3347 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3348
3349         Bring mac expectations in-line with other platforms
3350         https://bugs.webkit.org/show_bug.cgi?id=174472
3351         <rdar://problem/33297388>
3352
3353         Reviewed by David Kilzer.
3354
3355         The override order for Mac test expectations does not conform to the pattern used by iOS,
3356         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
3357
3358             platform/mac-wk2
3359             platform/wk2
3360             platform/mac-elcapitan
3361             platform/mac-sierra
3362             generic
3363
3364         After this change, El Capitan's baseline search path looks like this:
3365
3366             platform/mac-sierra-wk2
3367             platform/mac-sierra
3368             platform/mac-wk2
3369             platform/wk2
3370             generic
3371
3372         * Scripts/webkitpy/port/mac.py:
3373         (MacPort.__init__): If a specific version is specified in the port name, use that
3374         as the os version.
3375         (MacPort.default_baseline_search_path): Expectation search paths should work the
3376         same way they do on other ports. Port + version overrides port, port overrides generic
3377         and wk1/wk2 should override expectations for the two combined.
3378         * Scripts/webkitpy/port/mac_unittest.py:
3379         (MacTest.test_tests_for_other_platforms): Deleted.
3380         (MacTest._assert_search_path): Deleted.
3381         (MacTest.test_baseline_search_path): Deleted.
3382         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3383         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
3384         (test_rebaseline_test_and_print_scm_changes): Ditto.
3385         (test_rebaseline_and_copy_test): Ditto.
3386         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
3387         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
3388         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
3389
3390 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3391
3392         Fix style checker unit test
3393
3394         Unreviewed WebKit2 => WebKit fixup.
3395
3396         * Scripts/webkitpy/style/checker_unittest.py:
3397         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3398
3399 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3400
3401         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
3402
3403         Unreviewed build fix.
3404
3405         r219492 missed one hunk from its partial revert of r219489.
3406         This patch reverts that hunk.
3407
3408         * TestWebKitAPI/CMakeLists.txt:
3409
3410 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3411
3412         Use the old WebKit/WebKit2 targets for CMake builds.
3413
3414         Unreviewed build fix.
3415
3416         We can update the target names to match the Framework names in a future patch.
3417         This is a partial revert of r219489.
3418
3419         * TestWebKitAPI/CMakeLists.txt:
3420         WebKitLegacy => WebKit
3421         WebKit => WebKit2
3422
3423 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3424
3425         Fix TestWebKit API.
3426         https://bugs.webkit.org/show_bug.cgi?id=174164
3427         rdar://problem/33137595
3428
3429         Reviewed by Dan Bernstein.
3430
3431         * TestWebKitAPI/CMakeLists.txt:
3432         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3433         * TestWebKitAPI/PlatformGTK.cmake:
3434
3435 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3436
3437         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
3438         https://bugs.webkit.org/show_bug.cgi?id=174164
3439         rdar://problem/33137595
3440
3441         Reviewed by Dan Bernstein.
3442
3443         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3444         (ShouldBuildTest):
3445         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3446         * Scripts/build-webkit:
3447         * Scripts/do-file-rename:
3448         * Scripts/do-webcore-rename:
3449         * Scripts/update-webkit-localizable-strings:
3450         * Scripts/webkitpy/common/config/watchlist:
3451         * Scripts/webkitpy/style/checker.py:
3452         * Scripts/webkitpy/style/checkers/featuredefines.py:
3453         * gtk/make-dist.py:
3454         (ensure_version_if_possible):
3455         * gtk/manifest.txt.in:
3456
3457 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
3458
3459         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
3460         https://bugs.webkit.org/show_bug.cgi?id=174162
3461         rdar://problem/33137594
3462
3463         Reviewed by Dan Bernstein.
3464
3465         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
3466
3467         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3468         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3469         * EWSTools/configure-clang-linux.sh:
3470         * Scripts/build-webkit:
3471         * Scripts/do-file-rename:
3472         * Scripts/do-webcore-rename:
3473         * Scripts/update-webkit-localizable-strings:
3474         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3475         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3476         * Scripts/webkitpy/style/checkers/featuredefines.py:
3477         * gtk/manifest.txt.in:
3478
3479 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
3480
3481         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
3482         https://bugs.webkit.org/show_bug.cgi?id=174438
3483         <rdar://problem/33277112>
3484
3485         Reviewed by Aakash Jain.
3486
3487         Given a patch, this will convert the changes from the path to the new directory structure.
3488
3489         * Scripts/rebase-patch-after-webkit-move: Added.
3490         (append_source): Append 'Source' to the provided path.
3491         (is_editable_line): Return true if a line the script expects to modify.
3492         (needs_rebase): Return if a line needs to be rebased based on it's content.
3493         (rebase_line): Rebase the provided line.
3494         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
3495         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
3496         were provided.
3497
3498 2017-07-12  Nan Wang  <n_wang@apple.com>
3499
3500         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3501         https://bugs.webkit.org/show_bug.cgi?id=174393
3502         <rdar://problem/33248006>
3503
3504         Reviewed by Chris Fleizach.
3505
3506         * DumpRenderTree/AccessibilityUIElement.cpp:
3507         (textMarkerRangeMatchesTextNearMarkersCallback):
3508         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3509         (AccessibilityUIElement::getJSClass):
3510         * DumpRenderTree/AccessibilityUIElement.h:
3511         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3512         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3513         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3514         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3515         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3516         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3517         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3518         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3519
3520 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3521
3522         Unreviewed, rolling out r219409.
3523
3524         The revision caused the Windows builds to fail.
3525
3526         Reverted changeset:
3527
3528         "AX: [iOS] Implement a way to retrieve a text marker range
3529         with desired text that is closest to a position"
3530         https://bugs.webkit.org/show_bug.cgi?id=174393
3531         http://trac.webkit.org/changeset/219409
3532
3533 2017-07-12  Nan Wang  <n_wang@apple.com>
3534
3535         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3536         https://bugs.webkit.org/show_bug.cgi?id=174393
3537         <rdar://problem/33248006>
3538
3539         Reviewed by Chris Fleizach.
3540
3541         * DumpRenderTree/AccessibilityUIElement.cpp:
3542         (textMarkerRangeMatchesTextNearMarkersCallback):
3543         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3544         (AccessibilityUIElement::getJSClass):
3545         * DumpRenderTree/AccessibilityUIElement.h:
3546         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3547         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3548         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3549         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3550         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3551         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3552         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3553         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3554
3555 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
3556
3557         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
3558         https://bugs.webkit.org/show_bug.cgi?id=174197
3559
3560         Reviewed by Darin Adler.
3561
3562         This bit me the first time I tried to submit a patch to WebKit, and still I have
3563         to manually edit the ChangeLog every time I use the script.
3564
3565         This generates a more convenient and standard ChangeLog entry.
3566
3567         * Scripts/prepare-ChangeLog:
3568         (generateNewChangeLogs):
3569
3570 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3571
3572         Unreviewed, rolling out r219401.
3573
3574         This revision rolled out the previous patch, but after talking
3575         with reviewer, a rebaseline is what was needed.Rolling back in
3576         before rebaseline.
3577
3578         Reverted changeset:
3579
3580         "Unreviewed, rolling out r219379."
3581         https://bugs.webkit.org/show_bug.cgi?id=174400
3582         http://trac.webkit.org/changeset/219401
3583
3584 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3585
3586         Unreviewed, rolling out r219379.
3587
3588         This revision caused a consistent failure in the test
3589         fast/dom/Window/property-access-on-cached-window-after-frame-
3590         removed.html.
3591
3592         Reverted changeset:
3593
3594         "Remove NAVIGATOR_HWCONCURRENCY"
3595         https://bugs.webkit.org/show_bug.cgi?id=174400
3596         http://trac.webkit.org/changeset/219379
3597
3598 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3599
3600         [WPE] Use libepoxy
3601         https://bugs.webkit.org/show_bug.cgi?id=172104
3602
3603         Reviewed by Michael Catanzaro.
3604
3605         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
3606         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
3607
3608 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3609
3610         [GTK][WPE] Align Jhbuild patches for GStreamer packages
3611         https://bugs.webkit.org/show_bug.cgi?id=174363
3612
3613         Reviewed by Michael Catanzaro.
3614
3615         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
3616         between the GTK+ and WPE port. There's no reason for the two ports to apply
3617         different patches over same versions of GStreamer releases.
3618
3619         This aligns the two ports on this specific issue. Next we'll look into
3620         creating a single GStreamer-specific Jhbuild moduleset that will allow us
3621         to keep these patches in a single place, avoiding duplicate files.
3622
3623         * gtk/jhbuild.modules:
3624         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3625         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
3626         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3627         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
3628
3629 2017-07-11  Dean Jackson  <dino@apple.com>
3630
3631         Remove NAVIGATOR_HWCONCURRENCY
3632         https://bugs.webkit.org/show_bug.cgi?id=174400
3633
3634         Reviewed by Sam Weinig.
3635
3636         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3637
3638 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
3639
3640         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
3641         https://bugs.webkit.org/show_bug.cgi?id=174239
3642
3643         Reviewed by Brady Eidson.
3644
3645         Create windows with specific features set and make sure those are properly reflected in the
3646         WKWindowFeatures object.
3647
3648         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3649         (resetToConsistentState):
3650         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3651         (TEST):
3652
3653 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
3654
3655         Do not duplicate files when deleting directories with svn 1.9
3656         https://bugs.webkit.org/show_bug.cgi?id=174339
3657         <rdar://problem/33226781>
3658
3659         Reviewed by David Kilzer.
3660
3661         * Scripts/svn-create-patch:
3662         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
3663         (generateFileList): Determine which files are deleted because they are part of a
3664         directory being deleted.
3665
3666 2017-07-11  Dean Jackson  <dino@apple.com>
3667
3668         Rolling out r219372.
3669
3670         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3671
3672 2017-07-11  Dean Jackson  <dino@apple.com>
3673
3674         Remove NAVIGATOR_HWCONCURRENCY
3675         https://bugs.webkit.org/show_bug.cgi?id=174400
3676
3677         Reviewed by Sam Weinig.
3678
3679         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3680
3681 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3682
3683         Teach build workers to fetch archives from S3.
3684         https://bugs.webkit.org/show_bug.cgi?id=174384
3685
3686         Reviewed by Aakash Jain.
3687
3688         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3689         (DownloadBuiltProduct):
3690
3691 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3692
3693         Configure buildbot to transfer all archives to S3.
3694         Previously this was Mac only, but it's time to expand!
3695         https://bugs.webkit.org/show_bug.cgi?id=174378
3696         
3697         Reviewed by Aakash Jain.
3698
3699         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3700         (BuildFactory.__init__):
3701
3702 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
3703
3704         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
3705         https://bugs.webkit.org/show_bug.cgi?id=174350
3706
3707         Reviewed by Xabier Rodriguez-Calvar.
3708
3709         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
3710         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
3711         patches are removed. The patches for gst-plugins-good are updated, removing
3712         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
3713         rtpbin elements that will help with the EMEv3 development.
3714
3715         * wpe/jhbuild.modules:
3716         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
3717         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
3718         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
3719         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3720         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
3721         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3722         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
3723         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
3724         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
3725
3726 2017-07-10  John Wilander  <wilander@apple.com>
3727
3728         Resource Load Statistics: Prune statistics in orders of importance
3729         https://bugs.webkit.org/show_bug.cgi?id=174215
3730         <rdar://problem/33164403>
3731
3732         Reviewed by Chris Dumez.
3733
3734         Nest infrastructure. Adds these functions:
3735         1. testRunner.setStatisticsLastSeen()
3736         2. setStatisticsMaxStatisticsEntries()
3737         3. setStatisticsPruneEntriesDownTo()
3738
3739         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3740         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3741         (WTR::TestRunner::setStatisticsLastSeen):
3742         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
3743         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3744         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3745         * WebKitTestRunner/TestController.cpp:
3746         (WTR::TestController::setStatisticsLastSeen):
3747         (WTR::TestController::setMaxStatisticsEntries):
3748         (WTR::TestController::setPruneEntriesDownTo):
3749         * WebKitTestRunner/TestController.h:
3750         * WebKitTestRunner/TestInvocation.cpp:
3751         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3752         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3753         (WTR::TestController::setStatisticsLastSeen):
3754         (WTR::TestController::setStatisticsMaxStatisticsEntries):
3755         (WTR::TestController::setStatisticsPruneEntriesDownTo):
3756
3757 2017-07-03  Brian Burg  <bburg@apple.com>
3758
3759         Web Replay: remove some unused code
3760         https://bugs.webkit.org/show_bug.cgi?id=173903
3761
3762         Rubber-stamped by Joseph Pecoraro.
3763
3764         * Scripts/run-input-generator-tests: Removed.
3765         * Scripts/webkitpy/replay/__init__.py: Removed.
3766         * Scripts/webkitpy/replay/main.py: Removed.
3767
3768 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
3769
3770         [WPE] Fix layout test baseline and TestExpectations hierarchy
3771         https://bugs.webkit.org/show_bug.cgi?id=174092
3772
3773         Reviewed by Michael Catanzaro.
3774
3775         Like for the GTK+ port, override the default_baseline_search_path() and
3776         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
3777         Both methods operate on a short list of search paths that defaults to 'wpe' and
3778         'wk2', along with any other user-specified platform directory.
3779
3780         The test_expectations_file_position() method is overridden for testing purposes,
3781         and relevant unit tests are added.
3782
3783         * Scripts/webkitpy/port/wpe.py:
3784         (WPEPort._search_paths):
3785         (WPEPort):
3786         (WPEPort.default_baseline_search_path):
3787         (WPEPort._port_specific_expectations_files):
3788         (WPEPort.test_expectations_file_position):
3789         * Scripts/webkitpy/port/wpe_unittest.py:
3790         (WPEPortTest.test_default_baseline_search_path):
3791         (WPEPortTest):
3792         (WPEPortTest.test_port_specific_expectations_files):
3793
3794 2017-07-10  Chris Dumez  <cdumez@apple.com>
3795
3796         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
3797         https://bugs.webkit.org/show_bug.cgi?id=174301
3798
3799         Reviewed by Brent Fulgham.
3800
3801         Rename some of the testRunner API for clarity and to better match what it calls
3802         internally.
3803
3804         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3805         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3806         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
3807         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
3808         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3809         * WebKitTestRunner/TestController.cpp:
3810         (WTR::TestController::statisticsUpdateCookiePartitioning):
3811         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
3812         * WebKitTestRunner/TestController.h:
3813         * WebKitTestRunner/TestInvocation.cpp:
3814         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3815         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3816         (WTR::TestController::statisticsUpdateCookiePartitioning):
3817         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
3818
3819 2017-07-10  Charlie Turner  <cturner@igalia.com>
3820
3821         [GStreamer] Live twitch.tv videos do not play
3822         https://bugs.webkit.org/show_bug.cgi?id=174222
3823
3824         Reviewed by Michael Catanzaro.
3825
3826         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
3827         fixes videos not playing on twitch.tv.
3828
3829         * gtk/jhbuild.modules:
3830
3831 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
3832
3833         Add WebGL2 configuration option to build-webkit
3834         https://bugs.webkit.org/show_bug.cgi?id=174251
3835
3836         Reviewed by Michael Catanzaro.
3837
3838         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
3839         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
3840         is marked as enabled for the Apple Cocoa ports.
3841
3842 2017-07-08  Chris Dumez  <cdumez@apple.com>
3843
3844         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
3845         https://bugs.webkit.org/show_bug.cgi?id=174290
3846
3847         Reviewed by Brent Fulgham.
3848
3849         Rename testRunner API to match the new internal API names.
3850
3851         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3852         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3853         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
3854         (WTR::TestRunner::statisticsSubmitTelemetry):
3855         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3856         * WebKitTestRunner/TestController.cpp:
3857         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3858         (WTR::TestController::statisticsSubmitTelemetry):
3859         * WebKitTestRunner/TestController.h:
3860         * WebKitTestRunner/TestInvocation.cpp:
3861         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3862         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3863         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3864         (WTR::TestController::statisticsSubmitTelemetry):
3865
3866 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3867
3868         Drop NOSNIFF compile flag
3869         https://bugs.webkit.org/show_bug.cgi?id=174289
3870
3871         Reviewed by Michael Catanzaro.
3872
3873         * Scripts/webkitperl/FeatureList.pm:
3874         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3875
3876 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3877
3878         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
3879         https://bugs.webkit.org/show_bug.cgi?id=174219
3880         <rdar://problem/32083177>
3881
3882         Reviewed by Ryosuke Niwa.
3883
3884         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
3885         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
3886         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
3887         place.
3888
3889         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
3890         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
3891         no action is taken when dropping.
3892
3893         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
3894         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3895         (TestWebKitAPI::TEST):
3896         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3897         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3898         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
3899         (-[MockDragDropSession allowsMoveOperation]):
3900         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
3901         (-[MockDataInteractionSession initWithWindow:allowMove:]):
3902         (-[DataInteractionSimulator initWithWebView:]):
3903         (-[DataInteractionSimulator runFrom:to:]):
3904         (-[DataInteractionSimulator _advanceProgress]):
3905         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
3906         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
3907         (-[MockDataInteractionSession initWithWindow:]): Deleted.
3908
3909 2017-07-07  Commit Queue  <commit-queue@webkit.org>
3910
3911         Unreviewed, rolling out r219238, r219239, and r219241.
3912         https://bugs.webkit.org/show_bug.cgi?id=174265
3913
3914         "fast/workers/dedicated-worker-lifecycle.html is flaky"
3915         (Requested by yusukesuzuki on #webkit).
3916
3917         Reverted changesets:
3918
3919         "[WTF] Implement WTF::ThreadGroup"
3920         https://bugs.webkit.org/show_bug.cgi?id=174081
3921         http://trac.webkit.org/changeset/219238
3922
3923         "Unreviewed, build fix after r219238"
3924         https://bugs.webkit.org/show_bug.cgi?id=174081
3925         http://trac.webkit.org/changeset/219239
3926
3927         "Unreviewed, CLoop build fix after r219238"
3928         https://bugs.webkit.org/show_bug.cgi?id=174081
3929         http://trac.webkit.org/changeset/219241
3930
3931 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
3932
3933         [GTK][WPE] Enable X-Content-Type-Options: nosniff
3934         https://bugs.webkit.org/show_bug.cgi?id=174250
3935
3936         Reviewed by Carlos Alberto Lopez Perez.
3937
3938         * Scripts/webkitperl/FeatureList.pm:
3939
3940 2017-07-07  Charlie Turner  <cturner@igalia.com>
3941         [GStreamer] vid.me videos do not play
3942         https://bugs.webkit.org/show_bug.cgi?id=172240
3943
3944         Reviewed by Xabier Rodriguez-Calvar.
3945
3946         Build httpsoupsrc again for use in adaptive streaming pipelines, and
3947         have the existing libsoup build against GNOME to avoid header drift
3948         against GStreamer's linked Soup library.
3949
3950         * gtk/jhbuild.modules:
3951
3952 2017-07-06  Lucas Forschler  <lforschler@apple.com>
3953
3954         Write a support script to enable buildbot to upload to S3
3955         https://bugs.webkit.org/show_bug.cgi?id=174196
3956         
3957         Reviewed by Stephanie Lewis.
3958
3959         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
3960         (uploadToS3):
3961         (archiveExists):
3962
3963 2017-07-06  Lucas Forschler  <lforschler@apple.com>
3964
3965         Enabling uploading archives to S3.
3966         https://bugs.webkit.org/show_bug.cgi?id=174198
3967         
3968         Reviewed by Stephanie Lewis.
3969
3970         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3971         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
3972         (UploadMinifiedBuiltProduct): Upload minified archive to build master
3973         (TransferToS3): Transfer full and minified archives to S3
3974
3975 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3976
3977         [WTF] Implement WTF::ThreadGroup
3978         https://bugs.webkit.org/show_bug.cgi?id=174081
3979
3980         Reviewed by Mark Lam.
3981
3982         Add WTF::ThreadGroup tests.
3983
3984         * TestWebKitAPI/CMakeLists.txt:
3985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3986         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
3987         (TestWebKitAPI::TEST):
3988
3989 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3990
3991         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3992         https://bugs.webkit.org/show_bug.cgi?id=174150
3993
3994         Reviewed by Mark Lam.
3995
3996         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3997         (TestWebKitAPI::TEST):
3998         * TestWebKitAPI/TestsController.cpp:
3999         (TestWebKitAPI::TestsController::TestsController):
4000
4001 2017-07-06  Lucas Forschler  <lforschler@apple.com>
4002
4003         Enabling uploading archives to S3.
4004         https://bugs.webkit.org/show_bug.cgi?id=174198
4005         
4006         Reviewed by Lucas Forschler.
4007
4008         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4009         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
4010         (UploadMinifiedBuiltProduct): Upload minified archive to build master
4011         (TransferToS3): Transfer full and minified archives to S3
4012
4013 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4014
4015         [GTK][WPE] kill-old-process should kill more webkit related process
4016         https://bugs.webkit.org/show_bug.cgi?id=174220
4017
4018         Reviewed by Michael Catanzaro.
4019
4020         Generate list of possible webkit-related process names and add
4021         them to the list of process to kill.
4022         Also update the possible system related process for GTK+/WPE.
4023
4024         * BuildSlaveSupport/kill-old-processes:
4025         (listAllWebKitPrograms):
4026         (main):
4027
4028 2017-07-06  Chris Dumez  <cdumez@apple.com>
4029
4030         FileMonitor should not be ref counted
4031         https://bugs.webkit.org/show_bug.cgi?id=174166
4032
4033         Reviewed by Brent Fulgham.
4034
4035         Update the API tests to reflect the API change.
4036
4037         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
4038         (TestWebKitAPI::TEST_F):
4039
4040 2017-07-06  Commit Queue  <commit-queue@webkit.org>
4041
4042         Unreviewed, rolling out r219194.
4043         https://bugs.webkit.org/show_bug.cgi?id=174207
4044
4045         it broke some layout tests (Requested by clopez on #webkit).
4046
4047         Reverted changeset:
4048
4049         "[GStreamer] vid.me videos do not play"
4050         https://bugs.webkit.org/show_bug.cgi?id=172240
4051         http://trac.webkit.org/changeset/219194
4052
4053 2017-07-06  Matt Lewis  <jlewis3@apple.com>
4054
4055         Unreviewed, rolling out r219178.
4056
4057         This caused a consistent failure with the API test
4058         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
4059
4060         Reverted changeset:
4061
4062         "[WTF] Clean up StringStatics.cpp by using
4063         LazyNeverDestroyed<> for Atoms"
4064         https://bugs.webkit.org/show_bug.cgi?id=174150
4065         http://trac.webkit.org/changeset/219178
4066
4067 2017-07-06  Alicia Boya García  <aboya@igalia.com>
4068
4069         Add CWD to Perl library path (no longer the default since 5.26.0)
4070         https://bugs.webkit.org/show_bug.cgi?id=174200
4071
4072         Reviewed by Michael Catanzaro.
4073
4074         * Scripts/webkitpy/tool/commands/setupgitclone.py:
4075         (SetupGitClone._get_username_and_email):
4076
4077 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4078
4079         Unreviewed, update my email address.
4080
4081         * Scripts/webkitpy/common/config/contributors.json:
4082
4083 2017-07-06  Charlie Turner  <cturner@igalia.com>
4084         [GStreamer] vid.me videos do not play
4085         https://bugs.webkit.org/show_bug.cgi?id=172240
4086
4087         Reviewed by Xabier Rodriguez-Calvar.
4088
4089         Build httpsoupsrc again for use in adaptive streaming pipelines, and
4090         have the existing libsoup build against GNOME to avoid header drift
4091         against GStreamer's linked Soup library.
4092
4093         * gtk/jhbuild.modules:
4094
4095 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
4096
4097         [WTF] Move SoftLinking.h into WTF
4098         https://bugs.webkit.org/show_bug.cgi?id=174000
4099
4100         Reviewed by Alex Christensen.
4101
4102         * DumpRenderTree/mac/TestRunnerMac.mm:
4103         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4104         (test_primary_header):
4105         (ErrorCollector.__init__): Deleted.
4106         (ErrorCollector.__call__): Deleted.
4107         (ErrorCollector.results): Deleted.
4108         (ErrorCollector.result_list): Deleted.
4109         (ErrorCollector.verify_all_categories_are_seen): Deleted.
4110         (MockIo.open): Deleted.
4111         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
4112         (CppFunctionsTest.test_create_acronym): Deleted.
4113         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
4114         (CppFunctionsTest.test_parameter): Deleted.
4115         (CppFunctionsTest.test_single_line_view): Deleted.
4116         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
4117         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
4118         (CppFunctionsTest.test_parameter_list): Deleted.
4119         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
4120         (CppStyleTestBase.process_file_data): Deleted.
4121         (CppStyleTestBase.perform_lint): Deleted.
4122         (CppStyleTestBase.perform_single_line_lint): Deleted.
4123         (CppStyleTestBase.perform_multi_line_lint): Deleted.
4124         (CppStyleTestBase.perform_language_rules_check): Deleted.
4125         (CppStyleTestBase.perform_function_lengths_check): Deleted.
4126         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
4127         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
4128         (CppStyleTestBase.perform_include_what_you_use): Deleted.
4129         (CppStyleTestBase.perform_header_guard_check): Deleted.
4130         (CppStyleTestBase.assert_lint): Deleted.
4131         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
4132         (CppStyleTestBase.assert_multi_line_lint): Deleted.
4133         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
4134         (CppStyleTestBase.assert_language_rules_check): Deleted.
4135         (CppStyleTestBase.assert_include_what_you_use): Deleted.
4136         (CppStyleTestBase.assert_header_guard): Deleted.
4137         (CppStyleTestBase.assert_blank_lines_check): Deleted.
4138         (CppStyleTestBase.assert_positions_equal): Deleted.
4139         (FunctionDetectionTest.test_basic_function_detection): Deleted.
4140         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
4141         (FunctionDetectionTest.test_pure_function_detection): Deleted.
4142         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
4143         (FunctionDetectionTest.test_ignore_macros): Deleted.
4144         (FunctionDetectionTest.test_non_functions): Deleted.
4145         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
4146         (FunctionDetectionTest.test_parameter_list): Deleted.
4147         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
4148         (CppStyleTest.test_asm_lines_ignored): Deleted.
4149         (CppStyleTest.test_get_line_width): Deleted.
4150         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
4151         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
4152         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
4153         (CppStyleTest.test_position): Deleted.
4154         (CppStyleTest.test_rfind_in_lines): Deleted.
4155         (CppStyleTest.test_close_expression): Deleted.
4156         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
4157         (CppStyleTest.test_cstyle_cast): Deleted.
4158         (CppStyleTest.test_runtime_casting): Deleted.
4159         (CppStyleTest.test_runtime_selfinit): Deleted.
4160         (CppStyleTest.test_runtime_rtti): Deleted.
4161         (CppStyleTest.test_static_cast_readability): Deleted.
4162         (CppStyleTest.test_check_for_unnamed_params): Deleted.
4163         (CppStyleTest.void): Deleted.
4164         (CppStyleTest.test_deprecated_cast): Deleted.
4165         (CppStyleTest.test_mock_method): Deleted.
4166         (CppStyleTest.test_sizeof_type): Deleted.
4167         (CppStyleTest.cases): Deleted.
4168         (CppStyleTest.for): Deleted.
4169         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
4170         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
4171         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
4172         (CppStyleTest.test_include_what_you_use): Deleted.
4173         (CppStyleTest.test_files_belong_to_same_module): Deleted.
4174         (CppStyleTest.test_cleanse_line): Deleted.
4175         (CppStyleTest.test_multi_line_comments): Deleted.
4176         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
4177         (CppStyleTest.test_multiline_strings): Deleted.
4178         (CppStyleTest.test_platformh_comments): Deleted.
4179         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
4180         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
4181         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
4182         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
4183         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
4184         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
4185         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
4186         (CppStyleTest.test_check_posix_threading): Deleted.
4187         (CppStyleTest.test_insecure_string_operations): Deleted.
4188         (CppStyleTest.test_format_strings): Deleted.
4189         (CppStyleTest.test_insecure_temp_file): Deleted.
4190         (CppStyleTest.test_variable_length_array_detection): Deleted.
4191         (CppStyleTest.test_braces): Deleted.
4192         (CppStyleTest.test_check_check): Deleted.
4193         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
4194         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
4195         (CppStyleTest.test_spacing_for_fncall): Deleted.
4196         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
4197         (CppStyleTest.test_spacing_before_braces): Deleted.
4198         (CppStyleTest.test_spacing_between_braces): Deleted.
4199         (CppStyleTest.test_spacing_before_brackets): Deleted.
4200         (CppStyleTest.test_cpp_lambda_functions): Deleted.
4201         (CppStyleTest.test_objective_c_block): Deleted.
4202         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
4203         (CppStyleTest.test_spacing_around_else): Deleted.
4204         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
4205         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
4206         (CppStyleTest.test_operator_methods): Deleted.
4207         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
4208         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
4209         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
4210         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
4211         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
4212         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
4213         (CppStyleTest.test_space_after_comment_marker): Deleted.
4214         (CppStyleTest.test_newline_at_eof): Deleted.
4215         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
4216         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
4217         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
4218         (CppStyleTest.test_invalid_utf8): Deleted.
4219         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
4220         (CppStyleTest.test_is_blank_line): Deleted.
4221         (CppStyleTest.test_blank_lines_check): Deleted.
4222         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
4223         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
4224         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
4225         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
4226         (CppStyleTest.test_comma): Deleted.
4227         (CppStyleTest.test_declaration): Deleted.
4228         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
4229         (CppStyleTest.test_indent): Deleted.
4230         (CppStyleTest.test_indent.Foo): Deleted.
4231         (CppStyleTest.test_not_alabel): Deleted.
4232         (CppStyleTest.test_tab): Deleted.
4233         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
4234         (CppStyleTest.test_build_class): Deleted.
4235         (CppStyleTest.test_build_class.definitions): Deleted.
4236         (CppStyleTest.test_build_class.Foo): Deleted.
4237         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
4238         (CppStyleTest.test_build_end_comment): Deleted.
4239         (CppStyleTest.test_build_forward_decl): Deleted.
4240         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
4241         (CppStyleTest.test_build_header_guard): Deleted.
4242         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
4243         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
4244         (CppStyleTest.test_build_printf_format): Deleted.
4245         (CppStyleTest.test_runtime_printf_format): Deleted.
4246         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
4247         (CppStyleTest.test_build_storage_class): Deleted.
4248         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
4249         (CppStyleTest.test_build_storage_class.declaration): Deleted.
4250         (CppStyleTest.test_build_storage_class.after): Deleted.
4251         (CppStyleTest.test_build_storage_class.is): Deleted.
4252         (CppStyleTest.test_legal_copyright): Deleted.
4253         (CppStyleTest.test_invalid_increment): Deleted.
4254         (CppStyleTest.test_enum_bitfields): Deleted.
4255         (CppStyleTest.test_plain_integral_bitfields): Deleted.
4256         (CleansedLinesTest.test_init_empty): Deleted.
4257         (CleansedLinesTest.test_collapse_strings): Deleted.
4258         (OrderOfIncludesTest.tearDown): Deleted.
4259         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.