78f8e852289eb523acf2eca298aa3f826ee35dd3
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-18  Ryan Haddad  <ryanhaddad@apple.com>
2
3         Unreviewed, rolling out r220938.
4
5         The API tests added with this change are failing.
6
7         Reverted changeset:
8
9         "Add WTFLogChannel level to allow runtime log filtering"
10         https://bugs.webkit.org/show_bug.cgi?id=175731
11         http://trac.webkit.org/changeset/220938
12
13 2017-08-18  Devin Rousso  <webkit@devinrousso.com>
14
15         Unreviewed, change my email.
16
17         * Scripts/webkitpy/common/config/contributors.json:
18
19 2017-08-18  Jonathan Bedard  <jbedard@apple.com>
20
21         Fix leak-checking for iOS Simulators
22         https://bugs.webkit.org/show_bug.cgi?id=175735
23
24         Reviewed by Darin Adler.
25
26         If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
27         Simulator (or device) because the process will have already been killed by the time we
28         check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.
29
30         * Scripts/webkitpy/port/server_process.py:
31         (ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
32         (ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
33         and SimulatorProcess.
34         * Scripts/webkitpy/port/simulator_process.py:
35         (SimulatorProcess.stop): Before closing the process, check for leaks.
36
37 2017-08-18  Eric Carlson  <eric.carlson@apple.com>
38
39         Add WTFLogChannel level to allow runtime log filtering
40         https://bugs.webkit.org/show_bug.cgi?id=175731
41         <rdar://problem/33967234>
42
43         Reviewed by Jer Noble.
44
45         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
46         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
47         (TestWebKitAPI::LoggingTest::output):
48         (TestWebKitAPI::TEST_F):
49
50 2017-08-18  Alexey Proskuryakov  <ap@apple.com>
51
52         Add Dean Johnson to contributors.json for Bugzilla autocomplete.
53
54         * Scripts/webkitpy/common/config/contributors.json:
55
56 2017-08-18  Ross Kirsling  <ross.kirsling@sony.com>
57
58         [Tools] Add script to download a GitHub release
59         https://bugs.webkit.org/show_bug.cgi?id=175279
60
61         Reviewed by Brent Fulgham.
62
63         * Scripts/download-latest-github-release.py: Added.
64
65 2017-08-18  Commit Queue  <commit-queue@webkit.org>
66
67         Unreviewed, rolling out r220854.
68         https://bugs.webkit.org/show_bug.cgi?id=175716
69
70         I'm not sure we really need this (Requested by KaL on
71         #webkit).
72
73         Reverted changeset:
74
75         "[GTK][WPE] Add NTLM authentication enabled API"
76         https://bugs.webkit.org/show_bug.cgi?id=122952
77         http://trac.webkit.org/changeset/220854
78
79 2017-08-17  Michael Catanzaro  <mcatanzaro@igalia.com>
80
81         [GTK] Make TestContextMenu work on Fedora
82         https://bugs.webkit.org/show_bug.cgi?id=175708
83
84         Reviewed by Carlos Garcia Campos.
85
86         TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
87         and my student last summer who was trying to work on a context menu API. It's trying to load
88         an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
89         entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
90         don't care to investigate. Let's switch it to WebM so I can move on.
91
92         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
93         (prepareContextMenuTestView):
94         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
95         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
96
97 2017-08-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
98
99         check-webkit-style shouldn't check spacing in #elif preprocessor lines
100         https://bugs.webkit.org/show_bug.cgi?id=175652
101
102         Reviewed by Alex Christensen.
103
104         * Scripts/webkitpy/style/checkers/cpp.py:
105         (check_spacing):
106         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
107         (CppStyleTest.test_spacing_for_binary_ops):
108
109 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
110
111         Fix the build on other platforms after r220865
112         https://bugs.webkit.org/show_bug.cgi?id=175683
113
114         Reviewed by Tim Horton.
115
116         Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
117         availability is determined by SDK version rather than deployment version.
118
119         * TestWebKitAPI/ios/UIKitSPI.h:
120
121 2017-08-17  Andreas Kling  <akling@apple.com>
122
123         Disable CSS regions at compile time
124         https://bugs.webkit.org/show_bug.cgi?id=175630
125
126         Reviewed by Antti Koivisto.
127
128         * Scripts/webkitperl/FeatureList.pm:
129         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
130
131 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
132
133         Unreviewed, try to fix the internal iOS 10 build after r220865.
134
135         * TestWebKitAPI/ios/UIKitSPI.h:
136
137         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
138         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
139         this compiler guard.
140
141 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
142
143         [iOS] Respect type fidelities when copying image elements to the pasteboard
144         https://bugs.webkit.org/show_bug.cgi?id=175638
145         <rdar://problem/26556043>
146
147         Reviewed by Ryosuke Niwa.
148
149         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
150         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
151         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
152
153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
154         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
155         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
156         (TestWebKitAPI::TEST):
157         (TestWebKitAPI::presentActionSheetAndChooseAction):
158         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
159         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
160         (checkEstimatedSize):
161         (checkSuggestedNameAndEstimatedSize):
162
163         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
164
165         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
166         (TestWebKitAPI::TEST):
167         * TestWebKitAPI/ios/DataInteractionSimulator.h:
168         * TestWebKitAPI/ios/UIKitSPI.h: Added.
169
170 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
171
172         Recursively create resource load statistics folder for testing
173         https://bugs.webkit.org/show_bug.cgi?id=175676
174
175         Reviewed by Brady Eidson.
176
177         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
178         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
179
180 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
181
182         [GTK][WPE] Add NTLM authentication enabled API
183         https://bugs.webkit.org/show_bug.cgi?id=122952
184
185         Reviewed by Michael Catanzaro.
186
187         Add a test case to check we can enable/disable NTLM.
188
189         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
190         (testWebViewAuthenticationNTLM):
191         (beforeAll):
192
193 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
194
195         [PAL] Move spi/ios and spi/win directories into PAL
196         https://bugs.webkit.org/show_bug.cgi?id=175171
197
198         Reviewed by Antti Koivisto.
199
200         * DumpRenderTree/mac/EventSendingController.mm:
201
202 2017-08-16  Andy Estes  <aestes@apple.com>
203
204         [Payment Request] Add an ENABLE flag and an experimental feature preference
205         https://bugs.webkit.org/show_bug.cgi?id=175622
206
207         Reviewed by Tim Horton.
208
209         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
210         * WebKitTestRunner/TestController.cpp:
211         (WTR::TestController::resetPreferencesToConsistentValues):
212
213 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
214
215         undefined URL in PopoverTracker for failed step
216         https://bugs.webkit.org/show_bug.cgi?id=175593
217         <rdar://problem/33898769>
218
219         Reviewed by Daniel Bates.
220
221         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
222         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
223
224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
225         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
226         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
228         (BuildbotTestResults): Accept URL in constructor.
229
230 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
231
232         Remove Proximity Events and related code
233         https://bugs.webkit.org/show_bug.cgi?id=175545
234
235         Reviewed by Daniel Bates.
236
237         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
238         and other related code.
239
240         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
241
242 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
243
244         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
245         https://bugs.webkit.org/show_bug.cgi?id=175504
246
247         Reviewed by Sam Weinig.
248
249         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
250
251 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
252
253         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
254         https://bugs.webkit.org/show_bug.cgi?id=175557
255
256         Reviewed by Jon Lee.
257         
258         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
259
260         * DumpRenderTree/TestRunner.cpp:
261         (TestRunner::staticFunctions):
262         (setViewModeMediaFeatureCallback): Deleted.
263         * DumpRenderTree/TestRunner.h:
264         * DumpRenderTree/mac/TestRunnerMac.mm:
265         (TestRunner::setViewModeMediaFeature): Deleted.
266         * DumpRenderTree/win/TestRunnerWin.cpp:
267         (TestRunner::setViewModeMediaFeature): Deleted.
268         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
269
270 2017-08-14  Andy Estes  <aestes@apple.com>
271
272         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
273         https://bugs.webkit.org/show_bug.cgi?id=175548
274         <rdar://problem/33866206>
275
276         Reviewed by Brady Eidson.
277
278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
279         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
280         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
281
282 2017-08-14  Youenn Fablet  <youenn@apple.com>
283
284         WPT server should be able to do logging even if its output folder is not created at launch time
285         https://bugs.webkit.org/show_bug.cgi?id=175543
286
287         Reviewed by Alexey Proskuryakov.
288
289         Removing no longer used stdout/stderr member variables.
290         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
291
292         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
293         (WebPlatformTestServer.__init__):
294         (WebPlatformTestServer._prepare_config):
295         (WebPlatformTestServer._spawn_process):
296         (WebPlatformTestServer._stop_running_server):
297
298 2017-08-14  Daniel Bates  <dabates@apple.com>
299
300         webkit-patch: Passing --no-review should submit patch to EWS by default
301         https://bugs.webkit.org/show_bug.cgi?id=148899
302
303         Reviewed by David Kilzer.
304
305         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
306         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
307         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
308
309         Frequently I want to post a draft of a patch without review to have the EWS bots process
310         it to catch build and test breakage before I clean it up and post it for formal review.
311         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
312         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
313         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
314
315         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
316         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
317         parse the attachment id from the response page after adding an attachment to the bug.
318         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
319         HTTP response after uploading the patch.
320         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
321         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
322         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
323         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
324         * Scripts/webkitpy/tool/commands/upload.py:
325         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
326         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
327         this command.
328         (PostCommits.execute): Submit the patch to EWS, if applicable.
329         * Scripts/webkitpy/tool/commands/upload_unittest.py:
330         (test_upload): Set options.ews to False as the upload command expects this option
331         to be specified.
332         (test_upload_with_no_review_and_ews): Added.
333         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
334         * Scripts/webkitpy/tool/steps/options.py:
335         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
336         * Scripts/webkitpy/tool/steps/postdiff.py:
337         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
338         this command.
339         (PostDiff.run): Submit the patch to EWS, if applicable.
340         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
341         (SubmitToEWS):
342         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
343         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
344
345 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
346
347         Disable two flaky VideoControlsManager API tests.
348
349         Unreviewed test gardening.
350
351         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
352         (TestWebKitAPI::TEST):
353
354 2017-08-14  Tim Horton  <timothy_horton@apple.com>
355
356         Only create directory and sandbox extension handle for storage directories if they are set
357         https://bugs.webkit.org/show_bug.cgi?id=175522
358
359         Reviewed by Brady Eidson.
360
361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
362         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
363         (TEST):
364         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
365         doesn't log anything to stderr.
366
367 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
368
369         sub-categorize Sandbox violation logs
370         https://bugs.webkit.org/show_bug.cgi?id=175536
371         <rdar://problem/33834416>
372
373         Reviewed by David Kilzer.
374
375         * Scripts/webkitpy/common/system/crashlogs.py:
376         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
377         a Sandbox violation.
378         (CrashLogs._find_all_logs_darwin): Update comment.
379         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
380         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
381         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
382         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
383         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
384         * Scripts/webkitpy/port/darwin.py:
385         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
386
387 2017-08-14  Daniel Bates  <dabates@apple.com>
388
389         Add Automator service to copy permalink to Clipboard
390         https://bugs.webkit.org/show_bug.cgi?id=170978
391
392         Reviewed by Joseph Pecoraro.
393
394         It is helpful to reference using a hyperlink a particular line of code when having
395         a discussion on IRC or in a bug. You can get such a link by navigating to the file
396         in the Trac Browse Source viewer and selecting the line your are interested in.
397         I found myself doing this often enough that I wrote an Automator service to do it
398         for me.
399
400         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
401
402         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
403         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
404         * CopyPermalink/README: Added.
405
406 2017-08-14  Chris Dumez  <cdumez@apple.com>
407
408         Address flakiness related to download tests
409         https://bugs.webkit.org/show_bug.cgi?id=175338
410         <rdar://problem/33865119>
411
412         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
413         between tests.
414
415         * WebKitTestRunner/TestController.cpp:
416         (WTR::TestController::resetStateToConsistentValues):
417
418 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
419
420         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
421         https://bugs.webkit.org/show_bug.cgi?id=175474
422         <rdar://problem/33844628>
423
424         Reviewed by Wenson Hsieh.
425
426         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
427
428         * DumpRenderTree/mac/DumpRenderTree.mm:
429         (resetWebPreferencesToConsistentValues):
430         * WebKitTestRunner/TestController.cpp:
431         (WTR::TestController::resetPreferencesToConsistentValues):
432
433 2017-08-12  Chris Dumez  <cdumez@apple.com>
434
435         Address flakiness related to download tests
436         https://bugs.webkit.org/show_bug.cgi?id=175338
437
438         Reviewed by Ryosuke Niwa.
439
440         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
441           is actually queried when a download completes. Previously, this would be
442           identical to a call to testRunner.waitUntilDone() because any download
443           completion would call testRunner.notifyDone().
444         - Disable logging of download callbacks by default and add a
445           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
446           enable such logging.
447
448         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
449         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
450         (WTR::InjectedBundle::didReceiveMessageToPage):
451         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
452         (WTR::TestRunner::setShouldLogDownloadCallbacks):
453         * WebKitTestRunner/InjectedBundle/TestRunner.h:
454         * WebKitTestRunner/TestController.cpp:
455         (WTR::TestController::downloadDidStart):
456         (WTR::TestController::decideDestinationWithSuggestedFilename):
457         (WTR::TestController::downloadDidFinish):
458         (WTR::TestController::downloadDidFail):
459         (WTR::TestController::downloadDidCancel):
460         * WebKitTestRunner/TestController.h:
461         (WTR::TestController::setShouldLogDownloadCallbacks):
462         * WebKitTestRunner/TestInvocation.cpp:
463         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
464
465 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
466
467         Create mock ITP data in testing to prevent grandfathering
468         https://bugs.webkit.org/show_bug.cgi?id=174720
469
470         Unreviewed follow-up fix for r220604.
471
472         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
473         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
474
475 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
476
477         Create mock ITP data in testing to prevent grandfathering
478         https://bugs.webkit.org/show_bug.cgi?id=174720
479         <rdar://problem/33457779>
480
481         Reviewed by Brent Fulgham.
482
483         We don't need to be triggering grandfathering when each test runner starts. On Mac,
484         this may launch plugins which can cause layout tests to fail later if the test
485         runner does not shut-down before the plugins unload.
486
487         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
488         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
489         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
490         prevent grandfathering from being triggered.
491         * WebKitTestRunner/ios/TestControllerIOS.mm:
492         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
493         * WebKitTestRunner/mac/TestControllerMac.mm:
494         (WTR::TestController::platformInitialize): Ditto.
495
496 2017-08-11  Sam Weinig  <sam@webkit.org>
497
498         WTF::Function does not allow for reference / non-default constructible return types
499         https://bugs.webkit.org/show_bug.cgi?id=175244
500         <rdar://problem/33801582>
501
502         Reviewed by Chris Dumez.
503
504         * TestWebKitAPI/Tests/WTF/Function.cpp:
505         (TestWebKitAPI::TEST):
506
507 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
508
509         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
510         https://bugs.webkit.org/show_bug.cgi?id=175378
511
512         Reviewed by Sergio Villar Senin.
513
514         Add two test cases to check proxy authentication.
515
516         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
517         (Tunnel::Tunnel):
518         (Tunnel::~Tunnel):
519         (Tunnel::connect):
520         (Tunnel::connected):
521         (serverCallback):
522         (ProxyAuthenticationTest::ProxyAuthenticationTest):
523         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
524         (ProxyAuthenticationTest::proxyServerPortAsString):
525         (testWebViewAuthenticationProxy):
526         (testWebViewAuthenticationProxyHTTPS):
527         (beforeAll):
528
529 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
530
531         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
532         https://bugs.webkit.org/show_bug.cgi?id=175428
533
534         Both ports share the GStreamer code as multimedia backend and till
535         not so long they were using different versions. Now they do use
536         the same versions and it does not make any sense anymore (and
537         neither had sense before) to have differences in the modulesets.
538
539         In this patch I created a GStreamer moduleset and referenced it
540         from both GTK+'s and WPE's. GStreamer patches were also moved there.
541
542         Reviewed by Žan Doberšek.
543
544         * gstreamer/jhbuild.modules: Added.
545         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
546         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
547         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
548         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
549         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
550         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
551         * gtk/jhbuild.modules:
552         * wpe/jhbuild.modules:
553         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
554         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
555         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
556         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
557         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
558
559 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
560
561         Unreviewed, adding Ross Kirsling to contributors.json
562
563         * Scripts/webkitpy/common/config/contributors.json:
564
565 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
566
567         Unreviewed, attempt to fix build failure with VC2017
568
569         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
570         (TEST):
571
572 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
573
574         Unreviewed, suppress warnings on GCC
575
576         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
577         (TestWebKitAPI::CheckedArithmeticTester::run):
578
579 2017-08-10  Dan Bernstein  <mitz@apple.com>
580
581         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
582         https://bugs.webkit.org/show_bug.cgi?id=173223
583
584         Reviewed by Tim Horton.
585
586         The rebuilds were happening due to a difference in the compiler options that the IDE and
587         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
588         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
589         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
590         Advanced when a Custom Absolute path is selected.
591
592         * Scripts/webkitdirs.pm:
593         (determineBaseProductDir):
594
595 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
596
597         Run more WTF tests
598         https://bugs.webkit.org/show_bug.cgi?id=174970
599
600         Reviewed by Michael Catanzaro.
601
602         Some of WTF tests are not executed in non Apple ports while they are generic ones.
603         This patch adds these tests to non-Apple port TestWebKitAPI.
604         Currently, we do not add Signals.cpp since it depends on signal functionality.
605
606         * TestWebKitAPI/CMakeLists.txt:
607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
608         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
609         (isHigherPriority):
610         (TEST):
611         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
612         (TEST):
613         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
614         (TEST):
615
616 2017-08-10  obinna obike  <oobike@apple.com>
617
618         Remove obsolete link from webkit-queues status page
619         https://bugs.webkit.org/show_bug.cgi?id=175337
620
621         Reviewed by Aakash Jain.
622
623         * QueueStatusServer/templates/recentstatus.html:
624         Removed the link to the ews-watcher server.
625
626 2017-08-10  Brian Burg  <bburg@apple.com>
627
628         WKPreferences should conform to NSCopying
629         https://bugs.webkit.org/show_bug.cgi?id=175303
630         <rdar://problem/33764939>
631
632         Reviewed by Dan Bernstein.
633
634         Add unit test to make sure a WKPreference and its copy are
635         not aliased to each other or affect each other's properties.
636
637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
638         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
639         (TEST):
640
641 2017-08-10  Tim Horton  <timothy_horton@apple.com>
642
643         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
644         https://bugs.webkit.org/show_bug.cgi?id=175436
645         <rdar://problem/33667497>
646
647         Reviewed by Simon Fraser.
648
649         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
650         (TestWebKitAPI::TEST_F):
651
652 2017-08-10  Lucas Forschler  <lforschler@apple.com>
653
654         Fix duplicated code in r220534.
655
656         Unreviewed cleanup.
657
658         * Scripts/bisect-builds:
659
660 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
661
662         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
663         https://bugs.webkit.org/show_bug.cgi?id=175344
664         <rdar://problem/28507240>
665
666         Reviewed by Alexey Proskuryakov.
667
668         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
669         Finally enable the existing tests for iOS.
670
671         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
672         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
673         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
674         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
675
676 2017-08-10  Lucas Forschler  <lforschler@apple.com>
677
678         Write a tool to bisect WebKit builds
679         https://bugs.webkit.org/show_bug.cgi?id=174596
680
681         Reviewed by Dean Johnson and Kocsen Chung.
682
683         * Scripts/bisect-builds: Added.
684         (bisect_builds): main bisection algorithm
685         (download_archive):download an archive from S3 using existing tools
686         (extract_archive):extract an archive using existing tools
687         (find_le):Find rightmost value less than or equal to x
688         (find_ge):Find leftmost item greater than or equal to x
689         (get_api_url):generate url for the rest api/database
690         (get_indices_from_revisions):convert revisions to list indexes for bisection
691         (get_sorted_revisions):retrieve sorted revision list
692         (get_s3_location_for_revision):calculate the S3 archive storage location
693         (parse_args):parse command line arguments
694         (pick_next_build):compute the next build to bisect
695         (prompt_did_reproduce):prompt user for direction for bisection
696         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
697         (test_archive):Platform specific logic to test downloaded archive
698         (minified_platforms):return a list of minified platforms in the database
699         (unminified_platforms):return a list of full platforms in the database
700         (is_supported_platform):check if platform is supported
701         (validate_options):validate command line options
702         (main):
703
704 2017-08-10  Lucas Forschler  <lforschler@apple.com>
705
706         Remove bisect-builds script.
707         https://bugs.webkit.org/show_bug.cgi?id=175433
708         
709         Reviewed by Aakash Jain.
710
711         * Scripts/bisect-builds: Removed.
712
713 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
714
715         Remove ENABLE_GAMEPAD_DEPRECATED
716         https://bugs.webkit.org/show_bug.cgi?id=175361
717
718         Reviewed by Carlos Garcia Campos.
719
720         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
721
722 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
723
724         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
725         https://bugs.webkit.org/show_bug.cgi?id=175426
726
727         Reviewed by Carlos Garcia Campos.
728
729         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
730
731 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
732
733         Add Ms2ger as contributor.
734         https://bugs.webkit.org/show_bug.cgi?id=175325
735
736         Reviewed by Carlos Alberto Lopez Perez.
737
738         * Scripts/webkitpy/common/config/contributors.json:
739
740 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
741
742         Fix run-benchmark after r220483.
743         https://bugs.webkit.org/show_bug.cgi?id=175415
744         <rdar://problem/33803003>
745
746         Reviewed by Ryosuke Niwa.
747
748         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
749
750         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
751         (WebServerBenchmarkRunner._run_one_test):
752
753 2017-08-09  Chris Dumez  <cdumez@apple.com>
754
755         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
756         https://bugs.webkit.org/show_bug.cgi?id=175401
757
758         Reviewed by Brady Eidson.
759
760         * DumpRenderTree/mac/DumpRenderTree.mm:
761         (enableExperimentalFeatures):
762
763 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
764
765         [PAL] Move spi/cocoa and spi/cg directories into PAL
766         https://bugs.webkit.org/show_bug.cgi?id=175175
767
768         Reviewed by Myles C. Maxfield.
769
770         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
771         * DumpRenderTree/mac/DumpRenderTree.mm:
772         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
773         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
774
775         * Scripts/webkitpy/style/checker.py:
776         * Scripts/webkitpy/style/checker_unittest.py:
777         (GlobalVariablesTest.test_path_rules_specifier):
778
779         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
780
781         * Scripts/webkitpy/style/checkers/cpp.py:
782         (check_braces):
783         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
784         (WebKitStyleTest.test_braces.CF_OPTIONS):
785         (WebKitStyleTest.test_braces):
786
787         Prevent CF_OPTIONS() from being handled as funtion definition.
788
789 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
790
791         [WTF] Move TextStream into WTF
792         https://bugs.webkit.org/show_bug.cgi?id=175211
793
794         Reviewed by Myles C. Maxfield.
795
796         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
797
798 2017-08-09  Andy Estes  <aestes@apple.com>
799
800         Part 3 of: Rename DatabaseProcess to StorageProcess
801         https://bugs.webkit.org/show_bug.cgi?id=175034
802
803         Reviewed by Brady Eidson.
804
805         * WebKitTestRunner/TestController.cpp:
806         (WTR::TestController::databaseProcessName): Updated to return
807         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
808
809 2017-08-09  Commit Queue  <commit-queue@webkit.org>
810
811         Unreviewed, rolling out r220466, r220477, and r220487.
812         https://bugs.webkit.org/show_bug.cgi?id=175411
813
814         This change broke existing API tests and follow up fixes did
815         not resolve all the issues. (Requested by ryanhaddad on
816         #webkit).
817
818         Reverted changesets:
819
820         https://bugs.webkit.org/show_bug.cgi?id=175244
821         http://trac.webkit.org/changeset/220466
822
823         "WTF::Function does not allow for reference / non-default
824         constructible return types"
825         https://bugs.webkit.org/show_bug.cgi?id=175244
826         http://trac.webkit.org/changeset/220477
827
828         https://bugs.webkit.org/show_bug.cgi?id=175244
829         http://trac.webkit.org/changeset/220487
830
831 2017-08-09  Sam Weinig  <sam@webkit.org>
832
833         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
834
835         Remove one addition of null Function test.
836
837 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
838
839         Allow nested timeouts in webkitpy
840         https://bugs.webkit.org/show_bug.cgi?id=175390
841         <rdar://problem/33803003>
842
843         Reviewed by David Kilzer.
844
845         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
846         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
847         the executive to detect and recover from any issues connecting with devices.
848
849         * Scripts/webkitpy/benchmark_runner/utils.py:
850         (TimeoutError): Deleted.
851         (timeout): Deleted.
852         * Scripts/webkitpy/common/timeout_context.py: Added.
853         (Timeout): A timeout context designed to be nested.
854         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
855         (Timeout.TimeoutData.__init__):
856         (Timeout.default_handler): Timeout handler used if none is specified.
857         (Timeout.current): Access data about the most urgent timeout.
858         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
859         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
860         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
861         urgent timeout data.
862         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
863         most urgent timeout data, if such data exists.
864         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
865         (TimeoutContextTests):
866         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
867         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
868         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
869         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
870         over a less urgent outer timeout.
871         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
872         over a less urgent inner timeout.
873         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
874         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
875         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
876         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
877         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
878         * Scripts/webkitpy/port/simulator_process.py:
879         (SimulatorProcess._start): Use Timeout class.
880         * Scripts/webkitpy/xcode/simulated_device.py:
881         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
882         (SimulatedDevice.launch_app): Ditto.
883         (SimulatedDevice.launch_app._install_timeout): Deleted.
884         * Scripts/webkitpy/xcode/simulator.py:
885         (Simulator.wait_until_device_is_booted):Use Timeout class.
886         (Simulator.wait_until_device_is_in_state): Ditto.
887
888 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
889
890         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
891         https://bugs.webkit.org/show_bug.cgi?id=175392
892         <rdar://problem/33783207>
893
894         Reviewed by Tim Horton and Megan Gardner.
895
896         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
897
898         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
899
900 2017-08-09  Sam Weinig  <sam@webkit.org>
901
902         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
903
904         * TestWebKitAPI/Tests/WTF/Function.cpp:
905         Remove tests of null Functions, as they are no longer supported.
906
907 2017-08-09  Daniel Bates  <dabates@apple.com>
908
909         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
910         https://bugs.webkit.org/show_bug.cgi?id=175247
911         <rdar://problem/33679804>
912
913         Reviewed by Brady Eidson.
914
915         Add tests for redirects.
916
917         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
918         (TEST):
919         * TestWebKitAPI/cocoa/TestProtocol.mm:
920         (createRedirectURL):
921         (-[TestProtocol startLoading]):
922
923 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
924
925         Unreviewed, rolling out r220393.
926
927         This patch regresses the performance of WebPage::editorState.
928
929         Reverted changeset:
930
931         "[iOS WK2] WKWebView schedules nonstop layout after pressing
932         cmb+b,i,u inside a contenteditable div"
933         https://bugs.webkit.org/show_bug.cgi?id=175116
934         http://trac.webkit.org/changeset/220393
935
936 2017-08-08  obinna obike  <oobike@apple.com>
937
938         Created Individual EWS Pages
939         https://bugs.webkit.org/show_bug.cgi?id=174477
940
941         Reviewed by Aakash Jain.
942
943         Created individual pages for each EWS. Changed the link within each status bubble
944         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
945
946         * QueueStatusServer/handlers/patch.py:
947         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
948         * QueueStatusServer/handlers/statusbubble.py:
949         (StatusBubble._build_bubble): Updated url for specific EWS.
950         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
951         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
952         all ews queues.
953         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
954         takes you directly to the individual ews page.
955
956 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
957
958         Separate jsc stress test script writer from run-jsc-stress-tests
959         https://bugs.webkit.org/show_bug.cgi?id=175216
960
961         Reviewed by Mark Lam.
962
963         * Scripts/run-jsc-stress-tests:
964         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
965
966 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
967
968         Unreviewed, fix Ubuntu LTS build
969         https://bugs.webkit.org/show_bug.cgi?id=174490
970
971         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
972
973 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
974
975         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
976         https://bugs.webkit.org/show_bug.cgi?id=175302
977         <rdar://problem/33762116>
978
979         Reviewed by Tim Horton.
980
981         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
982         See WebKit ChangeLog for more details.
983
984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
985         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
986         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
987         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
988         (-[SlowTextInputContext handleEvent:completionHandler:]):
989         (-[SlowInputWebView inputContext]):
990         (-[SlowInputWebView _web_superInputContext]):
991         (TEST):
992
993 2017-08-08  John Wilander  <wilander@apple.com>
994
995         Resource Load Statistics: Clear web processes' state on history removal
996         https://bugs.webkit.org/show_bug.cgi?id=175271
997         <rdar://problem/33756560>
998
999         Reviewed by Chris Dumez.
1000
1001         Test infrastructure for asynchronous tests of website data
1002         removal for _WKWebsiteDataTypeResourceLoadStatistics.
1003
1004         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1005         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1006         (WTR::InjectedBundle::didReceiveMessageToPage):
1007         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1008         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1009         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
1010         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1011         * WebKitTestRunner/TestController.cpp:
1012         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1013         * WebKitTestRunner/TestController.h:
1014         * WebKitTestRunner/TestInvocation.cpp:
1015         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1016         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
1017         * WebKitTestRunner/TestInvocation.h:
1018         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1019         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1020
1021 2017-08-08  Alicia Boya García  <aboya@igalia.com>
1022
1023         Add Alicia Boya García as contributor
1024         https://bugs.webkit.org/show_bug.cgi?id=175326
1025
1026         Reviewed by Michael Catanzaro.
1027
1028         * Scripts/webkitpy/common/config/contributors.json:
1029
1030 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1031
1032         [CMake] Properly test if compiler supports compiler flags
1033         https://bugs.webkit.org/show_bug.cgi?id=174490
1034
1035         Reviewed by Konstantin Tokarev.
1036
1037         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1038         * MiniBrowser/gtk/CMakeLists.txt:
1039         * TestRunnerShared/Bindings/JSWrapper.cpp:
1040         (WTR::JSWrapper::initialize):
1041         * TestWebKitAPI/CMakeLists.txt:
1042         * TestWebKitAPI/PlatformGTK.cmake:
1043         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1044         (TestWebKitAPI::CheckedArithmeticTester::run):
1045         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1046         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1047         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1048         (formControlsAssociatedCallback):
1049         * TestWebKitAPI/glib/CMakeLists.txt:
1050         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1051         (Test::getResourcesDir):
1052         * WebKitTestRunner/CMakeLists.txt:
1053         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1054         (WTR::menuItemClickCallback):
1055         (WTR::staticConvertMenuItemToType):
1056         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1057         (WTR::TestRunner::setUseDashboardCompatibilityMode):
1058         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1059         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1060         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1061         (WTR::AccessibilityUIElement::helpText const):
1062         (WTR::AccessibilityUIElement::attributedStringForRange):
1063         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1064         (WTR::EventSenderProxy::updateTouchPoint):
1065         (WTR::EventSenderProxy::releaseTouchPoint):
1066
1067 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1068
1069         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
1070         https://bugs.webkit.org/show_bug.cgi?id=175116
1071         <rdar://problem/28279301>
1072
1073         Reviewed by Darin Adler and Ryosuke Niwa.
1074
1075         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
1076         EditorStateTests run on both iOS and Mac.
1077
1078         * TestWebKitAPI/EditingTestHarness.h: Added.
1079         * TestWebKitAPI/EditingTestHarness.mm: Added.
1080
1081         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
1082         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
1083         the state of the latest observed EditorState.
1084
1085         (-[EditingTestHarness initWithWebView:]):
1086         (-[EditingTestHarness dealloc]):
1087         (-[EditingTestHarness webView]):
1088         (-[EditingTestHarness latestEditorState]):
1089         (-[EditingTestHarness editorStateHistory]):
1090         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
1091         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
1092         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
1093         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
1094         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
1095         (-[EditingTestHarness toggleBold]):
1096         (-[EditingTestHarness toggleItalic]):
1097         (-[EditingTestHarness toggleUnderline]):
1098         (-[EditingTestHarness setForegroundColor:]):
1099         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
1100         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
1101         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
1102         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
1103         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
1104         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
1105         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
1106
1107         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
1108         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
1109         keys and values.
1110
1111         (-[EditingTestHarness latestEditorStateContains:]):
1112         (-[EditingTestHarness _webView:editorStateDidChange:]):
1113         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1114         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
1115         (TestWebKitAPI::setUpEditorStateTestHarness):
1116         (TestWebKitAPI::TEST):
1117         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
1118
1119 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
1120
1121         Prevent domain from being set to a TLD
1122         https://bugs.webkit.org/show_bug.cgi?id=175226
1123         <rdar://problem/11079948>
1124
1125         Reviewed by Chris Dumez.
1126
1127         Extend the public suffix tests to include cases used by the
1128         Public Domain 'Public Suffix List'.
1129
1130         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
1131         (TestWebKitAPI::TEST):
1132
1133 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
1134
1135         [XCode] webkit-patch should run sort-Xcode-project-file
1136         https://bugs.webkit.org/show_bug.cgi?id=174036
1137         <rdar://problem/33732709>
1138
1139         Reviewed by Simon Fraser.
1140
1141         * Scripts/webkitpy/common/config/ports.py:
1142         * Scripts/webkitpy/tool/commands/download.py:
1143         * Scripts/webkitpy/tool/commands/download_unittest.py:
1144         * Scripts/webkitpy/tool/commands/upload.py:
1145         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1146         * Scripts/webkitpy/tool/steps/__init__.py:
1147         * Scripts/webkitpy/tool/steps/options.py:
1148         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1149
1150 2017-08-07  Devin Rousso  <drousso@apple.com>
1151
1152         Web Inspector: Preview Canvas path when viewing a recording
1153         https://bugs.webkit.org/show_bug.cgi?id=174967
1154
1155         Reviewed by Brian Burg.
1156
1157         * DumpRenderTree/TestOptions.h:
1158         * DumpRenderTree/TestOptions.mm:
1159         (TestOptions::TestOptions):
1160         * DumpRenderTree/mac/DumpRenderTree.mm:
1161         (setWebPreferencesForTestOptions):
1162         * WebKitTestRunner/TestController.cpp:
1163         (WTR::TestController::resetPreferencesToConsistentValues):
1164         (WTR::updateTestOptionsFromTestHeader):
1165         * WebKitTestRunner/TestOptions.h:
1166         (WTR::TestOptions::hasSameInitializationOptions const):
1167         Add plumbing for new InspectorAdditions runtime flag.
1168
1169 2017-08-07  obinna obike  <oobike@apple.com>
1170
1171         Sorted EWS Queues on Patch page
1172         https://bugs.webkit.org/show_bug.cgi?id=173667
1173
1174         Reviewed by Aakash Jain.
1175
1176         * QueueStatusServer/handlers/patch.py:
1177         (Patch.get): Sorted queue_status.
1178         * QueueStatusServer/templates/patch.html:
1179         Changed queue_status.items to queue_status because it's a list.
1180
1181 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1182
1183         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
1184         https://bugs.webkit.org/show_bug.cgi?id=175286
1185
1186         Reviewed by Myles C. Maxfield.
1187
1188         * Scripts/webkitpy/style/checkers/cpp.py:
1189         (check_braces):
1190         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1191         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
1192         (WebKitStyleTest.test_braces):
1193         (WebKitStyleTest.test_braces.NS_OPTIONS):
1194
1195 2017-08-07  Brian Burg  <bburg@apple.com>
1196
1197         Remove CANVAS_PATH compilation guard
1198         https://bugs.webkit.org/show_bug.cgi?id=175207
1199
1200         Reviewed by Sam Weinig.
1201
1202         * Scripts/webkitperl/FeatureList.pm:
1203         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1204
1205 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
1206
1207         [Win] Use Visual Studio 2017 if installed.
1208         https://bugs.webkit.org/show_bug.cgi?id=175188
1209
1210         Reviewed by Sam Weinig.
1211
1212         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
1213
1214         * Scripts/webkitdirs.pm:
1215         (visualStudioInstallDir):
1216         (msBuildInstallDir):
1217
1218 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1219
1220         [GTK][WPE] Add API to provide browser information required by automation
1221         https://bugs.webkit.org/show_bug.cgi?id=175130
1222
1223         Reviewed by Michael Catanzaro.
1224
1225         * MiniBrowser/gtk/main.c:
1226         (automationStartedCallback): Set browser information when a new automation session is started.
1227         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1228         (testAutomationSessionApplicationInfo):
1229         (beforeAll):
1230
1231 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
1232
1233         Unreviewed, rolling out r220295.
1234
1235         This change introduced 4 errors in webkitpy tests.
1236
1237         Reverted changeset:
1238
1239         "[XCode] webkit-patch should run sort-Xcode-project-file"
1240         https://bugs.webkit.org/show_bug.cgi?id=174036
1241         http://trac.webkit.org/changeset/220295
1242
1243 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1244
1245         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
1246
1247         Unreviewed test gardening.
1248
1249         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1250         (TestWebKitAPI::TEST):
1251
1252 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
1253
1254         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
1255         https://bugs.webkit.org/show_bug.cgi?id=175083
1256
1257         Reviewed by Oliver Hunt.
1258         
1259         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
1260         to wait for VM destructions to finish before running the next test. This makes it easier to 
1261         understand leaks results from workers tests, and leads to fewer reported leaks.
1262
1263         * DumpRenderTree/mac/DumpRenderTree.mm:
1264         (runTest):
1265
1266 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1267
1268         check-webkit-style: fix path-specific rules for WebKit2 rename
1269         https://bugs.webkit.org/show_bug.cgi?id=175182
1270
1271         Reviewed by David Kilzer.
1272
1273         * Scripts/webkitpy/style/checker.py:
1274
1275 2017-08-04  Youenn Fablet  <youenn@apple.com>
1276
1277         [Cache API] Add Cache and CacheStorage IDL definitions
1278         https://bugs.webkit.org/show_bug.cgi?id=175201
1279
1280         Reviewed by Brady Eidson.
1281
1282         * DumpRenderTree/mac/DumpRenderTree.mm:
1283         (enableExperimentalFeatures):
1284         (resetWebPreferencesToConsistentValues):
1285         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1286         (WTR::InjectedBundle::beginTesting):
1287         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1288         (WTR::TestRunner::setCacheAPIEnabled):
1289         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1290
1291 2017-08-04  John Wilander  <wilander@apple.com>
1292
1293         Resource Load Statistics: Report user interaction immediately, but only when needed
1294         https://bugs.webkit.org/show_bug.cgi?id=175090
1295         <rdar://problem/33685546>
1296
1297         Reviewed by Chris Dumez.
1298
1299         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1300         (WTR::InjectedBundle::beginTesting):
1301             Now calls WebCore::ResourceLoadObserver::clearState().
1302
1303 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1304
1305         Add an API test for r220286
1306         https://bugs.webkit.org/show_bug.cgi?id=175206
1307
1308         Reviewed by Simon Fraser.
1309
1310         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1311         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1312         (createAnimatedResizeWebView):
1313         (TEST):
1314         Add a test to ensure that we don't call
1315         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1316         animated resize.
1317
1318 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1319
1320         [XCode] webkit-patch should run sort-Xcode-project-file
1321         https://bugs.webkit.org/show_bug.cgi?id=174036
1322
1323         Reviewed by Simon Fraser.
1324
1325         * Scripts/webkitpy/common/config/ports.py:
1326         * Scripts/webkitpy/tool/commands/download.py:
1327         * Scripts/webkitpy/tool/commands/upload.py:
1328         * Scripts/webkitpy/tool/steps/__init__.py:
1329         * Scripts/webkitpy/tool/steps/options.py:
1330         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1331
1332 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1333
1334         REGRESSION(r219857): run-benchmark --allplans broken
1335         https://bugs.webkit.org/show_bug.cgi?id=175186
1336
1337         Reviewed by Saam Barati.
1338
1339         r219857 forgot to update also the calls to BenchmarkRunner() that
1340         is done when the script is run with --allplans.
1341
1342         To fix this (and avoid future issues like this), let's factorize
1343         the calls to the benchhmark runner in a run_benchmark_plan()
1344         function.
1345
1346         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1347         (run_benchmark_plan):
1348         (start):
1349
1350 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1351
1352         Dashboard bubbles sometimes show failure count instead of crash count
1353         https://bugs.webkit.org/show_bug.cgi?id=175157
1354         <rdar://problem/33709009>
1355
1356         Reviewed by Alexey Proskuryakov.
1357
1358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1359         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1360
1361 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1362
1363         Add tests for NeverDestroyed
1364         https://bugs.webkit.org/show_bug.cgi?id=175146
1365
1366         Reviewed by Darin Adler.
1367
1368         * CMakeLists.txt:
1369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1370         New files and sort.
1371
1372         * TestWebKitAPI/Tests/WTF/Logger.h:
1373         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1374         (TestWebKitAPI::log):
1375         (TestWebKitAPI::takeLogStr):
1376         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1377         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1378         (TestWebKitAPI::log): Deleted.
1379         (TestWebKitAPI::takeLogStr): Deleted.
1380         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1381
1382         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1383         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1384         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1385         (TestWebKitAPI::LifecycleLogger::operator=):
1386         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1387         (TestWebKitAPI::LifecycleLogger::setName):
1388         (TestWebKitAPI::TEST):
1389         Add a class that logs construction / assignment / modifications.
1390
1391         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1392         (TestWebKitAPI::TEST):
1393         (TestWebKitAPI::list):
1394         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1395
1396 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1397
1398         minification logic is not implemented for ios builds
1399         <rdar://problem/33726561>
1400
1401         Reviewed by Dean Johnson
1402
1403         * BuildSlaveSupport/built-product-archive:
1404         (minifyDirectory): refactor minifySource -> minifyDirectory
1405         (archiveBuiltProduct): add ios minification logic
1406         (minifySource): Deleted.
1407
1408 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1409
1410         Unreviewed, rolling out r220271.
1411
1412         Rolling out due to Layout Test failing on iOS Simulator.
1413
1414         Reverted changeset:
1415
1416         "Remove STREAMS_API compilation guard"
1417         https://bugs.webkit.org/show_bug.cgi?id=175165
1418         http://trac.webkit.org/changeset/220271
1419
1420 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1421
1422         Unreviewed, rolling out r220268.
1423
1424         This change caused assertion failures on macOS and iOS Debug
1425         WK2.
1426
1427         Reverted changeset:
1428
1429         "Resource Load Statistics: Report user interaction
1430         immediately, but only when needed"
1431         https://bugs.webkit.org/show_bug.cgi?id=175090
1432         http://trac.webkit.org/changeset/220268
1433
1434 2017-08-04  Youenn Fablet  <youenn@apple.com>
1435
1436         Remove STREAMS_API compilation guard
1437         https://bugs.webkit.org/show_bug.cgi?id=175165
1438
1439         Reviewed by Darin Adler.
1440
1441         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1442
1443 2017-08-04  John Wilander  <wilander@apple.com>
1444
1445         Resource Load Statistics: Report user interaction immediately, but only when needed
1446         https://bugs.webkit.org/show_bug.cgi?id=175090
1447         <rdar://problem/33685546>
1448
1449         Reviewed by Chris Dumez.
1450
1451         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1452         (WTR::InjectedBundle::beginTesting):
1453             Now calls WebCore::ResourceLoadObserver::clearState().
1454
1455 2017-08-03  Brian Burg  <bburg@apple.com>
1456
1457         Remove ENABLE(WEB_SOCKET) guards
1458         https://bugs.webkit.org/show_bug.cgi?id=167044
1459
1460         Reviewed by Joseph Pecoraro.
1461
1462         * Scripts/webkitperl/FeatureList.pm:
1463         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1464
1465 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1466
1467         REGRESSION(r219850): run-benchmark script broken on Linux
1468         https://bugs.webkit.org/show_bug.cgi?id=175126
1469
1470         Reviewed by Stephanie Lewis.
1471
1472         The run-benchmark script dynamically generates the list of supported
1473         browsers and platforms (currently Linux and OSX) by loading all
1474         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1475         and getting the browser_name and platform variables from the
1476         classes defined there.
1477
1478         This means that this classes should not raise an exception when
1479         loaded on other platforms or otherwise they will broke the whole
1480         script. Its fine if they raise an exception when executing any of
1481         the methods they implement, but not when just loading/importing
1482         the class.
1483
1484         Move the argument variable definitions that call on the platform
1485         specific OSXBrowserDriver._screen_size() function from beeing
1486         variables that are evaluated when loading the file, to be functions
1487         that are only evaluated when the actual functionality needs to be
1488         executed.
1489
1490         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1491         (OSXChromeDriver.launch_url):
1492         (OSXChromeCanaryDriver.launch_url):
1493         (create_args):
1494         (create_chrome_options):
1495         (create_window_size_arg):
1496         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1497         (OSXFirefoxDriver.launch_url):
1498         (OSXFirefoxNightlyDriver.launch_url):
1499         (OSXFirefoxNightlyDriver.launch_driver):
1500         (create_args):
1501
1502 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1503
1504         [PAL] Move spi/cf directory into PAL
1505         https://bugs.webkit.org/show_bug.cgi?id=175057
1506
1507         Reviewed by Antti Koivisto.
1508
1509         * Scripts/webkitpy/style/checker.py:
1510         * Scripts/webkitpy/style/checker_unittest.py:
1511         (GlobalVariablesTest.test_path_rules_specifier):
1512
1513         Ignore "readability/naming/underscores" style errors for sources
1514         under the WebCore/PAL/pal/spi directory.
1515
1516         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1517
1518 2017-08-03  Youenn Fablet  <youenn@apple.com>
1519
1520         Remove FETCH_API compilation guard
1521         https://bugs.webkit.org/show_bug.cgi?id=175154
1522
1523         Reviewed by Chris Dumez.
1524
1525         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1526
1527 2017-08-03  Lucas Forschler  <lforschler@apple.com>
1528
1529         Enable archive minification on iOS builds
1530         https://bugs.webkit.org/show_bug.cgi?id=174718
1531         
1532         Reviewed by Aakash Jain.
1533
1534         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1535         (BuildFactory.__init__):
1536
1537 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1538
1539         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
1540         https://bugs.webkit.org/show_bug.cgi?id=175140
1541
1542         Reviewed by Alexey Proskuryakov.
1543
1544         We are having lately issues with JSC tests causing problems on
1545         the GTK+ and WPE bots due to the high amount of memory some tests
1546         need to run.
1547
1548         The best thing we can do now is to workaround this by disabling
1549         all the tests marked as memoryLimited on the GTK and WPE bots.
1550         We may revise this on the future.
1551
1552         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1553         (RunJavaScriptCoreTests.start):
1554
1555 2017-08-03  Brady Eidson  <beidson@apple.com>
1556
1557         Add SW IDLs and stub out basic functionality.
1558         https://bugs.webkit.org/show_bug.cgi?id=175115
1559
1560         Reviewed by Chris Dumez.
1561
1562         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1563
1564         * Scripts/webkitpy/bindings/main.py:
1565
1566 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
1567
1568         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
1569         https://bugs.webkit.org/show_bug.cgi?id=159510
1570
1571         Reviewed by Daniel Bates.
1572
1573         Allow any https certificate when running tests.
1574
1575         * DumpRenderTree/win/DumpRenderTree.cpp:
1576         (runTest):
1577
1578 2017-08-02  Youenn Fablet  <youenn@apple.com>
1579
1580         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
1581         https://bugs.webkit.org/show_bug.cgi?id=175089
1582
1583         Reviewed by Chris Dumez.
1584
1585         * DumpRenderTree/TestOptions.mm:
1586         (TestOptions::TestOptions): Using absolutePath if available.
1587         * DumpRenderTree/mac/DumpRenderTree.mm:
1588         (computeTestURL): Removing http/tests/ specific URL computation.
1589         * Scripts/webkitpy/port/driver.py:
1590         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
1591
1592 2017-08-02  Lucas Forschler  <lforschler@apple.com>
1593
1594         download-built-product should allow for a proxy option
1595         https://bugs.webkit.org/show_bug.cgi?id=174875
1596
1597         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
1598
1599         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1600         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
1601         
1602
1603 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1604
1605         check-webkit-style: deleting lines in a file runs the linter on the whole file
1606         https://bugs.webkit.org/show_bug.cgi?id=175078
1607
1608         Reviewed by David Kilzer.
1609
1610         Deleting lines in a file should not cause linter errors to be blamed on the patch.
1611         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
1612
1613         * Scripts/webkitpy/style/checkers/test_expectations.py:
1614         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
1615         * Scripts/webkitpy/style/main_unittest.py:
1616         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
1617         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
1618         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
1619
1620 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1621
1622         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
1623         https://bugs.webkit.org/show_bug.cgi?id=175075
1624
1625         Reviewed by David Kilzer.
1626
1627         We have no way of handling text files with illegal unicode characters. Allow the callers of
1628         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
1629         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
1630
1631         * Scripts/webkitpy/common/system/filesystem.py:
1632         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
1633         (FileSystem.write_text_file): Ditto.
1634         * Scripts/webkitpy/common/system/filesystem_mock.py:
1635         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
1636         (MockFileSystem.write_text_file): Ditto.
1637         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1638         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
1639         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
1640
1641 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
1642
1643         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
1644         https://bugs.webkit.org/show_bug.cgi?id=175072
1645
1646         Reviewed by Alexey Proskuryakov.
1647
1648         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1649         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
1650
1651 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1652
1653         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
1654         https://bugs.webkit.org/show_bug.cgi?id=175019
1655
1656         Reviewed by Darin Adler.
1657
1658         * TestWebKitAPI/CMakeLists.txt:
1659
1660 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1661
1662         Enabling uploading archives to S3
1663         https://bugs.webkit.org/show_bug.cgi?id=174198
1664
1665         Unreviewed unit test fix after r219235.
1666
1667         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1668
1669 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1670
1671         Fix JSCOnly ARM buildbots after r220047
1672         https://bugs.webkit.org/show_bug.cgi?id=174993
1673
1674         Unreviewed fix after r220087.
1675
1676         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1677         (BuildAndRemoteJSCTestsFactory.__init__):
1678
1679 2017-08-01  Chris Dumez  <cdumez@apple.com>
1680
1681         Add initial support for navigator.sendBeacon
1682         https://bugs.webkit.org/show_bug.cgi?id=175007
1683         <rdar://problem/33547728>
1684
1685         Reviewed by Sam Weinig.
1686
1687         Enable the Beacon API at runtime in the context of layout tests since the
1688         feature is currently disabled by default.
1689
1690         * DumpRenderTree/mac/DumpRenderTree.mm:
1691         (enableExperimentalFeatures):
1692         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1693         (WTR::InjectedBundle::beginTesting):
1694         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1695         (WTR::TestRunner::setModernMediaControlsEnabled):
1696         (WTR::TestRunner::setBeaconAPIEnabled):
1697         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1698
1699 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
1700
1701         Update Bot Watcher's Dashboard for Buildbot 0.9
1702         https://bugs.webkit.org/show_bug.cgi?id=174777
1703
1704         Reviewed by Daniel Bates.
1705
1706         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1707         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
1708         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
1709         in a dictionary.
1710         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
1711         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
1712         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1713         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
1714         (parseRevisionProperty): Ditto.
1715         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
1716         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
1717         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
1718         have changed in Buildbot 0.9.
1719         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
1720         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
1721         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
1722         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
1723         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
1724         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
1725         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
1726         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
1727         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
1728         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
1729         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1730         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
1731         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
1732         (BuildbotQueue.prototype.get overviewURL): Ditto.
1733         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
1734         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
1735         Buildbot 0.8 or 0.9.
1736         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
1737         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
1738         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
1739         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
1740         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
1741         Therefore we are fetching information for fixed number of build. 
1742         Also iterating the loop incrementally since the build data is already reverse sorted.
1743         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1744         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
1745         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
1746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1747         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
1748
1749 2017-08-01  Devin Rousso  <drousso@apple.com>
1750
1751         Web Inspector: simplify WebInspector with WI
1752         https://bugs.webkit.org/show_bug.cgi?id=175058
1753
1754         Reviewed by Joseph Pecoraro.
1755
1756         * Scripts/check-inspector-strings:
1757         (extract_ui_strings):
1758         * Scripts/extract-localizable-js-strings:
1759
1760 2017-08-01  Youenn Fablet  <youenn@apple.com>
1761
1762         Layout tests with 'https' suffix should be run over HTTPS
1763         https://bugs.webkit.org/show_bug.cgi?id=174992
1764
1765         Reviewed by Chris Dumez.
1766
1767         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
1768         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
1769         Covered by corresponding unit tests.
1770
1771         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1772         (run_server):
1773         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1774         (base_http_url):
1775         (base_https_url):
1776         (base_url): Deleted.
1777         * Scripts/webkitpy/port/base.py:
1778         (Port.to.web_platform_test_server_base_http_url):
1779         (Port.to):
1780         (Port.to.web_platform_test_server_base_https_url):
1781         (Port.to.web_platform_test_server_base_url): Deleted.
1782         * Scripts/webkitpy/port/driver.py:
1783         (Driver.__init__):
1784         (Driver.wpt_test_path_to_uri):
1785         (Driver):
1786         (Driver.http_test_path_to_uri):
1787         (Driver.test_to_uri):
1788         (Driver.uri_to_test):
1789         * Scripts/webkitpy/port/driver_unittest.py:
1790         (DriverTest.test_test_to_uri):
1791         (DriverTest.test_uri_to_test):
1792
1793 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1794
1795         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
1796         https://bugs.webkit.org/show_bug.cgi?id=173998
1797
1798         Reviewed by Darin Adler.
1799
1800         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
1801         detect mistakes in backward compatibility in the future when we change it.
1802
1803         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
1804         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
1805         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
1806         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
1807         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
1808         internal key data slot.
1809
1810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1811         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
1812         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
1813         (getNextMessage):
1814         (TEST):
1815         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
1816         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
1817         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
1818         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
1819         These are the pre-baked databases.
1820         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
1821         This is the actual test that do all the reads and comparisons.
1822         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
1823         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
1824         IndexedDB new stuffs. Then it can be used to bake the database again.
1825
1826 2017-08-01  Brady Eidson  <beidson@apple.com>
1827
1828         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
1829         https://bugs.webkit.org/show_bug.cgi?id=175030
1830
1831         Reviewed by Andy Estes.
1832
1833         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1834         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
1835
1836 2017-08-01  Brady Eidson  <beidson@apple.com>
1837
1838         Part 2 of: Rename DatabaseProcess to StorageProcess.
1839         https://bugs.webkit.org/show_bug.cgi?id=174880
1840
1841         Reviewed by Andy Estes.
1842
1843         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1844         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1845         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1846         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1847         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1848         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1849         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1850         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1851
1852 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
1853
1854         Fix JSCOnly ARM buildbots after r220047
1855         https://bugs.webkit.org/show_bug.cgi?id=174993
1856
1857         Reviewed by Saam Barati.
1858
1859         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1860         (BuildAndRemoteJSCTestsFactory.__init__):
1861
1862 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1863
1864         [WTF] Introduce Private Symbols
1865         https://bugs.webkit.org/show_bug.cgi?id=174935
1866
1867         Reviewed by Darin Adler.
1868
1869         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1870         (TestWebKitAPI::TEST):
1871
1872 2017-07-30  Darin Adler  <darin@apple.com>
1873
1874         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
1875         https://bugs.webkit.org/show_bug.cgi?id=130653
1876
1877         Reviewed by Antti Koivisto.
1878
1879         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1880         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
1881         when calling frameDidChangeLocation.
1882         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
1883         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
1884         thus causing mysterious failures of a couple of tests. There are two remaining issues:
1885         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
1886         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
1887         same logic flaw that causes "top loading frame" to get set to one of the subframes in
1888         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
1889         loading, subframe starts loading. It would be good to clean that up some day, but for now
1890         this patch makes the two work identically rather than changing both.
1891         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
1892
1893 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1894
1895         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
1896         https://bugs.webkit.org/show_bug.cgi?id=174963
1897
1898         Reviewed by Darin Adler.
1899
1900         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
1901         RetainPtr<>. This patch changes them to all use auto.
1902
1903         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1904         (TestWebKitAPI::TEST):
1905
1906 2017-07-30  Brady Eidson  <beidson@apple.com>
1907
1908         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
1909         https://bugs.webkit.org/show_bug.cgi?id=174958
1910
1911         Reviewed by Darin Adler.
1912
1913         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1914         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
1915         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
1916         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
1917         (runUntilTasksInFlight):
1918         (TEST):
1919
1920 2017-07-28  Commit Queue  <commit-queue@webkit.org>
1921
1922         Unreviewed, rolling out r219990.
1923         https://bugs.webkit.org/show_bug.cgi?id=174961
1924
1925         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
1926         estes on #webkit).
1927
1928         Reverted changeset:
1929
1930         "Part 2 of: Rename DatabaseProcess to StorageProcess."
1931         https://bugs.webkit.org/show_bug.cgi?id=174880
1932         http://trac.webkit.org/changeset/219990
1933
1934 2017-07-28  Brady Eidson  <beidson@apple.com>
1935
1936         API tests that use URLSchemeHandler are failing.
1937         https://bugs.webkit.org/show_bug.cgi?id=174950
1938
1939         Reviewed by Alex Christensen.
1940
1941         Fix the NoMIMEType test to be correct.
1942
1943         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1944         (-[SchemeHandler initWithData:mimeType:]):
1945         (-[SchemeHandler webView:startURLSchemeTask:]):
1946         (TEST):
1947
1948 2017-07-28  Daniel Bates  <dabates@apple.com>
1949
1950         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
1951         https://bugs.webkit.org/show_bug.cgi?id=174876
1952
1953         Reviewed by Alex Christensen.
1954
1955         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
1956         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
1957         they provide a more direct way to test the platform abstraction.
1958
1959         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
1960
1961         * Scripts/prepare-ChangeLog:
1962         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
1963         of the current working directory.
1964
1965 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
1966
1967         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1968         https://bugs.webkit.org/show_bug.cgi?id=174930
1969
1970         Unreviewed test fix.
1971
1972         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
1973
1974         * Scripts/prepare-ChangeLog:
1975         (get_function_line_ranges_for_cpp):
1976
1977 2017-07-28  JF Bastien  <jfbastien@apple.com>
1978
1979         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1980         https://bugs.webkit.org/show_bug.cgi?id=174930
1981
1982         Reviewed by Daniel Bates.
1983
1984         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
1985         here also teach it about const and volatile overloads. I didn't do
1986         reference and rvalue reference overloads because we don't really
1987         use them, and the current parser throws away those characters and
1988         it doesn't seem worth making it more complex.
1989
1990         * Scripts/prepare-ChangeLog:
1991         (get_function_line_ranges_for_cpp):
1992         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1993         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1994         (Foo::Arrow::arrow):
1995         (Foo::Arrow::otherArrow):
1996         (Foo::Arrow::otherArrow const):
1997         (Foo::Arrow::otherArrow volatile):
1998         (Foo::Arrow::otherArrow const volatile):
1999
2000 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
2001
2002         [GTK] Building with ENABLE_VIDEO=OFF fails
2003         https://bugs.webkit.org/show_bug.cgi?id=174940
2004
2005         Reviewed by Alex Christensen.
2006
2007         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
2008         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
2009
2010         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2011         (methodCallCallback): Add missing USE(GSTREAMER) guard.
2012
2013 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
2014
2015         [WPE] Implement EventSenderProxy in WTR
2016         https://bugs.webkit.org/show_bug.cgi?id=173419
2017
2018         Reviewed by Žan Doberšek.
2019
2020         Add the implementation of EventSenderProxy to the WTR. This
2021         allows us to extend the coverage of the test suite in WKWPE.
2022
2023         * WebKitTestRunner/EventSenderProxy.h:
2024         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
2025         libxkbcommon needed to deal with key events.
2026         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2027         (WTR::EventSenderProxy::EventSenderProxy):
2028         (WTR::senderButtonToWPEButton):
2029         (WTR::EventSenderProxy::mouseDown):
2030         (WTR::EventSenderProxy::mouseUp):
2031         (WTR::EventSenderProxy::mouseMoveTo):
2032         (WTR::EventSenderProxy::mouseScrollBy):
2033         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2034         (WTR::EventSenderProxy::leapForward):
2035         (WTR::wkEventModifiersToWPE):
2036         (WTR::getXKBKeySymForKeyRef):
2037         (WTR::EventSenderProxy::keyDown):
2038         (WTR::EventSenderProxy::addTouchPoint):
2039         (WTR::EventSenderProxy::updateTouchPoint):
2040         (WTR::EventSenderProxy::setTouchModifier):
2041         (WTR::EventSenderProxy::setTouchPointRadius):
2042         (WTR::EventSenderProxy::getUpdatedTouchEvents):
2043         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
2044         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2045         (WTR::EventSenderProxy::touchStart):
2046         (WTR::EventSenderProxy::touchMove):
2047         (WTR::EventSenderProxy::touchEnd):
2048         (WTR::EventSenderProxy::touchCancel):
2049         (WTR::EventSenderProxy::clearTouchPoints):
2050         (WTR::EventSenderProxy::releaseTouchPoint):
2051         (WTR::EventSenderProxy::cancelTouchPoint):
2052
2053 2017-07-27  Brady Eidson  <beidson@apple.com>
2054
2055         Part 2 of: Rename DatabaseProcess to StorageProcess.
2056         https://bugs.webkit.org/show_bug.cgi?id=174880
2057
2058         Reviewed by Andy Estes.
2059
2060         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2061         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2062         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2063         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2064         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2065         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2066         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2067         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2068
2069 2017-07-26  Mark Lam  <mark.lam@apple.com>
2070
2071         Add ability to only run specific tests in run-javascriptcore-tests.
2072         https://bugs.webkit.org/show_bug.cgi?id=174884
2073
2074         Reviewed by Saam Barati.
2075
2076         For example, if we only want to run testapi, we can do so as follows:
2077             $ run-javascriptcore-tests --testapi
2078
2079         Previously, specifying --testapi effectively does nothing because we run all tests
2080         by default.  Only --no-testapi had the effect of disabling the test set.  This
2081         old behavior for --testapi is not very useful or meaningful.  We're now changing
2082         it to mean that we will only run that test.
2083
2084         With this change, we can also run more than one set of tests.  For example, if we
2085         only want to run testmasm and testair, we can do so as follows:
2086             $ run-javascriptcore-tests --testmasm --testair
2087
2088         By default, if no specific test option is specified, run-javascriptcore-tests will
2089         run all tests.
2090
2091         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
2092         the mozilla tests (--mozilla-tests) even though both are run via the lower level
2093         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
2094         the other set will not run.  For example, the following only runs the mozilla tests:
2095             $ run-javascriptcore-tests --mozilla-tests
2096
2097         Note also that --jit-stress-tests is not for choosing a different set of tests.
2098         Instead, it is used for determining whether we run JIT'ed test configurations
2099         on the jsc stress tests and mozilla tests.  As a result, specifying
2100         --jit-stress-tests will not omit other tests.  For example, the following still
2101         runs all tests:
2102             $ run-javascriptcore-tests --jit-stress-tests
2103
2104         * Scripts/run-javascriptcore-tests:
2105         (defaultStringForTestState):
2106         (enableTestOrNot):
2107         (runJSCStressTests):
2108
2109 2017-07-26  Mark Lam  <mark.lam@apple.com>
2110
2111         Make run-javascriptcore-test run testair, testb3, and testmasm.
2112         https://bugs.webkit.org/show_bug.cgi?id=174837
2113         <rdar://problem/33522927>
2114
2115         Reviewed by Saam Barati and Filip Pizlo.
2116
2117         1. Refactors code for running testapi so that we can use it to run other tests.
2118         2. Added running of testmasm, testair, testb3.
2119
2120         Note: the existing testapi invocation code does not support remote invocation of
2121         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
2122         and testb3 also do not support remote invocation.  If we wish to add remote
2123         invocation support, we should do that in a separate patch.
2124
2125         * Scripts/run-javascriptcore-tests:
2126         (testPath):
2127         (runTest):
2128         (testapiPath): Deleted.
2129
2130 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2131
2132         Remove duplicate code from Buildbot.js in dashboard
2133         https://bugs.webkit.org/show_bug.cgi?id=174870
2134
2135         Reviewed by Daniel Bates.
2136
2137         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2138         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
2139         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
2140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
2141         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
2142
2143 2017-07-26  Brady Eidson  <beidson@apple.com>
2144
2145         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
2146         https://bugs.webkit.org/show_bug.cgi?id=174851
2147
2148         Reviewed by Chris Dumez.
2149
2150         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2151         (TEST):
2152
2153 2017-07-26  Brian Burg  <bburg@apple.com>
2154
2155         Remove WEB_TIMING feature flag
2156         https://bugs.webkit.org/show_bug.cgi?id=174795
2157
2158         Reviewed by Alex Christensen.
2159
2160         * Scripts/webkitperl/FeatureList.pm:
2161         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2162
2163 2017-07-26  Chris Dumez  <cdumez@apple.com>
2164
2165         Pressing the Escape key should not be a valid user gesture to enter fullscreen
2166         https://bugs.webkit.org/show_bug.cgi?id=174864
2167         <rdar://problem/33009088>
2168
2169         Reviewed by Geoffrey Garen.
2170
2171         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
2172         WKTR.
2173
2174         * DumpRenderTree/mac/EventSendingController.mm:
2175         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2176
2177 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2178
2179         Unreviewed, added Romain Bellessort to contributors.json.
2180
2181         * Scripts/webkitpy/common/config/contributors.json:
2182
2183 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
2184
2185         [WPE] WebGL2 support
2186         https://bugs.webkit.org/show_bug.cgi?id=174249
2187
2188         Reviewed by Alex Christensen.
2189
2190         * Scripts/webkitperl/FeatureList.pm:
2191         Enable WebGL2 for WPE when building through build-webkit.
2192
2193 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2194
2195         Unreviewed. Fix GTK distcheck.
2196
2197         * gtk/make-dist.py:
2198         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
2199
2200 2017-07-25  Brady Eidson  <beidson@apple.com>
2201
2202         ResourceLoadStatistics grandfathering happens much too often.
2203         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
2204
2205         Reviewed by Chris Dumez.
2206
2207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2208         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
2209         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
2210         (TEST):
2211
2212 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2213
2214         Fix autoinstaller failing on autoinstall_everything
2215         https://bugs.webkit.org/show_bug.cgi?id=174830
2216
2217         Reviewed by Joseph Pecoraro.
2218
2219         * Scripts/webkitpy/thirdparty/__init__.py:
2220         (AutoinstallImportHook.find_module):
2221         (AutoinstallImportHook.install_chromedriver):
2222         (AutoinstallImportHook.install_geckodriver):
2223         (AutoinstallImportHook._install_chromedriver): Deleted.
2224         (AutoinstallImportHook._install_geckodriver): Deleted.
2225
2226 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
2227
2228         Replace --runtime with something for both ios-simulator and ios-device
2229         https://bugs.webkit.org/show_bug.cgi?id=173775
2230         <rdar://problem/32952164>
2231
2232         Reviewed by Aakash Jain.
2233
2234         Add --version flag for both iOS simulator and iOS device.
2235
2236         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2237         (parse_args): Add --version flag and move --no-install.
2238         * Scripts/webkitpy/port/factory.py:
2239         (platform_options): Move --no-intall to run_webkit_tests.py.
2240         * Scripts/webkitpy/port/ios.py:
2241         (IOSPort):
2242         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
2243         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
2244         * Scripts/webkitpy/port/ios_device.py:
2245         (IOSDevicePort.ios_version): Consult --version flag before checking connected
2246         devices for iOS version.
2247         * Scripts/webkitpy/port/ios_device_unittest.py:
2248         (IOSDeviceTest.make_port): Set --version option so that we can generate test
2249         expectation paths without devices connected.
2250         (IOSDeviceTest.test_additional_platform_directory): Deleted.
2251         (IOSDeviceTest.test_baseline_searchpath): Deleted.
2252         (IOSDeviceTest.test_expectations_ordering): Deleted.
2253         * Scripts/webkitpy/port/ios_simulator.py:
2254         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
2255         flag to specify a runtime.
2256         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
2257         flag and then use the default runtime.
2258
2259 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2260
2261         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
2262         https://bugs.webkit.org/show_bug.cgi?id=174815
2263
2264         Reviewed by Carlos Alberto Lopez Perez.
2265
2266         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
2267         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
2268         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
2269         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
2270         think), probably because of a newer CMake version.
2271
2272         * CMakeLists.txt:
2273         * TestWebKitAPI/CMakeLists.txt:
2274         * TestWebKitAPI/PlatformGTK.cmake:
2275
2276 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2277
2278         Fix BenchmarkRunner to only import selenium when needed
2279         https://bugs.webkit.org/show_bug.cgi?id=174808
2280
2281         Reviewed by Stephanie Lewis.
2282
2283         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2284         (LinuxChromeDriver.launch_driver):
2285         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2286         (LinuxFirefoxDriver.launch_driver):
2287         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2288         (OSXChromeDriver.launch_driver):
2289         (OSXChromeCanaryDriver.launch_driver):
2290         (create_chrome_options):
2291         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2292         (OSXFirefoxDriver.launch_driver):
2293         (OSXFirefoxNightlyDriver.launch_driver):
2294         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2295         (OSXSafariDriver.launch_driver):
2296         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2297         (WebDriverBenchmarkRunner._run_one_test):
2298
2299 2017-07-23  Darin Adler  <darin@apple.com>
2300
2301         More NeverDestroyed and related cleanup
2302         https://bugs.webkit.org/show_bug.cgi?id=174745
2303
2304         Reviewed by Alex Christensen.
2305
2306         * DumpRenderTree/JavaScriptThreading.cpp:
2307         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2308         DEPRECATED_DEFINE_STATIC_LOCAL.
2309         (javaScriptThreads): Ditto.
2310
2311 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2312
2313         Subclass Benchmark Runner script for WebDriver support
2314         https://bugs.webkit.org/show_bug.cgi?id=174390
2315
2316         Reviewed by Dewei Zhu, Stephanie Lewis.
2317
2318         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2319
2320         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2321         (BenchmarkBuilder.__init__):
2322         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2323         (BenchmarkRunner.__init__):
2324         (BenchmarkRunner._find_plan_file):
2325         (BenchmarkRunner._run_one_test.and):
2326         (BenchmarkRunner.execute):
2327         (BenchmarkRunner._get_result): Deleted.
2328         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2329         (parse_args):
2330         (start):
2331         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2332         (WebDriverBenchmarkRunner):
2333         (WebDriverBenchmarkRunner._get_result):
2334         (WebDriverBenchmarkRunner._run_one_test):
2335         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2336         (WebServerBenchmarkRunner):
2337         (WebServerBenchmarkRunner.__init__):
2338         (WebServerBenchmarkRunner._get_result):
2339         (WebServerBenchmarkRunner._run_one_test):
2340
2341 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2342
2343         Add BenchmarkRunner patches with WebDriver support for each testing plan
2344         https://bugs.webkit.org/show_bug.cgi?id=174443
2345
2346         Reviewed by Dewei Zhu, Stephanie Lewis.
2347
2348         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2349         (BenchmarkBuilder.__enter__):
2350         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2351         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2352         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2353         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2354         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2355         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2356         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2357         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2358         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2359         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2360         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2361         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2362         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2363         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2364         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2365         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2366         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2367         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2368         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2369         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2370         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2371         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2372         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2373         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2374         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2375         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2376         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2377         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2378         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2379         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2380         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2381         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2382         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2383
2384 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2385
2386         Add functions to autoinstaller needed for Benchmark Runner script
2387         https://bugs.webkit.org/show_bug.cgi?id=174331
2388
2389         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2390
2391         Adds autoinstaller functions to install selenium and webdriver binaries
2392         which will be used by the browser driver part of Benchmark Runner.
2393
2394         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2395         (BrowserDriver.restore_env):
2396         (BrowserDriver):
2397         (BrowserDriver.get_webdriver_binary_path):
2398         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2399         (LinuxChromeDriver.launch_driver):
2400         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2401         (LinuxFirefoxDriver.launch_driver):
2402         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2403         (OSXChromeDriver.launch_driver):
2404         (OSXChromeCanaryDriver.launch_driver):
2405         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2406         (OSXFirefoxDriver.launch_driver):
2407         (OSXFirefoxNightlyDriver.launch_driver):
2408         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2409         * Scripts/webkitpy/benchmark_runner/utils.py:
2410         (get_driver_binary_path):
2411         * Scripts/webkitpy/common/system/autoinstall.py:
2412         (AutoInstaller._unzip):
2413         * Scripts/webkitpy/thirdparty/__init__.py:
2414         (AutoinstallImportHook.find_module):
2415         (AutoinstallImportHook._install_selenium):
2416         (AutoinstallImportHook):
2417         (AutoinstallImportHook._install_chromedriver):
2418         (AutoinstallImportHook._install_geckodriver):
2419         (AutoinstallImportHook.get_latest_pypi_url):
2420         (AutoinstallImportHook.install_binary):
2421         (autoinstall_everything):
2422         (get_driver_filename):
2423         (get_os_info):
2424
2425 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2426
2427         Add WebDriver support in browser driver part of BenchmarkRunner
2428         https://bugs.webkit.org/show_bug.cgi?id=174445
2429
2430         Reviewed by Stephanie Lewis.
2431
2432         Adds a launch_driver function to each BrowserDriver subclass. This
2433         function sets up the arguments for the webdriver and launches the
2434         webdriver specific to that browser.
2435
2436         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2437         (BrowserDriver.launch_webdriver):
2438         (BrowserDriver):
2439         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2440         (LinuxBrowserDriver.launch_webdriver):
2441         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2442         (LinuxChromeDriver.launch_url):
2443         (LinuxChromeDriver):
2444         (LinuxChromeDriver.launch_driver):
2445         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2446         (EpiphanyBrowserDriver.launch_url):
2447         (EpiphanyBrowserDriver):
2448         (EpiphanyBrowserDriver.launch_driver):
2449         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2450         (LinuxFirefoxDriver):
2451         (LinuxFirefoxDriver.launch_url):
2452         (LinuxFirefoxDriver.launch_driver):
2453         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2454         (GTKMiniBrowserDriver.launch_url):
2455         (GTKMiniBrowserDriver):
2456         (GTKMiniBrowserDriver.launch_driver):
2457         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2458         (OSXBrowserDriver._launch_webdriver):
2459         (OSXBrowserDriver):
2460         (OSXBrowserDriver._screen_size):
2461         (OSXBrowserDriver._insert_url):
2462         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2463         (OSXChromeDriver):
2464         (OSXChromeDriver.launch_url):
2465         (OSXChromeDriver.launch_driver):
2466         (OSXChromeCanaryDriver):
2467         (OSXChromeCanaryDriver.launch_url):
2468         (OSXChromeCanaryDriver.launch_driver):
2469         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2470         (OSXFirefoxDriver):
2471         (OSXFirefoxDriver.launch_url):
2472         (OSXFirefoxDriver.launch_driver):
2473         (OSXFirefoxNightlyDriver):
2474         (OSXFirefoxNightlyDriver.launch_url):
2475         (OSXFirefoxNightlyDriver.launch_driver):
2476         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2477         (OSXSafariDriver.launch_driver):
2478
2479 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2480
2481         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
2482         https://bugs.webkit.org/show_bug.cgi?id=174793
2483
2484         Reviewed by Tim Horton.
2485
2486         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
2487         down. Without r219765, this test will dereference null and crash.
2488
2489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2490         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
2491         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
2492         (TEST):
2493
2494 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2495
2496         [Win] Implement Authentication dialog in MiniBrowser
2497         https://bugs.webkit.org/show_bug.cgi?id=174662
2498
2499         Reviewed by Alex Christensen.
2500
2501         * MiniBrowser/win/Common.cpp:
2502         (CustomUserAgent):
2503         (DisplayAuthDialog):
2504         (AuthDialogProc):
2505         * MiniBrowser/win/MiniBrowserLib.rc:
2506         * MiniBrowser/win/MiniBrowserLibResource.h:
2507         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2508         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2509
2510 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
2511
2512         Handle case where line_numbers is None instead of an array of line numbers
2513         https://bugs.webkit.org/show_bug.cgi?id=174775
2514
2515         Reviewed by Aakash Jain.
2516
2517         Added files set line_numbers to None in process_file.
2518
2519         * Scripts/webkitpy/style/filereader.py:
2520         (TextFileReader.process_file): Handle case where line_number is set to None.
2521         * Scripts/webkitpy/style/main_unittest.py:
2522         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
2523
2524 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2525
2526         [WPE] Add libepoxy to the Jhbuild moduleset
2527         https://bugs.webkit.org/show_bug.cgi?id=174711
2528
2529         Reviewed by Carlos Alberto Lopez Perez.
2530
2531         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
2532
2533 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2534
2535         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
2536         https://bugs.webkit.org/show_bug.cgi?id=174780
2537
2538         Reviewed by Carlos Garcia Campos.
2539
2540         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2541         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
2542         in case the eglplatform.h header doesn't provide that macro. This replicates
2543         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
2544
2545 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2546
2547         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
2548         https://bugs.webkit.org/show_bug.cgi?id=174758
2549
2550         Reviewed by Dan Bernstein.
2551
2552         Migrate position-information-related unit tests from the PositionInformationTests suite to
2553         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
2554
2555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2556         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2557         (TestWebKitAPI::checkElementTypeAndBoundingRect):
2558         (TestWebKitAPI::TEST):
2559         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
2560         * TestWebKitAPI/cocoa/TestWKWebView.h:
2561         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2562         (-[TestWKWebView activatedElementAtPosition:]):
2563
2564 2017-07-22  Chris Dumez  <cdumez@apple.com>
2565
2566         REGRESSION(r204565): WKObject is broken
2567         https://bugs.webkit.org/show_bug.cgi?id=174736
2568         <rdar://problem/33246169>
2569
2570         Reviewed by Dan Bernstein.
2571
2572         Add API test that used to crash.
2573
2574         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2575         (TestWebKitAPI::TEST):
2576
2577 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2578
2579         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
2580         https://bugs.webkit.org/show_bug.cgi?id=174705
2581
2582         Reviewed by Mark Lam.
2583
2584         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2585         (TestWebKitAPI::testThreadGroup):
2586         (TestWebKitAPI::TEST):
2587
2588 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
2589
2590         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
2591         https://bugs.webkit.org/show_bug.cgi?id=174724
2592
2593         Reviewed by Aakash Jain.
2594
2595         * Scripts/webkitpy/port/ios_simulator.py:
2596         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
2597         simulator. Errors here should be treated the same as no simulators found.
2598
2599 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
2600
2601         [CMake] Add an option to stop build after generating project files
2602         https://bugs.webkit.org/show_bug.cgi?id=174664
2603
2604         Reviewed by Konstantin Tokarev.
2605
2606         Add "--generate-project-only" to stop build after generating project files.
2607
2608         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
2609         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
2610         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
2611         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
2612         (isGenerateProjectOnly): ditto
2613
2614 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2615
2616         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2617         https://bugs.webkit.org/show_bug.cgi?id=174501
2618
2619         Reviewed by Darin Adler.
2620
2621         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2622         (TestWebKitAPI::TEST):
2623
2624 2017-07-20  David Quesada  <david_quesada@apple.com>
2625
2626         Add SPI to notify WKNavigationDelegate about client redirects
2627         https://bugs.webkit.org/show_bug.cgi?id=174680
2628         rdar://problem/33184886
2629
2630         Reviewed by Brady Eidson.
2631
2632         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2633         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
2634         (TEST):
2635         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
2636
2637 2017-07-20  Brady Eidson  <beidson@apple.com>
2638
2639         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
2640         https://bugs.webkit.org/show_bug.cgi?id=174685
2641
2642         Reviewed by Andy Estes.
2643
2644         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2645         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
2646
2647 2017-07-20  Brady Eidson  <beidson@apple.com>
2648
2649         Deprecate WebIconDatabase in WebKitLegacy/mac.
2650         https://bugs.webkit.org/show_bug.cgi?id=174607
2651
2652         Reviewed by Alex Christensen.
2653
2654         * DumpRenderTree/mac/TestRunnerMac.mm:
2655
2656 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2657
2658         lint-test-expectations should be run during style checking
2659         https://bugs.webkit.org/show_bug.cgi?id=173559
2660         <rdar://problem/32854941>
2661
2662         Reviewed by Aakash Jain.
2663
2664         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2665         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
2666         prevents identifying errors on specific lines in a file.
2667         * Scripts/webkitpy/style/main_unittest.py:
2668         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
2669         case where a linter error is in the file modified, but the line modified is not related to
2670         the linter error.
2671
2672 2017-07-20  Brady Eidson  <beidson@apple.com>
2673
2674         Remove WebIconDatabase from WebKitLegacy/win.
2675         https://bugs.webkit.org/show_bug.cgi?id=174608
2676
2677         Reviewed by Alex Christensen.
2678
2679         * DumpRenderTree/win/DumpRenderTree.cpp:
2680         (main):
2681         * DumpRenderTree/win/TestRunnerWin.cpp:
2682         (TestRunner::setIconDatabaseEnabled):
2683
2684 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
2685
2686         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
2687         https://bugs.webkit.org/show_bug.cgi?id=174671
2688
2689         Reviewed by Carlos Garcia Campos.
2690
2691         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2692         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
2693         priority for this source in order to have it dispatched on the same
2694         priority as the other WebKit-controlled GSource objects.
2695
2696 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2697
2698         lint-test-expectations should be run during style checking
2699         https://bugs.webkit.org/show_bug.cgi?id=173559
2700         <rdar://problem/32854941>
2701
2702         Reviewed by Daniel Bates.
2703
2704         Follow up fix addressing style and a few minor bugs.
2705
2706         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2707         (TestExpectationParser.__init__): Use lambda x: x instead of str
2708         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
2709         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
2710         reduce the calls of _shorten_filename, fix minor bug in appending the current
2711         expectation's line number instead of the previous ones, clarify treatment of None
2712         in file-to-line-number mapping.
2713         (TestExpectations._report_warnings): Collapse call.
2714         * Scripts/webkitpy/style/checkers/test_expectations.py:
2715         (TestExpectationsChecker.lint_test_expectations):
2716         * Scripts/webkitpy/style/filereader.py: Re-write comment.
2717         (TextFileReader.process_file): Add comment explaining treatment of None in
2718         file-to-line-number mapping.
2719         (TextFileReader.delete_file): Collapse call.
2720
2721 2017-07-19  Chris Dumez  <cdumez@apple.com>
2722
2723         Unreviewed attempt to fix API test failure after r219663.
2724
2725         The test was hard-coding an exception string and the string has changed slightly
2726         in r219663.
2727
2728         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2729         (TEST):
2730
2731 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
2732
2733         Don't write file URLs to iOS Pasteboard
2734         https://bugs.webkit.org/show_bug.cgi?id=174647
2735         <rdar://problem/33199730>
2736
2737         Reviewed by Wenson Hsieh.
2738
2739         Updating tests to reflect the lack of file URLs for images.
2740
2741         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2742         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
2743         (checkEstimatedSize):
2744         (TestWebKitAPI::TEST):
2745
2746 2017-07-19  Brady Eidson  <beidson@apple.com>
2747
2748         iBooks sometimes crashes when closing a book.
2749         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
2750
2751         Reviewed by Oliver Hunt.
2752
2753         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2754         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
2755         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
2756         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
2757         (TestWebKitAPI::TEST):
2758
2759         Add a "spin the runloop X number of times" utility:
2760         * TestWebKitAPI/Utilities.h:
2761         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2762         (TestWebKitAPI::Util::spinRunLoop):
2763
2764 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2765
2766         lint-test-expectations should be run during style checking
2767         https://bugs.webkit.org/show_bug.cgi?id=173559
2768         <rdar://problem/32854941>
2769
2770         Reviewed by David Kilzer.
2771
2772         Running the test expectation linter requires reading both files and lines not in the
2773         patch because, for example, deletion of a test can cause a lint failure even though
2774         no test expectations where modified. This means that the linter will occasionally warn
2775         about lines which were not changed in a given patch but whose error is related to a
2776         change made in that patch.
2777
2778         * Scripts/webkitpy/common/system/filesystem_mock.py:
2779         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
2780         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2781         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
2782         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
2783         content, description of the error and the name of the associated test.
2784         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
2785         (TestExpectationParser.__init__): Pass shorten_filename function to
2786         TestExpectationsParser to add a deleted file to the related_files dictionary.
2787         (TestExpectationParser._check_test_exists): If the test does not exist, add the
2788         missing path to the related_files dictionary.
2789         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
2790         files and line numbers related to this test expectation line. This will allow
2791         tracking linter errors in the style checker occurring across multiple files.
2792         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
2793         lines to related_files dictionary.
2794         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
2795         (TestExpectations._report_warnings): Construct warning object instead of string
2796         when adding to warnings list.
2797         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
2798         clean-up log.
2799         * Scripts/webkitpy/style/checker.py:
2800         (ProcessorBase.do_association_check): Add required function for processor classes.
2801         (StyleProcessor):
2802         (StyleProcessor.do_association_check): Run the TestExpectations linter when
2803         checking for errors between associated files.
2804         * Scripts/webkitpy/style/checkers/test_expectations.py:
2805         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
2806         (TestExpectationsChecker):
2807         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
2808         of modified files, the current working directory and the host, determine if the linter
2809         warning is associated with the changes.
2810         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
2811         style checker.
2812         * Scripts/webkitpy/style/filereader.py:
2813         (TextFileReader):
2814         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
2815         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
2816         (TextFileReader.process_file): Track both the number of files changed and which lines
2817         in those files were changed.
2818         (TextFileReader.do_association_check): Run the processor's association check on all
2819         modified or deleted files processed by TextFileReader.
2820         (TextFileReader.delete_file): Track deleted files in _files dictionary.
2821         (TextFileReader.count_delete_only_file): Deleted.
2822         * Scripts/webkitpy/style/filereader_unittest.py:
2823         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
2824         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
2825         * Scripts/webkitpy/style/main.py:
2826         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
2827         explicitly run the association check on the file reader.
2828         * Scripts/webkitpy/style/main_unittest.py:
2829         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
2830         embedded in the style checker.
2831         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
2832         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
2833         construct the TextFileReader object with a StyleProcessor used to run style checks on
2834         specific files.
2835         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
2836         testing the test expectation linter inside the style checker. This host must contain a
2837         mock file system with the basic structure of test expectations.
2838         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
2839         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
2840         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
2841         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
2842         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
2843         * Scripts/webkitpy/style/patchreader.py:
2844         (PatchReader.check): Specify which file was deleted, run the association check.
2845         * Scripts/webkitpy/style/patchreader_unittest.py:
2846         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
2847         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
2848         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
2849
2850 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2851
2852         [WTF] Implement WTF::ThreadGroup
2853         https://bugs.webkit.org/show_bug.cgi?id=174081
2854
2855         Reviewed by Mark Lam.
2856
2857         Add WTF::ThreadGroup tests.
2858
2859         * TestWebKitAPI/CMakeLists.txt:
2860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2861         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2862         (TestWebKitAPI::testThreadGroup):
2863         (TestWebKitAPI::TEST):
2864
2865 2017-07-18  Andy Estes  <aestes@apple.com>
2866
2867         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2868         https://bugs.webkit.org/show_bug.cgi?id=174631
2869
2870         Reviewed by Tim Horton.
2871
2872         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2873         * MiniBrowser/Configurations/Base.xcconfig:
2874         * MobileMiniBrowser/Configurations/Base.xcconfig:
2875         * TestWebKitAPI/Configurations/Base.xcconfig:
2876         * WebKitTestRunner/Configurations/Base.xcconfig:
2877
2878 2017-07-18  Andy Estes  <aestes@apple.com>
2879
2880         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2881         https://bugs.webkit.org/show_bug.cgi?id=174631
2882
2883         Reviewed by Sam Weinig.
2884
2885         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2886         * MiniBrowser/Configurations/Base.xcconfig:
2887         * MobileMiniBrowser/Configurations/Base.xcconfig:
2888         * TestWebKitAPI/Configurations/Base.xcconfig:
2889         * WebKitTestRunner/Configurations/Base.xcconfig:
2890
2891 2017-07-18  Daniel Bates  <dabates@apple.com>
2892
2893         lldb: Add type summary for StringView
2894         https://bugs.webkit.org/show_bug.cgi?id=174637
2895
2896         Reviewed by Sam Weinig.
2897
2898         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
2899         StringView object will print output that has the form:
2900
2901             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
2902               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
2903               m_length = 2
2904               m_is8Bit = true
2905               m_underlyingString = 0x0000614000000a90
2906             }
2907
2908         * lldb/lldb_webkit.py:
2909         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
2910         (WTFStringView_SummaryProvider):
2911         (WTFStringViewProvider):
2912         (WTFStringViewProvider.__init__):
2913         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
2914         (WTFStringViewProvider.get_length): Access field StringView.m_length.
2915         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
2916         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
2917
2918 2017-07-18  Andy Estes  <aestes@apple.com>
2919
2920         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2921         https://bugs.webkit.org/show_bug.cgi?id=174631
2922
2923         Reviewed by Dan Bernstein.
2924
2925         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2926         * MiniBrowser/Configurations/Base.xcconfig:
2927         * MobileMiniBrowser/Configurations/Base.xcconfig:
2928         * TestWebKitAPI/Configurations/Base.xcconfig:
2929         * WebKitTestRunner/Configurations/Base.xcconfig:
2930
2931 2017-07-18  Devin Rousso  <drousso@apple.com>
2932
2933         Web Inspector: Add memoryCost to Inspector Protocol objects
2934         https://bugs.webkit.org/show_bug.cgi?id=174478
2935
2936         Reviewed by Joseph Pecoraro.
2937
2938         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2939         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
2940         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
2941         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
2942         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
2943         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
2944         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
2945         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
2946         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
2947         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
2948         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
2949         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
2950         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
2951         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
2952         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
2953         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
2954         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
2955
2956 2017-07-18  Andy Estes  <aestes@apple.com>
2957
2958         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2959         https://bugs.webkit.org/show_bug.cgi?id=174631
2960
2961         Reviewed by Darin Adler.
2962
2963         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2964         * MiniBrowser/Configurations/Base.xcconfig:
2965         * MobileMiniBrowser/Configurations/Base.xcconfig:
2966         * TestWebKitAPI/Configurations/Base.xcconfig:
2967         * WebKitTestRunner/Configurations/Base.xcconfig:
2968
2969 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2970
2971         Unreviewed, fix the iOS build.
2972
2973         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
2974
2975         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2976         (TestWebKitAPI::TEST):
2977
2978 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2979
2980         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
2981         https://bugs.webkit.org/show_bug.cgi?id=174585
2982         <rdar://problem/33302541>
2983
2984         Reviewed by Tim Horton.
2985
2986         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
2987         being dragged when initiating a drag.
2988
2989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2990         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
2991         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2992         (TestWebKitAPI::TEST):
2993         * TestWebKitAPI/cocoa/TestWKWebView.h:
2994
2995         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
2996
2997         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2998         (-[TestWKWebView synchronouslyLoadHTMLString:]):
2999
3000 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3001
3002         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
3003         https://bugs.webkit.org/show_bug.cgi?id=174547
3004
3005         Reviewed by Alex Christensen.
3006
3007         * DumpRenderTree/PlatformWin.cmake:
3008         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3009
3010 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3011
3012         Update style checker to deal with "final"
3013         https://bugs.webkit.org/show_bug.cgi?id=174528
3014
3015         Reviewed by Alex Christensen.
3016         
3017         check-webkit-style shouldn't complain about an open brace to start a
3018         line after a function definition with "final" or "const final".
3019
3020         * Scripts/webkitpy/style/checkers/cpp.py:
3021         (check_braces):
3022         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3023         (CppStyleTest.test_brace_at_begin_of_line):
3024
3025 2017-07-17  Alex Christensen  <achristensen@webkit.org>
3026
3027         Modernize content extension code
3028         https://bugs.webkit.org/show_bug.cgi?id=174588
3029
3030         Reviewed by Sam Weinig.
3031
3032         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3033         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3034         (TestWebKitAPI::testRequest):
3035         (TestWebKitAPI::makeBackend):
3036         (TestWebKitAPI::TEST_F):
3037
3038 2017-07-17  Brady Eidson  <beidson@apple.com>
3039
3040         WKHTTPCookieStore observing only works on the default cookie store.
3041         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
3042
3043         Reviewed by Sam Weinig.
3044
3045         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3046         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
3047           called for the default store, a non-persistent store, and a custom store.
3048         (TEST):
3049
3050 2017-07-16  Sam Weinig  <sam@webkit.org>
3051
3052         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
3053         https://bugs.webkit.org/show_bug.cgi?id=174575
3054
3055         Reviewed by Brady Eidson.
3056
3057         * Scripts/svn-create-patch:
3058         (findModificationType):
3059         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
3060         default value of "unknown".
3061
3062         (generateFileList):
3063         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
3064         for untracked, which matches our old behavior.
3065
3066 2017-07-17  Charlie Turner  <cturner@igalia.com>
3067
3068         Add some missing build dependencies on Fedora
3069         https://bugs.webkit.org/show_bug.cgi?id=174578
3070
3071         Unreviewed dependency update.
3072
3073         * gtk/install-dependencies:
3074
3075 2017-07-16  Brady Eidson  <beidson@apple.com>
3076
3077         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
3078         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
3079
3080         Reviewed by Tim Horton.
3081
3082         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3083         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
3084         (TEST):
3085
3086 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
3087
3088         [GTK] Sort inspector GResource manifest to ensure reproducible builds
3089         https://bugs.webkit.org/show_bug.cgi?id=174540
3090
3091         Reviewed by Michael Catanzaro.
3092
3093         * gtk/generate-inspector-gresource-manifest.py:
3094         (get_filenames): sort list of input files
3095
3096 2017-07-15  Brady Eidson  <beidson@apple.com>
3097
3098         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
3099         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
3100
3101         Reviewed by Tim Horton.
3102
3103         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3104         (TEST): Make this test more reliable by clearing everything beforehand.
3105
3106 2017-07-15  David Kilzer  <ddkilzer@apple.com>
3107
3108         Make it possible to extend check-webkit-style with Apple-internal checkers
3109         <https://webkit.org/b/174464>
3110         <rdar://problem/25564402>
3111
3112         Reviewed by Darin Adler.
3113
3114         * Scripts/webkitpy/style/checker.py: Import apple_additions.
3115         (_all_categories): Add categories from apple_additions() if it
3116         exists.
3117         (CheckerDispatcher._create_checker): Create python checker
3118         from apple_additions() if it exists.
3119
3120 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3121
3122         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
3123         https://bugs.webkit.org/show_bug.cgi?id=174539
3124         <rdar://problem/33307395>
3125
3126         Reviewed by Darin Adler.
3127
3128         Adds a new unit test suite to cover action sheet popover presentation.
3129
3130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3131         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
3132         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
3133         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
3134
3135         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
3136
3137         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
3138         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3139
3140         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
3141
3142         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3143         (TestWebKitAPI::TEST):
3144
3145 2017-07-15  Sam Weinig  <sam@webkit.org>
3146
3147         [Scripts] Make svn-create-patch work better when called in sub directories
3148         https://bugs.webkit.org/show_bug.cgi?id=174551
3149
3150         Reviewed by Darin Adler.
3151
3152         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
3153           by ensuring that the prefix is applied as is done in generateDiff.
3154         - Silence output of explanatory lines from svn stat (" > move to ...")
3155           that show up in STDERR when running svn-create-patch.
3156         - Add verbose logging that I found useful while debugging this issue.
3157
3158         * Scripts/svn-create-patch:
3159         (findBaseUrl):
3160         (findMimeType):
3161         (findSourceFileAndRevision):
3162         (generateDiff):
3163         (generateFileList):
3164         (manufacturePatchForAdditionWithHistory):
3165
3166 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
3167
3168         Unreviewed build fix after r219537.
3169
3170         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3171
3172 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3173
3174         Add iOS 11 SPI
3175         https://bugs.webkit.org/show_bug.cgi?id=174430
3176         <rdar://problem/33269288>
3177
3178         Reviewed by Tim Horton.
3179
3180         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
3181         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
3182         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
3183
3184 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3185
3186         Failing to install on iPad simulators
3187         https://bugs.webkit.org/show_bug.cgi?id=174532
3188         <rdar://problem/33328347>
3189
3190         Reviewed by Stephanie Lewis.
3191
3192         * Scripts/webkitpy/xcode/simulated_device.py:
3193         (SimulatedDevice.install_app): Place install command in retry try-except block.
3194
3195 2017-07-14  Jeff Miller  <jeffm@apple.com>
3196
3197         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3198         https://bugs.webkit.org/show_bug.cgi?id=174524
3199
3200         Reviewed by Sam Weinig.
3201
3202         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
3203         (TEST):
3204         Renamed TestParameter to TestParameter1.
3205         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3206
3207         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3208         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3209         Observe changes for two bundle parameters.
3210
3211         (-[BundleParametersPlugIn dealloc]):
3212         Remove observers for two bundle parameters.
3213
3214 2017-07-14  Commit Queue  <commit-queue@webkit.org>
3215
3216         Unreviewed, rolling out r219510.
3217         https://bugs.webkit.org/show_bug.cgi?id=174525
3218
3219         Need to revert length() == 0 check for null string (Requested
3220         by yusukesuzuki on #webkit).
3221
3222         Reverted changeset:
3223
3224         "[WTF] Newly added AtomicStringImpl should use BufferInternal
3225         static string if StringImpl is static"
3226         https://bugs.webkit.org/show_bug.cgi?id=174501
3227         http://trac.webkit.org/changeset/219510
3228
3229 2017-07-14  Jer Noble  <jer.noble@apple.com>
3230
3231         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
3232         https://bugs.webkit.org/show_bug.cgi?id=174514
3233
3234         Reviewed by Sam Weinig.
3235
3236         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
3237         (TestWebKitAPI::TEST_F):
3238
3239 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3240
3241         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3242         https://bugs.webkit.org/show_bug.cgi?id=174501
3243
3244         Reviewed by Darin Adler.
3245
3246         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3247         (TestWebKitAPI::TEST):
3248
3249 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3250
3251         Bring mac expectations in-line with other platforms
3252         https://bugs.webkit.org/show_bug.cgi?id=174472
3253         <rdar://problem/33297388>
3254
3255         Reviewed by David Kilzer.
3256
3257         The override order for Mac test expectations does not conform to the pattern used by iOS,
3258         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
3259
3260             platform/mac-wk2
3261             platform/wk2
3262             platform/mac-elcapitan
3263             platform/mac-sierra
3264             generic
3265
3266         After this change, El Capitan's baseline search path looks like this:
3267
3268             platform/mac-sierra-wk2
3269             platform/mac-sierra
3270             platform/mac-wk2
3271             platform/wk2
3272             generic
3273
3274         * Scripts/webkitpy/port/mac.py:
3275         (MacPort.__init__): If a specific version is specified in the port name, use that
3276         as the os version.
3277         (MacPort.default_baseline_search_path): Expectation search paths should work the
3278         same way they do on other ports. Port + version overrides port, port overrides generic
3279         and wk1/wk2 should override expectations for the two combined.
3280         * Scripts/webkitpy/port/mac_unittest.py:
3281         (MacTest.test_tests_for_other_platforms): Deleted.
3282         (MacTest._assert_search_path): Deleted.
3283         (MacTest.test_baseline_search_path): Deleted.
3284         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3285         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
3286         (test_rebaseline_test_and_print_scm_changes): Ditto.
3287         (test_rebaseline_and_copy_test): Ditto.
3288         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
3289         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
3290         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
3291
3292 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3293
3294         Fix style checker unit test
3295
3296         Unreviewed WebKit2 => WebKit fixup.
3297
3298         * Scripts/webkitpy/style/checker_unittest.py:
3299         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3300
3301 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3302
3303         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
3304
3305         Unreviewed build fix.
3306
3307         r219492 missed one hunk from its partial revert of r219489.
3308         This patch reverts that hunk.
3309
3310         * TestWebKitAPI/CMakeLists.txt:
3311
3312 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3313
3314         Use the old WebKit/WebKit2 targets for CMake builds.
3315
3316         Unreviewed build fix.
3317
3318         We can update the target names to match the Framework names in a future patch.
3319         This is a partial revert of r219489.
3320
3321         * TestWebKitAPI/CMakeLists.txt:
3322         WebKitLegacy => WebKit
3323         WebKit => WebKit2
3324
3325 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3326
3327         Fix TestWebKit API.
3328         https://bugs.webkit.org/show_bug.cgi?id=174164
3329         rdar://problem/33137595
3330
3331         Reviewed by Dan Bernstein.
3332
3333         * TestWebKitAPI/CMakeLists.txt:
3334         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3335         * TestWebKitAPI/PlatformGTK.cmake:
3336
3337 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3338
3339         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
3340         https://bugs.webkit.org/show_bug.cgi?id=174164
3341         rdar://problem/33137595
3342
3343         Reviewed by Dan Bernstein.
3344
3345         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3346         (ShouldBuildTest):
3347         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3348         * Scripts/build-webkit:
3349         * Scripts/do-file-rename:
3350         * Scripts/do-webcore-rename:
3351         * Scripts/update-webkit-localizable-strings:
3352         * Scripts/webkitpy/common/config/watchlist:
3353         * Scripts/webkitpy/style/checker.py:
3354         * Scripts/webkitpy/style/checkers/featuredefines.py:
3355         * gtk/make-dist.py:
3356         (ensure_version_if_possible):
3357         * gtk/manifest.txt.in:
3358
3359 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
3360
3361         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
3362         https://bugs.webkit.org/show_bug.cgi?id=174162
3363         rdar://problem/33137594
3364
3365         Reviewed by Dan Bernstein.
3366
3367         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
3368
3369         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3370         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3371         * EWSTools/configure-clang-linux.sh:
3372         * Scripts/build-webkit:
3373         * Scripts/do-file-rename:
3374         * Scripts/do-webcore-rename:
3375         * Scripts/update-webkit-localizable-strings:
3376         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3377         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3378         * Scripts/webkitpy/style/checkers/featuredefines.py:
3379         * gtk/manifest.txt.in:
3380
3381 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
3382
3383         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
3384         https://bugs.webkit.org/show_bug.cgi?id=174438
3385         <rdar://problem/33277112>
3386
3387         Reviewed by Aakash Jain.
3388
3389         Given a patch, this will convert the changes from the path to the new directory structure.
3390
3391         * Scripts/rebase-patch-after-webkit-move: Added.
3392         (append_source): Append 'Source' to the provided path.
3393         (is_editable_line): Return true if a line the script expects to modify.
3394         (needs_rebase): Return if a line needs to be rebased based on it's content.
3395         (rebase_line): Rebase the provided line.
3396         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
3397         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
3398         were provided.
3399
3400 2017-07-12  Nan Wang  <n_wang@apple.com>
3401
3402         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3403         https://bugs.webkit.org/show_bug.cgi?id=174393
3404         <rdar://problem/33248006>
3405
3406         Reviewed by Chris Fleizach.
3407
3408         * DumpRenderTree/AccessibilityUIElement.cpp:
3409         (textMarkerRangeMatchesTextNearMarkersCallback):
3410         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3411         (AccessibilityUIElement::getJSClass):
3412         * DumpRenderTree/AccessibilityUIElement.h:
3413         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3414         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3415         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3416         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3417         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3418         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3419         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3420         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3421
3422 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3423
3424         Unreviewed, rolling out r219409.
3425
3426         The revision caused the Windows builds to fail.
3427
3428         Reverted changeset:
3429
3430         "AX: [iOS] Implement a way to retrieve a text marker range
3431         with desired text that is closest to a position"
3432         https://bugs.webkit.org/show_bug.cgi?id=174393
3433         http://trac.webkit.org/changeset/219409
3434
3435 2017-07-12  Nan Wang  <n_wang@apple.com>
3436
3437         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3438         https://bugs.webkit.org/show_bug.cgi?id=174393
3439         <rdar://problem/33248006>
3440
3441         Reviewed by Chris Fleizach.
3442
3443         * DumpRenderTree/AccessibilityUIElement.cpp:
3444         (textMarkerRangeMatchesTextNearMarkersCallback):
3445         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3446         (AccessibilityUIElement::getJSClass):
3447         * DumpRenderTree/AccessibilityUIElement.h:
3448         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3449         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3450         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3451         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3452         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3453         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3454         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3455         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3456
3457 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
3458
3459         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
3460         https://bugs.webkit.org/show_bug.cgi?id=174197
3461
3462         Reviewed by Darin Adler.
3463
3464         This bit me the first time I tried to submit a patch to WebKit, and still I have
3465         to manually edit the ChangeLog every time I use the script.
3466
3467         This generates a more convenient and standard ChangeLog entry.
3468
3469         * Scripts/prepare-ChangeLog:
3470         (generateNewChangeLogs):
3471
3472 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3473
3474         Unreviewed, rolling out r219401.
3475
3476         This revision rolled out the previous patch, but after talking
3477         with reviewer, a rebaseline is what was needed.Rolling back in
3478         before rebaseline.
3479
3480         Reverted changeset:
3481
3482         "Unreviewed, rolling out r219379."
3483         https://bugs.webkit.org/show_bug.cgi?id=174400
3484         http://trac.webkit.org/changeset/219401
3485
3486 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3487
3488         Unreviewed, rolling out r219379.
3489
3490         This revision caused a consistent failure in the test
3491         fast/dom/Window/property-access-on-cached-window-after-frame-
3492         removed.html.
3493
3494         Reverted changeset:
3495
3496         "Remove NAVIGATOR_HWCONCURRENCY"
3497         https://bugs.webkit.org/show_bug.cgi?id=174400
3498         http://trac.webkit.org/changeset/219379
3499
3500 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3501
3502         [WPE] Use libepoxy
3503         https://bugs.webkit.org/show_bug.cgi?id=172104
3504
3505         Reviewed by Michael Catanzaro.
3506
3507         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
3508         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
3509
3510 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3511
3512         [GTK][WPE] Align Jhbuild patches for GStreamer packages
3513         https://bugs.webkit.org/show_bug.cgi?id=174363
3514
3515         Reviewed by Michael Catanzaro.
3516
3517         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
3518         between the GTK+ and WPE port. There's no reason for the two ports to apply
3519         different patches over same versions of GStreamer releases.
3520
3521         This aligns the two ports on this specific issue. Next we'll look into
3522         creating a single GStreamer-specific Jhbuild moduleset that will allow us
3523         to keep these patches in a single place, avoiding duplicate files.
3524
3525         * gtk/jhbuild.modules:
3526         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3527         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
3528         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3529         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
3530
3531 2017-07-11  Dean Jackson  <dino@apple.com>
3532
3533         Remove NAVIGATOR_HWCONCURRENCY
3534         https://bugs.webkit.org/show_bug.cgi?id=174400
3535
3536         Reviewed by Sam Weinig.
3537
3538         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3539
3540 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
3541
3542         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
3543         https://bugs.webkit.org/show_bug.cgi?id=174239
3544
3545         Reviewed by Brady Eidson.
3546
3547         Create windows with specific features set and make sure those are properly reflected in the
3548         WKWindowFeatures object.
3549
3550         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3551         (resetToConsistentState):
3552         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3553         (TEST):
3554
3555 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
3556
3557         Do not duplicate files when deleting directories with svn 1.9
3558         https://bugs.webkit.org/show_bug.cgi?id=174339
3559         <rdar://problem/33226781>
3560
3561         Reviewed by David Kilzer.
3562
3563         * Scripts/svn-create-patch:
3564         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
3565         (generateFileList): Determine which files are deleted because they are part of a
3566         directory being deleted.
3567
3568 2017-07-11  Dean Jackson  <dino@apple.com>
3569
3570         Rolling out r219372.
3571
3572         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3573
3574 2017-07-11  Dean Jackson  <dino@apple.com>
3575
3576         Remove NAVIGATOR_HWCONCURRENCY
3577         https://bugs.webkit.org/show_bug.cgi?id=174400
3578
3579         Reviewed by Sam Weinig.
3580
3581         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3582
3583 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3584
3585         Teach build workers to fetch archives from S3.
3586         https://bugs.webkit.org/show_bug.cgi?id=174384
3587
3588         Reviewed by Aakash Jain.
3589
3590         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3591         (DownloadBuiltProduct):
3592
3593 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3594
3595         Configure buildbot to transfer all archives to S3.
3596         Previously this was Mac only, but it's time to expand!
3597         https://bugs.webkit.org/show_bug.cgi?id=174378
3598         
3599         Reviewed by Aakash Jain.
3600
3601         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3602         (BuildFactory.__init__):
3603
3604 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
3605
3606         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
3607         https://bugs.webkit.org/show_bug.cgi?id=174350
3608
3609         Reviewed by Xabier Rodriguez-Calvar.
3610
3611         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
3612         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
3613         patches are removed. The patches for gst-plugins-good are updated, removing
3614         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
3615         rtpbin elements that will help with the EMEv3 development.
3616
3617         * wpe/jhbuild.modules:
3618         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
3619         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
3620         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
3621         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3622         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
3623         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3624         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
3625         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
3626         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
3627
3628 2017-07-10  John Wilander  <wilander@apple.com>
3629
3630         Resource Load Statistics: Prune statistics in orders of importance
3631         https://bugs.webkit.org/show_bug.cgi?id=174215
3632         <rdar://problem/33164403>
3633
3634         Reviewed by Chris Dumez.
3635
3636         Nest infrastructure. Adds these functions:
3637         1. testRunner.setStatisticsLastSeen()
3638         2. setStatisticsMaxStatisticsEntries()
3639         3. setStatisticsPruneEntriesDownTo()
3640
3641         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3642         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3643         (WTR::TestRunner::setStatisticsLastSeen):
3644         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
3645         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3646         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3647         * WebKitTestRunner/TestController.cpp:
3648         (WTR::TestController::setStatisticsLastSeen):
3649         (WTR::TestController::setMaxStatisticsEntries):
3650         (WTR::TestController::setPruneEntriesDownTo):
3651         * WebKitTestRunner/TestController.h:
3652         * WebKitTestRunner/TestInvocation.cpp:
3653         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3654         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3655         (WTR::TestController::setStatisticsLastSeen):
3656         (WTR::TestController::setStatisticsMaxStatisticsEntries):
3657         (WTR::TestController::setStatisticsPruneEntriesDownTo):
3658
3659 2017-07-03  Brian Burg  <bburg@apple.com>
3660
3661         Web Replay: remove some unused code
3662         https://bugs.webkit.org/show_bug.cgi?id=173903
3663
3664         Rubber-stamped by Joseph Pecoraro.
3665
3666         * Scripts/run-input-generator-tests: Removed.
3667         * Scripts/webkitpy/replay/__init__.py: Removed.
3668         * Scripts/webkitpy/replay/main.py: Removed.
3669
3670 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
3671
3672         [WPE] Fix layout test baseline and TestExpectations hierarchy
3673         https://bugs.webkit.org/show_bug.cgi?id=174092
3674
3675         Reviewed by Michael Catanzaro.
3676
3677         Like for the GTK+ port, override the default_baseline_search_path() and
3678         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
3679         Both methods operate on a short list of search paths that defaults to 'wpe' and
3680         'wk2', along with any other user-specified platform directory.
3681
3682         The test_expectations_file_position() method is overridden for testing purposes,
3683         and relevant unit tests are added.
3684
3685         * Scripts/webkitpy/port/wpe.py:
3686         (WPEPort._search_paths):
3687         (WPEPort):
3688         (WPEPort.default_baseline_search_path):
3689         (WPEPort._port_specific_expectations_files):
3690         (WPEPort.test_expectations_file_position):
3691         * Scripts/webkitpy/port/wpe_unittest.py:
3692         (WPEPortTest.test_default_baseline_search_path):
3693         (WPEPortTest):
3694         (WPEPortTest.test_port_specific_expectations_files):
3695
3696 2017-07-10  Chris Dumez  <cdumez@apple.com>
3697
3698         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
3699         https://bugs.webkit.org/show_bug.cgi?id=174301
3700
3701         Reviewed by Brent Fulgham.
3702
3703         Rename some of the testRunner API for clarity and to better match what it calls
3704         internally.
3705
3706         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3707         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3708         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
3709         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
3710         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3711         * WebKitTestRunner/TestController.cpp:
3712         (WTR::TestController::statisticsUpdateCookiePartitioning):
3713         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
3714         * WebKitTestRunner/TestController.h:
3715         * WebKitTestRunner/TestInvocation.cpp:
3716         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3717         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3718         (WTR::TestController::statisticsUpdateCookiePartitioning):
3719         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
3720
3721 2017-07-10  Charlie Turner  <cturner@igalia.com>
3722
3723         [GStreamer] Live twitch.tv videos do not play
3724         https://bugs.webkit.org/show_bug.cgi?id=174222
3725
3726         Reviewed by Michael Catanzaro.
3727
3728         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
3729         fixes videos not playing on twitch.tv.
3730
3731         * gtk/jhbuild.modules:
3732
3733 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
3734
3735         Add WebGL2 configuration option to build-webkit
3736         https://bugs.webkit.org/show_bug.cgi?id=174251
3737
3738         Reviewed by Michael Catanzaro.
3739
3740         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
3741         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
3742         is marked as enabled for the Apple Cocoa ports.
3743
3744 2017-07-08  Chris Dumez  <cdumez@apple.com>
3745
3746         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
3747         https://bugs.webkit.org/show_bug.cgi?id=174290
3748
3749         Reviewed by Brent Fulgham.
3750
3751         Rename testRunner API to match the new internal API names.
3752
3753         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3754         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3755         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
3756         (WTR::TestRunner::statisticsSubmitTelemetry):
3757         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3758         * WebKitTestRunner/TestController.cpp:
3759         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3760         (WTR::TestController::statisticsSubmitTelemetry):
3761         * WebKitTestRunner/TestController.h:
3762         * WebKitTestRunner/TestInvocation.cpp:
3763         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3764         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3765         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3766         (WTR::TestController::statisticsSubmitTelemetry):
3767
3768 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3769
3770         Drop NOSNIFF compile flag
3771         https://bugs.webkit.org/show_bug.cgi?id=174289
3772
3773         Reviewed by Michael Catanzaro.
3774
3775         * Scripts/webkitperl/FeatureList.pm:
3776         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3777
3778 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3779
3780         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
3781         https://bugs.webkit.org/show_bug.cgi?id=174219
3782         <rdar://problem/32083177>
3783
3784         Reviewed by Ryosuke Niwa.
3785
3786         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
3787         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
3788         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
3789         place.
3790
3791         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
3792         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
3793         no action is taken when dropping.
3794
3795         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
3796         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3797         (TestWebKitAPI::TEST):
3798         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3799         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3800         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
3801         (-[MockDragDropSession allowsMoveOperation]):
3802         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
3803         (-[MockDataInteractionSession initWithWindow:allowMove:]):
3804         (-[DataInteractionSimulator initWithWebView:]):
3805         (-[DataInteractionSimulator runFrom:to:]):
3806         (-[DataInteractionSimulator _advanceProgress]):
3807         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
3808         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
3809         (-[MockDataInteractionSession initWithWindow:]): Deleted.
3810
3811 2017-07-07  Commit Queue  <commit-queue@webkit.org>
3812
3813         Unreviewed, rolling out r219238, r219239, and r219241.
3814         https://bugs.webkit.org/show_bug.cgi?id=174265
3815
3816         "fast/workers/dedicated-worker-lifecycle.html is flaky"
3817         (Requested by yusukesuzuki on #webkit).
3818
3819         Reverted changesets:
3820
3821         "[WTF] Implement WTF::ThreadGroup"
3822         https://bugs.webkit.org/show_bug.cgi?id=174081
3823         http://trac.webkit.org/changeset/219238
3824
3825         "Unreviewed, build fix after r219238"
3826         https://bugs.webkit.org/show_bug.cgi?id=174081
3827         http://trac.webkit.org/changeset/219239
3828
3829         "Unreviewed, CLoop build fix after r219238"
3830         https://bugs.webkit.org/show_bug.cgi?id=174081
3831         http://trac.webkit.org/changeset/219241
3832
3833 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
3834
3835         [GTK][WPE] Enable X-Content-Type-Options: nosniff
3836         https://bugs.webkit.org/show_bug.cgi?id=174250
3837
3838         Reviewed by Carlos Alberto Lopez Perez.
3839
3840         * Scripts/webkitperl/FeatureList.pm:
3841
3842 2017-07-07  Charlie Turner  <cturner@igalia.com>
3843         [GStreamer] vid.me videos do not play
3844         https://bugs.webkit.org/show_bug.cgi?id=172240
3845
3846         Reviewed by Xabier Rodriguez-Calvar.
3847
3848         Build httpsoupsrc again for use in adaptive streaming pipelines, and
3849         have the existing libsoup build against GNOME to avoid header drift
3850         against GStreamer's linked Soup library.
3851
3852         * gtk/jhbuild.modules:
3853
3854 2017-07-06  Lucas Forschler  <lforschler@apple.com>
3855
3856         Write a support script to enable buildbot to upload to S3
3857         https://bugs.webkit.org/show_bug.cgi?id=174196
3858         
3859         Reviewed by Stephanie Lewis.
3860
3861         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
3862         (uploadToS3):
3863         (archiveExists):
3864
3865 2017-07-06  Lucas Forschler  <lforschler@apple.com>
3866
3867         Enabling uploading archives to S3.
3868         https://bugs.webkit.org/show_bug.cgi?id=174198
3869         
3870         Reviewed by Stephanie Lewis.
3871
3872         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3873         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
3874         (UploadMinifiedBuiltProduct): Upload minified archive to build master
3875         (TransferToS3): Transfer full and minified archives to S3
3876
3877 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3878
3879         [WTF] Implement WTF::ThreadGroup
3880         https://bugs.webkit.org/show_bug.cgi?id=174081
3881
3882         Reviewed by Mark Lam.
3883
3884         Add WTF::ThreadGroup tests.
3885
3886         * TestWebKitAPI/CMakeLists.txt:
3887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3888         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
3889         (TestWebKitAPI::TEST):
3890
3891 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3892
3893         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3894         https://bugs.webkit.org/show_bug.cgi?id=174150
3895
3896         Reviewed by Mark Lam.
3897
3898         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3899         (TestWebKitAPI::TEST):
3900         * TestWebKitAPI/TestsController.cpp:
3901         (TestWebKitAPI::TestsController::TestsController):
3902
3903 2017-07-06  Lucas Forschler  <lforschler@apple.com>
3904
3905         Enabling uploading archives to S3.
3906         https://bugs.webkit.org/show_bug.cgi?id=174198
3907         
3908         Reviewed by Lucas Forschler.
3909
3910         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3911         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
3912         (UploadMinifiedBuiltProduct): Upload minified archive to build master
3913         (TransferToS3): Transfer full and minified archives to S3
3914
3915 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3916
3917         [GTK][WPE] kill-old-process should kill more webkit related process
3918         https://bugs.webkit.org/show_bug.cgi?id=174220
3919
3920         Reviewed by Michael Catanzaro.
3921
3922         Generate list of possible webkit-related process names and add
3923         them to the list of process to kill.
3924         Also update the possible system related process for GTK+/WPE.
3925
3926         * BuildSlaveSupport/kill-old-processes:
3927         (listAllWebKitPrograms):
3928         (main):
3929
3930 2017-07-06  Chris Dumez  <cdumez@apple.com>
3931
3932         FileMonitor should not be ref counted
3933         https://bugs.webkit.org/show_bug.cgi?id=174166
3934
3935         Reviewed by Brent Fulgham.
3936
3937         Update the API tests to reflect the API change.
3938
3939         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3940         (TestWebKitAPI::TEST_F):
3941
3942 2017-07-06  Commit Queue  <commit-queue@webkit.org>
3943
3944         Unreviewed, rolling out r219194.
3945         https://bugs.webkit.org/show_bug.cgi?id=174207
3946
3947         it broke some layout tests (Requested by clopez on #webkit).
3948
3949         Reverted changeset:
3950
3951         "[GStreamer] vid.me videos do not play"
3952         https://bugs.webkit.org/show_bug.cgi?id=172240
3953         http://trac.webkit.org/changeset/219194
3954
3955 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3956
3957         Unreviewed, rolling out r219178.
3958
3959         This caused a consistent failure with the API test
3960         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3961
3962         Reverted changeset:
3963
3964         "[WTF] Clean up StringStatics.cpp by using
3965         LazyNeverDestroyed<> for Atoms"
3966         https://bugs.webkit.org/show_bug.cgi?id=174150
3967         http://trac.webkit.org/changeset/219178
3968
3969 2017-07-06  Alicia Boya García  <aboya@igalia.com>
3970
3971         Add CWD to Perl library path (no longer the default since 5.26.0)
3972         https://bugs.webkit.org/show_bug.cgi?id=174200
3973
3974         Reviewed by Michael Catanzaro.
3975
3976         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3977         (SetupGitClone._get_username_and_email):
3978
3979 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3980
3981         Unreviewed, update my email address.
3982
3983         * Scripts/webkitpy/common/config/contributors.json:
3984
3985 2017-07-06  Charlie Turner  <cturner@igalia.com>
3986         [GStreamer] vid.me videos do not play
3987         https://bugs.webkit.org/show_bug.cgi?id=172240
3988
3989         Reviewed by Xabier Rodriguez-Calvar.
3990
3991         Build httpsoupsrc again for use in adaptive streaming pipelines, and
3992         have the existing libsoup build against GNOME to avoid header drift
3993         against GStreamer's linked Soup library.
3994
3995         * gtk/jhbuild.modules:
3996
3997 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3998
3999         [WTF] Move SoftLinking.h into WTF
4000         https://bugs.webkit.org/show_bug.cgi?id=174000
4001
4002         Reviewed by Alex Christensen.
4003
4004         * DumpRenderTree/mac/TestRunnerMac.mm:
4005         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4006         (test_primary_header):
4007         (ErrorCollector.__init__): Deleted.
4008         (ErrorCollector.__call__): Deleted.
4009         (ErrorCollector.results): Deleted.
4010         (ErrorCollector.result_list): Deleted.
4011         (ErrorCollector.verify_all_categories_are_seen): Deleted.
4012         (MockIo.open): Deleted.
4013         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
4014         (CppFunctionsTest.test_create_acronym): Deleted.
4015         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
4016         (CppFunctionsTest.test_parameter): Deleted.
4017         (CppFunctionsTest.test_single_line_view): Deleted.
4018         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
4019         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
4020         (CppFunctionsTest.test_parameter_list): Deleted.
4021         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
4022         (CppStyleTestBase.process_file_data): Deleted.
4023         (CppStyleTestBase.perform_lint): Deleted.
4024         (CppStyleTestBase.perform_single_line_lint): Deleted.
4025         (CppStyleTestBase.perform_multi_line_lint): Deleted.
4026         (CppStyleTestBase.perform_language_rules_check): Deleted.
4027         (CppStyleTestBase.perform_function_lengths_check): Deleted.
4028         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
4029         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
4030         (CppStyleTestBase.perform_include_what_you_use): Deleted.
4031         (CppStyleTestBase.perform_header_guard_check): Deleted.
4032         (CppStyleTestBase.assert_lint): Deleted.
4033         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
4034         (CppStyleTestBase.assert_multi_line_lint): Deleted.
4035         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
4036         (CppStyleTestBase.assert_language_rules_check): Deleted.
4037         (CppStyleTestBase.assert_include_what_you_use): Deleted.
4038         (CppStyleTestBase.assert_header_guard): Deleted.
4039         (CppStyleTestBase.assert_blank_lines_check): Deleted.
4040         (CppStyleTestBase.assert_positions_equal): Deleted.
4041         (FunctionDetectionTest.test_basic_function_detection): Deleted.
4042         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
4043         (FunctionDetectionTest.test_pure_function_detection): Deleted.
4044         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
4045         (FunctionDetectionTest.test_ignore_macros): Deleted.
4046         (FunctionDetectionTest.test_non_functions): Deleted.
4047         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
4048         (FunctionDetectionTest.test_parameter_list): Deleted.
4049         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
4050         (CppStyleTest.test_asm_lines_ignored): Deleted.
4051         (CppStyleTest.test_get_line_width): Deleted.
4052         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
4053         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
4054         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
4055         (CppStyleTest.test_position): Deleted.
4056         (CppStyleTest.test_rfind_in_lines): Deleted.
4057         (CppStyleTest.test_close_expression): Deleted.
4058         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
4059         (CppStyleTest.test_cstyle_cast): Deleted.
4060         (CppStyleTest.test_runtime_casting): Deleted.
4061         (CppStyleTest.test_runtime_selfinit): Deleted.
4062         (CppStyleTest.test_runtime_rtti): Deleted.
4063         (CppStyleTest.test_static_cast_readability): Deleted.
4064         (CppStyleTest.test_check_for_unnamed_params): Deleted.
4065         (CppStyleTest.void): Deleted.
4066         (CppStyleTest.test_deprecated_cast): Deleted.
4067         (CppStyleTest.test_mock_method): Deleted.
4068         (CppStyleTest.test_sizeof_type): Deleted.
4069         (CppStyleTest.cases): Deleted.
4070         (CppStyleTest.for): Deleted.
4071         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
4072         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
4073         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
4074         (CppStyleTest.test_include_what_you_use): Deleted.
4075         (CppStyleTest.test_files_belong_to_same_module): Deleted.
4076         (CppStyleTest.test_cleanse_line): Deleted.
4077         (CppStyleTest.test_multi_line_comments): Deleted.
4078         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
4079         (CppStyleTest.test_multiline_strings): Deleted.
4080         (CppStyleTest.test_platformh_comments): Deleted.
4081         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
4082         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
4083         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
4084         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
4085         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
4086         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
4087         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
4088         (CppStyleTest.test_check_posix_threading): Deleted.
4089         (CppStyleTest.test_insecure_string_operations): Deleted.
4090         (CppStyleTest.test_format_strings): Deleted.
4091         (CppStyleTest.test_insecure_temp_file): Deleted.
4092         (CppStyleTest.test_variable_length_array_detection): Deleted.
4093         (CppStyleTest.test_braces): Deleted.
4094         (CppStyleTest.test_check_check): Deleted.
4095         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
4096         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
4097         (CppStyleTest.test_spacing_for_fncall): Deleted.
4098         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
4099         (CppStyleTest.test_spacing_before_braces): Deleted.
4100         (CppStyleTest.test_spacing_between_braces): Deleted.
4101         (CppStyleTest.test_spacing_before_brackets): Deleted.
4102         (CppStyleTest.test_cpp_lambda_functions): Deleted.
4103         (CppStyleTest.test_objective_c_block): Deleted.
4104         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
4105         (CppStyleTest.test_spacing_around_else): Deleted.
4106         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
4107         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
4108         (CppStyleTest.test_operator_methods): Deleted.
4109         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
4110         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
4111         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
4112         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
4113         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
4114         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
4115         (CppStyleTest.test_space_after_comment_marker): Deleted.
4116         (CppStyleTest.test_newline_at_eof): Deleted.
4117         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
4118         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
4119         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
4120         (CppStyleTest.test_invalid_utf8): Deleted.
4121         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
4122         (CppStyleTest.test_is_blank_line): Deleted.
4123         (CppStyleTest.test_blank_lines_check): Deleted.
4124         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
4125         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
4126         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
4127         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
4128         (CppStyleTest.test_comma): Deleted.
4129         (CppStyleTest.test_declaration): Deleted.
4130         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
4131         (CppStyleTest.test_indent): Deleted.
4132         (CppStyleTest.test_indent.Foo): Deleted.
4133         (CppStyleTest.test_not_alabel): Deleted.
4134         (CppStyleTest.test_tab): Deleted.
4135         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
4136         (CppStyleTest.test_build_class): Deleted.
4137         (CppStyleTest.test_build_class.definitions): Deleted.
4138         (CppStyleTest.test_build_class.Foo): Deleted.
4139         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
4140         (CppStyleTest.test_build_end_comment): Deleted.
4141         (CppStyleTest.test_build_forward_decl): Deleted.
4142         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
4143         (CppStyleTest.test_build_header_guard): Deleted.
4144         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
4145         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
4146         (CppStyleTest.test_build_printf_format): Deleted.
4147         (CppStyleTest.test_runtime_printf_format): Deleted.
4148         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
4149         (CppStyleTest.test_build_storage_class): Deleted.
4150         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
4151         (CppStyleTest.test_build_storage_class.declaration): Deleted.
4152         (CppStyleTest.test_build_storage_class.after): Deleted.
4153         (CppStyleTest.test_build_storage_class.is): Deleted.
4154         (CppStyleTest.test_legal_copyright): Deleted.
4155         (CppStyleTest.test_invalid_increment): Deleted.
4156         (CppStyleTest.test_enum_bitfields): Deleted.
4157         (CppStyleTest.test_plain_integral_bitfields): Deleted.
4158         (CleansedLinesTest.test_init_empty): Deleted.
4159         (CleansedLinesTest.test_collapse_strings): Deleted.
4160         (OrderOfIncludesTest.tearDown): Deleted.
4161         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
4162         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
4163         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
4164         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
4165         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
4166         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
4167         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
4168         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
4169         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
4170         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
4171         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
4172         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
4173         (OrderOfIncludesTest.test_primary_header): Deleted.
4174         (OrderOfIncludesTest.test_public_primary_header): Deleted.
4175         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
4176         (OrderOfIncludesTest.test_classify_include): Deleted.
4177         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
4178         (CheckForFunctionLengthsTest.tearDown): Deleted.
4179         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
4180         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
4181         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
4182         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
4183         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
4184         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
4185         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
4186         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
4187         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
4188         (CheckForFunctionLengthsTest.function_body): Deleted.
4189         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
4190         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
4191         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
4192         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
4193         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
4194         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
4195         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
4196         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
4197         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
4198         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
4199         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
4200         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
4201         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
4202         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
4203         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
4204         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
4205         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
4206         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
4207         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
4208         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
4209         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
4210         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
4211         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
4212         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
4213         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
4214         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
4215         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
4216         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
4217         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
4218         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
4219         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
4220         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
4221         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
4222         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
4223         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
4224         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
4225         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
4226         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
4227         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
4228         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
4229         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
4230         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
4231         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
4232         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
4233         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
4234         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
4235         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
4236         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
4237         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
4238         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
4239         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
4240         (NoNonVirtualDestructorsTest.test_destructor_no