WebKitTestRunner leaks strings in generateWhitelist()
[WebKit-https.git] / Tools / ChangeLog
1 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
2
3         WebKitTestRunner leaks strings in generateWhitelist()
4         https://bugs.webkit.org/show_bug.cgi?id=145665
5
6         Reviewed by Myles C. Maxfield.
7
8         * WebKitTestRunner/mac/TestControllerMac.mm:
9         (WTR::generateWhitelist):
10
11 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
12
13         Fix options in build-jsc for CMake builds
14         https://bugs.webkit.org/show_bug.cgi?id=145636
15
16         Reviewed by Gyuyoung Kim.
17
18         CMake only accepts -DXXX=YYY style options.
19         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
20
21         * Scripts/build-jsc:
22
23 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
24
25         Added a patch so that the colors displayed on the page could be toggled
26         in case people need accessibility colors displayed in their browser.
27         https://bugs.webkit.org/show_bug.cgi?id=145570
28         <rdar://problem/20994468>
29
30         Added in CSS colors and toggle buttons for checkmarks in the page, so that
31         the page could be rendered in a specific way for accessibility needs if needed.
32
33         Reviewed by Alexey Proskuryakov.
34
35         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
36         (updateHiddenPlatforms):
37         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
38         (toggleAccessibilityColors): Toggle colors on and off
39         (documentReady): Needed to make changes to the initialization
40         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
41         (a:hover):
42         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
43         (div.cellButton.hide, div.accessibilityButton.hide):
44         (div.cellButton.unhide, div.accessibilityButton.unhide):
45         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
46         (.popover-tracking:hover):
47         (.accessibilityButton):
48         (div.cellButton): Deleted.
49         (div.cellButton.hide): Deleted.
50         (div.cellButton.unhide): Deleted.
51         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
52         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
53         (.status-line.neutral .bubble):
54         (.status-line.unauthorized .bubble):
55         (.status-line.danger .bubble.pictogram):
56         (.status-line.bad .bubble.pictogram):
57         (.status-line.no-bubble .message):
58         (.status-line.bad .bubble):
59         (.status-line.good .bubble):
60         (.status-line.good .message):
61         (.status-line.bad .message):
62         (body.accessibility-colors .status-line.good .bubble):
63         (body.accessibility-colors .status-line.bad .bubble):
64         (body.accessibility-colors .status-line.good .message):
65         (body.accessibility-colors .status-line.bad .message):
66         (.status-line.danger .message):
67         (.status-line.unauthorized .message):
68
69 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
70
71         Unreviewed build fix for Dromaeo.
72
73         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
74         (BenchmarkResults._aggregate_results_for_test):
75
76 2015-06-03  Anders Carlsson  <andersca@apple.com>
77
78         Fix build.
79
80         * DumpRenderTree/mac/TestRunnerMac.mm:
81
82 2015-06-03  Daniel Bates  <dabates@apple.com>
83
84         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
85         https://bugs.webkit.org/show_bug.cgi?id=145616
86
87         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
88         of the test. Further investigation is needed.
89
90         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
91         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
92
93 2015-06-03  Brady Eidson  <beidson@apple.com>
94
95         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
96         https://bugs.webkit.org/show_bug.cgi?id=145580
97
98         Reviewed by Mark Lam.
99
100         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
101         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
102
103 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
104
105         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
106
107         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
108         (TestWebKitAPI::TEST): Update the syntax.
109
110 2015-06-02  Mark Lam  <mark.lam@apple.com>
111
112         build-jsc's --cloop option is broken.
113         https://bugs.webkit.org/show_bug.cgi?id=145516
114
115         Reviewed by Darin Adler.
116
117         * Scripts/build-jsc:
118         - Make sure to disable the JIT when --cloop is specified.
119           Did analogous fix for --ftljit.
120
121 2015-06-02  Daniel Bates  <dabates@apple.com>
122
123         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
124
125         Rubber-stamped by Alexey Proskuryakov.
126
127         * MiniBrowser/mac/Info.plist:
128         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
129
130 2015-06-01  Commit Queue  <commit-queue@webkit.org>
131
132         Unreviewed, rolling out r185066.
133         https://bugs.webkit.org/show_bug.cgi?id=145543
134
135         it breaks the FTL JIT builds with a local checkout of llvm
136         (Requested by pizlo on #webkit).
137
138         Reverted changeset:
139
140         "build-jsc's --cloop option is broken."
141         https://bugs.webkit.org/show_bug.cgi?id=145516
142         http://trac.webkit.org/changeset/185066
143
144 2015-06-01  Daniel Bates  <dabates@apple.com>
145
146         Notify client that we began editing when text field is focused
147         https://bugs.webkit.org/show_bug.cgi?id=145439
148         <rdar://problem/21142108>
149
150         Reviewed by Anders Carlsson.
151
152         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
153         a text field is focused and defocused.
154
155         * TestWebKitAPI/CMakeLists.txt:
156         * TestWebKitAPI/PlatformEfl.cmake:
157         * TestWebKitAPI/PlatformGTK.cmake:
158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
159         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
160         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
161         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
162         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
163         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
164         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
165         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
166         (TestWebKitAPI::TEST_F):
167         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
168         (TestWebKitAPI::textFieldDidBeginEditing):
169         (TestWebKitAPI::textFieldDidEndEditing):
170         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
171         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
172         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
173
174 2015-06-01  Alex Christensen  <achristensen@webkit.org>
175
176         [Content Extensions] resource-type and load-type should be independent.
177         https://bugs.webkit.org/show_bug.cgi?id=145528
178         rdar://problem/21190765
179
180         Reviewed by Benjamin Poulain.
181
182         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
183         (TestWebKitAPI::TEST_F):
184
185 2015-06-01  Daniel Bates  <dabates@apple.com>
186
187         Add ATS keys to WebKitTestRunnerApp
188         https://bugs.webkit.org/show_bug.cgi?id=145519
189
190         Reviewed by Alexey Proskuryakov.
191
192         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
193
194         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
195
196 2015-06-01  Brady Eidson  <beidson@apple.com>
197
198         Add WKTR support for "should open external URLs".
199         https://bugs.webkit.org/show_bug.cgi?id=145505
200
201         Reviewed by Darin Adler.
202
203         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
204           "should open external URLs" bit set.
205         
206         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
207           the policy delegate, including whether or not the bit was set.
208         
209         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
210         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
211         (WTR::TestRunner::queueLoad):
212         * WebKitTestRunner/InjectedBundle/TestRunner.h:
213         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
214         (WTR::TestRunner::shouldDumpPolicyCallbacks):
215         
216         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
217         (WTR::InjectedBundle::queueLoad):
218         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
219
220         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
221         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
222
223         * WebKitTestRunner/TestInvocation.cpp:
224         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
225
226         * WebKitTestRunner/WorkQueueManager.cpp:
227         (WTR::WorkQueueManager::queueLoad):
228         * WebKitTestRunner/WorkQueueManager.h:
229
230 2015-06-01  Mark Lam  <mark.lam@apple.com>
231
232         build-jsc's --cloop option is broken.
233         https://bugs.webkit.org/show_bug.cgi?id=145516
234
235         Reviewed by Darin Adler.
236
237         * Scripts/build-jsc:
238         - Make sure to disable the JIT when --cloop is specified.
239           Did analogous fix for --ftljit.
240
241 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
242
243         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
244         https://bugs.webkit.org/show_bug.cgi?id=144959
245
246         Reviewed by Darin Adler.
247
248         * Scripts/webkitpy/style/checkers/cmake.py:
249         (CMakeChecker.check): Use enumerate instead of xrange.
250         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
251         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
252         (CMakeCheckerTest.test_check): Update the expected results.
253
254 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
255
256         Fix the webkitpy scm unittests after r174051
257         https://bugs.webkit.org/show_bug.cgi?id=145511
258
259         Reviewed by Darin Adler.
260
261         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
262         (GitTestWithMock.make_scm):
263
264 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
265
266         EWS provides misleading information for not applyable patches
267         https://bugs.webkit.org/show_bug.cgi?id=145307
268
269         Reviewed by Alexey Proskuryakov.
270
271         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
272
273 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
274
275         Further tweak results of WebKit1.StringTruncator after r184965.
276
277         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
278
279 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
280
281         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
282         https://bugs.webkit.org/show_bug.cgi?id=145264
283
284         Reviewed by Carlos Garcia Campos.
285
286         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
287
288 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
289
290         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
291
292         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
293         (BenchmarkResults._lint_subtest_results):
294         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
295         (test_aggregate_nested_results):
296         (test_lint_results):
297         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
298
299 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
300
301         run-benchmark should print out the results
302         https://bugs.webkit.org/show_bug.cgi?id=145398
303
304         Reviewed by Antti Koivisto.
305
306         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
307         of the output to catch early errors.
308
309         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
310         (BenchmarkResults): Added.
311         (BenchmarkResults.__init__): Added.
312         (BenchmarkResults.format): Added.
313         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
314         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
315         Uses the sample standard deviation to compute the significant figures for the value.
316         (BenchmarkResults._unit_from_metric): Added.
317         (BenchmarkResults._aggregate_results): Added.
318         (BenchmarkResults._aggregate_results_for_test): Added.
319         (BenchmarkResults._flatten_list): Added.
320         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
321         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
322         (BenchmarkResults._aggregate_values): Added.
323         (BenchmarkResults._lint_results): Added.
324         (BenchmarkResults._lint_subtest_results): Added.
325         (BenchmarkResults._lint_aggregator_list): Added.
326         (BenchmarkResults._lint_configuration): Added.
327         (BenchmarkResults._lint_values): Added.
328         (BenchmarkResults._is_numeric): Added.
329         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
330         (BenchmarkResultsTest):
331         (BenchmarkResultsTest.test_init):
332         (BenchmarkResultsTest.test_format):
333         (test_format_values_with_large_error):
334         (test_format_values_with_small_error):
335         (test_format_values_with_time):
336         (test_format_values_with_no_error):
337         (test_format_values_with_small_difference):
338         (test_aggregate_results):
339         (test_aggregate_results_with_gropus):
340         (test_aggregate_nested_results):
341         (test_lint_results):
342         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
343         (BenchmarkRunner.execute): Added a call to show_results
344         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
345         (BenchmarkRunner.show_results): Added.
346
347 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
348
349         run_benchmark should have an option to specify the number of runs
350         https://bugs.webkit.org/show_bug.cgi?id=145091
351
352         Reviewed by Antti Koivisto.
353
354         Added --count option.
355
356         * Scripts/run-benchmark:
357         (main):
358         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
359         (BenchmarkRunner.__init__):
360
361 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
362
363         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
364
365         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
366
367 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
368
369         Update results of WebKit1.StringTruncator after r184965.
370
371         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
372
373 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
374
375         Unreviewed, updated my list of email addresses.
376
377         * Scripts/webkitpy/common/config/contributors.json:
378
379 2015-05-27  Dean Jackson  <dino@apple.com>
380
381         img.currentSrc problem in strict mode with old picturefill
382         https://bugs.webkit.org/show_bug.cgi?id=144095
383         <rdar://problem/21087013>
384
385         Reviewed by Simon Fraser.
386
387         Add a PICTURE_SIZES flag.
388
389         * Scripts/webkitperl/FeatureList.pm:
390
391 2015-05-26  Dana Burkart  <dburkart@apple.com>
392
393         Fixes compatibility issues with recent dashboard cleanup.
394         https://bugs.webkit.org/show_bug.cgi?id=144814
395
396         Reviewed by Alexey Proskuryakov.
397
398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
399         (BuildbotStaticAnalyzerQueueView):
400         (BuildbotStaticAnalyzerQueueView.prototype.update):
401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
402         (documentReady):
403
404 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
405
406         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
407         https://bugs.webkit.org/show_bug.cgi?id=143091
408         rdar://problem/19330328
409
410         Reviewed by Darin Adler and Timothy Hatcher.
411
412         We have many of these, which are hard to fit on the dashboard. Added a view that
413         collapses to a single green bubble when everything is good, and expands when there
414         are failures (or manually).
415
416         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
417
418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
419         (Buildbot.prototype.set isAuthenticated):
420         (Buildbot.prototype._normalizeQueueInfo):
421         (Buildbot.prototype._normalizeQueuesInfo):
422         (Buildbot.prototype.updateQueues):
423         Moved queue info normalization here from BuildbitQueue. The latter is a model class
424         that shouldn't have to know about presentation, and this lets us leep the knowledge
425         about combined queues out if it. Later, we can refactor existing code, and move out
426         all knowledge about headings and such.
427
428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
429         Added the new view. It's not quite universal, and doesn't have as helpful popovers
430         as other views, but we can extend it when/if we use it for more than JSC.
431
432         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
433         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
434
435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
436         (documentReady): Added support for combined queues. These are currently always ending up
437         in Other column, but it's easy to customize in the future if we need to.
438
439         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
440         (WebKitBuildbot): Added JSC queus.
441
442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
443         (.combined-queue-popover):
444         (.combined-queue-popover .revision):
445         Added styles for the combined view.
446
447 2015-05-26  Dan Bernstein  <mitz@apple.com>
448
449         Changed a file to use Unix line endings.
450
451         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
452
453 2015-05-26  Dan Bernstein  <mitz@apple.com>
454
455         <rdar://problem/21104551> Update build settings
456
457         Reviewed by Anders Carlsson.
458
459         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
460         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
461         * MiniBrowser/Configurations/DebugRelease.xcconfig:
462         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
463         * WebEditingTester/Configurations/DebugRelease.xcconfig:
464         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
465         * asan/asan.xcconfig:
466
467 2015-05-26  Anders Carlsson  <andersca@apple.com>
468
469         Fix build.
470
471         * WebKitTestRunner/mac/EventSenderProxy.mm:
472         (WTR::EventSenderProxy::mouseForceDown):
473         (WTR::EventSenderProxy::mouseForceUp):
474         (WTR::EventSenderProxy::mouseForceChanged):
475
476 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
477
478         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
479         https://bugs.webkit.org/show_bug.cgi?id=145342
480
481         Reviewed by Darin Adler.
482
483         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
484         (BuildbotIteration.prototype._parseData):
485
486 2015-05-26  Milan Crha  <mcrha@redhat.com>
487
488         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
489         https://bugs.webkit.org/show_bug.cgi?id=138134
490
491         Reviewed by Žan Doberšek.
492
493         * gtk/generate-inspector-gresource-manifest.py:
494         (get_filenames): Command line with expanded resources exceeds 32KB, which
495         is a limit on Windows. It's better to expand wildcards inside the python script.
496
497 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
498
499         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
500         https://bugs.webkit.org/show_bug.cgi?id=140882
501
502         Reviewed by Gustavo Noronha Silva.
503
504         Make sure unit tests write IndexedDB databases to the temporary
505         directory, and add a test case to check that the directory is
506         correctly created at the expected path.
507
508         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
509         (testWebContextConfiguration):
510         (serverCallback):
511         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
512         (Test::Test):
513
514 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
515
516         [GTK] Enable IndexedDB
517         https://bugs.webkit.org/show_bug.cgi?id=98932
518
519         Reviewed by Žan Doberšek.
520
521         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
522
523 2015-05-24  Sam Weinig  <sam@webkit.org>
524
525         Crash when using a removed ScriptMessageHandler
526         <rdar://problem/20888499>
527         https://bugs.webkit.org/show_bug.cgi?id=145359
528
529         Reviewed by Dan Bernstein.
530
531         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
532         Add tests for removing script message handlers.
533
534 2015-05-23  Dan Bernstein  <mitz@apple.com>
535
536         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
537         https://bugs.webkit.org/show_bug.cgi?id=145345
538
539         Reviewed by Sam Weinig.
540
541         * DumpRenderTree/mac/Configurations/Base.xcconfig:
542         * LayoutTestRelay/Configurations/Base.xcconfig:
543         * TestWebKitAPI/Configurations/Base.xcconfig:
544         * WebKitTestRunner/Configurations/Base.xcconfig:
545
546 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
547
548         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
549         https://bugs.webkit.org/show_bug.cgi?id=144848
550
551         Reviewed by Darin Adler.
552
553         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
554
555         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
556
557 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
558
559         Fix one more merge error in static analyzer support.
560
561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
562         (BuildbotStaticAnalyzerQueueView):
563
564 2015-05-22  Dana Burkart  <dburkart@apple.com>
565
566         Fix internal dashboard breakage from recent commit.
567         https://bugs.webkit.org/show_bug.cgi?id=144814
568
569         Unreviewed build fix.
570
571         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
572         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
573         (BuildbotStaticAnalyzerQueueView.prototype.update):
574
575 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
576
577         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
578         https://bugs.webkit.org/show_bug.cgi?id=130463
579         rdar://problem/20461342
580
581         Reviewed by Tim Horton.
582
583         This was more of a timing related flakiness than an actual OS version specific bug,
584         we weren't getting window visibility notifications.
585         
586         I will look into adding this function call to DumpRenderTree separately, layout tests
587         might actually rely on the broken behavior.
588
589         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
590         (TestWebKitAPI::TEST_F):
591         * TestWebKitAPI/mac/mainMac.mm:
592         (main):
593
594 2015-05-22  Dana Burkart  <dburkart@apple.com>
595
596         Add missing file from r184804 (mis-applied diff).
597         https://bugs.webkit.org/show_bug.cgi?id=144814
598
599         Reviewed by Alexey Proskuryakov.
600
601         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
602         (BuildbotStaticAnalyzerQueueView):
603         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
604         (BuildbotStaticAnalyzerQueueView.prototype.update):
605
606 2015-05-22  Dana Burkart  <dburkart@apple.com>
607
608         Add support to the botwatchers dashboard for a static analyzer bot.
609         https://bugs.webkit.org/show_bug.cgi?id=144814
610
611         Reviewed by Alexey Proskuryakov.
612
613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
614         scan-build should be considered a productive step.
615
616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
617         (BuildbotQueue):
618         Adds support for the staticAnalyzer property
619
620         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
621         (BuildbotTestResults.prototype._parseResults):
622         Get bug count from the scan-build step output
623
624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
625         (documentReady):
626         Rename the performance column 'Other', and merge the current 'Other' column with it.
627
628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
629         (WebKitBuildbot):
630         Now that performance bots are part of the 'Other' column, give them better headings.
631
632 2015-05-22  Tim Horton  <timothy_horton@apple.com>
633
634         Turn on autosaving of toolbar configuration in MiniBrowser
635
636         Rubber-stamped by Dan Bernstein.
637
638         * MiniBrowser/mac/BrowserWindow.xib:
639
640 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
641
642         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
643         https://bugs.webkit.org/show_bug.cgi?id=145297
644
645         Reviewed by Tim Horton.
646
647         This is a refactoring to simplify code, and to make it more logical.
648
649         It is up to the view to decide how to present the queues, and whether to split
650         them into debug and release, or in some different way.
651
652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
653         (BuildbotBuilderQueueView.filterQueues):
654         (BuildbotBuilderQueueView):
655         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
656         (BuildbotLeaksQueueView):
657         (BuildbotLeaksQueueView.prototype.update):
658         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
659         (BuildbotPerformanceQueueView):
660         (BuildbotPerformanceQueueView.prototype.update):
661         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
662         (BuildbotQueueView):
663         (BuildbotQueueView.prototype._updateQueues):
664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
665         (BuildbotTesterQueueView):
666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
667         (documentReady):
668
669 2015-05-22  Tim Horton  <timothy_horton@apple.com>
670
671         Remove action menu support
672         https://bugs.webkit.org/show_bug.cgi?id=145305
673         <rdar://problem/21070771>
674
675         Reviewed by Anders Carlsson.
676
677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
678         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
679         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
680         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
681         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
682         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
683         Remove the tests.
684
685 2015-05-22  Dan Bernstein  <mitz@apple.com>
686
687         Removed the Use Shrink To Fit button from the toolbar’s default set.
688
689         Rubber-stamped by Tim Horton.
690
691         * MiniBrowser/mac/BrowserWindow.xib:
692
693 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
694
695         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
696         https://bugs.webkit.org/show_bug.cgi?id=128420
697
698         Reviewed by Chris Fleizach.
699
700         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
701         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
702
703 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
704
705         [EFL] Bump libsoup version to 2.50.0
706         https://bugs.webkit.org/show_bug.cgi?id=145127
707
708         Reviewed by Gyuyoung Kim.
709
710         * efl/jhbuild.modules:
711         * efl/patches/soup-clang-warning-fix1.patch: Removed.
712         * efl/patches/soup-clang-warning-fix2.patch: Removed.
713
714 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
715
716         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
717         https://bugs.webkit.org/show_bug.cgi?id=145117
718
719         Reviewed by Csaba Osztrogonác.
720
721         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
722         Tools/TestWebKitAPI/Tests/WTF/glib/.
723
724         * TestWebKitAPI/PlatformGTK.cmake:
725         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
726         (TestWebKitAPI::TEST):
727
728 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
729
730         [EFL] fix efreet error
731         https://bugs.webkit.org/show_bug.cgi?id=143670
732
733         Reviewed by Gyuyoung Kim.
734
735         Fix efreet error by using external variable efreet_cache_update.
736         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
737         efreet error for efreet_cache does not occur.
738
739         * MiniBrowser/efl/main.c:
740         (elm_main):
741
742 2015-05-20  Michael Saboff  <msaboff@apple.com>
743
744         Add option to run_jsc_stress_tests to disable JIT testing
745         https://bugs.webkit.org/show_bug.cgi?id=145233
746
747         Reviewed by Mark Lam.
748
749         Added --no-jit option.
750
751         * Scripts/run-jsc-stress-tests:
752
753 2015-05-20  Alex Christensen  <achristensen@webkit.org>
754
755         Use correct String for StringView in WTF API tests
756         https://bugs.webkit.org/show_bug.cgi?id=145226
757         rdar://problem/20361786
758
759         Reviewed by Benjamin Poulain.
760
761         * TestWebKitAPI/Tests/WTF/StringView.cpp:
762         (TestWebKitAPI::TEST):
763         Use patternHolder for pattern.
764
765 2015-05-20  Alex Christensen  <achristensen@webkit.org>
766
767         [Content Extensions] Relax restrictions on triggers that match everything.
768         https://bugs.webkit.org/show_bug.cgi?id=145069
769
770         Reviewed by Benjamin Poulain.
771
772         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
773         (TestWebKitAPI::TEST_F):
774         Update and add tests for new possibilities with .*
775
776 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
777
778         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
779         https://bugs.webkit.org/show_bug.cgi?id=144992
780
781         Reviewed by Gyuyoung Kim.
782
783         * MiniBrowser/efl/main.c:
784         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
785         (on_key_down):
786         (on_fullscreen_enter):
787         (on_fullscreen_exit):
788         (window_create):
789
790 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
791
792         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
793         https://bugs.webkit.org/show_bug.cgi?id=145109
794
795         Reviewed by Darin Adler.
796
797         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
798         (TestWebKitAPI::TEST):
799
800 2015-05-19  Anders Carlsson  <andersca@apple.com>
801
802         Add alternate menu items for performing operations on the default data store
803         https://bugs.webkit.org/show_bug.cgi?id=145184
804
805         Reviewed by Sam Weinig.
806
807         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
808         associated with a data store.
809
810         * MiniBrowser/mac/AppDelegate.m:
811         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
812         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
813         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
814         * MiniBrowser/mac/MainMenu.xib:
815
816 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
817
818         Fix tautological-compare warning in AtomicString.cpp
819         https://bugs.webkit.org/show_bug.cgi?id=145120
820
821         Reviewed by Alexey Proskuryakov.
822
823         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
824         (TestWebKitAPI::TEST): Removed always true assert.
825
826 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
827
828         [EFL] Fix unsequenced warning in MiniBrowser's main.c
829         https://bugs.webkit.org/show_bug.cgi?id=145123
830
831         Reviewed by Gyuyoung Kim.
832
833         * MiniBrowser/efl/main.c:
834         (on_key_down):
835
836 2015-05-18  Daniel Bates  <dabates@apple.com>
837
838         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
839         when staged non-empty file for commit
840         https://bugs.webkit.org/show_bug.cgi?id=145082
841
842         Reviewed by Darin Adler.
843
844         Fixes two issues when running prepare-ChangeLog:
845             1. The function above a deleted function is reported as changed.
846             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
847             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
848             included in this patch).
849
850         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
851         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
852         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
853         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
854         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
855         VCSUtil::parseChunkRange() has existing test coverage.
856
857         * Scripts/prepare-ChangeLog:
858         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
859         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
860         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
861         examine files that only have deletions. Currently this works as a side effect of the behavior of
862         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
863         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
864         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
865         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
866         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
867         We return (-1, -1) when the change represents a deletion.
868         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
869         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
870         We return (-1, -1) when the change represents an addition.
871         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
872         unit tests.
873
874 2015-05-18  Anders Carlsson  <andersca@apple.com>
875
876         Add ATS keys to MiniBrowser
877         https://bugs.webkit.org/show_bug.cgi?id=145141
878
879         Reviewed by Sam Weinig.
880
881         * MiniBrowser/mac/Info.plist:
882
883 2015-05-17  David Kilzer  <ddkilzer@apple.com>
884
885         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
886         <http://webkit.org/b/145100>
887
888         Reviewed by Darin Adler.
889
890         * Scripts/bisect-builds:
891         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
892         - Switch to using PROMPT_RESPONSE_* constants when testing the
893           value of $didReproduceBug.
894         - Add do { } while loops to implement 'retry' mode.
895         (promptForTest):
896         - Switch to returning PROMPT_RESPONSE_* constants.
897         - Add support for 'retry' response.
898
899 2015-05-16  Tanay C  <tanay.c@samsung.com>
900
901         [EFL][WK2] Minibrowser : Add search icon to search bar
902         https://bugs.webkit.org/show_bug.cgi?id=139773
903
904         Reviewed by Gyuyoung Kim.
905
906         * MiniBrowser/efl/main.c: 
907         (search_icon_show): Added.
908         (search_box_show): Modified.
909
910 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
911
912         run_benchmark should have an option to specify the number of runs
913         https://bugs.webkit.org/show_bug.cgi?id=145091
914
915         Reviewed by Stephanie Lewis.
916
917         Added --count option.
918
919         * Scripts/run-benchmark:
920         (main):
921         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
922         (BenchmarkRunner.__init__):
923
924 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
925
926         Temporarily disable failing API test.
927
928         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
929         (TestWebKitAPI::TEST):
930
931 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
932
933         User interruption while running of run-webkit-tests should also generate results.html
934         https://bugs.webkit.org/show_bug.cgi?id=122154
935
936         Reviewed by Csaba Osztrogonác.
937
938         Generation of results.html on execution of run-webkit-tests happens only
939         on completion of entire layout tests run. It should be created even when
940         the execution has been interrupted - either by user (by pressing Ctrl+C)
941         or because of other interruptions (like exit-after-n-failures option).
942
943         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
944         (LayoutTestRunner.run_tests):
945         * Scripts/webkitpy/layout_tests/controllers/manager.py:
946         (Manager.run):
947         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
948         (TestRunResults.__init__):
949         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
950         (main):
951         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
952         (RunTest.test_keyboard_interrupt):
953         (MainTest.test_exception_handling):
954
955 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
956
957         [buildbot] Fix the URL of the performance bots
958         https://bugs.webkit.org/show_bug.cgi?id=145043
959
960         Reviewed by Ryosuke Niwa.
961
962         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
963
964 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
965
966         Add a layout mode that scales down the view to try to fit the document
967         https://bugs.webkit.org/show_bug.cgi?id=145022
968         <rdar://problem/19790341>
969
970         Reviewed by Dean Jackson.
971
972         * MiniBrowser/mac/BrowserWindow.xib:
973         * MiniBrowser/mac/BrowserWindowController.h:
974         * MiniBrowser/mac/WK2BrowserWindowController.m:
975         (-[WK2BrowserWindowController toggleShrinkToFit:]):
976         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
977         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
978
979 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
980
981         [CMake] Don't read the LOCATION property of targets
982         https://bugs.webkit.org/show_bug.cgi?id=145018
983
984         Reviewed by Martin Robinson.
985
986         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
987         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
988         be the same at configure-time as it is at generate-time.
989
990         * TestWebKitAPI/CMakeLists.txt:
991
992 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
993
994         Add String literal overloads to equalIgnoringASCIICase()
995         https://bugs.webkit.org/show_bug.cgi?id=145008
996
997         Reviewed by Benjamin Poulain.
998
999         Test changes to WTF.
1000
1001         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1002         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
1003         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
1004         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1005         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
1006         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
1007
1008 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1009
1010         SharedBuffer::createWithContentsOfFile should use map file routines
1011         https://bugs.webkit.org/show_bug.cgi?id=144192
1012
1013         Reviewed by Darin Adler.
1014
1015         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
1016
1017         * TestWebKitAPI/PlatformGTK.cmake:
1018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1019         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
1020         (TestWebKitAPI::FileSystemTest::tempFilePath):
1021         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
1022         (TestWebKitAPI::TEST_F):
1023         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
1024         (TestWebKitAPI::SharedBufferTest::tempFilePath):
1025         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
1026         (TestWebKitAPI::TEST_F):
1027
1028 2015-05-13  Alex Christensen  <achristensen@webkit.org>
1029
1030         [Content Extensions] Test interactions between multiple extensions and multiple domains.
1031         https://bugs.webkit.org/show_bug.cgi?id=144967
1032
1033         Reviewed by Benjamin Poulain.
1034
1035         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1036         Xcode wanted to fix an alphabetization issue.
1037         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1038         (TestWebKitAPI::TEST_F):
1039         Test interactions that worked but were not explicitly tested before.
1040
1041 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1042
1043         Unreviewed build fix.
1044
1045         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
1046
1047         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
1048
1049 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1050
1051         Fix the previous commit, which made both bubbles green.
1052
1053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1054         (.status-line.good .bubble):
1055         (.status-line.bad .bubble):
1056         (.status-line.good .message):
1057
1058 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1059
1060         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
1061         https://bugs.webkit.org/show_bug.cgi?id=144929
1062
1063         Reviewed by Eric Carlson.
1064
1065         Tweaked colors as I see fit.
1066
1067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1068         (.status-line.good .bubble):
1069         (.status-line.bad .bubble):
1070
1071 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
1072
1073         [Mac] Share cookie storage between UI process and secondary processes
1074         https://bugs.webkit.org/show_bug.cgi?id=144820
1075         rdar://problem/20572830
1076
1077         Reviewed by Darin Adler.
1078
1079         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1080         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
1081         for testing.
1082
1083 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
1084
1085         Fix internal build configuration issues
1086         https://bugs.webkit.org/show_bug.cgi?id=144762
1087
1088         Reviewed by David Kilzer.
1089
1090         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
1091
1092         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1093         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1094         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1095         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1096         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1097         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1098         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1099         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1100
1101 2015-05-12  David Kilzer  <ddkilzer@apple.com>
1102
1103         Switch to launching iOS Simulator using bundle ID
1104         <rdar://problem/20916096>
1105
1106         This is required to fix the layout tests on internal bots.
1107
1108         * Scripts/webkitdirs.pm:
1109         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
1110         Simulator.  Add FIXME.
1111         (quitIOSSimulator): Add FIXME.
1112         * Scripts/webkitpy/port/ios.py:
1113         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
1114         launch iOS Simulator.  Add FIXME.
1115         (IOSSimulatorPort.check_sys_deps): Add FIXME.
1116
1117 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
1118
1119         Fix run-javascriptcore-tests step on the WinCairo bot
1120         https://bugs.webkit.org/show_bug.cgi?id=144866
1121
1122         Reviewed by Csaba Osztrogonác.
1123
1124         Catch exception when failing to create soft link, so we can fall back to copy.
1125
1126         * Scripts/run-jsc-stress-tests:
1127
1128 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
1129
1130         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
1131         https://bugs.webkit.org/show_bug.cgi?id=116971
1132
1133         Reviewed by Chris Fleizach.
1134
1135         Implement rowAtIndex for ATK.
1136
1137         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1138         (WTR::AccessibilityUIElement::rowAtIndex):
1139
1140 2015-05-11  Dan Bernstein  <mitz@apple.com>
1141
1142         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
1143
1144         Reviewed by Alexey Proskuryakov.
1145
1146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1147         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
1148         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
1149         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
1150
1151 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
1152
1153         Fix internal build configuration issues
1154         https://bugs.webkit.org/show_bug.cgi?id=144762
1155
1156         Reviewed by Darin Adler.
1157
1158         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
1159
1160         * TestWebKitAPI/Configurations/Base.xcconfig:
1161         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1162         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1163         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1164         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1165         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1166         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1167
1168 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
1169
1170         [Win] Move Windows build target to Windows 7 (or newer)
1171         https://bugs.webkit.org/show_bug.cgi?id=144890
1172         <rdar://problem/20707307>
1173
1174         Reviewed by Anders Carlsson.
1175
1176         Update linked SDK and minimal Windows level to be compatible with
1177         Windows 7 or newer.
1178
1179         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1180         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1181         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1182         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1183         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1184         * DumpRenderTree/config.h:
1185         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1186         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1187         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1188         * WinLauncher/stdafx.h:
1189
1190 2015-05-11  Commit Queue  <commit-queue@webkit.org>
1191
1192         Unreviewed, rolling out r184119.
1193         https://bugs.webkit.org/show_bug.cgi?id=144888
1194
1195         broke JSC tests on Apple Windows bots (Requested by kling on
1196         #webkit).
1197
1198         Reverted changeset:
1199
1200         "Fix run-javascriptcore-tests step on the WinCairo bot"
1201         https://bugs.webkit.org/show_bug.cgi?id=144866
1202         http://trac.webkit.org/changeset/184119
1203
1204 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1205
1206         run-benchmark should support Dromaeo
1207         https://bugs.webkit.org/show_bug.cgi?id=144849
1208
1209         Reviewed by Chris Dumez.
1210
1211         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
1212         they can take as much as 15 minutes to run each.
1213
1214         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
1215         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
1216         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
1217         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
1218
1219 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1220
1221         Build fix. jetstream has a local copy, not remote archive.
1222
1223         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1224
1225 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1226
1227         run-benchmark should support SunSpider, Kraken and Octane
1228         https://bugs.webkit.org/show_bug.cgi?id=144840
1229
1230         Reviewed by Darin Adler.
1231
1232         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
1233         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
1234         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
1235         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
1236
1237         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
1238         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
1239
1240         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
1241         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
1242
1243         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
1244         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
1245         now has the ability to run an arbitrary "create script".
1246
1247         * Scripts/run-benchmark:
1248         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
1249         This also overrides the remote archive URL specified in the plan.
1250
1251         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
1252
1253         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
1254         JetStreamBenchmarkBuilder.
1255
1256         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
1257         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
1258         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
1259         _runCreateScript and _applyPatch to clean after themselves.
1260         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
1261         JetStream, SunSpider, Kraken all use this feature.
1262         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
1263         the leaf directory name since the latter is not available when a remote ZIP file is used.
1264         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
1265         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
1266         the benchmark name in the patches.
1267
1268         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
1269
1270         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1271         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
1272         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
1273         the browser opens by planName as the plan file no longer contains that.
1274
1275         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
1276         the top directory of JetStream instead of its parent.
1277         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
1278         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
1279         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
1280         the top directory of JetStream instead of its parent.
1281         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
1282         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
1283         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
1284         done in JetStream.patch.
1285         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
1286         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
1287         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
1288         path from the top directory of JetStream as done in JetStream.patch.
1289         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
1290
1291 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
1292
1293         Fix run-javascriptcore-tests step on the WinCairo bot
1294         https://bugs.webkit.org/show_bug.cgi?id=144866
1295
1296         Reviewed by Darin Adler.
1297
1298         * Scripts/run-jsc-stress-tests:
1299
1300 2015-05-11  Alex Christensen  <achristensen@webkit.org>
1301
1302         [Content Extensions] Support domain-specific rules and exceptions.
1303         https://bugs.webkit.org/show_bug.cgi?id=144833
1304
1305         Reviewed by Darin Adler.
1306
1307         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1308         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1309         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1310         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1311         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
1312         (TestWebKitAPI::mainDocumentRequest):
1313         (TestWebKitAPI::subResourceRequest):
1314         (TestWebKitAPI::TEST_F):
1315         (TestWebKitAPI::checkCompilerError):
1316         Added tests for parsing and functionality of if-domain and unless-domain.
1317
1318 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1319
1320         run-benchmark should support Chrome Canary and Firefox Nightly
1321         https://bugs.webkit.org/show_bug.cgi?id=144850
1322
1323         Reviewed by Darin Adler.
1324
1325         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
1326
1327         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
1328
1329         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
1330         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
1331         (OSXBrowserDriver):
1332         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
1333         (OSXBrowserDriver.closeBrowsers): Ditto.
1334         (OSXBrowserDriver.launchProcess): Ditto.
1335         (OSXBrowserDriver.terminateProcesses): Ditto.
1336         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1337         (OSXChromeDriver): Removed the unused self.chromePreferences.
1338         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
1339         (OSXChromeDriver.closeBrowsers): Ditto.
1340         (OSXChromeDriver.launchUrl):
1341         (OSXChromeCanaryDriver): Added.
1342         (OSXChromeCanaryDriver.launchUrl):
1343         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
1344         (OSXFirefoxDriver): Added.
1345         (OSXFirefoxDriver.launchUrl):
1346         (OSXFirefoxNightlyDriver): Added.
1347         (OSXFirefoxNightlyDriver.launchUrl):
1348         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1349         (OSXSafariDriver):
1350         (OSXSafariDriver.closeBrowsers):
1351
1352 2015-05-11  Tim Horton  <timothy_horton@apple.com>
1353
1354         Page overlay action context override should indicate the source of the request
1355         https://bugs.webkit.org/show_bug.cgi?id=144832
1356         <rdar://problem/20562594>
1357
1358         Reviewed by Darin Adler.
1359
1360         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
1361         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
1362
1363 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
1364
1365         [GTK] fast/events/page-visibility-transition-test.html is timing out
1366         https://bugs.webkit.org/show_bug.cgi?id=114789
1367
1368         Reviewed by Darin Adler.
1369
1370         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1371         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
1372         requests visibility changes.
1373
1374 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
1375
1376         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
1377         https://bugs.webkit.org/show_bug.cgi?id=144798
1378
1379         Reviewed by Darin Adler.
1380
1381         * efl/install-dependencies:
1382
1383 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
1384
1385         Make arguments of run-benchmark more user friendly
1386         https://bugs.webkit.org/show_bug.cgi?id=144835
1387
1388         Reviewed by Darin Adler.
1389
1390         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
1391         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
1392         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
1393         default values from --platform and --browser as they are required arguments.
1394
1395         * Scripts/run-benchmark:
1396         (main): Made --build-directory optional, and removed default values from --platform and --browser.
1397         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
1398         are not dynamically obtained via BrowserDriverFactory.
1399         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1400         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
1401         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
1402         run any benchmark in that case.
1403         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
1404         the specified file isn't a valid relative or an absolute path.
1405         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
1406         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
1407         and browsers.
1408         (BrowserDriverFactory.available_browsers): Ditto.
1409         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1410         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
1411         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
1412         browserBuildPath was None.
1413         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1414         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
1415         so that we can use locally built WebKit to launch Safari.
1416
1417 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
1418
1419         Remove the PICTURE_SIZES build flag
1420         https://bugs.webkit.org/show_bug.cgi?id=144679
1421
1422         Reviewed by Benjamin Poulain.
1423
1424         Removed the PICTURE_SIZES build time flag.
1425
1426         * Scripts/webkitperl/FeatureList.pm:
1427
1428 2015-05-09  David Kilzer  <ddkilzer@apple.com>
1429
1430         Layout tests broke due to unexpected simctl output
1431
1432         * Scripts/webkitpy/xcode/simulator.py:
1433         (Simulator._parse_devices): Handle new Device Pairs header.
1434         * Scripts/webkitpy/xcode/simulator_unittest.py:
1435         (test_device_pairs): Add unit test for Device Pairs header.
1436
1437 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
1438
1439         Remove convenience constructors for TextRun
1440         https://bugs.webkit.org/show_bug.cgi?id=144752
1441
1442         Reviewed by Anders Carlsson.
1443
1444         Test the StringView which takes a StringImpl*.
1445
1446         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1447         (StringView8Bit): Testing is8Bit() on StringView
1448
1449 2015-05-07  Sam Weinig  <sam@webkit.org>
1450
1451         [Content Extensions] Add simple tester that takes an extension and compiles it
1452         https://bugs.webkit.org/show_bug.cgi?id=144781
1453
1454         Reviewed by Dan Bates.
1455
1456         * ContentExtensionTester: Added.
1457         * ContentExtensionTester/Configurations: Added.
1458         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
1459         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
1460         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
1461         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
1462         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
1463         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
1464         * ContentExtensionTester/main.m: Added.
1465         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
1466
1467 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
1468
1469         Build fix.
1470
1471         Reviewed by Dan Bernstein.
1472
1473         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1474         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1475         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
1476         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
1477         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1478         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1479         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
1480         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
1481
1482 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
1483
1484         [GTK] Some tests fail because they do not assume the popup menu captures click events
1485         https://bugs.webkit.org/show_bug.cgi?id=40601
1486
1487         Reviewed by Carlos Garcia Campos.
1488
1489         Popdown all attached menus when moving between tests and between each new
1490         event sent to the WebView. This prevents context and popup menus from eating
1491         events.
1492
1493         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
1494         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
1495         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1496         (WTR::dispatchEvent): Popdown all menus between dispatching events.
1497         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
1498         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
1499         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1500         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
1501         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1502         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
1503         longer in the platform-independent file.
1504         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
1505
1506 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
1507
1508         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
1509         https://bugs.webkit.org/show_bug.cgi?id=144746
1510
1511         Reviewed by Carlos Garcia Campos.
1512
1513         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
1514
1515         * MiniBrowser/gtk/main.c:
1516         (main):
1517
1518 2015-05-08  Commit Queue  <commit-queue@webkit.org>
1519
1520         Unreviewed, rolling out r183996.
1521         https://bugs.webkit.org/show_bug.cgi?id=144806
1522
1523         ASan detected use-after free (Requested by ap on #webkit).
1524
1525         Reverted changeset:
1526
1527         "Remove convenience constructors for TextRun"
1528         https://bugs.webkit.org/show_bug.cgi?id=144752
1529         http://trac.webkit.org/changeset/183996
1530
1531 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
1532
1533         Remove convenience constructors for TextRun
1534         https://bugs.webkit.org/show_bug.cgi?id=144752
1535
1536         Reviewed by Anders Carlsson.
1537
1538         Test the StringView which takes a StringImpl*.
1539
1540         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1541         (StringView8Bit): Testing is8Bit() on StringView
1542
1543 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1544
1545         [GTK] WTR doesn't correctly handle the Escape key
1546         https://bugs.webkit.org/show_bug.cgi?id=144788
1547
1548         Reviewed by Martin Robinson.
1549
1550         Correctly handle 0x001B character code in GTK+ event sender to be
1551         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
1552         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
1553         to dismiss popup menus.
1554
1555         Fixes editing/selection/5354455-1.html.
1556
1557         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1558         (WTR::getGDKKeySymForKeyRef):
1559
1560 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1561
1562         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
1563         https://bugs.webkit.org/show_bug.cgi?id=144748
1564
1565         Reviewed by Sergio Villar Senin.
1566
1567         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1568         (testWebKitSettings): Check the new setting is correctly
1569         initialized and updated.
1570         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1571         (testWebContextSecurityFileXHR): Check XHR to local files is
1572         allowed from file URLs after changing the setting.
1573         (beforeAll): Add new test.
1574
1575 2015-05-08  Commit Queue  <commit-queue@webkit.org>
1576
1577         Unreviewed, rolling out r183945.
1578         https://bugs.webkit.org/show_bug.cgi?id=144789
1579
1580         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
1581
1582         Reverted changeset:
1583
1584         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
1585         https://bugs.webkit.org/show_bug.cgi?id=144746
1586         http://trac.webkit.org/changeset/183945
1587
1588 2015-05-07  Anders Carlsson  <andersca@apple.com>
1589
1590         Build fixes.
1591
1592         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
1593         (TestWebKitAPI::TEST):
1594         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
1595         (TestWebKitAPI::TEST):
1596         Add casts.
1597
1598 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
1599
1600         GC has trouble with pathologically large array allocations
1601         https://bugs.webkit.org/show_bug.cgi?id=144609
1602
1603         Reviewed by Geoffrey Garen.
1604         
1605         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
1606         and it's a frequently requested feature.
1607         
1608         Also add the ability to run a test pretending that your system has a particular RAM size.
1609         This is useful for GC tests, and the new GC test that I added uses this.
1610
1611         * Scripts/run-javascriptcore-tests:
1612         (runJSCStressTests):
1613         * Scripts/run-jsc-stress-tests:
1614
1615 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
1616
1617         [EFL] Bump EFL version to 1.14.0
1618         https://bugs.webkit.org/show_bug.cgi?id=144743
1619
1620         Reviewed by Darin Adler.
1621
1622         Bump EFL and elementary version to 1.14.0 and removed
1623         md5sum, because it isn't used at all if hash is present.
1624
1625         * efl/jhbuild.modules:
1626
1627 2015-05-07  Saam Barati  <saambarati1@gmail.com>
1628
1629         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
1630         https://bugs.webkit.org/show_bug.cgi?id=144753
1631
1632         Reviewed by Mark Lam.
1633
1634         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1635
1636 2015-05-07  Beth Dakin  <bdakin@apple.com>
1637
1638         New force-related DOM events should fire in WK1 views
1639         https://bugs.webkit.org/show_bug.cgi?id=144663
1640         -and corresponding-
1641         rdar://problem/20281886
1642
1643         Reviewed by Sam Weinig.
1644
1645         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
1646         now. Just send nil. 
1647         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1648         (TestWebKitAPI::buildAndPerformTest):
1649
1650 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1651
1652         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
1653         https://bugs.webkit.org/show_bug.cgi?id=144746
1654
1655         Reviewed by Martin Robinson.
1656
1657         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
1658
1659         * MiniBrowser/gtk/main.c:
1660         (main):
1661
1662 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
1663
1664         Revert "Introducing the Platform Abstraction Layer (PAL)"
1665         https://bugs.webkit.org/show_bug.cgi?id=144751
1666
1667         Unreviewed.
1668
1669         PAL should be a new target inside WebCore, rather than a top-level folder.
1670
1671         * Scripts/build-webkit: Add it to build-webkit.
1672
1673 2015-05-07  Ada Chan  <adachan@apple.com>
1674
1675         Add a test for WKPageCopySessionState() with filtering.
1676         https://bugs.webkit.org/show_bug.cgi?id=144666
1677
1678         Reviewed by Darin Adler.
1679
1680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1681         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
1682         (TestWebKitAPI::didFinishLoadForFrame):
1683         (TestWebKitAPI::setPageLoaderClient):
1684         (TestWebKitAPI::filterFirstItemCallback):
1685         (TestWebKitAPI::filterAllItemsCallback):
1686         (TestWebKitAPI::createSessionStates):
1687         (TestWebKitAPI::TEST):
1688
1689 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1690
1691         iOS build fix attempt
1692
1693         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
1694
1695         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1696
1697 2015-05-06  Matt Baker  <mattbaker@apple.com>
1698
1699         Unreviewed, updated my list of email addresses.
1700
1701         * Scripts/webkitpy/common/config/contributors.json:
1702
1703 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1704
1705         Do not link tools to WebKit2.framework
1706         https://bugs.webkit.org/show_bug.cgi?id=144699
1707
1708         Unreviewed build fix.
1709
1710         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1711         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1712         These linked to WebKit2 in two ways, eliminating the other one.
1713
1714 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
1715
1716         Introducing the Platform Abstraction Layer (PAL)
1717         https://bugs.webkit.org/show_bug.cgi?id=143358
1718
1719         Reviewed by Simon Fraser.
1720
1721         * Scripts/build-webkit: Add it to build-webkit.
1722
1723 2015-05-06  Alex Christensen  <achristensen@webkit.org>
1724
1725         Fix api tests after r183877.
1726
1727         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1728         (TestWebKitAPI::TEST_F):
1729         Generate all DFAs before compiling them.
1730
1731 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1732
1733         Do not link tools to WebKit2.framework
1734         https://bugs.webkit.org/show_bug.cgi?id=144699
1735
1736         Reviewed by Tim Horton.
1737
1738         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1740         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1741
1742 2015-05-06  Alex Christensen  <achristensen@webkit.org>
1743
1744         [Content Extensions] Test splitting NFAs by max NFA size.
1745         https://bugs.webkit.org/show_bug.cgi?id=144659
1746
1747         Reviewed by Darin Adler.
1748
1749         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1750         (TestWebKitAPI::createNFAs):
1751         (TestWebKitAPI::TEST_F):
1752         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1753         (TestWebKitAPI::createNFAs):
1754
1755 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
1756
1757         Remove the remaining vestiges of SVG feature define
1758         https://bugs.webkit.org/show_bug.cgi?id=144655
1759
1760         Reviewed by Alexey Proskuryakov.
1761
1762         * Scripts/webkitperl/FeatureList.pm:
1763
1764 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
1765
1766         Add a layout mode for computing fixed layout size from a minimum size
1767         https://bugs.webkit.org/show_bug.cgi?id=144610
1768         <rdar://problem/19790341>
1769
1770         Reviewed by Simon Fraser.
1771
1772         * MiniBrowser/mac/BrowserWindow.xib:
1773         * MiniBrowser/mac/BrowserWindowController.h:
1774         * MiniBrowser/mac/WK1BrowserWindowController.m:
1775         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
1776         * MiniBrowser/mac/WK2BrowserWindowController.m:
1777         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
1778         Add a optional toolbar item to toggle a minimum view size of 1024x0.
1779
1780 2015-05-05  Alex Christensen  <achristensen@webkit.org>
1781
1782         [Content Extensions] Release input NSString when finished copying it.
1783         https://bugs.webkit.org/show_bug.cgi?id=144642
1784
1785         Reviewed by Brian Weinstein.
1786
1787         * WebKitTestRunner/mac/TestControllerMac.mm:
1788         (WTR::TestController::platformConfigureViewForTest):
1789         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
1790
1791 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
1792
1793         Unreviewed test fix after r183798.
1794
1795         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1796         (convertToDRTLabel): Mimic behavior of Mac accessibility output
1797         so we can share results.
1798
1799 2015-05-05  Alex Christensen  <achristensen@webkit.org>
1800
1801         [Content Extensions] Use less memory to store the json input.
1802         https://bugs.webkit.org/show_bug.cgi?id=144604
1803
1804         Reviewed by Benjamin Poulain.
1805
1806         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1807         (-[ExtensionManagerWindowController add:]):
1808         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1809         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1810         * WebKitTestRunner/mac/TestControllerMac.mm:
1811         (WTR::TestController::platformConfigureViewForTest):
1812
1813 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1814
1815         Unreviewed. Make myself a WebKit reviewer.
1816
1817         * Scripts/webkitpy/common/config/contributors.json:
1818
1819 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
1820
1821         [GTK] r183783 breaks build
1822         https://bugs.webkit.org/show_bug.cgi?id=144632
1823
1824         Reviewed by Martin Robinson.
1825
1826         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
1827
1828         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1829         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1830
1831 2015-05-05  Alex Christensen  <achristensen@webkit.org>
1832
1833         [Content Extensions] Combine NFAs properly and free memory as we compile.
1834         https://bugs.webkit.org/show_bug.cgi?id=144485
1835
1836         Reviewed by Benjamin Poulain.
1837
1838         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1839         (TestWebKitAPI::TEST_F):
1840         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
1841         Added tests for deep NFAs.
1842
1843 2015-05-04  Alex Christensen  <achristensen@webkit.org>
1844
1845         [Content Extensions] Use less memory when writing byte code to file
1846         https://bugs.webkit.org/show_bug.cgi?id=144602
1847
1848         Reviewed by Darin Adler.
1849
1850         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1851
1852 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1853
1854         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
1855         https://bugs.webkit.org/show_bug.cgi?id=144541
1856
1857         Reviewed by Žan Doberšek.
1858
1859         Add a test case to WorkQueue unit test, to check that sources of
1860         asynchronous IO operations running in the WorkQueue thread are
1861         dispatched by the WorkQueue main loop.
1862
1863         * TestWebKitAPI/PlatformGTK.cmake:
1864         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
1865         (TestWebKitAPI::TEST):
1866
1867 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
1868
1869         Correct '--show-webview' option for Tiled Drawing tests
1870         https://bugs.webkit.org/show_bug.cgi?id=144621
1871
1872         Reviewed by Simon Fraser.
1873
1874         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
1875         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
1876
1877         * WebKitTestRunner/mac/TestControllerMac.mm:
1878         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
1879         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
1880
1881 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
1882
1883         Large array shouldn't be slow
1884         https://bugs.webkit.org/show_bug.cgi?id=144617
1885
1886         Reviewed by Geoffrey Garen.
1887         
1888         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
1889         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
1890         long-running. So, hash-map sort of belongs here.
1891
1892         * Scripts/run-jsc-benchmarks:
1893
1894 2015-05-04  Doug Russell  <d_russell@apple.com>
1895
1896         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
1897         https://bugs.webkit.org/show_bug.cgi?id=144489
1898
1899         Reviewed by Chris Fleizach.
1900
1901         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
1902         on the returned control.
1903         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
1904         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
1905         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
1906         Add support for setSelectedVisibleTextRange() in accessibility tests.
1907
1908         * DumpRenderTree/AccessibilityUIElement.cpp:
1909         (setSelectedVisibleTextRangeCallback):
1910         (AccessibilityUIElement::setSelectedVisibleTextRange):
1911         (AccessibilityUIElement::getJSClass):
1912         (AccessibilityUIElement::textMarkerForIndex): Deleted.
1913         * DumpRenderTree/AccessibilityUIElement.h:
1914         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1915         (AccessibilityUIElement::setSelectedVisibleTextRange):
1916         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1917         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1918         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
1919         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1920         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1921         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1922         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1923         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1924         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1925         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1926         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1927
1928 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
1929
1930         [Win] Implement the "--show-webview" option for Windows
1931         https://bugs.webkit.org/show_bug.cgi?id=144589
1932
1933         Reviewed by Alex Christensen.
1934
1935         Add another runtime flag (--show-webview) that causes DumpRenderTree
1936         to draw its view on-screen, rather than the standard offscreen mode.
1937
1938         * DumpRenderTree/win/DumpRenderTree.cpp:
1939         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
1940         (initializeGlobalsFromCommandLineOptions): Recognize the new
1941         command-line argument, and set the global 'showWebView' state if
1942         appropriate.
1943
1944 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
1945
1946         Remove dead code from TestInvocationCairo.cpp
1947         https://bugs.webkit.org/show_bug.cgi?id=144564
1948
1949         Reviewed by Gyuyoung Kim.
1950
1951         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
1952
1953         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1954         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1955
1956 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
1957
1958         [GTK] Add libnotify in gtk install-dependencies
1959         https://bugs.webkit.org/show_bug.cgi?id=144379
1960
1961         Reviewed by Csaba Osztrogonác.
1962
1963         * gtk/install-dependencies:
1964
1965 2015-05-01  Dan Bernstein  <mitz@apple.com>
1966
1967         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
1968         https://bugs.webkit.org/show_bug.cgi?id=144501
1969
1970         Reviewed by Darin Adler.
1971
1972         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1973         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
1974         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
1975         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
1976
1977 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
1978
1979         check-webkit-style fails due to system pylint
1980         https://bugs.webkit.org/show_bug.cgi?id=144360
1981
1982         Reviewed by Darin Adler.
1983
1984         Make sure that the directory containing third party autoinstalled modules
1985         is at the beginning of the search path, to avoid conflicts with other
1986         versions of the same modules installed in the system (e.g. pylint).
1987
1988         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
1989         modules directory to sys.path, instead of appending it.
1990
1991 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
1992
1993         Unreviewed, updated my list of email addresses.
1994
1995         * Scripts/webkitpy/common/config/contributors.json: Updated.
1996
1997 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
1998
1999         USE(...) macro should expect unprefixed variables
2000         https://bugs.webkit.org/show_bug.cgi?id=144454
2001
2002         Reviewed by Daniel Bates.
2003
2004         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
2005         * DumpRenderTree/config.h: Ditto.
2006         * TestWebKitAPI/config.h: Ditto.
2007
2008 2015-05-01  Basile Clement  <basile_clement@apple.com>
2009
2010         Unreviewed. Add myself as a commiter in contributors.json.
2011
2012         * Scripts/webkitpy/common/config/contributors.json:
2013
2014 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
2015
2016         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
2017         https://bugs.webkit.org/show_bug.cgi?id=144487
2018
2019         Reviewed by Ryosuke Niwa.
2020
2021         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2022         (BenchmarkRunner.merge): Fix bug.
2023         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
2024
2025 2015-05-01  Brady Eidson  <beidson@apple.com>
2026
2027         Add API to disable meta refreshes.
2028         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
2029
2030         Reviewed by Alexey Proskuryakov.
2031
2032         * DumpRenderTree/mac/DumpRenderTree.mm:
2033         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
2034
2035 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
2036
2037         Provide a runtime flag to run-webkit-tests that shows the test view
2038         https://bugs.webkit.org/show_bug.cgi?id=144079.
2039
2040         Unreviewed correction to r183651.
2041
2042         * WebKitTestRunner/TestController.cpp:
2043         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
2044         flag is included in the options dictionary passed to the PlatformWebView.
2045
2046 2015-05-01  Antti Koivisto  <antti@apple.com>
2047
2048         Remove network process load serialization code
2049         https://bugs.webkit.org/show_bug.cgi?id=144448
2050
2051         Reviewed by Alexey Proskuryakov.
2052
2053         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2054         (WTR::InjectedBundle::beginTesting):
2055         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2056         (WTR::TestRunner::setSerializeHTTPLoads):
2057         (WTR::TestRunner::dispatchPendingLoadRequests):
2058
2059 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2060
2061         [GTK] Add libhyphen-dev to the build dependencies
2062         https://bugs.webkit.org/show_bug.cgi?id=144452
2063
2064         Reviewed by Martin Robinson.
2065
2066         * gtk/install-dependencies: Added hyphen as Fedora and Arch
2067         dependencies.
2068
2069 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
2070
2071         Provide a runtime flag to run-webkit-tests that shows the test view
2072         https://bugs.webkit.org/show_bug.cgi?id=144079.
2073
2074         Reviewed by Dean Jackson.
2075
2076         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
2077         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
2078         option:
2079         
2080         --additional-drt-flag="--show-webview"
2081
2082         * DumpRenderTree/mac/DumpRenderTree.mm:
2083         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
2084         '--show-webview' flag.
2085         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
2086         * WebKitTestRunner/Options.cpp:
2087         (WTR::Options::Options):
2088         (WTR::handleOptionShowWebView):
2089         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
2090         * WebKitTestRunner/Options.h:
2091         * WebKitTestRunner/TestController.cpp:
2092         (WTR::TestController::TestController):
2093         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
2094         * WebKitTestRunner/TestController.h:
2095         (WTR::TestController::shouldShowWebView):
2096         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2097         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
2098         options dictionary. If it is true, display the web view while running the test.
2099
2100 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
2101
2102         r183355 didn't trigger Mac tests
2103         https://bugs.webkit.org/show_bug.cgi?id=144464
2104
2105         Reviewed by Simon Fraser.
2106
2107         Update badly neglected filters and unit tests.
2108
2109         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2110         (_should_file_trigger_build):
2111         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2112         (ShouldBuildTest):
2113         (ShouldBuildTest.test_should_build):
2114
2115 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2116
2117         [GTK] Add libhyphen-dev to the build dependencies
2118         https://bugs.webkit.org/show_bug.cgi?id=144452
2119
2120         Reviewed by Martin Robinson.
2121
2122         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
2123         build dependencies.
2124
2125 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
2126
2127         [GTK] Testing dictionaries are not installed automatically
2128         https://bugs.webkit.org/show_bug.cgi?id=144460
2129
2130         Reviewed by Carlos Garcia Campos.
2131
2132         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
2133
2134 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
2135
2136         Fix return code issue, check return code of safari process and dump results to log
2137         https://bugs.webkit.org/show_bug.cgi?id=144436
2138
2139         Reviewed by Ryosuke Niwa.
2140
2141         * Scripts/run-benchmark:
2142         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2143         (BenchmarkRunner.dump): Correct typo.
2144         (BenchmarkRunner.wrap): Add results to console.
2145         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
2146         (OSXSafariDriver.prepareEnv):
2147         (OSXSafariDriver.launchUrl):
2148         (OSXSafariDriver.closeBrowsers):
2149
2150 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
2151
2152         Should no longer need to worry about very old versions of Xcode
2153         https://bugs.webkit.org/show_bug.cgi?id=144437
2154
2155         Reviewed by Dan Bernstein.
2156
2157         * Scripts/check-for-exit-time-destructors:
2158         * Scripts/check-for-global-initializers:
2159         * Scripts/check-for-weak-vtables-and-externals:
2160
2161 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
2162
2163         REGRESSION(183583): [Mac] make without SDKROOT has issues
2164         https://bugs.webkit.org/show_bug.cgi?id=144431
2165
2166         Reviewed by Dan Bernstein.
2167
2168         * Makefile:
2169         * WebKitTestRunner/Makefile:
2170         Assume an empty SDKROOT means an macosx variant, so only
2171         enable settings if the SDKROOT is not empty and does not
2172         contain "macosx".
2173
2174 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
2175
2176         Expand test infrastructure to support scrolling tests
2177         https://bugs.webkit.org/show_bug.cgi?id=143684
2178         <rdar://problem/20375516>
2179
2180         Reviewed by Simon Fraser.
2181
2182         * DumpRenderTree/mac/DumpRenderTree.mm:
2183         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
2184         reset before the next test run.
2185         * WebKitTestRunner/TestController.cpp:
2186         (WTR::TestController::resetStateToConsistentValues): Ditto."
2187
2188 2015-04-29  Alex Christensen  <achristensen@webkit.org>
2189
2190         Run javascriptcore tests on Windows without cygwin
2191         https://bugs.webkit.org/show_bug.cgi?id=144419
2192
2193         Reviewed by Brent Fulgham.
2194
2195         * Scripts/run-javascriptcore-tests:
2196         (runJSCStressTests):
2197         Just call ruby, not /usr/bin/env ruby.
2198
2199 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
2200
2201         [GTK] Add --enable-shared option to LLVM to build mesa
2202         https://bugs.webkit.org/show_bug.cgi?id=144393
2203
2204         Reviewed by Martin Robinson.
2205
2206         The updated mesa requires the shared LLVM libraries.
2207         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
2208         to LLVM configure script. It will provide shared libraries in addition to static libraries.
2209
2210         * gtk/jhbuild-optional.modules:
2211
2212 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
2213
2214         [GTK] Add support for automatic hyphenation
2215         https://bugs.webkit.org/show_bug.cgi?id=44478
2216
2217         Reviewed by Carlos Garcia Campos.
2218
2219         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
2220         all systems will use the same dictionaries for testing purposes.
2221
2222 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
2223
2224         Failure when building WebKit for appletvsimulator.
2225         https://bugs.webkit.org/show_bug.cgi?id=144356
2226
2227         Reviewed by Alexey Proskuryakov.
2228
2229         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
2230         make TVOS and WatchOS behave correctly.
2231
2232         * Makefile:
2233         * WebKitTestRunner/Makefile:
2234
2235 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
2236
2237         Use-after-free when invalidating WKPageForceRepaint callback
2238         https://bugs.webkit.org/show_bug.cgi?id=144401
2239         rdar://problem/20741111
2240
2241         Reviewed by Tim Horton.
2242
2243         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
2244
2245         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
2246         Don't do anything on error, because the context may be a stale pointer now.
2247
2248 2015-04-29  David Kilzer  <ddkilzer@apple.com>
2249
2250         check-webkit-style: Don't complain about returning value from Objective-C method call in header
2251         <http://webkit.org/b/144395>
2252
2253         Reviewed by Andy Estes.
2254
2255         * Scripts/webkitpy/style/checkers/cpp.py:
2256         (check_spacing): Update regex so 'return' is ignored if it
2257         precedes the whitespace and bracket.  Change category name to
2258         'whitespace/brackets'.  Add period to error message.
2259         (CppChecker): Add 'whitespace/brackets' as a category.
2260         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2261         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
2262         'CppChecker.categories' since that's where the list lives now.
2263         (CppStyleTest.test_spacing_before_brackets): Add tests for
2264         'whitespace/brackets' issues and non-issues.
2265
2266 2015-04-29  Alex Christensen  <achristensen@webkit.org>
2267
2268         Fix WinCairo bot.
2269
2270         * Scripts/webkitdirs.pm:
2271         (determinePassedConfiguration):
2272         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
2273
2274 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
2275
2276         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
2277         https://bugs.webkit.org/show_bug.cgi?id=132159
2278
2279         Reviewed by Darin Adler.
2280
2281         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
2282         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
2283
2284         * DumpRenderTree/mac/DumpRenderTree.mm:
2285         (fontWhitelist):
2286         (adjustFonts):
2287         (createWebViewAndOffscreenWindow):
2288         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2289         (WTR::activateFonts):
2290         * WebKitTestRunner/mac/TestControllerMac.mm:
2291         (WTR::allowedFontFamilySet):
2292         (WTR::systemHiddenFontFamilySet):
2293         (WTR::generateWhitelist):
2294         (WTR::TestController::platformInitializeContext):
2295
2296 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
2297
2298         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2299         https://bugs.webkit.org/show_bug.cgi?id=144155
2300
2301         Reviewed by Andreas Kling.
2302
2303         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2304         Make sure that test window is "visible" before each test. While there is no concrete
2305         evidence that this is the problem indeed, the behavior is consistent with what would
2306         happen for an invisible window. Also, WKTR obviously needs to do this to protect
2307         against potential buggy tests that hide the window and don't show it.
2308
2309 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2310
2311         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
2312
2313         Latest changes in the inspector UI made this test fail. We were
2314         relying that the sidebar was always visible and the first 'li'
2315         element of the inspector was the one containing the title. This is
2316         no longer true, so better use document title that is not likely
2317         to change.
2318
2319         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2320         (openRemoteDebuggingSession):
2321
2322 2015-04-29  Andres Gomez  <agomez@igalia.com>
2323
2324         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
2325
2326         * Scripts/webkitpy/common/config/contributors.json:
2327
2328 2015-04-29  Andres Gomez  <agomez@igalia.com>
2329
2330         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
2331
2332         * Scripts/webkitpy/common/config/watchlist:
2333
2334 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
2335
2336         [EFL] Allow to run the tests on the native X display
2337         https://bugs.webkit.org/show_bug.cgi?id=144247
2338
2339         Reviewed by Gyuyoung Kim.
2340
2341         Added the USE_NATIVE_XDISPLAY option for the WTR.
2342         We can select the Xorg driver if environment variable is set up before running the tests.
2343
2344         * Scripts/webkitpy/port/efl.py:
2345         (EflPort._driver_class):
2346
2347 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
2348
2349         [GTK] Add libnotify-dev in gtk install-dependencies
2350         https://bugs.webkit.org/show_bug.cgi?id=144379
2351
2352         Reviewed by Žan Doberšek.
2353
2354         * gtk/install-dependencies:
2355
2356 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
2357
2358         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
2359         https://bugs.webkit.org/show_bug.cgi?id=143001
2360
2361         Reviewed by Gyuyoung Kim.
2362
2363         * WebKitTestRunner/TestController.cpp:
2364         (WTR::shouldUseFixedLayout):
2365
2366 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
2367
2368         Increase stablility of run-benchmark script
2369         https://bugs.webkit.org/show_bug.cgi?id=144361
2370
2371         Reviewed by Ryosuke Niwa.
2372
2373         * Scripts/run-benchmark:
2374         (main):
2375         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
2376         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2377         (GenericBenchmarkBuilder.clean):
2378         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
2379         (BenchmarkRunner.__init__):
2380         (BenchmarkRunner.execute):
2381         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2382         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
2383         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
2384         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
2385         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
2386         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
2387         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
2388         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2389         (HTTPServerDriver.fetchResult):
2390         (HTTPServerDriver):
2391         (HTTPServerDriver.killServer): Add kill server interface.
2392         (HTTPServerDriver.getReturnCode): Add get return code interface.
2393         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
2394         (SimpleHTTPServerDriver.serve):
2395         (SimpleHTTPServerDriver.fetchResult):
2396         (SimpleHTTPServerDriver):
2397         (SimpleHTTPServerDriver.killServer):
2398         (SimpleHTTPServerDriver.getReturnCode):
2399         * Scripts/webkitpy/benchmark_runner/utils.py:
2400         (forceRemove): Provide python version of 'rm -rf'.
2401
2402 2015-04-28  Sam Weinig  <sam@webkit.org>
2403
2404         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
2405         https://bugs.webkit.org/show_bug.cgi?id=144363
2406
2407         Reviewed by Alex Christensen.
2408
2409         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2410         (TestWebKitAPI::createNFAs):
2411         (TestWebKitAPI::TEST_F):
2412         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2413         (TestWebKitAPI::countLiveNodes):
2414         (TestWebKitAPI::createNFAs):
2415         (TestWebKitAPI::buildDFAFromPatterns):
2416         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
2417
2418 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2419
2420         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2421         https://bugs.webkit.org/show_bug.cgi?id=144304
2422
2423         Reviewed by Geoffrey Garen.
2424
2425         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
2426         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2427         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2428
2429 2015-04-28  Commit Queue  <commit-queue@webkit.org>
2430
2431         Unreviewed, rolling out r183514.
2432         https://bugs.webkit.org/show_bug.cgi?id=144359
2433
2434         It broke cloop test bots (Requested by mcatanzaro on #webkit).
2435
2436         Reverted changeset:
2437
2438         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
2439         https://bugs.webkit.org/show_bug.cgi?id=144304
2440         http://trac.webkit.org/changeset/183514
2441
2442 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2443
2444         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2445         https://bugs.webkit.org/show_bug.cgi?id=144304
2446
2447         Reviewed by Geoffrey Garen.
2448
2449         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
2450         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
2451         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2452         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2453
2454 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2455
2456         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
2457         https://bugs.webkit.org/show_bug.cgi?id=144319
2458
2459         Reviewed by Csaba Osztrogonác.
2460
2461         * TestWebKitAPI/CMakeLists.txt:
2462         * TestWebKitAPI/PlatformEfl.cmake:
2463
2464 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
2465
2466         Fix common typo "targetting" => "targeting"
2467         https://bugs.webkit.org/show_bug.cgi?id=144349
2468
2469         Reviewed by Daniel Bates.
2470
2471         * Scripts/webkitdirs.pm:
2472         (execMacWebKitAppForDebugging):
2473
2474 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2475
2476         [GTK][jhbuild] Mesa build failure with llvm 3.6
2477         https://bugs.webkit.org/show_bug.cgi?id=144250
2478
2479         Reviewed by Žan Doberšek.
2480
2481         Bump the version of Mesa to 10.5.4
2482
2483         * gtk/jhbuild.modules:
2484
2485 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
2486
2487         Disable App Nap in WebKitTestRunner UI process
2488         https://bugs.webkit.org/show_bug.cgi?id=144308
2489
2490         Reviewed by Daniel Bates.
2491
2492         * WebKitTestRunner/mac/main.mm:
2493         (disableAppNapInUIProcess):
2494         (main):
2495
2496 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2497
2498         [GTK] Update JHBuild Mesa download directory
2499         https://bugs.webkit.org/show_bug.cgi?id=144318
2500
2501         Update the download directory of Mesa module since the previous one
2502         doesn't exist any more.
2503
2504         Reviewed by Žan Doberšek.
2505
2506         * gtk/jhbuild.modules:
2507
2508 2015-04-28  Commit Queue  <commit-queue@webkit.org>
2509
2510         Unreviewed, rolling out r183477.
2511         https://bugs.webkit.org/show_bug.cgi?id=144334
2512
2513         Roll back the Mesa dependency bump in fear of uncaught
2514         regressions while the testing bots are no-op. (Requested by
2515         zdobersek on #webkit).
2516
2517         Reverted changeset:
2518
2519         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
2520         https://bugs.webkit.org/show_bug.cgi?id=144250
2521         http://trac.webkit.org/changeset/183477
2522
2523 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2524
2525         [GTK][jhbuild] Mesa build failure with llvm 3.6
2526         https://bugs.webkit.org/show_bug.cgi?id=144250
2527
2528         Reviewed by Žan Doberšek.
2529
2530         Bump the version of Mesa to 10.5.4
2531
2532         * gtk/jhbuild.modules:
2533
2534 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
2535
2536         Add '__init__.py' and fix known bug in benchmark runner.
2537         https://bugs.webkit.org/show_bug.cgi?id=144296
2538
2539         Reviewed by Ryosuke Niwa
2540
2541         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
2542         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
2543         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2544         (BenchmarkRunner.__init__):
2545         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
2546         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
2547         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
2548
2549 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2550
2551         More build fix.
2552
2553         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2554         (-[AccessibilityNotificationHandler _notificationReceived:]):
2555         Use -objectForKey:, not array subscript.
2556
2557 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2558
2559         Catch unexpected exits in DumpRenderTree
2560         https://bugs.webkit.org/show_bug.cgi?id=144288
2561
2562         Reviewed by Tim Horton.
2563
2564         * DumpRenderTree/mac/DumpRenderTree.mm:
2565         (atexitFunction):
2566         (DumpRenderTreeMain):
2567
2568 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2569
2570         Build fix
2571
2572         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2573         (-[AccessibilityNotificationHandler _notificationReceived:]):
2574         Use -objectForKey:, not array subscript.
2575
2576 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2577
2578         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2579         https://bugs.webkit.org/show_bug.cgi?id=144155
2580
2581         Reviewed by Tim Horton.
2582
2583         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
2584         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
2585         and we clearly don't want App Nap while testing.
2586
2587 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
2588
2589         [CMake] Autogenerate cmakeconfig.h.cmake
2590         https://bugs.webkit.org/show_bug.cgi?id=143997
2591
2592         Reviewed by Csaba Osztrogonác.
2593
2594         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
2595         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
2596
2597 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
2598
2599         REGRESSION(r182879): Images and video can no longer be downloaded
2600         https://bugs.webkit.org/show_bug.cgi?id=144267
2601         <rdar://problem/20702844>
2602
2603         Reviewed by Simon Fraser.
2604
2605         Revise tests to check for proper download menu state.
2606         1. Downloading a loal image should be disabled.
2607         2. Downloading a local media file should be disabled.
2608         3. Downloading non-downloadable media should be disabled.
2609
2610         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2611         (TestWebKitAPI::TEST):
2612
2613 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2614
2615         Merge run-launcher into run-minibrowser
2616         https://bugs.webkit.org/show_bug.cgi?id=141928
2617
2618         Reviewed by Darin Adler.
2619
2620         * Scripts/run-iexploder-tests:
2621         (runSafariWithIExploder):
2622         * Scripts/run-launcher: Removed.
2623         * Scripts/run-minibrowser:
2624         * Scripts/webkitdirs.pm:
2625         (launcherPath):
2626         * Scripts/webkitpy/port/efl.py:
2627         (EflPort.show_results_html_file):
2628         * Scripts/webkitpy/port/efl_unittest.py:
2629         (EflPortTest.test_show_results_html_file):
2630         * Scripts/webkitpy/port/gtk.py:
2631         (GtkPort.print_leaks_summary):
2632         (GtkPort.show_results_html_file):
2633         (GtkPort): Deleted.
2634         * Scripts/webkitpy/port/gtk_unittest.py:
2635         (GtkPortTest.test_show_results_html_file):
2636
2637 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2638
2639         [buildbot] Fix the output of perf-test buildstep on timeout
2640         https://bugs.webkit.org/show_bug.cgi?id=144097
2641
2642         Reviewed by Ryosuke Niwa.
2643
2644         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2645         (RunAndUploadPerfTests.getText2):
2646         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2647         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
2648         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
2649
2650 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2651
2652         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
2653         https://bugs.webkit.org/show_bug.cgi?id=143874
2654
2655         Reviewed by Gyuyoung Kim.
2656
2657         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
2658
2659 2015-04-24  Philippe Normand  <pnormand@igalia.com>
2660
2661         [JHBuild] Move to upstream OpenWebRTC
2662         https://bugs.webkit.org/show_bug.cgi?id=144145
2663
2664         Reviewed by Carlos Garcia Campos.
2665
2666         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
2667         and add a new simple patch to gst-plugins-base, required for
2668         OpenWebRTC build.
2669         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
2670         * gtk/jhbuild.modules: Ditto.
2671         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
2672
2673 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2674
2675         [ES6] Implement ES6 template literals
2676         https://bugs.webkit.org/show_bug.cgi?id=142691
2677
2678         Reviewed by Darin Adler.
2679
2680         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
2681
2682         * Scripts/webkitperl/FeatureList.pm:
2683
2684 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2685
2686         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
2687         https://bugs.webkit.org/show_bug.cgi?id=144217
2688
2689         Reviewed by Darin Adler.
2690
2691         * WebKitTestRunner/PlatformEfl.cmake:
2692
2693 2015-04-26  Doug Russell  <d_russell@apple.com>
2694
2695         AX: richer text change notifications (142719)
2696         https://bugs.webkit.org/show_bug.cgi?id=142719
2697
2698         Reviewed by Darin Adler.
2699
2700         Richer accessibility value change notifications. Introduce AXTextEditType,
2701         postTextStateChangeNotification and postTextReplacementNotification to give assistive
2702         tech apps more reliable context for responding to changes in web content. Also implement
2703         a mechanism to post value changes in password form fields in coalesced ticks to thwart
2704         analyzing the cadence of changes.
2705
2706         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
2707         and an overload of postTextReplacementNotification to give assistive tech apps more
2708         reliable context for responding to changes in web content selection. Also block posting
2709         selection changes on password fields.
2710
2711         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
2712         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2713         (-[AccessibilityNotificationHandler stopObserving]):
2714         (-[AccessibilityNotificationHandler _notificationReceived:]):
2715         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2716         (AccessibilityUIElement::removeNotificationListener):
2717         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2718         (-[AccessibilityNotificationHandler _notificationReceived:]):
2719         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2720         (WTR::AccessibilityUIElement::removeNotificationListener):
2721
2722 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
2723
2724         Add myself to contributors.json
2725         https://bugs.webkit.org/show_bug.cgi?id=144204
2726
2727         Reviewed by Darin Adler.
2728
2729         * Scripts/webkitpy/common/config/contributors.json:
2730
2731 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
2732
2733         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
2734         https://bugs.webkit.org/show_bug.cgi?id=144182
2735
2736         Reviewed by Simon Fraser.
2737
2738         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
2739
2740 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
2741
2742         https://bugs.webkit.org/show_bug.cgi?id=144038
2743
2744         Reviewed by Ryosuke Niwa
2745
2746         Add a script to run Speedometer and JetStream on a browser.
2747
2748         * Scripts/run-benchmark: Wrapper script to run benchmark.
2749         (main):
2750         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
2751         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
2752         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
2753         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
2754         (BenchmarkBuilderFactory):
2755         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
2756         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
2757         (GenericBenchmarkBuilder):
2758         (GenericBenchmarkBuilder.prepare):
2759         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
2760         (GenericBenchmarkBuilder._applyPatch):
2761         (GenericBenchmarkBuilder.clean):
2762         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
2763         (JetStreamBenchmarkBuilder):
2764         (JetStreamBenchmarkBuilder.prepare):
2765         (JetStreamBenchmarkBuilder._runCreateScript):
2766         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
2767         (BenchmarkRunner):
2768         (BenchmarkRunner.__init__):
2769         (BenchmarkRunner.execute):
2770         (BenchmarkRunner.dump):
2771         (BenchmarkRunner.wrap):
2772         (BenchmarkRunner.merge):
2773         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
2774         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
2775         (BrowserDriver):
2776         (BrowserDriver.prepareEnv):
2777         (BrowserDriver.launchUrl):
2778         (BrowserDriver.closeBrowser):
2779         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
2780         (BrowserDriverFactory):
2781         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
2782         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
2783         (OSXChromeDriver):
2784         (OSXChromeDriver.prepareEnv):
2785         (OSXChromeDriver.launchUrl):
2786         (OSXChromeDriver.closeBrowsers):
2787         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
2788         (OSXSafariDriver):
2789         (OSXSafariDriver.prepareEnv):
2790         (OSXSafariDriver.launchUrl):
2791         (OSXSafariDriver.closeBrowsers):
2792         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
2793         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
2794         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
2795         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
2796         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
2797         (GenericFactory):
2798         (GenericFactory.iterateGetItem):
2799         (GenericFactory.create):
2800         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
2801         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
2802         (ServerControl):
2803         (ServerControl.render_GET):
2804         (ServerControl.render_POST):
2805         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
2806         (HTTPServerDriver):
2807         (HTTPServerDriver.serve):
2808         (HTTPServerDriver.fetchResult):
2809         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
2810         (HTTPServerDriverFactory):
2811         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
2812         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
2813         (SimpleHTTPServerDriver):
2814         (SimpleHTTPServerDriver.depends):
2815         (SimpleHTTPServerDriver.__init__):
2816         (SimpleHTTPServerDriver.serve):
2817         (SimpleHTTPServerDriver.baseUrl):
2818         (SimpleHTTPServerDriver.fetchResult):
2819         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
2820         (ModuleNotFoundError):
2821         (loadModule):
2822         (getPathFromProjectRoot):
2823         (loadJSONFromFile):
2824         (TimeoutError):
2825         (timeout):
2826         (timeout.__init__):
2827         (timeout.handle_timeout):
2828         (timeout.__enter__):
2829         (timeout.__exit__):
2830
2831 2015-04-24  Commit Queue  <commit-queue@webkit.org>
2832
2833         Unreviewed, rolling out r183303.
2834         https://bugs.webkit.org/show_bug.cgi?id=144181
2835
2836         Change was incorrect, broke builds (Requested by smfr on
2837         #webkit).
2838
2839         Reverted changeset:
2840
2841         "Fix the build."
2842         http://trac.webkit.org/changeset/183303
2843
2844 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
2845
2846         Fix the build.
2847
2848         * MiniBrowser/mac/WK2BrowserWindowController.m:
2849         (-[WK2BrowserWindowController initWithConfiguration:]):
2850
2851 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
2852
2853         Disable ActionMenusPDFTest due to timeout on test bot
2854
2855         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2856         (TestWebKitAPI::TEST):
2857
2858 2015-04-24  Commit Queue  <commit-queue@webkit.org>
2859
2860         Unreviewed, rolling out r183266.
2861         https://bugs.webkit.org/show_bug.cgi?id=144164
2862
2863         Broke 32-bit build and a test. (Requested by ap on #webkit).
2864
2865         Reverted changeset:
2866
2867         "AX: richer text change notifications (142719)"
2868         https://bugs.webkit.org/show_bug.cgi?id=142719
2869         http://trac.webkit.org/changeset/183266
2870
2871 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
2872
2873         REGRESSION: WebKit2.ActionMenusTest API test fails
2874         https://bugs.webkit.org/show_bug.cgi?id=144149
2875         <rdar://problem/20677770>
2876
2877         Reviewed by Tim Horton.
2878
2879         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
2880         as the 'ActionMenusPDFTest'.
2881         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2882         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
2883         to match the hit test on the 'action-menu-target.pdf' test file.
2884
2885 2015-04-24  Daniel Bates  <dabates@apple.com>
2886
2887         Cleanup: Use @memoized for property IOSSimulator.testing_device
2888         https://bugs.webkit.org/show_bug.cgi?id=141715
2889
2890         Reviewed by Darin Adler.
2891
2892         Simplify the caching of the result of IOSSimulator.testing_device
2893         and make the code more readable by making use of the @memoized declarator
2894         instead of explicitly managing a private instance variable,
2895         IOSSimulator._testing_device, for the cached result.
2896
2897         * Scripts/webkitpy/port/ios.py:
2898         (IOSPort.determine_full_port_name):
2899         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
2900         (IOSSimulatorPort):
2901         (IOSSimulatorPort.testing_device): No need to cache the created device object in
2902         IOSSimulatorPort._testing_device since we are marking this function @memoized.
2903         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
2904         of caching in local variable since we only make use of this value exactly once in this function.
2905         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
2906         been used since being added in r178622. So, we can remove this constructor since
2907         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
2908
2909 2015-04-24  Anders Carlsson  <andersca@apple.com>
2910
2911         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
2912         https://bugs.webkit.org/show_bug.cgi?id=144158
2913
2914         Reviewed by Beth Dakin.
2915
2916         * MiniBrowser/mac/WK2BrowserWindowController.m:
2917         (-[WK2BrowserWindowController initWithConfiguration:]):
2918
2919 2015-04-24  Doug Russell  <d_russell@apple.com>
2920
2921         AX: richer text change notifications (142719)
2922         https://bugs.webkit.org/show_bug.cgi?id=142719
2923
2924         Reviewed by Darin Adler.
2925
2926         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
2927
2928         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
2929
2930         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
2931         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2932         (-[AccessibilityNotificationHandler stopObserving]):
2933         (-[AccessibilityNotificationHandler _notificationReceived:]):
2934         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2935         (AccessibilityUIElement::removeNotificationListener):
2936         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2937         (-[AccessibilityNotificationHandler _notificationReceived:]):
2938         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2939         (WTR::AccessibilityUIElement::removeNotificationListener):
2940
2941 2015-04-24  Darin Adler  <darin@apple.com>
2942
2943         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
2944         https://bugs.webkit.org/show_bug.cgi?id=128007
2945
2946         Reviewed by Anders Carlsson.
2947
2948         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
2949         * DumpRenderTree/win/UIDelegate.h: Ditto.
2950
2951         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
2952         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
2953
2954         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
2955
2956         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
2957         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
2958         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
2959         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
2960         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2961         (WebKitDOMDOMWindowTest::create): Ditto.
2962         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2963         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
2964         of smart pointers to DelayedSIgnal objects.
2965         (uriChangedCallback): Ditto.
2966
2967 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
2968
2969         [Mac] Unreviewed test fix.
2970         https://bugs.webkit.org/show_bug.cgi?id=144149
2971
2972         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2973         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
2974         test.
2975
2976 2015-04-23  Darin Adler  <darin@apple.com>
2977
2978         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
2979         https://bugs.webkit.org/show_bug.cgi?id=144090
2980
2981         Reviewed by Anders Carlsson.
2982
2983         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
2984
2985 2015-04-23  Michael Saboff  <msaboff@apple.com>
2986
2987         lldb macro btjs sometimes can't get a frame description
2988         https://bugs.webkit.org/show_bug.cgi?id=144130
2989
2990         Reviewed by Filip Pizlo.
2991
2992         We look to execute ExecState::describeFrame().  It appears that in some contexts the
2993         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
2994         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
2995
2996         * lldb/lldb_webkit.py:
2997         (btjs):
2998
2999 2015-04-23  Alex Christensen  <achristensen@webkit.org>
3000
3001         Use less memory when compiling content extensions.
3002         https://bugs.webkit.org/show_bug.cgi?id=144051
3003
3004         Reviewed by Darin Adler and Benjamin Poulain.
3005
3006         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3007         (TestWebKitAPI::TEST_F):
3008         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3009         (TestWebKitAPI::countLiveNodes):
3010
3011 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3012
3013         [CMake] Clean up JSC JIT options
3014         https://bugs.webkit.org/show_bug.cgi?id=143998
3015
3016         Reviewed by Filip Pizlo.
3017
3018         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
3019         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
3020
3021 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
3022
3023         [Mac] Extend action menus to support PDF
3024         https://bugs.webkit.org/show_bug.cgi?id=143895
3025         <rdar://problem/19003333>
3026
3027         Reviewed by Tim Horton.
3028
3029         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
3030         of PDF content works.
3031
3032         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
3033         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
3034         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
3035         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3036         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
3037         Update to support PDF tests.
3038         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
3039         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
3040
3041 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3042
3043         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
3044
3045         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3046         (beforeAll):
3047         (testWebViewAudioOnlyUserMediaPermissionRequests):
3048
3049 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3050
3051         Add myself to watchlist
3052         https://bugs.webkit.org/show_bug.cgi?id=144041
3053
3054         Reviewed by Alex Christensen.
3055
3056         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
3057
3058         * Scripts/webkitpy/common/config/watchlist:
3059
3060 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3061
3062         [GTK] MiniBrowser should use NetworkProcess by default
3063         https://bugs.webkit.org/show_bug.cgi?id=143948
3064
3065         Reviewed by Sergio Villar Senin.
3066
3067         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
3068         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
3069
3070         * MiniBrowser/gtk/main.c:
3071         (main):
3072
3073 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
3074
3075         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
3076
3077         Unreviewed build fix.
3078
3079         * Scripts/prepare-ChangeLog:
3080         (get_function_line_ranges_for_cpp):
3081         Use grep instead of any to determine if a string is an element of an array.
3082
3083 2015-04-21  Anders Carlsson  <andersca@apple.com>
3084
3085         Fix block signatures
3086         https://bugs.webkit.org/show_bug.cgi?id=144002
3087
3088         Reviewed by Andreas Kling.
3089
3090         * MiniBrowser/mac/WK2BrowserWindowController.m:
3091         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3092
3093 2015-04-21  Philippe Normand  <pnormand@igalia.com>
3094
3095         [GTK] jhbuild should not use a branch for openwebrtc
3096         https://bugs.webkit.org/show_bug.cgi?id=143981
3097
3098         Reviewed by Carlos Garcia Campos.
3099
3100         * gtk/jhbuild.modules:
3101
3102 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
3103
3104         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
3105
3106         Unreviewed build fix.
3107
3108         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
3109         However, it has been exposed by List::MoreUtils since its inception. This patch uses
3110         the any function exposed by List::MoreUtils for greater compatibility.
3111
3112         * Scripts/prepare-ChangeLog:
3113         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
3114         the any function in all of versions of Perl used by our infrastructure.
3115
3116 2015-04-20  Alex Christensen  <achristensen@webkit.org>
3117
3118         Remove unnecessary logs when resetting tests.
3119
3120         * WebKitTestRunner/mac/TestControllerMac.mm:
3121         (WTR::TestController::platformResetPreferencesToConsistentValues):
3122         In r183020 I added some logs when compiling or removing content extensions fails.
3123         We often try to remove a content extension that does not exist, and that is not a problem.
3124
3125 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
3126
3127         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
3128         https://bugs.webkit.org/show_bug.cgi?id=143897
3129
3130         Reviewed by David Kilzer.
3131
3132         This is a speculative fix that addresses two issues:
3133
3134         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
3135         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
3136
3137         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
3138         Before: (723, 729)
3139         After: (721, 720)
3140
3141         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
3142         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
3143
3144         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
3145         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
3146
3147         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
3148
3149         2. Creating git diffs from HEAD and not origin/master by default.
3150
3151         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
3152         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
3153
3154         * Scripts/prepare-ChangeLog:
3155         (originalFile):
3156         Use HEAD instead of origin/master in default Git case.
3157
3158         (generateFunctionLists):
3159         Ensure that the end line is not less than the start line.
3160
3161         (extractLineRangeAfterChange):
3162         Set the end line to the start line if the end line is less than the start line.
3163
3164         (extractLineRangeBeforeChange):
3165         Ditto.
3166
3167 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
3168
3169         Suppress warning in prepare-ChangeLog.
3170         https://bugs.webkit.org/show_bug.cgi?id=143882
3171
3172         Reviewed by David Kilzer.
3173
3174         Prune noisy prepare-ChangeLog output by using the List::Util::any function
3175         instead of the deprecated smartmatch operator.
3176
3177         * Scripts/prepare-ChangeLog:
3178         Import the List::Util::any function.
3179
3180         (get_function_line_ranges_for_cpp):
3181         Use the any function instead of smartmatch.
3182
3183 2015-04-20  Anders Carlsson  <andersca@apple.com>
3184
3185         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
3186         https://bugs.webkit.org/show_bug.cgi?id=143966
3187
3188         Reviewed by Dan Bernstein.
3189
3190         * MiniBrowser/mac/WK2BrowserWindowController.m:
3191         (dataTypes):
3192         (-[WK2BrowserWindowController fetchWebsiteData:]):
3193         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3194         (-[WK2BrowserWindowController clearWebsiteData:]):
3195
3196 2015-04-20  Alex Christensen  <achristensen@webkit.org>
3197
3198         Fix content extension test flakiness.
3199         https://bugs.webkit.org/show_bug.cgi?id=143950
3200
3201         Reviewed by Brady Eidson.
3202
3203         * WebKitTestRunner/mac/TestControllerMac.mm:
3204         (WTR::TestController::platformResetPreferencesToConsistentValues):
3205         Remove the TestContentExtensions if it exists.
3206         (WTR::TestController::platformConfigureViewForTest):
3207         Log errors in case there are any.
3208
3209 2015-04-20  Alex Christensen  <achristensen@webkit.org>
3210
3211         Properly report errors from _WKUserContentExtensionStore.
3212         https://bugs.webkit.org/show_bug.cgi?id=143808
3213
3214         Reviewed by Darin Adler.
3215
3216         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3217         (TEST_F):
3218
3219 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3220
3221         Add a rule for NetworkCache to watchlist file
3222         https://bugs.webkit.org/show_bug.cgi?id=143945
3223
3224         Reviewed by Sergio Villar Senin.
3225
3226         And add myself to the list of watchers.
3227
3228         * Scripts/webkitpy/common/config/watchlist:
3229
3230 2015-04-19  Darin Adler  <darin@apple.com>
3231
3232         Update RefPtr documentation and deprecation
3233         https://bugs.webkit.org/show_bug.cgi?id=143936
3234
3235         Reviewed by Andreas Kling.
3236
3237         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
3238
3239 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3240
3241         Introduce bytecode intrinsics
3242         https://bugs.webkit.org/show_bug.cgi?id=143926
3243
3244         Reviewed by Filip Pizlo.
3245
3246         Change cpplint to accept emit_intrinsic_XXX.
3247
3248         * Scripts/webkitpy/style/checkers/cpp.py:
3249         (check_identifier_name_in_declaration):
3250
3251 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
3252
3253         Fix lldb_webkit.py to show StringImpls correctly
3254         https://bugs.webkit.org/show_bug.cgi?id=143920
3255
3256         Reviewed by Andreas Kling.
3257         
3258         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
3259
3260         * lldb/lldb_webkit.py:
3261         (WTFStringImplProvider.is_8bit):
3262
3263 2015-04-17  Daniel Bates  <dabates@apple.com>
3264
3265         Not able to build WebKit against iOS Simulator 8.3 SDK
3266         https://bugs.webkit.org/show_bug.cgi?id=143883
3267
3268         Reviewed by David Kilzer.
3269
3270         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
3271         so that Xcode uses them.
3272
3273         * Scripts/copy-webkitlibraries-to-product-directory:
3274
3275 2015-04-17  Beth Dakin  <bdakin@apple.com>
3276
3277         Force mouse events should go through normal mouse event handling code paths
3278         https://bugs.webkit.org/show_bug.cgi?id=143749
3279         -and corresponding-
3280         rdar://problem/20472895
3281
3282         Reviewed by Dean Jackson.
3283
3284         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
3285         Since there is not a way to create an NSEventTypePressure from scratch, we 
3286         subclass NSEvent and override all of the critical methods.
3287
3288         * WebKitTestRunner/EventSenderProxy.h:
3289         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3290         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3291         (WTR::EventSendingController::mouseForceDown):
3292         (WTR::EventSendingController::mouseForceUp):
3293         (WTR::EventSendingController::mouseForceChanged):
3294         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3295         * WebKitTestRunner/TestController.cpp:
3296         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3297         * WebKitTestRunner/mac/EventSenderProxy.mm:
3298         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3299         (-[EventSenderPressureEvent timestamp]):
3300         (-[EventSenderPressureEvent type]):
3301         (-[EventSenderPressureEvent locationInWindow]):
3302         (-[EventSenderPressureEvent location]):
3303         (-[EventSenderPressureEvent stage]):
3304         (-[EventSenderPressureEvent pressure]):
3305         (-[EventSenderPressureEvent phase]):
3306         (-[EventSenderPressureEvent eventNumber]):
3307         (WTR::EventSenderProxy::mouseForceDown):
3308         (WTR::EventSenderProxy::mouseForceUp):
3309         (WTR::EventSenderProxy::mouseForceChanged):
3310
3311 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
3312
3313         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
3314         https://bugs.webkit.org/show_bug.cgi?id=143885
3315
3316         Reviewed by Tim Horton.
3317
3318         Fixed a case where we have two builds with the same revision(s). An in order build
3319         is one for which the revision is strictly higher.
3320
3321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3322         (BuildbotQueue.prototype._checkForInOrderResult):
3323         (BuildbotQueue.prototype.compareIterationsByRevisions):
3324
3325 2015-04-17  Commit Queue  <commit-queue@webkit.org>
3326
3327         Unreviewed, rolling out r182912 and r182920.
3328         https://bugs.webkit.org/show_bug.cgi?id=143881
3329
3330         Build breakage in some configurations (Requested by ap on
3331         #webkit).
3332
3333         Reverted changesets:
3334
3335         "Force mouse events should go through normal mouse event
3336         handling code paths"
3337         https://bugs.webkit.org/show_bug.cgi?id=143749
3338         http://trac.webkit.org/changeset/182912
3339
3340         http://trac.webkit.org/changeset/182920
3341
3342 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
3343
3344         [GTK] One more unreviewed fix after r182882.
3345
3346         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
3347
3348 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
3349
3350         [GTK] Unreviewed speculative clean build fix after r182882.
3351
3352         TestWebKitAPI's forwarding header generator depended on WeKit2's
3353         which generated SOUP related forwarding headers too.
3354
3355         This dependency isn't necessary and was removed by r182882 to make
3356         forwarding header generators parallelizable. But in this case
3357         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
3358         should generate SOUP related forwarding headers too similar to EFL.
3359
3360         * TestWebKitAPI/PlatformGTK.cmake:
3361         * WebKitTestRunner/PlatformGTK.cmake:
3362
3363 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3364
3365         [SOUP] Redirect to non HTTP destination is broken
3366         https://bugs.webkit.org/show_bug.cgi?id=143866
3367
3368         Reviewed by Sergio Villar Senin.
3369
3370         Add a unit test to check that redirect to a data URI works.
3371
3372         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3373         (testRedirectToDataURI):
3374         (serverCallback):
3375         (beforeAll):
3376
3377 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
3378
3379         Changes method of quitting iOS Simulator to be more correct.
3380         https://bugs.webkit.org/show_bug.cgi?id=143847
3381         <rdar://problem/20530344>
3382
3383         Reviewed by Darin Adler.
3384
3385         Fixes by addressing the app by ID rather than by name.
3386
3387         * Scripts/webkitdirs.pm:
3388         (quitIOSSimulator):
3389         * Scripts/webkitpy/port/ios.py:
3390         (IOSSimulatorPort.check_sys_deps):
3391
3392 2015-04-16  Anders Carlsson  <andersca@apple.com>
3393
3394         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
3395         https://bugs.webkit.org/show_bug.cgi?id=143844
3396
3397         Reviewed by Dan Bernstein.
3398
3399         * MiniBrowser/mac/AppDelegate.m:
3400         (-[BrowserAppDelegate newPrivateWindow:]):
3401         * MiniBrowser/mac/WK2BrowserWindowController.m:
3402         (-[WK2BrowserWindowController initWithConfiguration:]):
3403         (-[WK2BrowserWindowController fetchWebsiteData:]):
3404         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3405         (-[WK2BrowserWindowController clearWebsiteData:]):
3406
3407 2015-04-16  Alex Christensen  <achristensen@webkit.org>
3408
3409         32-bit build fix.
3410
3411         * WebKitTestRunner/mac/TestControllerMac.mm:
3412         (WTR::TestController::platformResetPreferencesToConsistentValues):
3413         (WTR::TestController::platformConfigureViewForTest):
3414         Added WK_API_ENABLED.
3415
3416 2015-04-16  Alex Christensen  <achristensen@webkit.org>
3417
3418         Removed unused WKUserContentFilterRef.
3419         https://bugs.webkit.org/show_bug.cgi?id=143852
3420
3421         Reviewed by Sam Weinig.
3422
3423         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3424         * WebKitTestRunner/mac/TestControllerMac.mm:
3425         (WTR::TestController::platformResetPreferencesToConsistentValues):
3426         (WTR::TestController::platformConfigureViewForTest):
3427
3428 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
3429
3430         Unreviewed. Adding myself as a commiter in contributers.json.
3431
3432         * Scripts/webkitpy/common/config/contributors.json:
3433
3434 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
3435
3436         It is very hard to attach a debugger to WebProcess to debug tests
3437         https://bugs.webkit.org/show_bug.cgi?id=143837
3438
3439         Reviewed by Chris Dumez.
3440
3441         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
3442         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
3443
3444         Now it disables all timeouts in tools, as is best for debugging tests.
3445
3446         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
3447         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
3448
3449         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
3450         now has the same functionality.
3451
3452 2015-04-16  Beth Dakin  <bdakin@apple.com>
3453
3454         Force mouse events should go through normal mouse event handling code paths
3455         https://bugs.webkit.org/show_bug.cgi?id=143749
3456         -and corresponding-
3457         rdar://problem/20472895
3458
3459         Reviewed by Dean Jackson.
3460
3461         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
3462         Since there is not a way to create an NSEventTypePressure from scratch, we 
3463         subclass NSEvent and override all of the critical methods.
3464
3465         * WebKitTestRunner/EventSenderProxy.h:
3466         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3467         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3468         (WTR::EventSendingController::mouseForceDown):
3469         (WTR::EventSendingController::mouseForceUp):
3470         (WTR::EventSendingController::mouseForceChanged):
3471         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3472         * WebKitTestRunner/TestController.cpp:
3473         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3474         * WebKitTestRunner/mac/EventSenderProxy.mm:
3475         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3476         (-[EventSenderPressureEvent timestamp]):
3477         (-[EventSenderPressureEvent type]):
3478         (-[EventSenderPressureEvent locationInWindow]):
3479         (-[EventSenderPressureEvent location]):
3480         (-[EventSenderPressureEvent stage]):
3481         (-[EventSenderPressureEvent pressure]):
3482         (-[EventSenderPressureEvent phase]):
3483         (-[EventSenderPressureEvent eventNumber]):
3484         (WTR::EventSenderProxy::mouseForceDown):
3485         (WTR::EventSenderProxy::mouseForceUp):
3486         (WTR::EventSenderProxy::mouseForceChanged):
3487
3488 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
3489
3490         [EFL] Bump LLVM to version 3.6.0 on X86_64
3491         https://bugs.webkit.org/show_bug.cgi?id=143604
3492
3493         Reviewed by Gyuyoung Kim.
3494
3495         * efl/jhbuild.modules:
3496         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
3497         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
3498         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
3499         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
3500
3501 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
3502
3503         [EFL] Remove an unnecessary workaround from jhbuildrc
3504         https://bugs.webkit.org/show_bug.cgi?id=143823
3505
3506         Reviewed by Gyuyoung Kim.
3507
3508         * efl/jhbuildrc:
3509
3510 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
3511
3512         [GTK] Run forwarding headers generator unconditionally
3513         https://bugs.webkit.org/show_bug.cgi?id=143819
3514
3515         Reviewed by Carlos Garcia Campos.
3516
3517         * TestWebKitAPI/PlatformGTK.cmake:
3518         * WebKitTestRunner/PlatformGTK.cmake:
3519
3520 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3521
3522         [EFL] Add gnutls to jhbuild.module
3523         https://bugs.webkit.org/show_bug.cgi?id=143777
3524
3525         Reviewed by Csaba Osztrogonác.
3526
3527         EFL port has required at least 3.0.0 version of gnutls since r176712.
3528         However some old linux distributions don't support 3.0.0 version. Besides
3529         other projects sometimes need to use lower version of gnutls.
3530
3531         This patch supports to download gnutls through jhbuild, and use it.
3532
3533         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
3534         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
3535
3536 2015-04-15  Mark Lam  <mark.lam@apple.com>
3537
3538         Remove obsolete VMInspector debugging tool.
3539         https://bugs.webkit.org/show_bug.cgi?id=143798
3540
3541         Reviewed by Michael Saboff.
3542
3543         * TestWebKitAPI/CMakeLists.txt:
3544         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3545         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3547         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
3548
3549 2015-04-15  Jer Noble  <jer.noble@apple.com>
3550
3551         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
3552
3553         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3554
3555 2015-04-15  Jer Noble  <jer.noble@apple.com>
3556
3557         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
3558
3559         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3560         (TestWebKitAPI::TEST_F):
3561
3562 2015-04-15  Chris Dumez  <cdumez@apple.com>
3563
3564         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
3565         https://bugs.webkit.org/show_bug.cgi?id=143779
3566
3567         Reviewed by Brent Fulgham.
3568
3569         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
3570         similarly to what is done on Mac / WK1. Without this, PageCache could
3571         stay enabled after page cache tests and cause weird behaviors.
3572
3573         * DumpRenderTree/win/DumpRenderTree.cpp:
3574         (resetWebPreferencesToConsistentValues):
3575
3576 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
3577
3578         Re-enable custom dilation for antialiased fonts
3579         https://bugs.webkit.org/show_bug.cgi?id=143738
3580
3581         Reviewed by Tim Horton.
3582         
3583         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
3584         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
3585         a private WebKit pref. This pref defaults to YES, enabling the feature by default
3586         in WK1 as we do for WK2.
3587
3588         * DumpRenderTree/mac/DumpRenderTree.mm:
3589         (resetWebPreferencesToConsistentValues):
3590         * WebKitTestRunner/TestController.cpp:
3591         (WTR::TestController::resetPreferencesToConsistentValues):
3592
3593 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
3594
3595         Correct layering violation in DumpRenderTree Build
3596         https://bugs.webkit.org/show_bug.cgi?id=143732
3597
3598         Reviewed by Simon Fraser.
3599
3600         Correct a layering violation in DumpRenderTree by calling functions on the
3601         WebCoreTestSupport library, rather than attempting to work with WebCore
3602         types directly.
3603
3604         * DumpRenderTree/mac/EventSendingController.mm:
3605         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
3606         than WebCore itself.,
3607         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
3608
3609 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
3610
3611         Add a conservative DFA minimizer for the content extension matcher
3612         https://bugs.webkit.org/show_bug.cgi?id=143501
3613
3614         Reviewed by Alex Christensen.
3615
3616         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3617         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3618
3619 2015-04-14  Daniel Bates  <dabates@apple.com>
3620
3621         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
3622         https://bugs.webkit.org/show_bug.cgi?id=143693
3623         <rdar://problem/20530316>
3624
3625         Reviewed by Tim Horton.
3626
3627         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
3628         to use the fixed layout code on iOS at this time.
3629
3630         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
3631
3632 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
3633
3634         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
3635         https://bugs.webkit.org/show_bug.cgi?id=143705
3636
3637         Unreviewed change to watchlist file.
3638
3639         * Scripts/webkitpy/common/config/watchlist:
3640
3641 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
3642
3643         [EFL] favicon wasn't updated for google.com sometimes.
3644         https://bugs.webkit.org/show_bug.cgi?id=141940
3645
3646         Reviewed by Gyuyoung Kim.
3647
3648         As elm_entry_utf8_to_markup can include additional characters, parameter for the
3649         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
3650
3651         * MiniBrowser/efl/main.c:
3652         (on_url_changed):
3653
3654 2015-04-13  Tim Horton  <timothy_horton@apple.com>
3655
3656         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
3657         https://bugs.webkit.org/show_bug.cgi?id=143560
3658         <rdar://problem/16302047>
3659
3660         Reviewed by Darin Adler.
3661
3662         * MiniBrowser/mac/BrowserWindowController.h:
3663         * MiniBrowser/mac/MainMenu.xib:
3664         * MiniBrowser/mac/WK1BrowserWindowController.m:
3665         (-[WK1BrowserWindowController setScale:]):
3666         * MiniBrowser/mac/WK2BrowserWindowController.m:
3667         (viewScaleForMenuItemTag):
3668         (-[WK2BrowserWindowController setScale:]):
3669         (-[WK2BrowserWindowController validateMenuItem:]):