[macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttac...
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
4         https://bugs.webkit.org/show_bug.cgi?id=181626
5
6         Reviewed by Joseph Pecoraro.
7
8         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
9         Additionally, write a new API test covering the change in r226915.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
12         (webViewForTestingAttachments):
13         (TestWebKitAPI::TEST):
14
15 2018-01-12  Alex Christensen  <achristensen@webkit.org>
16
17         History state should be updated during client redirects with asynchronous policy decisions
18         https://bugs.webkit.org/show_bug.cgi?id=181358
19         <rdar://problem/35547689>
20
21         Reviewed by Andy Estes.
22
23         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
24         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
25         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
26         (TEST):
27
28 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
29
30         webkitpy: Refactor simulator code (Part 4)
31         https://bugs.webkit.org/show_bug.cgi?id=180555
32         <rdar://problem/36131381>
33
34         Reviewed by Aakash Jain.
35
36         Move new_simulated_device.py to simulated_device.py.
37
38         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
39         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
40         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
41         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
42         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
43
44 2018-01-12  Alex Christensen  <achristensen@webkit.org>
45
46         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
47         https://bugs.webkit.org/show_bug.cgi?id=181595
48
49         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
50         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
51         I change the < and > to $ to make this test pass and continue to test what it used to.
52
53         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
54         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
55         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
56
57 2018-01-11  Keith Miller  <keith_miller@apple.com>
58
59         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
60         https://bugs.webkit.org/show_bug.cgi?id=181573
61
62         Reviewed by Simon Fraser.
63
64         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
65
66 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
67
68         [WebAuthN] Import a CBOR coder from Chromium
69         https://bugs.webkit.org/show_bug.cgi?id=181522
70         <rdar://problem/36055729>
71
72         Reviewed by Brent Fulgham.
73
74         This patch also imports all unit tests into our API tests to ensure all
75         workarounds and modification against the original codebase doesn't change
76         any original functionalities.
77
78         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
79         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
80         (TestWebKitAPI::TEST):
81         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
82         (TestWebKitAPI::TEST):
83         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
84         (TestWebKitAPI::eq):
85         Workarounds applied.
86         (TestWebKitAPI::TEST):
87
88 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
89
90         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
91         https://bugs.webkit.org/show_bug.cgi?id=181538
92         <rdar://problem/36440580>
93
94         Reviewed by Aakash Jain.
95
96         When disambiguating a device type, it is possible that the provided device type is sufficiently
97         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
98         will result in a failure to disambiguate the type.
99
100         * Scripts/webkitpy/xcode/new_simulated_device.py:
101         (SimulatedDeviceManager._disambiguate_device_type):
102
103 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
104
105         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
106         https://bugs.webkit.org/show_bug.cgi?id=181136
107         <rdar://problem/36116604>
108
109         Reviewed by Chris Dumez.
110
111         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
112         browsing sessions.
113
114         * Scripts/run-gtk-tests:
115         (GtkTestRunner): Unskip test now that it passes.
116         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
117         (TEST): Add new WebsiteDataStoreEphemeral test.
118
119 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
120
121         Unreviewed, rolling out r226816.
122
123         This change broke LayoutTests on the bots.
124
125         Reverted changeset:
126
127         "run-webkit-tests fails when there is a curly brace in Xcode
128         build output"
129         https://bugs.webkit.org/show_bug.cgi?id=181254
130         https://trac.webkit.org/changeset/226816
131
132 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
133
134         webkitpy: Fix flakey webserver tests
135         https://bugs.webkit.org/show_bug.cgi?id=181555
136         <rdar://problem/36448273>
137
138         Reviewed by Aakash Jain.
139
140         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
141         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
142         determine if a specific server is running.
143
144 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
145
146         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
147         https://bugs.webkit.org/show_bug.cgi?id=181561
148         <rdar://problem/36452652>
149
150         Reviewed by Aakash Jain.
151
152         BeautifulSoup.find may return None, this case should be gracefully handled.
153
154         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
155         (BugzillaQueries._parse_result_count):
156         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
157
158 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
159
160         run-webkit-tests fails when there is a curly brace in Xcode build output
161         https://bugs.webkit.org/show_bug.cgi?id=181254
162
163         Reviewed by Daniel Bates.
164
165         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
166         (MeteredStream.write):
167
168 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
169
170         webkitpy: Reimplement simulator code (Part 3)
171         https://bugs.webkit.org/show_bug.cgi?id=180555
172         <rdar://problem/36131381>
173
174         Reviewed by Aakash Jain.
175
176         Remove old simulator code.
177
178         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
179         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
180         * Scripts/webkitpy/xcode/simulator.py: Removed.
181         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
182
183 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
184
185         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
186         https://bugs.webkit.org/show_bug.cgi?id=181337
187         <rdar://problem/36324813>
188
189         Reviewed by Tim Horton.
190
191         Add 3 new API tests for attachment element dragging.
192
193         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
194         (-[TestWKWebView expectElementTag:toComeBefore:]):
195         (-[NSItemProvider expectType:withData:]):
196         (TestWebKitAPI::TEST):
197
198 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
199
200         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
201         https://bugs.webkit.org/show_bug.cgi?id=179621
202         <rdar://problem/35589585>
203
204         Unreviewed infrastructure fix.
205
206         * Scripts/webkitpy/port/mac.py:
207         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
208         list if we are the VERSION_MAX, which usually corresponds with future.
209
210 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
211
212         CodeBlocks should be in IsoSubspaces
213         https://bugs.webkit.org/show_bug.cgi?id=180884
214
215         Reviewed by Saam Barati.
216         
217         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
218         shouldn't take a long time due to benchmarks we don't optimize for.
219         
220         * Scripts/run-jsc-benchmarks:
221
222 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
223
224         Test gardening for GTK.
225         https://bugs.webkit.org/show_bug.cgi?id=181477
226
227         Unreviewed test gardening.
228
229         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
230         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
231
232 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
233
234         Add the new JSCOnly bot to the scheduler.
235         https://bugs.webkit.org/show_bug.cgi?id=181487
236
237         Unreviewed follow-up patch after r226729
238
239         On r226729 I missed to add the new JSCOnly bot the default scheduler.
240         This is needed to make the bot automatically pick each commit for testing.
241
242         * BuildSlaveSupport/build.webkit.org-config/config.json:
243
244 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
245
246         [Attachment Support] Support dragging attachment elements out as files on iOS
247         https://bugs.webkit.org/show_bug.cgi?id=181199
248         <rdar://problem/36299316>
249
250         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
251
252         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
253         attachment API tests.
254
255         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
256         (-[NSItemProvider expectType:withData:]):
257         (TestWebKitAPI::TEST):
258
259         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
260         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
261         -expectType:withData: helper to inspect the item providers created from the drag source.
262
263         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
264         (TestWebKitAPI::TEST):
265         * TestWebKitAPI/ios/DataInteractionSimulator.h:
266         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
267         (-[MockDragSession localContext]):
268         (-[MockDragSession setLocalContext:]):
269         (-[DataInteractionSimulator _resetSimulatedState]):
270         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
271         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
272         (-[DataInteractionSimulator _advanceProgress]):
273         (-[DataInteractionSimulator endDataTransfer]):
274
275         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
276         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
277         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
278         MockDragSession to hold on to a localContext.
279
280 2018-01-11  Ali Juma  <ajuma@chromium.org>
281
282         Unreviewed. Add Ali Juma as contributor
283
284         * Scripts/webkitpy/common/config/contributors.json:
285
286 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
287
288         Unreviewed. Update Selenium WebDriver imported tests.
289
290         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
291         environment variables.
292
293         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
294         (collect): Reorder the arguments to make pytest happy.
295         (run): Ditto.
296         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
297         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
298
299 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
300
301         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
302         https://bugs.webkit.org/show_bug.cgi?id=181492
303         <rdar://problem/36359679>
304
305         Reviewed by Alexey Proskuryakov. 
306
307 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
308
309         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
310         https://bugs.webkit.org/show_bug.cgi?id=181475
311
312         Reviewed by Michael Catanzaro.
313
314         * gtk/install-dependencies: Update package list for Arch Linux, extend
315         message shown at end of installation with additional tips.
316
317 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
318
319         REGRESSION(r222507): Composition highlight doesn't render when using IME
320         https://bugs.webkit.org/show_bug.cgi?id=181485
321         <rdar://problem/35896516>
322
323         Reviewed by Ryosuke Niwa.
324
325         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
326         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
327         allow rendering composition backgrounds (see InlineTextBox::paint).
328
329         * DumpRenderTree/ios/TextInputControllerIOS.m:
330         (+[TextInputController isSelectorExcludedFromWebScript:]):
331         (+[TextInputController webScriptNameForSelector:]):
332         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
333         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
334         * DumpRenderTree/mac/TextInputControllerMac.m:
335         (+[TextInputController isSelectorExcludedFromWebScript:]):
336         (+[TextInputController webScriptNameForSelector:]):
337         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
338         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
339         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
340         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
341         (WTR::TextInputController::setMarkedText):
342         * WebKitTestRunner/InjectedBundle/TextInputController.h:
343
344 2018-01-10  JF Bastien  <jfbastien@apple.com>
345
346         Poison small JSObject derivatives which only contain pointers
347         https://bugs.webkit.org/show_bug.cgi?id=181483
348         <rdar://problem/36407127>
349
350         Reviewed by Mark Lam.
351
352         Test the new move-assign and move-copy from unique_ptr, as well as
353         nullptr_t ctors.
354
355         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
356         (TestWebKitAPI::TEST):
357         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
358         (TestWebKitAPI::TEST):
359         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
360         (TestWebKitAPI::TEST):
361
362 2018-01-10  Chris Dumez  <cdumez@apple.com>
363
364         Multiple http/wpt/beacon/contentextensions/ test are flaky.
365         https://bugs.webkit.org/show_bug.cgi?id=179256
366         <rdar://problem/35401978>
367
368         Reviewed by Alex Christensen.
369
370         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
371         instance gets its own folder to avoid conflicts and flakiness.
372
373         * WebKitTestRunner/mac/TestControllerMac.mm:
374         (WTR::TestController::platformConfigureViewForTest):
375
376 2018-01-10  Tim Horton  <timothy_horton@apple.com>
377
378         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
379         https://bugs.webkit.org/show_bug.cgi?id=181269
380         <rdar://problem/35110344>
381
382         Reviewed by Simon Fraser.
383
384         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
385         (WTR::UIScriptController::beginBackSwipe):
386         (WTR::UIScriptController::completeBackSwipe):
387         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
388         (WTR::UIScriptController::beginBackSwipe):
389         (WTR::UIScriptController::completeBackSwipe):
390         (WTR::UIScriptController::overridePreference):
391         (WTR::UIScriptController::replaceTextAtRange):
392         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
393         (WTR::PlatformWebView::setNavigationGesturesEnabled):
394         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
395         (WTR::UIScriptController::beginBackSwipe):
396         (WTR::UIScriptController::completeBackSwipe):
397         Implement beginBackSwipe and completeBackSwipe on iOS (they already
398         exist on Mac) in terms of the new WKWebView testing SPI.
399
400 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
401
402         REGRESSION (r226715): ignore WARNING output in linter tests
403         https://bugs.webkit.org/show_bug.cgi?id=181486
404         <rdar://problem/36408847>
405
406         Reviewed by Aakash Jain.
407
408         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
409
410         * Scripts/webkitpy/common/system/outputcapture.py:
411         (OutputCapture.__init__): Pass logging level to be captured.
412         * Scripts/webkitpy/style/main_unittest.py:
413         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
414         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
415         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
416         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
417         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
418         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
419         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
420         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
421
422 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
423
424         Add a JSCOnly MIPS buildbot
425         https://bugs.webkit.org/show_bug.cgi?id=181487
426
427         Reviewed by Michael Catanzaro.
428
429         Add the new bot configs definitions for the master and update the unit tests.
430
431         * BuildSlaveSupport/build.webkit.org-config/config.json:
432         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
433
434 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
435
436         REGRESSION (r226715): don't re-check number of simulators in child processes
437         https://bugs.webkit.org/show_bug.cgi?id=181484
438         <rdar://problem/36407151>
439
440         Reviewed by Aakash Jain.
441
442         * Scripts/webkitpy/port/ios_simulator.py:
443         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
444         are already initialized.
445
446 2018-01-10  Commit Queue  <commit-queue@webkit.org>
447
448         Unreviewed, rolling out r226667 and r226673.
449         https://bugs.webkit.org/show_bug.cgi?id=181488
450
451         This caused a flaky crash. (Requested by mlewis13 on #webkit).
452
453         Reverted changesets:
454
455         "CodeBlocks should be in IsoSubspaces"
456         https://bugs.webkit.org/show_bug.cgi?id=180884
457         https://trac.webkit.org/changeset/226667
458
459         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
460         https://bugs.webkit.org/show_bug.cgi?id=180884
461         https://trac.webkit.org/changeset/226673
462
463 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
464
465         Follow-up fix to r226715
466         https://bugs.webkit.org/show_bug.cgi?id=180555
467         <rdar://problem/36131381>
468
469         Unreviewed infrastructure fix.
470
471         * Scripts/webkitpy/xcode/new_simulated_device.py:
472         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
473         of delete.
474
475 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
476
477         webkitpy: Refactor simulator code (Part 2)
478         https://bugs.webkit.org/show_bug.cgi?id=180555
479         <rdar://problem/36131381>
480
481         Reviewed by Aakash Jain.
482
483         The patch leverages the SimulatedDeviceManager when running layout tests.
484         This patch is primarily code removal, since much of the IOSSimulatorPort
485         was dedicated to managing simulators. The removed code is either now owned by the
486         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
487         boot multiple simulators which was made obsolete in Xcode 9.
488
489         * Scripts/webkitpy/layout_tests/controllers/manager.py:
490         (Manager._custom_device_for_test.in): Device names now have spaces in them,
491         strip those spaces.
492         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
493         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
494         * Scripts/webkitpy/port/ios.py:
495         (IOSPort.__init__): The _current_device idiom is no longer required since the
496         SimulatedDeviceManager keeps track of any previously booted devices.
497         (IOSPort.target_host): Even when only a single device is used, it will be accessed
498         through the array of managed devices.
499         (IOSPort.using_multiple_devices): Deleted.
500         * Scripts/webkitpy/port/ios_device.py:
501         (IOSDevicePort.using_multiple_devices): Deleted.
502         * Scripts/webkitpy/port/ios_simulator.py:
503         (IOSSimulatorPort): Remove constants required to manage simulators, change device
504         class strings so they can be parsed by the DeviceType class.
505         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
506         the number of simulators currently booted, the number of child processes specified
507         and the maximum number of simulators supported by this system.
508         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
509         devices owned by the SimulatedDeviceManager.
510         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
511         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
512         the maximum number of supported simulators on this system.
513         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
514         request for each child process and send this list to the SimulatedDeviceManager to
515         initialize the devices.
516         (IOSSimulatorPort.clean_up_test_run):
517         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
518         specified version of iOS.
519         (IOSSimulatorPort.reset_preferences):
520         (IOSSimulatorPort.simulator_runtime): Deleted.
521         (IOSSimulatorPort.simulator_device_type): Deleted.
522         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
523         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
524         (IOSSimulatorPort._create_simulators): Deleted.
525         (IOSSimulatorPort._quit_ios_simulator): Deleted.
526         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
527         (IOSSimulatorPort.using_multiple_devices): Deleted.
528         (IOSSimulatorPort._create_device): Deleted.
529         (IOSSimulatorPort.get_simulator_path): Deleted.
530         (IOSSimulatorPort._createSimulatorApps): Deleted.
531         (IOSSimulatorPort._createSimulatorApp): Deleted.
532         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
533         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
534         maximum number of simulators run on this system.
535         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
536         * Scripts/webkitpy/xcode/new_simulated_device.py:
537         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
538
539 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
540
541         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
542         https://bugs.webkit.org/show_bug.cgi?id=181474
543
544         Reviewed by Carlos Alberto Lopez Perez.
545
546         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
547         name as the name.
548
549         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
550         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
551         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
552
553 2018-01-09  Andy Estes  <aestes@apple.com>
554
555         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
556         https://bugs.webkit.org/show_bug.cgi?id=181459
557
558         Reviewed by Dan Bernstein.
559
560         * ImageDiff/cg/Configurations/Base.xcconfig:
561
562 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
563
564         font-display:fallback can cause a visual flash (which is supposed to be impossible)
565         https://bugs.webkit.org/show_bug.cgi?id=181374
566
567         Reviewed by Simon Fraser.
568
569         The test requires Palatino.
570
571         * DumpRenderTree/mac/DumpRenderTree.mm:
572         (allowedFontFamilySet):
573         * WebKitTestRunner/mac/TestControllerMac.mm:
574         (WTR::allowedFontFamilySet):
575
576 2018-01-09  Saam Barati  <sbarati@apple.com>
577
578         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
579         https://bugs.webkit.org/show_bug.cgi?id=181449
580
581         Reviewed by JF Bastien.
582
583         This allows me to Cmd+f in my terminal to search for things without
584         having the results become misaligned.
585
586         * Scripts/display-profiler-output:
587
588 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
589
590         [webkitpy] PlatformInfo should have default argument for casual use
591         https://bugs.webkit.org/show_bug.cgi?id=180827
592
593         Reviewed by David Kilzer.
594
595         PlatformInfo should be the only way to check platform specific thing instead
596         of sys.platform or other various checks. If there is something you want to check,
597         it should be placed in PlatformInfo.
598
599         Currently to instantiate PlatformInfo, it requires arguments, which is usually
600         sys, platform and Executive(). They are straight forward and should be handled
601         by default arguments. Then we can instantiate PlatformInfo more casual.
602
603         * Scripts/webkitpy/common/system/platforminfo.py:
604         (PlatformInfo): Use relative module path import
605         (PlatformInfo.__init__):
606         (PlatformInfo.executive): Lazy instantiation of Executive()
607         (PlatformInfo.total_bytes_memory): Accessing via above property
608         (PlatformInfo.xcode_sdk_version): Ditto
609         (PlatformInfo.xcode_simctl_list): Ditto
610         (PlatformInfo.xcode_version): Ditto
611         (PlatformInfo._win_version_str): Ditto
612         * Scripts/webkitpy/common/system/systemhost.py:
613         (SystemHost.__init__):
614         * Scripts/webkitpy/common/system/user.py:
615         (User.__init__):
616
617 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
618
619         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
620         https://bugs.webkit.org/show_bug.cgi?id=176443
621
622         Reviewed by Darin Adler.
623
624         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
625         (TEST):
626
627 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
628
629         check-webkit-style: Verify syntax for WK_API_AVAILABLE
630         https://bugs.webkit.org/show_bug.cgi?id=181394
631
632         Reviewed by Darin Adler.
633
634         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
635         as the second parameter instead of ios(WK_IOS_TBA). This generally
636         builds for iOS on EWS but not when using the public SDK. See r224057,
637         r223207 and r226211 for example. This patch adds a basic style check
638         for that macro to prevent this kind of mistake.
639
640         * Scripts/webkitpy/style/checkers/cpp.py:
641         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
642         (check_style): Run new style check.
643         (CppChecker): Add build type for the new style check.
644         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
645         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
646
647 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
648
649         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
650         https://bugs.webkit.org/show_bug.cgi?id=181420
651         <rdar://problem/36365827>
652
653         Reviewed by Alex Christensen.
654
655         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
656         of corresponding _WKAttachments.
657
658         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
659         (TestWebKitAPI::TEST):
660
661 2018-01-08  Alex Christensen  <achristensen@webkit.org>
662
663         Add WKNavigationDelegate SPI exposing WebProcess crash reason
664         https://bugs.webkit.org/show_bug.cgi?id=181410
665         <rdar://problem/36167199>
666
667         Reviewed by Wenson Hsieh.
668
669         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
670         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
671         (TEST):
672
673 2018-01-08  Alex Christensen  <achristensen@webkit.org>
674
675         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
676         https://bugs.webkit.org/show_bug.cgi?id=181408
677         <rdar://problem/35884960>
678
679         Reviewed by Tim Horton.
680
681         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
682         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
683
684 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
685
686         [Attachment Support] Expose file name and content type of WKAttachment
687         https://bugs.webkit.org/show_bug.cgi?id=181390
688         <rdar://problem/36336837>
689
690         Reviewed by Tim Horton.
691
692         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
693
694         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
695         (-[_WKAttachment synchronouslyRequestInfo:]):
696         (-[_WKAttachment synchronouslyRequestData:]):
697
698         Reimplement this in terms of -synchronouslyRequestInfo:.
699
700         (-[_WKAttachment expectRequestedDataToBe:]):
701         (TestWebKitAPI::TEST):
702
703 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
704
705         Copying, pasting, and then deleting an attachment element breaks attachment data requests
706         https://bugs.webkit.org/show_bug.cgi?id=181365
707         <rdar://problem/36340647>
708
709         Reviewed by Tim Horton.
710
711         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
712         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
713         detail.
714
715         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
716         (TestWebKitAPI::TEST):
717
718 2018-01-08  Youenn Fablet  <youenn@apple.com>
719
720         navigator.onLine does not work inside service workers
721         https://bugs.webkit.org/show_bug.cgi?id=181079
722         <rdar://problem/36178606>
723
724         Reviewed by Darin Adler.
725
726         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
727         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
728
729 2018-01-07  Saam Barati  <sbarati@apple.com>
730
731         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
732         https://bugs.webkit.org/show_bug.cgi?id=181372
733
734         Reviewed by Filip Pizlo.
735
736         Adding these sorting modes makes it easier to analyze functions
737         that recompile a lot and exit a lot.
738
739         * Scripts/display-profiler-output:
740
741 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
742
743         Unreviewed, remove my Cisco email from contributors.json
744
745         * Scripts/webkitpy/common/config/contributors.json:
746
747 2018-01-05  JF Bastien  <jfbastien@apple.com>
748
749         WebAssembly: poison JS object's secrets
750         https://bugs.webkit.org/show_bug.cgi?id=181339
751         <rdar://problem/36325001>
752
753         Reviewed by Mark Lam.
754
755         Update tests for swap(Poisoned<k, T>, T*)
756
757         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
758         (TestWebKitAPI::TEST):
759         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
760         (TestWebKitAPI::TEST):
761         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
762         (TestWebKitAPI::TEST):
763
764 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
765
766         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
767         https://bugs.webkit.org/show_bug.cgi?id=181359
768
769         Reviewed by Tim Horton.
770
771         Ensure that these tests still pass using older SDKs.
772
773         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
774         (TestWebKitAPI::TEST):
775
776 2018-01-05  Alex Christensen  <achristensen@webkit.org>
777
778         Rebase API test after r226469
779         https://bugs.webkit.org/show_bug.cgi?id=181308
780
781         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
782         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
783         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
784
785 2018-01-05  Alex Christensen  <achristensen@webkit.org>
786
787         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
788         https://bugs.webkit.org/show_bug.cgi?id=181217
789
790         Reviewed by Tim Horton.
791
792         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
793         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
794         (TEST):
795
796 2018-01-05  Alex Christensen  <achristensen@webkit.org>
797
798         Add WKBundleFrameCreateFrameHandle
799         https://bugs.webkit.org/show_bug.cgi?id=181232
800         <rdar://problem/35926696>
801
802         Reviewed by Tim Horton.
803
804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
805         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
806         (mouseDidMoveOverElement):
807         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
808         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
809         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
810         (TEST):
811
812 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
813
814         iOS: Build fix after r226432.
815         
816         Unreviewed. Stop duplicating speakAs symbols for iOS.
817
818         * DumpRenderTree/AccessibilityUIElement.cpp:
819         (AccessibilityUIElement::speakAs):
820
821 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
822
823         Unreviewed, added myself as WebKit reviewer
824
825         * Scripts/webkitpy/common/config/contributors.json:
826
827 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
828
829         WPE: Build fix after r226432.
830
831         Unreviewed. Rename ::speak() to ::speakAs().
832         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
833         (WTR::AccessibilityUIElement::speakAs):
834         (WTR::AccessibilityUIElement::speak): Deleted.
835
836 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
837
838         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
839         https://bugs.webkit.org/show_bug.cgi?id=180361
840
841         Reviewed by Zalan Bujtas.
842
843         * DumpRenderTree/AccessibilityUIElement.cpp:
844         (speakAsCallback):
845         (AccessibilityUIElement::speakAs):
846         (AccessibilityUIElement::getJSClass):
847         (speakCallback): Deleted.
848         (AccessibilityUIElement::speak): Deleted.
849         * DumpRenderTree/AccessibilityUIElement.h:
850         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
851         (AccessibilityUIElement::speakAs):
852         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
853         (AccessibilityUIElement::speakAs):
854         (AccessibilityUIElement::speak): Deleted.
855         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
856         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
857         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
858         (WTR::AccessibilityUIElement::speakAs):
859         (WTR::AccessibilityUIElement::speak): Deleted.
860         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
861         (WTR::AccessibilityUIElement::speakAs):
862         (WTR::AccessibilityUIElement::speak): Deleted.
863
864 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
865
866         REGRESSION (r226395): test-webkitperl test expectations incorrect
867         https://bugs.webkit.org/show_bug.cgi?id=181307
868         <rdar://problem/36306558>
869
870         Rubber-stamped by Aakash Jain.
871
872         r226395 added two lines towards the beginning of
873         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
874         numbers in the test expectations need to update.
875
876         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
877
878 2018-01-04  Tim Horton  <timothy_horton@apple.com>
879
880         WKWebView loses minimum layout size overrides that happen while the process is terminated
881         https://bugs.webkit.org/show_bug.cgi?id=181306
882         <rdar://problem/34398288>
883
884         Reviewed by Dan Bernstein.
885
886         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
887         (TEST):
888         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
889         while the process is terminated results in the page getting the correct
890         minimum layout size.
891
892 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
893
894         [MediaStream] Add Mock screen capture source
895         https://bugs.webkit.org/show_bug.cgi?id=181291
896         <rdar://problem/36298164>
897
898         Reviewed by Dean Jackson.
899
900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
901         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
902         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
903
904 2018-01-04  Lucas Forschler  <lforschler@apple.com>
905
906         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
907
908         Reviewed by Ling Ho.
909
910         * BuildSlaveSupport/build.webkit.org-config/steps.py:
911
912 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
913
914         [Attachment Support] Create attachment elements when dropping files on iOS
915         https://bugs.webkit.org/show_bug.cgi?id=181192
916         <rdar://problem/36280945>
917
918         Reviewed by Tim Horton.
919
920         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
921         switch is enabled. See below for more details.
922
923         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
924         (-[NSItemProvider registerData:type:]):
925         (platformCopyPNG):
926         (TestWebKitAPI::TEST):
927         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
928
929         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
930         source item provider when dragging rich text *without* attachments, so this should have been a check for just
931         kUTTypeRTF instead.
932
933         (TestWebKitAPI::TEST):
934
935         Tests a few cases of inserting attachment elements via drop:
936         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
937             Instead of inserting the contents as inline web content, this should generate attachment elements.
938         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
939             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
940             back to inserting the content as an attachment.
941         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
942             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
943             or at the end).
944
945         * TestWebKitAPI/cocoa/TestWKWebView.h:
946         * TestWebKitAPI/cocoa/TestWKWebView.mm:
947         (-[TestWKWebView objectByEvaluatingJavaScript:]):
948
949         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
950         -stringByEvaluatingJavaScript to just turn around and call this.
951
952         (-[TestWKWebView stringByEvaluatingJavaScript:]):
953
954 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
955
956         Replace hard-coded paths in shebangs with #!/usr/bin/env
957         https://bugs.webkit.org/show_bug.cgi?id=181040
958
959         Reviewed by Alex Christensen.
960
961         * BuildSlaveSupport/build-launcher-app:
962         * BuildSlaveSupport/build-launcher-dmg:
963         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
964         * BuildSlaveSupport/built-product-archive:
965         * BuildSlaveSupport/clean-build:
966         * BuildSlaveSupport/delete-stale-build-files:
967         * BuildSlaveSupport/download-built-product:
968         * BuildSlaveSupport/gtk/buildbot/log/run:
969         * BuildSlaveSupport/gtk/buildbot/run:
970         * BuildSlaveSupport/gtk/pulseaudio/run:
971         * BuildSlaveSupport/kill-old-processes:
972         * BuildSlaveSupport/test-result-archive:
973         * BuildSlaveSupport/win/kill-old-processes:
974         * Scripts/SpacingHeuristics.pm:
975         * Scripts/add-include:
976         * Scripts/build-api-tests:
977         * Scripts/build-dumprendertree:
978         * Scripts/build-imagediff:
979         * Scripts/build-jsc:
980         * Scripts/build-webkit:
981         * Scripts/build-webkittestrunner:
982         * Scripts/check-Xcode-source-file-types:
983         * Scripts/check-dom-results:
984         * Scripts/check-for-exit-time-destructors:
985         * Scripts/check-for-global-initializers:
986         * Scripts/check-for-inappropriate-objc-class-names:
987         * Scripts/check-for-weak-vtables-and-externals:
988         * Scripts/clean-header-guards:
989         * Scripts/compare-timing-files:
990         * Scripts/configure-xcode-for-ios-development:
991         * Scripts/copy-webkitlibraries-to-product-directory:
992         * Scripts/create-exports:
993         * Scripts/debug-minibrowser:
994         * Scripts/debug-safari:
995         * Scripts/debug-test-runner:
996         * Scripts/do-file-rename:
997         * Scripts/do-webcore-rename:
998         * Scripts/dump-webkit-tests-run:
999         * Scripts/ensure-valid-python:
1000         * Scripts/execAppWithEnv:
1001         * Scripts/extract-localizable-js-strings:
1002         * Scripts/filter-build-webkit:
1003         * Scripts/find-extra-includes:
1004         * Scripts/fix-blink-patch:
1005         * Scripts/generate-coverage-data:
1006         * Scripts/git-add-reviewer:
1007         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1008         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1009         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
1010         * Scripts/make-new-script-test:
1011         * Scripts/make-script-test-wrappers:
1012         * Scripts/package-root:
1013         * Scripts/parse-malloc-history:
1014         * Scripts/report-include-statistics:
1015         * Scripts/resolve-ChangeLogs:
1016         * Scripts/run-api-tests:
1017         * Scripts/run-bindings-tests:
1018         * Scripts/run-content-extension-tester:
1019         * Scripts/run-iexploder-tests:
1020         * Scripts/run-javascriptcore-tests:
1021         * Scripts/run-jsc:
1022         * Scripts/run-leaks:
1023         * Scripts/run-mangleme-tests:
1024         * Scripts/run-minibrowser:
1025         * Scripts/run-pageloadtest:
1026         * Scripts/run-regexp-tests:
1027         * Scripts/run-safari:
1028         * Scripts/run-sunspider:
1029         * Scripts/run-test-runner:
1030         * Scripts/run-webkit-app:
1031         * Scripts/run-webkit-httpd:
1032         * Scripts/run-webkit-websocketserver:
1033         * Scripts/set-webkit-configuration:
1034         * Scripts/show-pretty-diff:
1035         * Scripts/sort-Xcode-project-file:
1036         * Scripts/split-file-by-class:
1037         * Scripts/sunspider-compare-results:
1038         * Scripts/svn-apply:
1039         * Scripts/svn-unapply:
1040         * Scripts/test-webkit-scripts:
1041         * Scripts/test-webkitperl:
1042         * Scripts/update-iexploder-cssproperties:
1043         * Scripts/update-javascriptcore-test-results:
1044         * Scripts/update-webkit:
1045         * Scripts/update-webkit-auxiliary-libs:
1046         * Scripts/update-webkit-dependency:
1047         * Scripts/update-webkit-libs-jhbuild:
1048         * Scripts/update-webkit-localizable-strings:
1049         * Scripts/update-webkit-support-libs:
1050         * Scripts/update-webkitgtk-libs:
1051         * Scripts/update-webkitwpe-libs:
1052         * Scripts/webkit-build-directory:
1053         * Scripts/webkitperl/LoadAsModule.pm:
1054         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1055         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1056         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1057         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1058         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1059         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1060         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1061         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1062         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1063         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1064         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1065         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1066         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1067         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1068         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1069         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1070         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1071         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1072         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1073         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1074         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1075         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1076         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1077         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1078         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1079         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1080         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1081         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1082         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1083         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1084         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1085         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1086         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1087         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1088         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1089         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1090         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1091         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1092         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1093         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1094         * ccache/ccache-clang:
1095         * ccache/ccache-clang++:
1096         * ccache/ccache-wrapper:
1097         * gtk/install-dependencies:
1098         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1099         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1100         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1101         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1102         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1103         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1104         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1105         * iExploder/iexploder-1.7.2/src/webserver.rb:
1106         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1107         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1108         * wpe/install-dependencies:
1109
1110 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1111
1112         filter-build-webkit filters out useful compiler error lines
1113         https://bugs.webkit.org/show_bug.cgi?id=179864
1114
1115         Reviewed by Tim Horton.
1116
1117         Don't filter out lines that contain information about build errors by always showing lines
1118         after a line that contains "note:" or "error:".
1119
1120         * Scripts/filter-build-webkit:
1121         (shouldShowSubsequentLine):
1122         (shouldIgnoreLine):
1123
1124 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1125
1126         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1127         https://bugs.webkit.org/show_bug.cgi?id=173915
1128
1129         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1130         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1131         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1132         empty string in this case.
1133
1134         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1135         (emitFormSubmissionEvent):
1136
1137 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1138
1139         [GTK] Add web process API to detect when form is submitted via JavaScript
1140         https://bugs.webkit.org/show_bug.cgi?id=173915
1141
1142         Reviewed by Carlos Garcia Campos.
1143
1144         Test it.
1145
1146         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1147         (FormSubmissionTest::FormSubmissionTest):
1148         (FormSubmissionTest::~FormSubmissionTest):
1149         (FormSubmissionTest::testFormSubmissionResult):
1150         (FormSubmissionTest::willSendDOMEventCallback):
1151         (FormSubmissionTest::willCompleteCallback):
1152         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1153         (testWebExtensionFormSubmissionSteps):
1154         (beforeAll):
1155         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1156         (DelayedSignal::DelayedSignal):
1157         (emitFormSubmissionEvent):
1158         (handleFormSubmissionCallback):
1159         (willSubmitFormCallback):
1160         (pageCreatedCallback):
1161
1162 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1163
1164         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1165         https://bugs.webkit.org/show_bug.cgi?id=181251
1166
1167         * Scripts/run-gtk-tests:
1168         (GtkTestRunner):
1169
1170 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1171
1172         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1173         https://bugs.webkit.org/show_bug.cgi?id=181136
1174
1175         * Scripts/run-gtk-tests:
1176         (GtkTestRunner):
1177
1178 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1179
1180         [macOS, iOS] Adopt new secure coding APIs in WebKit
1181         https://bugs.webkit.org/show_bug.cgi?id=181085
1182         <rdar://problem/34837397>
1183
1184         Reviewed by Tim Horton.
1185
1186         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1187         capable of supporting NSSecureCoding, so pass through the current coding routines.
1188
1189         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1190         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1191         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1192         routines if necessary.
1193         (TEST): Updated for NSSecureCoding.
1194         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1195         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1196
1197 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1198
1199         Remove std::chrono completely
1200         https://bugs.webkit.org/show_bug.cgi?id=181186
1201
1202         Reviewed by Alex Christensen.
1203
1204         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1205         (WTR::TestController::platformRunUntil):
1206
1207 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1208
1209         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1210         https://bugs.webkit.org/show_bug.cgi?id=181231
1211
1212         Reviewed by Alex Christensen.
1213
1214         Implement TestController APIs needed by ResourceLoadStatistics tests.
1215
1216         * WebKitTestRunner/TestController.cpp:
1217         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1218         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1219
1220 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1221
1222         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1223         https://bugs.webkit.org/show_bug.cgi?id=181219
1224
1225         Reviewed by Wenson Hsieh.
1226
1227         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1228
1229 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1230
1231         Add a WebAuthentication runtime feature flag
1232         https://bugs.webkit.org/show_bug.cgi?id=181220
1233         <rdar://problem/36055305>
1234
1235         Reviewed by Brent Fulgham.
1236
1237         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1238
1239         * DumpRenderTree/TestOptions.h:
1240         * DumpRenderTree/TestOptions.mm:
1241         (TestOptions::TestOptions):
1242         * DumpRenderTree/mac/DumpRenderTree.mm:
1243         (enableExperimentalFeatures):
1244         (setWebPreferencesForTestOptions):
1245         * WebKitTestRunner/TestController.cpp:
1246         (WTR::TestController::resetPreferencesToConsistentValues):
1247         (WTR::updateTestOptionsFromTestHeader):
1248         * WebKitTestRunner/TestOptions.h:
1249         (WTR::TestOptions::hasSameInitializationOptions const):
1250
1251 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1252
1253         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1254         https://bugs.webkit.org/show_bug.cgi?id=181143
1255         <rdar://problem/36200381>
1256
1257         Reviewed by Tim Horton.
1258
1259         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1260         attachment elements are enabled.
1261
1262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1263         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1264         (TestWebKitAPI::TEST):
1265
1266 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1267
1268         Update Credential Management API for WebAuthentication
1269         https://bugs.webkit.org/show_bug.cgi?id=181082
1270         <rdar://problem/36055239>
1271
1272         Reviewed by Brent Fulgham.
1273
1274         Enable Credential Management API for testing.
1275
1276         * DumpRenderTree/TestOptions.h:
1277         * WebKitTestRunner/TestOptions.h:
1278
1279 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1280
1281         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1282         https://bugs.webkit.org/show_bug.cgi?id=168194
1283
1284         Reviewed by Carlos Garcia Campos.
1285
1286         Fix an assertion and unskip the test. The order that form controls are associated is not
1287         guaranteed.
1288
1289         * Scripts/run-gtk-tests:
1290         (GtkTestRunner):
1291         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1292         (didAssociateFormControlsCallback):
1293
1294 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1295
1296         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1297         https://bugs.webkit.org/show_bug.cgi?id=180897
1298         <rdar://problem/35535328>
1299
1300         Reviewed by Brent Fulgham.
1301
1302         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1303
1304         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1305         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1306         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1307         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1308         (websiteDataStoreTestWebView):
1309         (TEST):
1310
1311 == Rolled over to ChangeLog-2018-01-01 ==