[iOS] Support TestWebKitAPI in the iOS Simulator
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-15  David Kilzer  <ddkilzer@apple.com>
2
3         [iOS] Support TestWebKitAPI in the iOS Simulator
4         <http://webkit.org/b/129535>
5         <rdar://problem/16203529>
6
7         Reviewed by Daniel Bates.
8
9         * Scripts/run-api-tests:
10         (runTest):
11         (listAllTests):
12         - Extract common arguments into local variable.
13         - Use xcrun to find the sim tool in order to invoke
14         TestWebKitAPI properly in the iOS Simulator. 
15
16         * Scripts/webkitdirs.pm:
17         (argumentsForConfiguration): Set --device or --sim as
18         appropriate to fix buildTestTool() in run-api-tests.
19
20 2014-05-15  Tim Horton  <timothy_horton@apple.com>
21
22         Fix a logging typo in copy-webkitlibraries-to-product-directory
23
24         Reviewed by Dean Jackson.
25
26         * Scripts/copy-webkitlibraries-to-product-directory:
27
28 2014-05-15  David Kilzer  <ddkilzer@apple.com>
29
30         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
31         <http://webkit.org/b/132959>
32
33         Reviewed by Dan Bernstein.
34
35         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
36         Cocoa directory to project and move URLExtras.mm into it.
37         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
38
39 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
40
41         [GTK] Compile all installed resources as GResources
42         https://bugs.webkit.org/show_bug.cgi?id=131099
43
44         Reviewed by Philippe Normand.
45
46         * Scripts/webkitpy/port/gtk.py:
47         (GtkPort.setup_environ_for_server): Removed now unneeded
48         AUDIO_RESOURCES_PATH env var.
49
50 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
51
52         Remove CSS_STICKY_POSITION guards
53         https://bugs.webkit.org/show_bug.cgi?id=132676
54
55         Reviewed by Simon Fraser.
56
57         * Scripts/webkitperl/FeatureList.pm:
58
59 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
60
61         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
62         https://bugs.webkit.org/show_bug.cgi?id=132686
63
64         Reviewed by Philippe Normand.
65
66         Bring back InputMethodFilter test to the build and compile it into
67         a single binary TestWebCore with the other WebCore tests. Also
68         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
69
70         * Scripts/run-gtk-tests:
71         (TestRunner): Remove WebCoreGtk from the list of test directories.
72         * TestWebKitAPI/PlatformGTK.cmake:
73         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
74
75 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
76
77         [EFL] Make XVFBDriver optional
78         https://bugs.webkit.org/show_bug.cgi?id=131036
79
80         Reviewed by Gyuyoung Kim.
81
82         * Scripts/webkitpy/port/efl.py:
83         (EflPort._driver_class):
84
85 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
86
87         Flakiness dashboard contains outdated list of bots on builders.jsonp
88         https://bugs.webkit.org/show_bug.cgi?id=132874
89
90         Reviewed by Darin Adler.
91
92         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
93         file by changing to the directory Tools/TestResultServer and executing
94         the script generate_builders_json.py
95
96 2014-05-11  Anders Carlsson  <andersca@apple.com>
97
98         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
99         https://bugs.webkit.org/show_bug.cgi?id=132809
100
101         Reviewed by Dan Bernstein.
102
103         * WebKitTestRunner/TestController.cpp:
104         (WTR::TestController::initialize):
105         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
106
107 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
108
109         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
110         https://bugs.webkit.org/show_bug.cgi?id=132739
111
112         Reviewed Anders Carlsson.
113
114         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
115         the JSC unit tests.
116         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
117
118 2014-05-11  Anders Carlsson  <andersca@apple.com>
119
120         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
121         https://bugs.webkit.org/show_bug.cgi?id=132806
122
123         Reviewed by Beth Dakin.
124
125         Migrate to WKContextConfiguration.
126
127         * WebKitTestRunner/TestController.cpp:
128         (WTR::TestController::initialize):
129
130 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
131
132         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
133         https://bugs.webkit.org/show_bug.cgi?id=132685
134
135         Reviewed by Martin Robinson.
136
137         Use a single TestWebKit2 binary for all WebKit2 C API tests.
138
139         * TestWebKitAPI/PlatformGTK.cmake:
140
141 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
142
143         [iOS] Switch geolocation to an explicit authorization query model
144         https://bugs.webkit.org/show_bug.cgi?id=132717
145
146         Reviewed by Sam Weinig.
147
148         * DumpRenderTree/mac/MockGeolocationProvider.mm:
149         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
150         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
151
152 2014-05-09  David Farler  <dfarler@apple.com>
153
154         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
155         https://bugs.webkit.org/show_bug.cgi?id=132718
156
157         Reviewed by David Kilzer.
158
159         The simulator may not be able to look up runtimes by SDK paths
160         and instead will map SDK versions to runtimes instead. In
161         com.apple.iphonesimulator.startSession notifications,
162         'runtimeIdentifier' (SDK version string) is preferred over
163         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
164         when creating a new DRT or WKTR simulator session.
165
166         IPhoneSimulatorNotification.pm filters out keys for this
167         notification's userInfo with a hard-coded list. There's no harm
168         in including extra key-value pairs in an NSNotification userInfo
169         dictionary anyway and the simulator may again change its
170         userInfo schema for this notification.
171
172         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
173         (postStartSessionNotification):
174         * Scripts/old-run-webkit-tests:
175         (installAndLaunchDumpToolAppUsingNotification):
176
177 2014-05-09  Anders Carlsson  <andersca@apple.com>
178
179         Another build fix.
180
181         * Scripts/build-webkit:
182         WebKit2 should always be built for OS X and iOS.
183
184 2014-05-09  Anders Carlsson  <andersca@apple.com>
185
186         Follow-up build fix.
187
188         * Scripts/build-webkit:
189         WebKit2 should no longer be built before WebKit.
190
191 2014-05-09  Anders Carlsson  <andersca@apple.com>
192
193         Rename WebKit2.framework to WebKit.framework
194         https://bugs.webkit.org/show_bug.cgi?id=132743
195         <rdar://problem/15920046>
196
197         Reviewed by Dan Bernstein.
198
199         * Scripts/check-for-inappropriate-files-in-framework:
200         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
201         Change WebKit2 to WebKit.
202
203         * Scripts/check-for-webkit-framework-include-consistency:
204         Change WebKit to WebKitLegacy.
205
206 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
207
208         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
209         https://bugs.webkit.org/show_bug.cgi?id=132732
210
211         Reviewed by Alexey Proskuryakov.
212
213         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
214
215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
216         (EWS): Remove GTK+ WK1 EWS.
217
218 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
219
220         Add new u-szeged contributors.
221
222         Reviewed by Csaba Osztrogonác.
223
224         * Scripts/webkitpy/common/config/contributors.json:
225
226 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
227
228         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
229         https://bugs.webkit.org/show_bug.cgi?id=132736
230
231         Reviewed by Philippe Normand.
232
233         There are two problems, the path returned by common.library_build_path() is wrong when
234         common.binary_build_path() has previously been called, and the test is still looking for
235         the .la instead of .so
236
237         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
238         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
239         of .la as extension of the injected bundle library.
240         * gtk/common.py:
241         (binary_build_path): Remove unused global variable and add a new
242         one for binary_build_dir instead of sharing the same global
243         variable for library_build_path and binary_build_path.
244
245 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
246
247         [EFL] Enable MEDIA_STREAM for EFL port
248         https://bugs.webkit.org/show_bug.cgi?id=132648
249
250         Reviewed by Gyuyoung Kim.
251
252         Script modified to enable MEDIA_STREAM for EFL build.
253
254         * Scripts/webkitperl/FeatureList.pm: 
255
256 2014-05-08  David Farler  <dfarler@apple.com>
257
258         old-run-webkit-tests: update strings for simulator devices and app name
259         https://bugs.webkit.org/show_bug.cgi?id=132687
260
261         Reviewed by Darin Adler.
262
263         iPhone Retina (4-inch) -> iPhone 5
264         iPhone Retina (4-inch 64-bit) -> iPhone 5s
265
266         * Scripts/old-run-webkit-tests:
267         (installAndLaunchDumpToolAppUsingNotification):
268         (openIPhoneSimulator):
269         (quitIPhoneSimulator):
270         quit iOS Simulator, not iPhone Simulator.
271
272 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
273
274         REGRESSION(r168471): Update the builder names on the scheduler list.
275         https://bugs.webkit.org/show_bug.cgi?id=132699
276
277         Reviewed by Martin Robinson.
278
279         On r168471 I missed to update the builder names for the GTK build
280         bots on the AnyBranchScheduler type scheduler list of bots.
281
282         * BuildSlaveSupport/build.webkit.org-config/config.json:
283
284 2014-05-08  Brady Eidson  <beidson@apple.com>
285
286         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
287         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
288
289         Reviewed by Tim Horton.
290
291         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
292         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
293
294 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
295
296         REGRESSION(r168471): Duplicate builddirs broke the build master.
297         https://bugs.webkit.org/show_bug.cgi?id=132688
298
299         Reviewed by Carlos Garcia Campos.
300
301         Rename the builddirs of the new GTK bots introduced on r168471 to
302         be unique. Otherwise the master will break.
303
304         * BuildSlaveSupport/build.webkit.org-config/config.json:
305
306 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
307
308         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
309         https://bugs.webkit.org/show_bug.cgi?id=132674
310
311         Reviewed by Philippe Normand.
312
313         Only ignore mkdir failure when exception is raised because the
314         file already exists and it's a directory.
315
316         * gtk/webkitdom.py:
317         (write_doc_files):
318
319 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
320
321         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
322         https://bugs.webkit.org/show_bug.cgi?id=131358
323
324         Reviewed by Carlos Garcia Campos.
325
326         Current 64-bit GTK build bots (Release and Debug) not only test
327         the build, but run all tests. Split each one of the bots in
328         BuildOnly and TestWebKit2.
329
330         This will allow us to have a better overview of the status of
331         the GTK port.
332
333         Original patch from Sergio Villar Senin <svillar@igalia.com>
334
335         * BuildSlaveSupport/build.webkit.org-config/config.json:
336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
338         (WebKitBuildbot):
339         * Scripts/webkitpy/port/builders.py:
340         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
341         (TestRebaselineTest.test_baseline_directory):
342         * TestResultServer/static-dashboards/builders.jsonp:
343         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
344         (resetGlobals):
345         * TestResultServer/static-dashboards/loader_unittests.js:
346
347 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
348
349         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
350         https://bugs.webkit.org/show_bug.cgi?id=126022
351
352         Reviewed by Benjamin Poulain.
353
354         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
355
356         Added an unit test case to check if scroll position and scale are restored properly.
357
358         * TestWebKitAPI/PlatformEfl.cmake:
359         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
360         (TestWebKitAPI::didFinishLoadForFrame):
361         (TestWebKitAPI::didChangeContentsPosition):
362         (TestWebKitAPI::TEST):
363         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
364         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
365
366 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
367
368         WebKit1 is flashy when compositing layers come and go
369         https://bugs.webkit.org/show_bug.cgi?id=132655
370         <rdar://problem/16830981&16788846>
371
372         Reviewed by Sam Weinig.
373         
374         Revert the change from r166117.
375
376         * DumpRenderTree/mac/DumpRenderTree.mm:
377         (updateDisplay):
378
379 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
380
381         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
382         https://bugs.webkit.org/show_bug.cgi?id=132622
383
384         Reviewed by Mario Sanchez Prada.
385
386         * DumpRenderTree/AccessibilityUIElement.cpp:
387         (selectTextWithCriteriaCallback):
388         (isEqualCallback):
389         * DumpRenderTree/AccessibilityUIElement.h:
390         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
391         (AccessibilityUIElement::selectTextWithCriteria):
392         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
393         (AccessibilityUIElement::selectTextWithCriteria):
394         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
395         (selectTextParameterizedAttributeForCriteria):
396         (AccessibilityUIElement::selectTextWithCriteria):
397         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
398         (AccessibilityUIElement::selectTextWithCriteria):
399         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
400         (WTR::AccessibilityUIElement::selectTextWithCriteria):
401         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
402         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
403         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
404         (WTR::AccessibilityUIElement::selectTextWithCriteria):
405         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
406         (WTR::AccessibilityUIElement::selectTextWithCriteria):
407         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
408         (WTR::selectTextParameterizedAttributeForCriteria):
409         (WTR::AccessibilityUIElement::selectTextWithCriteria):
410
411 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
412
413         [SOUP] TLSErrors do not cause page load to fail when not ignored
414         https://bugs.webkit.org/show_bug.cgi?id=121548
415
416         Reviewed by Sergio Villar Senin.
417
418         Add unit tests to check that the load fails with TLS errors in
419         case of a redirection.
420
421         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
422         (testTLSErrorsRedirect):
423         (httpsServerCallback):
424         (beforeAll):
425
426 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
427
428         [CSS Grid Layout] Remove runtime feature
429         https://bugs.webkit.org/show_bug.cgi?id=132382
430
431         Reviewed by Benjamin Poulain.
432
433         Remove cssGridLayoutEnabled setting usage.
434
435         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
436         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
437         * DumpRenderTree/efl/TestRunnerEfl.cpp:
438         (TestRunner::overridePreference):
439         * DumpRenderTree/mac/DumpRenderTree.mm:
440         (resetWebPreferencesToConsistentValues):
441
442 2014-05-06  David Kilzer  <ddkilzer@apple.com>
443
444         Add Makefile targets for copying static libraries (LLVM and WKSI)
445         <http://webkit.org/b/132619>
446
447         Reviewed by Mark Rowe.
448
449         * Scripts/copy-webkitlibraries-to-product-directory: Set a
450         sensible default for product directory if not specified on
451         either the command-line or in the environment (by Xcode) by
452         calling productDir() in webkitdirs.pm.
453
454 2014-05-06  Brady Eidson  <beidson@apple.com>
455
456         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
457         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
458
459         Reviewed by Sam Weinig.
460
461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
462
463         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
464         (TestWebKitAPI::itemURLLastComponentIsString):
465         (TestWebKitAPI::didFinishLoadForFrame):
466         (TestWebKitAPI::willGoToBackForwardListItem):
467         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
468         (TestWebKitAPI::setPageLoaderClient):
469         (TestWebKitAPI::TEST):
470         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
471         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
472
473         * WebKitTestRunner/TestController.cpp:
474         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
475
476 2014-05-06  Darin Adler  <darin@apple.com>
477
478         Try to fix iOS build.
479
480         * DumpRenderTree/mac/TestRunnerMac.mm:
481         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
482         Updated since I changed testRunner into a pointer instead of a reference.
483         Updated argument names to avoid conflict with field names.
484         (-[APITestDelegateIPhone run]): Ditto.
485         (-[APITestDelegateIPhone _cleanUp]): Ditto.
486
487 2014-05-06  Commit Queue  <commit-queue@webkit.org>
488
489         Unreviewed, rolling out r168304.
490         https://bugs.webkit.org/show_bug.cgi?id=132607
491
492         Broke the build (Requested by KaL on #webkit).
493
494         Reverted changeset:
495
496         "[GTK][CMake] Unable to do make install"
497         https://bugs.webkit.org/show_bug.cgi?id=130188
498         http://trac.webkit.org/changeset/168304
499
500 2014-05-04  Darin Adler  <darin@apple.com>
501
502         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
503         https://bugs.webkit.org/show_bug.cgi?id=80222
504
505         Reviewed by Alexey Proskuryakov.
506
507         * DumpRenderTree/mac/TestRunnerMac.mm:
508         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
509         do more work here so we don't use RetainPtr local variables.
510         (-[APITestDelegateIPhone dealloc]): Added.
511         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
512         created. Updated for changes to member names and types.
513         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
514         updated for changes to member names and types. Changed to two word spelling.
515         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
516         name of _cleanUp method.
517         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
518         Ditto.
519         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
520
521 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
522
523         Clean up Image Document and tweak the layout and viewport
524         https://bugs.webkit.org/show_bug.cgi?id=132552
525
526         Reviewed by Anders Carlsson.
527
528         * DumpRenderTree/mac/DumpRenderTree.mm:
529         (resetWebPreferencesToConsistentValues):
530         Update the default settings to have something consistent with WebKit2.
531
532 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
533
534         [GTK][CMake] Unable to do make install
535         https://bugs.webkit.org/show_bug.cgi?id=130188
536
537         Reviewed by Carlos Garcia Campos.
538
539         * Scripts/webkitdirs.pm:
540         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
541         will give an early signal that a change has broken the documentation.
542
543 2014-05-05  Pratik Solanki  <psolanki@apple.com>
544
545         Update framework locations in package-root
546         https://bugs.webkit.org/show_bug.cgi?id=132571
547
548         Reviewed by Simon Fraser.
549
550         * Scripts/package-root:
551
552 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
553
554         [EFL][WK2] Refactor favicon database APIs
555         https://bugs.webkit.org/show_bug.cgi?id=132519
556
557         Reviewed by Gyuyoung Kim.
558
559         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
560         (update_view_favicon):
561         (on_icon_changed_cb):
562         (window_free):
563         (on_url_changed):
564         (window_create):
565         (on_view_favicon_changed): Deleted.
566
567 2014-05-02  Mark Rowe  <mrowe@apple.com>
568
569         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
570
571         Reviewed by Dan Bernstein.
572
573         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
574         when determining which LLVM archive to extract.
575
576 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
577
578         Add Jeremy as a committer.
579         https://bugs.webkit.org/show_bug.cgi?id=132492
580
581         Reviewed by Jer Noble.
582
583         Add myself as a committer.
584
585         * Scripts/webkitpy/common/config/contributors.json:
586
587 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
588
589         Add Jeremy as a committer.
590         https://bugs.webkit.org/show_bug.cgi?id=132492
591
592         Reviewed by Jer Noble.
593
594         Add Jeremy Jones to the committers file.
595
596         * Scripts/webkitpy/common/config/contributors.json:
597
598 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
599
600         Hard to figure out how to run a single test with run-api-tests
601         https://bugs.webkit.org/show_bug.cgi?id=116332
602
603         Reviewed by Alexey Proskuryakov.
604
605         * Scripts/run-api-tests: add two examples to the help message.
606
607 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
608
609         Fix several memory leaks found by code inspection
610         https://bugs.webkit.org/show_bug.cgi?id=132472
611
612         Reviewed by Geoffrey Garen.
613         
614         Fix memory leaks.
615
616         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
617         (TestWebKitAPI::TEST):
618         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
619         (WTR::InjectedBundlePage::willSendRequestForFrame):
620         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
621         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
622
623 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
624
625         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
626         https://bugs.webkit.org/show_bug.cgi?id=132446
627
628         Reviewed by Mark Hahnenberg.
629         
630         Test the FTL by default now that it's enabled by default.
631
632         * Scripts/run-javascriptcore-tests:
633
634 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
635
636         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
637         https://bugs.webkit.org/show_bug.cgi?id=132240
638
639         Reviewed by Anders Carlsson.
640
641         Removed ewk_view_setting_tiled_backingstore related code.
642
643         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
644         (DumpRenderTreeChrome::createView):
645         (shouldUseTiledBackingStore): Deleted.
646         * EWebLauncher/main.c:
647         (windowCreate):
648         (parseUserArguments):
649
650 2014-05-01  Anders Carlsson  <andersca@apple.com>
651
652         window.testRunner.keepWebHistory() should update the UI process state
653         https://bugs.webkit.org/show_bug.cgi?id=132440
654
655         Reviewed by Dan Bernstein.
656
657         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
658         (WTR::InjectedBundle::postSetAddsVisitedLinks):
659         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
660         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
661         (WTR::TestRunner::keepWebHistory):
662         * WebKitTestRunner/TestInvocation.cpp:
663         (WTR::TestInvocation::invoke):
664         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
665
666 2014-05-01  David Kilzer  <ddkilzer@apple.com>
667
668         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
669         <http://webkit.org/b/132432>
670
671         Reviewed by Tim Horton.
672
673         * Scripts/webkitperl/FeatureList.pm: Remove support for
674         --plugin-proxy-for-video switch.
675
676 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
677
678         Kernel sysctl interface hw.activecpu don't exists on Linux.
679         https://bugs.webkit.org/show_bug.cgi?id=132286
680
681         Reviewed by Filip Pizlo.
682
683         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
684         calling sysctl over hw.activecpu
685
686 2014-04-30  Anders Carlsson  <andersca@apple.com>
687
688         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
689         https://bugs.webkit.org/show_bug.cgi?id=132399
690         <rdar://problem/15920046>
691
692         Reviewed by Dan Bernstein.
693
694         * Scripts/check-for-webkit-framework-include-consistency:
695         Allos WAK headers in WebKitLegacy as well as WebKit.
696
697         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
698         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
699         Update header imports.
700
701 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
702
703         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
704         https://bugs.webkit.org/show_bug.cgi?id=131954
705
706         Reviewed by Darin Adler.
707         
708         WebKitTestRunner was adding application-specific information to crash reports
709         to log the test path, but only in the web process. Fix it to also do this
710         for the UI process, for both iOS and OS X.
711         
712         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
713         both iOS and OS X.
714         
715         Factored crash reprorter-related code into CrashReporterInfo, and call it from
716         a new TestController::platformWillRunTest() function on Mac and iOS.
717         
718         Also remove Xcode-added unit test junk from the project.
719
720         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
721         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
722         * WebKitTestRunner/TestController.cpp:
723         (WTR::TestController::runTest):
724         * WebKitTestRunner/TestController.h:
725         * WebKitTestRunner/TestInvocation.cpp:
726         (WTR::TestInvocation::url):
727         * WebKitTestRunner/TestInvocation.h:
728         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
729         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
730         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
731         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
732         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
733         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
734         (WTR::testPathFromURL):
735         (WTR::setCrashReportApplicationSpecificInformationToURL):
736         * WebKitTestRunner/efl/TestControllerEfl.cpp:
737         (WTR::TestController::platformWillRunTest):
738         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
739         (WTR::TestController::platformWillRunTest):
740         * WebKitTestRunner/ios/TestControllerIOS.mm:
741         (WTR::TestController::platformWillRunTest):
742         (WTR::TestController::setHidden):
743         * WebKitTestRunner/mac/TestControllerMac.mm:
744         (WTR::TestController::platformWillRunTest):
745
746 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
747
748         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
749
750         Reviewed by Tim Horton.
751
752         * DumpRenderTree/mac/DumpRenderTree.mm:
753         (resetWebPreferencesToConsistentValues):
754         (prepareConsistentTestingEnvironment):
755
756 2014-04-30  Anders Carlsson  <andersca@apple.com>
757
758         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
759         https://bugs.webkit.org/show_bug.cgi?id=132397
760
761         Reviewed by Dan Bernstein.
762
763         * Scripts/check-for-inappropriate-macros-in-external-headers:
764
765 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
766
767         [GTK] Make it easier to run CMake for downstreams
768         https://bugs.webkit.org/show_bug.cgi?id=132370
769
770         Reviewed by Carlos Garcia Campos.
771
772         * Scripts/webkitdirs.pm:
773         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
774         the GTK+ port.
775
776 2014-04-29  Stephanie Lewis  <slewis@apple.com>
777
778         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
779         
780         Rubber stamped by Jessie Berlin.
781
782         JSON.pm was removed from our tools setup.
783
784         * Scripts/generate-coverage-data:
785
786 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
787
788         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
789         https://bugs.webkit.org/show_bug.cgi?id=112840
790
791         Rubber stamped by Geoffrey Garen.
792
793         * Scripts/build-jsc: Enable it on Mac.
794         * Scripts/build-webkit: Enable it on Mac.
795         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
796
797 2014-04-28  Sam Weinig  <sam@webkit.org>
798
799         REGRESSION (r167751): svn-create-patch is very slow
800         https://bugs.webkit.org/show_bug.cgi?id=132300
801
802         Reviewed by Alexey Proskuryakov.
803
804         * Scripts/svn-create-patch:
805         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
806         by calling `svn-create-patch --style`.
807
808 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
809
810         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
811         https://bugs.webkit.org/show_bug.cgi?id=132190
812
813         Reviewed by Gustavo Noronha Silva.
814
815         * Scripts/webkitdirs.pm:
816         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
817             if ninja is in the path.
818         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
819             to the previous ninja generator if not.
820
821 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
822
823         check-webkit-style should understand --git-index
824         https://bugs.webkit.org/show_bug.cgi?id=125364
825
826         Reviewed by Csaba Osztrogonác.
827
828         * Scripts/webkitpy/common/checkout/scm/git.py:
829         (Git.create_patch): The command now supports the --cached option.
830         * Scripts/webkitpy/style/main.py:
831         (CheckWebKitStyle.main): Passing the --git-index option.
832         * Scripts/webkitpy/style/optparser.py:
833         (CommandOptionValues.__init__): The git-index option is switched off by default.
834         (CommandOptionValues.__eq__): Equality check for the new option.
835         (ArgumentParser._create_option_parser):Adding the --git-index option
836         (ArgumentParser.parse):
837         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
838         (CommandOptionValuesTest.test_init): 
839         (CommandOptionValuesTest.test_eq):
840
841 2014-04-28  Michael Saboff  <msaboff@apple.com>
842
843         Crash in platform/mac/accessibility/table-visible-rows.html
844         https://bugs.webkit.org/show_bug.cgi?id=132146
845
846         Reviewed by Filip Pizlo.
847
848         Instead of creating a local JSValueRef array on the stack and passing that to
849         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
850         values using the JSObjectSetPropertyAtIndex() API.
851
852         * DumpRenderTree/AccessibilityUIElement.cpp:
853         (elementsForRangeCallback):
854         (convertElementsToObjectArray):
855         * DumpRenderTree/mac/TestRunnerMac.mm:
856         (originsArrayToJS):
857         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
858         (WTR::EventSendingController::contextClick):
859         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
860         (WTR::stringArrayToJS):
861         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
862         (WTR::convertElementsToObjectArray):
863
864 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
865
866         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
867         "no-cjit" runs force the old-school threshold.
868
869         Rubber stamped by Mark Hahnenberg.
870
871         * Scripts/run-jsc-stress-tests:
872
873 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
874
875         [GTK] install-dependencies should also install ruby-json and ruby-highline
876         https://bugs.webkit.org/show_bug.cgi?id=132292
877
878         Reviewed by Philippe Normand.
879
880         * gtk/install-dependencies: Install ruby json and highline packages.
881
882 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
883
884         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
885         https://bugs.webkit.org/show_bug.cgi?id=132176
886
887         Reviewed by Gyuyoung Kim.
888
889         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
890         and turn off indexedDB feature until the sqlite implementation is introduced.
891
892         * Scripts/webkitperl/FeatureList.pm:
893
894 2014-04-25  James Craig  <jcraig@apple.com>
895
896         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
897         https://bugs.webkit.org/show_bug.cgi?id=132209
898
899         Reviewed by Daniel Bates.
900
901         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
902         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
903
904         * Scripts/prepare-ChangeLog:
905         (main): 
906
907 2014-04-25  Michael Saboff  <msaboff@apple.com>
908
909         Crash in platform/mac/accessibility/table-visible-rows.html
910         https://bugs.webkit.org/show_bug.cgi?id=132146
911
912         Reviewed by Mark Lam.
913
914         Changed to use a local JSValueRef array temporary instead of a
915         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
916         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
917         the temporary values could be collected.
918
919         * DumpRenderTree/AccessibilityUIElement.cpp:
920         (convertElementsToObjectArray):
921         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
922         (WTR::EventSendingController::contextClick):
923         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
924         (WTR::convertElementsToObjectArray):
925
926 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
927
928         Unreviewed GTK gardening
929
930         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
931         (TestRunner):
932
933 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
934
935         prepare-ChangeLog reports as deleted methods that has not been removed.
936         https://bugs.webkit.org/show_bug.cgi?id=131733
937
938         Reviewed by Ryosuke Niwa.
939
940         * Scripts/prepare-ChangeLog:
941         (originalFile): Set merge base to origin/master by default.
942
943 2014-04-23  James Craig  <jcraig@apple.com>
944
945         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
946         https://bugs.webkit.org/show_bug.cgi?id=131115
947
948         Reviewed by Daniel Bates.
949
950         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
951
952         * Scripts/commit-log-editor: Added --no-style.
953         * Scripts/prepare-ChangeLog: Primary patch.
954         (main): Primary patch.
955         (createPatchCommand): Added --no-style.
956         * Scripts/svn-create-patch: Primary patch.
957         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
958         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
959         (SVN.create_patch): Added --no-style.
960
961 2014-04-23  Anders Carlsson  <andersca@apple.com>
962
963         Try to fix iOS build.
964
965         * DumpRenderTree/mac/DumpRenderTree.mm:
966
967 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
968
969         Eliminate internals.setMockScrollbarsEnabled()
970         https://bugs.webkit.org/show_bug.cgi?id=132085
971
972         Reviewed by Tim Horton.
973
974         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
975         No need to reset the preference, there is no way it can change.
976
977 2014-04-23  James Craig  <jcraig@apple.com>
978
979         Unreviewed. Moving myself from Contributors to Committers list.
980
981         * Scripts/webkitpy/common/config/contributors.json:
982
983 2014-04-23  Tim Horton  <timothy_horton@apple.com>
984
985         Mock scrollbars don't always work in DumpRenderTree
986         https://bugs.webkit.org/show_bug.cgi?id=132082
987
988         Reviewed by Alexey Proskuryakov.
989
990         * DumpRenderTree/mac/DumpRenderTree.mm:
991         (prepareConsistentTestingEnvironment):
992         Set the mock scrollbar setting before creating the WebView, as this setting
993         cannot be dynamically changed, so any scrollbars that are created during
994         WebView initialization and are not replaced before snapshotting will end
995         up being platform scrollbars instead of mock ones.
996         WebKitTestRunner already sets this preference before creating WKViews,
997         so we're just matching its behavior.
998
999 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1000
1001         [GTK] ShadowRoot API was removed in r164131
1002         https://bugs.webkit.org/show_bug.cgi?id=132059
1003
1004         Reviewed by Gustavo Noronha Silva.
1005
1006         Add WebKitDOMShadowRoot to the list of deleted classes to generate
1007         the API docs.
1008
1009         * gtk/webkitdom.py:
1010         (WebKitDOMDocGenerator):
1011
1012 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
1013
1014         [GTK] run-webkit-tests script is failing to invoke run-launcher
1015         https://bugs.webkit.org/show_bug.cgi?id=132051
1016
1017         Reviewed by Philippe Normand.
1018
1019         After the WK1 support was dropped, if run-webkit-tests is executed
1020         without --no-show-results parameter, the launcher is being called
1021         using a -2 parameter that is it causing the run-launcher to break.
1022
1023         * Scripts/webkitpy/port/gtk.py:
1024         (GtkPort.show_results_html_file):
1025
1026 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1027
1028         DumpRenderTree generates black snapshots on some platforms
1029         https://bugs.webkit.org/show_bug.cgi?id=132029
1030         <rdar://problem/16679363>
1031
1032         Reviewed by Simon Fraser.
1033
1034         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1035         (createBitmapContextFromWebView):
1036         DRT checks with the WebView to determine whether it can use the window's
1037         backing store directly or (because of compositing) needs to take a WindowServer
1038         snapshot. However, on some platforms and in some situations, the window can
1039         be layer backed without the WebView necessarily currently being composited.
1040         We should check with the window in addition to the WebView before going
1041         ahead and using its backing store.
1042
1043 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1044
1045         DumpRenderTree generates white snapshots on some platforms
1046         https://bugs.webkit.org/show_bug.cgi?id=132026
1047         <rdar://problem/16679363>
1048
1049         Reviewed by Simon Fraser.
1050
1051         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1052         Link DRT against QuartzCore.
1053
1054         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1055         (createBitmapContextFromWebView):
1056         Force CoreAnimation to synchronously update layers in a more explicit
1057         way that doesn't depend on AppKit behavior. This is very similar to what
1058         WebKitTestRunner does (indirectly) during its force repaint.
1059
1060 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
1061
1062         [Win] Support Python 2.7 in Cygwin
1063         https://bugs.webkit.org/show_bug.cgi?id=132023
1064
1065         Reviewed by Michael Saboff.
1066
1067         * Scripts/webkitdirs.pm:
1068         (checkInstalledTools): Remove check for Python 2.7, since
1069         it now works properly.
1070
1071 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
1072
1073         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
1074         https://bugs.webkit.org/show_bug.cgi?id=130867
1075         <rdar://problem/16432456> 
1076
1077         Reviewed by Mark Hahnenberg.
1078
1079         * Scripts/build-webkit:
1080         * Scripts/copy-webkitlibraries-to-product-directory:
1081
1082 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
1083
1084         [GTK] Fails to build documentation when output is redirected
1085         https://bugs.webkit.org/show_bug.cgi?id=131178
1086
1087         Reviewed by Martin Robinson.
1088
1089         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
1090         explicitly to avoid encoding issues when they are redirected.
1091
1092 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
1093
1094         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
1095         https://bugs.webkit.org/show_bug.cgi?id=131911
1096
1097         Reviewed by Martin Robinson.
1098
1099         common.get_build_path returns release path even though Debug configuration
1100         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
1101
1102         * gtk/ycm_extra_conf.py:
1103         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
1104         (FlagsForFile):
1105
1106 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
1107
1108         Unreviewed build fix.
1109
1110         * DumpRenderTree/mac/EventSendingController.mm:
1111         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1112         Correct a typo that prevented tests from working properly.
1113
1114 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
1115
1116         [GTK] Should have the ability to output composited contents during layout testing
1117         https://bugs.webkit.org/show_bug.cgi?id=131864
1118
1119         Reviewed by Philippe Normand.
1120
1121         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1122         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
1123         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
1124         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1125         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
1126
1127 2014-04-21  Sam Weinig  <sam@webkit.org>
1128
1129         Attempt to fix the tests.
1130
1131         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1132         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1133         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
1134
1135 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
1136
1137         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
1138         being the same as a "quick run", which is meant for genuinely slow tests).
1139
1140         * Scripts/run-jsc-stress-tests:
1141
1142 2014-04-21  Darin Adler  <darin@apple.com>
1143
1144         Add HashSet::takeAny
1145         https://bugs.webkit.org/show_bug.cgi?id=131928
1146
1147         Reviewed by Benjamin Poulain.
1148
1149         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
1150
1151 2014-04-20  Dan Bernstein  <mitz@apple.com>
1152
1153         Fixed a test timing out after r167572.
1154
1155         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1156         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
1157         -webView:didFinishLoadingNavigation:.
1158
1159 2014-04-20  Commit Queue  <commit-queue@webkit.org>
1160
1161         Unreviewed, rolling out r167510.
1162         https://bugs.webkit.org/show_bug.cgi?id=131915
1163
1164         broke GTK Debug bot (Requested by philn on #webkit).
1165
1166         Reverted changeset:
1167
1168         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
1169         it when running layout tests"
1170         https://bugs.webkit.org/show_bug.cgi?id=131472
1171         http://trac.webkit.org/changeset/167510
1172
1173 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
1174
1175         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
1176         https://bugs.webkit.org/show_bug.cgi?id=131472
1177
1178         Reviewed by Philippe Normand.
1179
1180         * Scripts/webkitpy/port/gtk.py:
1181         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
1182         when running WebKitTestRunner with run-webkit-tests.
1183         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
1184         installed.
1185         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
1186         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
1187         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
1188         deal.
1189
1190 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
1191
1192         DownloadDecideDestinationCrash API test uses an incorrect value for path
1193         https://bugs.webkit.org/show_bug.cgi?id=131845
1194         <rdar://problem/15925560>
1195
1196         Reviewed by Enrica Casucci.
1197
1198         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1199         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
1200
1201 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
1202
1203         [Mac] AttributedStringTest API tests fail with async text input
1204         https://bugs.webkit.org/show_bug.cgi?id=131833
1205
1206         Reviewed by Enrica Casucci.
1207
1208         Don't run sync NSTextInputClient tests where we don't implement these calls.
1209
1210         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1211         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1212         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
1213         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1214         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
1215         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
1216         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
1217
1218 2014-04-18  Philippe Normand  <pnormand@igalia.com>
1219
1220         Remove NETWORK_INFO support
1221         https://bugs.webkit.org/show_bug.cgi?id=131841
1222
1223         Reviewed by Gyuyoung Kim.
1224
1225         * Scripts/webkitperl/FeatureList.pm:
1226
1227 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
1228
1229         [GTK] YouCompleteMe doesn't work for cmake build system.
1230         https://bugs.webkit.org/show_bug.cgi?id=131591
1231
1232         Reviewed by Martin Robinson.
1233
1234         Add cmake build system support for YouCompleteMe. It should work regardless of
1235         using make or ninja. In addition, autotools related code is removed since it's
1236         not used anymore in WebKit.
1237
1238         * Scripts/webkitdirs.pm:
1239         (generateBuildSystemFromCMakeProject):
1240         * gtk/ycm_extra_conf.py:
1241         (transform_relative_paths_to_absolute_paths):
1242         (FlagsForFile):
1243
1244 2014-04-17  Anders Carlsson  <andersca@apple.com>
1245
1246         Fix build.
1247
1248         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1249         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1250         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1251
1252 2014-04-17  Anders Carlsson  <andersca@apple.com>
1253
1254         Remove unused API enums
1255         https://bugs.webkit.org/show_bug.cgi?id=131836
1256
1257         Reviewed by Tim Horton.
1258
1259         * MiniBrowser/mac/WK2BrowserWindowController.m:
1260         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
1261
1262 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
1263
1264         [Win] A few final cleanups to the DataObject classes.
1265         https://bugs.webkit.org/show_bug.cgi?id=131784
1266
1267         Reviewed by Anders Carlsson.
1268
1269         * DumpRenderTree/win/DRTDataObject.cpp:
1270         (DRTDataObject::clearData): Use 'last()' method.
1271         * DumpRenderTree/win/UIDelegate.cpp:
1272         (DRTUndoStack::pop): Use 'takeLast()' method.
1273
1274 2014-04-17  Andres Gomez  <agomez@igalia.com>
1275
1276         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
1277         https://bugs.webkit.org/show_bug.cgi?id=131365
1278
1279         Reviewed by Brent Fulgham.
1280
1281         The cygwin installer is now downloading the wanted versions for
1282         the local installation given to the setup wizard.
1283
1284         * CygwinDownloader/cygwin-downloader.py:
1285         * CygwinDownloader/cygwin-downloader.zip:
1286
1287 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
1288
1289         [GTK] Make run-webkit-tests always use WKTR
1290         https://bugs.webkit.org/show_bug.cgi?id=131737
1291
1292         Reviewed by Darin Adler.
1293
1294         Now that the GTK+ port only has support for WebKit2, instruct
1295         run-webkit-tests to always use WKTR. This avoids needing to pass
1296         flag "-2" every time.
1297
1298         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
1299         (_set_up_derived_options): Always set webkit_test_runner when
1300         the platform is GTK+.
1301
1302 2014-04-17  Brendan Long  <b.long@cablelabs.com>
1303
1304         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
1305         https://bugs.webkit.org/show_bug.cgi?id=131760
1306
1307         Reviewed by Philippe Normand.
1308
1309         * gtk/install-dependencies: Install ninja-build when it's available.
1310
1311 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
1312
1313         [Win] run-javascriptcore-tests fails to run.
1314         https://bugs.webkit.org/show_bug.cgi?id=131761
1315
1316         Reviewed by Brent Fulgham.
1317
1318         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
1319
1320 2014-04-16  Andres Gomez  <agomez@igalia.com>
1321
1322         [Win] Pass default parameters to cygwin setup wizard
1323         https://bugs.webkit.org/show_bug.cgi?id=131361
1324
1325         Reviewed by Brent Fulgham.
1326
1327         Added some parameters to the cygwin setup wizard so the user
1328         doesn't really have to do any interaction.
1329
1330         * CygwinDownloader/cygwin-downloader.py:
1331         * CygwinDownloader/cygwin-downloader.zip:
1332
1333 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
1334
1335         [Win] Eliminate use of deleteAllValues in Windows Files
1336         https://bugs.webkit.org/show_bug.cgi?id=131631
1337
1338         Reviewed by Darin Adler.
1339
1340         Switch to std::unique_ptr for memory lifetime. Get rid of
1341         deleteAllValues now that it is no longer needed. Use ranged
1342         for loops where possible.
1343
1344         * DumpRenderTree/win/DRTDataObject.cpp:
1345         (WCEnumFormatEtc::WCEnumFormatEtc):
1346         (DRTDataObject::~DRTDataObject):
1347         (DRTDataObject::GetData):
1348         (DRTDataObject::QueryGetData):
1349         (DRTDataObject::SetData):
1350         (DRTDataObject::clearData):
1351         * DumpRenderTree/win/DRTDataObject.h:
1352         * DumpRenderTree/win/UIDelegate.cpp:
1353         (DRTUndoObject::DRTUndoObject):
1354         (DRTUndoObject::~DRTUndoObject):
1355         (DRTUndoStack::~DRTUndoStack):
1356         (DRTUndoStack::clear):
1357         (DRTUndoStack::pop):
1358         (DRTUndoManager::DRTUndoManager):
1359         (DRTUndoManager::redo):
1360         (DRTUndoManager::undo):
1361         (UIDelegate::UIDelegate):
1362         (UIDelegate::resetUndoManager):
1363         * DumpRenderTree/win/UIDelegate.h:
1364
1365 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1366
1367         [GTK] Unreviewed GTK gardening.
1368
1369         Update list of skipped unit tests:
1370
1371           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
1372
1373           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
1374           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
1375
1376         * Scripts/run-gtk-tests:
1377         (TestRunner):
1378
1379 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1380
1381         check-webkit-style doesn't check code style in .mm or .m files
1382         https://bugs.webkit.org/show_bug.cgi?id=131708
1383
1384         Reviewed by Darin Adler.
1385
1386         * Scripts/webkitpy/style/checker.py:
1387         * Scripts/webkitpy/style/checker_unittest.py:
1388         (CheckerDispatcherDispatchTest.test_cpp_paths):
1389         (CheckerDispatcherDispatchTest.test_text_paths):
1390         Check .mm and .m files as C++.
1391
1392         * Scripts/webkitpy/style/checkers/cpp.py:
1393         (check_spacing):
1394         Add an override for our ordinary "missing spaces around =" for @synthesize,
1395         which should look like "@synthesize propertyName=_varName;"
1396
1397         Add an override for "missing space before {" for blocks' "^{".
1398
1399         Don't follow the "extra space before [" rule for Objective-C, because
1400         it breaks this rule in a multitude of ways because of method calls.
1401
1402         (check_braces):
1403         Don't complain about { not being on the end of the previous line if
1404         the previous line starts with "- (" or "+ (", which would indicate a
1405         Objective-C method definition.
1406
1407 2014-04-16  Darin Adler  <darin@apple.com>
1408
1409         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
1410         https://bugs.webkit.org/show_bug.cgi?id=131735
1411
1412         Reviewed by Alexey Proskuryakov.
1413
1414         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
1415         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
1416         is on the right. This can be confusing since our JavaScript test framework does it the opposite
1417         way, but gtest works better this way.
1418
1419 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
1420
1421         [EFL] Fix problems with the pixel dump.
1422         https://bugs.webkit.org/show_bug.cgi?id=131265
1423
1424         Reviewed by Gyuyoung Kim.
1425
1426         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
1427         However pixel dump codes still call deprecated functions like ewk_view_paint(),
1428         which causes that nothing is drawn.
1429
1430         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
1431         One of new functions is AcceleratedCompositingContext::extractImageData(),
1432         which replaces deprecated function calls. Besides the extractImageData() is invoked by
1433         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
1434
1435         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1436         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
1437
1438 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
1439
1440         Update LLVM export scrpt to handle the build directory being different from the
1441         source directory.
1442
1443         Rubber stamped by Geoffrey Garen.
1444
1445         * Scripts/export-llvm-build:
1446
1447 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
1448
1449         Update the hyperlink to waterfall views of perf bots on build.webkit.org
1450         https://bugs.webkit.org/show_bug.cgi?id=131695
1451
1452         Reviewed by Antti Koivisto.
1453
1454         Updated.
1455
1456         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1457
1458 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1459
1460         [GTK] Reduce the binary size by compressing the text based web inspector resources
1461         https://bugs.webkit.org/show_bug.cgi?id=121545
1462
1463         Reviewed by Gustavo Noronha Silva.
1464
1465         Compress text based files when compiling inspector resources. It
1466         reduces the binary size in 3MB.
1467
1468         * gtk/generate-inspector-gresource-manifest.py:
1469         (find_all_files_in_directory):
1470         (is_compressible):
1471
1472 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1473
1474         Remove Gtk WebKit1 tester.
1475
1476         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1477         results over and over as fast as it could.
1478
1479         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1480         (WebKitBuildbot):
1481
1482 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1483
1484         Wrong link for webkitpy tests results in dashboard popover
1485         https://bugs.webkit.org/show_bug.cgi?id=131664
1486
1487         Reviewed by Timothy Hatcher.
1488
1489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1490         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1491         Use a correct link.
1492
1493 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1494
1495         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1496
1497         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1498
1499         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1500         (CommitMessageForThisCommitTest):
1501
1502 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1503
1504         Fix commit-log-editor bug revealed by r165447
1505         https://bugs.webkit.org/show_bug.cgi?id=130676
1506
1507         Reviewed by Csaba Osztrogonác.
1508
1509         * Scripts/commit-log-editor:
1510         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1511         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1512         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1513         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1514
1515 2014-04-13  Darin Adler  <darin@apple.com>
1516
1517         userVisibleString should not try to "encode" host names
1518         https://bugs.webkit.org/show_bug.cgi?id=131587
1519         rdar://problem/14686849
1520
1521         Reviewed by Alexey Proskuryakov.
1522
1523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1524
1525         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1526         Coverage is tiny at this point; we could add a lot more cases!
1527
1528 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1529
1530         Use #include instead of #import
1531         https://bugs.webkit.org/show_bug.cgi?id=131604
1532
1533         Reviewed by Darin Adler.
1534
1535         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1536
1537         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1538
1539 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1540
1541         Make slow-stress tests run faster by running fewer VM variants.
1542
1543         Rubber stamped by Geoffrey Garen.
1544
1545         * Scripts/run-javascriptcore-tests:
1546         * Scripts/run-jsc-stress-tests:
1547
1548 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1549
1550         [CMake] Add missing WTF unit tests
1551         https://bugs.webkit.org/show_bug.cgi?id=131459
1552
1553         Reviewed by Martin Robinson.
1554
1555         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1556         that should be compiled into the TestWTF binary.
1557
1558 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1559
1560         [Gtk] run-launcher doesn't work by default
1561         https://bugs.webkit.org/show_bug.cgi?id=131494
1562
1563         Reviewed by Philippe Normand.
1564
1565         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1566         * Scripts/webkitdirs.pm:
1567         (launcherName): Same.
1568         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1569         * gtk/common.py:
1570         (get_build_path.is_valid_build_directory): Same.
1571         * gtk/manifest.txt: Same.
1572
1573 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1574
1575         Unreviewed, rolling out r167046.
1576         https://bugs.webkit.org/show_bug.cgi?id=131479
1577
1578         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1579         on #webkit).
1580
1581         Reverted changeset:
1582
1583         "Remove "System Font" from whitelisted DRT fonts and char
1584         width calculations"
1585         https://bugs.webkit.org/show_bug.cgi?id=131411
1586         http://trac.webkit.org/changeset/167046
1587
1588 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1589
1590         Remove "System Font" from whitelisted DRT fonts and char width calculations
1591         https://bugs.webkit.org/show_bug.cgi?id=131411
1592
1593         Reviewed by Tim Horton.
1594
1595         Covered by existing tests.
1596
1597         * DumpRenderTree/mac/DumpRenderTree.mm:
1598         (allowedFontFamilySet):
1599
1600 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1601
1602         systemHiddenFontFamilySet in DRT is unnecessary
1603         https://bugs.webkit.org/show_bug.cgi?id=131414
1604
1605         Reviewed by Tim Horton.
1606
1607         It doesn't seem to affect test results on my machine.
1608
1609         * DumpRenderTree/mac/DumpRenderTree.mm:
1610         (drt_NSFontManager_availableFonts):
1611         (systemHiddenFontFamilySet): Deleted.
1612
1613 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1614
1615         [Win] Unreviewed test fix: Don't double-release BSTR.
1616
1617         * DumpRenderTree/win/DumpRenderTree.cpp:
1618         (dump): Remove unneeded call to SysFreeString now that we are
1619         using _bstr_t for this variable.
1620
1621 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1622
1623         [Win] Various DumpRenderTree Fixes.
1624         https://bugs.webkit.org/show_bug.cgi?id=131446.
1625
1626         Reviewed by Tim Horton.
1627
1628         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1629         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1630         (AccessibilityUIElement::description): Ditto.
1631         (AccessibilityUIElement::helpText): Ditto.
1632         (AccessibilityUIElement::intValue): Ditto.
1633         (AccessibilityUIElement::isPressActionSupported): Ditto.
1634         (AccessibilityUIElement::accessibilityValue): Ditto.
1635         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1636         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1637         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1638         (DRTDesktopNotificationPresenter::Release): Ditto.
1639         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1640         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1641         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1642         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1643         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1644         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1645         * DumpRenderTree/win/DumpRenderTree.cpp:
1646         (dumpFrameScrollPosition): Ditto.
1647         (dumpFramesAsText): Ditto.
1648         (compareHistoryItems): Ditto.
1649         (dumpHistoryItem): Ditto.
1650         (dump): Ditto.
1651         (resetDefaultsToConsistentValues): Ditto.
1652         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1653         (runTest): Ditto.
1654         (createWebViewAndOffscreenWindow): Ditto.
1655         * DumpRenderTree/win/EditingDelegate.cpp:
1656         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1657         (EditingDelegate::AddRef): Ditto.
1658         (EditingDelegate::Release): Ditto.
1659         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1660         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1661         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1662         (EditingDelegate::shouldInsertNode): Ditto.
1663         (EditingDelegate::shouldInsertText): Ditto.
1664         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1665         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1666         (EditingDelegate::shouldApplyStyle): Ditto.
1667         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1668         (EditingDelegate::doPlatformCommand): Ditto.
1669         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1670         (EditingDelegate::webViewDidChange): Ditto.
1671         (EditingDelegate::webViewDidEndEditing): Ditto.
1672         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1673         (EditingDelegate::webViewDidChangeSelection): Ditto.
1674         (EditingDelegate::checkSpellingOfString): Ditto.
1675         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1676         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1677         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1678         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1679         (FrameLoadDelegate::AddRef): Ditto.
1680         (FrameLoadDelegate::Release): Ditto.
1681         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1682         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1683         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1684         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1685         (FrameLoadDelegate::didReceiveTitle): Ditto.
1686         (FrameLoadDelegate::didChangeIcons): Ditto.
1687         (delegatesWithDelayedWork): Ditto.
1688         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1689         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1690         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1691         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1692         (FrameLoadDelegate::willCloseFrame): Ditto.
1693         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1694         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1695         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1696         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1697         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1698         * DumpRenderTree/win/FrameLoadDelegate.h:
1699         * DumpRenderTree/win/HistoryDelegate.cpp:
1700         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1701         (HistoryDelegate::updateHistoryTitle): Ditto.
1702         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1703         * DumpRenderTree/win/PolicyDelegate.cpp:
1704         (dumpPath):
1705         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1706         (PolicyDelegate::AddRef): Ditto.
1707         (PolicyDelegate::Release): Ditto.
1708         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1709         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1710         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1711         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1712         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1713         (ResourceLoadDelegate::AddRef): Ditto.
1714         (ResourceLoadDelegate::Release): Ditto.
1715         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1716         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1717         (ResourceLoadDelegate::willSendRequest): Ditto.
1718         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1719         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1720         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1721         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1722         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1723         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1724         (TestRunner::setUserStyleSheetLocation): Ditto.
1725         (TestRunner::execCommand): Ditto.
1726         (TestRunner::overridePreference): Ditto.
1727         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1728         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1729         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1730         (TextInputController::insertText): Ditto.
1731         * DumpRenderTree/win/UIDelegate.cpp:
1732         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1733         (UIDelegate::AddRef): Ditto.
1734         (UIDelegate::Release): Ditto.
1735         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1736         (UIDelegate::trackCustomPopupMenu): Ditto.
1737         (UIDelegate::registerUndoWithTarget): Ditto.
1738         (UIDelegate::removeAllActionsWithTarget): Ditto.
1739         (UIDelegate::setActionTitle): Ditto.
1740         (UIDelegate::undo): Ditto.
1741         (UIDelegate::redo): Ditto.
1742         (UIDelegate::canUndo): Ditto.
1743         (UIDelegate::canRedo): Ditto.
1744         (UIDelegate::printFrame): Ditto.
1745         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1746         (UIDelegate::webViewHeaderHeight): Ditto.
1747         (UIDelegate::webViewFooterHeight): Ditto.
1748         (UIDelegate::drawHeaderInRect): Ditto.
1749         (UIDelegate::drawFooterInRect): Ditto.
1750         (UIDelegate::webViewPrintingMarginRect): Ditto.
1751         (UIDelegate::canRunModal): Ditto.
1752         (UIDelegate::createModalDialog): Ditto.
1753         (UIDelegate::runModal): Ditto.
1754         (UIDelegate::isMenuBarVisible): Ditto.
1755         (UIDelegate::setMenuBarVisible): Ditto.
1756         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1757         (UIDelegate::paintCustomScrollbar): Ditto.
1758         (UIDelegate::paintCustomScrollCorner): Ditto.
1759         (UIDelegate::setFrame): Ditto.
1760         (UIDelegate::webViewFrame): Ditto.
1761         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1762         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1763         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1764         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1765         (UIDelegate::webViewAddMessageToConsole): Ditto.
1766         (UIDelegate::doDragDrop): Ditto.
1767         (UIDelegate::webViewGetDlgCode): Ditto.
1768         (UIDelegate::createWebViewWithRequest): Ditto.
1769         (UIDelegate::webViewClose): Ditto.
1770         (UIDelegate::webViewFocus): Ditto.
1771         (UIDelegate::webViewUnfocus): Ditto.
1772         (UIDelegate::webViewPainted): Ditto.
1773         (UIDelegate::exceededDatabaseQuota): Ditto.
1774         (UIDelegate::embeddedViewWithArguments): Ditto.
1775         (UIDelegate::webViewClosing): Ditto.
1776         (UIDelegate::webViewSetCursor): Ditto.
1777         (UIDelegate::webViewDidInvalidate): Ditto.
1778         (UIDelegate::setStatusText): Ditto.
1779         (UIDelegate::desktopNotificationsDelegate): Ditto.
1780         (UIDelegate::drawBackground): Ditto.
1781         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1782         (UIDelegate::didPressMissingPluginButton): Ditto.
1783         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1784         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1785         (LoadHTMLStringItem::invoke): Ditto.
1786         (ScriptItem::invoke): Ditto.
1787
1788 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1789
1790         Stylechecker: False positive on inline asm code.
1791         https://bugs.webkit.org/show_bug.cgi?id=130570
1792
1793         Reviewed by Csaba Osztrogonác.
1794
1795         Disable stylechecking in asm blocks.
1796
1797         * Scripts/webkitpy/style/checkers/cpp.py:
1798         (process_line):
1799         (_InlineASMState):
1800         (_InlineASMState.__init__):
1801         (_InlineASMState.process_line):
1802         (_InlineASMState.isInside):
1803         (_process_lines):
1804         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1805         (WebKitStyleTest.test_member_initialization_list):
1806
1807 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1808
1809         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1810         https://bugs.webkit.org/show_bug.cgi?id=131029
1811
1812         Reviewed by Philippe Normand.
1813
1814         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1815         tests and remove the getWebKit1TestResoucesDir() method.
1816
1817         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1818         (testDownloadLocalFile): Use Test::getResourcesDir().
1819         (testDownloadLocalFileError): Ditto.
1820         (serverCallback): Ditto.
1821         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1822         (serverCallback): Ditto.
1823         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1824         (httpServerCallback): Ditto.
1825         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1826         (serverCallback): Ditto.
1827         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1828         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1829         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1830         (Test::getWebKit1TestResoucesDir): Deleted.
1831
1832 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1833
1834         [WK2] HTTP authentication regression tests fail
1835         https://bugs.webkit.org/show_bug.cgi?id=81627
1836         <rdar://problem/11079296>
1837
1838         Reviewed by Anders Carlsson.
1839
1840         * WebKitTestRunner/TestController.h:
1841         * WebKitTestRunner/TestController.cpp:
1842         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1843         to pageLoaderClient structure.
1844         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1845         for password based authentication (we do get server trust challenges on some tests,
1846         which WKTR can't handle).
1847         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1848         calls won't be made, at least on CFNetwork based platforms.
1849         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1850         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1851         make sense to associate auth requests with individual resources - there can be
1852         multiple resources loading at once from the same protection space, so WebKit1 API
1853         that had a resource identifier was inherently racy.
1854
1855 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1856
1857         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1858         https://bugs.webkit.org/show_bug.cgi?id=131427
1859
1860         Reviewed by Gyuyoung Kim.
1861
1862         Since r166973, font path was changed.
1863
1864         * DumpRenderTree/PlatformEfl.cmake:
1865         * WebKitTestRunner/PlatformEfl.cmake:
1866
1867 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1868
1869         Fix the build-jsc build
1870         https://bugs.webkit.org/show_bug.cgi?id=131410
1871
1872         Reviewed by Michael Saboff.
1873
1874         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1875         WTF depends on it.
1876
1877 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1878
1879         [GTK] Remove WebKit1 unit tests
1880         https://bugs.webkit.org/show_bug.cgi?id=131359
1881
1882         Reviewed by Anders Carlsson.
1883
1884         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1885         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1886         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1887
1888         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1889         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1890         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1891         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1892         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1893         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1894         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1895         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1896         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1897         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1898         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1899         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1900         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1901         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1902         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1903         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1904         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1905         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1906         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1907         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1908         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1909         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1910         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1911         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1912         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1913         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1914         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1915         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1916         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1917         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1918         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1919         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1920         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1921         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1922         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1923         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1924         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1925         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1926
1927 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1928
1929         Unreviewed gardening (Take 2): Prevent users from attempting
1930         to build with known invalid cURL. 
1931
1932         * Scripts/webkitdirs.pm:
1933         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1934         7.33.0 (the known good version).
1935
1936 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1937
1938         [GTK] Remove DumpRenderTree and GtkLauncher
1939         https://bugs.webkit.org/show_bug.cgi?id=131373
1940
1941         Reviewed by Andreas Kling.
1942
1943         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1944         no longer necessary now that WebKit1 GTK+ will be removed.
1945
1946         * CMakeLists.txt:
1947         * DumpRenderTree/PlatformGTK.cmake: Removed.
1948         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1949         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1950         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1951         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1952         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1953         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1954         * DumpRenderTree/gtk/EventSender.h: Removed.
1955         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1956         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1957         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1958         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1959         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1960         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1961         * DumpRenderTree/gtk/TextInputController.h: Removed.
1962         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1963         * GtkLauncher/CMakeLists.txt: Removed.
1964         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1965         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1966         * GtkLauncher/main.c: Removed.
1967         * GtkLauncher/simple.svg: Removed.
1968         * GtkLauncher/text.html: Removed.
1969         * WebKitTestRunner/PlatformGTK.cmake:
1970         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1971         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1972         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1973
1974 2014-04-08  Mark Rowe  <mrowe@apple.com>
1975
1976         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1977         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1978
1979         Reviewed by Alexey Proskuryakov.
1980
1981         * Scripts/webkitdirs.pm:
1982         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1983         (execMacWebKitAppForDebugging): Ditto.
1984
1985 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1986
1987         Build bmalloc on iOS too
1988         https://bugs.webkit.org/show_bug.cgi?id=131381
1989
1990         Reviewed by Andreas Kling.
1991
1992         * Scripts/build-webkit:
1993
1994 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1995
1996         Unreviewed gardening: Prevent users from attempting
1997         to build with known invalid cURL.
1998
1999         * Scripts/webkitdirs.pm:
2000         (checkInstalledTools): Block build attempts with bad
2001         Cygwin tool set.
2002
2003 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
2004
2005         Build bmalloc on Mac
2006         https://bugs.webkit.org/show_bug.cgi?id=131333
2007
2008         Reviewed by Mark Rowe.
2009
2010         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
2011         (Note: Just testing Mac is not good enough because in this
2012         script 'Mac' means 'Mac or iOS'.)
2013
2014 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
2015
2016         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
2017         https://bugs.webkit.org/show_bug.cgi?id=130951
2018
2019         Reviewed by Geoffrey Garen.
2020
2021         * Scripts/run-javascriptcore-tests:
2022
2023 2014-04-06  Darin Adler  <darin@apple.com>
2024
2025         Rework CSS calc logic, fixing some reference count mistakes in Length
2026         https://bugs.webkit.org/show_bug.cgi?id=131280
2027
2028         Reviewed by Andreas Kling.
2029
2030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
2031         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
2032
2033 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
2034
2035         Enable WEB_REPLAY for PLATFORM(MAC)
2036         https://bugs.webkit.org/show_bug.cgi?id=130700
2037
2038         Reviewed by Timothy Hatcher.
2039
2040         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
2041
2042 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2043
2044         [CMake] Include X11's include dirs in TestNetscapePlugin
2045         https://bugs.webkit.org/show_bug.cgi?id=131270
2046
2047         Reviewed by Martin Robinson.
2048
2049         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
2050         TestNetscapePlugin includes WebCore code that includes X headers.
2051
2052 2014-04-05  David Kilzer  <ddkilzer@apple.com>
2053
2054         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
2055         <http://webkit.org/b/130986>
2056
2057         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
2058         prefix to TileCache class names in exception list.
2059
2060 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2061
2062         [GTK] kill-old-processes should kill dbus-daemon processes
2063         https://bugs.webkit.org/show_bug.cgi?id=127352
2064
2065         Reviewed by Martin Robinson.
2066
2067         * BuildSlaveSupport/kill-old-processes:
2068         (main):
2069
2070 2014-04-04  Andres Gomez  <agomez@igalia.com>
2071
2072         [Win] Update obsolete packages in cygwin
2073         https://bugs.webkit.org/show_bug.cgi?id=126264
2074
2075         Reviewed by Brent Fulgham.
2076
2077         Removed "apache" and "minires" as the first has been replaced by
2078         "lighttpd" and the second is now integrated into
2079         "cygwin". Replaced the transitional and now obsolete "gcc" package
2080         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
2081         since the newer version available is "2.7.3" which breaks the
2082         build due to some funniness with environment variable handling.
2083
2084         * CygwinDownloader/cygwin-downloader.py:
2085         * CygwinDownloader/cygwin-downloader.zip:
2086
2087 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
2088
2089         check-webkit-style: Improve warnings on Objective-C @property syntax
2090         https://bugs.webkit.org/show_bug.cgi?id=131200
2091
2092         Reviewed by Dan Bernstein.
2093
2094         * Scripts/webkitpy/style/checkers/cpp.py:
2095         (check_spacing):
2096         (CppChecker):
2097         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2098         (CppStyleTest.test_spacing_in_objective_c_properties):
2099
2100 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2101
2102         Unreviewed. Moving my name to commiter section
2103
2104         * Scripts/webkitpy/common/config/contributors.json:
2105
2106 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2107
2108         Unreviewed. Add myself as a committer.
2109
2110         * Scripts/webkitpy/common/config/contributors.json:
2111
2112 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
2113
2114         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
2115         https://bugs.webkit.org/show_bug.cgi?id=130391
2116
2117         Reviewed by Gyuyoung Kim.
2118
2119         Change the implementation of the zoom functionality from ewk_view_scale_set
2120         to ewk_view_page_zoom_set.
2121
2122         * MiniBrowser/efl/main.c:
2123
2124 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2125
2126         [webkitpy] perf profiler does not understand --call-graph argument
2127         https://bugs.webkit.org/show_bug.cgi?id=131132
2128
2129         Reviewed by Ryosuke Niwa.
2130
2131         New versions of perf profiler have changed the argument from --call-graph to -g.
2132
2133         * Scripts/webkitpy/common/system/profiler.py:
2134         (Perf.wrapper_arguments): Use -g instead of --call-graph.
2135         * Scripts/webkitpy/port/driver_unittest.py:
2136         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
2137
2138 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2139
2140         Add EFL WK2 performance bot to build.webkit.org
2141         https://bugs.webkit.org/show_bug.cgi?id=131034
2142
2143         Fix after r166707, use "Perf" instead of "perf" for consistency.
2144
2145         Reviewed by Csaba Osztrogonác.
2146
2147         * BuildSlaveSupport/build.webkit.org-config/config.json:
2148
2149 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2150
2151         Add EFL WK2 performance bot to build.webkit.org
2152         https://bugs.webkit.org/show_bug.cgi?id=131034
2153
2154         Reviewed by Csaba Osztrogonác.
2155
2156         * BuildSlaveSupport/build.webkit.org-config/config.json:
2157
2158 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
2159
2160         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
2161         https://bugs.webkit.org/show_bug.cgi?id=131151
2162
2163         Reviewed by Gyuyoung Kim.
2164
2165         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
2166         (TouchEventInfo::TouchEventInfo):
2167         (sendTouchEvent):
2168         (addTouchPointCallback):
2169         (updateTouchPointCallback):
2170         (cancelTouchPointCallback):
2171         (releaseTouchPointCallback):
2172
2173 2014-04-02  David Kilzer  <ddkilzer@apple.com>
2174
2175         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
2176         <http://webkit.org/b/131045>
2177
2178         Reviewed by Daniel Bates.
2179
2180         * Scripts/filter-build-webkit:
2181         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
2182         of clang, plus debug data for all DVTAssertions.
2183
2184 2014-04-01  Dean Jackson  <dino@apple.com>
2185
2186         Load Media Controls js/css from bundle
2187         https://bugs.webkit.org/show_bug.cgi?id=131086
2188
2189         Reviewed by Eric Carlson.
2190
2191         We're now putting CSS files into the bundle, so remove the test for them.
2192
2193         * Scripts/check-for-inappropriate-files-in-framework:
2194
2195 2014-04-02  Martin Hock  <mhock@apple.com>
2196
2197         Unify private browsing with sessions.
2198         https://bugs.webkit.org/show_bug.cgi?id=130099
2199
2200         Reviewed by Alexey Proskuryakov.
2201
2202         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
2203         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2204         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2205         (TestWebKitAPI::didNavigateWithNavigationData):
2206         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2207         (TestWebKitAPI::TEST):
2208
2209         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
2210         (TestWebKitAPI::didNavigateWithoutNavigationData):
2211         (TestWebKitAPI::didNavigateWithNavigationData):
2212         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2213         (TestWebKitAPI::TEST):
2214
2215 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
2216
2217         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
2218         https://bugs.webkit.org/show_bug.cgi?id=130343
2219
2220         Reviewed by Gustavo Noronha Silva.
2221
2222         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
2223         of directories on the command line and look for all appropriate files in those directories for the
2224         GResource archive. Also make archive paths relative to those directories.
2225         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
2226         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
2227
2228 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2229
2230         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
2231         https://bugs.webkit.org/show_bug.cgi?id=131106
2232
2233         Reviewed by Csaba Osztrogonác.
2234
2235         * Scripts/webkitpy/tool/commands/download.py:
2236         (AbstractRolloutPrepCommand._prepare_state):
2237         * Scripts/webkitpy/tool/commands/download_unittest.py:
2238         (test_prepare_rollout):
2239         (test_create_rollout):
2240         (test_create_rollout_resolved):
2241         (test_rollout):
2242
2243 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
2244
2245         [EFL] Add option to use separate web process for new window in MiniBrowser
2246         https://bugs.webkit.org/show_bug.cgi?id=130190
2247
2248         Reviewed by Gyuyoung Kim.
2249
2250         New created window (CTRL + n) will be open in separated web process.
2251         This option is enabled by adding a flag (S/separate-process) with launching
2252         MiniBrowser.
2253
2254         * MiniBrowser/efl/main.c:
2255         (elm_main):
2256
2257 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2258
2259         [GTK] Move NEWS file to a new location
2260         https://bugs.webkit.org/show_bug.cgi?id=130901
2261
2262         Reviewed by Brent Fulgham.
2263
2264         * gtk/manifest.txt: Update the NEWS file path.
2265
2266 2014-04-01  Anders Carlsson  <andersca@apple.com>
2267
2268         Fix build.
2269
2270         * MiniBrowser/mac/WK2BrowserWindowController.m:
2271         (-[WK2BrowserWindowController awakeFromNib]):
2272         (-[WK2BrowserWindowController dealloc]):
2273         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2274
2275 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
2276
2277         Unreviewed test gardening.
2278
2279         * Scripts/webkitpy/port/base_unittest.py:
2280         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
2281
2282 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
2283
2284         [CSS Exclusions] Remove exclusions parsing support
2285         https://bugs.webkit.org/show_bug.cgi?id=131046
2286
2287         Reviewed by David Hyatt.
2288
2289         * Scripts/webkitperl/FeatureList.pm:
2290
2291 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2292
2293         [GTK] Remove last reference to GTK+ WK1 EWS
2294         https://bugs.webkit.org/show_bug.cgi?id=131058
2295
2296         Reviewed by Martin Robinson.
2297
2298         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
2299
2300         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
2301
2302 2014-04-01  Lucas Forschler  <lforschler@apple.com>
2303
2304         Add a 32bit JSC builder/tester.
2305         https://bugs.webkit.org/show_bug.cgi?id=131054
2306         
2307         Reviewed by Michael Saboff.
2308
2309         * BuildSlaveSupport/build.webkit.org-config/config.json:
2310         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2311         (Compile32bitJSC):
2312         (Run32bitJSCTests):
2313         (Run32bitJSCTests.countFailures):
2314         (BuildAndTest32bitJSCFactory):
2315         (BuildAndTest32bitJSCFactory.__init__):
2316
2317 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
2318
2319         [GTK] No longer build WebKit1 gtkdoc
2320         https://bugs.webkit.org/show_bug.cgi?id=130970
2321
2322         Reviewed by Anders Carlsson.
2323
2324         * gtk/common.py:
2325         (gtk_version_of_pkg_config_file): Deleted.
2326         * gtk/generate-gtkdoc:
2327         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
2328         was only applicable for WebKit1.
2329         (get_generator_for_config): No longer look for the WebKit1 configuration file.
2330
2331 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
2332
2333         [GTK] Running minibrowser with url crashes in debug build
2334         https://bugs.webkit.org/show_bug.cgi?id=130492
2335
2336         Reviewed by Martin Robinson.
2337
2338         Update "uri-scheme" test not to use invalid URIs in it, so we
2339         don't get a mistmatch when comparing the original URI stored in
2340         the test class with the one returned by the WebKitWebView.
2341
2342         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2343         (testWebContextURIScheme): Update the test.
2344
2345 2014-04-01  Mihai Tica  <mitica@adobe.com>
2346
2347         Unreviewed: Add myself as a commiter to the contributors list.
2348
2349         * Scripts/webkitpy/common/config/contributors.json:
2350
2351 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2352
2353         [EFL][WK2] Extract the control of page background out of color_set
2354         https://bugs.webkit.org/show_bug.cgi?id=127539
2355
2356         Reviewed by Gyuyoung Kim.
2357
2358         Added an option(C) to change background color.
2359
2360         * MiniBrowser/efl/main.c:
2361         (window_create):
2362         (elm_main):
2363
2364 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2365
2366         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
2367
2368         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
2369
2370 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2371
2372         Unreviewed test correction after r166530.
2373
2374         * DumpRenderTree/mac/DumpRenderTree.mm:
2375         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
2376         fine-grained setting for swipe tests. This prevents existing tests from breaking.
2377
2378 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2379
2380         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
2381         https://bugs.webkit.org/show_bug.cgi?id=130987
2382
2383         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
2384         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
2385
2386         Reviewed by Martin Robinson.
2387
2388         * BuildSlaveSupport/build.webkit.org-config/config.json:
2389
2390 2014-03-31  Dean Jackson  <dino@apple.com>
2391
2392         Remove WEB_ANIMATIONS
2393         https://bugs.webkit.org/show_bug.cgi?id=130989
2394
2395         Reviewed by Simon Fraser.
2396
2397         Remove this feature flag until we plan to implement.
2398
2399         * Scripts/webkitperl/FeatureList.pm:
2400
2401 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2402
2403         Reduced Latched Scroll Test Flakiness
2404         https://bugs.webkit.org/show_bug.cgi?id=130983
2405
2406         Reviewed by Darin Adler.
2407
2408         * DumpRenderTree/mac/DumpRenderTree.mm:
2409         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
2410         * DumpRenderTree/mac/EventSendingController.mm:
2411         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
2412         with high resolution flags turned on.
2413         * WebKitTestRunner/mac/EventSenderProxy.mm:
2414         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2415
2416 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2417
2418         run-webkit-tests should have a --no-timeout option
2419         https://bugs.webkit.org/show_bug.cgi?id=128286
2420
2421         Reviewed by Joseph Pecoraro.
2422
2423         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2424         (Worker._run_test): Renaming _run_test_with_timeout()
2425         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
2426         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
2427         (Worker._run_test_in_this_thread):
2428         (Worker._run_test_with_timeout): Deleted.
2429         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2430         (parse_args): Added the --no-timeout option
2431
2432 2014-03-31  Samuel White  <samuel_white@apple.com>
2433
2434         AX: Need ability to get line range for text marker.
2435         https://bugs.webkit.org/show_bug.cgi?id=130906
2436
2437         Reviewed by Chris Fleizach.
2438
2439         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2440
2441         * DumpRenderTree/AccessibilityUIElement.cpp:
2442         (lineTextMarkerRangeForTextMarkerCallback):
2443         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2444         (AccessibilityUIElement::getJSClass):
2445         * DumpRenderTree/AccessibilityUIElement.h:
2446         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2447         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2448         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2449         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2450         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2451         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2452         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2453         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2454         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2455         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2456         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2457         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2458
2459 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2460
2461         More validation for FTL inline caches
2462         https://bugs.webkit.org/show_bug.cgi?id=130948
2463
2464         Reviewed by Geoffrey Garen.
2465
2466         * Scripts/run-jsc-stress-tests:
2467
2468 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2469
2470         [GTK] Do not run WebKit1 unit tests by default
2471         https://bugs.webkit.org/show_bug.cgi?id=130968
2472
2473         Reviewed by Martin Robinson.
2474
2475         * Scripts/run-gtk-tests:
2476         (TestRunner):
2477
2478 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2479
2480         [GTK] Remove scripts code only applicable to autotools
2481         https://bugs.webkit.org/show_bug.cgi?id=130841
2482
2483         Reviewed by Anders Carlsson.
2484
2485         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2486         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2487         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2488         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2489         * gtk/find-make-dist-errors: Removed.
2490         * gtk/generate-feature-defines-files: Removed.
2491         * gtk/manifest.txt: No longer need to consider autotools files.
2492
2493 2014-03-30  Andy Estes  <aestes@apple.com>
2494
2495         Fix two failing layout tests on Mountain Lion after r166466.
2496
2497         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2498         (-[DownloadDelegate _downloadDidStart:]):
2499
2500 2014-03-30  Andy Estes  <aestes@apple.com>
2501
2502         [Cocoa] Add an originatingWebView property to _WKDownload
2503         https://bugs.webkit.org/show_bug.cgi?id=130945
2504
2505         Reviewed by Anders Carlsson.
2506
2507         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2508         (-[DownloadDelegate _downloadDidStart:]):
2509         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2510         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2511         (TEST):
2512
2513 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2514
2515         Land the stackmap register liveness glue with the uses of the liveness disabled
2516         https://bugs.webkit.org/show_bug.cgi?id=130924
2517
2518         Reviewed by Oliver Hunt.
2519
2520         * Scripts/run-jsc-stress-tests:
2521
2522 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2523
2524         Update WebKit1.StringTruncator for Mountain Lion.
2525
2526         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2527         due to different font metrics on 10.8.
2528
2529 2014-03-28  Darin Adler  <darin@apple.com>
2530
2531         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2532         https://bugs.webkit.org/show_bug.cgi?id=130889
2533
2534         Reviewed by Alexey Proskuryakov.
2535
2536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2537         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2538         WebStringTruncator methods; should be good for a start. These are dependent on the
2539         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2540
2541 2014-03-28  Martin Hock  <mhock@apple.com>
2542
2543         Unreviewed. Add myself as a committer.
2544
2545         * Scripts/webkitpy/common/config/contributors.json:
2546
2547 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2548
2549         Remove WebKit1 GTK+ bots
2550         https://bugs.webkit.org/show_bug.cgi?id=130904
2551
2552         Reviewed by Anders Carlsson.
2553
2554         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2555         all bots are testing WebKit2 only.
2556         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2557         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2558         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2559         * Scripts/webkitpy/port/builders.py: Ditto.
2560         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2561         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2562
2563 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2564
2565         Remove Brian Burg's apple.com email address.
2566
2567         * Scripts/webkitpy/common/config/contributors.json:
2568
2569 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2570
2571         bisect-builds should print Trac 'changeset' URL if only one build is detected
2572         <http://webkit.org/b/130903>
2573
2574         Reviewed by Dan Bernstein.
2575
2576         * Scripts/bisect-builds:
2577         (printTracLink): Print a direct link to the Trac 'changeset'
2578         URL if there is only one revision in the range.
2579
2580 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2581
2582         [EFL] Bump glib version from 2.36 to 2.38 
2583         https://bugs.webkit.org/show_bug.cgi?id=130886
2584
2585         Reviewed by Csaba Osztrogonác.
2586
2587         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2588         we need to bump glib version up to 2.38 as gtk port.
2589
2590         * efl/jhbuild.modules:
2591
2592 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2593
2594         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2595
2596         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2597         the globalhistory directory.
2598
2599         Reviewed by Sam Weinig.
2600
2601         * WebKitTestRunner/TestController.cpp:
2602         (WTR::TestController::TestController):
2603         (WTR::TestController::initialize): Set the history client.
2604         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2605         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2606         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2607         and we don't yet have API to access the data in question.
2608         (WTR::TestController::didPerformClientRedirect):
2609         (WTR::TestController::didPerformServerRedirect):
2610         (WTR::TestController::didUpdateHistoryTitle):
2611         * WebKitTestRunner/TestController.h:
2612         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2613         * WebKitTestRunner/TestInvocation.cpp:
2614         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2615         (WTR::TestInvocation::invoke):
2616
2617 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2618
2619         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2620
2621         * Scripts/build-webkit:
2622         * Scripts/copy-webkitlibraries-to-product-directory:
2623
2624 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2625
2626         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2627         https://bugs.webkit.org/show_bug.cgi?id=130867
2628         <rdar://problem/16432456> 
2629
2630         Reviewed by Mark Hahnenberg.
2631
2632         * Scripts/build-webkit:
2633         * Scripts/copy-webkitlibraries-to-product-directory:
2634
2635 2014-03-26  Andy Estes  <aestes@apple.com>
2636
2637         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2638         https://bugs.webkit.org/show_bug.cgi?id=130805
2639
2640         Reviewed by Dan Bernstein.
2641
2642         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2643         (-[DownloadDelegate _download:didReceiveResponse:]):
2644         (-[DownloadDelegate _downloadDidFinish:]):
2645         (runTest):
2646         (TEST):
2647         (-[FailingDownloadDelegate _downloadDidFinish:]):
2648         (-[FailingDownloadDelegate _download:didFailWithError:]):
2649         (-[FailingDownloadDelegate _downloadDidCancel:]):
2650         (-[CancelledDownloadDelegate _downloadDidStart:]):
2651         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2652         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2653         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2654         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2655         (-[DownloadDelegate sourceURL]): Deleted.
2656         (runTestWithNavigationDelegate): Deleted.
2657
2658 2014-03-26  Anders Carlsson  <andersca@apple.com>
2659
2660         Change MiniBrowser to hold on to window controllers instead of windows
2661         https://bugs.webkit.org/show_bug.cgi?id=130797
2662
2663         Reviewed by Oliver Hunt.
2664
2665         * MiniBrowser/mac/AppDelegate.h:
2666         * MiniBrowser/mac/AppDelegate.m:
2667         (-[BrowserAppDelegate init]):
2668         (-[BrowserAppDelegate newWindow:]):
2669         (-[BrowserAppDelegate browserWindowWillClose:]):
2670         (-[BrowserAppDelegate applicationWillTerminate:]):
2671         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2672
2673 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2674
2675         Unreviewed, rolling out r166264.
2676         https://bugs.webkit.org/show_bug.cgi?id=130785
2677
2678         Broke some window.opener tests for WK2 Mavericks (Requested by
2679         brrian__ on #webkit).
2680
2681         Reverted changeset:
2682
2683         "Web Replay: resource unique identifiers should be unique-per-
2684         frame, not globally"
2685         https://bugs.webkit.org/show_bug.cgi?id=130632
2686         http://trac.webkit.org/changeset/166264
2687
2688 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2689
2690         [CSS Shapes] Remove shape-inside support
2691         https://bugs.webkit.org/show_bug.cgi?id=130698
2692
2693         Reviewed by David Hyatt.
2694
2695         * Scripts/webkitperl/FeatureList.pm:
2696
2697 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2698
2699         Unreviewed. Add myself as a committer.
2700
2701         * Scripts/webkitpy/common/config/contributors.json:
2702
2703 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2704
2705         run-launcher is Perl script so use elsif and not elif
2706         https://bugs.webkit.org/show_bug.cgi?id=130771
2707
2708         Reviewed by Carlos Garcia Campos.
2709
2710         * Scripts/run-launcher:
2711
2712 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2713
2714         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2715         https://bugs.webkit.org/show_bug.cgi?id=130575
2716
2717         Reviewed by Mario Sanchez Prada.
2718
2719         Change ATK version to 2.11.92. Adjust current implementation.
2720
2721         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2722         (AccessibilityUIElement::intValue):
2723         (AccessibilityUIElement::minValue):
2724         (AccessibilityUIElement::maxValue):
2725         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2726         (WTR::AccessibilityUIElement::intValue):
2727         (WTR::AccessibilityUIElement::minValue):
2728         (WTR::AccessibilityUIElement::maxValue):
2729         * efl/jhbuild.modules:
2730         * gtk/jhbuild.modules:
2731
2732 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2733
2734         [GTK] The gnumake package is no longer needed in jhbuild
2735         https://bugs.webkit.org/show_bug.cgi?id=130121
2736
2737         Reviewed by Martin Robinson.
2738
2739         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2740         for a debug build cmake/system-gnumake worked just fine for me.
2741
2742         * gtk/jhbuild.modules: Removed gnumake.
2743         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2744         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2745
2746 2014-03-25  Andy Estes  <aestes@apple.com>
2747
2748         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2749
2750         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2751         (-[DownloadDelegate _download:didReceiveData:]):
2752         (-[DownloadDelegate _downloadDidFinish:]):
2753
2754 2014-03-25  Brian Burg  <bburg@apple.com>
2755
2756         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2757         https://bugs.webkit.org/show_bug.cgi?id=130623
2758
2759         Reviewed by Timothy Hatcher.
2760
2761         The resource loader callback dumping routines assumed that resource identifiers
2762         were globally unique. Its map of resource identifiers to URLs must also track the
2763         frame associated with the resource.
2764
2765         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2766         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2767         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2768         stable as long as the frame is valid.
2769         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2770         (WTR::InjectedBundlePage::willSendRequestForFrame):
2771         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2772         (WTR::InjectedBundlePage::didFinishLoadForResource):
2773         (WTR::InjectedBundlePage::didFailLoadForResource):
2774
2775 2014-03-25  Andy Estes  <aestes@apple.com>
2776
2777         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2778
2779         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2780         (-[DownloadDelegate _download:didReceiveResponse:]):
2781         (-[DownloadDelegate _download:didReceiveData:]):
2782
2783 2014-03-25  Andy Estes  <aestes@apple.com>
2784
2785         Add some debug logging to an API test that's failing on Mountain Lion.
2786
2787         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2788         (-[DownloadDelegate _download:didReceiveResponse:]):
2789         (-[DownloadDelegate _downloadDidFinish:]):
2790
2791 2014-03-25  Anders Carlsson  <andersca@apple.com>
2792
2793         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2794         https://bugs.webkit.org/show_bug.cgi?id=130732
2795
2796         Reviewed by Tim Horton.
2797
2798         * MiniBrowser/mac/WK2BrowserWindowController.m:
2799         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2800
2801 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2802
2803         [GTK] Remove the autotools build
2804         https://bugs.webkit.org/show_bug.cgi?id=130717
2805
2806         Reviewed by Anders Carlsson.
2807
2808         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2809         * GNUmakefile.am: Removed.
2810         * GtkLauncher/GNUmakefile.am: Removed.
2811         * GtkLauncher/main.c: Remove references to the autotools configure file.
2812         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2813         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2814         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2815         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2816         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2817         * Scripts/build-webkit: No longer handle autotools.
2818         * Scripts/run-gtk-tests: Ditto.
2819         (TestRunner._setup_testing_environment):
2820         * Scripts/run-launcher: Ditto.
2821         * Scripts/webkitdirs.pm: Ditto.
2822         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2823         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2824         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2825         * Scripts/webkitpy/style/checker.py:
2826         * TestWebKitAPI/GNUmakefile.am: Removed.
2827         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2828         * WebKitTestRunner/GNUmakefile.am: Removed.
2829         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2830         * gtk/GNUmakefile.am: Removed.
2831         * gtk/common.py: Remove checks for the autotools build.
2832         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2833
2834 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2835
2836         prepare-ChangeLog throws false positive warnings for modified files.
2837         https://bugs.webkit.org/show_bug.cgi?id=130687
2838
2839         Reviewed by Darin Adler.
2840
2841         * Scripts/prepare-ChangeLog:
2842         (originalFile): Ignore git commit paremeter.
2843         We don't need this to get the unmodified file.
2844         (extractLineRangeBeforeChange):
2845         Simplify the if statement. Follow-up after r166189.
2846
2847 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2848
2849         [EFL] Add ARM64 build support
2850         https://bugs.webkit.org/show_bug.cgi?id=130506
2851
2852         Rubber stamped by Gyuyoung Kim.
2853
2854         * Scripts/webkitdirs.pm:
2855         (isARM): Detect aarch64 as ARM.
2856
2857 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2858
2859         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2860         https://bugs.webkit.org/show_bug.cgi?id=130137
2861
2862         Reviewed by Csaba Osztrogonác.
2863
2864         * Scripts/webkitpy/common/checkout/changelog.py:
2865         (ChangeLogEntry._parse_bug_description):
2866         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2867         (test_parse_log_entries_from_changelog):
2868         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2869         (CheckoutTest.test_commit_info_for_revision):
2870
2871 2014-03-24  Andy Estes  <aestes@apple.com>
2872
2873         Fix the iOS build of TestWebKitAPI.
2874
2875         * TestWebKitAPI/Configurations/Base.xcconfig:
2876         * TestWebKitAPI/PlatformUtilities.h:
2877
2878 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2879
2880         Fix prepare-ChangeLog after r166156.
2881         https://bugs.webkit.org/show_bug.cgi?id=130674
2882
2883         Reviewed by Darin Adler.
2884
2885         * Scripts/prepare-ChangeLog:
2886         (generateFunctionLists):
2887         (extractLineRangeBeforeChange):
2888
2889 2014-03-24  Andy Estes  <aestes@apple.com>
2890
2891         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2892         https://bugs.webkit.org/show_bug.cgi?id=129322
2893
2894         Reviewed by Anders Carlsson.
2895
2896         Add an API test suite for _WKDownload.
2897
2898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2899         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2900         (-[DownloadDelegate initWithSourceURL:]):
2901         (-[DownloadDelegate sourceURL]):
2902         (-[DownloadDelegate _downloadDidStart:]):
2903         (-[DownloadDelegate _download:didReceiveResponse:]):
2904         (-[DownloadDelegate _download:didReceiveData:]):
2905         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2906         (-[DownloadDelegate _downloadDidFinish:]):
2907         (TEST):
2908         (runTestWithNavigationDelegate):
2909         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2910         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2911
2912 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2913
2914         filter-build-webkit: reduce unfiltered output
2915         https://bugs.webkit.org/show_bug.cgi?id=130485
2916
2917         Reviewed by Brent Fulgham.
2918
2919         * Scripts/filter-build-webkit:
2920         (shouldIgnoreLine):
2921
2922 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2923
2924         prepare-ChangeLog should list functions that have been removed too.
2925         https://bugs.webkit.org/show_bug.cgi?id=130508
2926
2927         Reviewed by Darin Adler.
2928
2929         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2930         We have to read the functions and the line ranges of them from the source
2931         before the change, then search for overlaps between them and the changed
2932         line ranges from diff.
2933
2934         * Scripts/prepare-ChangeLog:
2935         (originalFile): Get original source command.
2936         (generateFunctionLists): Collect deleted functions too.
2937         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2938         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2939         deleted functions ranges too.
2940         (extractLineRange): Renamed to extractLineRangeAfterChange.
2941
2942 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2943
2944         Move all EFL typedefs into EflTypedefs.h.
2945         https://bugs.webkit.org/show_bug.cgi?id=130511
2946
2947         Reviewed by Gyuyoung Kim.
2948
2949         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2950         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2951         * WebKitTestRunner/PlatformWebView.h: Ditto.
2952
2953 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2954
2955         Don't flush compositing layers within FrameView::willPaintContents()
2956         https://bugs.webkit.org/show_bug.cgi?id=130627
2957         <rdar://problem/16368869>
2958
2959         Reviewed by Sam Weinig.
2960         
2961         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2962         does not flush.
2963         
2964         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2965         into an explicit function called before dumping. 
2966         
2967         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2968         are flushed to CA. They will be pushed to the window by snapshotting.
2969
2970         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2971         Fix weird path to IOKit.framework.
2972         * DumpRenderTree/mac/DumpRenderTree.mm:
2973         (updateDisplay):
2974         (dump):
2975         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2976         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2977         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2978
2979 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2980
2981         fix-blink-patch: tool to fix up renamed directory paths in Blink
2982         <http://webkit.org/b/130609>
2983
2984         Reviewed by Ryosuke Niwa.
2985
2986         Usage: cat blink.patch | fix-blink-patch | svn-apply
2987
2988         * Scripts/fix-blink-patch: Added.
2989
2990 2014-03-21  Darin Adler  <darin@apple.com>
2991
2992         Remove use of deprecatedCharacters in WebKit API tests
2993         https://bugs.webkit.org/show_bug.cgi?id=130602
2994
2995         Reviewed by Antti Koivisto.
2996
2997         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2998         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2999         (TestWebKitAPI::expectEmpty): Use characters8.
3000         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
3001
3002         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3003         Removed the test that is entirely about 16-bit conversion since that's basically a test of
3004         the deprecatedCharacters function itself, which we are about to delete.
3005
3006 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3007
3008         [webkitpy] Fix has_valid_reviewer()
3009         https://bugs.webkit.org/show_bug.cgi?id=130589
3010
3011         Reviewed by Csaba Osztrogonác.
3012
3013         * Scripts/webkitpy/common/checkout/changelog.py:
3014         (ChangeLogEntry.has_valid_reviewer):
3015         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3016         (test_has_valid_reviewer):
3017         * Scripts/webkitpy/common/config/committers.py:
3018         (CommitterList._reviewer_only):
3019         (CommitterList.committer_by_name):
3020         (CommitterList.reviewer_by_email):
3021         (CommitterList):
3022         (CommitterList.reviewer_by_name):
3023
3024 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3025
3026         Add cache support for jhbuild
3027         https://bugs.webkit.org/show_bug.cgi?id=130588
3028
3029         Reviewed by Csaba Osztrogonác.
3030
3031         * jhbuild/jhbuildrc_common.py:
3032         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
3033
3034 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3035
3036         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
3037         https://bugs.webkit.org/show_bug.cgi?id=130504
3038
3039         Reviewed by Martin Robinson.
3040
3041         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
3042         CMake if not specified.
3043         * Scripts/webkitdirs.pm:
3044         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
3045         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
3046
3047 2014-03-21  Andreas Kling  <akling@apple.com>
3048
3049         RetainPtr API test should use CFArray instead of CFString for testing.
3050         <rdar://problem/16384899>
3051
3052         Unreviewed bot fix.
3053
3054         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3055         (TestWebKitAPI::TEST):
3056         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3057         (TestWebKitAPI::TEST):
3058
3059 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
3060
3061         Move to using std::unique_ptr for EFL objects.
3062         https://bugs.webkit.org/show_bug.cgi?id=129853
3063
3064         Reviewed by Gyuyoung Kim.
3065
3066         EflUniquePtr is a template alias of std::unique_ptr
3067         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
3068         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
3069
3070         * DumpRenderTree/efl/DumpRenderTree.cpp:
3071         (main):
3072         * ImageDiff/efl/ImageDiff.cpp:
3073         (initEfl):
3074         (main):
3075
3076 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
3077
3078         Unreviewed buildfix after r165983 for non Cocoa platforms
3079
3080         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
3081
3082         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
3083         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3084         * WebKitTestRunner/TestController.cpp:
3085
3086 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
3087
3088         [GTK][CMake] Add support for building with Clang
3089         https://bugs.webkit.org/show_bug.cgi?id=130260
3090
3091         Reviewed by Martin Robinson.
3092
3093         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
3094         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
3095         included GTest framework headers.
3096         * gtk/generate-gtkdoc:
3097         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
3098         in case of using Clang since that is now set by the CMake rule.
3099
3100 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
3101
3102         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
3103         https://bugs.webkit.org/show_bug.cgi?id=130476
3104
3105         Reviewed by Anders Carlsson.
3106         
3107         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
3108
3109         * MiniBrowser/mac/WK1BrowserWindowController.m:
3110         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3111         Remove log.
3112         * MiniBrowser/mac/WK2BrowserWindowController.m:
3113         (-[WK2BrowserWindowController awakeFromNib]):
3114         (-[WK2BrowserWindowController validateMenuItem:]):
3115         (-[WK2BrowserWindowController reload:]):
3116         Hook up reload.
3117         (-[WK2BrowserWindowController toggleZoomMode:]):
3118         (-[WK2BrowserWindowController resetZoom:]):
3119         (-[WK2BrowserWindowController canResetZoom]):
3120         (-[WK2BrowserWindowController currentZoomFactor]):
3121         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3122         (-[WK2BrowserWindowController canZoomIn]):
3123         (-[WK2BrowserWindowController canZoomOut]):
3124
3125 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
3126
3127         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
3128         https://bugs.webkit.org/show_bug.cgi?id=130463
3129
3130         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
3131
3132 2014-03-18  Samuel White  <samuel_white@apple.com>
3133
3134         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
3135         https://bugs.webkit.org/show_bug.cgi?id=130250
3136
3137         Reviewed by Chris Fleizach.
3138
3139         Added ability to toggle enhanced accessibility on and off to support tests that require it.
3140
3141         * DumpRenderTree/AccessibilityController.cpp:
3142         (enableEnhancedAccessibilityCallback):
3143         (getEnhancedAccessibilityEnabledCallback):
3144         (AccessibilityController::getJSClass):
3145         * DumpRenderTree/AccessibilityController.h:
3146         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3147         (AccessibilityController::enableEnhancedAccessibility):
3148         (AccessibilityController::enhancedAccessibilityEnabled):
3149         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3150         (AccessibilityController::enableEnhancedAccessibility):
3151         (AccessibilityController::enhancedAccessibilityEnabled):
3152         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3153         (AccessibilityController::enableEnhancedAccessibility):
3154         (AccessibilityController::enhancedAccessibilityEnabled):
3155         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3156         (AccessibilityController::enableEnhancedAccessibility):
3157         (AccessibilityController::enhancedAccessibilityEnabled):
3158         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3159         (WTR::AccessibilityController::enableEnhancedAccessibility):
3160         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
3161         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3162         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3163
3164 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
3165
3166         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
3167         yet).
3168
3169         * Scripts/webkitpy/common/config/contributors.json:
3170
3171 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3172
3173         Web Inspector: Remove stale ReportMemoryUsagePlugin
3174         https://bugs.webkit.org/show_bug.cgi?id=130405
3175
3176         Reviewed by Andreas Kling.
3177
3178         This clang plugin looks like it was used for the old Inspector memory
3179         instrumentation that was removed. So the tool can be removed.
3180
3181         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
3182         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
3183         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
3184         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
3185
3186 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3187
3188         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
3189         https://bugs.webkit.org/show_bug.cgi?id=130220
3190
3191         Reviewed by Csaba Osztrogonác.
3192
3193         * Scripts/webkitpy/common/checkout/changelog.py:
3194         (ChangeLog.set_reviewer):
3195         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3196         (test_set_reviewer):
3197
3198 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
3199
3200         More FTL enabling.
3201
3202         Rubber stamped by Dan Bernstein.
3203
3204         * Tools/Scripts/build-webkit:
3205
3206 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3207
3208         Renable pagination mode in WK2 MiniBrowser
3209         https://bugs.webkit.org/show_bug.cgi?id=130374
3210
3211         Reviewed by Anders Carlsson.
3212         
3213         Put the implementation of togglePaginationMode: back, and correctly
3214         enable the menu item.
3215
3216         * MiniBrowser/mac/WK2BrowserWindowController.m:
3217         (-[WK2BrowserWindowController validateMenuItem:]):
3218         (-[WK2BrowserWindowController isPaginated]):
3219         (-[WK2BrowserWindowController togglePaginationMode:]):
3220
3221 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3222
3223         Add --reset option to Tools/Scripts/set-webkit-configuration script
3224         https://bugs.webkit.org/show_bug.cgi?id=130401
3225
3226         Reviewed by Csaba Osztrogonác.
3227
3228         * Scripts/set-webkit-configuration:
3229
3230 2014-03-18  Alberto Garcia  <berto@igalia.com>
3231
3232         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
3233         https://bugs.webkit.org/show_bug.cgi?id=130388
3234
3235         Reviewed by Sergio Villar Senin.
3236
3237         * Scripts/webkitdirs.pm:
3238         (shouldRemoveCMakeCache): make sure that the build directory
3239         exists before attempting to create a file in it.
3240
3241 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
3242
3243         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
3244         https://bugs.webkit.org/show_bug.cgi?id=130336
3245
3246         Reviewed by Gyuyoung Kim.
3247
3248         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
3249         requires a space between literal and string macro [-Wliteral-suffix]'
3250         warning treated as error.
3251
3252         This patch applies a solution from r162448 to the EFL port.
3253
3254         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3255         * efl/jhbuild.modules: Added appropriate patch section.
3256
3257 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3258
3259         webkitpy test rebaseline.
3260
3261         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3262         (MainTest.test_default_args):
3263
3264 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3265
3266         --profile should imply --test-runner-count=1 in run-perf-tests
3267         https://bugs.webkit.org/show_bug.cgi?id=130375
3268
3269         Reviewed by Benjamin Poulain.
3270
3271         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
3272
3273         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3274         (PerfTestsRunner._parse_args): Use -1 as the default value.
3275         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
3276         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
3277         should be 1.
3278
3279 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3280
3281         Address some style nits.
3282
3283         * MiniBrowser/mac/WK2BrowserWindowController.m:
3284
3285 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3286
3287         Add transparent window support back into MiniBrowser
3288         https://bugs.webkit.org/show_bug.cgi?id=130363
3289
3290         Reviewed by Anders Carlsson.
3291         
3292         Re-enable transparent window support for WK2.
3293
3294         * MiniBrowser/mac/WK2BrowserWindowController.m:
3295         (-[WK2BrowserWindowController validateMenuItem:]):
3296         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3297
3298 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3299
3300         Fix the 32-bit build; make the open panel make a WK1 window.
3301
3302         * MiniBrowser/mac/AppDelegate.m:
3303         (-[BrowserAppDelegate openDocument:]):
3304
3305 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3306
3307         Convert MiniBrowser to use WKWebView API
3308         https://bugs.webkit.org/show_bug.cgi?id=130061
3309
3310         Reviewed by Anders Carlsson.
3311         
3312         Convert the MiniBrowser WK2 window to use WebKit2 API as much
3313         as possible.
3314         
3315         Some functionality was removed temporarily:
3316             - text zoom, page zoom
3317             - reload
3318             - pagination mode
3319             - transparent window
3320             - dumping source
3321             - window.open support
3322             - beforeUnload panel
3323             - find in page
3324
3325         * MiniBrowser/mac/AppDelegate.h:
3326         * MiniBrowser/mac/AppDelegate.m:
3327         (-[BrowserAppDelegate init]):
3328         (-[BrowserAppDelegate newWindow:]):
3329         (-[BrowserAppDelegate applicationWillTerminate:]):
3330         (-[BrowserAppDelegate openDocument:]):
3331         * MiniBrowser/mac/WK2BrowserWindowController.h:
3332         * MiniBrowser/mac/WK2BrowserWindowController.m:
3333         (-[WK2BrowserWindowController awakeFromNib]):
3334         (-[WK2BrowserWindowController dealloc]):
3335         (-[WK2BrowserWindowController fetch:]):
3336         (-[WK2BrowserWindowController validateMenuItem:]):
3337         (-[WK2BrowserWindowController reload:]):
3338         (-[WK2BrowserWindowController goBack:]):
3339         (-[WK2BrowserWindowController goForward:]):
3340         (-[WK2BrowserWindowController toggleZoomMode:]):
3341         (-[WK2BrowserWindowController resetZoom:]):
3342         (-[WK2BrowserWindowController canResetZoom]):
3343         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3344         (-[WK2BrowserWindowController togglePaginationMode:]):
3345         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3346         (-[WK2BrowserWindowController windowShouldClose:]):
3347         (-[WK2BrowserWindowController applicationTerminating]):
3348         (-[WK2BrowserWindowController currentZoomFactor]):
3349         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3350         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3351         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3352         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3353         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3354         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3355         (-[WK2BrowserWindowController find:]):
3356         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
3357         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
3358         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
3359         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
3360         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3361         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3362         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3363         * WebKitTestRunner/PlatformWebView.h:
3364         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3365         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3366
3367 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
3368
3369         Use RunLoop objects through references instead of pointers
3370         https://bugs.webkit.org/show_bug.cgi?id=130313
3371
3372         Reviewed by Andreas Kling.
3373
3374         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
3375         return RunLoop reference instead of a pointer.
3376
3377         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3378         (loadedCallback):
3379         (clickedCallback):
3380
3381 2014-03-17  Tim Horton  <timothy_horton@apple.com>
3382
3383         sort-export-file --help doesn't work (missing 'use')
3384         https://bugs.webkit.org/show_bug.cgi?id=130338
3385
3386         Reviewed by Anders Carlsson.
3387
3388         * Scripts/sort-export-file:
3389         Add a missing 'use', and fix a typo in an error message.
3390
3391 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
3392
3393         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
3394         https://bugs.webkit.org/show_bug.cgi?id=130155
3395
3396         Reviewed by Philippe Normand.
3397
3398         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
3399
3400 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3401
3402         [GTK] MiniBrowser fails to load injected bundle lib
3403         https://bugs.webkit.org/show_bug.cgi?id=130332
3404
3405         Reviewed by Anders Carlsson.
3406
3407         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
3408
3409         * MiniBrowser/gtk/main.c:
3410         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
3411         process is spawn.
3412
3413 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
3414
3415         [EFL] Enable TOUCH_SLIDER macro
3416         https://bugs.webkit.org/show_bug.cgi?id=130185
3417
3418         Reviewed by Gyuyoung Kim.
3419
3420         * Scripts/webkitperl/FeatureList.pm:
3421
3422 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
3423
3424         [GTK][CMake] Build with -fno-rtti
3425         https://bugs.webkit.org/show_bug.cgi?id=130261
3426
3427         Reviewed by Martin Robinson.
3428
3429         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
3430         defined to 0 to prevent typeid use in included GTest headers.
3431
3432 2014-03-16  Brian Burg  <bburg@apple.com>
3433
3434         Web Inspector: vended backend commands file should be generated as part of the build
3435         https://bugs.webkit.org/show_bug.cgi?id=130110
3436
3437         Reviewed by Timothy Hatcher.
3438
3439         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
3440
3441 2014-03-16  Diego Pino García  <dpino@igalia.com>
3442
3443         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
3444         https://bugs.webkit.org/show_bug.cgi?id=128999
3445
3446         Reviewed by Philippe Normand.
3447
3448         * MiniBrowser/gtk/BrowserWindow.c:
3449         (reloadPage):
3450         (reloadPageIgnoringCache):
3451         (browser_window_init):
3452
3453 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
3454
3455         [GTK] Improve ninja detection in webkitdirs.pm
3456         https://bugs.webkit.org/show_bug.cgi?id=129902
3457
3458         Reviewed by Daniel Bates.
3459
3460         * Scripts/webkitdirs.pm:
3461         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
3462         us to look for ninja-build as well.
3463
3464 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
3465
3466         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3467         https://bugs.webkit.org/show_bug.cgi?id=130276
3468         <rdar://problem/16266927>
3469         
3470         Reviewed by Simon Fraser.
3471
3472         * BuildSlaveSupport/build-launcher-app:
3473         * BuildSlaveSupport/build-launcher-dmg:
3474         * DumpRenderTree/DumpRenderTree.h:
3475         * DumpRenderTree/DumpRenderTreePrefix.h:
3476         * DumpRenderTree/GCController.cpp:
3477         * DumpRenderTree/GCController.h:
3478         * DumpRenderTree/JavaScriptThreading.cpp:
3479         * DumpRenderTree/JavaScriptThreading.h:
3480         * DumpRenderTree/PixelDumpSupport.cpp:
3481         * DumpRenderTree/PixelDumpSupport.h:
3482         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3483         * DumpRenderTree/TestRunner.cpp:
3484         * DumpRenderTree/TestRunner.h:
3485         * DumpRenderTree/WorkQueue.cpp:
3486         * DumpRenderTree/WorkQueue.h:
3487         * DumpRenderTree/WorkQueueItem.h:
3488         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3489         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3490         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3491         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3492         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3493         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3494         * DumpRenderTree/efl/EditingCallbacks.cpp:
3495         * DumpRenderTree/efl/EditingCallbacks.h:
3496         * DumpRenderTree/efl/EventSender.cpp:
3497         * DumpRenderTree/efl/EventSender.h:
3498         * DumpRenderTree/efl/GCControllerEfl.cpp:
3499         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3500         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3501         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3502         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3503         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3504         * DumpRenderTree/gtk/EditingCallbacks.h:
3505         * DumpRenderTree/gtk/EventSender.cpp:
3506         * DumpRenderTree/gtk/EventSender.h:
3507         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3508         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3509         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3510         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
3511         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3512         * DumpRenderTree/gtk/TextInputController.cpp:
3513         * DumpRenderTree/gtk/TextInputController.h:
3514         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
3515         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3516         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3517         * DumpRenderTree/mac/AppleScriptController.h:
3518         * DumpRenderTree/mac/AppleScriptController.m:
3519         * DumpRenderTree/mac/CheckedMalloc.cpp:
3520         * DumpRenderTree/mac/CheckedMalloc.h:
3521         * DumpRenderTree/mac/DumpRenderTree.mm:
3522         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3523         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3524         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3525         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3526         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3527         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3528         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3529         * DumpRenderTree/mac/EditingDelegate.h:
3530         * DumpRenderTree/mac/EditingDelegate.mm:
3531         * DumpRenderTree/mac/EventSendingController.h:
3532         * DumpRenderTree/mac/EventSendingController.mm:
3533         * DumpRenderTree/mac/FrameLoadDelegate.h:
3534         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3535         * DumpRenderTree/mac/GCControllerMac.mm:
3536         * DumpRenderTree/mac/MockWebNotificationProvider.h:
3537         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3538         * DumpRenderTree/mac/NavigationController.h:
3539         * DumpRenderTree/mac/NavigationController.m:
3540         * DumpRenderTree/mac/ObjCController.h:
3541         * DumpRenderTree/mac/ObjCController.m:
3542         * DumpRenderTree/mac/ObjCPlugin.h:
3543         * DumpRenderTree/mac/ObjCPlugin.m:
3544         * DumpRenderTree/mac/ObjCPluginFunction.h:
3545         * DumpRenderTree/mac/ObjCPluginFunction.m:
3546         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3547         * DumpRenderTree/mac/PolicyDelegate.h:
3548         * DumpRenderTree/mac/PolicyDelegate.mm:
3549         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3550         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3551         * DumpRenderTree/mac/TestRunnerMac.mm:
3552         * DumpRenderTree/mac/TextInputController.h:
3553         * DumpRenderTree/mac/TextInputController.m:
3554         * DumpRenderTree/mac/UIDelegate.h:
3555         * DumpRenderTree/mac/UIDelegate.mm:
3556         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3557         * DumpRenderTree/win/DRTDataObject.cpp:
3558         * DumpRenderTree/win/DRTDataObject.h:
3559         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3560         * DumpRenderTree/win/DRTDropSource.cpp:
3561         * DumpRenderTree/win/DRTDropSource.h:
3562         * DumpRenderTree/win/DraggingInfo.h:
3563         * DumpRenderTree/win/DumpRenderTree.cpp:
3564         * DumpRenderTree/win/DumpRenderTreeWin.h:
3565         * DumpRenderTree/win/EditingDelegate.cpp:
3566         * DumpRenderTree/win/EditingDelegate.h:
3567         * DumpRenderTree/win/EventSender.cpp:
3568         * DumpRenderTree/win/EventSender.h:
3569         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3570         * DumpRenderTree/win/FrameLoadDelegate.h:
3571         * DumpRenderTree/win/GCControllerWin.cpp:
3572         * DumpRenderTree/win/HistoryDelegate.cpp:
3573         * DumpRenderTree/win/HistoryDelegate.h:
3574         * DumpRenderTree/win/MD5.cpp:
3575         * DumpRenderTree/win/MD5.h:
3576         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3577         * DumpRenderTree/win/PolicyDelegate.cpp:
3578         * DumpRenderTree/win/PolicyDelegate.h:
3579         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3580         * DumpRenderTree/win/ResourceLoadDelegate.h:
3581         * DumpRenderTree/win/TestRunnerWin.cpp:
3582         * DumpRenderTree/win/TextInputController.cpp:
3583         * DumpRenderTree/win/TextInputController.h:
3584         * DumpRenderTree/win/TextInputControllerWin.cpp:
3585         * DumpRenderTree/win/UIDelegate.cpp:
3586         * DumpRenderTree/win/UIDelegate.h:
3587         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3588         * EWebLauncher/main.c:
3589         * GtkLauncher/main.c:
3590         * ImageDiff/efl/ImageDiff.cpp:
3591         * ImageDiff/gtk/ImageDiff.cpp:
3592         * MiniBrowser/gtk/main.c:
3593         * Scripts/SpacingHeuristics.pm:
3594         * Scripts/VCSUtils.pm:
3595         * Scripts/bisect-builds:
3596         * Scripts/build-dumprendertree:
3597         * Scripts/build-jsc:
3598         * Scripts/build-webkit:
3599         * Scripts/check-dom-results:
3600         * Scripts/check-for-exit-time-destructors:
3601         * Scripts/check-for-global-initializers:
3602         * Scripts/commit-log-editor:
3603         * Scripts/compare-timing-files:
3604         * Scripts/debug-minibrowser:
3605         * Scripts/debug-safari:
3606         * Scripts/do-file-rename:
3607         * Scripts/find-extra-includes:
3608         * Scripts/generate-coverage-data:
3609         * Scripts/make-script-test-wrappers:
3610         * Scripts/malloc-tree:
3611         * Scripts/old-run-webkit-tests:
3612         * Scripts/parse-malloc-history:
3613         * Scripts/report-include-statistics:
3614         * Scripts/resolve-ChangeLogs:
3615         * Scripts/run-bindings-tests:
3616         * Scripts/run-iexploder-tests:
3617         * Scripts/run-javascriptcore-tests:
3618         * Scripts/run-jsc:
3619         * Scripts/run-launcher:
3620         * Scripts/run-leaks:
3621         * Scripts/run-mangleme-tests:
3622         * Scripts/run-minibrowser:
3623         * Scripts/run-pageloadtest:
3624         * Scripts/run-regexp-tests:
3625         * Scripts/run-safari:
3626         * Scripts/run-sunspider:
3627         * Scripts/run-webkit-app:
3628         * Scripts/sampstat:
3629         * Scripts/set-webkit-configuration:
3630         * Scripts/sort-Xcode-project-file:
3631         * Scripts/sort-export-file:
3632         * Scripts/split-file-by-class:
3633         * Scripts/sunspider-compare-results:
3634         * Scripts/svn-apply:
3635         * Scripts/svn-create-patch:
3636         * Scripts/svn-unapply:
3637         * Scripts/test-webkit-scripts:
3638         * Scripts/update-javascriptcore-test-results:
3639         * Scripts/update-webkit:
3640         * Scripts/update-webkit-auxiliary-libs:
3641         * Scripts/update-webkit-dependency:
3642         * Scripts/update-webkit-localizable-strings:
3643         * Scripts/update-webkit-support-libs:
3644         * Scripts/update-webkit-wincairo-libs:
3645         * Scripts/webkit-build-directory:
3646         * Scripts/webkitdirs.pm:
3647         (installedSafariPath):
3648         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3649         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3650         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3651         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3652         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3653         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3654         * Scripts/webkitperl/features.pm:
3655         * Scripts/webkitperl/httpd.pm:
3656         * Scripts/webkitpy/bindings/main.py:
3657         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3658         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3659         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3660         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3661         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3662         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3663         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3664         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3665         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3666         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3667         * WebKitTestRunner/PixelDumpSupport.cpp:
3668         * WebKitTestRunner/PixelDumpSupport.h:
3669         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3670         * WinLauncher/WinLauncher.cpp:
3671         * WinLauncher/WinLauncher.h:
3672     &n