WTR is not successfully changing the NSUserDefaults
[WebKit-https.git] / Tools / ChangeLog
1 2011-10-01  Sam Weinig  <sam@webkit.org>
2
3         WTR is not successfully changing the NSUserDefaults
4         https://bugs.webkit.org/show_bug.cgi?id=69204
5
6         Reviewed by Dan Bernstein.
7
8         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
9         (WTR::InjectedBundle::platformInitialize):
10         Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
11         get our overrides picked up.
12
13 2011-09-30  Daniel Bates  <dbates@rim.com>
14
15         Cleanup: Extract code to launch a Mac WebKit application into a common function
16         https://bugs.webkit.org/show_bug.cgi?id=68662
17
18         Reviewed by Adam Roben.
19
20         Extracts common code to launch a WebKit application on Mac OS X into a function
21         so that we can remove duplicate code.
22
23         * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
24         * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
25         (runMacWebKitApp): Added.
26         (runSafari): Modified to use webkitdirs::runMacWebKitApp().
27         (runMiniBrowser): Ditto.
28         (runWebKitTestRunner): Ditto.
29         (runTestWebKitAPI): Ditto.
30
31 2011-09-29  David Levin  <levin@chromium.org>
32
33         watchlist: Add webkit-patch command to run watchlist.
34         https://bugs.webkit.org/show_bug.cgi?id=68973
35
36         Reviewed by Eric Seidel.
37
38         * Scripts/webkitpy/common/host.py: Exposed the watch_list.
39         * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
40         the cc and messages as sorted lists. To allow for deterministic ordering.
41         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
42         * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
43         that it will be exposed as a command by webkit-patch.
44         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
45         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
46         * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
47         * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
48         * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
49         * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
50         * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
51         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
52
53 2011-09-30  David Levin  <levin@chromium.org>
54
55         watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
56         https://bugs.webkit.org/show_bug.cgi?id=69031
57
58         Reviewed by Adam Barth.
59
60         * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
61         a comment to explain something important about the email addresses, and
62         a comment to let emacs know to treat the file as a python file.
63         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
64         Detects increases or decreases in a pattern.
65         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
66         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
67         Added unit tests for watchlist which has "more" or "less".
68         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
69         Added support for "more" or "less".
70
71 2011-09-30  Sam Weinig  <sam@webkit.org>
72
73         Add support for eventSender.mouseScrollBy in WTR
74         https://bugs.webkit.org/show_bug.cgi?id=69189
75
76         Add implementation of eventSender.mouseScrollBy for the mac.
77
78         Reviewed by Simon Fraser.
79
80         * WebKitTestRunner/EventSenderProxy.h:
81         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
82         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
83         (WTR::EventSendingController::keyDown):
84         (WTR::EventSendingController::mouseScrollBy):
85         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
86         * WebKitTestRunner/TestController.cpp:
87         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
88         * WebKitTestRunner/mac/EventSenderProxy.mm:
89         (WTR::EventSenderProxy::mouseScrollBy):
90
91 2011-09-30  Simon Fraser  <simon.fraser@apple.com>
92
93         fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
94         https://bugs.webkit.org/show_bug.cgi?id=35273
95
96         Reviewed by Dan Bernstein.
97         
98         There are two types of font issue that can cause layout test failure.
99         First, the user may have non-standard fonts installed that affect the layout
100         of some tests. For example, some tests use the MS Gothic font if installed.
101         
102         Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
103         which override the system fonts (e.g. a copy of Arial from MS Office). For
104         some tests, this can affect font metrics or fallback behavior.
105         
106         This change addresses the first problem only. It limits the set of fonts
107         available through NSFontManager, by swizzling some methods to return
108         a list of fonts or font families which only include fonts from a hardcoded
109         whitelist.
110         
111         * DumpRenderTree/mac/DumpRenderTree.mm:
112         (allowedFontFamilySet):
113         (drt_NSFontManager_availableFontFamilies):
114         (drt_NSFontManager_availableFonts):
115         (swizzleNSFontManagerMethods):
116         (activateTestingFonts):
117         (adjustFonts):
118         (createWebViewAndOffscreenWindow):
119         (prepareConsistentTestingEnvironment):
120         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
121         (WTR::allowedFontFamilySet):
122         (WTR::drt_NSFontManager_availableFontFamilies):
123         (WTR::drt_NSFontManager_availableFonts):
124         (WTR::swizzleNSFontManagerMethods):
125         (WTR::InjectedBundle::platformInitialize):
126
127 2011-09-30  David Levin  <levin@chromium.org>
128
129         Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
130         https://bugs.webkit.org/show_bug.cgi?id=69039
131
132         Reviewed by Adam Barth.
133
134         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
135         Actually skip only one specific test that is failing on Windows.
136
137 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
138
139         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
140
141         For DRT we didn't install the message handler early enough to
142         catch output while constructing the QApplication. For WTR we
143         didn't even install a message handler.
144
145         Since the UI process will forward any output from the web process
146         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
147         in WTR before the web process is started. This is picked up by the
148         web process which installs its own message handler.
149
150         The environment variable can be overriden on the command line if you
151         want to see output from the web process, or you can pass --verbose to
152         WTR to see output from both processes.
153
154         https://bugs.webkit.org/show_bug.cgi?id=69132
155
156         Reviewed by Andreas Kling.
157
158         * DumpRenderTree/qt/main.cpp:
159         * WebKitTestRunner/qt/main.cpp:
160
161 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
162
163         [Qt] Make sure WTR sizes the window and item correctly
164
165         Revision 96345 changed the logic for how the view and
166         window was created, but missed a vital part, setting
167         the size.
168
169         We now use a QSGView for the window, that has a simple
170         item as its root object that is always resized to fit
171         within the window. The webview is then parented to the
172         root object and set to anchors.fill: parent. That way
173         any window geometry changes will propagate to the web
174         view.
175
176         https://bugs.webkit.org/show_bug.cgi?id=69134
177
178         Reviewed by Andreas Kling.
179
180         * WebKitTestRunner/PlatformWebView.h:
181         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
182
183 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
184
185         [EFL] Only save the current viewport in PixelDumpSupportEfl.
186         https://bugs.webkit.org/show_bug.cgi?id=68450
187
188         Reviewed by Antonio Gomes.
189
190         The previous implementation saved the whole page contents in the final
191         PNG, however the baselines and expectations in the tree only want the
192         current viewport (with a scrollbar, if needed), so we now only save the
193         currently visible contents.
194
195         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
196         (createBitmapContextFromWebView): Use
197         ewk_frame_visible_content_geometry_get instead of
198         ewk_frame_contents_size_get.
199
200 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
201
202         [EFL] Support and keep track of extra windows (views).
203         https://bugs.webkit.org/show_bug.cgi?id=68454
204
205         Reviewed by Antonio Gomes.
206
207         So far, window.open and related JavaScript code would not work, as
208         DRTView did not implementation
209         Ewk_View_Smart_Class::window_{open,close}. The default implementation
210         in ewk just returns the current window/view, which broke any
211         layouttest which relied on window.open.
212
213         We now properly create and remove these new views. Unfortunately, the
214         current way ewk works (and due to the fact that we cannot pass class
215         methods as function pointers to the EFL functions), DRTView needs to
216         know that DRTChrome exists and call `browser' directly in some points.
217
218         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
219         (onWindowCreate):
220         (onWindowCloseDelayed):
221         (onWindowClose):
222         (drtViewTiledAdd):
223
224 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
225
226         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
227         https://bugs.webkit.org/show_bug.cgi?id=42698
228
229         Reviewed by Andreas Kling.
230
231         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
232         and call clearApplicationCache when layoutTest start up.
233
234         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
235         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
236         (WTR::InjectedBundle::beginTesting):
237         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
238         (WTR::LayoutTestController::clearAllApplicationCaches):
239         (WTR::LayoutTestController::setAppCacheMaximumSize):
240         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
241
242 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
243
244         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
245         https://bugs.webkit.org/show_bug.cgi?id=69145
246
247         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
248         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
249         and is perfectly suitable for SceneGraph as well. GraphicsScene events
250         will not be available in QtGui anymore in future. Therefore we also have to change
251         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
252
253         Reviewed by Chang Shu.
254
255         * WebKitTestRunner/EventSenderProxy.h:
256         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
257         (WTR::EventSenderProxy::createMouseEvent):
258         (WTR::EventSenderProxy::mouseDown):
259         (WTR::EventSenderProxy::mouseUp):
260         (WTR::EventSenderProxy::mouseMoveTo):
261
262 2011-09-30  James Robinson  <jamesr@chromium.org>
263
264         [chromium] Add WebKit API for sending input events to the compositor thread
265         https://bugs.webkit.org/show_bug.cgi?id=69117
266
267         Reviewed by Darin Fisher.
268
269         Adds support for creating and setting a compositor thread in DRT.
270
271         * DumpRenderTree/chromium/WebViewHost.cpp:
272         (WebViewHost::WebViewHost):
273         * DumpRenderTree/chromium/WebViewHost.h:
274
275 2011-09-29  David Levin  <levin@chromium.org>
276
277         watchlist: Add cross-checks for WatchList once it is filled.
278         https://bugs.webkit.org/show_bug.cgi?id=68975
279
280         Reviewed by Eric Seidel.
281
282         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
283         instead of having trivial getter and setters.
284         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
285         pass the validation checks.
286         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
287         and fix a few style nits.
288         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
289         validation checks.
290         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
291
292 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
293
294         run-api-tests fails on chromium-win bot
295         https://bugs.webkit.org/show_bug.cgi?id=69121
296
297         On Windows running a perl script needs the interpreter.
298
299         Reviewed by Adam Barth.
300
301         * Scripts/run-api-tests:
302         (buildTestTool):
303
304 2011-09-29  Adam Barth  <abarth@webkit.org>
305
306         Attempt to make this tool work on Windows.
307
308         * Scripts/run-api-tests:
309         (buildTestTool):
310
311 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
312
313         [Qt] Try to fix the minial build
314
315         * QtTestBrowser/launcherwindow.cpp:
316         * QtTestBrowser/webpage.cpp:
317
318 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
319
320         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
321
322         QWidget and friends now live in the QtWidgets library. We update
323         includes in implementation files and private headers to us the
324         non-module-prefixed path, and leave the lookup for the include
325         path. For public headers we have to ifdef the includes as the
326         user might now have the modules we need in his QT config.
327
328         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
329         have to update our code and use windowHandle() for setting the
330         parent relationships.
331
332         https://bugs.webkit.org/show_bug.cgi?id=68687
333
334         Reviewed by Andreas Kling.
335
336         * DumpRenderTree/qt/DumpRenderTree.pro:
337         * DumpRenderTree/qt/ImageDiff.pro:
338         * MiniBrowser/qt/BrowserView.cpp:
339         * MiniBrowser/qt/BrowserView.h:
340         * MiniBrowser/qt/BrowserWindow.cpp:
341         * MiniBrowser/qt/BrowserWindow.h:
342         * MiniBrowser/qt/MiniBrowser.pro:
343         * MiniBrowser/qt/MiniBrowserApplication.h:
344         * MiniBrowser/qt/main.cpp:
345         * QtTestBrowser/QtTestBrowser.pro:
346         * QtTestBrowser/launcherwindow.cpp:
347         * QtTestBrowser/launcherwindow.h:
348         * QtTestBrowser/locationedit.h:
349         * QtTestBrowser/main.cpp:
350         * QtTestBrowser/mainwindow.cpp:
351         * QtTestBrowser/mainwindow.h:
352         * QtTestBrowser/webinspector.h:
353         * QtTestBrowser/webpage.cpp:
354         * QtTestBrowser/webview.cpp:
355         * WebKitTestRunner/PlatformWebView.h:
356         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
357
358 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
359
360         Initial implementation of WebInspector for WebKit2 GTK port.
361         https://bugs.webkit.org/show_bug.cgi?id=68235
362
363         Reviewed by Martin Robinson.
364
365         * MiniBrowser/gtk/BrowserWindow.c:
366         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
367
368 2011-09-29  Adam Barth  <abarth@webkit.org>
369
370         Unbreak the "update expectatations" button by using the existing
371         machinery to create the failureInfo objects.
372
373         Unbreak the "close" button on the progress dialog by using |this|
374         instead of the old name of the object.
375
376         Teach the controllers unit test not to talk to the actual network.
377
378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
381
382 2011-09-29  Hans Wennborg  <hans@chromium.org>
383
384         IndexedDB: Use LevelDB also for in-memory databases
385         https://bugs.webkit.org/show_bug.cgi?id=68903
386
387         Reviewed by Steve Block.
388
389         Remove the temporary dir that was necessary before LevelDB supported
390         in-memory databases.
391
392         * DumpRenderTree/chromium/TestShell.cpp:
393         (TestShell::TestShell):
394         * DumpRenderTree/chromium/TestShell.h:
395
396 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
397
398         Run TestWebKitAPI on Chromium buildbots
399         https://bugs.webkit.org/show_bug.cgi?id=68678
400
401         Reviewed by Tony Chang.
402
403         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
404
405 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
406
407         garden-o-matic results should anticipate 0 unexpected failures.
408         https://bugs.webkit.org/show_bug.cgi?id=69036
409
410         Also fixes controllers: UnexpectedFailures test.
411
412         Reviewed by Adam Barth.
413
414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
415
416 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
417
418         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
419
420         https://bugs.webkit.org/show_bug.cgi?id=67253
421
422         Reviewed by Eric Seidel.
423
424         Nearly all of the work in this was done by Simon Fraser; I'm
425         just repackaging it and cleaning it up a bit. This change
426         modifies port.diff_image() to return a tuple of (pass/fail,
427         %age), adds the value to the FailureImageHashMismatch, and
428         writes the value into the full_results.json files to be
429         displayed in the results page.
430
431         * Scripts/webkitpy/layout_tests/controllers/manager.py:
432         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
433         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
434         * Scripts/webkitpy/layout_tests/models/test_failures.py:
435         * Scripts/webkitpy/layout_tests/port/base.py:
436         * Scripts/webkitpy/layout_tests/port/chromium.py:
437         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
438         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
439         * Scripts/webkitpy/layout_tests/port/test.py:
440         * Scripts/webkitpy/layout_tests/port/webkit.py:
441         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
442
443 2011-09-25  Kentaro Hara  <haraken@chromium.org>
444
445         Unreviewed. Adding myself to committers.py.
446
447         * Scripts/webkitpy/common/config/committers.py:
448
449 2011-09-28  Adam Barth  <abarth@webkit.org>
450
451         garden-o-matic shouldn't depend on test-results.appspot.com
452         https://bugs.webkit.org/show_bug.cgi?id=69019
453
454         Reviewed by Dimitri Glazkov.
455
456         This patch moves garden-o-matic from getting full_results.json from
457         test-results.appspot.com to getting that information directly from the
458         buildbot.  This patch improve the load time and accuracy of
459         garden-o-matic because test-results.appspot.com is slow and is dropping
460         a significant number of writes (see
461         https://bugs.webkit.org/show_bug.cgi?id=68748).
462
463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
466
467 2011-09-28  David Levin  <levin@chromium.org>
468
469         watchlist: Add a way to load the watchlist from config.
470         https://bugs.webkit.org/show_bug.cgi?id=68991
471
472         Reviewed by Eric Seidel.
473
474         * Scripts/webkitpy/common/config/watchlist: Added.
475         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
476         Support for loading the watch list.
477         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
478         Tests for the loading.
479         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
480         Adjusted to use the common base class.
481         * Scripts/webkitpy/common/webkitunittest.py: Added.
482         Made a common base class for functionality used in more than one.
483
484 2011-09-28  David Levin  <levin@chromium.org>
485
486         Attempt fix for Leopard python unit test run.
487
488         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
489
490 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
491
492         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
493         https://bugs.webkit.org/show_bug.cgi?id=68938
494
495         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
496
497         Reviewed by David Hyatt.
498
499         * DumpRenderTree/chromium/WebViewHost.cpp:
500         (WebViewHost::didUpdateLayout): Added width/height queries.
501         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
502
503 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
504
505         Get rebaseline server running again
506         https://bugs.webkit.org/show_bug.cgi?id=69020
507
508         Reviewed by Adam Barth.
509
510         Make rebaseline server run again after r90337 (missing format_date_time
511         import, results_json wasn't outputting anything).
512
513         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
514         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
515
516 2011-09-28  David Grogan  <dgrogan@chromium.org>
517
518         Move dgrogan from contributor to committer
519         https://bugs.webkit.org/show_bug.cgi?id=69021
520
521         * Scripts/webkitpy/common/config/committers.py:
522
523 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
524
525         Add Mac Skia GPU bots to builders.py
526         https://bugs.webkit.org/show_bug.cgi?id=69016
527
528         Reviewed by Eric Seidel.
529
530         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
531         GPU tests.
532
533         * Scripts/webkitpy/layout_tests/port/builders.py:
534         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
535
536 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
537
538         Second try at fixing the GTK+ build.
539
540         * GNUmakefile.am:
541
542 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
543
544         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
545         https://bugs.webkit.org/show_bug.cgi?id=68680
546
547         Reviewed by Tony Chang.
548
549         * Scripts/run-chromium-webkit-unit-tests:
550         * Scripts/webkitdirs.pm:
551         (determineBaseProductDir):
552
553 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
554
555         [Gtk] Implement textInputController.doCommand
556         https://bugs.webkit.org/show_bug.cgi?id=66496
557
558         Reviewed by Martin Robinson.
559
560         * DumpRenderTree/gtk/TextInputController.cpp:
561         (doCommandCallback): Callback function for textInputController.doCommand
562
563 2011-09-28  David Levin  <levin@chromium.org>
564
565         watchlist: Suggest corrections for typos and improve error message consistency.
566         https://bugs.webkit.org/show_bug.cgi?id=68976
567
568         Reviewed by Adam Barth.
569
570         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
571         for typos and improve consistency of the error messages.
572         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
573         and improve the regex that were already present.
574
575 2011-09-28  David Levin  <levin@chromium.org>
576
577         watchlist: Add support for matching added or deleted lines.
578         https://bugs.webkit.org/show_bug.cgi?id=68972
579
580         Reviewed by Adam Barth.
581
582         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
583         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
584         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
585         to the pattern match to only have the diff lines instead of the DiffFile.
586         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
587         Add tests for the new patterns and combinations of the patterns.
588         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
589         Sort imports. Add changeline support.
590
591 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
592
593         [GTK] Add WebKitError to GTK+ WebKit2 API
594         https://bugs.webkit.org/show_bug.cgi?id=68508
595
596         Reviewed by Martin Robinson.
597
598         * GNUmakefile.am: Add path to webkitgtk derived sources to the
599         include path.
600
601 2011-09-28  Philippe Normand  <pnormand@igalia.com>
602
603         [GTK] missing WebKit2 support in run-gtk-tests
604         https://bugs.webkit.org/show_bug.cgi?id=68992
605
606         Rubber-stamped by Andreas Kling.
607
608         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
609         webkit2 directory.
610
611 2011-09-27  Philippe Normand  <pnormand@igalia.com>
612
613         [GTK] build-webkit --no-webkit2 still builds WebKit2
614         https://bugs.webkit.org/show_bug.cgi?id=68892
615
616         Reviewed by Martin Robinson.
617
618         Take the --no-webkit2 option in account when building WebKitGTK+.
619
620         * Scripts/build-webkit:
621         * Scripts/webkitdirs.pm:
622         (buildAutotoolsProject):
623         (buildGtkProject):
624
625 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
626
627         Make Chromium Win Release (Tests) a core builder
628         https://bugs.webkit.org/show_bug.cgi?id=68906
629
630         Reviewed by Adam Barth.
631
632         Add Chromium Win Release (Tests) to the list of core builders.
633
634         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
635         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
636
637 2011-09-27  Adam Barth  <abarth@webkit.org>
638
639         garden-o-matic should load faster and inform the user what is happening
640         https://bugs.webkit.org/show_bug.cgi?id=68954
641
642         Reviewed by Dimitri Glazkov.
643
644         This test disables the expected failures tab.  The web inspector showed
645         that loading the data for this tab was slowing down the loading time
646         for the whole app.  We need to find a way to load that data lazily.
647
648         This patch also improves the update message to better describe the
649         progress the app is making analyzing data from the buildbot.
650
651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
654
655 2011-09-27  Adam Barth  <abarth@webkit.org>
656
657         garden-o-matic should show the first result when examining results
658         https://bugs.webkit.org/show_bug.cgi?id=68960
659
660         Reviewed by Dimitri Glazkov.
661
662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
663
664 2011-09-27  David Levin  <levin@chromium.org>
665
666         watchlist: Add support for cc and message rules.
667         https://bugs.webkit.org/show_bug.cgi?id=68950
668
669         Reviewed by Adam Barth.
670
671         * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
672         the cc's and messages for a patch.
673         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
674         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
675         for the rules.
676         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
677         A generic encapsulation of either a message list or a cc list.
678         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
679
680 2011-09-27  Tom Zakrajsek  <tomz@codeaurora.org>
681
682         webkit-patch doesn't like UTF-8 characters in reviewers names
683         https://bugs.webkit.org/show_bug.cgi?id=63452
684
685         Reviewed by Eric Seidel.
686
687         * Scripts/webkit-patch:
688
689 2011-09-27  Adam Barth  <abarth@webkit.org>
690
691         garden-o-matic examine buttons shows both expected and unexpected failures
692         https://bugs.webkit.org/show_bug.cgi?id=68918
693
694         Reviewed by Dimitri Glazkov.
695
696         This was a copy/paste error when I refactored this classes to share
697         more code.
698
699         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
700
701 2011-09-27  Ryosuke Niwa  <rniwa@webkit.org>
702
703         Add Kaustubh Atrawalkar to the list of contributors.
704
705         * Scripts/webkitpy/common/config/committers.py:
706
707 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
708
709         [Chromium] Fixed layout mode tests break subsequent tests
710         https://bugs.webkit.org/show_bug.cgi?id=68923
711         
712         Reviewed by Adam Barth.        
713
714         Reset fixed layout mode between tests, so that tests that run after
715         platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
716         regular 800x600 non-fixed layout.
717
718         * DumpRenderTree/chromium/TestShell.cpp:
719         (TestShell::resetTestController):
720
721 2011-09-27  David Levin  <levin@chromium.org>
722
723         watchlist: Add the filename pattern for definitions.
724         https://bugs.webkit.org/show_bug.cgi?id=68917
725
726         Reviewed by Adam Barth.
727
728         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
729         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
730         * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
731         for definitions.
732         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
733         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
734
735 2011-09-27  Adam Barth  <abarth@webkit.org>
736
737         garden-o-matic results view should sort test and builder names
738         https://bugs.webkit.org/show_bug.cgi?id=68488
739
740         Reviewed by Andy Estes.
741
742         Previously, the test and builder names were displayed in an arbitrary
743         order that changed from time to time.  That confused one user study
744         participant.  This patch sorts the lists so that they occur in a
745         predictable order.
746
747         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
748
749 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
750
751         Unreviewed, rolling out r96108, r96111, r96113, and r96116.
752         http://trac.webkit.org/changeset/96108
753         http://trac.webkit.org/changeset/96111
754         http://trac.webkit.org/changeset/96113
755         http://trac.webkit.org/changeset/96116
756         https://bugs.webkit.org/show_bug.cgi?id=68913
757
758         Wait for working Qt5 (Requested by ossy on #webkit).
759
760         * DumpRenderTree/qt/DumpRenderTree.pro:
761         * DumpRenderTree/qt/ImageDiff.pro:
762         * MiniBrowser/qt/BrowserView.cpp:
763         (BrowserView::BrowserView):
764         * MiniBrowser/qt/BrowserView.h:
765         * MiniBrowser/qt/BrowserWindow.cpp:
766         (BrowserWindow::BrowserWindow):
767         (BrowserWindow::urlChanged):
768         (BrowserWindow::~BrowserWindow):
769         * MiniBrowser/qt/BrowserWindow.h:
770         * MiniBrowser/qt/MiniBrowser.pro:
771         * MiniBrowser/qt/MiniBrowserApplication.h:
772         * MiniBrowser/qt/main.cpp:
773         * QtTestBrowser/QtTestBrowser.pro:
774         * QtTestBrowser/launcherwindow.cpp:
775         * QtTestBrowser/launcherwindow.h:
776         * QtTestBrowser/locationedit.h:
777         * QtTestBrowser/main.cpp:
778         * QtTestBrowser/mainwindow.cpp:
779         * QtTestBrowser/mainwindow.h:
780         * QtTestBrowser/webinspector.h:
781         * QtTestBrowser/webpage.cpp:
782         * QtTestBrowser/webview.cpp:
783         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
784         * WebKitTestRunner/PlatformWebView.h:
785         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
786         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
787         (WTR::WebView::wkView):
788         (WTR::WebView::pageRef):
789         (WTR::WebView::~WebView):
790         (WTR::WebView::WebView):
791         (WTR::PlatformWebView::PlatformWebView):
792         (WTR::PlatformWebView::sendEvent):
793         (WTR::PlatformWebView::postEvent):
794         * WebKitTestRunner/qt/WebKitTestRunner.pro:
795
796 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
797
798         [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
799         https://bugs.webkit.org/show_bug.cgi?id=65178
800
801         Reviewed by Martin Robinson.
802
803         * GNUmakefile.am:
804         * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
805
806 2011-09-27  Csaba Osztrogonác  <ossy@webkit.org>
807
808         [Qt][WK2] Buildfix after r96108.
809
810         Rubber-stamped by Andreas Kling.
811
812         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
813         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
814         * WebKitTestRunner/qt/WebKitTestRunner.pro:
815
816 2011-09-27  David Levin  <levin@chromium.org>
817
818         watchlist: Change watchlistparser.py to be class based.
819         https://bugs.webkit.org/show_bug.cgi?id=68869
820
821         Reviewed by Eric Seidel.
822
823         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
824         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
825
826 2011-09-27  David Levin  <levin@chromium.org>
827
828         watchlist: Break out the diff boilerplate to allow for re-use.
829         https://bugs.webkit.org/show_bug.cgi?id=68871
830
831         Reviewed by Eric Seidel.
832
833         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
834         Break out the diff into a new file.
835         * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
836
837 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
838
839         Web Inspector: UI performance: introduce heap size tracking stats.
840         https://bugs.webkit.org/show_bug.cgi?id=68901
841
842         It is interesting how much the heap memory is used by Inspector in order of running the test.
843
844         Reviewed by Yury Semikhatsky.
845
846         * DumpRenderTree/chromium/TestShell.cpp:
847         (TestShell::showDevTools):
848         (TestShell::closeDevTools):
849
850 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
851
852         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
853
854         QWidget and friends now live in the QtWidgets library. We update
855         includes in implementation files and private headers to us the
856         non-module-prefixed path, and leave the lookup for the include
857         path. For public headers we have to ifdef the includes as the
858         user might now have the modules we need in his QT config.
859
860         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
861         have to update our code and use windowHandle() for setting the
862         parent relationships.
863
864         https://bugs.webkit.org/show_bug.cgi?id=68687
865
866         Reviewed by Andreas Kling.
867
868         * DumpRenderTree/qt/DumpRenderTree.pro:
869         * DumpRenderTree/qt/ImageDiff.pro:
870         * MiniBrowser/qt/BrowserView.cpp:
871         * MiniBrowser/qt/BrowserView.h:
872         * MiniBrowser/qt/BrowserWindow.cpp:
873         * MiniBrowser/qt/BrowserWindow.h:
874         * MiniBrowser/qt/MiniBrowser.pro:
875         * MiniBrowser/qt/MiniBrowserApplication.h:
876         * MiniBrowser/qt/main.cpp:
877         * QtTestBrowser/QtTestBrowser.pro:
878         * QtTestBrowser/launcherwindow.cpp:
879         * QtTestBrowser/launcherwindow.h:
880         * QtTestBrowser/locationedit.h:
881         * QtTestBrowser/main.cpp:
882         * QtTestBrowser/mainwindow.cpp:
883         * QtTestBrowser/mainwindow.h:
884         * QtTestBrowser/webinspector.h:
885         * QtTestBrowser/webpage.cpp:
886         * QtTestBrowser/webview.cpp:
887         * WebKitTestRunner/PlatformWebView.h:
888         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
889
890 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
891
892         [Qt][WK2] Add support for hover API in Qt WebKit2
893         https://bugs.webkit.org/show_bug.cgi?id=68369
894
895         Reviewed by Andreas Kling.
896
897         Change the statusbar to show the link URL when hovering links in
898         MiniBrowser using QDesktopWebView.
899
900         * MiniBrowser/qt/BrowserWindow.cpp:
901         (BrowserWindow::BrowserWindow):
902         (BrowserWindow::onLinkHovered):
903         * MiniBrowser/qt/BrowserWindow.h:
904
905 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
906
907         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
908         https://bugs.webkit.org/show_bug.cgi?id=68864
909
910         Reviewed by Adam Barth.
911
912         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
913         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
914         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
915         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
916
917 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
918
919         [Qt][WK2] One more unreviewed buildfix after r96005.
920
921         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
922
923 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
924
925         [Qt][WK2] Unreviewed buildfix after r96005.
926
927         * WebKitTestRunner/qt/TestInvocationQt.cpp:
928         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
929
930 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
931
932         garden-o-matic should be pretty in Open Sans.
933         https://bugs.webkit.org/show_bug.cgi?id=68845
934
935         Reviewed by Adam Barth.
936
937         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
938
939 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
940
941         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
942         https://bugs.webkit.org/show_bug.cgi?id=68841
943
944         Reviewed by Adam Barth.
945
946         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
949
950 2011-09-26  David Levin  <levin@chromium.org>
951
952         watchlist: Add parsing for definition section.
953         https://bugs.webkit.org/show_bug.cgi?id=68850
954
955         Reviewed by Adam Barth.
956
957         * Scripts/webkitpy/common/watchlist/watchlist.py:
958         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
959         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
960
961 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
962
963         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
964
965         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
966         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
967         * WebKitTestRunner/win/TestInvocationWin.cpp:
968         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
969
970 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
971
972         Repaint tests don't work in WebKit2
973         https://bugs.webkit.org/show_bug.cgi?id=68453
974
975         Reviewed by Sam Weinig.
976         
977         Convert DumpRenderTree to use use the repaint rects
978         exposed via WebKit API when generating the repaint test
979         overlay.
980         
981         Fix WebKitTestRunner to work with repaint tests, again
982         using the repaint rects exposed from WK2.
983         
984         In both cases, layoutTestController.display() now just
985         forces a display of the web view, and turns on repaint
986         rect tracking on the main FrameView.
987         
988         Later, when pixel results are requested, the alpha overlay
989         that shows the repaint rects is generated using the list
990         of rects supplied by WebCore.
991
992         * DumpRenderTree/mac/DumpRenderTree.mm:
993         (resetDefaultsToConsistentValues):
994         (resetWebViewToConsistentStateBeforeTesting):
995         (displayWebView):
996         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
997         (paintRepaintRectOverlay):
998         (createBitmapContextFromWebView):
999         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1000         (WTR::InjectedBundle::beginTesting):
1001         (WTR::InjectedBundle::done):
1002         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1003         (WTR::InjectedBundle::setRepaintRects):
1004         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1005         (WTR::InjectedBundlePage::reset):
1006         (WTR::InjectedBundlePage::dump):
1007         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1008         (WTR::LayoutTestController::display):
1009         * WebKitTestRunner/TestInvocation.cpp:
1010         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1011         * WebKitTestRunner/TestInvocation.h:
1012         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1013         (WTR::paintRepaintRectOverlay):
1014         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1015
1016 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
1017
1018         Get hover'ed element URL from HitTest.
1019
1020         mouseDidMoveOverElement now gets the hover'ed element link using
1021         WKHitTestResult API's.
1022         https://bugs.webkit.org/show_bug.cgi?id=68426 
1023
1024         Reviewed by Anders Carlsson.
1025
1026         * MiniBrowser/gtk/BrowserWindow.c:
1027         (mouseDidMoveOverElement):
1028
1029 2011-09-26  David Levin  <levin@chromium.org>
1030
1031         Add skeleton parsing for a WatchList.
1032         https://bugs.webkit.org/show_bug.cgi?id=68823
1033
1034         Reviewed by Adam Barth.
1035
1036         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
1037         Parses the top level watch list sections -- none are defined yet -- and
1038         throws an exception if an invalid one is listed.
1039         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
1040         Verify the exception for an invalid section in a watch list.
1041         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
1042
1043 2011-09-26  Adam Roben  <aroben@apple.com>
1044
1045         Clean up code imported from WebKitAPITest
1046
1047         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
1048         TestWebKitAPI conventions
1049
1050         Reviewed by David Levin.
1051
1052         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
1053         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
1054         namespace name.
1055
1056         (TestWebKitAPI::WebViewDestruction::SetUp):
1057         (TestWebKitAPI::WebViewDestruction::webViewCount):
1058         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
1059         (TestWebKitAPI::WebViewDestruction::runMessagePump):
1060         (TestWebKitAPI::WebViewDestruction::TearDown):
1061         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
1062         Moved functionality from free functions into these new test fixtures.
1063
1064         * TestWebKitAPI/win/HostWindow.cpp:
1065         * TestWebKitAPI/win/HostWindow.h:
1066         Prefixed Win32 API calls with ::. Updated namespace name.
1067
1068 2011-09-23  Adam Roben  <aroben@apple.com>
1069
1070         Merge WebKitAPITest into TestWebKitAPI
1071
1072         This also means that our formerly-WebKitAPITest tests will be run on the bots!
1073
1074         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
1075         them more idiomatic in a separate pass.
1076
1077         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
1078         functionality (and names!)
1079
1080         Reviewed by Anders Carlsson.
1081
1082         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
1083         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
1084         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
1085
1086         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
1087
1088         * TestWebKitAPI/win/main.cpp:
1089         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
1090
1091         * WebKitAPITest: Removed this directory and its contents.
1092
1093 2011-09-23  Adam Roben  <aroben@apple.com>
1094
1095         Remove two failing WebKitAPITest tests
1096
1097         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
1098
1099         Reviewed by Anders Carlsson.
1100
1101         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
1102         MainFrameAfterClose tests.
1103
1104 2011-09-25  Adam Barth  <abarth@webkit.org>
1105
1106         Finish removing PLATFORM(BREWMP) by removing associated code
1107         https://bugs.webkit.org/show_bug.cgi?id=68779
1108
1109         Reviewed by Sam Weinig.
1110
1111         * Scripts/webkitpy/common/config/build.py:
1112         * waf/build/settings.py:
1113
1114 2011-09-21  Ai Makabi  <makabi@google.com>
1115
1116         Provides a simple LRU cache class in Python.
1117
1118         https://bugs.webkit.org/show_bug.cgi?id=67823
1119
1120         Reviewed by Tony Chang.
1121
1122         * Scripts/webkitpy/common/lru_cache.py:
1123         * Scripts/webkitpy/common/lru_cache_unittest.py:
1124
1125 2011-09-25  Adam Barth  <abarth@webkit.org>
1126
1127         Remove PLATFORM(HAIKU) and associated code
1128         https://bugs.webkit.org/show_bug.cgi?id=68774
1129
1130         Reviewed by Sam Weinig.
1131
1132         * Scripts/webkitpy/common/config/build.py:
1133         * waf/build/settings.py:
1134
1135 2011-09-24  Adam Barth  <abarth@webkit.org>
1136
1137         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
1138         https://bugs.webkit.org/show_bug.cgi?id=68767
1139
1140         Reviewed by Eric Seidel.
1141
1142         * Scripts/build-webkit:
1143
1144 2011-09-24  Adam Barth  <abarth@webkit.org>
1145
1146         Remove ENABLE(WCSS) and associated code
1147         https://bugs.webkit.org/show_bug.cgi?id=68759
1148
1149         Reviewed by Darin Adler.
1150
1151         * Scripts/build-webkit:
1152         * Scripts/old-run-webkit-tests:
1153         * Scripts/webkitperl/features.pm:
1154         (hasFeature):
1155         * Scripts/webkitpy/layout_tests/port/webkit.py:
1156         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1157
1158 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
1159
1160         Fixed GTK compilation after r95878, the operator== was defined
1161         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
1162
1163         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1164
1165 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
1166
1167         [DRT] Include the right config file for EFL's DRT.
1168         https://bugs.webkit.org/show_bug.cgi?id=67042
1169
1170         Reviewed by Martin Robinson.
1171
1172         Ports which use CMake as their buildsystem (such as the EFL one) also
1173         have config.h files, but they are named differently, so include the
1174         right one depending on the buildsystem being used.
1175
1176         * DumpRenderTree/config.h:
1177
1178 2011-09-23  Adam Klein  <adamk@chromium.org>
1179
1180         Add ENABLE_MUTATION_OBSERVERS feature flag
1181         https://bugs.webkit.org/show_bug.cgi?id=68732
1182
1183         Reviewed by Ojan Vafai.
1184
1185         This flag will guard an implementation of the "Mutation Observers" proposed in
1186         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
1187
1188         * Scripts/build-webkit:
1189
1190 2011-09-23  Chang Shu  <cshu@webkit.org>
1191
1192         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1193         https://bugs.webkit.org/show_bug.cgi?id=68556
1194
1195         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
1196
1197         Reviewed by Darin Adler.
1198
1199         * WebKitTestRunner/EventSenderProxy.h:
1200         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1201         * WebKitTestRunner/PlatformWebView.h:
1202         * WebKitTestRunner/mac/EventSenderProxy.mm:
1203         (WTR::EventSenderProxy::EventSenderProxy):
1204         (WTR::EventSenderProxy::leapForward):
1205         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1206         (WTR::EventSenderProxy::EventSenderProxy):
1207         (WTR::getMouseButton):
1208         (WTR::getModifiers):
1209         (WTR::EventSenderProxy::updateClickCountForButton):
1210         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
1211         (WTR::EventSenderProxy::mouseDown):
1212         (WTR::EventSenderProxy::mouseUp):
1213         (WTR::EventSenderProxy::mouseMoveTo):
1214         (WTR::EventSenderProxy::leapForward):
1215         (WTR::EventSenderProxy::sendOrQueueEvent):
1216         (WTR::EventSenderProxy::replaySavedEvents):
1217         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1218         (WTR::PlatformWebView::postEvent):
1219         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1220
1221 2011-09-23  Lei Zhang  <thestig@chromium.org>
1222
1223         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
1224         https://bugs.webkit.org/show_bug.cgi?id=68026
1225
1226         Reviewed by Dirk Pranke.
1227
1228         * Scripts/webkitpy/layout_tests/port/chromium.py:
1229
1230 2011-09-23  Elliot Poger  <epoger@google.com>
1231
1232         update layout_tests to account for new default of use_skia=1
1233         https://bugs.webkit.org/show_bug.cgi?id=68698
1234
1235         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
1236         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
1237         (Chromium-on-Mac now uses the Skia graphics library instead of
1238         Core Graphics).
1239
1240         Also updates layout_test code to work with that change.
1241
1242         Reviewed by Mihai Parparita.
1243
1244         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1245         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1246
1247 2011-09-23  Mark Rowe  <mrowe@apple.com>
1248
1249         Fix the build.
1250         
1251         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
1252         the WTF namespace.
1253
1254 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
1255
1256         enable NRWT for run-webkit-tests on Lion
1257         https://bugs.webkit.org/show_bug.cgi?id=68673
1258
1259         Reviewed by Eric Seidel.
1260
1261         * Scripts/run-webkit-tests:
1262         (useNewRunWebKitTests):
1263
1264 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1265
1266         Add unit test for existing StringBuilder
1267         https://bugs.webkit.org/show_bug.cgi?id=67080
1268
1269         Reviewed by Darin Adler.
1270
1271         * TestWebKitAPI/TestWebKitAPI.gypi:
1272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1273         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
1274         (operator<<):
1275         (TestWebKitAPI::expectBuilderContent):
1276         (TestWebKitAPI::expectEmpty):
1277         (TestWebKitAPI::TEST):
1278
1279 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
1280
1281         [EFL] Use ewk_view to navigate in history instead of ewk_history.
1282         https://bugs.webkit.org/show_bug.cgi?id=68455
1283
1284         Reviewed by Antonio Gomes.
1285
1286         BackForwardItem::invoke() was using ewk_history functions to navigate
1287         in history; however, this will only call WebCore::BackForwardListImpl
1288         and not move between pages at all. We now call ewk_view_navigate and
1289         its siblings to make sure the navigation actually happens.
1290
1291         This should make tests like fast/dom/navigation-type-back-forward.html
1292         stop timing out.
1293
1294         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1295         (BackForwardItem::invoke):
1296
1297 2011-09-22  Dean Jackson  <dino@apple.com>
1298
1299         Add ENABLE_CSS_FILTERS
1300         https://bugs.webkit.org/show_bug.cgi?id=68652
1301
1302         Reviewed by Simon Fraser.
1303
1304         * Scripts/build-webkit:
1305
1306 2011-09-22  Anders Carlsson  <andersca@apple.com>
1307
1308         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
1309         https://bugs.webkit.org/show_bug.cgi?id=68660
1310
1311         Reviewed by Adam Barth.
1312
1313         * WebKitTestRunner/mac/EventSenderProxy.mm:
1314         (WTR::EventSenderProxy::mouseUp):
1315
1316 2011-09-22  Adam Roben  <aroben@apple.com>
1317
1318         Remove FindSafari
1319
1320         It isn't used or built anymore.
1321
1322         Fixes <http://webkit.org/b/68628>
1323
1324         Reviewed by Darin Adler.
1325
1326         * FindSafari: Removed this directory and its contents.
1327
1328 2011-09-22  Adam Roben  <aroben@apple.com>
1329
1330         Remove FindSafari from all our .sln files
1331
1332         It isn't used anymore, so there's no point in building it.
1333
1334         Part of <http://webkit.org/b/68628> Remove FindSafari
1335
1336         Reviewed by Steve Falkenburg.
1337
1338         * DumpRenderTree/DumpRenderTree.sln:
1339         * WebKitTestRunner/WebKitTestRunner.sln:
1340
1341 2011-09-22  Adam Roben  <aroben@apple.com>
1342
1343         Remove all uses of FindSafari
1344
1345         It isn't really needed anymore.
1346
1347         Fixes <http://webkit.org/b/68626>.
1348
1349         Reviewed by Darin Adler.
1350
1351         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
1352
1353         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
1354         WebKit, but now we use WebKit.exe for that.
1355
1356         * Scripts/webkitdirs.pm:
1357         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
1358         do the same thing.
1359
1360         (readRegistryString):
1361         (writeRegistryString):
1362         Moved here from old-run-webkit-tests.
1363
1364 2011-09-22  Adam Roben  <aroben@apple.com>
1365
1366         Use the "direct object" form of system() to run WebKit.exe
1367
1368         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
1369         path to WebKit.exe.
1370
1371         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
1372         %WEBKITOUTPUTDIR%
1373
1374         Reviewed by Steve Falkenburg.
1375
1376         * Scripts/webkitdirs.pm:
1377         (runSafari):
1378
1379 2011-09-22  Adam Roben  <aroben@apple.com>
1380
1381         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
1382
1383         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
1384         spaces in the path to the WebKit source tree
1385
1386         Reviewed by John Sullivan.
1387
1388         * Scripts/webkitdirs.pm:
1389         (setupCygwinEnv):
1390
1391 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1392
1393         [Qt] Use same DPI for application font as rest of app in DRT and WTR
1394
1395         QApplication will initialize the default application font based
1396         on the application DPI at construction time, but we then override
1397         the application DPI using QX11Info (hard-coding it to 96 for
1398         consistency). This hard-coding is not reflected in the application
1399         font, so we explicitly have update the font ourselves.
1400
1401         The 6 test results that are updated were originally produced with
1402         a DPI of 75, as this is the default fallback DPI when a QFont is
1403         constructed before QApplication. This was wrong, and the results
1404         are updated to match a DPI of 96.
1405
1406         Reviewed by Csaba Osztrogonác.
1407
1408         * DumpRenderTree/qt/main.cpp:
1409         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1410
1411 2011-09-21  Anna Cavender  <annacc@chromium.org>
1412
1413         Update committers.py with a new contributor contact        
1414         https://bugs.webkit.org/show_bug.cgi?id=68565
1415
1416         Reviewed by Eric Carlson.
1417
1418         * Scripts/webkitpy/common/config/committers.py:
1419
1420 2011-09-21  Chang Shu  <cshu@webkit.org>
1421
1422         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1423         https://bugs.webkit.org/show_bug.cgi?id=68108
1424
1425         This patch implements the event sender mouse events through WebKit2 UIProcess which is
1426         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
1427         platform as the first step so the existing code is still kept for other platforms.
1428
1429         Reviewed by Darin Adler.
1430
1431         * WebKitTestRunner/EventSenderProxy.h:
1432         (WTR::EventSenderProxy::EventSenderProxy):
1433         (WTR::EventSenderProxy::leapForward):
1434         (WTR::EventSenderProxy::currentEventTime):
1435         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1436         (WTR::EventSendingController::EventSendingController):
1437         (WTR::EventSendingController::mouseDown):
1438         (WTR::EventSendingController::mouseUp):
1439         (WTR::EventSendingController::mouseMoveTo):
1440         (WTR::EventSendingController::leapForward):
1441         (WTR::EventSendingController::keyDown):
1442         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1443         * WebKitTestRunner/TestController.cpp:
1444         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1445         * WebKitTestRunner/mac/EventSenderProxy.mm:
1446         (WTR::eventTypeForMouseButtonAndAction):
1447         (WTR::operator==):
1448         (WTR::EventSenderProxy::updateClickCountForButton):
1449         (WTR::EventSenderProxy::mouseDown):
1450         (WTR::EventSenderProxy::mouseUp):
1451         (WTR::EventSenderProxy::mouseMoveTo):
1452         (WTR::EventSenderProxy::keyDown):
1453         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1454         (WTR::EventSenderProxy::keyDown):
1455         (WTR::EventSenderProxy::mouseDown):
1456         (WTR::EventSenderProxy::mouseUp):
1457         (WTR::EventSenderProxy::mouseMoveTo):
1458
1459 2011-09-21  Dan Bernstein  <mitz@apple.com>
1460
1461         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
1462         https://bugs.webkit.org/show_bug.cgi?id=68451
1463
1464         Reviewed by Darin Adler.
1465
1466         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
1467         Objective-C classes with names not having one of a list of prefixes
1468         passed on the command line.
1469
1470 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
1471
1472         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
1473         https://bugs.webkit.org/show_bug.cgi?id=68206
1474
1475         Reviewed by Tony Chang.
1476
1477         * Scripts/webkitdirs.pm:
1478         (determineBaseProductDir): add support for chromium-mac
1479         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1480         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1481
1482 2011-09-21  Adam Barth  <abarth@webkit.org>
1483
1484         garden-o-matic command should explain that it is starting a local server
1485         https://bugs.webkit.org/show_bug.cgi?id=68486
1486
1487         Reviewed by Dimitri Glazkov.
1488
1489         In the user study, both participants didn't understand why the
1490         garden-o-matic command appeared to hang.  This patch adds an
1491         explaination of what's going on.  It also adds a confirmation prompt
1492         before launching the browser to give the user a chance to read the
1493         text.  If that's too much of a speed bump, we can iterate.
1494
1495         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1496
1497 2011-09-21  Chang Shu  <cshu@webkit.org>
1498
1499         [Qt] Implement KeyDown function for WebKit2 EventSender.
1500         https://bugs.webkit.org/show_bug.cgi?id=56485
1501
1502         Implement the KeyDown function on Qt platform.
1503
1504         Reviewed by Andreas Kling.
1505
1506         * WebKitTestRunner/PlatformWebView.h:
1507         * WebKitTestRunner/TestController.cpp:
1508         (WTR::TestController::TestController):
1509         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1510         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
1511         (WTR::getModifiers):
1512         (WTR::EventSenderProxy::keyDown):
1513         (buildModifierFlags):
1514         (EventSenderProxy::keyDown):
1515         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1516         (WTR::PlatformWebView::sendEvent):
1517         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1518
1519 2011-09-20  Adam Barth  <abarth@webkit.org>
1520
1521         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
1522         https://bugs.webkit.org/show_bug.cgi?id=68496
1523
1524         Reviewed by Dimitri Glazkov.
1525
1526         This patch adds a bunch of sorting to make sure things happen in a
1527         predictable order in both JavaScriptCore and V8.  We've talked before
1528         about whether these two JavaScript engines should enumerate
1529         dictionaries in the same order, but the consensus has been that they
1530         shouldn't.  Personally, I disagree with that consensus, but such is life.
1531
1532         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1533         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1535         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1536
1537 2011-09-20  Adam Barth  <abarth@webkit.org>
1538
1539         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
1540         https://bugs.webkit.org/show_bug.cgi?id=68495
1541
1542         Reviewed by Dimitri Glazkov.
1543
1544         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
1545
1546         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1547
1548 2011-09-20  Eric Seidel  <eric@webkit.org>
1549
1550         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
1551         https://bugs.webkit.org/show_bug.cgi?id=65781
1552
1553         Reviewed by Ryosuke Niwa.
1554
1555         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
1556         to resolve the passed in url relative to the absolute url for the test.
1557         For http tests, since the test url is an http url, we can't resolve relative
1558         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
1559         for resolving.
1560
1561         I believe this is a better approach than the on used in the Qt and Chromium DRT's
1562         (which resolves the path relative to the built location of the DRT executable)
1563         and we should move this new code into a shared location in a follow-up patch.
1564
1565         It turns out that there was a second use for pathToLocalResource, used by one
1566         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
1567         To support this test I made the new pathToLocalResource smart enough to map
1568         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
1569
1570         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1571         (LayoutTestController::pathToLocalResource):
1572         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
1573
1574 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1575
1576         Need to specify a django version, instead of using default
1577         https://bugs.webkit.org/show_bug.cgi?id=68398
1578
1579         Reviewed by Eric Seidel.
1580
1581         * QueueStatusServer/__init__.py:
1582         * QueueStatusServer/main.py:
1583
1584 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1585
1586         Update committers.py with a few more contributor contacts
1587         https://bugs.webkit.org/show_bug.cgi?id=68487
1588
1589         Reviewed by Eric Seidel.
1590
1591         * Scripts/webkitpy/common/config/committers.py:
1592
1593 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1594
1595         Fix webkitpy unit tests after 95547 and 95549
1596         https://bugs.webkit.org/show_bug.cgi?id=68483
1597
1598         Reviewed by Adam Barth.
1599         
1600         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
1601
1602         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
1603         parse_entries_from_file(), use StringIO and entry.reviewer_text().
1604         While testing parse_latest_entry_from_file(), expect the correct
1605         touched_files() list.
1606
1607 2011-09-20  Adam Barth  <abarth@webkit.org>
1608
1609         garden-o-matic makes it hard to compare images when scroll bars appear
1610         https://bugs.webkit.org/show_bug.cgi?id=68482
1611
1612         Reviewed by Eric Seidel.
1613
1614         Because we autoscale image width, the images rescale if we overflow
1615         vertically and get a scrollbar.  That makes it hard to compare two sets
1616         of images.  This patch reserves space for the scrollbar so we won't
1617         have the layout change.
1618
1619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1620
1621 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1622
1623         Unreviewed, rolling out r95565.
1624         http://trac.webkit.org/changeset/95565
1625         https://bugs.webkit.org/show_bug.cgi?id=68470
1626
1627         Broke builds (Requested by andersca on #webkit).
1628
1629         * MiniBrowser/gtk/BrowserWindow.c:
1630         (mouseDidMoveOverElement):
1631
1632 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
1633
1634         Get hover'ed element URL from HitTest.
1635         
1636         mouseDidMoveOverElement now gets the hover'ed element link using
1637         WKHitTestResult API's.
1638         https://bugs.webkit.org/show_bug.cgi?id=68426
1639
1640         Reviewed by Anders Carlsson.
1641
1642         * MiniBrowser/gtk/BrowserWindow.c:
1643         (mouseDidMoveOverElement):
1644
1645 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1646
1647         Changelog class should have a method to return all entries
1648         https://bugs.webkit.org/show_bug.cgi?id=68399
1649         
1650         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
1651         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
1652
1653         Reviewed by Ryosuke Niwa.
1654
1655         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
1656         and adapt it to become a generator.
1657         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
1658
1659 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
1660
1661         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
1662         https://bugs.webkit.org/show_bug.cgi?id=51159
1663
1664         Permit any URL with a local scheme to set a user style sheet. Allow qrc
1665         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
1666         
1667         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
1668
1669         Reviewed by Kenneth Rohde Christiansen.
1670
1671         * DumpRenderTree/qt/DumpRenderTree.pro:
1672         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
1673         * DumpRenderTree/qt/resources/user.css: Added.
1674         (body):
1675         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1676         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
1677         * WebKitTestRunner/qt/resources/user.css: Added.
1678         (body):
1679
1680 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1681
1682         ChangeLogEntry class should contain a list of touched files
1683         https://bugs.webkit.org/show_bug.cgi?id=68115
1684
1685         Reviewed by Eric Seidel.
1686         
1687         Add method to return the list of files touched in a ChangeLog entry.
1688
1689         * Scripts/webkitpy/common/checkout/changelog.py: Add
1690         touched_files_regexp and touched_files() method.
1691         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
1692         unit tests for touched_files() method.
1693
1694 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1695
1696         Unreviewed, rolling out r95526 and r95541.
1697         http://trac.webkit.org/changeset/95526
1698         http://trac.webkit.org/changeset/95541
1699         https://bugs.webkit.org/show_bug.cgi?id=68443
1700
1701         It broke 6 tests (Requested by ossy_ on #webkit).
1702
1703         * DumpRenderTree/qt/main.cpp:
1704         (main):
1705         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1706         (WTR::activateFonts):
1707
1708 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1709
1710         Fix patch and bug numbering in the mocktool simulation code
1711         https://bugs.webkit.org/show_bug.cgi?id=68374
1712
1713         Reviewed by Adam Barth.
1714
1715         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1716         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1717         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1718         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1719         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1720         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1721         * Scripts/webkitpy/tool/commands/download_unittest.py:
1722         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1723         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1724         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1725         * Scripts/webkitpy/tool/commands/queuestest.py:
1726         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1727         * Scripts/webkitpy/tool/mocktool.py:
1728         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1729         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1730
1731 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1732
1733         [Qt] Don't override default QApplication font for DRT and WTR
1734
1735         Revision 95526 moved the relevant code below the QApplication
1736         constructor, to fix a potential crash, and that made the code
1737         take effect, breaking 6 tests.
1738
1739         We should rely on the QWebSettings to set default fonts, and
1740         this QApplication::setFont() is a relic from when we didn't
1741         have that option, so we remove the code.
1742
1743         Reviewed by Csaba Osztrogonác.
1744
1745         * DumpRenderTree/qt/main.cpp:
1746         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1747
1748 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1749
1750         WebKitTestRunner: Provide usage if run without arguments
1751
1752         If WTR is run without either one or more filenames, or
1753         a '-' to indicate server mode, we don't need to start
1754         up the test machinery. Doing so might actually crash,
1755         as we'll exit the application immedeatly after anyways.
1756
1757         Reviewed by Simon Hausmann.
1758
1759         * WebKitTestRunner/TestController.cpp:
1760         (WTR::TestController::initialize):
1761
1762 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1763
1764         [Qt] Don't use QFont before initializing QApplication
1765
1766         Could potentially result in crash.
1767
1768         Reviewed by Simon Hausmann.
1769
1770         * DumpRenderTree/qt/main.cpp:
1771         (main):
1772
1773 2011-09-19  Adam Barth  <abarth@webkit.org>
1774
1775         Always enable ENABLE(EVENTSOURCE)
1776         https://bugs.webkit.org/show_bug.cgi?id=68414
1777
1778         Reviewed by Eric Seidel.
1779
1780         * Scripts/build-webkit:
1781
1782 2011-09-19  David Levin  <levin@chromium.org>
1783
1784         Sheriffbot rollout should be more intuitive.
1785         https://bugs.webkit.org/show_bug.cgi?id=68415
1786
1787         Reviewed by Adam Barth.
1788
1789         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
1790         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
1791           and a few others cases.
1792         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
1793
1794 2011-09-19  David Levin  <levin@chromium.org>
1795
1796         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
1797         https://bugs.webkit.org/show_bug.cgi?id=68391
1798
1799         Reviewed by Darin Adler.
1800
1801         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
1802         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
1803
1804 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
1805
1806         Style checker should not check public Qt WK2 API for parameter_name.
1807         https://bugs.webkit.org/show_bug.cgi?id=68359
1808
1809         Reviewed by Andreas Kling.
1810
1811         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
1812         Add an exception in the style checker to disable the check. Also added the test for it.
1813
1814         * Scripts/webkitpy/style/checker.py:
1815         * Scripts/webkitpy/style/checker_unittest.py:
1816
1817 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
1818
1819         GTK DRT leaks memory while comparing history items
1820         https://bugs.webkit.org/show_bug.cgi?id=68086
1821
1822         Reviewed by Martin Robinson.
1823         
1824         webkit_web_history_item_get_target() returns a g_strdup()'d string,
1825         so memory must be freed before compareHistoryItems() returns.
1826
1827         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1828         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
1829
1830 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1831
1832         Buildbot marks a nrwt bot red when tests are missing results
1833         https://bugs.webkit.org/show_bug.cgi?id=64812
1834
1835         Reviewed by Ryosuke Niwa.
1836
1837         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1838         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1839
1840 2011-09-19  Jessie Berlin  <jberlin@apple.com>
1841
1842         Sites that use history pushState or replaceState are recorded in history in Private Browsing
1843         mode.
1844         https://bugs.webkit.org/show_bug.cgi?id=68208
1845
1846         Reviewed by Brady Eidson.
1847
1848         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
1849         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
1850
1851         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
1852         (TestWebKitAPI::didNavigateWithNavigationData):
1853         This is a context history client callback, so it should not be called when in Private
1854         Browsing. Add a call to FAIL().
1855         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1856         This is a page load client callback that happens after the didNavigateWithNavigationData
1857         callback. End the test.
1858         (TestWebKitAPI::TEST):
1859         Enable Private Browsing and load a page that uses history.pushState.
1860
1861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1862         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
1863         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
1864         Ditto.
1865         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1866         Ditto.
1867         * TestWebKitAPI/win/copy-resources.cmd:
1868         Ditto.
1869
1870 2011-09-16  Elliot Poger  <epoger@google.com>
1871
1872         add non-CG Webkit-Mac builds to flakiness dashboard
1873         https://bugs.webkit.org/show_bug.cgi?id=68265
1874
1875         Reviewed by Adam Barth.
1876
1877         As Chromium-on-Mac approaches the switchover from Core Graphics to
1878         Skia, we need to add the Skia version to the flakiness dashboard.
1879
1880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1881         * TestResultServer/static-dashboards/builders.js:
1882         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1883
1884 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
1885
1886         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
1887         https://bugs.webkit.org/show_bug.cgi?id=68071
1888
1889         Reviewed by Adam Barth.
1890
1891         * DumpRenderTree/chromium/WebPermissions.cpp:
1892         (WebPermissions::allowImage):
1893         * DumpRenderTree/chromium/WebPermissions.h:
1894
1895 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
1896
1897         update-webkit-chromium should retry the gclient call if it fails once
1898         https://bugs.webkit.org/show_bug.cgi?id=68252
1899
1900         Reviewed by Adam Barth.
1901
1902         * Scripts/update-webkit-chromium:
1903
1904 2011-09-16  Rob Buis  <rbuis@rim.com>
1905
1906         Add Eli's rim address and change the nick.
1907
1908         * Scripts/webkitpy/common/config/committers.py:
1909
1910 2011-09-16  Anders Carlsson  <andersca@apple.com>
1911
1912         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
1913         https://bugs.webkit.org/show_bug.cgi?id=68269
1914
1915         Reviewed by Geoffrey Garen.
1916
1917         Update client function signatures.
1918
1919         * MiniBrowser/gtk/BrowserWindow.c:
1920         (browserWindowUIClientInit):
1921         * MiniBrowser/mac/BrowserWindowController.m:
1922         (mouseDidMoveOverElement):
1923         (-[BrowserWindowController awakeFromNib]):
1924         * MiniBrowser/win/BrowserView.cpp:
1925         (BrowserView::create):
1926         * WebKitTestRunner/TestController.cpp:
1927         (WTR::TestController::createOtherPage):
1928         (WTR::TestController::initialize):
1929
1930 2011-09-16  Anders Carlsson  <andersca@apple.com>
1931
1932         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
1933         https://bugs.webkit.org/show_bug.cgi?id=68266
1934
1935         Reviewed by John Sullivan.
1936
1937         * MiniBrowser/mac/BrowserWindowController.m:
1938         (mouseDidMoveOverElement):
1939
1940 2011-09-16  Vincent Scheib  <scheib@chromium.org>
1941
1942         Add Vincent Scheib to the committers list.
1943
1944         * Scripts/webkitpy/common/config/committers.py:
1945
1946 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1947
1948         Unreviewed, rolling out r95285.
1949         http://trac.webkit.org/changeset/95285
1950         https://bugs.webkit.org/show_bug.cgi?id=68247
1951
1952         It broke a webkitpy test (Requested by ossy on #webkit).
1953
1954         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1955
1956 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1957
1958         Buildbot marks a nrwt bot red when tests are missing results
1959         https://bugs.webkit.org/show_bug.cgi?id=64812
1960
1961         Reviewed by Dirk Pranke.
1962
1963         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1964
1965 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
1966
1967         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
1968         https://bugs.webkit.org/show_bug.cgi?id=68178
1969
1970         Reviewed by Xan Lopez.
1971
1972         Add a work-around to enable WebKit2 when using build-webkit.
1973
1974         * Scripts/webkitdirs.pm:
1975         (buildAutotoolsProject): 
1976
1977 2011-09-15  James Robinson  <jamesr@chromium.org>
1978
1979         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
1980
1981         * Scripts/webkitpy/common/config/committers.py:
1982
1983 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
1984
1985         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
1986         https://bugs.webkit.org/show_bug.cgi?id=68003
1987
1988         Reviewed by Adam Barth.
1989
1990         * Scripts/webkitpy/tool/mocktool.py:
1991         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1992         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1993
1994 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
1995
1996         Python version check is confusing in test-webkitpy
1997         https://bugs.webkit.org/show_bug.cgi?id=68004
1998
1999         Reviewed by Adam Barth.
2000
2001         * Scripts/test-webkitpy:
2002
2003 2011-09-15  Eric Seidel  <eric@webkit.org>
2004
2005         Reviewed by Adam Barth.
2006
2007         webkit-patch should be able to find users and add them to bugzilla groups
2008         https://bugs.webkit.org/show_bug.cgi?id=63351
2009
2010         These are both very basic commands.  But it's now possible to find
2011         all users matching a regexp, as well as add all users matching a regexp
2012         to a set of groups.
2013
2014         bugzilla.py already knew how to find users (for validate-committer-lists)
2015         but now it has the ability to modify the user records.
2016
2017         I split some of the logic out into a new EditUsersParser class
2018         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
2019
2020         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2021         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2022         * Scripts/webkitpy/tool/commands/__init__.py:
2023         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
2024         * Scripts/webkitpy/tool/commands/findusers.py: Added.
2025
2026 2011-09-15  Eric Seidel  <eric@webkit.org>
2027
2028         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
2029         https://bugs.webkit.org/show_bug.cgi?id=68182
2030
2031         Reviewed by Adam Barth.
2032
2033         * Scripts/build-webkit:
2034         * waf/build/settings.py:
2035
2036 2011-09-15  Eric Seidel  <eric@webkit.org>
2037
2038         Unreviewed.  Make contributor email look-up case-insensitive.
2039
2040         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
2041         was missing from committers.py due to case sensitivity.
2042
2043         This also includes a test expectations update to committers_unittest.py
2044         after my previous change.
2045
2046         * Scripts/webkitpy/common/config/committers.py:
2047         * Scripts/webkitpy/common/config/committers_unittest.py:
2048         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2049
2050 2011-09-15  Eric Seidel  <eric@webkit.org>
2051
2052         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
2053
2054         Add a bunch of email aliases to committers.py for regular contributors
2055         who are committing using other email addresses than they have listed in the file.
2056
2057         * Scripts/webkitpy/common/config/committers.py:
2058
2059 2011-09-15  Eric Seidel  <eric@webkit.org>
2060
2061         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
2062         https://bugs.webkit.org/show_bug.cgi?id=68022
2063
2064         Reviewed by Ryosuke Niwa.
2065
2066         * Scripts/build-webkit:
2067         * waf/build/settings.py:
2068
2069 2011-09-15  Anders Carlsson  <andersca@apple.com>
2070
2071         Fix Mac build by including config.h where needed.
2072
2073         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2074         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2075         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2076         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2077         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2078         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2079         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2080         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2081         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2082         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2083         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2084         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2085         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2086         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
2087         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2088         * TestWebKitAPI/mac/main.mm:
2089
2090 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
2091
2092         Let TestWebKitAPI work for chromium
2093         https://bugs.webkit.org/show_bug.cgi?id=67756
2094
2095         Reviewed by Sam Weinig.
2096
2097         * Scripts/build-api-tests:
2098         * Scripts/run-api-tests:
2099         (isSupportedPlatform):
2100         (runTest):
2101         (populateTests):
2102         * Scripts/webkitdirs.pm:
2103         (determineBaseProductDir):
2104         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2105         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2106         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2107         * TestWebKitAPI/InjectedBundleController.cpp:
2108         * TestWebKitAPI/InjectedBundleMain.cpp:
2109         * TestWebKitAPI/JavaScriptTest.cpp:
2110         * TestWebKitAPI/PlatformUtilities.cpp:
2111         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
2112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2113         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
2114         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2115         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2116         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2117         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
2118         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2119         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2120         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2121         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2122         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2123         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2124         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2125         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2126         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2127         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2128         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2129         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2130         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2131         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2132         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2133         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2134         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2135         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2136         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2137         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2138         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2139         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2140         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2141         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2142         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2143         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2144         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2145         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2146         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2147         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2148         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2149         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2150         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2151         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2152         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2153         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2154         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2155         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2156         * TestWebKitAPI/TestsController.cpp:
2157         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
2158         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
2159         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2160         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2161         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2162         * TestWebKitAPI/win/main.cpp:
2163
2164 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
2165
2166         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
2167         https://bugs.webkit.org/show_bug.cgi?id=68145
2168
2169         This will allow for other classes in DumpRenderTree to reuse this functionality
2170
2171         Reviewed by David Levin.
2172
2173         * DumpRenderTree/chromium/TestShell.cpp:
2174         (normalizeLayoutTestURLInternal):
2175         (dumpHistoryItem):
2176         (TestShell::normalizeLayoutTestURL):
2177         * DumpRenderTree/chromium/TestShell.h:
2178
2179 2011-09-14  Ada Chan  <adachan@apple.com>
2180
2181         Add test for WKBundleFrameCopyWebArchive().
2182         https://bugs.webkit.org/show_bug.cgi?id=67857
2183
2184         Reviewed by Anders Carlsson.
2185
2186         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
2187         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
2188         the returned data is a valid webarchive.
2189         (TestWebKitAPI::setInjectedBundleClient):
2190         (TestWebKitAPI::didFinishLoadForFrame):
2191         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
2192         injected bundle for the webarchive and check the returned webarchive.
2193         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
2194         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
2195         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
2196         the web archive.
2197
2198         Add files to project.
2199         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
2200         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2202
2203 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2204
2205         committers.py should support multiple IRC nicknames
2206         https://bugs.webkit.org/show_bug.cgi?id=68110
2207
2208         Reviewed by Eric Seidel.
2209
2210         Add multiple IRC nickname support to committers.py
2211
2212         * Scripts/webkitpy/common/config/committers.py:
2213         * Scripts/webkitpy/common/config/committers_unittest.py:
2214         * Scripts/webkitpy/tool/bot/irc_command.py:
2215         * Scripts/webkitpy/tool/bot/sheriff.py:
2216
2217 2011-09-14  Jon Lee  <jonlee@apple.com>
2218
2219         Implement globalFlag for WebKitTestRunner
2220         https://bugs.webkit.org/show_bug.cgi?id=68033
2221         <rdar://problem/10119204>
2222
2223         Reviewed by Sam Weinig.
2224
2225         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
2226         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2227         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
2228         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
2229         (WTR::LayoutTestController::globalFlag): simple getter
2230         (WTR::LayoutTestController::setGlobalFlag): simple setter
2231
2232 2011-09-13  Eric Seidel  <eric@webkit.org>
2233
2234         Remove ENABLE_SVG_USE as <use> is required by HTML5
2235         https://bugs.webkit.org/show_bug.cgi?id=68019
2236
2237         Reviewed by Ryosuke Niwa.
2238
2239         * Scripts/build-webkit:
2240         * waf/build/settings.py:
2241
2242 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2243
2244         Remove Jan Erik Hanssen (added in my r95078) from the list for now
2245         since I can't confirm acceptable his committership.
2246
2247         * Scripts/webkitpy/common/config/committers.py:
2248
2249 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
2250
2251         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
2252         https://bugs.webkit.org/show_bug.cgi?id=68066
2253
2254         Reviewed by Adam Barth.
2255
2256         * DumpRenderTree/chromium/WebViewHost.cpp:
2257         * DumpRenderTree/chromium/WebViewHost.h:
2258
2259 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2260
2261         committers.py is missing some contributors
2262         https://bugs.webkit.org/show_bug.cgi?id=68059
2263
2264         Reviewed by Adam Barth.
2265
2266         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
2267
2268         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
2269
2270         * Scripts/webkitpy/common/config/committers.py:
2271
2272 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2273
2274         Fix webkit python test after r95061.
2275
2276         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2277
2278 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
2279
2280         Add myself as a contributor. No review needed.
2281
2282         * Scripts/webkitpy/common/config/committers.py:
2283
2284 2011-09-13  Adam Barth  <abarth@webkit.org>
2285
2286         garden-o-matic has unfriendly error messages when the local server is not available
2287         https://bugs.webkit.org/show_bug.cgi?id=68042
2288
2289         Reviewed by Dimitri Glazkov.
2290
2291         This patch moves us from using alert to showing the error inline in the
2292         progress dialog.
2293
2294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2298         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2299
2300 2011-09-13  Adam Barth  <abarth@webkit.org>
2301
2302         FailureGrid in garden-o-matic should link to the builder's waterfall page
2303         https://bugs.webkit.org/show_bug.cgi?id=68036
2304
2305         Reviewed by Dimitri Glazkov.
2306
2307         One of the users in the user study thought the configurations names in
2308         the failure grid would link to the underlying bots.  That makes sense,
2309         so this patch adds the behavior.
2310
2311         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2312         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2313         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2314         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2315
2316 2011-09-13  Adam Barth  <abarth@webkit.org>
2317
2318         garden-o-matic should be able to mark failures as expected
2319         https://bugs.webkit.org/show_bug.cgi?id=68027
2320
2321         Reviewed by Dimitri Glazkov.
2322
2323         All the back-end infrastructure exists for this operation.  This patch
2324         just adds some UI to the front-end and wires that UI up to the back
2325         end.  This exact UI will likely need some more polish, but this should
2326         be a reasonable first cut.
2327
2328         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2329         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2330         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2331         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2333
2334 2011-09-13  Adam Barth  <abarth@webkit.org>
2335
2336         garden-o-matic should tell you about the progress of your rebaseline
2337         https://bugs.webkit.org/show_bug.cgi?id=67967
2338
2339         Reviewed by Dimitri Glazkov.
2340
2341         This patch adds ui.MessageBox, which is a light wrapper around jQuery
2342         UI's dialog widget.  We then use ui.MessageBox to show status messages
2343         about in-progress rebaselines.  As each baseline is downloaded, the
2344         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
2345
2346         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2348         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2350         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2351         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2352
2353 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
2354
2355         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
2356         https://bugs.webkit.org/show_bug.cgi?id=68024
2357
2358         Reviewed by Gustavo Noronha Silva.
2359         
2360         Using g_list_count() and g_list_nth_data() together on a loop is
2361         inneficient since they're both O(n). Iterate over lists in a saner
2362         way.
2363
2364         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2365         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
2366         iterate on it using g_list_next(). Free the list after done with it.
2367         (dumpBackForwardListForWebView): Instead of appending (which is
2368         expensive in GLists) history items and then iterating from the tail
2369         of the itemsToPrint list, prepend items and walk forwards as usual.
2370         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
2371         remove the (unneeded) viewList variable.
2372
2373 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2374
2375         Add Eric's IRC nick.
2376
2377         * Scripts/webkitpy/common/config/committers.py:
2378
2379 2011-09-13  Anders Carlsson  <andersca@apple.com>
2380
2381         Disable C++ exceptions when building with clang
2382         https://bugs.webkit.org/show_bug.cgi?id=68031
2383         <rdar://problem/9556880>
2384
2385         Reviewed by Mark Rowe.
2386
2387         * MiniBrowser/Configurations/Base.xcconfig:
2388         * TestWebKitAPI/Configurations/Base.xcconfig:
2389         * WebKitTestRunner/Configurations/Base.xcconfig:
2390
2391 2011-09-13  Ojan Vafai  <ojan@chromium.org>
2392
2393         [chromium] fix flakiness dashboard for chromium interactive tests
2394         https://bugs.webkit.org/show_bug.cgi?id=68029
2395
2396         Reviewed by Tony Chang.
2397
2398         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2399         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2400
2401 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2402
2403         Add Alice and Aryeh to the list of contributors.
2404
2405         * Scripts/webkitpy/common/config/committers.py:
2406
2407 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2408
2409         sheriffbot whois should also tell us email addresses
2410         https://bugs.webkit.org/show_bug.cgi?id=67975
2411
2412         Reviewed by Eric Seidel and David Levin.
2413
2414         Taught sheriffbot how to tell us contributor's email addresses.
2415
2416         * Scripts/webkitpy/tool/bot/irc_command.py:
2417         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2418
2419 2011-09-13  Eric Seidel  <eric@webkit.org>
2420
2421         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
2422         https://bugs.webkit.org/show_bug.cgi?id=68018
2423
2424         Reviewed by Ryosuke Niwa.
2425
2426         * Scripts/build-webkit:
2427         * waf/build/settings.py:
2428
2429 2011-09-13  Chang Shu  <cshu@webkit.org>
2430
2431         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
2432         https://bugs.webkit.org/show_bug.cgi?id=57515
2433
2434         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
2435         TestController synchronously. The latter then sends simulated event to WebKit2 module,
2436         which is synchronous, too.
2437
2438         Reviewed by Darin Adler.
2439
2440         * WebKitTestRunner/EventSenderProxy.h: Added.
2441         (WTR::EventSenderProxy::EventSenderProxy):
2442         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2443         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2444         (WTR::EventSendingController::keyDown):
2445         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2446         * WebKitTestRunner/PlatformWebView.h:
2447         (WTR::PlatformWebView::platformWindow):
2448         * WebKitTestRunner/TestController.cpp:
2449         (WTR::TestController::TestController):
2450         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2451         * WebKitTestRunner/TestController.h:
2452         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2453         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
2454         (WTR::buildModifierFlags):
2455         (WTR::EventSenderProxy::keyDown):
2456
2457 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
2458
2459         [EFL] DRT: Add DumpRenderTreeEfl.h
2460         https://bugs.webkit.org/show_bug.cgi?id=63993
2461
2462         Reviewed by Eric Seidel.
2463         
2464         This header contains some global variables used by EFL's
2465         DumpRenderTree implementation.
2466
2467         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
2468         appropriate.
2469         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
2470
2471 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
2472
2473         [EFL] Send the right key names for PageUp and PageDown.
2474         https://bugs.webkit.org/show_bug.cgi?id=67044
2475
2476         Reviewed by Kenneth Rohde Christiansen.
2477
2478         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
2479         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
2480         However, EventSender was sending "Page_Up" and "Page_Down", so tests
2481         such as editing/input/page-up-down-scrolls.html were timing out due to
2482         the right key down events not being sent.
2483
2484         * DumpRenderTree/efl/EventSender.cpp:
2485         (keyPadNameFromJSValue):
2486         (keyNameFromJSValue):
2487
2488 2011-09-12  Eric Seidel  <eric@webkit.org>
2489
2490         sheriffbot whois is case sensitive
2491         https://bugs.webkit.org/show_bug.cgi?id=67972
2492
2493         Reviewed by Adam Barth.
2494
2495         I also fixed a typo in the "More than 5 contributors" message
2496         from my previous commit.
2497
2498         * Scripts/webkitpy/common/config/committers.py:
2499         * Scripts/webkitpy/common/config/committers_unittest.py:
2500         * Scripts/webkitpy/tool/bot/irc_command.py:
2501         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2502
2503 2011-09-12  Eric Seidel  <eric@webkit.org>
2504
2505         sheriffbot whois should be smarter
2506         https://bugs.webkit.org/show_bug.cgi?id=67971
2507
2508         Reviewed by Adam Barth.
2509
2510         This makes sheriffbot whois basically grep the committers list
2511         making it much easier to find a contributor by name.
2512
2513         Unfortunately the current unittests depend on the real committers.py
2514         file, so as we add more eric's to the project, this unittest result will
2515         change.  I think that's OK for now.  We'll fix it when it breaks.
2516
2517         * Scripts/webkitpy/common/config/committers.py:
2518         * Scripts/webkitpy/tool/bot/irc_command.py:
2519         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2520
2521 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2522
2523         Unreviewed, rolling out r94976.
2524         http://trac.webkit.org/changeset/94976
2525         https://bugs.webkit.org/show_bug.cgi?id=67953
2526
2527         Broke a bunch of security/load& tests (Requested by rniwa on
2528         #webkit).
2529
2530         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2531         (LayoutTestController::pathToLocalResource):
2532
2533 2011-09-12  Eric Seidel  <eric@webkit.org>
2534
2535         Rubber-stamped by Adam Barth.
2536
2537         Remove the "the tree is burning!" warning previously shown
2538         when landing patches.  It was a dream.  But it's just noise now.
2539
2540         Some bots will require a restart to notice the removal of the option
2541         so I've left the --ignore-builders option in for now.
2542
2543         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2544         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2545         * Scripts/webkitpy/tool/commands/download.py:
2546         * Scripts/webkitpy/tool/commands/download_unittest.py:
2547         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2548         * Scripts/webkitpy/tool/steps/__init__.py:
2549         * Scripts/webkitpy/tool/steps/commit.py:
2550         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
2551         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2552
2553 2011-09-12  Eric Seidel  <eric@webkit.org>
2554
2555         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
2556         https://bugs.webkit.org/show_bug.cgi?id=65781
2557
2558         Reviewed by Ryosuke Niwa.
2559
2560         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
2561         to resolve the passed in url relative to the absolute url for the test.
2562
2563         I believe this is a better approach than the on used in the Qt and Chromium DRT's
2564         (which resolves the path relative to the built location of the DRT executable)
2565         and we should move this new code into a shared location in a follow-up patch.
2566
2567         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2568         (LayoutTestController::pathToLocalResource):
2569
2570 2011-09-12  Eric Seidel  <eric@webkit.org>
2571
2572         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
2573         https://bugs.webkit.org/show_bug.cgi?id=67530
2574
2575         Reviewed by Adam Barth.
2576
2577         I believe I've fixed the bug in the original patch which prompted the rollout.
2578         The previous patch was using the wrong deadline for the initial read,
2579         subtracting time.time() twice from the deadline value.
2580
2581         * Scripts/webkitpy/layout_tests/port/webkit.py:
2582         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2583
2584 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
2585
2586         [Qt][WK2] WebKitTestRunner does not produce crash logs
2587         https://bugs.webkit.org/show_bug.cgi?id=67714
2588
2589         Reviewed by Chang Shu.
2590
2591         Added a simple way of generating backtrace on crash
2592         to the web process. The implementation is similar what
2593         we have in DRT. It depends on GNU libc functionality
2594         so it is only enabled where we are running in such an environment.
2595
2596         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2597         (WTR::printBacktrace):
2598         (WTR::crashHandler):
2599         (WTR::InjectedBundle::platformInitialize):
2600
2601 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
2602
2603         Added my IRC nick to the committers file.
2604
2605         * Scripts/webkitpy/common/config/committers.py:
2606
2607 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
2608
2609         The executable allocator makes it difficult to free individual
2610         chunks of executable memory
2611         https://bugs.webkit.org/show_bug.cgi?id=66363
2612
2613         Reviewed by Oliver Hunt.
2614         
2615         Introduced a best-fit, balanced-tree based allocator. The allocator
2616         required a balanced tree that does not allocate memory and that
2617         permits the removal of individual nodes directly (as opposed to by
2618         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
2619         Changed all references to executable code to use a reference counted
2620         handle.
2621
2622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2623         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
2624         (TestWebKitAPI::TEST_F):
2625         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
2626         (TestWebKitAPI::Pair::findExact):
2627         (TestWebKitAPI::Pair::remove):
2628         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
2629         (TestWebKitAPI::Pair::assertFoundAndRemove):
2630         (TestWebKitAPI::Pair::assertEqual):
2631         (TestWebKitAPI::Pair::assertSameValuesForKey):
2632         (TestWebKitAPI::Pair::testDriver):
2633         (TestWebKitAPI::TEST_F):
2634
2635 2011-09-10  Andy Estes  <aestes@apple.com>
2636
2637         Move myself from committers_unable_to_review to reviewers_list.
2638
2639         * Scripts/webkitpy/common/config/committers.py:
2640
2641 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
2642
2643         [wx] Unreviewed build fix. MSW build fixes.
2644
2645         * DumpRenderTree/config.h:
2646         * waf/build/wxpresets.py:
2647
2648 2011-09-10  Andreas Kling  <kling@webkit.org>
2649
2650         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
2651         https://bugs.webkit.org/show_bug.cgi?id=59328
2652
2653         Reviewed by Kenneth Rohde Christiansen.
2654
2655         * MiniBrowser/mac/BrowserWindowController.m:
2656         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
2657
2658 2011-09-10  Adam Barth  <abarth@webkit.org>
2659
2660         Build fix for Android.  DumpRenderTree is a client of the WebKit API
2661         and does not have access to notImplemented().
2662
2663         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2664         (openStartupDialog):
2665
2666 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
2667
2668         Add a script to create a monolithic script-test
2669         https://bugs.webkit.org/show_bug.cgi?id=67747
2670
2671         Reviewed by Darin Adler.
2672
2673         * Scripts/make-new-script-test: Added.
2674
2675 2011-09-09  Luiz Agostini  <luiz@webkit.org>
2676
2677         Adding myself to the reviewers list.
2678
2679         * Scripts/webkitpy/common/config/committers.py:
2680
2681 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
2682
2683         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
2684         https://bugs.webkit.org/show_bug.cgi?id=67855
2685
2686         Reviewed by Dirk Pranke.
2687
2688         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
2689         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
2690
2691         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
2692
2693         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2694
2695 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
2696
2697         Add myself to committers.py
2698         https://bugs.webkit.org/show_bug.cgi?id=67853
2699
2700         Reviewed by Darin Adler.
2701
2702         * Scripts/webkitpy/common/config/committers.py:
2703
2704 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2705
2706         [Qt] Remove common.pri
2707         https://bugs.webkit.org/show_bug.cgi?id=67814
2708
2709         Reviewed by Andreas Kling.
2710
2711         * Tools.pro:
2712
2713 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2714
2715         [NRWT] the nrwt check httpd with --no-http option
2716         https://bugs.webkit.org/show_bug.cgi?id=67835
2717
2718         Reviewed by Tony Chang.
2719
2720         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2721         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2722
2723 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
2724
2725         [chromium] Implement DRT support for Android.
2726         https://bugs.webkit.org/show_bug.cgi?id=67590
2727
2728         Reviewed by Tony Chang.
2729
2730         Add 2 mechanism to make DRT interaction more robust on Android:
2731         - Send 'QUIT' to DRT to make it stop.
2732         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
2733         input commands before it starts.
2734         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
2735         and <clocale> for 'LC_ALL' to compile on Android.
2736
2737         Also change to use sigaction instead of signal for TestShellGtk.cpp,
2738         as signal() man page recommends using sigaction().
2739
2740         * DumpRenderTree/DumpRenderTree.gypi:
2741         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2742         (main):
2743         * DumpRenderTree/chromium/LayoutTestController.cpp:
2744         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
2745         (AlarmHandler):
2746         (TestShell::waitTestFinished):
2747         (platformInit):
2748         (openStartupDialog):
2749         (checkLayoutTestSystemDependencies):
2750         * DumpRenderTree/chromium/TestShellGtk.cpp:
2751         (AlarmHandler):
2752         (TestShell::waitTestFinished):
2753
2754 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
2755
2756         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
2757
2758         * waf/build/settings.py:
2759
2760 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2761
2762         Unreviewed, rolling out r94851.
2763         http://trac.webkit.org/changeset/94851
2764         https://bugs.webkit.org/show_bug.cgi?id=67847
2765
2766         It broke a webkitpy test (Requested by ossy on #webkit).
2767
2768         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2769
2770 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2771
2772         [NRWT] the nrwt check httpd with --no-http option
2773         https://bugs.webkit.org/show_bug.cgi?id=67835
2774
2775         Reviewed by Csaba Osztrogonác.
2776
2777         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2778
2779 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
2780
2781         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
2782         https://bugs.webkit.org/show_bug.cgi?id=67794
2783         <rdar://problem/9892024>
2784         
2785         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
2786
2787         Reviewed by Brady Eidson.
2788
2789         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
2790         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
2791         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
2792         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
2793             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
2794             didPerformServerRedirect.
2795
2796         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
2797         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
2798             our InjectedBundleTest.
2799         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
2800             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
2801             the request.
2802         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
2803
2804         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
2805         
2806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2807         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
2808         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
2809         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
2810
2811 2011-09-08  David Levin  <levin@chromium.org>
2812
2813         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
2814         https://bugs.webkit.org/show_bug.cgi?id=67797
2815
2816         Reviewed by Eric Seidel.
2817
2818         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
2819         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
2820
2821 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
2822
2823         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
2824         https://bugs.webkit.org/show_bug.cgi?id=67723
2825
2826         Reviewed by Adam Barth.
2827
2828         * DumpRenderTree/chromium/EventSender.h:
2829         * DumpRenderTree/chromium/LayoutTestController.cpp:
2830         (LayoutTestController::LayoutTestController):
2831         (LayoutTestController::enableFixedLayoutMode):
2832         (LayoutTestController::setFixedLayoutSize):
2833         * DumpRenderTree/chromium/LayoutTestController.h:
2834
2835 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
2836
2837         Add standalone script that filters the output of build-webkit to be more human-readable
2838         https://bugs.webkit.org/show_bug.cgi?id=44081
2839
2840         Reviewed by Daniel Bates.
2841
2842         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
2843         a build script (e.g. build-webkit) and it spits out a prettier version.
2844         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
2845         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
2846
2847 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
2848
2849         Add myself to committers.py                 
2850         https://bugs.webkit.org/show_bug.cgi?id=67696
2851
2852         Reviewed by Kent Tamura.
2853
2854         * Scripts/webkitpy/common/config/committers.py:
2855
2856 2011-09-07  Adam Barth  <abarth@webkit.org>
2857
2858         rebaseline button in garden-o-matic details view should work
2859         https://bugs.webkit.org/show_bug.cgi?id=67738
2860
2861         Reviewed by Dimitri Glazkov.
2862
2863         This patch wires up the rebaseline button in garden-o-matic results
2864         details view.  The button is current per-test, so there isn't a way to
2865         rebaseline individual bots.  This is a place to start.  If we decide we
2866         want per-bot rebaselining, we'll need to think of some better UI.
2867
2868         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2869         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2870         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2871         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2872
2873 2011-09-07  Eric Seidel  <eric@webkit.org>
2874
2875         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
2876         https://bugs.webkit.org/show_bug.cgi?id=67737
2877
2878         Reviewed by Adam Barth.
2879
2880         I got a little over-eager when deprecating host.port_factory in the previous commit.
2881         Turns out that Host.port_factory was already the "modern" port/factory.py
2882         it was just the Module object.  I un-deprecated the variable, and changed it from
2883         being the module to being an actual PortFactory, passing it a host object.
2884         I also taught PortFactory how to set user/executive/filesystem in the kwargs
2885         when instantiating a new Port object.
2886         This magically fixed the test_rebaseline test, since its now no longer talking
2887         to the real filesystem.
2888
2889         * Scripts/webkitpy/common/host.py:
2890         * Scripts/webkitpy/layout_tests/port/factory.py:
2891         * Scripts/webkitpy/tool/commands/queries.py:
2892         * Scripts/webkitpy/tool/mocktool.py:
2893
2894 2011-09-07  Eric Seidel  <eric@webkit.org>
2895
2896         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
2897         https://bugs.webkit.org/show_bug.cgi?id=67734
2898
2899         Reviewed by Adam Barth.
2900
2901         Right now every place that creates a Port object has to be very careful
2902         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
2903         The correct fix is for port/factory.py (which creates most port objects)
2904         to know how to pass these in automatically.  However, currently all port/factory.py
2905         functions are free functions instead of being on an object.  This patch
2906         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
2907
2908         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
2909         pass along the proper scm/user/filesystem to the Port object.
2910
2911         * Scripts/webkitpy/common/host.py:
2912         * Scripts/webkitpy/layout_tests/port/factory.py:
2913         * Scripts/webkitpy/tool/commands/queries.py:
2914         * Scripts/webkitpy/tool/mocktool.py:
2915
2916 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2917
2918         Unreviewed, rolling out r94441.
2919         http://trac.webkit.org/changeset/94441
2920         https://bugs.webkit.org/show_bug.cgi?id=67731
2921
2922         "MacEWSes are backed up due to new machines not able to reach
2923         git.webkit.org.  Disabling tests for now" (Requested by
2924         eseidel2 on #webkit).
2925
2926         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2927
2928 2011-09-07  Elliot Poger  <epoger@google.com>
2929
2930         filter test_expectations properly for chromium-mac vs chromium-cg-mac
2931         https://bugs.webkit.org/show_bug.cgi?id=67324
2932
2933         Reviewed by Dirk Pranke.
2934
2935         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2936         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2937         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2938         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2939         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2940
2941 2011-09-07  Eric Boren  <borenet@gmail.com>
2942
2943         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
2944         https://bugs.webkit.org/show_bug.cgi?id=66800
2945
2946         Reviewed by Darin Fisher.
2947
2948         * DumpRenderTree/chromium/EventSender.cpp:
2949         (EventSender::sendCurrentTouchEvent):
2950
2951 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
2952
2953         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2954         https://bugs.webkit.org/show_bug.cgi?id=67254
2955
2956         Reviewed by Csaba Osztrogonác.
2957
2958         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
2959         derived from the running location of DumpRenderTree binary.
2960
2961         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2962         (LayoutTestController::pathToLocalResource):
2963         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
2964
2965 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2966
2967         REGRESSION(r94288) build-webkit doesn't work on Symbian
2968         https://bugs.webkit.org/show_bug.cgi?id=67706
2969
2970         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
2971         (buildQMakeProject):
2972
2973 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2974
2975         REGRESSION(r94288) build-webkit doesn't work on Windows
2976         https://bugs.webkit.org/show_bug.cgi?id=67646
2977
2978         Roll back r94655 with a small fix.
2979
2980         * Scripts/webkitdirs.pm:
2981         (buildQMakeProject):
2982
2983 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2984
2985         Unreviewed, rolling out r94635.
2986         http://trac.webkit.org/changeset/94635
2987         https://bugs.webkit.org/show_bug.cgi?id=67704
2988
2989         Linux Touch build is failing to compile this change.
2990         (Requested by loislo on #webkit).
2991
2992         * DumpRenderTree/chromium/EventSender.cpp:
2993         (EventSender::sendCurrentTouchEvent):
2994
2995 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2996
2997         Unreviewed, rolling out r94655.
2998         http://trac.webkit.org/changeset/94655
2999         https://bugs.webkit.org/show_bug.cgi?id=67703
3000
3001         It broke Leopard debug bot (Requested by ossy on #webkit).
3002
3003         * Scripts/webkitdirs.pm:
3004
3005 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3006
3007         REGRESSION(r94288) build-webkit doesn't work on Windows
3008         https://bugs.webkit.org/show_bug.cgi?id=67646
3009
3010         Reviewed by Csaba Osztrogonác.
3011
3012         * Scripts/webkitdirs.pm:
3013
3014 2011-09-06  Eric Boren  <borenet@gmail.com>
3015
3016         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
3017         https://bugs.webkit.org/show_bug.cgi?id=66800
3018
3019         Reviewed by Darin Fisher.
3020
3021         * DumpRenderTree/chromium/EventSender.cpp:
3022         (EventSender::sendCurrentTouchEvent):
3023
3024 2011-09-06  Adam Barth  <abarth@webkit.org>
3025
3026         garden-o-matic details view should having working rebaseline and next/previous buttons
3027         https://bugs.webkit.org/show_bug.cgi?id=67659
3028
3029         Reviewed by Dimitri Glazkov.
3030
3031         This patch wires up basic back/forward buttons that let you traverse
3032         through the results we're examining in the details view.  This ended up
3033         being more code than I expected, but I wanted to keep all the state
3034         information in the DOM itself.
3035
3036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3038         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3039
3040 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
3041
3042         fix MockFileSystem.glob(), refactor filesystem tests
3043         https://bugs.webkit.org/show_bug.cgi?id=67462
3044
3045         Reviewed by Eric Seidel.
3046
3047         In debugging why my proposed change for MockFileSystem.glob()
3048         in bug 66228 didn't work, I stumbled across two real bugs
3049         that cancelled each other out for the unit tests. I fixed those
3050         (glob shouldn't recurse into subdirs, and we weren't populating
3051         self.dirs from self.files properly).
3052
3053         I have also created a "mixin" class for tests that can be shared
3054         between the real filesystem and the mock filesystem - MockFileSystem
3055         is being used enough it needs its own tests.
3056
3057         * Scripts/webkitpy/common/system/filesystem_mock.py:
3058         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
3059         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3060
3061 2011-09-06  Anders Carlsson  <andersca@apple.com>
3062
3063         Move NPAPI headers in bridge to plugins
3064         https://bugs.webkit.org/show_bug.cgi?id=67661
3065
3066         Update forwarding headers.
3067
3068         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
3069         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
3070
3071 2011-09-06  Tony Chang  <tony@chromium.org>
3072
3073         [chromium] Check in 'build' for compiled binaries first
3074         https://bugs.webkit.org/show_bug.cgi?id=67549
3075
3076         Reviewed by Dirk Pranke.
3077
3078         I'm working on moving the windows build output to a common location
3079         rather than relative to the sln file.  Because of that, we need to
3080         check those build locations first for DumpRenderTree.exe.
3081
3082         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3083
3084 2011-09-06  Adam Barth  <abarth@webkit.org>
3085
3086         Use a hierarchial structure for the garden-o-matic results view
3087         https://bugs.webkit.org/show_bug.cgi?id=67620
3088
3089         Reviewed by Dimitri Glazkov.
3090
3091         This patch re-organizes the results view to use a hierachial structure
3092         for selection.  At the top-level are sections for each test.  Expanding
3093         the test section shows a tab selector for builders.
3094
3095         This structure prepares us for wiring up various actions to this view.
3096
3097         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3098         (.):
3099         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3100         ():
3101         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3102         (.):
3103         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3105         (.results-view>.toolbar):
3106         (.results-view>.toolbar ul.actions):
3107         (.results-view>.toolbar ul.actions li):
3108         (.results-grid table):
3109         (.results-grid table td, .results-view table th):
3110         (.results-grid table th):
3111         (.results-grid .text-result):
3112         (.results-grid .image-result):
3113
3114 2011-09-06  Adam Barth  <abarth@webkit.org>
3115
3116         garden-o-matic's base.probe generates spam in the JavaScript console
3117         https://bugs.webkit.org/show_bug.cgi?id=67622
3118
3119         Reviewed by Dimitri Glazkov.
3120
3121         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
3122         instead of HTMLScriptElement to test whether results exist.  This
3123         reduces the console.log spam and saves bandwidth because we can use a
3124         HEAD request instead of a GET request.
3125
3126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
3127
3128 2011-09-05  Adam Barth  <abarth@webkit.org>
3129
3130         Add a tab to garden-o-matic for viewing expected failures
3131         https://bugs.webkit.org/show_bug.cgi?id=67619
3132
3133         Reviewed by Dimitri Glazkov.
3134
3135         This patch adds a basic tab to garden-o-matic that shows all the tests
3136         failing on the bots, including the expected failures.  This patch
3137         mostly involves refactoring existing classes to allow new subclasses.
3138
3139         This view is useful for when gardeners mark tests as expected to fail
3140         and then rebaseline them later.
3141
3142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
3146         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3147         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3149
3150 2011-09-05  Adam Barth  <abarth@webkit.org>
3151
3152         Fix global variable leak in garden-o-matic
3153         https://bugs.webkit.org/show_bug.cgi?id=67617
3154
3155         Reviewed by Dimitri Glazkov.
3156
3157         Caught by running the unit tests with noglobals turned on.
3158
3159         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3160
3161 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
3162
3163         [Qt][WK2] Add pixel test support
3164         https://bugs.webkit.org/show_bug.cgi?id=66283
3165
3166         Reviewed by Andreas Kling.
3167
3168         Implemented pixel result generation by reusing the logic
3169         that we have in DumpRenderTree.
3170         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3171         (WTR::dumpImage):
3172         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3173
3174 2011-09-04  Robin Dunn  <robin@alldunn.com>
3175
3176         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
3177         https://bugs.webkit.org/show_bug.cgi?id=67577
3178
3179         Reviewed by Kevin Ollivier.
3180
3181         * waf/build/settings.py:
3182
3183 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
3184
3185         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
3186
3187         * waf/build/settings.py:
3188
3189 2011-09-03  Dan Bernstein  <mitz@apple.com>
3190
3191         32-bit build fix.
3192
3193         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3194         (TestWebKitAPI::Util::toSTD):
3195
3196 2011-09-03  Dan Bernstein  <mitz@apple.com>
3197
3198         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
3199         https://bugs.webkit.org/show_bug.cgi?id=67559
3200
3201         Reviewed by Darin Adler.
3202
3203         * DumpRenderTree/mac/DumpRenderTree.mm:
3204         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
3205         the call to it.
3206         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
3207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
3208         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
3209         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
3210         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3211         (TestWebKitAPI::Util::toSTD): Added.
3212
3213 2011-09-03  Adam Barth  <abarth@webkit.org>
3214
3215         garden-o-matic results view should have a better results selector
3216         https://bugs.webkit.org/show_bug.cgi?id=67542
3217
3218         Reviewed by Dimitri Glazkov.
3219
3220         This patch adds a basic grid-based results selector to the results
3221         view.  Currently, this grid just shows how the tests fail on the
3222         various bots.  A future patch will let you select which failure to view
3223         and to mark the failures for rebaselining.
3224
3225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3227           - Add some more basic functions for manipulating dictionaries.
3228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3229         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3231
3232 2011-09-03  Adam Barth  <abarth@webkit.org>
3233
3234         garden-o-matic results view should show Actual and Expected results for text failures
3235         https://bugs.webkit.org/show_bug.cgi?id=67536
3236
3237         Reviewed by Eric Seidel.
3238
3239         In the past, we didn't show actual and expected text results (we just
3240         showed the diff) because we didn't have the awesome six-by-two results
3241         grid.  Now that we do, we can move show these results.
3242
3243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3245           - Fixed some typos that were preventing these unit tests from running.
3246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3247         (.):
3248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3249           - Report -actual.txt and -expected.txt as possible results URLs.
3250
3251 2011-09-03  Adam Barth  <abarth@webkit.org>
3252
3253         garden-o-matic shows "ghost" failures that are already fixed
3254         https://bugs.webkit.org/show_bug.cgi?id=67535
3255
3256         Reviewed by Eric Seidel.
3257
3258         About 10% of writes fail to stick on test-results.appspot.com.  This
3259         patch causes us to fetch the full_results.json blob directly from
3260         build.chromium.org rather than relying upon AppEngine.
3261
3262         Unforuntately, we still need to get historical information from
3263         AppEngine.  That will take several patches to fix becuase I need to
3264         change the bots to write the full_results.json file to the
3265         build-specific directory in addition to the zip file.
3266
3267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3270
3271 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3272
3273         Unreviewed, rolling out r94458.
3274         http://trac.webkit.org/changeset/94458
3275         https://bugs.webkit.org/show_bug.cgi?id=67558
3276
3277         Caused appcache test to fail on various bots (Requested by
3278         rniwa on #webkit).
3279
3280         * Scripts/webkitpy/layout_tests/port/webkit.py:
3281         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3282
3283 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3284
3285         Unreviewed, rolling out r94453.
3286         http://trac.webkit.org/changeset/94453
3287         https://bugs.webkit.org/show_bug.cgi?id=67557
3288
3289         Caused appcache test to fail on various bots (Requested by
3290         rniwa on #webkit).
3291
3292         * Scripts/webkitpy/layout_tests/port/webkit.py:
3293
3294 2011-09-02  Michael Saboff  <msaboff@apple.com>
3295
3296         Add JSC:RegExp functional tests
3297         https://bugs.webkit.org/show_bug.cgi?id=67339
3298
3299         New perl script to build JavaScriptCore and run the RegExp tests.
3300
3301         Reviewed by Gavin Barraclough.
3302
3303         * Scripts/run-regexp-tests: Added.
3304
3305 2011-09-02  Michael Saboff  <msaboff@apple.com>
3306
3307         Add JSC:RegExp functional tests
3308         https://bugs.webkit.org/show_bug.cgi?id=67339
3309
3310         New perl script to build JavaScriptCore and run the RegExp tests.
3311
3312         Reviewed by Gavin Barraclough.
3313
3314         * Scripts/run-regexp-tests: Added.
3315
3316 2011-09-02  Eric Seidel  <eric@webkit.org>
3317
3318         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3319         https://bugs.webkit.org/show_bug.cgi?id=67530
3320
3321         Unreviewed.  Fixing typo from previous commit.
3322
3323         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
3324         which exercises the code I previously made a typo in.
3325
3326         * Scripts/webkitpy/layout_tests/port/webkit.py:
3327         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3328
3329 2011-09-02  Eric Seidel  <eric@webkit.org>
3330
3331         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3332         https://bugs.webkit.org/show_bug.cgi?id=67530
3333
3334         Reviewed by Adam Barth.
3335
3336         No functional change, just reshuffling code.
3337
3338         * Scripts/webkitpy/layout_tests/port/webkit.py:
3339
3340 2011-09-02  Darin Adler  <darin@apple.com>
3341
3342         Added Subversion ignore for .pyc generated files.
3343
3344         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
3345         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
3346         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
3347
3348 2011-09-02  Adam Barth  <abarth@webkit.org>
3349
3350         Enable testing on mac-ews
3351         https://bugs.webkit.org/show_bug.cgi?id=67505
3352
3353         Reviewed by Eric Seidel.
3354
3355         This patch enables testing on the Mac EWS, which should help
3356         contributors not turn the Mac bots red.
3357
3358         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3359
3360 2011-09-01  Beth Dakin  <bdakin@apple.com>
3361
3362         https://bugs.webkit.org/show_bug.cgi?id=67451
3363         Add a test for going back to a cached page after changing the device scale factor
3364
3365         Reviewed by Adam Roben.
3366
3367         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
3368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3369         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
3370         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
3371         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
3372         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
3373         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
3374         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3375         (TestWebKitAPI::TEST_F):
3376
3377         Added new function to WebKitAgnosticTest to goBack. Separated 
3378         waitForLoadToFinish() into its own function (instead of being a part of 
3379         loadAndWaitUntilFinished()) so that it can be called from goBack as 
3380         well. Also added initializeView() so we can set the cache model.
3381         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
3382         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
3383         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3384         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
3385         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
3386         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3387         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
3388         (TestWebKitAPI::WebKitAgnosticTest::goBack):
3389         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
3390
3391 2011-09-02  Anders Carlsson  <andersca@apple.com>
3392
3393         Build fix.
3394
3395         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
3396         (PrivateBrowsing::ScriptableObject::pluginTest):
3397
3398 2011-09-02  Anders Carlsson  <andersca@apple.com>
3399
3400         Move private browsing test to a PluginTest subclass
3401         https://bugs.webkit.org/show_bug.cgi?id=67498
3402
3403         Reviewed by Darin Adler.
3404
3405         * DumpRenderTree/DumpRenderTree.gypi:
3406         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3407         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3408         (pluginGetProperty):
3409         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3410         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3411         (PluginTest::NPP_SetValue):
3412         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3413         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
3414         (PrivateBrowsing::PrivateBrowsing):
3415         (PrivateBrowsing::privateBrowsingEnabled):
3416         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
3417         (PrivateBrowsing::ScriptableObject::hasProperty):
3418         (PrivateBrowsing::ScriptableObject::getProperty):
3419         (PrivateBrowsing::ScriptableObject::pluginTest):
3420         (PrivateBrowsing::NPP_New):
3421         (PrivateBrowsing::NPP_GetValue):
3422         (PrivateBrowsing::NPP_SetValue):
3423         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3424         (NPP_New):
3425         (NPP_SetValue):
3426         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3427         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3428         * GNUmakefile.am:
3429
3430 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
3431
3432         [Qt] Build dependency problems
3433         https://bugs.webkit.org/show_bug.cgi?id=38054
3434
3435         Trivial fix after r94288.
3436
3437         Rubber-stamped by Andras Becsi.
3438
3439         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
3440         (buildQMakeProject):
3441
3442 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
3443
3444         Remove my old e-mail address and add my new one.
3445
3446         Rubber-stamped by Tor Arne Vestbø.
3447
3448         * Scripts/webkitpy/common/config/committers.py:
3449
3450 2011-09-02  Philippe Normand  <pnormand@igalia.com>
3451
3452         [GTK] run-gtk-tests leaves a zombie Xvfb process
3453         https://bugs.webkit.org/show_bug.cgi?id=67389
3454
3455         Reviewed by Martin Robinson.
3456
3457         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
3458         child process instead of doing shell redirection.
3459
3460 2011-09-01  Mark Rowe  <mrowe@apple.com>
3461
3462         Fix the build by adding some more missing return types.
3463
3464         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3465         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3466
3467 2011-09-01  Eric Seidel  <eric@webkit.org>
3468
3469         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
3470         https://bugs.webkit.org/show_bug.cgi?id=66228
3471
3472         Reviewed by Dirk Pranke.
3473
3474         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
3475         The LeaksViewer tool globs for all *-leaks.txt files.
3476         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
3477
3478         In order to test this I had to fix a limitation in our MockFileSystem.glob
3479         method.  However, doing so uncovered a typo and bug in the integration tests.
3480         I've disabled the offending integration tests.
3481
3482         * Scripts/webkitpy/common/system/filesystem_mock.py:
3483         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3484         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3485
3486 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
3487
3488         Adds a LayoutTestController method to make it possible to test
3489         starting speech input via an API call.
3490         https://bugs.webkit.org/show_bug.cgi?id=60170
3491
3492         Reviewed by Dimitri Glazkov.
3493
3494         * DumpRenderTree/LayoutTestController.h:
3495         * DumpRenderTree/chromium/LayoutTestController.cpp:
3496         (LayoutTestController::LayoutTestController):
3497         (LayoutTestController::startSpeechInput):
3498         * DumpRenderTree/chromium/LayoutTestController.h:
3499         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3500         (LayoutTestController::startSpeechInput):
3501         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3502         (LayoutTestController::startSpeechInput):
3503         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3504         (LayoutTestController::startSpeechInput):
3505         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3506         (LayoutTestController::startSpeechInput):
3507         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3508         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3509         (LayoutTestController::startSpeechInput):
3510         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3511         (LayoutTestController::startSpeechInput):
3512
3513 2011-09-01  Tim Horton  <hortont424@gmail.com>
3514
3515         Fix TestWebKitAPI build on clang-2.0
3516
3517         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3518
3519 2011-09-01  Adam Barth  <abarth@webkit.org>
3520
3521         Remove unused "extension" parameter from rebaseline gardeningserver handler
3522         https://bugs.webkit.org/show_bug.cgi?id=67384
3523
3524         Reviewed by James Robinson.
3525
3526         This parameter hasn't done anything in a while.
3527
3528         * Scripts/webkitpy/tool/commands/rebaseline.py:
3529         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3530         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3531
3532 2011-09-01  Eric Seidel  <eric@webkit.org>
3533
3534         Unreviewed.
3535
3536         Fix a typo in unittests.  Unfortunately fixing it
3537         caused several assertions.  Just disabling the test
3538         instead, since it was providing no value before due to the typo.
3539
3540         * Scripts/webkitpy/layout_tests/port/test.py:
3541
3542 2011-09-01  Adam Barth  <abarth@webkit.org>
3543
3544         Add a "rebaseline" button to the garden-o-matic summary page
3545         https://bugs.webkit.org/show_bug.cgi?id=67382
3546
3547         Reviewed by Dimitri Glazkov.
3548
3549         As much as we might wish folks to not rebaseline entire test groups at
3550         once, the truth is that doing so is a common operation.  Adding a
3551         button for this operation is likely to make folks happy.
3552
3553         This patch also cleans up a bunch of plumbing surrounding failureInfo
3554         objects.
3555
3556         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3557         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3558         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3559         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3560         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3561         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3562         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3563         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3564         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3565         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3566
3567 2011-09-01  Adam Barth  <abarth@webkit.org>
3568
3569         garden-o-matic should let the gardener assign blame for a group of test failures
3570         https://bugs.webkit.org/show_bug.cgi?id=67379
3571
3572         Reviewed by Dimitri Glazkov.
3573
3574         If a group of test failures has a large revision range, the gardener
3575         might wish to blame a specific revision for the failure.  Currently,
3576         this only effect of assigning blame in this way is to hide the other
3577         suspect commits.
3578
3579         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3580         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3582
3583 2011-09-01  Adam Barth  <abarth@webkit.org>
3584
3585         Hide garden-o-matic failure table until hover
3586         https://bugs.webkit.org/show_bug.cgi?id=67376
3587
3588         Reviewed by Dimitri Glazkov.
3589
3590         This patch removes the failure table for build failures (because it
3591         does not make sense) and hides the failure table for test groups until
3592         the user hovers over the test failure block, reducing visual noise.
3593
3594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3597
3598 2011-09-01  Adam Barth  <abarth@webkit.org>
3599
3600         Switch garden-o-matic from commitData.title to commitData.summary
3601         https://bugs.webkit.org/show_bug.cgi?id=67375
3602
3603         Reviewed by Dimitri Glazkov.
3604
3605         commitData.title is a string provided by Trac, which isn't great in all
3606         cases.  commitData.summary is my attempt to find the most important
3607         one-line summary of the commit.  This patch switches garden-o-matic
3608         over to summary.
3609
3610         Also, this patch tweaks a bunch of CSS to tighten up the summary page
3611         and reduce visual noise.
3612
3613         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3614         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3615         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3616
3617 2011-09-01  Adam Barth  <abarth@webkit.org>
3618
3619         Group failing tests in garden-o-matic if there are more than three in a folder
3620         https://bugs.webkit.org/show_bug.cgi?id=67373
3621
3622         Reviewed by Dimitri Glazkov.
3623
3624         Sometimes a failure will cause many tests in a given directory to fail.
3625         When that happens, it's better to list the directory as a single item
3626         (with a count) rather than spamming all the test names.
3627
3628         (This patch also updates a bunch of unit test expected results after my last commit.)
3629
3630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3631         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3633         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3634         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3635
3636 2011-09-01  Adam Barth  <abarth@webkit.org>
3637
3638         Lower the visual noise from the failing builders display
3639         https://bugs.webkit.org/show_bug.cgi?id=67369
3640
3641         Reviewed by Dimitri Glazkov.
3642
3643         This patch ensures that the "Building" row in the failing builders
3644         display is always last and dims it by 50% to reduce visual noise.  This
3645         lets the gardener focus on the actual failures.
3646
3647         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3648         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3649         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
3650
3651 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3652
3653         [Qt] Build dependency problems
3654         https://bugs.webkit.org/show_bug.cgi?id=38054
3655
3656         Make clean build after the defines are changed.
3657
3658         Reviewed by Csaba Osztrogonác.
3659
3660         * Scripts/webkitdirs.pm:
3661         (buildQMakeProject):
3662
3663 2011-08-31  Adam Barth  <abarth@webkit.org>
3664