762c0e84773d03aac5ca404228df592c5fbd4e6f
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-01  Devin Rousso  <drousso@apple.com>
2
3         Web Inspector: simplify WebInspector with WI
4         https://bugs.webkit.org/show_bug.cgi?id=175058
5
6         Reviewed by Joseph Pecoraro.
7
8         * Scripts/check-inspector-strings:
9         (extract_ui_strings):
10         * Scripts/extract-localizable-js-strings:
11
12 2017-08-01  Youenn Fablet  <youenn@apple.com>
13
14         Layout tests with 'https' suffix should be run over HTTPS
15         https://bugs.webkit.org/show_bug.cgi?id=174992
16
17         Reviewed by Chris Dumez.
18
19         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
20         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
21         Covered by corresponding unit tests.
22
23         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
24         (run_server):
25         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
26         (base_http_url):
27         (base_https_url):
28         (base_url): Deleted.
29         * Scripts/webkitpy/port/base.py:
30         (Port.to.web_platform_test_server_base_http_url):
31         (Port.to):
32         (Port.to.web_platform_test_server_base_https_url):
33         (Port.to.web_platform_test_server_base_url): Deleted.
34         * Scripts/webkitpy/port/driver.py:
35         (Driver.__init__):
36         (Driver.wpt_test_path_to_uri):
37         (Driver):
38         (Driver.http_test_path_to_uri):
39         (Driver.test_to_uri):
40         (Driver.uri_to_test):
41         * Scripts/webkitpy/port/driver_unittest.py:
42         (DriverTest.test_test_to_uri):
43         (DriverTest.test_uri_to_test):
44
45 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
46
47         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
48         https://bugs.webkit.org/show_bug.cgi?id=173998
49
50         Reviewed by Darin Adler.
51
52         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
53         detect mistakes in backward compatibility in the future when we change it.
54
55         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
56         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
57         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
58         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
59         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
60         internal key data slot.
61
62         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
63         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
64         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
65         (getNextMessage):
66         (TEST):
67         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
68         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
69         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
70         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
71         These are the pre-baked databases.
72         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
73         This is the actual test that do all the reads and comparisons.
74         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
75         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
76         IndexedDB new stuffs. Then it can be used to bake the database again.
77
78 2017-08-01  Brady Eidson  <beidson@apple.com>
79
80         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
81         https://bugs.webkit.org/show_bug.cgi?id=175030
82
83         Reviewed by Andy Estes.
84
85         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
86         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
87
88 2017-08-01  Brady Eidson  <beidson@apple.com>
89
90         Part 2 of: Rename DatabaseProcess to StorageProcess.
91         https://bugs.webkit.org/show_bug.cgi?id=174880
92
93         Reviewed by Andy Estes.
94
95         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
96         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
97         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
98         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
99         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
100         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
101         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
102         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
103
104 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
105
106         Fix JSCOnly ARM buildbots after r220047
107         https://bugs.webkit.org/show_bug.cgi?id=174993
108
109         Reviewed by Saam Barati.
110
111         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
112         (BuildAndRemoteJSCTestsFactory.__init__):
113
114 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
115
116         [WTF] Introduce Private Symbols
117         https://bugs.webkit.org/show_bug.cgi?id=174935
118
119         Reviewed by Darin Adler.
120
121         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
122         (TestWebKitAPI::TEST):
123
124 2017-07-30  Darin Adler  <darin@apple.com>
125
126         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
127         https://bugs.webkit.org/show_bug.cgi?id=130653
128
129         Reviewed by Antti Koivisto.
130
131         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
132         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
133         when calling frameDidChangeLocation.
134         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
135         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
136         thus causing mysterious failures of a couple of tests. There are two remaining issues:
137         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
138         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
139         same logic flaw that causes "top loading frame" to get set to one of the subframes in
140         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
141         loading, subframe starts loading. It would be good to clean that up some day, but for now
142         this patch makes the two work identically rather than changing both.
143         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
144
145 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
146
147         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
148         https://bugs.webkit.org/show_bug.cgi?id=174963
149
150         Reviewed by Darin Adler.
151
152         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
153         RetainPtr<>. This patch changes them to all use auto.
154
155         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
156         (TestWebKitAPI::TEST):
157
158 2017-07-30  Brady Eidson  <beidson@apple.com>
159
160         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
161         https://bugs.webkit.org/show_bug.cgi?id=174958
162
163         Reviewed by Darin Adler.
164
165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
166         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
167         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
168         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
169         (runUntilTasksInFlight):
170         (TEST):
171
172 2017-07-28  Commit Queue  <commit-queue@webkit.org>
173
174         Unreviewed, rolling out r219990.
175         https://bugs.webkit.org/show_bug.cgi?id=174961
176
177         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
178         estes on #webkit).
179
180         Reverted changeset:
181
182         "Part 2 of: Rename DatabaseProcess to StorageProcess."
183         https://bugs.webkit.org/show_bug.cgi?id=174880
184         http://trac.webkit.org/changeset/219990
185
186 2017-07-28  Brady Eidson  <beidson@apple.com>
187
188         API tests that use URLSchemeHandler are failing.
189         https://bugs.webkit.org/show_bug.cgi?id=174950
190
191         Reviewed by Alex Christensen.
192
193         Fix the NoMIMEType test to be correct.
194
195         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
196         (-[SchemeHandler initWithData:mimeType:]):
197         (-[SchemeHandler webView:startURLSchemeTask:]):
198         (TEST):
199
200 2017-07-28  Daniel Bates  <dabates@apple.com>
201
202         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
203         https://bugs.webkit.org/show_bug.cgi?id=174876
204
205         Reviewed by Alex Christensen.
206
207         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
208         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
209         they provide a more direct way to test the platform abstraction.
210
211         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
212
213         * Scripts/prepare-ChangeLog:
214         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
215         of the current working directory.
216
217 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
218
219         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
220         https://bugs.webkit.org/show_bug.cgi?id=174930
221
222         Unreviewed test fix.
223
224         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
225
226         * Scripts/prepare-ChangeLog:
227         (get_function_line_ranges_for_cpp):
228
229 2017-07-28  JF Bastien  <jfbastien@apple.com>
230
231         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
232         https://bugs.webkit.org/show_bug.cgi?id=174930
233
234         Reviewed by Daniel Bates.
235
236         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
237         here also teach it about const and volatile overloads. I didn't do
238         reference and rvalue reference overloads because we don't really
239         use them, and the current parser throws away those characters and
240         it doesn't seem worth making it more complex.
241
242         * Scripts/prepare-ChangeLog:
243         (get_function_line_ranges_for_cpp):
244         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
245         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
246         (Foo::Arrow::arrow):
247         (Foo::Arrow::otherArrow):
248         (Foo::Arrow::otherArrow const):
249         (Foo::Arrow::otherArrow volatile):
250         (Foo::Arrow::otherArrow const volatile):
251
252 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
253
254         [GTK] Building with ENABLE_VIDEO=OFF fails
255         https://bugs.webkit.org/show_bug.cgi?id=174940
256
257         Reviewed by Alex Christensen.
258
259         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
260         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
261
262         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
263         (methodCallCallback): Add missing USE(GSTREAMER) guard.
264
265 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
266
267         [WPE] Implement EventSenderProxy in WTR
268         https://bugs.webkit.org/show_bug.cgi?id=173419
269
270         Reviewed by Žan Doberšek.
271
272         Add the implementation of EventSenderProxy to the WTR. This
273         allows us to extend the coverage of the test suite in WKWPE.
274
275         * WebKitTestRunner/EventSenderProxy.h:
276         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
277         libxkbcommon needed to deal with key events.
278         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
279         (WTR::EventSenderProxy::EventSenderProxy):
280         (WTR::senderButtonToWPEButton):
281         (WTR::EventSenderProxy::mouseDown):
282         (WTR::EventSenderProxy::mouseUp):
283         (WTR::EventSenderProxy::mouseMoveTo):
284         (WTR::EventSenderProxy::mouseScrollBy):
285         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
286         (WTR::EventSenderProxy::leapForward):
287         (WTR::wkEventModifiersToWPE):
288         (WTR::getXKBKeySymForKeyRef):
289         (WTR::EventSenderProxy::keyDown):
290         (WTR::EventSenderProxy::addTouchPoint):
291         (WTR::EventSenderProxy::updateTouchPoint):
292         (WTR::EventSenderProxy::setTouchModifier):
293         (WTR::EventSenderProxy::setTouchPointRadius):
294         (WTR::EventSenderProxy::getUpdatedTouchEvents):
295         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
296         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
297         (WTR::EventSenderProxy::touchStart):
298         (WTR::EventSenderProxy::touchMove):
299         (WTR::EventSenderProxy::touchEnd):
300         (WTR::EventSenderProxy::touchCancel):
301         (WTR::EventSenderProxy::clearTouchPoints):
302         (WTR::EventSenderProxy::releaseTouchPoint):
303         (WTR::EventSenderProxy::cancelTouchPoint):
304
305 2017-07-27  Brady Eidson  <beidson@apple.com>
306
307         Part 2 of: Rename DatabaseProcess to StorageProcess.
308         https://bugs.webkit.org/show_bug.cgi?id=174880
309
310         Reviewed by Andy Estes.
311
312         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
313         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
314         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
315         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
316         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
317         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
318         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
319         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
320
321 2017-07-26  Mark Lam  <mark.lam@apple.com>
322
323         Add ability to only run specific tests in run-javascriptcore-tests.
324         https://bugs.webkit.org/show_bug.cgi?id=174884
325
326         Reviewed by Saam Barati.
327
328         For example, if we only want to run testapi, we can do so as follows:
329             $ run-javascriptcore-tests --testapi
330
331         Previously, specifying --testapi effectively does nothing because we run all tests
332         by default.  Only --no-testapi had the effect of disabling the test set.  This
333         old behavior for --testapi is not very useful or meaningful.  We're now changing
334         it to mean that we will only run that test.
335
336         With this change, we can also run more than one set of tests.  For example, if we
337         only want to run testmasm and testair, we can do so as follows:
338             $ run-javascriptcore-tests --testmasm --testair
339
340         By default, if no specific test option is specified, run-javascriptcore-tests will
341         run all tests.
342
343         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
344         the mozilla tests (--mozilla-tests) even though both are run via the lower level
345         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
346         the other set will not run.  For example, the following only runs the mozilla tests:
347             $ run-javascriptcore-tests --mozilla-tests
348
349         Note also that --jit-stress-tests is not for choosing a different set of tests.
350         Instead, it is used for determining whether we run JIT'ed test configurations
351         on the jsc stress tests and mozilla tests.  As a result, specifying
352         --jit-stress-tests will not omit other tests.  For example, the following still
353         runs all tests:
354             $ run-javascriptcore-tests --jit-stress-tests
355
356         * Scripts/run-javascriptcore-tests:
357         (defaultStringForTestState):
358         (enableTestOrNot):
359         (runJSCStressTests):
360
361 2017-07-26  Mark Lam  <mark.lam@apple.com>
362
363         Make run-javascriptcore-test run testair, testb3, and testmasm.
364         https://bugs.webkit.org/show_bug.cgi?id=174837
365         <rdar://problem/33522927>
366
367         Reviewed by Saam Barati and Filip Pizlo.
368
369         1. Refactors code for running testapi so that we can use it to run other tests.
370         2. Added running of testmasm, testair, testb3.
371
372         Note: the existing testapi invocation code does not support remote invocation of
373         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
374         and testb3 also do not support remote invocation.  If we wish to add remote
375         invocation support, we should do that in a separate patch.
376
377         * Scripts/run-javascriptcore-tests:
378         (testPath):
379         (runTest):
380         (testapiPath): Deleted.
381
382 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
383
384         Remove duplicate code from Buildbot.js in dashboard
385         https://bugs.webkit.org/show_bug.cgi?id=174870
386
387         Reviewed by Daniel Bates.
388
389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
390         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
391         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
392         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
393         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
394
395 2017-07-26  Brady Eidson  <beidson@apple.com>
396
397         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
398         https://bugs.webkit.org/show_bug.cgi?id=174851
399
400         Reviewed by Chris Dumez.
401
402         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
403         (TEST):
404
405 2017-07-26  Brian Burg  <bburg@apple.com>
406
407         Remove WEB_TIMING feature flag
408         https://bugs.webkit.org/show_bug.cgi?id=174795
409
410         Reviewed by Alex Christensen.
411
412         * Scripts/webkitperl/FeatureList.pm:
413         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
414
415 2017-07-26  Chris Dumez  <cdumez@apple.com>
416
417         Pressing the Escape key should not be a valid user gesture to enter fullscreen
418         https://bugs.webkit.org/show_bug.cgi?id=174864
419         <rdar://problem/33009088>
420
421         Reviewed by Geoffrey Garen.
422
423         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
424         WKTR.
425
426         * DumpRenderTree/mac/EventSendingController.mm:
427         (-[EventSendingController keyDown:withModifiers:withLocation:]):
428
429 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
430
431         Unreviewed, added Romain Bellessort to contributors.json.
432
433         * Scripts/webkitpy/common/config/contributors.json:
434
435 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
436
437         [WPE] WebGL2 support
438         https://bugs.webkit.org/show_bug.cgi?id=174249
439
440         Reviewed by Alex Christensen.
441
442         * Scripts/webkitperl/FeatureList.pm:
443         Enable WebGL2 for WPE when building through build-webkit.
444
445 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
446
447         Unreviewed. Fix GTK distcheck.
448
449         * gtk/make-dist.py:
450         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
451
452 2017-07-25  Brady Eidson  <beidson@apple.com>
453
454         ResourceLoadStatistics grandfathering happens much too often.
455         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
456
457         Reviewed by Chris Dumez.
458
459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
460         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
461         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
462         (TEST):
463
464 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
465
466         Fix autoinstaller failing on autoinstall_everything
467         https://bugs.webkit.org/show_bug.cgi?id=174830
468
469         Reviewed by Joseph Pecoraro.
470
471         * Scripts/webkitpy/thirdparty/__init__.py:
472         (AutoinstallImportHook.find_module):
473         (AutoinstallImportHook.install_chromedriver):
474         (AutoinstallImportHook.install_geckodriver):
475         (AutoinstallImportHook._install_chromedriver): Deleted.
476         (AutoinstallImportHook._install_geckodriver): Deleted.
477
478 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
479
480         Replace --runtime with something for both ios-simulator and ios-device
481         https://bugs.webkit.org/show_bug.cgi?id=173775
482         <rdar://problem/32952164>
483
484         Reviewed by Aakash Jain.
485
486         Add --version flag for both iOS simulator and iOS device.
487
488         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
489         (parse_args): Add --version flag and move --no-install.
490         * Scripts/webkitpy/port/factory.py:
491         (platform_options): Move --no-intall to run_webkit_tests.py.
492         * Scripts/webkitpy/port/ios.py:
493         (IOSPort):
494         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
495         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
496         * Scripts/webkitpy/port/ios_device.py:
497         (IOSDevicePort.ios_version): Consult --version flag before checking connected
498         devices for iOS version.
499         * Scripts/webkitpy/port/ios_device_unittest.py:
500         (IOSDeviceTest.make_port): Set --version option so that we can generate test
501         expectation paths without devices connected.
502         (IOSDeviceTest.test_additional_platform_directory): Deleted.
503         (IOSDeviceTest.test_baseline_searchpath): Deleted.
504         (IOSDeviceTest.test_expectations_ordering): Deleted.
505         * Scripts/webkitpy/port/ios_simulator.py:
506         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
507         flag to specify a runtime.
508         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
509         flag and then use the default runtime.
510
511 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
512
513         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
514         https://bugs.webkit.org/show_bug.cgi?id=174815
515
516         Reviewed by Carlos Alberto Lopez Perez.
517
518         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
519         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
520         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
521         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
522         think), probably because of a newer CMake version.
523
524         * CMakeLists.txt:
525         * TestWebKitAPI/CMakeLists.txt:
526         * TestWebKitAPI/PlatformGTK.cmake:
527
528 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
529
530         Fix BenchmarkRunner to only import selenium when needed
531         https://bugs.webkit.org/show_bug.cgi?id=174808
532
533         Reviewed by Stephanie Lewis.
534
535         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
536         (LinuxChromeDriver.launch_driver):
537         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
538         (LinuxFirefoxDriver.launch_driver):
539         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
540         (OSXChromeDriver.launch_driver):
541         (OSXChromeCanaryDriver.launch_driver):
542         (create_chrome_options):
543         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
544         (OSXFirefoxDriver.launch_driver):
545         (OSXFirefoxNightlyDriver.launch_driver):
546         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
547         (OSXSafariDriver.launch_driver):
548         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
549         (WebDriverBenchmarkRunner._run_one_test):
550
551 2017-07-23  Darin Adler  <darin@apple.com>
552
553         More NeverDestroyed and related cleanup
554         https://bugs.webkit.org/show_bug.cgi?id=174745
555
556         Reviewed by Alex Christensen.
557
558         * DumpRenderTree/JavaScriptThreading.cpp:
559         (javaScriptThreadsMutex): Use NeverDestroyed instead of
560         DEPRECATED_DEFINE_STATIC_LOCAL.
561         (javaScriptThreads): Ditto.
562
563 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
564
565         Subclass Benchmark Runner script for WebDriver support
566         https://bugs.webkit.org/show_bug.cgi?id=174390
567
568         Reviewed by Dewei Zhu, Stephanie Lewis.
569
570         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
571
572         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
573         (BenchmarkBuilder.__init__):
574         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
575         (BenchmarkRunner.__init__):
576         (BenchmarkRunner._find_plan_file):
577         (BenchmarkRunner._run_one_test.and):
578         (BenchmarkRunner.execute):
579         (BenchmarkRunner._get_result): Deleted.
580         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
581         (parse_args):
582         (start):
583         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
584         (WebDriverBenchmarkRunner):
585         (WebDriverBenchmarkRunner._get_result):
586         (WebDriverBenchmarkRunner._run_one_test):
587         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
588         (WebServerBenchmarkRunner):
589         (WebServerBenchmarkRunner.__init__):
590         (WebServerBenchmarkRunner._get_result):
591         (WebServerBenchmarkRunner._run_one_test):
592
593 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
594
595         Add BenchmarkRunner patches with WebDriver support for each testing plan
596         https://bugs.webkit.org/show_bug.cgi?id=174443
597
598         Reviewed by Dewei Zhu, Stephanie Lewis.
599
600         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
601         (BenchmarkBuilder.__enter__):
602         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
603         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
604         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
605         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
606         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
607         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
608         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
609         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
610         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
611         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
612         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
613         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
614         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
615         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
616         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
617         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
618         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
619         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
620         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
621         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
622         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
623         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
624         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
625         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
626         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
627         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
628         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
629         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
630         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
631         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
632         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
633         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
634         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
635
636 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
637
638         Add functions to autoinstaller needed for Benchmark Runner script
639         https://bugs.webkit.org/show_bug.cgi?id=174331
640
641         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
642
643         Adds autoinstaller functions to install selenium and webdriver binaries
644         which will be used by the browser driver part of Benchmark Runner.
645
646         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
647         (BrowserDriver.restore_env):
648         (BrowserDriver):
649         (BrowserDriver.get_webdriver_binary_path):
650         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
651         (LinuxChromeDriver.launch_driver):
652         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
653         (LinuxFirefoxDriver.launch_driver):
654         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
655         (OSXChromeDriver.launch_driver):
656         (OSXChromeCanaryDriver.launch_driver):
657         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
658         (OSXFirefoxDriver.launch_driver):
659         (OSXFirefoxNightlyDriver.launch_driver):
660         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
661         * Scripts/webkitpy/benchmark_runner/utils.py:
662         (get_driver_binary_path):
663         * Scripts/webkitpy/common/system/autoinstall.py:
664         (AutoInstaller._unzip):
665         * Scripts/webkitpy/thirdparty/__init__.py:
666         (AutoinstallImportHook.find_module):
667         (AutoinstallImportHook._install_selenium):
668         (AutoinstallImportHook):
669         (AutoinstallImportHook._install_chromedriver):
670         (AutoinstallImportHook._install_geckodriver):
671         (AutoinstallImportHook.get_latest_pypi_url):
672         (AutoinstallImportHook.install_binary):
673         (autoinstall_everything):
674         (get_driver_filename):
675         (get_os_info):
676
677 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
678
679         Add WebDriver support in browser driver part of BenchmarkRunner
680         https://bugs.webkit.org/show_bug.cgi?id=174445
681
682         Reviewed by Stephanie Lewis.
683
684         Adds a launch_driver function to each BrowserDriver subclass. This
685         function sets up the arguments for the webdriver and launches the
686         webdriver specific to that browser.
687
688         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
689         (BrowserDriver.launch_webdriver):
690         (BrowserDriver):
691         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
692         (LinuxBrowserDriver.launch_webdriver):
693         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
694         (LinuxChromeDriver.launch_url):
695         (LinuxChromeDriver):
696         (LinuxChromeDriver.launch_driver):
697         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
698         (EpiphanyBrowserDriver.launch_url):
699         (EpiphanyBrowserDriver):
700         (EpiphanyBrowserDriver.launch_driver):
701         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
702         (LinuxFirefoxDriver):
703         (LinuxFirefoxDriver.launch_url):
704         (LinuxFirefoxDriver.launch_driver):
705         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
706         (GTKMiniBrowserDriver.launch_url):
707         (GTKMiniBrowserDriver):
708         (GTKMiniBrowserDriver.launch_driver):
709         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
710         (OSXBrowserDriver._launch_webdriver):
711         (OSXBrowserDriver):
712         (OSXBrowserDriver._screen_size):
713         (OSXBrowserDriver._insert_url):
714         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
715         (OSXChromeDriver):
716         (OSXChromeDriver.launch_url):
717         (OSXChromeDriver.launch_driver):
718         (OSXChromeCanaryDriver):
719         (OSXChromeCanaryDriver.launch_url):
720         (OSXChromeCanaryDriver.launch_driver):
721         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
722         (OSXFirefoxDriver):
723         (OSXFirefoxDriver.launch_url):
724         (OSXFirefoxDriver.launch_driver):
725         (OSXFirefoxNightlyDriver):
726         (OSXFirefoxNightlyDriver.launch_url):
727         (OSXFirefoxNightlyDriver.launch_driver):
728         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
729         (OSXSafariDriver.launch_driver):
730
731 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
732
733         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
734         https://bugs.webkit.org/show_bug.cgi?id=174793
735
736         Reviewed by Tim Horton.
737
738         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
739         down. Without r219765, this test will dereference null and crash.
740
741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
742         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
743         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
744         (TEST):
745
746 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
747
748         [Win] Implement Authentication dialog in MiniBrowser
749         https://bugs.webkit.org/show_bug.cgi?id=174662
750
751         Reviewed by Alex Christensen.
752
753         * MiniBrowser/win/Common.cpp:
754         (CustomUserAgent):
755         (DisplayAuthDialog):
756         (AuthDialogProc):
757         * MiniBrowser/win/MiniBrowserLib.rc:
758         * MiniBrowser/win/MiniBrowserLibResource.h:
759         * MiniBrowser/win/ResourceLoadDelegate.cpp:
760         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
761
762 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
763
764         Handle case where line_numbers is None instead of an array of line numbers
765         https://bugs.webkit.org/show_bug.cgi?id=174775
766
767         Reviewed by Aakash Jain.
768
769         Added files set line_numbers to None in process_file.
770
771         * Scripts/webkitpy/style/filereader.py:
772         (TextFileReader.process_file): Handle case where line_number is set to None.
773         * Scripts/webkitpy/style/main_unittest.py:
774         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
775
776 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
777
778         [WPE] Add libepoxy to the Jhbuild moduleset
779         https://bugs.webkit.org/show_bug.cgi?id=174711
780
781         Reviewed by Carlos Alberto Lopez Perez.
782
783         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
784
785 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
786
787         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
788         https://bugs.webkit.org/show_bug.cgi?id=174780
789
790         Reviewed by Carlos Garcia Campos.
791
792         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
793         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
794         in case the eglplatform.h header doesn't provide that macro. This replicates
795         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
796
797 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
798
799         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
800         https://bugs.webkit.org/show_bug.cgi?id=174758
801
802         Reviewed by Dan Bernstein.
803
804         Migrate position-information-related unit tests from the PositionInformationTests suite to
805         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
806
807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
808         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
809         (TestWebKitAPI::checkElementTypeAndBoundingRect):
810         (TestWebKitAPI::TEST):
811         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
812         * TestWebKitAPI/cocoa/TestWKWebView.h:
813         * TestWebKitAPI/cocoa/TestWKWebView.mm:
814         (-[TestWKWebView activatedElementAtPosition:]):
815
816 2017-07-22  Chris Dumez  <cdumez@apple.com>
817
818         REGRESSION(r204565): WKObject is broken
819         https://bugs.webkit.org/show_bug.cgi?id=174736
820         <rdar://problem/33246169>
821
822         Reviewed by Dan Bernstein.
823
824         Add API test that used to crash.
825
826         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
827         (TestWebKitAPI::TEST):
828
829 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
830
831         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
832         https://bugs.webkit.org/show_bug.cgi?id=174705
833
834         Reviewed by Mark Lam.
835
836         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
837         (TestWebKitAPI::testThreadGroup):
838         (TestWebKitAPI::TEST):
839
840 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
841
842         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
843         https://bugs.webkit.org/show_bug.cgi?id=174724
844
845         Reviewed by Aakash Jain.
846
847         * Scripts/webkitpy/port/ios_simulator.py:
848         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
849         simulator. Errors here should be treated the same as no simulators found.
850
851 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
852
853         [CMake] Add an option to stop build after generating project files
854         https://bugs.webkit.org/show_bug.cgi?id=174664
855
856         Reviewed by Konstantin Tokarev.
857
858         Add "--generate-project-only" to stop build after generating project files.
859
860         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
861         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
862         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
863         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
864         (isGenerateProjectOnly): ditto
865
866 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
867
868         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
869         https://bugs.webkit.org/show_bug.cgi?id=174501
870
871         Reviewed by Darin Adler.
872
873         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
874         (TestWebKitAPI::TEST):
875
876 2017-07-20  David Quesada  <david_quesada@apple.com>
877
878         Add SPI to notify WKNavigationDelegate about client redirects
879         https://bugs.webkit.org/show_bug.cgi?id=174680
880         rdar://problem/33184886
881
882         Reviewed by Brady Eidson.
883
884         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
885         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
886         (TEST):
887         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
888
889 2017-07-20  Brady Eidson  <beidson@apple.com>
890
891         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
892         https://bugs.webkit.org/show_bug.cgi?id=174685
893
894         Reviewed by Andy Estes.
895
896         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
897         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
898
899 2017-07-20  Brady Eidson  <beidson@apple.com>
900
901         Deprecate WebIconDatabase in WebKitLegacy/mac.
902         https://bugs.webkit.org/show_bug.cgi?id=174607
903
904         Reviewed by Alex Christensen.
905
906         * DumpRenderTree/mac/TestRunnerMac.mm:
907
908 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
909
910         lint-test-expectations should be run during style checking
911         https://bugs.webkit.org/show_bug.cgi?id=173559
912         <rdar://problem/32854941>
913
914         Reviewed by Aakash Jain.
915
916         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
917         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
918         prevents identifying errors on specific lines in a file.
919         * Scripts/webkitpy/style/main_unittest.py:
920         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
921         case where a linter error is in the file modified, but the line modified is not related to
922         the linter error.
923
924 2017-07-20  Brady Eidson  <beidson@apple.com>
925
926         Remove WebIconDatabase from WebKitLegacy/win.
927         https://bugs.webkit.org/show_bug.cgi?id=174608
928
929         Reviewed by Alex Christensen.
930
931         * DumpRenderTree/win/DumpRenderTree.cpp:
932         (main):
933         * DumpRenderTree/win/TestRunnerWin.cpp:
934         (TestRunner::setIconDatabaseEnabled):
935
936 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
937
938         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
939         https://bugs.webkit.org/show_bug.cgi?id=174671
940
941         Reviewed by Carlos Garcia Campos.
942
943         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
944         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
945         priority for this source in order to have it dispatched on the same
946         priority as the other WebKit-controlled GSource objects.
947
948 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
949
950         lint-test-expectations should be run during style checking
951         https://bugs.webkit.org/show_bug.cgi?id=173559
952         <rdar://problem/32854941>
953
954         Reviewed by Daniel Bates.
955
956         Follow up fix addressing style and a few minor bugs.
957
958         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
959         (TestExpectationParser.__init__): Use lambda x: x instead of str
960         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
961         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
962         reduce the calls of _shorten_filename, fix minor bug in appending the current
963         expectation's line number instead of the previous ones, clarify treatment of None
964         in file-to-line-number mapping.
965         (TestExpectations._report_warnings): Collapse call.
966         * Scripts/webkitpy/style/checkers/test_expectations.py:
967         (TestExpectationsChecker.lint_test_expectations):
968         * Scripts/webkitpy/style/filereader.py: Re-write comment.
969         (TextFileReader.process_file): Add comment explaining treatment of None in
970         file-to-line-number mapping.
971         (TextFileReader.delete_file): Collapse call.
972
973 2017-07-19  Chris Dumez  <cdumez@apple.com>
974
975         Unreviewed attempt to fix API test failure after r219663.
976
977         The test was hard-coding an exception string and the string has changed slightly
978         in r219663.
979
980         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
981         (TEST):
982
983 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
984
985         Don't write file URLs to iOS Pasteboard
986         https://bugs.webkit.org/show_bug.cgi?id=174647
987         <rdar://problem/33199730>
988
989         Reviewed by Wenson Hsieh.
990
991         Updating tests to reflect the lack of file URLs for images.
992
993         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
994         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
995         (checkEstimatedSize):
996         (TestWebKitAPI::TEST):
997
998 2017-07-19  Brady Eidson  <beidson@apple.com>
999
1000         iBooks sometimes crashes when closing a book.
1001         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1002
1003         Reviewed by Oliver Hunt.
1004
1005         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1006         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1007         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1008         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1009         (TestWebKitAPI::TEST):
1010
1011         Add a "spin the runloop X number of times" utility:
1012         * TestWebKitAPI/Utilities.h:
1013         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1014         (TestWebKitAPI::Util::spinRunLoop):
1015
1016 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1017
1018         lint-test-expectations should be run during style checking
1019         https://bugs.webkit.org/show_bug.cgi?id=173559
1020         <rdar://problem/32854941>
1021
1022         Reviewed by David Kilzer.
1023
1024         Running the test expectation linter requires reading both files and lines not in the
1025         patch because, for example, deletion of a test can cause a lint failure even though
1026         no test expectations where modified. This means that the linter will occasionally warn
1027         about lines which were not changed in a given patch but whose error is related to a
1028         change made in that patch.
1029
1030         * Scripts/webkitpy/common/system/filesystem_mock.py:
1031         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1032         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1033         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1034         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1035         content, description of the error and the name of the associated test.
1036         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1037         (TestExpectationParser.__init__): Pass shorten_filename function to
1038         TestExpectationsParser to add a deleted file to the related_files dictionary.
1039         (TestExpectationParser._check_test_exists): If the test does not exist, add the
1040         missing path to the related_files dictionary.
1041         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1042         files and line numbers related to this test expectation line. This will allow
1043         tracking linter errors in the style checker occurring across multiple files.
1044         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1045         lines to related_files dictionary.
1046         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1047         (TestExpectations._report_warnings): Construct warning object instead of string
1048         when adding to warnings list.
1049         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1050         clean-up log.
1051         * Scripts/webkitpy/style/checker.py:
1052         (ProcessorBase.do_association_check): Add required function for processor classes.
1053         (StyleProcessor):
1054         (StyleProcessor.do_association_check): Run the TestExpectations linter when
1055         checking for errors between associated files.
1056         * Scripts/webkitpy/style/checkers/test_expectations.py:
1057         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1058         (TestExpectationsChecker):
1059         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1060         of modified files, the current working directory and the host, determine if the linter
1061         warning is associated with the changes.
1062         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1063         style checker.
1064         * Scripts/webkitpy/style/filereader.py:
1065         (TextFileReader):
1066         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1067         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1068         (TextFileReader.process_file): Track both the number of files changed and which lines
1069         in those files were changed.
1070         (TextFileReader.do_association_check): Run the processor's association check on all
1071         modified or deleted files processed by TextFileReader.
1072         (TextFileReader.delete_file): Track deleted files in _files dictionary.
1073         (TextFileReader.count_delete_only_file): Deleted.
1074         * Scripts/webkitpy/style/filereader_unittest.py:
1075         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1076         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1077         * Scripts/webkitpy/style/main.py:
1078         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1079         explicitly run the association check on the file reader.
1080         * Scripts/webkitpy/style/main_unittest.py:
1081         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1082         embedded in the style checker.
1083         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1084         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1085         construct the TextFileReader object with a StyleProcessor used to run style checks on
1086         specific files.
1087         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1088         testing the test expectation linter inside the style checker. This host must contain a
1089         mock file system with the basic structure of test expectations.
1090         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1091         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1092         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1093         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1094         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1095         * Scripts/webkitpy/style/patchreader.py:
1096         (PatchReader.check): Specify which file was deleted, run the association check.
1097         * Scripts/webkitpy/style/patchreader_unittest.py:
1098         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1099         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1100         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1101
1102 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1103
1104         [WTF] Implement WTF::ThreadGroup
1105         https://bugs.webkit.org/show_bug.cgi?id=174081
1106
1107         Reviewed by Mark Lam.
1108
1109         Add WTF::ThreadGroup tests.
1110
1111         * TestWebKitAPI/CMakeLists.txt:
1112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1113         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1114         (TestWebKitAPI::testThreadGroup):
1115         (TestWebKitAPI::TEST):
1116
1117 2017-07-18  Andy Estes  <aestes@apple.com>
1118
1119         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1120         https://bugs.webkit.org/show_bug.cgi?id=174631
1121
1122         Reviewed by Tim Horton.
1123
1124         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1125         * MiniBrowser/Configurations/Base.xcconfig:
1126         * MobileMiniBrowser/Configurations/Base.xcconfig:
1127         * TestWebKitAPI/Configurations/Base.xcconfig:
1128         * WebKitTestRunner/Configurations/Base.xcconfig:
1129
1130 2017-07-18  Andy Estes  <aestes@apple.com>
1131
1132         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1133         https://bugs.webkit.org/show_bug.cgi?id=174631
1134
1135         Reviewed by Sam Weinig.
1136
1137         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1138         * MiniBrowser/Configurations/Base.xcconfig:
1139         * MobileMiniBrowser/Configurations/Base.xcconfig:
1140         * TestWebKitAPI/Configurations/Base.xcconfig:
1141         * WebKitTestRunner/Configurations/Base.xcconfig:
1142
1143 2017-07-18  Daniel Bates  <dabates@apple.com>
1144
1145         lldb: Add type summary for StringView
1146         https://bugs.webkit.org/show_bug.cgi?id=174637
1147
1148         Reviewed by Sam Weinig.
1149
1150         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
1151         StringView object will print output that has the form:
1152
1153             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
1154               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
1155               m_length = 2
1156               m_is8Bit = true
1157               m_underlyingString = 0x0000614000000a90
1158             }
1159
1160         * lldb/lldb_webkit.py:
1161         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
1162         (WTFStringView_SummaryProvider):
1163         (WTFStringViewProvider):
1164         (WTFStringViewProvider.__init__):
1165         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
1166         (WTFStringViewProvider.get_length): Access field StringView.m_length.
1167         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
1168         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
1169
1170 2017-07-18  Andy Estes  <aestes@apple.com>
1171
1172         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1173         https://bugs.webkit.org/show_bug.cgi?id=174631
1174
1175         Reviewed by Dan Bernstein.
1176
1177         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1178         * MiniBrowser/Configurations/Base.xcconfig:
1179         * MobileMiniBrowser/Configurations/Base.xcconfig:
1180         * TestWebKitAPI/Configurations/Base.xcconfig:
1181         * WebKitTestRunner/Configurations/Base.xcconfig:
1182
1183 2017-07-18  Devin Rousso  <drousso@apple.com>
1184
1185         Web Inspector: Add memoryCost to Inspector Protocol objects
1186         https://bugs.webkit.org/show_bug.cgi?id=174478
1187
1188         Reviewed by Joseph Pecoraro.
1189
1190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1191         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
1192         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
1193         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
1194         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
1195         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
1196         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
1197         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
1198         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
1199         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
1200         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
1201         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
1202         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
1203         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
1204         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
1205         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
1206         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
1207
1208 2017-07-18  Andy Estes  <aestes@apple.com>
1209
1210         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1211         https://bugs.webkit.org/show_bug.cgi?id=174631
1212
1213         Reviewed by Darin Adler.
1214
1215         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1216         * MiniBrowser/Configurations/Base.xcconfig:
1217         * MobileMiniBrowser/Configurations/Base.xcconfig:
1218         * TestWebKitAPI/Configurations/Base.xcconfig:
1219         * WebKitTestRunner/Configurations/Base.xcconfig:
1220
1221 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1222
1223         Unreviewed, fix the iOS build.
1224
1225         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
1226
1227         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1228         (TestWebKitAPI::TEST):
1229
1230 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1231
1232         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
1233         https://bugs.webkit.org/show_bug.cgi?id=174585
1234         <rdar://problem/33302541>
1235
1236         Reviewed by Tim Horton.
1237
1238         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
1239         being dragged when initiating a drag.
1240
1241         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1242         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
1243         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1244         (TestWebKitAPI::TEST):
1245         * TestWebKitAPI/cocoa/TestWKWebView.h:
1246
1247         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
1248
1249         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1250         (-[TestWKWebView synchronouslyLoadHTMLString:]):
1251
1252 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1253
1254         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
1255         https://bugs.webkit.org/show_bug.cgi?id=174547
1256
1257         Reviewed by Alex Christensen.
1258
1259         * DumpRenderTree/PlatformWin.cmake:
1260         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1261
1262 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1263
1264         Update style checker to deal with "final"
1265         https://bugs.webkit.org/show_bug.cgi?id=174528
1266
1267         Reviewed by Alex Christensen.
1268         
1269         check-webkit-style shouldn't complain about an open brace to start a
1270         line after a function definition with "final" or "const final".
1271
1272         * Scripts/webkitpy/style/checkers/cpp.py:
1273         (check_braces):
1274         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1275         (CppStyleTest.test_brace_at_begin_of_line):
1276
1277 2017-07-17  Alex Christensen  <achristensen@webkit.org>
1278
1279         Modernize content extension code
1280         https://bugs.webkit.org/show_bug.cgi?id=174588
1281
1282         Reviewed by Sam Weinig.
1283
1284         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1285         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1286         (TestWebKitAPI::testRequest):
1287         (TestWebKitAPI::makeBackend):
1288         (TestWebKitAPI::TEST_F):
1289
1290 2017-07-17  Brady Eidson  <beidson@apple.com>
1291
1292         WKHTTPCookieStore observing only works on the default cookie store.
1293         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
1294
1295         Reviewed by Sam Weinig.
1296
1297         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1298         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
1299           called for the default store, a non-persistent store, and a custom store.
1300         (TEST):
1301
1302 2017-07-16  Sam Weinig  <sam@webkit.org>
1303
1304         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
1305         https://bugs.webkit.org/show_bug.cgi?id=174575
1306
1307         Reviewed by Brady Eidson.
1308
1309         * Scripts/svn-create-patch:
1310         (findModificationType):
1311         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
1312         default value of "unknown".
1313
1314         (generateFileList):
1315         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
1316         for untracked, which matches our old behavior.
1317
1318 2017-07-17  Charlie Turner  <cturner@igalia.com>
1319
1320         Add some missing build dependencies on Fedora
1321         https://bugs.webkit.org/show_bug.cgi?id=174578
1322
1323         Unreviewed dependency update.
1324
1325         * gtk/install-dependencies:
1326
1327 2017-07-16  Brady Eidson  <beidson@apple.com>
1328
1329         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
1330         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
1331
1332         Reviewed by Tim Horton.
1333
1334         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1335         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
1336         (TEST):
1337
1338 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
1339
1340         [GTK] Sort inspector GResource manifest to ensure reproducible builds
1341         https://bugs.webkit.org/show_bug.cgi?id=174540
1342
1343         Reviewed by Michael Catanzaro.
1344
1345         * gtk/generate-inspector-gresource-manifest.py:
1346         (get_filenames): sort list of input files
1347
1348 2017-07-15  Brady Eidson  <beidson@apple.com>
1349
1350         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
1351         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
1352
1353         Reviewed by Tim Horton.
1354
1355         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1356         (TEST): Make this test more reliable by clearing everything beforehand.
1357
1358 2017-07-15  David Kilzer  <ddkilzer@apple.com>
1359
1360         Make it possible to extend check-webkit-style with Apple-internal checkers
1361         <https://webkit.org/b/174464>
1362         <rdar://problem/25564402>
1363
1364         Reviewed by Darin Adler.
1365
1366         * Scripts/webkitpy/style/checker.py: Import apple_additions.
1367         (_all_categories): Add categories from apple_additions() if it
1368         exists.
1369         (CheckerDispatcher._create_checker): Create python checker
1370         from apple_additions() if it exists.
1371
1372 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1373
1374         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
1375         https://bugs.webkit.org/show_bug.cgi?id=174539
1376         <rdar://problem/33307395>
1377
1378         Reviewed by Darin Adler.
1379
1380         Adds a new unit test suite to cover action sheet popover presentation.
1381
1382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1383         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
1384         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
1385         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
1386
1387         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
1388
1389         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
1390         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1391
1392         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
1393
1394         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1395         (TestWebKitAPI::TEST):
1396
1397 2017-07-15  Sam Weinig  <sam@webkit.org>
1398
1399         [Scripts] Make svn-create-patch work better when called in sub directories
1400         https://bugs.webkit.org/show_bug.cgi?id=174551
1401
1402         Reviewed by Darin Adler.
1403
1404         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
1405           by ensuring that the prefix is applied as is done in generateDiff.
1406         - Silence output of explanatory lines from svn stat (" > move to ...")
1407           that show up in STDERR when running svn-create-patch.
1408         - Add verbose logging that I found useful while debugging this issue.
1409
1410         * Scripts/svn-create-patch:
1411         (findBaseUrl):
1412         (findMimeType):
1413         (findSourceFileAndRevision):
1414         (generateDiff):
1415         (generateFileList):
1416         (manufacturePatchForAdditionWithHistory):
1417
1418 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
1419
1420         Unreviewed build fix after r219537.
1421
1422         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1423
1424 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1425
1426         Add iOS 11 SPI
1427         https://bugs.webkit.org/show_bug.cgi?id=174430
1428         <rdar://problem/33269288>
1429
1430         Reviewed by Tim Horton.
1431
1432         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
1433         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
1434         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
1435
1436 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1437
1438         Failing to install on iPad simulators
1439         https://bugs.webkit.org/show_bug.cgi?id=174532
1440         <rdar://problem/33328347>
1441
1442         Reviewed by Stephanie Lewis.
1443
1444         * Scripts/webkitpy/xcode/simulated_device.py:
1445         (SimulatedDevice.install_app): Place install command in retry try-except block.
1446
1447 2017-07-14  Jeff Miller  <jeffm@apple.com>
1448
1449         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1450         https://bugs.webkit.org/show_bug.cgi?id=174524
1451
1452         Reviewed by Sam Weinig.
1453
1454         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1455         (TEST):
1456         Renamed TestParameter to TestParameter1.
1457         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1458
1459         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1460         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1461         Observe changes for two bundle parameters.
1462
1463         (-[BundleParametersPlugIn dealloc]):
1464         Remove observers for two bundle parameters.
1465
1466 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1467
1468         Unreviewed, rolling out r219510.
1469         https://bugs.webkit.org/show_bug.cgi?id=174525
1470
1471         Need to revert length() == 0 check for null string (Requested
1472         by yusukesuzuki on #webkit).
1473
1474         Reverted changeset:
1475
1476         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1477         static string if StringImpl is static"
1478         https://bugs.webkit.org/show_bug.cgi?id=174501
1479         http://trac.webkit.org/changeset/219510
1480
1481 2017-07-14  Jer Noble  <jer.noble@apple.com>
1482
1483         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1484         https://bugs.webkit.org/show_bug.cgi?id=174514
1485
1486         Reviewed by Sam Weinig.
1487
1488         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1489         (TestWebKitAPI::TEST_F):
1490
1491 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1492
1493         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1494         https://bugs.webkit.org/show_bug.cgi?id=174501
1495
1496         Reviewed by Darin Adler.
1497
1498         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1499         (TestWebKitAPI::TEST):
1500
1501 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1502
1503         Bring mac expectations in-line with other platforms
1504         https://bugs.webkit.org/show_bug.cgi?id=174472
1505         <rdar://problem/33297388>
1506
1507         Reviewed by David Kilzer.
1508
1509         The override order for Mac test expectations does not conform to the pattern used by iOS,
1510         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1511
1512             platform/mac-wk2
1513             platform/wk2
1514             platform/mac-elcapitan
1515             platform/mac-sierra
1516             generic
1517
1518         After this change, El Capitan's baseline search path looks like this:
1519
1520             platform/mac-sierra-wk2
1521             platform/mac-sierra
1522             platform/mac-wk2
1523             platform/wk2
1524             generic
1525
1526         * Scripts/webkitpy/port/mac.py:
1527         (MacPort.__init__): If a specific version is specified in the port name, use that
1528         as the os version.
1529         (MacPort.default_baseline_search_path): Expectation search paths should work the
1530         same way they do on other ports. Port + version overrides port, port overrides generic
1531         and wk1/wk2 should override expectations for the two combined.
1532         * Scripts/webkitpy/port/mac_unittest.py:
1533         (MacTest.test_tests_for_other_platforms): Deleted.
1534         (MacTest._assert_search_path): Deleted.
1535         (MacTest.test_baseline_search_path): Deleted.
1536         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1537         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1538         (test_rebaseline_test_and_print_scm_changes): Ditto.
1539         (test_rebaseline_and_copy_test): Ditto.
1540         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1541         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1542         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1543
1544 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1545
1546         Fix style checker unit test
1547
1548         Unreviewed WebKit2 => WebKit fixup.
1549
1550         * Scripts/webkitpy/style/checker_unittest.py:
1551         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1552
1553 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1554
1555         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1556
1557         Unreviewed build fix.
1558
1559         r219492 missed one hunk from its partial revert of r219489.
1560         This patch reverts that hunk.
1561
1562         * TestWebKitAPI/CMakeLists.txt:
1563
1564 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1565
1566         Use the old WebKit/WebKit2 targets for CMake builds.
1567
1568         Unreviewed build fix.
1569
1570         We can update the target names to match the Framework names in a future patch.
1571         This is a partial revert of r219489.
1572
1573         * TestWebKitAPI/CMakeLists.txt:
1574         WebKitLegacy => WebKit
1575         WebKit => WebKit2
1576
1577 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1578
1579         Fix TestWebKit API.
1580         https://bugs.webkit.org/show_bug.cgi?id=174164
1581         rdar://problem/33137595
1582
1583         Reviewed by Dan Bernstein.
1584
1585         * TestWebKitAPI/CMakeLists.txt:
1586         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1587         * TestWebKitAPI/PlatformGTK.cmake:
1588
1589 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1590
1591         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1592         https://bugs.webkit.org/show_bug.cgi?id=174164
1593         rdar://problem/33137595
1594
1595         Reviewed by Dan Bernstein.
1596
1597         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1598         (ShouldBuildTest):
1599         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1600         * Scripts/build-webkit:
1601         * Scripts/do-file-rename:
1602         * Scripts/do-webcore-rename:
1603         * Scripts/update-webkit-localizable-strings:
1604         * Scripts/webkitpy/common/config/watchlist:
1605         * Scripts/webkitpy/style/checker.py:
1606         * Scripts/webkitpy/style/checkers/featuredefines.py:
1607         * gtk/make-dist.py:
1608         (ensure_version_if_possible):
1609         * gtk/manifest.txt.in:
1610
1611 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1612
1613         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1614         https://bugs.webkit.org/show_bug.cgi?id=174162
1615         rdar://problem/33137594
1616
1617         Reviewed by Dan Bernstein.
1618
1619         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
1620
1621         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1622         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1623         * EWSTools/configure-clang-linux.sh:
1624         * Scripts/build-webkit:
1625         * Scripts/do-file-rename:
1626         * Scripts/do-webcore-rename:
1627         * Scripts/update-webkit-localizable-strings:
1628         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1629         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1630         * Scripts/webkitpy/style/checkers/featuredefines.py:
1631         * gtk/manifest.txt.in:
1632
1633 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
1634
1635         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
1636         https://bugs.webkit.org/show_bug.cgi?id=174438
1637         <rdar://problem/33277112>
1638
1639         Reviewed by Aakash Jain.
1640
1641         Given a patch, this will convert the changes from the path to the new directory structure.
1642
1643         * Scripts/rebase-patch-after-webkit-move: Added.
1644         (append_source): Append 'Source' to the provided path.
1645         (is_editable_line): Return true if a line the script expects to modify.
1646         (needs_rebase): Return if a line needs to be rebased based on it's content.
1647         (rebase_line): Rebase the provided line.
1648         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
1649         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
1650         were provided.
1651
1652 2017-07-12  Nan Wang  <n_wang@apple.com>
1653
1654         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1655         https://bugs.webkit.org/show_bug.cgi?id=174393
1656         <rdar://problem/33248006>
1657
1658         Reviewed by Chris Fleizach.
1659
1660         * DumpRenderTree/AccessibilityUIElement.cpp:
1661         (textMarkerRangeMatchesTextNearMarkersCallback):
1662         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1663         (AccessibilityUIElement::getJSClass):
1664         * DumpRenderTree/AccessibilityUIElement.h:
1665         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1666         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1667         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1668         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1669         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1670         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1671         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1672         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1673
1674 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1675
1676         Unreviewed, rolling out r219409.
1677
1678         The revision caused the Windows builds to fail.
1679
1680         Reverted changeset:
1681
1682         "AX: [iOS] Implement a way to retrieve a text marker range
1683         with desired text that is closest to a position"
1684         https://bugs.webkit.org/show_bug.cgi?id=174393
1685         http://trac.webkit.org/changeset/219409
1686
1687 2017-07-12  Nan Wang  <n_wang@apple.com>
1688
1689         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1690         https://bugs.webkit.org/show_bug.cgi?id=174393
1691         <rdar://problem/33248006>
1692
1693         Reviewed by Chris Fleizach.
1694
1695         * DumpRenderTree/AccessibilityUIElement.cpp:
1696         (textMarkerRangeMatchesTextNearMarkersCallback):
1697         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1698         (AccessibilityUIElement::getJSClass):
1699         * DumpRenderTree/AccessibilityUIElement.h:
1700         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1701         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1702         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1703         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1704         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1705         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1706         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1707         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1708
1709 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
1710
1711         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
1712         https://bugs.webkit.org/show_bug.cgi?id=174197
1713
1714         Reviewed by Darin Adler.
1715
1716         This bit me the first time I tried to submit a patch to WebKit, and still I have
1717         to manually edit the ChangeLog every time I use the script.
1718
1719         This generates a more convenient and standard ChangeLog entry.
1720
1721         * Scripts/prepare-ChangeLog:
1722         (generateNewChangeLogs):
1723
1724 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1725
1726         Unreviewed, rolling out r219401.
1727
1728         This revision rolled out the previous patch, but after talking
1729         with reviewer, a rebaseline is what was needed.Rolling back in
1730         before rebaseline.
1731
1732         Reverted changeset:
1733
1734         "Unreviewed, rolling out r219379."
1735         https://bugs.webkit.org/show_bug.cgi?id=174400
1736         http://trac.webkit.org/changeset/219401
1737
1738 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1739
1740         Unreviewed, rolling out r219379.
1741
1742         This revision caused a consistent failure in the test
1743         fast/dom/Window/property-access-on-cached-window-after-frame-
1744         removed.html.
1745
1746         Reverted changeset:
1747
1748         "Remove NAVIGATOR_HWCONCURRENCY"
1749         https://bugs.webkit.org/show_bug.cgi?id=174400
1750         http://trac.webkit.org/changeset/219379
1751
1752 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1753
1754         [WPE] Use libepoxy
1755         https://bugs.webkit.org/show_bug.cgi?id=172104
1756
1757         Reviewed by Michael Catanzaro.
1758
1759         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
1760         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
1761
1762 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1763
1764         [GTK][WPE] Align Jhbuild patches for GStreamer packages
1765         https://bugs.webkit.org/show_bug.cgi?id=174363
1766
1767         Reviewed by Michael Catanzaro.
1768
1769         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
1770         between the GTK+ and WPE port. There's no reason for the two ports to apply
1771         different patches over same versions of GStreamer releases.
1772
1773         This aligns the two ports on this specific issue. Next we'll look into
1774         creating a single GStreamer-specific Jhbuild moduleset that will allow us
1775         to keep these patches in a single place, avoiding duplicate files.
1776
1777         * gtk/jhbuild.modules:
1778         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1779         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
1780         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1781         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
1782
1783 2017-07-11  Dean Jackson  <dino@apple.com>
1784
1785         Remove NAVIGATOR_HWCONCURRENCY
1786         https://bugs.webkit.org/show_bug.cgi?id=174400
1787
1788         Reviewed by Sam Weinig.
1789
1790         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1791
1792 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
1793
1794         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
1795         https://bugs.webkit.org/show_bug.cgi?id=174239
1796
1797         Reviewed by Brady Eidson.
1798
1799         Create windows with specific features set and make sure those are properly reflected in the
1800         WKWindowFeatures object.
1801
1802         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1803         (resetToConsistentState):
1804         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1805         (TEST):
1806
1807 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
1808
1809         Do not duplicate files when deleting directories with svn 1.9
1810         https://bugs.webkit.org/show_bug.cgi?id=174339
1811         <rdar://problem/33226781>
1812
1813         Reviewed by David Kilzer.
1814
1815         * Scripts/svn-create-patch:
1816         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
1817         (generateFileList): Determine which files are deleted because they are part of a
1818         directory being deleted.
1819
1820 2017-07-11  Dean Jackson  <dino@apple.com>
1821
1822         Rolling out r219372.
1823
1824         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1825
1826 2017-07-11  Dean Jackson  <dino@apple.com>
1827
1828         Remove NAVIGATOR_HWCONCURRENCY
1829         https://bugs.webkit.org/show_bug.cgi?id=174400
1830
1831         Reviewed by Sam Weinig.
1832
1833         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1834
1835 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1836
1837         Teach build workers to fetch archives from S3.
1838         https://bugs.webkit.org/show_bug.cgi?id=174384
1839
1840         Reviewed by Aakash Jain.
1841
1842         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1843         (DownloadBuiltProduct):
1844
1845 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1846
1847         Configure buildbot to transfer all archives to S3.
1848         Previously this was Mac only, but it's time to expand!
1849         https://bugs.webkit.org/show_bug.cgi?id=174378
1850         
1851         Reviewed by Aakash Jain.
1852
1853         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1854         (BuildFactory.__init__):
1855
1856 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
1857
1858         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
1859         https://bugs.webkit.org/show_bug.cgi?id=174350
1860
1861         Reviewed by Xabier Rodriguez-Calvar.
1862
1863         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
1864         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
1865         patches are removed. The patches for gst-plugins-good are updated, removing
1866         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
1867         rtpbin elements that will help with the EMEv3 development.
1868
1869         * wpe/jhbuild.modules:
1870         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1871         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1872         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1873         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1874         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1875         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1876         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1877         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1878         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1879
1880 2017-07-10  John Wilander  <wilander@apple.com>
1881
1882         Resource Load Statistics: Prune statistics in orders of importance
1883         https://bugs.webkit.org/show_bug.cgi?id=174215
1884         <rdar://problem/33164403>
1885
1886         Reviewed by Chris Dumez.
1887
1888         Nest infrastructure. Adds these functions:
1889         1. testRunner.setStatisticsLastSeen()
1890         2. setStatisticsMaxStatisticsEntries()
1891         3. setStatisticsPruneEntriesDownTo()
1892
1893         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1894         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1895         (WTR::TestRunner::setStatisticsLastSeen):
1896         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1897         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1898         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1899         * WebKitTestRunner/TestController.cpp:
1900         (WTR::TestController::setStatisticsLastSeen):
1901         (WTR::TestController::setMaxStatisticsEntries):
1902         (WTR::TestController::setPruneEntriesDownTo):
1903         * WebKitTestRunner/TestController.h:
1904         * WebKitTestRunner/TestInvocation.cpp:
1905         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1906         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1907         (WTR::TestController::setStatisticsLastSeen):
1908         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1909         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1910
1911 2017-07-03  Brian Burg  <bburg@apple.com>
1912
1913         Web Replay: remove some unused code
1914         https://bugs.webkit.org/show_bug.cgi?id=173903
1915
1916         Rubber-stamped by Joseph Pecoraro.
1917
1918         * Scripts/run-input-generator-tests: Removed.
1919         * Scripts/webkitpy/replay/__init__.py: Removed.
1920         * Scripts/webkitpy/replay/main.py: Removed.
1921
1922 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1923
1924         [WPE] Fix layout test baseline and TestExpectations hierarchy
1925         https://bugs.webkit.org/show_bug.cgi?id=174092
1926
1927         Reviewed by Michael Catanzaro.
1928
1929         Like for the GTK+ port, override the default_baseline_search_path() and
1930         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1931         Both methods operate on a short list of search paths that defaults to 'wpe' and
1932         'wk2', along with any other user-specified platform directory.
1933
1934         The test_expectations_file_position() method is overridden for testing purposes,
1935         and relevant unit tests are added.
1936
1937         * Scripts/webkitpy/port/wpe.py:
1938         (WPEPort._search_paths):
1939         (WPEPort):
1940         (WPEPort.default_baseline_search_path):
1941         (WPEPort._port_specific_expectations_files):
1942         (WPEPort.test_expectations_file_position):
1943         * Scripts/webkitpy/port/wpe_unittest.py:
1944         (WPEPortTest.test_default_baseline_search_path):
1945         (WPEPortTest):
1946         (WPEPortTest.test_port_specific_expectations_files):
1947
1948 2017-07-10  Chris Dumez  <cdumez@apple.com>
1949
1950         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
1951         https://bugs.webkit.org/show_bug.cgi?id=174301
1952
1953         Reviewed by Brent Fulgham.
1954
1955         Rename some of the testRunner API for clarity and to better match what it calls
1956         internally.
1957
1958         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1959         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1960         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1961         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1962         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1963         * WebKitTestRunner/TestController.cpp:
1964         (WTR::TestController::statisticsUpdateCookiePartitioning):
1965         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1966         * WebKitTestRunner/TestController.h:
1967         * WebKitTestRunner/TestInvocation.cpp:
1968         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1969         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1970         (WTR::TestController::statisticsUpdateCookiePartitioning):
1971         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1972
1973 2017-07-10  Charlie Turner  <cturner@igalia.com>
1974
1975         [GStreamer] Live twitch.tv videos do not play
1976         https://bugs.webkit.org/show_bug.cgi?id=174222
1977
1978         Reviewed by Michael Catanzaro.
1979
1980         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1981         fixes videos not playing on twitch.tv.
1982
1983         * gtk/jhbuild.modules:
1984
1985 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1986
1987         Add WebGL2 configuration option to build-webkit
1988         https://bugs.webkit.org/show_bug.cgi?id=174251
1989
1990         Reviewed by Michael Catanzaro.
1991
1992         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1993         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1994         is marked as enabled for the Apple Cocoa ports.
1995
1996 2017-07-08  Chris Dumez  <cdumez@apple.com>
1997
1998         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1999         https://bugs.webkit.org/show_bug.cgi?id=174290
2000
2001         Reviewed by Brent Fulgham.
2002
2003         Rename testRunner API to match the new internal API names.
2004
2005         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2006         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2007         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2008         (WTR::TestRunner::statisticsSubmitTelemetry):
2009         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2010         * WebKitTestRunner/TestController.cpp:
2011         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2012         (WTR::TestController::statisticsSubmitTelemetry):
2013         * WebKitTestRunner/TestController.h:
2014         * WebKitTestRunner/TestInvocation.cpp:
2015         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2016         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2017         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2018         (WTR::TestController::statisticsSubmitTelemetry):
2019
2020 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2021
2022         Drop NOSNIFF compile flag
2023         https://bugs.webkit.org/show_bug.cgi?id=174289
2024
2025         Reviewed by Michael Catanzaro.
2026
2027         * Scripts/webkitperl/FeatureList.pm:
2028         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2029
2030 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2031
2032         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2033         https://bugs.webkit.org/show_bug.cgi?id=174219
2034         <rdar://problem/32083177>
2035
2036         Reviewed by Ryosuke Niwa.
2037
2038         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2039         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2040         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2041         place.
2042
2043         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2044         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2045         no action is taken when dropping.
2046
2047         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2048         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2049         (TestWebKitAPI::TEST):
2050         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2051         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2052         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2053         (-[MockDragDropSession allowsMoveOperation]):
2054         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2055         (-[MockDataInteractionSession initWithWindow:allowMove:]):
2056         (-[DataInteractionSimulator initWithWebView:]):
2057         (-[DataInteractionSimulator runFrom:to:]):
2058         (-[DataInteractionSimulator _advanceProgress]):
2059         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2060         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2061         (-[MockDataInteractionSession initWithWindow:]): Deleted.
2062
2063 2017-07-07  Commit Queue  <commit-queue@webkit.org>
2064
2065         Unreviewed, rolling out r219238, r219239, and r219241.
2066         https://bugs.webkit.org/show_bug.cgi?id=174265
2067
2068         "fast/workers/dedicated-worker-lifecycle.html is flaky"
2069         (Requested by yusukesuzuki on #webkit).
2070
2071         Reverted changesets:
2072
2073         "[WTF] Implement WTF::ThreadGroup"
2074         https://bugs.webkit.org/show_bug.cgi?id=174081
2075         http://trac.webkit.org/changeset/219238
2076
2077         "Unreviewed, build fix after r219238"
2078         https://bugs.webkit.org/show_bug.cgi?id=174081
2079         http://trac.webkit.org/changeset/219239
2080
2081         "Unreviewed, CLoop build fix after r219238"
2082         https://bugs.webkit.org/show_bug.cgi?id=174081
2083         http://trac.webkit.org/changeset/219241
2084
2085 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2086
2087         [GTK][WPE] Enable X-Content-Type-Options: nosniff
2088         https://bugs.webkit.org/show_bug.cgi?id=174250
2089
2090         Reviewed by Carlos Alberto Lopez Perez.
2091
2092         * Scripts/webkitperl/FeatureList.pm:
2093
2094 2017-07-07  Charlie Turner  <cturner@igalia.com>
2095         [GStreamer] vid.me videos do not play
2096         https://bugs.webkit.org/show_bug.cgi?id=172240
2097
2098         Reviewed by Xabier Rodriguez-Calvar.
2099
2100         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2101         have the existing libsoup build against GNOME to avoid header drift
2102         against GStreamer's linked Soup library.
2103
2104         * gtk/jhbuild.modules:
2105
2106 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2107
2108         Write a support script to enable buildbot to upload to S3
2109         https://bugs.webkit.org/show_bug.cgi?id=174196
2110         
2111         Reviewed by Stephanie Lewis.
2112
2113         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2114         (uploadToS3):
2115         (archiveExists):
2116
2117 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2118
2119         Enabling uploading archives to S3.
2120         https://bugs.webkit.org/show_bug.cgi?id=174198
2121         
2122         Reviewed by Stephanie Lewis.
2123
2124         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2125         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2126         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2127         (TransferToS3): Transfer full and minified archives to S3
2128
2129 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2130
2131         [WTF] Implement WTF::ThreadGroup
2132         https://bugs.webkit.org/show_bug.cgi?id=174081
2133
2134         Reviewed by Mark Lam.
2135
2136         Add WTF::ThreadGroup tests.
2137
2138         * TestWebKitAPI/CMakeLists.txt:
2139         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2140         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2141         (TestWebKitAPI::TEST):
2142
2143 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2144
2145         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2146         https://bugs.webkit.org/show_bug.cgi?id=174150
2147
2148         Reviewed by Mark Lam.
2149
2150         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2151         (TestWebKitAPI::TEST):
2152         * TestWebKitAPI/TestsController.cpp:
2153         (TestWebKitAPI::TestsController::TestsController):
2154
2155 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2156
2157         Enabling uploading archives to S3.
2158         https://bugs.webkit.org/show_bug.cgi?id=174198
2159         
2160         Reviewed by Lucas Forschler.
2161
2162         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2163         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2164         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2165         (TransferToS3): Transfer full and minified archives to S3
2166
2167 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2168
2169         [GTK][WPE] kill-old-process should kill more webkit related process
2170         https://bugs.webkit.org/show_bug.cgi?id=174220
2171
2172         Reviewed by Michael Catanzaro.
2173
2174         Generate list of possible webkit-related process names and add
2175         them to the list of process to kill.
2176         Also update the possible system related process for GTK+/WPE.
2177
2178         * BuildSlaveSupport/kill-old-processes:
2179         (listAllWebKitPrograms):
2180         (main):
2181
2182 2017-07-06  Chris Dumez  <cdumez@apple.com>
2183
2184         FileMonitor should not be ref counted
2185         https://bugs.webkit.org/show_bug.cgi?id=174166
2186
2187         Reviewed by Brent Fulgham.
2188
2189         Update the API tests to reflect the API change.
2190
2191         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2192         (TestWebKitAPI::TEST_F):
2193
2194 2017-07-06  Commit Queue  <commit-queue@webkit.org>
2195
2196         Unreviewed, rolling out r219194.
2197         https://bugs.webkit.org/show_bug.cgi?id=174207
2198
2199         it broke some layout tests (Requested by clopez on #webkit).
2200
2201         Reverted changeset:
2202
2203         "[GStreamer] vid.me videos do not play"
2204         https://bugs.webkit.org/show_bug.cgi?id=172240
2205         http://trac.webkit.org/changeset/219194
2206
2207 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2208
2209         Unreviewed, rolling out r219178.
2210
2211         This caused a consistent failure with the API test
2212         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2213
2214         Reverted changeset:
2215
2216         "[WTF] Clean up StringStatics.cpp by using
2217         LazyNeverDestroyed<> for Atoms"
2218         https://bugs.webkit.org/show_bug.cgi?id=174150
2219         http://trac.webkit.org/changeset/219178
2220
2221 2017-07-06  Alicia Boya García  <aboya@igalia.com>
2222
2223         Add CWD to Perl library path (no longer the default since 5.26.0)
2224         https://bugs.webkit.org/show_bug.cgi?id=174200
2225
2226         Reviewed by Michael Catanzaro.
2227
2228         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2229         (SetupGitClone._get_username_and_email):
2230
2231 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2232
2233         Unreviewed, update my email address.
2234
2235         * Scripts/webkitpy/common/config/contributors.json:
2236
2237 2017-07-06  Charlie Turner  <cturner@igalia.com>
2238         [GStreamer] vid.me videos do not play
2239         https://bugs.webkit.org/show_bug.cgi?id=172240
2240
2241         Reviewed by Xabier Rodriguez-Calvar.
2242
2243         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2244         have the existing libsoup build against GNOME to avoid header drift
2245         against GStreamer's linked Soup library.
2246
2247         * gtk/jhbuild.modules:
2248
2249 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2250
2251         [WTF] Move SoftLinking.h into WTF
2252         https://bugs.webkit.org/show_bug.cgi?id=174000
2253
2254         Reviewed by Alex Christensen.
2255
2256         * DumpRenderTree/mac/TestRunnerMac.mm:
2257         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2258         (test_primary_header):
2259         (ErrorCollector.__init__): Deleted.
2260         (ErrorCollector.__call__): Deleted.
2261         (ErrorCollector.results): Deleted.
2262         (ErrorCollector.result_list): Deleted.
2263         (ErrorCollector.verify_all_categories_are_seen): Deleted.
2264         (MockIo.open): Deleted.
2265         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
2266         (CppFunctionsTest.test_create_acronym): Deleted.
2267         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
2268         (CppFunctionsTest.test_parameter): Deleted.
2269         (CppFunctionsTest.test_single_line_view): Deleted.
2270         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
2271         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
2272         (CppFunctionsTest.test_parameter_list): Deleted.
2273         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
2274         (CppStyleTestBase.process_file_data): Deleted.
2275         (CppStyleTestBase.perform_lint): Deleted.
2276         (CppStyleTestBase.perform_single_line_lint): Deleted.
2277         (CppStyleTestBase.perform_multi_line_lint): Deleted.
2278         (CppStyleTestBase.perform_language_rules_check): Deleted.
2279         (CppStyleTestBase.perform_function_lengths_check): Deleted.
2280         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
2281         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
2282         (CppStyleTestBase.perform_include_what_you_use): Deleted.
2283         (CppStyleTestBase.perform_header_guard_check): Deleted.
2284         (CppStyleTestBase.assert_lint): Deleted.
2285         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
2286         (CppStyleTestBase.assert_multi_line_lint): Deleted.
2287         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
2288         (CppStyleTestBase.assert_language_rules_check): Deleted.
2289         (CppStyleTestBase.assert_include_what_you_use): Deleted.
2290         (CppStyleTestBase.assert_header_guard): Deleted.
2291         (CppStyleTestBase.assert_blank_lines_check): Deleted.
2292         (CppStyleTestBase.assert_positions_equal): Deleted.
2293         (FunctionDetectionTest.test_basic_function_detection): Deleted.
2294         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
2295         (FunctionDetectionTest.test_pure_function_detection): Deleted.
2296         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
2297         (FunctionDetectionTest.test_ignore_macros): Deleted.
2298         (FunctionDetectionTest.test_non_functions): Deleted.
2299         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
2300         (FunctionDetectionTest.test_parameter_list): Deleted.
2301         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
2302         (CppStyleTest.test_asm_lines_ignored): Deleted.
2303         (CppStyleTest.test_get_line_width): Deleted.
2304         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
2305         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
2306         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
2307         (CppStyleTest.test_position): Deleted.
2308         (CppStyleTest.test_rfind_in_lines): Deleted.
2309         (CppStyleTest.test_close_expression): Deleted.
2310         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
2311         (CppStyleTest.test_cstyle_cast): Deleted.
2312         (CppStyleTest.test_runtime_casting): Deleted.
2313         (CppStyleTest.test_runtime_selfinit): Deleted.
2314         (CppStyleTest.test_runtime_rtti): Deleted.
2315         (CppStyleTest.test_static_cast_readability): Deleted.
2316         (CppStyleTest.test_check_for_unnamed_params): Deleted.
2317         (CppStyleTest.void): Deleted.
2318         (CppStyleTest.test_deprecated_cast): Deleted.
2319         (CppStyleTest.test_mock_method): Deleted.
2320         (CppStyleTest.test_sizeof_type): Deleted.
2321         (CppStyleTest.cases): Deleted.
2322         (CppStyleTest.for): Deleted.
2323         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
2324         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
2325         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
2326         (CppStyleTest.test_include_what_you_use): Deleted.
2327         (CppStyleTest.test_files_belong_to_same_module): Deleted.
2328         (CppStyleTest.test_cleanse_line): Deleted.
2329         (CppStyleTest.test_multi_line_comments): Deleted.
2330         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
2331         (CppStyleTest.test_multiline_strings): Deleted.
2332         (CppStyleTest.test_platformh_comments): Deleted.
2333         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
2334         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
2335         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
2336         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
2337         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
2338         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
2339         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
2340         (CppStyleTest.test_check_posix_threading): Deleted.
2341         (CppStyleTest.test_insecure_string_operations): Deleted.
2342         (CppStyleTest.test_format_strings): Deleted.
2343         (CppStyleTest.test_insecure_temp_file): Deleted.
2344         (CppStyleTest.test_variable_length_array_detection): Deleted.
2345         (CppStyleTest.test_braces): Deleted.
2346         (CppStyleTest.test_check_check): Deleted.
2347         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
2348         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
2349         (CppStyleTest.test_spacing_for_fncall): Deleted.
2350         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
2351         (CppStyleTest.test_spacing_before_braces): Deleted.
2352         (CppStyleTest.test_spacing_between_braces): Deleted.
2353         (CppStyleTest.test_spacing_before_brackets): Deleted.
2354         (CppStyleTest.test_cpp_lambda_functions): Deleted.
2355         (CppStyleTest.test_objective_c_block): Deleted.
2356         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
2357         (CppStyleTest.test_spacing_around_else): Deleted.
2358         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
2359         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
2360         (CppStyleTest.test_operator_methods): Deleted.
2361         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
2362         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
2363         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
2364         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
2365         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
2366         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
2367         (CppStyleTest.test_space_after_comment_marker): Deleted.
2368         (CppStyleTest.test_newline_at_eof): Deleted.
2369         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
2370         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
2371         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
2372         (CppStyleTest.test_invalid_utf8): Deleted.
2373         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
2374         (CppStyleTest.test_is_blank_line): Deleted.
2375         (CppStyleTest.test_blank_lines_check): Deleted.
2376         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
2377         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
2378         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
2379         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
2380         (CppStyleTest.test_comma): Deleted.
2381         (CppStyleTest.test_declaration): Deleted.
2382         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
2383         (CppStyleTest.test_indent): Deleted.
2384         (CppStyleTest.test_indent.Foo): Deleted.
2385         (CppStyleTest.test_not_alabel): Deleted.
2386         (CppStyleTest.test_tab): Deleted.
2387         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
2388         (CppStyleTest.test_build_class): Deleted.
2389         (CppStyleTest.test_build_class.definitions): Deleted.
2390         (CppStyleTest.test_build_class.Foo): Deleted.
2391         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
2392         (CppStyleTest.test_build_end_comment): Deleted.
2393         (CppStyleTest.test_build_forward_decl): Deleted.
2394         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
2395         (CppStyleTest.test_build_header_guard): Deleted.
2396         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
2397         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
2398         (CppStyleTest.test_build_printf_format): Deleted.
2399         (CppStyleTest.test_runtime_printf_format): Deleted.
2400         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
2401         (CppStyleTest.test_build_storage_class): Deleted.
2402         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
2403         (CppStyleTest.test_build_storage_class.declaration): Deleted.
2404         (CppStyleTest.test_build_storage_class.after): Deleted.
2405         (CppStyleTest.test_build_storage_class.is): Deleted.
2406         (CppStyleTest.test_legal_copyright): Deleted.
2407         (CppStyleTest.test_invalid_increment): Deleted.
2408         (CppStyleTest.test_enum_bitfields): Deleted.
2409         (CppStyleTest.test_plain_integral_bitfields): Deleted.
2410         (CleansedLinesTest.test_init_empty): Deleted.
2411         (CleansedLinesTest.test_collapse_strings): Deleted.
2412         (OrderOfIncludesTest.tearDown): Deleted.
2413         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
2414         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
2415         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
2416         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
2417         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
2418         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
2419         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
2420         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
2421         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
2422         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
2423         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
2424         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
2425         (OrderOfIncludesTest.test_primary_header): Deleted.
2426         (OrderOfIncludesTest.test_public_primary_header): Deleted.
2427         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
2428         (OrderOfIncludesTest.test_classify_include): Deleted.
2429         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
2430         (CheckForFunctionLengthsTest.tearDown): Deleted.
2431         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
2432         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
2433         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
2434         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
2435         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
2436         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
2437         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
2438         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
2439         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
2440         (CheckForFunctionLengthsTest.function_body): Deleted.
2441         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
2442         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
2443         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
2444         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
2445         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
2446         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
2447         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
2448         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
2449         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
2450         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2451         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2452         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2453         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2454         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2455         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2456         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2457         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2458         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2459         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2460         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2461         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2462         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2463         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2464         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2465         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2466         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2467         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2468         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2469         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2470         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2471         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2472         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2473         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2474         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2475         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2476         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2477         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2478         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2479         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2480         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2481         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2482         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2483         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2484         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2485         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2486         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2487         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2488         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2489         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2490         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2491         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2492         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2493         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2494         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2495         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2496         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2497         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2498         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2499         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2500         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2501         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2502         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2503         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2504         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2505         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2506         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2507         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2508         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2509         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2510         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2511         (LeakyPatternTest.test_get_dc): Deleted.
2512         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2513         (LeakyPatternTest.test_own_get_dc): Deleted.
2514         (LeakyPatternTest.test_create_dc): Deleted.
2515         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2516         (WebKitStyleTest.test_indentation): Deleted.
2517         (WebKitStyleTest.test_indentation.Foo): Deleted.
2518         (WebKitStyleTest.test_indentation.Document): Deleted.
2519         (WebKitStyleTest.test_spacing): Deleted.
2520         (WebKitStyleTest.test_line_breaking): Deleted.
2521         (WebKitStyleTest.test_braces): Deleted.
2522         (WebKitStyleTest.test_braces.MyClass): Deleted.
2523         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2524         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2525         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2526         (WebKitStyleTest.test_null_false_zero): Deleted.
2527         (WebKitStyleTest.test_directive_indentation): Deleted.
2528         (WebKitStyleTest.test_using_std): Deleted.
2529         (WebKitStyleTest.test_using_namespace): Deleted.
2530         (WebKitStyleTest.test_max_macro): Deleted.
2531         (WebKitStyleTest.test_min_macro): Deleted.
2532         (WebKitStyleTest.test_wtf_move): Deleted.
2533         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2534         (WebKitStyleTest.test_names): Deleted.
2535         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2536         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2537         (WebKitStyleTest.test_names.declarations): Deleted.
2538         (WebKitStyleTest.test_names.struct): Deleted.
2539         (WebKitStyleTest.test_names.VectorType): Deleted.
2540         (WebKitStyleTest.test_parameter_names): Deleted.
2541         (WebKitStyleTest.test_comments): Deleted.
2542         (WebKitStyleTest.test_webkit_export_check): Deleted.
2543         (WebKitStyleTest.test_member_initialization_list): Deleted.
2544         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2545         (WebKitStyleTest.test_other): Deleted.
2546         (CppCheckerTest.mock_handle_style_error): Deleted.
2547         (CppCheckerTest._checker): Deleted.
2548         (CppCheckerTest.test_init): Deleted.
2549         (CppCheckerTest.test_eq): Deleted.
2550         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2551         (CppCheckerTest.test_ne): Deleted.
2552         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2553         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2554         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2555         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2556         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2557         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2558
2559 2017-07-05  Saam Barati  <sbarati@apple.com>
2560
2561         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2562         https://bugs.webkit.org/show_bug.cgi?id=174188
2563         <rdar://problem/30581423>
2564
2565         Reviewed by Mark Lam.
2566
2567         * Scripts/run-jsc-stress-tests:
2568
2569 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2570
2571         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2572         https://bugs.webkit.org/show_bug.cgi?id=174150
2573
2574         Reviewed by Mark Lam.
2575
2576         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2577         (TestWebKitAPI::TEST):
2578
2579 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2580
2581         Remove copy of ICU headers from WebKit
2582         https://bugs.webkit.org/show_bug.cgi?id=116407
2583
2584         Reviewed by Alex Christensen.
2585
2586         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2587         * TestWebKitAPI/Configurations/Base.xcconfig:
2588         * WebKitTestRunner/Configurations/Base.xcconfig:
2589
2590 2017-07-05  Chris Dumez  <cdumez@apple.com>
2591
2592         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2593         https://bugs.webkit.org/show_bug.cgi?id=174163
2594         <rdar://problem/33067518>
2595
2596         Reviewed by Alex Christensen.
2597
2598         Add API test coverage.
2599
2600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2601         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
2602         (TEST):
2603
2604 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2605
2606         When dragging a selection, clearing the selection in dragstart should not crash the web process
2607         https://bugs.webkit.org/show_bug.cgi?id=174142
2608         <rdar://problem/33067501>
2609
2610         Reviewed by Tim Horton.
2611
2612         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
2613         drag is starting up.
2614
2615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2616         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
2617         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2618         (TestWebKitAPI::TEST):
2619
2620 2017-07-05  Daniel Bates  <dabates@apple.com>
2621
2622         Do not pass API::FrameInfo for source frame or clear out page of target frame on
2623         API navigation
2624         https://bugs.webkit.org/show_bug.cgi?id=174170
2625         <rdar://problem/33140328>
2626
2627         Reviewed by Brady Eidson.
2628
2629         Update tests as needed for the behavior change.
2630
2631         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2632         (TEST):
2633
2634 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2635
2636         Add WebKitPrivateFrameworkStubs for iOS 11
2637         https://bugs.webkit.org/show_bug.cgi?id=173988
2638
2639         Reviewed by David Kilzer.
2640
2641         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
2642         should use the same directory for private framework stubs.
2643         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2644
2645 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
2646
2647         [MediaStream] Protect request and web view during gUM client callback
2648         https://bugs.webkit.org/show_bug.cgi?id=174096
2649         <rdar://problem/32833102>
2650
2651         Reviewed by Youenn Fablet.
2652
2653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2654         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2655
2656 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2657
2658         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
2659
2660         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2661
2662 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2663
2664         Unreviewed, rolling out r219128.
2665
2666         Spoke with engineer who originally submitted, Patch for APi
2667         test to follow.
2668
2669         Reverted changeset:
2670
2671         "Unreviewed, rolling out r219070."
2672         https://bugs.webkit.org/show_bug.cgi?id=174082
2673         http://trac.webkit.org/changeset/219128
2674
2675 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2676
2677         Unreviewed, rolling out r219070.
2678
2679         This revision caused consistent failures of the API test
2680         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
2681
2682         Reverted changeset:
2683
2684         "Pasting single words copied to UIPasteboard inserts URLs in
2685         editable areas"
2686         https://bugs.webkit.org/show_bug.cgi?id=174082
2687         http://trac.webkit.org/changeset/219070
2688
2689 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2690
2691         Remove unused EFL logo from bot watcher dashboard
2692         https://bugs.webkit.org/show_bug.cgi?id=174136
2693
2694         Reviewed by Alexey Proskuryakov.
2695
2696         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
2697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
2698
2699 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2700
2701         [GTK] Add more GTK bots to dashboard
2702         https://bugs.webkit.org/show_bug.cgi?id=174129
2703
2704         Reviewed by Carlos Alberto Lopez Perez.
2705
2706         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
2707         them.
2708
2709         This also changes the sort order to put WPE above GTK so that it's not buried under all the
2710         less-essential GTK bots.
2711
2712         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2713         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2714         (WebKitBuildbot):
2715
2716 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2717
2718         [WPE] Add WPE to bot watcher dashboard
2719         https://bugs.webkit.org/show_bug.cgi?id=174119
2720
2721         Reviewed by Alexey Proskuryakov.
2722
2723         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
2724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
2725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
2726         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2727         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2728         (WebKitBuildbot):
2729         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2730         (table.queue-grid tr.platform.linux-wpe img.logo):
2731
2732 2017-07-03  Lucas Forschler  <lforschler@apple.com>
2733
2734         https://bugs.webkit.org/show_bug.cgi?id=174105
2735         
2736         Reviewed by Stephanie Lewis.
2737
2738         * BuildSlaveSupport/built-product-archive:
2739         (main): Add a -minify parser option
2740         (createZip): Pass along the optional Minify argument if requested
2741         (minifySource): This will trim down archives, logic limited to Mac platform.
2742
2743 2017-07-03  Matt Rajca  <mrajca@apple.com>
2744
2745         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
2746         https://bugs.webkit.org/show_bug.cgi?id=174103
2747
2748         Reviewed by Alex Christensen.
2749
2750         Added an API test.
2751
2752         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
2753         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2754         (TEST): Added test.
2755         * TestWebKitAPI/cocoa/TestWKWebView.h:
2756         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2757         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
2758
2759 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2760
2761         Unreviewed, rolling out r219103.
2762
2763         Caused multiple build failures.
2764
2765         Reverted changeset:
2766
2767         "Remove copy of ICU headers from WebKit"
2768         https://bugs.webkit.org/show_bug.cgi?id=116407
2769         http://trac.webkit.org/changeset/219103
2770
2771 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2772
2773         Remove copy of ICU headers from WebKit
2774         https://bugs.webkit.org/show_bug.cgi?id=116407
2775
2776         Reviewed by Alex Christensen.
2777
2778         Use WTF's copy of ICU headers.
2779
2780         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2781         * TestWebKitAPI/Configurations/Base.xcconfig:
2782         * WebKitTestRunner/Configurations/Base.xcconfig:
2783
2784 2017-07-03  Brady Eidson  <beidson@apple.com>
2785
2786         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2787         https://bugs.webkit.org/show_bug.cgi?id=174073
2788
2789         Reviewed by Andy Estes.
2790
2791         * DumpRenderTree/mac/TestRunnerMac.mm:
2792         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
2793
2794         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
2795         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2796
2797 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2798
2799         Unreviewed, rolling out r219083.
2800
2801         The revision caused an API failure on all testing platforms.
2802
2803         Reverted changeset:
2804
2805         "[MediaStream] Protect request and web view during gUM client
2806         callback"
2807         https://bugs.webkit.org/show_bug.cgi?id=174096
2808         http://trac.webkit.org/changeset/219083
2809
2810 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
2811
2812         webkitpy: Properly number duplicated crashlogs
2813         https://bugs.webkit.org/show_bug.cgi?id=172002
2814
2815         Reviewed by Aakash Jain.
2816
2817         * Scripts/webkitpy/common/system/crashlogs.py:
2818         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
2819         an increasing integer.
2820         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2821         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
2822         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
2823         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
2824
2825 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
2826
2827         WebContent processes crash when the network process crashes with pending connection requests
2828         https://bugs.webkit.org/show_bug.cgi?id=174065
2829         <rdar://problem/30359835>
2830
2831         Reviewed by Tim Horton.
2832
2833         Add a API to ensure UI process tries to relaunch a new network process when the network process
2834         crashes with pending network connection requests.
2835
2836         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2837         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
2838         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2839         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2840         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
2841
2842 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
2843
2844         [MediaStream] Protect request and web view during gUM client callback
2845         https://bugs.webkit.org/show_bug.cgi?id=174096
2846         <rdar://problem/32833102>
2847
2848         Reviewed by Youenn Fablet.
2849
2850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2851         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2852
2853 2017-07-03  Andy Estes  <aestes@apple.com>
2854
2855         [Xcode] Add an experimental setting to build with ccache
2856         https://bugs.webkit.org/show_bug.cgi?id=173875
2857
2858         Reviewed by Tim Horton.
2859
2860         On systems that already have ccache(1) installed, this patch adds experimental support for
2861         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
2862
2863         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
2864         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
2865         find the toolchain from which to run clang, and then invokes ccache with the required
2866         arguments.
2867
2868         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
2869         precompiled headers to work properly [1].
2870
2871         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
2872         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
2873         during linking.
2874         
2875         [1] https://ccache.samba.org/manual.html#_precompiled_headers
2876
2877         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2878         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2879         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2880         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2881         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
2882         * ccache/README.md: Added.
2883         * ccache/ccache-clang: Added.
2884         * ccache/ccache-clang++: Added.
2885         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
2886
2887 2017-07-03  Alex Christensen  <achristensen@webkit.org>
2888
2889         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2890         https://bugs.webkit.org/show_bug.cgi?id=174051
2891
2892         Reviewed by Tim Horton.
2893
2894         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2895         (TestWebKitAPI::TEST_F):
2896
2897 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2898
2899         Unreviewed, rolling out r219024.
2900
2901         This patch cause 3 didferent test to fail.
2902
2903         Reverted changeset:
2904
2905         "REGRESSION(r215096) Queries of URLs with non-special schemes
2906         should not percent-encode single quotes"
2907         https://bugs.webkit.org/show_bug.cgi?id=174051
2908         http://trac.webkit.org/changeset/219024
2909
2910 2017-07-03  Chris Dumez  <cdumez@apple.com>
2911
2912         Drop ResourceLoadStatisticsStore's statisticsLock
2913         https://bugs.webkit.org/show_bug.cgi?id=174080
2914
2915         Reviewed by Brent Fulgham.
2916
2917         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2918
2919         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2920         (WTR::TestController::isStatisticsPrevalentResource):
2921         (WTR::TestController::isStatisticsHasHadUserInteraction):
2922         (WTR::TestController::isStatisticsGrandfathered):
2923
2924 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2925
2926         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2927         https://bugs.webkit.org/show_bug.cgi?id=174082
2928         <rdar://problem/33046992>
2929
2930         Reviewed by Tim Horton.
2931
2932         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2933
2934         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2935         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2936         (TestWebKitAPI::TEST):
2937
2938 2017-07-02  Brady Eidson  <beidson@apple.com>
2939
2940         Add API test for all parts of WebKit1 API related to favicons.
2941         https://bugs.webkit.org/show_bug.cgi?id=174069
2942
2943         Reviewed by Andy Estes.
2944
2945         These two API tests cover all WebKit1 API related to icons.
2946         
2947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2948         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2949         (mainResourceData):
2950         (defaultFaviconData):
2951         (customFaviconData):
2952         (imageFromData):
2953         (+[IconLoadingProtocol canInitWithRequest:]):
2954         (+[IconLoadingProtocol canonicalRequestForRequest:]):
2955         (-[IconLoadingProtocol startLoading]):
2956         (-[IconLoadingProtocol stopLoading]):
2957         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2958         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2959         (TestWebKitAPI::TEST):
2960
2961 2017-07-01  Dan Bernstein  <mitz@apple.com>
2962
2963         [iOS] Remove code only needed when building for iOS 9.x
2964         https://bugs.webkit.org/show_bug.cgi?id=174068
2965
2966         Reviewed by Tim Horton.
2967
2968         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2969         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2970         (WTR::initializeWebViewConfiguration):
2971         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2972         (-[HIDEventGenerator _createIOHIDEventType:]):
2973
2974 2017-07-01  Brady Eidson  <beidson@apple.com>
2975
2976         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2977         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2978
2979         Reviewed by Alex Christensen.
2980
2981         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2982
2983 2017-07-01  Dan Bernstein  <mitz@apple.com>
2984
2985         [macOS] Remove code only needed when building for OS X Yosemite
2986         https://bugs.webkit.org/show_bug.cgi?id=174067
2987
2988         Reviewed by Tim Horton.
2989
2990         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2991         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2992         * DumpRenderTree/mac/DumpRenderTree.mm:
2993         (setDefaultsToConsistentValuesForTesting):
2994         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2995         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2996         * MiniBrowser/Configurations/Base.xcconfig:
2997         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2998         * TestWebKitAPI/Configurations/Base.xcconfig:
2999         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3000         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3001         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3002         (TestWebKitAPI::TEST_F):
3003         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3004         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3005         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3006         (TestWebKitAPI::TEST_F):
3007         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3008         (TestWebKitAPI::TEST):
3009         * WebKitTestRunner/Configurations/Base.xcconfig:
3010         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3011         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3012         (WTR::InjectedBundle::platformInitialize):
3013         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3014         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3015
3016 2017-07-01  Chris Dumez  <cdumez@apple.com>
3017
3018         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
3019         https://bugs.webkit.org/show_bug.cgi?id=174060
3020
3021         Reviewed by Brent Fulgham.
3022
3023         Port WebKitTestRunner over to the new Cocoa SPI.
3024
3025         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3026         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3027         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3028         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
3029         no-ops since this code runs in the WebContent process, not the
3030         UIProcess.
3031
3032         * WebKitTestRunner/TestController.cpp:
3033         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3034
3035 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3036
3037         Unreviewed mac build fix.
3038
3039         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3040         (TestWebKitAPI::TEST):
3041
3042 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3043
3044         Add API to get WKActivatedElementInfo
3045         https://bugs.webkit.org/show_bug.cgi?id=174001
3046         <rdar://problem/29165518>
3047         
3048         Tests for now SPI to get activatedElementInfo.
3049
3050         Reviewed by Tim Horton.
3051
3052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3053         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
3054         (TestWebKitAPI::TEST):
3055
3056 2017-06-30  Chris Dumez  <cdumez@apple.com>
3057
3058         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
3059         https://bugs.webkit.org/show_bug.cgi?id=174038
3060
3061         Reviewed by Brent Fulgham.
3062
3063         Fix typo in API name.
3064
3065         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3066         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3067         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3068         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3069         * WebKitTestRunner/TestController.cpp:
3070         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3071         * WebKitTestRunner/TestController.h:
3072         * WebKitTestRunner/TestInvocation.cpp:
3073         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3074
3075 2017-06-30  Alex Christensen  <achristensen@webkit.org>
3076
3077         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3078         https://bugs.webkit.org/show_bug.cgi?id=174051
3079         <rdar://problem/33002846>
3080
3081         Reviewed by Tim Horton.
3082
3083         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3084         (TestWebKitAPI::TEST_F):
3085
3086 2017-06-30  Daniel Bates  <dabates@apple.com>
3087
3088         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3089         https://bugs.webkit.org/show_bug.cgi?id=165160
3090         <rdar://problem/29451999>
3091
3092         Reviewed by Brady Eidson.
3093
3094         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
3095         for navigations and window creation.
3096
3097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3098         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
3099         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3100         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
3101         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3102         (TEST):
3103
3104 2017-06-29  Jer Noble  <jer.noble@apple.com>
3105
3106         Make Legacy EME API controlled by RuntimeEnabled setting.
3107         https://bugs.webkit.org/show_bug.cgi?id=173994
3108
3109         Reviewed by Sam Weinig.
3110
3111         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3112
3113 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3114
3115         Follow-up fix for r218996
3116
3117         Unreviewed infrastructure fix.
3118
3119         Repeated calls to 'ios_version' make the log noisy, memoize the function.
3120
3121         * Scripts/webkitpy/port/ios_simulator.py:
3122         (IOSSimulatorPort): Memoize ios_version().
3123
3124 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3125
3126         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3127         https://bugs.webkit.org/show_bug.cgi?id=174017
3128         <rdar://problem/32959782>
3129
3130         Reviewed by Simon Fraser.
3131
3132         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
3133         changes, the caret would appear outside of the iframe.
3134
3135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3136         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
3137         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3138         (checkDragCaretRectIsContainedInRect):
3139         (TestWebKitAPI::TEST):
3140         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3141         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3142         (-[DataInteractionSimulator _resetSimulatedState]):
3143         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3144         (-[DataInteractionSimulator _advanceProgress]):
3145         (-[DataInteractionSimulator lastKnownDragCaretRect]):
3146
3147 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3148
3149         Add support for different versions of iOS when loading test expectations
3150         https://bugs.webkit.org/show_bug.cgi?id=173774
3151         <rdar://problem/32951132>
3152
3153         Rubber-stamped by Aakash Jain.
3154
3155         When running layout tests, we should support multiple version of iOS the same way we do Mac.
3156
3157         * Scripts/webkitpy/port/ios.py:
3158         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
3159         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
3160         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
3161         * Scripts/webkitpy/port/ios_device.py:
3162         (IOSDevicePort.ios_version): Ask connected devices for implementation.
3163         * Scripts/webkitpy/port/ios_device_unittest.py:
3164         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
3165         (IOSDeviceTest.test_baseline_searchpath): Ditto.
3166         (IOSDeviceTest.test_expectations_ordering): Ditto.
3167         * Scripts/webkitpy/port/ios_simulator.py:
3168         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
3169         ask the platform.
3170
3171 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
3172
3173         Fontconfig build breaks with glibc 2.15+
3174         https://bugs.webkit.org/show_bug.cgi?id=174019
3175
3176         Reviewed by Carlos Alberto Lopez Perez.
3177
3178         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
3179
3180         * wpe/jhbuild.modules:
3181         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
3182
3183 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3184
3185         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
3186         https://bugs.webkit.org/show_bug.cgi?id=174010
3187         <rdar://problem/32597802>
3188
3189         Reviewed by Tim Horton.
3190
3191         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
3192         snapshot fails for any reason.
3193
3194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3195         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
3196         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3197         (TestWebKitAPI::TEST):
3198
3199 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
3200
3201         AX: Cannot call setValue() on contenteditable or ARIA text controls
3202         https://bugs.webkit.org/show_bug.cgi?id=173520
3203
3204         Reviewed by Ryosuke Niwa.
3205
3206         Add setValue() method to WKTR (already existed in DRT).
3207
3208         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3209         (WTR::AccessibilityUIElement::setValue):
3210         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3211         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3212         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3213         (WTR::AccessibilityUIElement::setValue):
3214
3215 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
3216
3217         getBoundingClientRect returns wrong value for combination of page zoom and scroll
3218         https://bugs.webkit.org/show_bug.cgi?id=173841
3219         rdar://problem/32983841
3220
3221         Reviewed by Dean Jackson.
3222
3223         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
3224         always did text zooming.
3225
3226         * MiniBrowser/mac/WK1BrowserWindowController.m:
3227         (-[WK1BrowserWindowController zoomIn:]):
3228         (-[WK1BrowserWindowController zoomOut:]):
3229         (-[WK1BrowserWindowController canResetZoom]):
3230         (-[WK1BrowserWindowController resetZoom:]):
3231
3232 2017-06-29  John Wilander  <wilander@apple.com>
3233
3234         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
3235         https://bugs.webkit.org/show_bug.cgi?id=173940
3236         <rdar://problem/33018125>
3237
3238         Reviewed by Brent Fulgham.
3239
3240         This change allows the TestController to turn off
3241         regular resource load statistics telemetry submission
3242         and to manually control when telemetry is calculated
3243         and submitted.
3244
3245         * WebKitTestRunner/TestController.cpp:
3246         (WTR::TestController::initialize):
3247             Turns off automatic resource load statistics telemetry submission.
3248
3249 2017-06-29  Commit Queue  <commit-queue@webkit.org>
3250
3251         Unreviewed, rolling out r218512.
3252         https://bugs.webkit.org/show_bug.cgi?id=173981
3253
3254         "It changes the behavior of the JS API's JSEvaluateScript
3255         which breaks TurboTax" (Requested by saamyjoon on #webkit).
3256
3257         Reverted changeset:
3258
3259         "test262: Completion values for control flow do not match the
3260         spec"
3261         https://bugs.webkit.org/show_bug.cgi?id=171265
3262         http://trac.webkit.org/changeset/218512
3263
3264 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
3265
3266         Add WebKitSystemInterface for iOS 11
3267         https://bugs.webkit.org/show_bug.cgi?id=173936
3268
3269         Reviewed by Lucas Forschler.
3270
3271         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
3272
3273 2017-06-28  Keith Miller  <keith_miller@apple.com>
3274
3275         VMTraps has some races
3276         https://bugs.webkit.org/show_bug.cgi?id=173941
3277
3278         Reviewed by Michael Saboff.
3279
3280         Add new testing mode for testing the Watchdog with our stress
3281         tests.
3282
3283         * Scripts/run-jsc-stress-tests:
3284
3285 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3286
3287         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
3288         https://bugs.webkit.org/show_bug.cgi?id=173877
3289
3290         Reviewed by Brady Eidson.
3291
3292         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
3293         the next tests.
3294
3295         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3296         (testGetFavicon):
3297
3298 2017-06-28  Tim Horton  <timothy_horton@apple.com>
3299
3300         MobileSafari was constantly using 10-15% CPU viewing a PDF
3301         https://bugs.webkit.org/show_bug.cgi?id=173944
3302         <rdar://problem/33039910>
3303
3304         Reviewed by Simon Fraser.
3305
3306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3307         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
3308         Add a test that we ever call the stable presentation update callback
3309         when we have a WKPDFView up, instead of infinitely looping.
3310
3311 2017-06-28  Alex Christensen  <achristensen@webkit.org>
3312
3313         Prevent displaying URLs with small capital letters
3314         https://bugs.webkit.org/show_bug.cgi?id=173949
3315         <rdar://problem/32952058>
3316
3317         Reviewed by Brent Fulgham.
3318
3319         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3320         (TestWebKitAPI::TEST):
3321
3322 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
3323
3324         Unreviewed test fix.
3325
3326         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
3327
3328         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
3329
3330 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
3331
3332         Teach ResourceLoadStatistics to recognize changes in the file system
3333         https://bugs.webkit.org/show_bug.cgi?id=173800
3334         <rdar://problem/32937842>
3335
3336         Reviewed by Chris Dumez.
3337
3338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3339         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
3340         (TestWebKitAPI::FileMonitorTest::tempFilePath):
3341         (TestWebKitAPI::handleFileModification):
3342         (TestWebKitAPI::handleFileDeletion):
3343         (TestWebKitAPI::resetTestState):
3344         (TestWebKitAPI::TEST_F):
3345
3346 2017-06-28  Brady Eidson  <beidson@apple.com>
3347
3348         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
3349         https://bugs.webkit.org/show_bug.cgi?id=173874
3350
3351         Reviewed by Alex Christensen.
3352
3353         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3354
3355 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
3356
3357         Unreviewed, adding Don Olmstead to contributors.json
3358
3359         * Scripts/webkitpy/common/config/contributors.json:
3360
3361 2017-06-28  Alex Christensen  <achristensen@webkit.org>
3362
3363         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
3364         https://bugs.webkit.org/show_bug.cgi?id=173886
3365         <rdar://problem/32543191>
3366
3367         Reviewed by Andy Estes.
3368
3369         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3370         (ParsedRange::ParsedRange):
3371         (-[TestSchemeHandler initWithVideoData:]):
3372         (-[TestSchemeHandler webView:startURLSchemeTask:]):
3373         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
3374         (TEST):
3375
3376 2017-06-27  JF Bastien  <jfbastien@apple.com>
3377
3378         WebAssembly: running out of executable memory should throw OoM
3379         https://bugs.webkit.org/show_bug.cgi?id=171537
3380         <rdar://problem/32963338>
3381
3382         Reviewed by Saam Barati.
3383
3384         * Scripts/run-jsc-stress-tests: add a configuration which runs the
3385         tests under limited executable memory and avoids non-WebAssembly
3386         code generation so that we more reliably run out of executable
3387         memory in WebAssembly.
3388
3389 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3390
3391         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
3392         https://bugs.webkit.org/show_bug.cgi?id=173854
3393         <rdar://problem/32236827>
3394
3395         Reviewed by Ryosuke Niwa and Tim Horton.
3396
3397         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
3398
3399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3400         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
3401         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3402         (TestWebKitAPI::TEST):
3403
3404 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
3405
3406         [PAL] Add symbol export macros for PAL
3407         https://bugs.webkit.org/show_bug.cgi?id=171519
3408
3409         Reviewed by Konstantin Tokarev.
3410
3411         * DumpRenderTree/config.h:
3412         * TestWebKitAPI/CMakeLists.txt:
3413         * TestWebKitAPI/config.h:
3414         * WebKitTestRunner/config.h:
3415
3416 2017-06-27  John Wilander  <wilander@apple.com>
3417
3418         Resource Load Statistics: Add telemetry
3419         https://bugs.webkit.org/show_bug.cgi?id=173499
3420         <rdar://problem/32826094>
3421
3422         Reviewed by Brent Fulgham.
3423
3424         Adds three new testRunner functions:
3425         - installStatisticsDidRunTelemetryCallback()
3426         - statisticsFireTelemetryHandler()
3427         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
3428
3429         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3430         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3431         (WTR::InjectedBundle::didReceiveMessageToPage):
3432         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3433         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
3434         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
3435         (WTR::TestRunner::statisticsFireTelemetryHandler):
3436         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3437         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3438         * WebKitTestRunner/TestController.cpp:
3439         (WTR::TestController::resetStateToConsistentValues):
3440         (WTR::TestController::statisticsFireTelemetryHandler):
3441         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3442         * WebKitTestRunner/TestController.h:
3443         * WebKitTestRunner/TestInvocation.cpp:
3444         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3445
3446 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
3447
3448         Add missing includes to fix compilation error on FreeBSD
3449         https://bugs.webkit.org/show_bug.cgi?id=172919
3450
3451         Reviewed by Mark Lam.
3452
3453         * ImageDiff/cairo/PlatformImageCairo.cpp:
3454
3455 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
3456
3457         Unreviewed, rolling out r218783.
3458
3459         Causing accessibility/mac/setting-attributes-is-
3460         asynchronous.html to crash consistently on mac-wk2 Debug
3461
3462         Reverted changeset:
3463
3464         "AX: Cannot call setValue() on contenteditable or ARIA text
3465         controls"
3466         https://bugs.webkit.org/show_bug.cgi?id=173520
3467         http://trac.webkit.org/changeset/218783
3468
3469 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3470
3471         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
3472         https://bugs.webkit.org/show_bug.cgi?id=173825
3473
3474         Reviewed by Saam Barati.
3475
3476         * DumpRenderTree/JavaScriptThreading.cpp:
3477         (runJavaScriptThread):
3478         (startJavaScriptThreads):
3479         * DumpRenderTree/mac/DumpRenderTree.mm:
3480         (runThread):
3481         (runPthread):
3482         (testThreadIdentifierMap):
3483
3484 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3485
3486         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
3487         <https://webkit.org/b/173837>
3488
3489         Reviewed by Geoffrey Garen.
3490
3491         The clang static analyzer can't reason about objects that are
3492         assigned to a delegate as +1 retained, and then released
3493         later in a different method when the delegate is cleared.
3494
3495         Instead, use a common idiom where the object setting the
3496         delegate retains it as an instance variable on initialization.
3497         Then the same object clears the delegate and releases its
3498         instance variable during teardown.
3499
3500         Also add EXPECT_TRUE() tests to make sure the delegate objects
3501         match before teardown.
3502
3503         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3504         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3505         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
3506         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3507         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
3508         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
3509
3510 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3511
3512         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
3513         <https://webkit.org/b/173836>
3514
3515         Reviewed by Brady Eidson.
3516
3517         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3518         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
3519         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
3520         objects in this test.
3521
3522 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
3523
3524         [ATK] Add support for aria-details and aria-errormessage
3525         https://bugs.webkit.org/show_bug.cgi?id=172588
3526
3527         Reviewed by Chris Fleizach.
3528
3529         Add additional methods to test ARIA properties which are exposed via
3530         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
3531         to versions which support the details and error-message relation types.
3532
3533         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3534         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3535         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3536         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3537         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3538         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3539         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3540         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3541         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3542         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3543         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3544         * gtk/jhbuild.modules:
3545
3546 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3547
3548         Unreviewed. Add libfii to GTK+ install dependencies script.
3549
3550         * gtk/install-dependencies:
3551
3552 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3553
3554         Unreviewed, rolling out r215190.
3555
3556         Broke product select element on GNOME Bugzilla
3557
3558         Reverted changeset:
3559
3560         "[GTK] Misplaced right click menu on web page due to
3561         deprecated gtk_menu_popup()"
3562         https://bugs.webkit.org/show_bug.cgi?id=170553
3563         http://trac.webkit.org/changeset/215190
3564
3565 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
3566
3567         Remove Reflect.enumerate
3568         https://bugs.webkit.org/show_bug.cgi?id=173806
3569
3570         Reviewed by Yusuke Suzuki.
3571
3572         * Scripts/run-jsc-stress-tests:
3573
3574 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
3575
3576         AX: Cannot call setValue() on contenteditable or ARIA text controls
3577         https://bugs.webkit.org/show_bug.cgi?id=173520
3578
3579         Reviewed by Ryosuke Niwa.
3580
3581         Add setValue() method to WKTR (already existed in DRT).
3582
3583         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3584         (WTR::AccessibilityUIElement::setValue):
3585         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3586         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3587         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3588         (WTR::AccessibilityUIElement::setValue):
3589
3590 2017-06-23  Keith Miller  <keith_miller@apple.com>
3591
3592         Switch VMTraps to use halt instructions rather than breakpoint instructions
3593         https://bugs.webkit.org/show_bug.cgi?id=173677
3594
3595         Reviewed by JF Bastien.
3596
3597         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3598         (TEST):
3599
3600 2017-06-23  Youenn Fablet  <youenn@apple.com>
3601
3602         Set getUserMedia permission to true by default on WTR
3603         https://bugs.webkit.org/show_bug.cgi?id=173610
3604
3605         Reviewed by Alex Christensen.
3606
3607         Adding a way to reset the getUserMedia permission to pending.
3608
3609         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3610         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3611         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
3612         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3613         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3614         (WTR::TestRunner::setUserMediaPermissionAsUnset):
3615         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3616         * WebKitTestRunner/TestController.cpp: