Source/WebKit2: <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links...
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-27  Dan Bernstein  <mitz@apple.com>
2
3         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
4         https://bugs.webkit.org/show_bug.cgi?id=79607
5
6         Reviewed by Adele Peterson.
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
9         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
10         (TestWebKitAPI::AcceptsFirstMouse::url):
11         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
12         (TestWebKitAPI::AcceptsFirstMouse::runTest):
13         (TestWebKitAPI::TEST_F):
14         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
15
16 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
17
18         Unreviewed. Fix make distcheck.
19
20         * GNUmakefile.am: Fix typo.
21
22 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
23
24         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
25
26         Reviewed by Kenneth Rohde Christiansen..
27
28         * qmake/mkspecs/features/features.prf:
29
30 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
31
32         Add a ChromiumGpuAndroid port.
33         https://bugs.webkit.org/show_bug.cgi?id=79628
34
35         Reviewed by Adam Barth.
36
37         Android does have a gpu port, so revert r107697.
38
39         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
40         (ChromiumAndroidPort.__init__):
41         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
42         (ChromiumGpuAndroidPort):
43         (ChromiumGpuAndroidPort.__init__):
44         (ChromiumGpuAndroidPort.baseline_search_path):
45         (ChromiumGpuAndroidPort.default_child_processes):
46         (ChromiumGpuAndroidPort.tests):
47         * Scripts/webkitpy/layout_tests/port/factory.py:
48         (PortFactory):
49
50 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
51
52         Change Build bot with BuildAndTest bot for EFL port.
53         https://bugs.webkit.org/show_bug.cgi?id=77518
54
55         Reviewed by Ryosuke Niwa.
56
57         EFL build bot starts to support layout test.
58
59         * BuildSlaveSupport/build.webkit.org-config/config.json:
60         * BuildSlaveSupport/built-product-archive:
61         (archiveBuiltProduct):
62         (extractBuiltProduct):
63         * BuildSlaveSupport/test-result-archive:
64         (archiveTestResults):
65         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
66         (generateBuildSystemFromCMakeProject):
67
68 2012-02-24  Darin Fisher  <darin@chromium.org>
69
70         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
71
72         Reviewed by James Robinson.
73
74         * Scripts/webkitpy/common/config/watchlist:
75
76 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
77
78         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
79         https://bugs.webkit.org/show_bug.cgi?id=79258
80
81         Reviewed by Ryosuke Niwa.
82
83         Split the fuzzy matching into separate functions so that they
84         can be sharded and run in parallel.
85
86         Also, fix a bug in the svn_blame_regexp that was causing us
87         to require ChangeLog lines to have at least one space after the
88         author, making the code require trailing whitespace in the
89         changelog in some places (this was making my life harder because
90         I have my text editor set to strip trailing whitespace in python
91         files, and that was causing test_parse_log_entries_from_changelog() to fail
92         when the whitespace on line 275 was removed).
93
94         * Scripts/webkitpy/common/checkout/changelog.py:
95         (ChangeLog):
96         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
97         (test_fuzzy_reviewer_match__none):
98         (test_fuzzy_reviewer_match_adam_barth):
99         (test_fuzzy_reviewer_match_darin_adler_et_al):
100         (test_fuzzy_reviewer_match_dimitri_glazkov):
101         (test_fuzzy_reviewer_match_george_staikos):
102         (test_fuzzy_reviewer_match_mark_rowe):
103
104 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
105
106         webkitpy: committers_unittest fuzzy matching is really slow
107         https://bugs.webkit.org/show_bug.cgi?id=79179
108
109         Reviewed by Ryosuke Niwa.
110
111         Break the fuzzy matching tests into individual routines for
112         each contributor so that the intent is a little clearer, so
113         that it's easier to test individual names (and identify
114         duplicate tests), and so that we can eventually run
115         them in parallel.
116
117         Also, mark most of them as 'integration' tests so that they
118         can be skipped if we want to go fast (we leave a few as
119         regular tests for functional coverage).
120
121         * Scripts/webkitpy/common/config/committers_unittest.py:
122         (CommittersTest):
123         (CommittersTest.test_contributors_by_fuzzy_match):
124         (CommittersTest.integration_test_contributors__none):
125         (CommittersTest.integration_test_contributors__none_2):
126         (CommittersTest.integration_test_contributors__none_3):
127         (CommittersTest.integration_test_contributors_ada_chan):
128         (CommittersTest.integration_test_contributors_adele_peterson):
129         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
130         (CommittersTest.integration_test_contributors_alice_liu):
131         (CommittersTest.integration_test_contributors_alp_toker):
132         (CommittersTest.integration_test_contributors_anders_carlsson):
133         (CommittersTest.integration_test_contributors_antti_koivisto):
134         (CommittersTest.integration_test_contributors_beth_dakin):
135         (CommittersTest.integration_test_contributors_brady_eidson):
136         (CommittersTest.integration_test_contributors_cameron_zwarich):
137         (CommittersTest.integration_test_contributors_chris_blumenberg):
138         (CommittersTest.integration_test_contributors_dan_bernstein):
139         (CommittersTest.integration_test_contributors_dan_bernstein_2):
140         (CommittersTest.integration_test_contributors_darin_adler):
141         (CommittersTest.integration_test_contributors_david_harrison):
142         (CommittersTest.integration_test_contributors_david_harrison_2):
143         (CommittersTest.integration_test_contributors_david_hyatt):
144         (CommittersTest.integration_test_contributors_david_kilzer):
145         (CommittersTest.integration_test_contributors_don_melton):
146         (CommittersTest.integration_test_contributors_eric_seidel):
147         (CommittersTest.integration_test_contributors_geoffrey_garen):
148         (CommittersTest.integration_test_contributors_greg_bolsinga):
149         (CommittersTest.integration_test_contributors_holger_freyther):
150         (CommittersTest.integration_test_contributors_jon_sullivan):
151         (CommittersTest.integration_test_contributors_jon_honeycutt):
152         (CommittersTest.integration_test_contributors_joseph_pecoraro):
153         (CommittersTest.integration_test_contributors_ken_kocienda):
154         (CommittersTest.integration_test_contributors_kenneth_russell):
155         (CommittersTest.integration_test_contributors_kevin_decker):
156         (CommittersTest.integration_test_contributors_kevin_mccullough):
157         (CommittersTest.integration_test_contributors_lars_knoll):
158         (CommittersTest.integration_test_contributors_lars_weintraub):
159         (CommittersTest.integration_test_contributors_maciej_stachowiak):
160         (CommittersTest.integration_test_contributors_mark_rowe):
161         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
162         (CommittersTest.integration_test_contributors_oliver_hunt):
163         (CommittersTest.integration_test_contributors_rniwa):
164         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
165         (CommittersTest.integration_test_contributors_steve_falkenburg):
166         (CommittersTest.integration_test_contributors_sam_weinig):
167         (CommittersTest.integration_test_contributors_tim_omernick):
168         (CommittersTest.integration_test_contributors_timothy_hatcher):
169         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
170         (CommittersTest.integration_test_contributors_vicki_murley):
171         (CommittersTest.integration_test_contributors_zack_rusin):
172
173 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
174
175         webkitpy: should autoinstall coverage
176         https://bugs.webkit.org/show_bug.cgi?id=79535
177
178         Reviewed by Eric Seidel.
179
180         We should automatically print the coverage report after the run, too.
181
182         * Scripts/webkitpy/test/main.py:
183         (Tester._run_tests):
184         * Scripts/webkitpy/thirdparty/__init__.py:
185         (AutoinstallImportHook.find_module):
186         (AutoinstallImportHook._install_coverage):
187
188 2012-02-24  Pablo Flouret  <pablof@motorola.com>
189
190         Fix copypasta in build-webkit's --vibration option description
191         https://bugs.webkit.org/show_bug.cgi?id=79528
192
193         Reviewed by Andreas Kling.
194
195         * Scripts/build-webkit:
196
197 2012-02-24  Antonio Gomes  <agomes@rim.com>
198
199         Adding myself to ScrollingCoordinator watchlist
200         https://bugs.webkit.org/show_bug.cgi?id=79525
201
202         Reviewed by Rob Buis.
203
204         * Scripts/webkitpy/common/config/watchlist:
205
206 2012-02-24  Darin Fisher  <darin@chromium.org>
207
208         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
209
210         Reviewed by Adam Barth.
211
212         * Scripts/webkitpy/common/config/watchlist:
213
214 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
215
216         webkitpy: config_unittest is sensitive to other tests that might've already run
217         https://bugs.webkit.org/show_bug.cgi?id=79382
218
219         Reviewed by Adam Barth.
220
221         If another test runs prior to config_unittest and pokes the
222         cached configuration, the first test in config_unittest might
223         fail; the tearDown() will then allow subsequent tests to pass.
224         Clearing the configuration prior to each test makes things
225         slightly slower but safer.
226
227         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
228         (ConfigTest.setUp):
229
230 2012-02-24  David Kilzer  <ddkilzer@apple.com>
231
232         Use xcrun to find compiler paths for Generate Derived Sources build phase script
233         <http://webkit.org/b/79512>
234
235         Reviewed by Dan Bernstein.
236
237         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
238         (Generate Derived Sources): Use xcrun to find the path to the
239         compiler since that works on both iOS and OS X.
240
241 2012-02-24  James Robinson  <jamesr@chromium.org>
242
243         Create a watchlist for ScrollingCoordinator changes
244         https://bugs.webkit.org/show_bug.cgi?id=79511
245
246         Reviewed by Anders Carlsson.
247
248         * Scripts/webkitpy/common/config/watchlist:
249
250 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
251
252         [EFL][DRT] Implement setValueForUser and setAutofilled.
253         https://bugs.webkit.org/show_bug.cgi?id=79237
254
255         Reviewed by Andreas Kling.
256
257         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
258         Those implementations are related with input fields and allow to pass following tests:
259         fast/forms/onchange-setvalueforuser.html
260         fast/forms/input-autofilled.html
261         fast/forms/reset-autofilled.html
262
263         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
264         (LayoutTestController::setValueForUser):
265         (LayoutTestController::setAutofilled):
266
267 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
268
269         [Qt] Allow to use WebCore imagedecoders
270         https://bugs.webkit.org/show_bug.cgi?id=32410
271
272         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
273
274         Reviewed by Simon Hausmann.
275
276         * qmake/mkspecs/features/features.prf:
277
278 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
279
280         [Qt] Add Qt5 way to force 96 DPI for tests
281         https://bugs.webkit.org/show_bug.cgi?id=79364
282
283         Reviewed by Simon Hausmann.
284
285         * DumpRenderTree/qt/main.cpp:
286         (main):
287         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
288         (WTR::activateFonts):
289
290 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
291
292         [GTK] MiniBrowser should reload the view then the reload button is clicked
293         https://bugs.webkit.org/show_bug.cgi?id=79472
294
295         Reviewed by Philippe Normand.
296
297         * MiniBrowser/gtk/BrowserWindow.c:
298         (reloadCallback): Call webkit_web_view_reload().
299         (browser_window_init): Connect reload item clicked even to
300         reloadCallback instead of activateUriEntryCallback.
301
302 2012-02-24  Kentaro Hara  <haraken@chromium.org>
303
304         Add performance tests for DOM attribute getters and setters
305         https://bugs.webkit.org/show_bug.cgi?id=79208
306
307         Reviewed by Ryosuke Niwa.
308
309         We want to allow perf tests to output info messages
310         that do not affect the test results. To accomplish this,
311         this patch modifies perftestsrunner.py so that it ignores
312         a line that starts from "Info:".
313
314         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
315         (PerfTestsRunner):
316
317 2012-02-24  Andrew Lo  <anlo@rim.com>
318
319         [BlackBerry] Enable requestAnimationFrame
320         https://bugs.webkit.org/show_bug.cgi?id=79408
321
322         Enable requestAnimationFrame for BlackBerry.
323
324         Reviewed by Rob Buis.
325
326         * Scripts/build-webkit:
327
328 2012-02-24  Adam Barth  <abarth@webkit.org>
329
330         style-queue tries to apply the patch twice
331         https://bugs.webkit.org/show_bug.cgi?id=79459
332
333         Reviewed by Eric Seidel.
334
335         Previously, we applied the patch using both apply-patch and
336         check-style.  This patch introduces a check-style-local to mirror the
337         apply-watchlist-local, which operates on the current working diff.
338
339         This patch also cleans up some other bugs I found by running the queue
340         locally for a while.  The queue still prints out a slightly
341         less-than-ideal message on the bugs when it find an error, but it's ok
342         for now.  We'll need to iterate a bit.
343
344         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
345         (StyleQueueTask.validate):
346         (StyleQueueTask._check_style):
347         * Scripts/webkitpy/tool/commands/download.py:
348         (CheckStyleLocal):
349         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
350         (EarlyWarningSytemTest._default_expected_stderr):
351         (EarlyWarningSytemTest._test_testing_ews):
352         * Scripts/webkitpy/tool/commands/queues.py:
353         (AbstractReviewQueue.handle_script_error):
354         (StyleQueue.review_patch):
355         * Scripts/webkitpy/tool/commands/queues_unittest.py:
356         * Scripts/webkitpy/tool/commands/queuestest.py:
357         (QueuesTest.assert_queue_outputs):
358
359 2012-02-23  Adam Barth  <abarth@webkit.org>
360
361         should_proceed_with_work_item is unused and can be removed
362         https://bugs.webkit.org/show_bug.cgi?id=79416
363
364         Reviewed by Eric Seidel.
365
366         We used to use this function to check whether the tree is red.  Now, we
367         don't use external measures of whether to proceed with work items.
368         Instead, we analyze them with the idea in mind that the tree might be
369         red.
370
371         * Scripts/webkitpy/tool/bot/queueengine.py:
372         (QueueEngineDelegate.next_work_item):
373         (QueueEngine.run):
374         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
375         (LoggingDelegate):
376         (LoggingDelegate.next_work_item):
377         (RaisingDelegate.process_work_item):
378         (QueueEngineTest.test_terminating_error):
379         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
380         (AbstractEarlyWarningSystem.__init__):
381         * Scripts/webkitpy/tool/commands/queues.py:
382         (AbstractQueue.next_work_item):
383         (FeederQueue.next_work_item):
384         (CommitQueue.next_work_item):
385         (AbstractReviewQueue.next_work_item):
386         (StyleQueue.__init__):
387         * Scripts/webkitpy/tool/commands/queues_unittest.py:
388         (FeederQueueTest.test_feeder_queue):
389         (CommitQueueTest.test_commit_queue):
390         (test_commit_queue_failure):
391         (test_commit_queue_failure_with_failing_tests):
392         (test_rollout):
393         (test_rollout_lands):
394         (StyleQueueTest.test_style_queue_with_style_exception):
395         (test_style_queue_with_watch_list_exception):
396         * Scripts/webkitpy/tool/commands/queuestest.py:
397         (QueuesTest.assert_queue_outputs):
398         * Scripts/webkitpy/tool/commands/sheriffbot.py:
399         (SheriffBot.next_work_item):
400
401 2012-02-23  Adrienne Walker  <enne@google.com>
402
403         Unreviewed, add Stephen Chenney to committers.py as a contributor.
404
405         * Scripts/webkitpy/common/config/committers.py:
406
407 2012-02-23  Adam Barth  <abarth@webkit.org>
408
409         style-queue logs bogus messages to the QueueStatusServer
410         https://bugs.webkit.org/show_bug.cgi?id=79424
411
412         Reviewed by Eric Seidel.
413
414         Copy/paste error.
415
416         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
417         (StyleQueueTask._check_style):
418         (StyleQueueTask._apply_watch_list):
419         * Scripts/webkitpy/tool/commands/queues_unittest.py:
420
421 2012-02-23  Eric Seidel  <eric@webkit.org>
422
423         Use self._filesystem in more places in the SCM classes
424         https://bugs.webkit.org/show_bug.cgi?id=79415
425
426         Reviewed by Adam Barth.
427
428         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
429         (SCMDetectorTest.test_detect_scm_system):
430         * Scripts/webkitpy/common/checkout/scm/git.py:
431         (Git.find_checkout_root):
432         (Git.to_object_name):
433         * Scripts/webkitpy/common/checkout/scm/scm.py:
434         (SCM.__init__):
435         (SCM.in_working_directory):
436         * Scripts/webkitpy/common/checkout/scm/svn.py:
437         (SVN.find_uuid):
438         (SVN.find_checkout_root):
439
440 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
441
442         Unreviewed, rolling out r108685.
443         http://trac.webkit.org/changeset/108685
444         https://bugs.webkit.org/show_bug.cgi?id=79414
445
446         Broke Chromium builds (Requested by enne on #webkit).
447
448         * qmake/mkspecs/features/features.prf:
449
450 2012-02-23  Adam Barth  <abarth@webkit.org>
451
452         style-queue shouldn't spam bugs if it fails to update its working copy
453         https://bugs.webkit.org/show_bug.cgi?id=79412
454
455         Reviewed by Eric Seidel.
456
457         This patch moves style-queue over to the new PatchAnalysisTask
458         infrastructure, which is smarter about retrying patches when update
459         fails.
460
461         * Scripts/webkitpy/common/system/executive_mock.py:
462         (MockExecutive.run_and_throw_if_fail):
463         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
464         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
465         (UnableToApplyPatch):
466         (UnableToApplyPatch.__init__):
467         (PatchAnalysisTask.__init__):
468         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
469         (StyleQueueTaskDelegate):
470         (StyleQueueTaskDelegate.parent_command):
471         (StyleQueueTask):
472         (StyleQueueTask.validate):
473         (StyleQueueTask._check_style):
474         (StyleQueueTask._apply_watch_list):
475         (StyleQueueTask.run):
476         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
477         * Scripts/webkitpy/tool/commands/queues.py:
478         (StyleQueue):
479         (StyleQueue.should_proceed_with_work_item):
480         (StyleQueue.review_patch):
481         (StyleQueue.run_command):
482         (StyleQueue.command_passed):
483         (StyleQueue.command_failed):
484         (StyleQueue.expected_failures):
485         (StyleQueue.refetch_patch):
486         * Scripts/webkitpy/tool/commands/queues_unittest.py:
487         (StyleQueueTest.test_style_queue_with_style_exception):
488         (test_style_queue_with_watch_list_exception):
489
490 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
491
492         [Qt] Allow to use WebCore imagedecoders
493         https://bugs.webkit.org/show_bug.cgi?id=32410
494
495         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
496
497         Reviewed by Simon Hausmann.
498
499         * qmake/mkspecs/features/features.prf:
500
501 2012-02-23  Eric Seidel  <eric@webkit.org>
502
503         Remove old broken find_checkout_root tests now that find_checkout_root is gone
504         https://bugs.webkit.org/show_bug.cgi?id=79405
505
506         Reviewed by Adam Barth.
507
508         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
509         (SCMDetectorTest):
510         (SCMDetectorTest.test_find_checkout_root):
511         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
512         (SVNTestRepository.tear_down):
513
514 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
515
516         [Qt][WK2] Implement proxy authentication dialog.
517         https://bugs.webkit.org/show_bug.cgi?id=79350
518
519         Reviewed by Simon Hausmann.
520
521         * MiniBrowser/qt/MiniBrowser.qrc:
522         * MiniBrowser/qt/qml/BrowserWindow.qml:
523         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
524
525 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
526
527         [wx] Build fix, add recently added source dirs.
528
529         * waf/build/settings.py:
530
531 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
532
533         [Qt] Add support for touch cancellation
534         https://bugs.webkit.org/show_bug.cgi?id=79348
535
536         Reviewed by Kenneth Rohde Christiansen.
537
538         Added straight-forward touch cancellation event sending to Qt WK1 DRT
539         and WK2 WTR.
540
541         * DumpRenderTree/qt/EventSenderQt.cpp:
542         (EventSender::touchCancel):
543         (EventSender::cancelTouchPoint):
544         * DumpRenderTree/qt/EventSenderQt.h:
545         (EventSender):
546         * WebKitTestRunner/EventSenderProxy.h:
547         (EventSenderProxy):
548         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
549         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
550         (WTR::EventSendingController::touchCancel):
551         (WTR):
552         (WTR::EventSendingController::cancelTouchPoint):
553         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
554         (EventSendingController):
555         * WebKitTestRunner/TestController.cpp:
556         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
557         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
558         (WTR::EventSenderProxy::touchCancel):
559         (WTR):
560         (WTR::EventSenderProxy::cancelTouchPoint):
561
562 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
563
564         Unreviewed, rolling out r108626.
565         http://trac.webkit.org/changeset/108626
566         https://bugs.webkit.org/show_bug.cgi?id=79370
567
568         broke qt-wk2 bot, somehow the workaround does not work on the
569         bot (Requested by Ossy on #webkit).
570
571         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
572         (WTR::WrapperWindow::handleStatusChanged):
573         (WTR::PlatformWebView::resizeTo):
574
575 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
576
577         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
578         https://bugs.webkit.org/show_bug.cgi?id=78481
579
580         Reviewed by Gustavo Noronha Silva.
581
582         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
583         to create gdk press key event.
584         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
585         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
586
587         * DumpRenderTree/gtk/EventSender.cpp:
588         (scheduleAsynchronousClickCallback):
589         (createKeyPressEvent):
590         (sendKeyDown):
591         (keyDownCallback):
592         (sendAsynchronousKeyDown):
593         (scheduleAsynchronousKeyDownCallback):
594
595 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
596
597         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
598         https://bugs.webkit.org/show_bug.cgi?id=76546
599
600         Reviewed by Simon Hausmann.
601
602         Co-authored with Simon Hausmann.
603
604         Revert the workaround introduced in r107868 and reintroduce
605         the qml binding so we can test the code path that we are more
606         interested in. The reason that it did not work before is that
607         we don't have an active platform window which we now workaround
608         by propagating the resize through QWindowSystemInterface.
609
610         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
611         (WTR::WrapperWindow::handleStatusChanged):
612         (WTR::PlatformWebView::resizeTo):
613
614 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
615
616         Unreviewed, rolling out r108577.
617         http://trac.webkit.org/changeset/108577
618         https://bugs.webkit.org/show_bug.cgi?id=79359
619
620         It doesn't work as expected (Requested by Ossy on #webkit).
621
622         * DumpRenderTree/qt/EventSenderQt.cpp:
623         (EventSender::postEvent):
624         * DumpRenderTree/qt/EventSenderQt.h:
625         (EventSender):
626
627 2012-02-23  Philippe Normand  <pnormand@igalia.com>
628
629         [GTK] FullScreen signals
630         https://bugs.webkit.org/show_bug.cgi?id=76181
631
632         Reviewed by Martin Robinson.
633
634         Use the two new entering/leaving fullscreen signals to hide/show
635         the tool bar, the status bar and ask the user's permission before
636         entering fullscreen.
637
638         * GtkLauncher/main.c:
639         (webViewFullscreenMessageWindowClose):
640         (webViewWindowStateEvent):
641         (hide_widget):
642         (show_widget):
643         (webViewEnteringFullScreen):
644         (webViewLeavingFullScreen):
645         (createBrowser):
646         (createWindow):
647
648 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
649
650         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
651         https://bugs.webkit.org/show_bug.cgi?id=79076
652
653         Reviewed by Andreas Kling.
654
655         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
656         (builtDylibPathForName):
657
658 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
659
660         [Qt] Add eventSender.gestureTap
661         https://bugs.webkit.org/show_bug.cgi?id=66173
662
663         Reviewed by Kenneth Rohde Christiansen.
664
665         * DumpRenderTree/qt/EventSenderQt.cpp:
666         (EventSender::gestureTap):
667         * DumpRenderTree/qt/EventSenderQt.h:
668
669 2012-02-22  Brady Eidson  <beidson@apple.com>
670
671         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
672         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
673
674         Reviewed by Anders Carlsson.
675
676         Update our tools to the new form of the PageLoadClient.
677
678         * MiniBrowser/mac/BrowserWindowController.m:
679         (-[BrowserWindowController awakeFromNib]): 
680
681         * WebKitTestRunner/TestController.cpp:
682         (WTR::TestController::initialize):
683
684 2012-02-22  Daniel Bates  <dbates@webkit.org>
685
686         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
687         https://bugs.webkit.org/show_bug.cgi?id=79277
688
689         Reviewed by Adam Barth.
690
691         Pass command line argument no-saved-state to run-safari to disable Safari
692         state restoration for the session on OS 10.7.
693
694         * Scripts/webkitpy/layout_tests/port/mac.py:
695         (MacPort.show_results_html_file):
696         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
697         (test_show_results_html_file):
698
699 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
700
701         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
702         https://bugs.webkit.org/show_bug.cgi?id=77759
703
704         Reviewed by Tony Chang.
705
706         Fixes build with gcc 4.7.
707
708         r100432 added the include only for ANDROID; this changes the ifdef to
709         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
710         longer implicitly includes unistd.h from standard headers and other
711         unix platforms are likely to get gcc 4.7 as well in the future.
712
713         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
714
715 2012-02-22  Philippe Normand  <pnormand@igalia.com>
716
717         Unreviewed, rolling out r108522.
718         http://trac.webkit.org/changeset/108522
719         https://bugs.webkit.org/show_bug.cgi?id=76181
720
721         Broke 4 fullscreen tests on GTK.
722
723         * GtkLauncher/main.c:
724         (createBrowser):
725         (createWindow):
726
727 2012-02-20  Philippe Normand  <pnormand@igalia.com>
728
729         [GTK] FullScreen signals
730         https://bugs.webkit.org/show_bug.cgi?id=76181
731
732         Reviewed by Martin Robinson.
733
734         Use the two new entering/leaving fullscreen signals to hide/show
735         the tool bar, the status bar and ask the user's permission before
736         entering fullscreen.
737
738         * GtkLauncher/main.c:
739         (webViewFullscreenMessageWindowClose):
740         (webViewWindowStateEvent):
741         (hide_widget):
742         (show_widget):
743         (webViewEnteringFullScreen):
744         (webViewLeavingFullScreen):
745         (createBrowser):
746         (createWindow):
747
748 2012-02-22  Rob Flack  <flackr@chromium.org>
749
750         Update Linux ChromiumOS builders in flakiness dashboard.
751         https://bugs.webkit.org/show_bug.cgi?id=79238
752
753         Reviewed by Ojan Vafai.
754
755         * TestResultServer/static-dashboards/builders.js:
756
757 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
758
759         webkitpy: test_function_length_check_definition_huge_lines is slow
760         https://bugs.webkit.org/show_bug.cgi?id=79185
761
762         Reviewed by Adam Barth.
763
764         This test takes ~3 seconds to run, apparently because we're
765         running a test on a 10,000 line function :). Dropping the
766         function length to 640 still exercises the code path and
767         provides a 10x speedup.
768
769         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
770         (CppStyleTest):
771         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
772
773 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
774
775         webkitpy: speed up FileLockTest.test_lock_lifecycle
776         https://bugs.webkit.org/show_bug.cgi?id=79189
777
778         Reviewed by Adam Barth.
779
780         The unit test had a second lock trying to acquire a
781         lock already held, and a hard-coded timeout of one second.
782         I have changed the timeouts to a tenth of a second (which
783         is probably still fine) and changed the hard-spin on
784         the lock to a slow-spin every hundredth of a second.
785
786         * Scripts/webkitpy/common/system/file_lock.py:
787         (FileLock.acquire_lock):
788         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
789         (FileLockTest.setUp):
790         (FileLockTest.test_stuck_lock):
791
792 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
793
794         build-webkit should use environment variable at number of CPU
795         detection on all platform
796         https://bugs.webkit.org/show_bug.cgi?id=79227
797
798         Reviewed by Martin Robinson.
799
800         * Scripts/webkitdirs.pm:
801         (determineNumberOfCPUs):
802
803 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
804
805         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
806         https://bugs.webkit.org/show_bug.cgi?id=78960
807
808         Reviewed by Csaba Osztrogonác.
809
810         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
811         (LayoutTestController::overridePreference):
812
813 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
814
815         [chromium] Build WebKit with MEDIA_STREAM disabled.
816         https://bugs.webkit.org/show_bug.cgi?id=79214
817
818         Reviewed by Kent Tamura.
819
820         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
821         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
822         * DumpRenderTree/chromium/WebViewHost.cpp:
823         (WebViewHost::createMediaPlayer):
824         * DumpRenderTree/chromium/WebViewHost.h:
825         (WebViewHost):
826
827 2012-02-22  Zeno Albisser  <zeno@webkit.org>
828
829         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
830         https://bugs.webkit.org/show_bug.cgi?id=79124
831
832         WebKitTestRunnerPrefix.h should also be included
833         when building with clang.
834
835         Reviewed by Kenneth Rohde Christiansen.
836
837         * WebKitTestRunner/Target.pri:
838
839 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
840
841         <style scoped>: Add runtime-flag
842         https://bugs.webkit.org/show_bug.cgi?id=79074
843
844         Enable the runtime-flag for DRT. 
845
846         Reviewed by Dimitri Glazkov.
847
848         * DumpRenderTree/chromium/TestShell.cpp:
849         (TestShell::TestShell):
850
851 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
852
853         Unreviewed, rolling out r107351.
854         http://trac.webkit.org/changeset/107351
855         https://bugs.webkit.org/show_bug.cgi?id=53600
856
857         Several issues introduced in WebKitGTK+ API
858
859         * DumpRenderTree/gtk/DumpRenderTree.cpp:
860         (createWebView):
861         * GtkLauncher/main.c:
862         (createWebViewCb):
863         (createBrowser):
864         (createWindow):
865         (main):
866
867 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
868
869         JSC should be a triple-tier VM
870         https://bugs.webkit.org/show_bug.cgi?id=75812
871         <rdar://problem/10079694>
872
873         Reviewed by Gavin Barraclough.
874
875         Changed EFL's build system to include a new directory in JavaScriptCore.
876
877         * DumpRenderTree/efl/CMakeLists.txt:
878
879 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
880
881         [chromium] Fix image drag out on Chromium
882         https://bugs.webkit.org/show_bug.cgi?id=79158
883
884         Reviewed by Tony Chang.
885
886         * DumpRenderTree/chromium/EventSender.cpp:
887         (EventSender::dumpFilenameBeingDragged):
888         (EventSender::beginDragWithFiles):
889         * DumpRenderTree/chromium/WebViewHost.cpp:
890         (addDRTFakeFileToDataObject):
891
892 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
893
894         webkitpy: speed up hot filesystem_mock functions
895         https://bugs.webkit.org/show_bug.cgi?id=79159
896
897         Reviewed by Adam Barth.
898
899         Profiling run_webkit_tests_integrationtest.py revealed that
900         isdir(), normpath(), and join() are called a lot and were very
901         slow.This patch speeds them up substantially, shaving 20 seconds
902         off of the execution time.
903
904         * Scripts/webkitpy/common/system/filesystem_mock.py:
905         (MockFileSystem.isdir):
906         (MockFileSystem._slow_but_correct_join):
907         (MockFileSystem.join):
908         (MockFileSystem.listdir):
909         (MockFileSystem._slow_but_correct_normpath):
910         (MockFileSystem.normpath):
911         (MockFileSystem.write_binary_file):
912         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
913         (MockFileSystemTest.quick_check):
914         (MockFileSystemTest):
915         (MockFileSystemTest.test_join):
916         (MockFileSystemTest.test_normpath):
917         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
918         (get_test_config): Call write_binary_file() instead of updating
919           filesystem.files directly, so that we create directories as
920           needed.
921
922 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
923
924         nrwt: make the delay between starting workers configurable per-port
925         https://bugs.webkit.org/show_bug.cgi?id=79148
926
927         Reviewed by Eric Seidel.
928
929         Because of bug 79147, we have to sleep a bit in between starting
930         DRTs; however, doing so across the board slows down the Test
931         port. Making this configurable shaves 10 seconds off of
932         run_webkit_tests_integrationtest.py
933         
934         * Scripts/webkitpy/layout_tests/controllers/manager.py:
935         (Manager._run_tests):
936         * Scripts/webkitpy/layout_tests/port/base.py:
937         (Port.worker_startup_delay_secs):
938         * Scripts/webkitpy/layout_tests/port/test.py:
939         (TestPort.worker_startup_delay_secs):
940
941 2012-02-21  Jon Lee  <jonlee@apple.com>
942
943         Bring notifications support to WK1 mac
944         https://bugs.webkit.org/show_bug.cgi?id=78783
945         <rdar://problem/10610578>
946
947         Reviewed by Anders Carlsson.
948
949         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
950         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
951         (-[UIDelegate timerFired]):
952
953 2012-02-21  Kentaro Hara  <haraken@chromium.org>
954
955         Enable the IDL attribute checker in run-bindings-tests
956         https://bugs.webkit.org/show_bug.cgi?id=79091
957
958         Reviewed by Adam Barth.
959
960         We have enabled the IDL attribute checker in Chromium in r108322.
961         This patch enables the IDL attribute checker in run-bindings-tests.
962
963         No tests. I manually checked that [Custommm], [CallWith=],
964         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
965         run-bindings-tests failures.
966
967         * Scripts/webkitpy/bindings/main.py:
968         (BindingsTests.generate_supplemental_dependency):
969
970 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
971
972         Add rafaelw as a committer.
973
974         Unreviewed.
975
976         * Scripts/webkitpy/common/config/committers.py:
977
978 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
979
980         webkitpy: update names after deleting message_broker
981         https://bugs.webkit.org/show_bug.cgi?id=79000
982
983         Reviewed by Eric Seidel.
984
985         Part 3 of 3 in deleting message_broker.py; this change just
986         adjusts the names for the newly merged symbols so that they are
987         private as appropriate.
988
989         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
990         (get):
991         (_Broker):
992         (_BrokerConnection):
993         (_BrokerConnection.__init__):
994         (AbstractWorker.__init__):
995         (_ManagerConnection):
996         (_ManagerConnection.__init__):
997         (_WorkerConnection):
998         (_WorkerConnection.__init__):
999
1000 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
1001
1002         webkitpy: merge message_broker.py into manager_worker_broker.py
1003         https://bugs.webkit.org/show_bug.cgi?id=78999
1004
1005         Reviewed by Tony Chang.
1006
1007         This is pretty much a straight cut-and-paste of one file into
1008         another (broken up so that docstrings and imports are in the
1009         right place).
1010
1011         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1012         (BrokerClient):
1013         (BrokerClient.is_done):
1014         (BrokerClient.name):
1015         (Broker):
1016         (Broker.__init__):
1017         (Broker.add_topic):
1018         (Broker._get_queue_for_topic):
1019         (Broker.post_message):
1020         (Broker.run_message_loop):
1021         (Broker.run_all_pending):
1022         (Broker._run_loop):
1023         (Broker._dispatch_message):
1024         (_Message):
1025         (_Message.loads):
1026         (_Message.__init__):
1027         (_Message.dumps):
1028         (_Message.__repr__):
1029         (BrokerConnection):
1030         (BrokerConnection.__init__):
1031         (BrokerConnection.run_message_loop):
1032         (BrokerConnection.post_message):
1033         (BrokerConnection.raise_exception):
1034         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
1035
1036 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
1037
1038         webkitpy: prepare to delete message_broker.py
1039         https://bugs.webkit.org/show_bug.cgi?id=78997
1040
1041         Reviewed by Eric Seidel.
1042
1043         This is part 1 of 3 changes to fix bug 78187. This change
1044         prepares the code for merging message_broker.py into
1045         manager_worker_broker.py; the tests in message_broker_unittest
1046         are merged into manager_worker_broker_unittest, the symbols
1047         needed by the tests are exported from manager_worker_broker.py,
1048         and manager_worker_broker itself is updated to refer to the
1049         symbols directly (without the module prefix).
1050
1051         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1052         (get):
1053         (AbstractWorker):
1054         (AbstractWorker.__init__):
1055         (_ManagerConnection):
1056         (_ManagerConnection.__init__):
1057         (_WorkerConnection):
1058         (_WorkerConnection.__init__):
1059         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1060         (InterfaceTest.test_brokerclient_is_abstract):
1061         (InterfaceTest.test_brokerclient_is_abstract.methods):
1062         (MessageTest):
1063         (MessageTest.test__no_body):
1064         (MessageTest.test__body):
1065         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
1066
1067 2012-02-21  Sam Weinig  <sam@webkit.org>
1068
1069         Attempt to fix the Snow Leopard build.
1070
1071         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1072         * MiniBrowser/Configurations/Base.xcconfig:
1073         * TestWebKitAPI/Configurations/Base.xcconfig:
1074         * WebKitTestRunner/Configurations/Base.xcconfig:
1075
1076 2012-02-21  Sam Weinig  <sam@webkit.org>
1077
1078         Use libc++ when building with Clang on Mac
1079         https://bugs.webkit.org/show_bug.cgi?id=78981
1080
1081         Reviewed by Dan Bernstein.
1082
1083         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1084         * MiniBrowser/Configurations/Base.xcconfig:
1085         * TestWebKitAPI/Configurations/Base.xcconfig:
1086         * WebKitTestRunner/Configurations/Base.xcconfig:
1087
1088 2012-02-21  Adam Roben  <aroben@apple.com>
1089
1090         Roll out r108309, r108323, and r108326
1091
1092         They broke the 32-bit Lion build.
1093
1094         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
1095
1096         * DumpRenderTree/efl/CMakeLists.txt:
1097
1098 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
1099
1100         [Qt][WK2] Get rid of the dependency to QtWidgets
1101         https://bugs.webkit.org/show_bug.cgi?id=76276
1102
1103         Reviewed by Simon Hausmann.
1104
1105         * MiniBrowser/qt/MiniBrowser.pro:
1106         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1107         (MiniBrowserApplication::MiniBrowserApplication):
1108         (MiniBrowserApplication::notify):
1109         (MiniBrowserApplication::sendTouchEvent):
1110         * MiniBrowser/qt/MiniBrowserApplication.h:
1111         (MiniBrowserApplication):
1112         * QtTestBrowser/locationedit.h:
1113         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1114         (WTR::activateFonts):
1115         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1116
1117 2012-02-20  Adam Barth  <abarth@webkit.org>
1118
1119         mastercfg_unittest.py fails without simplejson
1120         https://bugs.webkit.org/show_bug.cgi?id=79070
1121
1122         Reviewed by Csaba Osztrogonác.
1123
1124         Now that we require Python 2.6 (and higher) we can import json rather
1125         than simplejson.  We still need to use the simplejson name because
1126         that's what the master.cfg script expects.
1127
1128         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1129         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
1130
1131 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
1132
1133         JSC should be a triple-tier VM
1134         https://bugs.webkit.org/show_bug.cgi?id=75812
1135         <rdar://problem/10079694>
1136
1137         Reviewed by Gavin Barraclough.
1138
1139         Changed EFL's build system to include a new directory in JavaScriptCore.
1140
1141         * DumpRenderTree/efl/CMakeLists.txt:
1142
1143 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
1144
1145         Update pywebsocket to 0.7.2
1146         https://bugs.webkit.org/show_bug.cgi?id=79066
1147
1148         This version includes vendor-prefixed deflate-frame extension support.
1149
1150         Reviewed by Kent Tamura.
1151
1152         * Scripts/webkitpy/thirdparty/__init__.py:
1153         (AutoinstallImportHook._install_pywebsocket):
1154
1155 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
1156
1157         [UNIX] Plugin information fields are not interpreted as UTF-8
1158         https://bugs.webkit.org/show_bug.cgi?id=78635
1159
1160         Reviewed by Gustavo Noronha Silva.
1161
1162         Interpret plugin metadata as UTF8 aways. This matches the behavior
1163         of Chromium and the Totem plugin.
1164
1165         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1166         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
1167
1168 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
1169
1170         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
1171         https://bugs.webkit.org/show_bug.cgi?id=78935
1172
1173         Reviewed by Gustavo Noronha Silva.
1174
1175         Move the TestNetscapePlugin headers to a more appropriate directory and update
1176         the build files to match.
1177
1178         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
1179         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
1180         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
1181         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
1182         * GNUmakefile.am: Ditto.
1183
1184 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
1185
1186         Add a new API for the Vibration API(W3C).
1187         https://bugs.webkit.org/show_bug.cgi?id=72010
1188
1189         Reviewed by Hajime Morita.
1190
1191         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
1192
1193 2012-02-20  János Badics  <dicska@gmail.com>
1194
1195         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
1196         https://bugs.webkit.org/show_bug.cgi?id=71816
1197
1198         RunQtAPITests will notify if a timeout occurs during testing.
1199         Added unittest to the master.cfg
1200
1201         Reviewed by Csaba Osztrogonác.
1202
1203         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1204         (RunQtAPITests.evaluateCommand):
1205         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1206         (RunQtAPITestsTest):
1207         (RunQtAPITestsTest.assertResults):
1208         (RunQtAPITestsTest.test_timeout):
1209         (test_success):
1210         (test_failure):
1211         (test_timeout_and_failure):
1212
1213 2012-02-20  Andy Wingo  <wingo@igalia.com>
1214
1215         Add wingo as a committer.
1216
1217         Unreviewed.
1218
1219         * Scripts/webkitpy/common/config/committers.py: Add myself to the
1220         committers list.
1221
1222 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
1223
1224         [chromium] check that we're not running multiple modal dialogs at the same time
1225         https://bugs.webkit.org/show_bug.cgi?id=78486
1226
1227         Reviewed by Kent Tamura.
1228
1229         * DumpRenderTree/chromium/TestShell.cpp:
1230         (TestShell::TestShell):
1231         * DumpRenderTree/chromium/TestShell.h:
1232         (TestShell::setIsDisplayingModalDialog):
1233         (TestShell::isDisplayingModalDialog):
1234         (TestShell):
1235         * DumpRenderTree/chromium/WebViewHost.cpp:
1236         (WebViewHost::runModal):
1237
1238 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
1239
1240         Fix WebKit2GTK+ for 'make distcheck'.
1241
1242         Instead of conditionally including WebKit2 GNUmakefiles, always
1243         include them and conditionally activate the final targets.
1244
1245         * MiniBrowser/gtk/GNUmakefile.am:
1246         * WebKitTestRunner/GNUmakefile.am:
1247
1248 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1249
1250         Enable video option for EFL port in build-webkit.
1251         https://bugs.webkit.org/show_bug.cgi?id=79006
1252
1253         Reviewed by Daniel Bates.
1254
1255         * Scripts/build-webkit:
1256
1257 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
1258
1259         [EFL] Use modifier keys to execute pre-rendering.
1260         https://bugs.webkit.org/show_bug.cgi?id=77933
1261
1262         Reviewed by Chang Shu.
1263
1264         Use modifier key to execute pre-rendering instead of using reserved function keys.
1265
1266         * EWebLauncher/main.c:
1267         (on_key_down):
1268
1269 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1270
1271         Fix one more dangling reference to worker_connection.name, delete unused code.
1272
1273         Unreviewed, build fix.
1274
1275         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1276         (Manager.update):
1277         (_WorkerState.__init__):
1278
1279 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1280
1281         Add a change that should've been in r108005.
1282
1283         Unreviewed, build fix.
1284
1285         In the refactoring/cleanup in r108005 I should've changed the
1286         implementation of WorkerConnection to make it match BrokerClient
1287         (and everything else) so that objects had a name() method
1288         instead of a name property.
1289
1290         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1291         (Manager._run_tests):
1292         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1293         (_WorkerConnection.__init__):
1294         (_WorkerConnection.name):
1295         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1296         (_TestWorker.__init__):
1297         (_TestsMixin.name):
1298         (_TestsMixin.test_name):
1299         (_TestsMixin.test_cancel):
1300         (_TestsMixin.test_unknown_message):
1301
1302 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1303
1304         webkitpy: remove webkitpy.common.array_stream
1305         https://bugs.webkit.org/show_bug.cgi?id=78952
1306
1307         Reviewed by Eric Seidel.
1308
1309         Turns out array_stream didn't really do anything that StringIO
1310         didn't do (at least as of Python 2.6). This change removes it
1311         and updates all of the callers. Where possible, I changed the
1312         test assertions in order to capture the intent more clearly,
1313         e.g., instead of calling self.assertTrue('foo' in stream.get()),
1314         we have self.assertContainsLine(stream, 'foo'), and instead of
1315         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
1316         the latter isn't that much more readable, but StringIO doesn't
1317         export an empty() method.
1318
1319         * Scripts/webkitpy/common/array_stream.py: Removed.
1320         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
1321         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1322         (passing_run):
1323         (run_and_capture):
1324         (StreamTestingMixin):
1325         (StreamTestingMixin.assertContains):
1326         (StreamTestingMixin.assertContainsLine):
1327         (StreamTestingMixin.assertEmpty):
1328         (StreamTestingMixin.assertNotEmpty):
1329         (LintTest):
1330         (LintTest.test_lint_test_files):
1331         (LintTest.test_lint_test_files__errors):
1332         (MainTest):
1333         (MainTest.test_child_process_1):
1334         (MainTest.test_child_processes_2):
1335         (MainTest.test_child_processes_min):
1336         (MainTest.test_help_printing):
1337         (MainTest.test_hung_thread):
1338         (MainTest.test_no_tests_found):
1339         (MainTest.test_no_tests_found_2):
1340         (MainTest.test_repeat_each_iterations_num_tests):
1341         (MainTest.test_test_list):
1342         (MainTest.test_unexpected_failures):
1343         (MainTest.test_worker_model__inline_with_child_processes):
1344         (MainTest.test_additional_platform_directory):
1345         (RebaselineTest):
1346         (RebaselineTest.assertBaselines):
1347         (RebaselineTest.test_reset_results):
1348         (RebaselineTest.test_missing_results):
1349         (RebaselineTest.test_new_baseline):
1350         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1351         (MeteredStream.update):
1352         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1353         (TestMeteredStream.test_regular):
1354         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1355         (TestUtilityFunctions.assertEmpty):
1356         (TestUtilityFunctions):
1357         (TestUtilityFunctions.assertNotEmpty):
1358         (TestUtilityFunctions.assertWritten):
1359         (TestUtilityFunctions.test_configure_logging):
1360         (Testprinter.assertEmpty):
1361         (Testprinter):
1362         (Testprinter.assertNotEmpty):
1363         (Testprinter.assertWritten):
1364         (Testprinter.reset):
1365         (Testprinter.get_printer):
1366         (Testprinter.test_help_printer):
1367         (Testprinter.do_switch_tests.do_helper):
1368         (Testprinter.test_print_one_line_summary):
1369         (Testprinter.test_print_test_result):
1370         (Testprinter.test_print_progress):
1371         (Testprinter.test_write_nothing):
1372         (Testprinter.test_write_misc):
1373         (Testprinter.test_write_everything):
1374         (Testprinter.test_write_verbose):
1375         (Testprinter.test_print_unexpected_results):
1376         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1377         (MainTest.assertWritten):
1378         (create_runner):
1379         (test_run_test_set):
1380         (test_run_test_set_kills_drt_per_run):
1381         (test_run_test_set_for_parser_tests):
1382         (test_run_test_set_with_json_output):
1383         (test_run_test_set_with_json_source):
1384         (test_run_test_set_with_multiple_repositories):
1385         (test_upload_json):
1386
1387 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
1388
1389         [wx] Add the WebCore/page/scrolling directory to the build dirs.
1390
1391         * waf/build/settings.py:
1392
1393 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
1394
1395         [wx] Unreviewed build fix. Don't error out or hang if we have
1396         downloaded dependencies but server update check fails.
1397
1398         * waf/build/build_utils.py:
1399         (download_if_newer):
1400
1401 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1402
1403         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
1404         https://bugs.webkit.org/show_bug.cgi?id=69444
1405
1406         Reviewed by Tony Chang.
1407
1408         Currently if a test's image checksum doesn't match the checksum
1409         in the baseline, but the images themselves match according to
1410         ImageDiff, new-run-webkit-tests ignores the problem. This is
1411         probably bad, but it's not yet clear what the right thing to do
1412         is. This patch will log a warning to stderr, at least (but the
1413         test will still pass).
1414
1415         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1416         (SingleTestRunner._compare_image):
1417         (SingleTestRunner._run_reftest):
1418         * Scripts/webkitpy/layout_tests/port/test.py:
1419         (unit_test_list):
1420         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1421
1422 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1423
1424         NRWT does not report failure for a skipped test
1425         https://bugs.webkit.org/show_bug.cgi?id=78750
1426
1427         Reviewed by Eric Seidel.
1428
1429         If a test is listed in a Skipped file and you run it anyway
1430         with --force, and the test fails, currently NRWT will print
1431         "test ran as expected"; this is confusing, because you probably
1432         expect the test to fail and yet this might lead you to think the
1433         test passed. This patch changes the expected behavior to "PASS",
1434         so tests that fail will be reported.
1435
1436         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1437         (result_was_expected):
1438         (TestExpectationParser):
1439         (TestExpectationParser.expectation_for_skipped_test):
1440         (TestExpectations):
1441         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1442         (test_add_skipped_tests):
1443         * Scripts/webkitpy/layout_tests/port/test.py:
1444         (unit_test_list): Add some tests that are expected to be in a Skipped file.
1445         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
1446
1447 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1448
1449         webkitpy: fix test code after bug 78181
1450         https://bugs.webkit.org/show_bug.cgi?id=78870
1451
1452         Reviewed by Adam Barth.
1453
1454         I forgot to update the test code as per Tony's suggestion in
1455         bug 78181 (r108005). This change does that, and in doing so
1456         it revealed a subtle bug in _InlineWorkerConnection.run() that
1457         I am fixing as part of this (_alive would not be cleared if an
1458         exception was thrown).
1459
1460         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1461         (_InlineWorkerConnection.run):
1462         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1463         (_TestWorker.__init__):
1464         (_TestWorker.handle_stop):
1465         (_TestWorker.handle_test):
1466         (_TestWorker.run):
1467         (_TestsMixin.handle_exception):
1468         (_TestsMixin.test_unknown_message):
1469
1470 2012-02-17  Adam Roben  <aroben@apple.com>
1471
1472         Mac build fix after r108119
1473
1474         * DumpRenderTree/mac/DumpRenderTree.mm:
1475         (runThread):
1476         (runPthread):
1477         (testThreadIdentifierMap):
1478         Updated to match current WTF threading APIs.
1479
1480 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1481
1482         revert r107147 - breaks webkit-patch on Mac SL
1483         https://bugs.webkit.org/show_bug.cgi?id=78866
1484
1485         Reviewed by Adam Barth.
1486
1487         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
1488         which is the version that ships on Mac SL. Reverting this
1489         change until we no longer have to worry about that version.
1490
1491         * Scripts/webkitpy/common/system/autoinstall.py:
1492         (AutoInstaller):
1493         (AutoInstaller._extract_all): Added a comment about SL.
1494         (AutoInstaller._unzip):
1495
1496 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
1497
1498         CSS regions enabled by default
1499         https://bugs.webkit.org/show_bug.cgi?id=78525
1500
1501         Reviewed by David Hyatt.
1502
1503         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
1504         CSSRegions are still enabled by default.
1505         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
1506
1507         * DumpRenderTree/chromium/LayoutTestController.cpp:
1508         (LayoutTestController::overridePreference):
1509         * DumpRenderTree/chromium/WebPreferences.cpp:
1510         (WebPreferences::reset):
1511         (WebPreferences::applyTo):
1512         * DumpRenderTree/chromium/WebPreferences.h:
1513         (WebPreferences):
1514         * DumpRenderTree/mac/DumpRenderTree.mm:
1515         (resetDefaultsToConsistentValues):
1516
1517 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
1518
1519         Some API tests erroneously use = instead of == (causing build failures)
1520         https://bugs.webkit.org/show_bug.cgi?id=78915
1521
1522         Reviewed by Sam Weinig.
1523
1524         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1525         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
1526         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
1527
1528 2012-02-17  Peter Beverloo  <peter@chromium.org>
1529
1530         [Chromium] Include TestShellLinux.cpp in the build for Android
1531         https://bugs.webkit.org/show_bug.cgi?id=78865
1532
1533         Reviewed by Eric Seidel.
1534
1535         Android will be re-using the TestShellLinux.cpp file. I already
1536         added this r104033, but it seems to have gotten lost in the
1537         recent refactorings.
1538
1539         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1540
1541 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1542
1543         Unreviewed, disable video build on EFL until it can be
1544         supported by EFL build bot.
1545
1546         * Scripts/build-webkit:
1547
1548 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1549
1550         [GTK] Implement zoom in/out in MiniBrowser
1551         https://bugs.webkit.org/show_bug.cgi?id=75253
1552
1553         Reviewed by Gustavo Noronha Silva.
1554
1555         * MiniBrowser/gtk/BrowserWindow.c:
1556         (browserWindowCanZoomIn):
1557         (browserWindowCanZoomOut):
1558         (browserWindowUpdateZoomActions):
1559         (webViewZoomLevelChanged):
1560         (zoomInCallback):
1561         (zoomOutCallback):
1562         (browser_window_init):
1563         (browserWindowConstructed):
1564
1565 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
1566
1567         layoutTestController.display() is flaky for SVG tests
1568         https://bugs.webkit.org/show_bug.cgi?id=78021
1569
1570         Reviewed by Adam Roben.
1571
1572         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
1573         Size the web view before running the test, not when dumping.
1574         All platforms handle this correctly now.
1575
1576         * DumpRenderTree/win/DumpRenderTree.cpp:
1577         (dump):
1578         (sizeWebViewForCurrentTest):
1579         (runTest):
1580
1581 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1582
1583         [GTK] Make install is broken when building without --enable-gtk-doc
1584         https://bugs.webkit.org/show_bug.cgi?id=78828
1585
1586         Reviewed by Martin Robinson.
1587
1588         * gtk/generate-gtkdoc:
1589         (rebase_installed_docs): Check documentation has been generated
1590         before trying to rebase it.
1591
1592 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
1593
1594         nrwt: simplify worker interface
1595         https://bugs.webkit.org/show_bug.cgi?id=78181
1596
1597         Reviewed by Tony Chang.
1598
1599         This change moves code in name(), is_done(), run(), and cancel()
1600         from Worker to AbstractWorker, since the logic is pretty much
1601         boilerplate code that any implementation would want to use.
1602
1603         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1604         (get.should):
1605         (AbstractWorker.__init__):
1606         (AbstractWorker):
1607         (AbstractWorker.name):
1608         (AbstractWorker.stop_handling_messages):
1609         (AbstractWorker.run):
1610         (AbstractWorker.is_done):
1611         (AbstractWorker.cancel):
1612         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1613         (Worker.__init__):
1614         (Worker.run):
1615         (Worker.handle_stop):
1616
1617 2012-02-16  Michael Saboff  <msaboff@apple.com>
1618
1619         ENH: Add ability to run subset of JavaScript layout tests with JSC
1620         https://bugs.webkit.org/show_bug.cgi?id=78764
1621
1622         Reviewed by Gavin Barraclough.
1623
1624         New simple test drive shell script that runs a defined
1625         list of javascript tests using jsc and the standalone-{pre,post}.js
1626         wrappers.
1627
1628         * Scripts/run-fast-jsc: Added.
1629
1630 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
1631
1632         Add new Qt performance tester bot to build.webkit.org
1633         https://bugs.webkit.org/show_bug.cgi?id=78795
1634
1635         Reviewed by Adam Roben.
1636
1637         * BuildSlaveSupport/build.webkit.org-config/config.json:
1638
1639 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
1640
1641         Disable inspector on WinCE.
1642
1643         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
1644
1645         * Scripts/build-webkit:
1646
1647 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
1648
1649         WinCE build fix after r107656.
1650
1651         Disable FTPDIR on WinCE, since it does not compile there.
1652
1653         * Scripts/build-webkit:
1654
1655 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
1656
1657         Build fix after r107863.
1658
1659         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1660
1661 2012-02-15  Tony Chang  <tony@chromium.org>
1662
1663         [chromium] add linux dbg back to garden-o-matic
1664         https://bugs.webkit.org/show_bug.cgi?id=78752
1665
1666         Reviewed by Adam Barth.
1667
1668         This reflects the current linux debug bot name (there's only one bot).
1669         I'm also remove the mac clang builder since it doesn't exist (mac
1670         always uses clang now).
1671
1672         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1673         * Scripts/webkitpy/layout_tests/port/builders.py:
1674
1675 2012-02-15  Sam Weinig  <sam@webkit.org>
1676
1677         Add style check for ctype functions that are generally frowned upon in WebKit
1678         https://bugs.webkit.org/show_bug.cgi?id=78748
1679
1680         Reviewed by Anders Carlsson.
1681
1682         Not every platform has DisallowCType.h to check for uses of the ctype.h
1683         functions, so add a style check for them as well.
1684
1685         * Scripts/webkitpy/style/checkers/cpp.py:
1686         (check_ctype_functions):
1687         (check_style):
1688         (CppChecker):
1689         Add check.
1690
1691         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1692         (WebKitStyleTest.test_ctype_fucntion):
1693         Add checker.
1694
1695 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
1696
1697         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
1698         https://bugs.webkit.org/show_bug.cgi?id=76546
1699
1700         Reviewed by Simon Hausmann.
1701
1702         Resize the web view programatically because the declarative property binding
1703         does not work. Seems like our qml environment is not initialized fully but it
1704         needs more investigation.
1705
1706         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1707         (WTR::WrapperWindow::handleStatusChanged):
1708         (WTR::PlatformWebView::resizeTo):
1709
1710 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
1711
1712         webkitpy: add a worker_args concept to start_worker()
1713         https://bugs.webkit.org/show_bug.cgi?id=78572
1714
1715         Reviewed by Tony Chang.
1716
1717         This change replaces the three NRWT-specific arguments passed
1718         through the broker to the worker with a generic WorkerArguments
1719         wrapper class and a separate set_inline_arguments() call that can
1720         be used to pass additional data to the worker when it is running
1721         in the same process as the manager (this is needed for testing).
1722         With the addition of set_inline_arguments() we also no longer
1723         need to pass an optional argument to the worker.run() call.
1724
1725         Note that this method is *only* implemented on inline workers,
1726         so calling this on a regular (child process) worker will result
1727         in a runtime error.
1728
1729         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1730         (Manager._run_tests):
1731         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1732         (AbstractWorker.__init__):
1733         (AbstractWorker.run):
1734         (_ManagerConnection.start_worker):
1735         (_InlineManager.start_worker):
1736         (_InlineManager.set_inline_arguments):
1737         (_InlineManager.run_message_loop):
1738         (_MultiProcessManager.start_worker): Reworked signature.
1739         (_WorkerConnection.__init__):
1740         (_InlineWorkerConnection.__init__):
1741         (_InlineWorkerConnection.set_inline_arguments): New method.
1742         (_InlineWorkerConnection):
1743         (_InlineWorkerConnection.run):
1744         (_Process.run):
1745         (_MultiProcessWorkerConnection.__init__):
1746         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1747         (_TestWorker.__init__):
1748         (_TestWorker.set_inline_arguments):
1749         (_TestWorker.handle_test):
1750         (_TestWorker.run):
1751         (_TestsMixin.test_cancel):
1752         (_TestsMixin.test_done):
1753         (_TestsMixin.test_unknown_message):
1754         (InlineBrokerTests): New class for more testing.
1755         (InlineBrokerTests.setUp):
1756         (InlineBrokerTests.test_inline_arguments): New test.
1757         (InterfaceTest.test_managerconnection_is_abstract):
1758         (InterfaceTest.test_workerconnection_is_abstract):
1759         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1760         (WorkerArguments):
1761         (WorkerArguments.__init__):
1762         (Worker.__init__):
1763         (Worker.set_inline_arguments):
1764         (Worker):
1765         (Worker.run):
1766         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1767         (WorkerTest.test_default_platform_in_worker):
1768
1769 2012-02-15  Adam Klein  <adamk@chromium.org>
1770
1771         Unreviewed, rolling out r107704.
1772         http://trac.webkit.org/changeset/107704
1773         https://bugs.webkit.org/show_bug.cgi?id=78486
1774
1775         Caused layout test crashes in debug builds.
1776
1777         Specific crashing tests:
1778
1779         fast/events/show-modal-dialog-onblur-onfocus.html
1780         fast/harness/show-modal-dialog.html
1781         inspector/console/console-long-eval-crash.html
1782
1783         * DumpRenderTree/chromium/TestShell.cpp:
1784         (TestShell::TestShell):
1785         * DumpRenderTree/chromium/TestShell.h:
1786         (TestShell):
1787         * DumpRenderTree/chromium/WebViewHost.cpp:
1788         (WebViewHost::runModal):
1789
1790 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
1791
1792         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
1793         https://bugs.webkit.org/show_bug.cgi?id=76347
1794
1795         Reviewed by Kenneth Rohde Christiansen.
1796
1797         * MiniBrowser/qt/MiniBrowser.qrc:
1798         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
1799         * MiniBrowser/qt/qml/BrowserWindow.qml:
1800         * MiniBrowser/qt/qml/DialogLineInput.qml:
1801
1802 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
1803
1804         [Qt] Fix WebGL in QtTestBrowser
1805
1806         Reviewed by Tor Arne Vestbø.
1807
1808         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
1809         the options for enabling GL we also pass them on properly.
1810
1811 2012-02-14  Sam Weinig  <sam@webkit.org>
1812
1813         Add #include of unistd.h on the mac for getcwd. 
1814
1815         Reviewed by Anders Carlsson.
1816
1817         This is necessary when building with libc++.
1818
1819         * WebKitTestRunner/TestInvocation.cpp:
1820
1821 2012-02-14  Sam Weinig  <sam@webkit.org>
1822
1823         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
1824         https://bugs.webkit.org/show_bug.cgi?id=78663
1825
1826         Reviewed by Anders Carlsson.
1827
1828         * DumpRenderTree/DumpRenderTreePrefix.h:
1829         * DumpRenderTree/cg/ImageDiffCG.cpp:
1830
1831 2012-02-14  Adam Barth  <abarth@webkit.org>
1832
1833         Implement an adb-based driver for the ChromiumAndroidPort
1834         https://bugs.webkit.org/show_bug.cgi?id=78627
1835
1836         Reviewed by Eric Seidel.
1837
1838         This driver mostly just wires up the ChromiumDriver through adb.  In
1839         some cases, it translates protocol elements, such as URIs, so that the
1840         rest of webkitpy is insulated from the "remoteness" of the target device.
1841
1842         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1843         (ChromiumAndroidPort.start_helper):
1844         (ChromiumAndroidPort._driver_class):
1845         (ChromiumAndroidPort._update_version):
1846         (ChromiumAndroidPort._get_stderr):
1847         (ChromiumAndroidPort):
1848         (ChromiumAndroidPort._get_last_stacktrace):
1849         (ChromiumAndroidPort._teardown_performance):
1850         (ChromiumAndroidDriver):
1851         (ChromiumAndroidDriver.__init__):
1852         (ChromiumAndroidDriver._start):
1853         (ChromiumAndroidDriver.run_test):
1854         (ChromiumAndroidDriver.stop):
1855         (ChromiumAndroidDriver._test_shell_command):
1856         (ChromiumAndroidDriver._write_command_and_read_line):
1857         (ChromiumAndroidDriver._output_image):
1858         (ChromiumAndroidDriver._has_crash_hint):
1859
1860 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1861
1862         webkitpy: the real_name() method in the Port class is no longer needed
1863         https://bugs.webkit.org/show_bug.cgi?id=78651
1864
1865         Reviewed by Eric Seidel.
1866
1867         The change in bug 78565 / r107718 made it no longer necessary
1868         (we can use options.platform instead).
1869
1870         * Scripts/webkitpy/layout_tests/port/base.py:
1871         (Port.name):
1872         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1873         (MockDRTPort.__init__):
1874
1875 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1876
1877         webkitpy: clean up options, port handling in manager_worker_broker
1878         https://bugs.webkit.org/show_bug.cgi?id=78568
1879
1880         Reviewed by Tony Chang.
1881
1882         manager_worker_broker no longer needs options or port objects
1883         directly, so we make them only be passed in start_worker().
1884
1885         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1886         (Manager._run_tests):
1887         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1888         (get):
1889         (_ManagerConnection.__init__):
1890         (_ManagerConnection.start_worker):
1891         (_InlineManager.__init__):
1892         (_InlineManager.start_worker):
1893         (_InlineManager.run_message_loop):
1894         (_MultiProcessManager.__init__):
1895         (_MultiProcessManager):
1896         (_MultiProcessManager.start_worker):
1897         (_InlineWorkerConnection.__init__):
1898         (_InlineWorkerConnection.run):
1899         (_Process.__init__):
1900         (_MultiProcessWorkerConnection.__init__):
1901         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1902         (make_broker):
1903         (_TestWorker.run):
1904         (_TestsMixin.test_cancel):
1905         (_TestsMixin.test_done):
1906         (_TestsMixin.test_unknown_message):
1907         (MultiProcessBrokerTests.setUp):
1908         (InterfaceTest.test_managerconnection_is_abstract):
1909         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
1910         (Broker.__init__):
1911
1912 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1913
1914         nrwt: add a unit test for regression introduced in bug 78565
1915         https://bugs.webkit.org/show_bug.cgi?id=78646
1916
1917         Reviewed by Tony Chang.
1918
1919         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
1920         (FakeConnection):
1921         (FakeConnection.run_message_loop):
1922         (FakeConnection.post_message):
1923         (WorkerTest):
1924         (WorkerTest.test_default_platform_in_worker):
1925
1926 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1927
1928         NRWT is broken for the default port
1929         https://bugs.webkit.org/show_bug.cgi?id=78640
1930     
1931         Reviewed by Tony Chang.
1932
1933         The change in r107718 (bug 78565) broke NRWT if you didn't
1934         specify any sort of --platform flag or equivalent. I didn't
1935         catch this because it's a full integration test (which we don't
1936         have an automated test for) and I missed this command line
1937         variant when testing interactively.
1938
1939         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1940         (Worker.run):
1941
1942 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
1943
1944         Last character display for passwords in Android.
1945         https://bugs.webkit.org/show_bug.cgi?id=78532
1946
1947         Reviewed by Adam Barth.
1948
1949         * DumpRenderTree/chromium/WebPreferences.cpp:
1950         (WebPreferences::applyTo):
1951
1952 2012-02-14  Adam Barth  <abarth@webkit.org>
1953
1954         Finish implementing start_helper for ChromiumAndroidPort
1955         https://bugs.webkit.org/show_bug.cgi?id=78582
1956
1957         Reviewed by Eric Seidel.
1958
1959         This patch contains the remaining odds and ends for the start_helper function.
1960
1961         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1962         (ChromiumAndroidPort.start_helper):
1963         (ChromiumAndroidPort._synchronize_datetime):
1964         (ChromiumAndroidPort):
1965         (ChromiumAndroidPort._check_version):
1966         (ChromiumAndroidPort._run_adb_command):
1967         (ChromiumAndroidPort._copy_device_file):
1968
1969 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1970
1971         webkitpy: create ports in Workers, not in manager_worker_broker
1972         https://bugs.webkit.org/show_bug.cgi?id=78565
1973
1974         Reviewed by Tony Chang.
1975
1976         We will now create the Port object (if necessary) in the Worker
1977         directly, so that the manager_worker_broker module doesn't need
1978         all of this layout_test-specific logic. Part of the fixes for
1979         bug 78171.
1980
1981         These changes are all well-tested by the existing tests in
1982         run_webkit_tests_integrationtest.py.
1983
1984         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1985         (_Process.run):
1986         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1987         (Worker.__init__):
1988         (Worker.safe_init):
1989         (Worker.run):
1990         (Worker.cleanup):
1991         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1992         (parse_args):
1993         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
1994
1995 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
1996
1997         [chromium] check that we're not running multiple modal dialogs at the same time
1998         https://bugs.webkit.org/show_bug.cgi?id=78486
1999
2000         Reviewed by Kent Tamura.
2001
2002         * DumpRenderTree/chromium/TestShell.cpp:
2003         (TestShell::TestShell):
2004         * DumpRenderTree/chromium/TestShell.h:
2005         (TestShell::setIsDisplayingModalDialog):
2006         (TestShell::isDisplayingModalDialog):
2007         (TestShell):
2008         * DumpRenderTree/chromium/WebViewHost.cpp:
2009         (WebViewHost::runModal):
2010
2011 2012-02-14  Adam Barth  <abarth@webkit.org>
2012
2013         Enable the GPU codepath in the chromium-android port
2014         https://bugs.webkit.org/show_bug.cgi?id=78580
2015
2016         Reviewed by James Robinson.
2017
2018         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
2019         Android always uses the GPU codepath, so we set the GPU flags on the
2020         main chromium-android port instead.
2021
2022         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2023         (ChromiumAndroidPort.__init__):
2024
2025 2012-02-14  Adam Barth  <abarth@webkit.org>
2026
2027         NRWT should expose --adb-args flag for Android
2028         https://bugs.webkit.org/show_bug.cgi?id=78579
2029
2030         Reviewed by Eric Seidel.
2031
2032         This flag is already wired up to the ChromiumAndroidPort.
2033
2034         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2035         (parse_args):
2036
2037 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
2038
2039         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
2040         https://bugs.webkit.org/show_bug.cgi?id=78541
2041         <rdar://problem/10036695>
2042
2043         Reviewed by Kent Tamura.
2044
2045         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
2046         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
2047         After each test, reset to using new protocol.
2048
2049 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
2050
2051         Convert svg/animations to use SMIL methods for driving the timeline
2052         https://bugs.webkit.org/show_bug.cgi?id=78422
2053
2054         Reviewed by Dirk Schulze.
2055
2056         Remove no longer needed SVG specific animation sampling functionality from DRT.
2057         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
2058
2059         * DumpRenderTree/LayoutTestController.cpp:
2060         (LayoutTestController::staticFunctions):
2061         * DumpRenderTree/LayoutTestController.h:
2062         (LayoutTestController):
2063         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2064         * DumpRenderTree/chromium/LayoutTestController.cpp:
2065         (LayoutTestController::LayoutTestController):
2066         * DumpRenderTree/chromium/LayoutTestController.h:
2067         (LayoutTestController):
2068         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2069         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2070         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2071         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2072         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2073         (LayoutTestController):
2074         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2075         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2076
2077 2012-02-13  Rob Flack  <flackr@chromium.org>
2078
2079         Add Linux ChromiumOS test results to flakiness dashboard.
2080         https://bugs.webkit.org/show_bug.cgi?id=78495
2081
2082         Reviewed by Ojan Vafai.
2083
2084         * TestResultServer/static-dashboards/builders.js:
2085         * TestResultServer/static-dashboards/dashboard_base.js:
2086
2087 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
2088
2089         [GTK] Mutation Observers build is broken
2090         https://bugs.webkit.org/show_bug.cgi?id=78433
2091
2092         Reviewed by Martin Robinson.
2093
2094         Enabled mutation observers as a default feature for GTK port, too.
2095
2096         * Scripts/build-webkit:
2097
2098 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
2099
2100         Allow to configure ENABLE_FTPDIR in build-webkit
2101         https://bugs.webkit.org/show_bug.cgi?id=65098
2102
2103         Reviewed by Eric Seidel.
2104
2105         Allow to disable ENABLE_FTPDIR by command line.
2106         Remove ENABLE_FTPDIR from --minimal build
2107
2108         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
2109         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
2110         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
2111
2112 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
2113
2114         Add shinyak as committer.
2115
2116         Unreviewed.
2117
2118         * Scripts/webkitpy/common/config/committers.py:
2119
2120 2012-02-13  Adam Barth  <abarth@webkit.org>
2121
2122         Implement start/stop_helper for ChromiumAndroidPort
2123         https://bugs.webkit.org/show_bug.cgi?id=78558
2124
2125         Reviewed by Dirk Pranke.
2126
2127         These functions (and their dependencies) set up the Android device for
2128         testing.
2129
2130         This patch also includes a few tweaks on the previous patch recommended
2131         by dpranke.
2132
2133         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2134         (ChromiumAndroidPort.__init__):
2135         (ChromiumAndroidPort.start_helper):
2136         (ChromiumAndroidPort.stop_helper):
2137         (ChromiumAndroidPort._shut_down_http_server):
2138         (ChromiumAndroidPort):
2139         (ChromiumAndroidPort._push_executable):
2140         (ChromiumAndroidPort._push_fonts):
2141         (ChromiumAndroidPort._restore_system_font):
2142         (ChromiumAndroidPort._push_test_resources):
2143         (ChromiumAndroidPort._push_to_device):
2144         (ChromiumAndroidPort._pull_from_device):
2145         (ChromiumAndroidPort._kill_device_process):
2146         (ChromiumAndroidPort._setup_performance):
2147         (ChromiumAndroidPort._teardown_performance):
2148         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2149         (ChromiumAndroidPortTest):
2150         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2151         (PortTestCase):
2152         (PortTestCase.make_port):
2153         (PortTestCase.test_default_worker_model):
2154
2155 2012-02-13  Adam Barth  <abarth@webkit.org>
2156
2157         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
2158         https://bugs.webkit.org/show_bug.cgi?id=78550
2159
2160         Reviewed by Eric Seidel.
2161
2162         Much of this code just forwards to the "host" port, which seems like a
2163         reasonable thing to do.
2164
2165         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2166         (ChromiumAndroidPort.__init__):
2167         (ChromiumAndroidPort.stop_helper):
2168         (ChromiumAndroidPort):
2169         (ChromiumAndroidPort._build_path):
2170         (ChromiumAndroidPort._path_to_apache):
2171         (ChromiumAndroidPort._path_to_apache_config_file):
2172         (ChromiumAndroidPort._path_to_driver):
2173         (ChromiumAndroidPort._path_to_helper):
2174         (ChromiumAndroidPort._path_to_image_diff):
2175         (ChromiumAndroidPort._path_to_lighttpd):
2176         (ChromiumAndroidPort._path_to_lighttpd_modules):
2177         (ChromiumAndroidPort._path_to_lighttpd_php):
2178         (ChromiumAndroidPort._path_to_wdiff):
2179         (ChromiumAndroidPort._shut_down_http_server):
2180         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2181         (ChromiumAndroidPortTest):
2182         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2183         (PortTestCase):
2184         (PortTestCase.make_port):
2185         (PortTestCase.test_default_worker_model):
2186
2187 2012-02-13  Adam Barth  <abarth@webkit.org>
2188
2189         chromium_android.py should implement "virtual" methods from ChromiumPort
2190         https://bugs.webkit.org/show_bug.cgi?id=78545
2191
2192         Reviewed by Dirk Pranke.
2193
2194         This patch adds basic implementations that specialize a bunch of
2195         functions from ChromiumPort.
2196
2197         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2198         (ChromiumAndroidPort):
2199         (ChromiumAndroidPort.__init__):
2200         (ChromiumAndroidPort.default_child_processes):
2201         (ChromiumAndroidPort.baseline_search_path):
2202         (ChromiumAndroidPort.check_build):
2203         (ChromiumAndroidPort.check_sys_deps):
2204         (ChromiumAndroidPort.default_worker_model):
2205         (ChromiumAndroidPort.test_expectations):
2206         (ChromiumAndroidPort.start_http_server):
2207         (ChromiumAndroidPort.stop_http_server):
2208         (ChromiumAndroidPort.start_helper):
2209         (ChromiumAndroidPort.stop_helper):
2210
2211 2012-02-13  Adam Barth  <abarth@webkit.org>
2212
2213         Add a skeleton ChromiumAndroid port to webkitpy
2214         https://bugs.webkit.org/show_bug.cgi?id=78543
2215
2216         Reviewed by Eric Seidel.
2217
2218         This patch just adds an empty ChromiumAndroid port object to webkitpy
2219         and wires it up to the factory objects.  An actual implementation will
2220         follow.
2221
2222         * Scripts/webkitpy/layout_tests/port/chromium.py:
2223         (ChromiumPort):
2224         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
2225         (ChromiumAndroidPort):
2226         (ChromiumAndroidPort.__init__):
2227         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2228         (ChromiumPortTest.test_all_test_configurations):
2229         * Scripts/webkitpy/layout_tests/port/factory.py:
2230         (PortFactory):
2231
2232 2012-02-13  Adam Barth  <abarth@webkit.org>
2233
2234         NRWT's HTTP servers should support additional directories for resources
2235         https://bugs.webkit.org/show_bug.cgi?id=78528
2236
2237         Reviewed by Eric Seidel.
2238
2239         This functionality will be used by the Chromium-Android port.
2240
2241         * Scripts/webkitpy/layout_tests/port/base.py:
2242         (Port.to.start_http_server):
2243         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2244         (LayoutTestApacheHttpd.__init__):
2245         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2246         (Lighttpd.__init__):
2247         (Lighttpd._prepare_config):
2248
2249 2012-02-13  Ami Fischman  <fischman@chromium.org>
2250
2251         Add fischman as committer.
2252
2253         Unreviewed
2254
2255         * Scripts/webkitpy/common/config/committers.py:
2256
2257 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
2258
2259         [EFL] Drop support for the Curl network backend.
2260         https://bugs.webkit.org/show_bug.cgi?id=77874
2261
2262         Reviewed by Eric Seidel.
2263
2264         Nobody seems to be maintaining the Curl backend in WebCore, the
2265         EFL port developers all seem to be using the Soup backend and the
2266         port itself has many features which are only implemented for the
2267         latter.
2268
2269         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
2270         and always add the required include directories.
2271         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
2272         include directories and link to them.
2273
2274 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
2275
2276         [WebSocket] Update pywebsocket to 0.7.1
2277         https://bugs.webkit.org/show_bug.cgi?id=78484
2278
2279         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
2280
2281         Reviewed by Kent Tamura.
2282
2283         * Scripts/webkitpy/thirdparty/__init__.py:
2284         (AutoinstallImportHook._install_pywebsocket):
2285
2286 2012-02-12  Kangil Han  <kangil.han@samsung.com>
2287
2288         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
2289         https://bugs.webkit.org/show_bug.cgi?id=78091
2290
2291         Reviewed by Hajime Morita.
2292
2293         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
2294         This patch will activate around 1,900 test cases from skipped list in EFL port.
2295
2296         * DumpRenderTree/efl/EventSender.cpp:
2297         (textZoom):
2298         (pageZoom):
2299         (textZoomInCallback):
2300         (textZoomOutCallback):
2301         (zoomPageInCallback):
2302         (zoomPageOutCallback):
2303
2304 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2305
2306         KeywordLookupGenerator.py script fails in some cases
2307         https://bugs.webkit.org/show_bug.cgi?id=77886
2308
2309         Reviewed by Benjamin Poulain.
2310
2311         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
2312         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
2313         (GlobalVariablesTest.test_path_rules_specifier):
2314
2315 2012-02-12  Joe Thomas  <joethomas@motorola.com>
2316
2317         Add toText and isTextNode helpers in Text class.
2318         https://bugs.webkit.org/show_bug.cgi?id=78140
2319
2320         Unit test case for the new style checker introduced.
2321
2322         Reviewed by Adam Barth.
2323
2324         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2325         (CppStyleTest):
2326         (CppStyleTest.test_static_cast_readability): Added a unit test case.
2327
2328 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2329
2330         Enable features supported by EFL port in build-webkit.
2331         https://bugs.webkit.org/show_bug.cgi?id=78348
2332
2333         Reviewed by Ryosuke Niwa.
2334
2335         Sync build-webkit with OptionEfl.cmake, as some features enabled in
2336         OptionEfl.cmake are not enabled in build-webkit.
2337
2338         * Scripts/build-webkit:
2339
2340 2012-02-12  Joe Thomas  <joethomas@motorola.com>
2341
2342         Add toText and isTextNode helpers in Text class.
2343         https://bugs.webkit.org/show_bug.cgi?id=78140
2344
2345         Added a style checker to use toText rather than static_cast<Text*>.
2346
2347         Reviewed by Adam Barth.
2348
2349         * Scripts/webkitpy/style/checkers/cpp.py:
2350         (check_language): Style checker for static_cast<Text*>.
2351
2352 2012-02-12  Philippe Normand  <pnormand@igalia.com>
2353
2354         Unreviewed, disable Mutation observers build on GTK until it can
2355         actually build.
2356
2357         * Scripts/build-webkit:
2358
2359 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
2360
2361         Add back WTFURL to WebKit
2362         https://bugs.webkit.org/show_bug.cgi?id=77291
2363
2364         Reviewed by Adam Barth.
2365
2366         Add a flag to build-webkit to easily build WebKit with WTFURL.
2367
2368         * Scripts/build-webkit:
2369
2370 2012-02-10  Adam Klein  <adamk@chromium.org>
2371
2372         Enable MUTATION_OBSERVERS by default on all platforms
2373         https://bugs.webkit.org/show_bug.cgi?id=78196
2374
2375         Reviewed by Ojan Vafai.
2376
2377         * Scripts/build-webkit:
2378
2379 2012-02-10  Adam Barth  <abarth@webkit.org>
2380
2381         Move garden-o-matic's All Failures out of experimental
2382         https://bugs.webkit.org/show_bug.cgi?id=78395
2383
2384         Reviewed by Dimitri Glazkov.
2385
2386         Several folks have tried this feature and found it useful.
2387
2388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2389
2390 2012-02-10  Tim Horton  <timothy_horton@apple.com>
2391
2392         NRWT should categorize options in --help
2393         https://bugs.webkit.org/show_bug.cgi?id=76221
2394
2395         Reviewed by Eric Seidel.
2396         
2397         Use optparse's OptionGroup mechanism to logically group NRWT's options,
2398         providing a better experience when scanning all the options.
2399
2400         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2401         (parse_args):
2402
2403 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2404
2405         [Qt][WK2] Refactor on Qt5 Layout tests' structure
2406         https://bugs.webkit.org/show_bug.cgi?id=77450
2407
2408         Reviewed by Csaba Osztrogonác.
2409
2410         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
2411         to qt-5.0-wk2 and qt-5.0-wk1.
2412
2413         * Scripts/old-run-webkit-tests:
2414         (buildPlatformResultHierarchy):
2415         (readSkippedFiles):
2416         * Scripts/webkitpy/layout_tests/port/qt.py:
2417         (QtPort._wk2_port_name):
2418         (QtPort._skipped_file_search_paths):
2419         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2420         (QtPortTest.test_baseline_search_path):
2421         * Scripts/webkitpy/layout_tests/port/webkit.py:
2422         (WebKitPort._wk2_port_name):
2423
2424 2012-02-09  Philippe Normand  <pnormand@igalia.com>
2425
2426         [GTK] EWS command-line option to run the tests
2427         https://bugs.webkit.org/show_bug.cgi?id=78211
2428
2429         Reviewed by Adam Barth.
2430
2431         New --run-tests option (defaults to False) for the EWS commands.
2432
2433         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2434         (AbstractEarlyWarningSystem):
2435         (AbstractEarlyWarningSystem.__init__):
2436         (AbstractEarlyWarningSystem.review_patch):
2437         (ChromiumLinuxEWS):
2438         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2439         (EarlyWarningSytemTest._test_builder_ews):
2440
2441 2012-02-09  Eric Seidel  <eric@webkit.org>
2442
2443         Rename compare_text and compare_audio to make it clear that they're !=
2444         https://bugs.webkit.org/show_bug.cgi?id=78301
2445
2446         Reviewed by Adam Barth.
2447
2448         I also removed the maybe_create_directory function which was redundant.
2449
2450         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2451         (Manager.set_up_run):
2452         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2453         (TestResultWriter._make_output_directory):
2454         * Scripts/webkitpy/layout_tests/port/base.py:
2455         (Port.do_text_results_differ):
2456         (Port.do_audio_results_differ):
2457         (Port.diff_text):
2458         (Port.driver_name):
2459         (Port.skips_perf_test):
2460         * Scripts/webkitpy/layout_tests/port/win.py:
2461         (WinPort.do_text_results_differ):
2462         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2463         (WinPortTest.test_do_text_results_differ):
2464         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2465         (LayoutTestApacheHttpd.__init__):
2466         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2467         (HttpServerBase.__init__):
2468         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2469         (Rebaseliner._diff_baselines):
2470
2471 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
2472
2473         [GTK] Add DRT support for modal dialogs
2474         https://bugs.webkit.org/show_bug.cgi?id=53600
2475
2476         Reviewed by Martin Robinson.
2477
2478         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
2479         Most significantly, when creating a new web view in GtkLauncher, the window
2480         of the web view opener is passed around. In DumpRenderTree, the window of
2481         the main web view is always considered as the opener. This is required so
2482         the modal dialog's toplevel can be made transient for the opener's toplevel.
2483
2484         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2485         (webViewRunModalDialog):
2486         (createWebView):
2487         * GtkLauncher/main.c:
2488         (createWebViewCb):
2489         (runModalDialogCb):
2490         (createBrowser):
2491         (createWindow):
2492         (main):
2493
2494 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
2495
2496         [Gtk] security/set-form-autocomplete-attribute.html fails
2497         https://bugs.webkit.org/show_bug.cgi?id=78261
2498
2499         Reviewed by Martin Robinson.
2500
2501         Use the new helper in DumpRenderTreeSupportGtk to properly
2502         test whether an element performs autocompletion.
2503
2504         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2505         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2506
2507 2012-02-09  James Robinson  <jamesr@chromium.org>
2508
2509         [chromium] Enable mock scrollbars for compositing layout tests
2510         https://bugs.webkit.org/show_bug.cgi?id=78299
2511
2512         Reviewed by Dirk Pranke.
2513
2514         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
2515         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
2516         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
2517
2518         * DumpRenderTree/chromium/TestShell.cpp:
2519         (TestShell::runFileTest):
2520         * DumpRenderTree/chromium/WebPreferences.cpp:
2521         (WebPreferences::reset):
2522         (WebPreferences::applyTo):
2523         * DumpRenderTree/chromium/WebPreferences.h:
2524         (WebPreferences):
2525
2526 2012-02-09  Eric Seidel  <eric@webkit.org>
2527
2528         Remove more uses of "os" from our webkitpy code
2529         https://bugs.webkit.org/show_bug.cgi?id=78292
2530
2531         Reviewed by Adam Barth.
2532
2533         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2534         (MockCheckout.__init__):
2535         (MockCheckout.is_path_to_changelog):
2536         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2537         * Scripts/webkitpy/common/system/filesystem_mock.py:
2538         (MockFileSystem._split):
2539         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2540         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2541         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2542         * Scripts/webkitpy/layout_tests/port/webkit.py:
2543         * Scripts/webkitpy/tool/bot/queueengine.py:
2544         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2545         * Scripts/webkitpy/tool/commands/download.py:
2546         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2547         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2548         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2549         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2550         * Scripts/webkitpy/tool/commands/upload.py:
2551         (CreateBug.prompt_for_bug_title_and_comment):
2552         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2553         * Scripts/webkitpy/tool/steps/attachtobug.py:
2554         (AttachToBug.run):
2555         * Scripts/webkitpy/tool/steps/checkstyle.py:
2556         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2557         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2558         * Scripts/webkitpy/tool/steps/editchangelog.py:
2559         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2560         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2561         (PrepareChangeLogTest.test_ensure_bug_url):
2562         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2563         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2564         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2565         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2566
2567 2012-02-09  Eric Seidel  <eric@webkit.org>
2568
2569         Remove the cr-mac-ews (it's long been dead)
2570         https://bugs.webkit.org/show_bug.cgi?id=78267
2571
2572         Reviewed by Adam Barth.
2573
2574         * QueueStatusServer/model/queues.py:
2575         (Queue):
2576         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2577         (ChromiumWindowsEWS):
2578         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2579         (EarlyWarningSytemTest._test_builder_ews):
2580         (EarlyWarningSytemTest._test_testing_ews):
2581
2582 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
2583
2584         some tests in webkitpy are being run three times
2585         https://bugs.webkit.org/show_bug.cgi?id=78283
2586
2587         Reviewed by Ryosuke Niwa.
2588
2589         It turns out that if you import a class derived from
2590         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
2591         the unittest framework treats it as if the class was defined in
2592         the file (as well in the original file). This led us to running
2593         the tests in ChangeLogTest three times.
2594
2595         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2596         (PrepareChangeLogTest):
2597         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2598         (_assert_message_for_revert_output):
2599
2600 2012-02-09  Adam Barth  <abarth@webkit.org>
2601
2602         Remove extraneous line in previous patch.  I forgot to remove this
2603         before landing.
2604
2605         * Scripts/webkitpy/layout_tests/port/driver.py:
2606         (DriverProxy.start):
2607
2608 2012-02-09  Adam Barth  <abarth@webkit.org>
2609
2610         run-perf-tests should have an option to pause before running tests so we can attach Instruments
2611         https://bugs.webkit.org/show_bug.cgi?id=78271
2612
2613         Reviewed by Ryosuke Niwa.
2614
2615         This lets me attach instruments to profile the performance of the test.
2616
2617         * Scripts/webkitpy/layout_tests/port/chromium.py:
2618         (ChromiumDriver.start):
2619         * Scripts/webkitpy/layout_tests/port/driver.py:
2620         (Driver.start):
2621         (DriverProxy.start):
2622         * Scripts/webkitpy/layout_tests/port/server_process.py:
2623         (ServerProcess.start):
2624         * Scripts/webkitpy/layout_tests/port/test.py:
2625         (TestDriver.start):
2626         * Scripts/webkitpy/layout_tests/port/webkit.py:
2627         (WebKitDriver.start):
2628         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2629         (get_tests_run.RecordingTestDriver.start):
2630         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2631         (PerfTestsRunner._parse_args):
2632         (PerfTestsRunner._run_tests_set):
2633         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2634         (start):
2635         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2636         (test_run_test_set_kills_drt_per_run):
2637         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
2638         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
2639
2640 2012-02-09  Adam Barth  <abarth@webkit.org>
2641
2642         run-perf-tests --chromium should run the chromium port
2643         https://bugs.webkit.org/show_bug.cgi?id=78266
2644
2645         Reviewed by Ryosuke Niwa.
2646
2647         This patch makes run-perf-tests work more like run-webkit-tests.
2648
2649         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2650         (PerfTestsRunner._parse_args):
2651
2652 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2653
2654         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
2655         https://bugs.webkit.org/show_bug.cgi?id=77466
2656
2657         Reviewed by Dirk Pranke.
2658
2659         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
2660         is set or if we should raise an error. A unit test was added.
2661
2662         * Scripts/webkitpy/layout_tests/port/qt.py:
2663         (QtPort.operating_system):
2664         (QtPort):
2665         (QtPort.check_sys_deps):
2666         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2667         (QtPortTest.test_operating_system):
2668         (QtPortTest):
2669         (QtPortTest.test_check_sys_deps):
2670
2671 2012-02-09  Eric Seidel  <eric@webkit.org>
2672
2673         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
2674         https://bugs.webkit.org/show_bug.cgi?id=78263
2675
2676         Reviewed by Adam Barth.
2677
2678         * Scripts/webkitpy/common/config/ports.py:
2679         (DeprecatedPort):
2680         (DeprecatedPort.name):
2681         (DeprecatedPort.flag):
2682         (DeprecatedPort.script_path):
2683         (DeprecatedPort.script_shell_command):
2684         (DeprecatedPort.port):
2685         (DeprecatedPort.makeArgs):
2686         (DeprecatedPort.update_webkit_command):
2687         (DeprecatedPort.check_webkit_style_command):
2688         (DeprecatedPort.prepare_changelog_command):
2689         (DeprecatedPort.build_webkit_command):
2690         (DeprecatedPort.run_javascriptcore_tests_command):
2691         (DeprecatedPort.run_webkit_unit_tests_command):
2692         (DeprecatedPort.run_webkit_tests_command):
2693         (DeprecatedPort.run_python_unittests_command):
2694         (DeprecatedPort.run_perl_unittests_command):
2695         (DeprecatedPort.layout_tests_results_path):
2696         (MacPort):
2697         (WinPort):
2698         (GtkPort):
2699         (GtkPort.build_webkit_command):
2700         (GtkPort.run_webkit_tests_command):
2701         (QtPort):
2702         (QtPort.build_webkit_command):
2703         (EflPort):
2704         (EflPort.build_webkit_command):
2705         (ChromiumPort):
2706         (ChromiumPort.update_webkit_command):
2707         (ChromiumPort.build_webkit_command):
2708         (ChromiumPort.run_webkit_tests_command):
2709         (ChromiumPort.run_javascriptcore_tests_command):
2710         (ChromiumXVFBPort):
2711         (ChromiumXVFBPort.run_webkit_tests_command):
2712         * Scripts/webkitpy/common/config/ports_unittest.py:
2713         (DeprecatedPortTest):
2714         (DeprecatedPortTest.test_mac_port):
2715         (DeprecatedPortTest.test_gtk_port):
2716         (DeprecatedPortTest.test_qt_port):
2717         (DeprecatedPortTest.test_chromium_port):
2718         (DeprecatedPortTest.test_chromium_xvfb_port):
2719         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2720         (AbstractEarlyWarningSystem.__init__):
2721         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2722         * Scripts/webkitpy/tool/main.py:
2723         (WebKitPatch):
2724         (WebKitPatch.handle_global_options):
2725         * Scripts/webkitpy/tool/steps/abstractstep.py:
2726         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2727         (StepsTest.test_runtests_args):
2728
2729 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
2730
2731         [chromium] always initialize makeArgs in buildChromiumNinja
2732         https://bugs.webkit.org/show_bug.cgi?id=78231
2733
2734         Reviewed by Tony Gentilcore.
2735
2736         * Scripts/webkitdirs.pm:
2737         (buildChromiumNinja):
2738
2739 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2740
2741         [GTK] Show url of current hovered link in MiniBrowser
2742         https://bugs.webkit.org/show_bug.cgi?id=78098
2743
2744         Reviewed by Martin Robinson.
2745
2746         * MiniBrowser/gtk/BrowserWindow.c:
2747         (webViewMouseTargetChanged): Check whether hit test result is a
2748         link and use the url to update the status bar text.
2749         (browserWindowConstructed): Connect to
2750         WebKitWebView::mouse-target-changed signal.
2751
2752 2012-02-09  Rob Buis  <rbuis@rim.com>
2753
2754         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2755         https://bugs.webkit.org/show_bug.cgi?id=78042
2756
2757         Reviewed by Antonio Gomes.
2758
2759         Upstream final part of our DRT implementation.
2760
2761         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
2762         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
2763         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
2764         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
2765         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
2766
2767 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
2768
2769         kill-old-processes should kill gcc and clang
2770         https://bugs.webkit.org/show_bug.cgi?id=78189
2771
2772         Reviewed by Eric Seidel.
2773
2774         Added a bunch of processes names of gcc and clang to the list.
2775
2776         * BuildSlaveSupport/kill-old-processes:
2777
2778 2012-02-07  MORITA Hajime  <morrita@google.com>
2779
2780         Replacement text should be available from the marker.
2781         https://bugs.webkit.org/show_bug.cgi?id=77934
2782
2783         Made the mock requestCheckingOfText() implementation to return
2784         a replacement text for each misspelled word if available.
2785
2786         Reviewed by Kent Tamura.
2787
2788         * DumpRenderTree/chromium/WebViewHost.cpp:
2789         (WebViewHost::finishLastTextCheck):
2790
2791 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2792
2793         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
2794         https://bugs.webkit.org/show_bug.cgi?id=78146
2795
2796         Reviewed by Ryosuke Niwa.
2797
2798         Our DumpRenderTree should support --no-timeout and --timeout options in order
2799         to be able to use run-perf-tests and have a Performance Bot.
2800         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
2801         and the necessary code to handle such command line arguments to our DumpRenderTree.
2802
2803         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2804         (WebCore::DumpRenderTree::setTimeout):
2805         (WebCore):
2806         (WebCore::DumpRenderTree::setShouldTimeout):
2807         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2808         (DumpRenderTree):
2809         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2810         (LayoutTestController::LayoutTestController):
2811         (LayoutTestController::waitUntilDone):
2812         (LayoutTestController::notifyDone):
2813         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2814         (LayoutTestController::setTimeout):
2815         (LayoutTestController::setShouldTimeout):
2816         (LayoutTestController):
2817         * DumpRenderTree/qt/main.cpp:
2818         (isOption):
2819         (printUsage):
2820         (main):
2821
2822 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2823
2824         Rubber-stamped by Martin Robinson.
2825
2826         * gtk/common.py:
2827         (get_build_path): Move test for current directory being a valid
2828         directory up so it takes precedence over WebKitBuild/Release and
2829         WebKitBuild/Debug when they exist as well.
2830
2831 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2832
2833         [GTK] doc rebasing does not respect DESTDIR
2834         https://bugs.webkit.org/show_bug.cgi?id=78177
2835
2836         Reviewed by Martin Robinson.
2837
2838         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
2839         calling it for rebasing.
2840         * gtk/generate-gtkdoc:
2841         (get_common_options): Handle the new --virtual-root option.
2842         * gtk/gtkdoc.py:
2843         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
2844         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
2845
2846 2012-02-08  Adam Barth  <abarth@webkit.org>
2847
2848         Remove Python 2.5 support from WebKit
2849         https://bugs.webkit.org/show_bug.cgi?id=71593
2850
2851         Reviewed by Eric Seidel.
2852
2853         This is the last vestige of our Python 2.5 support.
2854
2855         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2856         (AbstractQueueTest.test_log_from_script_error_for_upload):
2857
2858 2012-02-08  Adam Barth  <abarth@webkit.org>
2859
2860         version_check.py should inform users that we don't support Python 2.5 anymore
2861         https://bugs.webkit.org/show_bug.cgi?id=78179
2862
2863         Reviewed by Eric Seidel.
2864
2865         We don't support Python 2.5 anymore.
2866
2867         * Scripts/webkitpy/common/version_check.py:
2868
2869 2012-02-08  Adam Barth  <abarth@webkit.org>
2870
2871         test_configuration.py shouldn't re-implement itertools
2872         https://bugs.webkit.org/show_bug.cgi?id=78178
2873
2874         Reviewed by Eric Seidel.
2875
2876         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2877         (TestConfigurationConverter.to_specifiers_list):
2878         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2879         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2880         (TestConfigurationConverter):
2881
2882 2012-02-08  Adam Barth  <abarth@webkit.org>
2883
2884         webkitpy should reply upon the multiprocessing package existing
2885         https://bugs.webkit.org/show_bug.cgi?id=78176
2886
2887         Reviewed by Eric Seidel.
2888
2889         Now that we don't support Python 2.5, this import can't fail.
2890
2891         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2892         (get):
2893         (_Process):
2894         (_Process.__init__):
2895         (_Process.run):
2896         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2897         (FunctionTests.test_get__processes):
2898         (MultiProcessBrokerTests.setUp):
2899         * Scripts/webkitpy/layout_tests/port/base.py:
2900         (Port.__init__):
2901         (Port.default_worker_model):
2902         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2903         (ChromiumMacPort.check_build):
2904         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2905         (PortTestCase.test_default_worker_model):
2906         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2907
2908 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2909
2910         Unreviewed typo fix that makes docs build again for the gtk2-based
2911         library.
2912
2913         * gtk/generate-gtkdoc:
2914
2915 2012-02-08  Adam Barth  <abarth@webkit.org>
2916
2917         Don't re-implement ZipFile.extractall
2918         https://bugs.webkit.org/show_bug.cgi?id=78173
2919
2920         Reviewed by Eric Seidel.
2921
2922         We can use ZipFile.extractall now that we don't support Python 2.5.
2923
2924         * Scripts/webkitpy/common/system/autoinstall.py:
2925         (AutoInstaller._extract_targz):
2926         (AutoInstaller._unzip):
2927
2928 2012-02-08  Adam Barth  <abarth@webkit.org>
2929
2930         Remove the ospath compat shim from webkitpy
2931         https://bugs.webkit.org/show_bug.cgi?id=78170
2932
2933         Reviewed by Eric Seidel.
2934
2935         We no longer need this compat shim now that we don't support Python 2.5.
2936
2937         * Scripts/webkitpy/common/checkout/scm/git.py:
2938         * Scripts/webkitpy/common/checkout/scm/svn.py:
2939         * Scripts/webkitpy/common/system/filesystem.py:
2940         (FileSystem.relpath):
2941         * Scripts/webkitpy/common/system/filesystem_mock.py:
2942         (MockFileSystem.relpath):
2943         * Scripts/webkitpy/common/system/ospath.py: Removed.
2944         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
2945
2946 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2947
2948         Build fix attempt after r107053.
2949
2950         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2951         (test_collect_tests):
2952
2953 2012-02-08  Adam Barth  <abarth@webkit.org>
2954
2955         Remove simplejson because it's no longer used by webkitpy
2956         https://bugs.webkit.org/show_bug.cgi?id=78164
2957
2958         Reviewed by Eric Seidel.
2959
2960         All the importers of this code were removed in a previous patch.
2961
2962         * Scripts/webkitpy/thirdparty/simplejson: Removed.
2963         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
2964         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
2965         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
2966         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
2967         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
2968         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
2969         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
2970         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
2971         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
2972         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
2973
2974 2012-02-08  Adam Barth  <abarth@webkit.org>
2975
2976         webkitpy still imports simplejson
2977         https://bugs.webkit.org/show_bug.cgi?id=78161
2978
2979         Reviewed by Eric Seidel.
2980
2981         We no longer support Python 2.5, so we can rely upon Python's built-in
2982         JSON package.
2983
2984         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2985         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2986         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
2987         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2988         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2989         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2990         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2991         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2992         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2993         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2994         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2995
2996 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2997
2998         [GTK] Fails to build docs with non-standard build directories
2999         https://bugs.webkit.org/show_bug.cgi?id=78118
3000
3001         * gtk/common.py:
3002         (get_build_path): add comment to document changes done in r107098,
3003         as requested by the reviewer and forgotten by me.
3004
3005 2012-02-08  Adam Barth  <abarth@webkit.org>
3006
3007         Stop importing with_statement from the mysterious future
3008         https://bugs.webkit.org/show_bug.cgi?id=78156
3009
3010         Reviewed by Eric Seidel.
3011
3012         The future is now!  (Well, at least 2008, when Python 2.6 was released,
3013         is no longer the __future__.)
3014
3015         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3016         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3017         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3018         * Scripts/webkitpy/common/net/credentials_unittest.py:
3019         * Scripts/webkitpy/common/net/file_uploader.py:
3020         * Scripts/webkitpy/common/newstringio_unittest.py:
3021         * Scripts/webkitpy/common/system/autoinstall.py:
3022         * Scripts/webkitpy/common/system/crashlogs.py:
3023         * Scripts/webkitpy/common/system/fileset.py:
3024         * Scripts/webkitpy/common/system/filesystem.py:
3025         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3026         * Scripts/webkitpy/common/system/path.py:
3027         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
3028         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3029         * Scripts/webkitpy/layout_tests/port/base.py:
3030         (of):
3031         * Scripts/webkitpy/layout_tests/port/gtk.py:
3032         * Scripts/webkitpy/layout_tests/port/test.py:
3033         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3034         * Scripts/webkitpy/style/filereader_unittest.py:
3035         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3036         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3037         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
3038         * Scripts/webkitpy/tool/commands/queues.py:
3039         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3040         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3041
3042 2012-02-08  Rob Buis  <rbuis@rim.com>
3043
3044         [BlackBerry] Upstream DumpRenderTreeBlackBerry
3045         https://bugs.webkit.org/show_bug.cgi?id=78042
3046
3047         Reviewed by Antonio Gomes.
3048
3049         Upstream more parts of our DRT implementation.
3050
3051         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
3052         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
3053         * DumpRenderTree/blackberry/EventSender.cpp: Added.
3054         * DumpRenderTree/blackberry/EventSender.h: Added.
3055         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
3056         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
3057
3058 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
3059
3060         check-webkit-style failing with "Path does not exist."
3061         https://bugs.webkit.org/show_bug.cgi?id=77873
3062
3063         Reviewed by Ojan Vafai.
3064
3065         This change fixes the way the style checker determines which
3066         Port class to use for a given test_expectations.txt path; the
3067         previous version used a heuristic that didn't really work in the
3068         first place.
3069
3070         * Scripts/webkitpy/style/checkers/test_expectations.py:
3071         (TestExpectationsChecker._determine_port_from_expectations_path):
3072         (TestExpectationsChecker.__init__):
3073         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3074         (TestExpectationsTestCase._expect_port_for_expectations_path):
3075         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
3076
3077 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
3078
3079         nrwt: make --skip-pixel-test-if-no-baseline option
3080         https://bugs.webkit.org/show_bug.cgi?id=70484
3081
3082         Reviewed by Dirk Pranke.
3083
3084         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3085         (SingleTestRunner.__init__):
3086         (SingleTestRunner._should_fetch_expected_checksum):
3087         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3088         (Worker.handle_test_list):
3089         * Scripts/webkitpy/layout_tests/models/test_input.py:
3090         (TestInput.__init__):
3091         * Scripts/webkitpy/layout_tests/port/webkit.py:
3092         (WebKitDriver.cmd_line):
3093         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3094         (_set_up_derived_options):
3095         (parse_args):
3096         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3097         (MainTest.test_skip_pixel_test_if_no_baseline_option):
3098         * WebKitTestRunner/TestController.cpp:
3099         (WTR::TestController::TestController):
3100         (WTR::TestController::initialize):
3101         (WTR::TestController::runTest):
3102         * WebKitTestRunner/TestController.h:
3103         (TestController):
3104         * WebKitTestRunner/TestInvocation.cpp:
3105         (WTR::TestInvocation::TestInvocation):
3106         (WTR::TestInvocation::setIsPixelTest):
3107         * WebKitTestRunner/TestInvocation.h:
3108         (WTR::TestInvocation::setSkipPixelTestOption):
3109         (TestInvocation):
3110
3111 2012-02-08  Rob Buis  <rbuis@rim.com>
3112
3113         [BlackBerry] Upstream DumpRenderTreeBlackBerry
3114         https://bugs.webkit.org/show_bug.cgi?id=78042
3115
3116         Reviewed by Antonio Gomes.
3117
3118         Add implementation for our DumpRenderTree solution.
3119
3120         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
3121         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
3122
3123 2012-02-08  Antti Koivisto  <antti@apple.com>
3124
3125         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
3126         https://bugs.webkit.org/show_bug.cgi?id=78080
3127
3128         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
3129         
3130         Add API test.
3131
3132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3133         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
3134         (TestWebKitAPI):
3135         (TestWebKitAPI::TEST):
3136
3137 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
3138
3139         [GTK] Fails to build docs with non-standard build directories
3140         https://bugs.webkit.org/show_bug.cgi?id=78118
3141
3142         Reviewed by Martin Robinson.
3143
3144         * gtk/common.py:
3145         (get_build_path): also try the current directory as a valid build
3146         dir, which makes non-standard build directories such as build-2.0
3147         and build-3.0 work
3148
3149 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3150
3151         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
3152         https://bugs.webkit.org/show_bug.cgi?id=78099
3153
3154         Reviewed by Martin Robinson.
3155
3156         * MiniBrowser/gtk/BrowserWindow.c:
3157         (webViewDecidePolicy): Check whether it's a link clicked with the
3158         middle mouse button and load the request in a new window.
3159         (browserWindowConstructed): Connect to
3160         WebKitWebView::decide-policy signal.
3161
3162 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
3163
3164         Revert a part of the change in r106687 as a build fix.
3165
3166         Since Chromium port doesn't checkout the entire WebKit trunk,
3167         we can't run "svn info" on webkit_base.
3168
3169         * Scripts/webkitpy/layout_tests/port/base.py:
3170         (Port.repository_paths):
3171
3172 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
3173
3174         run-perf-tests doesn't recognize paths that start with PerformanceTests
3175         https://bugs.webkit.org/show_bug.cgi?id=78012
3176
3177         Reviewed by Adam Barth.
3178
3179         Use resolve paths using filesystem.relpath before passing it to find_files.find.
3180
3181         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3182         (PerfTestsRunner):
3183         (PerfTestsRunner._collect_tests):
3184         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3185         (test_collect_tests):
3186         (test_collect_tests.add_file):
3187
3188 2012-02-07  Justin Novosad  <junov@chromium.org>
3189
3190         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
3191         https://bugs.webkit.org/show_bug.cgi?id=78039
3192
3193         Reviewed by Stephen White.
3194
3195         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
3196
3197         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3198         (main):
3199         * DumpRenderTree/chromium/TestShell.cpp:
3200         (TestShell::TestShell):
3201         (TestShell::resetWebSettings):
3202         (TestShell::runFileTest):
3203         * DumpRenderTree/chromium/TestShell.h:
3204         (TestShell::setDeferred2dCanvasEnabled):
3205         (TestShell):
3206         * DumpRenderTree/chromium/WebPreferences.cpp:
3207         (WebPreferences::reset):
3208         (WebPreferences::applyTo):
3209         * DumpRenderTree/chromium/WebPreferences.h:
3210         (WebPreferences):
3211
3212 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3213
3214         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
3215         https://bugs.webkit.org/show_bug.cgi?id=77928
3216
3217         Reviewed by Daniel Bates.
3218
3219         CMake has used *Programs* directory for executable. In addition, shared libraries are being
3220         built in source directory. It is better to set common places in order to maintain executable
3221         and libraries. *bin* is for executable and *lib* is for library.
3222
3223         * DumpRenderTree/efl/CMakeLists.txt:
3224         * EWebLauncher/CMakeLists.txt:
3225         * Scripts/run-launcher:
3226         * Scripts/webkitdirs.pm:
3227         (jscProductDir):
3228         * Scripts/webkitpy/layout_tests/port/efl.py:
3229         (EflPort._path_to_driver):
3230         (EflPort._path_to_image_diff):
3231
3232 2012-02-07  Adam Klein  <adamk@chromium.org>
3233
3234         Add JSC support for delivering mutations when the outermost script context exits
3235         https://bugs.webkit.org/show_bug.cgi?id=70289
3236
3237         Reviewed by Eric Seidel.
3238
3239         * DumpRenderTree/mac/EventSendingController.mm: Add support for
3240         eventSender.scheduleAsynchronousKeyDown.
3241         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3242         (+[EventSendingController webScriptNameForSelector:]):
3243         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
3244         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
3245         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
3246
3247 2012-02-07  Chris Rogers  <crogers@google.com>
3248
3249         Add Chris Rogers to reviewers section
3250         https://bugs.webkit.org/show_bug.cgi?id=78016
3251
3252         Reviewed by Adam Barth.
3253
3254         * Scripts/webkitpy/common/config/committers.py:
3255
3256 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3257
3258         layoutTestController.display() is flaky for SVG tests
3259         https://bugs.webkit.org/show_bug.cgi?id=78021
3260
3261         Reviewed by Dan Bernstein.
3262
3263         Fix race condition in repaint rect tracking. When running a test using the repaint.js
3264         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
3265         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
3266         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
3267         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
3268         the repaint test already run, thus invalidating the previously tracked repaint rects.
3269
3270         * DumpRenderTree/mac/DumpRenderTree.mm:
3271         (dump):
3272         (runTest):
3273
3274 2012-02-07  Hans Wennborg  <hans@chromium.org>
3275
3276         Chromium: remove WebSpeechInputResult::set
3277         https://bugs.webkit.org/show_bug.cgi?id=77977
3278
3279         Reviewed by Darin Fisher.
3280
3281         It was renamed to assign() in r106475.
3282
3283         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3284         (makeRectResult):
3285
3286 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3287
3288         [Qt] Give emulated touch-point a radius
3289         https://bugs.webkit.org/show_bug.cgi?id=77985
3290         
3291         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
3292
3293         Reviewed by Kenneth Rohde Christiansen.
3294
3295         * MiniBrowser/qt/BrowserWindow.cpp:
3296         (BrowserWindow::updateVisualMockTouchPoints):
3297         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3298         (MiniBrowserApplication::notify):
3299         * MiniBrowser/qt/qml/MockTouchPoint.qml:
3300
3301 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
3302
3303         [GTK] Include gdk-pixbuf in the jhbuild modules
3304         https://bugs.webkit.org/show_bug.cgi?id=77980
3305
3306         Reviewed by Gustavo Noronha Silva.
3307
3308         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
3309
3310 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
3311
3312         [Qt] Prevent early test termination with newer Qt 5
3313         https://bugs.webkit.org/show_bug.cgi?id=77945
3314
3315         Reviewed by Csaba Osztrogonác.
3316
3317         QTBUG-24120 tracks a regression in Qt that would make layout tests
3318         terminate early. This patch works around it in a Qt 4 + 5 safe manner
3319         by disabling the quitOnLastWindowClosed feature, which we don't want/need
3320         for DRT anyway.
3321
3322         * DumpRenderTree/qt/main.cpp:
3323         (main): Don't quit on last window closed.
3324
3325 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
3326
3327         Fix some miscellaneous 'make dist' error for WebKitGTK+.
3328
3329         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
3330         files should not be distributed.
3331
3332 2012-02-02  Hajime Morrita  <morrita@chromium.org>
3333
3334         [PerformanceTests] Each Dromaeo test needs its landing html.
3335         https://bugs.webkit.org/show_bug.cgi?id=77504
3336
3337         Reviewed by Ryosuke Niwa.
3338
3339         Added an ignorable pattern which happens in some Dromaeo tests.
3340
3341         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3342         (PerfTestsRunner):
3343
3344 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
3345
3346         [GTK] Add missing pango include dir to fix build
3347         https://bugs.webkit.org/show_bug.cgi?id=77832
3348
3349         Reviewed by Martin Robinson.
3350
3351         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
3352
3353 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
3354
3355         [GTK] Fix remaining errors in GTK+ WebKit2 API
3356         https://bugs.webkit.org/show_bug.cgi?id=77890
3357
3358         Reviewed by Gustavo Noronha Silva.
3359
3360         Verify that WebKit2 GTK+ test files are not skipped during style checks.
3361         Skip soup_server_new when checking for NULL versus 0 usage.
3362
3363         * Scripts/webkitpy/style/checker_unittest.py:
3364         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3365         * Scripts/webkitpy/style/checkers/cpp.py:
3366         (check_for_null):
3367
3368 2012-02-06  Eric Seidel  <eric@webkit.org>
3369
3370         webkit-patch apply-from-bug should be able to apply non-reviewed patches
3371         https://bugs.webkit.org/show_bug.cgi?id=77883
3372
3373         Reviewed by Adam Barth.
3374
3375         This is very helpful if you use bugzilla as a replacement for git-stash.
3376         Makes it simpler to re-apply the patch w/o having to look up the patch id.
3377
3378         * Scripts/webkitpy/tool/commands/download.py:
3379         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3380         * Scripts/webkitpy/tool/commands/download_unittest.py:
3381         (DownloadCommandsTest.test_apply_from_bug):
3382
3383 2012-02-06  Philippe Normand  <pnormand@igalia.com>
3384
3385         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
3386         https://bugs.webkit.org/show_bug.cgi?id=77866
3387
3388         Reviewed by Martin Robinson.
3389
3390         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
3391         errors in some gstreamer source code files defining new GStreamer elements.
3392         * Scripts/webkitpy/style/checker_unittest.py:
3393         (GlobalVariablesTest.test_path_rules_specifier):
3394
3395 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3396
3397         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
3398         https://bugs.webkit.org/show_bug.cgi?id=77869
3399
3400         Reviewed by Philippe Normand.
3401
3402         * gtk/gtkdoc.py:
3403         (GTKDoc.rebase_installed_docs): Check html_dir exists.
3404
3405 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3406
3407         [Qt] Don't version QtWebKit.experimental.
3408         https://bugs.webkit.org/show_bug.cgi?id=77739
3409
3410         Reviewed by Tor Arne Vestbø.
3411
3412         * MiniBrowser/qt/qml/BrowserWindow.qml:
3413
3414 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3415
3416         [GTK] Fix several gtkdoc-fixxref warnings
3417         https://bugs.webkit.org/show_bug.cgi?id=77613
3418
3419         Reviewed by Martin Robinson.
3420
3421         * gtk/generate-gtkdoc:
3422         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
3423         of ignored files, since it's private.
3424         * gtk/gtkdoc.py:
3425         (GTKDoc._ignored_files_basenames): Helper function that returns a
3426         string with the list of ignored files basenames separated by a
3427         spaces, as expected by several gtkdoc commands.
3428         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
3429         --ignore-headers option.
3430         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
3431         --ignore-files option.
3432
3433 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3434
3435         [GTK] Fix xrefs after installing API documentation
3436         https://bugs.webkit.org/show_bug.cgi?id=77551
3437
3438         Reviewed by Martin Robinson.
3439
3440         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
3441         api docs.
3442         * gtk/common.py:
3443         (prefix_of_pkg_config_file): Get the prefix variable of the given
3444         pkg-config file.
3445         (gtk_version_of_pkg_config_file): Get the gtk version required by
3446         the given pkg-config file.
3447         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
3448         installed documentation.
3449         (get_gtkdoc_module_paths): Get paths where API doc is installed
3450         for the dependencies of the given pkg-config file.
3451         (get_common_xref_deps): Get API doc directories of dependencies
3452         common to WebKit1 and WebKit2.
3453         (get_webkit2_options): Add cross_reference_deps option.
3454         (get_webkit1_options): Ditto
3455         (rebase_installed_docs): Helper function to create a generator for
3456         the given pkg-config file and options and call rebase_installed_docs.
3457         * gtk/gtkdoc.py:
3458         (GTKDoc.__init__): Initialize cross_reference_deps.
3459         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
3460         dependencies.
3461         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
3462         links of installed documentation.
3463         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
3464         file.
3465
3466 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
3467
3468         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
3469         https://bugs.webkit.org/show_bug.cgi?id=77672
3470
3471         Reviewed by Dirk Pranke.
3472
3473         Test repetitions must be taken into account when working out
3474         the statistics shown by run-webkit-tests.
3475
3476         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3477         (Manager.prepare_lists_and_print_output):
3478         (Manager._print_result_summary):
3479         * Scripts/webkitpy/layout_tests/models/result_summary.py:
3480         (ResultSummary.__init__):
3481         (ResultSummary.add):
3482         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3483         (MainTest.test_repeat_each_iterations_num_tests):
3484
3485 2012-02-05  Dan Bernstein  <mitz@apple.com>
3486
3487         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
3488         https://bugs.webkit.org/show_bug.cgi?id=77823
3489
3490         Reviewed by Anders Carlsson.
3491
3492         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3493         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
3494
3495 2012-02-04  Dan Bernstein  <mitz@apple.com>
3496
3497         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
3498         https://bugs.webkit.org/show_bug.cgi?id=77822
3499
3500         Reviewed by Sam Weinig.
3501
3502         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3503         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
3504
3505 2012-02-04  Sam Weinig  <sam@webkit.org>
3506
3507         Add ability to send WKURLRequests in WebKit2 API user messages
3508         https://bugs.webkit.org/show_bug.cgi?id=77819
3509
3510         Reviewed by Anders Carlsson.
3511
3512         Add testing for round-tripping WKTypes from the UIProcess,
3513         to the WebProcess, and back.
3514
3515         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
3516           More can easily be added.
3517
3518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3519         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
3520         (TestWebKitAPI):
3521         (WebKit2UserMessageRoundTripTest):
3522         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
3523         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
3524         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
3525         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
3526         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
3527         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
3528         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
3529         (TestWebKitAPI::TEST_F):
3530         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
3531         (TestWebKitAPI):
3532         (UserMessageTest):
3533         (TestWebKitAPI::UserMessageTest::UserMessageTest):
3534         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
3535         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3536         (TestWebKitAPI::PlatformWebView::resizeTo):
3537         (TestWebKitAPI):
3538         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3539         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3540
3541 2012-02-04  Dan Bernstein  <mitz@apple.com>
3542
3543         <rdar://problem/10772406> WKPreferences instances cannot be copied
3544         https://bugs.webkit.org/show_bug.cgi?id=77816
3545
3546         Reviewed by Sam Weinig.
3547
3548         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3549         (TestWebKitAPI::TEST):
3550
3551 2012-02-04  Adam Barth  <abarth@webkit.org>
3552
3553         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
3554         https://bugs.webkit.org/show_bug.cgi?id=77802
3555
3556         Reviewed by Eric Seidel.
3557
3558         This patch refactors our directory grouping code into base.js where it
3559         can be shared between failures.js and notifications.js.  It then adds
3560         an Examine action to each group of failures that triggers the "results"
3561         view.
3562
3563         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3564         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3565         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3566         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3567         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3568         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3569
3570 2012-02-04  Ojan Vafai  <ojan@chromium.org>
3571
3572         check-webkit-style is throwing an exception
3573         https://bugs.webkit.org/show_bug.cgi?id=77744
3574
3575         Reviewed by David Levin.
3576
3577         If the test_list is None, then we don't need to check for unsupported
3578         feature tests to skip.
3579
3580         * Scripts/webkitpy/layout_tests/port/webkit.py:
3581         (WebKitPort._has_test_in_directories):
3582         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3583         (test_skipped_tests_for_unsupported_features_empty_test_list):
3584
3585 2012-02-03  Adam Barth  <abarth@webkit.org>
3586
3587         List of all failures in garden-o-matic should actually list all the failures
3588         https://bugs.webkit.org/show_bug.cgi?id=77796
3589
3590         Reviewed by Eric Seidel.
3591
3592         This patch wires a bit more data into the new "All Failures" tab.  I've
3593         also iterated on how we enable this experimental feature.  The tab is
3594         still just a dumb list, but we'll make it smarter.
3595
3596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3600
3601 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3602
3603         Windows build fix after r106692.
3604
3605         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3606         (PortTest.test_reference_files):
3607
3608 2012-02-03  Beth Dakin  <bdakin@apple.com>
3609
3610         https://bugs.webkit.org/show_bug.cgi?id=77782
3611         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
3612         once on some pages with frames
3613         -and corresponding-
3614         <rdar://problem/10798474>
3615
3616         Reviewed by Sam Weinig.
3617
3618         One new test.
3619         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3620         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
3621         (TestWebKitAPI):
3622         (TestWebKitAPI::didForceRepaint):
3623         (TestWebKitAPI::didFinishLoadForFrame):
3624         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3625         (TestWebKitAPI::setPageLoaderClient):
3626         (TestWebKitAPI::TEST):
3627         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
3628         (TestWebKitAPI):
3629         (NewFirstVisuallyNonEmptyLayoutFramesTest):
3630         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
3631         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
3632         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
3633
3634 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
3635
3636         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
3637         https://bugs.webkit.org/show_bug.cgi?id=77781
3638
3639         Reviewed by Eric Seidel.
3640
3641         This change fixes a couple of issues discovered while debugging
3642         test-webkitpy; both calling exit() instead of sys.exit() --
3643         which is discouraged in program code instead of the interpreter
3644         -- and a particular usage of outputcapture were stdin to get whacked
3645         and preventing debugging.
3646        
3647         This change introduces a couple of common _exit() methods that
3648         will standardize how webkit-patch exit's, in case we need to do
3649         something different in the future.
3650
3651         * Scripts/webkitpy/common/system/deprecated_logging.py:
3652         (error):
3653         * Scripts/webkitpy/common/system/outputcapture.py:
3654         (OutputCapture.assert_outputs):
3655         * Scripts/webkitpy/tool/bot/queueengine.py:
3656         (QueueEngine.exit_after_handled_error):
3657         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3658         (AbstractSequencedCommand.execute):
3659         * Scripts/webkitpy/tool/commands/queues.py:
3660         (StyleQueue.handle_script_error):
3661         * Scripts/webkitpy/tool/commands/upload.py:
3662         (MarkBugFixed.execute):
3663         * Scripts/webkitpy/tool/multicommandtool.py:
3664         (Command._exit):
3665         * Scripts/webkitpy/tool/steps/abstractstep.py:
3666         (AbstractStep._exit):
3667         * Scripts/webkitpy/tool/steps/checkstyle.py:
3668         (CheckStyle.run):
3669         * Scripts/webkitpy/tool/steps/commit.py:
3670         (Commit._check_test_expectations):
3671         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3672         (ConfirmDiff.run):
3673
3674 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3675
3676         Perf bot build fix.
3677
3678         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3679         (PerfTestsRunner._generate_json):
3680
3681 2012-02-03  Adam Barth  <abarth@webkit.org>
3682
3683         Add a blank "Expected Failures" tab to garden-o-matic
3684         https://bugs.webkit.org/show_bug.cgi?id=77793
3685
3686         Reviewed by Eric Seidel.
3687
3688         This tab will help us explore and manage our expected failures.  The
3689         tab is hidden by default via a new "experimental features" flag.
3690
3691         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3692         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3693         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3694         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3695         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3696         (#unexpected):
3697         (#onebar.partytime #unexpected):
3698
3699 2012-02-03  Lucas Forschler  <lforschler@apple.com>
3700
3701         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
3702         https://bugs.webkit.org/show_bug.cgi?id=77785
3703
3704         Fix the build bots.
3705         
3706         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
3707
3708         * Scripts/update-webkit-support-libs:
3709         (downloadExpectedVersionNumber):
3710
3711 2012-02-03  Lucas Forschler  <lforschler@apple.com>