7425feb887b1f66c3fb8f28c58f4f19dd98980f2
[WebKit-https.git] / Tools / ChangeLog
1 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         Fix std::make_unique / new[] using system malloc
4         https://bugs.webkit.org/show_bug.cgi?id=182975
5
6         Reviewed by JF Bastien.
7
8         * TestWebKitAPI/CMakeLists.txt:
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp: Copied from Source/WebKit/Platform/win/LoggingWin.cpp.
11         (TestWebKitAPI::NonTrivialDestructor::NonTrivialDestructor):
12         (TestWebKitAPI::NonTrivialDestructor::~NonTrivialDestructor):
13         (TestWebKitAPI::NonTrivialDestructor::setLog):
14         (TestWebKitAPI::TEST):
15
16 2018-03-05  Myles C. Maxfield  <mmaxfield@apple.com>
17
18         DumpRenderTree build fix
19
20         Unreviewed.
21
22         * DumpRenderTree/mac/LayoutTestHelper.m:
23
24 2018-03-05  Andy Estes  <aestes@apple.com>
25
26         [Mac] Teach WebCore::Pasteboard about file promise drags
27         https://bugs.webkit.org/show_bug.cgi?id=183314
28         <rdar://problem/38105493>
29
30         Reviewed by Darin Adler.
31
32         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
33         * DumpRenderTree/DumpRenderTreeFileDraggingSource.m:
34         (-[DumpRenderTreeFileDraggingSource initWithPromisedFileURLs:]):
35         (-[DumpRenderTreeFileDraggingSource dealloc]):
36
37         Taught DumpRenderTreeFileDraggingSource to store the promised file URLs.
38
39         * DumpRenderTree/mac/DumpRenderTree.mm:
40         (runTest):
41
42         Called +[DumpRenderTreeDraggingInfo clearAllFilePromiseReceivers] after running a test.
43
44         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
45         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
46         (-[DumpRenderTreeFilePromiseReceiver initWithPromisedUTIs:]):
47         (-[DumpRenderTreeFilePromiseReceiver fileTypes]):
48         (-[DumpRenderTreeFilePromiseReceiver fileNames]):
49         (-[DumpRenderTreeFilePromiseReceiver dealloc]):
50         (copyFile):
51         (-[DumpRenderTreeFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
52
53         We can't instantiate real NSFilePromiseReceivers in DumpRenderTree. They rely on the
54         pasteboard server to generate unique file URLs, which is incompatible with our swizzled
55         NSPasteboard.
56
57         Instead, create a subclass of NSFilePromiseReceiver that implements its own promise resolution.
58         -receivePromisedFilesAtDestination:... asks its DumpRenderTreeFileDraggingSource for the
59         array of file URLs, then copies each to the destination directory on the specified operation
60         queue. It emulates how NSPasteboard tries to find a unique destination name by appending
61         numbers to the file name.
62
63         All receivers are collected in a global array that is cleared when each test finishes.
64         DumpRenderTreeFilePromiseReceiver will delete the files it copied in -dealloc.
65
66         (+[DumpRenderTreeDraggingInfo clearAllFilePromiseReceivers]):
67         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
68         
69         If NSFilesPromisePboardType is on the pasteboard and classArray contains
70         NSFilePromiseReceiver, construct a DumpRenderTreeFilePromiseReceiver, add it to the array of
71         all file promise receivers, then wrap it in an NSDraggingItem and call block.
72
73         * DumpRenderTree/mac/EventSendingController.mm:
74         (+[EventSendingController isSelectorExcludedFromWebScript:]):
75         (+[EventSendingController webScriptNameForSelector:]):
76         (-[EventSendingController beginDragWithFilePromises:]):
77
78         Implement eventSender.beginDragWithFilePromises() by placing file UTIs on the pasteboard
79         with type NSFilesPromisePboardType, creating a DumpRenderTreeFileDraggingSource with the
80         file URLs, and creating a new DumpRenderTreeDraggingInfo and passing it to
81         -[WebView draggingEntered:].
82
83 2018-03-05  Aakash Jain  <aakash_jain@apple.com>
84
85         [webkitpy] Bugzilla class should use NetworkTransaction for network operations
86         https://bugs.webkit.org/show_bug.cgi?id=183222
87
88         Reviewed by Alexey Proskuryakov.
89
90         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
91         (Bugzilla.open_url): Method which uses NetworkTransaction for opening url.
92         (Bugzilla.fetch_user): Used self.open_url instead of directly calling browser.open().
93         (Bugzilla.add_user_to_groups): Ditto.
94         (Bugzilla._fetch_bug_page): Ditto.
95         (Bugzilla.fetch_attachment_contents): Ditto.
96         (Bugzilla.get_bug_id_for_attachment_id): Ditto.
97         (Bugzilla.authenticate): Ditto.
98         (Bugzilla.add_attachment_to_bug): Ditto.
99         (Bugzilla.add_patch_to_bug): Ditto.
100         (Bugzilla.create_bug): Ditto.
101         (Bugzilla.clear_attachment_flags): Ditto.
102         (Bugzilla.set_flag_on_attachment): Ditto.
103         (Bugzilla.obsolete_attachment): Ditto.
104         (Bugzilla.add_cc_to_bug): Ditto.
105         (Bugzilla.post_comment_to_bug): Ditto.
106         (Bugzilla.close_bug_as_fixed): Ditto.
107         (Bugzilla.reassign_bug): Ditto.
108         (Bugzilla.reopen_bug): Ditto.
109         (Bugzilla._fetch_bug_page_by_url): Deleted, not required anymore.
110         * Scripts/webkitpy/common/net/networktransaction.py:
111         (NetworkTransaction.run): Added a FIXME.
112
113 2018-03-05  Joseph Pecoraro  <pecoraro@apple.com>
114
115         dump-class-layout mishandles duplicates base classes and miscomputes padding
116         https://bugs.webkit.org/show_bug.cgi?id=183311
117
118         Reviewed by Simon Fraser.
119
120         * Scripts/dump-class-layout:
121         (verify_type):
122         (verify_type_recursive):
123         Keep a list of seen (offset, type) that we have output and don't re-output them.
124         The Python types list the base classes as members multiple times as you iterate
125         through the members, so just ignore them if we have seem them already at a
126         specific offset.
127
128 2018-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
129
130         [GTK][Wayland] The GTK Wayland bot exits early because of assertions related with libsecret since r221925
131         https://bugs.webkit.org/show_bug.cgi?id=183330
132
133         Reviewed by Michael Catanzaro.
134
135         Add libsecret to the JHBuild and build it only when the system version is
136         less than 0.18.6 (unreleased as of writing this) in order to cherry pick
137         a fix for a bug that causes crashes with layout tests.
138
139         * gtk/jhbuild.modules:
140         * gtk/patches/libsecret-secret-methods-Don-t-unref-NULL-when-search-fails.patch: Added.
141
142 2018-03-05  Claudio Saavedra  <csaavedra@igalia.com>
143
144         [GTK] Implement WTR's PlatformWebView::setWindowIsKey()
145         https://bugs.webkit.org/show_bug.cgi?id=183143
146
147         Reviewed by Carlos Garcia Campos.
148
149         Implement ::setWindowIsKey() by keeping a second window to be
150         presented when the webview's window is to lose its key status.
151
152         * WebKitTestRunner/PlatformWebView.h:
153         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
154         (WTR::PlatformWebView::PlatformWebView):
155         (WTR::PlatformWebView::~PlatformWebView):
156         (WTR::PlatformWebView::setWindowIsKey):
157
158 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
159
160         Unreviewed, attempt to fix Apple port build
161
162         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
163
164 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
165
166         Unreviewed, attempt to fix WPE build
167
168         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
169         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
170         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
171         (WTR::PlatformWebView::windowSnapshotImage):
172         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
173         (WTR::TestController::platformRunUntil):
174
175 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
176
177         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
178         https://bugs.webkit.org/show_bug.cgi?id=183312
179
180         Reviewed by Mark Lam.
181
182         Remove wtf/CurrentTime.h include pragma.
183
184         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
185         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp:
186         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp:
187         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
188         * TestWebKitAPI/Tests/WTF/Condition.cpp:
189         * TestWebKitAPI/Tests/WTF/Signals.cpp:
190         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
191         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
192         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
193         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
194         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp:
195         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
196
197 2018-03-04  Tim Horton  <timothy_horton@apple.com>
198
199         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
200         https://bugs.webkit.org/show_bug.cgi?id=183283
201         <rdar://problem/38062148>
202
203         Reviewed by Sam Weinig.
204
205         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
206
207 2018-03-02  Chris Dumez  <cdumez@apple.com>
208
209         Converting a load to a download does not work with async policy delegates
210         https://bugs.webkit.org/show_bug.cgi?id=183254
211         <rdar://problem/38035334>
212
213         Reviewed by Youenn Fablet.
214
215         Add layout test infrastructure for responding to the decidePolicyForNavigationResponse
216         delegate asynchronously.
217
218         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
219         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
220         (WTR::InjectedBundlePage::decidePolicyForResponse):
221         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
222         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
223         * WebKitTestRunner/InjectedBundle/TestRunner.h:
224         (WTR::TestRunner::shouldDecideResponsePolicyAfterDelay const):
225         * WebKitTestRunner/TestController.cpp:
226         (WTR::TestController::resetStateToConsistentValues):
227         (WTR::TestController::decidePolicyForNavigationResponse):
228         * WebKitTestRunner/TestController.h:
229         (WTR::TestController::setShouldDecideResponsePolicyAfterDelay):
230         * WebKitTestRunner/TestInvocation.cpp:
231         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
232
233 2018-03-01  Youenn Fablet  <youenn@apple.com>
234
235         Add API test to validate setting of service worker and cache storage directories
236         https://bugs.webkit.org/show_bug.cgi?id=182543
237
238         Reviewed by Chris Dumez.
239
240         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
241
242 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
243
244         [Win][DRT] Implement setSpatialNavigationEnabled.
245         https://bugs.webkit.org/show_bug.cgi?id=183166
246
247         Reviewed by Per Arne Vollan.
248
249         * DumpRenderTree/TestRunner.cpp:
250         (setSpatialNavigationEnabledCallback):
251         * DumpRenderTree/win/DumpRenderTree.cpp:
252         (resetWebPreferencesToConsistentValues):
253         * DumpRenderTree/win/TestRunnerWin.cpp:
254         (TestRunner::setSpatialNavigationEnabled):
255
256 2018-03-01  Basuke Suzuki  <Basuke.Suzuki@sony.com>
257
258         [webkitpy] Use shell=False to launch apache http server.
259         https://bugs.webkit.org/show_bug.cgi?id=183191
260
261         Reviewed by Aakash Jain.
262
263         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
264         (LayoutTestApacheHttpd.__init__):
265         (LayoutTestApacheHttpd._run):
266
267 2018-03-01  Chris Dumez  <cdumez@apple.com>
268
269         Unreviewed, update WebKit.CustomHeaderFields API test after r229133.
270
271         We no longer do policy checks for 'about:blank'.
272
273         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
274         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
275         (TEST):
276
277 2018-02-28  Jonathan Bedard  <jbedard@apple.com>
278
279         [webkitpy] Remove concept of 'future' versions (Follow-up fix 2)
280         https://bugs.webkit.org/show_bug.cgi?id=183184
281         <rdar://problem/37958594>
282
283         Reviewed by Aakash Jain.
284
285         Unlisted Apple versions can't run webkitpy tests because they don't
286         have specified port names.
287
288         * Scripts/webkitpy/port/apple.py:
289         (ApplePort.determine_full_port_name): Return valid port name for unnamed
290         versions.
291         * Scripts/webkitpy/port/base.py:
292         (Port.version_name): Check both public and internal version mapping
293         when returning a version name.
294         * Scripts/webkitpy/port/mac.py:
295         (MacPort.__init__): If no os version is defined, use the current version.
296
297 2018-02-28  John Wilander  <wilander@apple.com>
298
299         Add a second tier of prevalence to facilitate telemetry on very prevalent domains
300         https://bugs.webkit.org/show_bug.cgi?id=183218
301         <rdar://problem/37992388>
302
303         Reviewed by Brent Fulgham.
304
305         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
306             Added two new testRunner functions:
307             - setStatisticsVeryPrevalentResource()
308             - isStatisticsVeryPrevalentResource()
309         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
310         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
311         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
312         * WebKitTestRunner/InjectedBundle/TestRunner.h:
313         * WebKitTestRunner/TestController.cpp:
314         (WTR::TestController::setStatisticsVeryPrevalentResource):
315         (WTR::TestController::isStatisticsVeryPrevalentResource):
316         * WebKitTestRunner/TestController.h:
317         * WebKitTestRunner/TestInvocation.cpp:
318         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
319
320 2018-02-28  Jonathan Bedard  <jbedard@apple.com>
321
322         [webkitpy] Remove concept of 'future' versions (Follow-up fix)
323         https://bugs.webkit.org/show_bug.cgi?id=183184
324         <rdar://problem/37958594>
325
326         Reviewed by David Kilzer.
327
328         The factory also relies on future in a non-obvious way.
329
330         * Scripts/webkitpy/common/system/platforminfo.py:
331         (PlatformInfo.os_version_name): Check both public and internal version mapping
332         when returning a version name.
333         * Scripts/webkitpy/common/system/platforminfo_mock.py:
334         (MockPlatformInfo.os_version_name): Ditto.
335
336 2018-02-28  Zan Dobersek  <zdobersek@igalia.com>
337
338         Unreviewed WPE fixup after r229080.
339
340         Add empty definitions for two AccessibilityUIElement methods,
341         avoiding undefined symbols in the WKTR injected bundle.
342
343         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
344         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
345         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
346
347 2018-02-27  Jonathan Bedard  <jbedard@apple.com>
348
349         Remove concept of 'future'
350         https://bugs.webkit.org/show_bug.cgi?id=183184
351         <rdar://problem/37958594>
352
353         Reviewed by Aakash Jain.
354
355         Remove concept of 'future' from expectations and instead
356         use a system of inheritance centered around the current version
357         of an OS for Mac and iOS.
358
359         Inheritance works like so:
360
361         | ....
362         V Future
363         > High Sierra (mac)
364         ^ mac-sierra
365         | mac-elcapitan
366         | ....
367
368         This does not change expectation inheritance for any currently running
369         configurations, it generalizes the logic already used.
370
371         * Scripts/webkitpy/common/version_name_map.py:
372         (VersionNameMap.__init__): Remove all future versions.
373         (VersionNameMap.mapping_for_platform): Return empty dicts instead of
374         asserting.
375         * Scripts/webkitpy/port/apple.py:
376         (ApplePort):
377         (ApplePort._allowed_versions): Return all available versions.
378         (ApplePort._generate_all_test_configurations): Instead of picking from a set
379         of allowed versions, assume that every specified version is allowed.
380         (ApplePort._port_name_with_version): Deleted.
381         * Scripts/webkitpy/port/darwin.py: Add CURRENT_VERSION overridden by subclasses.
382         (DarwinPort):
383         * Scripts/webkitpy/port/ios.py:
384         (IOSPort):
385         (IOSPort.default_baseline_search_path): Use system of inheritance centered around
386         the current version.
387         * Scripts/webkitpy/port/mac.py:
388         (MacPort):
389         (MacPort.__init__): Use current version by default.
390         (MacPort.default_baseline_search_path): Use system of inheritance centered around
391         the current version.
392         (MacPort.configuration_specifier_macros): Use the same set of version names
393         supported in default_baseline_search_path.
394         * Scripts/webkitpy/port/mac_unittest.py:
395         (MacTest.test_versions): Remove 'future' tests.
396
397 2018-02-27  Michael Catanzaro  <mcatanzaro@igalia.com>
398
399         Unreviewed GTK test gardening
400
401         * TestWebKitAPI/glib/TestExpectations.json:
402
403 2018-02-27  Doug Russell  <doug@getitdownonpaper.com>
404
405         AX: Spell check and style attributes should be optional when fetching attributed string
406         https://bugs.webkit.org/show_bug.cgi?id=160744
407
408         Reviewed by Chris Fleizach.
409
410         The overhead of fetching a spell checked attributed string via AX API is substantial. 
411         In some cases on the order of 7/8 of the total time spent fetching the string.
412
413         This change introduces the new attribute AXAttributedStringForTextMarkerRangeWithOptions which accepts an NSDictionary as it's parameter with keys "AXTextMarkerRange" (AXTextMarkerRangeRef) and "AXSpellCheck" (NSNumber(BOOL)).
414
415         AXAttributedStringForTextMarkerRange will remain unchanged.
416
417         * DumpRenderTree/AccessibilityUIElement.cpp:
418         (attributedStringForTextMarkerRangeCallback):
419         (attributedStringForTextMarkerRangeWithOptionsCallback):
420         (AccessibilityUIElement::attributedStringForTextMarkerRange):
421         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
422         (AccessibilityUIElement::getJSClass):
423         * DumpRenderTree/AccessibilityUIElement.h:
424         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
425         (AccessibilityUIElement::attributedStringForTextMarkerRange):
426         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
427         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
428         (createJSStringRef):
429         (AccessibilityUIElement::attributedStringForTextMarkerRange):
430         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
431         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
432         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
433         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
434         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
435         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
436         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
437         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
438         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
439         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
440         (WTR::createJSStringRef):
441         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
442         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
443
444 2018-02-27  Daniel Bates  <dabates@apple.com>
445
446         Standardize terminology for marked text
447         https://bugs.webkit.org/show_bug.cgi?id=180999
448
449         Reviewed by Zalan Bujtas.
450
451         The name MarkerSubrange is a misnomer for a data structure that associates a text subrange with a type
452         and optional document marker. In particular, a MarkerSubrange may not always correspond to a document
453         marker. For instance, selected text is represented using a MarkerSubrange that does not have a
454         corresponding document marker. Let's standardize on the phrase "marked text" as the canonical way to
455         describe these tagged text subranges.
456
457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
458         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp: Added.
459         (WebCore::operator<<):
460         (TestWebKitAPI::TEST):
461         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp: Removed.
462
463 2018-02-27  Aakash Jain  <aakash_jain@apple.com>
464
465         webkitpy Bugzilla transactions should retry on URLError
466         https://bugs.webkit.org/show_bug.cgi?id=183156
467
468         Reviewed by Alexey Proskuryakov.
469
470         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
471         (Bugzilla): Use NetworkTransaction.
472         (Bugzilla._fetch_bug_page_by_url):
473         (Bugzilla.bug_id_for_attachment_id):
474         (Bugzilla.get_bug_id_for_attachment_id):
475
476 2018-02-27  Wenson Hsieh  <wenson_hsieh@apple.com>
477
478         [Extra zoom mode] Implement additional SPI for adjusting viewport shrink-to-fit behavior
479         https://bugs.webkit.org/show_bug.cgi?id=183100
480         <rdar://problem/37840987>
481
482         Reviewed by Tim Horton.
483
484         Add API tests that exercise -_setMinimumAllowedLayoutWidth: and -_setForceHorizontalViewportShrinkToFit:. See
485         WebKit ChangeLog for more detail.
486
487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
488         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Added.
489         (TestWebKitAPI::while):
490         (viewportTestPageMarkup):
491         (TestWebKitAPI::TEST):
492
493 2018-02-27  Yusuke Suzuki  <utatane.tea@gmail.com>
494
495         Unreviewed, skip FTL tests if FTL is disabled
496         https://bugs.webkit.org/show_bug.cgi?id=183071
497
498         * Scripts/run-jsc-stress-tests:
499
500 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
501
502         Fix WebCore includes within WebKitLegacy
503         https://bugs.webkit.org/show_bug.cgi?id=183147
504
505         Reviewed by Tim Horton.
506
507         * MiniBrowser/win/ResourceLoadDelegate.cpp:
508
509 2018-02-26  Yousuke Kimoto  <yousuke.kimoto@sony.com>
510
511         [WinCairo] WebKit2_C.h should be included for TestWebKit
512         https://bugs.webkit.org/show_bug.cgi?id=182682
513
514         Reviewed by Yusuke Suzuki.
515
516         * TestWebKitAPI/config.h:
517
518 2018-02-25  Fujii Hironori  <Hironori.Fujii@sony.com>
519
520         [WK2] http/tests/navigation/new-window-redirect-history.html crashes
521         https://bugs.webkit.org/show_bug.cgi?id=127683
522
523         Reviewed by Dan Bernstein.
524
525         m_previousTestBackForwardListItem was null for the new window.
526         m_previousTestBackForwardListItem is initialized only for the main
527         window in InjectedBundlePage::prepare.
528
529         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
530         (WTR::InjectedBundlePage::dumpBackForwardList):
531         Do null-check of m_previousTestBackForwardListItem.
532
533 2018-02-25  Alexey Proskuryakov  <ap@apple.com>
534
535         Various crashes in WebKitTestRunner, especially when system is under heavy load
536         https://bugs.webkit.org/show_bug.cgi?id=183109
537
538         Reviewed by Tim Horton.
539
540         WebKitTestRunner had many places where it sent messages to WebContent with a timeout,
541         but it didn't handle the timeout when it did occur. Nearly all of those would result
542         in logic errors and failing tests, and most would even result in stack corruption,
543         as the response handler modified local variables.
544
545         There is only one timeout scenario that we actually mean to handle in WKTR. That's
546         when a test freezes after it is done (e.g. an infinite loop in beforeunload) - we don't
547         want to blame the next test for freezing, so we silently relaunch WebContent.
548         Everything else is cargo cult code that never worked.
549
550         This patch addresses the crashes, and actually makes tests pass a lot more on an
551         overloaded system.
552
553         * WebKitTestRunner/TestController.cpp:
554         (WTR::TestController::resetStateToConsistentValues): Moved m_doneResetting assignment
555         to where it's actually needed, for clarity.
556         (WTR::TestController::reattachPageToWebProcess): This function used to always hit
557         and ignore message timeout, as m_doneResetting is only updated by navigation callback
558         when the state is Resetting. This change makes it faster.
559         (WTR::TestController::platformResetStateToConsistentValues): Style fix.
560         (WTR::TestController::clearServiceWorkerRegistrations): Timing out here wasn't
561         handled in a meaningful manner, and would even corrupt the stack.
562         (WTR::TestController::clearDOMCache): Ditto.
563         (WTR::TestController::clearDOMCaches): Ditto.
564         (WTR::TestController::hasDOMCache): Ditto.
565         (WTR::TestController::domCacheSize): Ditto.
566         (WTR::TestController::isStatisticsPrevalentResource): Ditto.
567         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder): Ditto.
568         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo): Ditto.
569         (WTR::TestController::isStatisticsHasHadUserInteraction): Ditto.
570         (WTR::TestController::isStatisticsGrandfathered): Ditto.
571         (WTR::TestController::statisticsUpdateCookiePartitioning): Ditto.
572         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Ditto.
573         (WTR::TestController::statisticsClearInMemoryAndPersistentStore): Ditto.
574         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): Ditto.
575         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval): Ditto.
576
577         * WebKitTestRunner/TestInvocation.cpp:
578         (WTR::TestInvocation::shortTimeout const): Made shortTimeout shorter (on a hunch).
579         (WTR::TestInvocation::invoke): Removed a timeout waiting for initial response. There
580         is never a logical reason for such a timeout, as we always have a new or responsive
581         WebContent process here.
582         (WTR::TestInvocation::dumpResults): Removed another timeout that we don't know how to
583         properly handle.
584         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Removed assignment to
585         m_errorMessage, which had no effect in this context.
586
587         * WebKitTestRunner/TestInvocation.h: Removed no longer used code.
588
589         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
590         (WTR::TestController::cocoaResetStateToConsistentValues): Use a named constant for
591         no timeout.
592         
593         * WebKitTestRunner/ios/TestControllerIOS.mm:
594         (WTR::TestController::platformConfigureViewForTest): Removed a useless timeout.
595         Not sure if timing out here would corrupt the stack or not, but there is no reason
596         to impose arbitrary limits on individual steps of a test.
597
598         * WebKitTestRunner/mac/TestControllerMac.mm:
599         (WTR::TestController::platformConfigureViewForTest): Use a named constant for
600         no timeout.
601
602 2018-02-25  Ali Juma  <ajuma@chromium.org>
603
604         Unreviewed. Change my status to committer.
605
606         * Scripts/webkitpy/common/config/contributors.json:
607
608 2018-02-25  Chris Dumez  <cdumez@apple.com>
609
610         Service workers do not work well inside Web.app
611         https://bugs.webkit.org/show_bug.cgi?id=183105
612         <rdar://problem/37864140>
613
614         Reviewed by Youenn Fablet.
615
616         Add API test coverage.
617
618         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
619
620 2018-02-25  Aakash Jain  <aakash_jain@apple.com>
621
622         [build.webkit.org] unit-tests fail if buildbot 0.8.6p1 is not installed locally
623         https://bugs.webkit.org/show_bug.cgi?id=183103
624
625         Reviewed by Alexey Proskuryakov.
626
627         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Removed extra imports.
628
629 2018-02-24  Wenson Hsieh  <wenson_hsieh@apple.com>
630
631         Unreviewed, fix the TestWebKitAPI build after r228825.
632
633         I removed a `>= iOS 11` check in r228825, but forgot that this was also neeed to guard against tvOS and watchOS
634         builds. This fixes the build by restoring the compile-time guard and also makes it explicit for these platforms.
635
636         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
637
638 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
639
640         Remove currentTime() / currentTimeMS()
641         https://bugs.webkit.org/show_bug.cgi?id=183052
642
643         Reviewed by Mark Lam.
644
645         * DumpRenderTree/TestRunner.cpp:
646         (preciseTimeCallback):
647         * DumpRenderTree/mac/TestRunnerMac.mm:
648         (TestRunner::setMockGeolocationPosition):
649         * TestWebKitAPI/Tests/WTF/Condition.cpp:
650         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
651         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
652         * WebKitTestRunner/GeolocationProviderMock.cpp:
653         (WTR::GeolocationProviderMock::setPosition):
654         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
655         (WTR::TestRunner::preciseTime):
656
657 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
658
659         Remove sleep(double) and sleepMS(double) interfaces
660         https://bugs.webkit.org/show_bug.cgi?id=183038
661
662         Reviewed by Mark Lam.
663
664         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
665         (PluginTest::indicateTestFailure):
666         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp:
667         (EvaluteJSWithinNPP_New::NPP_New):
668         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp:
669         (InvokeDestroysPluginWithinNPP_New::NPP_New):
670         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
671         * TestWebKitAPI/Tests/WTF/Signals.cpp:
672         (TEST):
673         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
674         (TestWebKitAPI::testThreadGroup):
675         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
676         (TestWebKitAPI::TEST):
677         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
678         (TestWebKitAPI::TEST):
679         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
680         (TestWebKitAPI::TEST):
681         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp:
682         (TestWebKitAPI::Util::sleep):
683
684 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
685
686         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
687         https://bugs.webkit.org/show_bug.cgi?id=182883
688
689         Reviewed by Per Arne Vollan.
690
691         * DumpRenderTree/config.h:
692         * TestWebKitAPI/config.h:
693
694 2018-02-21  Michael Catanzaro  <mcatanzaro@igalia.com>
695
696         [GTK] Unsafe g_setenv use in MiniBrowser main
697         https://bugs.webkit.org/show_bug.cgi?id=182978
698
699         Reviewed by Carlos Garcia Campos.
700
701         setenv (and g_setenv) will randomly crash if called too late.
702
703         * MiniBrowser/gtk/main.c:
704         (main):
705
706 2018-02-21  Aakash Jain  <aakash_jain@apple.com>
707
708         webkitpy NetworkTransaction should retry on URLError
709         https://bugs.webkit.org/show_bug.cgi?id=182987
710
711         Reviewed by Alexey Proskuryakov.
712
713         * Scripts/webkitpy/common/net/networktransaction.py:
714         (NetworkTransaction.run): Retry on urllib2.URLError.
715
716 2018-02-21  Ms2ger  <Ms2ger@igalia.com>
717
718         [WTR][WPE] Correct the process names in TestController.
719         https://bugs.webkit.org/show_bug.cgi?id=178700
720
721         Reviewed by Michael Catanzaro.
722
723         Similar to r228731 for GTK.
724
725         * Scripts/webkitpy/port/wpe.py:
726         (WPEPort._get_crash_log): removed the code to convert WebProcess name.
727         * WebKitTestRunner/TestController.cpp: return the correct process names for WPE.
728         (WTR::TestController::webProcessName):
729         (WTR::TestController::networkProcessName):
730         (WTR::TestController::databaseProcessName):
731
732 2018-02-21  Ms2ger  <Ms2ger@igalia.com>
733
734         [ATK] Remove attributeSet variable from AccessibilityUIElement::attributedStringForRange().
735         https://bugs.webkit.org/show_bug.cgi?id=183000
736
737         Reviewed by Joanmarie Diggs.
738
739         It is never initialized, but is passed to atk_attribute_set_free.
740         This caused a crash in accessibility/content-editable-as-textarea.html on the debug bots.
741
742         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
743         (WTR::AccessibilityUIElement::attributedStringForRange):
744
745 2018-02-21  Myles C. Maxfield  <mmaxfield@apple.com>
746
747         [Cocoa] Make system-ui obey the user-installed-font policy
748         https://bugs.webkit.org/show_bug.cgi?id=182860
749         <rdar://problem/36158249>
750
751         Reviewed by Antti Koivisto.
752
753         Create a font, FakeHelvetica-ArmenianCharacter.ttf, which supports a particular Armenian
754         character which isn't isn't supported by any other font on the system.
755
756         * WebKitTestRunner/FakeHelvetica-ArmenianCharacter.ttf:
757         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
758
759 2018-02-20  Timothy Horton  <timothy_horton@apple.com>
760
761         Try to fix the 32-bit build after r228857
762
763         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
764         (WTR::UIScriptController::firstResponderSuppressionForWebView):
765
766 2018-02-20  Nan Wang  <n_wang@apple.com>
767
768         AX: Keyboard focus not following VoiceOver cursor into web content or within web content.
769         https://bugs.webkit.org/show_bug.cgi?id=182752
770         <rdar://problem/37518233>
771
772         Reviewed by Ryosuke Niwa.
773
774         * DumpRenderTree/mac/UIScriptControllerMac.mm:
775         (WTR::UIScriptController::firstResponderSuppressionForWebView):
776         (WTR::UIScriptController::makeWindowContentViewFirstResponder):
777         (WTR::UIScriptController::isWindowContentViewFirstResponder const):
778         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
779         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
780         (WTR::UIScriptController::firstResponderSuppressionForWebView):
781         (WTR::UIScriptController::makeWindowContentViewFirstResponder):
782         (WTR::UIScriptController::isWindowContentViewFirstResponder const):
783         * TestRunnerShared/UIScriptContext/UIScriptController.h:
784         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
785         (WTR::UIScriptController::firstResponderSuppressionForWebView):
786         (WTR::UIScriptController::makeWindowContentViewFirstResponder):
787         (WTR::UIScriptController::isWindowContentViewFirstResponder const):
788
789 2018-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
790
791         [GTK] jhbuild: Remove gtk-doc
792         https://bugs.webkit.org/show_bug.cgi?id=182956
793
794         Reviewed by Michael Catanzaro.
795
796         jhbuild doesn't need to build gtk-doc because major LTS Linux
797         distributions have gtk-doc v1.25, and
798         Tools/gtk/install-dependencies installs gtk-doc.
799
800         * gtk/jhbuild.modules: Removed gtk-doc.
801
802 2018-02-20  Tim Horton  <timothy_horton@apple.com>
803
804         Introduce HAVE(IOSURFACE_ACCELERATOR)
805         https://bugs.webkit.org/show_bug.cgi?id=182955
806         <rdar://problem/37699510>
807
808         Reviewed by Sam Weinig.
809
810         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
811         (createBitmapContextFromWebView):
812         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
813         (WTR::PlatformWebView::windowSnapshotImage):
814
815 2018-02-20  Chris Dumez  <cdumez@apple.com>
816
817         Provisional load may get committed before receiving the decidePolicyForNavigationResponse response
818         https://bugs.webkit.org/show_bug.cgi?id=182720
819         <rdar://problem/37515204>
820
821         Reviewed by Alex Christensen.
822
823         Add API test coverage.
824
825         * TestWebKitAPI/Tests/WebKitCocoa/AsyncPolicyForNavigationResponse.mm:
826         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
827         (TestWebKitAPI::TEST):
828
829 2018-02-20  Nan Wang  <n_wang@apple.com>
830
831         AX: AOM: Dispatch accessibleclick event
832         https://bugs.webkit.org/show_bug.cgi?id=180898
833         <rdar://problem/36086710>
834
835         Reviewed by Ryosuke Niwa.
836
837         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
838         (WTR::AccessibilityUIElement::syncPress):
839         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
840         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
841         (WTR::AccessibilityUIElement::syncPress):
842
843 2018-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
844
845         [iOS 11.3 Beta] Can't copy a URL from Safari and paste it into the Gmail app
846         https://bugs.webkit.org/show_bug.cgi?id=182952
847         <rdar://problem/37636190>
848
849         Reviewed by Tim Horton.
850
851         Adds a new iOS copy/paste test that copies an anchor element via action sheet, and checks that upon pasting,
852         both "text/plain" and "text/uri-list" are provided. Additionally tweaks an existing iOS drag and drop test to
853         check for the same behavior.
854
855         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
856         (TestWebKitAPI::TEST):
857         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
858         (TestWebKitAPI::TEST):
859
860 2018-02-20  Philippe Normand  <pnormand@igalia.com>
861
862         [GStreamer][MiniBrowser] Honor GStreamer command line parameters in MiniBrowser
863         https://bugs.webkit.org/show_bug.cgi?id=173655
864
865         Reviewed by Xabier Rodriguez-Calvar.
866
867         The FIXME in GStreamerUtilities.cpp asks to pass the command line
868         parameters to the GStreamer initialization function.
869
870         Based on initial patch by: Vanessa Chipirrás Navalón  <vchipirras@igalia.com>
871
872         * MiniBrowser/gtk/main.c:
873         (main): Add the group containing the Gstreamer options that the console displays.
874
875 2018-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
876
877         [WTR][GTK] crash log backtrace doesn't show symbol names for DatabaseProcess and NetworkProcess
878         https://bugs.webkit.org/show_bug.cgi?id=182953
879
880         Reviewed by Carlos Garcia Campos.
881
882         * Scripts/webkitpy/port/gtk.py:
883         (GtkPort._get_crash_log): Removed the code to convert WebProcess name.
884         * WebKitTestRunner/TestController.cpp:
885         (WTR::TestController::webProcessName): Return the correct program name for GTK+ port.
886         (WTR::TestController::networkProcessName): Ditto.
887         (WTR::TestController::databaseProcessName): Ditto.
888
889 2018-02-19  Ryan Haddad  <ryanhaddad@apple.com>
890
891         Unreviewed, rolling out r228696.
892
893         The API test added with this change is timing out on macOS.
894
895         Reverted changeset:
896
897         "Null pointer dereference in
898         WebPageProxy::urlSchemeHandlerForScheme()"
899         https://bugs.webkit.org/show_bug.cgi?id=182905
900         https://trac.webkit.org/changeset/228696
901
902 2018-02-16  Ryosuke Niwa  <rniwa@webkit.org>
903
904         Add an entitlement check for service worker on iOS
905         https://bugs.webkit.org/show_bug.cgi?id=182865
906         <rdar://problem/37505903>
907
908         Reviewed by Brady Eidson.
909
910         Added the service worker entitlements to WebKitTestRunner and TestWebKitAPI on iOS.
911
912         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:
913         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
914         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
915         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
916
917 2018-02-16  Youenn Fablet  <youenn@apple.com>
918
919         Allow specifying which plug-ins are supported
920         https://bugs.webkit.org/show_bug.cgi?id=182748
921
922         Reviewed by Chris Dumez.
923
924         Add support for a test runner API to specificy supported plug-ins.
925
926         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
927         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
928         (WTR::TestRunner::setPluginsAsUnsupported):
929         * WebKitTestRunner/InjectedBundle/TestRunner.h:
930         * WebKitTestRunner/TestController.cpp:
931         (WTR::TestController::resetStateToConsistentValues):
932         (WTR::TestController::setPluginsAsUnsupported):
933         * WebKitTestRunner/TestController.h:
934         * WebKitTestRunner/TestInvocation.cpp:
935         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
936
937 2018-02-16  Per Arne Vollan  <pvollan@apple.com>
938
939         Implement stopping of run loop in the WebContent process when using NSRunLoop.
940         https://bugs.webkit.org/show_bug.cgi?id=182499
941         <rdar://problem/37247424>
942
943         Reviewed by Brent Fulgham.
944
945         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
946         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessTerminate.mm: Added.
947         (TEST):
948
949 2018-02-15  Alexey Proskuryakov  <ap@apple.com>
950
951         Speed up dSYM generation on build.webkit.org with -gline-tables-only
952         https://bugs.webkit.org/show_bug.cgi?id=182841
953         rdar://problem/34579649
954
955         Reviewed by Aakash Jain.
956
957         Build speed and binary size improvements are so substantial that I'm willing to make
958         CI builds less suitable for debugging, which is not a common scenario anyway.
959         Crash logs will still have line numbers in them.
960
961         * BuildSlaveSupport/build.webkit.org-config/steps.py: (CompileWebKit.start):
962
963 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
964
965         WebCore headers should not be included relatively within dependent projects
966         https://bugs.webkit.org/show_bug.cgi?id=182805
967
968         Reviewed by Chris Dumez.
969
970         * TestWebKitAPI/win/TestWebCoreStubs.cpp:
971         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
972         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
973         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
974         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
975         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
976
977 2018-02-15  Tomas Popela  <tpopela@redhat.com>
978
979         run-jsc-stress-tests - skip a test if any of the run commands evals to skip
980         https://bugs.webkit.org/show_bug.cgi?id=182729
981
982         If multiple run commands are specified and one of them evals to skip,
983         then the test is not skipped, because the run is scheduled while
984         evaluating other commands.
985
986         Remember if the test is going to be skipped - if yes, just stop
987         evaluating the other run commands.
988
989         Reviewed by Saam Barati.
990
991         * Scripts/run-jsc-stress-tests:
992
993 2018-02-14  Charlie Turner  <cturner@igalia.com>
994
995         Get Garden-O-Matic running again.
996         https://bugs.webkit.org/show_bug.cgi?id=179089
997
998         Reviewed by Carlos Alberto Lopez Perez.
999
1000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
1001         (parseCommitData): Author field is not always spelled 'author' these days.
1002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1003         No longer have a 32-bit builder.
1004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
1005         (ui.perf.View.base.init): createElement has a required parameter these days.
1006         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1007         (GardenOMatic): Override use_globs so that platform lookup in config.js works.
1008
1009 2018-02-14  Don Olmstead  <don.olmstead@sony.com>
1010
1011         Remove unused ForwardingHeaders directories from Tools
1012         https://bugs.webkit.org/show_bug.cgi?id=182813
1013
1014         Reviewed by Konstantin Tokarev.
1015
1016         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Removed.
1017         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Removed.
1018         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed.
1019         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Removed.
1020         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Removed.
1021
1022 2018-02-14  Daniel Bates  <dabates@apple.com>
1023
1024         Disallow cross-origin subresources from asking for credentials
1025         https://bugs.webkit.org/show_bug.cgi?id=182579
1026         <rdar://problem/36162271>
1027
1028         Reviewed by Andy Estes.
1029
1030         Add test option allowCrossOriginSubresourcesToAskForCredential (defaults to false)
1031         so that tests can toggle between the old behavior and new behavior.
1032
1033         * DumpRenderTree/TestOptions.h:
1034         * DumpRenderTree/TestOptions.mm:
1035         (TestOptions::TestOptions):
1036         * DumpRenderTree/mac/DumpRenderTree.mm:
1037         (setWebPreferencesForTestOptions):
1038         * WebKitTestRunner/TestController.cpp:
1039         (WTR::TestController::resetPreferencesToConsistentValues):
1040         (WTR::updateTestOptionsFromTestHeader):
1041         * WebKitTestRunner/TestOptions.h:
1042         (WTR::TestOptions::hasSameInitializationOptions const):
1043
1044 2018-02-12  Ryosuke Niwa  <rniwa@webkit.org>
1045
1046         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
1047         https://bugs.webkit.org/show_bug.cgi?id=182564
1048
1049         Reviewed by Wenson Hsieh.
1050
1051         Updated assertions to make sure the trailing "}" of @list rules is includd in the style, the "style" element
1052         is wrapped by "head" element (not present in the pasted markup since the fragment parsing algorithm strips away),
1053         and the style content is enclosed in "<!--" and "-->".
1054
1055         Also use execCommand('insertHTML', ~) to insert the HTML obtained via dataTransfer.getData instead of innerHTML
1056         to make sure our pasting code preserves the special style element for MSO list quirks.
1057
1058         Finally, added two more test cases for pasting content from Microsoft Word's compatibility mode.
1059
1060         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1061         (TEST):
1062         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
1063         (TEST):
1064
1065 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1066
1067         [Tools] --wincairo should imply --64-bit by default.
1068         https://bugs.webkit.org/show_bug.cgi?id=182753
1069
1070         Reviewed by Daniel Bates.
1071
1072         WinCairo does not currently support 32-bit and `--wincairo` itself should refer to a working platform.
1073         This patch ensures x64 is determined correctly for `build-webkit --no-ninja` and `run-webkit-tests`.
1074
1075         * Scripts/webkitdirs.pm:
1076         (determinePassedArchitecture):
1077         (shouldBuild32Bit):
1078         (determineShouldBuild32Bit):
1079         (determineIsWin64):
1080         * Scripts/webkitpy/common/config/ports.py:
1081         (WinCairoPort.build_webkit_command):
1082         * Scripts/webkitpy/common/config/ports_unittest.py:
1083         (DeprecatedPortTest.test_wincairo_port):
1084         * Scripts/webkitpy/port/win.py:
1085         (WinCairoPort):
1086
1087 2018-02-13  Commit Queue  <commit-queue@webkit.org>
1088
1089         Unreviewed, rolling out r228431.
1090         https://bugs.webkit.org/show_bug.cgi?id=182766
1091
1092         Regressed CMake build stability (Requested by dolmstead on
1093         #webkit).
1094
1095         Reverted changeset:
1096
1097         "[CMake] Make WebCore headers copies"
1098         https://bugs.webkit.org/show_bug.cgi?id=182512
1099         https://trac.webkit.org/changeset/228431
1100
1101 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
1102
1103         [CMake] Make WebCore headers copies
1104         https://bugs.webkit.org/show_bug.cgi?id=182512
1105
1106         Reviewed by Keith Miller.
1107
1108         * DumpRenderTree/CMakeLists.txt:
1109         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1110         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1111         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1112         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1113         * TestWebKitAPI/PlatformGTK.cmake:
1114         * TestWebKitAPI/PlatformWPE.cmake:
1115         * TestWebKitAPI/PlatformWin.cmake:
1116         * TestWebKitAPI/win/TestWebCoreStubs.cpp:
1117         (loadResourceIntoBuffer):
1118         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1119         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
1120         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1121         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1122         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1123
1124 2018-02-13  Chris Dumez  <cdumez@apple.com>
1125
1126         REGRESSION (r228299): Broke reader mode in Safari
1127         https://bugs.webkit.org/show_bug.cgi?id=182697
1128         <rdar://problem/37399012>
1129
1130         Reviewed by Ryosuke Niwa.
1131
1132         Add API test coverage for responding asynchronously to the decidePolicyForNavigationResponse
1133         delegate.
1134
1135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1136         * TestWebKitAPI/Tests/WebKitCocoa/AsyncPolicyForNavigationResponse.mm: Added.
1137         (-[TestAsyncNavigationDelegate webView:didFinishNavigation:]):
1138         (-[TestAsyncNavigationDelegate webView:didFailNavigation:withError:]):
1139         (-[TestAsyncNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1140         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1141         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1142         (TestWebKitAPI::TEST):
1143
1144 2018-02-12  John Wilander  <wilander@apple.com>
1145
1146         Resource Load Statistics: Classify resources as prevalent based on redirects to other prevalent resources
1147         https://bugs.webkit.org/show_bug.cgi?id=182664
1148         <rdar://problem/37372572>
1149
1150         Reviewed by Brent Fulgham.
1151
1152         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1153         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1154         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1155         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1156         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1157         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1158         * WebKitTestRunner/TestController.cpp:
1159         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
1160         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
1161         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
1162         * WebKitTestRunner/TestController.h:
1163         * WebKitTestRunner/TestInvocation.cpp:
1164         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1165
1166 2018-02-12  Ross Kirsling  <ross.kirsling@sony.com>
1167
1168         download-latest-github-release .py should not use "browser download URL".
1169         https://bugs.webkit.org/show_bug.cgi?id=182646
1170
1171         Reviewed by Per Arne Vollan.
1172
1173         * Scripts/download-latest-github-release.py:
1174         Download request should be a proper GitHub API call and should actually include the token when applicable.
1175         (Also clean up usage of args and print while we're in here.)
1176
1177 2018-02-12  Per Arne Vollan  <pvollan@apple.com>
1178
1179         EWS should run Windows tests.
1180         https://bugs.webkit.org/show_bug.cgi?id=177967
1181
1182         Reviewed by Lucas Forschler.
1183
1184         This will help catch regressions at an early stage.
1185
1186         * Scripts/webkitpy/common/config/ews.json:
1187
1188 2018-02-08  Ryosuke Niwa  <rniwa@webkit.org>
1189
1190         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
1191         https://bugs.webkit.org/show_bug.cgi?id=182564
1192
1193         Reviewed by Wenson Hsieh.
1194
1195         Added tests for pasting HTML with list items generated by Microsoft Word as well as HTML which looks like
1196         the one generated by Microsoft Word but missing a proper "html" element at the beginning.
1197
1198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1199         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added test cases.
1200         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm: Added test cases.
1201         (msoListMarkupWithoutProperHTMLElement): Added.
1202         * TestWebKitAPI/Tests/WebKitCocoa/mso-list.html: Added.
1203
1204 2018-02-09  Don Olmstead  <don.olmstead@sony.com>
1205
1206         [CMake] Make PAL headers copies
1207         https://bugs.webkit.org/show_bug.cgi?id=182645
1208
1209         Reviewed by Alex Christensen.
1210
1211         * TestWebKitAPI/CMakeLists.txt:
1212
1213 2018-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1214
1215         Pasting from Excel no longer provides text/html data
1216         https://bugs.webkit.org/show_bug.cgi?id=182636
1217         <rdar://problem/37087060>
1218
1219         Reviewed by Ryosuke Niwa.
1220
1221         Add new API tests to exercise pasting images with various other content types on macOS, and when dropping images
1222         and HTML markup on iOS. See the WebCore ChangeLog for more detail.
1223
1224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1225         * TestWebKitAPI/Tests/WebKitCocoa/DataTransfer.html: Added.
1226
1227         Add a new API test harness that dumps various bits of information about a DataTransfer upon paste and drop.
1228         While somewhat similar to some existing harnesses, this makes a distinction between the raw HTML data on the
1229         pasteboard and the actual result of inserting said HTML into the DOM. This allows us to check that the HTML has
1230         been sanitized, while making checks for the actual content of the HTML robust against inline style changes.
1231
1232         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1233         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm: Added.
1234
1235         Add a new test suite to exercise pasting mixed content types. In these test cases, the pasteboard contains a
1236         file, with some combination of plain text, rich text, and URLs.
1237
1238         (imagePath):
1239         (writeTypesAndDataToPasteboard):
1240
1241         Add a helper to write a var-arg list of content types and data to the general NSPasteboard.
1242
1243         (setUpWebView):
1244         (markupString):
1245         (TestWebKitAPI::TEST):
1246         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1247         (TestWebKitAPI::testIconImageData):
1248         (TestWebKitAPI::TEST):
1249         * TestWebKitAPI/cocoa/TestWKWebView.h:
1250
1251         Move a private declaration of -[WKWebView paste:] out to TestWKWebView.h, so that it can be shared across
1252         multiple tests. Currently, it only resides in PasteImage.mm, but I need it in PasteMixedContent.mm as well.
1253
1254 2018-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1255
1256         Add a way to check if a host is an IP address
1257         https://bugs.webkit.org/show_bug.cgi?id=182427
1258
1259         Reviewed by Alex Christensen.
1260
1261         Add unit test for URL::hostIsIPAddress().
1262
1263         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1264         (TestWebKitAPI::TEST_F):
1265
1266 2018-02-09  Philippe Normand  <pnormand@igalia.com>
1267
1268         [GStreamer] Layout test fast/replaced/border-radius-clip.html crashes with GStreamer-CRITICAL **: gst_segment_to_stream_time: assertion 'segment->format == format' failed in gst_segment_to_stream_time()
1269         https://bugs.webkit.org/show_bug.cgi?id=176802
1270
1271         Reviewed by Xabier Rodriguez-Calvar.
1272
1273         * gstreamer/jhbuild.modules:
1274         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Added.
1275
1276 2018-02-09  Philippe Normand  <pnormand@igalia.com>
1277
1278         [JHBuild] Update Mesa to version 17
1279         https://bugs.webkit.org/show_bug.cgi?id=182599
1280
1281         Reviewed by Carlos Alberto Lopez Perez.
1282
1283         * gtk/jhbuild.modules: Update Mesa (and its dependencies, hopefully) to version 17.3.3.
1284
1285 2018-02-08  Chris Dumez  <cdumez@apple.com>
1286
1287         There should be a way to disable [OverrideBuiltins] behavior in a given DOMWrapperWorld
1288         https://bugs.webkit.org/show_bug.cgi?id=182524
1289         <rdar://problem/9057327>
1290
1291         Reviewed by Ryosuke Niwa.
1292
1293         Add API test coverage.
1294
1295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1296         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp: Added.
1297         (TestWebKitAPI::runJavaScriptAlert):
1298         (TestWebKitAPI::TEST):
1299         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp: Added.
1300         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::InjectedBundleDisableOverrideBuiltinsBehaviorTest):
1301         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1302         * TestWebKitAPI/Tests/WebKit/override-builtins-test.html: Added.
1303
1304 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1305
1306         TestController should not exercise cocoa-specific resource load statistics APIs
1307         https://bugs.webkit.org/show_bug.cgi?id=182355
1308
1309         Reviewed by Alex Christensen.
1310
1311         Remove unnecessary use of platform-specific APIs in the TestController, since there are
1312         cross-platform APIs to do the same thing.
1313
1314         Also, ensure callbacks execute before returning from TestController's functions, since
1315         otherwise the tests are guaranteed to be flaky at best, and also since there's nothing to
1316         prevent the TestController from being destroyed before the callbacks execute.
1317
1318         * WebKitTestRunner/TestController.cpp:
1319         (WTR::resourceStatisticsVoidResultCallback):
1320         (WTR::resourceStatisticsBooleanResultCallback):
1321         (WTR::TestController::isStatisticsPrevalentResource):
1322         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1323         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1324         (WTR::TestController::isStatisticsHasHadUserInteraction):
1325         (WTR::TestController::isStatisticsGrandfathered):
1326         (WTR::TestController::statisticsUpdateCookiePartitioning):
1327         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1328         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1329         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1330         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1331         (WTR::resourceStatisticsCallback): Deleted.
1332         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback): Deleted.
1333         * WebKitTestRunner/TestController.h:
1334         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1335         (WTR::toNSString): Deleted.
1336         (WTR::TestController::setStatisticsLastSeen): Deleted.
1337         (WTR::TestController::setStatisticsPrevalentResource): Deleted.
1338         (WTR::TestController::isStatisticsPrevalentResource): Deleted.
1339         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder): Deleted.
1340         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo): Deleted.
1341         (WTR::TestController::setStatisticsHasHadUserInteraction): Deleted.
1342         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
1343         (WTR::TestController::isStatisticsHasHadUserInteraction): Deleted.
1344         (WTR::TestController::setStatisticsGrandfathered): Deleted.
1345         (WTR::TestController::isStatisticsGrandfathered): Deleted.
1346         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin): Deleted.
1347         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin): Deleted.
1348         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo): Deleted.
1349         (WTR::TestController::setStatisticsTimeToLiveUserInteraction): Deleted.
1350         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
1351         (WTR::TestController::statisticsProcessStatisticsAndDataRecords): Deleted.
1352         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
1353         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
1354         (WTR::TestController::statisticsSubmitTelemetry): Deleted.
1355         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned): Deleted.
1356         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval): Deleted.
1357         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured): Deleted.
1358         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval): Deleted.
1359         (WTR::TestController::setStatisticsGrandfatheringTime): Deleted.
1360         (WTR::TestController::setStatisticsMaxStatisticsEntries): Deleted.
1361         (WTR::TestController::setStatisticsPruneEntriesDownTo): Deleted.
1362         (WTR::TestController::statisticsClearInMemoryAndPersistentStore): Deleted.
1363         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): Deleted.
1364         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval): Deleted.
1365         (WTR::TestController::statisticsResetToConsistentState): Deleted.
1366
1367 2018-02-08  Jonathan Bedard  <jbedard@apple.com>
1368
1369         webkit-patch suggest-reviewers dies with AttributeError: 'NoneType' object has no attribute 'revision'
1370         https://bugs.webkit.org/show_bug.cgi?id=182584
1371
1372         Reviewed by Daniel Bates.
1373
1374         It is possible that a specific revision has an empty ChangeLog. In this case, Checkout.commit_info_for_revision
1375         will return 'None'. Checkout.recent_commit_infos_for_files should never return a set with 'None' in it.
1376
1377         * Scripts/webkitpy/common/checkout/checkout.py:
1378         (Checkout.recent_commit_infos_for_files): Remove any empty commit information from the set.
1379         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Add a file which references an empty ChangeLog.
1380
1381 2018-02-08  Matt Lewis  <jlewis3@apple.com>
1382
1383         Unreviewed, rolling out r228261.
1384
1385         This broke an internal build
1386
1387         Reverted changeset:
1388
1389         "Add a way to check if a host is an IP address"
1390         https://bugs.webkit.org/show_bug.cgi?id=182427
1391         https://trac.webkit.org/changeset/228261
1392
1393 2018-02-08  Commit Queue  <commit-queue@webkit.org>
1394
1395         Unreviewed, rolling out r228267, r228268, and r228269.
1396         https://bugs.webkit.org/show_bug.cgi?id=182601
1397
1398         jhbuild socks (Requested by philn on #webkit).
1399
1400         Reverted changesets:
1401
1402         "[JHBuild] Update Mesa to version 17"
1403         https://bugs.webkit.org/show_bug.cgi?id=182599
1404         https://trac.webkit.org/changeset/228267
1405
1406         "Unreviewed, GTK build fix attempt after r228267."
1407         https://trac.webkit.org/changeset/228268
1408
1409         "Unreviewed, final GTK build fix attempt after r228267."
1410         https://trac.webkit.org/changeset/228269
1411
1412 2018-02-08  Philippe Normand  <pnormand@igalia.com>
1413
1414         Unreviewed, final GTK build fix attempt after r228267.
1415
1416         * gtk/jhbuild.modules: sha256sum for libdrm was for the tar.gz archive. Oops.
1417
1418 2018-02-08  Philippe Normand  <pnormand@igalia.com>
1419
1420         Unreviewed, GTK build fix attempt after r228267.
1421
1422         * gtk/jhbuild.modules: Update to libdrm version 2.4.89, Mesa 17 requires at least version 2.4.75.
1423
1424 2018-02-08  Philippe Normand  <pnormand@igalia.com>
1425
1426         [JHBuild] Update Mesa to version 17
1427         https://bugs.webkit.org/show_bug.cgi?id=182599
1428
1429         Reviewed by Carlos Alberto Lopez Perez.
1430
1431         * gtk/jhbuild.modules: Update Mesa to version 17.3.3.
1432
1433 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1434
1435         Add a way to check if a host is an IP address
1436         https://bugs.webkit.org/show_bug.cgi?id=182427
1437
1438         Reviewed by Alex Christensen.
1439
1440         Add unit test for URL::hostIsIPAddress().
1441
1442         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1443         (TestWebKitAPI::TEST_F):
1444
1445 2018-02-07  Tim Horton  <timothy_horton@apple.com>
1446
1447         Evernote device management web view sometimes displays at the wrong scale
1448         https://bugs.webkit.org/show_bug.cgi?id=182590
1449         <rdar://problem/36633687>
1450
1451         Reviewed by Simon Fraser.
1452
1453         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1454         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm.
1455         (-[TestDelegateForScrollView dealloc]):
1456         (TestWebKitAPI::TEST):
1457         (-[WKScrollViewDelegateWithViewForZoomingOverridden viewForZoomingInScrollView:]):
1458         Add a test that failed before the change that ensures that we don't
1459         consult the external delegate for viewForZoomingInScrollView:, and that
1460         we succesfully update the scale even if it matches that of the view
1461         the external delegate returns for viewForZoomingInScrollView:.
1462
1463 2018-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1464
1465         REGRESSION(r226396): File paths are inserted when dropping image files
1466         https://bugs.webkit.org/show_bug.cgi?id=182557
1467         <rdar://problem/37294120>
1468
1469         Reviewed by Ryosuke Niwa.
1470
1471         Tweak some image pasting API tests to ensure that file paths are not inserted when pasting images backed by
1472         file paths on disk.
1473
1474         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1475         (TEST):
1476
1477 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
1478
1479         [GTK] Enable WebKit.GeolocationTransitionTo{High,Low}Accuracy tests
1480         https://bugs.webkit.org/show_bug.cgi?id=125068
1481
1482         Unreviewed test gardening.
1483
1484         They do not appear to have failed since we started running them again in r226944.
1485
1486         * TestWebKitAPI/glib/TestExpectations.json:
1487
1488 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
1489
1490         [GTK] Enable WebKit.InjectedBundleFrameHitTest test
1491         https://bugs.webkit.org/show_bug.cgi?id=120303
1492
1493         Unreviewed test gardening.
1494
1495         It does not appear to have failed since we started running it again in r226944.
1496
1497         * TestWebKitAPI/glib/TestExpectations.json:
1498
1499 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
1500
1501         [GTK] Enable WebKit.ForceRepaint test
1502         https://bugs.webkit.org/show_bug.cgi?id=105532
1503
1504         Unreviewed test gardening.
1505
1506         It does not appear to have failed since we started running it again in r226944.
1507
1508         * TestWebKitAPI/glib/TestExpectations.json:
1509
1510 2018-02-07  Philippe Normand  <pnormand@igalia.com>
1511
1512         [JHBuild] Add libva in moduleset
1513         https://bugs.webkit.org/show_bug.cgi?id=182384
1514
1515         Reviewed by Xabier Rodriguez-Calvar.
1516
1517         * gstreamer/jhbuild.modules: Add libva and disable spurious message output.
1518         * gtk/install-dependencies: Remove libva from dependencies.
1519         * wpe/install-dependencies: Ditto.
1520
1521 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
1522
1523         [GTK] Enable WebKit.NewFirstVisuallyNonEmptyLayoutFrames test
1524         https://bugs.webkit.org/show_bug.cgi?id=85037
1525
1526         Unreviewed test gardening.
1527
1528         It does not appear to have failed since we started running it again in r226944.
1529
1530         * TestWebKitAPI/glib/TestExpectations.json:
1531
1532 2018-02-06  Leo Balter  <leonardo.balter@gmail.com>
1533
1534         Nit fix for ruby script called through Perl
1535         https://bugs.webkit.org/show_bug.cgi?id=182552
1536
1537         Reviewed by Yusuke Suzuki.
1538
1539         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1540         (RunTest262Tests):
1541
1542 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1543
1544         Remove WebCore/ForwardingHeaders directory
1545         https://bugs.webkit.org/show_bug.cgi?id=182347
1546
1547         Reviewed by Keith Miller.
1548
1549         * WebKitTestRunner/TestController.cpp:
1550
1551 2018-02-06  Ross Kirsling  <ross.kirsling@sony.com>
1552
1553         webkit-patch upload should ask for confirmation before creating a new bug
1554         https://bugs.webkit.org/show_bug.cgi?id=182551
1555
1556         Reviewed by Daniel Bates.
1557
1558         It is quite easy to paste unintended text into the bug number prompt. This creates a junk bug with an uneditable
1559         first comment, which could result in embarrassment or potentially even a proprietary information leak.
1560
1561         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1562         (test_prepare):
1563         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
1564         (PromptForBugOrTitle):
1565         (PromptForBugOrTitle.options):
1566         (PromptForBugOrTitle.run):
1567
1568 2018-02-06  Youenn Fablet  <youenn@apple.com>
1569
1570         HasServiceWorkerRegistration bit should be sent when creating a new page
1571         https://bugs.webkit.org/show_bug.cgi?id=182410
1572
1573         Reviewed by Chris Dumez.
1574
1575         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1576
1577 2018-02-06  Andres Gomez  <agomez@igalia.com>
1578
1579         [GTK][WPE] Add dependencies watching lists for WKGTK+ and WPE
1580         https://bugs.webkit.org/show_bug.cgi?id=182346
1581
1582         Reviewed by Michael Catanzaro.
1583
1584         Loren, Carlos and Andres are interested on the WKGTK+ dependencies
1585         watchlist since they are running WKGTK+ EWS.
1586
1587         Similarly, Adrian and Carlos are running a WPE EWS.
1588
1589         * Scripts/webkitpy/common/config/watchlist: Added WPEDependencies
1590           and WebKitGTKDependencies watchlists with the proper people.
1591
1592 2018-02-06  Andres Gomez  <agomez@igalia.com>
1593
1594         Unreviewed, canonicalize contributors.json
1595
1596         After Thibault's addition, automatic checks complain about
1597         contributors.json with:
1598
1599         "[...] Use "validate-committer-lists --canonicalize" to reformat
1600         it. [...]"
1601
1602         * Scripts/webkitpy/common/config/contributors.json: Canonicalize.
1603
1604 2018-02-06  Andres Gomez  <agomez@igalia.com>
1605
1606         Unreviewed, add Lorenzo Tilve to contributors.json
1607
1608         We need to add Loren to the contributors list in order to CC him
1609         in Bugzilla.
1610
1611         * Scripts/webkitpy/common/config/contributors.json: Added Lorenzo
1612           Tilve.
1613
1614 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
1615
1616         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
1617         https://bugs.webkit.org/show_bug.cgi?id=182478
1618
1619         Reviewed by Alex Christensen.
1620
1621         For TestWebKitAPI, sources related to WebKitLegacy are built
1622         at WebKit build. Those files should be reffered for WebKitLegacy build.
1623
1624         * TestWebKitAPI/PlatformWin.cmake:
1625
1626 2018-02-05  Daniel Bates  <dabates@apple.com>
1627
1628         REGRESSION (r217572): run-webkit-tests exits without emitting newline character
1629         https://bugs.webkit.org/show_bug.cgi?id=182360
1630
1631         Rubber-stamped by Aakash Jain.
1632
1633         Fixes an annoyance where run-webkit-tests always exits without printing a newline character.
1634         In the terminal this looks like:
1635
1636             $ Tools/Scripts/run-webkit-tests
1637             Expected to fail, but passed: (7)
1638             ...
1639             Stopping WebSocket server ...$
1640
1641         This bug was caused by code added in r217572 to stop all run-webkit-tests started servers (e.g. an HTTP
1642         server) from an at-exit handler. When run-webkit-tests runs successfully (i.e. without error or
1643         control-C interruption) we would stop all such servers twice: once as part of ending the test
1644         run and once from the at-exit handler. The latter never prints a trailing newline character hence
1645         the state of the terminal (as depicted above). Instead LayoutTestRunner.stop_servers() should only
1646         stop servers that it started in LayoutTestRunner.start_servers().
1647
1648         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1649         (LayoutTestRunner.__init__):
1650         (LayoutTestRunner.start_servers):
1651         (LayoutTestRunner.stop_servers):
1652         Only start servers that run-webkit-tests has not already started and only stop servers that
1653         run-webkit-tests started.
1654
1655         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1656         (LayoutTestRunnerTests.test_servers_started.is_websocket_server_running):
1657         (LayoutTestRunnerTests.test_servers_started):
1658         (LayoutTestRunnerTests.test_servers_started.is_websocket_servers_running): Deleted.
1659         Update due to rename below.
1660
1661         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1662         (is_web_socket_server_running): Added.
1663         (PyWebSocket.is_running): Deleted.
1664
1665         * Scripts/webkitpy/port/base.py:
1666         (Port.is_http_server_running): Check if we already started the server ourself.
1667         (Port.is_websocket_server_running): Formerly named is_websocket_servers_running. Modified
1668         to check if we already started the server ourself. Take a similar approach as the other
1669         Port.is_*_running methods and only check if an existing WebSocket server is running on the
1670         non-secure server port. This is a simple heuristic and should be sufficient in practice.
1671         (Port.is_wpt_server_running): Check if we already started the server ourself.
1672         (Port.is_websocket_servers_running): Deleted; renamed to is_websocket_server_running().
1673
1674 2018-02-05  Daniel Bates  <dabates@apple.com>
1675
1676         prepare-ChangeLog gets confused about Python docstrings that contain the word "class" or "def"
1677         https://bugs.webkit.org/show_bug.cgi?id=182405
1678
1679         Reviewed by David Kilzer.
1680
1681         String literal statements, including docstrings, do not demarcate a new scope in Python.
1682         So, do not treat them like they do when building up the list of modified functions.
1683
1684         * Scripts/prepare-ChangeLog:
1685         (get_function_line_ranges_for_python):
1686         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
1687         The expected ending line number for the last "pass" statement inside the scope of Class5 changed
1688         from 97 to 98 because empty lines do not effect scope. This is consistent with the parsing
1689         of the second "pass" statement in the scope of class Class5. A "pass" is a null operation that
1690         is used as a syntactic placeholder when a statement is required. Ideally we would make
1691         the parsing code smarter so as to avoid emitting ranges for "pass" statements that serve
1692         not syntactic purpose.
1693         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
1694         (Class5):
1695         (Class6):
1696         (Class6.__init__):
1697         (Class7):
1698         (Class7.__init__):
1699         (Class8):
1700         (Class8.__init__):
1701         Add some more tests.
1702
1703 2018-02-05  Matt Lewis  <jlewis3@apple.com>
1704
1705         Unreviewed, rolling out r228086.
1706
1707         This introduced a failure with API test
1708         URLTest.HostIsIPAddress.
1709
1710         Reverted changeset:
1711
1712         "Add a way to check if a host is an IP address"
1713         https://bugs.webkit.org/show_bug.cgi?id=182427
1714         https://trac.webkit.org/changeset/228086
1715
1716 2018-02-05  John Wilander  <wilander@apple.com>
1717
1718         Storage Access API: Add testRunner.getAllStorageAccessEntries() to make testing easier and more explicit
1719         https://bugs.webkit.org/show_bug.cgi?id=181601
1720         <rdar://problem/36475837>
1721
1722         Reviewed by Alex Christensen.
1723
1724         http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html
1725         was found to be flaky. With the testRunner.hasStorageAccessEntry() getter
1726         it's possible to check access even if a frame doesn't respond timely to
1727         postMessage after detach and attach.
1728
1729         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1730         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1731         (WTR::InjectedBundle::didReceiveMessageToPage):
1732         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1733         (WTR::TestRunner::setStorageAccessAPIEnabled):
1734             Just moved for source file grouping.
1735         (WTR::TestRunner::getAllStorageAccessEntries):
1736         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback):
1737         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1738         * WebKitTestRunner/TestController.cpp:
1739         (WTR::TestController::getAllStorageAccessEntries):
1740             Note that this is just stubbed out, i.e. not implemented.
1741         * WebKitTestRunner/TestController.h:
1742         * WebKitTestRunner/TestInvocation.cpp:
1743         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1744         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1745         * WebKitTestRunner/TestInvocation.h:
1746         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1747         (WTR::TestController::getAllStorageAccessEntries):
1748             This is the Cocoa-specific version of this test infrastructure.
1749
1750 2018-02-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1751
1752         [Win] Enable multi CPU building on MSBuild.
1753         https://bugs.webkit.org/show_bug.cgi?id=182446
1754
1755         Compiling itself already uses multi cores, but other stuff is still on single core.
1756         This patch enables that by passing an argument to MSBuild.exe.
1757
1758         Reviewed by Alex Christensen.
1759
1760         * Scripts/webkitdirs.pm:
1761         (determineNumberOfCPUs):
1762         (buildVisualStudioProject):
1763
1764 2018-02-05  Alicia Boya García  <aboya@igalia.com>
1765
1766         Fix bug in MediaTime comparison for negative values with different scale.
1767         https://bugs.webkit.org/show_bug.cgi?id=182433
1768
1769         Improved test coverage for MediaTime::compare().
1770
1771         Reviewed by Xabier Rodriguez-Calvar.
1772
1773         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1774         (TestWebKitAPI::TEST):
1775
1776 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1777
1778         [SOUP] WebSockets must use system proxy settings
1779         https://bugs.webkit.org/show_bug.cgi?id=126384
1780
1781         Reviewed by Michael Catanzaro.
1782
1783         Check also WebSockets in /webkit2/WebKitWebContext/proxy.
1784
1785         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1786         (ProxyTest::webSocketProxyServerCallback):
1787         (ProxyTest::ProxyTest):
1788         (ProxyTest::webSocketConnected):
1789         (ProxyTest::createWebSocketAndWaitUntilConnected):
1790         (webSocketServerCallback):
1791         (testWebContextProxySettings):
1792         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1793         (WebKitTestServer::~WebKitTestServer):
1794         (WebKitTestServer::addWebSocketHandler):
1795         (WebKitTestServer::removeWebSocketHandler):
1796         (WebKitTestServer::getWebSocketURIForPath const):
1797         (WebKitTestServer::getURIForPath const):
1798         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
1799         (WebKitTestServer::baseURI const):
1800         (WebKitTestServer::baseWebSocketURI const):
1801
1802 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1803
1804         Add a way to check if a host is an IP address
1805         https://bugs.webkit.org/show_bug.cgi?id=182427
1806
1807         Reviewed by Alex Christensen.
1808
1809         Add unit test for URL::hostIsIPAddress().
1810
1811         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1812         (TestWebKitAPI::TEST_F):
1813
1814 2018-02-03  Charlie Turner  <cturner@igalia.com>
1815
1816         Add libmount to WPE dependencies
1817         https://bugs.webkit.org/show_bug.cgi?id=182345
1818
1819         Reviewed by Michael Catanzaro.
1820
1821         * wpe/install-dependencies:
1822
1823 2018-02-02  Youenn Fablet  <youenn@apple.com>
1824
1825         W3C test exporter should allow exporting newly added files
1826         https://bugs.webkit.org/show_bug.cgi?id=182369
1827
1828         Reviewed by Ryosuke Niwa.
1829
1830         * Scripts/webkitpy/common/checkout/scm/git.py:
1831         (Git.apply_mail_patch):
1832
1833 2018-02-02  David Quesada  <david_quesada@apple.com>
1834
1835         WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified
1836         https://bugs.webkit.org/show_bug.cgi?id=182363
1837         rdar://problem/37093498
1838
1839         Reviewed by Ryosuke Niwa.
1840
1841         Updated ApplicationManifestParserTests to account for the new default scope behavior.
1842
1843         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1844         (assertManifestHasDefaultValues):
1845         (TEST_F):
1846
1847 2018-02-02  Youenn Fablet  <youenn@apple.com>
1848
1849         Clearing all service worker registrations should wait for importing service worker registration to finish
1850         https://bugs.webkit.org/show_bug.cgi?id=182407
1851
1852         Reviewed by Chris Dumez.
1853
1854         Make sure we finish clearing service worker registrations before running tests.
1855
1856         * WebKitTestRunner/TestController.cpp:
1857         (WTR::TestController::resetStateToConsistentValues):
1858         (WTR::ClearServiceWorkerRegistrationsCallbackContext::ClearServiceWorkerRegistrationsCallbackContext):
1859         (WTR::clearServiceWorkerRegistrationsCallback):
1860         (WTR::TestController::clearServiceWorkerRegistrations):
1861         * WebKitTestRunner/TestController.h:
1862
1863 2018-02-02  Youenn Fablet  <youenn@apple.com>
1864
1865         Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
1866         https://bugs.webkit.org/show_bug.cgi?id=182403
1867
1868         Reviewed by Alex Christensen.
1869
1870         * WebKitTestRunner/TestController.cpp:
1871         (WTR::TestController::generateContextConfiguration const):
1872         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1873         (WTR::initializeWebViewConfiguration):
1874
1875 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1876
1877         [GTK] WebDriver: tests step always times out in the bot
1878         https://bugs.webkit.org/show_bug.cgi?id=182437
1879
1880         Reviewed by Carlos Alberto Lopez Perez.
1881
1882         The process itself is not timing out, but the buildbot step is. This is because we are leaking the Xvfb
1883         processes. We should ensure that only one driver is executed and it's stopped before the process finishes.
1884
1885         * Scripts/run-webdriver-tests: Call teardown() after run().
1886         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1887         (WebDriverSeleniumExecutor.__init__): Receive the env directly instead of the display driver.
1888         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1889         (WebDriverTestRunner.__init__): Use the driver class directly instead of using the DriverProxy. Get the env from
1890         the display driver once and pass it to the test runners.
1891         (WebDriverTestRunner.teardown): Stop the display server.
1892         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1893         (WebDriverTestRunnerSelenium.__init__): Receive the env directly instead of the display driver.
1894         (WebDriverTestRunnerSelenium.collect_tests): Pass the env to the executor.
1895         (WebDriverTestRunnerSelenium.run): Ditto.
1896         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1897         (WebDriverTestRunnerW3C.__init__): Receive the env directly instead of the display driver.
1898         (WebDriverTestRunnerW3C.run): Pass the env to the executor.
1899         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1900         (WebDriverW3CExecutor.__init__): Receive the env directly instead of the display driver.
1901
1902 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1903
1904         Unreviewed, rolling out r227999.
1905
1906         It didn't fix the problem
1907
1908         Reverted changeset:
1909
1910         "Unreviewed. Try to avoid webdriver tests step timing out in
1911         the bots."
1912         https://trac.webkit.org/changeset/227999
1913
1914 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1915
1916         Start timeout for the run-buildbot-test script is too aggressive
1917         https://bugs.webkit.org/show_bug.cgi?id=182429
1918
1919         Reviewed by Carlos Garcia Campos.
1920
1921         15 seconds is not enough waiting for the update database process
1922         to complete on a system backed with rotational HDDs. Raise it to 60.
1923
1924         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
1925         (wait_for_master_ready):
1926
1927 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1928
1929         re-add ARM JSCOnly bots on buildbot waterfall
1930         https://bugs.webkit.org/show_bug.cgi?id=182428
1931
1932         Reviewed by Csaba Osztrogonác.
1933
1934         * BuildSlaveSupport/build.webkit.org-config/config.json:
1935         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1936
1937 2018-02-02  Csaba Osztrogonác  <ossy@webkit.org>
1938
1939         Remove ARM JSCOnly bots from buildbot waterfall
1940         https://bugs.webkit.org/show_bug.cgi?id=182398
1941
1942         Reviewed by Alexey Proskuryakov.
1943
1944         * BuildSlaveSupport/build.webkit.org-config/config.json:
1945         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1946
1947 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1948
1949         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
1950
1951         This is another speculative workaround. Carlos Lopez suggested to use os._exit() instead of sys.exit() as a
1952         workaround for a bug in python2.7 when using multiprocess module.
1953
1954         * Scripts/run-webdriver-tests:
1955
1956 2018-02-01  Youenn Fablet  <youenn@apple.com>
1957
1958         Delay service worker process creation until actually needed by SWServer
1959         https://bugs.webkit.org/show_bug.cgi?id=182301
1960
1961         Reviewed by Chris Dumez.
1962
1963         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1964         (function):
1965
1966 2018-02-01  Aakash Jain  <aakash_jain@apple.com>
1967
1968         Bubbles intermittently disappear from bot watchers dashboard
1969         https://bugs.webkit.org/show_bug.cgi?id=182085
1970
1971         Reviewed by Alexey Proskuryakov.
1972
1973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1974         (BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
1975         Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
1976         confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
1977
1978 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1979
1980         [GTK] Problem with Washington Post images
1981         https://bugs.webkit.org/show_bug.cgi?id=181421
1982
1983         Reviewed by Carlos Alberto Lopez Perez.
1984
1985         Add test case for the new user agent quirk.
1986
1987         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1988         (TestWebKitAPI::TEST):
1989
1990 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1991
1992         [GTK] MiniBrowser settings are just a list of names
1993         https://bugs.webkit.org/show_bug.cgi?id=182005
1994
1995         Reviewed by Sergio Villar Senin.
1996
1997         The default size we are using is too small to show the values column, and the window is not resizable because
1998         GObjectClass::constructed() is not called in the parent class.
1999
2000         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2001         (browser_settings_dialog_init): Use 600x400 as default size.
2002         (browserSettingsDialogConstructed): Chain up to parent constructed.
2003
2004 2018-01-31  Andres Gomez  <agomez@igalia.com>
2005
2006         Unreviewed. Remove WebInspectorUI watchlist and remove myself from 2 watchlists more
2007
2008         * Scripts/webkitpy/common/config/watchlist:
2009
2010 2018-01-31  Per Arne Vollan  <pvollan@apple.com>
2011
2012         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
2013         https://bugs.webkit.org/show_bug.cgi?id=181204
2014         <rdar://problem/36256274>
2015
2016         Reviewed by Ryosuke Niwa.
2017
2018         Implement 'testRunner.forceImmediateCompletion()' for WK1.
2019
2020         * DumpRenderTree/TestRunner.cpp:
2021         (forceImmediateCompletionCallback):
2022         (TestRunner::staticFunctions):
2023
2024 2018-01-31  Alex Christensen  <achristensen@webkit.org>
2025
2026         Unreviewed, rolling out r227942.
2027
2028         r227875 should not have been rolled out.
2029
2030         Reverted changeset:
2031
2032         "Unreviewed, rolling out r227875."
2033         https://bugs.webkit.org/show_bug.cgi?id=182357
2034         https://trac.webkit.org/changeset/227942
2035
2036 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2037
2038         Unreviewed, rolling out r227875.
2039         https://bugs.webkit.org/show_bug.cgi?id=182357
2040
2041         Missing cross-platform TestController implementation
2042
2043         Reverted changeset:
2044
2045         "Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()"
2046         https://bugs.webkit.org/show_bug.cgi?id=181958
2047         https://trac.webkit.org/changeset/227875
2048
2049         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2050         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2051         (WTR::InjectedBundle::didReceiveMessageToPage):
2052         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2053         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2054         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2055         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
2056         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2057         * WebKitTestRunner/TestInvocation.cpp:
2058         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
2059         * WebKitTestRunner/TestInvocation.h:
2060         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2061         (WTR::TestController::statisticsUpdateCookiePartitioning):
2062         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2063
2064 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2065
2066         REGRESSION(r227223): http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html, http/tests/resourceLoadStatistics/grandfathering.html timing out on GTK, WPE
2067         https://bugs.webkit.org/show_bug.cgi?id=182222
2068
2069         Reviewed by Alex Christensen.
2070
2071         Use the new API to notify when resource load statistics deletion is complete.
2072
2073         * WebKitTestRunner/TestController.cpp:
2074         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
2075         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2076         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2077
2078 2018-01-31  Ryosuke Niwa  <rniwa@webkit.org>
2079
2080         Add the support for running StyleBench to run-benchmark
2081         https://bugs.webkit.org/show_bug.cgi?id=182323
2082
2083         Reviewed by Antti Koivisto.
2084
2085         Added the plan file and the patch needed to run StyleBench using run-benchmark as of r227863.
2086
2087         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/StyleBench.patch: Added.
2088         * Scripts/webkitpy/benchmark_runner/data/plans/stylebench.plan: Added.
2089
2090 2018-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
2091
2092         [iOS WK2] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing after an SDK update
2093         https://bugs.webkit.org/show_bug.cgi?id=182339
2094         <rdar://problem/36041396>
2095
2096         Reviewed by Andy Estes.
2097
2098         This API test wasn't meant to be dependent on the size of an image generated using UIImagePNGRepresentation().
2099         To make this test robust against changes to image encoding, write the raw data to the test folder instead and
2100         check against the length of the data written.
2101
2102         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2103         (testIconImageData):
2104         (runTestWithTemporaryFolder):
2105         (TestWebKitAPI::TEST):
2106
2107 2018-01-31  Dan Bernstein  <mitz@apple.com>
2108
2109         [macOS] MiniBrowser isn’t app-sandboxed
2110         https://bugs.webkit.org/show_bug.cgi?id=182147
2111
2112         Reviewed by Sam Weinig.
2113
2114         Enable App Sandbox and add a temporary exception allowing read access to all files.
2115
2116         * MiniBrowser/Configurations/Base.xcconfig: Enabled ad-hoc code signing.
2117         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Specified the entitlements file to use.
2118         * MiniBrowser/MiniBrowser.entitlements: Added. Enables App Sandbox with outbound networking
2119           and read access from /.
2120         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added reference to new file.
2121
2122 2018-01-31  Philippe Normand  <pnormand@igalia.com>
2123
2124         [JHBuild] Add gstreamer-vaapi in moduleset
2125         https://bugs.webkit.org/show_bug.cgi?id=182283
2126
2127         Reviewed by Carlos Alberto Lopez Perez.
2128
2129         GStreamer-VAAPI is required for hardware-accelerated video
2130         playback support on Intel and AMD (using radeosi driver)
2131         platforms.
2132
2133         * gstreamer/jhbuild.modules: Add gstreamer-vaapi.
2134         * gtk/install-dependencies: Install libva.
2135         * wpe/install-dependencies: Ditto.
2136         * Scripts/webkitpy/port/gtk.py:
2137         (GtkPort.setup_environ_for_server): Disable va-api support when
2138         testing because it's incompatible with Mesa's softGL driver.
2139
2140 2018-01-31  Charlie Turner  <cturner@igalia.com>
2141
2142         [WPE] Update jhbuild dependencies
2143         https://bugs.webkit.org/show_bug.cgi?id=182286
2144
2145         This upgrades the following packages,
2146         glib 2.44.1 -> 2.54.3
2147         glib-networking 2.42.0 -> 2.54.1
2148         libsoup 2.48.0 -> 2.60.3
2149
2150         The initial reason for performing these upgrades was that when
2151         visiting https://youtube.com, WPE was getting TLS certificate
2152         errors. After upgrading glib-networking, these were fixed, but the
2153         upgrade introduced dependencies on newer versions of the other
2154         packages upgraded in this commit.
2155
2156         The upgrade to glib caused a linking error in gstreamer, the
2157         following errors were being logged during linking,
2158
2159         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_from_script'
2160         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_get_unicode_funcs'
2161         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_to_script'
2162
2163         This was fixed by adding the glib package built in the jhbuild to
2164         harfbuzz.
2165
2166         Finally, the upgrade of glib caused the glib-warning-fix.patch to
2167         no longer apply, so this patch was removed.
2168
2169         Reviewed by Michael Catanzaro.
2170
2171         * wpe/jhbuild.modules: Added dependecies.
2172         * wpe/patches/glib-warning-fix.patch: Removed.
2173
2174 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2175
2176         Unreviewed, rolling out r227782.
2177
2178         It didn't fix the problem
2179
2180         Reverted changeset:
2181
2182         "Unreviewed. Try to avoid webdriver tests step timing out in
2183         the bots."
2184         https://trac.webkit.org/changeset/227782
2185
2186 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2187
2188         WebDriver: add domains to server config in w3c tests
2189         https://bugs.webkit.org/show_bug.cgi?id=182294
2190
2191         Reviewed by Carlos Alberto Lopez Perez.
2192
2193         Several cookie tests expect server_config to have a domains key.
2194
2195         Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie
2196                imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_session_cookie_with_leading_dot_character_in_domain
2197
2198         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2199         (WebDriverW3CExecutor.__init__):
2200
2201 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2202
2203         Unreviewed. Update W3C WebDriver imported tests.
2204
2205         Show full pytest failure logs.
2206
2207         pytest truncates long lists when printing a failed assertion.
2208         This is not great for debugging and arguably it should be the
2209         default to show the full diff when comparing lists.
2210
2211         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2212         (run):
2213
2214 2018-01-30  John Wilander  <wilander@apple.com>
2215
2216         Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()
2217         https://bugs.webkit.org/show_bug.cgi?id=181958
2218         https://bugs.webkit.org/show_bug.cgi?id=182072
2219         <rdar://problem/36801804>
2220         <rdar://problem/36845795>
2221
2222         Reviewed by Brent Fulgham.
2223
2224         Because of the asynchronous nature of XPC and cookies,
2225         we need callbacks in these TestRunner functions so that
2226         the layout tests can wait for state changes to finish
2227         before checking test conditions.
2228
2229         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2230         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2231         (WTR::InjectedBundle::didReceiveMessageToPage):
2232         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2233         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2234         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2235         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback):
2236         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2237         * WebKitTestRunner/TestInvocation.cpp:
2238         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost):
2239         * WebKitTestRunner/TestInvocation.h:
2240         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2241         (WTR::TestController::statisticsUpdateCookiePartitioning):
2242         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2243
2244 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2245
2246         [webkitpy] Config file for apache is copied twice.
2247         https://bugs.webkit.org/show_bug.cgi?id=182131
2248
2249         Reviewed by Daniel Bates.
2250
2251         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2252         (LayoutTestApacheHttpd.__init__):
2253         (LayoutTestApacheHttpd._copy_apache_config_file):
2254         (LayoutTestApacheHttpd._get_apache_config_file_path): Deleted.
2255
2256 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
2257
2258         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
2259         https://bugs.webkit.org/show_bug.cgi?id=182312
2260
2261         Reviewed by Michael Catanzaro.
2262
2263         * DumpRenderTree/config.h:
2264         * TestWebKitAPI/config.h:
2265         * WebKitTestRunner/config.h:
2266
2267 2018-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2268
2269         [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
2270         https://bugs.webkit.org/show_bug.cgi?id=182307
2271         <rdar://problem/36041485>
2272
2273         Reviewed by Ryosuke Niwa.
2274
2275         Adjusts a failing API test that we forgot to rebaseline after r223440, which ensures that the result of reading
2276         "text/html" from the DataTransfer is sanitized markup. To do this, teach the test harness
2277         (dump-datatransfer-types.html) to ignore inline styles in markup if a flag is set, and then set that flag in
2278         UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations.
2279
2280         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
2281         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2282         (TestWebKitAPI::TEST):
2283
2284 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
2285
2286         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
2287         https://bugs.webkit.org/show_bug.cgi?id=182284
2288
2289         Reviewed by Michael Catanzaro.
2290
2291         * gtk/manifest.txt.in: Added ThirdParty/openvr to exclusions.
2292         * wpe/manifest.txt.in: Ditto.
2293
2294 2018-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2295
2296         Unreviewed, try to fix JSCOnly build
2297         https://bugs.webkit.org/show_bug.cgi?id=177202
2298
2299         * CMakeLists.txt:
2300
2301 2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2302
2303         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
2304
2305         The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
2306         after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
2307         file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
2308         creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
2309
2310         * Scripts/run-webdriver-tests:
2311         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2312         (WebDriverTestRunner.dump_results_to_json_file):
2313
2314 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2315
2316         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
2317         https://bugs.webkit.org/show_bug.cgi?id=177202
2318
2319         Reviewed by Alex Christensen.
2320
2321         * CMakeLists.txt:
2322
2323 2018-01-29  Alex Christensen  <achristensen@webkit.org>
2324
2325         Clean up API after bugs 178240 and 176474
2326         https://bugs.webkit.org/show_bug.cgi?id=182259
2327
2328         Reviewed by Dan Bernstein.
2329
2330         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2331         (TEST):
2332         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
2333
2334 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
2335
2336         [WebAuthN] Add a compile-time feature flag
2337         https://bugs.webkit.org/show_bug.cgi?id=182211
2338         <rdar://problem/36936365>
2339
2340         Reviewed by Brent Fulgham.
2341
2342         * Scripts/webkitperl/FeatureList.pm:
2343         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2344
2345 2018-01-29  Brady Eidson  <beidson@apple.com>
2346
2347         Make the API test added in r227737 be Mac-only.
2348
2349         Unreviewed gardening.
2350
2351         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
2352
2353 2018-01-29  Matt Lewis  <jlewis3@apple.com>
2354
2355         Unreviewed, rolling out r227731.
2356
2357         This caused and assertion failure in API tests.
2358
2359         Reverted changeset:
2360
2361         "Layout Test fast/events/beforeunload-dom-manipulation-
2362         crash.html is crashing"
2363         https://bugs.webkit.org/show_bug.cgi?id=181204
2364         https://trac.webkit.org/changeset/227731
2365
2366 2018-01-29  Youenn Fablet  <youenn@apple.com>
2367
2368         WPT test exporter should add WebKit export in its PR description
2369         https://bugs.webkit.org/show_bug.cgi?id=182246
2370
2371         Reviewed by Chris Dumez.
2372
2373         Updating PR description body to contain the words 'WebKit export'.
2374         That way, WPT PR bot will mark the PR as reviewed downstream.
2375
2376         * Scripts/webkitpy/w3c/test_exporter.py:
2377         (TestExporter.__init__):
2378         (TestExporter.make_pull_request):
2379         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
2380         (TestExporterTest.test_export):
2381
2382 2018-01-29  Ryosuke Niwa  <rniwa@webkit.org>
2383
2384         Add the support for running Speedometer 2.0 to run-benchmark
2385         https://bugs.webkit.org/show_bug.cgi?id=182231
2386
2387         Reviewed by Antti Koivisto.
2388
2389         Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
2390         aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
2391         requires aggregating the geometric mean out of total time spent in each suite.
2392
2393         Also added --show-iteration-values to show individual measured values in each iteration.
2394
2395         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2396         (BenchmarkResults.format): Added show_iteration_values as an option.
2397         (BenchmarkResults._format_tests): Ditto.
2398         (BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
2399         when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
2400         is easily parsable as a JSON array.
2401         (BenchmarkResults._format_values.format_scaled): Added. A helper function.
2402         (BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
2403         the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
2404         had exactly one aggregator.
2405         (BenchmarkResults._lint_results):
2406         (BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
2407         test's name only when the parent test had an aggregator, by self-explanatory parent_test and
2408         parent_aggregator_list.
2409         (BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
2410         its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
2411         (BenchmarkResults._lint_configuration):
2412         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
2413         (test_format_values_with_no_unit_scaling): Added.
2414         (test_format_values_with_iteration_values): Added.
2415         (test_format_values_with_no_unit_scaling_and_iteration_values): Added.
2416         (test_aggregate_results_from_another_aggregator): Added.
2417         (test_lint_results): Added a test case.
2418         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2419         (BenchmarkRunner.__init__): Added show_iteration_values as an argument.
2420         (BenchmarkRunner._run_benchmark): Ditto.
2421         (BenchmarkRunner.show_results): Ditto.
2422         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
2423         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
2424         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2425         (parse_args): Added --show-iteration-values as a boolean argument.
2426         (run_benchmark_plan): Ditto.
2427         (start): Ditto.
2428         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2429         (WebServerBenchmarkRunner.__init__): Ditto.
2430
2431 2018-01-29  Brady Eidson  <beidson@apple.com>
2432
2433         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
2434         https://bugs.webkit.org/show_bug.cgi?id=182229
2435
2436         Reviewed by Chris Dumez.
2437
2438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2439         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
2440
2441 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2442
2443         WebDriver: properly recover w3c tests after a webdriver server crash
2444         https://bugs.webkit.org/show_bug.cgi?id=182242
2445
2446         Reviewed by Carlos Alberto Lopez Perez.
2447
2448         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
2449         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
2450         relaunching the server after every test failure, because other failures, even when not crashing the server,
2451         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
2452         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
2453
2454         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2455         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
2456         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2457         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
2458         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
2459         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
2460         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
2461         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
2462
2463 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
2464
2465         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
2466         https://bugs.webkit.org/show_bug.cgi?id=181204
2467         <rdar://problem/36256274>
2468
2469         Reviewed by Ryosuke Niwa.
2470
2471         Implement 'testRunner.forceImmediateCompletion()' for WK1.
2472
2473         * DumpRenderTree/TestRunner.cpp:
2474         (forceImmediateCompletionCallback):
2475         (TestRunner::staticFunctions):
2476
2477 2018-01-29  Frederic Wang  <fwang@igalia.com>
2478
2479         Unreviewed, add myself to some watch lists.
2480
2481         * Scripts/webkitpy/common/config/watchlist:
2482
2483 2018-01-27  Dan Bernstein  <mitz@apple.com>
2484
2485         HaveInternalSDK includes should be "#include?"
2486         https://bugs.webkit.org/show_bug.cgi?id=179670
2487
2488         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2489
2490 2018-01-26  Chris Dumez  <cdumez@apple.com>
2491
2492         Make sure service worker code does not launch a StorageProcess unnecessarily
2493         https://bugs.webkit.org/show_bug.cgi?id=182192
2494         <rdar://problem/36927427>
2495
2496         Reviewed by Geoffrey Garen.
2497
2498         Add API test coverage.
2499
2500         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2501
2502 2018-01-26  Chris Dumez  <cdumez@apple.com>
2503
2504         Offlined content does not work for apps on home screen
2505         https://bugs.webkit.org/show_bug.cgi?id=182070
2506         <rdar://problem/36843906>
2507
2508         Reviewed by Youenn Fablet.
2509
2510         Add API test coverage to make sure an already registered service worker is able to intercept
2511         the very first load.
2512
2513         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2514         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
2515
2516 2018-01-26  Chris Nardi  <cnardi@chromium.org>
2517
2518         Addressing post-review comments after r226614
2519         https://bugs.webkit.org/show_bug.cgi?id=182151
2520
2521         Reviewed by Myles C. Maxfield.
2522
2523         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
2524         (TestWebKitAPI::TEST):
2525
2526 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
2527
2528         Unreviewed, rolling out r224920.
2529
2530         Some Win EWS bots are not coming back up after starting reboot.
2531
2532         * EWSTools/start-queue-win.sh:
2533
2534 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2535
2536         WebDriver: simplify the tests json report
2537         https://bugs.webkit.org/show_bug.cgi?id=182171
2538
2539         Reviewed by Carlos Alberto Lopez Perez.
2540
2541         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
2542         form the subtest name. We should do the same for simplicity and compatibility with WPT.
2543
2544         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2545         (WebDriverTestRunner.dump_results_to_json_file):
2546
2547 2018-01-25  Alex Christensen  <achristensen@webkit.org>
2548
2549         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
2550         https://bugs.webkit.org/show_bug.cgi?id=182152
2551
2552         Reviewed by Joseph Pecoraro.
2553
2554         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2555         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2556         (TEST):
2557
2558 2018-01-25  Youenn Fablet  <youenn@apple.com>
2559
2560         WebPluginInfoProvider should handle null host queries
2561         https://bugs.webkit.org/show_bug.cgi?id=182112
2562
2563         Reviewed by Chris Dumez.
2564
2565         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
2566         (TEST):
2567
2568 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2569
2570         [webkitpy] Stop modifying path information only when running on Cygwin
2571         https://bugs.webkit.org/show_bug.cgi?id=182136
2572
2573         On LayoutTestApacheHttpd, some path configuration is modified when platform
2574         is Windows. This modification is only required for AppleWin running on Cygwin.
2575         WinCairo uses native Windows environment, so the condition should be changed.
2576
2577         Reviewed by Per Arne Vollan.
2578
2579         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2580         (LayoutTestApacheHttpd.__init__):
2581         (LayoutTestApacheHttpd._get_apache_config_file_path):
2582
2583 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
2584
2585         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
2586         https://bugs.webkit.org/show_bug.cgi?id=182038
2587         <rdar://problem/36812083>
2588
2589         Reviewed by Jer Noble.
2590
2591         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2592         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
2593
2594 2018-01-24  Daniel Bates  <dabates@apple.com>
2595
2596         webkit-patch upload emits irrelevant simulator warnings
2597         https://bugs.webkit.org/show_bug.cgi?id=181702
2598         <rdar://problem/36556359>
2599
2600         Reviewed by Aakash Jain.
2601
2602         Remove warning when a person explicitly passes --child-processes with a value greater than
2603         the default number of simulator instances webkitpy would have used had --child-processes
2604         been omitted. Moreover, the placement of the warning logic to support printing such a message
2605         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
2606
2607         By default, webkitpy will parallelize running tests using the maximum number of simulator
2608         instances that can be supported based on available system resources at the time run-webkit-tests
2609         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
2610         by specifying --child-processes knows what they are doing. The effects of picking a large
2611         value be obvious, the system may become sluggish.
2612
2613         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
2614         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
2615
2616         * Scripts/webkitpy/port/ios_simulator.py:
2617         (IOSSimulatorPort.__init__):
2618
2619 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
2620
2621         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
2622         https://bugs.webkit.org/show_bug.cgi?id=182102
2623
2624         Reviewed by Carlos Garcia Campos.
2625
2626         * MiniBrowser/gtk/main.c:
2627         (main): Removed the call to set_enable_webvr().
2628
2629 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2630
2631         WebDriver: add support for slow tests
2632         https://bugs.webkit.org/show_bug.cgi?id=182095
2633
2634         Reviewed by Carlos Alberto Lopez Perez.
2635
2636         Add timeout mark to slow tests.
2637
2638         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2639         (TestExpectationsMarker.__init__): Save the timeout.
2640         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
2641         (run): Pass timeout to TestExpectationsMarker constructor.
2642
2643 2018-01-24  Alex Christensen  <achristensen@webkit.org>
2644
2645         Gracefully recover from NetworkProcess crashes in private browsing
2646         https://bugs.webkit.org/show_bug.cgi?id=182073
2647         <rdar://problem/36572023>
2648
2649         Reviewed by Geoff Garen.
2650
2651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2652         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
2653         (-[CrashDelegate webView:didFinishNavigation:]):
2654         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
2655         (-[CrashDelegate webView:didFailNavigation:withError:]):
2656         (TEST):
2657
2658 2018-01-24  Ali Juma  <ajuma@chromium.org>
2659
2660         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
2661         https://bugs.webkit.org/show_bug.cgi?id=182052
2662
2663         Reviewed by Simon Fraser.
2664
2665         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
2666         immediately.
2667
2668         Test: fast/visual-viewport/viewport-dimensions.html
2669
2670         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2671         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2672
2673 2018-01-24  Alex Christensen  <achristensen@webkit.org>
2674
2675         Remove pre-Sierra-OS-specific code in Tools
2676         https://bugs.webkit.org/show_bug.cgi?id=182034
2677
2678         Reviewed by Tim Horton.
2679
2680         * DumpRenderTree/mac/DumpRenderTree.mm:
2681         (setDefaultsToConsistentValuesForTesting):
2682         * MiniBrowser/mac/BrowserWindowController.m:
2683         (-[BrowserWindowController windowDidLoad]):
2684         (-[BrowserWindowController share:]):
2685         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2686         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
2687         (-[EventStreamPlayer playbackTimerFired:]):
2688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2689         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
2690         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
2691         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2692         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2693         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2694         (WTR::InjectedBundle::platformInitialize):
2695         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2696         (WTR::initializeWebViewConfiguration):
2697
2698 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
2699
2700         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
2701         https://bugs.webkit.org/show_bug.cgi?id=181400
2702         <rdar://problem/36358768>
2703
2704         Reviewed by Joseph Pecoraro.
2705
2706         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
2707
2708         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
2709         Always disable poisoning when running with --leaks, as this should work locally,
2710         not just on bots.
2711
2712 2018-01-24  Daniel Bates  <dabates@apple.com>
2713
2714         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
2715         https://bugs.webkit.org/show_bug.cgi?id=181993
2716         <rdar://problem/36421080>
2717
2718         Reviewed by David Hyatt.
2719
2720         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
2721         as we no longer support this strategy.
2722
2723         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
2724
2725 2018-01-24  David Kilzer  <ddkilzer@apple.com>
2726
2727         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
2728         <https://webkit.org/b/182015>
2729         <rdar://problem/36449728>
2730
2731         Reviewed by Tim Horton.
2732
2733         * Scripts/webkitpy/style/checkers/cpp.py:
2734         (regex_for_lambdas_and_blocks): Update regex to include
2735         optional return type for block argument in Objective-C.
2736         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2737         (WebKitStyleTest.test_braces): Add test.
2738
2739 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
2740
2741         WPE-focused test gardening.
2742         https://bugs.webkit.org/show_bug.cgi?id=182051
2743
2744         Unreviewed test gardening.
2745
2746         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
2747
2748 2018-01-23  Mark Lam  <mark.lam@apple.com>
2749
2750         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
2751         https://bugs.webkit.org/show_bug.cgi?id=182017
2752         <rdar://problem/36795513>
2753
2754         Reviewed by Filip Pizlo and JF Bastien.
2755
2756         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2757         (TestWebKitAPI::TEST):
2758         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2759         (TestWebKitAPI::TEST):
2760         (TestWebKitAPI::passWithRef):
2761         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2762         (TestWebKitAPI::TEST):
2763         (TestWebKitAPI::f1):
2764         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2765         (TestWebKitAPI::TEST):
2766         (TestWebKitAPI::poisonedPtrFoo):
2767         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2768         (TestWebKitAPI::TEST):
2769         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2770         (TestWebKitAPI::TEST):
2771
2772 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
2773
2774         [WebVR] Add OpenVR to the tree and to the build
2775         https://bugs.webkit.org/show_bug.cgi?id=177298
2776
2777         Reviewed by Žan Doberšek.
2778
2779         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
2780         with reduced style checks.
2781
2782 2018-01-24  Chris Nardi  <cnardi@chromium.org>
2783
2784         Add Chris Nardi to contributors list
2785         https://bugs.webkit.org/show_bug.cgi?id=182029
2786
2787         Reviewed by Antti Koivisto.
2788
2789         * Scripts/webkitpy/common/config/contributors.json:
2790
2791 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2792
2793         Mac Sierra perf bots have been failing due to CG errors
2794         https://bugs.webkit.org/show_bug.cgi?id=181955
2795
2796         Reviewed by Antti Koivisto.
2797
2798         Ignore the CoreGraphics error messages on macOS Sierra.
2799
2800         Also added tests for ignoring lines in stdout and stderr.
2801
2802         * Scripts/webkitpy/performance_tests/perftest.py:
2803         (PerfTest.run_failed): Refactored for clarity.
2804         (PerfTest):
2805         (PerfTest.filter_ignored_lines): Added.
2806         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
2807         are now used to ignore lines in other kinds of tests than parser tests.
2808         (PerfTest._errors_to_ignore_in_sierra): Added.
2809         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
2810         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2811         (test_parse_output_with_ignored_stdout): Added.
2812         (test_parse_output_with_ignored_stderr): Added.
2813         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
2814
2815 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
2816
2817         Resign NowPlaying status when no media element is eligible
2818         https://bugs.webkit.org/show_bug.cgi?id=181914
2819         <rdar://problem/35294116>
2820
2821         Reviewed by Jer Noble.
2822
2823         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2824         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
2825         (TestWebKitAPI::TEST):
2826         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
2827
2828 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2829
2830         [WinCairo] Use 64-bit toolset
2831         https://bugs.webkit.org/show_bug.cgi?id=181979
2832
2833         Reviewed by Alex Christensen.
2834
2835         Use 64-bit toolset for 64-bit build in order to improve build time. 
2836
2837         * Scripts/webkitdirs.pm:
2838         (generateBuildSystemFromCMakeProject):
2839
2840 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
2841
2842         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
2843         https://bugs.webkit.org/show_bug.cgi?id=181741
2844         rdar://problem/36593581
2845
2846         Reviewed by Tim Horton.
2847         
2848         If zoomToScale:animated: is called with the current zoom level, call the callback
2849         rather than doing nothing.
2850
2851         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2852         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2853
2854 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2855
2856         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
2857         https://bugs.webkit.org/show_bug.cgi?id=180820
2858
2859         Reviewed by David Kilzer.
2860
2861         * Scripts/webkitpy/common/checkout/scm/git.py:
2862         (Git.in_working_directory):
2863         (Git.clone):
2864         (Git.read_git_config):
2865         (Git.apply_reverse_diff):
2866         * Scripts/webkitpy/common/checkout/scm/scm.py:
2867         (SCM.run):
2868         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2869         * Scripts/webkitpy/common/checkout/scm/svn.py:
2870         (SVNRepository.has_authorization_for_realm):
2871         * Scripts/webkitpy/common/net/credentials_unittest.py:
2872         * Scripts/webkitpy/common/system/abstractexecutive.py:
2873         (AbstractExecutive.run_command):
2874         * Scripts/webkitpy/common/system/executive.py:
2875         (Executive.kill_process.is):
2876         (Executive.running_pids):
2877         (Executive.kill_all):
2878         (Executive.run_command):
2879         * Scripts/webkitpy/common/system/executive_mock.py:
2880         (MockExecutive.run_command):
2881         (MockExecutive2.run_command):
2882         * Scripts/webkitpy/common/system/executive_unittest.py:
2883         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
2884         * Scripts/webkitpy/common/system/platforminfo.py:
2885         (PlatformInfo.xcode_sdk_version):
2886         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2887         (Lighttpd._check_and_kill):
2888         * Scripts/webkitpy/port/base.py:
2889         (Port._symbols_string):
2890         * Scripts/webkitpy/port/gtk.py:
2891         (GtkPort.setup_environ_for_server):
2892         * Scripts/webkitpy/port/win.py:
2893         (WinPort._runtime_feature_list):
2894         (WinPort.read_registry_value):
2895         * Scripts/webkitpy/port/win_unittest.py:
2896         (WinPortTest.test_runtime_feature_list):
2897         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2898         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
2899
2900 2018-01-23  Commit Queue  <commit-queue@webkit.org>
2901
2902         Unreviewed, rolling out r227279 and r227373.
2903         https://bugs.webkit.org/show_bug.cgi?id=181988
2904
2905         The LayoutTest crash fix introduced an API test failure.
2906         (Requested by ryanhaddad on #webkit).
2907
2908         Reverted changesets:
2909
2910         "Resign NowPlaying status when no media element is eligible"
2911         https://bugs.webkit.org/show_bug.cgi?id=181914
2912         https://trac.webkit.org/changeset/227279
2913
2914         "Resign NowPlaying status when no media element is eligible"
2915         https://bugs.webkit.org/show_bug.cgi?id=181914
2916         https://trac.webkit.org/changeset/227373
2917
2918 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2919
2920         Unreviewed. Add test case for slow in test_expectations.py.
2921
2922         I forgot to also check slow tests in test_expectations.py unit tests.
2923
2924         * Scripts/webkitpy/common/test_expectations_unittest.py:
2925         (assert_slow):
2926         (test_build_type):
2927         (test_slow):
2928
2929 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2930
2931         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
2932
2933         * TestWebKitAPI/glib/TestExpectations.json:
2934
2935 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2936
2937         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
2938         https://bugs.webkit.org/show_bug.cgi?id=181616
2939         <rdar://problem/36484908>
2940
2941         Reviewed by Wenson Hsieh.
2942
2943         Added tests to make sure we sanitize plain HTML, not just web archives,
2944         when and only when custom pasteboard data is enabled.
2945
2946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2947         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
2948         (writeHTMLToPasteboard): Added.
2949         (createWebViewWithCustomPasteboardDataSetting): Added.
2950
2951 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
2952
2953         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
2954         https://bugs.webkit.org/show_bug.cgi?id=181400
2955         rdar://problem/36358768
2956
2957         Reviewed by JF Bastien.
2958
2959         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
2960
2961 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2962
2963         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
2964         https://bugs.webkit.org/show_bug.cgi?id=181929
2965
2966         Reviewed by Michael Catanzaro.
2967
2968         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
2969         the website data completion callback is not called immediately, and a new file is created when the operation
2970         finishes. We need to check that the file was removing after calling clear.
2971
2972         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2973         (fileChangedCallback):
2974         (testWebsiteDataResourceLoadStatistics):
2975
2976 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2977
2978         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
2979
2980         * TestWebKitAPI/glib/TestExpectations.json:
2981
2982 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2983
2984         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
2985
2986         Partially revert r226782, the fix was wrong for the GLib version we currently use.
2987
2988         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2989         (testWebKitConsoleMessageNetworkError):
2990
2991 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2992
2993         Unreviewed. Remove unused verbose mode from GLib API tests runner.
2994
2995         * glib/api_test_runner.py:
2996         (add_options):
2997
2998 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2999
3000         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
3001         https://bugs.webkit.org/show_bug.cgi?id=181918
3002
3003         Reviewed by Tim Horton.
3004
3005         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
3006
3007         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3008
3009 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
3010
3011         Resign NowPlaying status when no media element is eligible
3012         https://bugs.webkit.org/show_bug.cgi?id=181914
3013         <rdar://problem/35294116>
3014
3015         Reviewed by Jer Noble.
3016
3017         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
3018         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
3019         (TestWebKitAPI::TEST):
3020         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
3021
3022 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
3023
3024         Fix broken unit-tests after r227192
3025         https://bugs.webkit.org/show_bug.cgi?id=181909
3026
3027         Reviewed by Carlos Garcia Campos.
3028
3029         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3030
3031 2018-01-20  Chris Dumez  <cdumez@apple.com>
3032
3033         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
3034         https://bugs.webkit.org/show_bug.cgi?id=174984
3035         <rdar://problem/33665676>
3036
3037         Reviewed by Alexey Proskuryakov.
3038
3039         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
3040
3041         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
3042         (TEST):
3043
3044 2018-01-20  Brian Burg  <bburg@apple.com>
3045
3046         WebDriver: fix some nits that prevent running W3C tests on Mac
3047         https://bugs.webkit.org/show_bug.cgi?id=181864
3048
3049         Reviewed by Carlos Garcia Campos.
3050
3051         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
3052         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
3053         as we assume that the property exists later.
3054
3055         (WebDriverW3CWebServer.stop): If the temporary file doesn't
3056         exist for some reason, the remove call will raise and exception.
3057         Gracefully handle the case where the file isn't created due to
3058         a problem/exception that happened elsewhere.
3059
3060 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
3061
3062         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
3063         https://bugs.webkit.org/show_bug.cgi?id=181881
3064
3065         Reviewed by Alexey Proskuryakov.
3066
3067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3068         (BubbleQueueServer):
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3070         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3071         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
3072
3073 2018-01-19  Youenn Fablet  <youenn@apple.com>
3074
3075         Do not go to the storage process when registering a service worker client if there is no service worker registered
3076         https://bugs.webkit.org/show_bug.cgi?id=181740
3077         <rdar://problem/36650400>
3078
3079         Reviewed by Chris Dumez.
3080
3081         Add support for internals inside API tests.
3082
3083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3084         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
3085         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
3086         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
3087         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
3088         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
3089         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3090         (setConfigurationInjectedBundlePath):
3091         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
3092
3093 2018-01-19  John Wilander  <wilander@apple.com>
3094
3095         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
3096         https://bugs.webkit.org/show_bug.cgi?id=181822
3097         https://bugs.webkit.org/show_bug.cgi?id=175263
3098         https://bugs.webkit.org/show_bug.cgi?id=178536
3099         https://bugs.webkit.org/show_bug.cgi?id=181223
3100         https://bugs.webkit.org/show_bug.cgi?id=181482
3101         <rdar://problem/33491222>
3102         <rdar://problem/33805293>
3103         <rdar://problem/36332683>
3104         <rdar://problem/36549026>
3105
3106         Reviewed by Alex Christensen.
3107
3108         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3109         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3110         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
3111         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3112         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3113         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3114         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
3115         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3116
3117 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
3118
3119         run-webkit-tests fails when there is a curly brace in Xcode build output
3120         https://bugs.webkit.org/show_bug.cgi?id=181254
3121         <rdar://problem/36453374>
3122
3123         Reviewed by Daniel Bates.
3124
3125         * Scripts/webkitpy/port/base.py:
3126         (Port._run_script): Encode script output before logging it.
3127
3128 2018-01-19  Chris Dumez  <cdumez@apple.com>
3129
3130         Service worker registrations restored from disk may not be reused when the JS calls register() again
3131         https://bugs.webkit.org/show_bug.cgi?id=181810
3132         <rdar://problem/36591711>
3133
3134         Reviewed by Youenn Fablet.
3135
3136         Add API test coverage.
3137
3138         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3139         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
3140         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
3141
3142 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
3143
3144         Remove El Capitan queues from flakiness dashboard
3145         https://bugs.webkit.org/show_bug.cgi?id=181860
3146
3147         Reviewed by Aakash Jain.
3148
3149         * TestResultServer/static-dashboards/builders.jsonp:
3150
3151 2018-01-19  Keith Miller  <keith_miller@apple.com>
3152
3153         HaveInternalSDK includes should be "#include?"
3154         https://bugs.webkit.org/show_bug.cgi?id=179670
3155
3156         Reviewed by Dan Bernstein.
3157
3158         * MiniBrowser/Configurations/Base.xcconfig:
3159         * MobileMiniBrowser/Configurations/Base.xcconfig:
3160         * TestWebKitAPI/Configurations/Base.xcconfig:
3161         * WebKitTestRunner/Configurations/Base.xcconfig:
3162
3163 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3164
3165         WebDriver: driver environment not passed to pytest when running w3c tests
3166         https://bugs.webkit.org/show_bug.cgi?id=181852
3167
3168         Reviewed by Carlos Alberto Lopez Perez.
3169
3170         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
3171
3172         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
3173         (WebDriverW3CExecutor.run):
3174
3175 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3176
3177         [GTK] WebDriver: wayland display no used in wayland bot
3178         https://bugs.webkit.org/show_bug.cgi?id=181851
3179
3180         Reviewed by Carlos Alberto Lopez Perez.
3181
3182         We need to handle the additionalArguments property in the WebDriverTests step.
3183
3184         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3185         (RunWebDriverTests.start):
3186
3187 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3188
3189         [GTK] TERM environment variable is not passed to the test driver.
3190         https://bugs.webkit.org/show_bug.cgi?id=181847
3191
3192         Rubber-stamped by by Carlos Garcia Campos.
3193
3194         * Scripts/webkitpy/port/base.py:
3195         (Port.to.setup_environ_for_server):
3196
3197 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3198
3199         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
3200         https://bugs.webkit.org/show_bug.cgi?id=181844
3201
3202         Reviewed by Carlos Alberto Lopez Perez.
3203
3204         We always try to create the directory where to store the json file, but when the filename is given directly,
3205         like in the bots, the current dir is used.
3206
3207         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3208         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
3209         empty string.
3210
3211 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3212
3213         [GTK] WebDriver tests are running outside the jhbuild env
3214         https://bugs.webkit.org/show_bug.cgi?id=181842
3215
3216         Reviewed by Žan Doberšek.
3217
3218         We need to enter jhbuild env in run-webdriver-tests.
3219
3220         * Scripts/run-webdriver-tests:
3221
3222 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3223
3224         [GTK] Run WebDriver tests in the bots
3225         https://bugs.webkit.org/show_bug.cgi?id=181787
3226
3227         Reviewed by Michael Catanzaro.
3228
3229         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
3230         factory for the GTK port for now.
3231
3232         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3233         (TestFactory.__init__):
3234         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3235         (RunWebDriverTests):
3236         (RunWebDriverTests.start):
3237         (RunWebDriverTests.commandComplete):
3238         (RunWebDriverTests.evaluateCommand):
3239         (RunWebDriverTests.getText):
3240         (RunWebDriverTests.getText2):
3241
3242 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3243
3244         [WinCairo] Pass correct url for http test to test driver.
3245         https://bugs.webkit.org/show_bug.cgi?id=181814
3246
3247         Reviewed by Alex Christensen.
3248
3249         * Scripts/webkitpy/port/driver.py:
3250         (Driver):
3251         (Driver.http_test_path_to_uri):
3252         (Driver.is_secure_path):
3253         (Driver.http_base_url):
3254         (Driver.uri_to_test):
3255
3256 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3257
3258         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
3259
3260         * BuildSlaveSupport/build.webkit.org-config/config.json:
3261
3262 2018-01-18  Dan Bernstein  <mitz@apple.com>
3263
3264         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
3265         https://bugs.webkit.org/show_bug.cgi?id=181803
3266
3267         Reviewed by Tim Horton.
3268
3269         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
3270         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
3271         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
3272         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
3273         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
3274         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3275         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3276         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3277         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
3278           helpers.
3279         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
3280           settings useful for defining settings that depend on the target macOS version.
3281         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
3282         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
3283
3284 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
3285
3286         Remove Opensource El Capitan queues from buildbot
3287         https://bugs.webkit.org/show_bug.cgi?id=181712
3288
3289         Reviewed by Aakash Jain.
3290
3291         * BuildSlaveSupport/build.webkit.org-config/config.json:
3292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3293         (WebKitBuildbot):
3294         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3295
3296 2018-01-18  Chris Dumez  <cdumez@apple.com>
3297
3298         Service Workers restored from persistent storage have 'redundant' state
3299         https://bugs.webkit.org/show_bug.cgi?id=181749
3300         <rdar://problem/36556486>
3301
3302         Reviewed by Youenn Fablet.
3303
3304         Add API test coverage.
3305
3306         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3307         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
3308
3309 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3310
3311         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
3312         https://bugs.webkit.org/show_bug.cgi?id=176796
3313
3314         Reviewed by Chris Fleizach.
3315
3316         Add sanity check that we have a URL before calling g_strstr_len().
3317
3318         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3319         (WTR::AccessibilityUIElement::url):
3320
3321 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3322
3323         Add triggers for Sierra test262 and perf queues
3324         https://bugs.webkit.org/show_bug.cgi?id=181799
3325
3326         Reviewed by Aakash Jain.
3327
3328         * BuildSlaveSupport/build.webkit.org-config/config.json:
3329
3330 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3331
3332         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
3333         https://bugs.webkit.org/show_bug.cgi?id=181783
3334         <rdar://problem/35785445>
3335
3336         Reviewed by Ryosuke Niwa.
3337
3338         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
3339         copying an image contains a relevant title.
3340
3341         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3342         (TestWebKitAPI::TEST):
3343         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3344         * TestWebKitAPI/ios/UIKitSPI.h:
3345
3346 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3347
3348         WebDriver: ignore the driver in selenium test names when getting expectations
3349         https://bugs.webkit.org/show_bug.cgi?id=181738
3350
3351         Reviewed by Carlos Alberto Lopez Perez.
3352
3353         In selenium tests, the driver is added as a parameter to every test which results in tests names like
3354         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
3355         driver name in the test expectations file, so we need to remove it when querying the expectations.
3356
3357         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3358         (TestExpectationsMarker.__init__): Save the param to ignore.
3359         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
3360         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
3361         (run): Pass param to ignore to TestExpectationsMarker().
3362         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3363         (WebDriverSeleniumExecutor.__init__): Save the driver name.
3364         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
3365
3366 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3367
3368         [GTK][WPE] Show unit tests unexpectedly passing in the bots
3369         https://bugs.webkit.org/show_bug.cgi?id=181726
3370
3371         Reviewed by Michael Catanzaro.
3372
3373         Now that we have the info, let's show it also in the bots.
3374
3375         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3376         (RunGLibAPITests.commandComplete):
3377
3378 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
3379
3380         Fix broken unittest after r227048
3381         https://bugs.webkit.org/show_bug.cgi?id=181760
3382
3383         Reviewed by Aakash Jain.
3384
3385
3386 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3387
3388         WEBKIT_FRAMEWORK should not modify file-global include directories
3389         https://bugs.webkit.org/show_bug.cgi?id=181656
3390
3391         Reviewed by Konstantin Tokarev.
3392
3393         * TestWebKitAPI/PlatformWPE.cmake:
3394         * TestWebKitAPI/glib/CMakeLists.txt:
3395
3396 2018-01-17  Alicia Boya García  <aboya@igalia.com>
3397
3398         Unreviewed, mark Alicia as committer in contributors.json
3399
3400         * Scripts/webkitpy/common/config/contributors.json:
3401
3402 2018-01-17  Youenn Fablet  <youenn@apple.com>
3403
3404         Put fetch Request.keepalive behind a runtime flag
3405         https://bugs.webkit.org/show_bug.cgi?id=181592
3406
3407         Reviewed by Chris Dumez.
3408
3409         * DumpRenderTree/mac/DumpRenderTree.mm:
3410         (enableExperimentalFeatures):
3411         * DumpRenderTree/win/DumpRenderTree.cpp:
3412         (enableExperimentalFeatures):
3413         * WebKitTestRunner/TestController.cpp:
3414         (WTR::TestController::resetPreferencesToConsistentValues):
3415
3416 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3417
3418         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
3419         https://bugs.webkit.org/show_bug.cgi?id=181637
3420         <rdar://problem/36508471>
3421
3422         Reviewed by Tim Horton.
3423
3424         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
3425         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
3426
3427         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3428         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3429         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
3430
3431         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
3432         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
3433
3434         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3435         (webViewForTestingAttachments):
3436         (-[TestWKWebView tagsInBody]):
3437         (-[TestWKWebView expectElementTagsInOrder:]):
3438         (-[TestWKWebView expectElementTag:toComeBefore:]):
3439
3440         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
3441         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
3442
3443         (TestWebKitAPI::TEST):
3444         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3445         (WTR::InjectedBundlePage::InjectedBundlePage):
3446
3447 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3448
3449         WebDriver: add support for test expectations
3450         https://bugs.webkit.org/show_bug.cgi?id=180420
3451
3452         Reviewed by Carlos Alberto Lopez Perez.
3453
3454         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
3455
3456         * Scripts/run-webdriver-tests: Get the retval from process_results().
3457         * Scripts/webkitpy/thirdparty/__init__.py:
3458         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
3459         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3460         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
3461         (TestExpectationsMarker.__init__): Initialize expectations.
3462         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
3463         (run): Create and use TestExpectationsMarker plugin.
3464         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3465         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
3466         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3467         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
3468         (WebDriverTestRunner.run): Do not count results here.
3469         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
3470         amount of failures. Printing the test summary while processing results will be made optional in a follow up
3471         patch.
3472         (WebDriverTestRunner.process_results.report): Return the amount of failures.
3473         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3474         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
3475         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
3476         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
3477         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3478         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
3479         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
3480         (WebDriverTestRunnerW3C._scan_directory): Ditto.
3481         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
3482         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
3483         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
3484
3485 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3486
3487         Unreviewed WPE gardening. Mark some known unit test failures.
3488
3489         * TestWebKitAPI/glib/TestExpectations.json:
3490
3491 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3492
3493         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
3494         https://bugs.webkit.org/show_bug.cgi?id=181724
3495
3496         Reviewed by Philippe Normand.
3497
3498         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
3499         reason to use different names. This way we can refer to the same test names for both and we can share the
3500         expectations in the TestExpectations.json file.
3501
3502         * TestWebKitAPI/glib/TestExpectations.json:
3503         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
3504
3505 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3506
3507         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
3508
3509         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
3510         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
3511
3512         * glib/api_test_runner.py:
3513         (TestRunner._run_test_glib):
3514         (TestRunner._run_google_test):
3515
3516 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3517
3518         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
3519         https://bugs.webkit.org/show_bug.cgi?id=179914
3520
3521         Reviewed by Žan Doberšek.
3522
3523         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
3524         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
3525         all symbols listed in the script are present in the library.
3526
3527         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
3528         (bss_symbols):
3529         * Scripts/check-for-invalid-symbols-in-version-script: Added.
3530         (script_symbols):
3531         * Scripts/make-dist:
3532         (Distcheck.build):
3533         (Distcheck):
3534         (Distcheck.check_symbols):
3535         (Distcheck.check):
3536
3537 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3538
3539         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
3540         https://bugs.webkit.org/show_bug.cgi?id=181722
3541
3542         Reviewed by Žan Doberšek.
3543
3544         I forgot to pass the parameters to run() when restarting.
3545
3546         * glib/glib_test_runner.py:
3547         (GLibTestRunner.run):
3548
3549 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
3550
3551         [CMake] Remove WebCoreDerivedSources library target
3552         https://bugs.webkit.org/show_bug.cgi?id=181664
3553
3554         Reviewed by Carlos Garcia Campos.
3555
3556         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
3557         * TestWebKitAPI/PlatformWin.cmake: Ditto.
3558
3559 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
3560
3561         Move Debug Test262, Release Test262 and Performance queues to Sierra
3562         https://bugs.webkit.org/show_bug.cgi?id=181692
3563
3564         Unreviewed
3565
3566 2018-01-16  Zach Li  <zachli@apple.com>
3567
3568         Add pop-up policy support in website policies.
3569         https://bugs.webkit.org/show_bug.cgi?id=181544.
3570         rdar://problem/30521400.
3571
3572         Reviewed by Alex Christensen.
3573
3574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3575         Added pop-up-check.html.
3576
3577         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
3578
3579         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3580         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3581         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3582         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3583         (TEST):
3584
3585 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3586
3587         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
3588         https://bugs.webkit.org/show_bug.cgi?id=181638
3589         <rdar://problem/36508702>
3590
3591         Reviewed by Dan Bernstein.
3592
3593         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
3594         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
3595
3596         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3597         (-[AttachmentUpdateObserver init]):
3598         (-[AttachmentUpdateObserver sourceForIdentifier:]):
3599         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
3600         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
3601         (TestWebKitAPI::TEST):
3602         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
3603
3604 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3605
3606         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
3607
3608         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
3609
3610         * glib/api_test_runner.py:
3611         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
3612         * glib/glib_test_runner.py:
3613         (GLibTestRunner.run): Use given env.
3614
3615 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3616
3617         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
3618         https://bugs.webkit.org/show_bug.cgi?id=181676
3619
3620         Reviewed by Carlos Alberto Lopez Perez.
3621
3622         The option was removed in r226967.
3623
3624         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3625         (RunGtkAPITests):
3626         (RunWPEAPITests):
3627
3628 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3629
3630         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
3631
3632         The bots are still passing that option and the step is failing because it was removed in r226967.
3633
3634         * glib/api_test_runner.py:
3635         (add_options):
3636
3637 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3638
3639         [GTK][WPE] Improve the way glib tests are run
3640         https://bugs.webkit.org/show_bug.cgi?id=181674
3641
3642         Reviewed by Žan Doberšek.
3643
3644         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
3645         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
3646         tests failing due to an expected assert in the test and unexpected crashes.
3647         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
3648         not showing the subtest name in stdout in case of timeouts.
3649         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
3650         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
3651         of every test case.
3652
3653         * glib/api_test_runner.py:
3654         (TestRunner._run_test_glib): Use GLibTestRunner.
3655         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
3656         (add_options):
3657         * glib/glib_test_runner.py: Added.
3658         (TestTimeout):
3659         (Message):
3660         (Message.__init__):
3661         (Message.create):
3662         (Message.create.read_unsigned):
3663         (Message.create.read_double):
3664         (Message.create.read_string):
3665         (GLibTestRunner):
3666         (GLibTestRunner.__init__):
3667         (GLibTestRunner._process_data):
3668         (GLibTestRunner._process_message):
3669         (GLibTestRunner._read_from_pipe):
3670         (GLibTestRunner._read_from_stderr):
3671         (GLibTestRunner._start_timeout):
3672         (GLibTestRunner._start_timeout._alarm_handler):
3673         (GLibTestRunner._stop_timeout):
3674         (GLibTestRunner._subtest_start):
3675         (GLibTestRunner._subtest_message):
3676         (GLibTestRunner._subtest_stderr):
3677         (GLibTestRunner._subtest_end):
3678         (GLibTestRunner.run):
3679
3680 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3681
3682         Unreviewed, add Thibault to contributors.json
3683
3684         It's a bit weird to add someone here before their first contribution, but this affects
3685         Bugzilla autocomplete, and that is serious business.
3686
3687         * Scripts/webkitpy/common/config/contributors.json:
3688
3689 2018-01-15  JF Bastien  <jfbastien@apple.com>
3690
3691         Remove makePoisonedUnique
3692         https://bugs.webkit.org/show_bug.cgi?id=181630
3693         <rdar://problem/36498623>
3694
3695         Reviewed by Mark Lam.
3696
3697         Update tests.
3698
3699         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
3700         (TestWebKitAPI::TEST):
3701         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
3702         (TestWebKitAPI::TEST):
3703
3704 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
3705
3706         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
3707         https://bugs.webkit.org/show_bug.cgi?id=181476
3708
3709         Reviewed by Michael Catanzaro.
3710
3711         Update to xorg-server 1.19.6 which depends on libxfont2, and change
3712         the lists of packages to install libxfont2-devel (or equivalent).
3713
3714         * gtk/install-dependencies:
3715         * gtk/jhbuild.modules:
3716
3717 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3718
3719         [GTK][WPE] Add support for unit test expectations
3720         https://bugs.webkit.org/show_bug.cgi?id=181589
3721
3722         Reviewed by Michael Catanzaro.
3723
3724         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
3725         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
3726         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
3727         script itself is not a good idea either.
3728
3729         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
3730         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
3731         convenient methods to query them.
3732
3733         * Scripts/run-gtk-tests:
3734         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
3735         * Scripts/run-wpe-tests:
3736         (WPETestRunner): Ditto.
3737         * Scripts/webkitpy/common/test_expectations.py: Added.
3738         (TestExpectations):
3739         (TestExpectations.__init__):
3740         (TestExpectations._port_name_for_expected):
3741         (TestExpectations._expected_value):
3742         (TestExpectations.skipped_tests):
3743         (TestExpectations.skipped_subtests):
3744         (TestExpectations._expectation_value):
3745         (TestExpectations.is_slow):
3746         (TestExpectations.get_expectation):
3747         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
3748         (MockTestExpectations):
3749         (MockTestExpectations.__init__):
3750         (MockTestExpectations.is_skip):
3751         (ExpectationsTest):
3752         (assert_exp):
3753         (assert_not_exp):
3754         (assert_bad_exp):
3755         (assert_skip):
3756         (test_basic):
3757         (test_skip):
3758         (test_flaky):
3759         (test_build_type):
3760         * TestWebKitAPI/glib/TestExpectations.json: Added.
3761         * glib/api_test_runner.py:
3762         (TestRunner): Remove SkippedTest implementation.
3763         (TestRunner.__init__): Create a TestExpectations.
3764         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
3765         (TestRunner._should_run_test_program): Ditto.
3766         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
3767         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
3768         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
3769         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
3770         (TestRunner.run_tests.report): Helper to write report to stdout.
3771
3772 2018-01-13  Mark Lam  <mark.lam@apple.com>
3773
3774         Replace all use of ConstExprPoisoned with Poisoned.
3775         https://bugs.webkit.org/show_bug.cgi?id=181542
3776         <rdar://problem/36442138>
3777
3778         Reviewed by JF Bastien.
3779
3780         1. Converted tests to using new uintptr_t& poison type.
3781         2. Added tests for Poisoned comparison operators.
3782
3783         * TestWebKitAPI/CMakeLists.txt:
3784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3785         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
3786         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
3787         (TestWebKitAPI::TEST):
3788         (TestWebKitAPI::initializeTestPoison): Deleted.
3789         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
3790         (TestWebKitAPI::TEST):
3791         (TestWebKitAPI::passWithRef):
3792         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
3793         (TestWebKitAPI::TEST):
3794         (TestWebKitAPI::f1):
3795         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
3796         (TestWebKitAPI::TEST):
3797         (TestWebKitAPI::poisonedPtrFoo):
3798         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
3799         (TestWebKitAPI::TEST):
3800         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
3801         (TestWebKitAPI::TEST):
3802
3803 2018-01-13  David Kilzer  <ddkilzer@apple.com>
3804
3805         check-webkit-style: false positive for [whitespace/braces] with os_log format string
3806         <https://webkit.org/b/181606>
3807
3808         Reviewed by Darin Adler.
3809
3810         * Scripts/webkitpy/style/checkers/cpp.py:
3811         (check_spacing): Modify regular expression to ignore
3812         os_log format strings like '%{public}'.
3813         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3814         (CppStyleTest.test_spacing_before_braces): Add os_log
3815         format string test.
3816
3817 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3818
3819         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
3820         https://bugs.webkit.org/show_bug.cgi?id=181626
3821
3822         Reviewed by Joseph Pecoraro.
3823
3824         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
3825         Additionally, write a new API test covering the change in r226915.
3826
3827         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3828         (webViewForTestingAttachments):
3829         (TestWebKitAPI::TEST):
3830
3831 2018-01-12  Alex Christensen  <achristensen@webkit.org>
3832
3833         History state should be updated during client redirects with asynchronous policy decisions
3834         https://bugs.webkit.org/show_bug.cgi?id=181358
3835         <rdar://problem/35547689>
3836
3837         Reviewed by Andy Estes.
3838
3839         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3840         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
3841         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3842         (TEST):
3843
3844 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
3845
3846         webkitpy: Refactor simulator code (Part 4)
3847         https://bugs.webkit.org/show_bug.cgi?id=180555
3848         <rdar://problem/36131381>
3849
3850         Reviewed by Aakash Jain.
3851
3852         Move new_simulated_device.py to simulated_device.py.
3853
3854         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
3855         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
3856         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
3857         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
3858         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
3859
3860 2018-01-12  Alex Christensen  <achristensen@webkit.org>
3861
3862         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
3863         https://bugs.webkit.org/show_bug.cgi?id=181595
3864
3865         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
3866         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
3867         I change the < and > to $ to make this test pass and continue to test what it used to.
3868
3869         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
3870         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
3871         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3872
3873 2018-01-11  Keith Miller  <keith_miller@apple.com>
3874
3875         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
3876         https://bugs.webkit.org/show_bug.cgi?id=181573
3877
3878         Reviewed by Simon Fraser.
3879
3880         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3881
3882 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
3883
3884         [WebAuthN] Import a CBOR coder from Chromium
3885         https://bugs.webkit.org/show_bug.cgi?id=181522
3886         <rdar://problem/36055729>
3887
3888         Reviewed by Brent Fulgham.
3889
3890         This patch also imports all unit tests into our API tests to ensure all
3891         workarounds and modification against the original codebase doesn't change
3892         any original functionalities.
3893
3894         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3895         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
3896         (TestWebKitAPI::TEST):
3897         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
3898         (TestWebKitAPI::TEST):
3899         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
3900         (TestWebKitAPI::eq):
3901         Workarounds applied.
3902         (TestWebKitAPI::TEST):
3903
3904 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3905
3906         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
3907         https://bugs.webkit.org/show_bug.cgi?id=181538
3908         <rdar://problem/36440580>
3909
3910         Reviewed by Aakash Jain.
3911
3912         When disambiguating a device type, it is possible that the provided device type is sufficiently
3913         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
3914         will result in a failure to disambiguate the type.
3915
3916         * Scripts/webkitpy/xcode/new_simulated_device.py:
3917         (SimulatedDeviceManager._disambiguate_device_type):
3918
3919 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
3920
3921         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
3922         https://bugs.webkit.org/show_bug.cgi?id=181136
3923         <rdar://problem/36116604>
3924
3925         Reviewed by Chris Dumez.
3926
3927         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
3928         browsing sessions.
3929
3930         * Scripts/run-gtk-tests:
3931         (GtkTestRunner): Unskip test now that it passes.
3932         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3933         (TEST): Add new WebsiteDataStoreEphemeral test.
3934
3935 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
3936
3937         Unreviewed, rolling out r226816.
3938
3939         This change broke LayoutTests on the bots.
3940
3941         Reverted changeset:
3942
3943         "run-webkit-tests fails when there is a curly brace in Xcode
3944         build output"
3945         https://bugs.webkit.org/show_bug.cgi?id=181254
3946         https://trac.webkit.org/changeset/226816
3947
3948 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3949
3950         webkitpy: Fix flakey webserver tests
3951         https://bugs.webkit.org/show_bug.cgi?id=181555
3952         <rdar://problem/36448273>
3953
3954         Reviewed by Aakash Jain.
3955
3956         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3957         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
3958         determine if a specific server is running.
3959
3960 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3961
3962         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
3963         https://bugs.webkit.org/show_bug.cgi?id=181561
3964         <rdar://problem/36452652>
3965
3966         Reviewed by Aakash Jain.
3967
3968         BeautifulSoup.find may return None, this case should be gracefully handled.
3969
3970         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3971         (BugzillaQueries._parse_result_count):
3972         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
3973
3974 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
3975
3976         run-webkit-tests fails when there is a curly brace in Xcode build output
3977         https://bugs.webkit.org/show_bug.cgi?id=181254
3978
3979         Reviewed by Daniel Bates.
3980
3981         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3982         (MeteredStream.write):
3983
3984 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3985
3986         webkitpy: Reimplement simulator code (Part 3)
3987         https://bugs.webkit.org/show_bug.cgi?id=180555
3988         <rdar://problem/36131381>
3989
3990         Reviewed by Aakash Jain.
3991
3992         Remove old simulator code.
3993
3994         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
3995         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
3996         * Scripts/webkitpy/xcode/simulator.py: Removed.
3997         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
3998
3999 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4000
4001         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
4002         https://bugs.webkit.org/show_bug.cgi?id=181337
4003         <rdar://problem/36324813>
4004
4005         Reviewed by Tim Horton.
4006
4007         Add 3 new API tests for attachment element dragging.
4008
4009         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4010         (-[TestWKWebView expectElementTag:toComeBefore:]):
4011         (-[NSItemProvider expectType:withData:]):
4012         (TestWebKitAPI::TEST):
4013
4014 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
4015
4016         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
4017         https://bugs.webkit.org/show_bug.cgi?id=179621
4018         <rdar://problem/35589585>
4019
4020         Unreviewed infrastructure fix.
4021
4022         * Scripts/webkitpy/port/mac.py:
4023         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
4024         list if we are the VERSION_MAX, which usually corresponds with future.
4025
4026 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
4027
4028         CodeBlocks should be in IsoSubspaces
4029         https://bugs.webkit.org/show_bug.cgi?id=180884
4030
4031         Reviewed by Saam Barati.
4032         
4033         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
4034         shouldn't take a long time due to benchmarks we don't optimize for.
4035         
4036         * Scripts/run-jsc-benchmarks:
4037
4038 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
4039
4040         Test gardening for GTK.
4041         https://bugs.webkit.org/show_bug.cgi?id=181477
4042
4043         Unreviewed test gardening.
4044
4045         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
4046         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
4047
4048 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4049
4050         Add the new JSCOnly bot to the scheduler.
4051         https://bugs.webkit.org/show_bug.cgi?id=181487
4052
4053         Unreviewed follow-up patch after r226729
4054
4055         On r226729 I missed to add the new JSCOnly bot the default scheduler.
4056         This is needed to make the bot automatically pick each commit for testing.
4057
4058         * BuildSlaveSupport/build.webkit.org-config/config.json:
4059
4060 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4061
4062         [Attachment Support] Support dragging attachment elements out as files on iOS
4063         https://bugs.webkit.org/show_bug.cgi?id=181199
4064         <rdar://problem/36299316>
4065
4066         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
4067
4068         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
4069         attachment API tests.
4070
4071         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4072         (-[NSItemProvider expectType:withData:]):
4073         (TestWebKitAPI::TEST):
4074
4075         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
4076         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
4077         -expectType:withData: helper to inspect the item providers created from the drag source.
4078
4079         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4080         (TestWebKitAPI::TEST):
4081         * TestWebKitAPI/ios/DataInteractionSimulator.h:
4082         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
4083         (-[MockDragSession localContext]):
4084         (-[MockDragSession setLocalContext:]):
4085         (-[DataInteractionSimulator _resetSimulatedState]):
4086         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
4087         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
4088         (-[DataInteractionSimulator _advanceProgress]):
4089         (-[DataInteractionSimulator endDataTransfer]):
4090
4091         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
4092         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
4093         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
4094         MockDragSession to hold on to a localContext.
4095
4096 2018-01-11  Ali Juma  <ajuma@chromium.org>
4097
4098         Unreviewed. Add Ali Juma as contributor
4099
4100         * Scripts/webkitpy/common/config/contributors.json:
4101
4102 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
4103
4104         Unreviewed. Update Selenium WebDriver imported tests.
4105
4106         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
4107         environment variables.
4108
4109         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
4110         (collect): Reorder the arguments to make pytest happy.
4111         (run): Ditto.
4112         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
4113         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
4114
4115 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
4116
4117         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
4118         https://bugs.webkit.org/show_bug.cgi?id=181492
4119         <rdar://problem/36359679>
4120
4121         Reviewed by Alexey Proskuryakov. 
4122
4123 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
4124
4125         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
4126         https://bugs.webkit.org/show_bug.cgi?id=181475
4127
4128         Reviewed by Michael Catanzaro.
4129
4130         * gtk/install-dependencies: Update package list for Arch Linux, extend
4131         message shown at end of installation with additional tips.
4132
4133 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
4134
4135         REGRESSION(r222507): Composition highlight doesn't render when using IME
4136         https://bugs.webkit.org/show_bug.cgi?id=181485
4137         <rdar://problem/35896516>
4138
4139         Reviewed by Ryosuke Niwa.
4140
4141         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
4142         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
4143         allow rendering composition backgrounds (see InlineTextBox::paint).
4144
4145         * DumpRenderTree/ios/TextInputControllerIOS.m:
4146         (+[TextInputController isSelectorExcludedFromWebScript:]):
4147         (+[TextInputController webScriptNameForSelector:]):
4148         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
4149         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
4150         * DumpRenderTree/mac/TextInputControllerMac.m:
4151         (+[TextInputController isSelectorExcludedFromWebScript:]):
4152         (+[TextInputController webScriptNameForSelector:]):
4153         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
4154         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
4155         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
4156         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
4157         (WTR::TextInputController::setMarkedText):
4158         * WebKitTestRunner/InjectedBundle/TextInputController.h:
4159
4160 2018-01-10  JF Bastien  <jfbastien@apple.com>
4161
4162         Poison small JSObject derivatives which only contain pointers
4163         https://bugs.webkit.org/show_bug.cgi?id=181483
4164         <rdar://problem/36407127>
4165
4166         Reviewed by Mark Lam.
4167
4168         Test the new move-assign and move-copy from unique_ptr, as well as
4169         nullptr_t ctors.
4170
4171         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
4172         (TestWebKitAPI::TEST):
4173         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
4174         (TestWebKitAPI::TEST):
4175         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
4176         (TestWebKitAPI::TEST):
4177
4178 2018-01-10  Chris Dumez  <cdumez@apple.com>
4179
4180         Multiple http/wpt/beacon/contentextensions/ test are flaky.
4181         https://bugs.webkit.org/show_bug.cgi?id=179256
4182         <rdar://problem/35401978>
4183
4184         Reviewed by Alex Christensen.
4185
4186         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
4187         instance gets its own folder to avoid conflicts and flakiness.
4188
4189         * WebKitTestRunner/mac/TestControllerMac.mm:
4190         (WTR::TestController::platformConfigureViewForTest):
4191
4192 2018-01-10  Tim Horton  <timothy_horton@apple.com>
4193
4194         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
4195         https://bugs.webkit.org/show_bug.cgi?id=181269
4196         <rdar://problem/35110344>
4197
4198         Reviewed by Simon Fraser.
4199
4200         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4201         (WTR::UIScriptController::beginBackSwipe):
4202         (WTR::UIScriptController::completeBackSwipe):
4203         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4204         (WTR::UIScriptController::beginBackSwipe):
4205         (WTR::UIScriptController::completeBackSwipe):
4206         (WTR::UIScriptController::overridePreference):
4207         (WTR::UIScriptController::replaceTextAtRange):
4208         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4209         (WTR::PlatformWebView::setNavigationGesturesEnabled):
4210         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4211         (WTR::UIScriptController::beginBackSwipe):
4212         (WTR::UIScriptController::completeBackSwipe):
4213         Implement beginBackSwipe and completeBackSwipe on iOS (they already
4214         exist on Mac) in terms of the new WKWebView testing SPI.
4215
4216 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
4217
4218         REGRESSION (r226715): ignore WARNING output in linter tests
4219         https://bugs.webkit.org/show_bug.cgi?id=181486
4220         <rdar://problem/36408847>
4221
4222         Reviewed by Aakash Jain.
4223
4224         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
4225
4226         * Scripts/webkitpy/common/system/outputcapture.py:
4227         (OutputCapture.__init__): Pass logging level to be captured.
4228         * Scripts/webkitpy/style/main_unittest.py:
4229         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
4230         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
4231         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
4232         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
4233         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
4234         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
4235         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
4236         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
4237
4238 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4239
4240         Add a JSCOnly MIPS buildbot
4241         https://bugs.webkit.org/show_bug.cgi?id=181487
4242
4243         Reviewed by Michael Catanzaro.
4244
4245         Add the new bot configs definitions for the master and update the unit tests.
4246
4247         * BuildSlaveSupport/build.webkit.org-config/config.json:
4248         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4249
4250 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
4251
4252         REGRESSION (r226715): don't re-check number of simulators in child processes
4253         https://bugs.webkit.org/show_bug.cgi?id=181484
4254         <rdar://problem/36407151>
4255
4256         Reviewed by Aakash Jain.
4257
4258         * Scripts/webkitpy/port/ios_simulator.py:
4259         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
4260         are already initialized.
4261
4262 2018-01-10  Commit Queue  <commit-queue@webkit.org>
4263
4264         Unreviewed, rolling out r226667 and r226673.
4265         https://bugs.webkit.org/show_bug.cgi?id=181488
4266
4267         This caused a flaky crash. (Requested by mlewis13 on #webkit).
4268
4269         Reverted changesets:
4270
4271         "CodeBlocks should be in IsoSubspaces"
4272         https://bugs.webkit.org/show_bug.cgi?id=180884
4273         https://trac.webkit.org/changeset/226667
4274
4275         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
4276         https://bugs.webkit.org/show_bug.cgi?id=180884
4277         https://trac.webkit.org/changeset/226673
4278
4279 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
4280
4281         Follow-up fix to r226715
4282         https://bugs.webkit.org/show_bug.cgi?id=180555
4283         <rdar://problem/36131381>
4284
4285         Unreviewed infrastructure fix.
4286
4287         * Scripts/webkitpy/xcode/new_simulated_device.py:
4288         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
4289         of delete.
4290
4291 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
4292
4293         webkitpy: Refactor simulator code (Part 2)
4294         https://bugs.webkit.org/show_bug.cgi?id=180555
4295         <rdar://problem/36131381>
4296
4297         Reviewed by Aakash Jain.
4298
4299         The patch leverages the SimulatedDeviceManager when running layout tests.
4300         This patch is primarily code removal, since much of the IOSSimulatorPort
4301         was dedicated to managing simulators. The removed code is either now owned by the
4302