732754f526cee278fd1284fae9f4eacdc20e41dc
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
2
3         [Qt][WK2] Add support for modal event loop processing for WTR
4         https://bugs.webkit.org/show_bug.cgi?id=74852
5
6         Reviewed by Kenneth Rohde Christiansen.
7
8         Rewrote event loop processing: Instead of terminating the event loop
9         in notifyDone() - something no other platform does - we now respect the
10         "bool& condition" parameter passed to platformRunUntil. This ensures
11         proper termination even when the condition is changed from within a
12         nested event loop, because only when we _exit_ from the nested event
13         loop we will check the condition and terminate the test properly.
14
15         In addition this patch implements TestController::runModal by means of
16         a nested event loop, which is passed to the platform webview that is
17         supposed to be modal. It is that view's responsibility to exit the
18         loop, upon destruction. I believe that's similar to how it works on the Mac,
19         where it doesn't seem that NSApp's runModalForWindow is terminate via
20         abort/stopModal but simply because the window is closed.
21
22         * WebKitTestRunner/PlatformWebView.h:
23         (WTR::PlatformWebView::setModalEventLoop):
24         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
25         (WTR::PlatformWebView::PlatformWebView):
26         (WTR::PlatformWebView::~PlatformWebView):
27         * WebKitTestRunner/qt/TestControllerQt.cpp:
28         (WTR::TestController::notifyDone):
29         (WTR::TestController::platformRunUntil):
30         (WTR::TestController::runModal):
31
32 2011-12-18  Kentaro Hara  <haraken@chromium.org>
33
34         REGRESSION(r103149): prepare-ChangeLog outputs a warning
35         https://bugs.webkit.org/show_bug.cgi?id=74808
36
37         Reviewed by David Kilzer.
38
39         Added the prototype declaration of main() to avoid warning messages.
40         Sorted subroutine declarations in the alphabetical order.
41
42         * Scripts/prepare-ChangeLog:
43
44 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
45
46         [Qt] Fix QtTestBrowser compilation with QtWidgets module
47         https://bugs.webkit.org/show_bug.cgi?id=74791
48
49         Reviewed by Andreas Kling.
50
51         * QtTestBrowser/QtTestBrowser.pro:
52
53 2011-12-17  Kentaro Hara  <haraken@chromium.org>
54
55         Remove top-level code completely from prepare-ChangeLog
56         https://bugs.webkit.org/show_bug.cgi?id=74698
57
58         Reviewed by Darin Adler.
59
60         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
61         This patch just moves all top-level code into main().
62
63         * Scripts/prepare-ChangeLog:
64         (main):
65
66 2011-12-16  Dean Jackson  <dino@apple.com>
67
68         Move webkit-bug-importer to Contributor. It won't
69         autocomplete as an Account.
70         See https://bugs.webkit.org/show_bug.cgi?id=74739
71         for some discussion.
72
73         Unreviewed.
74
75         * Scripts/webkitpy/common/config/committers.py:
76
77 2011-12-16  Dean Jackson  <dino@apple.com>
78
79         Add webkit-bug-importer@group.apple.com to accounts
80         so that it autocompletes in bugzilla.
81
82         Unreviewed.
83
84         * Scripts/webkitpy/common/config/committers.py:
85
86 2011-12-16  Philippe Normand  <pnormand@igalia.com>
87
88         Unreviewed, skipping 3 failing GTK API tests.
89
90         * Scripts/run-gtk-tests:
91
92 2011-12-16  Philippe Normand  <pnormand@igalia.com>
93
94         Unreviewed, GTK API tests build fix attempt.
95
96         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
97
98 2011-12-16  Philippe Normand  <pnormand@igalia.com>
99
100         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
101
102         * Scripts/run-gtk-tests:
103
104 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
105
106         [Qt] Fix the build for newer Qt5
107         https://bugs.webkit.org/show_bug.cgi?id=74703
108
109         Reviewed by Csaba Osztrogonác.
110
111         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
112         * DumpRenderTree/qt/EventSenderQt.cpp:
113         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
114         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
115         (WTR::EventSenderProxy::sendTouchEvent):
116         * MiniBrowser/qt/MiniBrowserApplication.cpp:
117         (MiniBrowserApplication::sendTouchEvent): Ditto.
118         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
119
120 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
121
122         [Qt] Detect and force clean build when feature defines are added
123
124         Reviewed by Ossy.
125
126         https://bugs.webkit.org/show_bug.cgi?id=74689
127
128         * Scripts/webkitdirs.pm:
129
130 2011-12-16  Kentaro Hara  <haraken@chromium.org>
131
132         [Refactoring] Remove all global variables from prepare-ChangeLog
133         https://bugs.webkit.org/show_bug.cgi?id=74681
134
135         Reviewed by Ryosuke Niwa.
136
137         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
138         manner. This bug is one of the incremental refactorings to remove all top-level
139         code and global variables from prepare-ChangeLog. In this patch,
140         we make the following global variables be used only through parameter passing.
141         This patch removes all global variables from prepare-ChangeLog.
142             - $mergeBase
143             - $gitCommit
144             - $gitIndex
145
146         * Scripts/prepare-ChangeLog:
147         (generateFunctionLists):
148         (changeLogNameFromArgs):
149         (changeLogEmailAddressFromArgs):
150         (generateNewChangeLogs):
151         (printDiff):
152         (diffFromToString):
153         (diffCommand):
154         (statusCommand):
155         (createPatchCommand):
156         (generateFileList):
157         (isConflictStatus):
158
159 2011-12-15  Philippe Normand  <pnormand@igalia.com>
160
161         [GTK] Rounding errors on 32-bit machines causes tests to fail
162         https://bugs.webkit.org/show_bug.cgi?id=72254
163
164         Initial patch by vanuan@gmail.com.
165         Reviewed by Martin Robinson.
166
167         * Scripts/webkitdirs.pm:
168         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
169         CXXFLAGS to autogen in an attempt to harmonize floating point
170         values between 32-bit and 64-bit architectures.
171
172 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
173
174         [GTK] Make distcheck fails during the install
175         https://bugs.webkit.org/show_bug.cgi?id=74274
176
177         No review, since this is a build fix.
178
179         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
180         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
181         always runs. This means that the gtkdoc step was always running when make was
182         invoked. Generating gtkdoc during 'make install' was triggering a race condition
183         with the library file. Later we can fix generate-forwarding-headers and unbreak
184         'make docs,' but this bandaid is sufficient to let us release.
185
186 2011-12-15  Eric Seidel  <eric@webkit.org>
187
188         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
189         https://bugs.webkit.org/show_bug.cgi?id=74650
190
191         Reviewed by Adam Barth.
192
193         * Scripts/webkitpy/common/system/platforminfo.py:
194         (PlatformInfo._compute_bytes_from_vm_stat_output):
195         * Scripts/webkitpy/layout_tests/port/base.py:
196         (Port.default_child_processes):
197         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
198         (PortTest.test_default_child_processes):
199
200 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
201
202         bencher script should support remote benchmarking on platforms that don't have ruby
203         https://bugs.webkit.org/show_bug.cgi?id=74659
204
205         Rubber-stamped by Sam Weinig.
206         
207         Added the ability to have bencher generate a benchmarking playload that consists of
208         copies of all of the benchmarks, optionally copies of all of the frameworks and
209         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
210         order, which then spits out a raw results file that bencher can parse.
211         
212         In normal operating mode, you never see this, as it just generates the payload and
213         script internally, runs it, parses the results, and spits them out.
214         
215         The --remote mode has been changed to use this style, so any remote host that has
216         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
217         a sh-compatible shell can be used for remote benchmarking.
218         
219         The feature to include VMs in the benchmarking payload is by default only activated
220         when using --remote, but it can also be activated when doing local benchmarking; the
221         benefit is that you remove any pathname-related performance pathologies. All VMs
222         become equal because they are all located in
223         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
224         (usually 0 or 1).
225         
226         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
227         through DumpRenderTree. This is only a bit slower than running in jsc.
228
229         * Scripts/bencher:
230
231 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
232
233         webkitpy: clean up TestPort to (mostly) not create a new filesystem
234         https://bugs.webkit.org/show_bug.cgi?id=74556
235
236         This change modifies the TestPort to be ready to add tests to an
237         existing filesystem instead of creating a new filesystem; we
238         leave unit_test_filesystem() in for now for compatibility.
239
240         * Scripts/webkitpy/common/host_mock.py:
241         (MockHost.__init__):
242           - call add_unit_tests_to_mock_filesystem by default to make
243             the MockHost more generally useful for layout_test unit tests.
244         * Scripts/webkitpy/layout_tests/port/test.py:
245         (TestInstance.__init__):
246         (add_unit_tests_to_mock_filesystem):
247         (add_file):
248         (unit_test_filesystem):
249         (TestPort.__init__):
250         (TestPort._set_default_overriding_none):
251
252 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
253
254         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
255         https://bugs.webkit.org/show_bug.cgi?id=74551
256
257         This is some minor cleanup prior to making all of the host/port
258         changes described in bug 74138.
259
260         * Scripts/webkitpy/common/host_mock.py:
261         (MockHost.__init__):
262           - make sure the scm object is initialized with the same mock
263             executive and filesystem objects.
264
265         * Scripts/webkitpy/common/system/filesystem_mock.py:
266         (MockFileSystem.clear_written_files):
267           - add a routine that will be useful in testing.
268         (MockFileSystem.maybe_make_directory):
269         (MockFileSystem.write_binary_file):
270           - fix bugs to make sure directories are created properly.
271         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
272         (_Process.run):
273           - add clarifying comments.
274         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
275         (MockDRTPort.__init__):
276         (MockDRT.__init__):
277           - add clarifying comments.
278
279 2011-12-15  Anders Carlsson  <andersca@apple.com>
280
281         Regression (r102866): Navigating away from or closing a page with a plugin crashes
282         https://bugs.webkit.org/show_bug.cgi?id=74655
283
284         Reviewed by Sam Weinig.
285
286         Add a bunch of tests.
287
288         * TestWebKitAPI/Tests/WTF/Functional.cpp:
289
290 2011-12-15  Stephanie Lewis  <slewis@apple.com>
291
292         https://bugs.webkit.org/show_bug.cgi?id=74469
293         Escape paths to svn commands so our tools can handle filenames with @ symbols.
294
295         Reviewed by Adam Roben.
296
297         * Scripts/VCSUtils.pm:
298         (scmMoveOrRenameFile):
299         (scmAddExecutableBit):
300         (scmRemoveExecutableBit):
301         (determineSVNRoot):
302         (svnRevisionForDirectory):
303         (pathRelativeToSVNRepositoryRootForPath):
304         (svnStatus):
305         (escapeSubversionPath):
306         * Scripts/parse-malloc-history:
307         (main):
308         * Scripts/prepare-ChangeLog:
309         (diffCommand):
310         (statusCommand):
311         (findOriginalFileFromSvn):
312         (determinePropertyChanges):
313         * Scripts/resolve-ChangeLogs:
314         (conflictFiles):
315         (resolveConflict):
316         (showStatus):
317         * Scripts/svn-apply:
318         (patch):
319         (scmCopy):
320         (scmAdd):
321         (scmRemove):
322         * Scripts/svn-create-patch:
323         (findBaseUrl):
324         (findMimeType):
325         (findSourceFileAndRevision):
326         (generateDiff):
327         (generateFileList):
328         (manufacturePatchForAdditionWithHistory):
329         * Scripts/svn-unapply:
330         (patch):
331         (revertDirectories):
332
333 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
334
335         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
336         https://bugs.webkit.org/show_bug.cgi?id=74617
337
338         Reviewed by Kenneth Rohde Christiansen.
339
340         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
341         for viewport info button, adjusted height and added rounded corners.
342
343 2011-12-15  Andy Estes  <aestes@apple.com>
344
345         TestFailures: store the name of the buildbot results directory in a property
346         https://bugs.webkit.org/show_bug.cgi?id=74663
347
348         Reviewed by Adam Barth.
349         
350         Store the name of the results directory as a property on Buildbot's
351         prototype. This allows subclasses of Buildbot to customize the results
352         directory.
353
354         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
355         (Buildbot.prototype.resultsDirectoryURL):
356
357 2011-12-15  Tony Chang  <tony@chromium.org>
358
359         [chromium] pass --delete_unversioned_trees to gclient on the bots
360         https://bugs.webkit.org/show_bug.cgi?id=74565
361
362         Reviewed by Kenneth Russell.
363
364         It was temporarily removed in r102891 to keep the bots green.  Now
365         that the bots have cycled, we can add it back.
366
367         * Scripts/update-webkit-chromium:
368
369 2011-12-15  Kentaro Hara  <haraken@chromium.org>
370
371         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
372         https://bugs.webkit.org/show_bug.cgi?id=74497
373
374         Reviewed by Ryosuke Niwa.
375
376         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
377         manner. This bug is one of the incremental refactorings to remove all top-level
378         code and global variables from prepare-ChangeLog. In this patch,
379         we make the following global variables be used only through parameter passing.
380             - $bugDescription
381             - $bugNumber
382             - $name
383             - $emailAddress
384             - $gitReviewer
385             - $writeChangeLogs
386
387         * Scripts/prepare-ChangeLog:
388         (fetchBugDescriptionFromURL):
389         (generateNewChangeLogs):
390         (reviewerAndDescriptionForGitCommit):
391
392 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
393
394         [EFL] Add a few more web database functions to ewk_settings.
395         https://bugs.webkit.org/show_bug.cgi?id=72148
396
397         Reviewed by Antonio Gomes.
398
399         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
400         (LayoutTestController::clearAllDatabases):
401         (LayoutTestController::setDatabaseQuota):
402
403 2011-12-15  Martin Kosiba  <mkosiba@google.com>
404
405         Fix find on web pages with -webkit-user-select: none for Chromium
406         https://bugs.webkit.org/show_bug.cgi?id=72281
407
408         Reviewed by Ryosuke Niwa.
409
410         Provided a partial findString implementation. This doesn't support
411         all of the FindOptions since they're not exposed via WebFindOptions.
412
413         * DumpRenderTree/chromium/LayoutTestController.cpp:
414         (LayoutTestController::LayoutTestController):
415         (LayoutTestController::findString):
416         * DumpRenderTree/chromium/LayoutTestController.h:
417
418 2011-12-15  Kenneth Russell  <kbr@google.com>
419
420         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
421         https://bugs.webkit.org/show_bug.cgi?id=74581
422
423         Reviewed by Darin Fisher.
424
425         * DumpRenderTree/chromium/LayoutTestController.cpp:
426         (LayoutTestController::overridePreference):
427         * DumpRenderTree/chromium/WebPreferences.cpp:
428         (WebPreferences::reset):
429         (WebPreferences::applyTo):
430         * DumpRenderTree/chromium/WebPreferences.h:
431
432 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
433
434         [Qt] Improve the look of the viewport info overlay
435
436         Reviewed by Tor Arne Vestbø.
437
438         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
439
440 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
441
442         [Qt] Support requestAnimationFrame API
443         https://bugs.webkit.org/show_bug.cgi?id=74528
444
445         Add build-option for requestAnimationFrame feature.
446
447         Reviewed by Kenneth Rohde Christiansen.
448
449         * qmake/mkspecs/features/features.prf:
450
451 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
452
453         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
454
455         Reviewed by Simon Hausmann.
456
457         * qmake/mkspecs/features/webcore.prf:
458
459 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
460
461         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
462         https://bugs.webkit.org/show_bug.cgi?id=72893
463
464         Reviewed by Kenneth Rohde Christiansen.
465
466         This patch extends QQuickWebViewExperimental by a property named
467         viewportInfo, which contains the viewport scalability and
468         layout and contents size information. This property is exposed to
469         QML through the experimental extension for QQuickWebView.
470
471         * MiniBrowser/qt/MiniBrowser.pro:
472         * MiniBrowser/qt/MiniBrowser.qrc:
473         * MiniBrowser/qt/icons/info.png: Added.
474         * MiniBrowser/qt/qml/BrowserWindow.qml:
475         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
476
477 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
478
479         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
480         https://bugs.webkit.org/show_bug.cgi?id=74586
481
482         Reviewed by Hajime Morita.
483
484         No new tests. Covered by existing tests.
485
486         * DumpRenderTree/chromium/WebViewHost.cpp:
487         (WebViewHost::requestCheckingOfText):
488           Returns immediately if text is empty.
489
490 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
491
492         [Qt] QtWebKit fails to build on Mac OS X after r102776
493         https://bugs.webkit.org/show_bug.cgi?id=74593
494
495         Reviewed by Simon Hausmann.
496
497         CONFIG =+ link_pkgconfig is needed such that the correct parameters
498         are passed to the compiler.
499
500         * DumpRenderTree/qt/DumpRenderTree.pro:
501
502 2011-12-14  Tony Chang  <tony@chromium.org>
503
504         [chromium] Remove redundant third_party entries from chromium DEPS
505         https://bugs.webkit.org/show_bug.cgi?id=74472
506
507         Reviewed by Kenneth Russell.
508
509         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
510
511 2011-12-14  Kentaro Hara  <haraken@chromium.org>
512
513         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
514         VCSUtils::isGit() and VCSUtils::isSVN().
515         https://bugs.webkit.org/show_bug.cgi?id=74485
516
517         Reviewed by David Kilzer.
518
519         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
520         manner. This bug is one of the incremental refactorings to remove all top-level
521         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
522         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
523         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
524         just by looking at the current working directory.
525
526         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
527         (diffFromToString):
528         (diffCommand):
529         (statusCommand):
530         (createPatchCommand):
531         (diffHeaderFormat):
532         (generateFileList):
533         (isAddedStatus):
534         (isConflictStatus):
535         (statusDescription):
536         (extractLineRange):
537
538 2011-12-14  Sam Weinig  <weinig@apple.com>
539
540         Remove whitespace from InheritedPropertySheets attributes in
541         vsprops files to appease the Visual Studio project migrator.
542
543         Reviewed by Adam Roben.
544
545         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
546         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
547         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
548         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
549         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
550         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
551         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
552         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
553         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
554         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
555         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
556         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
557         * DumpRenderTree/win/ImageDiffDebug.vsprops:
558         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
559         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
560         * DumpRenderTree/win/ImageDiffProduction.vsprops:
561         * DumpRenderTree/win/ImageDiffRelease.vsprops:
562         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
563         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
564         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
565         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
566         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
567         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
568         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
569         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
570         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
571         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
572         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
573         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
574         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
575         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
576         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
577         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
578         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
579         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
580         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
581         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
582         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
583         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
584         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
585         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
586         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
587         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
588         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
589         * WinLauncher/WinLauncherDebug.vsprops:
590         * WinLauncher/WinLauncherDebugAll.vsprops:
591         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
592         * WinLauncher/WinLauncherProduction.vsprops:
593         * WinLauncher/WinLauncherRelease.vsprops:
594         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
595         * record-memory-win/record-memory-winDebug.vsprops:
596         * record-memory-win/record-memory-winDebugAll.vsprops:
597         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
598         * record-memory-win/record-memory-winProduction.vsprops:
599         * record-memory-win/record-memory-winRelease.vsprops:
600         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
601
602 2011-12-14  Anders Carlsson  <andersca@apple.com>
603
604         Windows build fix.
605
606         Move CHECKs out of the destructor.
607
608         * TestWebKitAPI/Tests/WTF/Functional.cpp:
609         (TestWebKitAPI::B::~B):
610         (TestWebKitAPI::TEST):
611
612 2011-12-14  Anders Carlsson  <andersca@apple.com>
613
614         binding a member function should ref/deref the object pointer if needed
615         https://bugs.webkit.org/show_bug.cgi?id=74552
616
617         Reviewed by Sam Weinig.
618
619         Add new tests.
620
621         * TestWebKitAPI/Tests/WTF/Functional.cpp:
622         (TestWebKitAPI::B::B):
623         (TestWebKitAPI::B::~B):
624         (TestWebKitAPI::B::ref):
625         (TestWebKitAPI::B::deref):
626         (TestWebKitAPI::B::f):
627         (TestWebKitAPI::B::g):
628         (TestWebKitAPI::TEST):
629
630 2011-12-14  Hajime Morrita  <morrita@chromium.org>
631
632         JS_INLINE and WTF_INLINE should be visible from WebCore
633         https://bugs.webkit.org/show_bug.cgi?id=73191
634
635         Reviewed by Kevin Ollivier.
636
637         Removed macro definitions which is now provided by Platform.h
638
639         * DumpRenderTree/chromium/config.h:
640         * DumpRenderTree/config.h:
641         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
642         * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
643         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
644         * TestWebKitAPI/config.h:
645         * WebKitTestRunner/config.h:
646
647 2011-12-14  Kentaro Hara  <haraken@chromium.org>
648
649         Unreviewed, rolling out r102761.
650         http://trac.webkit.org/changeset/102761
651         https://bugs.webkit.org/show_bug.cgi?id=74485
652
653         we came up with a better fix than this (see comments in bug
654         74485)
655
656         * Scripts/prepare-ChangeLog:
657         (generateFunctionLists):
658         (printDiff):
659         (diffCommand):
660         (statusCommand):
661         (createPatchCommand):
662         (generateFileList):
663         (isAddedStatus):
664         (isConflictStatus):
665         (statusDescription):
666         (extractLineRange):
667
668 2011-12-14  Anders Carlsson  <andersca@apple.com>
669
670         Work around a bug in the MSVC2005 compiler
671         https://bugs.webkit.org/show_bug.cgi?id=74550
672
673         Reviewed by Sam Weinig.
674
675         Re-enable tests.
676
677         * TestWebKitAPI/Tests/WTF/Functional.cpp:
678
679 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
680
681         [Qt] Test fonts are not used with Qt5
682         https://bugs.webkit.org/show_bug.cgi?id=72513
683
684         My last unreviewed buildfix for this crazy bug.
685
686         * qmake/mkspecs/features/features.prf:
687
688 2011-12-14  Anders Carlsson  <andersca@apple.com>
689
690         Another attempt at fixing the Windows build.
691
692         Disable all the tests until I can figure out what's going on here.
693
694         * TestWebKitAPI/Tests/WTF/Functional.cpp:
695
696 2011-12-14  Anders Carlsson  <andersca@apple.com>
697
698         Fix the Windows build.
699
700         Disable some of the tests for now.
701
702         * TestWebKitAPI/Tests/WTF/Functional.cpp:
703
704 2011-12-14  Anders Carlsson  <andersca@apple.com>
705
706         bind should handle member functions
707         https://bugs.webkit.org/show_bug.cgi?id=74529
708
709         Reviewed by Sam Weinig.
710
711         Add tests.
712
713         * TestWebKitAPI/Tests/WTF/Functional.cpp:
714         (TestWebKitAPI::A::A):
715         (TestWebKitAPI::A::f):
716         (TestWebKitAPI::A::addF):
717         (TestWebKitAPI::TEST):
718
719 2011-12-14  Anders Carlsson  <andersca@apple.com>
720
721         Add unary and binary bind overloads
722         https://bugs.webkit.org/show_bug.cgi?id=74524
723
724         Reviewed by Sam Weinig.
725
726         Add tests.
727
728         * TestWebKitAPI/Tests/WTF/Functional.cpp:
729         (TestWebKitAPI::TEST):
730         (TestWebKitAPI::multiplyByTwo):
731         (TestWebKitAPI::multiplyByOneAndAHalf):
732         (TestWebKitAPI::multiply):
733         (TestWebKitAPI::subtract):
734
735 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
736
737         [Qt] Test fonts are not used with Qt5
738         https://bugs.webkit.org/show_bug.cgi?id=72513
739
740         MIPS and SH4 buildfix after r102776 and r102795.
741
742         Reviewed by Csaba Osztrogonác.
743
744         * qmake/mkspecs/features/features.prf:
745
746 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
747
748         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
749
750         * qmake/mkspecs/features/features.prf:
751
752 2011-12-14  Andreas Kling  <kling@webkit.org>
753
754         Make my e-mail address a little more awesome.
755
756         * Scripts/webkitpy/common/config/committers.py:
757
758 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
759
760         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
761
762         * qmake/mkspecs/features/webcore.prf:
763
764 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
765
766         [Qt] Test fonts are not used with Qt5
767         https://bugs.webkit.org/show_bug.cgi?id=72513
768
769         Reviewed by Simon Hausmann.
770
771         Don't depend on Q_WS_X11 anymore since it's not the Qt5
772         way to detect the platform. Make the guards depend
773         on our own configtest for fontconfig. For Qt4 we can still
774         use the preassumption that we have it on Linux.
775
776         * DumpRenderTree/qt/DumpRenderTree.pro:
777         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
778         (WebCore::DumpRenderTree::open):
779         (WebCore::DumpRenderTree::initializeFonts):
780         * DumpRenderTree/qt/DumpRenderTreeQt.h:
781         * DumpRenderTree/qt/main.cpp:
782         (main): Additionally remove a nonsense piece of code that was
783         trying to reset the font settings - which is not necessary -
784         after we have already returned from main.
785         * WebKitTestRunner/InjectedBundle/Target.pri:
786         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
787         (WTR::activateFonts):
788         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
789         from WTR. It is not needed. We set up the fonts via the injected bundle.
790         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
791         (main):
792         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
793         * qmake/mkspecs/features/features.prf:
794         * qmake/sync.profile:
795
796 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
797
798         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
799
800         Followup to r102679
801
802         https://bugs.webkit.org/show_bug.cgi?id=74413
803
804         Reviewed by Simon Hausmann.
805
806         * qmake/mkspecs/features/webcore.prf:
807
808 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
809
810         [Qt] Mobile theme could use a little refresh
811         https://bugs.webkit.org/show_bug.cgi?id=74293
812
813         Have MiniBrowser use the mobile theme when not
814         passed --desktop.
815
816         Reviewed by Kenneth Rohde Christiansen.
817
818         * MiniBrowser/qt/MiniBrowserApplication.cpp:
819         (MiniBrowserApplication::handleUserOptions):
820
821 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
822
823         [Qt] [Gardening] Remove qt-4.7 layout tests dir
824         https://bugs.webkit.org/show_bug.cgi?id=74426
825
826         Building trunk now depends on Qt >= 4.8, so no need to keep this directory
827         on the tree.
828
829         Reviewed by Csaba Osztrogonác.
830
831         * Scripts/webkitpy/layout_tests/port/qt.py:
832         (QtPort.qt_version):
833         (QtPort.baseline_search_path):
834         (QtPort._skipped_file_search_paths):
835         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
836         (QtPortTest._assert_search_path):
837
838 2011-12-14  Kentaro Hara  <haraken@chromium.org>
839
840         [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
841         through parameter passing
842         https://bugs.webkit.org/show_bug.cgi?id=74485
843
844         Reviewed by Ryosuke Niwa.
845
846         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
847         manner. This bug is one of the incremental refactorings to remove all top-level
848         code and global variables from prepare-ChangeLog. In this patch,
849         we make the following global variables be used only through parameter passing.
850             - $isGit
851             - $isSVN
852
853         * Scripts/prepare-ChangeLog:
854         (generateFunctionLists):
855         (printDiff):
856         (diffFromToString):
857         (diffCommand):
858         (statusCommand):
859         (createPatchCommand):
860         (diffHeaderFormat):
861         (generateFileList):
862         (isAddedStatus):
863         (isConflictStatus):
864         (statusDescription):
865         (extractLineRange):
866
867 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
868
869         [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
870         https://bugs.webkit.org/show_bug.cgi?id=74417
871
872         Reviewed by Simon Hausmann.
873
874         Based on original patch by Kenneth Christiansen.
875
876         Already covered by current tests.
877
878         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
879         (WebCore::DumpRenderTree::DumpRenderTree):
880         (WebCore::DumpRenderTree::~DumpRenderTree):
881         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
882         (LayoutTestController::setMockDeviceOrientation):
883
884 2011-12-03  Philippe Normand  <pnormand@igalia.com>
885
886         [GTK] Bad text rendering since r101343
887         https://bugs.webkit.org/show_bug.cgi?id=73744
888
889         Reviewed by Martin Robinson.
890
891         Turn cairo hint metrics off for better font metrics reporting in
892         the tests. This is especially important for SVG.
893
894         * DumpRenderTree/gtk/DumpRenderTree.cpp:
895         (initializeGtkFontSettings):
896         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
897         (WTR::initializeGtkSettings):
898
899 2011-12-13  Kentaro Hara  <haraken@chromium.org>
900
901         [Refactoring] Remove several global variables from prepare-ChangeLog
902         https://bugs.webkit.org/show_bug.cgi?id=74389
903
904         Reviewed by David Kilzer.
905
906         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
907         manner. This bug is one of the incremental refactorings to remove all top-level
908         code and global variables from prepare-ChangeLog. In this patch,
909         we make the following global variables being used only through parameter passing.
910             - %paths
911             - $changedFiles
912             - $conflictFiles
913             - $functionLists
914             - $bugURL
915
916         * Scripts/prepare-ChangeLog:
917         (findChangeLogs):
918         (generateNewChangeLogs):
919         (processPaths):
920         (generateFileList):
921         (firstDirectoryOrCwd):
922
923 2011-12-13  Anders Carlsson  <andersca@apple.com>
924
925         Add a very bare-bones implementation of bind and Function to WTF
926         https://bugs.webkit.org/show_bug.cgi?id=74462
927
928         Reviewed by Sam Weinig.
929
930         Add basic tests for WTF::Function and WTF::bind.
931
932         * TestWebKitAPI/TestWebKitAPI.gypi:
933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
934         * TestWebKitAPI/Tests/Functional.cpp: Added.
935         (TestWebKitAPI::returnFortyTwo):
936         (TestWebKitAPI::TEST):
937         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
938
939 2011-12-13  Robin Dunn  <robin@alldunn.com>
940
941         [wx] Add a URL argument to wxWebView constructor.
942         https://bugs.webkit.org/show_bug.cgi?id=74316
943         
944         Reviewed by Kevin Ollivier.
945
946         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
947         (MyApp::OnInit):
948         * wx/browser/browser.cpp:
949         (MyApp::OnInit):
950
951 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
952
953         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
954         https://bugs.webkit.org/show_bug.cgi?id=74430
955
956         Reviewed by David Levin.
957
958         * Scripts/webkitpy/common/config/watchlist:
959
960 2011-12-13  Peter Beverloo  <peter@chromium.org>
961
962         [Chromium] Pull in FreeType and decrease check-out complexity for Android
963         https://bugs.webkit.org/show_bug.cgi?id=74401
964
965         Decrease the check-out complexity by removing the need to first run
966         "update-webkit-chromium --chromium" prior to running it with
967         "--chromium-android", which was caused by an unversioned third_party/
968         directory being created. This moves the Android NDK to Source/WebKit/
969         chromium/, coming from third_party/ in that directory.
970
971         Reviewed by Adam Barth.
972
973         * Scripts/update-webkit-chromium:
974         * Scripts/webkitdirs.pm:
975         (buildChromiumMakefile):
976
977 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
978
979         build-jsc passing incorrect args to buildGtkProject
980         https://bugs.webkit.org/show_bug.cgi?id=74308
981
982         Reviewed by Gustavo Noronha Silva.
983
984         * Scripts/build-webkit: Instead of invoking buildGtkProject with
985         another argument about webkit2, unshift a --disable-webkit2
986         argument onto the buildArgs.
987         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
988         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
989         and build-jsc are run one after the other.
990
991 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
992
993         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
994         https://bugs.webkit.org/show_bug.cgi?id=74413
995
996         Unreviewed buildfix.
997
998         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
999
1000 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1001
1002         [Qt] Unreviewed speculativ debug buildfix after r102679.
1003
1004         * QtTestBrowser/QtTestBrowser.pro:
1005         * QtTestBrowser/main.cpp:
1006
1007 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1008
1009         [Qt] Get rid of layering violations in includes
1010
1011         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
1012         in the webcore.prf, but rather in each target that specificly needs
1013         headers in these location. We used to include them directly in webcore
1014         since we had layering violations between WebCore and WebKit, but now
1015         that they are gone there's no reason to do that.
1016
1017         Reviewed by Simon Hausmann.
1018
1019         * DumpRenderTree/qt/DumpRenderTree.pro:
1020         * QtTestBrowser/launcherwindow.h:
1021         * WebKitTestRunner/InjectedBundle/Target.pri:
1022         * qmake/mkspecs/features/webcore.prf:
1023         * qmake/mkspecs/features/webkit2.prf:
1024
1025 2011-12-13  János Badics  <dicska@gmail.com>
1026
1027         [NRWT] It crashes intermittently when there are WebProcess crashes
1028         https://bugs.webkit.org/show_bug.cgi?id=73451
1029
1030         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
1031
1032         Reviewed by Kenneth Rohde Christiansen.
1033
1034         * Scripts/webkitpy/layout_tests/port/server_process.py:
1035         (ServerProcess._check_for_crash):
1036
1037 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1038
1039         Unreviewed. Fix GTK+ API docs build.
1040
1041         * gtk/generate-gtkdoc:
1042         (get_webkit2_options): Ignore WebKitUIClient since it's private
1043         API.
1044
1045 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
1046
1047         Reviewed, removed one of my email addresses to use the apprpriate one.
1048
1049         * Scripts/webkitpy/common/config/committers.py:
1050
1051 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
1052
1053         [Qt] Fix skip list search path and expected file search path in ORWT
1054         https://bugs.webkit.org/show_bug.cgi?id=74281
1055
1056         Expected file search path fixed.
1057
1058         Print all used skipped list and expected search path in verbose mode similar to NRWT.
1059
1060         Reviewed by Csaba Osztrogonác.
1061
1062         * Scripts/old-run-webkit-tests:
1063         (buildPlatformResultHierarchy):
1064         (buildPlatformTestHierarchy):
1065         (readSkippedFiles):
1066
1067 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1068
1069         [Qt] Missing layoutTestController.dumpWillCacheResponse
1070         https://bugs.webkit.org/show_bug.cgi?id=74287
1071
1072         Reviewed by Csaba Osztrogonác.
1073
1074         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1075         (LayoutTestController::reset):
1076         (LayoutTestController::dumpWillCacheResponse):
1077         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1078
1079 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
1080
1081         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
1082         https://bugs.webkit.org/show_bug.cgi?id=73771
1083
1084         Reviewed by Gustavo Noronha Silva.
1085
1086         When using a fallback font during testing, always use DejaVu Sans. This prevents
1087         falling back to DejaVu Serif on some systems.
1088
1089         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
1090
1091 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1092
1093         Add myself as a committer
1094
1095         * Scripts/webkitpy/common/config/committers.py:
1096
1097 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1098
1099         [Qt] [WK2] Support customizing popup menus with QML
1100         https://bugs.webkit.org/show_bug.cgi?id=73560
1101
1102         Reviewed by Tor Arne Vestbø.
1103
1104         Add an Item Selector to our WebView using the experimental API.
1105
1106         * MiniBrowser/qt/MiniBrowser.pro:
1107         * MiniBrowser/qt/MiniBrowser.qrc:
1108         * MiniBrowser/qt/qml/BrowserWindow.qml:
1109         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
1110
1111 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
1112
1113         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
1114         https://bugs.webkit.org/show_bug.cgi?id=74283
1115
1116         Reviewed by Simon Hausmann.
1117
1118         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1119         (MiniBrowserApplication::sendTouchEvent):
1120
1121 2011-12-12  Kentaro Hara  <haraken@chromium.org>
1122
1123         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
1124         to show ChangeLogs diff and open ChangeLogs in an editor
1125         https://bugs.webkit.org/show_bug.cgi?id=74266
1126
1127         Reviewed by Ryosuke Niwa.
1128
1129         We are planning to write unit-tests for prepare-ChangeLog
1130         in a run-leaks_unittest manner. This patch is one of the incremental
1131         refactorings to remove all top-level code and global variables from
1132         prepare-ChangeLog.
1133
1134         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
1135         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
1136         Renamed @changed_files to @changedFiles.
1137         Renamed %conflict_files to %conflictFiles.
1138         (generateFunctionLists):
1139         (printDiff):
1140         (openChangeLogs):
1141
1142 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1143
1144         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
1145         https://bugs.webkit.org/show_bug.cgi?id=74257
1146
1147         Reviewed by Ryosuke Niwa.
1148
1149         We are planning to write unit-tests for prepare-ChangeLog
1150         in a run-leaks_unittest/ manner. This patch is one of the incremental
1151         refactorings to remove all top-level code and global variables from
1152         prepare-ChangeLog.
1153
1154         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
1155         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
1156         into resolveConflictedChangeLogs().
1157         (getLatestChangeLogs):
1158         (resolveConflictedChangeLogs):
1159
1160 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1161
1162         [Refactoring] Move top-level code to generate a new ChangeLog into a method
1163         https://bugs.webkit.org/show_bug.cgi?id=74253
1164
1165         Reviewed by David Kilzer.
1166
1167         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
1168         which requires to remove top-level code and global variables. This patch is one of
1169         the incremental refactorings for that.
1170
1171         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
1172         (generateFunctionLists):
1173         (findChangeLogs):
1174         (generateNewChangeLogs):
1175         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
1176
1177 2011-12-10  Kentaro Hara  <haraken@chromium.org>
1178
1179         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
1180         https://bugs.webkit.org/show_bug.cgi?id=74175
1181
1182         Reviewed by Ryosuke Niwa.
1183
1184         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1185         This requires to remove top-level code. This patch is one of the incremental refactorings
1186         for that.
1187
1188         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
1189         (findChangeLogs):
1190
1191 2011-12-10  Andreas Kling  <kling@webkit.org>
1192
1193         Add my Apple e-mail to committers.py.
1194
1195         * Scripts/webkitpy/common/config/committers.py:
1196
1197 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1198
1199         chromium win build: revert build_webkit_exes_from_webkit_gyp change
1200         https://bugs.webkit.org/show_bug.cgi?id=74225
1201
1202         This change sets build_webkit_exes_from_webkit_gyp back to 1;
1203         the "All.gyp" solution doesn't work on windows.
1204
1205         * Scripts/webkitdirs.pm:
1206         (buildChromium):
1207
1208 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
1209
1210         [Qt] Click's count is limited to three continuous clicks.
1211         https://bugs.webkit.org/show_bug.cgi?id=45666
1212
1213         Reviewed by Kenneth Rohde Christiansen.
1214
1215         Update m_time at every call to leapForward, so double clicks
1216         event are correctly sent by EventSender.
1217
1218         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1219         (WTR::EventSenderProxy::updateClickCountForButton):
1220         (WTR::EventSenderProxy::leapForward):
1221
1222 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1223
1224         [Refactoring] Reduce top-level code in prepare-ChangeLog
1225         https://bugs.webkit.org/show_bug.cgi?id=74172
1226
1227         Reviewed by Ryosuke Niwa.
1228
1229         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1230         This requires to remove top-level code. This patch is one of the incremental refactorings
1231         for that.
1232
1233         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
1234         (generateFunctionLists):
1235
1236 2011-12-09  Sam Weinig  <sam@webkit.org>
1237
1238         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
1239         https://bugs.webkit.org/show_bug.cgi?id=74218
1240
1241         Reviewed by Anders Carlsson.
1242
1243         Add a test of the WKConnectionRef API.
1244
1245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1246         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
1247         (TestWebKitAPI::didCreateConnection):
1248         (TestWebKitAPI::connectionDidReceiveMessage):
1249         (TestWebKitAPI::connectionDidClose):
1250         (TestWebKitAPI::TEST):
1251         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
1252         (TestWebKitAPI::connectionDidReceiveMessage):
1253         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
1254         (TestWebKitAPI::WKConnectionTest::initialize):
1255
1256 2011-12-09  David Levin  <levin@chromium.org>
1257
1258         Hash* iterators should allow comparison between const and const versions.
1259         https://bugs.webkit.org/show_bug.cgi?id=73370
1260
1261         Reviewed by Darin Adler.
1262
1263         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
1264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1265         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1266         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
1267         (TestWebKitAPI::TEST): Add a test for the new functionality.
1268
1269 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1270
1271         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
1272         https://bugs.webkit.org/show_bug.cgi?id=74212
1273
1274         Reviewed by Tony Chang.
1275
1276         The change introduced in r102201 to split the executables out of
1277         WebKit.gyp apparently doesn't work right on Windows, since
1278         WebKit.gyp and Tools.gyp refer to dependent projects by
1279         different relative paths (it appears gyp doesn't normalize the
1280         paths). This change moves Tools.gyp to be in the same directory
1281         as WebKit.gyp (and All.gyp), which should fix this and
1282         conveniently will also solve the problem of how to add Tools.gyp
1283         to the chromium DEPS file.
1284
1285         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
1286
1287 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1288
1289         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
1290         https://bugs.webkit.org/show_bug.cgi?id=74173
1291
1292         Reviewed by Ryosuke Niwa.
1293
1294         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1295         This requires to remove top-level code. This patch is one of the incremental refactorings
1296         for that.
1297
1298         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
1299         (fetchBugDescriptionFromURL):
1300
1301 2011-12-09  Tony Chang  <tony@chromium.org>
1302
1303         Switch the chromium mac bots to using skia test results
1304         https://bugs.webkit.org/show_bug.cgi?id=74201
1305
1306         Reviewed by Ryosuke Niwa.
1307
1308         This is reverting http://trac.webkit.org/changeset/97781 and changing
1309         the name in master.cfg to no longer have cg in the name.
1310
1311         * BuildSlaveSupport/build.webkit.org-config/config.json:
1312         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1313         (appendCustomBuildFlags):
1314         (RunWebKitTests.start):
1315
1316 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1317
1318         [Qt] Remove a wrongly placed ASSERT.
1319
1320         Reviewed by Tor Arne Vestbø.
1321
1322         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1323         (MiniBrowserApplication::notify):
1324
1325 2011-12-09  Cary Clark  <caryclark@google.com>
1326
1327         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
1328         https://bugs.webkit.org/show_bug.cgi?id=74118
1329
1330         Reviewed by Adam Barth.
1331
1332         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1333         (get):
1334         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1335         (ChromiumMacPort.__init__):
1336         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1337         (ChromiumMacPortTest.test_versions):
1338         (ChromiumMacPortTest.test_graphics_type):
1339
1340 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1341
1342         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
1343
1344         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
1345         this failed when moving files in the source tree, as the .d file would contain
1346         stale dependencies on the old source file location. By keeping the object files
1347         (and hence the depdendency files) in a proper tree structure inside the objects
1348         directory we can prevent this failure.
1349
1350         A side benefit is that we can also have objects with the same name inside the
1351         same project.
1352
1353         Reviewed by Simon Hausmann.
1354
1355         * qmake/mkspecs/features/unix/default_pre.prf:
1356
1357 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
1358
1359         Unreviewed. Update unit test after r102412.
1360
1361         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1362         (IRCCommandTest.test_whois):
1363
1364 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1365
1366         REGRESSION(r102105): run-bindings-tests should output full diff results
1367         https://bugs.webkit.org/show_bug.cgi?id=74166
1368
1369         Reviewed by Adam Barth.
1370
1371         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
1372         run-bindings-tests should output full diff results.
1373
1374         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
1375         (BindingsTests.generate_from_idl):
1376         (BindingsTests.generate_supplemental_dependency):
1377         (BindingsTests.detect_changes):
1378
1379 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
1380
1381         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
1382         https://bugs.webkit.org/show_bug.cgi?id=73990
1383
1384         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
1385
1386         Fix QtQuick includes after move from QtDeclarative to QtQuick.
1387
1388         * MiniBrowser/qt/BrowserWindow.h:
1389         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1390
1391 2011-12-08  Adam Klein  <adamk@chromium.org>
1392
1393         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
1394         https://bugs.webkit.org/show_bug.cgi?id=73492
1395
1396         Reviewed by Adam Barth.
1397
1398         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
1399         keypress event without any script on the stack.
1400
1401         * DumpRenderTree/chromium/EventSender.cpp:
1402         (EventSender::EventSender):
1403         (EventSender::keyDown):
1404         (KeyDownTask::KeyDownTask):
1405         (KeyDownTask::runIfValid):
1406         (EventSender::scheduleAsynchronousKeyDown):
1407         * DumpRenderTree/chromium/EventSender.h:
1408
1409 2011-12-08  Hayato Ito  <hayato@chromium.org>
1410
1411         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
1412         https://bugs.webkit.org/show_bug.cgi?id=73980
1413
1414         Reviewed by Tony Chang.
1415
1416         * gdb/webkit.py:
1417         (guess_string_length):
1418         (ustring_to_string):
1419         (lstring_to_string):
1420         (LCharStringPrinter):
1421         (LCharStringPrinter.to_string):
1422         (WTFStringImplPrinter.get_length):
1423         (WTFStringImplPrinter.to_string):
1424         (WTFStringImplPrinter.is_8bit):
1425         (WTFStringPrinter.stringimpl_ptr):
1426         (WTFStringPrinter.get_length):
1427         (WTFStringPrinter.to_string):
1428         (add_pretty_printers.lookup_function):
1429
1430 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1431
1432         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
1433         https://bugs.webkit.org/show_bug.cgi?id=73916
1434
1435         Reviewed by Kent Tamura.
1436
1437         * qmake/mkspecs/features/features.prf:
1438
1439 2011-12-08  Adrienne Walker  <enne@google.com>
1440
1441         Unreviewed contributor additions to committers.py.
1442
1443         * Scripts/webkitpy/common/config/committers.py:
1444
1445 2011-12-08  David Reveman  <reveman@chromium.org>
1446
1447         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
1448         https://bugs.webkit.org/show_bug.cgi?id=74017
1449
1450         Reviewed by James Robinson.
1451         
1452         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
1453
1454         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1455         (main):
1456         * DumpRenderTree/chromium/TestShell.cpp:
1457         (TestShell::TestShell):
1458         (TestShell::resetWebSettings):
1459         * DumpRenderTree/chromium/TestShell.h:
1460         (TestShell::setAcceleratedPaintingEnabled):
1461         (TestShell::setPerTilePaintingEnabled):
1462         * DumpRenderTree/chromium/WebPreferences.cpp:
1463         (WebPreferences::reset):
1464         (WebPreferences::applyTo):
1465         * DumpRenderTree/chromium/WebPreferences.h:
1466         * Scripts/webkitpy/layout_tests/port/chromium.py:
1467         (ChromiumDriver._wrapper_options):
1468         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1469         (parse_args):
1470
1471 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
1472
1473         create a "SystemHost" object for webkitpy to slim down the Host object
1474         https://bugs.webkit.org/show_bug.cgi?id=72680
1475
1476         Reviewed by Eric Siedel.
1477
1478         This creates a SystemHost object that other objects that should
1479         only have dependencies on functionality in webkitpy.common.system
1480         can use; this will allow them to not require a full Host.
1481
1482         * Scripts/webkitpy/common/host.py:
1483         * Scripts/webkitpy/common/host_mock.py:
1484         * Scripts/webkitpy/common/system/systemhost.py: Added.
1485         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
1486
1487 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
1488
1489         AX: platform/mac/accessibility/search-with-frames.html crashes
1490         https://bugs.webkit.org/show_bug.cgi?id=74093
1491
1492         Reviewed by Darin Adler.
1493
1494         Take care of the case when an incoming element is null.
1495
1496         * DumpRenderTree/AccessibilityUIElement.cpp:
1497         (uiElementForSearchPredicateCallback):
1498         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1499         (AccessibilityUIElement::uiElementForSearchPredicate):
1500         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1501         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1502
1503 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
1504
1505         [Qt] Visualize mock point ID's in the MiniBrowser
1506         https://bugs.webkit.org/show_bug.cgi?id=74098
1507
1508         Reviewed by Tor Arne Vestbø.
1509
1510         * MiniBrowser/qt/BrowserWindow.cpp:
1511         (BrowserWindow::updateVisualMockTouchPoints):
1512         * MiniBrowser/qt/qml/MockTouchPoint.qml:
1513
1514 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
1515
1516         Accessibility: AccessibilityController should support listening to notifications on all elements.
1517         https://bugs.webkit.org/show_bug.cgi?id=72866
1518
1519         Adds addNotificationListener and removeNotificationListener methods
1520         to AccessibilityController, to listen to notifications on any element
1521         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
1522         implementations are all contained in this change.
1523
1524         On Mac, refactors AccessibilityNotificationHandler into its own
1525         source file that can be used by both AccessibilityController and
1526         AccessibilityUIElement. (Both DRT and WKTR.)
1527
1528         Reviewed by Chris Fleizach.
1529
1530         * DumpRenderTree/AccessibilityController.cpp:
1531         (addNotificationListenerCallback):
1532         (removeNotificationListenerCallback):
1533         (AccessibilityController::getJSClass):
1534         * DumpRenderTree/AccessibilityController.h:
1535         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1536         * DumpRenderTree/chromium/AccessibilityController.cpp:
1537         (AccessibilityController::AccessibilityController):
1538         (AccessibilityController::notificationReceived):
1539         (AccessibilityController::addNotificationListenerCallback):
1540         (AccessibilityController::removeNotificationListenerCallback):
1541         * DumpRenderTree/chromium/AccessibilityController.h:
1542         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1543         (AccessibilityController::addNotificationListener):
1544         (AccessibilityController::removeNotificationListener):
1545         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1546         (AccessibilityController::~AccessibilityController):
1547         (AccessibilityController::addNotificationListener):
1548         (AccessibilityController::removeNotificationListener):
1549         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
1550         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
1551         (-[NSString createJSStringRef]):
1552         (-[AccessibilityNotificationHandler init]):
1553         (-[AccessibilityNotificationHandler setPlatformElement:]):
1554         (-[AccessibilityNotificationHandler dealloc]):
1555         (-[AccessibilityNotificationHandler setCallback:]):
1556         (-[AccessibilityNotificationHandler startObserving]):
1557         (-[AccessibilityNotificationHandler _notificationReceived:]):
1558         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1559         (AccessibilityUIElement::addNotificationListener):
1560         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1561         (notificationListenerProc):
1562         (AccessibilityController::addNotificationListener):
1563         (AccessibilityController::removeNotificationListener):
1564         (AccessibilityController::winNotificationReceived):
1565         (AccessibilityController::winAddNotificationListener):
1566         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1567         (AccessibilityUIElement::addNotificationListener):
1568         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1569         (WTR::AccessibilityController::addNotificationListener):
1570         (WTR::AccessibilityController::removeNotificationListener):
1571         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1572         (WTR::AccessibilityController::logAccessibilityEvents):
1573         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
1574         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
1575         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
1576         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1577         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1578         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
1579         (WTR::AccessibilityController::addNotificationListener):
1580         (WTR::AccessibilityController::removeNotificationListener):
1581         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
1582         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
1583         (-[NSString createJSStringRef]):
1584         (-[AccessibilityNotificationHandler init]):
1585         (-[AccessibilityNotificationHandler setPlatformElement:]):
1586         (-[AccessibilityNotificationHandler dealloc]):
1587         (-[AccessibilityNotificationHandler setCallback:]):
1588         (-[AccessibilityNotificationHandler startObserving]):
1589         (-[AccessibilityNotificationHandler _notificationReceived:]):
1590         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1591         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1592         (WTR::AccessibilityUIElement::verticalScrollbar):
1593         (WTR::AccessibilityUIElement::addNotificationListener):
1594         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1595
1596 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
1597
1598         [Qt][WK2] Unreviewed buildfix after r102352.
1599
1600         * qmake/mkspecs/features/webkit2.prf:
1601
1602 2011-12-08  Adam Roben  <aroben@apple.com>
1603
1604         Make finding crash logs by PID work on Snow Leopard
1605
1606         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
1607         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
1608         read the first line of the crash log and pull the PID out of there.
1609
1610         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
1611         Snow Leopard
1612
1613         Reviewed by Darin Adler.
1614
1615         * Scripts/webkitpy/common/system/crashlogs.py:
1616         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
1617         name and PID for the log, rather than checking the Lion-only app_description extended
1618         attribute. We now also reject the log if the process name doesn't match what we expect.
1619
1620         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1621         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
1622         PID.
1623         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
1624         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
1625         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
1626         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
1627         read, files that actually contain a crash log for some other process, and files that are
1628         misformatted.
1629
1630         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
1631         unused.
1632
1633         * Scripts/webkitpy/common/system/filesystem_mock.py:
1634         (MockFileSystem.__init__): Removed xattr support, which is now unused.
1635         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
1636         ReadableTextFileObject. This function was completely broken before!
1637         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
1638         bugs like the above.
1639         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
1640         things like readline() and seek().
1641
1642         (ReadableTextFileObject.close):
1643         (ReadableTextFileObject.read):
1644         Added. We override the superclass implementation to account for using a StringIO object.
1645
1646         (ReadableTextFileObject.readline):
1647         (ReadableTextFileObject.seek):
1648         Added. These just call through to StringIO.
1649
1650         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1651         (MainTest.test_crash_log):
1652         (MainTest.test_web_process_crash_log):
1653         Changed to use make_mock_crash_report_darwin.
1654
1655 2011-12-06  Jon Lee  <jonlee@apple.com>
1656
1657         [WK2] Add permissions support (73960)
1658         https://bugs.webkit.org/show_bug.cgi?id=73960
1659         <rdar://problem/10357008>
1660
1661         Reviewed by Darin Adler.
1662
1663         Add null function item to comply with added callback to WKPageUIClient.
1664
1665         * MiniBrowser/mac/BrowserWindowController.m:
1666         (-[BrowserWindowController awakeFromNib]):
1667         * WebKitTestRunner/TestController.cpp:
1668         (WTR::TestController::createOtherPage):
1669         (WTR::TestController::initialize):
1670
1671 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
1672
1673         [Qt] Visualize mock points in the Qt MiniBrowser
1674         https://bugs.webkit.org/show_bug.cgi?id=74074
1675
1676         Reviewed by Tor Arne Vestbø.
1677
1678         * MiniBrowser/qt/BrowserWindow.cpp:
1679         (BrowserWindow::updateVisualMockTouchPoints):
1680         * MiniBrowser/qt/BrowserWindow.h:
1681         * MiniBrowser/qt/MiniBrowser.qrc:
1682         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1683         (MiniBrowserApplication::notify):
1684         (MiniBrowserApplication::sendTouchEvent):
1685         * MiniBrowser/qt/MiniBrowserApplication.h:
1686         * MiniBrowser/qt/icons/touchpoint.png: Added.
1687         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
1688
1689 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
1690
1691         [Qt] WebKitTestRunner crashes with debug builds
1692         https://bugs.webkit.org/show_bug.cgi?id=74090
1693
1694         Reviewed by Tor Arne Vestbø.
1695
1696         * WebKitTestRunner/qt/TestControllerQt.cpp:
1697         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
1698         to ensure WTF/JSC threading is initialized.
1699
1700 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
1701
1702         fix build-webkit --chromium after breakage in r102201
1703         https://bugs.webkit.org/show_bug.cgi?id=74031
1704
1705         Reviewed by Tony Chang.
1706
1707         * Scripts/webkitdirs.pm:
1708         (buildChromium):
1709
1710 2011-12-08  Kentaro Hara  <haraken@chromium.org>
1711
1712         Unreviewed, rolling out r102280.
1713         http://trac.webkit.org/changeset/102280
1714         https://bugs.webkit.org/show_bug.cgi?id=74031
1715
1716         Chromium/Windows build is broken
1717
1718         * Scripts/webkitdirs.pm:
1719         (buildChromium):
1720
1721 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
1722
1723         Adding myself to committers list.
1724
1725         Unreviewed.
1726
1727         * Scripts/webkitpy/common/config/committers.py:
1728
1729 2011-12-07  Michael Saboff  <msaboff@apple.com>
1730
1731         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
1732         https://bugs.webkit.org/show_bug.cgi?id=73995
1733
1734         Reenabled failing tests that the code part of the patch fixes.
1735
1736         Reviewed by Geoffrey Garen.
1737
1738         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1739         (TestWebKitAPI::TEST):
1740
1741 2011-12-07  MORITA Hajime  <morrita@google.com>
1742
1743         [filter-build-webkit] should not emit reset color when --no-color is given
1744         https://bugs.webkit.org/show_bug.cgi?id=73992
1745
1746         Reviewed by Daniel Bates.
1747
1748         Stop printing control sequences when --no-color is given.
1749         After this change, the filter runs nicely even on environments
1750         like Emacs compilation-mode which cannot understand the control sequence.
1751
1752         * Scripts/filter-build-webkit:
1753         (printLine):
1754
1755 2011-12-07  Eric Seidel  <eric@webkit.org>
1756
1757         Use free memory to determine if we have space for DRT instances instead of total memory
1758         https://bugs.webkit.org/show_bug.cgi?id=74021
1759
1760         Reviewed by Adam Barth.
1761
1762         This will hopefully make the Mac buildbots behave better.
1763
1764         I also reduced the expected memory needed per DRT now that
1765         we're properly accounting for the system memory in our calculations.
1766
1767         * Scripts/webkitpy/common/system/platforminfo.py:
1768         (PlatformInfo.total_bytes_memory):
1769         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
1770         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1771         (MockPlatformInfo.total_bytes_memory):
1772         * Scripts/webkitpy/layout_tests/port/base.py:
1773         (Port.default_child_processes):
1774         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1775         (PortTest.test_default_child_processes):
1776
1777 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
1778
1779         fix build-webkit --chromium after breakage in r102201
1780         https://bugs.webkit.org/show_bug.cgi?id=74031
1781
1782         Reviewed by Tony Chang.
1783
1784         r102201 introduced a change to the chromium build that splits
1785         the executables out of WebKit.gyp into other gyp files, and adds
1786         a new "All.gyp" that builds everything. However, I forgot to
1787         update the build script to use All.gyp.
1788
1789         * Scripts/webkitdirs.pm:
1790         (buildChromium):
1791
1792 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
1793
1794         Moved myself to the committers list.
1795
1796         * Scripts/webkitpy/common/config/committers.py:
1797
1798 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
1799
1800         [Qt] Fix debug shlib build with V8.
1801
1802         Reviewed by Tor Arne Vestbø.
1803
1804         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
1805         v8 builds.
1806
1807 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
1808
1809         [Qt] V8 build fixes.
1810
1811         Reviewed by Tor Arne Vestbø.
1812
1813         * qmake/mkspecs/features/javascriptcore.prf: Don't add
1814         Source/Thirdparty to the include search path here.
1815         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
1816         used when building WebCore as well as using it, because header files like
1817         GraphicsContext3D.h include stuff from ThirdParty.
1818
1819 2011-12-07  Peter Beverloo  <peter@chromium.org>
1820
1821         [Chromium] Fix project file generation for the Android bot after r102201
1822         https://bugs.webkit.org/show_bug.cgi?id=73996
1823
1824         The gyp refactoring in r102201 was didn't explicitly exclude
1825         the Android operating system in Tools/Tools.gyp, which broke
1826         as gcc_version is not defined for that configuration.
1827
1828         Reviewed by Andreas Kling.
1829
1830         * Tools.gyp:
1831
1832 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
1833
1834         Unreviewed. Disabled failing tests on chromium.
1835
1836         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1837         (TestWebKitAPI::TEST):
1838
1839 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
1840
1841         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
1842         https://bugs.webkit.org/show_bug.cgi?id=73382
1843
1844         Reviewed by Tony Chang.
1845
1846         XCode (and hence GYP) can't handle circular dependencies between
1847         files (and projects). Accordingly, although the binaries in
1848         WebKit.gyp depend on webkit_support and webkit_support depends
1849         on webkit, we don't mention the latter dependency in the file.
1850         To fix this, this change moves the binaries like DRT into a new
1851         GYP file, and modifies gyp_webkit to build from that file
1852         instead of WebKit.gyp.
1853
1854         * Tools.gyp: Added.
1855
1856 2011-12-06  Adam Roben  <aroben@apple.com>
1857
1858         Add a pid parameter to CrashLogs.find_newest_log
1859
1860         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
1861         considered.
1862
1863         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
1864         process whose crash log you want to find
1865
1866         Reviewed by Dirk Pranke.
1867
1868         * Scripts/webkitpy/common/system/crashlogs.py:
1869         (CrashLogs.find_newest_log): Added an optional pid parameter.
1870         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
1871         candidate log's app_description extended attribute to see if that log corresponds to a
1872         crashed process with the specified PID.
1873
1874         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1875         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
1876         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
1877         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
1878
1879         * Scripts/webkitpy/common/system/filesystem.py:
1880         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
1881         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
1882         present.
1883
1884         * Scripts/webkitpy/common/system/filesystem_mock.py:
1885         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
1886         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
1887         dictionary.
1888
1889         * Scripts/webkitpy/tool/commands/queries.py:
1890         (CrashLog): Added help text. Added an optional PID parameter.
1891         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
1892
1893 2011-12-06  Adam Roben  <aroben@apple.com>
1894
1895         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
1896
1897         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
1898         alive beyond the normal timeout limit. In cases where the crashed process was able to die
1899         faster, NRWT would assume that Crash Reporter had finished even though it often was still
1900         running, which would lead to an incorrect crash log being picked up.
1901
1902         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
1903
1904         Reviewed by Dirk Pranke.
1905
1906         * Scripts/webkitpy/layout_tests/port/server_process.py:
1907         (ServerProcess._reset):
1908         (ServerProcess.write):
1909         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
1910         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
1911         set_crashed.
1912
1913         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
1914         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
1915         we bail out of handling the failure as a timeout if we find out that the process in fact
1916         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
1917         so.
1918         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
1919         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
1920         disk.
1921
1922         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1923         (TrivialMockPort.is_crash_reporter): Added.
1924
1925         * Scripts/webkitpy/layout_tests/port/webkit.py:
1926         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
1927         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
1928
1929 2011-12-06  Adam Barth  <abarth@webkit.org>
1930
1931         NRWT fails on unreleased versions of Mac OS X
1932         https://bugs.webkit.org/show_bug.cgi?id=72748
1933
1934         Reviewed by Dirk Pranke.
1935
1936         Hopefully this patch will make NRWT work on future versions on Mac OS X.
1937         Most of the infrastructure was already in place, but there were some
1938         asserts that failed.  I've tested this patch by haxoring the version
1939         detection logic to simulate an unknown version.  We might need to
1940         iterate based on feedback from folks with a real future version.
1941
1942         * Scripts/webkitpy/layout_tests/port/apple.py:
1943         (ApplePort.__init__):
1944             - mac-future is an allowed port_name that's used internally by
1945               webkitpy to represent future versions of Mac OS X.
1946         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1947         (test_versions):
1948             - Test that we don't throw exceptions when dealing with future
1949               versions of Mac OS X.
1950         * Scripts/webkitpy/layout_tests/port/webkit.py:
1951         (WebKitPort._expectations_from_skipped_files):
1952             - Demote this logging message to "debug".  It's expected that
1953               mac-future doesn't have a Skipped file.
1954         * Scripts/webkitpy/layout_tests/port/mac.py:
1955         (MacPort.__init__):
1956         * Scripts/webkitpy/layout_tests/port/win.py:
1957         (WinPort.__init__):
1958             - Re-order some code in these constructors so that
1959               self._operating_system is available to the ApplePort constructor.
1960
1961 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
1962
1963         Added myself as a committer.
1964
1965         * Scripts/webkitpy/common/config/committers.py:
1966
1967 2011-12-06  Peter Beverloo  <peter@chromium.org>
1968
1969         Added myself as a committer.
1970
1971         * Scripts/webkitpy/common/config/committers.py:
1972
1973 2011-12-06  Kentaro Hara  <haraken@chromium.org>
1974
1975         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
1976         https://bugs.webkit.org/show_bug.cgi?id=73637
1977
1978         Reviewed by Adam Barth.
1979
1980         This patch replaces subprocess.Popen() with Executive, similar to other
1981         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
1982         works well for cases where no exception is raised, no exception is raised
1983         but diff is found, and ScriptError is raised.
1984
1985         * Scripts/run-bindings-tests:
1986         (main):
1987         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
1988         (BindingsTests.__init__):
1989         (BindingsTests.generate_from_idl):
1990         (BindingsTests.generate_supplemental_dependency):
1991         (BindingsTests.detect_changes):
1992
1993 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1994
1995         [Qt] MiniBrowser should default to touch behavior
1996         https://bugs.webkit.org/show_bug.cgi?id=73863
1997
1998         Reviewed by Chang Shu.
1999
2000         MiniBrowser currently defaults to the traditional desktop behaviour
2001         instead of touch behaviour which is prefered.
2002
2003         * MiniBrowser/qt/BrowserWindow.cpp:
2004         (BrowserWindow::BrowserWindow):
2005         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2006         (printHelp):
2007         (MiniBrowserApplication::handleUserOptions):
2008         * MiniBrowser/qt/MiniBrowserApplication.h:
2009         (WindowOptions::WindowOptions):
2010         (WindowOptions::setUseTraditionalDesktopBehavior):
2011         (WindowOptions::useTraditionalDesktopBehavior):
2012
2013 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2014
2015         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
2016         https://bugs.webkit.org/show_bug.cgi?id=73878
2017
2018         Reviewed by Tony Chang.
2019
2020         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
2021         r98785 made webkit.py always use m_data16, which does not work when
2022         the string is an 8-bit string (such as KURL::string()).
2023
2024         I was not able to directly call StringImpl::is8Bit() in the Python
2025         code, so I just reproduced the implementation there.
2026
2027         * gdb/webkit.py:
2028         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2029         (WTFStringPrinter.to_string):
2030         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2031         (JSCUStringPrinter.to_string):
2032
2033 2011-12-05  Eric Seidel  <eric@webkit.org>
2034
2035         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
2036         in hopes of making the Snow Leopard bot stop timing out.
2037
2038         Unreviewed.
2039
2040         * Scripts/webkitpy/layout_tests/port/base.py:
2041         (Port.default_child_processes):
2042         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2043         (PortTest.test_default_child_processes):
2044
2045 2011-12-05  Eric Seidel  <eric@webkit.org>
2046
2047         NRWT creates too many workers on RAM-limited machines
2048         https://bugs.webkit.org/show_bug.cgi?id=73847
2049
2050         Reviewed by Dirk Pranke.
2051
2052         Make NRWT restrict its number of workers when there isn't enough
2053         RAM to support them.
2054         Also re-enable parallel testing on the Mac bots which were
2055         failing due to not enough ram.
2056
2057         * Scripts/run-webkit-tests:
2058         (platformIsReadyForParallelTesting):
2059         * Scripts/webkitpy/common/host.py:
2060         (Host.__init__):
2061         * Scripts/webkitpy/common/system/executive_mock.py:
2062         (MockExecutive.cpu_count):
2063         * Scripts/webkitpy/common/system/platforminfo.py:
2064         (PlatformInfo.__init__):
2065         (PlatformInfo.display_name):
2066         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2067         (MockPlatformInfo.display_name):
2068         * Scripts/webkitpy/layout_tests/port/base.py:
2069         (Port.default_child_processes):
2070         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2071         (PortTest.test_default_child_processes):
2072         (PortTest.test_pretty_patch_os_error):
2073
2074 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
2075
2076         Last mouse event could be lost if a JS call to eventSender.leapForward is made
2077         https://bugs.webkit.org/show_bug.cgi?id=73366
2078
2079         Reviewed by Kenneth Rohde Christiansen.
2080
2081         Empty the entire event queue when requested besides using
2082         sendEvent instead of postEvent to make sure all events were
2083         delivered.
2084
2085         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2086         (WTR::EventSenderProxy::EventSenderProxy):
2087         (WTR::EventSenderProxy::sendOrQueueEvent):
2088         (WTR::EventSenderProxy::replaySavedEvents):
2089
2090 2011-12-05  Adam Barth  <abarth@webkit.org>
2091
2092         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
2093         https://bugs.webkit.org/show_bug.cgi?id=73845
2094
2095         Reviewed by Darin Fisher.
2096
2097         Update includes to point to the new header locations.
2098
2099         * DumpRenderTree/chromium/AccessibilityController.cpp:
2100         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2101         * DumpRenderTree/chromium/CppBoundClass.cpp:
2102         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2103         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2104         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2105         * DumpRenderTree/chromium/EventSender.cpp:
2106         * DumpRenderTree/chromium/EventSender.h:
2107         * DumpRenderTree/chromium/GamepadController.h:
2108         * DumpRenderTree/chromium/LayoutTestController.cpp:
2109         * DumpRenderTree/chromium/LayoutTestController.h:
2110         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2111         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2112         * DumpRenderTree/chromium/PlainTextController.cpp:
2113         * DumpRenderTree/chromium/Task.cpp:
2114         * DumpRenderTree/chromium/TestNavigationController.h:
2115         * DumpRenderTree/chromium/TestShell.cpp:
2116         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2117         * DumpRenderTree/chromium/TestWebPlugin.h:
2118         * DumpRenderTree/chromium/TextInputController.cpp:
2119         * DumpRenderTree/chromium/WebPermissions.cpp:
2120         * DumpRenderTree/chromium/WebPreferences.h:
2121         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2122         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2123         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2124         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2125         * DumpRenderTree/chromium/WebViewHost.cpp:
2126
2127 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2128
2129         Add Aharon Lanin to the contributors list.
2130
2131         * Scripts/webkitpy/common/config/committers.py:
2132
2133 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
2134
2135         Moving myself from contributors to committers.
2136
2137         * Scripts/webkitpy/common/config/committers.py:
2138
2139 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2140
2141         Add myself as a committer.
2142
2143         * Scripts/webkitpy/common/config/committers.py:
2144
2145 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
2146
2147         [Qt] Rename QQuickWebView::canStop property to just loading 
2148         https://bugs.webkit.org/show_bug.cgi?id=73813
2149
2150         Reviewed by Kenneth Rohde Christiansen.
2151
2152         Replaced references to WebView.canStop with WebView.loading.
2153
2154         * MiniBrowser/qt/qml/BrowserWindow.qml:
2155
2156 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
2157
2158         run-webkit-tests: limit --child-processes properly on apple mac
2159         https://bugs.webkit.org/show_bug.cgi?id=73856
2160
2161         Reviewed by Adam Roben.
2162
2163         Fix typos in r102013 so that we correctly pass --child-processes=1 on
2164         the apple mac bots temporarily.
2165
2166         * Scripts/run-webkit-tests:
2167         (platformIsReadyForParallelTesting):
2168
2169 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2170
2171         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
2172         https://bugs.webkit.org/show_bug.cgi?id=73840
2173
2174         Reviewed by Simon Fraser.
2175
2176         Temporarily go back to single process mode on Mac.
2177
2178         * Scripts/run-webkit-tests:
2179         (platformIsReadyForParallelTesting):
2180
2181 2011-12-05  Adam Roben  <aroben@apple.com>
2182
2183         Redeploy apple-macpro-7 and apple-xserve-1
2184
2185         These slaves have been sitting idle since we removed our Leopard builders in r97496.
2186
2187         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
2188         sitting idle
2189
2190         Reviewed by Sam Weinig.
2191
2192         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
2193         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
2194         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
2195         (WebKit2 Tests)".
2196
2197 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2198
2199         [Qt] Make the UI of the MiniBrowser slightly nicer
2200
2201         Rubberstamped by Simon Hausmann.
2202
2203         - Add proper padding
2204         - Show feedback when pressing on the toolbar icons
2205         - Make the text entry better looking
2206
2207         * MiniBrowser/qt/qml/BrowserWindow.qml:
2208
2209 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2210
2211         NRWT should handle duplicated expectations
2212         https://bugs.webkit.org/show_bug.cgi?id=69750
2213
2214         Reviewed by Dirk Pranke.
2215
2216         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2217         (TestExpectations.__init__):
2218         (TestExpectations._report_errors):
2219         (TestExpectations._add_expectations):
2220         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2221         (test_add_skipped_tests):
2222         * Scripts/webkitpy/layout_tests/port/base.py:
2223         (Port.skipped_tests):
2224         * Scripts/webkitpy/layout_tests/port/webkit.py:
2225         (WebKitPort.test_expectations):
2226         (WebKitPort.skipped_tests):
2227         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2228         (test_test_expectations):
2229
2230 2011-12-04  Eric Seidel  <eric@webkit.org>
2231
2232         After success with Mac, Win and Gtk, turning on parallel testing
2233         by default for all platforms (except Qt).
2234
2235         We'll add more platforms to the blacklist if we see problems.
2236
2237         Unreviewed.
2238
2239         * Scripts/run-webkit-tests:
2240         (platformIsReadyForParallelTesting):
2241
2242 2011-12-04  Sam Weinig  <sam@webkit.org>
2243
2244         Add tests for RetainPtr::adoptNS/adoptCF
2245         https://bugs.webkit.org/show_bug.cgi?id=73470
2246
2247         Reviewed by Adam Roben and Darin Adler.
2248
2249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2250         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
2251         (TestWebKitAPI::TEST):
2252         Test that adopting using adoptCF creates a RetainPtr with a
2253         value whose retain count is 1.
2254
2255         * TestWebKitAPI/Tests/WTF/ns: Added.
2256         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
2257         (TestWebKitAPI::TEST):
2258         Test that adopting using adoptNS creates a RetainPtr with a
2259         value whose retain count is 1.
2260
2261 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
2262
2263         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
2264         https://bugs.webkit.org/show_bug.cgi?id=73748
2265
2266         Reviewed by Gustavo Noronha Silva.
2267
2268         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
2269
2270 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2271
2272         Another GTK build fix after r101922.
2273
2274         Rubber-stamped by Martin Robinson.
2275
2276         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2277         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
2278
2279 2011-12-04  Xan Lopez  <xlopez@igalia.com>
2280
2281         Fix compiler warning in LayoutTestController
2282
2283         Reviewed by Philippe Normand.
2284
2285         * DumpRenderTree/LayoutTestController.cpp:
2286         (LayoutTestController::LayoutTestController): fix warning.
2287
2288 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
2289
2290         Add missing methods used by fast/notifications tests to LayoutTestController
2291         https://bugs.webkit.org/show_bug.cgi?id=63616
2292
2293         Reviewed by Martin Robinson.
2294
2295         Add missing simulateDesktopNotificationClick method used by
2296         fast/notifications. Provide a default implementation for
2297         areDesktopNotificationPermissionRequestsIgnored and
2298         ignoreDesktopNotificationPermissionRequests.
2299
2300         * DumpRenderTree/LayoutTestController.cpp:
2301         (LayoutTestController::LayoutTestController): call into the port implementation.
2302         (simulateDesktopNotificationClickCallback): ditto.
2303         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
2304         (LayoutTestController::staticFunctions): declare new methods.
2305         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
2306         * DumpRenderTree/LayoutTestController.h:
2307         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
2308         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2309         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
2310         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2311         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2312         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2313         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2314         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2315         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2316         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2317         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2318
2319 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
2320
2321         [GTK] Don't log document events in DRT
2322         https://bugs.webkit.org/show_bug.cgi?id=73746
2323
2324         Reviewed by Martin Robinson.
2325
2326         Stop connecting globally to document-related events.
2327
2328         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2329         (connectAccessibilityCallbacks): Removed connections.
2330         (disconnectAccessibilityCallbacks): Removed disconnections.
2331
2332 2011-12-03  Dan Bernstein  <mitz@apple.com>
2333
2334         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
2335
2336         Reviewed by Darin Adler.
2337
2338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2339         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
2340         (TestWebKitAPI::TEST):
2341
2342 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2343
2344         Another GTK build fix after r101922.
2345
2346         Rubber-stamped by Martin James Robinson.
2347
2348         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2349         (LayoutTestController::pathToLocalResource): return value needs to
2350         be a URI.
2351
2352 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2353
2354         Small fix for my previous patch. Do not try to delete a member
2355         of a dictionary that does not exist.
2356
2357         Reviewed by Gustavo Noronha Silva.
2358
2359         * gtk/run-with-jhbuild:
2360         (install_and_run_jhbuild):
2361
2362 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2363
2364         Fix jhbuild installation for people who have unusual MAKE environment
2365         variables such as 'make -j4' as the jhbuild build does not handle it.
2366
2367         Reviewed by Gustavo Noronha Silva.
2368
2369         * gtk/run-with-jhbuild:
2370         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
2371
2372 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2373
2374         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
2375         when run for the first time.
2376
2377         Reviewed by Gustavo Noronha Silva.
2378
2379         * Scripts/update-webkitgtk-libs: Fix first run.
2380
2381 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2382
2383         Unreviewed, GTK build fix after r101922.
2384
2385         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2386         (LayoutTestController::pathToLocalResource): Added sentinel in
2387         g_build_filename call.
2388
2389 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2390
2391         GTK API tests build fix. Run the tests inside jhbuild.
2392
2393         Rubber-stamped by Gustavo Noronha Silva.
2394
2395         * Scripts/run-gtk-tests:
2396         (TestRunner.__init__):
2397         (TestRunner.run._error_handler):
2398         (TestRunner):
2399         (TestRunner.run):
2400
2401 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2402
2403         Small build fix. Properly specify the path to the locally installed jhbuild.
2404
2405         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
2406
2407 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2408
2409         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2410         https://bugs.webkit.org/show_bug.cgi?id=67256
2411
2412         Reviewed by Philippe Normand.
2413
2414         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing 
2415         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
2416         which points to the more generic top-level path of the WebKit checkout. This code is
2417         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
2418         share code here.
2419
2420         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
2421         location. This will cause the fallback to fail if you build into a non-typical location
2422         or even fake it with a symlink. In this case it's important to use the environment variable.
2423
2424         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2425         (getTopLevelPath): Added.
2426         (initializeFonts): Use the new helper to get the font path.
2427         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
2428         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2429         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
2430         test paths.
2431         * Scripts/webkitpy/layout_tests/port/gtk.py:
2432         (GtkPort.setup_environ_for_server):Pass the top-level path of the
2433         checkout instead of passing the font path.
2434         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2435         (WTR::getTopLevelPath): Added this helper.
2436         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
2437
2438 2011-12-02  David Levin  <levin@chromium.org>
2439
2440         Rename WTF class from TemporarilyChange to TemporaryChange.
2441         https://bugs.webkit.org/show_bug.cgi?id=73479
2442
2443         Reviewed by Eric Seidel.
2444
2445         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
2446         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
2447         * TestWebKitAPI/TestWebKitAPI.gypi:
2448         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2449         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
2450         (TestWebKitAPI::TEST):
2451         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2452
2453 2011-12-02  Tony Chang  <tony@chromium.org>
2454
2455         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
2456         https://bugs.webkit.org/show_bug.cgi?id=73453
2457
2458         Reviewed by Ryosuke Niwa.
2459
2460         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
2461         The verbose output will include the failure reason.
2462
2463         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
2464         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2465         (write_test_result):
2466         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
2467         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
2468         (determine_result_type):
2469         (FailureReftestNoImagesGenerated.__init__):
2470         (FailureReftestNoImagesGenerated):
2471         (FailureReftestNoImagesGenerated.message):
2472         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
2473         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
2474         (MainTest.test_run_singly_actually_runs_tests):
2475         (MainTest.test_unexpected_failures):
2476         (EndToEndTest.test_end_to_end):
2477
2478 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
2479
2480         ChangeLog should be able to parse annotated changelogs
2481         https://bugs.webkit.org/show_bug.cgi?id=72703
2482
2483         Reviewed by Eric Seidel.
2484
2485         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
2486         and extract the revision number for each entry.
2487
2488         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
2489
2490         * Scripts/webkitpy/common/checkout/changelog.py:
2491         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2492         * Scripts/webkitpy/common/checkout/scm/git.py:
2493         * Scripts/webkitpy/common/checkout/scm/scm.py:
2494         * Scripts/webkitpy/common/checkout/scm/svn.py:
2495
2496 2011-12-02  Eric Seidel  <eric@webkit.org>
2497
2498         Enable parallel testing for Win and Gtk bots
2499         after confirming with Lucas and Martin the bots should be OK.
2500
2501         Unreviewed. (I ran the idea by Lucas and Martin.)
2502
2503         * Scripts/run-webkit-tests:
2504         (platformIsReadyForParallelTesting):
2505
2506 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
2507
2508         Try to fix the GTK+ build.
2509
2510         * gtk/jhbuild.modules: Properly specify the glib-networking
2511         dependency for soup.
2512
2513 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
2514
2515         Fix a syntax error in the committers.py file.
2516
2517         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
2518
2519 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
2520
2521         Add Alan Stearns and Peter Linss to the contributors list.
2522
2523         * Scripts/webkitpy/common/config/committers.py:
2524
2525 2011-12-02  Kent Tamura  <tkent@chromium.org>
2526
2527         [Chromium] Fix compilation warnings for ASSERT()
2528         https://bugs.webkit.org/show_bug.cgi?id=73623
2529
2530         Reviewed by Tony Chang.
2531
2532         * DumpRenderTree/chromium/ImageDiff.cpp:
2533          - Fix fprintf format: %s -> %d for __LINE__
2534          - Do nothing for ASSERT() if NDEBUG.
2535
2536 2011-12-02  Eric Seidel  <eric@webkit.org>
2537
2538         Enable parallel testing for all Mac bots.
2539
2540         Unreviewed.
2541
2542         * Scripts/run-webkit-tests:
2543         (platformIsReadyForParallelTesting):
2544
2545 2011-12-02  Eric Seidel  <eric@webkit.org>
2546
2547         Enable parallel testing for run-webkit-tests on Mac Lion.
2548         I plan to move all the machines to parallel testing shortly
2549         but we're starting with Lion.
2550
2551         Unreviewed.
2552
2553         * Scripts/run-webkit-tests:
2554         (platformIsReadyForParallelTesting):
2555
2556 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
2557
2558         Added helper method to identify whether the page has custom page size style.
2559         https://bugs.webkit.org/show_bug.cgi?id=73585
2560
2561         Reviewed by Darin Fisher.
2562
2563         * DumpRenderTree/chromium/LayoutTestController.cpp:
2564         (LayoutTestController::LayoutTestController):
2565         (LayoutTestController::hasCustomPageSizeStyle):
2566         * DumpRenderTree/chromium/LayoutTestController.h:
2567
2568 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
2569
2570         [NRWT] reftest should support having multiple references per test
2571         https://bugs.webkit.org/show_bug.cgi?id=73613
2572
2573         Reviewed by Dirk Pranke.
2574
2575         Add a support for having multiple reference files for a single test.
2576
2577         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
2578         at least one of expected mismatches, we compare expected mismatches first in order to minimize
2579         the number of reference files to open on DRT.
2580
2581         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2582         (interpret_test_failures): Remove checks no longer applicable.
2583         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2584         (ResultSummaryTest.test_interpret_test_failures): Ditto.
2585         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2586         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
2587         (SingleTestRunner._driver_input):
2588         (SingleTestRunner.run):
2589         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
2590         * Scripts/webkitpy/layout_tests/models/test_input.py:
2591         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
2592         * Scripts/webkitpy/layout_tests/port/base.py:
2593         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
2594         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
2595         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2596         (PortTest.test_parse_reftest_list):
2597         * Scripts/webkitpy/layout_tests/port/test.py:
2598         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2599         (MainTest.test_unexpected_failures):
2600         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
2601         (EndToEndTest.test_end_to_end):
2602         (EndToEndTest.test_reftest_with_two_notrefs): Added.
2603
2604 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2605
2606         Build libsoup without gnome dependencies (like keyring).
2607
2608         * gtk/jhbuild.modules:
2609
2610 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2611
2612         Also build gcrypt and p11-kit, and make them dependencies of
2613         gnutls.
2614
2615         * gtk/jhbuild.modules:
2616
2617 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
2618
2619         [wx] Unreviewed build fixes for Windows build.
2620
2621         * waf/build/wxpresets.py:
2622
2623 2011-12-01  Eric Seidel  <eric@webkit.org>
2624
2625         Reviewed by Adam Barth.
2626
2627         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
2628         https://bugs.webkit.org/show_bug.cgi?id=32006
2629
2630         I decided not to make it warn, and just have it re-open the bug.
2631         That's not that different from today's behavior which will
2632         just silently attach the patch.
2633
2634         This patch makes behavior between upload and land-safely consistent
2635         (previously one would assign patches and the other would not)
2636         as well as adds the ability for both to ensure that the bug is open.
2637
2638         To test this I had to add a few more methods to MockBugzilla which
2639         (positively) affected a few other test results.
2640
2641         I also made AbstractStep keep a cached copy of the Bug object
2642         and used the cached copy where appropriate (including for 'bug_title').
2643         This should reduce the number of bug fetches we perform.
2644
2645         * Scripts/webkitpy/tool/commands/download_unittest.py:
2646         * Scripts/webkitpy/tool/commands/upload.py:
2647         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2648         * Scripts/webkitpy/tool/mocktool.py:
2649         * Scripts/webkitpy/tool/steps/__init__.py:
2650         * Scripts/webkitpy/tool/steps/abstractstep.py:
2651         * Scripts/webkitpy/tool/steps/closebug.py:
2652         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
2653         * Scripts/webkitpy/tool/steps/postdiff.py:
2654         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
2655         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2656         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2657         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2658
2659 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2660
2661         Also pass --no-interact to jhbuild when updating dependencies.
2662
2663         * Scripts/update-webkitgtk-libs:
2664
2665 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
2666
2667         Make _build_path check more thoroughly that build paths exist.
2668         https://bugs.webkit.org/show_bug.cgi?id=73601
2669
2670         Reviewed by Ojan Vafai.
2671
2672         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2673         (ChromiumMacPort._build_path):
2674
2675 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2676
2677         Add libffi to the jhbuild modules list as a glib dependency.
2678
2679         Rubber-stamped by Martin Robinson.
2680
2681         * gtk/jhbuild.modules:
2682
2683 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2684
2685         Build fix. Use internal pcre on glib, make gnutls a dependency of
2686         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
2687         in non-interactive mode.
2688
2689         * Scripts/update-webkitgtk-libs:
2690         * gtk/jhbuild.modules:
2691         * gtk/run-with-jhbuild:
2692
2693 2011-12-02  Adam Roben  <aroben@apple.com>
2694
2695         Fix for Python 2.6
2696
2697         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2698         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
2699         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
2700         searching for "Tests that timed out:" etc. This makes our check less strict, but it
2701         shouldn't matter given the kinds of content we parse.
2702
2703 2011-12-02  Adam Roben  <aroben@apple.com>
2704
2705         Fix names of failed/timed out tests in run-api-tests output
2706
2707         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
2708         out tests
2709
2710         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
2711
2712         Reviewed by Simon Fraser.
2713
2714         * Scripts/run-api-tests:
2715         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
2716         of this function.
2717
2718 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
2719
2720         [GTK] generate-gtkdoc should respect build type
2721         https://bugs.webkit.org/show_bug.cgi?id=73296
2722
2723         Reviewed by Philippe Normand.
2724
2725         * Scripts/webkitdirs.pm:
2726         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
2727         * gtk/common.py: If --build is passed give preference to the Debug build directory.
2728
2729 2011-12-02  Tony Chang  <tony@chromium.org>
2730
2731         [nrwt] fix wdiff output
2732         https://bugs.webkit.org/show_bug.cgi?id=73604
2733
2734         Reviewed by Adam Barth.
2735
2736         * Scripts/webkitpy/layout_tests/port/base.py:
2737         (Port.wdiff_text):
2738         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2739         (PortTest.test_wdiff_text):
2740
2741 2011-12-02  Adam Roben  <aroben@apple.com>
2742
2743         Teach build.webkit.org to display how many unit tests failed or timed out
2744
2745         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
2746         build.webkit.org
2747
2748         We now display something like "5 unit tests failed or timed out". Eventually we might want
2749         to split out how many failure vs. timeouts there were.
2750
2751         Reviewed by Darin Adler.
2752
2753         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2754         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
2755         classes that may want to subclass it.
2756         (RunUnitTests): Changed to inherit from TestWithFailureCount.
2757         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
2758         timed out:" and "Tests that failed:" lines, if present.
2759
2760         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2761         (StubStdio):
2762         (StubRemoteCommand):
2763         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
2764
2765         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
2766         the test run correctly.
2767
2768         (RunUnitTestsTest.test_no_failures_or_timeouts):
2769         (RunUnitTestsTest.test_one_failure):
2770         (RunUnitTestsTest.test_multiple_failures):
2771         (RunUnitTestsTest.test_one_timeout):
2772         (RunUnitTestsTest.test_multiple_timeouts):
2773         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
2774         Test various cases.
2775
2776 2011-12-02  Adam Roben  <aroben@apple.com>
2777
2778         Teach prepare-ChangeLog to treat master.cfg as a Python file
2779
2780         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
2781         in buildbot's master.cfg
2782
2783         Reviewed by Darin Adler.
2784
2785         * Scripts/prepare-ChangeLog:
2786         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
2787         master.cfg.
2788
2789 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
2790
2791         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
2792         https://bugs.webkit.org/show_bug.cgi?id=73669
2793
2794         Reviewed by Gustavo Noronha Silva.
2795
2796         Add a wrapper script that knows how to install jhbuild and also to wrap commands
2797         in the jhbuild shell.
2798
2799         * Scripts/webkitdirs.pm:
2800         (runAutogenForAutotoolsProject): Use the new wrapper script.
2801         (mustReRunAutogen): Ditto.
2802         (buildAutotoolsProject): Ditto.
2803         * Scripts/webkitpy/layout_tests/port/gtk.py:
2804         (GtkDriver.cmd_line): Ditto.
2805         * gtk/run-with-jhbuild: Added.
2806
2807 2011-12-01  Adam Roben  <aroben@apple.com>
2808
2809         Teach check-webkit-style how to check the syntax of JSON files
2810
2811         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
2812
2813         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
2814         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
2815         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
2816         been removed, since its output differs by platform.
2817
2818         Reviewed by Darin Adler.
2819
2820         * Scripts/webkitpy/style/checker.py:
2821         (_all_categories): Added JSONChecker's categories to the set of all categories.
2822         (FileType): Added a JSON type. Incremented other types.
2823         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
2824         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
2825
2826         * Scripts/webkitpy/style/checker_unittest.py:
2827         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
2828         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
2829
2830         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
2831         which would have matched our other checkers, because I couldn't figure out how to call
2832         "json.loads" without hitting namespace conflicts.)
2833         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
2834         just the modified lines from a patch.
2835         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
2836         exception.
2837         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
2838         try to extract a line number.
2839
2840         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
2841         (MockErrorHandler.__init__):
2842         (MockErrorHandler.turn_off_line_filtering):
2843         (MockErrorHandler.__call__):
2844         Helper class. Copied from xml_unittest.py.
2845
2846         (JSONCheckerTest.test_line_number_from_json_exception): Test the
2847         line_number_from_json_exception helper method.
2848
2849         (JSONCheckerTest.assert_no_error):
2850         (JSONCheckerTest.assert_error):
2851         Helper methods to assert that we did or didn't get an error.
2852
2853         (JSONCheckerTest.mock_handle_style_error): Helper method.
2854
2855         (JSONCheckerTest.test_conflict_marker):
2856         (JSONCheckerTest.test_single_quote):
2857         (JSONCheckerTest.test_init):
2858         (JSONCheckerTest.test_no_error):
2859         Test various cases.
2860
2861 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2862
2863         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
2864         https://bugs.webkit.org/show_bug.cgi?id=73664
2865
2866         Reviewed by Martin Robinson.
2867
2868         This patch adds our HTTP library and its main dependencies; this
2869         should not affect layout or rendering.
2870
2871         * gtk/jhbuild.modules:
2872
2873 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2874
2875         [GTK] Also run DumpRenderTree under jhbuild
2876         https://bugs.webkit.org/show_bug.cgi?id=73646
2877
2878         Reviewed by Martin Robinson.
2879
2880         * Scripts/webkitpy/layout_tests/port/gtk.py:
2881         (GtkDriver.cmd_line):
2882
2883 2011-12-02  Hajime Morrita  <morrita@chromium.org>
2884
2885         Unreviewed, rolling out r101751 and r101775.
2886         http://trac.webkit.org/changeset/101751
2887         http://trac.webkit.org/changeset/101775
2888         https://bugs.webkit.org/show_bug.cgi?id=73191
2889
2890         breaks Windows build
2891
2892         * DumpRenderTree/chromium/config.h:
2893         * DumpRenderTree/config.h:
2894         * TestWebKitAPI/config.h:
2895         * WebKitTestRunner/config.h:
2896
2897 2011-12-02  Kentaro Hara  <haraken@chromium.org>
2898
2899         Move run-bindings-tests implementation to webkitpy/bindings/main.py
2900         https://bugs.webkit.org/show_bug.cgi?id=73619
2901
2902         Reviewed by Adam Barth.
2903
2904         As run-bindings-tests has been growing, this patch just moves its implementation
2905         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
2906
2907         No change in behavior.
2908
2909         * Scripts/run-bindings-tests:
2910         (main):
2911         * Scripts/webkitpy/bindings/__init__.py: Added.
2912         * Scripts/webkitpy/bindings/main.py: Added.
2913         (BindingsTests.__init__):
2914         (BindingsTests.generate_from_idl):
2915         (BindingsTests.generate_supplemental_dependency):
2916         (BindingsTests.detect_changes):
2917         (BindingsTests.run_tests):
2918
2919 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
2920
2921         Tools/Scripts: eliminate find_test_files from Port class.
2922         https://bugs.webkit.org/show_bug.cgi?id=73553
2923
2924         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
2925         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
2926         Also I'll move _is_test_file() and related functions close to Port.tests().
2927
2928         Reviewed by Dirk Pranke.
2929
2930         * Scripts/webkitpy/layout_tests/port/base.py:
2931         (Port.tests):
2932         (Port.is_reference_html_file):
2933         (Port._has_supported_extension):
2934         (Port._is_test_file):
2935         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2936         (PortTest.test_find_no_paths_specified):
2937         (PortTest.test_find_one_test):
2938         (PortTest.test_find_glob):
2939         (PortTest.test_find_with_skipped_directories):
2940         (PortTest.test_find_with_skipped_directories_2):
2941         (PortTest.test_is_test_file):
2942         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2943         (_default_tests_paths):
2944         (ChromiumGpuLinuxPort.tests):
2945         (ChromiumGpuCgMacPort.tests):
2946         (ChromiumGpuMacPort.tests):
2947         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2948         (ChromiumGpuTest.test_default_tests_paths.test_paths):
2949         (ChromiumGpuTest.test_default_tests_paths):
2950         (ChromiumGpuTest.test_test_files.test_paths):
2951         (ChromiumGpuTest):
2952         (ChromiumGpuTest.test_test_files):
2953         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2954         (get_tests_run.RecordingTestDriver.run_test):
2955         * Scripts/webkitpy/tool/commands/rebaseline.py:
2956         (OptimizeBaselines._optimize_baseline):
2957         (OptimizeBaselines.execute):
2958         (AnalyzeBaselines._analyze_baseline):
2959         (AnalyzeBaselines.execute):
2960
2961 2011-12-01  Hajime Morrita  <morrita@chromium.org>
2962
2963         JS_INLINE and WTF_INLINE should be visible from WebCore
2964         https://bugs.webkit.org/show_bug.cgi?id=73191
2965
2966         Reviewed by Kevin Ollivier.
2967
2968         Removed macro definitions which is now provided by Platform.h
2969
2970         * DumpRenderTree/chromium/config.h:
2971         * DumpRenderTree/config.h:
2972         * TestWebKitAPI/config.h:
2973         * WebKitTestRunner/config.h:
2974
2975 2011-12-01  Hayato Ito  <hayato@chromium.org>
2976
2977         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
2978         https://bugs.webkit.org/show_bug.cgi?id=73406
2979
2980         Reviewed by Ryosuke Niwa.
2981
2982         WebKitPort's image_diff uses tolerance='0.1' in default.
2983         When reftests fail, we should use tolerace=0 when diff-ing images.
2984
2985         Since ImageDiff on chromium port doesn't use tolerance value as of now,
2986         this change doesn't affect chromium port's behavior.
2987
2988         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2989         (write_test_result):
2990         * Scripts/webkitpy/layout_tests/port/base.py:
2991         (Port.diff_image):
2992         * Scripts/webkitpy/layout_tests/port/chromium.py:
2993         (ChromiumPort.diff_image):
2994         * Scripts/webkitpy/layout_tests/port/test.py:
2995         (TestPort.diff_image):
2996         * Scripts/webkitpy/layout_tests/port/webkit.py:
2997         (WebKitPort.diff_image):
2998         (WebKitPort._start_image_diff_process):
2999         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3000         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3001
3002 2011-12-01  Adam Klein  <adamk@chromium.org>
3003
3004         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
3005         https://bugs.webkit.org/show_bug.cgi?id=73599
3006
3007         Reviewed by Ojan Vafai.
3008
3009         * TestResultServer/static-dashboards/builders.js:
3010         * TestResultServer/static-dashboards/dashboard_base.js:
3011         ():
3012         (htmlForTestTypeSwitcher):
3013         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3014         (testHtmlForTestTypeSwitcherGroup):
3015
3016 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
3017
3018         Parse reftest.list and extract types of ref tests
3019         https://bugs.webkit.org/show_bug.cgi?id=66837
3020
3021         Reviewed by Dirk Pranke.
3022
3023         Add support for reftest.list to base port.
3024
3025         * Scripts/webkitpy/common/find_files.py:
3026         (find):
3027         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3028         (SingleTestRunner.__init__):
3029         * Scripts/webkitpy/layout_tests/port/base.py:
3030         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
3031         to a dictionary of {test path: ("==" or "!=", reference file path)}
3032         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
3033         (Port._reference_file_for): Added; obtains the reference file name given a test name.
3034         (Port.is_reftest): Added; Calls _reference_file_for.
3035         (Port.reftest_expected_filename): Calls _reference_file_for.
3036         (Port.reftest_expected_mismatch_filename): Ditto.
3037         (Port.find_test_files):
3038         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
3039         -expected, -expected-mismach, -ref, or -notref as a reference file.
3040         (_is_test_file):
3041         (_parse_reftest_list): Added.
3042         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3043         (PortTest.test_is_test_file):
3044         (PortTest.test_parse_reftest_list):
3045         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3046         (DryrunDriver.run_test):
3047         * Scripts/webkitpy/layout_tests/port/test.py:
3048         (unit_test_filesystem.add_test_file):
3049         (unit_test_filesystem.add_file):
3050         (unit_test_filesystem):
3051         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3052         (get_tests_run.RecordingTestDriver.run_test):
3053         (MainTest.test_unexpected_failures):
3054         (MainTest.test_missing_and_unexpected_results):
3055         (EndToEndTest.test_end_to_end):
3056         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3057         (Rebaseliner._compile_rebaselining_tests):
3058
3059 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3060
3061         Unreviewed, rolling out r101711.
3062         http://trac.webkit.org/changeset/101711
3063         https://bugs.webkit.org/show_bug.cgi?id=73605
3064
3065         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
3066
3067         * Scripts/webkitpy/style/checker.py:
3068         (_all_categories):
3069         (FileType):
3070         (CheckerDispatcher._file_type):
3071         (CheckerDispatcher._create_checker):
3072         * Scripts/webkitpy/style/checker_unittest.py:
3073         (CheckerDispatcherDispatchTest.assert_checker_cpp):
3074         (CheckerDispatcherDispatchTest.test_cpp_paths):
3075         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
3076         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
3077
3078 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3079
3080         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
3081
3082         * Scripts/webkitpy/common/config/watchlist:
3083
3084 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3085
3086         [GTK] Read fonts from the jhbuild root
3087         https://bugs.webkit.org/show_bug.cgi?id=73487
3088
3089         Reviewed by Gustavo Noronha Silva.
3090
3091         Read fonts from the jhbuild root instead of from the system. This will ensure
3092         that all testers use the same fonts instead of leaving this up to luck.
3093
3094         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3095         (initializeFonts): Load fonts from jhbuild root.
3096         * Scripts/webkitpy/layout_tests/port/gtk.py:
3097         (GtkPort.setup_environ_for_server): Pass an environment variable containing
3098         the path to the jhbuild root.
3099         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3100         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
3101
3102 2011-12-01  Adam Roben  <aroben@apple.com>
3103
3104         Teach check-webkit-style how to check the syntax of JSON files
3105
3106         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3107
3108         Reviewed by Darin Adler.
3109
3110         * Scripts/webkitpy/style/checker.py:
3111         (_all_categories): Added JSONChecker's categories to the set of all categories.
3112         (FileType): Added a JSON type. Incremented other types.
3113         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3114         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3115
3116         * Scripts/webkitpy/style/checker_unittest.py:
3117         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3118         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3119
3120         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3121         which would have matched our other checkers, because I couldn't figure out how to call
3122         "json.loads" without hitting namespace conflicts.)
3123         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3124         just the modified lines from a patch.
3125         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3126         exception.
3127         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3128         try to extract a line number.
3129
3130         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3131         (MockErrorHandler.__init__):
3132         (MockErrorHandler.turn_off_line_filtering):
3133         (MockErrorHandler.__call__):
3134         Helper class. Copied from xml_unittest.py.
3135
3136         (JSONCheckerTest.test_line_number_from_json_exception): Test the
3137         line_number_from_json_exception helper method.
3138
3139         (JSONCheckerTest.assert_no_error):
3140         (JSONCheckerTest.assert_error):
3141         Helper methods to assert that we did or didn't get an error.
3142
3143         (JSONCheckerTest.mock_handle_style_error): Helper method.
3144
3145         (JSONCheckerTest.test_conflict_marker):
3146         (JSONCheckerTest.test_single_quote):
3147         (JSONCheckerTest.test_init):
3148         (JSONCheckerTest.test_missing_closing_brace):
3149         (JSONCheckerTest.test_no_error):
3150         Test various cases.
3151
3152 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3153
3154         [GTK] Add a helper function to find the current executable's path
3155         https://bugs.webkit.org/show_bug.cgi?id=73473
3156
3157         Reviewed by Gustavo Noronha Silva.
3158
3159         Update MiniBrowser to not pass the binary directory as an environment variable.
3160         This means that you can move the binaries around without it breaking.
3161
3162         * MiniBrowser/gtk/main.c:
3163         (main): No longer set the environment variable.
3164         * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
3165         * WebKitTestRunner/gtk/main.cpp:  Ditto.
3166
3167 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3168
3169         Unreviewed. Fix bad file =(.
3170
3171         * gtk/jhbuild.modules:
3172         * Scripts/webkitdirs.pm:
3173         (runAutogenForAutotoolsProject):
3174
3175 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3176
3177         [GTK] Add freetype to our jhbuild setup
3178         https://bugs.webkit.org/show_bug.cgi?id=73488
3179
3180         Reviewed by Martin Robinson.
3181
3182         This adds the first library to our jhbuild setup, and makes sure
3183         build-webkit calls autogen.sh and make with jhbuild, so that the
3184         environment is properly set.
3185
3186         * Scripts/webkitdirs.pm:
3187         (saveSum):
3188         (hashFile):
3189         (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
3190         call autogen under jhbuild run;
3191         (mustRunAutogen): generalized the arguments change checking to also force
3192         running autogen when jhbuild files change;
3193         (buildAutotoolsProject): run make under jhbuild;
3194         * gtk/jhbuild.modules: add freetype.
3195
3196 2011-12-01  Dominic Mazzoni  <dmazzoni@google.com>
3197
3198         Fix WebKitTestRunner compile warnings with XCode 3.2
3199         https://bugs.webkit.org/show_bug.cgi?id=73378
3200
3201         Reviewed by Chris Fleizach.
3202
3203         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
3204         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
3205         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
3206         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3207         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3208         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3209         (WTR::AccessibilityUIElement::verticalScrollbar):
3210
3211 2011-12-01  Adam Roben  <aroben@apple.com>
3212
3213         Allow committers to use their Trac credentials to force builds on the buildbots
3214
3215         Fixes <http://webkit.org/b/73353>
3216
3217         A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
3218         three files to do its job: a config file that contains a list of WebKit committer usernames,
3219         an htdigest file that contains Trac credentials, and JSON file that gives the paths for
3220         those two files.
3221
3222         Reviewed by Darin Adler.
3223
3224         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.
3225         (Error): Basic wrapper around Exception that we use for cases where we couldn't even check
3226         whether credentials were valid or not.
3227         (CommitterAuth.__init__): Just store the path to auth.json.
3228         (CommitterAuth.auth_json): Load, parse, and return auth.json.
3229         (CommitterAuth.auth_json_filename): Return the path to auth.json.
3230         (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
3231         credentials are valid Trac credentials. Return false otherwise or if an error occurred while
3232         checking those conditions.
3233         (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
3234         false otherwise or if an exception was thrown.
3235         (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
3236         Trac credentials htdigest file. Return false otherwise or if an exception was thrown.
3237
3238         (CommitterAuth.open_auth_json_file):
3239         (CommitterAuth.open_trac_credentials_file):
3240         (CommitterAuth.open_webkit_committers_file):
3241         Open the specified file. These are mostly useful for testing purposes.
3242
3243         (CommitterAuth.trac_credentials_filename):
3244         (CommitterAuth.webkit_committers_filename):
3245         Return the path to the specified file by retrieving it from auth.json.
3246
3247         (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
3248         of WebKit committers from it.
3249
3250         * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.
3251         (CMStringIO.__enter__):
3252         (CMStringIO.__exit__):
3253         Helper class that makes it possible to use StringIO with the "with" statement.
3254
3255         (open_override): Helper context manager for overriding the global "open" function
3256         temporarily.
3257
3258         (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
3259         tests.
3260         (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
3261         "open" to test that the expected path was opened.
3262         (CommitterAuthTest.test_authentication_success): Test that committers can authenticate
3263         successfully.
3264         (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
3265         somehow have no Trac account can't authenticate.
3266
3267         (CommitterAuthTest.test_fail_to_open_auth_json_file):
3268         (CommitterAuthTest.test_fail_to_open_trac_credentials_file):
3269         (CommitterAuthTest.test_fail_to_open_webkit_committers_file):
3270         Test what happens when we can't open the three files we depend upon.
3271
3272         (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
3273         an authentication class.
3274
3275         (CommitterAuthTest.test_invalid_auth_json_file):
3276         (CommitterAuthTest.test_invalid_committers_file):
3277         (CommitterAuthTest.test_invalid_trac_credentials_file):
3278         (CommitterAuthTest.test_missing_auth_json_keys):
3279         Test what happens when the three files we depend upon are invalid in some way.
3280
3281         (CommitterAuthTest.test_open_auth_json_file):
3282         (CommitterAuthTest.test_open_trac_credentials_file):
3283         (CommitterAuthTest.test_open_webkit_committers_file):
3284         Test that we open the expected paths.
3285
3286         (CommitterAuthTest.test_trac_credentials_filename):
3287         (CommitterAuthTest.test_webkit_committers_filename):
3288         Test that we extract filenames out of auth.json correctly.
3289
3290         (CommitterAuthTest.test_non_committer_fails):
3291         (CommitterAuthTest.test_unknown_user_fails):
3292         (CommitterAuthTest.test_username_is_prefix_of_valid_user):
3293         (CommitterAuthTest.test_wrong_password_fails):
3294         Test various failed authentication attempts.
3295
3296         (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
3297         committers out of the committers file correctly.
3298
3299         (CommitterAuthTest.fake_auth_json_file):
3300         (CommitterAuthTest.invalid_auth_json_file):
3301         (CommitterAuthTest.fake_committers_file):
3302         (CommitterAuthTest.invalid_committers_file):
3303         (CommitterAuthTest.fake_htdigest_file):
3304         (CommitterAuthTest.invalid_htdigest_file):
3305         Return various fake files for testing.
3306
3307         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth
3308         to be used for authentication in the web interface, and specify that only authenticated
3309         users may force builds.
3310
3311 2011-12-01  Adam Roben  <aroben@apple.com>
3312
3313         Add an HTDigestParser class to webkitpy
3314
3315         Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files
3316
3317         This class can be used to parse Apache's htdigest files and check whether a given
3318         username/realm/password tuple is present in the file. Eventually this will be used for
3319         authenticating users on build.webkit.org (<http://webkit.org/b/73353>).
3320
3321         Reviewed by Eric Seidel.
3322
3323         * Scripts/webkitpy/common/net/htdigestparser.py: Added.
3324         (HTDigestParser.__init__): Stores the parsed representation of the file.
3325         (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
3326         password and returns whether the resulting tuple is present in the file.
3327         (HTDigestParser.entries): Just returns the parsed representation of the file.
3328         (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
3329         expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
3330         whole file as invalid and all authentication attempts will fail.
3331
3332         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.
3333         (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
3334         optionally appended with some extra data, generates the expected entries.
3335         (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
3336         authenticate, and tuples not present cannot.
3337         (HTDigestParserTest.test_entries): Tests that we get the expected entries from
3338         fake_htdigest_file.
3339
3340         (HTDigestParserTest.test_empty_file):
3341         (HTDigestParserTest.test_too_few_colons):
3342         (HTDigestParserTest.test_too_many_colons):
3343         (HTDigestParserTest.test_invalid_hash):
3344         Test various forms of invalid files.
3345
3346         (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.
3347
3348 2011-12-01  Philippe Normand  <pnormand@igalia.com>
3349
3350         [GTK] Make the new 64-bit Release bot part of the core set
3351         https://bugs.webkit.org/show_bug.cgi?id=73570
3352
3353         Reviewed by Adam Roben.
3354
3355         The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
3356         Debug bot which was already part of the core set. The GTK
3357         gardeners are willing to actively maintain it.
3358
3359         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3360         (BuildBot.__init__):
3361         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3362         (test_builder_name_regexps):
3363
3364 2011-12-01  Philippe Normand  <pnormand@igalia.com>
3365
3366         [GTK] Buildslave switch from 32-bit Debug to 64-bit Release
3367         https://bugs.webkit.org/show_bug.cgi?id=73547
3368
3369         Reviewed by Adam Roben.
3370
3371         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename
3372         the 32-bit Debug configuration to 64-bit Release. The new slave is
3373         a 64-bit machine already. The 32-bit slave will be shut down.
3374
3375 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3376
3377         [GTK] build-jsc should not trigger gtkdoc generation
3378         https://bugs.webkit.org/show_bug.cgi?id=73552
3379
3380         Reviewed by Philippe Normand.
3381
3382         Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
3383         that build-jsc does not try to generate gtkdoc.
3384
3385         * Scripts/webkitdirs.pm:
3386         (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".
3387
3388 2011-12-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3389
3390         tests_run0.txt gets clobbered when re-running failing tests
3391         https://bugs.webkit.org/show_bug.cgi?id=63844
3392
3393         Reviewed by Dirk Pranke.
3394
3395         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3396         (Manager.results_directory):
3397         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3398         (AbstractWorker.__init__):
3399         (_ManagerConnection.start_worker):
3400         (_InlineManager.start_worker):
3401         (_MultiProcessManager.start_worker):
3402         (_WorkerConnection.__init__):
3403         (_InlineWorkerConnection.__init__):
3404         (_MultiProcessWorkerConnection.__init__):
3405         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3406         (_TestWorker.__init__):
3407         (_TestsMixin.test_cancel):
3408         (_TestsMixin.test_done):
3409         (_TestsMixin.test_unknown_message):
3410         (InterfaceTest.test_managerconnection_is_abstract):
3411         (InterfaceTest.test_workerconnection_is_abstract):
3412         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3413         (Worker.__init__):
3414         (Worker.safe_init):
3415         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3416         (MainTest.test_retries_directory):
3417
3418 2011-12-01  Adam Roben  <aroben@apple.com>
3419
3420         Buildbot fix
3421
3422         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of
3423         BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
3424         it possible for build steps to reference things like the buildbotURL property of the config.
3425
3426 2011-11-30  Adam Roben  <aroben@apple.com>
3427
3428         Use curl for downloading builds to test slaves
3429
3430         Buildbot's built-in file transfer capabilities are transferring files much more slowly than
3431         curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
3432         often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
3433         overhead (courtesy of the Twisted framework).
3434
3435         Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
3436         meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
3437         This should make the test slaves quite a bit faster, and should ease the CPU load on
3438         build.webkit.org a bit.
3439
3440         Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build
3441
3442         Reviewed by Mark Rowe.
3443
3444         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory
3445         to Test slaves. It's run just before DownloadBuiltProduct.
3446         (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
3447         download.
3448         (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
3449         FileDownload used to do this for us automatically.
3450
3451 2011-11-21  Philippe Normand  <pnormand@igalia.com>
3452
3453         [GTK] enable-webaudio websetting
3454         https://bugs.webkit.org/show_bug.cgi?id=69836
3455
3456         Reviewed by Martin Robinson.
3457
3458         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3459         (LayoutTestController::overridePreference): Update WebKitGTK
3460         enable-webaudio setting when a layout test requests it.
3461
3462 2011-11-30  Ilya Tikhonovsky  <loislo@chromium.org>
3463
3464         Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
3465         https://bugs.webkit.org/show_bug.cgi?id=73079
3466
3467         The idea is to have performance tests for WebInspector.
3468         I was suggested to put these tests into PerformanceTests/inspector.
3469         They produce output in a format that is suitable for chromium perf bot drawing scripts.
3470
3471         I'd like to reuse code for scanning folders for test files.
3472         Because of the fact that original test_files.py has common and layout specific parts
3473         I decided to extract the generic part and put it into webkitpy/common
3474         I think the two packages with name test_files look strange but I have no idea about a better name.
3475
3476         Reviewed by Dirk Pranke.
3477
3478         * Scripts/run-inspector-perf-tests.py: Added.
3479         * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.
3480         (find):
3481         (_normalize):
3482         * Scripts/webkitpy/common/find_files_unittest.py: Added.
3483         (MockWinFileSystem.join):
3484         (MockWinFileSystem):
3485         (MockWinFileSystem.normpath):
3486         (TestWinNormalize.assert_filesystem_normalizes):
3487         (TestWinNormalize.test_mocked_win):
3488         (TestWinNormalize):
3489         (TestWinNormalize.test_win):
3490         * Scripts/webkitpy/layout_tests/port/base.py:
3491         (Port.tests):
3492         (Port.find_test_files):
3493         (Port._driver_class):
3494         (is_reference_html_file):
3495         (_has_supported_extension):
3496         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3497         (PortTest.test_find_no_paths_specified):
3498         (PortTest.test_find_one_test):
3499         (PortTest.test_find_glob):
3500         (PortTest.test_find_with_skipped_directories):
3501         (PortTest.test_find_with_skipped_directories_2):
3502         (PortTest):
3503         (PortTest.test_is_test_file):
3504         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3505         (_tests):
3506         * Scripts/webkitpy/layout_tests/port/test.py:
3507         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
3508         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3509         * Scripts/webkitpy/performance_tests/__init__.py: Added.
3510         * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.
3511         (PerfTestsRunner.__init__):
3512         (PerfTestsRunner._parse_args):
3513         (PerfTestsRunner._collect_tests._is_test_file):
3514         (PerfTestsRunner._collect_tests):
3515         (PerfTestsRunner.run):
3516         (PerfTestsRunner._run_tests_set):
3517         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.
3518         (MainTest.TestPort):
3519         (MainTest.TestPort.create_driver):
3520         (MainTest.TestDriver.run_test):
3521         (MainTest.TestDriver):
3522         (MainTest.TestDriver.stop):
3523         (MainTest.create_runner):
3524         (MainTest.run_test):
3525         (MainTest.test_run_passing_test):
3526         (MainTest.test_run_silent_test):
3527         (MainTest.test_run_failed_test):
3528         (MainTest.test_run_tonguey_test):
3529         (MainTest.test_run_timeout_test):
3530         (MainTest.test_run_crash_test):
3531         (MainTest.test_run_test_set):
3532         (MainTest.test_collect_tests):
3533         (MainTest):
3534         (MainTest.test_parse_args):
3535         * Scripts/webkitpy/tool/commands/rebaseline.py:
3536         (OptimizeBaselines.execute):
3537         (AnalyzeBaselines.execute):
3538
3539 2011-11-30  nduca@chromium.org  <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
3540
3541         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
3542         https://bugs.webkit.org/show_bug.cgi?id=70838
3543
3544         Reviewed by James Robinson.
3545
3546         * DumpRenderTree/chromium/TestShell.cpp:
3547         (TestShell::resetWebSettings):
3548         * DumpRenderTree/chromium/TestShell.h:
3549         (TestShell::threadedCompositingEnabled):
3550         * DumpRenderTree/chromium/WebPreferences.cpp:
3551         (WebPreferences::reset):
3552         (WebPreferences::applyTo):
3553         * DumpRenderTree/chromium/WebPreferences.h:
3554         * DumpRenderTree/chromium/WebViewHost.cpp:
3555         (WebViewHost::WebViewHost):
3556         (WebViewHost::~WebViewHost):
3557
3558 2011-11-30  Chris Fleizach  <cfleizach@apple.com>
3559
3560         AX: Nodes are reporting that focus can be set when they really can't
3561         https://bugs.webkit.org/show_bug.cgi?id=72791
3562
3563         Reviewed by Beth Dakin.
3564
3565         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3566         (AccessibilityUIElement::isFocusable):
3567         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3568         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3569         (WTR::AccessibilityUIElement::isFocusable):
3570
3571 2011-11-30  Alejandro G. Castro  <alex@igalia.com>
3572
3573         Moved myself to the reviewers list.
3574
3575         * Scripts/webkitpy/common/config/committers.py:
3576
3577 2011-11-30  David Levin  <levin@chromium.org>
3578
3579         [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
3580         https://bugs.webkit.org/show_bug.cgi?id=73415
3581
3582         Reviewed by Darin Fisher.
3583
3584         * DumpRenderTree/chromium/WebViewHost.cpp:
3585         (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
3586         it being moved to a new interface and having the parameter removed.
3587         * DumpRenderTree/chromium/WebViewHost.h: Ditto.
3588
3589 2011-11-30  Adam Roben  <aroben@apple.com>
3590
3591         Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed
3592
3593         This will make it a lot easier to investigate build failures on the bots.
3594
3595         Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT
3596
3597         Reviewed by Eric Seidel.
3598
3599         * Scripts/webkitpy/common/system/executive_mock.py:
3600         (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
3601         makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
3602         seen in practice.
3603
3604         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3605         (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
3606         The Printer was modifying the root logger in way that would cause my new tests in
3607         WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
3608         seem important to the functioning of this test, and passing False makes Printer not modify
3609         the root logger.
3610
3611         * Scripts/webkitpy/layout_tests/port/webkit.py:
3612         (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
3613         up when --verbose is passed but not otherwise.
3614         (WebKitPort._build_driver): When an error occurs, log the error message and the script's
3615         output at the ERROR level so it will always show up.
3616
3617         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3618         (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
3619         cases. Test that the build scripts' output is logged when --verbose is passed or the build
3620         fails.
3621
3622 2011-11-30  Adam Roben  <aroben@apple.com>
3623
3624         Add a way to set OutputCapture's log level
3625
3626         This will be used by some unit tests I'm planning to add.
3627
3628         Fixes <http://webkit.org/b/73469> OutputCapture can't be used to capture DEBUG messages
3629
3630         Reviewed by Eric Seidel.
3631
3632         * Scripts/webkitpy/common/system/outputcapture.py:
3633         (OutputCapture.__init__): Initialize our internal logging level to INFO, which was the only
3634         level we ever used before this patch.
3635         (OutputCapture.set_log_level): Added. This is useful for testing what log level code that is
3636         being tested uses. Sets the log level for any current or future logging handlers.
3637         (OutputCapture.capture_output): Use our internal logging level instead of always using INFO.
3638
3639         * Scripts/webkitpy/common/system/outputcapture_unittest.py: Added.
3640         (OutputCaptureTest.setUp): Create an OutputCapture to test.
3641         (OutputCaptureTest.log_all_levels): Helper method to log a message at each log level.
3642         (OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings
3643         was logged.