71fdd308da6f063132f90844bae0daf08e466eb3
[WebKit-https.git] / Tools / ChangeLog
1 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
2
3         Add a branch keyword argument to _run_git_svn_find_rev.
4         https://bugs.webkit.org/show_bug.cgi?id=138372
5
6         Reviewed by Ryosuke Niwa.
7
8         The addition of this keyword argument allows clients to determine the Git hash
9         of commits made on an SVN branch, provided that branch has been fetched locally.
10
11         * Scripts/webkitpy/common/checkout/scm/git.py:
12         (Git._run_git_svn_find_rev):
13         Add a branch keyword argument that is added to the end of the command, if present.
14
15 2014-11-04  Chris Dumez  <cdumez@apple.com>
16
17         Add ptr() method to Ref class
18         https://bugs.webkit.org/show_bug.cgi?id=138361
19
20         Reviewed by Darin Adler.
21
22         Use the new Ref::ptr() method.
23
24         * TestWebKitAPI/Tests/WTF/Ref.cpp:
25         (TestWebKitAPI::TEST):
26
27 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
28
29         [jhbuild] Make it possible to build GTK/EFL in same repository
30         https://bugs.webkit.org/show_bug.cgi?id=137448
31
32         Reviewed by Martin Robinson.
33
34         * Scripts/webkitdirs.pm:
35         (getJhbuildPath):
36         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
37         (getPlatformFontsPath):
38         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
39         (WTR::getFontsPath):
40         * jhbuild/jhbuild-wrapper:
41         (determine_platform):
42         (install_jhbuild):
43         * jhbuild/jhbuildrc_common.py:
44         (init):
45
46 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
47
48         [EFL] Bump LLVM to version 3.5.0
49         https://bugs.webkit.org/show_bug.cgi?id=138312
50
51         Reviewed by Csaba Osztrogonác.
52
53         * efl/jhbuild.modules:
54         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
55         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
56
57 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
58
59         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
60         https://bugs.webkit.org/show_bug.cgi?id=138257
61
62         Reviewed by Tim Horton.
63         
64         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
65         the user to toggle region page overlays on and off. Two overlays are available,
66         for the non-fast scrollable region, and the region of element with wheel
67         event handlers.
68
69         * MiniBrowser/mac/SettingsController.h:
70         * MiniBrowser/mac/SettingsController.m:
71         (-[SettingsController _populateMenu]):
72         (-[SettingsController validateMenuItem:]):
73         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
74         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
75         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
76         (-[SettingsController toggleDebugOverlay:]):
77         (-[SettingsController debugOverlayVisible:]):
78         * MiniBrowser/mac/WK2BrowserWindowController.m:
79         (-[WK2BrowserWindowController didChangeSettings]):
80
81 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
82
83         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
84         https://bugs.webkit.org/show_bug.cgi?id=138323
85
86         Reviewed by Zalan Bujtas.
87
88         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
89
90 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
91
92         [ninja] Don't remove response files for verbose builds
93         https://bugs.webkit.org/show_bug.cgi?id=137816
94
95         Reviewed by Csaba Osztrogonác.
96
97         * Scripts/webkitdirs.pm:
98         (determineNinjaVersion):
99         (buildCMakeGeneratedProject):
100
101 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
102
103         [GTK] Fix the build of FTL JIT
104         https://bugs.webkit.org/show_bug.cgi?id=138298
105
106         Reviewed by Carlos Garcia Campos.
107
108         * gtk/jhbuild-optional.modules:
109         Bump up LLVM version to 3.5.0 release and apply patches.
110         * gtk/patches/llvm-elf-add-stackmaps.patch:
111         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
112         trunk.
113         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
114         Added. Ensures that PC-relative relocations in EH frames are not
115         truncated to 32 bits on x86_64.
116
117 2014-10-31  Michael Saboff  <msaboff@apple.com>
118
119         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
120         https://bugs.webkit.org/show_bug.cgi?id=138268
121
122         Reviewed by Andreas Kling.
123
124         Added a --arch and --os option to set or override the values that are
125         normally computed based on examining the JavaScriptCore we want to test.
126
127         * Scripts/run-jsc-stress-tests:
128
129 2014-10-31  Dan Bernstein  <mitz@apple.com>
130
131         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
132         https://bugs.webkit.org/show_bug.cgi?id=138259
133
134         Reviewed by Geoff Garen.
135
136         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
137         going to be empty to silence the warning.
138
139 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
140
141         [GTK] Support script message handlers WebKitUserContentManager
142         https://bugs.webkit.org/show_bug.cgi?id=133730
143
144         Reviewed by Carlos Garcia Campos.
145
146         Support user script message handlers in WebKitUserContentManager.
147         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
148         an option is added to the CMake build files. The option is disabled
149         globally by default, and the WebKitGTK port enables it. On the API
150         level, two new methods to register and unregister names are provided
151         in the "window.webkit" namespace, and on message reception the
152         "WebKitUserContentManager::script-message-received" signal is
153         emitted, using the registered names as signal detail.
154
155         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
156         Add test case for user script message handlers.
157         (scriptMessageReceived):
158         (testUserContentManagerScriptMessageReceived):
159         (beforeAll):
160
161 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
162
163         bisect-builds should support WebKit clients other than Safari
164         https://bugs.webkit.org/show_bug.cgi?id=138225
165
166         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
167
168         The -a / --application optional argument allows the user to specify which application (or application bundle)
169         should be run against the WebKit nightly builds.
170
171         Reviewed by David Kilzer.
172
173         * Scripts/bisect-builds:
174         Swap out $safariPath for the more general $applicationPath
175         Leave --safari-path as a commandline option for backwards compatibility
176         (mountAndRunNightly):
177         Use File::Spec->cat correctly (one directory per argument)
178         Use open --wait-apps instead of running the target application directly
179
180 2014-10-30  Dana Burkart  <dburkart@apple.com>
181
182         <rdar://problem/18821260> Perpare for the mysterious future
183
184         Reviewed by Lucas Forschler.
185
186         * DumpRenderTree/mac/Configurations/Base.xcconfig:
187         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
188         * LayoutTestRelay/Configurations/Base.xcconfig:
189         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
190         * MiniBrowser/Configurations/Base.xcconfig:
191         * MiniBrowser/Configurations/DebugRelease.xcconfig:
192         * TestWebKitAPI/Configurations/Base.xcconfig:
193         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
194         * WebKitLauncher/Configurations/Base.xcconfig:
195         * WebKitTestRunner/Configurations/Base.xcconfig:
196         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
197
198 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
199
200         Update safariVersion to safariVersionString
201         https://bugs.webkit.org/show_bug.cgi?id=138193
202
203         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
204         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
205
206         Rubber-stamped by David Kilzer.
207
208         * Scripts/bisect-builds:
209         (makeNightlyList):
210         Compare safariVersionString to a string literal, instead of safariVersion.
211
212 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
213
214         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
215         https://bugs.webkit.org/show_bug.cgi?id=137775
216
217         Reviewed by Carlos Garcia Campos.
218
219         * MiniBrowser/gtk/BrowserWindow.c:
220         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
221         (browser_window_init):
222
223 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
224
225         CommitQueue and EWS should reject any patches that result in consistent test
226         failures that aren't present on the tree.
227         https://bugs.webkit.org/show_bug.cgi?id=138184
228
229         Reviewed by Alexey Proskuryakov.
230
231         * Scripts/webkitpy/layout_tests/models/test_results.py:
232         Adds a simple hashing function to allow for set operations to handle
233         TestResult objects properly.
234         (TestResult.__hash__):
235         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
236         Adds one unit test, and modifies others to agree with the notion that
237         patches that introduce new test failures (but also have flakyness)
238         should be rejected rather than spin.
239         (MockCommitQueue.report_flaky_tests):
240         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
241         (test_double_flaky_test_failure):
242         (test_two_flaky_tests):
243         (test_very_flaky_patch):
244         (test_very_flaky_patch_with_some_tree_redness):
245         (test_different_test_failures):
246         (test_different_test_failures_with_some_tree_redness):
247         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
248         (test_mildly_flaky_patch):
249         (test_mildly_flaky_patch_with_some_tree_redness):
250         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
251         Makes PatchAnalysisTask reject said patches.
252         (PatchAnalysisTask._test_patch):
253
254 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
255
256         WinCairoRequirements.zip cannot be downloaded from dropbox
257         https://bugs.webkit.org/show_bug.cgi?id=138113
258
259         Reviewed by Alexey Proskuryakov.
260
261         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
262
263 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
264
265         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
266         https://bugs.webkit.org/show_bug.cgi?id=138193
267
268         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
269         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
270
271         It also does a bit of refactoring, including distinguishing between versions and version strings and
272         saving versions to local variables instead of using eval in each conditional.
273
274         Reviewed by David Kilzer.
275
276         * Scripts/bisect-builds:
277         (makeNightlyList):
278         Restrict the set of nightlies to r174650 and above when running Yosemite.
279         Restrict the set of nightlies to r157846 and above when running Mavericks.
280         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
281
282 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
283
284         [EFL] build-webkit should try harder to avoid re-running cmake
285         https://bugs.webkit.org/show_bug.cgi?id=137949
286
287         Reviewed by Martin Robinson.
288
289         * Scripts/webkitdirs.pm:
290         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
291         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
292
293 2014-10-28  Daniel Bates  <dabates@apple.com>
294
295         Unify logic in RunTests.run() to run the Python unit tests
296         https://bugs.webkit.org/show_bug.cgi?id=138160
297
298         Reviewed by Martin Robinson.
299
300         Unify the interactive and non-interactive code path for running the Python unit tests
301         in step RunTests so as to remove duplicate code to compute the the path to the script
302         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
303
304         No new tests since no functionality was changed.
305
306         * Scripts/webkitpy/port/base.py:
307         (Port.python_unittest_results_directory):
308         * Scripts/webkitpy/tool/steps/runtests.py:
309         (RunTests.run):
310
311 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
312
313         Make runtest.py call test-webkitpy with the --json flag when in
314         non-interactive mode.
315         https://bugs.webkit.org/show_bug.cgi?id=137667
316
317         Reviewed by Daniel Bates.
318
319         * Scripts/webkitpy/port/base.py:
320         Adds the python_unittest_results_directory method.
321         (Port.python_unittest_results_directory):
322         * Scripts/webkitpy/tool/steps/runtests.py:
323         Changes RunTests to call test-webkitpy with the --json flag if the
324         --non-interactive flag is set.
325         (RunTests):
326         (RunTests.run):
327
328 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
329
330         import-w3c-tests should use re.escape() wherever it's handling file paths
331         https://bugs.webkit.org/show_bug.cgi?id=137934
332
333         This patch adds re.escape() to a few places where we're doing string
334         conversions. This prevents errors when attribute values coincidentally
335         have character sequences that can be interpreted as regular expressions.
336
337         Reviewed by Bem Jones-Bey.
338
339         * Scripts/webkitpy/w3c/test_converter.py:
340         (_W3CTestConverter.convert_attributes_if_needed):
341
342 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
343
344         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
345         https://bugs.webkit.org/show_bug.cgi?id=138130
346
347         Reviewed by Csaba Osztrogonác.
348
349         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
350
351 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
352
353         Fix link to Arch Linux Wiki
354         https://bugs.webkit.org/show_bug.cgi?id=138010
355
356         Reviewed by Benjamin Poulain.
357
358         * gtk/install-dependencies:
359
360 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
361
362         Test regressions are not detected when image result is missing
363         https://bugs.webkit.org/show_bug.cgi?id=138070
364
365         Reviewed by Simon Fraser.
366
367         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
368         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
369         Count these as regressions, not as flaky tests.
370
371         * Scripts/webkitpy/port/test.py:
372         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
373         Test it.
374
375 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
376
377         Add Conrad Shultz to the contributors list.
378
379         * Scripts/webkitpy/common/config/contributors.json:
380
381 2014-10-24  Dan Bernstein  <mitz@apple.com>
382
383         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
384         https://bugs.webkit.org/show_bug.cgi?id=138046
385
386         Reviewed by Alexey Proskuryakov.
387
388         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
389         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
390         401. Otherwise, we’ll retry normally in 45 seconds.
391
392 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
393
394         [GTK] Implement is_selected method on WebKitHitTestResult
395         https://bugs.webkit.org/show_bug.cgi?id=137110
396
397         Reviewed by Tim Horton.
398
399         Add tests for new context SELECTION on WebKitHitTestResult.
400
401         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
402         (testContextMenuDefaultMenu):
403         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
404         (testWebViewMouseTarget):
405
406 2014-10-23  Roger Fong  <roger_fong@apple.com>
407
408         [Win] Skip failing JSC tests following r175078
409         https://bugs.webkit.org/show_bug.cgi?id=130967.
410
411         * Scripts/run-javascriptcore-tests:
412
413 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
414
415         commitqueuetask_unittest.py should be made more concise.
416         https://bugs.webkit.org/show_bug.cgi?id=137985
417
418         Reviewed by Alexey Proskuryakov.
419
420         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
421         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
422         (MockCommitQueue.__init__):
423         (MockCommitQueue.report_flaky_tests):
424         (MockCommitQueue):
425         (MockCommitQueue.get_reported_flaky_tests):
426         (MockSimpleTestPlanCommitQueue.__init__):
427         (MockSimpleTestPlanCommitQueue.run_command):
428         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
429         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
430         (test_land_failure):
431         (test_failed_archive):
432         (test_double_flaky_test_failure):
433         (test_test_failure):
434         (test_red_test_failure):
435         (test_very_red_tree_retry):
436         (test_red_tree_patch_rejection):
437         (test_one_flaky_test):
438         (test_tree_more_red_than_patch):
439         (MockCommitQueue.test_results): Deleted.
440         (test_simple_flaky_test_failure): Deleted.
441         (_expect_validate): Deleted.
442         (_expect_validate.MockDelegate): Deleted.
443         (_expect_validate.MockDelegate.refetch_patch): Deleted.
444         (_expect_validate.MockDelegate.expected_failures): Deleted.
445         (_mock_patch): Deleted.
446         (test_validate): Deleted.
447         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
448         Fixes a bug that slipped through the cracks prior to this change.
449         (PatchAnalysisTask._test_patch):
450
451 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
452
453         Flakiness dashboard should support OS X Yosemite
454         https://bugs.webkit.org/show_bug.cgi?id=137986
455
456         Reviewed by Ryosuke Niwa.
457
458         * TestResultServer/app.yaml:
459         * TestResultServer/static-dashboards/builders.jsonp:
460         * TestResultServer/static-dashboards/flakiness_dashboard.js:
461
462 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
463
464         commitqueuetask should include more tests to ensure that the behavior
465         of PatchAnalysisTask._test_patch() is well defined
466         https://bugs.webkit.org/show_bug.cgi?id=137977
467
468         Reviewed by Alexey Proskuryakov.
469
470         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
471         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
472         and more readable to define tests that are meant to test the behaviour
473         of PatchAnalysisTask._test_patch(), and adds several unit tests.
474         (FailingTestCommitQueue.test_results):
475         (PatchAnalysisResult):
476         (MockSimpleTestPlanCommitQueue):
477         (MockSimpleTestPlanCommitQueue.__init__):
478         (MockSimpleTestPlanCommitQueue.run_command):
479         (MockSimpleTestPlanCommitQueue._mock_test_result):
480         (MockSimpleTestPlanCommitQueue.test_results):
481         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
482         (test_flaky_test_failure):
483         (test_failed_archive):
484         (test_two_flaky_tests):
485         (test_one_flaky_test):
486         (test_very_flaky_patch):
487         (test_very_flaky_patch_with_some_tree_redness):
488         (test_different_test_failures):
489         (test_different_test_failures_with_some_tree_redness):
490         (test_mildly_flaky_patch):
491         (test_mildly_flaky_patch_with_some_tree_redness):
492         (test_tree_more_red_than_patch):
493
494 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
495
496         PatchAnalysisTask._test_patch() needs refactoring
497         https://bugs.webkit.org/show_bug.cgi?id=137904
498
499         Reviewed by Alexey Proskuryakov.
500
501         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
502         Fixes several small bugs, and makes minor changes to accomodate the
503         changes in PatchAnalysisTask.
504         (MockCommitQueue.refetch_patch):
505         (MockCommitQueue.test_results):
506         (test_flaky_test_failure):
507         (test_failed_archive):
508         (test_very_red_tree_retry):
509         (_expect_validate.MockDelegate.refetch_patch):
510         (MockCommitQueue.expected_failures): Deleted.
511         (_expect_validate.MockDelegate.expected_failures): Deleted.
512         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
513         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
514         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
515         Removes the unexpected_failures member, adds the _clean_tree_results
516         member, adds a helper function for _test_patch, and refactors
517         _test_patch to be more readable.
518         (PatchAnalysisTask.__init__):
519         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
520         (PatchAnalysisTask._test_patch):
521         (PatchAnalysisTask.results_from_test_run_without_patch):
522         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
523         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
524         (AbstractEarlyWarningSystem.begin_work_queue):
525         (AbstractEarlyWarningSystem._failing_tests_message):
526         (AbstractEarlyWarningSystem.command_failed):
527         (AbstractEarlyWarningSystem.expected_failures): Deleted.
528         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
529         Makes changes to accomodate the changes made to PatchAnalysisTask.
530         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
531         * Scripts/webkitpy/tool/commands/perfalizer.py:
532         Removes Perfalizer's dependancy on ExpectedFailures. 
533         (PerfalizerTask.refetch_patch):
534         (PerfalizerTask.expected_failures): Deleted.
535         * Scripts/webkitpy/tool/commands/queues.py:
536         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
537         initializer to allow for mock injection.
538         (CommitQueue.__init__):
539         (CommitQueue.begin_work_queue):
540         (CommitQueue.process_work_item):
541         (CommitQueue._failing_tests_message):
542         * Scripts/webkitpy/tool/commands/queues_unittest.py:
543         Removes dependancy on ExpectedFailures, and instead uses mock
544         injection.
545         (MockCommitQueueTask):
546         (MockCommitQueueTask.results_from_patch_test_run):
547         (MockCommitQueueTask.results_from_test_run_without_patch):
548         (mock_run_webkit_patch):
549
550 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
551
552         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
553         https://bugs.webkit.org/show_bug.cgi?id=136736
554
555         Reviewed by Gyuyoung Kim.
556
557         * MiniBrowser/efl/main.c:
558         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
559         (window_create):
560
561 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
562
563         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
564         https://bugs.webkit.org/show_bug.cgi?id=137884
565
566         Reviewed by Gustavo Noronha Silva.
567
568         Move InputMethodFilter test from WebCore tests to WebKit2 tests
569         and adapt it to use the new InputMethodFilter WebKit class. Instead
570         of having virtual methods just for testing, it has a testing mode
571         that logs the events.
572
573         * TestWebKitAPI/PlatformGTK.cmake:
574         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
575         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
576         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
577         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
578         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
579         (TestWebKitAPI::TEST):
580         (TestWebKitAPI::temporaryGetPreeditStringOverride):
581         (TestWebKitAPI::temporaryResetOverride):
582         (TestWebKitAPI::verifyCanceledComposition):
583
584 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
585
586         build.webkit.org/dashboard: Cannot click on green tester bubbles
587         https://bugs.webkit.org/show_bug.cgi?id=137909
588
589         Reviewed by Darin Adler.
590
591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
592         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
593
594 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
595
596         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
597         https://bugs.webkit.org/show_bug.cgi?id=137932
598
599         Reviewed by Simon Fraser.
600
601         This is the first step in moving over to native Windows rendering for our layout tests.
602         Once this change lands, approximately 300 tests will start failing on Windows. I will
603         rebaseline these changes against our test hardware and update this bug with the
604         commits related to that work.
605
606         * DumpRenderTree/win/DumpRenderTree.cpp:
607         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
608         we use native Windows drawing style.
609
610 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
611
612         Fix FTL Native Inlining for EFL
613         https://bugs.webkit.org/show_bug.cgi?id=137774
614
615         Reviewed by Michael Saboff.
616
617         Added Clang as an optional module to jhbuild.
618
619         * efl/jhbuild.modules:
620
621 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
622
623         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
624         https://bugs.webkit.org/show_bug.cgi?id=137832
625
626         Reviewed by Carlos Garcia Campos.
627
628         Ensure each test sets the TLS errors policy that it really needs.
629         Have each test except testTLSErrorsPolicy stash and restore the original
630         TLS errors policy. Update testTLSErrorsPolicy to account for the new
631         default policy.
632
633         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
634         (testSSL):
635         (testInsecureContent):
636         (testTLSErrorsPolicy):
637         (testTLSErrorsRedirect):
638         (testTLSErrorsHTTPAuth):
639         (testLoadFailedWithTLSErrors):
640         (beforeAll):
641
642 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
643
644         Unreviewed. Unskip inspector server unit tests.
645
646         They should pass now.
647
648         * Scripts/run-gtk-tests:
649         (TestRunner):
650
651 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
652
653         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
654         https://bugs.webkit.org/show_bug.cgi?id=132044
655
656         Reviewed by Brian Burg.
657
658         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
659         (openRemoteDebuggingSession): Remove trailing slash when
660         concatenating base inspector URL with the page, because the
661         inspector returns the relative paths with a leading slash.
662
663 2014-10-20  Tanay C  <tanay.c@samsung.com>
664
665         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
666         https://bugs.webkit.org/show_bug.cgi?id=137023
667
668         Reviewed by Gyuyoung Kim.
669
670         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
671         (search_box_show): Modified.
672         (search_box_hide): Modified.
673         (on_search_field_activated): Modified.
674         (on_search_backward_button_clicked): Modified.
675         (on_search_forward_button_clicked): Modified.
676         (on_search_case_option_changed): Added.
677         (on_search_word_start_option_changed): Added.
678         (window_create): Modified.
679
680 2014-10-20  Tanay C  <tanay.c@samsung.com>
681
682         [GTK][Minibrowser] Escape key does not hide the search box
683         https://bugs.webkit.org/show_bug.cgi?id=137734
684
685         Reviewed by Philippe Normand.
686
687         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
688         (stopPageLoad): Modified.
689
690 2014-10-18  Antti Koivisto  <antti@apple.com>
691
692         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
693         https://bugs.webkit.org/show_bug.cgi?id=137855
694
695         Reviewed by Dan Bernstein.
696
697         Test and warn if the dumped response mime type differs from the platform response mime type.
698
699         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
700         (WTR::InjectedBundlePage::didReceiveResponseForResource):
701         (WTR::InjectedBundlePage::platformResponseMimeType):
702         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
703         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
704         (WTR::InjectedBundlePage::platformResponseMimeType):
705
706 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
707
708         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
709         https://bugs.webkit.org/show_bug.cgi?id=137835
710
711         Reviewed by Andreas Kling.
712
713         * Scripts/run-inspector-perf-tests.py: Removed.
714         This script is stale, as PerformanceTests/inspector no longer exists.
715
716 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
717
718         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
719
720         * Scripts/webkitpy/port/ios.py:
721         (IOSSimulatorPort.default_baseline_search_path):
722
723 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
724
725         [iOS] Simplify test fallback paths for iOS Simulator testing
726         https://bugs.webkit.org/show_bug.cgi?id=137830
727
728         Reviewed by Zalan Bujtas.
729         
730         Make the fallback paths be:
731             ios-simulator -> generic
732             ios-simulator-wk2->ios-simulator -> generic
733         
734         so don't include mac in the fallback path. Also remove the
735         version handling for simplicity.
736
737         * Scripts/webkitpy/port/ios.py:
738         (IOSSimulatorPort):
739         (IOSSimulatorPort.default_baseline_search_path):
740
741 2014-10-17  Dana Burkart  <dburkart@apple.com>
742
743         Fix typos in the dashboard config file.
744
745         Unreviewed.
746
747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
748         (WebKitBuildbot):
749
750 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
751
752         [Win] Allow WinLauncher to specify Custom User Agent strings
753         https://bugs.webkit.org/show_bug.cgi?id=137828
754
755         Reviewed by Dean Jackson.
756
757         * WinLauncher/Common.cpp: Add support for custom user agent strings.
758         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
759         and set the user agent strings.
760         * WinLauncher/WinLauncher.h:
761         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
762         resources and dialog for setting custom User Agent strings.
763         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
764
765 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
766
767         [iOS] Turn off font autosizing for iOS WebKitTestRunner
768         https://bugs.webkit.org/show_bug.cgi?id=137806
769
770         Reviewed by Sam Weinig.
771
772         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
773         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
774         to disable font autosizing.
775         
776         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
777         test controller to set platform-specific prefs.
778
779         * WebKitTestRunner/TestController.cpp:
780         (WTR::TestController::resetPreferencesToConsistentValues):
781         (WTR::TestController::platformResetPreferencesToConsistentValues):
782         * WebKitTestRunner/TestController.h:
783         * WebKitTestRunner/ios/TestControllerIOS.mm:
784         (WTR::TestController::platformResetPreferencesToConsistentValues):
785         * WebKitTestRunner/mac/TestControllerMac.mm:
786         (WTR::TestController::platformResetPreferencesToConsistentValues):
787
788 2014-10-16  Dan Bernstein  <mitz@apple.com>
789
790         OSObjectPtr is missing leakRef()
791         https://bugs.webkit.org/show_bug.cgi?id=137798
792
793         Reviewed by Sam Weinig.
794
795         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
796         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
797
798 2014-10-16  Lucas Forschler  <lforschler@apple.com>
799
800         Update target platform to remove Leopard, Snow Leopard, Lion.
801         Add Yosemite. 
802         
803         Unreviewed.
804
805         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
806         (_should_file_trigger_build):
807
808 2014-10-16  David Kilzer  <ddkilzer@apple.com>
809
810         commit-queue: fails to replace OO-PS! with reviewer name
811         <http://webkit.org/b/137795>
812
813         Reviewed by Alexey Proskuryakov.
814
815         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
816         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
817         email addresses to unauthenticated page loads, so we must always
818         authenticate before getting bug data so we get full email
819         addresses.
820
821 2014-10-16  David Kilzer  <ddkilzer@apple.com>
822
823         commit-queue: fails to close bugs after successfully landing patches
824         <http://webkit.org/b/137794>
825
826         Reviewed by Alexey Proskuryakov.
827
828         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
829         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
830         tell Mechanize to use the second <textarea> on the page with
831         name="comment".
832
833 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
834
835         [Win] Update DRT to match Mac Logic
836         https://bugs.webkit.org/show_bug.cgi?id=137787
837
838         Reviewed by Dean Jackson.
839
840         * DumpRenderTree/win/DumpRenderTree.cpp:
841         (initialize): 0 -> nullptr
842         (runTest): Initialize MSG structure before using.
843         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
844         Also, cleanly shut down COM when exiting.
845         * DumpRenderTree/win/FrameLoadDelegate.cpp:
846         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
847         header and add printf to match Mac.
848         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
849         * DumpRenderTree/win/FrameLoadDelegate.h:
850         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
851         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
852         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
853         (isLocalhost): Added.
854         (hostIsUsedBySomeTestsToGenerateError): Added.
855         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
856         of certain error and redirect host names.
857         * DumpRenderTree/win/UIDelegate.cpp:
858         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
859         anything should be output to the console. This modifies behavior to match the Mac.
860         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
861         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
862         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
863         (UIDelegate::webViewAddMessageToConsole): Ditto.
864         * WinLauncher/PageLoadTestClient.cpp:
865         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
866         added last week.
867
868 2014-10-16  Commit Queue  <commit-queue@webkit.org>
869
870         Unreviewed, rolling out r174754.
871         https://bugs.webkit.org/show_bug.cgi?id=137789
872
873         Speculative fix for Windows test was ineffective. (Requested
874         by rfong on #webkit).
875
876         Reverted changeset:
877
878         "[Windows] Add some more logging to debug Windows test
879         issues."
880         http://trac.webkit.org/changeset/174754
881
882 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
883
884         Unreviewed, add myself to CoordinatedGraphics watchers.
885
886         * Scripts/webkitpy/common/config/watchlist:
887
888 2014-10-15  Roger Fong  <roger_fong@apple.com>
889
890         [Windows] Speculative Windows test fix.
891
892         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
893
894 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
895
896         import-w3c-test rewrites relative src paths in ref files incorrectly
897         https://bugs.webkit.org/show_bug.cgi?id=137586
898
899         This patch fixes a bug in test_converter.py where src paths were getting 
900         rewritten as ../../some-path instead of <script src="../../some-path>". 
901         It also adds support for rewriting src paths in style  elements, which was 
902         missing before and it adds tests for this case.
903
904         Reviewed by Bem Jones-Bey.
905
906         * Scripts/webkitpy/w3c/test_converter.py:
907         (_W3CTestConverter.convert_attributes_if_needed):
908         * Scripts/webkitpy/w3c/test_converter_unittest.py:
909         (test_convert_attributes_if_needed):
910         (verify_reference_relative_paths):
911
912 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
913
914         Add --json flag to test-webkitpy to emit JSON formatted test results
915         to stdout
916         https://bugs.webkit.org/show_bug.cgi?id=137353
917
918         Reviewed by Daniel Bates.
919
920         * Scripts/webkitpy/port/server_process_unittest.py:
921         Adds the read method to MockFile to allow the stdout of test_webkitpy
922         to be redirected without causing erroneous test failures.
923         In particular,
924         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
925         and
926         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
927         because when redirecting to a file, the
928         _wait_for_data_and_update_buffers_using_select method in 
929         server_process.py will find that there is a read file descriptor in
930         its call to select.select, which eventually leads to it calling read()
931         on the MockFile object.
932         (MockFile.read):
933         * Scripts/webkitpy/test/main.py:
934         Adds the _print_results_as_json method and the --json flag which
935         determines whether _print_results_as_json will get called.
936         (Tester._parse_args):
937         (Tester._print_results_as_json):
938         (Tester._print_results_as_json.result_dict_from_tuple):
939         (Tester._run_tests):
940
941 2014-10-13  David Farler  <dfarler@apple.com>
942
943         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
944         https://bugs.webkit.org/show_bug.cgi?id=137662
945
946         Reviewed by Darin Adler.
947
948         The layout test harness can close LayoutTestRelay's subprocess
949         stdout and stderr in the case of a timeout or if a run is
950         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
951         finds that no one is listening to its stdout/stderr (broken
952         pipe), then just exit(1), there is nothing to report.
953
954         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
955         (-[LTRelayController didReceiveStdoutData:]):
956         Add @try/@catch for NSFileHandleOperationException.
957         (-[LTRelayController didReceiveStderrData:]):
958         Add @try/@catch for NSFileHandleOperationException.
959
960 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
961
962         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
963         https://bugs.webkit.org/show_bug.cgi?id=137060
964
965         Reviewed by Philippe Normand.
966
967         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
968
969         * MiniBrowser/gtk/BrowserWindow.c:
970         (zoomInCallback):
971         (zoomOutCallback):
972         (defaultZoomCallback): Callback for default zoom keyboard support.
973         (browser_window_init):
974
975 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
976
977         [Mac] DRT stderr logging after the test completes gets attributed to the next test
978
979         Reviewed by Alexey Proskuryakov.
980         
981         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
982         logging to stderr to get associated with the next test.
983         
984         Fix by logging #EOF to stderr later, after we've completely finished with this test.
985
986         * DumpRenderTree/mac/DumpRenderTree.mm:
987         (dumpTestResults):
988         (runTest):
989
990 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
991
992         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
993
994         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
995
996 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
997
998         [cmake] Fix the make build after r174683
999         https://bugs.webkit.org/show_bug.cgi?id=137703
1000
1001         Reviewed by Martin Robinson.
1002
1003         * Scripts/webkitdirs.pm:
1004         (buildCMakeGeneratedProject):
1005
1006 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
1007
1008         Adding myself to the watchlist to CachedFont
1009
1010         Unreviewed.
1011
1012         * Scripts/webkitpy/common/config/watchlist:
1013
1014 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1015
1016         [EFL][GTK] Make it possible to get verbose output with ninja
1017         https://bugs.webkit.org/show_bug.cgi?id=137606
1018
1019         Reviewed by Csaba Osztrogonác.
1020
1021         * Scripts/webkitdirs.pm:
1022         (buildCMakeGeneratedProject):
1023
1024 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1025
1026         [EFL] Make it possible to use ninja for EFL build too
1027         https://bugs.webkit.org/show_bug.cgi?id=137605
1028
1029         Reviewed by Csaba Osztrogonác.
1030
1031         * Scripts/webkitdirs.pm:
1032         (generateBuildSystemFromCMakeProject):
1033         * efl/install-dependencies:
1034
1035 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
1036
1037         [GTK] Minibrowser : Add home buton and keyboard support for home page load
1038         https://bugs.webkit.org/show_bug.cgi?id=137486
1039
1040         Reviewed by Philippe Normand.
1041
1042         * MiniBrowser/gtk/BrowserWindow.c:
1043         (loadHomePage): Callback for home page load.
1044         (browser_window_init):
1045         * MiniBrowser/gtk/BrowserWindow.h:
1046         * MiniBrowser/gtk/main.c:
1047         (main):
1048
1049 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
1050
1051         import-w3c-tests doesn't prefix property values
1052         https://bugs.webkit.org/show_bug.cgi?id=137600
1053
1054         Reviewed by Bem Jones-Bey.
1055
1056         Some property values are prefixed in WebKit. Modified the W3C import
1057         script in order to prefix property values and not only properties.
1058         The patch re-uses most of the already existent logic to prefix
1059         properties.
1060
1061         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
1062         from CSSValueKeywords.in and adapt converter to modify both properties
1063         and property values.
1064         (convert_for_webkit):
1065         (_W3CTestConverter.__init__):
1066         (_W3CTestConverter.output):
1067         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
1068         (_W3CTestConverter):
1069         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
1070         (_W3CTestConverter.add_webkit_prefix_following_regex):
1071         (_W3CTestConverter.convert_reference_relpaths):
1072         (_W3CTestConverter.convert_style_data):
1073         (_W3CTestConverter.convert_attributes_if_needed):
1074         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
1075         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
1076         include checks for property values too.
1077         (W3CTestConverterTest.test_read_prefixed_property_list):
1078         (verify_no_conversion_happened):
1079         (verify_prefixed_properties):
1080         (verify_prefixed_property_values):
1081         (generate_test_content_properties_and_values):
1082         (generate_test_content):
1083         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
1084         prefixed property values and inform about them.
1085         (TestImporter.import_tests):
1086         (TestImporter.write_import_log):
1087
1088 2014-10-13  Jer Noble  <jer.noble@apple.com>
1089
1090         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
1091         https://bugs.webkit.org/show_bug.cgi?id=137533
1092
1093         Reviewed by Andy Estes.
1094
1095         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
1096
1097         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1098         (TestWebKitAPI::isMSEEnabledCallback):
1099         (TestWebKitAPI::TEST):
1100
1101 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
1102
1103         [Win] Implement a page load profiling tool
1104         https://bugs.webkit.org/show_bug.cgi?id=137673
1105
1106         Reviewed by Dean Jackson.
1107
1108         Add a tool to capture and summarize page load statistics.
1109
1110         * WinLauncher/Common.cpp:
1111         (parseCommandLine): Move from WinMain.cpp so that it can
1112         be shared with internal tools.
1113         * WinLauncher/PageLoadTestClient.cpp: Added.
1114         (PageLoadTestClient::PageLoadTestClient):
1115         (PageLoadTestClient::pageLoadStartedAtTime):
1116         (PageLoadTestClient::didStartProvisionalLoad):
1117         (PageLoadTestClient::didCommitLoad):
1118         (PageLoadTestClient::didFirstLayoutForMainFrame):
1119         (PageLoadTestClient::didHandleOnLoadEvents):
1120         (PageLoadTestClient::didFinishLoad):
1121         (PageLoadTestClient::didFailLoad):
1122         (PageLoadTestClient::didInitiateResourceLoad):
1123         (PageLoadTestClient::didEndResourceLoad):
1124         (PageLoadTestClient::pageLoadEndedAtTime):
1125         (PageLoadTestClient::endPageLoad):
1126         (PageLoadTestClient::clearPageLoadState):
1127         (PageLoadTestClient::shouldConsiderPageLoadEnded):
1128         (PageLoadTestClient::maybeEndPageLoadSoon):
1129         (PageLoadTestClient::setPageURL):
1130         (PageLoadTestClient::dumpRunStatistics):
1131         * WinLauncher/PrintWebUIDelegate.cpp:
1132         (PrintWebUIDelegate::createWebViewWithRequest): Handle
1133         nullptr URL properly.
1134         * WinLauncher/ResourceLoadDelegate.cpp: Added.
1135         (ResourceLoadDelegate::QueryInterface):
1136         (ResourceLoadDelegate::AddRef):
1137         (ResourceLoadDelegate::Release):
1138         (ResourceLoadDelegate::identifierForInitialRequest):
1139         (ResourceLoadDelegate::willSendRequest):
1140         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1141         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
1142         (ResourceLoadDelegate::didReceiveResponse):
1143         (ResourceLoadDelegate::didReceiveContentLength):
1144         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1145         (ResourceLoadDelegate::didFailLoadingWithError):
1146         (ResourceLoadDelegate::plugInFailedWithError):
1147         * WinLauncher/ResourceLoadDelegate.h: Added.
1148         (ResourceLoadDelegate::ResourceLoadDelegate):
1149         * WinLauncher/WinLauncher.cpp:
1150         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
1151         page loading statistics.
1152         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
1153         and set private load delegate state.
1154         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
1155         that sets the view's resource load delegate.
1156         (WinLauncher::loadURL): If no URL is passed, load the test document.
1157         * WinLauncher/WinLauncher.h:
1158         (WinLauncher::pageLoadTestClient):
1159         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
1160         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
1161         * WinLauncher/WinLauncherWebHost.cpp:
1162         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
1163         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
1164         it could be used from other source files.
1165         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
1166         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
1167         (WinLauncherWebHost::didFailLoadWithError): Ditto.
1168         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
1169         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
1170         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
1171         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1172         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
1173         * WinLauncher/WinLauncherWebHost.h:
1174         * WinLauncher/WinMain.cpp:
1175         (wWinMain): Create and use new delegates for gathering page load data.
1176         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
1177
1178 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
1179
1180         Improve the test image diffs page
1181         https://bugs.webkit.org/show_bug.cgi?id=137674
1182
1183         Reviewed by Alexey Proskuryakov.
1184         
1185         Don't treat the input file as a format string, otherwise we have to escape special
1186         characters. Just do a couple of replaces.
1187
1188         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1189         (TestResultWriter.write_image_diff_files):
1190
1191 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1192
1193         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
1194         https://bugs.webkit.org/show_bug.cgi?id=137659
1195
1196         Reviewed by Martin Robinson.
1197
1198         * Scripts/webkitpy/port/xvfbdriver.py:
1199         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
1200
1201 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
1202
1203         Add more detailed wait time information to EWS metrics
1204         https://bugs.webkit.org/show_bug.cgi?id=137649
1205
1206         Reviewed by Daniel Bates.
1207
1208         Added average and worst time (we used to only have median), and also a percentage
1209         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
1210
1211         There is always some wait due to the polling nature of the queues, which is well understood
1212         and doesn't need to be measured. What needs to be measured is whether there is enough
1213         bot machines to process patches as soon as they are submitted.
1214
1215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1216         (Analyzer.prototype._analyzeBubblePerformance):
1217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
1218         (MetricsBubbleView.prototype._update):
1219
1220 2014-10-11  Jer Noble  <jer.noble@apple.com>
1221
1222         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
1223         https://bugs.webkit.org/show_bug.cgi?id=137533
1224
1225         Reviewed by Darin Adler.
1226
1227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1228         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1229         (TestWebKitAPI::TEST):
1230         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
1231         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
1232
1233 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
1234
1235         iOS DRT snapshots are limited to the page visible area
1236         https://bugs.webkit.org/show_bug.cgi?id=137650
1237
1238         Reviewed by Daniel Bates.
1239         
1240         LegacyTileCache drawing was limited to the window's visible area, found by
1241         crawling up the layer hierarchy to the root layer. This caused test snapshots to
1242         be missing non-composited content outside the iPhone visible area, which hinders
1243         testing.
1244         
1245         Fix by adding a test-only mode where the window visible area is the entire window.
1246         
1247         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1248         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
1249         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1250         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
1251         for the DRT window.
1252         
1253
1254 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
1255
1256         Page not fully rendered in iOS DRT snapshots
1257         https://bugs.webkit.org/show_bug.cgi?id=137638
1258
1259         Reviewed by Tim Horton.
1260         
1261         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
1262         to ensure that the page has laid out and is rendered by the time we take
1263         the snapshot.
1264
1265         * DumpRenderTree/mac/DumpRenderTree.mm:
1266         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
1267         (-[DumpRenderTree _webThreadInvoked]): Moved.
1268         (-[DumpRenderTree _waitForWebThreadThenDump]):
1269         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
1270         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
1271         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
1272         relies on dispatch_async too, and the inner block won't complete until the outer block
1273         has completed.
1274         (dumpTestResults): Move the guts of dump() here.
1275         (runTest): Whitespace.
1276
1277 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
1278
1279         Adding svn:ignore so that .pyc files don't show up as new.
1280
1281         * Scripts/webkitpy/xcode: Added property svn:ignore.
1282
1283 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
1284
1285         [EFL] Introduce EWebKit_Extension
1286         https://bugs.webkit.org/show_bug.cgi?id=134921
1287
1288         Reviewed by Gyuyoung Kim.
1289
1290         * MiniBrowser/efl/main.c: Added x option to test extension path.
1291         (window_create):
1292         (elm_main):
1293         * Scripts/webkitpy/common/config/watchlist:
1294         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
1295         * Scripts/webkitpy/style/checker.py:
1296         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
1297
1298 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
1299
1300         After r174628 we send the test process a SIGTERM before the SIGKILL.
1301
1302         * Scripts/webkitpy/common/system/executive_unittest.py:
1303         (ExecutiveTest.serial_test_kill_process):
1304
1305 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
1306
1307         [EFL] Enable WebP support.
1308         https://bugs.webkit.org/show_bug.cgi?id=136156
1309
1310         Reviewed by Gyuyoung Kim.
1311
1312         Include libwebp-dev package to support WebP for WK2 Efl.
1313
1314         * efl/install-dependencies:
1315
1316 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1317
1318         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
1319         https://bugs.webkit.org/show_bug.cgi?id=137485
1320
1321         Reviewed by Sergio Villar Senin.
1322
1323         Update GMainLoopSource tests. Most of the tests are now run twice,
1324         first with a GMainLoopSource and then with a
1325         GThreadSafeMainLoopSource, since both should have the same
1326         behaviour. The threading test uses GThreadSafeMainLoopSource and
1327         the delete on destroy test uses GMainLoopSource. The tests
1328         themselves haven't changed, since there's no change in behaviour.
1329
1330         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1331         (TestWebKitAPI::GMainLoopSourceTest::source):
1332         (TestWebKitAPI::basicRescheduling):
1333         (TestWebKitAPI::TEST):
1334         (TestWebKitAPI::reentrantRescheduling):
1335         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
1336         (TestWebKitAPI::basicDestroyCallbacks):
1337         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
1338         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
1339
1340 2014-10-10  Dana Burkart  <dburkart@apple.com>
1341
1342         Fix fat-fingered function name in git-add-reviewer.
1343
1344         Unreviewed.
1345
1346         * Scripts/git-add-reviewer:
1347         (getConfigValue):
1348
1349 2014-10-10  David Farler  <dfarler@apple.com>
1350
1351         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
1352         https://bugs.webkit.org/show_bug.cgi?id=137528
1353
1354         Reviewed by Simon Fraser.
1355
1356         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
1357         and SIGKILL the paired simulator app before exiting cleanly.
1358
1359         webkitpy only uses SIGKILL to kill processes which you cannot
1360         catch. Send SIGTERM to the process and give it chance to do
1361         its thing before sending SIGKILL. Sending a SIGKILL to an already
1362         dead PID is safe.
1363
1364         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
1365         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1366         (-[LTRelayController finish]):
1367         * LayoutTestRelay/LayoutTestRelay/main.m:
1368         (receivedSignal):
1369         (main):
1370
1371 2014-10-10  David Farler  <dfarler@apple.com>
1372
1373         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
1374         https://bugs.webkit.org/show_bug.cgi?id=137527
1375
1376         Reviewed by Simon Fraser.
1377
1378         NSFileHandle doesn't notify of EOF in its readability handler.
1379         Use a dispatch_source_t and an event handler that is called when reading is possible.
1380         In the handler block, do a run-of-the-mill read(2) from standard input and
1381         detect EOF in the usual way by checking that zero bytes were read.
1382
1383         Once an EOF is received, the FIFOs are disconnected, the simulator app
1384         is killed, and the relay exits with status 0.
1385
1386         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1387         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
1388         (-[LTRelayController didDisconnect]):
1389         (-[LTRelayController didConnect]):
1390         (-[LTRelayController launchApp]):
1391         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
1392         confusion with this new dispatch source, called "standardInputDispatchSource".
1393         (-[LTRelayController finish]): Added.
1394         (-[LTRelayController readFileHandle:]): Deleted.
1395
1396 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1397
1398         [EFL] Crash on facebook.com
1399         https://bugs.webkit.org/show_bug.cgi?id=137562
1400
1401         Reviewed by Chris Dumez.
1402
1403         Crash occurs on the facebook.com when the webview is resized
1404         after the <select> item is clicked but no item is chosen.
1405         This crash is just caused by the reference of invalidated variable.
1406         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
1407         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
1408         on MiniBrowser is called.
1409         As a result, just set ewk_menu to NULL in order to prevent crash condition.
1410
1411         * MiniBrowser/efl/main.c:
1412         (on_popup_menu_hide):
1413
1414 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1415
1416         A small wording change for clarity.
1417
1418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
1419         (MetricsBubbleView.prototype._update):
1420
1421 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1422
1423         Dashboard metrics page should have EWS statistics
1424         https://bugs.webkit.org/show_bug.cgi?id=137626
1425
1426         Reviewed by Ryosuke Niwa.
1427
1428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1429         (BubbleQueue): Put shortName in the object, so that it's actually useful.
1430
1431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1432         (BubbleQueueServer): Re-ordered queues to match bubble order.
1433         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
1434         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
1435
1436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1437         Added analysis for bubble queues.
1438
1439         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
1440
1441         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1442         (buildBubbleQueuesTable): Build the UI.
1443
1444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
1445         Added JS sources to load.
1446
1447         * QueueStatusServer/app.yaml: To update app version.
1448
1449         * QueueStatusServer/handlers/processingtimesjson.py: Added.
1450
1451         * QueueStatusServer/main.py: Added a handler for processing-times-json.
1452
1453 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1454
1455         REGRESSION: Commit queue doesn't process rollouts
1456         https://bugs.webkit.org/show_bug.cgi?id=137623
1457
1458         Reviewed by Tim Horton.
1459
1460         * QueueStatusServer/app.yaml:
1461         * QueueStatusServer/handlers/updateworkitems.py:
1462         (UpdateWorkItems._work_items_from_request):
1463
1464 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
1465
1466         Fix syntax error after r174601.
1467
1468         * Scripts/run-javascriptcore-tests:
1469
1470 2014-10-10  Michael Saboff  <msaboff@apple.com>
1471
1472         Add ability to select tarfile name in run-jsc-stress-tests
1473         https://bugs.webkit.org/show_bug.cgi?id=137614
1474
1475         Reviewed by Mark Hahnenberg.
1476
1477         Added optional file name argument to the --tarball option.  
1478
1479         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
1480         extra test given after the options wont be used for the optional tarball file name.
1481         * Scripts/run-jsc-stress-tests:
1482
1483 2014-10-10  Chris Dumez  <cdumez@apple.com>
1484
1485         Unreviewed, update my information in contributors.json
1486
1487         Use my preferred first name and update my expertise areas.
1488
1489         * Scripts/webkitpy/common/config/contributors.json:
1490
1491 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
1492
1493         Fix perl scripts to run with env on Linux
1494         https://bugs.webkit.org/show_bug.cgi?id=137601
1495
1496         Reviewed by Csaba Osztrogonác.
1497
1498         Use of arguments in #! is nonstandard and does not behave the same on
1499         different systems. Linux would look for an executable named "perl -w" 
1500         "use warnings;" does the same things in a more portable way.
1501
1502         * Scripts/commit-log-editor:
1503         * Scripts/num-cpus:
1504         * Scripts/prepare-ChangeLog:
1505         * Scripts/run-launcher:
1506         * Scripts/svn-create-patch:
1507
1508 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1509
1510         [jhbuild] We should be able to disable wiping on configuration change
1511         https://bugs.webkit.org/show_bug.cgi?id=137446
1512
1513         Reviewed by Csaba Osztrogonác.
1514
1515         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
1516         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
1517         or passing --no-wipe-on-change command line option.
1518
1519         * Scripts/update-webkit-libs-jhbuild:
1520
1521 2014-10-09  Andy Estes  <aestes@apple.com>
1522
1523         Teach webkitpy about OS X Yosemite
1524         https://bugs.webkit.org/show_bug.cgi?id=137585
1525
1526         Reviewed by Simon Fraser.
1527
1528         * Scripts/webkitpy/common/system/platforminfo.py:
1529         (PlatformInfo._determine_mac_version):
1530         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1531         (TestPlatformInfo.test_os_version):
1532         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1533         (TestExpectationParser):
1534         * Scripts/webkitpy/port/builders.py:
1535         * Scripts/webkitpy/port/mac.py:
1536         (MacPort):
1537         * Scripts/webkitpy/port/mac_unittest.py:
1538         (test_versions):
1539         (test_baseline_search_path):
1540         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1541         (TestRebaselineTest.test_baseline_directory):
1542         (TestRebaselineExpectations.test_rebaseline_expectations):
1543
1544 2014-10-09  Dana Burkart  <dburkart@apple.com>
1545
1546         Add Mac OS Yosemite dashboard support.
1547
1548         Rubber-stamped by Lucas Forschler.
1549
1550         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
1551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
1552         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1553         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1554         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1555
1556 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
1557
1558         Add Babak to contributors.json and add historical email addresses for some contributors
1559         https://bugs.webkit.org/show_bug.cgi?id=137546
1560
1561         Reviewed by Christophe Dumez.
1562
1563         contributors.json is used to analyze historical commit data and change logs.
1564
1565         Add back historical email addresses for some contributors and also add Babak (Shafiei).
1566
1567         * Scripts/webkitpy/common/config/contributors.json:
1568
1569 2014-10-09  Lucas Forschler  <lforschler@apple.com>
1570
1571         Add Mac OS Yosemite webkit build infrastructure.
1572         
1573         This patch adds 15 bots to our build.webkit.org configuration.
1574         We are matching the current Mavericks machines 1:1.
1575         
1576         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
1577         
1578         Reviewed by Matt Hanson.
1579
1580         * BuildSlaveSupport/build.webkit.org-config/config.json:
1581
1582 2014-10-09  Dana Burkart  <dburkart@apple.com>
1583
1584         Don't use backticks when running commands, as we run into sh-related
1585         interpolation issues. Also, fix our usage of system() to properly
1586         retrieve the status code.
1587         https://bugs.webkit.org/show_bug.cgi?id=137541
1588
1589         Reviewed by Darin Adler.
1590
1591         * Scripts/git-add-reviewer:
1592         (interactive):
1593         (nonInteractive):
1594         (requireCleanWorkTree):
1595         (cherryPick):
1596         (commit):
1597         (addReviewerToFile):
1598         (head):
1599         (isAncestor):
1600         (toCommit):
1601         (changeLogsForCommit):
1602         (resetToCommit):
1603         (getConfigValue):
1604         (runCommandWithOutput):
1605
1606 2014-10-09  Tim Horton  <timothy_horton@apple.com>
1607
1608         Add a WebKit1 preference for selection services
1609         https://bugs.webkit.org/show_bug.cgi?id=137498
1610         <rdar://problem/18572699>
1611
1612         Reviewed by Simon Fraser.
1613
1614         * MiniBrowser/mac/WK1BrowserWindowController.m:
1615         (-[WK1BrowserWindowController awakeFromNib]):
1616         Turn on image and selection services in the Legacy WebKit MiniBrowser.
1617
1618 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
1619
1620         Get the patch scripts running on Haiku
1621         https://bugs.webkit.org/show_bug.cgi?id=137559
1622
1623         Reviewed by Benjamin Poulain.
1624
1625         Use /usr/bin/env instead of hardcoding path to perl.
1626         Declare haiku platform in platforminfo.py to avoid check-webkit-style
1627         failure.
1628
1629         * Scripts/commit-log-editor:
1630         * Scripts/num-cpus:
1631         * Scripts/prepare-ChangeLog:
1632         * Scripts/run-launcher:
1633         * Scripts/svn-create-patch:
1634         * Scripts/webkitpy/common/system/platforminfo.py:
1635         (PlatformInfo._determine_os_name):
1636
1637 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
1638
1639         StyleQueue should throw a PatchIsNotValid exception to achieve
1640         consistency with CommitQueue and EWS
1641         https://bugs.webkit.org/show_bug.cgi?id=137500
1642
1643         Reviewed by Alexey Proskuryakov.
1644
1645         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1646         Adds a call to validate() in run().
1647         (StyleQueueTask.run):
1648         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1649         Adds a return False in the patch is not valid exception statement.
1650         (AbstractEarlyWarningSystem.review_patch):
1651         * Scripts/webkitpy/tool/commands/queues.py:
1652         Adds a return False in the patch is not valid exception statement in
1653         commit queue, and adds an except statement to catch PatchIsNotValid
1654         exceptions in style queue.
1655         (CommitQueue.process_work_item):
1656         (StyleQueue.review_patch):
1657
1658 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1659
1660         Race condition with WebKitWebView:is-loading after starting page load
1661         https://bugs.webkit.org/show_bug.cgi?id=136692
1662
1663         Reviewed by Gustavo Noronha Silva.
1664
1665         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1666         (loadChangedCallback): Only check is-loading is false when load
1667         has finished if the load didn't fail due to a cancellation.
1668         (loadFailedCallback): Only check is-loading is false if the load
1669         didn't fail due to a cancellation.
1670         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1671         (WebViewTest::loadURI): Check is-loading is true and active URI is
1672         the requested one rigth after requesting the load.
1673         (WebViewTest::loadHtml): Ditto.
1674         (WebViewTest::loadPlainText): Ditto.
1675         (WebViewTest::loadBytes): Ditto.
1676         (WebViewTest::loadRequest): Ditto.
1677         (WebViewTest::loadAlternateHTML): Ditto.
1678         (WebViewTest::goBack): Ditto.
1679         (WebViewTest::goForward): Ditto.
1680         (WebViewTest::goToBackForwardListItem): Ditto.
1681
1682 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
1683
1684         [Win] Resolve various static analyzer warnings in Tools.
1685         https://bugs.webkit.org/show_bug.cgi?id=137534
1686
1687         Reviewed by Dean Jackson.
1688
1689         * DumpRenderTree/cg/ImageDiffCG.cpp:
1690         (main): User proper printf specifiers.
1691         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1692         (AccessibilityUIElement::childrenCount): Handle possibility that
1693         gcc_accChildCount returns with an error.
1694         (accessibilityState): Ditto for gcc_accState.
1695         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1696         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
1697         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
1698         be treated as such.
1699         * DumpRenderTree/win/DumpRenderTree.cpp:
1700         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
1701         by comparing an unsigned value as being greater-than zero.
1702         * DumpRenderTree/win/EditingDelegate.cpp:
1703         (dump): Pass proper character pointer type to printf.
1704         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
1705         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1706         (EditingDelegate::shouldInsertNode): Ditto.
1707         (EditingDelegate::shouldInsertText): Ditto.
1708         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1709         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1710         (EditingDelegate::shouldApplyStyle): Ditto.
1711         * DumpRenderTree/win/EventSender.cpp:
1712         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
1713         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
1714         system headers.
1715         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
1716         from CreateDIBSection.
1717         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
1718         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
1719         older versions of MSVC we no longer support.
1720         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
1721         for 64-bit builds.
1722         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
1723         * TestWebKitAPI/TestsController.h: Ditto.
1724         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
1725         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
1726         performing bitwise | before the comparison is done.
1727
1728 2014-10-08  Ada Chan  <adachan@apple.com>
1729
1730         Add a test for WKPageIsPlayingAudio().
1731         https://bugs.webkit.org/show_bug.cgi?id=137048
1732
1733         Reviewed by Darin Adler.
1734
1735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1736         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
1737         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
1738         (TestWebKitAPI::nullJavaScriptCallback):
1739         (TestWebKitAPI::didFinishLoadForFrame):
1740         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
1741         (TestWebKitAPI::setUpClients):
1742         (TestWebKitAPI::TEST):
1743         This test loads a page with a video in it. When the page is loaded, we first check that
1744         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
1745         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
1746         now returns true for the page.
1747         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
1748         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
1749         This is a video copied from LayoutTests/media/content.
1750
1751 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
1752
1753         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
1754         https://bugs.webkit.org/show_bug.cgi?id=137516
1755
1756         Reviewed by Alexey Proskuryakov.
1757
1758         * Scripts/webkitpy/thirdparty/__init__.py:
1759         (AutoinstallImportHook._install_irc):
1760
1761 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1762
1763         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
1764         https://bugs.webkit.org/show_bug.cgi?id=137520
1765
1766         Reviewed by Philippe Normand.
1767
1768         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
1769         For other distributions, we are already installing libjpeg-turbo.
1770         So, do the same for Debian and derivatives.
1771
1772         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
1773
1774 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1775
1776         [webkitpy] Add back the workaround to replace ZipFile.extractall()
1777         https://bugs.webkit.org/show_bug.cgi?id=137519
1778
1779         Reviewed by Csaba Osztrogonác.
1780
1781         It was removed by <http://trac.webkit.org/changeset/174266>,
1782         because the comment stated it is a workaround for buggy python
1783         2.6.1 which shipped on Snow Leopard. But it turned out the bug
1784         is still valid with python 2.7 shipped on the latest Ubuntu
1785         (12.04 and 14.04) and OS X 10.9.
1786
1787         * Scripts/webkitpy/common/system/autoinstall.py:
1788         (AutoInstaller):
1789         (AutoInstaller._extract_all):
1790         (AutoInstaller._unzip):
1791
1792 2014-10-08  Commit Queue  <commit-queue@webkit.org>
1793
1794         Unreviewed, rolling out r174335.
1795         https://bugs.webkit.org/show_bug.cgi?id=137515
1796
1797         It broke EFL layout test totally (Requested by gyuyoung on
1798         #webkit).
1799
1800         Reverted changeset:
1801
1802         "[EFL] Introduce EWebKit_Extension"
1803         https://bugs.webkit.org/show_bug.cgi?id=134921
1804         http://trac.webkit.org/changeset/174335
1805
1806 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1807
1808         [GTK] Make forwarding headers generation depend on source code
1809         https://bugs.webkit.org/show_bug.cgi?id=137394
1810
1811         Reviewed by Philippe Normand.
1812
1813         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
1814         * TestWebKitAPI/PlatformGTK.cmake: Only run
1815         generate-forwarding-headers.pl when source code changes.
1816         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
1817
1818 2014-10-07  Tanay C  <tanay.c@samsung.com>
1819
1820         Remove build warnings in Hashmap API tests
1821         https://bugs.webkit.org/show_bug.cgi?id=137484
1822
1823         Reviewed by Darin Adler.
1824
1825         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1826         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
1827
1828 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
1829
1830         Commit queue doesn't drop obsolete patches sometimes
1831         https://bugs.webkit.org/show_bug.cgi?id=137460
1832
1833         Reviewed by Alexey Proskuryakov.
1834
1835         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1836         Adds another test patch for use in queues_unittest.py.
1837         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1838         (MockBugzilla):
1839         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1840         Raises a PatchIsNotValid exception in the case of validate() returning
1841         false.
1842         (CommitQueueTask.run):
1843         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1844         Raises a PatchIsNotValid exception in the case of validate() returning
1845         false.
1846         (EarlyWarningSystemTask.run):
1847         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1848         Defines PatchIsNotValid exception. 
1849         (PatchIsNotValid):
1850         (PatchIsNotValid.__init__):
1851         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1852         Remove call to validate() and instead catches the PatchIsNotValid
1853         exception.
1854         (AbstractEarlyWarningSystem.review_patch):
1855         * Scripts/webkitpy/tool/commands/queues.py:
1856         Adds logic to catch the PatchIsNotValid exception.
1857         (CommitQueue.process_work_item):
1858         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1859         Adds the test_non_valid_patch test to ensure that invalid patches are
1860         handled properly, and don't just result in indefinite spinning.
1861         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1862         (test_non_valid_patch):
1863
1864 2014-10-07  Daniel Bates  <dabates@apple.com>
1865
1866         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
1867         https://bugs.webkit.org/show_bug.cgi?id=137499
1868
1869         Reviewed by Simon Fraser.
1870
1871         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
1872         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
1873         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
1874         bit simulator builds of iOS WebKit.
1875
1876         * Scripts/webkitpy/port/ios.py:
1877         (IOSSimulatorPort._generate_all_test_configurations):
1878
1879 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1880
1881         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
1882         https://bugs.webkit.org/show_bug.cgi?id=137482
1883
1884         Reviewed by Martin Robinson.
1885
1886         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
1887
1888 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1889
1890         [SOUP] TLS errors should take precedence over HTTP authentication
1891         https://bugs.webkit.org/show_bug.cgi?id=137300
1892
1893         Reviewed by Sergio Villar Senin.
1894
1895         Add a test case to check that authenticate signal is not emitted
1896         in case of TLS errors, and the load fails instead.
1897
1898         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1899         (webViewAuthenticationCallback):
1900         (testTLSErrorsHTTPAuth):
1901         (httpsServerCallback):
1902         (beforeAll):
1903
1904 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
1905
1906         Make webkit-patch find-users useful
1907         https://bugs.webkit.org/show_bug.cgi?id=137475
1908
1909         Reviewed by Alexey Proskuryakov.
1910
1911         Make find-users use the CommitterList instead of accessing Bugzilla.
1912
1913         This essentially exposes the same functionality as webkitbot's whois command.
1914
1915         * Scripts/webkitpy/tool/commands/findusers.py:
1916         (FindUsers.execute):
1917
1918 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
1919
1920         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
1921         https://bugs.webkit.org/show_bug.cgi?id=137289
1922
1923         Unreviewed build fix.
1924
1925         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1926         (AccessibilityUIElement::getChildrenWithRange):
1927
1928 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1929
1930         build.webkit.org/dashboard: Add commit queue
1931         https://bugs.webkit.org/show_bug.cgi?id=137462
1932
1933         Reviewed by Tim Horton.
1934
1935         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
1936         Style queue is still invisible, as it doesn't have an associated platform, and also
1937         we never have problems with it anyway, so it's not worth watching.
1938
1939         The UI now allows for adding more bots to the Other column (such as leaks bot).
1940         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
1941         sources of data in a cell.
1942
1943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
1944         (BubbleQueue):
1945         (BubbleQueue.prototype.get statusPageURL):
1946         (BubbleQueue.prototype.update):
1947         (BubbleQueue.prototype.loadDetailedStatus):
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
1949         (BubbleQueueServer):
1950         (BubbleQueueServer.prototype.jsonQueueLengthURL):
1951         (BubbleQueueServer.prototype.jsonQueueStatusURL):
1952         (BubbleQueueServer.prototype.queueStatusURL):
1953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
1954         (BubbleQueueView):
1955         (BubbleQueueView.prototype.update.appendQueue):
1956         (BubbleQueueView.prototype.update):
1957         (BubbleQueueView.prototype._addQueueHeadingToPopover):
1958         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
1959         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
1960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
1961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
1962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
1963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1964         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1965         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1966         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
1967         (.bubble-server-popover .latest-status-no-link):
1968         (.bubble-server-popover .bot-status-description):
1969         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1970
1971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1972         (buildAggregateTable):
1973         (buildQueuesTable):
1974         Removed dysfunctional support for EWS for now. It will be different.
1975
1976 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1977
1978         One more case of incorrect comparison in recordpatchevent.py
1979         https://bugs.webkit.org/show_bug.cgi?id=137459
1980
1981         Reviewed by Tim Horton.
1982
1983         * QueueStatusServer/app.yaml:
1984         * QueueStatusServer/loggers/recordpatchevent.py:
1985         (RecordPatchEvent.started):
1986
1987 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1988
1989         webkit-queues PatchLog is incorrect for patches that took less than a second
1990         https://bugs.webkit.org/show_bug.cgi?id=137453
1991
1992         Reviewed by Tim Horton.
1993
1994         * QueueStatusServer/app.yaml: Updated app version.
1995
1996         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
1997         Don't bail out for patches that took 0 seconds to process (as frequently happens
1998         when a patch is obsolete).
1999
2000 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
2001
2002         EWS bubble hover shows wrong timestamps
2003         https://bugs.webkit.org/show_bug.cgi?id=137252
2004
2005         Reviewed by Alexey Proskuryakov.
2006
2007         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
2008
2009         * QueueStatusServer/handlers/queuestatusjson.py:
2010         (QueueStatusJSON.get):
2011         * QueueStatusServer/handlers/statusbubble.py:
2012         (StatusBubble._iso_time):
2013
2014 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
2015
2016         Unreviewed, updated list of email addresses in contributors.json
2017
2018         * Scripts/webkitpy/common/config/contributors.json: Added my former
2019         email address in Igalia, for the sake of completeness.
2020
2021 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2022
2023         Unreviewed, moved myself to the list of committers.
2024
2025         * Scripts/webkitpy/common/config/contributors.json:
2026
2027 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
2028
2029         [EFL] Introduce EWebKit_Extension
2030         https://bugs.webkit.org/show_bug.cgi?id=134921
2031
2032         Reviewed by Gyuyoung Kim.
2033
2034         * MiniBrowser/efl/main.c: Added x option to test extension path.
2035         (window_create):
2036         (elm_main):
2037         * Scripts/webkitpy/common/config/watchlist:
2038         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
2039         * Scripts/webkitpy/style/checker.py:
2040         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
2041
2042 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
2043
2044         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
2045         https://bugs.webkit.org/show_bug.cgi?id=137390
2046
2047         Reviewed by Carlos Garcia Campos.
2048
2049         * Scripts/update-webkit-libs-jhbuild:
2050
2051 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2052
2053         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
2054         https://bugs.webkit.org/show_bug.cgi?id=137391
2055
2056         Reviewed by Martin Robinson.
2057
2058         Add a custom command to only re-generate
2059         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
2060
2061         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2062
2063 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2064
2065         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
2066         https://bugs.webkit.org/show_bug.cgi?id=135502
2067
2068         Reviewed by Martin Robinson.
2069
2070         When writing to stdout/stderr fails due to a UnicodeDecodeError
2071         exception, try again without encoding the output.
2072
2073         * gtk/gtkdoc.py:
2074         (GTKDoc._run_command):
2075
2076 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
2077
2078         Bugzilla status bubble displays an exception showing attachment 175738
2079         https://bugs.webkit.org/show_bug.cgi?id=137410
2080
2081         Reviewed by Tim Horton.
2082
2083         * QueueStatusServer/app.yaml: Update version.
2084
2085         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
2086         Don't fail even if expected status message is missing.
2087
2088         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
2089         the field in the same way it's defined in QueueStatus table.
2090
2091 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
2092
2093         Record latest message in PatchLog for quick access
2094         https://bugs.webkit.org/show_bug.cgi?id=137405
2095
2096         Fixing a typo.
2097
2098         * QueueStatusServer/app.yaml:
2099         * QueueStatusServer/handlers/releasepatch.py:
2100
2101 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
2102
2103         Record latest message in PatchLog for quick access
2104         https://bugs.webkit.org/show_bug.cgi?id=137405
2105
2106         Reviewed by Ryosuke Niwa.
2107
2108         It's no SQL...
2109
2110         * QueueStatusServer/handlers/releasepatch.py:
2111         * QueueStatusServer/handlers/updatestatus.py:
2112         * QueueStatusServer/loggers/recordpatchevent.py:
2113         * QueueStatusServer/model/patchlog.py:
2114
2115 2014-10-02  David Farler  <dfarler@apple.com>
2116
2117         -asan-blacklist option also renamed to generic -fsanitize-blacklist
2118         https://bugs.webkit.org/show_bug.cgi?id=137377
2119
2120         Reviewed by Daniel Bates.
2121
2122         * asan/asan.xcconfig:
2123         -asan-blacklist -> -fsanitize-blacklist
2124
2125         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
2126
2127 2014-10-03  Roger Fong  <roger_fong@apple.com>
2128
2129         [Windows] Include batch size argument to layout tests on Windows.
2130
2131         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2132         (RunWebKitTests.start): 
2133         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
2134         These crashes seem to happen on random tests though generally in a spread out fashion.
2135         It seems possible that the DRT instance is being clobbered somehow after running too many
2136         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
2137
2138 2014-10-03  Roger Fong  <roger_fong@apple.com>
2139
2140         [Windows] Settle for 2 chid processes running NRWT on Windows.
2141
2142         * Scripts/webkitpy/port/win.py:
2143         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
2144
2145 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
2146
2147         [GTK] Bump up and patch dependencies to allow building for aarch64
2148         https://bugs.webkit.org/show_bug.cgi?id=137147
2149
2150         Reviewed by Martin Robinson.
2151
2152         The currently used versions of pixman, libffi, librsvg, glib,
2153         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
2154         and/or build for aarch64, so they are bumped up and patched where
2155         necessary. Wherever possible, the same versions and patches were used as
2156         for the EFL port bump-up
2157         (https://bugs.webkit.org/show_bug.cgi?id=135885).
2158
2159         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
2160         regression by crashing http/tests/media/video-redirect.html . A patch
2161         already in upstream fixes that bug.
2162
2163         This change does not touch xserver, which also needs bumping up, but 
2164         will be dealt with later.
2165
2166         * gtk/jhbuild.modules:
2167         Specified versions and patches necessary to correctly build for aarch64.
2168         * gtk/patches/gst-events-arent-gstobjects.patch:
2169         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
2170         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
2171         Added. Patches gst-plugins-base to configure correctly for aarch64.
2172         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
2173         Added. Bumps up config.guess and config.sub in librsvg to recognize
2174         aarch64.
2175         * gtk/patches/libxml2-2.9.0-dtd.patch:
2176         Removed. Not necessary for libxml2 v2.9.1 anymore.
2177
2178 2014-09-28  Sam Weinig  <sam@webkit.org>
2179
2180         Remove RefPtrHashMap
2181         https://bugs.webkit.org/show_bug.cgi?id=137200
2182
2183         Reviewed by Darin Adler.
2184
2185         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2186         (TestWebKitAPI::TEST):
2187         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
2188         a minimum of refcount churn occurs.
2189
2190 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2191
2192         Remove workarounds for versions of Python before 2.7
2193         https://bugs.webkit.org/show_bug.cgi?id=137338
2194
2195         Reviewed by Csaba Osztrogonác.
2196
2197         * Scripts/webkitpy/common/system/autoinstall.py:
2198         (AutoInstaller._extract_targz):
2199         (AutoInstaller._unzip):
2200         (AutoInstaller): Deleted.
2201         (AutoInstaller._extract_all): Deleted.
2202         * Scripts/webkitpy/common/webkitunittest.py:
2203         (TestCase.setUp): Deleted.
2204         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2205         (TestConfigurationConverter.collapse_macros):
2206         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2207         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2208         (TestConfigurationConverter):
2209         (TestConfigurationConverter.combinations): Deleted.
2210         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2211         * Scripts/webkitpy/port/base.py:
2212
2213 2014-10-03  Commit Queue  <commit-queue@webkit.org>
2214
2215         Unreviewed, rolling out r174264.
2216         https://bugs.webkit.org/show_bug.cgi?id=137392
2217
2218         It broke run-webkit-tests (Requested by ebalazsfalvi on
2219         #webkit).
2220
2221         Reverted changeset:
2222
2223         "Remove workarounds for versions of Python before 2.7"
2224         https://bugs.webkit.org/show_bug.cgi?id=137338
2225         http://trac.webkit.org/changeset/174264
2226
2227 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2228
2229         Remove workarounds for versions of Python before 2.7
2230         https://bugs.webkit.org/show_bug.cgi?id=137338
2231
2232         Reviewed by Csaba Osztrogonác.
2233
2234         * Scripts/webkitpy/common/system/autoinstall.py:
2235         (AutoInstaller._extract_targz):
2236         (AutoInstaller._unzip):
2237         (AutoInstaller): Deleted.
2238         (AutoInstaller._extract_all): Deleted.
2239         * Scripts/webkitpy/common/webkitunittest.py:
2240         (TestCase.setUp): Deleted.
2241         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2242         (TestConfigurationConverter.collapse_macros):
2243         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2244         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2245         (TestConfigurationConverter):
2246         (TestConfigurationConverter.combinations): Deleted.
2247         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2248         * Scripts/webkitpy/port/base.py:
2249         * Scripts/webkitpy/port/driver.py:
2250         (ContentBlock.__init__):
2251         * Scripts/webkitpy/port/server_process.py:
2252         (ServerProcess._reset):
2253
2254 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2255
2256         Remove autoinstaller workaround for python 2.6
2257         https://bugs.webkit.org/show_bug.cgi?id=137343
2258
2259         Reviewed by Daniel Bates.
2260
2261         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
2262         2.6, nor Snow Leopard is supported anymore, so the workaround is not
2263         needed anymore.
2264
2265         * Scripts/webkitpy/common/system/autoinstall.py:
2266         (AutoInstaller.install):
2267         * Scripts/webkitpy/test/main.py:
2268         (Tester._run_tests):
2269         * Scripts/webkitpy/thirdparty/__init__.py:
2270         (AutoinstallImportHook._install_mechanize):
2271         (AutoinstallImportHook._install_pep8):
2272         (AutoinstallImportHook._install_pylint):
2273         (AutoinstallImportHook._install_buildbot):
2274         (AutoinstallImportHook._install_coverage):
2275         (AutoinstallImportHook._install_eliza):
2276         (AutoinstallImportHook._install_irc):
2277         (AutoinstallImportHook._install):
2278         (autoinstall_everything):
2279
2280 2014-10-02  Daniel Bates  <dabates@apple.com>
2281
2282         Use version number 101000 instead of 10100 for OS X Yosemite
2283         https://bugs.webkit.org/show_bug.cgi?id=137372
2284
2285         Reviewed by Mark Rowe.
2286
2287         The version number for OS X Yosemite is 101000.
2288
2289         * DumpRenderTree/mac/TextInputController.m:
2290
2291 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
2292
2293         update-work-items should never delete items
2294         https://bugs.webkit.org/show_bug.cgi?id=137366
2295
2296         Reviewed by Ryosuke Niwa.
2297
2298         As we don't just replace the whole list any more, indicate which items are high
2299         priority, and which are not. Hight priority ones will be prepended to the queue,
2300         others will be appended.
2301
2302         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
2303         But hopefully we will never have many rollouts competing like that.
2304
2305         * QueueStatusServer/app.yaml: Update version.
2306
2307         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
2308         priority and regular items separately. Removed some error handling that used to
2309         end up in returning status 500 - an uncaught exception does that automatically.
2310
2311         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
2312
2313         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
2314
2315         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
2316         priority items.
2317
2318         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2319         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
2320         line that complicated testing.
2321
2322         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
2323
2324         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
2325         priority items into separate lists.
2326
2327         * Scripts/webkitpy/common/net/statusserver_mock.py:
2328         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2329         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2330         Updated tests.
2331
2332 2014-10-02  Brendan Long  <b.long@cablelabs.com>
2333
2334         Annoying build warnings in WTFString API tests
2335         https://bugs.webkit.org/show_bug.cgi?id=137360
2336
2337         Reviewed by Darin Adler.
2338
2339         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2340         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
2341
2342 2014-10-02  Roger Fong  <roger_fong@apple.com>
2343
2344         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
2345
2346         * Scripts/webkitpy/port/win.py:
2347         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
2348
2349 2014-10-02  David Farler  <dfarler@apple.com>
2350
2351         Move ASan arguments from LLVM (-mllvm) to the frontend
2352         https://bugs.webkit.org/show_bug.cgi?id=137365
2353
2354         Reviewed by David Kilzer.
2355
2356         * asan/asan.xcconfig:
2357         Remove the -mllvm prefix to the asan-blacklist argument, moving it
2358         to the clang frontend.
2359
2360         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
2361
2362 2014-10-02  Commit Queue  <commit-queue@webkit.org>
2363
2364         Unreviewed, rolling out r174120.
2365         https://bugs.webkit.org/show_bug.cgi?id=137350
2366
2367         While number of failures is reasonable with 2 processes, test
2368         results seem to be inconsistent between runs (Requested by
2369         rfong on #webkit).
2370
2371         Reverted changeset:
2372
2373         "[Windows] Back to 2 child processes for NRWT on Windows."
2374         http://trac.webkit.org/changeset/174120
2375
2376 2014-10-02  Jeff Miller  <jeffm@apple.com>
2377
2378         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
2379         https://bugs.webkit.org/show_bug.cgi?id=137347
2380
2381         Reviewed by Dan Bernstein.
2382
2383         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2384         Use WebKitSystemInterfaceYosemite on OS X 10.10.
2385
2386         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2387         Ditto.
2388
2389 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2390
2391         [GTK] [JHBuild] Switch sourceware.org mirror to http.
2392
2393         Unreviewed.
2394
2395         The ftp access is recently failing to work as expected, and the
2396         bots fail to download the file.
2397         The same mirror is available via http and seems to work better.
2398
2399         * gtk/jhbuild.modules:
2400
2401 2014-10-01  Commit Queue  <commit-queue@webkit.org>
2402
2403         Unreviewed, rolling out r174185.
2404         https://bugs.webkit.org/show_bug.cgi?id=137334
2405
2406         Patch that adds logging causes webkitpy failures (Requested by
2407         rfong on #webkit).
2408
2409         Reverted changeset:
2410
2411         "commitqueuetasks_unittest references a non-existent member
2412         variable"
2413         https://bugs.webkit.org/show_bug.cgi?id=137303
2414         http://trac.webkit.org/changeset/174185
2415
2416 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2417
2418         EWS and Commit Queue should know better than to spew 500 failed
2419         results in the case of extremely red patches.
2420         https://bugs.webkit.org/show_bug.cgi?id=137324
2421
2422         Reviewed by Alexey Proskuryakov.
2423
2424         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2425         Adds a check for did_exceed_test_failure_limit.
2426         (AbstractEarlyWarningSystem._failing_tests_message):
2427         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2428         Alters the task mock to respond properly to
2429         results_from_patch_test_run(patch)
2430         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2431         * Scripts/webkitpy/tool/commands/queues.py:
2432         Adds a check for did_exceed_test_failure_limit.
2433         (CommitQueue._failing_tests_message):
2434
2435 2014-10-01  Daniel Bates  <dabates@apple.com>
2436
2437         Unreviewed, rolling out r174192.
2438
2439         Revert the unit test fix in r174192 since we reverted r174187
2440         in r174194 due to correctness issues. See
2441         <http://webkit.org/b/137329> for more details.
2442
2443         Reverted changeset:
2444
2445         "Test fix after r174187"
2446         http://trac.webkit.org/changeset/174192
2447
2448 2014-10-01  Mark Rowe  <mrowe@apple.com>
2449
2450         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2451
2452         Reviewed by Dan Bernstein.
2453
2454         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
2455         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
2456         for the LLVM components when on Yosemite.
2457
2458 2014-10-01  Commit Queue  <commit-queue@webkit.org>
2459
2460         Unreviewed, rolling out r174187.
2461         https://bugs.webkit.org/show_bug.cgi?id=137329
2462
2463         webkitpy failures, and thorton says the patch is wrong
2464         (Requested by dethbakin on #webkit).
2465
2466         Reverted changeset:
2467
2468         "[Windows] Increase layout test timeout for Windows following
2469         r174162."
2470         http://trac.webkit.org/changeset/174187
2471
2472 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
2473
2474         Test fix after r174187
2475
2476         * Scripts/webkitpy/port/win_unittest.py:
2477         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
2478
2479 2014-10-01  Roger Fong  <roger_fong@apple.com>
2480
2481         [Windows] Increase layout test timeout for Windows following r174162.
2482
2483         * Scripts/webkitpy/port/win.py:
2484         (WinPort.default_timeout_ms):
2485
2486 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2487
2488         commitqueuetasks_unittest references a non-existent member variable
2489         when mock-reporting flaky tests.
2490         https://bugs.webkit.org/show_bug.cgi?id=137303
2491
2492         Reviewed by Daniel Bates.
2493
2494         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2495         (MockCommitQueue.report_flaky_tests):
2496         Makes the appropriate name change.
2497         (test_simple_flaky_test_failure):
2498         Adds a unit test to make sure that the code is excercised.
2499
2500 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2501
2502         EWS is inconclusively spinning forever on a patch that breaks 500+
2503         tests
2504         https://bugs.webkit.org/show_bug.cgi?id=137223
2505
2506         Reviewed by Tim Horton.
2507
2508         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2509         Checks to see whether the tests have exceeded the failure limit, and
2510         only spins off another test if they have not exceeded the limit.
2511         (PatchAnalysisTask._test_patch):
2512
2513 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
2514
2515         Unreviewed, add Katie Madonna as a contributor.
2516
2517         * Scripts/webkitpy/common/config/contributors.json:
2518
2519 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2520
2521         commitqueuetasks_unittest does not construct FailingTestCommitQueue
2522         objects properly in its test cases.
2523         https://bugs.webkit.org/show_bug.cgi?id=137281
2524
2525         Reviewed by Daniel Bates.
2526
2527         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2528         (FailingTestCommitQueue.test_results):
2529         Adds an assert to make FailingTestCommitQueue harder to mis-use.
2530         (test_double_flaky_test_failure):
2531         Nests the intended test failure strings into one-length lists.
2532         (test_red_test_failure):
2533         Nests the intended test failure strings into one-length lists.
2534
2535 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
2536
2537         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
2538         https://bugs.webkit.org/show_bug.cgi?id=136987
2539
2540         Reviewed by Daniel Bates.
2541
2542         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
2543         Specify the default encoding for all WebKit developers to get consistent results.
2544
2545 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
2546
2547         EWS is too eager to say that a patch does not apply to trunk of repository
2548         https://bugs.webkit.org/show_bug.cgi?id=137290
2549
2550         Reviewed by Ryosuke Niwa.
2551
2552         * QueueStatusServer/app.yaml: Updated app version.
2553
2554         * QueueStatusServer/handlers/statusbubble.py:
2555         (StatusBubble._build_bubble):
2556         (StatusBubble._build_bubbles_for_attachment):
2557         Rewrote to make more sense.
2558
2559 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2560
2561         Remove thirdparty/unittest2 from webkitpy
2562         https://bugs.webkit.org/show_bug.cgi?id=137251
2563
2564         Reviewed by Brent Fulgham.
2565
2566         Additionally ordered imports in related webkitpy files and
2567         removed unnecessary shebangs from unittest files.
2568
2569         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
2570         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2571         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2572         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
2573         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
2574         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2575         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2576         * Scripts/webkitpy/common/config/committers_unittest.py:
2577         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2578         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
2579         * Scripts/webkitpy/common/config/ports_unittest.py:
2580         * Scripts/webkitpy/common/config/urls_unittest.py:
2581         * Scripts/webkitpy/common/editdistance_unittest.py:
2582         * Scripts/webkitpy/common/find_files_unittest.py:
2583         * Scripts/webkitpy/common/lru_cache_unittest.py:
2584         * Scripts/webkitpy/common/memoized_unittest.py:
2585         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
2586         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2587         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2588         * Scripts/webkitpy/common/net/credentials_unittest.py:
2589         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2590         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
2591         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2592         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2593         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2594         * Scripts/webkitpy/common/net/statusserver_unittest.py:
2595         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
2596         * Scripts/webkitpy/common/newstringio_unittest.py:
2597         * Scripts/webkitpy/common/prettypatch_unittest.py:
2598         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
2599         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2600         * Scripts/webkitpy/common/system/environment_unittest.py:
2601         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
2602         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
2603         * Scripts/webkitpy/common/system/executive_unittest.py:
2604         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2605         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2606         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2607         * Scripts/webkitpy/common/system/logtesting.py:
2608         * Scripts/webkitpy/common/system/logutils_unittest.py:
2609         * Scripts/webkitpy/common/system/outputcapture.py:
2610         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2611         * Scripts/webkitpy/common/system/outputtee_unittest.py:
2612         * Scripts/webkitpy/common/system/path_unittest.py:
2613         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2614         * Scripts/webkitpy/common/system/profiler_unittest.py:
2615         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
2616         * Scripts/webkitpy/common/system/user_unittest.py:
2617         * Scripts/webkitpy/common/system/workspace_unittest.py:
2618         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2619         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
2620         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
2621         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
2622         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
2623         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
2624         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
2625         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
2626         * Scripts/webkitpy/common/webkitunittest.py:
2627         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2628         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2629         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2630         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2631         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2632         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2633         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2634         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
2635         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
2636         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2637         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2638         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2639         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
2640         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2641         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2642         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
2643         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2644         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2645         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2646         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2647         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2648         * Scripts/webkitpy/port/base_unittest.py:
2649         * Scripts/webkitpy/port/builders_unittest.py:
2650         * Scripts/webkitpy/port/config_unittest.py:
2651         * Scripts/webkitpy/port/driver_unittest.py:
2652         * Scripts/webkitpy/port/efl_unittest.py:
2653         * Scripts/webkitpy/port/factory_unittest.py:
2654         * Scripts/webkitpy/port/gtk_unittest.py:
2655         * Scripts/webkitpy/port/http_lock_unittest.py:
2656         * Scripts/webkitpy/port/image_diff_unittest.py:
2657         * Scripts/webkitpy/port/leakdetector_unittest.py:
2658         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
2659         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2660         * Scripts/webkitpy/port/mock_drt_unittest.py:
2661         * Scripts/webkitpy/port/port_testcase.py:
2662         * Scripts/webkitpy/port/server_process_unittest.py:
2663         * Scripts/webkitpy/port/westondriver_unittest.py:
2664         * Scripts/webkitpy/port/win_unittest.py:
2665         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2666         * Scripts/webkitpy/style/checker_unittest.py:
2667         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2668         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2669         * Scripts/webkitpy/style/checkers/common_unittest.py:
2670         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2671         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
2672         * Scripts/webkitpy/style/checkers/js_unittest.py:
2673         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
2674         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
2675         * Scripts/webkitpy/style/checkers/png_unittest.py:
2676         * Scripts/webkitpy/style/checkers/python_unittest.py:
2677         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2678         * Scripts/webkitpy/style/checkers/text_unittest.py:
2679         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
2680         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
2681         * Scripts/webkitpy/style/checkers/xml_unittest.py:
2682         * Scripts/webkitpy/style/error_handlers_unittest.py:
2683         * Scripts/webkitpy/style/filereader_unittest.py:
2684         * Scripts/webkitpy/style/filter_unittest.py:
2685         * Scripts/webkitpy/style/main_unittest.py:
2686         * Scripts/webkitpy/style/optparser_unittest.py:
2687         * Scripts/webkitpy/style/patchreader_unittest.py:
2688         * Scripts/webkitpy/test/finder_unittest.py:
2689         * Scripts/webkitpy/test/main.py: Ordered imports.
2690         * Scripts/webkitpy/test/main_unittest.py:
2691         * Scripts/webkitpy/test/printer.py: Ordered imports.
2692         (Printer.configure):
2693         * Scripts/webkitpy/test/runner_unittest.py:
2694         * Scripts/webkitpy/test/skip_unittest.py:
2695         * Scripts/webkitpy/thirdparty/__init__.py:
2696         (AutoinstallImportHook._install_irc):
2697         (AutoinstallImportHook._install_unittest2): Deleted.
2698         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2699         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
2700         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2701         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2702         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2703         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2704         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2705         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2706         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2707         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2708         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2709         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2710         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2711         * Scripts/webkitpy/tool/commands/download_unittest.py:
2712         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2713         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
2714         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2715         * Scripts/webkitpy/tool/commands/queuestest.py:
2716         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2717         * Scripts/webkitpy/tool/grammar_unittest.py:
2718         * Scripts/webkitpy/tool/mocktool_unittest.py:
2719         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2720         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2721         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2722         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
2723         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
2724         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2725         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2726         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2727         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2728         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
2729         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2730         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2731         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2732         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2733         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2734         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2735         * Scripts/webkitpy/tool/steps/update_unittest.py:
2736         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2737         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2738         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2739         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2740         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2741
2742 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
2743
2744         LayoutTestResults and ExpectedFailures should know about the
2745         interrupted flag from the json results file
2746         https://bugs.webkit.org/show_bug.cgi?id=137229
2747
2748         Reviewed by Daniel Bates.
2749
2750         Changes LayoutTestResults to use the interrupted flag instead of
2751         counting failures.
2752
2753         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2754         (BuilderTest._install_fetch_build._mock_fetch_build):
2755         (BuilderTest.test_latest_layout_test_results):
2756         * Scripts/webkitpy/common/net/layouttestresults.py:
2757         Removes notion of failure_limit_count, and adds
2758         did_exceed_test_failure_limit.
2759
2760         (LayoutTestResults.results_from_string):
2761         (LayoutTestResults.__init__):
2762         (LayoutTestResults.did_exceed_test_failure_limit):
2763         (LayoutTestResults): Deleted.
2764         (LayoutTestResults.set_failure_limit_count): Deleted.
2765         (LayoutTestResults.failure_limit_count): Deleted.
2766         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2767         Removes unit test for failure_limit_count logic.
2768
2769         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
2770         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2771         Instead of providing a class method that returns a list of
2772         TestResults objects, resultsjsonparser now provides a class
2773         ParsedJSONResults that serves as an interface between the results.json
2774         file and the rest of webkitpy.
2775
2776         (ParsedJSONResults):
2777         (ParsedJSONResults.__init__):
2778         (ParsedJSONResults.did_exceed_test_failure_limit):
2779         (ParsedJSONResults.test_results):
2780         (ResultsJSONParser): Deleted.
2781         (ResultsJSONParser.parse_results_json): Deleted.
2782         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2783         Updates the unit test so that it can test the new ResultsJSONParser
2784         class.
2785
2786         (ParsedJSONResultsTest):
2787         (test_basic):
2788         (ResultsJSONParserTest): Deleted.
2789         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2790         Updates the unit test to instantiate ResultsJSONParser objects rather
2791         than simple lists of TestResult objects.
2792
2793         (MockCommitQueue.test_results):
2794         (FailingTestCommitQueue.test_results):
2795         (test_flaky_test_failure):
2796         (test_failed_archive):
2797         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2798         Updates ExpectedFailures to use the did_exceed_test_failure_limit
2799         method rather than counting the number of failed tests.
2800
2801         (ExpectedFailures._should_trust):
2802         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2803         Updates MockResults to more closely resemble the updated
2804         LayoutTestResults class.
2805
2806         (MockResults.__init__):
2807         (MockResults.did_exceed_test_failure_limit):
2808         (ExpectedFailuresTest.test_can_trust_results):
2809         (ExpectedFailuresTest.test_unexpected_failures_observed):
2810         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
2811         (MockResults.failure_limit_count): Deleted.
2812         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2813         Removes a FIXME regarding the use of the
2814         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
2815
2816         (LayoutTestResultsReader.results):
2817         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2818         Updates test to not check the now-nonexistant failure_count_limit
2819         method.
2820
2821         (test_missing_unit_test_results_path):
2822         (test_layout_test_results):
2823         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2824         Accounts for name change: ResultsJSONParserTest ->
2825         ParsedJSONParserTest.
2826
2827         (RebaselineTestTest.test_gather_baselines):
2828
2829 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2830
2831         [EFL] Rename TEST_THEME_DIR macro
2832         https://bugs.webkit.org/show_bug.cgi?id=137244
2833
2834         Reviewed by Csaba Osztrogonác.
2835
2836         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
2837         DEFAULT_THEME_DIR is better than it.
2838
2839         * MiniBrowser/efl/main.c:
2840         (window_create):
2841         * TestWebKitAPI/efl/PlatformWebView.cpp:
2842         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2843         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2844         (WTR::PlatformWebView::PlatformWebView):
2845
2846 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2847
2848         Windows EWS went purple when it failed to build
2849         https://bugs.webkit.org/show_bug.cgi?id=137267
2850
2851         Reviewed by Ryosuke Niwa.
2852
2853         * QueueStatusServer/app.yaml: Update the version.
2854
2855         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
2856         Make it work for style and win-ews queues.
2857
2858 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
2859
2860         It should be fun and easy to run every possible JavaScript benchmark from the command line
2861         https://bugs.webkit.org/show_bug.cgi?id=137245
2862
2863         Reviewed by Oliver Hunt.
2864         
2865         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
2866         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
2867         having their own private scripts for doing benchmark runs, and didn't share them in the open
2868         source community, because of fears about the shady licensing of the benchmarks suites that
2869         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
2870         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
2871         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
2872         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
2873         but some of them are. The non-public tests are exclusively those that were not made by any
2874         WebKit contributor, but which JSC/WebKit devs found useful for testing.
2875
2876         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
2877         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
2878         checked into WebKit svn at all) can be run by passing the path to them via a configuration
2879         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
2880         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
2881         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
2882         probably never be checked in because there is no license text anywhere in that benchmark.
2883         A valid ~/.run-jsc-benchmarks file will just be something like:
2884         
2885             {
2886                 "OctanePath": "/path/to/Octane2",
2887                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
2888             }
2889         
2890         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
2891         run-jsc-benchmarks will just gracefully avoid running that test suite.
2892         
2893         Finally, a word about policy: it is understood that different organizations that do
2894         development on JSC may find themselves having internal benchmarks that they cannot share
2895         because of weird licensing. It happens - usually because the organization doing JSC
2896         development found some test in the wild that is owned by someone else and therefore cannot
2897         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
2898         that add support for some new kind of benchmark suite even if the suite is not made public
2899         as part of the same patch - so long as the patch isn't too invasive. An example of
2900         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
2901         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
2902         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
2903         completely open-sourced and committed to the WebKit repo - but the reality is that this
2904         can't always be done safely.
2905
2906         * Scripts/bencher: Removed.
2907         * Scripts/run-jsc-benchmarks: Added.
2908
2909 2014-09-30  Roger Fong  <roger_fong@apple.com>
2910
2911         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
2912
2913         * Scripts/webkitpy/port/drdiver.py:
2914         (Driver.stop):
2915         * Scripts/webkitpy/port/server_process.py:
2916         (ServerProcess.stop):
2917
2918 2014-09-30  Roger Fong  <roger_fong@apple.com>
2919
2920         [Windows] Back to 2 child processes for NRWT on Windows.
2921
2922         * Scripts/webkitpy/port/win.py:
2923         (WinPort.default_child_processes):
2924         Changing the number of processes to 1 did not have an effect on the layout test results. 
2925         It does introduce an issue with one of the workers hanging indefinitely and causing the 
2926         layout tests to timeout as a whole occasionally, but we should just fix that.
2927
2928 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2929
2930         Remove an accidentally committed line..
2931
2932         * QueueStatusServer/handlers/statusbubble.py:
2933         (StatusBubble._build_bubble):
2934
2935 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2936
2937         build.webkit.org/dashboard: Switch EWS view to using actual retry count
2938         https://bugs.webkit.org/show_bug.cgi?id=137240
2939
2940         Reviewed by Ryosuke Niwa.
2941
2942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2943         (EWSQueue.prototype.loadDetailedStatus):
2944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2945         (EWSQueueView.prototype._popoverContentForEWSQueue):
2946         Use the new retry_count data member from JSON.
2947
2948         * QueueStatusServer/app.yaml: Updating the version.
2949
2950         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
2951         Instead of message_count, produce retry_count.
2952
2953 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2954
2955         EWS doesn't need to show all the bubbles when a patch fails to apply
2956         https://bugs.webkit.org/show_bug.cgi?id=137256
2957
2958         Reviewed by Ryosuke Niwa.
2959
2960         * QueueStatusServer/app.yaml: Updated app version.
2961
2962         * QueueStatusServer/handlers/statusbubble.py:
2963         (StatusBubble._build_bubble):
2964         (StatusBubble._build_bubbles_for_attachment):
2965         (StatusBubble.get):
2966         * QueueStatusServer/templates/statusbubble.html:
2967         When some queues fail to apply, and no queues had meaningful output (meaning that
2968         they will almost certainly fail to apply later), we can show a single bubble
2969         telling the user just that.
2970
2971 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2972
2973         [EFL] Bump EFL version to 1.11.2
2974         https://bugs.webkit.org/show_bug.cgi?id=137118
2975
2976         Reviewed by Gyuyoung Kim.
2977
2978         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
2979         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
2980
2981         * efl/jhbuild.modules:
2982         * efl/patches/ecore.patch: Removed.
2983
2984 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2985
2986         REGRESSION(r173929): [GTK] TestInspector fails after r173929
2987         https://bugs.webkit.org/show_bug.cgi?id=137247
2988
2989         Reviewed by Philippe Normand.
2990
2991         Wait until can-attach property changes before trying to attach the
2992         inspector after resizing the view.
2993
2994         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
2995         (testInspectorDefault):
2996
2997 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2998
2999         Require Python 2.7 version
3000         https://bugs.webkit.org/show_bug.cgi?id=137112
3001
3002         Reviewed by Csaba Osztrogonác.
3003
3004         * Scripts/ensure-valid-python:
3005         (checkPythonVersion):
3006         * Scripts/webkitpy/common/version_check.py:
3007
3008 2014-09-30  Martin Hock  <mhock@apple.com>
3009
3010         Skip a JSC test after r174036.
3011         https://bugs.webkit.org/show_bug.cgi?id=137236
3012
3013         Reviewed by Csaba Osztrogonác.
3014
3015         * Scripts/run-javascriptcore-tests:
3016
3017 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3018
3019         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
3020         https://bugs.webkit.org/show_bug.cgi?id=137212
3021
3022         This moves TestNetscapePlugin to a new folder (lib/plugins).
3023         We should not use the same directory for TestNetscapePlugin and
3024         the other libraries, because we end up scanning all the .so in the
3025         lib dir for every test.
3026
3027         Reviewed by Carlos Garcia Campos.
3028
3029         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
3030         * Scripts/webkitpy/port/efl.py:
3031         (EflPort.setup_environ_for_server): Update plugin path.
3032         * Scripts/webkitpy/port/gtk.py:
3033         (GtkPort.setup_environ_for_server): Update plugin path.
3034         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
3035
3036 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
3037
3038         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
3039
3040         Rubber-stamped by Tim Horton.
3041
3042         * QueueStatusServer/app.yaml:
3043         * QueueStatusServer/handlers/statusbubble.py:
3044         (StatusBubble._build_bubble):
3045
3046 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
3047
3048         Typo fix, suggested by Tim Horton.
3049
3050         * QueueStatusServer/handlers/statusbubble.py:
3051         (StatusBubble._build_message_for_provisional_failure):
3052
3053 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
3054
3055         Improve Bugzilla status bubbles
3056         https://bugs.webkit.org/show_bug.cgi?id=137232
3057
3058         Reviewed by Ryosuke Niwa.
3059
3060         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
3061
3062         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
3063         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
3064         that are stuck, as it was only confusing that they disappeared after 99.
3065
3066         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
3067         by old bubbles. We need a lot more information to determine color, so the implementation
3068         can not be here.
3069
3070         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
3071         always have a link for consistency. Added code to convert timestamps in tooltips
3072         to local time zone.
3073
3074 2014-09-29  Commit Queue  <commit-queue@webkit.org>
3075
3076         Unreviewed, rolling out r174045.
3077         https://bugs.webkit.org/show_bug.cgi?id=137231
3078
3079         Introduced a crash during page loading tests on Mac (Requested
3080         by rniwa on #webkit).
3081
3082         Reverted changeset:
3083
3084         "Replace OSObjectPtr with RetainPtr/adoptOS"
3085         https://bugs.webkit.org/show_bug.cgi?id=137158
3086         http://trac.webkit.org/changeset/174045
3087
3088 2014-09-29  Tim Horton  <timothy_horton@apple.com>
3089
3090         Add Jake as a contributor.
3091
3092         * Scripts/webkitpy/common/config/contributors.json:
3093
3094 2014-09-29  Roger Fong  <roger_fong@apple.com>
3095
3096         [Windows] Skip a javascriptcore test following r174036.
3097
3098         * Scripts/run-javascriptcore-tests:
3099
3100 2014-09-29  Roger Fong  <roger_fong@apple.com>
3101
3102         [Windows] Reduce number of processes used by NRWT on Windows to 1.
3103
3104         * Scripts/webkitpy/port/win.py:
3105         (WinPort.default_child_processes):
3106         Reduce number of processes to 1 so we can get a good baseline for what failures
3107         we should be expecting to see from the Windows bots.
3108
3109 2014-09-29  Darin Adler  <darin@apple.com>
3110
3111         Tweak and tighten SVG font converter
3112         https://bugs.webkit.org/show_bug.cgi?id=136956
3113
3114         Reviewed by Myles Maxfield.
3115
3116         I was investigating behavior of String::toInt, String::toDouble, and
3117         String::toFloat for various failure cases, and decided to start some
3118         unit tests for those functions here.
3119
3120         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3121         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
3122         StringToDouble testing.
3123
3124 2014-09-29  Philippe Normand  <pnormand@igalia.com>
3125
3126         [GTK][CMake] TestWebCore target build sometimes fail
3127         https://bugs.webkit.org/show_bug.cgi?id=137207
3128
3129         Reviewed by Csaba Osztrogon.
3130
3131         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
3132         headers are generated before the TestWebCore target is built.
3133
3134 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3135
3136         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
3137         https://bugs.webkit.org/show_bug.cgi?id=137209
3138
3139         Reviewed by Philippe Normand.
3140
3141         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
3142         from the WebCore test sources.
3143
3144 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
3145
3146         Allow webkit-patch upload to respect the --directory argument with git checkouts
3147         https://bugs.webkit.org/show_bug.cgi?id=137166
3148
3149         Reviewed by Darin Adler.
3150
3151         We simply hadn't plumbed it through.
3152
3153         * Scripts/webkitpy/common/checkout/scm/detection.py:
3154         (SCMDetector.detect_scm_system):
3155         * Scripts/webkitpy/common/checkout/scm/git.py:
3156         (Git.__init__):
3157         (Git.changed_files):
3158
3159 2014-09-26  Sam Weinig  <sam@webkit.org>
3160
3161         Replace OSObjectPtr with RetainPtr/adoptOS
3162         https://bugs.webkit.org/show_bug.cgi?id=137158
3163
3164         Reviewed by Dan Bernstein.
3165
3166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3167         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
3168         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
3169         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
3170
3171 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
3172
3173         Disable function.arguments
3174         https://bugs.webkit.org/show_bug.cgi?id=137167
3175
3176         Rubber stamped by Geoffrey Garen
3177         
3178         Enable the feature by default during tests.
3179
3180         * Scripts/run-jsc-stress-tests:
3181
3182 2014-09-26  Beth Dakin  <bdakin@apple.com>
3183
3184         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
3185         https://bugs.webkit.org/show_bug.cgi?id=137089
3186
3187         Reviewed by Tim Horton.
3188
3189         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
3190         tests run at 1x, but that code does not seem to execute at the right time for 
3191         these tests, so if we just ensure we start out at 1x, that appears to fix these 
3192         tests and does not break the HiDPI tests either.
3193         * WebKitTestRunner/TestController.cpp:
3194         (WTR::TestController::createWebViewWithOptions):
3195
3196 2014-09-26  Roger Fong  <roger_fong@apple.com>
3197
3198         [Windows] Decrease default number of child processes used by Windows.
3199
3200         * Scripts/webkitpy/port/win.py:
3201         (WinPort.default_child_processes):
3202         Having too many seems to cause many tests to crash or timeout. 
3203         We may even need to make it have only 1 child process if we’re still seeing problems after this.
3204
3205 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
3206
3207         Mac EWS bots do not keep logs as promised
3208         https://bugs.webkit.org/show_bug.cgi?id=137151
3209
3210         Reviewed by Ryosuke Niwa.
3211
3212         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
3213
3214 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
3215
3216         Get rid of webkit-queues dashboard
3217         https://bugs.webkit.org/show_bug.cgi?id=137141
3218
3219         Reviewed by Ryosuke Niwa.
3220
3221         * QueueStatusServer/app.yaml: Updated version.
3222
3223         * QueueStatusServer/templates/dashboard.html: Removed.
3224         * QueueStatusServer/handlers/dashboard.py: Removed.
3225         * QueueStatusServer/main.py:
3226         Kill it!
3227
3228         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
3229         (.status-cell): Deleted.
3230         (.status-cell:hover): Deleted.
3231         (.status-cell.pass): Deleted.
3232         (.status-cell.fail): Deleted.
3233         (.status-cell.pending): Deleted.
3234         (.status-cell.error): Deleted.
3235         * QueueStatusServer/stylesheets/dashboard.css: Removed.
3236         * QueueStatusServer/templates/activebots.html:
3237         * QueueStatusServer/templates/patch.html:
3238         * QueueStatusServer/templates/queuestatus.html:
3239         * QueueStatusServer/templates/recentstatus.html:
3240         Renamed dashboard.css to common.css, and removed dashboard-only rules.
3241
3242 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
3243
3244         Get rid of Retry status in webkit-queues
3245         https://bugs.webkit.org/show_bug.cgi?id=137135
3246
3247         Reviewed by Ryosuke Niwa.
3248
3249         * QueueStatusServer/config/messages.py: Removed Retry.
3250
3251         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
3252         no longer needs to check the latest status. It just always both unlocks the patch
3253         and removes it from WorkItems.
3254
3255         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
3256         I don't understand why we even needed to check for retries here, but now that there
3257         are no retries, that code can go to /dev/null.
3258
3259         * QueueStatusServer/loggers/recordpatchevent.py:
3260         (RecordPatchEvent.started):
3261         (RecordPatchEvent.retrying): Deleted.
3262         Fixed retry counting, it should work for all queues now.
3263
3264         * QueueStatusServer/model/queuestatus.py:
3265         (QueueStatus.is_retry_request): Deleted. These are no more.
3266
3267         * Scripts/webkitpy/common/net/statusserver_mock.py:
3268         (MockStatusServer.release_lock):
3269         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3270         Did whatever it took to keep passing the tests. The particular test doesn't seem
3271         quite right, but whatever.
3272
3273         * Scripts/webkitpy/tool/commands/queues.py:
3274         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
3275         and let others pick up. Also, added explicit returns for clarity.
3276         (AbstractPatchQueue._did_retry): Deleted.
3277
3278 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
3279
3280         [EFL] Fix the gst-libav build on ARM Thumb2
3281         https://bugs.webkit.org/show_bug.cgi?id=137022
3282
3283         Reviewed by Zoltan Herczeg.
3284
3285         * efl/jhbuild.modules:
3286         * efl/patches/gst-libav.patch: Added.
3287
3288 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
3289
3290         [EFL] Bump up dependencies not to conflict with the GTK port.
3291         https://bugs.webkit.org/show_bug.cgi?id=137143
3292
3293         Reviewed by Gyuyoung Kim.
3294
3295         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
3296         installing and removing different versions of libgnutls-dev, thus
3297         hindering the development for both ports on the same machine. GTK is
3298         using the newer version of the package, now bumping up EFL to use the 
3299         same.
3300
3301         * efl/install-dependencies:
3302
3303 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
3304
3305         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
3306         https://bugs.webkit.org/show_bug.cgi?id=136854
3307
3308         Reviewed by Gyuyoung Kim.
3309
3310         'Escape' key should exit fullscreen first and then should be used to stop page load.
3311
3312         * MiniBrowser/efl/main.c:
3313         (on_key_down):
3314
3315 2014-09-25  Dean Jackson  <dino@apple.com>
3316
3317         Add Said to the contributors list so his name completes in bugzilla.
3318
3319         * Scripts/webkitpy/common/config/contributors.json:
3320
3321 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
3322
3323         EWS only repeats its cycle every two hours
3324         https://bugs.webkit.org/show_bug.cgi?id=137129
3325
3326         Reviewed by Ryosuke Niwa.
3327
3328         * QueueStatusServer/app.yaml: Updated version.
3329
3330         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
3331
3332         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
3333         the patch from work items.
3334
3335         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
3336
3337         * QueueStatusServer/main.py: Added release-lock.
3338
3339         * QueueStatusServer/model/activeworkitems.py:
3340         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
3341
3342         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
3343         we don't want it to be immediately picked up again, it's better to give other patches
3344         a chance.
3345
3346         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
3347         these interactive versions, but OK.
3348
3349         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
3350         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
3351         or svn is down).
3352
3353         * Scripts/webkitpy/tool/commands/queues.py:
3354         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
3355         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
3356         meaning that these handlers could never do the right thing. We'd either get a duplicate
3357         _did_fail, or try to unlock an already unlocked patch.
3358         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
3359         making it eligible for retry immediately.
3360
3361         * Scripts/webkitpy/common/net/statusserver.py:
3362         (StatusServer._post_release_lock):
3363         (StatusServer.release_lock):
3364         Added a call to release-lock.
3365
3366 2014-09-25  Roger Fong  <roger_fong@apple.com>
3367
3368         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
3369
3370         * Scripts/webkitpy/common/system/path.py:
3371         (_CygPath.convert):
3372
3373 2014-09-25  Roger Fong  <roger_fong@apple.com>
3374
3375         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
3376
3377         * Scripts/webkitpy/common/system/path.py:
3378         (_CygPath.convert):
3379
3380 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3381
3382         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
3383         https://bugs.webkit.org/show_bug.cgi?id=136377
3384
3385         Reviewed by Philippe Normand.
3386
3387         * Scripts/webkitdirs.pm:
3388         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
3389
3390 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
3391
3392         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
3393         https://bugs.webkit.org/show_bug.cgi?id=137117
3394
3395         Tools/efl/install-dependencies relies on apt-get to install packages.
3396         Unfortunately, if a package does not exist (e.g., for a given
3397         architecture) then apt-get install is not able to ignore the missing
3398         package and install the rest but fails to run entirely (and there
3399         seems to be no intent to change this behaviour).
3400
3401         On ARM64, the luajit package is missing and currently it needs manual
3402         editing of install-dependencies to get the script install as much as it
3403         can.
3404
3405         This patch separates the installation of the universally available
3406         packages from those which might not be available for all architectures.
3407
3408         Reviewed by Gyuyoung Kim.
3409
3410         * efl/install-dependencies:
3411
3412 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
3413
3414         Remove WinCE port from trunk
3415         https://bugs.webkit.org/show_bug.cgi?id=136951
3416
3417         Reviewed by Alex Christensen.
3418
3419         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3420         (_should_file_trigger_build):
3421         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3422         (ShouldBuildTest):
3423         * CMakeLists.txt:
3424         * DumpRenderTree/win/DRTDataObject.cpp:
3425         (DRTDataObject::CopyMedium):
3426         * Scripts/build-webkit:
3427         * Scripts/webkit-build-directory:
3428         * Scripts/webkitdirs.pm:
3429         (argumentsForConfiguration):
3430         (builtDylibPathForName):
3431         (isAppleWinWebKit):
3432         (launcherPath):
3433         (launcherName):
3434         (shouldRemoveCMakeCache):
3435         (cmakeBasedPortArguments):
3436         (cmakeBasedPortName):
3437         (isCMakeBuild):
3438         (isWinCE): Deleted.
3439         (determineIsWinCE): Deleted.
3440         * Scripts/webkitperl/FeatureList.pm:
3441         * Scripts/webkitpy/port/port_testcase.py:
3442         (test_apache_config_file_name_for_platform):
3443         * TestWebKitAPI/config.h:
3444         * WinCELauncher/CMakeLists.txt: Removed.
3445         * WinCELauncher/main.cpp: Removed.
3446         * gtk/manifest.txt:
3447
3448 2014-09-23  David Farler  <dfarler@apple.com>
3449
3450         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
3451         https://bugs.webkit.org/show_bug.cgi?id=136895
3452
3453         Reviewed by David Kilzer.
3454
3455         Create Device, DeviceType, and Runtime data classes.
3456         Create Simulator class represent simctl output.
3457
3458         Wherever possible, use structured data classes anywhere a raw
3459         identifier or UDID string was used for a cleaner implementation
3460         and to encapsulate the inherent fragility of scraping simctl output.
3461
3462         Create a suitably named testing device if one doesn't exist.
3463
3464         Finally, accurately handle having multiple simulator runtimes (SDKs)
3465         installed in the active Xcode.app bundle.
3466
3467         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3468         (_set_up_derived_options):
3469         * Scripts/webkitpy/port/driver.py:
3470         (IOSSimulatorDriver.cmd_line):
3471         Construct DeviceType and Runtime objects from identifiers passed at the
3472         command line, still providing sensible defaults for 32- and 64-bit testing.
3473         * Scripts/webkitpy/port/ios.py:
3474         (IOSSimulatorPort.__init__):
3475         (IOSSimulatorPort.setup_test_run):
3476         (IOSSimulatorPort):
3477         (IOSSimulatorPort.testing_device):
3478         Cache the testing device once it is created or found.
3479         (IOSSimulatorPort.reset_preferences):
3480         Get the device path from the Device object instead of consructing it
3481         in the port class.
3482         (IOSSimulatorPort.simulator_udid): Deleted.
3483         Get the UDID from the testing_device :: Device object itself.
3484         * Scripts/webkitpy/xcode/simulator.py:
3485         Created Device, DeviceType, Runtime, and Simulator classes.
3486         (get_runtimes): Deleted.
3487         (get_devices): Deleted.
3488         (get_device_types): Deleted.
3489         (get_latest_runtime): Deleted.
3490
3491 2014-09-24  Roger Fong  <roger_fong@apple.com>
3492
3493         [Windows] Tentative fix for Windows test bots.
3494
3495         * Scripts/webkitpy/common/system/path.py:
3496         (_CygPath.convert):
3497
3498 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
3499
3500         Change more build.webkit.org links to https
3501         https://bugs.webkit.org/show_bug.cgi?id=137049
3502
3503         Reviewed by Csaba Osztrogonác.
3504
3505         Fix appspot, svn.webkit.org and Trac links.
3506
3507         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3508         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
3509         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3510         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
3511         (ViewController.prototype._domForBuildName):
3512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3513         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3516         (.):
3517         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3518         (EWS):
3519         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
3521         (TestHistory):
3522         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3523
3524 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
3525
3526         Update the list of u-szeged contributors.
3527
3528         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
3529
3530         * Scripts/webkitpy/common/config/contributors.json:
3531
3532 2014-09-23  Roger Fong  <roger_fong@apple.com>
3533
3534         [Windows] More debugging for the Windows bots.
3535
3536         * Scripts/webkitpy/common/system/path.py:
3537         (_CygPath):
3538
3539 2014-09-23  Roger Fong  <roger_fong@apple.com>
3540
3541         Unreviewed. Fix for r173899, those tabs should be spaces.
3542
3543         * Scripts/webkitpy/port/driver.py:
3544         (Driver._command_from_driver_input):
3545         (Driver): Deleted.
3546
3547 2014-09-23  Roger Fong  <roger_fong@apple.com>
3548
3549         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
3550
3551         * Scripts/webkitpy/port/driver.py:
3552         (Driver):
3553
3554 2014-09-23  Jer Noble  <jer.noble@apple.com>
3555
3556         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
3557         https://bugs.webkit.org/show_bug.cgi?id=137031
3558
3559         Reviewed by Joseph Pecoraro.
3560
3561         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
3562         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
3563         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
3564         ChangeLog locations before passing them to createCommitMessage().
3565
3566         * Scripts/commit-log-editor:
3567
3568 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3569
3570         W3C test importer should detect manual and reference tests according their filenames
3571         https://bugs.webkit.org/show_bug.cgi?id=133852
3572
3573         Reviewed by Bem Jones-Bey.
3574
3575         * Scripts/webkitpy/w3c/test_parser.py:
3576         (TestParser.analyze_test): Adding checks based on WPT filename rules.
3577         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
3578         (TestParser):
3579         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
3580         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
3581         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3582         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
3583
3584 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
3585
3586         Unreviewed, add Rebecca Hauck as a contributor.
3587
3588         * Scripts/webkitpy/common/config/contributors.json:
3589
3590 2014-09-23  David Kilzer  <ddkilzer@apple.com>
3591
3592         Switch build.webkit.org URLs to https
3593
3594         Reviewed by Lucas Forschler and Alexey Proskuryakov.
3595
3596         * TestResultServer/app.yaml: Update version to this commit
3597         revision.
3598
3599         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3600         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3601         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
3603         (WebKitBuildbot):
3604         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3607         (.):
3608         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3609         (WebKitBuildbot):
3610         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3611         * Scripts/webkitpy/common/config/urls.py:
3612         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3613         (test_builder_with_name):
3614         * Scripts/webkitpy/tool/commands/queries.py:
3615         (TreeStatus):
3616         * TestResultServer/generate_builders_json.py:
3617         (main):
3618         * TestResultServer/generate_builders_json_unittest.py:
3619         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
3620         (GenerateBuildersJsonTest):
3621         (GenerateBuildersJsonTest.test_generate_json_data):
3622         * TestResultServer/static-dashboards/builders.jsonp:
3623         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3624         (loadExpectationsLayoutTests):
3625         * TestResultServer/static-dashboards/timeline_explorer.js:
3626
3627 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3628
3629         W3C test importer should copy .htaccess files
3630         https://bugs.webkit.org/show_bug.cgi?id=136850
3631
3632         Reviewed by Bem Jones-Bey.
3633
3634         * Scripts/webkitpy/w3c/test_importer.py:
3635         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
3636         (TestImporter):
3637         (TestImporter.find_importable_tests): Making use of new helper function.
3638
3639 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
3640
3641         Trying to revive bot watcher's dashboard after HSTS.
3642
3643         Unreviewed.
3644
3645         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3646         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
3647
3648 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3649
3650         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
3651         https://bugs.webkit.org/show_bug.cgi?id=137026
3652
3653         Reviewed by Csaba Osztrogonác.
3654
3655         * BuildSlaveSupport/wait-for-SVN-server.py:
3656         (getLatestSVNRevision):
3657         (waitForSVNRevision):
3658
3659 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3660
3661         Remove unlinkZeroFiles from build-webkit
3662         https://bugs.webkit.org/show_bug.cgi?id=137018
3663
3664         Reviewed by Csaba Osztrogonác.
3665
3666         * Scripts/build-webkit:
3667         (unlinkZeroFiles): Deleted.
3668
3669 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
3670
3671         [GTK] Minibrowser : Add keyboard support for stop page load
3672         https://bugs.webkit.org/show_bug.cgi?id=136857
3673
3674         Reviewed by Philippe Normand.
3675
3676         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
3677
3678         * MiniBrowser/gtk/BrowserWindow.c:
3679         (stopPageLoad): Callback to stop page load.
3680         (browser_window_init):
3681
3682 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
3683
3684         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
3685         https://bugs.webkit.org/show_bug.cgi?id=136813
3686
3687         Reviewed by Gyuyoung Kim.
3688
3689         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
3690
3691         * MiniBrowser/efl/main.c:
3692         (on_key_down):
3693
3694 2014-09-22  Daniel Bates  <dabates@apple.com>
3695
3696         [Cocoa] Add UI delegate callback when window.close() is called
3697         https://bugs.webkit.org/show_bug.cgi?id=137008
3698         <rdar://problem/17801001>
3699
3700         Reviewed by Anders Carlsson.
3701
3702         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
3703         for window opened via JavaScript (i.e. window.open()).
3704
3705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3706         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
3707         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
3708
3709 2014-09-22  Youenn Fablet  <youennf@gmail.com>
3710
3711         W3C importer should import html files within resources folders
3712         https://bugs.webkit.org/show_bug.cgi?id=127548
3713
3714         Reviewed by Ryosuke Niwa.
3715         
3716         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
3717
3718         * Scripts/webkitpy/w3c/test_importer.py:
3719         (TestImporter.find_importable_tests):
3720
3721 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3722
3723         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
3724         https://bugs.webkit.org/show_bug.cgi?id=136998
3725
3726         Reviewed by Philippe Normand.
3727
3728         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3729         (testWebViewCanShowMIMEType): Remove the check of PDF as
3730         unsupported MIME type.
3731
3732 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3733
3734         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
3735
3736         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
3737         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
3738
3739         * Scripts/webkitpy/common/config/watchlist: Use
3740         Source/WebCore/platform/gtk/po/ as directory to watch for
3741         WebKitGTKTranslations rule and add berto and myself to the list of
3742         watchers.
3743
3744 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
3745
3746         Fix syntaxError in watchlist since r173594
3747         https://bugs.webkit.org/show_bug.cgi?id=136996
3748
3749         Reviewed by Philippe Normand.
3750
3751         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
3752
3753 2014-09-20  Sam Weinig  <sam@webkit.org>
3754
3755         Make possible HashSet<std::unique_ptr<>>
3756         https://bugs.webkit.org/show_bug.cgi?id=136166
3757
3758         Reviewed by Darin Adler.
3759
3760         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
3761         * TestWebKitAPI/Counters.cpp: Added.
3762         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
3763         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
3764         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
3765         translation unit.
3766     
3767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3768         Add new files.
3769
3770         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3771         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
3772
3773         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3774         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
3775
3776 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3777
3778         run-webkit-tests should count tests submitted as absolute paths once
3779         https://bugs.webkit.org/show_bug.cgi?id=136848
3780
3781         Reviewed by Darin Adler.
3782
3783         * Scripts/webkitpy/port/base.py:
3784         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
3785
3786 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
3787
3788         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
3789         https://bugs.webkit.org/show_bug.cgi?id=136974
3790
3791         Reviewed by Chris Fleizach.
3792
3793         * DumpRenderTree/AccessibilityUIElement.cpp:
3794         (selectTextWithCriteriaCallback):
3795         Be sure to release the string if it was allocated.
3796
3797 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
3798
3799         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
3800         https://bugs.webkit.org/show_bug.cgi?id=136966
3801
3802         Reviewed by Daniel Bates.
3803
3804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3805         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
3806
3807 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3808
3809         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
3810         https://bugs.webkit.org/show_bug.cgi?id=136917
3811
3812         Reviewed by Darin Adler.
3813
3814         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
3815
3816         * TestWebKitAPI/PlatformEfl.cmake:
3817         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
3818         (TestWebKitAPI::didFinishLoadForFrame):
3819         (TestWebKitAPI::TEST):
3820         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
3821
3822 2014-09-19  Daniel Bates  <dabates@apple.com>
3823
3824         Always assume internal SDK when building configuration Production
3825         https://bugs.webkit.org/show_bug.cgi?id=136925
3826         <rdar://problem/18362399>
3827
3828         Reviewed by Dan Bernstein.
3829
3830         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3831         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3832         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3833         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3834
3835 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3836
3837         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
3838         https://bugs.webkit.org/show_bug.cgi?id=136847
3839
3840         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
3841
3842         Reviewed by Alexey Proskuryakov.
3843
3844         * WebKitTestRunner/TestController.cpp:
3845         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
3846
3847 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3848
3849         [GTK] Missing inspector files in the tarball
3850         https://bugs.webkit.org/show_bug.cgi?id=136952
3851
3852         Reviewed by Gustavo Noronha Silva.
3853
3854         * gtk/manifest.txt: Add
3855         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
3856         to the tarball.
3857
3858 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3859
3860         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
3861         https://bugs.webkit.org/show_bug.cgi?id=136632
3862
3863         Reviewed by Gustavo Noronha Silva.
3864
3865         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
3866         the gtk icons.
3867         * gtk/manifest.txt: Only include the free icons in the tarball.
3868
3869 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3870
3871         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
3872         https://bugs.webkit.org/show_bug.cgi?id=136943
3873
3874         Reviewed by Philippe Normand.
3875
3876         Update the script to receive the list of files from the command
3877         line instead of scanning the given directories.
3878
3879         * gtk/generate-inspector-gresource-manifest.py:
3880         (get_filenames): Convert filenames to use relative paths.
3881         (find_all_files_in_directory): Deleted.
3882         (find_all_files_in_directory.select_file): Deleted.
3883
3884 2014-09-18  Tanay C  <tanay.c@samsung.com>
3885
3886         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
3887         https://bugs.webkit.org/show_bug.cgi?id=136739
3888
3889         Reviewed by Gyuyoung Kim.
3890
3891         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
3892         (on_mouse_wheel): Modified.
3893
3894 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3895
3896         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
3897         https://bugs.webkit.org/show_bug.cgi?id=136923
3898
3899         Reviewed by Gustavo Noronha Silva.
3900
3901         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3902         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
3903         the source.
3904
3905 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
3906
3907         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
3908         https://bugs.webkit.org/show_bug.cgi?id=136856
3909
3910         Reviewed by Darin Adler.
3911
3912         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3913         (RunLLINTCLoopTests.countFailures):
3914         (Run32bitJSCTests.countFailures):
3915         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3916         (RunLLINTCLoopTestsTest.test_failures):
3917         (RunLLINTCLoopTestsTest.test_failure):
3918         (RunLLINTCLoopTestsTest.test_no_failure):
3919         (Run32bitJSCTestsTest.test_failures):
3920         (Run32bitJSCTestsTest.test_failure):
3921         (Run32bitJSCTestsTest.test_no_failure):
3922
3923 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
3924
3925         GMainLoopSource is exposed to race conditions
3926         https://bugs.webkit.org/show_bug.cgi?id=135800
3927
3928         Reviewed by Carlos Garcia Campos.
3929
3930         Add unit tests for GMainLoopSource.
3931
3932         The tests check correct behavior of GMainLoopSource in various conditions --
3933         from the most simple rescheduling to rescheduling during dispatch, cancelling
3934         or destroying the GMainLoopSource during dispatch, proper destroy callback
3935         dispatching etc.
3936
3937         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
3938         State of the GMainLoopSource object (either ready, sheduled or active) is
3939         thoroughly tested throughout the lifetime of that object.
3940
3941         Still missing are tests for socket callbacks, which are a bit trickier because
3942         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
3943         are also not tested thoroughly, simply because it is at the moment impossible
3944         to test that the objects are actually destroyed when the corresponding source
3945         is finally deleted.
3946
3947         * TestWebKitAPI/PlatformGTK.cmake:
3948         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
3949         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
3950         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
3951         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
3952         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
3953         (TestWebKitAPI::GMainLoopSourceTest::finish):
3954         (TestWebKitAPI::GMainLoopSourceTest::source):
3955         (TestWebKitAPI::TEST):
3956
3957 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
3958
3959         Unreviewed, Update my email in contributors.json
3960
3961         * Scripts/webkitpy/common/config/contributors.json:
3962
3963 2014-09-17  Daniel Bates  <dabates@apple.com>
3964
3965         Unreviewed, rolling out r173695.
3966
3967         Broke building third-party Legacy WebKit apps; will
3968         investigate offline
3969
3970         Reverted changeset:
3971
3972         "[iOS] Make WebCore build with public iOS SDK"
3973         https://bugs.webkit.org/show_bug.cgi?id=136487
3974         http://trac.webkit.org/changeset/173695
3975
3976 2014-09-17  Daniel Bates  <dabates@apple.com>
3977
3978         [iOS] Make WebCore build with public iOS SDK
3979         https://bugs.webkit.org/show_bug.cgi?id=136487
3980
3981         Reviewed by David Kilzer.
3982
3983         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
3984
3985         * DumpRenderTree/mac/CheckedMalloc.cpp:
3986
3987 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3988
3989         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
3990         https://bugs.webkit.org/show_bug.cgi?id=136889
3991
3992         Reviewed by Gustavo Noronha Silva.
3993
3994         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3995         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
3996         event was added to the events vector.
3997         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3998         (loadFailedCallback): Do not assume the web view URI is the
3999         failing URI when the load fails before the committed state.
4000         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
4001         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
4002         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
4003         (LoadTrackingTest::loadFailedWithTLSErrors): Add
4004         LoadFailedWithTLSErrors event to the events vector.
4005         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
4006
4007 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
4008
4009         [EFL][GTK] Remove WebKit1 related codes
4010         https://bugs.webkit.org/show_bug.cgi?id=136853
4011
4012         Reviewed by Csaba Osztrogonác.
4013
4014         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
4015         from scripts.
4016
4017         * BuildSlaveSupport/build.webkit.org-config/config.json:
4018         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4019         (Compile32bitJSC):
4020         (BuildAndTestWebKit2Factory):
4021         (CompileWebKit1Only): Deleted.
4022         (CompileWebKit2Only): Deleted.
4023         (BuildAndTestWebKit1OnlyFactory): Deleted.
4024         (BuildAndTestWebKit2OnlyFactory): Deleted.
4025         * Scripts/build-webkit:
4026         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
4027         * Scripts/webkitpy/common/config/ports.py:
4028         (GtkWK2Port.build_webkit_command):
4029         (EflWK2Port.build_webkit_command):
4030         * Scripts/webkitpy/common/config/ports_unittest.py:
4031         (DeprecatedPortTest.test_gtk_wk2_port):
4032         * Scripts/webkitpy/port/efl.py:
4033         (EflPort.build_webkit_command):
4034         * Scripts/webkitpy/port/gtk.py:
4035         (GtkPort._built_libraries_path):
4036         (GtkPort._search_paths):
4037         (GtkPort.test_expectations_file_position):
4038         (GtkPort.build_webkit_command):
4039         (GtkPort.run_webkit_tests_command):
4040         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
4041
4042 2014-09-16  Daniel Bates  <dabates@apple.com>
4043
4044         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
4045         https://bugs.webkit.org/show_bug.cgi?id=136862
4046
4047         Reviewed by David Kilzer.
4048
4049         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4050         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4051         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
4052         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
4053
4054 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
4055
4056         Mac queue slaves should reboot every so often
4057         https://bugs.webkit.org/show_bug.cgi?id=136791
4058
4059         Reviewed by Alexey Proskuryakov.
4060
4061         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
4062
4063         * EWSTools/start-queue-mac.sh:
4064
4065 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
4066
4067         Unreviewed gardening, skip one more tests on Windows.
4068
4069         * Scripts/run-javascriptcore-tests:
4070
4071 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
4072
4073         JSC test gardening
4074         https://bugs.webkit.org/show_bug.cgi?id=136823
4075
4076         Reviewed by Geoffrey Garen.
4077
4078         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
4079
4080 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4081
4082         Remove shouldAbortEarly cruft from master.cfg
4083         https://bugs.webkit.org/show_bug.cgi?id=136779
4084
4085         Reviewed by Csaba Osztrogonác.
4086
4087         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4088         (ConfigureBuild.start):
4089         (RunWebKitTests.start):
4090         (RunWebKit2Tests.start): Deleted.
4091
4092 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
4093
4094         Remove ORWT related crufts from webkitdirs.pm
4095         https://bugs.webkit.org/show_bug.cgi?id=136821
4096
4097         Reviewed by Alexey Proskuryakov.
4098
4099         * Scripts/webkitdirs.pm:
4100         (isPerianInstalled): Deleted.
4101         (determineIPhoneSimulatorVersion): Deleted.
4102         (iPhoneSimulatorVersion): Deleted.
4103         (isSnowLeopard): Deleted.
4104         (isLion): Deleted.
4105         (quitIOSSimulator): Deleted.
4106
4107 2014-09-15  Roger Fong  <roger_fong@apple.com>
4108
4109         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
4110         https://bugs.webkit.org/show_bug.cgi?id=25160
4111
4112         * Scripts/run-javascriptcore-tests:
4113
4114 2014-09-15  Lucas Forschler  <lforschler@apple.com>
4115
4116         Add another Apple build slave to the Mountain Lion Debug WK1 queue
4117         
4118         Rubber stamped by Matt Hanson.
4119         
4120         * BuildSlaveSupport/build.webkit.org-config/config.json:
4121
4122 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
4123
4124         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
4125         https://bugs.webkit.org/show_bug.cgi?id=136822
4126
4127         Reviewed by Gyuyoung Kim.
4128
4129         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
4130         initialized as we already does it in PlatformWebView::PlatformWebView
4131         calling ewk_init(). The reason for that was to ensure testing for example,
4132         WTF where creating the view is not mandatory.
4133
4134         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
4135         in order to properly initalize and release EWebKit.
4136
4137         * TestWebKitAPI/PlatformEfl.cmake:
4138         * TestWebKitAPI/efl/PlatformWebView.cpp:
4139         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4140         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
4141         * TestWebKitAPI/efl/main.cpp:
4142         (main):
4143
4144 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
4145
4146         [WinCairo] Make it easier to enable/disable GStreamer.
4147         https://bugs.webkit.org/show_bug.cgi?id=135766
4148
4149         Reviewed by Brent Fulgham.
4150
4151         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
4152
4153         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
4154
4155 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
4156
4157         Web Inspector: remind about rebaselining generator test results
4158         https://bugs.webkit.org/show_bug.cgi?id=136759
4159
4160         Reviewed by Joseph Pecoraro.
4161
4162         For now, we can implement this as a watchlist message. Add watchlist
4163         groups and messages for the inspector and web replay generators.
4164
4165         * Scripts/webkitpy/common/config/watchlist:
4166
4167 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
4168
4169         build.webkit.org/dashboard: Overlapping text when status is long
4170         https://bugs.webkit.org/show_bug.cgi?id=136794
4171
4172         Reviewed by Timothy Hatcher.
4173
4174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
4175         (.status-line): Replaces height with min-height.
4176
4177 2014-09-12  Timothy Hatcher  <timothy@apple.com>
4178
4179         Make Brian Burg a WebKit reviewer.
4180
4181         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
4182
4183 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
4184
4185         Multiple EWS or commit bots can pick up processing of the same patch
4186         https://bugs.webkit.org/show_bug.cgi?id=136793
4187
4188         Reviewed by Ryosuke Niwa.
4189
4190         Change timeout from one hour to two hours. This will let bots finish, and in the
4191         unlikely event of a bot being frozen, will only delay patch processing restart by
4192         one hour.
4193
4194         * QueueStatusServer/app.yaml:
4195         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
4196
4197 2014-09-11  Andy Estes  <aestes@apple.com>
4198
4199         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
4200         https://bugs.webkit.org/show_bug.cgi?id=136768
4201
4202         Reviewed by Tim Horton.
4203
4204         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4205         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
4206         (TestWebKitAPI::TEST):
4207
4208 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4209
4210         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
4211         https://bugs.webkit.org/show_bug.cgi?id=136669
4212
4213         Reviewed by Antti Koivisto.
4214
4215         * Scripts/run-gtk-tests:
4216         (TestRunner): Unskip SSL test.
4217
4218 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
4219
4220         Strip extraneous AVFoundation and CoreMedia logging
4221         https://bugs.webkit.org/show_bug.cgi?id=136747
4222
4223         Reviewed by Jer Noble.
4224
4225         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4226         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
4227
4228         * Scripts/webkitpy/port/base.py:
4229         (Port.stderr_patterns_to_strip): Base class, empty list
4230
4231         * Scripts/webkitpy/port/driver.py:
4232         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
4233
4234         * Scripts/webkitpy/port/ios.py:
4235         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
4236
4237         * Scripts/webkitpy/port/mac.py:
4238         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
4239
4240
4241 2014-09-11  Michael Saboff  <msaboff@apple.com>
4242
4243         lldb_webkit.py:btjs doesn't work with release builds
4244         https://bugs.webkit.org/show_bug.cgi?id=136760
4245
4246         Reviewed by Jer Noble.
4247
4248         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
4249         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
4250         we can't get a valid result from trying either call.  In that case, we fallback to
4251         just showing the PC.  Also added check for both entry points.  If neither is found,
4252         we issue a warning and output the stack trace without JavaScript annotations.
4253
4254         * lldb/lldb_webkit.py:
4255         (btjs):
4256
4257 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
4258
4259         webkitpy test failures from import-w3c-tests
4260         https://bugs.webkit.org/show_bug.cgi?id=136752
4261
4262         Reviewed by Bem Jones-Bey.
4263
4264         This patch fixes a bug in import-w3c-tests where we were appending
4265         the wrong set of files to the copy_list. This also updates the tests
4266         to clear the failures introduced in the patch for bug 135929.
4267
4268         * Scripts/webkitpy/w3c/test_converter_unittest.py:
4269         (W3CTestConverterTest.test_read_prefixed_property_list):
4270         * Scripts/webkitpy/w3c/test_parser.py:
4271         (TestParser.analyze_test):
4272         (TestParser.support_files):
4273         * Scripts/webkitpy/w3c/test_parser_unittest.py:
4274
4275 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
4276
4277         Blink merge: Speculative fix for windows run-webkit-tests hangs
4278         https://bugs.webkit.org/show_bug.cgi?id=136727
4279
4280         Reviewed by Csaba Osztrogonác.
4281
4282         Merged from Blink (patch by Dirk Pranke):
4283         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
4284
4285         * Scripts/webkitpy/common/system/executive.py:
4286         (Executive.kill_process):
4287
4288 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4289
4290         Added myself as a committer.
4291
4292         Unreviewed.
4293
4294         * Scripts/webkitpy/co