[iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk,...
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-19  David Kilzer  <ddkilzer@apple.com>
2
3         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
4         <http://webkit.org/b/133089>
5
6         Reviewed by Darin Adler.
7
8         * Scripts/webkitdirs.pm:
9         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
10         specified on the command line, we would remove the '--sdk'
11         arguments, but leave '--sim', potentially passing it along to
12         xcodebuild causing a build failure.  This happens when
13         'old-run-webkit-tests --release --sim' invokes
14         build-dumprendertree when DumpRenderTree hasn't been built yet.
15
16 2014-05-19  David Farler  <dfarler@apple.com>
17
18         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
19         https://bugs.webkit.org/show_bug.cgi?id=133086
20
21         Reviewed by Daniel Bates.
22
23         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
24
25 2014-05-19  David Kilzer  <ddkilzer@apple.com>
26
27         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
28         <http://webkit.org/b/132954>
29
30         * Scripts/webkitdirs.pm:
31         (sharedCommandLineOptionsUsage): Remove the prototype for the
32         subroutine.  Older perls don't like the "+@" syntax.
33
34 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
35
36         run-javascriptcore-tests should sort the list of failing stress tests
37         https://bugs.webkit.org/show_bug.cgi?id=132989
38
39         Reviewed by Csaba Osztrogonác.
40
41         * Scripts/run-javascriptcore-tests:
42
43 2014-05-19  David Kilzer  <ddkilzer@apple.com>
44
45         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
46         <http://webkit.org/b/132954>
47
48         Reviewed by Darin Adler.
49
50         Extract code into setupMacWebKitEnvironment() for setting up
51         common environment variables so it may be shared.  Sets
52         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
53         using guardmalloc to some scripts.
54
55         Also adds support for parsing shared (common) command-line
56         switches, initially just -g|--guard-malloc.
57
58         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
59         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
60         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
61         local copy of %ENV when launching Safari so we don't have to
62         restore variables.
63
64         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
65         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
66         Check result of GetOptions() to catch invalid command-line
67         switches.
68         (runTest): Use a local copy of %ENV when running tests so we
69         don't have to restore variables.
70         (prepareEnvironmentForRunningTestTool): Call
71         setupMacWebKitEnvironment().
72
73         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
74         using sharedCommandLineOptions() and
75         sharedCommandLineOptionsUsage().  Call
76         setupMacWebKitEnvironment().
77
78         * Scripts/webkitdirs.pm:
79         (sharedCommandLineOptions): Return array of common switches to
80         pass to Getopt::Long::GetOptions().
81         (sharedCommandLineOptionsUsage): Return formatted string of
82         common switches for printing usage help text.
83         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
84         guardmalloc.
85         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
86         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
87         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
88         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
89         local copy of %ENV when launching Safari so we don't have to
90         restore variables.
91         (execMacWebKitAppForDebugging): Call
92         setupMacWebKitEnvironment().
93
94 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
95
96         support for navigator.hardwareConcurrency
97         https://bugs.webkit.org/show_bug.cgi?id=132588
98
99         Reviewed by Filip Pizlo.
100
101         * Scripts/webkitperl/FeatureList.pm:
102
103 2014-05-18  Anders Carlsson  <andersca@apple.com>
104
105         Implement Navigations for all methods declared returning one
106         https://bugs.webkit.org/show_bug.cgi?id=133048
107         <rdar://problem/16830064>
108
109         Reviewed by Sam Weinig.
110
111         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
112         Import WebKit.h.
113         
114         * MiniBrowser/mac/WK2BrowserWindowController.m:
115         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
116         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
117         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
118         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
119         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
120         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
121         Print out the navigations.
122
123 2014-05-17  Zalan Bujtas  <zalan@apple.com>
124
125         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
126         https://bugs.webkit.org/show_bug.cgi?id=133029
127
128         Reviewed by Simon Fraser.
129
130         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
131         toggling it on a WK2 window needs restart.
132         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
133         the WebPreferences just to support this temporary toggle.
134
135         * MiniBrowser/mac/BrowserWindowController.h:
136         * MiniBrowser/mac/MainMenu.xib:
137         * MiniBrowser/mac/WK1BrowserWindowController.m:
138         (-[WK1BrowserWindowController validateMenuItem:]):
139         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
140         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
141         * MiniBrowser/mac/WK2BrowserWindowController.m:
142         (-[WK2BrowserWindowController validateMenuItem:]):
143         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
144         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
145
146 2014-05-17  Anders Carlsson  <andersca@apple.com>
147
148         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
149         https://bugs.webkit.org/show_bug.cgi?id=133033
150         <rdar://problem/16830143>
151
152         Reviewed by Sam Weinig.
153
154         Set up the WebSQL and IndexedDB directories.
155
156         * WebKitTestRunner/TestController.cpp:
157         (WTR::TestController::initialize):
158
159 2014-05-16  Martin Hock  <mhock@apple.com>
160
161         MemoryCache::addImageToCache should return the result of add().
162         https://bugs.webkit.org/show_bug.cgi?id=132928
163         <rdar://problem/16651547>
164
165         Reviewed by Alexey Proskuryakov.
166
167         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
169         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
170         (TestWebKitAPI::TEST):
171
172 2014-05-15  David Farler  <dfarler@apple.com>
173
174         old-run-webkit-tests: allow specifying a simulator app path
175         https://bugs.webkit.org/show_bug.cgi?id=132975
176
177         Reviewed by Anders Carlsson.
178
179         * Scripts/old-run-webkit-tests:
180         (openIPhoneSimulator):
181         Add new --simulator-app command line parameter for specifying the
182         absolute path to the simulator app to launch before starting a
183         session.
184
185 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
186
187         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
188         https://bugs.webkit.org/show_bug.cgi?id=131363
189
190         Reviewed by Csaba Osztrogonác.
191
192         * Scripts/webkitpy/common/checkout/checkout_mock.py:
193         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
194         (MockBugzilla):
195         * Scripts/webkitpy/tool/commands/download_unittest.py:
196         (test_create_rollout_multiple_revision_with_one_resolved):
197         (test_create_rollout_multiple_resolved):
198         (test_rollout_two_revisions):
199         (test_rollout_multiple_revisions):
200         (test_rollout_multiple_revisions_with_a_missing_bug_id):
201         * Scripts/webkitpy/tool/steps/createbug.py:
202         (CreateBug.run):
203         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
204         (ReopenBugAfterRollout.run):
205
206 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
207
208         [WK2] Change the remaining framework includes from WebKit2 to WebKit
209         https://bugs.webkit.org/show_bug.cgi?id=132956
210
211         Reviewed by Sam Weinig.
212
213         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
214         * MiniBrowser/mac/AppDelegate.m:
215         * MiniBrowser/mac/WK2BrowserWindowController.m:
216         * TestWebKitAPI/InjectedBundleController.h:
217         * TestWebKitAPI/InjectedBundleMain.cpp:
218         * TestWebKitAPI/JavaScriptTest.cpp:
219         * TestWebKitAPI/PlatformUtilities.h:
220         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
221         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
222         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
223         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
224         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
225         (TestWebKitAPI::TEST):
226         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
227         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
228         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
229         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
230         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
231         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
232         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
233         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
234         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
235         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
236         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
237         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
238         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
239         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
240         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
241         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
242         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
243         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
244         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
245         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
246         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
247         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
248         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
249         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
250         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
251         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
252         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
253         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
254         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
255         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
256         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
257         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
258         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
259         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
260         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
261         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
262         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
263         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
264         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
265         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
266         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
267         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
268         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
269         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
270         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
271         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
272         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
273         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
274         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
275         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
276         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
277         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
278         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
279         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
280         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
281         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
282         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
283         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
284         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
285         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
286         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
287         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
288         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
289         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
290         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
291         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
292         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
293         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
294         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
295         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
296         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
297         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
298         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
299         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
300         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
301         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
302         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
303         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
304         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
305         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
306         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
307         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
308         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
309         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
310         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
311         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
312         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
313         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
314         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
315         * TestWebKitAPI/config.h:
316         * TestWebKitAPI/efl/PlatformWebView.cpp:
317         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
318         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
319         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
320         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
321         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
322         * WebKitTestRunner/EventSenderProxy.h:
323         * WebKitTestRunner/GeolocationProviderMock.cpp:
324         * WebKitTestRunner/GeolocationProviderMock.h:
325         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
326         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
327         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
328         * WebKitTestRunner/InjectedBundle/GCController.cpp:
329         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
330         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
331         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
332         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
333         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
334         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
335         * WebKitTestRunner/InjectedBundle/TestRunner.h:
336         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
337         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
338         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
339         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
340         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
341         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
342         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
343         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
344         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
345         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
346         * WebKitTestRunner/PlatformWebView.h:
347         * WebKitTestRunner/StringFunctions.h:
348         * WebKitTestRunner/TestController.cpp:
349         * WebKitTestRunner/TestController.h:
350         * WebKitTestRunner/TestInvocation.cpp:
351         * WebKitTestRunner/TestInvocation.h:
352         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
353         * WebKitTestRunner/WebNotificationProvider.cpp:
354         * WebKitTestRunner/WebNotificationProvider.h:
355         * WebKitTestRunner/WorkQueueManager.cpp:
356         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
357         * WebKitTestRunner/cg/TestInvocationCG.cpp:
358         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
359         * WebKitTestRunner/config.h:
360         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
361         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
362         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
363         * WebKitTestRunner/ios/TestControllerIOS.mm:
364         * WebKitTestRunner/mac/EventSenderProxy.mm:
365         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
366         * WebKitTestRunner/mac/TestControllerMac.mm:
367
368 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
369
370         [EFL][WK2] Skip failing unit tests
371         https://bugs.webkit.org/show_bug.cgi?id=132979
372
373         Reviewed by Daniel Bates.
374
375         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
376
377 2014-05-15  David Kilzer  <ddkilzer@apple.com>
378
379         [iOS] Support TestWebKitAPI in the iOS Simulator
380         <http://webkit.org/b/129535>
381         <rdar://problem/16203529>
382
383         Reviewed by Daniel Bates.
384
385         * Scripts/run-api-tests:
386         (runTest):
387         (listAllTests):
388         - Extract common arguments into local variable.
389         - Use xcrun to find the sim tool in order to invoke
390         TestWebKitAPI properly in the iOS Simulator. 
391
392         * Scripts/webkitdirs.pm:
393         (argumentsForConfiguration): Set --device or --sim as
394         appropriate to fix buildTestTool() in run-api-tests.
395
396 2014-05-15  Tim Horton  <timothy_horton@apple.com>
397
398         Fix a logging typo in copy-webkitlibraries-to-product-directory
399
400         Reviewed by Dean Jackson.
401
402         * Scripts/copy-webkitlibraries-to-product-directory:
403
404 2014-05-15  David Kilzer  <ddkilzer@apple.com>
405
406         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
407         <http://webkit.org/b/132959>
408
409         Reviewed by Dan Bernstein.
410
411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
412         Cocoa directory to project and move URLExtras.mm into it.
413         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
414
415 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
416
417         [GTK] Compile all installed resources as GResources
418         https://bugs.webkit.org/show_bug.cgi?id=131099
419
420         Reviewed by Philippe Normand.
421
422         * Scripts/webkitpy/port/gtk.py:
423         (GtkPort.setup_environ_for_server): Removed now unneeded
424         AUDIO_RESOURCES_PATH env var.
425
426 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
427
428         Remove CSS_STICKY_POSITION guards
429         https://bugs.webkit.org/show_bug.cgi?id=132676
430
431         Reviewed by Simon Fraser.
432
433         * Scripts/webkitperl/FeatureList.pm:
434
435 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
436
437         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
438         https://bugs.webkit.org/show_bug.cgi?id=132686
439
440         Reviewed by Philippe Normand.
441
442         Bring back InputMethodFilter test to the build and compile it into
443         a single binary TestWebCore with the other WebCore tests. Also
444         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
445
446         * Scripts/run-gtk-tests:
447         (TestRunner): Remove WebCoreGtk from the list of test directories.
448         * TestWebKitAPI/PlatformGTK.cmake:
449         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
450
451 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
452
453         [EFL] Make XVFBDriver optional
454         https://bugs.webkit.org/show_bug.cgi?id=131036
455
456         Reviewed by Gyuyoung Kim.
457
458         * Scripts/webkitpy/port/efl.py:
459         (EflPort._driver_class):
460
461 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
462
463         Flakiness dashboard contains outdated list of bots on builders.jsonp
464         https://bugs.webkit.org/show_bug.cgi?id=132874
465
466         Reviewed by Darin Adler.
467
468         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
469         file by changing to the directory Tools/TestResultServer and executing
470         the script generate_builders_json.py
471
472 2014-05-11  Anders Carlsson  <andersca@apple.com>
473
474         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
475         https://bugs.webkit.org/show_bug.cgi?id=132809
476
477         Reviewed by Dan Bernstein.
478
479         * WebKitTestRunner/TestController.cpp:
480         (WTR::TestController::initialize):
481         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
482
483 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
484
485         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
486         https://bugs.webkit.org/show_bug.cgi?id=132739
487
488         Reviewed Anders Carlsson.
489
490         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
491         the JSC unit tests.
492         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
493
494 2014-05-11  Anders Carlsson  <andersca@apple.com>
495
496         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
497         https://bugs.webkit.org/show_bug.cgi?id=132806
498
499         Reviewed by Beth Dakin.
500
501         Migrate to WKContextConfiguration.
502
503         * WebKitTestRunner/TestController.cpp:
504         (WTR::TestController::initialize):
505
506 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
507
508         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
509         https://bugs.webkit.org/show_bug.cgi?id=132685
510
511         Reviewed by Martin Robinson.
512
513         Use a single TestWebKit2 binary for all WebKit2 C API tests.
514
515         * TestWebKitAPI/PlatformGTK.cmake:
516
517 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
518
519         [iOS] Switch geolocation to an explicit authorization query model
520         https://bugs.webkit.org/show_bug.cgi?id=132717
521
522         Reviewed by Sam Weinig.
523
524         * DumpRenderTree/mac/MockGeolocationProvider.mm:
525         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
526         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
527
528 2014-05-09  David Farler  <dfarler@apple.com>
529
530         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
531         https://bugs.webkit.org/show_bug.cgi?id=132718
532
533         Reviewed by David Kilzer.
534
535         The simulator may not be able to look up runtimes by SDK paths
536         and instead will map SDK versions to runtimes instead. In
537         com.apple.iphonesimulator.startSession notifications,
538         'runtimeIdentifier' (SDK version string) is preferred over
539         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
540         when creating a new DRT or WKTR simulator session.
541
542         IPhoneSimulatorNotification.pm filters out keys for this
543         notification's userInfo with a hard-coded list. There's no harm
544         in including extra key-value pairs in an NSNotification userInfo
545         dictionary anyway and the simulator may again change its
546         userInfo schema for this notification.
547
548         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
549         (postStartSessionNotification):
550         * Scripts/old-run-webkit-tests:
551         (installAndLaunchDumpToolAppUsingNotification):
552
553 2014-05-09  Anders Carlsson  <andersca@apple.com>
554
555         Another build fix.
556
557         * Scripts/build-webkit:
558         WebKit2 should always be built for OS X and iOS.
559
560 2014-05-09  Anders Carlsson  <andersca@apple.com>
561
562         Follow-up build fix.
563
564         * Scripts/build-webkit:
565         WebKit2 should no longer be built before WebKit.
566
567 2014-05-09  Anders Carlsson  <andersca@apple.com>
568
569         Rename WebKit2.framework to WebKit.framework
570         https://bugs.webkit.org/show_bug.cgi?id=132743
571         <rdar://problem/15920046>
572
573         Reviewed by Dan Bernstein.
574
575         * Scripts/check-for-inappropriate-files-in-framework:
576         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
577         Change WebKit2 to WebKit.
578
579         * Scripts/check-for-webkit-framework-include-consistency:
580         Change WebKit to WebKitLegacy.
581
582 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
583
584         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
585         https://bugs.webkit.org/show_bug.cgi?id=132732
586
587         Reviewed by Alexey Proskuryakov.
588
589         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
590
591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
592         (EWS): Remove GTK+ WK1 EWS.
593
594 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
595
596         Add new u-szeged contributors.
597
598         Reviewed by Csaba Osztrogonác.
599
600         * Scripts/webkitpy/common/config/contributors.json:
601
602 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
603
604         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
605         https://bugs.webkit.org/show_bug.cgi?id=132736
606
607         Reviewed by Philippe Normand.
608
609         There are two problems, the path returned by common.library_build_path() is wrong when
610         common.binary_build_path() has previously been called, and the test is still looking for
611         the .la instead of .so
612
613         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
614         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
615         of .la as extension of the injected bundle library.
616         * gtk/common.py:
617         (binary_build_path): Remove unused global variable and add a new
618         one for binary_build_dir instead of sharing the same global
619         variable for library_build_path and binary_build_path.
620
621 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
622
623         [EFL] Enable MEDIA_STREAM for EFL port
624         https://bugs.webkit.org/show_bug.cgi?id=132648
625
626         Reviewed by Gyuyoung Kim.
627
628         Script modified to enable MEDIA_STREAM for EFL build.
629
630         * Scripts/webkitperl/FeatureList.pm: 
631
632 2014-05-08  David Farler  <dfarler@apple.com>
633
634         old-run-webkit-tests: update strings for simulator devices and app name
635         https://bugs.webkit.org/show_bug.cgi?id=132687
636
637         Reviewed by Darin Adler.
638
639         iPhone Retina (4-inch) -> iPhone 5
640         iPhone Retina (4-inch 64-bit) -> iPhone 5s
641
642         * Scripts/old-run-webkit-tests:
643         (installAndLaunchDumpToolAppUsingNotification):
644         (openIPhoneSimulator):
645         (quitIPhoneSimulator):
646         quit iOS Simulator, not iPhone Simulator.
647
648 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
649
650         REGRESSION(r168471): Update the builder names on the scheduler list.
651         https://bugs.webkit.org/show_bug.cgi?id=132699
652
653         Reviewed by Martin Robinson.
654
655         On r168471 I missed to update the builder names for the GTK build
656         bots on the AnyBranchScheduler type scheduler list of bots.
657
658         * BuildSlaveSupport/build.webkit.org-config/config.json:
659
660 2014-05-08  Brady Eidson  <beidson@apple.com>
661
662         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
663         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
664
665         Reviewed by Tim Horton.
666
667         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
668         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
669
670 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
671
672         REGRESSION(r168471): Duplicate builddirs broke the build master.
673         https://bugs.webkit.org/show_bug.cgi?id=132688
674
675         Reviewed by Carlos Garcia Campos.
676
677         Rename the builddirs of the new GTK bots introduced on r168471 to
678         be unique. Otherwise the master will break.
679
680         * BuildSlaveSupport/build.webkit.org-config/config.json:
681
682 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
683
684         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
685         https://bugs.webkit.org/show_bug.cgi?id=132674
686
687         Reviewed by Philippe Normand.
688
689         Only ignore mkdir failure when exception is raised because the
690         file already exists and it's a directory.
691
692         * gtk/webkitdom.py:
693         (write_doc_files):
694
695 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
696
697         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
698         https://bugs.webkit.org/show_bug.cgi?id=131358
699
700         Reviewed by Carlos Garcia Campos.
701
702         Current 64-bit GTK build bots (Release and Debug) not only test
703         the build, but run all tests. Split each one of the bots in
704         BuildOnly and TestWebKit2.
705
706         This will allow us to have a better overview of the status of
707         the GTK port.
708
709         Original patch from Sergio Villar Senin <svillar@igalia.com>
710
711         * BuildSlaveSupport/build.webkit.org-config/config.json:
712         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
713         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
714         (WebKitBuildbot):
715         * Scripts/webkitpy/port/builders.py:
716         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
717         (TestRebaselineTest.test_baseline_directory):
718         * TestResultServer/static-dashboards/builders.jsonp:
719         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
720         (resetGlobals):
721         * TestResultServer/static-dashboards/loader_unittests.js:
722
723 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
724
725         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
726         https://bugs.webkit.org/show_bug.cgi?id=126022
727
728         Reviewed by Benjamin Poulain.
729
730         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
731
732         Added an unit test case to check if scroll position and scale are restored properly.
733
734         * TestWebKitAPI/PlatformEfl.cmake:
735         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
736         (TestWebKitAPI::didFinishLoadForFrame):
737         (TestWebKitAPI::didChangeContentsPosition):
738         (TestWebKitAPI::TEST):
739         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
740         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
741
742 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
743
744         WebKit1 is flashy when compositing layers come and go
745         https://bugs.webkit.org/show_bug.cgi?id=132655
746         <rdar://problem/16830981&16788846>
747
748         Reviewed by Sam Weinig.
749         
750         Revert the change from r166117.
751
752         * DumpRenderTree/mac/DumpRenderTree.mm:
753         (updateDisplay):
754
755 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
756
757         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
758         https://bugs.webkit.org/show_bug.cgi?id=132622
759
760         Reviewed by Mario Sanchez Prada.
761
762         * DumpRenderTree/AccessibilityUIElement.cpp:
763         (selectTextWithCriteriaCallback):
764         (isEqualCallback):
765         * DumpRenderTree/AccessibilityUIElement.h:
766         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
767         (AccessibilityUIElement::selectTextWithCriteria):
768         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
769         (AccessibilityUIElement::selectTextWithCriteria):
770         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
771         (selectTextParameterizedAttributeForCriteria):
772         (AccessibilityUIElement::selectTextWithCriteria):
773         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
774         (AccessibilityUIElement::selectTextWithCriteria):
775         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
776         (WTR::AccessibilityUIElement::selectTextWithCriteria):
777         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
778         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
779         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
780         (WTR::AccessibilityUIElement::selectTextWithCriteria):
781         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
782         (WTR::AccessibilityUIElement::selectTextWithCriteria):
783         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
784         (WTR::selectTextParameterizedAttributeForCriteria):
785         (WTR::AccessibilityUIElement::selectTextWithCriteria):
786
787 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
788
789         [SOUP] TLSErrors do not cause page load to fail when not ignored
790         https://bugs.webkit.org/show_bug.cgi?id=121548
791
792         Reviewed by Sergio Villar Senin.
793
794         Add unit tests to check that the load fails with TLS errors in
795         case of a redirection.
796
797         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
798         (testTLSErrorsRedirect):
799         (httpsServerCallback):
800         (beforeAll):
801
802 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
803
804         [CSS Grid Layout] Remove runtime feature
805         https://bugs.webkit.org/show_bug.cgi?id=132382
806
807         Reviewed by Benjamin Poulain.
808
809         Remove cssGridLayoutEnabled setting usage.
810
811         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
812         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
813         * DumpRenderTree/efl/TestRunnerEfl.cpp:
814         (TestRunner::overridePreference):
815         * DumpRenderTree/mac/DumpRenderTree.mm:
816         (resetWebPreferencesToConsistentValues):
817
818 2014-05-06  David Kilzer  <ddkilzer@apple.com>
819
820         Add Makefile targets for copying static libraries (LLVM and WKSI)
821         <http://webkit.org/b/132619>
822
823         Reviewed by Mark Rowe.
824
825         * Scripts/copy-webkitlibraries-to-product-directory: Set a
826         sensible default for product directory if not specified on
827         either the command-line or in the environment (by Xcode) by
828         calling productDir() in webkitdirs.pm.
829
830 2014-05-06  Brady Eidson  <beidson@apple.com>
831
832         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
833         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
834
835         Reviewed by Sam Weinig.
836
837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
838
839         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
840         (TestWebKitAPI::itemURLLastComponentIsString):
841         (TestWebKitAPI::didFinishLoadForFrame):
842         (TestWebKitAPI::willGoToBackForwardListItem):
843         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
844         (TestWebKitAPI::setPageLoaderClient):
845         (TestWebKitAPI::TEST):
846         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
847         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
848
849         * WebKitTestRunner/TestController.cpp:
850         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
851
852 2014-05-06  Darin Adler  <darin@apple.com>
853
854         Try to fix iOS build.
855
856         * DumpRenderTree/mac/TestRunnerMac.mm:
857         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
858         Updated since I changed testRunner into a pointer instead of a reference.
859         Updated argument names to avoid conflict with field names.
860         (-[APITestDelegateIPhone run]): Ditto.
861         (-[APITestDelegateIPhone _cleanUp]): Ditto.
862
863 2014-05-06  Commit Queue  <commit-queue@webkit.org>
864
865         Unreviewed, rolling out r168304.
866         https://bugs.webkit.org/show_bug.cgi?id=132607
867
868         Broke the build (Requested by KaL on #webkit).
869
870         Reverted changeset:
871
872         "[GTK][CMake] Unable to do make install"
873         https://bugs.webkit.org/show_bug.cgi?id=130188
874         http://trac.webkit.org/changeset/168304
875
876 2014-05-04  Darin Adler  <darin@apple.com>
877
878         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
879         https://bugs.webkit.org/show_bug.cgi?id=80222
880
881         Reviewed by Alexey Proskuryakov.
882
883         * DumpRenderTree/mac/TestRunnerMac.mm:
884         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
885         do more work here so we don't use RetainPtr local variables.
886         (-[APITestDelegateIPhone dealloc]): Added.
887         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
888         created. Updated for changes to member names and types.
889         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
890         updated for changes to member names and types. Changed to two word spelling.
891         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
892         name of _cleanUp method.
893         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
894         Ditto.
895         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
896
897 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
898
899         Clean up Image Document and tweak the layout and viewport
900         https://bugs.webkit.org/show_bug.cgi?id=132552
901
902         Reviewed by Anders Carlsson.
903
904         * DumpRenderTree/mac/DumpRenderTree.mm:
905         (resetWebPreferencesToConsistentValues):
906         Update the default settings to have something consistent with WebKit2.
907
908 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
909
910         [GTK][CMake] Unable to do make install
911         https://bugs.webkit.org/show_bug.cgi?id=130188
912
913         Reviewed by Carlos Garcia Campos.
914
915         * Scripts/webkitdirs.pm:
916         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
917         will give an early signal that a change has broken the documentation.
918
919 2014-05-05  Pratik Solanki  <psolanki@apple.com>
920
921         Update framework locations in package-root
922         https://bugs.webkit.org/show_bug.cgi?id=132571
923
924         Reviewed by Simon Fraser.
925
926         * Scripts/package-root:
927
928 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
929
930         [EFL][WK2] Refactor favicon database APIs
931         https://bugs.webkit.org/show_bug.cgi?id=132519
932
933         Reviewed by Gyuyoung Kim.
934
935         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
936         (update_view_favicon):
937         (on_icon_changed_cb):
938         (window_free):
939         (on_url_changed):
940         (window_create):
941         (on_view_favicon_changed): Deleted.
942
943 2014-05-02  Mark Rowe  <mrowe@apple.com>
944
945         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
946
947         Reviewed by Dan Bernstein.
948
949         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
950         when determining which LLVM archive to extract.
951
952 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
953
954         Add Jeremy as a committer.
955         https://bugs.webkit.org/show_bug.cgi?id=132492
956
957         Reviewed by Jer Noble.
958
959         Add myself as a committer.
960
961         * Scripts/webkitpy/common/config/contributors.json:
962
963 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
964
965         Add Jeremy as a committer.
966         https://bugs.webkit.org/show_bug.cgi?id=132492
967
968         Reviewed by Jer Noble.
969
970         Add Jeremy Jones to the committers file.
971
972         * Scripts/webkitpy/common/config/contributors.json:
973
974 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
975
976         Hard to figure out how to run a single test with run-api-tests
977         https://bugs.webkit.org/show_bug.cgi?id=116332
978
979         Reviewed by Alexey Proskuryakov.
980
981         * Scripts/run-api-tests: add two examples to the help message.
982
983 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
984
985         Fix several memory leaks found by code inspection
986         https://bugs.webkit.org/show_bug.cgi?id=132472
987
988         Reviewed by Geoffrey Garen.
989         
990         Fix memory leaks.
991
992         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
993         (TestWebKitAPI::TEST):
994         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
995         (WTR::InjectedBundlePage::willSendRequestForFrame):
996         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
997         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
998
999 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
1000
1001         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
1002         https://bugs.webkit.org/show_bug.cgi?id=132446
1003
1004         Reviewed by Mark Hahnenberg.
1005         
1006         Test the FTL by default now that it's enabled by default.
1007
1008         * Scripts/run-javascriptcore-tests:
1009
1010 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
1011
1012         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
1013         https://bugs.webkit.org/show_bug.cgi?id=132240
1014
1015         Reviewed by Anders Carlsson.
1016
1017         Removed ewk_view_setting_tiled_backingstore related code.
1018
1019         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1020         (DumpRenderTreeChrome::createView):
1021         (shouldUseTiledBackingStore): Deleted.
1022         * EWebLauncher/main.c:
1023         (windowCreate):
1024         (parseUserArguments):
1025
1026 2014-05-01  Anders Carlsson  <andersca@apple.com>
1027
1028         window.testRunner.keepWebHistory() should update the UI process state
1029         https://bugs.webkit.org/show_bug.cgi?id=132440
1030
1031         Reviewed by Dan Bernstein.
1032
1033         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1034         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1035         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1036         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1037         (WTR::TestRunner::keepWebHistory):
1038         * WebKitTestRunner/TestInvocation.cpp:
1039         (WTR::TestInvocation::invoke):
1040         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1041
1042 2014-05-01  David Kilzer  <ddkilzer@apple.com>
1043
1044         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
1045         <http://webkit.org/b/132432>
1046
1047         Reviewed by Tim Horton.
1048
1049         * Scripts/webkitperl/FeatureList.pm: Remove support for
1050         --plugin-proxy-for-video switch.
1051
1052 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1053
1054         Kernel sysctl interface hw.activecpu don't exists on Linux.
1055         https://bugs.webkit.org/show_bug.cgi?id=132286
1056
1057         Reviewed by Filip Pizlo.
1058
1059         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
1060         calling sysctl over hw.activecpu
1061
1062 2014-04-30  Anders Carlsson  <andersca@apple.com>
1063
1064         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
1065         https://bugs.webkit.org/show_bug.cgi?id=132399
1066         <rdar://problem/15920046>
1067
1068         Reviewed by Dan Bernstein.
1069
1070         * Scripts/check-for-webkit-framework-include-consistency:
1071         Allos WAK headers in WebKitLegacy as well as WebKit.
1072
1073         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1074         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1075         Update header imports.
1076
1077 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1078
1079         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
1080         https://bugs.webkit.org/show_bug.cgi?id=131954
1081
1082         Reviewed by Darin Adler.
1083         
1084         WebKitTestRunner was adding application-specific information to crash reports
1085         to log the test path, but only in the web process. Fix it to also do this
1086         for the UI process, for both iOS and OS X.
1087         
1088         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
1089         both iOS and OS X.
1090         
1091         Factored crash reprorter-related code into CrashReporterInfo, and call it from
1092         a new TestController::platformWillRunTest() function on Mac and iOS.
1093         
1094         Also remove Xcode-added unit test junk from the project.
1095
1096         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1097         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1098         * WebKitTestRunner/TestController.cpp:
1099         (WTR::TestController::runTest):
1100         * WebKitTestRunner/TestController.h:
1101         * WebKitTestRunner/TestInvocation.cpp:
1102         (WTR::TestInvocation::url):
1103         * WebKitTestRunner/TestInvocation.h:
1104         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1105         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
1106         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
1107         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
1108         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1109         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
1110         (WTR::testPathFromURL):
1111         (WTR::setCrashReportApplicationSpecificInformationToURL):
1112         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1113         (WTR::TestController::platformWillRunTest):
1114         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1115         (WTR::TestController::platformWillRunTest):
1116         * WebKitTestRunner/ios/TestControllerIOS.mm:
1117         (WTR::TestController::platformWillRunTest):
1118         (WTR::TestController::setHidden):
1119         * WebKitTestRunner/mac/TestControllerMac.mm:
1120         (WTR::TestController::platformWillRunTest):
1121
1122 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1123
1124         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
1125
1126         Reviewed by Tim Horton.
1127
1128         * DumpRenderTree/mac/DumpRenderTree.mm:
1129         (resetWebPreferencesToConsistentValues):
1130         (prepareConsistentTestingEnvironment):
1131
1132 2014-04-30  Anders Carlsson  <andersca@apple.com>
1133
1134         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
1135         https://bugs.webkit.org/show_bug.cgi?id=132397
1136
1137         Reviewed by Dan Bernstein.
1138
1139         * Scripts/check-for-inappropriate-macros-in-external-headers:
1140
1141 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
1142
1143         [GTK] Make it easier to run CMake for downstreams
1144         https://bugs.webkit.org/show_bug.cgi?id=132370
1145
1146         Reviewed by Carlos Garcia Campos.
1147
1148         * Scripts/webkitdirs.pm:
1149         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
1150         the GTK+ port.
1151
1152 2014-04-29  Stephanie Lewis  <slewis@apple.com>
1153
1154         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
1155         
1156         Rubber stamped by Jessie Berlin.
1157
1158         JSON.pm was removed from our tools setup.
1159
1160         * Scripts/generate-coverage-data:
1161
1162 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
1163
1164         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
1165         https://bugs.webkit.org/show_bug.cgi?id=112840
1166
1167         Rubber stamped by Geoffrey Garen.
1168
1169         * Scripts/build-jsc: Enable it on Mac.
1170         * Scripts/build-webkit: Enable it on Mac.
1171         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
1172
1173 2014-04-28  Sam Weinig  <sam@webkit.org>
1174
1175         REGRESSION (r167751): svn-create-patch is very slow
1176         https://bugs.webkit.org/show_bug.cgi?id=132300
1177
1178         Reviewed by Alexey Proskuryakov.
1179
1180         * Scripts/svn-create-patch:
1181         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
1182         by calling `svn-create-patch --style`.
1183
1184 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
1185
1186         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
1187         https://bugs.webkit.org/show_bug.cgi?id=132190
1188
1189         Reviewed by Gustavo Noronha Silva.
1190
1191         * Scripts/webkitdirs.pm:
1192         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
1193             if ninja is in the path.
1194         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
1195             to the previous ninja generator if not.
1196
1197 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1198
1199         check-webkit-style should understand --git-index
1200         https://bugs.webkit.org/show_bug.cgi?id=125364
1201
1202         Reviewed by Csaba Osztrogonác.
1203
1204         * Scripts/webkitpy/common/checkout/scm/git.py:
1205         (Git.create_patch): The command now supports the --cached option.
1206         * Scripts/webkitpy/style/main.py:
1207         (CheckWebKitStyle.main): Passing the --git-index option.
1208         * Scripts/webkitpy/style/optparser.py:
1209         (CommandOptionValues.__init__): The git-index option is switched off by default.
1210         (CommandOptionValues.__eq__): Equality check for the new option.
1211         (ArgumentParser._create_option_parser):Adding the --git-index option
1212         (ArgumentParser.parse):
1213         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
1214         (CommandOptionValuesTest.test_init): 
1215         (CommandOptionValuesTest.test_eq):
1216
1217 2014-04-28  Michael Saboff  <msaboff@apple.com>
1218
1219         Crash in platform/mac/accessibility/table-visible-rows.html
1220         https://bugs.webkit.org/show_bug.cgi?id=132146
1221
1222         Reviewed by Filip Pizlo.
1223
1224         Instead of creating a local JSValueRef array on the stack and passing that to
1225         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
1226         values using the JSObjectSetPropertyAtIndex() API.
1227
1228         * DumpRenderTree/AccessibilityUIElement.cpp:
1229         (elementsForRangeCallback):
1230         (convertElementsToObjectArray):
1231         * DumpRenderTree/mac/TestRunnerMac.mm:
1232         (originsArrayToJS):
1233         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1234         (WTR::EventSendingController::contextClick):
1235         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1236         (WTR::stringArrayToJS):
1237         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1238         (WTR::convertElementsToObjectArray):
1239
1240 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
1241
1242         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
1243         "no-cjit" runs force the old-school threshold.
1244
1245         Rubber stamped by Mark Hahnenberg.
1246
1247         * Scripts/run-jsc-stress-tests:
1248
1249 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1250
1251         [GTK] install-dependencies should also install ruby-json and ruby-highline
1252         https://bugs.webkit.org/show_bug.cgi?id=132292
1253
1254         Reviewed by Philippe Normand.
1255
1256         * gtk/install-dependencies: Install ruby json and highline packages.
1257
1258 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
1259
1260         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
1261         https://bugs.webkit.org/show_bug.cgi?id=132176
1262
1263         Reviewed by Gyuyoung Kim.
1264
1265         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
1266         and turn off indexedDB feature until the sqlite implementation is introduced.
1267
1268         * Scripts/webkitperl/FeatureList.pm:
1269
1270 2014-04-25  James Craig  <jcraig@apple.com>
1271
1272         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
1273         https://bugs.webkit.org/show_bug.cgi?id=132209
1274
1275         Reviewed by Daniel Bates.
1276
1277         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
1278         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
1279
1280         * Scripts/prepare-ChangeLog:
1281         (main): 
1282
1283 2014-04-25  Michael Saboff  <msaboff@apple.com>
1284
1285         Crash in platform/mac/accessibility/table-visible-rows.html
1286         https://bugs.webkit.org/show_bug.cgi?id=132146
1287
1288         Reviewed by Mark Lam.
1289
1290         Changed to use a local JSValueRef array temporary instead of a
1291         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
1292         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
1293         the temporary values could be collected.
1294
1295         * DumpRenderTree/AccessibilityUIElement.cpp:
1296         (convertElementsToObjectArray):
1297         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1298         (WTR::EventSendingController::contextClick):
1299         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1300         (WTR::convertElementsToObjectArray):
1301
1302 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
1303
1304         Unreviewed GTK gardening
1305
1306         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
1307         (TestRunner):
1308
1309 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
1310
1311         prepare-ChangeLog reports as deleted methods that has not been removed.
1312         https://bugs.webkit.org/show_bug.cgi?id=131733
1313
1314         Reviewed by Ryosuke Niwa.
1315
1316         * Scripts/prepare-ChangeLog:
1317         (originalFile): Set merge base to origin/master by default.
1318
1319 2014-04-23  James Craig  <jcraig@apple.com>
1320
1321         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
1322         https://bugs.webkit.org/show_bug.cgi?id=131115
1323
1324         Reviewed by Daniel Bates.
1325
1326         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
1327
1328         * Scripts/commit-log-editor: Added --no-style.
1329         * Scripts/prepare-ChangeLog: Primary patch.
1330         (main): Primary patch.
1331         (createPatchCommand): Added --no-style.
1332         * Scripts/svn-create-patch: Primary patch.
1333         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
1334         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
1335         (SVN.create_patch): Added --no-style.
1336
1337 2014-04-23  Anders Carlsson  <andersca@apple.com>
1338
1339         Try to fix iOS build.
1340
1341         * DumpRenderTree/mac/DumpRenderTree.mm:
1342
1343 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
1344
1345         Eliminate internals.setMockScrollbarsEnabled()
1346         https://bugs.webkit.org/show_bug.cgi?id=132085
1347
1348         Reviewed by Tim Horton.
1349
1350         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
1351         No need to reset the preference, there is no way it can change.
1352
1353 2014-04-23  James Craig  <jcraig@apple.com>
1354
1355         Unreviewed. Moving myself from Contributors to Committers list.
1356
1357         * Scripts/webkitpy/common/config/contributors.json:
1358
1359 2014-04-23  Tim Horton  <timothy_horton@apple.com>
1360
1361         Mock scrollbars don't always work in DumpRenderTree
1362         https://bugs.webkit.org/show_bug.cgi?id=132082
1363
1364         Reviewed by Alexey Proskuryakov.
1365
1366         * DumpRenderTree/mac/DumpRenderTree.mm:
1367         (prepareConsistentTestingEnvironment):
1368         Set the mock scrollbar setting before creating the WebView, as this setting
1369         cannot be dynamically changed, so any scrollbars that are created during
1370         WebView initialization and are not replaced before snapshotting will end
1371         up being platform scrollbars instead of mock ones.
1372         WebKitTestRunner already sets this preference before creating WKViews,
1373         so we're just matching its behavior.
1374
1375 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1376
1377         [GTK] ShadowRoot API was removed in r164131
1378         https://bugs.webkit.org/show_bug.cgi?id=132059
1379
1380         Reviewed by Gustavo Noronha Silva.
1381
1382         Add WebKitDOMShadowRoot to the list of deleted classes to generate
1383         the API docs.
1384
1385         * gtk/webkitdom.py:
1386         (WebKitDOMDocGenerator):
1387
1388 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
1389
1390         [GTK] run-webkit-tests script is failing to invoke run-launcher
1391         https://bugs.webkit.org/show_bug.cgi?id=132051
1392
1393         Reviewed by Philippe Normand.
1394
1395         After the WK1 support was dropped, if run-webkit-tests is executed
1396         without --no-show-results parameter, the launcher is being called
1397         using a -2 parameter that is it causing the run-launcher to break.
1398
1399         * Scripts/webkitpy/port/gtk.py:
1400         (GtkPort.show_results_html_file):
1401
1402 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1403
1404         DumpRenderTree generates black snapshots on some platforms
1405         https://bugs.webkit.org/show_bug.cgi?id=132029
1406         <rdar://problem/16679363>
1407
1408         Reviewed by Simon Fraser.
1409
1410         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1411         (createBitmapContextFromWebView):
1412         DRT checks with the WebView to determine whether it can use the window's
1413         backing store directly or (because of compositing) needs to take a WindowServer
1414         snapshot. However, on some platforms and in some situations, the window can
1415         be layer backed without the WebView necessarily currently being composited.
1416         We should check with the window in addition to the WebView before going
1417         ahead and using its backing store.
1418
1419 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1420
1421         DumpRenderTree generates white snapshots on some platforms
1422         https://bugs.webkit.org/show_bug.cgi?id=132026
1423         <rdar://problem/16679363>
1424
1425         Reviewed by Simon Fraser.
1426
1427         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1428         Link DRT against QuartzCore.
1429
1430         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1431         (createBitmapContextFromWebView):
1432         Force CoreAnimation to synchronously update layers in a more explicit
1433         way that doesn't depend on AppKit behavior. This is very similar to what
1434         WebKitTestRunner does (indirectly) during its force repaint.
1435
1436 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
1437
1438         [Win] Support Python 2.7 in Cygwin
1439         https://bugs.webkit.org/show_bug.cgi?id=132023
1440
1441         Reviewed by Michael Saboff.
1442
1443         * Scripts/webkitdirs.pm:
1444         (checkInstalledTools): Remove check for Python 2.7, since
1445         it now works properly.
1446
1447 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
1448
1449         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
1450         https://bugs.webkit.org/show_bug.cgi?id=130867
1451         <rdar://problem/16432456> 
1452
1453         Reviewed by Mark Hahnenberg.
1454
1455         * Scripts/build-webkit:
1456         * Scripts/copy-webkitlibraries-to-product-directory:
1457
1458 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
1459
1460         [GTK] Fails to build documentation when output is redirected
1461         https://bugs.webkit.org/show_bug.cgi?id=131178
1462
1463         Reviewed by Martin Robinson.
1464
1465         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
1466         explicitly to avoid encoding issues when they are redirected.
1467
1468 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
1469
1470         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
1471         https://bugs.webkit.org/show_bug.cgi?id=131911
1472
1473         Reviewed by Martin Robinson.
1474
1475         common.get_build_path returns release path even though Debug configuration
1476         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
1477
1478         * gtk/ycm_extra_conf.py:
1479         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
1480         (FlagsForFile):
1481
1482 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
1483
1484         Unreviewed build fix.
1485
1486         * DumpRenderTree/mac/EventSendingController.mm:
1487         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1488         Correct a typo that prevented tests from working properly.
1489
1490 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
1491
1492         [GTK] Should have the ability to output composited contents during layout testing
1493         https://bugs.webkit.org/show_bug.cgi?id=131864
1494
1495         Reviewed by Philippe Normand.
1496
1497         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1498         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
1499         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
1500         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1501         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
1502
1503 2014-04-21  Sam Weinig  <sam@webkit.org>
1504
1505         Attempt to fix the tests.
1506
1507         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1508         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1509         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
1510
1511 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
1512
1513         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
1514         being the same as a "quick run", which is meant for genuinely slow tests).
1515
1516         * Scripts/run-jsc-stress-tests:
1517
1518 2014-04-21  Darin Adler  <darin@apple.com>
1519
1520         Add HashSet::takeAny
1521         https://bugs.webkit.org/show_bug.cgi?id=131928
1522
1523         Reviewed by Benjamin Poulain.
1524
1525         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
1526
1527 2014-04-20  Dan Bernstein  <mitz@apple.com>
1528
1529         Fixed a test timing out after r167572.
1530
1531         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1532         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
1533         -webView:didFinishLoadingNavigation:.
1534
1535 2014-04-20  Commit Queue  <commit-queue@webkit.org>
1536
1537         Unreviewed, rolling out r167510.
1538         https://bugs.webkit.org/show_bug.cgi?id=131915
1539
1540         broke GTK Debug bot (Requested by philn on #webkit).
1541
1542         Reverted changeset:
1543
1544         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
1545         it when running layout tests"
1546         https://bugs.webkit.org/show_bug.cgi?id=131472
1547         http://trac.webkit.org/changeset/167510
1548
1549 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
1550
1551         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
1552         https://bugs.webkit.org/show_bug.cgi?id=131472
1553
1554         Reviewed by Philippe Normand.
1555
1556         * Scripts/webkitpy/port/gtk.py:
1557         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
1558         when running WebKitTestRunner with run-webkit-tests.
1559         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
1560         installed.
1561         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
1562         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
1563         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
1564         deal.
1565
1566 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
1567
1568         DownloadDecideDestinationCrash API test uses an incorrect value for path
1569         https://bugs.webkit.org/show_bug.cgi?id=131845
1570         <rdar://problem/15925560>
1571
1572         Reviewed by Enrica Casucci.
1573
1574         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1575         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
1576
1577 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
1578
1579         [Mac] AttributedStringTest API tests fail with async text input
1580         https://bugs.webkit.org/show_bug.cgi?id=131833
1581
1582         Reviewed by Enrica Casucci.
1583
1584         Don't run sync NSTextInputClient tests where we don't implement these calls.
1585
1586         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1587         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1588         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
1589         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1590         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
1591         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
1592         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
1593
1594 2014-04-18  Philippe Normand  <pnormand@igalia.com>
1595
1596         Remove NETWORK_INFO support
1597         https://bugs.webkit.org/show_bug.cgi?id=131841
1598
1599         Reviewed by Gyuyoung Kim.
1600
1601         * Scripts/webkitperl/FeatureList.pm:
1602
1603 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
1604
1605         [GTK] YouCompleteMe doesn't work for cmake build system.
1606         https://bugs.webkit.org/show_bug.cgi?id=131591
1607
1608         Reviewed by Martin Robinson.
1609
1610         Add cmake build system support for YouCompleteMe. It should work regardless of
1611         using make or ninja. In addition, autotools related code is removed since it's
1612         not used anymore in WebKit.
1613
1614         * Scripts/webkitdirs.pm:
1615         (generateBuildSystemFromCMakeProject):
1616         * gtk/ycm_extra_conf.py:
1617         (transform_relative_paths_to_absolute_paths):
1618         (FlagsForFile):
1619
1620 2014-04-17  Anders Carlsson  <andersca@apple.com>
1621
1622         Fix build.
1623
1624         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1625         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1626         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1627
1628 2014-04-17  Anders Carlsson  <andersca@apple.com>
1629
1630         Remove unused API enums
1631         https://bugs.webkit.org/show_bug.cgi?id=131836
1632
1633         Reviewed by Tim Horton.
1634
1635         * MiniBrowser/mac/WK2BrowserWindowController.m:
1636         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
1637
1638 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
1639
1640         [Win] A few final cleanups to the DataObject classes.
1641         https://bugs.webkit.org/show_bug.cgi?id=131784
1642
1643         Reviewed by Anders Carlsson.
1644
1645         * DumpRenderTree/win/DRTDataObject.cpp:
1646         (DRTDataObject::clearData): Use 'last()' method.
1647         * DumpRenderTree/win/UIDelegate.cpp:
1648         (DRTUndoStack::pop): Use 'takeLast()' method.
1649
1650 2014-04-17  Andres Gomez  <agomez@igalia.com>
1651
1652         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
1653         https://bugs.webkit.org/show_bug.cgi?id=131365
1654
1655         Reviewed by Brent Fulgham.
1656
1657         The cygwin installer is now downloading the wanted versions for
1658         the local installation given to the setup wizard.
1659
1660         * CygwinDownloader/cygwin-downloader.py:
1661         * CygwinDownloader/cygwin-downloader.zip:
1662
1663 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
1664
1665         [GTK] Make run-webkit-tests always use WKTR
1666         https://bugs.webkit.org/show_bug.cgi?id=131737
1667
1668         Reviewed by Darin Adler.
1669
1670         Now that the GTK+ port only has support for WebKit2, instruct
1671         run-webkit-tests to always use WKTR. This avoids needing to pass
1672         flag "-2" every time.
1673
1674         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
1675         (_set_up_derived_options): Always set webkit_test_runner when
1676         the platform is GTK+.
1677
1678 2014-04-17  Brendan Long  <b.long@cablelabs.com>
1679
1680         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
1681         https://bugs.webkit.org/show_bug.cgi?id=131760
1682
1683         Reviewed by Philippe Normand.
1684
1685         * gtk/install-dependencies: Install ninja-build when it's available.
1686
1687 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
1688
1689         [Win] run-javascriptcore-tests fails to run.
1690         https://bugs.webkit.org/show_bug.cgi?id=131761
1691
1692         Reviewed by Brent Fulgham.
1693
1694         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
1695
1696 2014-04-16  Andres Gomez  <agomez@igalia.com>
1697
1698         [Win] Pass default parameters to cygwin setup wizard
1699         https://bugs.webkit.org/show_bug.cgi?id=131361
1700
1701         Reviewed by Brent Fulgham.
1702
1703         Added some parameters to the cygwin setup wizard so the user
1704         doesn't really have to do any interaction.
1705
1706         * CygwinDownloader/cygwin-downloader.py:
1707         * CygwinDownloader/cygwin-downloader.zip:
1708
1709 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
1710
1711         [Win] Eliminate use of deleteAllValues in Windows Files
1712         https://bugs.webkit.org/show_bug.cgi?id=131631
1713
1714         Reviewed by Darin Adler.
1715
1716         Switch to std::unique_ptr for memory lifetime. Get rid of
1717         deleteAllValues now that it is no longer needed. Use ranged
1718         for loops where possible.
1719
1720         * DumpRenderTree/win/DRTDataObject.cpp:
1721         (WCEnumFormatEtc::WCEnumFormatEtc):
1722         (DRTDataObject::~DRTDataObject):
1723         (DRTDataObject::GetData):
1724         (DRTDataObject::QueryGetData):
1725         (DRTDataObject::SetData):
1726         (DRTDataObject::clearData):
1727         * DumpRenderTree/win/DRTDataObject.h:
1728         * DumpRenderTree/win/UIDelegate.cpp:
1729         (DRTUndoObject::DRTUndoObject):
1730         (DRTUndoObject::~DRTUndoObject):
1731         (DRTUndoStack::~DRTUndoStack):
1732         (DRTUndoStack::clear):
1733         (DRTUndoStack::pop):
1734         (DRTUndoManager::DRTUndoManager):
1735         (DRTUndoManager::redo):
1736         (DRTUndoManager::undo):
1737         (UIDelegate::UIDelegate):
1738         (UIDelegate::resetUndoManager):
1739         * DumpRenderTree/win/UIDelegate.h:
1740
1741 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1742
1743         [GTK] Unreviewed GTK gardening.
1744
1745         Update list of skipped unit tests:
1746
1747           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
1748
1749           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
1750           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
1751
1752         * Scripts/run-gtk-tests:
1753         (TestRunner):
1754
1755 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1756
1757         check-webkit-style doesn't check code style in .mm or .m files
1758         https://bugs.webkit.org/show_bug.cgi?id=131708
1759
1760         Reviewed by Darin Adler.
1761
1762         * Scripts/webkitpy/style/checker.py:
1763         * Scripts/webkitpy/style/checker_unittest.py:
1764         (CheckerDispatcherDispatchTest.test_cpp_paths):
1765         (CheckerDispatcherDispatchTest.test_text_paths):
1766         Check .mm and .m files as C++.
1767
1768         * Scripts/webkitpy/style/checkers/cpp.py:
1769         (check_spacing):
1770         Add an override for our ordinary "missing spaces around =" for @synthesize,
1771         which should look like "@synthesize propertyName=_varName;"
1772
1773         Add an override for "missing space before {" for blocks' "^{".
1774
1775         Don't follow the "extra space before [" rule for Objective-C, because
1776         it breaks this rule in a multitude of ways because of method calls.
1777
1778         (check_braces):
1779         Don't complain about { not being on the end of the previous line if
1780         the previous line starts with "- (" or "+ (", which would indicate a
1781         Objective-C method definition.
1782
1783 2014-04-16  Darin Adler  <darin@apple.com>
1784
1785         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
1786         https://bugs.webkit.org/show_bug.cgi?id=131735
1787
1788         Reviewed by Alexey Proskuryakov.
1789
1790         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
1791         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
1792         is on the right. This can be confusing since our JavaScript test framework does it the opposite
1793         way, but gtest works better this way.
1794
1795 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
1796
1797         [EFL] Fix problems with the pixel dump.
1798         https://bugs.webkit.org/show_bug.cgi?id=131265
1799
1800         Reviewed by Gyuyoung Kim.
1801
1802         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
1803         However pixel dump codes still call deprecated functions like ewk_view_paint(),
1804         which causes that nothing is drawn.
1805
1806         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
1807         One of new functions is AcceleratedCompositingContext::extractImageData(),
1808         which replaces deprecated function calls. Besides the extractImageData() is invoked by
1809         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
1810
1811         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1812         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
1813
1814 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
1815
1816         Update LLVM export scrpt to handle the build directory being different from the
1817         source directory.
1818
1819         Rubber stamped by Geoffrey Garen.
1820
1821         * Scripts/export-llvm-build:
1822
1823 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
1824
1825         Update the hyperlink to waterfall views of perf bots on build.webkit.org
1826         https://bugs.webkit.org/show_bug.cgi?id=131695
1827
1828         Reviewed by Antti Koivisto.
1829
1830         Updated.
1831
1832         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1833
1834 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1835
1836         [GTK] Reduce the binary size by compressing the text based web inspector resources
1837         https://bugs.webkit.org/show_bug.cgi?id=121545
1838
1839         Reviewed by Gustavo Noronha Silva.
1840
1841         Compress text based files when compiling inspector resources. It
1842         reduces the binary size in 3MB.
1843
1844         * gtk/generate-inspector-gresource-manifest.py:
1845         (find_all_files_in_directory):
1846         (is_compressible):
1847
1848 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1849
1850         Remove Gtk WebKit1 tester.
1851
1852         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1853         results over and over as fast as it could.
1854
1855         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1856         (WebKitBuildbot):
1857
1858 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1859
1860         Wrong link for webkitpy tests results in dashboard popover
1861         https://bugs.webkit.org/show_bug.cgi?id=131664
1862
1863         Reviewed by Timothy Hatcher.
1864
1865         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1866         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1867         Use a correct link.
1868
1869 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1870
1871         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1872
1873         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1874
1875         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1876         (CommitMessageForThisCommitTest):
1877
1878 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1879
1880         Fix commit-log-editor bug revealed by r165447
1881         https://bugs.webkit.org/show_bug.cgi?id=130676
1882
1883         Reviewed by Csaba Osztrogonác.
1884
1885         * Scripts/commit-log-editor:
1886         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1887         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1888         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1889         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1890
1891 2014-04-13  Darin Adler  <darin@apple.com>
1892
1893         userVisibleString should not try to "encode" host names
1894         https://bugs.webkit.org/show_bug.cgi?id=131587
1895         rdar://problem/14686849
1896
1897         Reviewed by Alexey Proskuryakov.
1898
1899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1900
1901         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1902         Coverage is tiny at this point; we could add a lot more cases!
1903
1904 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1905
1906         Use #include instead of #import
1907         https://bugs.webkit.org/show_bug.cgi?id=131604
1908
1909         Reviewed by Darin Adler.
1910
1911         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1912
1913         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1914
1915 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1916
1917         Make slow-stress tests run faster by running fewer VM variants.
1918
1919         Rubber stamped by Geoffrey Garen.
1920
1921         * Scripts/run-javascriptcore-tests:
1922         * Scripts/run-jsc-stress-tests:
1923
1924 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1925
1926         [CMake] Add missing WTF unit tests
1927         https://bugs.webkit.org/show_bug.cgi?id=131459
1928
1929         Reviewed by Martin Robinson.
1930
1931         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1932         that should be compiled into the TestWTF binary.
1933
1934 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1935
1936         [Gtk] run-launcher doesn't work by default
1937         https://bugs.webkit.org/show_bug.cgi?id=131494
1938
1939         Reviewed by Philippe Normand.
1940
1941         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1942         * Scripts/webkitdirs.pm:
1943         (launcherName): Same.
1944         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1945         * gtk/common.py:
1946         (get_build_path.is_valid_build_directory): Same.
1947         * gtk/manifest.txt: Same.
1948
1949 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1950
1951         Unreviewed, rolling out r167046.
1952         https://bugs.webkit.org/show_bug.cgi?id=131479
1953
1954         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1955         on #webkit).
1956
1957         Reverted changeset:
1958
1959         "Remove "System Font" from whitelisted DRT fonts and char
1960         width calculations"
1961         https://bugs.webkit.org/show_bug.cgi?id=131411
1962         http://trac.webkit.org/changeset/167046
1963
1964 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1965
1966         Remove "System Font" from whitelisted DRT fonts and char width calculations
1967         https://bugs.webkit.org/show_bug.cgi?id=131411
1968
1969         Reviewed by Tim Horton.
1970
1971         Covered by existing tests.
1972
1973         * DumpRenderTree/mac/DumpRenderTree.mm:
1974         (allowedFontFamilySet):
1975
1976 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1977
1978         systemHiddenFontFamilySet in DRT is unnecessary
1979         https://bugs.webkit.org/show_bug.cgi?id=131414
1980
1981         Reviewed by Tim Horton.
1982
1983         It doesn't seem to affect test results on my machine.
1984
1985         * DumpRenderTree/mac/DumpRenderTree.mm:
1986         (drt_NSFontManager_availableFonts):
1987         (systemHiddenFontFamilySet): Deleted.
1988
1989 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1990
1991         [Win] Unreviewed test fix: Don't double-release BSTR.
1992
1993         * DumpRenderTree/win/DumpRenderTree.cpp:
1994         (dump): Remove unneeded call to SysFreeString now that we are
1995         using _bstr_t for this variable.
1996
1997 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1998
1999         [Win] Various DumpRenderTree Fixes.
2000         https://bugs.webkit.org/show_bug.cgi?id=131446.
2001
2002         Reviewed by Tim Horton.
2003
2004         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2005         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2006         (AccessibilityUIElement::description): Ditto.
2007         (AccessibilityUIElement::helpText): Ditto.
2008         (AccessibilityUIElement::intValue): Ditto.
2009         (AccessibilityUIElement::isPressActionSupported): Ditto.
2010         (AccessibilityUIElement::accessibilityValue): Ditto.
2011         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2012         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2013         (DRTDesktopNotificationPresenter::AddRef): Ditto.
2014         (DRTDesktopNotificationPresenter::Release): Ditto.
2015         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2016         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
2017         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
2018         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
2019         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
2020         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2021         * DumpRenderTree/win/DumpRenderTree.cpp:
2022         (dumpFrameScrollPosition): Ditto.
2023         (dumpFramesAsText): Ditto.
2024         (compareHistoryItems): Ditto.
2025         (dumpHistoryItem): Ditto.
2026         (dump): Ditto.
2027         (resetDefaultsToConsistentValues): Ditto.
2028         (resetWebViewToConsistentStateBeforeTesting): Ditto.
2029         (runTest): Ditto.
2030         (createWebViewAndOffscreenWindow): Ditto.
2031         * DumpRenderTree/win/EditingDelegate.cpp:
2032         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2033         (EditingDelegate::AddRef): Ditto.
2034         (EditingDelegate::Release): Ditto.
2035         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
2036         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
2037         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2038         (EditingDelegate::shouldInsertNode): Ditto.
2039         (EditingDelegate::shouldInsertText): Ditto.
2040         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2041         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2042         (EditingDelegate::shouldApplyStyle): Ditto.
2043         (EditingDelegate::shouldChangeTypingStyle): Ditto.
2044         (EditingDelegate::doPlatformCommand): Ditto.
2045         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2046         (EditingDelegate::webViewDidChange): Ditto.
2047         (EditingDelegate::webViewDidEndEditing): Ditto.
2048         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
2049         (EditingDelegate::webViewDidChangeSelection): Ditto.
2050         (EditingDelegate::checkSpellingOfString): Ditto.
2051         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2052         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2053         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
2054         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2055         (FrameLoadDelegate::AddRef): Ditto.
2056         (FrameLoadDelegate::Release): Ditto.
2057         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2058         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
2059         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
2060         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
2061         (FrameLoadDelegate::didReceiveTitle): Ditto.
2062         (FrameLoadDelegate::didChangeIcons): Ditto.
2063         (delegatesWithDelayedWork): Ditto.
2064         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
2065         (FrameLoadDelegate::didFailLoadWithError): Ditto.
2066         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
2067         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
2068         (FrameLoadDelegate::willCloseFrame): Ditto.
2069         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
2070         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
2071         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2072         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
2073         (FrameLoadDelegate::didRunInsecureContent): Ditto.
2074         * DumpRenderTree/win/FrameLoadDelegate.h:
2075         * DumpRenderTree/win/HistoryDelegate.cpp:
2076         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2077         (HistoryDelegate::updateHistoryTitle): Ditto.
2078         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
2079         * DumpRenderTree/win/PolicyDelegate.cpp:
2080         (dumpPath):
2081         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2082         (PolicyDelegate::AddRef): Ditto.
2083         (PolicyDelegate::Release): Ditto.
2084         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2085         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
2086         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2087         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2088         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2089         (ResourceLoadDelegate::AddRef): Ditto.
2090         (ResourceLoadDelegate::Release): Ditto.
2091         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2092         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
2093         (ResourceLoadDelegate::willSendRequest): Ditto.
2094         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
2095         (ResourceLoadDelegate::didReceiveResponse): Ditto.
2096         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
2097         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
2098         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2099         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2100         (TestRunner::setUserStyleSheetLocation): Ditto.
2101         (TestRunner::execCommand): Ditto.
2102         (TestRunner::overridePreference): Ditto.
2103         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
2104         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
2105         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2106         (TextInputController::insertText): Ditto.
2107         * DumpRenderTree/win/UIDelegate.cpp:
2108         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2109         (UIDelegate::AddRef): Ditto.
2110         (UIDelegate::Release): Ditto.
2111         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2112         (UIDelegate::trackCustomPopupMenu): Ditto.
2113         (UIDelegate::registerUndoWithTarget): Ditto.
2114         (UIDelegate::removeAllActionsWithTarget): Ditto.
2115         (UIDelegate::setActionTitle): Ditto.
2116         (UIDelegate::undo): Ditto.
2117         (UIDelegate::redo): Ditto.
2118         (UIDelegate::canUndo): Ditto.
2119         (UIDelegate::canRedo): Ditto.
2120         (UIDelegate::printFrame): Ditto.
2121         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
2122         (UIDelegate::webViewHeaderHeight): Ditto.
2123         (UIDelegate::webViewFooterHeight): Ditto.
2124         (UIDelegate::drawHeaderInRect): Ditto.
2125         (UIDelegate::drawFooterInRect): Ditto.
2126         (UIDelegate::webViewPrintingMarginRect): Ditto.
2127         (UIDelegate::canRunModal): Ditto.
2128         (UIDelegate::createModalDialog): Ditto.
2129         (UIDelegate::runModal): Ditto.
2130         (UIDelegate::isMenuBarVisible): Ditto.
2131         (UIDelegate::setMenuBarVisible): Ditto.
2132         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
2133         (UIDelegate::paintCustomScrollbar): Ditto.
2134         (UIDelegate::paintCustomScrollCorner): Ditto.
2135         (UIDelegate::setFrame): Ditto.
2136         (UIDelegate::webViewFrame): Ditto.
2137         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
2138         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2139         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2140         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2141         (UIDelegate::webViewAddMessageToConsole): Ditto.
2142         (UIDelegate::doDragDrop): Ditto.
2143         (UIDelegate::webViewGetDlgCode): Ditto.
2144         (UIDelegate::createWebViewWithRequest): Ditto.
2145         (UIDelegate::webViewClose): Ditto.
2146         (UIDelegate::webViewFocus): Ditto.
2147         (UIDelegate::webViewUnfocus): Ditto.
2148         (UIDelegate::webViewPainted): Ditto.
2149         (UIDelegate::exceededDatabaseQuota): Ditto.
2150         (UIDelegate::embeddedViewWithArguments): Ditto.
2151         (UIDelegate::webViewClosing): Ditto.
2152         (UIDelegate::webViewSetCursor): Ditto.
2153         (UIDelegate::webViewDidInvalidate): Ditto.
2154         (UIDelegate::setStatusText): Ditto.
2155         (UIDelegate::desktopNotificationsDelegate): Ditto.
2156         (UIDelegate::drawBackground): Ditto.
2157         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
2158         (UIDelegate::didPressMissingPluginButton): Ditto.
2159         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
2160         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
2161         (LoadHTMLStringItem::invoke): Ditto.
2162         (ScriptItem::invoke): Ditto.
2163
2164 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
2165
2166         Stylechecker: False positive on inline asm code.
2167         https://bugs.webkit.org/show_bug.cgi?id=130570
2168
2169         Reviewed by Csaba Osztrogonác.
2170
2171         Disable stylechecking in asm blocks.
2172
2173         * Scripts/webkitpy/style/checkers/cpp.py:
2174         (process_line):
2175         (_InlineASMState):
2176         (_InlineASMState.__init__):
2177         (_InlineASMState.process_line):
2178         (_InlineASMState.isInside):
2179         (_process_lines):
2180         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2181         (WebKitStyleTest.test_member_initialization_list):
2182
2183 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2184
2185         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
2186         https://bugs.webkit.org/show_bug.cgi?id=131029
2187
2188         Reviewed by Philippe Normand.
2189
2190         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
2191         tests and remove the getWebKit1TestResoucesDir() method.
2192
2193         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2194         (testDownloadLocalFile): Use Test::getResourcesDir().
2195         (testDownloadLocalFileError): Ditto.
2196         (serverCallback): Ditto.
2197         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2198         (serverCallback): Ditto.
2199         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2200         (httpServerCallback): Ditto.
2201         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2202         (serverCallback): Ditto.
2203         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
2204         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
2205         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2206         (Test::getWebKit1TestResoucesDir): Deleted.
2207
2208 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
2209
2210         [WK2] HTTP authentication regression tests fail
2211         https://bugs.webkit.org/show_bug.cgi?id=81627
2212         <rdar://problem/11079296>
2213
2214         Reviewed by Anders Carlsson.
2215
2216         * WebKitTestRunner/TestController.h:
2217         * WebKitTestRunner/TestController.cpp:
2218         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
2219         to pageLoaderClient structure.
2220         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
2221         for password based authentication (we do get server trust challenges on some tests,
2222         which WKTR can't handle).
2223         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
2224         calls won't be made, at least on CFNetwork based platforms.
2225         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
2226         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
2227         make sense to associate auth requests with individual resources - there can be
2228         multiple resources loading at once from the same protection space, so WebKit1 API
2229         that had a resource identifier was inherently racy.
2230
2231 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
2232
2233         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
2234         https://bugs.webkit.org/show_bug.cgi?id=131427
2235
2236         Reviewed by Gyuyoung Kim.
2237
2238         Since r166973, font path was changed.
2239
2240         * DumpRenderTree/PlatformEfl.cmake:
2241         * WebKitTestRunner/PlatformEfl.cmake:
2242
2243 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2244
2245         Fix the build-jsc build
2246         https://bugs.webkit.org/show_bug.cgi?id=131410
2247
2248         Reviewed by Michael Saboff.
2249
2250         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
2251         WTF depends on it.
2252
2253 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2254
2255         [GTK] Remove WebKit1 unit tests
2256         https://bugs.webkit.org/show_bug.cgi?id=131359
2257
2258         Reviewed by Anders Carlsson.
2259
2260         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
2261         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
2262         they were inadvertently left in http://trac.webkit.org/changeset/166504.
2263
2264         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
2265         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
2266         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
2267         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
2268         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
2269         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
2270         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
2271         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
2272         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
2273         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
2274         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
2275         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
2276         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
2277         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
2278         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
2279         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
2280         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
2281         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
2282         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
2283         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
2284         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
2285         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
2286         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
2287         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
2288         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
2289         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
2290         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
2291         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
2292         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
2293         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
2294         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
2295         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
2296         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
2297         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
2298         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
2299         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
2300         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
2301         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
2302
2303 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2304
2305         Unreviewed gardening (Take 2): Prevent users from attempting
2306         to build with known invalid cURL. 
2307
2308         * Scripts/webkitdirs.pm:
2309         (checkInstalledTools): Check for 7.34.0 (the broken version), not
2310         7.33.0 (the known good version).
2311
2312 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2313
2314         [GTK] Remove DumpRenderTree and GtkLauncher
2315         https://bugs.webkit.org/show_bug.cgi?id=131373
2316
2317         Reviewed by Andreas Kling.
2318
2319         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
2320         no longer necessary now that WebKit1 GTK+ will be removed.
2321
2322         * CMakeLists.txt:
2323         * DumpRenderTree/PlatformGTK.cmake: Removed.
2324         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
2325         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
2326         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
2327         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
2328         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
2329         * DumpRenderTree/gtk/EventSender.cpp: Removed.
2330         * DumpRenderTree/gtk/EventSender.h: Removed.
2331         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
2332         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
2333         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
2334         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
2335         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
2336         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
2337         * DumpRenderTree/gtk/TextInputController.h: Removed.
2338         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
2339         * GtkLauncher/CMakeLists.txt: Removed.
2340         * GtkLauncher/LauncherInspectorWindow.c: Removed.
2341         * GtkLauncher/LauncherInspectorWindow.h: Removed.
2342         * GtkLauncher/main.c: Removed.
2343         * GtkLauncher/simple.svg: Removed.
2344         * GtkLauncher/text.html: Removed.
2345         * WebKitTestRunner/PlatformGTK.cmake:
2346         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
2347         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
2348         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
2349
2350 2014-04-08  Mark Rowe  <mrowe@apple.com>
2351
2352         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
2353         <https://webkit.org/b/131388> / <rdar://problem/16291687>
2354
2355         Reviewed by Alexey Proskuryakov.
2356
2357         * Scripts/webkitdirs.pm:
2358         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
2359         (execMacWebKitAppForDebugging): Ditto.
2360
2361 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2362
2363         Build bmalloc on iOS too
2364         https://bugs.webkit.org/show_bug.cgi?id=131381
2365
2366         Reviewed by Andreas Kling.
2367
2368         * Scripts/build-webkit:
2369
2370 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2371
2372         Unreviewed gardening: Prevent users from attempting
2373         to build with known invalid cURL.
2374
2375         * Scripts/webkitdirs.pm:
2376         (checkInstalledTools): Block build attempts with bad
2377         Cygwin tool set.
2378
2379 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
2380
2381         Build bmalloc on Mac
2382         https://bugs.webkit.org/show_bug.cgi?id=131333
2383
2384         Reviewed by Mark Rowe.
2385
2386         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
2387         (Note: Just testing Mac is not good enough because in this
2388         script 'Mac' means 'Mac or iOS'.)
2389
2390 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
2391
2392         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
2393         https://bugs.webkit.org/show_bug.cgi?id=130951
2394
2395         Reviewed by Geoffrey Garen.
2396
2397         * Scripts/run-javascriptcore-tests:
2398
2399 2014-04-06  Darin Adler  <darin@apple.com>
2400
2401         Rework CSS calc logic, fixing some reference count mistakes in Length
2402         https://bugs.webkit.org/show_bug.cgi?id=131280
2403
2404         Reviewed by Andreas Kling.
2405
2406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
2407         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
2408
2409 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
2410
2411         Enable WEB_REPLAY for PLATFORM(MAC)
2412         https://bugs.webkit.org/show_bug.cgi?id=130700
2413
2414         Reviewed by Timothy Hatcher.
2415
2416         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
2417
2418 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2419
2420         [CMake] Include X11's include dirs in TestNetscapePlugin
2421         https://bugs.webkit.org/show_bug.cgi?id=131270
2422
2423         Reviewed by Martin Robinson.
2424
2425         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
2426         TestNetscapePlugin includes WebCore code that includes X headers.
2427
2428 2014-04-05  David Kilzer  <ddkilzer@apple.com>
2429
2430         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
2431         <http://webkit.org/b/130986>
2432
2433         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
2434         prefix to TileCache class names in exception list.
2435
2436 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2437
2438         [GTK] kill-old-processes should kill dbus-daemon processes
2439         https://bugs.webkit.org/show_bug.cgi?id=127352
2440
2441         Reviewed by Martin Robinson.
2442
2443         * BuildSlaveSupport/kill-old-processes:
2444         (main):
2445
2446 2014-04-04  Andres Gomez  <agomez@igalia.com>
2447
2448         [Win] Update obsolete packages in cygwin
2449         https://bugs.webkit.org/show_bug.cgi?id=126264
2450
2451         Reviewed by Brent Fulgham.
2452
2453         Removed "apache" and "minires" as the first has been replaced by
2454         "lighttpd" and the second is now integrated into
2455         "cygwin". Replaced the transitional and now obsolete "gcc" package
2456         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
2457         since the newer version available is "2.7.3" which breaks the
2458         build due to some funniness with environment variable handling.
2459
2460         * CygwinDownloader/cygwin-downloader.py:
2461         * CygwinDownloader/cygwin-downloader.zip:
2462
2463 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
2464
2465         check-webkit-style: Improve warnings on Objective-C @property syntax
2466         https://bugs.webkit.org/show_bug.cgi?id=131200
2467
2468         Reviewed by Dan Bernstein.
2469
2470         * Scripts/webkitpy/style/checkers/cpp.py:
2471         (check_spacing):
2472         (CppChecker):
2473         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2474         (CppStyleTest.test_spacing_in_objective_c_properties):
2475
2476 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2477
2478         Unreviewed. Moving my name to commiter section
2479
2480         * Scripts/webkitpy/common/config/contributors.json:
2481
2482 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2483
2484         Unreviewed. Add myself as a committer.
2485
2486         * Scripts/webkitpy/common/config/contributors.json:
2487
2488 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
2489
2490         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
2491         https://bugs.webkit.org/show_bug.cgi?id=130391
2492
2493         Reviewed by Gyuyoung Kim.
2494
2495         Change the implementation of the zoom functionality from ewk_view_scale_set
2496         to ewk_view_page_zoom_set.
2497
2498         * MiniBrowser/efl/main.c:
2499
2500 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2501
2502         [webkitpy] perf profiler does not understand --call-graph argument
2503         https://bugs.webkit.org/show_bug.cgi?id=131132
2504
2505         Reviewed by Ryosuke Niwa.
2506
2507         New versions of perf profiler have changed the argument from --call-graph to -g.
2508
2509         * Scripts/webkitpy/common/system/profiler.py:
2510         (Perf.wrapper_arguments): Use -g instead of --call-graph.
2511         * Scripts/webkitpy/port/driver_unittest.py:
2512         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
2513
2514 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2515
2516         Add EFL WK2 performance bot to build.webkit.org
2517         https://bugs.webkit.org/show_bug.cgi?id=131034
2518
2519         Fix after r166707, use "Perf" instead of "perf" for consistency.
2520
2521         Reviewed by Csaba Osztrogonác.
2522
2523         * BuildSlaveSupport/build.webkit.org-config/config.json:
2524
2525 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2526
2527         Add EFL WK2 performance bot to build.webkit.org
2528         https://bugs.webkit.org/show_bug.cgi?id=131034
2529
2530         Reviewed by Csaba Osztrogonác.
2531
2532         * BuildSlaveSupport/build.webkit.org-config/config.json:
2533
2534 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
2535
2536         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
2537         https://bugs.webkit.org/show_bug.cgi?id=131151
2538
2539         Reviewed by Gyuyoung Kim.
2540
2541         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
2542         (TouchEventInfo::TouchEventInfo):
2543         (sendTouchEvent):
2544         (addTouchPointCallback):
2545         (updateTouchPointCallback):
2546         (cancelTouchPointCallback):
2547         (releaseTouchPointCallback):
2548
2549 2014-04-02  David Kilzer  <ddkilzer@apple.com>
2550
2551         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
2552         <http://webkit.org/b/131045>
2553
2554         Reviewed by Daniel Bates.
2555
2556         * Scripts/filter-build-webkit:
2557         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
2558         of clang, plus debug data for all DVTAssertions.
2559
2560 2014-04-01  Dean Jackson  <dino@apple.com>
2561
2562         Load Media Controls js/css from bundle
2563         https://bugs.webkit.org/show_bug.cgi?id=131086
2564
2565         Reviewed by Eric Carlson.
2566
2567         We're now putting CSS files into the bundle, so remove the test for them.
2568
2569         * Scripts/check-for-inappropriate-files-in-framework:
2570
2571 2014-04-02  Martin Hock  <mhock@apple.com>
2572
2573         Unify private browsing with sessions.
2574         https://bugs.webkit.org/show_bug.cgi?id=130099
2575
2576         Reviewed by Alexey Proskuryakov.
2577
2578         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
2579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2580         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2581         (TestWebKitAPI::didNavigateWithNavigationData):
2582         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2583         (TestWebKitAPI::TEST):
2584
2585         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
2586         (TestWebKitAPI::didNavigateWithoutNavigationData):
2587         (TestWebKitAPI::didNavigateWithNavigationData):
2588         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2589         (TestWebKitAPI::TEST):
2590
2591 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
2592
2593         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
2594         https://bugs.webkit.org/show_bug.cgi?id=130343
2595
2596         Reviewed by Gustavo Noronha Silva.
2597
2598         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
2599         of directories on the command line and look for all appropriate files in those directories for the
2600         GResource archive. Also make archive paths relative to those directories.
2601         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
2602         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
2603
2604 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2605
2606         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
2607         https://bugs.webkit.org/show_bug.cgi?id=131106
2608
2609         Reviewed by Csaba Osztrogonác.
2610
2611         * Scripts/webkitpy/tool/commands/download.py:
2612         (AbstractRolloutPrepCommand._prepare_state):
2613         * Scripts/webkitpy/tool/commands/download_unittest.py:
2614         (test_prepare_rollout):
2615         (test_create_rollout):
2616         (test_create_rollout_resolved):
2617         (test_rollout):
2618
2619 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
2620
2621         [EFL] Add option to use separate web process for new window in MiniBrowser
2622         https://bugs.webkit.org/show_bug.cgi?id=130190
2623
2624         Reviewed by Gyuyoung Kim.
2625
2626         New created window (CTRL + n) will be open in separated web process.
2627         This option is enabled by adding a flag (S/separate-process) with launching
2628         MiniBrowser.
2629
2630         * MiniBrowser/efl/main.c:
2631         (elm_main):
2632
2633 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2634
2635         [GTK] Move NEWS file to a new location
2636         https://bugs.webkit.org/show_bug.cgi?id=130901
2637
2638         Reviewed by Brent Fulgham.
2639
2640         * gtk/manifest.txt: Update the NEWS file path.
2641
2642 2014-04-01  Anders Carlsson  <andersca@apple.com>
2643
2644         Fix build.
2645
2646         * MiniBrowser/mac/WK2BrowserWindowController.m:
2647         (-[WK2BrowserWindowController awakeFromNib]):
2648         (-[WK2BrowserWindowController dealloc]):
2649         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2650
2651 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
2652
2653         Unreviewed test gardening.
2654
2655         * Scripts/webkitpy/port/base_unittest.py:
2656         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
2657
2658 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
2659
2660         [CSS Exclusions] Remove exclusions parsing support
2661         https://bugs.webkit.org/show_bug.cgi?id=131046
2662
2663         Reviewed by David Hyatt.
2664
2665         * Scripts/webkitperl/FeatureList.pm:
2666
2667 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2668
2669         [GTK] Remove last reference to GTK+ WK1 EWS
2670         https://bugs.webkit.org/show_bug.cgi?id=131058
2671
2672         Reviewed by Martin Robinson.
2673
2674         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
2675
2676         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
2677
2678 2014-04-01  Lucas Forschler  <lforschler@apple.com>
2679
2680         Add a 32bit JSC builder/tester.
2681         https://bugs.webkit.org/show_bug.cgi?id=131054
2682         
2683         Reviewed by Michael Saboff.
2684
2685         * BuildSlaveSupport/build.webkit.org-config/config.json:
2686         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2687         (Compile32bitJSC):
2688         (Run32bitJSCTests):
2689         (Run32bitJSCTests.countFailures):
2690         (BuildAndTest32bitJSCFactory):
2691         (BuildAndTest32bitJSCFactory.__init__):
2692
2693 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
2694
2695         [GTK] No longer build WebKit1 gtkdoc
2696         https://bugs.webkit.org/show_bug.cgi?id=130970
2697
2698         Reviewed by Anders Carlsson.
2699
2700         * gtk/common.py:
2701         (gtk_version_of_pkg_config_file): Deleted.
2702         * gtk/generate-gtkdoc:
2703         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
2704         was only applicable for WebKit1.
2705         (get_generator_for_config): No longer look for the WebKit1 configuration file.
2706
2707 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
2708
2709         [GTK] Running minibrowser with url crashes in debug build
2710         https://bugs.webkit.org/show_bug.cgi?id=130492
2711
2712         Reviewed by Martin Robinson.
2713
2714         Update "uri-scheme" test not to use invalid URIs in it, so we
2715         don't get a mistmatch when comparing the original URI stored in
2716         the test class with the one returned by the WebKitWebView.
2717
2718         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2719         (testWebContextURIScheme): Update the test.
2720
2721 2014-04-01  Mihai Tica  <mitica@adobe.com>
2722
2723         Unreviewed: Add myself as a commiter to the contributors list.
2724
2725         * Scripts/webkitpy/common/config/contributors.json:
2726
2727 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2728
2729         [EFL][WK2] Extract the control of page background out of color_set
2730         https://bugs.webkit.org/show_bug.cgi?id=127539
2731
2732         Reviewed by Gyuyoung Kim.
2733
2734         Added an option(C) to change background color.
2735
2736         * MiniBrowser/efl/main.c:
2737         (window_create):
2738         (elm_main):
2739
2740 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2741
2742         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
2743
2744         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
2745
2746 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2747
2748         Unreviewed test correction after r166530.
2749
2750         * DumpRenderTree/mac/DumpRenderTree.mm:
2751         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
2752         fine-grained setting for swipe tests. This prevents existing tests from breaking.
2753
2754 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2755
2756         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
2757         https://bugs.webkit.org/show_bug.cgi?id=130987
2758
2759         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
2760         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
2761
2762         Reviewed by Martin Robinson.
2763
2764         * BuildSlaveSupport/build.webkit.org-config/config.json:
2765
2766 2014-03-31  Dean Jackson  <dino@apple.com>
2767
2768         Remove WEB_ANIMATIONS
2769         https://bugs.webkit.org/show_bug.cgi?id=130989
2770
2771         Reviewed by Simon Fraser.
2772
2773         Remove this feature flag until we plan to implement.
2774
2775         * Scripts/webkitperl/FeatureList.pm:
2776
2777 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2778
2779         Reduced Latched Scroll Test Flakiness
2780         https://bugs.webkit.org/show_bug.cgi?id=130983
2781
2782         Reviewed by Darin Adler.
2783
2784         * DumpRenderTree/mac/DumpRenderTree.mm:
2785         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
2786         * DumpRenderTree/mac/EventSendingController.mm:
2787         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
2788         with high resolution flags turned on.
2789         * WebKitTestRunner/mac/EventSenderProxy.mm:
2790         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2791
2792 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2793
2794         run-webkit-tests should have a --no-timeout option
2795         https://bugs.webkit.org/show_bug.cgi?id=128286
2796
2797         Reviewed by Joseph Pecoraro.
2798
2799         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2800         (Worker._run_test): Renaming _run_test_with_timeout()
2801         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
2802         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
2803         (Worker._run_test_in_this_thread):
2804         (Worker._run_test_with_timeout): Deleted.
2805         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2806         (parse_args): Added the --no-timeout option
2807
2808 2014-03-31  Samuel White  <samuel_white@apple.com>
2809
2810         AX: Need ability to get line range for text marker.
2811         https://bugs.webkit.org/show_bug.cgi?id=130906
2812
2813         Reviewed by Chris Fleizach.
2814
2815         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2816
2817         * DumpRenderTree/AccessibilityUIElement.cpp:
2818         (lineTextMarkerRangeForTextMarkerCallback):
2819         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2820         (AccessibilityUIElement::getJSClass):
2821         * DumpRenderTree/AccessibilityUIElement.h:
2822         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2823         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2824         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2825         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2826         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2827         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2828         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2829         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2830         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2831         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2832         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2833         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2834
2835 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2836
2837         More validation for FTL inline caches
2838         https://bugs.webkit.org/show_bug.cgi?id=130948
2839
2840         Reviewed by Geoffrey Garen.
2841
2842         * Scripts/run-jsc-stress-tests:
2843
2844 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2845
2846         [GTK] Do not run WebKit1 unit tests by default
2847         https://bugs.webkit.org/show_bug.cgi?id=130968
2848
2849         Reviewed by Martin Robinson.
2850
2851         * Scripts/run-gtk-tests:
2852         (TestRunner):
2853
2854 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2855
2856         [GTK] Remove scripts code only applicable to autotools
2857         https://bugs.webkit.org/show_bug.cgi?id=130841
2858
2859         Reviewed by Anders Carlsson.
2860
2861         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2862         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2863         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2864         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2865         * gtk/find-make-dist-errors: Removed.
2866         * gtk/generate-feature-defines-files: Removed.
2867         * gtk/manifest.txt: No longer need to consider autotools files.
2868
2869 2014-03-30  Andy Estes  <aestes@apple.com>
2870
2871         Fix two failing layout tests on Mountain Lion after r166466.
2872
2873         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2874         (-[DownloadDelegate _downloadDidStart:]):
2875
2876 2014-03-30  Andy Estes  <aestes@apple.com>
2877
2878         [Cocoa] Add an originatingWebView property to _WKDownload
2879         https://bugs.webkit.org/show_bug.cgi?id=130945
2880
2881         Reviewed by Anders Carlsson.
2882
2883         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2884         (-[DownloadDelegate _downloadDidStart:]):
2885         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2886         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2887         (TEST):
2888
2889 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2890
2891         Land the stackmap register liveness glue with the uses of the liveness disabled
2892         https://bugs.webkit.org/show_bug.cgi?id=130924
2893
2894         Reviewed by Oliver Hunt.
2895
2896         * Scripts/run-jsc-stress-tests:
2897
2898 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2899
2900         Update WebKit1.StringTruncator for Mountain Lion.
2901
2902         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2903         due to different font metrics on 10.8.
2904
2905 2014-03-28  Darin Adler  <darin@apple.com>
2906
2907         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2908         https://bugs.webkit.org/show_bug.cgi?id=130889
2909
2910         Reviewed by Alexey Proskuryakov.
2911
2912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2913         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2914         WebStringTruncator methods; should be good for a start. These are dependent on the
2915         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2916
2917 2014-03-28  Martin Hock  <mhock@apple.com>
2918
2919         Unreviewed. Add myself as a committer.
2920
2921         * Scripts/webkitpy/common/config/contributors.json:
2922
2923 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2924
2925         Remove WebKit1 GTK+ bots
2926         https://bugs.webkit.org/show_bug.cgi?id=130904
2927
2928         Reviewed by Anders Carlsson.
2929
2930         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2931         all bots are testing WebKit2 only.
2932         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2933         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2934         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2935         * Scripts/webkitpy/port/builders.py: Ditto.
2936         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2937         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2938
2939 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2940
2941         Remove Brian Burg's apple.com email address.
2942
2943         * Scripts/webkitpy/common/config/contributors.json:
2944
2945 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2946
2947         bisect-builds should print Trac 'changeset' URL if only one build is detected
2948         <http://webkit.org/b/130903>
2949
2950         Reviewed by Dan Bernstein.
2951
2952         * Scripts/bisect-builds:
2953         (printTracLink): Print a direct link to the Trac 'changeset'
2954         URL if there is only one revision in the range.
2955
2956 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2957
2958         [EFL] Bump glib version from 2.36 to 2.38 
2959         https://bugs.webkit.org/show_bug.cgi?id=130886
2960
2961         Reviewed by Csaba Osztrogonác.
2962
2963         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2964         we need to bump glib version up to 2.38 as gtk port.
2965
2966         * efl/jhbuild.modules:
2967
2968 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2969
2970         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2971
2972         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2973         the globalhistory directory.
2974
2975         Reviewed by Sam Weinig.
2976
2977         * WebKitTestRunner/TestController.cpp:
2978         (WTR::TestController::TestController):
2979         (WTR::TestController::initialize): Set the history client.
2980         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2981         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2982         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2983         and we don't yet have API to access the data in question.
2984         (WTR::TestController::didPerformClientRedirect):
2985         (WTR::TestController::didPerformServerRedirect):
2986         (WTR::TestController::didUpdateHistoryTitle):
2987         * WebKitTestRunner/TestController.h:
2988         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2989         * WebKitTestRunner/TestInvocation.cpp:
2990         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2991         (WTR::TestInvocation::invoke):
2992
2993 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2994
2995         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2996
2997         * Scripts/build-webkit:
2998         * Scripts/copy-webkitlibraries-to-product-directory:
2999
3000 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
3001
3002         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
3003         https://bugs.webkit.org/show_bug.cgi?id=130867
3004         <rdar://problem/16432456> 
3005
3006         Reviewed by Mark Hahnenberg.
3007
3008         * Scripts/build-webkit:
3009         * Scripts/copy-webkitlibraries-to-product-directory:
3010
3011 2014-03-26  Andy Estes  <aestes@apple.com>
3012
3013         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
3014         https://bugs.webkit.org/show_bug.cgi?id=130805
3015
3016         Reviewed by Dan Bernstein.
3017
3018         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3019         (-[DownloadDelegate _download:didReceiveResponse:]):
3020         (-[DownloadDelegate _downloadDidFinish:]):
3021         (runTest):
3022         (TEST):
3023         (-[FailingDownloadDelegate _downloadDidFinish:]):
3024         (-[FailingDownloadDelegate _download:didFailWithError:]):
3025         (-[FailingDownloadDelegate _downloadDidCancel:]):
3026         (-[CancelledDownloadDelegate _downloadDidStart:]):
3027         (-[CancelledDownloadDelegate _downloadDidFinish:]):
3028         (-[CancelledDownloadDelegate _download:didFailWithError:]):
3029         (-[CancelledDownloadDelegate _downloadDidCancel:]):
3030         (-[DownloadDelegate initWithSourceURL:]): Deleted.
3031         (-[DownloadDelegate sourceURL]): Deleted.
3032         (runTestWithNavigationDelegate): Deleted.
3033
3034 2014-03-26  Anders Carlsson  <andersca@apple.com>
3035
3036         Change MiniBrowser to hold on to window controllers instead of windows
3037         https://bugs.webkit.org/show_bug.cgi?id=130797
3038
3039         Reviewed by Oliver Hunt.
3040
3041         * MiniBrowser/mac/AppDelegate.h:
3042         * MiniBrowser/mac/AppDelegate.m:
3043         (-[BrowserAppDelegate init]):
3044         (-[BrowserAppDelegate newWindow:]):
3045         (-[BrowserAppDelegate browserWindowWillClose:]):
3046         (-[BrowserAppDelegate applicationWillTerminate:]):
3047         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3048
3049 2014-03-26  Commit Queue  <commit-queue@webkit.org>
3050
3051         Unreviewed, rolling out r166264.
3052         https://bugs.webkit.org/show_bug.cgi?id=130785
3053
3054         Broke some window.opener tests for WK2 Mavericks (Requested by
3055         brrian__ on #webkit).
3056
3057         Reverted changeset:
3058
3059         "Web Replay: resource unique identifiers should be unique-per-
3060         frame, not globally"
3061         https://bugs.webkit.org/show_bug.cgi?id=130632
3062         http://trac.webkit.org/changeset/166264
3063
3064 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
3065
3066         [CSS Shapes] Remove shape-inside support
3067         https://bugs.webkit.org/show_bug.cgi?id=130698
3068
3069         Reviewed by David Hyatt.
3070
3071         * Scripts/webkitperl/FeatureList.pm:
3072
3073 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
3074
3075         Unreviewed. Add myself as a committer.
3076
3077         * Scripts/webkitpy/common/config/contributors.json:
3078
3079 2014-03-26  Tomas Popela  <tpopela@redhat.com>
3080
3081         run-launcher is Perl script so use elsif and not elif
3082         https://bugs.webkit.org/show_bug.cgi?id=130771
3083
3084         Reviewed by Carlos Garcia Campos.
3085
3086         * Scripts/run-launcher:
3087
3088 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
3089
3090         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
3091         https://bugs.webkit.org/show_bug.cgi?id=130575
3092
3093         Reviewed by Mario Sanchez Prada.
3094
3095         Change ATK version to 2.11.92. Adjust current implementation.
3096
3097         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3098         (AccessibilityUIElement::intValue):
3099         (AccessibilityUIElement::minValue):
3100         (AccessibilityUIElement::maxValue):
3101         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3102         (WTR::AccessibilityUIElement::intValue):
3103         (WTR::AccessibilityUIElement::minValue):
3104         (WTR::AccessibilityUIElement::maxValue):
3105         * efl/jhbuild.modules:
3106         * gtk/jhbuild.modules:
3107
3108 2014-03-12  Philippe Normand  <pnormand@igalia.com>
3109
3110         [GTK] The gnumake package is no longer needed in jhbuild
3111         https://bugs.webkit.org/show_bug.cgi?id=130121
3112
3113         Reviewed by Martin Robinson.
3114
3115         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
3116         for a debug build cmake/system-gnumake worked just fine for me.
3117
3118         * gtk/jhbuild.modules: Removed gnumake.
3119         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
3120         * gtk/patches/make-3.82-parallel-build.patch: Removed.
3121
3122 2014-03-25  Andy Estes  <aestes@apple.com>
3123
3124         Fix a failing API test on Mountain Lion and remove temporary debug logging.
3125
3126         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3127         (-[DownloadDelegate _download:didReceiveData:]):
3128         (-[DownloadDelegate _downloadDidFinish:]):
3129
3130 2014-03-25  Brian Burg  <bburg@apple.com>
3131
3132         Web Replay: resource unique identifiers should be unique-per-frame, not globally
3133         https://bugs.webkit.org/show_bug.cgi?id=130623
3134
3135         Reviewed by Timothy Hatcher.
3136
3137         The resource loader callback dumping routines assumed that resource identifiers
3138         were globally unique. Its map of resource identifiers to URLs must also track the
3139         frame associated with the resource.
3140
3141         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3142         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
3143         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
3144         stable as long as the frame is valid.
3145         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3146         (WTR::InjectedBundlePage::willSendRequestForFrame):
3147         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3148         (WTR::InjectedBundlePage::didFinishLoadForResource):
3149         (WTR::InjectedBundlePage::didFailLoadForResource):
3150
3151 2014-03-25  Andy Estes  <aestes@apple.com>
3152
3153         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
3154
3155         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3156         (-[DownloadDelegate _download:didReceiveResponse:]):
3157         (-[DownloadDelegate _download:didReceiveData:]):
3158
3159 2014-03-25  Andy Estes  <aestes@apple.com>
3160
3161         Add some debug logging to an API test that's failing on Mountain Lion.
3162
3163         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3164         (-[DownloadDelegate _download:didReceiveResponse:]):
3165         (-[DownloadDelegate _downloadDidFinish:]):
3166
3167 2014-03-25  Anders Carlsson  <andersca@apple.com>
3168
3169         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
3170         https://bugs.webkit.org/show_bug.cgi?id=130732
3171
3172         Reviewed by Tim Horton.
3173
3174         * MiniBrowser/mac/WK2BrowserWindowController.m:
3175         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3176
3177 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
3178
3179         [GTK] Remove the autotools build
3180         https://bugs.webkit.org/show_bug.cgi?id=130717
3181
3182         Reviewed by Anders Carlsson.
3183
3184         * DumpRenderTree/config.h: Remove references to the autotools configure file.
3185         * GNUmakefile.am: Removed.
3186         * GtkLauncher/GNUmakefile.am: Removed.
3187         * GtkLauncher/main.c: Remove references to the autotools configure file.
3188         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
3189         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
3190         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
3191         * MiniBrowser/gtk/GNUmakefile.am: Removed.
3192         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
3193         * Scripts/build-webkit: No longer handle autotools.
3194         * Scripts/run-gtk-tests: Ditto.
3195         (TestRunner._setup_testing_environment):
3196         * Scripts/run-launcher: Ditto.
3197         * Scripts/webkitdirs.pm: Ditto.
3198         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
3199         * Scripts/webkitpy/common/config/contributors.json: Ditto.
3200         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
3201         * Scripts/webkitpy/style/checker.py:
3202         * TestWebKitAPI/GNUmakefile.am: Removed.
3203         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
3204         * WebKitTestRunner/GNUmakefile.am: Removed.
3205         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
3206         * gtk/GNUmakefile.am: Removed.
3207         * gtk/common.py: Remove checks for the autotools build.
3208         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
3209
3210 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
3211
3212         prepare-ChangeLog throws false positive warnings for modified files.
3213         https://bugs.webkit.org/show_bug.cgi?id=130687
3214
3215         Reviewed by Darin Adler.
3216
3217         * Scripts/prepare-ChangeLog:
3218         (originalFile): Ignore git commit paremeter.
3219         We don't need this to get the unmodified file.
3220         (extractLineRangeBeforeChange):
3221         Simplify the if statement. Follow-up after r166189.
3222
3223 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
3224
3225         [EFL] Add ARM64 build support
3226         https://bugs.webkit.org/show_bug.cgi?id=130506
3227
3228         Rubber stamped by Gyuyoung Kim.
3229
3230         * Scripts/webkitdirs.pm:
3231         (isARM): Detect aarch64 as ARM.
3232
3233 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3234
3235         [webkitpy] Improve _parse_bug_description to recognize more descriptions
3236         https://bugs.webkit.org/show_bug.cgi?id=130137
3237
3238         Reviewed by Csaba Osztrogonác.
3239
3240         * Scripts/webkitpy/common/checkout/changelog.py:
3241         (ChangeLogEntry._parse_bug_description):
3242         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3243         (test_parse_log_entries_from_changelog):
3244         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3245         (CheckoutTest.test_commit_info_for_revision):
3246
3247 2014-03-24  Andy Estes  <aestes@apple.com>
3248
3249         Fix the iOS build of TestWebKitAPI.
3250
3251         * TestWebKitAPI/Configurations/Base.xcconfig:
3252         * TestWebKitAPI/PlatformUtilities.h:
3253
3254 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3255
3256         Fix prepare-ChangeLog after r166156.
3257         https://bugs.webkit.org/show_bug.cgi?id=130674
3258
3259         Reviewed by Darin Adler.
3260
3261         * Scripts/prepare-ChangeLog:
3262         (generateFunctionLists):
3263         (extractLineRangeBeforeChange):
3264
3265 2014-03-24  Andy Estes  <aestes@apple.com>
3266
3267         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
3268         https://bugs.webkit.org/show_bug.cgi?id=129322
3269
3270         Reviewed by Anders Carlsson.
3271
3272         Add an API test suite for _WKDownload.
3273
3274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3275         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
3276         (-[DownloadDelegate initWithSourceURL:]):
3277         (-[DownloadDelegate sourceURL]):
3278         (-[DownloadDelegate _downloadDidStart:]):
3279         (-[DownloadDelegate _download:didReceiveResponse:]):
3280         (-[DownloadDelegate _download:didReceiveData:]):
3281         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3282         (-[DownloadDelegate _downloadDidFinish:]):
3283         (TEST):
3284         (runTestWithNavigationDelegate):
3285         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3286         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3287
3288 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
3289
3290         filter-build-webkit: reduce unfiltered output
3291         https://bugs.webkit.org/show_bug.cgi?id=130485
3292
3293         Reviewed by Brent Fulgham.
3294
3295         * Scripts/filter-build-webkit:
3296         (shouldIgnoreLine):
3297
3298 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3299
3300         prepare-ChangeLog should list functions that have been removed too.
3301         https://bugs.webkit.org/show_bug.cgi?id=130508
3302
3303         Reviewed by Darin Adler.
3304
3305         The prepare-ChangeLog does not list the deleted functions in the Changelog.
3306         We have to read the functions and the line ranges of them from the source
3307         before the change, then search for overlaps between them and the changed
3308         line ranges from diff.
3309
3310         * Scripts/prepare-ChangeLog:
3311         (originalFile): Get original source command.
3312         (generateFunctionLists): Collect deleted functions too.
3313         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
3314         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
3315         deleted functions ranges too.
3316         (extractLineRange): Renamed to extractLineRangeAfterChange.
3317
3318 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
3319
3320         Move all EFL typedefs into EflTypedefs.h.
3321         https://bugs.webkit.org/show_bug.cgi?id=130511
3322
3323         Reviewed by Gyuyoung Kim.
3324
3325         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
3326         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
3327         * WebKitTestRunner/PlatformWebView.h: Ditto.
3328
3329 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
3330
3331         Don't flush compositing layers within FrameView::willPaintContents()
3332         https://bugs.webkit.org/show_bug.cgi?id=130627
3333         <rdar://problem/16368869>
3334
3335         Reviewed by Sam Weinig.
3336         
3337         Fix DRT to correctly render tests with layers now that FrameView::paintContents
3338         does not flush.
3339         
3340         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
3341         into an explicit function called before dumping. 
3342         
3343         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
3344         are flushed to CA. They will be pushed to the window by snapshotting.
3345
3346         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3347         Fix weird path to IOKit.framework.
3348         * DumpRenderTree/mac/DumpRenderTree.mm:
3349         (updateDisplay):
3350         (dump):
3351         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3352         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
3353         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
3354
3355 2014-03-21  David Kilzer  <ddkilzer@apple.com>
3356
3357         fix-blink-patch: tool to fix up renamed directory paths in Blink
3358         <http://webkit.org/b/130609>
3359
3360         Reviewed by Ryosuke Niwa.
3361
3362         Usage: cat blink.patch | fix-blink-patch | svn-apply
3363
3364         * Scripts/fix-blink-patch: Added.
3365
3366 2014-03-21  Darin Adler  <darin@apple.com>
3367
3368         Remove use of deprecatedCharacters in WebKit API tests
3369         https://bugs.webkit.org/show_bug.cgi?id=130602
3370
3371         Reviewed by Antti Koivisto.
3372
3373         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3374         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
3375         (TestWebKitAPI::expectEmpty): Use characters8.
3376         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
3377
3378         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3379         Removed the test that is entirely about 16-bit conversion since that's basically a test of
3380         the deprecatedCharacters function itself, which we are about to delete.
3381
3382 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3383
3384         [webkitpy] Fix has_valid_reviewer()
3385         https://bugs.webkit.org/show_bug.cgi?id=130589
3386
3387         Reviewed by Csaba Osztrogonác.
3388
3389         * Scripts/webkitpy/common/checkout/changelog.py:
3390         (ChangeLogEntry.has_valid_reviewer):
3391         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3392         (test_has_valid_reviewer):
3393         * Scripts/webkitpy/common/config/committers.py:
3394         (CommitterList._reviewer_only):
3395         (CommitterList.committer_by_name):
3396         (CommitterList.reviewer_by_email):
3397         (CommitterList):
3398         (CommitterList.reviewer_by_name):
3399
3400 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3401
3402         Add cache support for jhbuild
3403         https://bugs.webkit.org/show_bug.cgi?id=130588
3404
3405         Reviewed by Csaba Osztrogonác.
3406
3407         * jhbuild/jhbuildrc_common.py:
3408         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
3409
3410 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3411
3412         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
3413         https://bugs.webkit.org/show_bug.cgi?id=130504
3414
3415         Reviewed by Martin Robinson.
3416
3417         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
3418         CMake if not specified.
3419         * Scripts/webkitdirs.pm:
3420         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
3421         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
3422
3423 2014-03-21  Andreas Kling  <akling@apple.com>
3424
3425         RetainPtr API test should use CFArray instead of CFString for testing.
3426         <rdar://problem/16384899>
3427
3428         Unreviewed bot fix.
3429
3430         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3431         (TestWebKitAPI::TEST):
3432         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3433         (TestWebKitAPI::TEST):
3434
3435 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
3436
3437         Move to using std::unique_ptr for EFL objects.
3438         https://bugs.webkit.org/show_bug.cgi?id=129853
3439
3440         Reviewed by Gyuyoung Kim.
3441
3442         EflUniquePtr is a template alias of std::unique_ptr
3443         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
3444         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
3445
3446         * DumpRenderTree/efl/DumpRenderTree.cpp:
3447         (main):
3448         * ImageDiff/efl/ImageDiff.cpp:
3449         (initEfl):
3450         (main):
3451
3452 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
3453
3454         Unreviewed buildfix after r165983 for non Cocoa platforms
3455
3456         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
3457
3458         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
3459         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3460         * WebKitTestRunner/TestController.cpp:
3461
3462 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
3463
3464         [GTK][CMake] Add support for building with Clang
3465         https://bugs.webkit.org/show_bug.cgi?id=130260
3466
3467         Reviewed by Martin Robinson.
3468
3469         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
3470         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
3471         included GTest framework headers.
3472         * gtk/generate-gtkdoc:
3473         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
3474         in case of using Clang since that is now set by the CMake rule.
3475
3476 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
3477
3478         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
3479         https://bugs.webkit.org/show_bug.cgi?id=130476
3480
3481         Reviewed by Anders Carlsson.
3482         
3483         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
3484
3485         * MiniBrowser/mac/WK1BrowserWindowController.m:
3486         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3487         Remove log.
3488         * MiniBrowser/mac/WK2BrowserWindowController.m:
3489         (-[WK2BrowserWindowController awakeFromNib]):
3490         (-[WK2BrowserWindowController validateMenuItem:]):
3491         (-[WK2BrowserWindowController reload:]):
3492         Hook up reload.
3493         (-[WK2BrowserWindowController toggleZoomMode:]):
3494         (-[WK2BrowserWindowController resetZoom:]):
3495         (-[WK2BrowserWindowController canResetZoom]):
3496         (-[WK2BrowserWindowController currentZoomFactor]):
3497         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3498         (-[WK2BrowserWindowController canZoomIn]):
3499         (-[WK2BrowserWindowController canZoomOut]):
3500
3501 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
3502
3503         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
3504         https://bugs.webkit.org/show_bug.cgi?id=130463
3505
3506         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
3507
3508 2014-03-18  Samuel White  <samuel_white@apple.com>
3509
3510         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
3511         https://bugs.webkit.org/show_bug.cgi?id=130250
3512
3513         Reviewed by Chris Fleizach.
3514
3515         Added ability to toggle enhanced accessibility on and off to support tests that require it.
3516
3517         * DumpRenderTree/AccessibilityController.cpp:
3518         (enableEnhancedAccessibilityCallback):
3519         (getEnhancedAccessibilityEnabledCallback):
3520         (AccessibilityController::getJSClass):
3521         * DumpRenderTree/AccessibilityController.h:
3522         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3523         (AccessibilityController::enableEnhancedAccessibility):
3524         (AccessibilityController::enhancedAccessibilityEnabled):
3525         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3526         (AccessibilityController::enableEnhancedAccessibility):
3527         (AccessibilityController::enhancedAccessibilityEnabled):
3528         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3529         (AccessibilityController::enableEnhancedAccessibility):
3530         (AccessibilityController::enhancedAccessibilityEnabled):
3531         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3532         (AccessibilityController::enableEnhancedAccessibility):
3533         (AccessibilityController::enhancedAccessibilityEnabled):
3534         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3535         (WTR::AccessibilityController::enableEnhancedAccessibility):
3536         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
3537         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3538         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3539
3540 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
3541
3542         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
3543         yet).
3544
3545         * Scripts/webkitpy/common/config/contributors.json:
3546
3547 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3548
3549         Web Inspector: Remove stale ReportMemoryUsagePlugin
3550         https://bugs.webkit.org/show_bug.cgi?id=130405
3551
3552         Reviewed by Andreas Kling.
3553
3554         This clang plugin looks like it was used for the old Inspector memory
3555         instrumentation that was removed. So the tool can be removed.
3556
3557         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
3558         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
3559         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
3560         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
3561
3562 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3563
3564         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
3565         https://bugs.webkit.org/show_bug.cgi?id=130220
3566
3567         Reviewed by Csaba Osztrogonác.
3568
3569         * Scripts/webkitpy/common/checkout/changelog.py:
3570         (ChangeLog.set_reviewer):
3571         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3572         (test_set_reviewer):
3573
3574 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
3575
3576         More FTL enabling.
3577
3578         Rubber stamped by Dan Bernstein.
3579
3580         * Tools/Scripts/build-webkit:
3581
3582 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3583
3584         Renable pagination mode in WK2 MiniBrowser
3585         https://bugs.webkit.org/show_bug.cgi?id=130374
3586
3587         Reviewed by Anders Carlsson.
3588         
3589         Put the implementation of togglePaginationMode: back, and correctly
3590         enable the menu item.
3591
3592         * MiniBrowser/mac/WK2BrowserWindowController.m:
3593         (-[WK2BrowserWindowController validateMenuItem:]):
3594         (-[WK2BrowserWindowController isPaginated]):
3595         (-[WK2BrowserWindowController togglePaginationMode:]):
3596
3597 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3598
3599         Add --reset option to Tools/Scripts/set-webkit-configuration script
3600         https://bugs.webkit.org/show_bug.cgi?id=130401
3601
3602         Reviewed by Csaba Osztrogonác.
3603
3604         * Scripts/set-webkit-configuration:
3605
3606 2014-03-18  Alberto Garcia  <berto@igalia.com>
3607
3608         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
3609         https://bugs.webkit.org/show_bug.cgi?id=130388
3610
3611         Reviewed by Sergio Villar Senin.
3612
3613         * Scripts/webkitdirs.pm:
3614         (shouldRemoveCMakeCache): make sure that the build directory
3615         exists before attempting to create a file in it.
3616
3617 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
3618
3619         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
3620         https://bugs.webkit.org/show_bug.cgi?id=130336
3621
3622         Reviewed by Gyuyoung Kim.
3623
3624         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
3625         requires a space between literal and string macro [-Wliteral-suffix]'
3626         warning treated as error.
3627
3628         This patch applies a solution from r162448 to the EFL port.
3629
3630         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3631         * efl/jhbuild.modules: Added appropriate patch section.
3632
3633 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3634
3635         webkitpy test rebaseline.
3636
3637         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3638         (MainTest.test_default_args):
3639
3640 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3641
3642         --profile should imply --test-runner-count=1 in run-perf-tests
3643         https://bugs.webkit.org/show_bug.cgi?id=130375
3644
3645         Reviewed by Benjamin Poulain.
3646
3647         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
3648
3649         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3650         (PerfTestsRunner._parse_args): Use -1 as the default value.
3651         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
3652         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
3653         should be 1.
3654
3655 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3656
3657         Address some style nits.
3658
3659         * MiniBrowser/mac/WK2BrowserWindowController.m:
3660
3661 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3662
3663         Add transparent window support&nb