Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
[WebKit-https.git] / Tools / ChangeLog
1 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
4
5         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
6         (BenchmarkResults._lint_subtest_results):
7         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
8         (test_aggregate_nested_results):
9         (test_lint_results):
10         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
11
12 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
13
14         run-benchmark should print out the results
15         https://bugs.webkit.org/show_bug.cgi?id=145398
16
17         Reviewed by Antti Koivisto.
18
19         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
20         of the output to catch early errors.
21
22         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
23         (BenchmarkResults): Added.
24         (BenchmarkResults.__init__): Added.
25         (BenchmarkResults.format): Added.
26         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
27         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
28         Uses the sample standard deviation to compute the significant figures for the value.
29         (BenchmarkResults._unit_from_metric): Added.
30         (BenchmarkResults._aggregate_results): Added.
31         (BenchmarkResults._aggregate_results_for_test): Added.
32         (BenchmarkResults._flatten_list): Added.
33         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
34         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
35         (BenchmarkResults._aggregate_values): Added.
36         (BenchmarkResults._lint_results): Added.
37         (BenchmarkResults._lint_subtest_results): Added.
38         (BenchmarkResults._lint_aggregator_list): Added.
39         (BenchmarkResults._lint_configuration): Added.
40         (BenchmarkResults._lint_values): Added.
41         (BenchmarkResults._is_numeric): Added.
42         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
43         (BenchmarkResultsTest):
44         (BenchmarkResultsTest.test_init):
45         (BenchmarkResultsTest.test_format):
46         (test_format_values_with_large_error):
47         (test_format_values_with_small_error):
48         (test_format_values_with_time):
49         (test_format_values_with_no_error):
50         (test_format_values_with_small_difference):
51         (test_aggregate_results):
52         (test_aggregate_results_with_gropus):
53         (test_aggregate_nested_results):
54         (test_lint_results):
55         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
56         (BenchmarkRunner.execute): Added a call to show_results
57         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
58         (BenchmarkRunner.show_results): Added.
59
60 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
61
62         run_benchmark should have an option to specify the number of runs
63         https://bugs.webkit.org/show_bug.cgi?id=145091
64
65         Reviewed by Antti Koivisto.
66
67         Added --count option.
68
69         * Scripts/run-benchmark:
70         (main):
71         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
72         (BenchmarkRunner.__init__):
73
74 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
75
76         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
77
78         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
79
80 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
81
82         Update results of WebKit1.StringTruncator after r184965.
83
84         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
85
86 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
87
88         Unreviewed, updated my list of email addresses.
89
90         * Scripts/webkitpy/common/config/contributors.json:
91
92 2015-05-27  Dean Jackson  <dino@apple.com>
93
94         img.currentSrc problem in strict mode with old picturefill
95         https://bugs.webkit.org/show_bug.cgi?id=144095
96         <rdar://problem/21087013>
97
98         Reviewed by Simon Fraser.
99
100         Add a PICTURE_SIZES flag.
101
102         * Scripts/webkitperl/FeatureList.pm:
103
104 2015-05-26  Dana Burkart  <dburkart@apple.com>
105
106         Fixes compatibility issues with recent dashboard cleanup.
107         https://bugs.webkit.org/show_bug.cgi?id=144814
108
109         Reviewed by Alexey Proskuryakov.
110
111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
112         (BuildbotStaticAnalyzerQueueView):
113         (BuildbotStaticAnalyzerQueueView.prototype.update):
114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
115         (documentReady):
116
117 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
118
119         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
120         https://bugs.webkit.org/show_bug.cgi?id=143091
121         rdar://problem/19330328
122
123         Reviewed by Darin Adler and Timothy Hatcher.
124
125         We have many of these, which are hard to fit on the dashboard. Added a view that
126         collapses to a single green bubble when everything is good, and expands when there
127         are failures (or manually).
128
129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
130
131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
132         (Buildbot.prototype.set isAuthenticated):
133         (Buildbot.prototype._normalizeQueueInfo):
134         (Buildbot.prototype._normalizeQueuesInfo):
135         (Buildbot.prototype.updateQueues):
136         Moved queue info normalization here from BuildbitQueue. The latter is a model class
137         that shouldn't have to know about presentation, and this lets us leep the knowledge
138         about combined queues out if it. Later, we can refactor existing code, and move out
139         all knowledge about headings and such.
140
141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
142         Added the new view. It's not quite universal, and doesn't have as helpful popovers
143         as other views, but we can extend it when/if we use it for more than JSC.
144
145         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
146         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
147
148         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
149         (documentReady): Added support for combined queues. These are currently always ending up
150         in Other column, but it's easy to customize in the future if we need to.
151
152         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
153         (WebKitBuildbot): Added JSC queus.
154
155         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
156         (.combined-queue-popover):
157         (.combined-queue-popover .revision):
158         Added styles for the combined view.
159
160 2015-05-26  Dan Bernstein  <mitz@apple.com>
161
162         Changed a file to use Unix line endings.
163
164         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
165
166 2015-05-26  Dan Bernstein  <mitz@apple.com>
167
168         <rdar://problem/21104551> Update build settings
169
170         Reviewed by Anders Carlsson.
171
172         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
173         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
174         * MiniBrowser/Configurations/DebugRelease.xcconfig:
175         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
176         * WebEditingTester/Configurations/DebugRelease.xcconfig:
177         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
178         * asan/asan.xcconfig:
179
180 2015-05-26  Anders Carlsson  <andersca@apple.com>
181
182         Fix build.
183
184         * WebKitTestRunner/mac/EventSenderProxy.mm:
185         (WTR::EventSenderProxy::mouseForceDown):
186         (WTR::EventSenderProxy::mouseForceUp):
187         (WTR::EventSenderProxy::mouseForceChanged):
188
189 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
190
191         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
192         https://bugs.webkit.org/show_bug.cgi?id=145342
193
194         Reviewed by Darin Adler.
195
196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
197         (BuildbotIteration.prototype._parseData):
198
199 2015-05-26  Milan Crha  <mcrha@redhat.com>
200
201         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
202         https://bugs.webkit.org/show_bug.cgi?id=138134
203
204         Reviewed by Žan Doberšek.
205
206         * gtk/generate-inspector-gresource-manifest.py:
207         (get_filenames): Command line with expanded resources exceeds 32KB, which
208         is a limit on Windows. It's better to expand wildcards inside the python script.
209
210 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
211
212         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
213         https://bugs.webkit.org/show_bug.cgi?id=140882
214
215         Reviewed by Gustavo Noronha Silva.
216
217         Make sure unit tests write IndexedDB databases to the temporary
218         directory, and add a test case to check that the directory is
219         correctly created at the expected path.
220
221         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
222         (testWebContextConfiguration):
223         (serverCallback):
224         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
225         (Test::Test):
226
227 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
228
229         [GTK] Enable IndexedDB
230         https://bugs.webkit.org/show_bug.cgi?id=98932
231
232         Reviewed by Žan Doberšek.
233
234         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
235
236 2015-05-24  Sam Weinig  <sam@webkit.org>
237
238         Crash when using a removed ScriptMessageHandler
239         <rdar://problem/20888499>
240         https://bugs.webkit.org/show_bug.cgi?id=145359
241
242         Reviewed by Dan Bernstein.
243
244         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
245         Add tests for removing script message handlers.
246
247 2015-05-23  Dan Bernstein  <mitz@apple.com>
248
249         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
250         https://bugs.webkit.org/show_bug.cgi?id=145345
251
252         Reviewed by Sam Weinig.
253
254         * DumpRenderTree/mac/Configurations/Base.xcconfig:
255         * LayoutTestRelay/Configurations/Base.xcconfig:
256         * TestWebKitAPI/Configurations/Base.xcconfig:
257         * WebKitTestRunner/Configurations/Base.xcconfig:
258
259 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
260
261         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
262         https://bugs.webkit.org/show_bug.cgi?id=144848
263
264         Reviewed by Darin Adler.
265
266         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
267
268         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
269
270 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
271
272         Fix one more merge error in static analyzer support.
273
274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
275         (BuildbotStaticAnalyzerQueueView):
276
277 2015-05-22  Dana Burkart  <dburkart@apple.com>
278
279         Fix internal dashboard breakage from recent commit.
280         https://bugs.webkit.org/show_bug.cgi?id=144814
281
282         Unreviewed build fix.
283
284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
285         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
286         (BuildbotStaticAnalyzerQueueView.prototype.update):
287
288 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
289
290         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
291         https://bugs.webkit.org/show_bug.cgi?id=130463
292         rdar://problem/20461342
293
294         Reviewed by Tim Horton.
295
296         This was more of a timing related flakiness than an actual OS version specific bug,
297         we weren't getting window visibility notifications.
298         
299         I will look into adding this function call to DumpRenderTree separately, layout tests
300         might actually rely on the broken behavior.
301
302         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
303         (TestWebKitAPI::TEST_F):
304         * TestWebKitAPI/mac/mainMac.mm:
305         (main):
306
307 2015-05-22  Dana Burkart  <dburkart@apple.com>
308
309         Add missing file from r184804 (mis-applied diff).
310         https://bugs.webkit.org/show_bug.cgi?id=144814
311
312         Reviewed by Alexey Proskuryakov.
313
314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
315         (BuildbotStaticAnalyzerQueueView):
316         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
317         (BuildbotStaticAnalyzerQueueView.prototype.update):
318
319 2015-05-22  Dana Burkart  <dburkart@apple.com>
320
321         Add support to the botwatchers dashboard for a static analyzer bot.
322         https://bugs.webkit.org/show_bug.cgi?id=144814
323
324         Reviewed by Alexey Proskuryakov.
325
326         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
327         scan-build should be considered a productive step.
328
329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
330         (BuildbotQueue):
331         Adds support for the staticAnalyzer property
332
333         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
334         (BuildbotTestResults.prototype._parseResults):
335         Get bug count from the scan-build step output
336
337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
338         (documentReady):
339         Rename the performance column 'Other', and merge the current 'Other' column with it.
340
341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
342         (WebKitBuildbot):
343         Now that performance bots are part of the 'Other' column, give them better headings.
344
345 2015-05-22  Tim Horton  <timothy_horton@apple.com>
346
347         Turn on autosaving of toolbar configuration in MiniBrowser
348
349         Rubber-stamped by Dan Bernstein.
350
351         * MiniBrowser/mac/BrowserWindow.xib:
352
353 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
354
355         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
356         https://bugs.webkit.org/show_bug.cgi?id=145297
357
358         Reviewed by Tim Horton.
359
360         This is a refactoring to simplify code, and to make it more logical.
361
362         It is up to the view to decide how to present the queues, and whether to split
363         them into debug and release, or in some different way.
364
365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
366         (BuildbotBuilderQueueView.filterQueues):
367         (BuildbotBuilderQueueView):
368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
369         (BuildbotLeaksQueueView):
370         (BuildbotLeaksQueueView.prototype.update):
371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
372         (BuildbotPerformanceQueueView):
373         (BuildbotPerformanceQueueView.prototype.update):
374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
375         (BuildbotQueueView):
376         (BuildbotQueueView.prototype._updateQueues):
377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
378         (BuildbotTesterQueueView):
379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
380         (documentReady):
381
382 2015-05-22  Tim Horton  <timothy_horton@apple.com>
383
384         Remove action menu support
385         https://bugs.webkit.org/show_bug.cgi?id=145305
386         <rdar://problem/21070771>
387
388         Reviewed by Anders Carlsson.
389
390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
391         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
392         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
393         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
394         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
395         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
396         Remove the tests.
397
398 2015-05-22  Dan Bernstein  <mitz@apple.com>
399
400         Removed the Use Shrink To Fit button from the toolbar’s default set.
401
402         Rubber-stamped by Tim Horton.
403
404         * MiniBrowser/mac/BrowserWindow.xib:
405
406 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
407
408         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
409         https://bugs.webkit.org/show_bug.cgi?id=128420
410
411         Reviewed by Chris Fleizach.
412
413         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
414         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
415
416 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
417
418         [EFL] Bump libsoup version to 2.50.0
419         https://bugs.webkit.org/show_bug.cgi?id=145127
420
421         Reviewed by Gyuyoung Kim.
422
423         * efl/jhbuild.modules:
424         * efl/patches/soup-clang-warning-fix1.patch: Removed.
425         * efl/patches/soup-clang-warning-fix2.patch: Removed.
426
427 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
428
429         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
430         https://bugs.webkit.org/show_bug.cgi?id=145117
431
432         Reviewed by Csaba Osztrogonác.
433
434         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
435         Tools/TestWebKitAPI/Tests/WTF/glib/.
436
437         * TestWebKitAPI/PlatformGTK.cmake:
438         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
439         (TestWebKitAPI::TEST):
440
441 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
442
443         [EFL] fix efreet error
444         https://bugs.webkit.org/show_bug.cgi?id=143670
445
446         Reviewed by Gyuyoung Kim.
447
448         Fix efreet error by using external variable efreet_cache_update.
449         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
450         efreet error for efreet_cache does not occur.
451
452         * MiniBrowser/efl/main.c:
453         (elm_main):
454
455 2015-05-20  Michael Saboff  <msaboff@apple.com>
456
457         Add option to run_jsc_stress_tests to disable JIT testing
458         https://bugs.webkit.org/show_bug.cgi?id=145233
459
460         Reviewed by Mark Lam.
461
462         Added --no-jit option.
463
464         * Scripts/run-jsc-stress-tests:
465
466 2015-05-20  Alex Christensen  <achristensen@webkit.org>
467
468         Use correct String for StringView in WTF API tests
469         https://bugs.webkit.org/show_bug.cgi?id=145226
470         rdar://problem/20361786
471
472         Reviewed by Benjamin Poulain.
473
474         * TestWebKitAPI/Tests/WTF/StringView.cpp:
475         (TestWebKitAPI::TEST):
476         Use patternHolder for pattern.
477
478 2015-05-20  Alex Christensen  <achristensen@webkit.org>
479
480         [Content Extensions] Relax restrictions on triggers that match everything.
481         https://bugs.webkit.org/show_bug.cgi?id=145069
482
483         Reviewed by Benjamin Poulain.
484
485         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
486         (TestWebKitAPI::TEST_F):
487         Update and add tests for new possibilities with .*
488
489 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
490
491         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
492         https://bugs.webkit.org/show_bug.cgi?id=144992
493
494         Reviewed by Gyuyoung Kim.
495
496         * MiniBrowser/efl/main.c:
497         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
498         (on_key_down):
499         (on_fullscreen_enter):
500         (on_fullscreen_exit):
501         (window_create):
502
503 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
504
505         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
506         https://bugs.webkit.org/show_bug.cgi?id=145109
507
508         Reviewed by Darin Adler.
509
510         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
511         (TestWebKitAPI::TEST):
512
513 2015-05-19  Anders Carlsson  <andersca@apple.com>
514
515         Add alternate menu items for performing operations on the default data store
516         https://bugs.webkit.org/show_bug.cgi?id=145184
517
518         Reviewed by Sam Weinig.
519
520         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
521         associated with a data store.
522
523         * MiniBrowser/mac/AppDelegate.m:
524         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
525         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
526         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
527         * MiniBrowser/mac/MainMenu.xib:
528
529 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
530
531         Fix tautological-compare warning in AtomicString.cpp
532         https://bugs.webkit.org/show_bug.cgi?id=145120
533
534         Reviewed by Alexey Proskuryakov.
535
536         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
537         (TestWebKitAPI::TEST): Removed always true assert.
538
539 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
540
541         [EFL] Fix unsequenced warning in MiniBrowser's main.c
542         https://bugs.webkit.org/show_bug.cgi?id=145123
543
544         Reviewed by Gyuyoung Kim.
545
546         * MiniBrowser/efl/main.c:
547         (on_key_down):
548
549 2015-05-18  Daniel Bates  <dabates@apple.com>
550
551         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
552         when staged non-empty file for commit
553         https://bugs.webkit.org/show_bug.cgi?id=145082
554
555         Reviewed by Darin Adler.
556
557         Fixes two issues when running prepare-ChangeLog:
558             1. The function above a deleted function is reported as changed.
559             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
560             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
561             included in this patch).
562
563         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
564         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
565         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
566         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
567         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
568         VCSUtil::parseChunkRange() has existing test coverage.
569
570         * Scripts/prepare-ChangeLog:
571         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
572         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
573         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
574         examine files that only have deletions. Currently this works as a side effect of the behavior of
575         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
576         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
577         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
578         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
579         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
580         We return (-1, -1) when the change represents a deletion.
581         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
582         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
583         We return (-1, -1) when the change represents an addition.
584         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
585         unit tests.
586
587 2015-05-18  Anders Carlsson  <andersca@apple.com>
588
589         Add ATS keys to MiniBrowser
590         https://bugs.webkit.org/show_bug.cgi?id=145141
591
592         Reviewed by Sam Weinig.
593
594         * MiniBrowser/mac/Info.plist:
595
596 2015-05-17  David Kilzer  <ddkilzer@apple.com>
597
598         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
599         <http://webkit.org/b/145100>
600
601         Reviewed by Darin Adler.
602
603         * Scripts/bisect-builds:
604         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
605         - Switch to using PROMPT_RESPONSE_* constants when testing the
606           value of $didReproduceBug.
607         - Add do { } while loops to implement 'retry' mode.
608         (promptForTest):
609         - Switch to returning PROMPT_RESPONSE_* constants.
610         - Add support for 'retry' response.
611
612 2015-05-16  Tanay C  <tanay.c@samsung.com>
613
614         [EFL][WK2] Minibrowser : Add search icon to search bar
615         https://bugs.webkit.org/show_bug.cgi?id=139773
616
617         Reviewed by Gyuyoung Kim.
618
619         * MiniBrowser/efl/main.c: 
620         (search_icon_show): Added.
621         (search_box_show): Modified.
622
623 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
624
625         run_benchmark should have an option to specify the number of runs
626         https://bugs.webkit.org/show_bug.cgi?id=145091
627
628         Reviewed by Stephanie Lewis.
629
630         Added --count option.
631
632         * Scripts/run-benchmark:
633         (main):
634         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
635         (BenchmarkRunner.__init__):
636
637 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
638
639         Temporarily disable failing API test.
640
641         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
642         (TestWebKitAPI::TEST):
643
644 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
645
646         User interruption while running of run-webkit-tests should also generate results.html
647         https://bugs.webkit.org/show_bug.cgi?id=122154
648
649         Reviewed by Csaba Osztrogonác.
650
651         Generation of results.html on execution of run-webkit-tests happens only
652         on completion of entire layout tests run. It should be created even when
653         the execution has been interrupted - either by user (by pressing Ctrl+C)
654         or because of other interruptions (like exit-after-n-failures option).
655
656         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
657         (LayoutTestRunner.run_tests):
658         * Scripts/webkitpy/layout_tests/controllers/manager.py:
659         (Manager.run):
660         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
661         (TestRunResults.__init__):
662         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
663         (main):
664         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
665         (RunTest.test_keyboard_interrupt):
666         (MainTest.test_exception_handling):
667
668 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
669
670         [buildbot] Fix the URL of the performance bots
671         https://bugs.webkit.org/show_bug.cgi?id=145043
672
673         Reviewed by Ryosuke Niwa.
674
675         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
676
677 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
678
679         Add a layout mode that scales down the view to try to fit the document
680         https://bugs.webkit.org/show_bug.cgi?id=145022
681         <rdar://problem/19790341>
682
683         Reviewed by Dean Jackson.
684
685         * MiniBrowser/mac/BrowserWindow.xib:
686         * MiniBrowser/mac/BrowserWindowController.h:
687         * MiniBrowser/mac/WK2BrowserWindowController.m:
688         (-[WK2BrowserWindowController toggleShrinkToFit:]):
689         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
690         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
691
692 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
693
694         [CMake] Don't read the LOCATION property of targets
695         https://bugs.webkit.org/show_bug.cgi?id=145018
696
697         Reviewed by Martin Robinson.
698
699         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
700         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
701         be the same at configure-time as it is at generate-time.
702
703         * TestWebKitAPI/CMakeLists.txt:
704
705 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
706
707         Add String literal overloads to equalIgnoringASCIICase()
708         https://bugs.webkit.org/show_bug.cgi?id=145008
709
710         Reviewed by Benjamin Poulain.
711
712         Test changes to WTF.
713
714         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
715         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
716         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
717         * TestWebKitAPI/Tests/WTF/StringView.cpp:
718         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
719         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
720
721 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
722
723         SharedBuffer::createWithContentsOfFile should use map file routines
724         https://bugs.webkit.org/show_bug.cgi?id=144192
725
726         Reviewed by Darin Adler.
727
728         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
729
730         * TestWebKitAPI/PlatformGTK.cmake:
731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
732         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
733         (TestWebKitAPI::FileSystemTest::tempFilePath):
734         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
735         (TestWebKitAPI::TEST_F):
736         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
737         (TestWebKitAPI::SharedBufferTest::tempFilePath):
738         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
739         (TestWebKitAPI::TEST_F):
740
741 2015-05-13  Alex Christensen  <achristensen@webkit.org>
742
743         [Content Extensions] Test interactions between multiple extensions and multiple domains.
744         https://bugs.webkit.org/show_bug.cgi?id=144967
745
746         Reviewed by Benjamin Poulain.
747
748         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
749         Xcode wanted to fix an alphabetization issue.
750         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
751         (TestWebKitAPI::TEST_F):
752         Test interactions that worked but were not explicitly tested before.
753
754 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
755
756         Unreviewed build fix.
757
758         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
759
760         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
761
762 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
763
764         Fix the previous commit, which made both bubbles green.
765
766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
767         (.status-line.good .bubble):
768         (.status-line.bad .bubble):
769         (.status-line.good .message):
770
771 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
772
773         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
774         https://bugs.webkit.org/show_bug.cgi?id=144929
775
776         Reviewed by Eric Carlson.
777
778         Tweaked colors as I see fit.
779
780         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
781         (.status-line.good .bubble):
782         (.status-line.bad .bubble):
783
784 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
785
786         [Mac] Share cookie storage between UI process and secondary processes
787         https://bugs.webkit.org/show_bug.cgi?id=144820
788         rdar://problem/20572830
789
790         Reviewed by Darin Adler.
791
792         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
793         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
794         for testing.
795
796 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
797
798         Fix internal build configuration issues
799         https://bugs.webkit.org/show_bug.cgi?id=144762
800
801         Reviewed by David Kilzer.
802
803         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
804
805         * DumpRenderTree/mac/Configurations/Base.xcconfig:
806         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
807         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
808         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
809         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
810         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
811         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
812         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
813
814 2015-05-12  David Kilzer  <ddkilzer@apple.com>
815
816         Switch to launching iOS Simulator using bundle ID
817         <rdar://problem/20916096>
818
819         This is required to fix the layout tests on internal bots.
820
821         * Scripts/webkitdirs.pm:
822         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
823         Simulator.  Add FIXME.
824         (quitIOSSimulator): Add FIXME.
825         * Scripts/webkitpy/port/ios.py:
826         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
827         launch iOS Simulator.  Add FIXME.
828         (IOSSimulatorPort.check_sys_deps): Add FIXME.
829
830 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
831
832         Fix run-javascriptcore-tests step on the WinCairo bot
833         https://bugs.webkit.org/show_bug.cgi?id=144866
834
835         Reviewed by Csaba Osztrogonác.
836
837         Catch exception when failing to create soft link, so we can fall back to copy.
838
839         * Scripts/run-jsc-stress-tests:
840
841 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
842
843         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
844         https://bugs.webkit.org/show_bug.cgi?id=116971
845
846         Reviewed by Chris Fleizach.
847
848         Implement rowAtIndex for ATK.
849
850         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
851         (WTR::AccessibilityUIElement::rowAtIndex):
852
853 2015-05-11  Dan Bernstein  <mitz@apple.com>
854
855         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
856
857         Reviewed by Alexey Proskuryakov.
858
859         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
860         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
861         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
862         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
863
864 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
865
866         Fix internal build configuration issues
867         https://bugs.webkit.org/show_bug.cgi?id=144762
868
869         Reviewed by Darin Adler.
870
871         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
872
873         * TestWebKitAPI/Configurations/Base.xcconfig:
874         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
875         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
876         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
877         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
878         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
879         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
880
881 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
882
883         [Win] Move Windows build target to Windows 7 (or newer)
884         https://bugs.webkit.org/show_bug.cgi?id=144890
885         <rdar://problem/20707307>
886
887         Reviewed by Anders Carlsson.
888
889         Update linked SDK and minimal Windows level to be compatible with
890         Windows 7 or newer.
891
892         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
893         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
894         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
895         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
896         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
897         * DumpRenderTree/config.h:
898         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
899         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
900         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
901         * WinLauncher/stdafx.h:
902
903 2015-05-11  Commit Queue  <commit-queue@webkit.org>
904
905         Unreviewed, rolling out r184119.
906         https://bugs.webkit.org/show_bug.cgi?id=144888
907
908         broke JSC tests on Apple Windows bots (Requested by kling on
909         #webkit).
910
911         Reverted changeset:
912
913         "Fix run-javascriptcore-tests step on the WinCairo bot"
914         https://bugs.webkit.org/show_bug.cgi?id=144866
915         http://trac.webkit.org/changeset/184119
916
917 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
918
919         run-benchmark should support Dromaeo
920         https://bugs.webkit.org/show_bug.cgi?id=144849
921
922         Reviewed by Chris Dumez.
923
924         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
925         they can take as much as 15 minutes to run each.
926
927         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
928         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
929         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
930         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
931
932 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
933
934         Build fix. jetstream has a local copy, not remote archive.
935
936         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
937
938 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
939
940         run-benchmark should support SunSpider, Kraken and Octane
941         https://bugs.webkit.org/show_bug.cgi?id=144840
942
943         Reviewed by Darin Adler.
944
945         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
946         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
947         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
948         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
949
950         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
951         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
952
953         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
954         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
955
956         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
957         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
958         now has the ability to run an arbitrary "create script".
959
960         * Scripts/run-benchmark:
961         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
962         This also overrides the remote archive URL specified in the plan.
963
964         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
965
966         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
967         JetStreamBenchmarkBuilder.
968
969         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
970         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
971         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
972         _runCreateScript and _applyPatch to clean after themselves.
973         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
974         JetStream, SunSpider, Kraken all use this feature.
975         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
976         the leaf directory name since the latter is not available when a remote ZIP file is used.
977         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
978         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
979         the benchmark name in the patches.
980
981         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
982
983         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
984         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
985         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
986         the browser opens by planName as the plan file no longer contains that.
987
988         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
989         the top directory of JetStream instead of its parent.
990         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
991         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
992         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
993         the top directory of JetStream instead of its parent.
994         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
995         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
996         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
997         done in JetStream.patch.
998         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
999         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
1000         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
1001         path from the top directory of JetStream as done in JetStream.patch.
1002         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
1003
1004 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
1005
1006         Fix run-javascriptcore-tests step on the WinCairo bot
1007         https://bugs.webkit.org/show_bug.cgi?id=144866
1008
1009         Reviewed by Darin Adler.
1010
1011         * Scripts/run-jsc-stress-tests:
1012
1013 2015-05-11  Alex Christensen  <achristensen@webkit.org>
1014
1015         [Content Extensions] Support domain-specific rules and exceptions.
1016         https://bugs.webkit.org/show_bug.cgi?id=144833
1017
1018         Reviewed by Darin Adler.
1019
1020         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1021         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1022         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1023         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1024         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
1025         (TestWebKitAPI::mainDocumentRequest):
1026         (TestWebKitAPI::subResourceRequest):
1027         (TestWebKitAPI::TEST_F):
1028         (TestWebKitAPI::checkCompilerError):
1029         Added tests for parsing and functionality of if-domain and unless-domain.
1030
1031 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1032
1033         run-benchmark should support Chrome Canary and Firefox Nightly
1034         https://bugs.webkit.org/show_bug.cgi?id=144850
1035
1036         Reviewed by Darin Adler.
1037
1038         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
1039
1040         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
1041
1042         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
1043         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
1044         (OSXBrowserDriver):
1045         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
1046         (OSXBrowserDriver.closeBrowsers): Ditto.
1047         (OSXBrowserDriver.launchProcess): Ditto.
1048         (OSXBrowserDriver.terminateProcesses): Ditto.
1049         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1050         (OSXChromeDriver): Removed the unused self.chromePreferences.
1051         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
1052         (OSXChromeDriver.closeBrowsers): Ditto.
1053         (OSXChromeDriver.launchUrl):
1054         (OSXChromeCanaryDriver): Added.
1055         (OSXChromeCanaryDriver.launchUrl):
1056         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
1057         (OSXFirefoxDriver): Added.
1058         (OSXFirefoxDriver.launchUrl):
1059         (OSXFirefoxNightlyDriver): Added.
1060         (OSXFirefoxNightlyDriver.launchUrl):
1061         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1062         (OSXSafariDriver):
1063         (OSXSafariDriver.closeBrowsers):
1064
1065 2015-05-11  Tim Horton  <timothy_horton@apple.com>
1066
1067         Page overlay action context override should indicate the source of the request
1068         https://bugs.webkit.org/show_bug.cgi?id=144832
1069         <rdar://problem/20562594>
1070
1071         Reviewed by Darin Adler.
1072
1073         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
1074         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
1075
1076 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
1077
1078         [GTK] fast/events/page-visibility-transition-test.html is timing out
1079         https://bugs.webkit.org/show_bug.cgi?id=114789
1080
1081         Reviewed by Darin Adler.
1082
1083         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1084         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
1085         requests visibility changes.
1086
1087 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
1088
1089         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
1090         https://bugs.webkit.org/show_bug.cgi?id=144798
1091
1092         Reviewed by Darin Adler.
1093
1094         * efl/install-dependencies:
1095
1096 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
1097
1098         Make arguments of run-benchmark more user friendly
1099         https://bugs.webkit.org/show_bug.cgi?id=144835
1100
1101         Reviewed by Darin Adler.
1102
1103         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
1104         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
1105         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
1106         default values from --platform and --browser as they are required arguments.
1107
1108         * Scripts/run-benchmark:
1109         (main): Made --build-directory optional, and removed default values from --platform and --browser.
1110         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
1111         are not dynamically obtained via BrowserDriverFactory.
1112         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1113         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
1114         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
1115         run any benchmark in that case.
1116         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
1117         the specified file isn't a valid relative or an absolute path.
1118         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
1119         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
1120         and browsers.
1121         (BrowserDriverFactory.available_browsers): Ditto.
1122         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1123         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
1124         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
1125         browserBuildPath was None.
1126         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1127         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
1128         so that we can use locally built WebKit to launch Safari.
1129
1130 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
1131
1132         Remove the PICTURE_SIZES build flag
1133         https://bugs.webkit.org/show_bug.cgi?id=144679
1134
1135         Reviewed by Benjamin Poulain.
1136
1137         Removed the PICTURE_SIZES build time flag.
1138
1139         * Scripts/webkitperl/FeatureList.pm:
1140
1141 2015-05-09  David Kilzer  <ddkilzer@apple.com>
1142
1143         Layout tests broke due to unexpected simctl output
1144
1145         * Scripts/webkitpy/xcode/simulator.py:
1146         (Simulator._parse_devices): Handle new Device Pairs header.
1147         * Scripts/webkitpy/xcode/simulator_unittest.py:
1148         (test_device_pairs): Add unit test for Device Pairs header.
1149
1150 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
1151
1152         Remove convenience constructors for TextRun
1153         https://bugs.webkit.org/show_bug.cgi?id=144752
1154
1155         Reviewed by Anders Carlsson.
1156
1157         Test the StringView which takes a StringImpl*.
1158
1159         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1160         (StringView8Bit): Testing is8Bit() on StringView
1161
1162 2015-05-07  Sam Weinig  <sam@webkit.org>
1163
1164         [Content Extensions] Add simple tester that takes an extension and compiles it
1165         https://bugs.webkit.org/show_bug.cgi?id=144781
1166
1167         Reviewed by Dan Bates.
1168
1169         * ContentExtensionTester: Added.
1170         * ContentExtensionTester/Configurations: Added.
1171         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
1172         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
1173         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
1174         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
1175         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
1176         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
1177         * ContentExtensionTester/main.m: Added.
1178         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
1179
1180 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
1181
1182         Build fix.
1183
1184         Reviewed by Dan Bernstein.
1185
1186         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1187         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1188         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
1189         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
1190         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1191         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1192         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
1193         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
1194
1195 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
1196
1197         [GTK] Some tests fail because they do not assume the popup menu captures click events
1198         https://bugs.webkit.org/show_bug.cgi?id=40601
1199
1200         Reviewed by Carlos Garcia Campos.
1201
1202         Popdown all attached menus when moving between tests and between each new
1203         event sent to the WebView. This prevents context and popup menus from eating
1204         events.
1205
1206         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
1207         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
1208         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1209         (WTR::dispatchEvent): Popdown all menus between dispatching events.
1210         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
1211         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
1212         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1213         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
1214         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1215         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
1216         longer in the platform-independent file.
1217         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
1218
1219 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
1220
1221         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
1222         https://bugs.webkit.org/show_bug.cgi?id=144746
1223
1224         Reviewed by Carlos Garcia Campos.
1225
1226         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
1227
1228         * MiniBrowser/gtk/main.c:
1229         (main):
1230
1231 2015-05-08  Commit Queue  <commit-queue@webkit.org>
1232
1233         Unreviewed, rolling out r183996.
1234         https://bugs.webkit.org/show_bug.cgi?id=144806
1235
1236         ASan detected use-after free (Requested by ap on #webkit).
1237
1238         Reverted changeset:
1239
1240         "Remove convenience constructors for TextRun"
1241         https://bugs.webkit.org/show_bug.cgi?id=144752
1242         http://trac.webkit.org/changeset/183996
1243
1244 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
1245
1246         Remove convenience constructors for TextRun
1247         https://bugs.webkit.org/show_bug.cgi?id=144752
1248
1249         Reviewed by Anders Carlsson.
1250
1251         Test the StringView which takes a StringImpl*.
1252
1253         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1254         (StringView8Bit): Testing is8Bit() on StringView
1255
1256 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1257
1258         [GTK] WTR doesn't correctly handle the Escape key
1259         https://bugs.webkit.org/show_bug.cgi?id=144788
1260
1261         Reviewed by Martin Robinson.
1262
1263         Correctly handle 0x001B character code in GTK+ event sender to be
1264         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
1265         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
1266         to dismiss popup menus.
1267
1268         Fixes editing/selection/5354455-1.html.
1269
1270         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1271         (WTR::getGDKKeySymForKeyRef):
1272
1273 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1274
1275         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
1276         https://bugs.webkit.org/show_bug.cgi?id=144748
1277
1278         Reviewed by Sergio Villar Senin.
1279
1280         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1281         (testWebKitSettings): Check the new setting is correctly
1282         initialized and updated.
1283         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1284         (testWebContextSecurityFileXHR): Check XHR to local files is
1285         allowed from file URLs after changing the setting.
1286         (beforeAll): Add new test.
1287
1288 2015-05-08  Commit Queue  <commit-queue@webkit.org>
1289
1290         Unreviewed, rolling out r183945.
1291         https://bugs.webkit.org/show_bug.cgi?id=144789
1292
1293         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
1294
1295         Reverted changeset:
1296
1297         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
1298         https://bugs.webkit.org/show_bug.cgi?id=144746
1299         http://trac.webkit.org/changeset/183945
1300
1301 2015-05-07  Anders Carlsson  <andersca@apple.com>
1302
1303         Build fixes.
1304
1305         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
1306         (TestWebKitAPI::TEST):
1307         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
1308         (TestWebKitAPI::TEST):
1309         Add casts.
1310
1311 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
1312
1313         GC has trouble with pathologically large array allocations
1314         https://bugs.webkit.org/show_bug.cgi?id=144609
1315
1316         Reviewed by Geoffrey Garen.
1317         
1318         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
1319         and it's a frequently requested feature.
1320         
1321         Also add the ability to run a test pretending that your system has a particular RAM size.
1322         This is useful for GC tests, and the new GC test that I added uses this.
1323
1324         * Scripts/run-javascriptcore-tests:
1325         (runJSCStressTests):
1326         * Scripts/run-jsc-stress-tests:
1327
1328 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
1329
1330         [EFL] Bump EFL version to 1.14.0
1331         https://bugs.webkit.org/show_bug.cgi?id=144743
1332
1333         Reviewed by Darin Adler.
1334
1335         Bump EFL and elementary version to 1.14.0 and removed
1336         md5sum, because it isn't used at all if hash is present.
1337
1338         * efl/jhbuild.modules:
1339
1340 2015-05-07  Saam Barati  <saambarati1@gmail.com>
1341
1342         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
1343         https://bugs.webkit.org/show_bug.cgi?id=144753
1344
1345         Reviewed by Mark Lam.
1346
1347         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1348
1349 2015-05-07  Beth Dakin  <bdakin@apple.com>
1350
1351         New force-related DOM events should fire in WK1 views
1352         https://bugs.webkit.org/show_bug.cgi?id=144663
1353         -and corresponding-
1354         rdar://problem/20281886
1355
1356         Reviewed by Sam Weinig.
1357
1358         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
1359         now. Just send nil. 
1360         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1361         (TestWebKitAPI::buildAndPerformTest):
1362
1363 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1364
1365         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
1366         https://bugs.webkit.org/show_bug.cgi?id=144746
1367
1368         Reviewed by Martin Robinson.
1369
1370         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
1371
1372         * MiniBrowser/gtk/main.c:
1373         (main):
1374
1375 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
1376
1377         Revert "Introducing the Platform Abstraction Layer (PAL)"
1378         https://bugs.webkit.org/show_bug.cgi?id=144751
1379
1380         Unreviewed.
1381
1382         PAL should be a new target inside WebCore, rather than a top-level folder.
1383
1384         * Scripts/build-webkit: Add it to build-webkit.
1385
1386 2015-05-07  Ada Chan  <adachan@apple.com>
1387
1388         Add a test for WKPageCopySessionState() with filtering.
1389         https://bugs.webkit.org/show_bug.cgi?id=144666
1390
1391         Reviewed by Darin Adler.
1392
1393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1394         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
1395         (TestWebKitAPI::didFinishLoadForFrame):
1396         (TestWebKitAPI::setPageLoaderClient):
1397         (TestWebKitAPI::filterFirstItemCallback):
1398         (TestWebKitAPI::filterAllItemsCallback):
1399         (TestWebKitAPI::createSessionStates):
1400         (TestWebKitAPI::TEST):
1401
1402 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1403
1404         iOS build fix attempt
1405
1406         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
1407
1408         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1409
1410 2015-05-06  Matt Baker  <mattbaker@apple.com>
1411
1412         Unreviewed, updated my list of email addresses.
1413
1414         * Scripts/webkitpy/common/config/contributors.json:
1415
1416 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1417
1418         Do not link tools to WebKit2.framework
1419         https://bugs.webkit.org/show_bug.cgi?id=144699
1420
1421         Unreviewed build fix.
1422
1423         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1424         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1425         These linked to WebKit2 in two ways, eliminating the other one.
1426
1427 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
1428
1429         Introducing the Platform Abstraction Layer (PAL)
1430         https://bugs.webkit.org/show_bug.cgi?id=143358
1431
1432         Reviewed by Simon Fraser.
1433
1434         * Scripts/build-webkit: Add it to build-webkit.
1435
1436 2015-05-06  Alex Christensen  <achristensen@webkit.org>
1437
1438         Fix api tests after r183877.
1439
1440         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1441         (TestWebKitAPI::TEST_F):
1442         Generate all DFAs before compiling them.
1443
1444 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1445
1446         Do not link tools to WebKit2.framework
1447         https://bugs.webkit.org/show_bug.cgi?id=144699
1448
1449         Reviewed by Tim Horton.
1450
1451         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1453         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1454
1455 2015-05-06  Alex Christensen  <achristensen@webkit.org>
1456
1457         [Content Extensions] Test splitting NFAs by max NFA size.
1458         https://bugs.webkit.org/show_bug.cgi?id=144659
1459
1460         Reviewed by Darin Adler.
1461
1462         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1463         (TestWebKitAPI::createNFAs):
1464         (TestWebKitAPI::TEST_F):
1465         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1466         (TestWebKitAPI::createNFAs):
1467
1468 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
1469
1470         Remove the remaining vestiges of SVG feature define
1471         https://bugs.webkit.org/show_bug.cgi?id=144655
1472
1473         Reviewed by Alexey Proskuryakov.
1474
1475         * Scripts/webkitperl/FeatureList.pm:
1476
1477 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
1478
1479         Add a layout mode for computing fixed layout size from a minimum size
1480         https://bugs.webkit.org/show_bug.cgi?id=144610
1481         <rdar://problem/19790341>
1482
1483         Reviewed by Simon Fraser.
1484
1485         * MiniBrowser/mac/BrowserWindow.xib:
1486         * MiniBrowser/mac/BrowserWindowController.h:
1487         * MiniBrowser/mac/WK1BrowserWindowController.m:
1488         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
1489         * MiniBrowser/mac/WK2BrowserWindowController.m:
1490         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
1491         Add a optional toolbar item to toggle a minimum view size of 1024x0.
1492
1493 2015-05-05  Alex Christensen  <achristensen@webkit.org>
1494
1495         [Content Extensions] Release input NSString when finished copying it.
1496         https://bugs.webkit.org/show_bug.cgi?id=144642
1497
1498         Reviewed by Brian Weinstein.
1499
1500         * WebKitTestRunner/mac/TestControllerMac.mm:
1501         (WTR::TestController::platformConfigureViewForTest):
1502         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
1503
1504 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
1505
1506         Unreviewed test fix after r183798.
1507
1508         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1509         (convertToDRTLabel): Mimic behavior of Mac accessibility output
1510         so we can share results.
1511
1512 2015-05-05  Alex Christensen  <achristensen@webkit.org>
1513
1514         [Content Extensions] Use less memory to store the json input.
1515         https://bugs.webkit.org/show_bug.cgi?id=144604
1516
1517         Reviewed by Benjamin Poulain.
1518
1519         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1520         (-[ExtensionManagerWindowController add:]):
1521         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1522         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1523         * WebKitTestRunner/mac/TestControllerMac.mm:
1524         (WTR::TestController::platformConfigureViewForTest):
1525
1526 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1527
1528         Unreviewed. Make myself a WebKit reviewer.
1529
1530         * Scripts/webkitpy/common/config/contributors.json:
1531
1532 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
1533
1534         [GTK] r183783 breaks build
1535         https://bugs.webkit.org/show_bug.cgi?id=144632
1536
1537         Reviewed by Martin Robinson.
1538
1539         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
1540
1541         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1542         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1543
1544 2015-05-05  Alex Christensen  <achristensen@webkit.org>
1545
1546         [Content Extensions] Combine NFAs properly and free memory as we compile.
1547         https://bugs.webkit.org/show_bug.cgi?id=144485
1548
1549         Reviewed by Benjamin Poulain.
1550
1551         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1552         (TestWebKitAPI::TEST_F):
1553         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
1554         Added tests for deep NFAs.
1555
1556 2015-05-04  Alex Christensen  <achristensen@webkit.org>
1557
1558         [Content Extensions] Use less memory when writing byte code to file
1559         https://bugs.webkit.org/show_bug.cgi?id=144602
1560
1561         Reviewed by Darin Adler.
1562
1563         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1564
1565 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1566
1567         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
1568         https://bugs.webkit.org/show_bug.cgi?id=144541
1569
1570         Reviewed by Žan Doberšek.
1571
1572         Add a test case to WorkQueue unit test, to check that sources of
1573         asynchronous IO operations running in the WorkQueue thread are
1574         dispatched by the WorkQueue main loop.
1575
1576         * TestWebKitAPI/PlatformGTK.cmake:
1577         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
1578         (TestWebKitAPI::TEST):
1579
1580 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
1581
1582         Correct '--show-webview' option for Tiled Drawing tests
1583         https://bugs.webkit.org/show_bug.cgi?id=144621
1584
1585         Reviewed by Simon Fraser.
1586
1587         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
1588         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
1589
1590         * WebKitTestRunner/mac/TestControllerMac.mm:
1591         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
1592         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
1593
1594 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
1595
1596         Large array shouldn't be slow
1597         https://bugs.webkit.org/show_bug.cgi?id=144617
1598
1599         Reviewed by Geoffrey Garen.
1600         
1601         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
1602         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
1603         long-running. So, hash-map sort of belongs here.
1604
1605         * Scripts/run-jsc-benchmarks:
1606
1607 2015-05-04  Doug Russell  <d_russell@apple.com>
1608
1609         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
1610         https://bugs.webkit.org/show_bug.cgi?id=144489
1611
1612         Reviewed by Chris Fleizach.
1613
1614         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
1615         on the returned control.
1616         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
1617         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
1618         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
1619         Add support for setSelectedVisibleTextRange() in accessibility tests.
1620
1621         * DumpRenderTree/AccessibilityUIElement.cpp:
1622         (setSelectedVisibleTextRangeCallback):
1623         (AccessibilityUIElement::setSelectedVisibleTextRange):
1624         (AccessibilityUIElement::getJSClass):
1625         (AccessibilityUIElement::textMarkerForIndex): Deleted.
1626         * DumpRenderTree/AccessibilityUIElement.h:
1627         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1628         (AccessibilityUIElement::setSelectedVisibleTextRange):
1629         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1630         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1631         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
1632         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1633         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1634         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1635         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1636         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1637         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1638         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1639         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1640
1641 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
1642
1643         [Win] Implement the "--show-webview" option for Windows
1644         https://bugs.webkit.org/show_bug.cgi?id=144589
1645
1646         Reviewed by Alex Christensen.
1647
1648         Add another runtime flag (--show-webview) that causes DumpRenderTree
1649         to draw its view on-screen, rather than the standard offscreen mode.
1650
1651         * DumpRenderTree/win/DumpRenderTree.cpp:
1652         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
1653         (initializeGlobalsFromCommandLineOptions): Recognize the new
1654         command-line argument, and set the global 'showWebView' state if
1655         appropriate.
1656
1657 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
1658
1659         Remove dead code from TestInvocationCairo.cpp
1660         https://bugs.webkit.org/show_bug.cgi?id=144564
1661
1662         Reviewed by Gyuyoung Kim.
1663
1664         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
1665
1666         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1667         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1668
1669 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
1670
1671         [GTK] Add libnotify in gtk install-dependencies
1672         https://bugs.webkit.org/show_bug.cgi?id=144379
1673
1674         Reviewed by Csaba Osztrogonác.
1675
1676         * gtk/install-dependencies:
1677
1678 2015-05-01  Dan Bernstein  <mitz@apple.com>
1679
1680         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
1681         https://bugs.webkit.org/show_bug.cgi?id=144501
1682
1683         Reviewed by Darin Adler.
1684
1685         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1686         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
1687         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
1688         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
1689
1690 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
1691
1692         check-webkit-style fails due to system pylint
1693         https://bugs.webkit.org/show_bug.cgi?id=144360
1694
1695         Reviewed by Darin Adler.
1696
1697         Make sure that the directory containing third party autoinstalled modules
1698         is at the beginning of the search path, to avoid conflicts with other
1699         versions of the same modules installed in the system (e.g. pylint).
1700
1701         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
1702         modules directory to sys.path, instead of appending it.
1703
1704 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
1705
1706         Unreviewed, updated my list of email addresses.
1707
1708         * Scripts/webkitpy/common/config/contributors.json: Updated.
1709
1710 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
1711
1712         USE(...) macro should expect unprefixed variables
1713         https://bugs.webkit.org/show_bug.cgi?id=144454
1714
1715         Reviewed by Daniel Bates.
1716
1717         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
1718         * DumpRenderTree/config.h: Ditto.
1719         * TestWebKitAPI/config.h: Ditto.
1720
1721 2015-05-01  Basile Clement  <basile_clement@apple.com>
1722
1723         Unreviewed. Add myself as a commiter in contributors.json.
1724
1725         * Scripts/webkitpy/common/config/contributors.json:
1726
1727 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
1728
1729         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
1730         https://bugs.webkit.org/show_bug.cgi?id=144487
1731
1732         Reviewed by Ryosuke Niwa.
1733
1734         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1735         (BenchmarkRunner.merge): Fix bug.
1736         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
1737
1738 2015-05-01  Brady Eidson  <beidson@apple.com>
1739
1740         Add API to disable meta refreshes.
1741         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
1742
1743         Reviewed by Alexey Proskuryakov.
1744
1745         * DumpRenderTree/mac/DumpRenderTree.mm:
1746         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
1747
1748 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
1749
1750         Provide a runtime flag to run-webkit-tests that shows the test view
1751         https://bugs.webkit.org/show_bug.cgi?id=144079.
1752
1753         Unreviewed correction to r183651.
1754
1755         * WebKitTestRunner/TestController.cpp:
1756         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
1757         flag is included in the options dictionary passed to the PlatformWebView.
1758
1759 2015-05-01  Antti Koivisto  <antti@apple.com>
1760
1761         Remove network process load serialization code
1762         https://bugs.webkit.org/show_bug.cgi?id=144448
1763
1764         Reviewed by Alexey Proskuryakov.
1765
1766         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1767         (WTR::InjectedBundle::beginTesting):
1768         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1769         (WTR::TestRunner::setSerializeHTTPLoads):
1770         (WTR::TestRunner::dispatchPendingLoadRequests):
1771
1772 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1773
1774         [GTK] Add libhyphen-dev to the build dependencies
1775         https://bugs.webkit.org/show_bug.cgi?id=144452
1776
1777         Reviewed by Martin Robinson.
1778
1779         * gtk/install-dependencies: Added hyphen as Fedora and Arch
1780         dependencies.
1781
1782 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
1783
1784         Provide a runtime flag to run-webkit-tests that shows the test view
1785         https://bugs.webkit.org/show_bug.cgi?id=144079.
1786
1787         Reviewed by Dean Jackson.
1788
1789         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
1790         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
1791         option:
1792         
1793         --additional-drt-flag="--show-webview"
1794
1795         * DumpRenderTree/mac/DumpRenderTree.mm:
1796         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
1797         '--show-webview' flag.
1798         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
1799         * WebKitTestRunner/Options.cpp:
1800         (WTR::Options::Options):
1801         (WTR::handleOptionShowWebView):
1802         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
1803         * WebKitTestRunner/Options.h:
1804         * WebKitTestRunner/TestController.cpp:
1805         (WTR::TestController::TestController):
1806         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
1807         * WebKitTestRunner/TestController.h:
1808         (WTR::TestController::shouldShowWebView):
1809         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1810         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
1811         options dictionary. If it is true, display the web view while running the test.
1812
1813 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
1814
1815         r183355 didn't trigger Mac tests
1816         https://bugs.webkit.org/show_bug.cgi?id=144464
1817
1818         Reviewed by Simon Fraser.
1819
1820         Update badly neglected filters and unit tests.
1821
1822         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1823         (_should_file_trigger_build):
1824         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1825         (ShouldBuildTest):
1826         (ShouldBuildTest.test_should_build):
1827
1828 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1829
1830         [GTK] Add libhyphen-dev to the build dependencies
1831         https://bugs.webkit.org/show_bug.cgi?id=144452
1832
1833         Reviewed by Martin Robinson.
1834
1835         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
1836         build dependencies.
1837
1838 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
1839
1840         [GTK] Testing dictionaries are not installed automatically
1841         https://bugs.webkit.org/show_bug.cgi?id=144460
1842
1843         Reviewed by Carlos Garcia Campos.
1844
1845         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
1846
1847 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
1848
1849         Fix return code issue, check return code of safari process and dump results to log
1850         https://bugs.webkit.org/show_bug.cgi?id=144436
1851
1852         Reviewed by Ryosuke Niwa.
1853
1854         * Scripts/run-benchmark:
1855         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1856         (BenchmarkRunner.dump): Correct typo.
1857         (BenchmarkRunner.wrap): Add results to console.
1858         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
1859         (OSXSafariDriver.prepareEnv):
1860         (OSXSafariDriver.launchUrl):
1861         (OSXSafariDriver.closeBrowsers):
1862
1863 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
1864
1865         Should no longer need to worry about very old versions of Xcode
1866         https://bugs.webkit.org/show_bug.cgi?id=144437
1867
1868         Reviewed by Dan Bernstein.
1869
1870         * Scripts/check-for-exit-time-destructors:
1871         * Scripts/check-for-global-initializers:
1872         * Scripts/check-for-weak-vtables-and-externals:
1873
1874 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
1875
1876         REGRESSION(183583): [Mac] make without SDKROOT has issues
1877         https://bugs.webkit.org/show_bug.cgi?id=144431
1878
1879         Reviewed by Dan Bernstein.
1880
1881         * Makefile:
1882         * WebKitTestRunner/Makefile:
1883         Assume an empty SDKROOT means an macosx variant, so only
1884         enable settings if the SDKROOT is not empty and does not
1885         contain "macosx".
1886
1887 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
1888
1889         Expand test infrastructure to support scrolling tests
1890         https://bugs.webkit.org/show_bug.cgi?id=143684
1891         <rdar://problem/20375516>
1892
1893         Reviewed by Simon Fraser.
1894
1895         * DumpRenderTree/mac/DumpRenderTree.mm:
1896         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
1897         reset before the next test run.
1898         * WebKitTestRunner/TestController.cpp:
1899         (WTR::TestController::resetStateToConsistentValues): Ditto."
1900
1901 2015-04-29  Alex Christensen  <achristensen@webkit.org>
1902
1903         Run javascriptcore tests on Windows without cygwin
1904         https://bugs.webkit.org/show_bug.cgi?id=144419
1905
1906         Reviewed by Brent Fulgham.
1907
1908         * Scripts/run-javascriptcore-tests:
1909         (runJSCStressTests):
1910         Just call ruby, not /usr/bin/env ruby.
1911
1912 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
1913
1914         [GTK] Add --enable-shared option to LLVM to build mesa
1915         https://bugs.webkit.org/show_bug.cgi?id=144393
1916
1917         Reviewed by Martin Robinson.
1918
1919         The updated mesa requires the shared LLVM libraries.
1920         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
1921         to LLVM configure script. It will provide shared libraries in addition to static libraries.
1922
1923         * gtk/jhbuild-optional.modules:
1924
1925 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
1926
1927         [GTK] Add support for automatic hyphenation
1928         https://bugs.webkit.org/show_bug.cgi?id=44478
1929
1930         Reviewed by Carlos Garcia Campos.
1931
1932         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
1933         all systems will use the same dictionaries for testing purposes.
1934
1935 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
1936
1937         Failure when building WebKit for appletvsimulator.
1938         https://bugs.webkit.org/show_bug.cgi?id=144356
1939
1940         Reviewed by Alexey Proskuryakov.
1941
1942         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
1943         make TVOS and WatchOS behave correctly.
1944
1945         * Makefile:
1946         * WebKitTestRunner/Makefile:
1947
1948 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
1949
1950         Use-after-free when invalidating WKPageForceRepaint callback
1951         https://bugs.webkit.org/show_bug.cgi?id=144401
1952         rdar://problem/20741111
1953
1954         Reviewed by Tim Horton.
1955
1956         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
1957
1958         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
1959         Don't do anything on error, because the context may be a stale pointer now.
1960
1961 2015-04-29  David Kilzer  <ddkilzer@apple.com>
1962
1963         check-webkit-style: Don't complain about returning value from Objective-C method call in header
1964         <http://webkit.org/b/144395>
1965
1966         Reviewed by Andy Estes.
1967
1968         * Scripts/webkitpy/style/checkers/cpp.py:
1969         (check_spacing): Update regex so 'return' is ignored if it
1970         precedes the whitespace and bracket.  Change category name to
1971         'whitespace/brackets'.  Add period to error message.
1972         (CppChecker): Add 'whitespace/brackets' as a category.
1973         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1974         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
1975         'CppChecker.categories' since that's where the list lives now.
1976         (CppStyleTest.test_spacing_before_brackets): Add tests for
1977         'whitespace/brackets' issues and non-issues.
1978
1979 2015-04-29  Alex Christensen  <achristensen@webkit.org>
1980
1981         Fix WinCairo bot.
1982
1983         * Scripts/webkitdirs.pm:
1984         (determinePassedConfiguration):
1985         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
1986
1987 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
1988
1989         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
1990         https://bugs.webkit.org/show_bug.cgi?id=132159
1991
1992         Reviewed by Darin Adler.
1993
1994         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
1995         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
1996
1997         * DumpRenderTree/mac/DumpRenderTree.mm:
1998         (fontWhitelist):
1999         (adjustFonts):
2000         (createWebViewAndOffscreenWindow):
2001         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2002         (WTR::activateFonts):
2003         * WebKitTestRunner/mac/TestControllerMac.mm:
2004         (WTR::allowedFontFamilySet):
2005         (WTR::systemHiddenFontFamilySet):
2006         (WTR::generateWhitelist):
2007         (WTR::TestController::platformInitializeContext):
2008
2009 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
2010
2011         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2012         https://bugs.webkit.org/show_bug.cgi?id=144155
2013
2014         Reviewed by Andreas Kling.
2015
2016         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2017         Make sure that test window is "visible" before each test. While there is no concrete
2018         evidence that this is the problem indeed, the behavior is consistent with what would
2019         happen for an invisible window. Also, WKTR obviously needs to do this to protect
2020         against potential buggy tests that hide the window and don't show it.
2021
2022 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2023
2024         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
2025
2026         Latest changes in the inspector UI made this test fail. We were
2027         relying that the sidebar was always visible and the first 'li'
2028         element of the inspector was the one containing the title. This is
2029         no longer true, so better use document title that is not likely
2030         to change.
2031
2032         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2033         (openRemoteDebuggingSession):
2034
2035 2015-04-29  Andres Gomez  <agomez@igalia.com>
2036
2037         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
2038
2039         * Scripts/webkitpy/common/config/contributors.json:
2040
2041 2015-04-29  Andres Gomez  <agomez@igalia.com>
2042
2043         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
2044
2045         * Scripts/webkitpy/common/config/watchlist:
2046
2047 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
2048
2049         [EFL] Allow to run the tests on the native X display
2050         https://bugs.webkit.org/show_bug.cgi?id=144247
2051
2052         Reviewed by Gyuyoung Kim.
2053
2054         Added the USE_NATIVE_XDISPLAY option for the WTR.
2055         We can select the Xorg driver if environment variable is set up before running the tests.
2056
2057         * Scripts/webkitpy/port/efl.py:
2058         (EflPort._driver_class):
2059
2060 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
2061
2062         [GTK] Add libnotify-dev in gtk install-dependencies
2063         https://bugs.webkit.org/show_bug.cgi?id=144379
2064
2065         Reviewed by Žan Doberšek.
2066
2067         * gtk/install-dependencies:
2068
2069 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
2070
2071         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
2072         https://bugs.webkit.org/show_bug.cgi?id=143001
2073
2074         Reviewed by Gyuyoung Kim.
2075
2076         * WebKitTestRunner/TestController.cpp:
2077         (WTR::shouldUseFixedLayout):
2078
2079 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
2080
2081         Increase stablility of run-benchmark script
2082         https://bugs.webkit.org/show_bug.cgi?id=144361
2083
2084         Reviewed by Ryosuke Niwa.
2085
2086         * Scripts/run-benchmark:
2087         (main):
2088         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
2089         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2090         (GenericBenchmarkBuilder.clean):
2091         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
2092         (BenchmarkRunner.__init__):
2093         (BenchmarkRunner.execute):
2094         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2095         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
2096         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
2097         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
2098         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
2099         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
2100         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
2101         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2102         (HTTPServerDriver.fetchResult):
2103         (HTTPServerDriver):
2104         (HTTPServerDriver.killServer): Add kill server interface.
2105         (HTTPServerDriver.getReturnCode): Add get return code interface.
2106         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
2107         (SimpleHTTPServerDriver.serve):
2108         (SimpleHTTPServerDriver.fetchResult):
2109         (SimpleHTTPServerDriver):
2110         (SimpleHTTPServerDriver.killServer):
2111         (SimpleHTTPServerDriver.getReturnCode):
2112         * Scripts/webkitpy/benchmark_runner/utils.py:
2113         (forceRemove): Provide python version of 'rm -rf'.
2114
2115 2015-04-28  Sam Weinig  <sam@webkit.org>
2116
2117         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
2118         https://bugs.webkit.org/show_bug.cgi?id=144363
2119
2120         Reviewed by Alex Christensen.
2121
2122         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2123         (TestWebKitAPI::createNFAs):
2124         (TestWebKitAPI::TEST_F):
2125         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2126         (TestWebKitAPI::countLiveNodes):
2127         (TestWebKitAPI::createNFAs):
2128         (TestWebKitAPI::buildDFAFromPatterns):
2129         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
2130
2131 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2132
2133         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2134         https://bugs.webkit.org/show_bug.cgi?id=144304
2135
2136         Reviewed by Geoffrey Garen.
2137
2138         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
2139         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2140         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2141
2142 2015-04-28  Commit Queue  <commit-queue@webkit.org>
2143
2144         Unreviewed, rolling out r183514.
2145         https://bugs.webkit.org/show_bug.cgi?id=144359
2146
2147         It broke cloop test bots (Requested by mcatanzaro on #webkit).
2148
2149         Reverted changeset:
2150
2151         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
2152         https://bugs.webkit.org/show_bug.cgi?id=144304
2153         http://trac.webkit.org/changeset/183514
2154
2155 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2156
2157         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2158         https://bugs.webkit.org/show_bug.cgi?id=144304
2159
2160         Reviewed by Geoffrey Garen.
2161
2162         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
2163         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
2164         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2165         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2166
2167 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2168
2169         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
2170         https://bugs.webkit.org/show_bug.cgi?id=144319
2171
2172         Reviewed by Csaba Osztrogonác.
2173
2174         * TestWebKitAPI/CMakeLists.txt:
2175         * TestWebKitAPI/PlatformEfl.cmake:
2176
2177 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
2178
2179         Fix common typo "targetting" => "targeting"
2180         https://bugs.webkit.org/show_bug.cgi?id=144349
2181
2182         Reviewed by Daniel Bates.
2183
2184         * Scripts/webkitdirs.pm:
2185         (execMacWebKitAppForDebugging):
2186
2187 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2188
2189         [GTK][jhbuild] Mesa build failure with llvm 3.6
2190         https://bugs.webkit.org/show_bug.cgi?id=144250
2191
2192         Reviewed by Žan Doberšek.
2193
2194         Bump the version of Mesa to 10.5.4
2195
2196         * gtk/jhbuild.modules:
2197
2198 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
2199
2200         Disable App Nap in WebKitTestRunner UI process
2201         https://bugs.webkit.org/show_bug.cgi?id=144308
2202
2203         Reviewed by Daniel Bates.
2204
2205         * WebKitTestRunner/mac/main.mm:
2206         (disableAppNapInUIProcess):
2207         (main):
2208
2209 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2210
2211         [GTK] Update JHBuild Mesa download directory
2212         https://bugs.webkit.org/show_bug.cgi?id=144318
2213
2214         Update the download directory of Mesa module since the previous one
2215         doesn't exist any more.
2216
2217         Reviewed by Žan Doberšek.
2218
2219         * gtk/jhbuild.modules:
2220
2221 2015-04-28  Commit Queue  <commit-queue@webkit.org>
2222
2223         Unreviewed, rolling out r183477.
2224         https://bugs.webkit.org/show_bug.cgi?id=144334
2225
2226         Roll back the Mesa dependency bump in fear of uncaught
2227         regressions while the testing bots are no-op. (Requested by
2228         zdobersek on #webkit).
2229
2230         Reverted changeset:
2231
2232         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
2233         https://bugs.webkit.org/show_bug.cgi?id=144250
2234         http://trac.webkit.org/changeset/183477
2235
2236 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2237
2238         [GTK][jhbuild] Mesa build failure with llvm 3.6
2239         https://bugs.webkit.org/show_bug.cgi?id=144250
2240
2241         Reviewed by Žan Doberšek.
2242
2243         Bump the version of Mesa to 10.5.4
2244
2245         * gtk/jhbuild.modules:
2246
2247 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
2248
2249         Add '__init__.py' and fix known bug in benchmark runner.
2250         https://bugs.webkit.org/show_bug.cgi?id=144296
2251
2252         Reviewed by Ryosuke Niwa
2253
2254         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
2255         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
2256         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2257         (BenchmarkRunner.__init__):
2258         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
2259         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
2260         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
2261
2262 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2263
2264         More build fix.
2265
2266         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2267         (-[AccessibilityNotificationHandler _notificationReceived:]):
2268         Use -objectForKey:, not array subscript.
2269
2270 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2271
2272         Catch unexpected exits in DumpRenderTree
2273         https://bugs.webkit.org/show_bug.cgi?id=144288
2274
2275         Reviewed by Tim Horton.
2276
2277         * DumpRenderTree/mac/DumpRenderTree.mm:
2278         (atexitFunction):
2279         (DumpRenderTreeMain):
2280
2281 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2282
2283         Build fix
2284
2285         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2286         (-[AccessibilityNotificationHandler _notificationReceived:]):
2287         Use -objectForKey:, not array subscript.
2288
2289 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2290
2291         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2292         https://bugs.webkit.org/show_bug.cgi?id=144155
2293
2294         Reviewed by Tim Horton.
2295
2296         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
2297         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
2298         and we clearly don't want App Nap while testing.
2299
2300 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
2301
2302         [CMake] Autogenerate cmakeconfig.h.cmake
2303         https://bugs.webkit.org/show_bug.cgi?id=143997
2304
2305         Reviewed by Csaba Osztrogonác.
2306
2307         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
2308         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
2309
2310 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
2311
2312         REGRESSION(r182879): Images and video can no longer be downloaded
2313         https://bugs.webkit.org/show_bug.cgi?id=144267
2314         <rdar://problem/20702844>
2315
2316         Reviewed by Simon Fraser.
2317
2318         Revise tests to check for proper download menu state.
2319         1. Downloading a loal image should be disabled.
2320         2. Downloading a local media file should be disabled.
2321         3. Downloading non-downloadable media should be disabled.
2322
2323         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2324         (TestWebKitAPI::TEST):
2325
2326 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2327
2328         Merge run-launcher into run-minibrowser
2329         https://bugs.webkit.org/show_bug.cgi?id=141928
2330
2331         Reviewed by Darin Adler.
2332
2333         * Scripts/run-iexploder-tests:
2334         (runSafariWithIExploder):
2335         * Scripts/run-launcher: Removed.
2336         * Scripts/run-minibrowser:
2337         * Scripts/webkitdirs.pm:
2338         (launcherPath):
2339         * Scripts/webkitpy/port/efl.py:
2340         (EflPort.show_results_html_file):
2341         * Scripts/webkitpy/port/efl_unittest.py:
2342         (EflPortTest.test_show_results_html_file):
2343         * Scripts/webkitpy/port/gtk.py:
2344         (GtkPort.print_leaks_summary):
2345         (GtkPort.show_results_html_file):
2346         (GtkPort): Deleted.
2347         * Scripts/webkitpy/port/gtk_unittest.py:
2348         (GtkPortTest.test_show_results_html_file):
2349
2350 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2351
2352         [buildbot] Fix the output of perf-test buildstep on timeout
2353         https://bugs.webkit.org/show_bug.cgi?id=144097
2354
2355         Reviewed by Ryosuke Niwa.
2356
2357         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2358         (RunAndUploadPerfTests.getText2):
2359         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2360         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
2361         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
2362
2363 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2364
2365         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
2366         https://bugs.webkit.org/show_bug.cgi?id=143874
2367
2368         Reviewed by Gyuyoung Kim.
2369
2370         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
2371
2372 2015-04-24  Philippe Normand  <pnormand@igalia.com>
2373
2374         [JHBuild] Move to upstream OpenWebRTC
2375         https://bugs.webkit.org/show_bug.cgi?id=144145
2376
2377         Reviewed by Carlos Garcia Campos.
2378
2379         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
2380         and add a new simple patch to gst-plugins-base, required for
2381         OpenWebRTC build.
2382         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
2383         * gtk/jhbuild.modules: Ditto.
2384         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
2385
2386 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2387
2388         [ES6] Implement ES6 template literals
2389         https://bugs.webkit.org/show_bug.cgi?id=142691
2390
2391         Reviewed by Darin Adler.
2392
2393         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
2394
2395         * Scripts/webkitperl/FeatureList.pm:
2396
2397 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2398
2399         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
2400         https://bugs.webkit.org/show_bug.cgi?id=144217
2401
2402         Reviewed by Darin Adler.
2403
2404         * WebKitTestRunner/PlatformEfl.cmake:
2405
2406 2015-04-26  Doug Russell  <d_russell@apple.com>
2407
2408         AX: richer text change notifications (142719)
2409         https://bugs.webkit.org/show_bug.cgi?id=142719
2410
2411         Reviewed by Darin Adler.
2412
2413         Richer accessibility value change notifications. Introduce AXTextEditType,
2414         postTextStateChangeNotification and postTextReplacementNotification to give assistive
2415         tech apps more reliable context for responding to changes in web content. Also implement
2416         a mechanism to post value changes in password form fields in coalesced ticks to thwart
2417         analyzing the cadence of changes.
2418
2419         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
2420         and an overload of postTextReplacementNotification to give assistive tech apps more
2421         reliable context for responding to changes in web content selection. Also block posting
2422         selection changes on password fields.
2423
2424         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
2425         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2426         (-[AccessibilityNotificationHandler stopObserving]):
2427         (-[AccessibilityNotificationHandler _notificationReceived:]):
2428         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2429         (AccessibilityUIElement::removeNotificationListener):
2430         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2431         (-[AccessibilityNotificationHandler _notificationReceived:]):
2432         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2433         (WTR::AccessibilityUIElement::removeNotificationListener):
2434
2435 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
2436
2437         Add myself to contributors.json
2438         https://bugs.webkit.org/show_bug.cgi?id=144204
2439
2440         Reviewed by Darin Adler.
2441
2442         * Scripts/webkitpy/common/config/contributors.json:
2443
2444 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
2445
2446         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
2447         https://bugs.webkit.org/show_bug.cgi?id=144182
2448
2449         Reviewed by Simon Fraser.
2450
2451         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
2452
2453 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
2454
2455         https://bugs.webkit.org/show_bug.cgi?id=144038
2456
2457         Reviewed by Ryosuke Niwa
2458
2459         Add a script to run Speedometer and JetStream on a browser.
2460
2461         * Scripts/run-benchmark: Wrapper script to run benchmark.
2462         (main):
2463         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
2464         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
2465         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
2466         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
2467         (BenchmarkBuilderFactory):
2468         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
2469         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
2470         (GenericBenchmarkBuilder):
2471         (GenericBenchmarkBuilder.prepare):
2472         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
2473         (GenericBenchmarkBuilder._applyPatch):
2474         (GenericBenchmarkBuilder.clean):
2475         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
2476         (JetStreamBenchmarkBuilder):
2477         (JetStreamBenchmarkBuilder.prepare):
2478         (JetStreamBenchmarkBuilder._runCreateScript):
2479         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
2480         (BenchmarkRunner):
2481         (BenchmarkRunner.__init__):
2482         (BenchmarkRunner.execute):
2483         (BenchmarkRunner.dump):
2484         (BenchmarkRunner.wrap):
2485         (BenchmarkRunner.merge):
2486         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
2487         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
2488         (BrowserDriver):
2489         (BrowserDriver.prepareEnv):
2490         (BrowserDriver.launchUrl):
2491         (BrowserDriver.closeBrowser):
2492         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
2493         (BrowserDriverFactory):
2494         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
2495         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
2496         (OSXChromeDriver):
2497         (OSXChromeDriver.prepareEnv):
2498         (OSXChromeDriver.launchUrl):
2499         (OSXChromeDriver.closeBrowsers):
2500         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
2501         (OSXSafariDriver):
2502         (OSXSafariDriver.prepareEnv):
2503         (OSXSafariDriver.launchUrl):
2504         (OSXSafariDriver.closeBrowsers):
2505         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
2506         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
2507         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
2508         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
2509         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
2510         (GenericFactory):
2511         (GenericFactory.iterateGetItem):
2512         (GenericFactory.create):
2513         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
2514         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
2515         (ServerControl):
2516         (ServerControl.render_GET):
2517         (ServerControl.render_POST):
2518         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
2519         (HTTPServerDriver):
2520         (HTTPServerDriver.serve):
2521         (HTTPServerDriver.fetchResult):
2522         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
2523         (HTTPServerDriverFactory):
2524         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
2525         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
2526         (SimpleHTTPServerDriver):
2527         (SimpleHTTPServerDriver.depends):
2528         (SimpleHTTPServerDriver.__init__):
2529         (SimpleHTTPServerDriver.serve):
2530         (SimpleHTTPServerDriver.baseUrl):
2531         (SimpleHTTPServerDriver.fetchResult):
2532         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
2533         (ModuleNotFoundError):
2534         (loadModule):
2535         (getPathFromProjectRoot):
2536         (loadJSONFromFile):
2537         (TimeoutError):
2538         (timeout):
2539         (timeout.__init__):
2540         (timeout.handle_timeout):
2541         (timeout.__enter__):
2542         (timeout.__exit__):
2543
2544 2015-04-24  Commit Queue  <commit-queue@webkit.org>
2545
2546         Unreviewed, rolling out r183303.
2547         https://bugs.webkit.org/show_bug.cgi?id=144181
2548
2549         Change was incorrect, broke builds (Requested by smfr on
2550         #webkit).
2551
2552         Reverted changeset:
2553
2554         "Fix the build."
2555         http://trac.webkit.org/changeset/183303
2556
2557 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
2558
2559         Fix the build.
2560
2561         * MiniBrowser/mac/WK2BrowserWindowController.m:
2562         (-[WK2BrowserWindowController initWithConfiguration:]):
2563
2564 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
2565
2566         Disable ActionMenusPDFTest due to timeout on test bot
2567
2568         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2569         (TestWebKitAPI::TEST):
2570
2571 2015-04-24  Commit Queue  <commit-queue@webkit.org>
2572
2573         Unreviewed, rolling out r183266.
2574         https://bugs.webkit.org/show_bug.cgi?id=144164
2575
2576         Broke 32-bit build and a test. (Requested by ap on #webkit).
2577
2578         Reverted changeset:
2579
2580         "AX: richer text change notifications (142719)"
2581         https://bugs.webkit.org/show_bug.cgi?id=142719
2582         http://trac.webkit.org/changeset/183266
2583
2584 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
2585
2586         REGRESSION: WebKit2.ActionMenusTest API test fails
2587         https://bugs.webkit.org/show_bug.cgi?id=144149
2588         <rdar://problem/20677770>
2589
2590         Reviewed by Tim Horton.
2591
2592         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
2593         as the 'ActionMenusPDFTest'.
2594         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2595         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
2596         to match the hit test on the 'action-menu-target.pdf' test file.
2597
2598 2015-04-24  Daniel Bates  <dabates@apple.com>
2599
2600         Cleanup: Use @memoized for property IOSSimulator.testing_device
2601         https://bugs.webkit.org/show_bug.cgi?id=141715
2602
2603         Reviewed by Darin Adler.
2604
2605         Simplify the caching of the result of IOSSimulator.testing_device
2606         and make the code more readable by making use of the @memoized declarator
2607         instead of explicitly managing a private instance variable,
2608         IOSSimulator._testing_device, for the cached result.
2609
2610         * Scripts/webkitpy/port/ios.py:
2611         (IOSPort.determine_full_port_name):
2612         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
2613         (IOSSimulatorPort):
2614         (IOSSimulatorPort.testing_device): No need to cache the created device object in
2615         IOSSimulatorPort._testing_device since we are marking this function @memoized.
2616         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
2617         of caching in local variable since we only make use of this value exactly once in this function.
2618         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
2619         been used since being added in r178622. So, we can remove this constructor since
2620         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
2621
2622 2015-04-24  Anders Carlsson  <andersca@apple.com>
2623
2624         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
2625         https://bugs.webkit.org/show_bug.cgi?id=144158
2626
2627         Reviewed by Beth Dakin.
2628
2629         * MiniBrowser/mac/WK2BrowserWindowController.m:
2630         (-[WK2BrowserWindowController initWithConfiguration:]):
2631
2632 2015-04-24  Doug Russell  <d_russell@apple.com>
2633
2634         AX: richer text change notifications (142719)
2635         https://bugs.webkit.org/show_bug.cgi?id=142719
2636
2637         Reviewed by Darin Adler.
2638
2639         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
2640
2641         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
2642
2643         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
2644         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2645         (-[AccessibilityNotificationHandler stopObserving]):
2646         (-[AccessibilityNotificationHandler _notificationReceived:]):
2647         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2648         (AccessibilityUIElement::removeNotificationListener):
2649         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2650         (-[AccessibilityNotificationHandler _notificationReceived:]):
2651         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2652         (WTR::AccessibilityUIElement::removeNotificationListener):
2653
2654 2015-04-24  Darin Adler  <darin@apple.com>
2655
2656         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
2657         https://bugs.webkit.org/show_bug.cgi?id=128007
2658
2659         Reviewed by Anders Carlsson.
2660
2661         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
2662         * DumpRenderTree/win/UIDelegate.h: Ditto.
2663
2664         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
2665         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
2666
2667         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
2668
2669         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
2670         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
2671         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
2672         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
2673         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2674         (WebKitDOMDOMWindowTest::create): Ditto.
2675         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2676         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
2677         of smart pointers to DelayedSIgnal objects.
2678         (uriChangedCallback): Ditto.
2679
2680 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
2681
2682         [Mac] Unreviewed test fix.
2683         https://bugs.webkit.org/show_bug.cgi?id=144149
2684
2685         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2686         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
2687         test.
2688
2689 2015-04-23  Darin Adler  <darin@apple.com>
2690
2691         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
2692         https://bugs.webkit.org/show_bug.cgi?id=144090
2693
2694         Reviewed by Anders Carlsson.
2695
2696         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
2697
2698 2015-04-23  Michael Saboff  <msaboff@apple.com>
2699
2700         lldb macro btjs sometimes can't get a frame description
2701         https://bugs.webkit.org/show_bug.cgi?id=144130
2702
2703         Reviewed by Filip Pizlo.
2704
2705         We look to execute ExecState::describeFrame().  It appears that in some contexts the
2706         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
2707         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
2708
2709         * lldb/lldb_webkit.py:
2710         (btjs):
2711
2712 2015-04-23  Alex Christensen  <achristensen@webkit.org>
2713
2714         Use less memory when compiling content extensions.
2715         https://bugs.webkit.org/show_bug.cgi?id=144051
2716
2717         Reviewed by Darin Adler and Benjamin Poulain.
2718
2719         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2720         (TestWebKitAPI::TEST_F):
2721         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2722         (TestWebKitAPI::countLiveNodes):
2723
2724 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2725
2726         [CMake] Clean up JSC JIT options
2727         https://bugs.webkit.org/show_bug.cgi?id=143998
2728
2729         Reviewed by Filip Pizlo.
2730
2731         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
2732         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
2733
2734 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
2735
2736         [Mac] Extend action menus to support PDF
2737         https://bugs.webkit.org/show_bug.cgi?id=143895
2738         <rdar://problem/19003333>
2739
2740         Reviewed by Tim Horton.
2741
2742         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
2743         of PDF content works.
2744
2745         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
2746         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
2747         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
2748         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2749         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
2750         Update to support PDF tests.
2751         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
2752         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
2753
2754 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2755
2756         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
2757
2758         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2759         (beforeAll):
2760         (testWebViewAudioOnlyUserMediaPermissionRequests):
2761
2762 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2763
2764         Add myself to watchlist
2765         https://bugs.webkit.org/show_bug.cgi?id=144041
2766
2767         Reviewed by Alex Christensen.
2768
2769         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
2770
2771         * Scripts/webkitpy/common/config/watchlist:
2772
2773 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2774
2775         [GTK] MiniBrowser should use NetworkProcess by default
2776         https://bugs.webkit.org/show_bug.cgi?id=143948
2777
2778         Reviewed by Sergio Villar Senin.
2779
2780         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
2781         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
2782
2783         * MiniBrowser/gtk/main.c:
2784         (main):
2785
2786 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
2787
2788         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
2789
2790         Unreviewed build fix.
2791
2792         * Scripts/prepare-ChangeLog:
2793         (get_function_line_ranges_for_cpp):
2794         Use grep instead of any to determine if a string is an element of an array.
2795
2796 2015-04-21  Anders Carlsson  <andersca@apple.com>
2797
2798         Fix block signatures
2799         https://bugs.webkit.org/show_bug.cgi?id=144002
2800
2801         Reviewed by Andreas Kling.
2802
2803         * MiniBrowser/mac/WK2BrowserWindowController.m:
2804         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2805
2806 2015-04-21  Philippe Normand  <pnormand@igalia.com>
2807
2808         [GTK] jhbuild should not use a branch for openwebrtc
2809         https://bugs.webkit.org/show_bug.cgi?id=143981
2810
2811         Reviewed by Carlos Garcia Campos.
2812
2813         * gtk/jhbuild.modules:
2814
2815 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
2816
2817         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
2818
2819         Unreviewed build fix.
2820
2821         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
2822         However, it has been exposed by List::MoreUtils since its inception. This patch uses
2823         the any function exposed by List::MoreUtils for greater compatibility.
2824
2825         * Scripts/prepare-ChangeLog:
2826         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
2827         the any function in all of versions of Perl used by our infrastructure.
2828
2829 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2830
2831         Remove unnecessary logs when resetting tests.
2832
2833         * WebKitTestRunner/mac/TestControllerMac.mm:
2834         (WTR::TestController::platformResetPreferencesToConsistentValues):
2835         In r183020 I added some logs when compiling or removing content extensions fails.
2836         We often try to remove a content extension that does not exist, and that is not a problem.
2837
2838 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
2839
2840         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
2841         https://bugs.webkit.org/show_bug.cgi?id=143897
2842
2843         Reviewed by David Kilzer.
2844
2845         This is a speculative fix that addresses two issues:
2846
2847         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
2848         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
2849
2850         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
2851         Before: (723, 729)
2852         After: (721, 720)
2853
2854         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
2855         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
2856
2857         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
2858         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
2859
2860         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
2861
2862         2. Creating git diffs from HEAD and not origin/master by default.
2863
2864         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
2865         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
2866
2867         * Scripts/prepare-ChangeLog:
2868         (originalFile):
2869         Use HEAD instead of origin/master in default Git case.
2870
2871         (generateFunctionLists):
2872         Ensure that the end line is not less than the start line.
2873
2874         (extractLineRangeAfterChange):
2875         Set the end line to the start line if the end line is less than the start line.
2876
2877         (extractLineRangeBeforeChange):
2878         Ditto.
2879
2880 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
2881
2882         Suppress warning in prepare-ChangeLog.
2883         https://bugs.webkit.org/show_bug.cgi?id=143882
2884
2885         Reviewed by David Kilzer.
2886
2887         Prune noisy prepare-ChangeLog output by using the List::Util::any function
2888         instead of the deprecated smartmatch operator.
2889
2890         * Scripts/prepare-ChangeLog:
2891         Import the List::Util::any function.
2892
2893         (get_function_line_ranges_for_cpp):
2894         Use the any function instead of smartmatch.
2895
2896 2015-04-20  Anders Carlsson  <andersca@apple.com>
2897
2898         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
2899         https://bugs.webkit.org/show_bug.cgi?id=143966
2900
2901         Reviewed by Dan Bernstein.
2902
2903         * MiniBrowser/mac/WK2BrowserWindowController.m:
2904         (dataTypes):
2905         (-[WK2BrowserWindowController fetchWebsiteData:]):
2906         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2907         (-[WK2BrowserWindowController clearWebsiteData:]):
2908
2909 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2910
2911         Fix content extension test flakiness.
2912         https://bugs.webkit.org/show_bug.cgi?id=143950
2913
2914         Reviewed by Brady Eidson.
2915
2916         * WebKitTestRunner/mac/TestControllerMac.mm:
2917         (WTR::TestController::platformResetPreferencesToConsistentValues):
2918         Remove the TestContentExtensions if it exists.
2919         (WTR::TestController::platformConfigureViewForTest):
2920         Log errors in case there are any.
2921
2922 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2923
2924         Properly report errors from _WKUserContentExtensionStore.
2925         https://bugs.webkit.org/show_bug.cgi?id=143808
2926
2927         Reviewed by Darin Adler.
2928
2929         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
2930         (TEST_F):
2931
2932 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2933
2934         Add a rule for NetworkCache to watchlist file
2935         https://bugs.webkit.org/show_bug.cgi?id=143945
2936
2937         Reviewed by Sergio Villar Senin.
2938
2939         And add myself to the list of watchers.
2940
2941         * Scripts/webkitpy/common/config/watchlist:
2942
2943 2015-04-19  Darin Adler  <darin@apple.com>
2944
2945         Update RefPtr documentation and deprecation
2946         https://bugs.webkit.org/show_bug.cgi?id=143936
2947
2948         Reviewed by Andreas Kling.
2949
2950         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
2951
2952 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2953
2954         Introduce bytecode intrinsics
2955         https://bugs.webkit.org/show_bug.cgi?id=143926
2956
2957         Reviewed by Filip Pizlo.
2958
2959         Change cpplint to accept emit_intrinsic_XXX.
2960
2961         * Scripts/webkitpy/style/checkers/cpp.py:
2962         (check_identifier_name_in_declaration):
2963
2964 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
2965
2966         Fix lldb_webkit.py to show StringImpls correctly
2967         https://bugs.webkit.org/show_bug.cgi?id=143920
2968
2969         Reviewed by Andreas Kling.
2970         
2971         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
2972
2973         * lldb/lldb_webkit.py:
2974         (WTFStringImplProvider.is_8bit):
2975
2976 2015-04-17  Daniel Bates  <dabates@apple.com>
2977
2978         Not able to build WebKit against iOS Simulator 8.3 SDK
2979         https://bugs.webkit.org/show_bug.cgi?id=143883
2980
2981         Reviewed by David Kilzer.
2982
2983         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
2984         so that Xcode uses them.
2985
2986         * Scripts/copy-webkitlibraries-to-product-directory:
2987
2988 2015-04-17  Beth Dakin  <bdakin@apple.com>
2989
2990         Force mouse events should go through normal mouse event handling code paths
2991         https://bugs.webkit.org/show_bug.cgi?id=143749
2992         -and corresponding-
2993         rdar://problem/20472895
2994
2995         Reviewed by Dean Jackson.
2996
2997         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
2998         Since there is not a way to create an NSEventTypePressure from scratch, we 
2999         subclass NSEvent and override all of the critical methods.
3000
3001         * WebKitTestRunner/EventSenderProxy.h:
3002         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3003         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3004         (WTR::EventSendingController::mouseForceDown):
3005         (WTR::EventSendingController::mouseForceUp):
3006         (WTR::EventSendingController::mouseForceChanged):
3007         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3008         * WebKitTestRunner/TestController.cpp:
3009         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3010         * WebKitTestRunner/mac/EventSenderProxy.mm:
3011         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3012         (-[EventSenderPressureEvent timestamp]):
3013         (-[EventSenderPressureEvent type]):
3014         (-[EventSenderPressureEvent locationInWindow]):
3015         (-[EventSenderPressureEvent location]):
3016         (-[EventSenderPressureEvent stage]):
3017         (-[EventSenderPressureEvent pressure]):
3018         (-[EventSenderPressureEvent phase]):
3019         (-[EventSenderPressureEvent eventNumber]):
3020         (WTR::EventSenderProxy::mouseForceDown):
3021         (WTR::EventSenderProxy::mouseForceUp):
3022         (WTR::EventSenderProxy::mouseForceChanged):
3023
3024 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
3025
3026         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
3027         https://bugs.webkit.org/show_bug.cgi?id=143885
3028
3029         Reviewed by Tim Horton.
3030
3031         Fixed a case where we have two builds with the same revision(s). An in order build
3032         is one for which the revision is strictly higher.
3033
3034         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3035         (BuildbotQueue.prototype._checkForInOrderResult):
3036         (BuildbotQueue.prototype.compareIterationsByRevisions):
3037
3038 2015-04-17  Commit Queue  <commit-queue@webkit.org>
3039
3040         Unreviewed, rolling out r182912 and r182920.
3041         https://bugs.webkit.org/show_bug.cgi?id=143881
3042
3043         Build breakage in some configurations (Requested by ap on
3044         #webkit).
3045
3046         Reverted changesets:
3047
3048         "Force mouse events should go through normal mouse event
3049         handling code paths"
3050         https://bugs.webkit.org/show_bug.cgi?id=143749
3051         http://trac.webkit.org/changeset/182912
3052
3053         http://trac.webkit.org/changeset/182920
3054
3055 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
3056
3057         [GTK] One more unreviewed fix after r182882.
3058
3059         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
3060
3061 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
3062
3063         [GTK] Unreviewed speculative clean build fix after r182882.
3064
3065         TestWebKitAPI's forwarding header generator depended on WeKit2's
3066         which generated SOUP related forwarding headers too.
3067
3068         This dependency isn't necessary and was removed by r182882 to make
3069         forwarding header generators parallelizable. But in this case
3070         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
3071         should generate SOUP related forwarding headers too similar to EFL.
3072
3073         * TestWebKitAPI/PlatformGTK.cmake:
3074         * WebKitTestRunner/PlatformGTK.cmake:
3075
3076 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3077
3078         [SOUP] Redirect to non HTTP destination is broken
3079         https://bugs.webkit.org/show_bug.cgi?id=143866
3080
3081         Reviewed by Sergio Villar Senin.
3082
3083         Add a unit test to check that redirect to a data URI works.
3084
3085         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3086         (testRedirectToDataURI):
3087         (serverCallback):
3088         (beforeAll):
3089
3090 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
3091
3092         Changes method of quitting iOS Simulator to be more correct.
3093         https://bugs.webkit.org/show_bug.cgi?id=143847
3094         <rdar://problem/20530344>
3095
3096         Reviewed by Darin Adler.
3097
3098         Fixes by addressing the app by ID rather than by name.
3099
3100         * Scripts/webkitdirs.pm:
3101         (quitIOSSimulator):
3102         * Scripts/webkitpy/port/ios.py:
3103         (IOSSimulatorPort.check_sys_deps):
3104
3105 2015-04-16  Anders Carlsson  <andersca@apple.com>
3106
3107         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
3108         https://bugs.webkit.org/show_bug.cgi?id=143844
3109
3110         Reviewed by Dan Bernstein.
3111
3112         * MiniBrowser/mac/AppDelegate.m:
3113         (-[BrowserAppDelegate newPrivateWindow:]):
3114         * MiniBrowser/mac/WK2BrowserWindowController.m:
3115         (-[WK2BrowserWindowController initWithConfiguration:]):
3116         (-[WK2BrowserWindowController fetchWebsiteData:]):
3117         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3118         (-[WK2BrowserWindowController clearWebsiteData:]):
3119
3120 2015-04-16  Alex Christensen  <achristensen@webkit.org>
3121
3122         32-bit build fix.
3123
3124         * WebKitTestRunner/mac/TestControllerMac.mm:
3125         (WTR::TestController::platformResetPreferencesToConsistentValues):
3126         (WTR::TestController::platformConfigureViewForTest):
3127         Added WK_API_ENABLED.
3128
3129 2015-04-16  Alex Christensen  <achristensen@webkit.org>
3130
3131         Removed unused WKUserContentFilterRef.
3132         https://bugs.webkit.org/show_bug.cgi?id=143852
3133
3134         Reviewed by Sam Weinig.
3135
3136         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3137         * WebKitTestRunner/mac/TestControllerMac.mm:
3138         (WTR::TestController::platformResetPreferencesToConsistentValues):
3139         (WTR::TestController::platformConfigureViewForTest):
3140
3141 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
3142
3143         Unreviewed. Adding myself as a commiter in contributers.json.
3144
3145         * Scripts/webkitpy/common/config/contributors.json:
3146
3147 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
3148
3149         It is very hard to attach a debugger to WebProcess to debug tests
3150         https://bugs.webkit.org/show_bug.cgi?id=143837
3151
3152         Reviewed by Chris Dumez.
3153
3154         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
3155         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
3156
3157         Now it disables all timeouts in tools, as is best for debugging tests.
3158
3159         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
3160         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
3161
3162         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
3163         now has the same functionality.
3164
3165 2015-04-16  Beth Dakin  <bdakin@apple.com>
3166
3167         Force mouse events should go through normal mouse event handling code paths
3168         https://bugs.webkit.org/show_bug.cgi?id=143749
3169         -and corresponding-
3170         rdar://problem/20472895
3171
3172         Reviewed by Dean Jackson.
3173
3174         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
3175         Since there is not a way to create an NSEventTypePressure from scratch, we 
3176         subclass NSEvent and override all of the critical methods.
3177
3178         * WebKitTestRunner/EventSenderProxy.h:
3179         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3180         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3181         (WTR::EventSendingController::mouseForceDown):
3182         (WTR::EventSendingController::mouseForceUp):
3183         (WTR::EventSendingController::mouseForceChanged):
3184         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3185         * WebKitTestRunner/TestController.cpp:
3186         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3187         * WebKitTestRunner/mac/EventSenderProxy.mm:
3188         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3189         (-[EventSenderPressureEvent timestamp]):
3190         (-[EventSenderPressureEvent type]):
3191         (-[EventSenderPressureEvent locationInWindow]):
3192         (-[EventSenderPressureEvent location]):
3193         (-[EventSenderPressureEvent stage]):
3194         (-[EventSenderPressureEvent pressure]):
3195         (-[EventSenderPressureEvent phase]):
3196         (-[EventSenderPressureEvent eventNumber]):
3197         (WTR::EventSenderProxy::mouseForceDown):
3198         (WTR::EventSenderProxy::mouseForceUp):
3199         (WTR::EventSenderProxy::mouseForceChanged):
3200
3201 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
3202
3203         [EFL] Bump LLVM to version 3.6.0 on X86_64
3204         https://bugs.webkit.org/show_bug.cgi?id=143604
3205
3206         Reviewed by Gyuyoung Kim.
3207
3208         * efl/jhbuild.modules:
3209         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
3210         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
3211         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
3212         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
3213
3214 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
3215
3216         [EFL] Remove an unnecessary workaround from jhbuildrc
3217         https://bugs.webkit.org/show_bug.cgi?id=143823
3218
3219         Reviewed by Gyuyoung Kim.
3220
3221         * efl/jhbuildrc:
3222
3223 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
3224
3225         [GTK] Run forwarding headers generator unconditionally
3226         https://bugs.webkit.org/show_bug.cgi?id=143819
3227
3228         Reviewed by Carlos Garcia Campos.
3229
3230         * TestWebKitAPI/PlatformGTK.cmake:
3231         * WebKitTestRunner/PlatformGTK.cmake:
3232
3233 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3234
3235         [EFL] Add gnutls to jhbuild.module
3236         https://bugs.webkit.org/show_bug.cgi?id=143777
3237
3238         Reviewed by Csaba Osztrogonác.
3239
3240         EFL port has required at least 3.0.0 version of gnutls since r176712.
3241         However some old linux distributions don't support 3.0.0 version. Besides
3242         other projects sometimes need to use lower version of gnutls.
3243
3244         This patch supports to download gnutls through jhbuild, and use it.
3245
3246         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
3247         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
3248
3249 2015-04-15  Mark Lam  <mark.lam@apple.com>
3250
3251         Remove obsolete VMInspector debugging tool.
3252         https://bugs.webkit.org/show_bug.cgi?id=143798
3253
3254         Reviewed by Michael Saboff.
3255
3256         * TestWebKitAPI/CMakeLists.txt:
3257         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3258         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3260         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
3261
3262 2015-04-15  Jer Noble  <jer.noble@apple.com>
3263
3264         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
3265
3266         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3267
3268 2015-04-15  Jer Noble  <jer.noble@apple.com>
3269
3270         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
3271
3272         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3273         (TestWebKitAPI::TEST_F):
3274
3275 2015-04-15  Chris Dumez  <cdumez@apple.com>
3276
3277         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
3278         https://bugs.webkit.org/show_bug.cgi?id=143779
3279
3280         Reviewed by Brent Fulgham.
3281
3282         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
3283         similarly to what is done on Mac / WK1. Without this, PageCache could
3284         stay enabled after page cache tests and cause weird behaviors.
3285
3286         * DumpRenderTree/win/DumpRenderTree.cpp:
3287         (resetWebPreferencesToConsistentValues):
3288
3289 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
3290
3291         Re-enable custom dilation for antialiased fonts
3292         https://bugs.webkit.org/show_bug.cgi?id=143738
3293
3294         Reviewed by Tim Horton.
3295         
3296         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
3297         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
3298         a private WebKit pref. This pref defaults to YES, enabling the feature by default
3299         in WK1 as we do for WK2.
3300
3301         * DumpRenderTree/mac/DumpRenderTree.mm:
3302         (resetWebPreferencesToConsistentValues):
3303         * WebKitTestRunner/TestController.cpp:
3304         (WTR::TestController::resetPreferencesToConsistentValues):
3305
3306 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
3307
3308         Correct layering violation in DumpRenderTree Build
3309         https://bugs.webkit.org/show_bug.cgi?id=143732
3310
3311         Reviewed by Simon Fraser.
3312
3313         Correct a layering violation in DumpRenderTree by calling functions on the
3314         WebCoreTestSupport library, rather than attempting to work with WebCore
3315         types directly.
3316
3317         * DumpRenderTree/mac/EventSendingController.mm:
3318         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
3319         than WebCore itself.,
3320         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
3321
3322 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
3323
3324         Add a conservative DFA minimizer for the content extension matcher
3325         https://bugs.webkit.org/show_bug.cgi?id=143501
3326
3327         Reviewed by Alex Christensen.
3328
3329         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3330         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3331
3332 2015-04-14  Daniel Bates  <dabates@apple.com>
3333
3334         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
3335         https://bugs.webkit.org/show_bug.cgi?id=143693
3336         <rdar://problem/20530316>
3337
3338         Reviewed by Tim Horton.
3339
3340         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
3341         to use the fixed layout code on iOS at this time.
3342
3343         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
3344
3345 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
3346
3347         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
3348         https://bugs.webkit.org/show_bug.cgi?id=143705
3349
3350         Unreviewed change to watchlist file.
3351
3352         * Scripts/webkitpy/common/config/watchlist:
3353
3354 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
3355
3356         [EFL] favicon wasn't updated for google.com sometimes.
3357         https://bugs.webkit.org/show_bug.cgi?id=141940
3358
3359         Reviewed by Gyuyoung Kim.
3360
3361         As elm_entry_utf8_to_markup can include additional characters, parameter for the
3362         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
3363
3364         * MiniBrowser/efl/main.c:
3365         (on_url_changed):
3366
3367 2015-04-13  Tim Horton  <timothy_horton@apple.com>
3368
3369         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
3370         https://bugs.webkit.org/show_bug.cgi?id=143560
3371         <rdar://problem/16302047>
3372
3373         Reviewed by Darin Adler.
3374
3375         * MiniBrowser/mac/BrowserWindowController.h:
3376         * MiniBrowser/mac/MainMenu.xib:
3377         * MiniBrowser/mac/WK1BrowserWindowController.m:
3378         (-[WK1BrowserWindowController setScale:]):
3379         * MiniBrowser/mac/WK2BrowserWindowController.m:
3380         (viewScaleForMenuItemTag):
3381         (-[WK2BrowserWindowController setScale:]):
3382         (-[WK2BrowserWindowController validateMenuItem:]):
3383         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
3384         When in use, we resize the window so that the view fits correctly, and
3385         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
3386         layout size will not change when scaling down (but will update appropriately
3387         when the view is resized).
3388
3389 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
3390
3391         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
3392         https://bugs.webkit.org/show_bug.cgi?id=138630
3393
3394         Reviewed by Tim Horton.
3395
3396         Make sure that we always load at least one in order productive iteration.
3397
3398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3399         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
3400         is done loading at least one iteration that wasn't an out of order build.
3401         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
3402         when that's needed to check for out of order builds.
3403         (BuildbotQueue.prototype.update): Ditto.
3404         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
3405         result, and if it does not, load more iterations.
3406         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
3407         an in order iteration loaded too.
3408         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
3409         corrected to always sort loaded iterations before unloaded ones.
3410
3411 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
3412
3413         Expand test infrastructure to support scrolling tests
3414         https://bugs.webkit.org/show_bug.cgi?id=143286
3415         <rdar://problem/20375516>
3416
3417         Reviewed by Simon Fraser.
3418
3419         Extend the WK1 and WK2 test programs to support two new EventSender commands:
3420         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
3421         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
3422         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
3423         relevant rubberband, scroll, and scroll-snap animations are finished.
3424
3425         * DumpRenderTree/mac/EventSendingController.mm:
3426         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
3427         and 'monitorWheelEvents'.
3428         (+[EventSendingController webScriptNameForSelector:]): Ditto.
3429         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
3430         debugging test failures.
3431         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
3432         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
3433         function, then passes it to WebCore to be called once the test deferrals have been cleared.
3434         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
3435         'callAfterScrollingCompletes' method.
3436         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
3437         and 'monitorWheelEvents'.
3438         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3439         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
3440         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
3441         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
3442         'callAfterScrollingComplates' method.
3443         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3444
3445 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
3446
3447         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
3448         https://bugs.webkit.org/show_bug.cgi?id=143656
3449
3450         Reviewed by Darin Adler.
3451
3452         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3453         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3454
3455 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
3456
3457         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
3458         https://bugs.webkit.org/show_bug.cgi?id=142387
3459
3460         Reviewed by Carlos Garcia Campos.
3461
3462         Running mixed content is blocked by default since r181134. Updated
3463         the test case to reflect the new default settings.
3464
3465         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3466         (testInsecureContent):
3467
3468 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3469
3470         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
3471         https://bugs.webkit.org/show_bug.cgi?id=143667
3472
3473         Reviewed by Csaba Osztrogonác.
3474
3475         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
3476         since r169017. Added $hardwareConcurrencySupport for it.
3477
3478         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
3479
3480         * Scripts/webkitperl/FeatureList.pm:
3481
3482 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
3483
3484         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
3485         https://bugs.webkit.org/show_bug.cgi?id=143664
3486
3487         Reviewed by Gyuyoung Kim.
3488
3489         * Scripts/webkitperl/FeatureList.pm:
3490
3491 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3492
3493         [EFL] Enable Media Source
3494         https://bugs.webkit.org/show_bug.cgi?id=143635
3495
3496         Reviewed by Csaba Osztrogonác.
3497
3498         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
3499
3500 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
3501
3502         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
3503         https://bugs.webkit.org/show_bug.cgi?id=143646
3504
3505         Reviewed by David Kilzer.
3506
3507         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3508         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3509
3510 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
3511
3512         Use en_US spell checker for tests on Mac instead of Multilingual
3513         https://bugs.webkit.org/show_bug.cgi?id=143641
3514
3515         Reviewed by Dan Bernstein.
3516
3517         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3518         While at it, override NSUserDictionaryReplacementItems, so that user replacements
3519         cannot affect tests.
3520
3521         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
3522         Made this more like WebKit1 version.
3523
3524 2015-04-10  Tim Horton  <timothy_horton@apple.com>
3525
3526         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
3527         https://bugs.webkit.org/show_bug.cgi?id=143576
3528
3529         Reviewed by Simon Fraser.
3530
3531         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
3532         (TEST):
3533         Adopt.
3534
3535 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3536
3537         Update my email address and expertise.
3538         https://bugs.webkit.org/show_bug.cgi?id=143586
3539
3540         Unreviewed, just update my info.
3541
3542         * Scripts/webkitpy/common/config/contributors.json:
3543
3544 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
3545
3546         Flakiness Dashboard not loading insecure content if loaded with https URL
3547         https://bugs.webkit.org/show_bug.cgi?id=143570
3548
3549         Reviewed by Alexey Proskuryakov.
3550
3551         * TestResultServer/app.yaml:
3552         * TestResultServer/static-dashboards/loader.js:
3553         Switch to https scheme.
3554
3555 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
3556
3557         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
3558         https://bugs.webkit.org/show_bug.cgi?id=142907
3559
3560         Reviewed by Carlos Garcia Campos.
3561
3562         * TestWebKitAPI/PlatformEfl.cmake:
3563         * TestWebKitAPI/PlatformGTK.cmake:
3564         * WebKitTestRunner/PlatformEfl.cmake:
3565         * WebKitTestRunner/PlatformGTK.cmake:
3566
3567 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
3568
3569         [Mac] Unreviewed test fix after r182584
3570         https://bugs.webkit.org/show_bug.cgi?id=143452
3571
3572         Put both of these tests back to their original state now that the underlying
3573         problem is fixed.
3574
3575         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
3576         (TestWebKitAPI::TEST):
3577         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3578         (TestWebKitAPI::TEST):
3579
3580 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
3581
3582         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
3583         https://bugs.webkit.org/show_bug.cgi?id=143553
3584
3585         Reviewed by Ryosuke Niwa.
3586         
3587         Remove the spurious printVMs left over from an earlier change.
3588
3589         * Scripts/run-jsc-benchmarks:
3590
3591 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
3592
3593         [Mac] Unreviewed test fix after r182581
3594
3595         The behavior of control-left-click is controlled by a system preference.
3596         Our test bots have this turned off.
3597
3598         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
3599         (TestWebKitAPI::TEST):
3600         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3601         (TestWebKitAPI::TEST):
3602
3603 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
3604
3605         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
3606         https://bugs.webkit.org/show_bug.cgi?id=143452
3607         <rdar://problem/20437483>
3608
3609         Reviewed by Tim Horton.
3610
3611         Add a new API test to confirm that Cocoa mouse button press events are properly
3612         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
3613
3614         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
3615         some registered event handlers that the expected button press and context menu
3616         events are received.
3617
3618         The WK1 unit test creates an NSEvent with the desired button press state, and then
3619         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
3620         We check the resulting PlatformMouseEvent for proper state.
3621
3622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
3623         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
3624         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
3625         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
3626         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
3627         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
3628         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
3629         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3630         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
3631         mouse down events.
3632         * TestWebKitAPI/mac/PlatformWebViewMac.h:
3633
3634 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
3635
3636         [GTK] Add pango to jhbuild-optional.modules
3637         https://bugs.webkit.org/show_bug.cgi?id=143537
3638
3639         Reviewed by Martin Robinson.
3640
3641         * gtk/jhbuild-optional.modules: Add pango.
3642
3643 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3644
3645         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
3646         https://bugs.webkit.org/show_bug.cgi?id=143530
3647
3648         Reviewed by Žan Doberšek.
3649
3650         Assume that the default value for display (:0) is reserved and start checking on :1
3651         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
3652         and for X server named Xorg.bin (previous bug 1376599)
3653
3654         * Scripts/webkitpy/port/xvfbdriver.py:
3655         (XvfbDriver._next_free_display)
3656         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3657         (XvfbDriverTest.test_start_no_pixel_tests):
3658         (XvfbDriverTest.test_start_pixel_tests):
3659         (XvfbDriverTest.test_start_arbitrary_worker_number):
3660         (XvfbDriverTest.test_next_free_display):
3661         (XvfbDriverTest.test_start_n