Tools/ChangeLog

   1 2011-01-17  Dan Bernstein  <mitz@apple.com>
   2
   3         Rubber-stamped by Mark Rowe.
   4
   5         Update xcodeproj svn:ignore to include xcuserdata.
   6
   7         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
   8         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
   9         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
  10         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
  11         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
  12
  13 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
  14
  15         Unreviewed fix after r75908.
  16
  17         Move WebKit into Source
  18         https://bugs.webkit.org/show_bug.cgi?id=52530
  19
  20         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
  21
  22 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
  23
  24         Unreviewed.
  25
  26         Remove accidentally committed debug printing after r75908.
  27
  28         * Scripts/webkitdirs.pm:
  29
  30 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
  31
  32         Unreviewed.
  33
  34         Add myself to committers list
  35         https://bugs.webkit.org/show_bug.cgi?id=52566
  36
  37         * Scripts/webkitpy/common/config/committers.py:
  38
  39 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
  40
  41         Reviewed by Jeremy Orlow.
  42
  43         GeolocationController should call stopUpdating on destruction
  44         https://bugs.webkit.org/show_bug.cgi?id=52216
  45
  46         fast/dom/Geolocation/window-close-crash.html requires that a
  47         Geolocation watch be started in a secondary window. Consequently,
  48         we need to allow geolocation permission and provide a mock
  49         geolocation position for the secondary window's
  50         GeolocationClientMock.
  51
  52         * DumpRenderTree/chromium/LayoutTestController.cpp:
  53         (LayoutTestController::setGeolocationPermission):
  54         (LayoutTestController::setMockGeolocationPosition):
  55         (LayoutTestController::setMockGeolocationError):
  56         * DumpRenderTree/chromium/TestShell.h:
  57         (TestShell::windowList):
  58
  59 2011-01-16  Adam Barth  <abarth@webkit.org>
  60
  61         Update more include paths to reflect WebKit move.
  62
  63         * DumpRenderTree/chromium/EventSender.cpp:
  64         (EventSender::keyDown):
  65         (EventSender::needsShiftModifier):
  66         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
  67         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
  68
  69 2011-01-16  Kent Tamura  <tkent@chromium.org>
  70
  71         Unreviewed, Chromium build fix.
  72
  73         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
  74
  75 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
  76
  77         Build fix for GTK+ after source directory movement.
  78
  79         * GNUmakefile.am: Correct include paths.
  80
  81 2011-01-16  Adam Barth  <abarth@webkit.org>
  82
  83         Teach svn-apply about WebKit move.
  84
  85         * Scripts/VCSUtils.pm:
  86
  87 2011-01-16  Adam Barth  <abarth@webkit.org>
  88
  89         Rubber-stamped by Eric Seidel.
  90
  91         Move WebKit into Source
  92         https://bugs.webkit.org/show_bug.cgi?id=52530
  93
  94         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
  95         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  96         * DumpRenderTree/qt/DumpRenderTreeQt.h:
  97         * DumpRenderTree/qt/GCControllerQt.cpp:
  98         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  99         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
 100         * DumpRenderTree/qt/TextInputControllerQt.cpp:
 101         * DumpRenderTree/wscript:
 102         * QtTestBrowser/launcherwindow.h:
 103         * Scripts/build-webkit:
 104         * Scripts/webkitdirs.pm:
 105
 106 2011-01-15  Adam Barth  <abarth@webkit.org>
 107
 108         Teach svn-apply about WebKit2 move.
 109
 110         * Scripts/VCSUtils.pm:
 111
 112 2011-01-15  Adam Barth  <abarth@webkit.org>
 113
 114         Rubber-stamped by Eric Seidel.
 115
 116         Move WebKit2 into Source
 117         https://bugs.webkit.org/show_bug.cgi?id=52438
 118
 119         * MiniBrowser/qt/MiniBrowser.pro:
 120         * Scripts/build-webkit:
 121         * Scripts/do-file-rename:
 122         * Scripts/do-webcore-rename:
 123         * Scripts/test-webkitpy:
 124         * Scripts/webkitdirs.pm:
 125         * Scripts/webkitpy/style/checker.py:
 126         * WebKitTestRunner/DerivedSources.pro:
 127         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 128         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 129
 130 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
 131
 132         Reviewed by David Levin.
 133
 134         [chromium] remove obsolete createView method
 135         https://bugs.webkit.org/show_bug.cgi?id=52437
 136
 137         * DumpRenderTree/chromium/WebViewHost.cpp:
 138         (WebViewHost::createView):
 139         * DumpRenderTree/chromium/WebViewHost.h:
 140
 141 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
 142
 143         Reviewed by Geoff Garen.
 144
 145         ShouldLoadResourceForFrame should use strings, not URLs.
 146         https://bugs.webkit.org/show_bug.cgi?id=52476
 147
 148         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 149         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
 150         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 151
 152 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 153
 154         Reviewed by David Levin.
 155
 156         Add Tony Gentilcore as a reviewer
 157         https://bugs.webkit.org/show_bug.cgi?id=52480
 158
 159         * Scripts/webkitpy/common/config/committers.py:
 160
 161 2011-01-14  David Levin  <levin@chromium.org>
 162
 163         Reviewed by Eric Seidel.
 164
 165         check-webkit-style: _FunctionState should keep track of where the function name starts.
 166         https://bugs.webkit.org/show_bug.cgi?id=52454
 167
 168         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
 169         _FunctionState and logic for setting it correctly.
 170         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
 171
 172 2011-01-14  Vincent Scheib  <scheib@chromium.org>
 173
 174         Reviewed by David Levin.
 175
 176         Add support to DumpRenderTree to use the GPU rather than software renderer
 177         https://bugs.webkit.org/show_bug.cgi?id=52333
 178
 179         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 180         (main):
 181         * Scripts/webkitpy/layout_tests/port/chromium.py:
 182         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 183
 184 2011-01-14  Tony Chang  <tony@chromium.org>
 185
 186         Reviewed by Kent Tamura.
 187
 188         [chromium] update fonts.conf to fix 6 linux tests in drt
 189         https://bugs.webkit.org/show_bug.cgi?id=52411
 190
 191         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
 192             chromium's src/webkit/tools/test_shell/resources/fonts.conf
 193
 194 2011-01-14  Eric Seidel  <eric@webkit.org>
 195
 196         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
 197
 198         Reviewed by Adam Barth.
 199
 200         Fix when running Tools/Scripts/check-webkit-style without arguments.
 201         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
 202
 203         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
 204         * Scripts/webkitpy/common/checkout/scm_unittest.py:
 205
 206 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
 207
 208         Reviewed by David Levin.
 209
 210         Store the tempdir object in a variable so it doesn't get deleted too early.
 211         https://bugs.webkit.org/show_bug.cgi?id=51875
 212
 213         * Scripts/update-webkit-auxiliary-libs:
 214         * Scripts/update-webkit-support-libs:
 215
 216 2011-01-14  Eric Seidel  <eric@webkit.org>
 217
 218         Unreviewed.  Make it work in python 2.5.
 219
 220         webkit-patch suggest-reviewers dies when ChangeLogs are missing
 221         https://bugs.webkit.org/show_bug.cgi?id=49158
 222
 223         * Scripts/webkitpy/common/checkout/api_unittest.py:
 224
 225 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
 226
 227         Unreviewed, rolling out r75774.
 228         http://trac.webkit.org/changeset/75774
 229         https://bugs.webkit.org/show_bug.cgi?id=52431
 230
 231         gtk builds were broken (Requested by loislo2 on #webkit).
 232
 233         * Scripts/webkitpy/common/checkout/scm.py:
 234
 235 2011-01-14  David Levin  <levin@chromium.org>
 236
 237         Reviewed by Shinichiro Hamaji.
 238
 239         check-webkit-style: _FunctionState should detect pure functions.
 240         https://bugs.webkit.org/show_bug.cgi?id=52428
 241
 242         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
 243         is a pure virtual function.
 244         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
 245         virtual functions are correctly detected.
 246
 247 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
 248
 249         Reviewed by Yury Semikhatsky.
 250
 251         Just small fix for problem with check-webkit-style.
 252         It just didn't work for this patch.
 253         Old code can't concatenate a list of strings with None.
 254
 255         * Scripts/webkitpy/common/checkout/scm.py:
 256
 257 2011-01-13  David Levin  <levin@chromium.org>
 258
 259         Reviewed by Shinichiro Hamaji.
 260
 261         check-webkit-style: _FunctionState should use Position to know where items are.
 262         https://bugs.webkit.org/show_bug.cgi?id=52424
 263
 264         * Scripts/webkitpy/style/checkers/cpp.py:
 265         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
 266         (detect_functions): Changed to pass Position's to _FunctionState.begin and
 267         did some minor clean-up.
 268         (*): Other changes are simply about converting to use the Position's in_FunctionState
 269         instead of line numbers.
 270         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
 271         to verify the positions stored in _FunctionState.
 272
 273 2011-01-13  Eric Seidel  <eric@webkit.org>
 274
 275         Reviewed by David Levin.
 276
 277         webkit-patch suggest-reviewers dies when ChangeLogs are missing
 278         https://bugs.webkit.org/show_bug.cgi?id=49158
 279
 280         This is not the most elegant, but it is a very safe fix to this bug.
 281         One advantage of catching ScriptError like this instead of adding a
 282         new added_or_modified_files or fixing all changed_files callers
 283         to use a more specific change_files variant, is that we catch
 284         all kinds of ScriptErrors which might cause our (non-essential)
 285         suggest-reviewers code to fail out.  This should make passing
 286         --suggest-reviewers to webkit-patch upload much more robust
 287         and may even make it possible for us to make it default.
 288
 289         The root of the problem here is that SCM.changed_files includes
 290         deleted ChangeLog paths (from moves, etc) which then when we ask
 291         SVN/Git for the contents of the file at that revision, the command
 292         errors out and Executive.run_command raises a ScriptError.
 293
 294         In the future we might fix this differently by making all current
 295         callers of chagned_files use a more specific method for requesting
 296         what types of changes they're interested in (adds, modifies, deletes, etc.)
 297
 298         * Scripts/webkitpy/common/checkout/api.py:
 299         * Scripts/webkitpy/common/checkout/api_unittest.py:
 300
 301 2011-01-13  Dan Bernstein  <mitz@apple.com>
 302
 303         Reviewed by Alexey Proskuryakov.
 304
 305         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
 306         https://bugs.webkit.org/show_bug.cgi?id=52419
 307
 308         Allow to further control the behavior of the willSendRequest delegate callback by making it
 309         set a different URL in the new request.
 310
 311         * DumpRenderTree/LayoutTestController.cpp:
 312         (addURLToRedirectCallback): Added.
 313         (LayoutTestController::staticFunctions): Added addURLToRedirect.
 314         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
 315         (LayoutTestController::redirectionDestinationForURL): Added this getter.
 316         * DumpRenderTree/LayoutTestController.h:
 317         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 318         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
 319         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
 320         change the URL in the new request to the redirect destination.
 321
 322 2011-01-13  Eric Seidel  <eric@webkit.org>
 323
 324         Reviewed by Mihai Parparita.
 325
 326         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
 327         https://bugs.webkit.org/show_bug.cgi?id=52416
 328
 329         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717
 330         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
 331
 332         I also added FIXMEs about the changed_files returning deleted files problem
 333         which is causing the other most common exception for suggest-reviewers
 334         (and is probably breaking sheriff-bots blame detection).
 335
 336         * Scripts/webkitpy/common/checkout/api.py:
 337         * Scripts/webkitpy/common/checkout/api_unittest.py:
 338         * Scripts/webkitpy/common/checkout/scm.py:
 339
 340 2011-01-13  Eric Seidel  <eric@webkit.org>
 341
 342         Reviewed by Adam Barth.
 343
 344         results archives from commit-queue are too large to upload
 345         https://bugs.webkit.org/show_bug.cgi?id=52405
 346
 347         * Scripts/webkitpy/common/system/filesystem.py:
 348         * Scripts/webkitpy/common/system/filesystem_mock.py:
 349         * Scripts/webkitpy/tool/commands/queues.py:
 350
 351 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
 352
 353         Reviewed by Martin Robinson.
 354
 355         [gtk] Zero-sized font does not yet work
 356         https://bugs.webkit.org/show_bug.cgi?id=49793
 357
 358         Set minimum-font-size to 0 for the DRT.
 359
 360         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 361         (resetDefaultsToConsistentValues):
 362
 363 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
 364
 365         Reviewed by Darin Adler.
 366
 367         Make old-run-webkit-tests more robust on buildbots
 368         https://bugs.webkit.org/show_bug.cgi?id=52364
 369
 370         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
 371
 372 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
 373
 374         Reviewed by Darin Adler.
 375
 376         Make old-run-webkit-tests more robust on buildbots
 377         https://bugs.webkit.org/show_bug.cgi?id=52364
 378
 379         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
 380
 381 2011-01-13  Tony Chang  <tony@chromium.org>
 382
 383         Reviewed by Kent Tamura.
 384
 385         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
 386         https://bugs.webkit.org/show_bug.cgi?id=52332
 387
 388         Forked Info.plist is not longer needed.
 389
 390         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
 391
 392 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
 393
 394         Reviewed by Timothy Hatcher.
 395
 396         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
 397         to be passed directly to WebInspector.UIString
 398
 399         https://bugs.webkit.org/show_bug.cgi?id=52365
 400
 401         * Scripts/check-inspector-strings:
 402
 403 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
 404
 405         Unreviewed, rolling out r74881.
 406         http://trac.webkit.org/changeset/74881
 407         https://bugs.webkit.org/show_bug.cgi?id=52357
 408
 409         The EFL builder has been red for days (Requested by abarth on
 410         #webkit).
 411
 412         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
 413         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
 414
 415 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 416
 417         Reviewed by David Levin.
 418
 419         Add beforeunload support to WebKitTestRunner
 420         https://bugs.webkit.org/show_bug.cgi?id=52353
 421
 422         This makes a number of currently failing tests pass.
 423
 424         * WebKitTestRunner/TestController.cpp:
 425         (WTR::runBeforeUnloadConfirmPanel):
 426         (WTR::createOtherPage):
 427         (WTR::TestController::initialize):
 428
 429 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 430
 431         Reviewed by Sam Weinig.
 432
 433         Detect, identify and recover from WebProcess crashes in run-webkit-tests
 434         https://bugs.webkit.org/show_bug.cgi?id=52330
 435
 436         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
 437         a web process crash.
 438         * WebKitTestRunner/TestController.cpp:
 439         (WTR::TestController::initialize): Set up a processDidCrash
 440         callback.
 441         (WTR::TestController::processDidCrash): Report that the Web process
 442         crashed.
 443         * WebKitTestRunner/TestController.h:
 444
 445 2011-01-12  David Levin  <levin@chromium.org>
 446
 447         Reviewed by Shinichiro Hamaji.
 448
 449         check-webkit-style -- close_expression function doesn't work correctly.
 450         https://bugs.webkit.org/show_bug.cgi?id=52272
 451
 452         * Scripts/webkitpy/style/checkers/cpp.py:
 453         (Position.__str__): Added a way to convert it to a string which is useful in tests.
 454         (Position.__cmp__): Added a way to compare Position which is useful in tests and
 455         generally useful (for upcoming code changes).
 456         (close_expression): Changed to use Position for input and output.
 457         Also, fixed many bugs such as only working correctly for parenthesis,
 458         not working correctly if given an offset in a line and not finding
 459         the real closing element if there were multiple closing elements in
 460         the same line.
 461         (detect_functions): Adjusted due to the change in arguments for
 462         close_expression.
 463         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 464         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
 465         two positions are the same.
 466         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
 467         (CppStyleTest.test_close_expression): Added tests to catch the issues
 468         that were fixed.
 469
 470 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
 471
 472         Unreviewed, rolling out r75576.
 473         http://trac.webkit.org/changeset/75576
 474         https://bugs.webkit.org/show_bug.cgi?id=52304
 475
 476         broke rebaseline-chromium-webkit-test (Requested by thakis on
 477         #webkit).
 478
 479         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 480         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 481         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 482         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 483         * Scripts/webkitpy/layout_tests/port/base.py:
 484         * Scripts/webkitpy/layout_tests/port/chromium.py:
 485         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 486         * Scripts/webkitpy/layout_tests/port/test.py:
 487         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 488         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 489         * Scripts/webkitpy/style/checkers/test_expectations.py:
 490         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
 491
 492 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 493
 494         Reviewed by Darin Adler.
 495
 496         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
 497         https://bugs.webkit.org/show_bug.cgi?id=52307
 498
 499         * Scripts/old-run-webkit-tests:
 500
 501 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
 502
 503         Reviewed by Martin Robinson.
 504
 505         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
 506         https://bugs.webkit.org/show_bug.cgi?id=50867
 507
 508         Fixed library extention for Mac in webkitdirs.pm and type conflict in
 509         TestNetscapePlugin.cpp
 510
 511         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
 512         * Scripts/webkitdirs.pm:
 513
 514 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
 515
 516         Reviewed by Pavel Feldman.
 517
 518         Add check-inspector-strings script.
 519
 520         https://bugs.webkit.org/show_bug.cgi?id=52295
 521
 522         * Scripts/check-inspector-strings: Added.
 523
 524 2011-01-12  Adam Roben  <aroben@apple.com>
 525
 526         Advertise the .testnetscape file extension on Windows
 527
 528         Fixes <http://webkit.org/b/52298>
 529         plugins/no-mime-with-valid-extension.html fails on Windows
 530
 531         Reviewed by Dan Bernstein.
 532
 533         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
 534         FileExtents field to map the .testnetscape file extension to the
 535         application/x-webkit-test-netscape MIME type, just as we do on Mac.
 536
 537 2011-01-12  Adam Barth  <abarth@webkit.org>
 538
 539         Reviewed by Eric Seidel.
 540
 541         Make webkit-patch support subdirectories for SVN checkouts
 542         https://bugs.webkit.org/show_bug.cgi?id=52261
 543
 544         os.relpath does not exist on Python 2.5, so we need to call our version
 545         of the API.
 546
 547         * Scripts/webkitpy/common/checkout/scm.py:
 548
 549 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
 550
 551         Reviewed by Eric Seidel.
 552
 553         Close additional pages opened during a test once the test completes.
 554         https://bugs.webkit.org/show_bug.cgi?id=52276
 555
 556         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 557         (WTR::InjectedBundle::done):
 558
 559 2011-01-11  David Levin  <levin@chromium.org>
 560
 561         Reviewed by Eric Seidel.
 562
 563         Errors should be separated from the command line in bot messages.
 564         https://bugs.webkit.org/show_bug.cgi?id=52275
 565
 566         * Scripts/webkitpy/common/system/executive.py:
 567         (ScriptError.message_with_output): Added a newline to separate the command
 568         line from the errors.
 569         * Scripts/webkitpy/common/system/executive_unittest.py:
 570         (ScriptErrorTest.test_message_with_output): Added tests for the various code
 571         paths in message_with_output.
 572
 573 2011-01-11  Eric Seidel  <eric@webkit.org>
 574
 575         Unreviewed.
 576
 577         commit-queue should know how to upload archived results (for test flakes or general failures)
 578         https://bugs.webkit.org/show_bug.cgi?id=52048
 579
 580         The zips are mostly empty due to forgetting -r.
 581         Expected diffs were not being pulled from the archive due
 582         to the archive having longer paths than I realized.
 583
 584         * Scripts/webkitpy/common/system/workspace.py:
 585         * Scripts/webkitpy/common/system/workspace_unittest.py:
 586         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 587         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 588
 589 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
 590
 591         Reviewed by Ojan Vafai.
 592
 593         The current modifier parsing code in test_expectations is
 594         fragile and hard-coded, so it's not easy to understand the logic
 595         or easily add new types of modifiers (like GPU vs. CPU testing
 596         for graphics tests, or 32-bit vs. 64-bit differences).
 597
 598         This is the first of two patches that will add in more generic
 599         support and then eliminate the GPU-specific test expectations
 600         files for Chromium.
 601
 602         This patch adds two standalone objects for handling modifiers. The
 603         rules for interpreting modifiers, precedence, and conflicts are
 604         given in the docstring to the ModifierMatcher class, which
 605         returns ModifierMatchResult objects.
 606
 607         This patch also adds routines to the Port interface and a
 608         default set of values in the base object, in order to obtain the
 609         values needed on a given test run. These values are then passed
 610         to the expectation parser. This also allows us to clean up the
 611         logic used to lint all of the different configurations in a
 612         single test_expectations.txt file.
 613
 614         The next patch will merge in the separate GPU expectations file.
 615
 616         https://bugs.webkit.org/show_bug.cgi?id=51222
 617
 618         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 619         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 620         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 621         * Scripts/webkitpy/layout_tests/port/base.py:
 622         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 623         * Scripts/webkitpy/layout_tests/port/chromium.py:
 624         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 625         * Scripts/webkitpy/layout_tests/port/test.py:
 626         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 627         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 628
 629 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
 630
 631         Reviewed by Adam Barth.
 632
 633         Make webkit-patch support subdirectories for SVN checkouts
 634         https://bugs.webkit.org/show_bug.cgi?id=52261
 635
 636         * Scripts/webkitpy/common/checkout/scm.py:
 637         * Scripts/webkitpy/style_references.py:
 638         * Scripts/webkitpy/tool/main.py:
 639         * Scripts/webkitpy/tool/steps/preparechangelog.py:
 640
 641 2011-01-11  Eric Seidel  <eric@webkit.org>
 642
 643         Unreviewed.
 644
 645         commit-queue should know how to upload archived results (for test flakes or general failures)
 646         https://bugs.webkit.org/show_bug.cgi?id=52048
 647
 648         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
 649         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
 650
 651         * Scripts/webkitpy/common/system/workspace.py:
 652         * Scripts/webkitpy/common/system/workspace_unittest.py:
 653         * Scripts/webkitpy/tool/commands/queues.py:
 654
 655 2011-01-11  Sam Weinig  <sam@webkit.org>
 656
 657         Roll r75474 back in.
 658
 659 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
 660
 661         Reviewed by Kenneth Rohde Christiansen.
 662
 663         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
 664         https://bugs.webkit.org/show_bug.cgi?id=51204
 665
 666         * QtTestBrowser/webpage.h:
 667         (QtNAMThread::QtNAMThread):
 668         (QtNAMThread::networkAccessManager):
 669         (QtNAMThread::run):
 670
 671 2011-01-11  Peter Varga  <pvarga@webkit.org>
 672
 673         Unreviewed.
 674
 675         Add myself to committers' list.
 676
 677         * Scripts/webkitpy/common/config/committers.py:
 678
 679 2011-01-11  Eric Seidel  <eric@webkit.org>
 680
 681         Reviewed by Adam Barth.
 682
 683         commit-queue should know how to upload archived results (for test flakes or general failures)
 684         https://bugs.webkit.org/show_bug.cgi?id=52048
 685
 686         Now the queue will always upload results.  Either the entire zip, or just
 687         the diffs.txt in the case of text failures.
 688
 689         This should make understanding flakes much easier, and paves the way
 690         for having the EWS run layout tests (and upload failures).
 691
 692         In order to upload .zip files I had to teach bugzilla.py to autodetect
 693         mime types from the filename.  Since mimetypes.py doesn't include a mapping
 694         for .patch files, I have it add one before calling guess_type.
 695
 696         We may find that always uploading the whole zip instead of just the -diffs.txt
 697         file is preferable, but for now I'm keeping the old behavior because it makes
 698         quickly understanding text failures easy.
 699
 700         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 701         * Scripts/webkitpy/common/system/workspace.py: Added.
 702         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
 703         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 704         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 705         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 706         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 707         * Scripts/webkitpy/tool/commands/queues.py:
 708         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 709
 710 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
 711
 712         Unreviewed, rolling out r75464.
 713         http://trac.webkit.org/changeset/75464
 714         https://bugs.webkit.org/show_bug.cgi?id=52193
 715
 716         Followup rollout for 75474 (Requested by Ossy on #webkit).
 717
 718         * MiniBrowser/mac/BrowserWindowController.m:
 719         (-[BrowserWindowController awakeFromNib]):
 720         * MiniBrowser/win/BrowserView.cpp:
 721         (BrowserView::create):
 722         * WebKitTestRunner/TestController.cpp:
 723         (WTR::createOtherPage):
 724         (WTR::TestController::initialize):
 725
 726 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 727
 728         Reviewed by Csaba Osztrogonác.
 729
 730         [Qt] Baseline qt_minimal configuration
 731         https://bugs.webkit.org/show_bug.cgi?id=51313
 732
 733         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 734         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
 735         QT_NO_UNDOSTACK guard.
 736
 737         * QtTestBrowser/launcherwindow.cpp:
 738         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
 739         guards.
 740         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
 741         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
 742         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
 743         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
 744
 745         * QtTestBrowser/launcherwindow.h:
 746         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
 747         * QtTestBrowser/locationedit.h: Ditto.
 748
 749         * QtTestBrowser/mainwindow.cpp:
 750         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
 751         QT_NO_UNDOSTACK guards.
 752         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
 753         (MainWindow::changeLocation): Ditto.
 754         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
 755         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
 756
 757         * QtTestBrowser/webpage.cpp:
 758         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
 759         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
 760
 761         * QtTestBrowser/webview.cpp:
 762         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
 763         (WebViewGraphicsBased::animatedYFlip): Ditto.
 764
 765 2011-01-10  Sam Weinig  <sam@webkit.org>
 766
 767         Fix build.
 768
 769         * MiniBrowser/mac/BrowserWindowController.m:
 770         (-[BrowserWindowController awakeFromNib]):
 771         * MiniBrowser/win/BrowserView.cpp:
 772         (BrowserView::create):
 773         * WebKitTestRunner/TestController.cpp:
 774         (WTR::createOtherPage):
 775         (WTR::TestController::initialize):
 776
 777 2011-01-10  Eric Seidel  <eric@webkit.org>
 778
 779         Reviewed by Ojan Vafai.
 780
 781         style-queue messages are way too long for big patches
 782         https://bugs.webkit.org/show_bug.cgi?id=52161
 783
 784         We definitely could build much fancier list-to-string-with-limit functions
 785         but this should be sufficient for our needs at the moment.
 786
 787         * Scripts/webkitpy/common/system/executive.py:
 788         * Scripts/webkitpy/common/system/executive_unittest.py:
 789
 790 2011-01-10  Tony Chang  <tony@chromium.org>
 791
 792         Unreviewed, rolling out r75398.
 793         http://trac.webkit.org/changeset/75398
 794         https://bugs.webkit.org/show_bug.cgi?id=52008
 795
 796         Some layout tests are crashing on Chromium Win.
 797
 798         * DumpRenderTree/chromium/WebViewHost.cpp:
 799         (WebViewHost::updatePaintRect):
 800         * DumpRenderTree/chromium/WebViewHost.h:
 801
 802 2011-01-10  Adam Roben  <aroben@apple.com>
 803
 804         Roll out r75392
 805
 806         It isn't needed now that r75289 has been rolled out.
 807
 808         * Scripts/run-javascriptcore-tests:
 809
 810 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
 811
 812         Reviewed by Anders Carlsson.
 813
 814         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
 815         https://bugs.webkit.org/show_bug.cgi?id=52160
 816
 817         * WebKitTestRunner/mac/TestControllerMac.mm:
 818         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
 819         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
 820         anyway.
 821
 822 2011-01-10  Tony Chang  <tony@chromium.org>
 823
 824         Reviewed by Mihai Parparita.
 825
 826         [chromium] fix for animated gif layout tests
 827         https://bugs.webkit.org/show_bug.cgi?id=52008
 828
 829         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
 830             to trigger gif animations.
 831         (WebViewHostPaintTask::WebViewHostPaintTask):
 832         (WebViewHostPaintTask::runIfValid):
 833         (WebViewHost::updatePaintRect):
 834         * DumpRenderTree/chromium/WebViewHost.h:
 835         (WebViewHost::taskList):
 836
 837 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
 838
 839         Reviewed by Xan Lopez.
 840
 841         [GTK] Fix gtk2 compilation for master
 842         https://bugs.webkit.org/show_bug.cgi?id=51885
 843
 844         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
 845         (createBitmapContextFromWebView): Replaced the old
 846         gdk_drawable_get_size with gdk_pixmap_get_size.
 847
 848 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
 849
 850         Reviewed by Laszlo Gombos.
 851
 852         [WINCE] Reenable NPAPI after r75203
 853         https://bugs.webkit.org/show_bug.cgi?id=52109
 854
 855         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
 856         it with !isEfl(), because EFL port does not support NPAPI (yet).
 857
 858         * Scripts/build-webkit:
 859
 860 2011-01-10  Adam Roben  <aroben@apple.com>
 861
 862         Skip some asserting JS tests
 863
 864         See <http://webkit.org/b/52156>.
 865
 866         * Scripts/run-javascriptcore-tests:
 867
 868 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
 869
 870         Reviewed by Xan Lopez.
 871
 872         [GTK] build-webkit disable Blob support via arguments passed to automake
 873         https://bugs.webkit.org/show_bug.cgi?id=52097
 874
 875         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
 876         build-webkit.
 877
 878 2011-01-10  Adam Roben  <aroben@apple.com>
 879
 880         Use the same name and description for TestNetscapePlugin on Windows and
 881         Mac
 882
 883         Fixes <http://webkit.org/b/52151>
 884         fast/frames/iframe-reparenting-plugins.html fails on Windows
 885
 886         Reviewed by Steve Falkenburg.
 887
 888         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
 889         the name and description from Mac's Info.plist.
 890
 891 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
 892
 893         Reviewed by Laszlo Gombos.
 894
 895         [Qt][WK2] Guard gcc-specific syntax
 896
 897         Non-gcc based compliers choke on the "-include"
 898         syntax for preinclude, place guard around it.
 899
 900         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 901         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 902
 903 2011-01-10  Andreas Kling  <kling@webkit.org>
 904
 905         Reviewed by Simon Hausmann.
 906
 907         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
 908         https://bugs.webkit.org/show_bug.cgi?id=52111
 909
 910         When getting a createNewPage() callback from QWKPage, create the
 911         new page with the same QWKContext as the page that is passed to
 912         the callback.
 913
 914         * MiniBrowser/qt/BrowserView.h:
 915         * MiniBrowser/qt/BrowserWindow.cpp:
 916         (newPageFunction):
 917         (BrowserWindow::BrowserWindow):
 918         * MiniBrowser/qt/BrowserWindow.h:
 919
 920 2011-01-10  Andreas Kling  <kling@webkit.org>
 921
 922         Reviewed by Kenneth Rohde Christiansen.
 923
 924         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
 925
 926         BrowserView set its own useless createNewPage() callback on QWKPage.
 927         This was immediately overridden by BrowserWindow anyway, so remove
 928         the BrowserView one.
 929
 930         * MiniBrowser/qt/BrowserView.cpp:
 931         (BrowserView::BrowserView):
 932
 933 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
 934
 935         Reviewed by Jeremy Orlow.
 936
 937         [Chromium] Remove non-client-based Geolocation code
 938         https://bugs.webkit.org/show_bug.cgi?id=50921
 939
 940         * DumpRenderTree/chromium/LayoutTestController.cpp:
 941         (LayoutTestController::setGeolocationPermission):
 942         (LayoutTestController::setMockGeolocationPosition):
 943         (LayoutTestController::setMockGeolocationError):
 944         * DumpRenderTree/chromium/WebViewHost.cpp:
 945         (WebViewHost::geolocationClientMock):
 946         (WebViewHost::reset):
 947         * DumpRenderTree/chromium/WebViewHost.h:
 948
 949 2011-01-10  Eric Seidel  <eric@webkit.org>
 950
 951         Reviewed by Adam Barth.
 952
 953         Commit bot tried to land r? cq+ patch
 954         https://bugs.webkit.org/show_bug.cgi?id=36638
 955
 956         It should now be possible to post a patch with r? and cq+ and the
 957         commit-queue will correctly wait for the r+ before attempting to land the patch.
 958         (This was a feature requested by several users.)
 959
 960         One caveat: We don't actually reject r-, cq+ patches from the queue
 961         (we just ignore them), but I think that's OK for now.
 962
 963         I also noticed that setting r- once a commit-queue node had grabbed
 964         a patch would not properly cancel the landing.  That's fixed and
 965         tested in this patch.
 966
 967         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 968         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 969         * Scripts/webkitpy/tool/bot/feeders.py:
 970         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
 971
 972 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
 973
 974         Reviewed by Kenneth Rohde Christiansen.
 975
 976         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
 977         https://bugs.webkit.org/show_bug.cgi?id=51934
 978
 979         When accessing the network from the destructor of QWebPage, the network access manager
 980         was already deleted because the object WebPage was already destructed.
 981
 982         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
 983         The object is now destructed in the destructor of QObject.
 984
 985         * QtTestBrowser/webpage.cpp:
 986         (WebPage::WebPage):
 987         (WebPage::setQnamThreaded):
 988         * QtTestBrowser/webpage.h:
 989         (QtNAMThread::QtNAMThread):
 990
 991 2011-01-08  Eric Seidel  <eric@webkit.org>
 992
 993         Reviewed by Ojan Vafai.
 994
 995         test_failures.py should not mention TestShell (long live DumpRenderTree!)
 996         https://bugs.webkit.org/show_bug.cgi?id=52067
 997
 998         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
 999         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1000
1001         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1002
1003 2011-01-08  Eric Seidel  <eric@webkit.org>
1004
1005         Reviewed by Mihai Parparita.
1006
1007         commit-queue hangs when the ChangeLog diff is bad
1008         https://bugs.webkit.org/show_bug.cgi?id=52072
1009
1010         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1011         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1012
1013 2011-01-08  Adam Barth  <abarth@webkit.org>
1014
1015         Teach svn-apply how to re-write WebCore to Source/WebCore.
1016
1017         * Scripts/VCSUtils.pm:
1018
1019 2011-01-07  Adam Barth  <abarth@webkit.org>
1020
1021         Rubber-stamped by Eric Seidel.
1022
1023         Move WebCore to Source
1024         https://bugs.webkit.org/show_bug.cgi?id=52050
1025
1026         Update the tools to understand WebCore's new location.
1027
1028         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1029         * DumpRenderTree/wscript:
1030         * GNUmakefile.am:
1031         * Scripts/build-webkit:
1032         * Scripts/do-file-rename:
1033         * Scripts/do-webcore-rename:
1034         * Scripts/generate-qt-inspector-resource:
1035         * Scripts/prepare-ChangeLog:
1036         * Scripts/run-bindings-tests:
1037         * Scripts/update-iexploder-cssproperties:
1038         * Scripts/update-sources-list.py:
1039         * Scripts/update-webkit-localizable-strings:
1040         * Scripts/webkitdirs.pm:
1041         * Scripts/webkitpy/common/config/build.py:
1042         * Scripts/webkitpy/common/config/build_unittest.py:
1043         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1044         * Scripts/webkitpy/style/checker.py:
1045         * Scripts/webkitpy/style/checker_unittest.py:
1046         * WebKitTestRunner/DerivedSources.pro:
1047         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1048         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1049         * wx/browser/wscript:
1050         * wx/build/settings.py:
1051
1052 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1053
1054         Reviewed by Sam Weinig.
1055
1056         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1057         https://bugs.webkit.org/show_bug.cgi?id=52086
1058
1059         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1060         (WTR::InjectedBundle::didReceiveMessage):
1061         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1062         (WTR::LayoutTestController::notifyDone):
1063         * WebKitTestRunner/TestController.cpp:
1064         (WTR::TestController::resetStateToConsistentValues):
1065         (WTR::TestController::run):
1066
1067 2011-01-07  James Robinson  <jamesr@chromium.org>
1068
1069         Revert "Implement mozilla's animationTime property"
1070         https://bugs.webkit.org/show_bug.cgi?id=51952
1071
1072         This approach isn't quite right.
1073
1074         * DumpRenderTree/chromium/WebViewHost.cpp:
1075         (WebViewHost::paintInvalidatedRegion):
1076
1077 2011-01-07  Adam Roben  <aroben@apple.com>
1078
1079         Build master fix
1080
1081         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1082         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1083
1084 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1085
1086         Reviewed by Csaba Osztrogonác.
1087
1088         run-qtwebkit-tests should be able to kill a testsuite.
1089
1090         Add new option in the script that can setup a timeout for a test.
1091         If the test execution takes more then specified time then the test
1092         would be terminated.
1093
1094         [Qt] run-qtwebkit-tests needs timeout
1095         https://bugs.webkit.org/show_bug.cgi?id=51894
1096
1097         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1098         * Scripts/run-qtwebkit-tests:
1099
1100 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1101
1102         Unreviewed fix after r75233.
1103
1104         Based on idea from Eric Seidel.
1105
1106         Add remote zip file handling to webkitpy.
1107         https://bugs.webkit.org/show_bug.cgi?id=50901
1108
1109         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1110
1111 2011-01-07  Shane Stephens  <shanestephens@google.com>
1112
1113         Reviewed by Eric Seidel.
1114
1115         svn-apply: should support git binary delta diffs
1116         https://bugs.webkit.org/show_bug.cgi?id=38864
1117
1118         * Scripts/VCSUtils.pm:
1119         * Scripts/svn-apply:
1120
1121 2011-01-06  Julie Parent  <jparent@chromium.org>
1122
1123         Reviewed by Eric Seidel.
1124
1125         Test Result Server not removing old results.
1126         https://bugs.webkit.org/show_bug.cgi?id=52012
1127
1128         * TestResultServer/model/jsonresults.py:
1129         Fix off-by-one: Truncate if >= num_runs, not just >.
1130         * TestResultServer/model/jsonresults_unittest.py:
1131         Add unit test to test that merging in a new result with the same value
1132         as the last result causes previous result to fall off.
1133
1134 2011-01-06  James Kozianski  <koz@chromium.org>
1135
1136         Reviewed by Mihai Parparita.
1137
1138         Add classes to provide a consistent interface to a set of files.
1139         https://bugs.webkit.org/show_bug.cgi?id=50901
1140
1141         These classes allow us to write code that is agnostic to whether a
1142         particular set of files resides in a local directory or in a zip file
1143         on a remote machine.
1144
1145         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1146         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1147         * Scripts/webkitpy/common/system/fileset.py: Added.
1148         * Scripts/webkitpy/common/system/filesystem.py:
1149         * Scripts/webkitpy/common/system/filesystem_mock.py:
1150         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1151         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1152
1153 2011-01-06  Eric Seidel  <eric@webkit.org>
1154
1155         Reviewed by Adam Barth.
1156
1157         NetworkTransaction should log the url it is retrying
1158         https://bugs.webkit.org/show_bug.cgi?id=52043
1159
1160         * Scripts/webkitpy/common/net/networktransaction.py:
1161         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1162
1163 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1164
1165         Windows build fix.
1166         Import os before using it.
1167
1168         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1169
1170 2011-01-06  Eric Seidel  <eric@webkit.org>
1171
1172         Reviewed by Adam Barth.
1173
1174         StyleQueue fails to report errors when patches have many files
1175         https://bugs.webkit.org/show_bug.cgi?id=52042
1176
1177         This is one of at least two errors preventing style error reporting at the moment.
1178         When we moved to passing the list of files to check explicitly,
1179         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1180         We could change the type of the QueueStatus.message type, or we could
1181         just teach statusserver.py how to clamp values (and warn when it does).
1182         I chose the latter path.
1183
1184         * Scripts/webkitpy/common/net/statusserver.py:
1185
1186 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1187
1188         Reviewed by Stephanie Lewis.
1189
1190         Fix syntax error in script.
1191
1192         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1193         https://bugs.webkit.org/show_bug.cgi?id=51996
1194
1195         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1196
1197 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1198
1199         Unreviewed, fixing WinCE build after r75196.
1200
1201         WinCE port does not (yet) support NPAPI.
1202
1203         * Scripts/build-webkit:
1204
1205 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1206
1207         Reviewed by Darin Adler.
1208
1209         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1210         https://bugs.webkit.org/show_bug.cgi?id=52015
1211
1212         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1213         after the platform has been detected, otherwise the script will
1214         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1215         detection.
1216
1217 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1218
1219         Reviewed by Eric Seidel.
1220
1221         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1222         https://bugs.webkit.org/show_bug.cgi?id=51346
1223
1224         * Scripts/build-webkit:
1225
1226 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1227
1228         Reviewed by Adam Roben.
1229
1230         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1231         https://bugs.webkit.org/show_bug.cgi?id=51996
1232
1233         After the configuration directory change, we were archiving the incorrect directory for
1234         build product, so we were running tests on the wrong binaries.
1235
1236         This change archives the correct directory, and also unarchives it into a configuration-
1237         specific directory.
1238
1239         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1240         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1241
1242 2011-01-06  Eric Seidel  <eric@webkit.org>
1243
1244         Reviewed by Mihai Parparita.
1245
1246         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1247         https://bugs.webkit.org/show_bug.cgi?id=52002
1248
1249         See an example of this here:
1250         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1251
1252         It's due to the fact that we pass around TestFailure() instance
1253         objects and yet expect them to all compare to be the same.
1254
1255         This is bad.  We should either have shared instances of these values
1256         or we should just pass around the class names.  There are already hacks
1257         in place to make TestFailure objects pass equality tests, I just added
1258         a __hash__ implementation so they can be used in sets as expected.
1259
1260         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1261         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1262
1263 2011-01-06  Evan Martin  <evan@chromium.org>
1264
1265         Reviewed by Tony Chang.
1266
1267         [gdb] handle inaccessible memory and UChar*
1268         https://bugs.webkit.org/show_bug.cgi?id=52003
1269
1270         To pretty-print a UChar*, we just grope around in the memory
1271         looking for a terminating NUL.  We need to handle the exception
1272         that can occur when we poke into an invalid location.
1273
1274         Additionally, the logic for choosing which pretty-printer would
1275         early return before hitting the point where we'd use the UChar*
1276         printer.  (Did this ever work?  How did it regress?)
1277
1278         * gdb/webkit.py:
1279
1280 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1281
1282         Reviewed by Ada Chan.
1283
1284         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1285         https://bugs.webkit.org/show_bug.cgi?id=51969
1286
1287         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1288
1289         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1290         (WTR::InjectedBundlePage::InjectedBundlePage):
1291         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1292         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1293
1294 2011-01-06  James Robinson  <jamesr@chromium.org>
1295
1296         Reviewed by Simon Fraser.
1297
1298         Implement mozilla's animationTime property
1299         https://bugs.webkit.org/show_bug.cgi?id=51952
1300
1301         Chromium DRT support for webkitAnimationTime.
1302
1303         * DumpRenderTree/chromium/WebViewHost.cpp:
1304         (WebViewHost::paintInvalidatedRegion):
1305
1306 2011-01-06  Julie Parent  <jparent@chromium.org>
1307
1308         Reviewed by Tony Chang.
1309
1310         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1311         https://bugs.webkit.org/show_bug.cgi?id=51217
1312
1313         * TestResultServer/model/jsonresults.py:
1314         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1315         Adds missing documentation.
1316         * TestResultServer/model/jsonresults_unittest.py:
1317         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1318         Update test_merge to take a number of builds to truncate at.
1319
1320 2011-01-06  Adam Barth  <abarth@webkit.org>
1321
1322         Reviewed by Eric Seidel.
1323
1324         The EWS should log outside of the working directory
1325         https://bugs.webkit.org/show_bug.cgi?id=51986
1326
1327         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1328         script, which will actually clean the working copy back to a pristine
1329         state instead of leaving untracked directories and ignored files.
1330
1331         * Scripts/webkitpy/tool/commands/queues.py:
1332         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1333
1334 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1335
1336         Windows build fix.
1337         Back out attempted change to built-product-archive.
1338
1339         * BuildSlaveSupport/built-product-archive:
1340
1341 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1342
1343         Windows build fix.
1344         Include configuration name when unpacking a build archive.
1345
1346         Needed, since we split Windows build results into configuration-specific directories
1347         under WebKitOutputDir.
1348
1349         * BuildSlaveSupport/built-product-archive:
1350
1351 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1352
1353         Reviewed by Darin Adler.
1354
1355         Debug and Release builds on Windows clobber each other
1356         https://bugs.webkit.org/show_bug.cgi?id=49185
1357
1358         Changes the structure of WebKitBuild build products directory so we
1359         completely separate each build configuration into independent directories.
1360
1361         Although we previously had per-configuration directories for obj, this change adds
1362         per-configuration directories for bin, lib, obj, and include. Each configuration's
1363         build products are stored within a directory inside of WebKitBuild.
1364
1365         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1366         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1367
1368         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1369         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1370         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1371         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1372         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1373         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1374         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1375         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1376         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1377         * FindSafari/FindSafari.vcproj:
1378         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1379         * MiniBrowser/MiniBrowserPostBuild.cmd:
1380         * MiniBrowser/MiniBrowserPreBuild.cmd:
1381         * Scripts/webkitdirs.pm:
1382         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1383         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1384         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1385         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1386         * TestWebKitAPI/win/copy-resources.cmd:
1387         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1388         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1389         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1390         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1391         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1392         * WebKitTestRunner/win/InjectedBundle.vcproj:
1393         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1394         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1395         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1396         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1397         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1398         * WinLauncher/WinLauncherCommon.vsprops:
1399         * WinLauncher/WinLauncherPostBuild.cmd:
1400         * WinLauncher/WinLauncherPreBuild.cmd:
1401
1402 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1403
1404         Reviewed by Ariya Hidayat.
1405
1406         [Qt] TestNetscapePlugin doesn't link on OS X
1407         https://bugs.webkit.org/show_bug.cgi?id=51948
1408
1409         Only add a dependency on libX11 on X11 systems
1410
1411         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1412
1413 2011-01-05  Jeff Miller  <jeffm@apple.com>
1414
1415         Reviewed by Adam Roben.
1416
1417         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1418         https://bugs.webkit.org/show_bug.cgi?id=51970
1419
1420         * Scripts/webkitpy/style/checker.py:
1421         Add -readability/naming for WebKit2 C API directories.
1422
1423 2011-01-05  Eric Seidel  <eric@webkit.org>
1424
1425         Unreviewed, just fixing one more log error from my previous python patch.
1426
1427         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1428         https://bugs.webkit.org/show_bug.cgi?id=51802
1429
1430         webkit-patch failure-reason was logging about parsing errors
1431         due to my misunderstanding of how BeautifulSoup.findAll worked.
1432
1433         Fixed, and added a unit test.
1434
1435         * Scripts/webkitpy/common/net/layouttestresults.py:
1436         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1437
1438 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1439
1440         Reviewed by Kenneth Rohde Christiansen.
1441
1442         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1443         https://bugs.webkit.org/show_bug.cgi?id=51951
1444
1445         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1446         to create new window from WebKit.
1447
1448         * MiniBrowser/qt/BrowserWindow.cpp:
1449         (newPageFunction):
1450         (BrowserWindow::BrowserWindow):
1451         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1452         (BrowserWindow::newWindow):
1453         (BrowserWindow::updateUserAgentList):
1454         (BrowserWindow::showUserAgentDialog):
1455         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1456         define the type of the backing store used for new windows.
1457         * MiniBrowser/qt/main.cpp:
1458         (main):
1459
1460 2011-01-05  Eric Seidel  <eric@webkit.org>
1461
1462         Reviewed by Ojan Vafai.
1463
1464         commit-queue should report failure type when reporting flaky tests
1465         https://bugs.webkit.org/show_bug.cgi?id=51900
1466
1467         This patch was a ridiculous amount of plumbing.  In the end I like
1468         the NRWT-style TestResult class even less.  But now we're passing
1469         a list of TestResult objects from the queue to the FlakyTestReporter.
1470         Thus the FlakyTestReporter can more easily report what type of failure
1471         occurred.
1472
1473         In the process, I found that I was not alone in finding TestResult
1474         cumbersome to use.  A bunch of code was trying to create a TestResult
1475         object with default values.  However since the constructor didn't make
1476         this easy, some places were getting it wrong (including the TestResult unit test)!
1477         I've fixed the TestResult constructor to have default values for non-essential
1478         arguments.
1479
1480         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1481         * Scripts/webkitpy/common/net/layouttestresults.py:
1482         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1483         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1484         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1485         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1486         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1487         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1488         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1489         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1490         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1491         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1492         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1493         * Scripts/webkitpy/tool/commands/queues.py:
1494         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1495
1496 2011-01-05  Eric Seidel  <eric@webkit.org>
1497
1498         Unreviewed.
1499
1500         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1501         https://bugs.webkit.org/show_bug.cgi?id=51802
1502
1503         Add another unit test to cover a previously missing import.
1504
1505         * Scripts/webkitpy/common/net/layouttestresults.py:
1506         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1507
1508 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1509
1510         Reviewed by David Levin.
1511
1512         Add mihaip@chromium.org as a reviewer
1513         https://bugs.webkit.org/show_bug.cgi?id=51966
1514
1515         Add myself as a reviewer.
1516
1517         * Scripts/webkitpy/common/config/committers.py:
1518
1519 2011-01-05  James Simonsen  <simonjam@chromium.org>
1520
1521         Unreviewed. Adding myself to the list of committers.
1522
1523         * Scripts/webkitpy/common/config/committers.py:
1524
1525 2011-01-05  Eric Seidel  <eric@webkit.org>
1526
1527         Unreviewed.
1528
1529         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1530         https://bugs.webkit.org/show_bug.cgi?id=51802
1531
1532         Fix two exceptions seen on the bots after my original commit.
1533
1534         * Scripts/webkitpy/common/net/layouttestresults.py:
1535         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1536
1537 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1538
1539         Reviewed by Andreas Kling.
1540
1541         [Qt]Add local storage settings to QtTestBrowser command line arguments
1542         https://bugs.webkit.org/show_bug.cgi?id=51750
1543
1544         * QtTestBrowser/main.cpp:
1545         (LauncherApplication::handleUserOptions):
1546          Local storage settings can be enable form command line arguments for
1547          QtTestBrowser.
1548
1549 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1550
1551         Reviewed by Martin Robinson.
1552
1553         GTK: AX: DRT needs to use correct root object method.
1554         https://bugs.webkit.org/show_bug.cgi?id=51911
1555
1556         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1557         (AccessibilityController::rootElement):
1558
1559 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1560
1561         Rubber-stamped by Csaba Osztrogonác.
1562
1563         Based on idea from Péter Gál.
1564
1565         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1566
1567 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1568
1569         Reviewed by Adam Barth.
1570
1571         sheriff-bot should be able to do multi-revision rollouts
1572         https://bugs.webkit.org/show_bug.cgi?id=51176
1573
1574         * Scripts/webkitpy/tool/bot/irc_command.py:
1575         * Scripts/webkitpy/tool/bot/sheriff.py:
1576         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1577
1578 2011-01-05  Eric Seidel  <eric@webkit.org>
1579
1580         Reviewed by Adam Barth.
1581
1582         queues.webkit.org should have per-bot status pages
1583         https://bugs.webkit.org/show_bug.cgi?id=51906
1584
1585         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1586         statuses from a single queue.  Now that we have many bots servicing
1587         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1588         you care about scroll off the end of the 15-message limit on the main page.
1589
1590         Eventually we should probably rename /queue-status to /queue or /queues,
1591         but that's fodder for another patch.
1592
1593         * QueueStatusServer/handlers/queuestatus.py:
1594         * QueueStatusServer/index.yaml:
1595         * QueueStatusServer/main.py:
1596         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1597          - This probably should use a custom filter instead of hard-coding
1598            the URL scheme here, but I couldn't figure out how to easily
1599            create such a filter.  Most filters work with "strings" so we can't
1600            pass the status object.  We could add a method to the status
1601            object and call that, but that seemed a bit strange too.
1602         * QueueStatusServer/templates/queuestatus.html:
1603
1604 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1605
1606         Unreviewed. Adding myself to the list of committers.
1607
1608         * Scripts/webkitpy/common/config/committers.py:
1609
1610 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1611
1612         Reviewed by David Levin.
1613
1614         check-webkit-style treated some macros with parentheses after #elif as function calls
1615         https://bugs.webkit.org/show_bug.cgi?id=51695
1616
1617         Ingore function call space checking in any preprocessor directives
1618         (things starting with #). Change search() to match() because
1619         preprocessor directives are supposed to be in the beginning of lines.
1620
1621         * Scripts/webkitpy/style/checkers/cpp.py:
1622         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1623
1624 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1625
1626         Reviewed by Tony Chang.
1627
1628         Change the --multi-load test option to --stress-opt
1629         https://bugs.webkit.org/show_bug.cgi?id=50751
1630
1631         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1632         (runTest):
1633         (main):
1634         * DumpRenderTree/chromium/TestShell.cpp:
1635         (TestShell::TestShell):
1636         * DumpRenderTree/chromium/TestShell.h:
1637         (TestShell::stressOpt):
1638         (TestShell::setStressOpt):
1639         (TestShell::stressDeopt):
1640         (TestShell::setStressDeopt):
1641         (TestShell::javaScriptFlags):
1642         (TestShell::setJavaScriptFlags):
1643         * Scripts/webkitpy/layout_tests/port/chromium.py:
1644         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1645
1646 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1647
1648         Reviewed by Sam Weinig.
1649
1650         WK2: Support Accessibility
1651         https://bugs.webkit.org/show_bug.cgi?id=51859
1652
1653         Use rootObject() method to get top of accessibility tree.
1654
1655         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1656         (AccessibilityController::focusedElement):
1657         (AccessibilityController::rootElement):
1658
1659 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1660
1661         Reviewed by Darin Adler.
1662
1663         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1664         https://bugs.webkit.org/show_bug.cgi?id=51846
1665
1666         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1667         back to GRefPtr.
1668
1669 2011-01-04  Zhe Su  <suzhe@chromium.org>
1670
1671         Reviewed by Kenneth Russell.
1672
1673         Fix insertText, setMarkedText and unmarkText methods of
1674         TextInputController to call corresponding methods of WebKit::WebView
1675         rather than WebKit::WebFrame. This change matches the behavior of
1676         chromium browser.
1677         insertText corresponds to WebView::confirmComposition(text)
1678         setMarkedText corresponds to WebView::setComposition(...)
1679         unmarkText corresponds to WebView::confirmComposition()
1680         https://bugs.webkit.org/show_bug.cgi?id=51693
1681
1682         * DumpRenderTree/chromium/TextInputController.cpp:
1683         (TextInputController::insertText):
1684         (TextInputController::setMarkedText):
1685         (TextInputController::unmarkText):
1686
1687 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1688
1689         Reviewed by Laszlo Gombos.
1690
1691         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1692
1693         On Symbian productDir points to the source directory. Removing all the
1694         empty files from the productDir directory corrupts the svn repository.
1695
1696         * Scripts/build-webkit:
1697
1698 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1699
1700         Reviewed by Adam Barth.
1701
1702         [Qt] Add SelectAll option to the context menu for the editor
1703         https://bugs.webkit.org/show_bug.cgi?id=50049
1704
1705         Set shortcut for the SelectAll action.
1706
1707         * QtTestBrowser/mainwindow.cpp:
1708         (MainWindow::buildUI):
1709
1710 2011-01-03  David Levin  <levin@chromium.org>
1711
1712         Reviewed by Eric Seidel.
1713
1714         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1715         https://bugs.webkit.org/show_bug.cgi?id=51842
1716
1717         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1718         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1719
1720 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1721
1722         Reviewed by David Kilzer.
1723
1724         [WINCE] Adds a build slave.
1725         https://bugs.webkit.org/show_bug.cgi?id=50523
1726
1727         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1728         entry for a release build of the WinCE port.
1729         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1730         flag to build the WinCE port.
1731
1732 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1733
1734         Reviewed by David Kilzer.
1735
1736         Add WinCE support to build-webkit
1737         https://bugs.webkit.org/show_bug.cgi?id=51642
1738
1739         * Scripts/build-webkit:
1740         * Scripts/webkitdirs.pm:
1741
1742 2011-01-03  Eric Seidel  <eric@webkit.org>
1743
1744         Reviewed by Adam Barth.
1745
1746         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1747         https://bugs.webkit.org/show_bug.cgi?id=51802
1748
1749         I'm not the biggest fan of the test_failures or test_results classes,
1750         but it's better to have one shared set of classes, than separate ones
1751         for new vs. old run-webkit-test result handling.
1752
1753         This moves the ORWT results class "LayoutTestResults" over to using
1754         TestResult and TestFailure classes, making it easy for us to
1755         make all our sheriff-bot and other webkitpy code NRWT ready.
1756
1757         This also makes it a trivial patch to generate results.json information
1758         from ORWT results.html files (for flaky test analysis, etc.) as well
1759         as making it a one-liner to report test failure types when the
1760         commit-queue sees flaky tests.
1761
1762         This patch tried not to add new functionality, but only to replace
1763         the guts of LayoutTestResults, while adding unit tests and hoping
1764         not to break anything.
1765
1766         I also moved callers which assumed User.prompt* were static/class methods
1767         to using them as instance methods (since we'll eventually want to make them such).
1768
1769         In the process of re-writing things, I broke the rebaseline command, so I wrote
1770         a unit test to catch my breakage were I do do so again in the future.
1771
1772         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1773         * Scripts/webkitpy/common/net/layouttestresults.py:
1774         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1775         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1776         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1777         * Scripts/webkitpy/tool/commands/queries.py:
1778         * Scripts/webkitpy/tool/commands/rebaseline.py:
1779         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1780         * Scripts/webkitpy/tool/mocktool.py:
1781
1782 2011-01-03  Adam Barth  <abarth@webkit.org>
1783
1784         Reviewed by Simon Fraser.
1785
1786         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1787         https://bugs.webkit.org/show_bug.cgi?id=51840
1788
1789         * Scripts/webkitpy/common/checkout/scm.py:
1790
1791 2011-01-03  Adam Barth  <abarth@webkit.org>
1792
1793         Reviewed by Simon Fraser.
1794
1795         webkit-patch should only hide update output if --quiet
1796         https://bugs.webkit.org/show_bug.cgi?id=51838
1797
1798         As requested by smfr.
1799
1800         * Scripts/webkitpy/tool/steps/update.py:
1801
1802 2011-01-03  Adam Barth  <abarth@webkit.org>
1803
1804         Reviewed by David Levin.
1805
1806         commit-queue shouldn't reject patches twice if two bots process the same patch
1807         https://bugs.webkit.org/show_bug.cgi?id=51805
1808
1809         Before raising an error, we first check whether the patch is still in
1810         the commit-queue.  This check is still racy, of course, but the time
1811         window is much smaller.
1812
1813         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1814
1815 2011-01-03  Sam Weinig  <sam@webkit.org>
1816
1817         Reviewed by Anders Carlsson.
1818
1819         Make run-api-tests less chatty.
1820         https://bugs.webkit.org/show_bug.cgi?id=51831
1821
1822         - Make script quiet by default and add --verbose option (replacing --quiet).
1823         - When not verbose, pipe stdout and stderr to devnull.
1824
1825         * Scripts/run-api-tests:
1826
1827 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1828
1829         Unreviewed. Adding myself to committers.py.
1830
1831         * Scripts/webkitpy/common/config/committers.py:
1832
1833 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1834
1835         Reviewed by Xan Lopez.
1836
1837         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1838         https://bugs.webkit.org/show_bug.cgi?id=51806
1839
1840         Originally, the $libraryName is 'JavaScriptCore'. When building release
1841         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1842         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1843         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and
1844         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1845         so make it 'WebKitBuild/Release/.libs'
1846
1847         * Scripts/webkitdirs.pm:
1848
1849 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1850
1851         Reviewed by Adam Barth.
1852
1853         Make EFL a core builder
1854         https://bugs.webkit.org/show_bug.cgi?id=51804
1855
1856         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1857         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1858
1859 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1860
1861         [Qt] Unreviewed fix after r74855 and r74875.
1862
1863         * BuildSlaveSupport/built-product-archive:
1864          - Create directories explicitly.
1865          - Pass shell=True to subprocess.call().
1866
1867 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1868
1869         [Qt] Unreviewed fix after r74855.
1870
1871         Move JavaScriptCore to Source
1872         https://bugs.webkit.org/show_bug.cgi?id=51604
1873
1874         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1875
1876 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1877
1878         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1879
1880         Move JavaScriptCore to Source
1881         https://bugs.webkit.org/show_bug.cgi?id=51604
1882
1883         * Scripts/webkitdirs.pm:
1884
1885 2011-01-02  Robert Hogan  <robert@webkit.org>
1886
1887         Unreviewed, build fix.
1888
1889         [Qt] Fix DRT build after 74855
1890
1891         * DumpRenderTree/qt/DumpRenderTree.pro:
1892
1893 2011-01-01  Adam Barth  <abarth@webkit.org>
1894
1895         Remove the assumption from the Qt and Gtk builds that every project is
1896         in the root directory.
1897
1898         * Scripts/build-webkit:
1899
1900 2011-01-01  Adam Barth  <abarth@webkit.org>
1901
1902         Reviewed by Eric Seidel.
1903
1904         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1905         https://bugs.webkit.org/show_bug.cgi?id=51796
1906
1907         After this change, svn-apply will magically apply patches to
1908         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1909
1910         * Scripts/VCSUtils.pm:
1911
1912 2011-01-01  Adam Barth  <abarth@webkit.org>
1913
1914         Reviewed by Eric Seidel.
1915
1916         Move JavaScriptCore to Source
1917         https://bugs.webkit.org/show_bug.cgi?id=51604
1918
1919         Update references to JavaScriptCore to point to the new location.
1920
1921         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1922         * DumpRenderTree/qt/DumpRenderTree.pro:
1923         * DumpRenderTree/qt/ImageDiff.pro:
1924         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1925         * DumpRenderTree/wscript:
1926         * Scripts/build-jsc:
1927         * Scripts/build-webkit:
1928         * Scripts/do-file-rename:
1929         * Scripts/do-webcore-rename:
1930         * Scripts/run-javascriptcore-tests:
1931         * Scripts/update-javascriptcore-test-results:
1932         * Scripts/webkitdirs.pm:
1933         * Scripts/webkitpy/common/config/build_unittest.py:
1934         * Scripts/webkitpy/style/checker.py:
1935         * Scripts/webkitpy/style/checker_unittest.py:
1936         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1937         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1938         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1939         * wx/build/settings.py:
1940
1941 2011-01-01  Adam Barth  <abarth@webkit.org>
1942
1943         Reviewed by Eric Seidel.
1944
1945         Move Sources to Source
1946         https://bugs.webkit.org/show_bug.cgi?id=51794
1947
1948         Update scripts to point to the new location.
1949
1950         * Scripts/build-webkit:
1951         * Scripts/do-file-rename:
1952         * Scripts/do-webcore-rename:
1953         * Scripts/webkitpy/common/config/build.py:
1954         * Scripts/webkitpy/common/config/build_unittest.py:
1955
1956 2010-12-31  Kent Tamura  <tkent@chromium.org>
1957
1958         Reviewed by Eric Seidel.
1959
1960         [DRT/Chromium] Enable mock spell checker on non-OSX
1961         https://bugs.webkit.org/show_bug.cgi?id=51401
1962
1963         * DumpRenderTree/chromium/WebViewHost.cpp:
1964         (WebViewHost::spellCheck):
1965
1966 2010-12-31  Adam Barth  <abarth@webkit.org>
1967
1968         Reviewed by Ariya Hidayat.
1969
1970         Remove Tools/Scripts/wkstyle
1971         https://bugs.webkit.org/show_bug.cgi?id=51774
1972
1973         This script appears to not have been touched in a while and seems to
1974         have been replaced by check-webkit-style.
1975
1976         * Scripts/wkstyle: Removed.
1977
1978 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1979
1980         Unreviewed. Coding style fix.
1981
1982         * DumpRenderTree/chromium/TestShell.h:
1983
1984 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1985
1986         Reviewed by Pavel Feldman.
1987
1988         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1989
1990         It was a problem with Chromium DRT. DevToolsAgent object instance was
1991         attached not only to the inspected page but to the DevTools window too.
1992         As result all the inspector files were interpreted as a content of inspected page
1993         and were transfered to the DevTools scripts panel for debugging etc.
1994
1995         https://bugs.webkit.org/show_bug.cgi?id=51735
1996
1997         * DumpRenderTree/chromium/TestShell.cpp:
1998         (TestShell::TestShell):
1999         (TestShell::bindJSObjectsToWindow):
2000         (TestShell::createNewWindow):
2001         * DumpRenderTree/chromium/TestShell.h:
2002
2003 2010-12-31  Adam Barth  <abarth@webkit.org>
2004
2005         Rubber-stamped by Eric Seidel.
2006
2007         Move PageLoadTests to PerformanceTests/PageLoad
2008         https://bugs.webkit.org/show_bug.cgi?id=51771
2009
2010         Update references to PageLoadTests to point to the new location.
2011
2012         * Scripts/run-pageloadtest:
2013         * Scripts/webkitpy/common/config/build.py:
2014
2015 2010-12-31  Adam Barth  <abarth@webkit.org>
2016
2017         Rubber-stamped by Eric Seidel.
2018
2019         Move SunSpider into PerformanceTests
2020         https://bugs.webkit.org/show_bug.cgi?id=51769
2021
2022         Update these scripts to point to the new location.
2023
2024         * Scripts/run-sunspider:
2025         * Scripts/sunspider-compare-results:
2026
2027 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2028
2029         Reviewed by Kent Tamura.
2030
2031         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2032         https://bugs.webkit.org/show_bug.cgi?id=51728
2033
2034         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2035         to render top-level scrollbars. This makes them match the Mac port's
2036         use of an NSScrollView, which means that we'll be able to share more
2037         pixel baselines.
2038
2039         The new rendering code will not be activated until the
2040         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2041         ScrollbarThemeChromiumMac.
2042
2043         * DumpRenderTree/DumpRenderTree.gypi:
2044         * DumpRenderTree/chromium/TestShellMac.mm:
2045         (platformInit):
2046         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2047         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2048         (+[FakeActiveWindow alwaysActiveWindow]):
2049         (+[FakeActiveWindow alwaysInactiveWindow]):
2050         (-[FakeActiveWindow initWithActiveControls:]):
2051         (-[FakeActiveWindow _hasActiveControls]):
2052         (WebThemeEngineDRTMac::paintScrollbarThumb):
2053         (stateToHIEnableState):
2054         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2055         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2056
2057 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2058
2059         Reviewed by David Kilzer.
2060
2061         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2062         used
2063         https://bugs.webkit.org/show_bug.cgi?id=51672
2064
2065         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2066         with USE_SYSTEM_MALLOC=1
2067         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2068         with USE_SYSTEM_MALLOC=1
2069
2070 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2071
2072         Reviewed by David Kilzer.
2073
2074         [Qt] [Symbian] Fix build-webkit script for Symbian
2075         https://bugs.webkit.org/show_bug.cgi?id=51509
2076
2077         Set the OUTPUT_DIR for Symbian to be the same as the source
2078         directory.
2079
2080         * Scripts/webkitdirs.pm:
2081
2082 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2083
2084         Reviewed by Darin Adler.
2085
2086         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2087         https://bugs.webkit.org/show_bug.cgi?id=51758
2088
2089         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2090
2091         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2092         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2093
2094 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2095
2096         Unreviewed WinCE buildfix.
2097
2098         * WinCELauncher/main.cpp: Add missing include.
2099
2100 2010-12-29  Daniel Bates  <dbates@rim.com>
2101
2102         Reviewed by Darin Adler.
2103
2104         svn-apply updates date of wrong change log entry for a change log diff that
2105         contains two consecutive entries with the same author and date
2106         https://bugs.webkit.org/show_bug.cgi?id=46061
2107
2108         Fixes an issue where the date of the wrong change log entry may be modified.
2109         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2110         in a ChangeLog file to the top of the file.
2111
2112         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2113         diff when it detects that the diff inserts a change log entry earlier in a
2114         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2115         change. With the advent of the commit-queue this functionality of bailing out
2116         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2117         Instead, we should always move the change log entry to the top of the ChangeLog file.
2118
2119         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2120         the date line of the correct change log entry in a ChangeLog diff.
2121
2122         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2123
2124         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2125           Updated the following unit tests now that we move entries inserted earlier to the top:
2126           - "fixChangeLogPatch: New entry inserted in middle."
2127             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2128
2129           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2130             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2131
2132         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2133
2134 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2135
2136         Reviewed by Eric Seidel.
2137
2138         [Qt] Fixed compatibility with gold linker on X11 platforms
2139         https://bugs.webkit.org/show_bug.cgi?id=51700
2140
2141         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2142         Linked TestNetscapePlugin with libX11 on Unix platforms
2143
2144 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2145
2146         Reviewed by Darin Adler.
2147
2148         Circular dependency in webkitpy.common.checkout.changelog module
2149         https://bugs.webkit.org/show_bug.cgi?id=50475
2150
2151         Remove automatic import of api.Checkout module when any checkout/
2152         submodule is imported (e.g.: when checkout.scm.Git is imported).
2153
2154         * Scripts/webkitpy/common/checkout/__init__.py:
2155
2156 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2157
2158         Reviewed by Ojan Vafai.
2159
2160         prepare-ChangeLog should support the -g option for specifying the git-commit
2161         https://bugs.webkit.org/show_bug.cgi?id=51708
2162
2163         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2164         webkit-patch, though the exact meaning of the two options remain different.
2165
2166         * Scripts/prepare-ChangeLog: Add -g.
2167
2168 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2169
2170         Reviewed by Simon Hausmann.
2171
2172         [Qt] Fix compilation with Qt in namespace
2173         https://bugs.webkit.org/show_bug.cgi?id=51701
2174
2175         * QtTestBrowser/webview.h:
2176
2177 2010-12-28  Daniel Bates  <dbates@rim.com>
2178
2179         Reviewed by Sam Weinig.
2180
2181         Substitute // MARK: for compiler-specific #pragma mark
2182         https://bugs.webkit.org/show_bug.cgi?id=51657
2183
2184         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2185         substituting  "// MARK:" for "#pragma mark", which provides
2186         analogous code-bookmarking functionality under Xcode.
2187
2188         Also, for consistency, we should substitute "// MARK:" for compiler-
2189         specific "#pragma mark" in the source files for the Mac port.
2190
2191         * DumpRenderTree/AccessibilityTextMarker.cpp:
2192         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2193         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2194         * DumpRenderTree/mac/ObjCController.m:
2195         * MiniBrowser/mac/AppDelegate.m:
2196         * MiniBrowser/mac/BrowserWindowController.m:
2197
2198 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2199
2200         Reviewed by Eric Seidel.
2201
2202         Add --no-build option to run-sunspider
2203         https://bugs.webkit.org/show_bug.cgi?id=51658
2204
2205         * Scripts/run-sunspider: add --no-build flag to skip building
2206         phase.
2207
2208 2010-12-27  Daniel Bates  <dbates@rim.com>
2209
2210         Rubber-stamped by Martin Robinson.
2211
2212         Append the directory Tools/DumpRenderTree to the list of directories that
2213         do-webcore-rename should search so that it can rename DRT files and
2214         source code.
2215
2216         * Scripts/do-webcore-rename:
2217
2218 2010-12-27  Eric Seidel  <eric@webkit.org>
2219
2220         Reviewed by Adam Barth.
2221
2222         build-webkit should detect missing Java SDK and explain how to install it
2223         https://bugs.webkit.org/show_bug.cgi?id=51651
2224
2225         * Scripts/build-webkit:
2226
2227 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2228
2229         Reviewed by Daniel Bates.
2230
2231         [GTK] Add support for build-jsc
2232         https://bugs.webkit.org/show_bug.cgi?id=51625
2233
2234         Add GTK+ support to build-jsc now that building the jsc executable as
2235         a standalone target is easy.
2236
2237         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2238         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2239         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2240         and pass it along to buildAutotoolsProject.
2241
2242 2010-12-27  David Levin  <levin@chromium.org>
2243
2244         Reviewed by Eric Seidel.
2245
2246         check-webkit-style check for meaningless variable names in function declarations.
2247         https://bugs.webkit.org/show_bug.cgi?id=51523
2248
2249         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2250         from the new check and whitespace/parens because the syntax is unusual and
2251         produced a fair number of positives for these checks.
2252         * Scripts/webkitpy/style/checkers/cpp.py:
2253         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2254         and parameter names when determining if the parameter name is useless.
2255         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2256         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2257         format.
2258         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2259         text or an acronym of it.
2260         (check_function_definition): Checks function definitions for meaningless variable names.
2261         (process_line): Added call to check_function_definition.
2262         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2263         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2264         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2265         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2266         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2267         because when only checking a snippet, there are a lot of bogus functions.
2268         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2269         that I put there previously and just noticed.
2270         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2271         check_function_definition and process_line.
2272
2273 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2274
2275         Reviewed by Martin Robinson.
2276
2277         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2278         https://bugs.webkit.org/show_bug.cgi?id=51591
2279
2280         Flash plugin uses gtk2 that is incompatible with gtk3 making
2281         webkit crash when it's built with gtk3.
2282
2283         * GtkLauncher/main.c:
2284         (main):
2285
2286 2010-12-25  Adam Barth  <abarth@webkit.org>
2287
2288         Reviewed by Eric Seidel.
2289
2290         Move ANGLE to Sources/ThirdParty
2291         https://bugs.webkit.org/show_bug.cgi?id=51605
2292
2293         * Scripts/build-webkit:
2294           - Point to the new ANGLE location.
2295
2296 2010-12-26  David Levin  <levin@chromium.org>
2297
2298         Reviewed by Eric Seidel.
2299
2300         check-webkit-style should be able to parse function declaration parameters.
2301         https://bugs.webkit.org/show_bug.cgi?id=51451
2302
2303         * Scripts/webkitpy/style/checkers/cpp.py:
2304         (Position.__init__): Holds simple position information (row, column).
2305         (Parameter.__init__): Holds information about a parameter.
2306         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2307         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2308         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2309         (find_parameter_name_index): Finds where the parameter name is.
2310         (parameter_list): Generates the list of parameters for a function.
2311         (_FunctionState.begin): Added information to allow determining the parameters
2312         on demand.
2313         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2314         (detect_functions): Improve function detection for operator functions and
2315         determine where the parameters end and pass that to _FunctionState.begin.
2316         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2317         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2318         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2319         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2320         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2321         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2322         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2323         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2324         the parameters found.
2325         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2326         detection test to verify that we catch the operator functions.
2327         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2328         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2329         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2330         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2331         test_function_length_check_definition_severity1_for_test.
2332
2333 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2334
2335         Unreviewed WinCE buildfix after r74334.
2336
2337         * CMakeListsWinCE.txt:
2338
2339 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2340
2341         Unreviewed, rolling out r74632.
2342         http://trac.webkit.org/changeset/74632
2343         https://bugs.webkit.org/show_bug.cgi?id=51600
2344
2345         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2346         on #webkit).
2347
2348         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2349         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2350
2351 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2352
2353         Reviewed by Kenneth Rohde Christiansen.
2354
2355         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2356         https://bugs.webkit.org/show_bug.cgi?id=43528
2357
2358         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2359         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2360         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2361         called.
2362
2363         * EWebLauncher/main.c:
2364         (browserCreate):
2365
2366 2010-12-24  Eric Seidel  <eric@webkit.org>
2367
2368         Reviewed by Adam Barth.
2369
2370         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2371         https://bugs.webkit.org/show_bug.cgi?id=28291
2372
2373         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2374         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2375         to strings with find in the diff.
2376         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2377
2378         * Scripts/webkitpy/common/checkout/api.py:
2379         * Scripts/webkitpy/common/checkout/diff_parser.py:
2380         * Scripts/webkitpy/tool/steps/abstractstep.py:
2381         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2382         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2383         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2384         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2385
2386 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2387
2388         Reviewed by Kenneth Russell.
2389
2390         Modify new-run-webkit-tests to shut up and exit when all the threads
2391         are wedged so that test runs complete faster and we don't end up
2392         w/ enormous log files.
2393
2394         https://bugs.webkit.org/show_bug.cgi?id=51572
2395
2396         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2397         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2398
2399 2010-12-24  Eric Seidel  <eric@webkit.org>
2400
2401         Reviewed by David Levin.
2402
2403         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2404         https://bugs.webkit.org/show_bug.cgi?id=51549
2405
2406         I've had multiple people ask me about the commit-queue's behavior
2407         regarding reporting flaky tests.  I figured it would be best to just
2408         have the queue explain itself in the bugs it files.
2409
2410         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2411         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2412
2413 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2414
2415         Reviewed by Eric Seidel.
2416
2417         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2418         https://bugs.webkit.org/show_bug.cgi?id=51467
2419
2420         * Scripts/webkitpy/style/checker.py:
2421         * Scripts/webkitpy/style/checker_unittest.py:
2422
2423 2010-12-23  Adam Barth  <abarth@webkit.org>
2424
2425         Rubber-stamped by Eric Seidel.
2426
2427         Move JavaScriptGlue into Sources
2428         https://bugs.webkit.org/show_bug.cgi?id=51583
2429
2430         These tools refer to JavaScriptGlue and need to be updated to its new
2431         location.
2432
2433         * Scripts/build-webkit:
2434         * Scripts/do-file-rename:
2435         * Scripts/do-webcore-rename:
2436         * Scripts/webkitpy/common/config/build.py:
2437         * Scripts/webkitpy/common/config/build_unittest.py:
2438
2439 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2440
2441         Reviewed by Eric Seidel.
2442
2443         Bug 51539 - update iexploder scripts to point to new location
2444
2445         * Scripts/run-iexploder-tests:
2446         * Scripts/update-iexploder-cssproperties:
2447
2448 2010-12-23  Evan Martin  <evan@chromium.org>
2449
2450         Reviewed by Ryosuke Niwa.
2451
2452         [chromium] LayoutTestController warning in float->int conversion
2453         https://bugs.webkit.org/show_bug.cgi?id=51553
2454
2455         Rather than reading an int, converting to a float, then getting a compiler
2456         warning on passing the float to something that expects an int, instead
2457         just pass around ints.
2458
2459         No tests, fixes a compiler warning.
2460
2461         * DumpRenderTree/chromium/LayoutTestController.cpp:
2462         (parsePageSizeParameters):
2463         (LayoutTestController::pageNumberForElementById):
2464         (LayoutTestController::numberOfPages):
2465
2466 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2467
2468         Reviewed by Darin Adler.
2469
2470         Bug 51537 - iexploder needs cleanup
2471
2472         * iExploder/htdocs: Removed.
2473         * iExploder/htdocs/config.rb: Removed.
2474         * iExploder/htdocs/cssproperties.in: Removed.
2475         * iExploder/htdocs/cssvalues.in: Removed.
2476         * iExploder/htdocs/htmlattrs.in: Removed.
2477         * iExploder/htdocs/htmltags.in: Removed.
2478         * iExploder/htdocs/htmlvalues.in: Removed.
2479         * iExploder/htdocs/iexploder.cgi: Removed.
2480         * iExploder/htdocs/iexploder.rb: Removed.
2481         * iExploder/htdocs/index.html: Removed.
2482         * iExploder/htdocs/webserver.rb: Removed.
2483         * iExploder/iexploder-1.7.2/output: Removed.
2484         * iExploder/tools: Removed.
2485         * iExploder/tools/lasthit.rb: Removed.
2486         * iExploder/tools/osx_last_crash.rb: Removed.
2487         * iExploder/tools/showtest.rb: Removed.
2488
2489 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2490
2491         Reviewed by Kenneth Rohde Christiansen.
2492
2493         [EFL] Make 'single' the default backing store in EWebLauncher
2494         https://bugs.webkit.org/show_bug.cgi?id=51534
2495
2496         'single' is the simplest backing store and the one intended to be the
2497         default in the test browser. By mistake the tiled backing store was
2498         left as default in r72617.
2499
2500         * EWebLauncher/main.c:
2501         (browserCreate): ditto.
2502
2503 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2504
2505         Reviewed by Kenneth Rohde Christiansen.
2506
2507         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2508         https://bugs.webkit.org/show_bug.cgi?id=51533
2509
2510         There's no point in concatenating env("HOME") with "blah", so remove
2511         option from EWebLauncher.
2512
2513         * EWebLauncher/main.c:
2514         (main): ditto.
2515
2516 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2517
2518         Reviewed by Eric Seidel.
2519
2520         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2521
2522         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2523         I just discovered that we have two additional GC runs per each WebViewHost.
2524         Test_shell had no such calls.
2525         These gc runs eat 15% of cpu time.
2526
2527         https://bugs.webkit.org/show_bug.cgi?id=51479
2528
2529         * DumpRenderTree/chromium/WebViewHost.cpp:
2530         (WebViewHost::~WebViewHost):
2531
2532 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2533
2534         Reviewed by Ojan Vafai.
2535
2536         This change splits out the TestRunner class into its own file.
2537         When we fork the code for message passing, we will create a new
2538         TestRunner, and this change will allow that to be more modular.
2539
2540         While we're at it, split out TestInput and ResultSummary into
2541         their own files, to reduce the size of run_webkit_tests to
2542         something more managable.
2543
2544         https://bugs.webkit.org/show_bug.cgi?id=51092
2545
2546         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2547         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2548         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2549         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2550         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2551         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2552         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2553
2554  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2555
2556         Reviewed by Ojan Vafai.
2557
2558         nrwt multiprocessing - start over, prepare to fork the code
2559
2560         This code cleans up the signatures and implementation of the
2561         TestRunner class so we can easily fork it to run either the
2562         stable implementation or the new, unstable message-passing
2563         implementation. The two variants will have different
2564         implementations of the run_tests() method. We will switch
2565         between the two based on the setting for the '--worker-model'
2566         switch. We rename the two currently valid values to 'old-inline'
2567         and 'old-threads'.
2568
2569         https://bugs.webkit.org/show_bug.cgi?id=51081
2570
2571         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2572         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2573
2574 2010-12-22  Victor Wang  <victorw@chromium.org>
2575
2576         Reviewed by Darin Fisher.
2577
2578         [Chromium] Update chromium archive test result url in rebaseline script.
2579
2580         https://bugs.webkit.org/show_bug.cgi?id=51503
2581
2582         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2583
2584 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2585
2586         Reviewed by Alice Liu.
2587
2588         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2589         Verified on Chrome, Safari, and IE.
2590         With this change, we will record memory from a parent browser window and all child processes.
2591
2592         * record-memory-win/main.cpp:
2593         (ProcessArgs):
2594         (PrintUsage):
2595         (getMemoryInfo):
2596         (printProcessInfo):
2597         (evalProcesses):
2598         (UseImage):
2599         (QueryContinuously):
2600         (ElapsedTime):
2601
2602 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2603
2604         Unreviewed rollout r74489, because it was missing changelog.
2605
2606         * record-memory-win/main.cpp:
2607
2608 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2609
2610         Adding myself as a reviewer.
2611
2612         * Scripts/webkitpy/common/config/committers.py:
2613
2614 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2615
2616         Unreviewed.  Adding myself to committers.py.
2617
2618         * Scripts/webkitpy/common/config/committers.py:
2619
2620 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2621
2622         Reviewed by Kenneth Rohde Christiansen.
2623
2624         TestNetscapePlugIn should use #if defined
2625         https://bugs.webkit.org/show_bug.cgi?id=51471
2626
2627         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2628         (NP_Initialize):
2629         (NPP_New):
2630
2631 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2632
2633         Reviewed by Yury Semikhatsky.
2634
2635         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2636
2637         DevTools window should be closed explicitly because it has custom deinitialization code.
2638
2639         https://bugs.webkit.org/show_bug.cgi?id=50722
2640
2641         * DumpRenderTree/chromium/TestShell.cpp:
2642         (TestShell::closeRemainingWindows):
2643
2644 2010-12-22  David Levin  <levin@chromium.org>
2645
2646         Reviewed by Shinichiro Hamaji.
2647
2648         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2649         https://bugs.webkit.org/show_bug.cgi?id=51452
2650
2651         * Scripts/webkitpy/style/checkers/cpp.py:
2652         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2653         Using the file extension if possible but falling back to the file contents if we have a header file.
2654         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2655         (_FileState.is_c_or_objective_c):
2656         (check_using_std): Changed to using _FileState to determine the file type.
2657         (check_max_min_macros): Ditto.
2658         (check_for_null): Ditto.
2659         (check_style): Changed the parameters to various calls since they now need _FileState
2660         to determine the file type.
2661         (check_language): Added the file_state parameter so it could be passed
2662         to check_identifier_name_in_declaration.
2663         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2664         this is an Objective C file.
2665         (_process_lines): Added information for the _FileState constructor (and moved the
2666         call to a place that had the information).
2667         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2668         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2669         its functionality.
2670         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2671
2672 2010-12-21  Andy Estes  <aestes@apple.com>
2673
2674         Reviewed by Mark Rowe.
2675
2676         Do not build non-Intel architectures for WebKit2-related projects.
2677         https://bugs.webkit.org/show_bug.cgi?id=51440
2678
2679         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2680         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2681         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2682
2683 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2684
2685         Reviewed by Darin Fisher.
2686
2687         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2688         https://bugs.webkit.org/show_bug.cgi?id=51406
2689
2690         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2691         to WebThemeEngineDRTWin and update references everywhere.
2692
2693         * DumpRenderTree/DumpRenderTree.gypi:
2694         * DumpRenderTree/chromium/TestShellWin.cpp:
2695         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2696         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2697         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2698         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2699
2700 2010-12-21  Anders Carlsson  <andersca@apple.com>
2701
2702         Reviewed by John Sullivan.
2703
2704         Clicking missing plug-in text does not show a sheet
2705         https://bugs.webkit.org/show_bug.cgi?id=51403
2706
2707         Update for changes to the WebPageUIClient.
2708
2709         * MiniBrowser/mac/BrowserWindowController.m:
2710         (-[BrowserWindowController awakeFromNib]):
2711         * WebKitTestRunner/TestController.cpp:
2712         (WTR::createOtherPage):
2713         (WTR::TestController::initialize):
2714
2715 2010-12-21  Eric Seidel  <eric@webkit.org>
2716
2717         Reviewed by Adam Barth.
2718
2719         commit-queue will report constant failures as flaky if other tests flake
2720         https://bugs.webkit.org/show_bug.cgi?id=51272
2721
2722         This patch just removes functionality and adds testing.
2723         Previously we attempted to report flaky tests when we had
2724         two different tests fail in a row.  However, since we stop
2725         running the tests at the first failure, our code was wrong in
2726         trying to determine flakiness from the incomplete runs.
2727
2728         Originally I posted an alternate patch:
2729         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2730         which fixed our flaky logic in this case, however it was decided
2731         that that patch would be too difficult to maintain, so now
2732         I'm just removing the broken logic.
2733
2734         This will dramatically cut-down on our flaky-test false positives
2735         at the (small) cost of the queues being unable to report
2736         any flakiness if the tree is very flaky.  (With at least one test
2737         flaking on every run, we'll never report failures anymore.)  I think
2738         this is a tradeoff worth making.
2739
2740         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2741         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2742
2743 2010-12-20  Eric Seidel  <eric@webkit.org>
2744
2745         Reviewed by Adam Barth.
2746
2747         commit-queue wrongly rejects patches when it can't update itself
2748         https://bugs.webkit.org/show_bug.cgi?id=46636
2749
2750         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2751         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2752         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2753
2754 2010-12-20  Adam Barth  <abarth@webkit.org>
2755
2756         Move web sites to Websites directory
2757         https://bugs.webkit.org/show_bug.cgi?id=51323
2758
2759         Update references to BugsSite to point to the new location.
2760
2761         This patch was never officially reviewed (because it was too large to
2762         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2763         Rowe gave me the green light.
2764
2765         * Scripts/old-run-webkit-tests:
2766         * Scripts/webkitpy/common/config/build.py:
2767         * Scripts/webkitpy/common/config/build_unittest.py:
2768         * Scripts/webkitpy/common/prettypatch.py:
2769         * Scripts/webkitpy/layout_tests/port/base.py:
2770         * Scripts/webkitpy/style/main.py:
2771
2772 2010-12-20  Adrienne Walker  <enne@google.com>
2773
2774         Unreviewed. Adding myself to the list of committers.
2775
2776         * webkitpy/common/config/committers.py:
2777
2778 2010-12-20  Mark Rowe  <mrowe@apple.com>
2779
2780         Reviewed by Dan Bernstein.
2781
2782         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2783
2784         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2785         Resources directory.
2786
2787 2010-12-20  Eric Seidel  <eric@webkit.org>
2788
2789         Reviewed by Adam Barth.
2790
2791         commit-queue should include bot id when attaching failure diffs
2792         https://bugs.webkit.org/show_bug.cgi?id=51280
2793
2794         This is a tiny change to include the bot id in the name of the attachment.
2795         Most of this diff is just changing the unit test expectations
2796         now that I hid the comment printing when the comment is None.
2797
2798         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2799         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2800         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2801         * Scripts/webkitpy/tool/mocktool.py:
2802
2803 2010-12-20  Jeff Miller  <jeffm@apple.com>
2804
2805         Reviewed by Dan Bernstein.
2806
2807         Tools/vcbin/midl.exe needs to be rebuilt
2808         https://bugs.webkit.org/show_bug.cgi?id=51347
2809
2810         * vcbin/midl.exe: Rebuilt.
2811
2812 2010-12-20  David Levin  <levin@chromium.org>
2813
2814         Reviewed by Ariya Hidayat.
2815
2816         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2817         https://bugs.webkit.org/show_bug.cgi?id=51343
2818
2819         Follow up from the WebKitTools -> Tools rename.
2820
2821         * Scripts/webkit-tools-completion.sh:
2822
2823 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2824
2825         Reviewed by James Robinson.
2826
2827         new-run-webkit-tests ignores trailing EOL differences in text tests
2828         https://bugs.webkit.org/show_bug.cgi?id=36983
2829
2830         Changed the handling of new-line characters within new-run-webkit-tests
2831         to match old-run-webkit-tests.  Differences in leading and trailing empty
2832         lines in text expectation files are no longer ignored.
2833
2834         * Scripts/webkitpy/layout_tests/port/base.py:
2835         * Scripts/webkitpy/layout_tests/port/test.py:
2836         Added unit tests.  Removed old duplicate unit test entries.
2837         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2838
2839 2010-12-20  David Levin  <levin@chromium.org>
2840
2841         Reviewed by Shinichiro Hamaji.
2842
2843         check-webkit-style should detect function declarations (and trivial functions).
2844         https://bugs.webkit.org/show_bug.cgi?id=51303
2845
2846         * Scripts/webkitpy/style/checkers/cpp.py:
2847         (_FunctionState.begin): Add is_declaration and changed the line count
2848         start to begin at -1 (which will keep the results consistent, since
2849         the starting line number passed in is one less in this change).
2850         (detect_functions): changed function detection to now catch trivial
2851         functions and declarations.
2852         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2853         of the function as this may look at return values (when processing
2854         a declaration).
2855         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2856         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2857         of testing the function detection.
2858         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2859         function.
2860         (FunctionDetectionTest.test_function_declaration_detection): Test a
2861         declaration.
2862         (FunctionDetectionTest.test_non_functions): A test case for a case
2863         that caused the code to fail due to the { being in quotes.
2864         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2865         cases to help catch false alarms for return values.
2866         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2867         we don't get false alarms for member variables either.
2868
2869 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2870
2871         Reviewed by Antonio Gomes.
2872
2873         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2874         https://bugs.webkit.org/show_bug.cgi?id=51319
2875
2876         * CMakeListsEfl.txt:
2877
2878 2010-12-18  Adam Barth  <abarth@webkit.org>
2879
2880         Reviewed by Sam Weinig.
2881
2882         Move WebKitExamplePlugins to Examples
2883         https://bugs.webkit.org/show_bug.cgi?id=51291
2884
2885         * Scripts/webkitpy/common/config/build.py:
2886
2887 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2888
2889         Unreviewed Qt buildfix after r74301.
2890
2891         Rename WebKitTools to Tools
2892         https://bugs.webkit.org/show_bug.cgi?id=49861
2893
2894         * MiniBrowser/DerivedSources.pro:
2895         * MiniBrowser/qt/MiniBrowser.pro:
2896
2897 2010-12-17  Dan Bernstein  <mitz@apple.com>
2898
2899         Reviewed by Simon Fraser.
2900
2901         Rename WebKitTools to Tools
2902         https://bugs.webkit.org/show_bug.cgi?id=49861
2903
2904         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2905         * CodeCoverage/README:
2906         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2907         (WebCore::DumpRenderTree::initializeFonts):
2908         * EWSTools/start-commit-queue.sh:
2909         * EWSTools/start-queue.sh:
2910         * GNUmakefile.am:
2911         * MIDLWrapper/MIDLWrapper.cpp:
2912         (wmain):
2913         * MiniBrowser/qt/MiniBrowser.pro:
2914         * Scripts/build-api-tests:
2915         * Scripts/build-dumprendertree:
2916         * Scripts/build-webkit:
2917         * Scripts/build-webkittestrunner:
2918         * Scripts/generate-coverage-data:
2919         * Scripts/old-run-webkit-tests:
2920         * Scripts/run-api-tests:
2921         * Scripts/run-iexploder-tests:
2922         * Scripts/run-javascriptcore-tests:
2923         * Scripts/run-mangleme-tests:
2924         * Scripts/run-sunspider:
2925         * Scripts/run-webkit-websocketserver:
2926         * Scripts/sunspider-compare-results:
2927         * Scripts/test-webkitperl:
2928         * Scripts/test-webkitpy:
2929         * Scripts/update-iexploder-cssproperties:
2930         * Scripts/update-webkit:
2931         * Scripts/update-webkit-localizable-strings:
2932         * Scripts/webkitdirs.pm:
2933         * Scripts/webkitpy/common/checkout/scm.py:
2934         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2935         * Scripts/webkitpy/common/config/committervalidator.py:
2936         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2937         * Scripts/webkitpy/common/config/ports.py:
2938         * Scripts/webkitpy/common/config/ports_unittest.py:
2939         * Scripts/webkitpy/common/system/logutils_unittest.py:
2940         * Scripts/webkitpy/common/system/ospath_unittest.py:
2941         * Scripts/webkitpy/layout_tests/port/chromium.py:
2942         * Scripts/webkitpy/layout_tests/port/config.py:
2943         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2944         * Scripts/webkitpy/layout_tests/port/http_server.py:
2945         * Scripts/webkitpy/layout_tests/port/test.py:
2946         * Scripts/webkitpy/style/checker.py:
2947         * Scripts/webkitpy/style/checker_unittest.py:
2948         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2949         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2950         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2951         * WebKitTestRunner/DerivedSources.pro:
2952         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2953         (WTR::activateFonts):
2954         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2955         * wx/build/build_utils.py:
2956
2957 2010-12-16  Antonio Gomes  <agomes@rim.com>
2958
2959         Reviewed by Martin Robinson.
2960
2961         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2962         https://bugs.webkit.org/show_bug.cgi?id=51163
2963
2964         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2965         GTK+'s DRT should also reset to UNIX after each test execution.
2966
2967         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2968         (resetDefaultsToConsistentValues):
2969
2970 2010-12-17  David Levin  <levin@chromium.org>
2971
2972         Reviewed by Eric Seidel.
2973
2974         check-webkit-style should understand WTF #include guards
2975         https://bugs.webkit.org/show_bug.cgi?id=44911
2976
2977         * Scripts/webkitpy/style/checkers/cpp.py:
2978         (get_header_guard_cpp_variable): modify to suggest the WTF style
2979         of header guard when appropriate.
2980         (check_for_header_guard): handle multiple return values from
2981         get_header_guard_cpp_variable
2982         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2983         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2984         header style.
2985
2986 2010-12-16  David Levin  <levin@chromium.org>
2987
2988         Reviewed by Eric Seidel.
2989
2990         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2991         https://bugs.webkit.org/show_bug.cgi?id=51210
2992
2993         The error only shows up when using python 2.6 or later.
2994
2995         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2996         the decprecated field error,message with something equivalent.
2997
2998 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2999
3000         Reviewed by Eric Seidel.
3001
3002         Add --exit-after-n-failures/crashes to NRWT
3003         https://bugs.webkit.org/show_bug.cgi?id=51160
3004
3005         Abort test run (in a similar way to how control-C is handled) when
3006         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3007         that number of unexpected failures/crashes/timeouts.
3008
3009         * Scripts/webkitpy/layout_tests/port/test.py:
3010         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3011         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3012
3013 2010-12-16  David Levin  <levin@chromium.org>
3014
3015         Reviewed by Shinichiro Hamaji.
3016
3017         check-webkit-style unit tests has some duplicate boilerplate code.
3018         https://bugs.webkit.org/show_bug.cgi?id=49519
3019
3020         * Scripts/webkitpy/style/checkers/cpp.py:
3021         (update_include_state): Replaced the "io" parameter with the global
3022         configuration _unit_test_config. This allowed not calling into
3023         functions at a low level and also not plumbing through the injection
3024         information through many levels of code.
3025         (check_for_include_what_you_use): Ditto.
3026         (process_file_data): Added the ability to set up the unit test config
3027         to allow for injection.
3028         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3029         (ErrorCollector.__init__): Added support for having a filter for errors.
3030         (ErrorCollector.__call__): Ditto.
3031         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3032         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3033         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3034         functions in the cpp.py with generic processing and a filter that
3035         indicates what errors should be kept.
3036         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3037         (CppStyleTestBase.perform_language_rules_check): Ditto.
3038         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3039         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3040         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3041         (CppStyleTest.test_multi_line_comments): Added another
3042         error message which applies to the test case.
3043         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3044         to not have config.h, since it is processed as a header file.
3045         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3046         style and indentation in checked code.
3047         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3048         Fixed line number.
3049         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3050         Ditto.
3051
3052 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3053
3054         Unreviewed, rolling out r74136.
3055         http://trac.webkit.org/changeset/74136
3056         https://bugs.webkit.org/show_bug.cgi?id=51135
3057
3058         r74136 breaks chromium canary bots because some tests are not
3059         rebaselined correctly to resolve EOL differences (Requested by
3060         jianli on #webkit).
3061
3062         * Scripts/webkitpy/layout_tests/port/base.py:
3063         * Scripts/webkitpy/layout_tests/port/test.py:
3064         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3065
3066 2010-12-15  Adam Roben  <aroben@apple.com>
3067
3068         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3069         syntax errors
3070
3071         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3072         XML syntax errors in .vcproj/.vsprops files
3073
3074         Reviewed by Dave Levin.
3075
3076         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3077         that should be treated as XML and that should be allowed to contain
3078         carriage returns. (These lists happen to be identical currently.)
3079         (FileType): Added a new XML type.
3080         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3081         Just does a simple file extension check.
3082         (CheckerDispatcher._file_type): Added a case for XML files.
3083         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3084         files (surprise!).
3085         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3086         lines through the carriage checker.
3087
3088         * Scripts/webkitpy/style/checker_unittest.py:
3089         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3090         Added. Checks a few file names to see if carriage returns are allowed
3091         or not.
3092         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3093         other assert_checker_* functions.
3094         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3095         test_*_paths functions.
3096         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3097         test_*_paths functions.
3098         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3099         file from this test case, as vcproj files now have a type.
3100         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3101         Added. Similar to the other should_* functions.
3102         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3103         Added. Checks that carriage returns aren't checked for or stripped for
3104         allowed files.
3105
3106         * Scripts/webkitpy/style/checkers/xml.py: Added.
3107         (XMLChecker.__init__): Simple init method.
3108         (XMLChecker.check): Pass each line through the expat parser, and record
3109         a style error for any errors thrown by the parser.
3110
3111         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3112         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3113         produce a style error.
3114         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3115         error of the given category on the given line.
3116         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3117         checking that the XMLChecker constructor works properly.
3118         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3119         cause a style error (see, e.g., r73887).
3120         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3121         cause a style error (see, e.g., r73773).
3122         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3123         properly.
3124         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3125         tags cause a style error (see, e.g., r72795).
3126         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3127         style error.
3128
3129 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3130
3131         Reviewed by Stephanie Lewis.
3132
3133         https://bugs.webkit.org/show_bug.cgi?id=51117
3134         Add a new leopard test bot
3135         really really commit to trunk this time.
3136
3137         * BuildSlaveSupport/build.webkit.org-config/config.json:
3138
3139 2010-12-15  Sam Weinig  <sam@webkit.org>
3140
3141         Reviewed by Anders Carlsson.
3142
3143         WebKit2: Can't add files to an <input type=file>
3144         https://bugs.webkit.org/show_bug.cgi?id=51087
3145
3146         * MiniBrowser/mac/BrowserWindowController.m:
3147         (runOpenPanel):
3148         (-[BrowserWindowController awakeFromNib]):
3149         Add simple implementation of runOpenPanel callback.
3150
3151         * MiniBrowser/win/BrowserView.cpp:
3152         (BrowserView::create):
3153         * WebKitTestRunner/TestController.cpp:
3154         (WTR::createOtherPage):
3155         (WTR::TestController::initialize):
3156         Stub out runOpenPanel callback.
3157
3158 2010-12-14  Eric Seidel  <eric@webkit.org>
3159
3160         Reviewed by Adam Barth.
3161
3162         commit-queue should upload failure diffs when tests flake
3163         https://bugs.webkit.org/show_bug.cgi?id=51051
3164
3165         To make this testable I needed to pipe FileSystem down onto tool.
3166         We've wanted it there for a long time anyway.
3167
3168         This patch is kinda a big hack.  But we don't have a nice
3169         way to read results.html files.  I think this will need further
3170         revision before this code actually feels clean.
3171
3172         As part of testing this change, I had to make MockBugzilla.create_bug
3173         actually return an id (like it should) which required updating
3174         a few other unit test results (for the better).
3175
3176         The results_matching_keys change in layouttestresults/rebasline
3177         was an alternate path which I decided not to use in the end, but
3178         I left the change as it seemed an improvement.
3179
3180         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3181         * Scripts/webkitpy/common/net/layouttestresults.py:
3182         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3183         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3184         * Scripts/webkitpy/tool/commands/queues.py:
3185         * Scripts/webkitpy/tool/commands/rebaseline.py:
3186         * Scripts/webkitpy/tool/main.py:
3187         * Scripts/webkitpy/tool/mocktool.py:
3188
3189 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3190
3191         Reviewed by James Robinson.
3192
3193         new-run-webkit-tests ignores trailing EOL differences in text tests
3194         https://bugs.webkit.org/show_bug.cgi?id=36983
3195
3196         Changed the handling of new-line characters within new-run-webkit-tests
3197         to match old-run-webkit-tests.  Differences in leading and trailing empty
3198         lines in text expectation files are no longer ignored.
3199
3200         * Scripts/webkitpy/layout_tests/port/base.py:
3201         * Scripts/webkitpy/layout_tests/port/test.py:
3202         Added unit tests.  Removed old duplicate unit test entries.
3203         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3204
3205 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3206
3207         Reviewed by Adam Barth.
3208
3209         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3210         https://bugs.webkit.org/show_bug.cgi?id=51149
3211
3212         * QueueStatusServer/templates/statusbubble.html:
3213
3214 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3215
3216         Reviewed by Adam Barth.
3217
3218         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3219         https://bugs.webkit.org/show_bug.cgi?id=51125
3220
3221         * QueueStatusServer/templates/statusbubble.html:
3222
3223 2010-12-15  Darin Adler  <darin@apple.com>
3224
3225         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3226
3227 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3228
3229         Unreviewed, rolling out r74117.
3230         http://trac.webkit.org/changeset/74117
3231         https://bugs.webkit.org/show_bug.cgi?id=51113
3232
3233         This broke the GTK1 build. (Requested by mrobinson on
3234         #webkit).
3235
3236         * Scripts/webkitdirs.pm:
3237
3238 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3239
3240         Reviewed by Martin Robinson.
3241
3242         Change generate-forwarding-headers.pl for GTK port usage
3243         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3244
3245         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3246
3247 2010-12-14  Kent Tamura  <tkent@chromium.org>
3248
3249         Reviewed by Jian Li.
3250
3251         [DRT/Chromium] Remove another unnecessary error message
3252         https://bugs.webkit.org/show_bug.cgi?id=51083
3253
3254         * DumpRenderTree/chromium/WebViewHost.cpp:
3255         (WebViewHost::didInvalidateRect):
3256
3257 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3258
3259         Reviewed by Stephanie Lewis.
3260
3261         Add a new Leopard Debug Test WK2 Bot
3262
3263         * BuildSlaveSupport/build.webkit.org-config/config.json:
3264
3265 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3266
3267         Fix python unittests after http://trac.webkit.org/changeset/74070.
3268
3269         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3270
3271 2010-12-14  Kent Tamura  <tkent@chromium.org>
3272
3273         Reviewed by Jian Li.
3274
3275         [DRT/Chromium] Remove a unnecessary error message
3276         https://bugs.webkit.org/show_bug.cgi?id=51069
3277
3278         * DumpRenderTree/chromium/WebViewHost.cpp:
3279         (WebViewHost::paintInvalidatedRegion):
3280
3281 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3282
3283         Reviewed by Ojan Vafai.
3284
3285         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3286         https://bugs.webkit.org/show_bug.cgi?id=48926
3287
3288         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3289         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3290
3291 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3292
3293         Reviewed by Eric Seidel.
3294
3295         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3296         https://bugs.webkit.org/show_bug.cgi?id=50231
3297
3298         Guard CONFIG+=link_pkgconfig with !symbian.
3299
3300         * DumpRenderTree/qt/DumpRenderTree.pro:
3301         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3302         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3303
3304 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3305
3306         Reviewed by Ojan Vafai.
3307
3308         [new-run-webkit-tests] expectations parsing is slow
3309         https://bugs.webkit.org/show_bug.cgi?id=50635
3310
3311         Avoid expensive iteration of all the tests when checking if a test
3312         file is to be skipped or not.
3313
3314         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3315         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3316         * Scripts/webkitpy/layout_tests/port/test.py:
3317
3318 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3319
3320         Reviewed by Xan Lopez.
3321
3322         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3323         https://bugs.webkit.org/show_bug.cgi?id=27048
3324
3325         Add support in DRT for checking whether an accessibility UI
3326         element is focusable and/or focused. Implemented for GTK.
3327
3328         * DumpRenderTree/AccessibilityUIElement.cpp:
3329         (getIsFocusedCallback): New.
3330         (getIsFocusableCallback): New.
3331         (AccessibilityUIElement::getJSClass): Add the new available
3332         callbacks for isFocused and isFocusable.
3333         * DumpRenderTree/AccessibilityUIElement.h:
3334         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3335         (AccessibilityUIElement::isFocused): New, implemented by checking
3336         whether the related AtkState value is in the object's state set.
3337         (AccessibilityUIElement::isFocusable): Ditto.
3338         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3339         (AccessibilityUIElement::isFocused): New, dummy implementation.
3340         (AccessibilityUIElement::isFocusable): Ditto.
3341         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3342         (AccessibilityUIElement::isFocused): Ditto.
3343         (AccessibilityUIElement::isFocusable): Ditto.
3344
3345 2010-12-14  Eric Seidel  <eric@webkit.org>
3346
3347         Reviewed by Ojan Vafai.
3348
3349         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3350         https://bugs.webkit.org/show_bug.cgi?id=50715
3351
3352         This patch makes webkit-patch print the following:
3353
3354         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3355         Install a 64-bit git for better performance, see:
3356         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3357
3358         I wrote this mostly because I have approximately 8 machines that I use
3359         and making sure each one is using a good Git install seemed folly.
3360         webkit-patch makes a lot of git calls, so using a fast git can shave
3361         several seconds in every invocation.  See the webkit-dev thread for more info.
3362
3363         This message will print twice during 'webkit-patch upload',
3364         once from webkit-patch and once from check-webkit-style.
3365
3366         Unfortunately there is no good way to test this due to how machine-dependent
3367         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3368
3369         * Scripts/webkitpy/common/checkout/scm.py:
3370
3371 2010-12-13  Eric Seidel  <eric@webkit.org>
3372
3373         Reviewed by Adam Barth.
3374
3375         FlakyTestReporter doesn't understand bots running from multiple email addresses
3376         https://bugs.webkit.org/show_bug.cgi?id=50960
3377
3378         This explains at least one of the dupes of:
3379         https://bugs.webkit.org/show_bug.cgi?id=50863
3380         that we saw filed by the commit-queue this morning.
3381         I think the other one was explained by my previous fix to result counting code.
3382
3383         Since this is really hard to test with a unit test, instead I
3384         create a new (possibly useful in the future) command
3385         which given a layout test path will return you
3386         the one bug which our tools would assume it the flaky test bug.
3387         If some other script wants to use bug-for-test we'll
3388         need to extend it with some options like --create-if-missing or similar.
3389
3390         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3391         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3392         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3393         * Scripts/webkitpy/tool/commands/__init__.py:
3394         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3395
3396 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3397
3398         Reviewed by James Robinson.
3399
3400         Add option to build-webkit to not build WebKit2
3401         https://bugs.webkit.org/show_bug.cgi?id=50988
3402
3403         Add support for a --no-webkit2 option to build-webkit. It seems to save
3404         ~1 minute from clean builds and ~10 seconds from no-op builds.
3405
3406         * Scripts/build-webkit:
3407
3408 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3409
3410         Reviewed by Dave Kilzer.
3411
3412         Update iexploder from 1.3.2 to 1.7.2
3413         Move 1.3.2 into its own subdir
3414         Add 1.7.2 into its own subdir
3415         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3416
3417         * Scripts/run-iexploder-tests:
3418         * Scripts/update-iexploder-cssproperties:
3419         * iExploder/CHANGELOG.txt: Removed.
3420         * iExploder/LICENSE.txt: Removed.
3421         * iExploder/README.txt: Removed.
3422         * iExploder/htdocs: Removed.
3423         * iExploder/iexploder-1.3.2: Added.
3424         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3425         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3426         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3427         * iExploder/iexploder-1.3.2/htdocs: Added.
3428         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3429         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3430         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3431         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3432         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3433         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3434         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3435         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3436         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3437         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3438         * iExploder/iexploder-1.3.2/tools: Added.
3439         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3440         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3441         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3442         * iExploder/iexploder-1.7.2: Added.
3443         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3444         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3445         * iExploder/iexploder-1.7.2/README.txt: Added.
3446         * iExploder/iexploder-1.7.2/output: Added.
3447         * iExploder/iexploder-1.7.2/src: Added.
3448         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3449         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3450         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3451         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3452         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3453         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3454         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3455         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3456         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3457         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3458         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3459         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3460         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3461         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3462         * iExploder/iexploder-1.7.2/src/css-values: Added.
3463         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3464         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3465         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3466         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3467         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3468         * iExploder/iexploder-1.7.2/src/headers: Added.
3469         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3470         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3471         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3472         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3473         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3474         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3475         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3476         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3477         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3478         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3479         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3480         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3481         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3482         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3483         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3484         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3485         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3486         * iExploder/iexploder-1.7.2/src/html-values: Added.
3487         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3488         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3489         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3490         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3491         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3492         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3493         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3494         * iExploder/iexploder-1.7.2/src/index.html: Added.
3495         * iExploder/iexploder-1.7.2/src/media: Added.
3496         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3497         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3498         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3499         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3500         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3501         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3502         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3503         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3504         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3505         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3506         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3507         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3508         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3509         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3510         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3511         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3512         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3513         * iExploder/iexploder-1.7.2/src/protocols: Added.
3514         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3515         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3516         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3517         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3518         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3519         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3520         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3521         * iExploder/iexploder-1.7.2/testcases: Added.
3522         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3523         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3524         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3525         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3526         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3527         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3528         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3529         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3530         * iExploder/iexploder-1.7.2/tools: Added.
3531         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3532         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3533         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3534         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3535         * iExploder/tools: Removed.
3536
3537 2010-12-13  Sam Weinig  <sam@webkit.org>
3538
3539         Reviewed by Anders Carlsson.
3540
3541         Remove associated page concept from WKView constructor
3542         https://bugs.webkit.org/show_bug.cgi?id=50983
3543
3544         Step 1: Remove associate page constructors from WKView and make
3545         all views use the shared namespace for the context.
3546
3547         * TestWebKitAPI/PlatformWebView.h:
3548         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3549         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3550         * WebKitTestRunner/PlatformWebView.h:
3551         * WebKitTestRunner/TestController.cpp:
3552         (WTR::createOtherPage):
3553         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3554         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3555         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3556
3557 2010-12-13  Sam Weinig  <sam@webkit.org>
3558
3559         Reviewed by Anders Carlsson.
3560
3561         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3562         https://bugs.webkit.org/show_bug.cgi?id=50898
3563
3564         * MiniBrowser/mac/AppDelegate.h:
3565         * MiniBrowser/mac/AppDelegate.m:
3566         * MiniBrowser/mac/BrowserWindowController.h:
3567         * MiniBrowser/mac/BrowserWindowController.m:
3568         * MiniBrowser/win/BrowserView.cpp:
3569         Convert MiniBrowser to not use PageNamespaces.
3570
3571         * TestWebKitAPI/PlatformWebView.h:
3572         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3573         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3574         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3575         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3576         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3577         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3578         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3579         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3580         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3581         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3582         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3583         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3584         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3585         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3586         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3587         Convert TestWebKitAPI to not use PageNamespaces.
3588
3589         * WebKitTestRunner/PlatformWebView.h:
3590         * WebKitTestRunner/TestController.cpp:
3591         * WebKitTestRunner/TestController.h:
3592         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3593         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3594         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3595         Convert WebKitTestRunner to not use PageNamespaces.
3596
3597 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3598
3599         Reviewed by Eric Seidel.
3600
3601         webkit-patch rollout should be able to do multi-revision rollouts
3602         https://bugs.webkit.org/show_bug.cgi?id=33336
3603
3604         Make it possible to pass more than one revision to webkit-patch.
3605
3606         * Scripts/webkitpy/common/checkout/api.py:
3607         * Scripts/webkitpy/common/checkout/changelog.py:
3608         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3609         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3610         * Scripts/webkitpy/tool/commands/download.py:
3611         * Scripts/webkitpy/tool/commands/download_unittest.py:
3612         * Scripts/webkitpy/tool/mocktool.py:
3613         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3614         * Scripts/webkitpy/tool/steps/revertrevision.py:
3615
3616 2010-12-13  Eric Seidel  <eric@webkit.org>
3617
3618         Unreviewed.
3619
3620         Teach webkit-patch how to search bugzilla
3621         https://bugs.webkit.org/show_bug.cgi?id=50500
3622
3623         webkit-patch bug-search fails when there is only one result.
3624         Turns out we needed a bit more logic in our result count parsing code.
3625
3626         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3627         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3628
3629 2010-12-13  Antti Koivisto  <antti@apple.com>
3630
3631         Reviewed by Alexey Proskuryakov.
3632
3633         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3634         https://bugs.webkit.org/show_bug.cgi?id=50758
3635
3636         * DumpRenderTree/LayoutTestController.cpp:
3637         (setSerializeHTTPLoadsCallback):
3638         (LayoutTestController::staticFunctions):
3639         * DumpRenderTree/LayoutTestController.h:
3640         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3641         (LayoutTestController::setSerializeHTTPLoads):
3642         * DumpRenderTree/mac/DumpRenderTree.mm:
3643         (resetDefaultsToConsistentValues):
3644         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3645         (LayoutTestController::setSerializeHTTPLoads):
3646         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3647         (LayoutTestController::setSerializeHTTPLoads):
3648
3649 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3650
3651         Reviewed by Ojan Vafai.
3652
3653         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3654         https://bugs.webkit.org/show_bug.cgi?id=50936