Tools/ChangeLog

   1 2011-08-08  Adam Barth  <abarth@webkit.org>
   2
   3         bulk-optimize-baselines should take directories on the command line
   4         https://bugs.webkit.org/show_bug.cgi?id=65879
   5
   6         Reviewed by Dimitri Glazkov.
   7
   8         Passing lists of tests via stdin is a pain.  It's easier if the command
   9         takes a list of tests on the command line, like run-webkit-tests.
  10
  11         * Scripts/webkitpy/tool/commands/rebaseline.py:
  12
  13 2011-08-08  Adam Barth  <abarth@webkit.org>
  14
  15         Deprecate rebaseline-chromium-webkit-tests
  16         https://bugs.webkit.org/show_bug.cgi?id=65873
  17
  18         Reviewed by Dimitri Glazkov.
  19
  20         This script never worked correctly and now is redundant with more
  21         modern infrastructure for rebaselining tests.  This patch deprecates
  22         the script in order to flush out any issues with the new tools.  Once
  23         folks are happy with the new tools, we'll delete this script.
  24
  25         * Scripts/rebaseline-chromium-webkit-tests:
  26
  27 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
  28
  29         garden-o-matic should only touch expectations that need updating.
  30         https://bugs.webkit.org/show_bug.cgi?id=65876
  31
  32         Reviewed by Adam Barth.
  33
  34         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,
  35             so that a caller could influence which lines to serialize from values.
  36         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
  37         * Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
  38         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
  39
  40 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
  41
  42         TestExpectationsEditor should return a list of updated expectations.
  43         https://bugs.webkit.org/show_bug.cgi?id=65872
  44
  45         Reviewed by Adam Barth.
  46
  47         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
  48         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
  49
  50 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
  51
  52         Fix SCM webkitpy unit test failures
  53         https://bugs.webkit.org/show_bug.cgi?id=65823
  54
  55         Reviewed by Eric Seidel.
  56
  57         * Scripts/webkitpy/common/checkout/scm/git.py:
  58         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  59
  60 2011-08-08  Eric Seidel  <eric@webkit.org>
  61
  62         Move the --leaks bot back over to NRWT now that I'm back
  63         from vacation and able to debug it.
  64
  65         Unreviewed.
  66
  67         * Scripts/run-webkit-tests:
  68         (usingWebKit2):
  69         (useNewRunWebKitTests):
  70
  71 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
  72
  73         Wire up updating expectations in garden-o-matic.
  74         https://bugs.webkit.org/show_bug.cgi?id=65794
  75
  76         Reviewed by Adam Barth.
  77
  78         * Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
  79         * Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
  80         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
  81         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
  82
  83 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
  84
  85         webkit-patch doesn't get along with renamed files
  86         https://bugs.webkit.org/show_bug.cgi?id=48075
  87
  88         Possibly a bit heavy handed - I removed all instances of -C and
  89         changed every instance of -M with '--no-renames' in git.py. This
  90         forces git to not try to tell us about renames at all, which is
  91         ultimately the behaviour we want. The old file is shown deleted,
  92         then the new file is shown added, followed by any changes that
  93         occurred. Also gets rid of the problem where deleting one file
  94         and adding another file which has similar content would
  95         unexpectedly show up as a rename, and fall out of a diff.
  96
  97         Based on a patch by Wyatt Carss.
  98
  99         Reviewed by Eric Seidel.
 100
 101         * Scripts/webkitpy/common/checkout/scm/git.py:
 102
 103 2011-08-07  Sam White  <samuel.white@rochester.edu>
 104
 105         Add the ability to search the AccessibilityObject cache
 106         https://bugs.webkit.org/show_bug.cgi?id=64994
 107
 108         Added testing support for AccessibilityObject cache searching. Currently,
 109         only the mac platform is full supported and has had API exposed. Other
 110         platforms have only have this new functionality stubbed. Full implementation
 111         is a job suited only for an accessibility expert of each respective platform.
 112
 113         Reviewed by Chris Fleizach.
 114
 115         * DumpRenderTree/AccessibilityUIElement.cpp:
 116         (uiElementForSearchPredicateCallback):
 117         (AccessibilityUIElement::getJSClass):
 118         * DumpRenderTree/AccessibilityUIElement.h:
 119         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 120         (AccessibilityUIElement::uiElementForSearchPredicate):
 121         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 122         (AccessibilityUIElement::uiElementForSearchPredicate):
 123         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 124         (AccessibilityUIElement::uiElementForSearchPredicate):
 125
 126 2011-08-06  Adam Barth  <abarth@webkit.org>
 127
 128         Remove dead code in webkitpy
 129         https://bugs.webkit.org/show_bug.cgi?id=65818
 130
 131         Reviewed by Dimitri Glazkov.
 132
 133         This code was added to support the rebaseline2 command six months ago,
 134         but the rebaseline2 command was never finished and no one else has used
 135         this code since it was landed.  This patch removes the dead code.  If
 136         we revive rebaseline2, then we can revert this patch and recover the
 137         code.  Until then, this code is just dead weight.
 138
 139         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
 140         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
 141         * Scripts/webkitpy/common/net/testoutput.py: Removed.
 142         * Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
 143         * Scripts/webkitpy/common/net/testoutputset.py: Removed.
 144         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
 145         * Scripts/webkitpy/common/system/directoryfileset.py: Removed.
 146         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
 147         * Scripts/webkitpy/layout_tests/port/base.py:
 148         * Scripts/webkitpy/layout_tests/port/chromium.py:
 149         * Scripts/webkitpy/layout_tests/port/webkit.py:
 150
 151 2011-08-06  Adam Barth  <abarth@webkit.org>
 152
 153         webkit-patch optimize-baselines can't handle promotions to base results directory
 154         https://bugs.webkit.org/show_bug.cgi?id=65819
 155
 156         Reviewed by Dimitri Glazkov.
 157
 158         This bug came up when testing the optimizer on some editing baselines.
 159
 160         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
 161         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
 162
 163 2011-08-06  Adam Barth  <abarth@webkit.org>
 164
 165         Add a small command to optimize baselines in bulk.
 166
 167         * Scripts/webkitpy/tool/commands/rebaseline.py:
 168
 169 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
 170
 171         Fix unit test breakage by plumbing convert_404_to_None in MockWeb.
 172
 173         * Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
 174
 175 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
 176
 177         Garden-o-matic updateexpectations needs a unit test.
 178         https://bugs.webkit.org/show_bug.cgi?id=65780
 179
 180         Reviewed by Adam Barth.
 181
 182         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
 183
 184 2011-08-05  Anders Carlsson  <andersca@apple.com>
 185
 186         Future proof an Objective-C test
 187         https://bugs.webkit.org/show_bug.cgi?id=65788
 188
 189         Reviewed by Dan Bernstein.
 190
 191         Add isObjectInstanceOf to ObjCController.
 192
 193         * DumpRenderTree/mac/ObjCController.m:
 194         (+[ObjCController isSelectorExcludedFromWebScript:]):
 195         (+[ObjCController webScriptNameForSelector:]):
 196         (-[ObjCController isObject:instanceOf:]):
 197
 198 2011-08-05  Adam Barth  <abarth@webkit.org>
 199
 200         trac.js needs unittests
 201         https://bugs.webkit.org/show_bug.cgi?id=65673
 202
 203         Reviewed by Dimitri Glazkov.
 204
 205         This tests also have somewhat large fixtures.  I've trimmed the example
 206         XML down a bunch while still hitting interesting cases in the parsing.
 207
 208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
 209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
 210
 211 2011-08-05  Adam Barth  <abarth@webkit.org>
 212
 213         Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
 214         https://bugs.webkit.org/show_bug.cgi?id=65759
 215
 216         Reviewed by Dimitri Glazkov.
 217
 218         rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
 219         architecture, is poorly tested, and has a bunch of quirks.  This patch
 220         rebuilds the core functionality of rebaseline-chromium-webkit-tests on
 221         top of more modern infrastructure.  In the process, we get more code
 222         re-use and better testing.
 223
 224         Once we're satisfied with this new implementation, we can delete the
 225         old implementation.
 226
 227         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
 228         * Scripts/webkitpy/common/net/web.py:
 229         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 230         * Scripts/webkitpy/layout_tests/port/builders.py:
 231         * Scripts/webkitpy/layout_tests/port/chromium.py:
 232         * Scripts/webkitpy/layout_tests/port/factory.py:
 233         * Scripts/webkitpy/layout_tests/port/webkit.py:
 234         * Scripts/webkitpy/tool/commands/rebaseline.py:
 235         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 236
 237 2011-08-05  Anders Carlsson  <andersca@apple.com>
 238
 239         Remove PluginHalter
 240         https://bugs.webkit.org/show_bug.cgi?id=65729
 241
 242         Reviewed by Darin Adler.
 243
 244         Remove call to set the allowed plug-in run time.
 245
 246         * DumpRenderTree/mac/DumpRenderTree.mm:
 247         (resetDefaultsToConsistentValues):
 248
 249 2011-08-05  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
 250
 251         Unreviewed build fix for Qt-Minimal buildbot
 252
 253         Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
 254         is disabled.
 255
 256         Rubber-stamped by Holger Freyther.
 257
 258         * QtTestBrowser/cookiejar.cpp:
 259         (TestBrowserCookieJar::TestBrowserCookieJar):
 260
 261 2011-08-05  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
 262
 263         [Qt] QtTestBrowser: Add support for saving cookies on disk
 264         https://bugs.webkit.org/show_bug.cgi?id=65328
 265
 266         Simple cookiejar that saves cookies on disk.
 267
 268         Added menu options to clear cookies (Edit->Clear cookies) and
 269         disable disk cookies (Settings->[ ]Save Cookies on Disk).
 270
 271         Option -no-disk-cookies is also available.
 272
 273         Reviewed by Andreas Kling.
 274
 275         * QtTestBrowser/QtTestBrowser.pro:
 276         * QtTestBrowser/cookiejar.cpp: Added.
 277         * QtTestBrowser/cookiejar.h: Added.
 278         * QtTestBrowser/launcherwindow.cpp:
 279         * QtTestBrowser/launcherwindow.h:
 280         * QtTestBrowser/main.cpp:
 281
 282 2011-08-04  Adam Barth  <abarth@webkit.org>
 283
 284         model.js needs some unit testing
 285         https://bugs.webkit.org/show_bug.cgi?id=65730
 286
 287         Reviewed by Dimitri Glazkov.
 288
 289         These tests do not cover all the functions exported by the model
 290         module.  We'll need to add the remaining ones in the future.
 291
 292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
 293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
 294
 295 2011-08-04  Adam Barth  <abarth@webkit.org>
 296
 297         Another speculative fix for the "svn revision on Windows" problem.
 298
 299         * Scripts/webkitpy/common/checkout/scm/git.py:
 300
 301 2011-08-04  Mark Rowe  <mrowe@apple.com>
 302
 303         Future-proof Xcode configuration settings.
 304
 305         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 306         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
 307         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 308         * MiniBrowser/Configurations/Base.xcconfig:
 309         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
 310         * MiniBrowser/Configurations/DebugRelease.xcconfig:
 311         * TestWebKitAPI/Configurations/Base.xcconfig:
 312         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
 313         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
 314         * WebKitTestRunner/Configurations/Base.xcconfig:
 315         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
 316         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
 317
 318 2011-08-04  Adam Barth  <abarth@webkit.org>
 319
 320         Fancier debug logging.
 321
 322         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 323
 324 2011-08-04  David Levin  <levin@chromium.org>
 325
 326         [chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
 327         https://bugs.webkit.org/show_bug.cgi?id=65685
 328
 329         Reviewed by Dmitry Titov.
 330
 331         * DumpRenderTree/chromium/WebViewHost.cpp:
 332         (WebViewHost::WebViewHost): Intialize WTF threading before
 333         anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
 334         but in some cases code may use WTF without creating WebViewImpl and
 335         WTF code functionality may call WTF::currentThread, which requires
 336         this initialization now.
 337
 338 2011-08-04  Adam Barth  <abarth@webkit.org>
 339
 340         An educated guess at causing the Windows bots on build.webkit.org to
 341         find the SVN revision number.
 342
 343         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 344         * Scripts/webkitpy/layout_tests/port/base.py:
 345
 346 2011-08-04  Adam Barth  <abarth@webkit.org>
 347
 348         More logging to help debug the "no SVN rev on Chromium Windows bots"
 349         bug.  My current theory is that we're trying to detect the SCM system
 350         in the wrong directory.
 351
 352         * Scripts/webkitpy/layout_tests/port/base.py:
 353
 354 2011-08-04  Dimitri Glazkov  <dglazkov@chromium.org>
 355
 356         Speed up webkit-patch optimize-expectations significantly by not collecting test files.
 357         https://bugs.webkit.org/show_bug.cgi?id=65697
 358
 359         I neglected to realize that collecting test names is not necessary for this operation.
 360
 361         Reviewed by Adam Barth.
 362
 363         * Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
 364
 365 2011-08-04  Adam Barth  <abarth@webkit.org>
 366
 367         checkout_unittest.js should have better coverage of checkout.js
 368         https://bugs.webkit.org/show_bug.cgi?id=65671
 369
 370         Reviewed by Dimitri Glazkov.
 371
 372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
 373             - Remove unused functions.
 374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
 375             - Test remaining public functions in the checkout module.
 376
 377 2011-08-04  Dmitry Lomov  <dslomov@google.com>
 378
 379         https://bugs.webkit.org/show_bug.cgi?id=65706
 380         Run run-unit-tests on release mode test bots.
 381         Reenabling after 61812 is fixed.
 382
 383         Reviewed by Adam Roben.
 384
 385         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 386
 387 2011-08-04  Adam Barth  <abarth@webkit.org>
 388
 389         builders.js needs unit tests
 390         https://bugs.webkit.org/show_bug.cgi?id=65670
 391
 392         Reviewed by Dimitri Glazkov.
 393
 394         This test requires somewhat large test fixtures, but using real
 395         examples seemed better than trimming them down too much.
 396
 397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
 398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
 399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
 400             - Note: trac_unittests.js doesn't exist (yet!).
 401
 402 2011-08-04  Alexis Menard  <alexis.menard@openbossa.org>
 403
 404         [Qt] Make navigation actions properly usable in QML.
 405         https://bugs.webkit.org/show_bug.cgi?id=65624
 406
 407         Fix compilation after the introduction of QWebNavigationController.
 408
 409         Reviewed by Benjamin Poulain.
 410
 411         * MiniBrowser/qt/BrowserView.cpp:
 412         (BrowserView::navigationAction):
 413
 414 2011-08-04  Adam Barth  <abarth@webkit.org>
 415
 416         Another subtle bug due to lack of testing in main.js.  :(
 417
 418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
 419
 420 2011-08-04  Adam Barth  <abarth@webkit.org>
 421
 422         Fix types.  Sadly, main.js has no test coverage.  (I need to think
 423         about how to test this part of the code.)
 424
 425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
 426
 427 2011-08-04  Adam Barth  <abarth@webkit.org>
 428
 429         bugzilla.js is missing unit tests
 430         https://bugs.webkit.org/show_bug.cgi?id=65656
 431
 432         Reviewed by Adam Roben.
 433
 434         Testing makes perfect.
 435
 436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added.
 437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
 438         (NetworkSimulator.prototype.runTest.get if):
 439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
 440
 441 2011-08-04  Adam Barth  <abarth@webkit.org>
 442
 443         Add missing license blocks to garden-o-matic
 444         https://bugs.webkit.org/show_bug.cgi?id=65654
 445
 446         Reviewed by Dimitri Glazkov.
 447
 448         This patch is entirely boilerplate.
 449
 450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
 451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
 452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
 453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
 454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
 455         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
 456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
 457         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
 458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
 459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
 460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
 461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
 462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
 463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
 464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
 465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
 466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
 467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
 468
 469 2011-08-04  Adam Barth  <abarth@webkit.org>
 470
 471         garden-o-matic needs a way to mock out the network
 472         https://bugs.webkit.org/show_bug.cgi?id=65653
 473
 474         Reviewed by Dimitri Glazkov.
 475
 476         This patch introduces the net module, which is a useful mock point for
 477         abstracting away the network.  Future patches will use this
 478         infrastructure to test some currently untested code.
 479
 480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
 481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
 482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
 483         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
 484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
 485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
 486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
 487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
 488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.
 489         (NetworkSimulator):
 490         (NetworkSimulator.prototype.scheduleCallback):
 491         (NetworkSimulator.prototype.runTest):
 492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
 493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
 494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
 495         * Scripts/webkitpy/tool/servers/gardeningserver.py:
 496
 497 2011-08-03  Adam Barth  <abarth@webkit.org>
 498
 499         Use failureInfo more pervasively in garden-o-matic
 500         https://bugs.webkit.org/show_bug.cgi?id=65650
 501
 502         Reviewed by Dimitri Glazkov.
 503
 504         These three variable appears in concert together many places.  This
 505         patch unifies the remaining uses into being failureInfo objects, which
 506         saves some marshalling.
 507
 508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
 509         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
 510         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
 511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
 512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
 513
 514 2011-08-03  Adam Barth  <abarth@webkit.org>
 515
 516         garden-o-matic should be able to update expecations from the details pane
 517         https://bugs.webkit.org/show_bug.cgi?id=65648
 518
 519         Reviewed by Dimitri Glazkov.
 520
 521         The new button queues up the updates, which get executed all at once.
 522
 523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
 524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
 525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
 526
 527 2011-08-03  Adam Barth  <abarth@webkit.org>
 528
 529         Add UI to garden-o-matic for updating expectations
 530         https://bugs.webkit.org/show_bug.cgi?id=65644
 531
 532         Reviewed by Dimitri Glazkov.
 533
 534         The patch plumbs the UI back to the gardening server, but the gardening
 535         server endpoint is just a stub at this point.
 536
 537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
 538         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
 539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
 540         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
 541         * Scripts/webkitpy/tool/servers/gardeningserver.py:
 542         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
 543
 544 2011-08-03  Adam Barth  <abarth@webkit.org>
 545
 546         garden-o-matic details view should queue rebaselines for later execution
 547         https://bugs.webkit.org/show_bug.cgi?id=65636
 548
 549         Reviewed by Dimitri Glazkov.
 550
 551         This patch doesn't contain any confirmation UI, but we'll probably want
 552         that at some point.
 553
 554         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
 555         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
 556         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
 557         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
 558
 559 2011-08-03  Kentaro Hara  <haraken@google.com>
 560
 561         Implement EventSender.scalePageBy()
 562         https://bugs.webkit.org/show_bug.cgi?id=58013
 563
 564         Reviewed by Darin Fisher.
 565
 566         Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
 567         and then sets a scroll position to (x, y). Enabled the tests that had been waiting
 568         for the implementation of EventSender.scalePageBy(f, x, y).
 569
 570         Tests: compositing/scaling/tiled-layer-recursion.html
 571                fast/repaint/scale-page-shrink.html
 572                fast/dom/Element/scale-page-client-rects.html
 573                fast/dom/Range/scale-page-client-rects.html
 574                fast/events/scroll-in-scaled-page-with-overflow-hidden.html
 575                fast/dom/Element/scale-page-bounding-client-rect.html
 576                fast/dom/Range/scale-page-bounding-client-rect.html
 577
 578         * DumpRenderTree/chromium/EventSender.cpp:
 579         (EventSender::EventSender): Added bindings for scalePageBy().
 580         (EventSender::scalePageBy): A wrapper method for scalePage() in WebView.
 581         * DumpRenderTree/chromium/EventSender.h:
 582         * DumpRenderTree/chromium/TestShell.cpp:
 583         (TestShell::resetTestController): Resets the scale factor to 1.
 584
 585 2011-08-03  David Levin  <levin@chromium.org>
 586
 587         Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
 588         https://bugs.webkit.org/show_bug.cgi?id=65652
 589
 590         Reviewed by Adam Barth.
 591
 592         * Scripts/webkitpy/style/checkers/cpp.py:
 593         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 594
 595 2011-08-03  Filip Pizlo  <fpizlo@apple.com>
 596
 597         Adding Filip Pizlo to committer list.
 598
 599         Unreviewed.
 600
 601         * Scripts/webkitpy/common/config/committers.py:
 602
 603 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
 604
 605         Add "optimize-expectations" command to webkit-patch.
 606         https://bugs.webkit.org/show_bug.cgi?id=65633
 607
 608         For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.
 609
 610         Reviewed by Adam Barth.
 611
 612         * Scripts/webkitpy/tool/commands/__init__.py: Added command.
 613         * Scripts/webkitpy/tool/commands/expectations.py: Added.
 614
 615 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
 616
 617         Allow multiple bug identifiers in test expectations.
 618         https://bugs.webkit.org/show_bug.cgi?id=65642
 619
 620         Reviewed by Adam Barth.
 621
 622         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
 623         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
 624
 625 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
 626
 627         Teach BuilderToPort to distinguish between Release and Debug builders.
 628         https://bugs.webkit.org/show_bug.cgi?id=65628
 629
 630         Reviewed by Adam Barth.
 631
 632         * Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
 633         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.
 634
 635 2011-08-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
 636
 637         [Qt] Fix running qmltests for WK2 in the bot
 638         https://bugs.webkit.org/show_bug.cgi?id=65621
 639
 640         Reviewed by Csaba Osztrogonác.
 641
 642         The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
 643         but now there's the case for WK2 UIProcess tests as well.
 644
 645         * Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.
 646
 647 2011-08-02  Dimitri Glazkov  <dglazkov@chromium.org>
 648
 649         Add a way to edit test expectations.
 650         https://bugs.webkit.org/show_bug.cgi?id=64922
 651
 652         Implements a TestExpectationsEditor, which provides a standard way to
 653         update and remove test expectations.
 654
 655         Reviewed by Adam Barth.
 656
 657         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,
 658             added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
 659             enchilada.
 660         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.
 661
 662 2011-08-03  Andreas Kling  <kling@webkit.org>
 663
 664         [Qt] MiniBrowser: Unbreak load progress indication.
 665         https://bugs.webkit.org/show_bug.cgi?id=65614
 666
 667         Reviewed by Kenneth Rohde Christiansen.
 668
 669         loadProgress() was renamed to loadProgressChanged().
 670
 671         * MiniBrowser/qt/BrowserWindow.cpp:
 672         (BrowserWindow::BrowserWindow):
 673         (BrowserWindow::onLoadProgressChanged):
 674         * MiniBrowser/qt/BrowserWindow.h:
 675
 676 2011-08-03  Martin Robinson  <mrobinson@igalia.com>
 677
 678         Build fix for WebKit2GTK+.
 679
 680         * WebKitTestRunner/GNUmakefile.am: Include libInternals as one of
 681         of the library dependencies of the injected bundle.
 682
 683 2011-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 684
 685         [GTK] Install web and plugin processes in libexecdir instead of bindir
 686         https://bugs.webkit.org/show_bug.cgi?id=65600
 687
 688         Reviewed by Martin Robinson.
 689
 690         Set WEBKIT_EXEC_PATH environment variable to use web and plugin
 691         process from current directory instead of the intalled ones.
 692
 693         * MiniBrowser/gtk/GNUmakefile.am:
 694         * MiniBrowser/gtk/main.c:
 695         (main):
 696         * WebKitTestRunner/GNUmakefile.am:
 697         * WebKitTestRunner/gtk/main.cpp:
 698         (main):
 699
 700 2011-08-02  Anders Carlsson  <andersca@apple.com>
 701
 702         Add mac-lion platform to old-run-webkit-tests
 703         https://bugs.webkit.org/show_bug.cgi?id=65577
 704
 705         * Scripts/old-run-webkit-tests:
 706         * Scripts/webkitdirs.pm:
 707         (isLion):
 708
 709 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
 710
 711         Buildbot: The Properties object has no "hasProperty" method in buildbot 8.3
 712         https://bugs.webkit.org/show_bug.cgi?id=65554
 713
 714         Using "has_key" instead of "hasProperty" in order to support buildbot 8.3.
 715
 716         Reviewed by Adam Roben.
 717
 718         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 719
 720 2011-08-02  Jochen Eisinger  <jochen@chromium.org>
 721
 722         Implement WebPermissionClient::allowPlugins for layout tests
 723         https://bugs.webkit.org/show_bug.cgi?id=33991
 724
 725         Reviewed by Adam Barth.
 726
 727         * DumpRenderTree/chromium/LayoutTestController.cpp:
 728         (LayoutTestController::LayoutTestController):
 729         (LayoutTestController::setPluginsAllowed):
 730         * DumpRenderTree/chromium/LayoutTestController.h:
 731         * DumpRenderTree/chromium/WebPermissions.cpp:
 732         (WebPermissions::allowPlugins):
 733         (WebPermissions::setPluginsAllowed):
 734         (WebPermissions::reset):
 735         * DumpRenderTree/chromium/WebPermissions.h:
 736
 737 2011-08-02  Adam Barth  <abarth@webkit.org>
 738
 739         TestFailures unit tests leak a global variable
 740         https://bugs.webkit.org/show_bug.cgi?id=65500
 741
 742         Reviewed by Adam Roben.
 743
 744         qunit detects the leak if you check the "noglobals" box on run-unittests.html.
 745
 746         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
 747
 748 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
 749
 750         CSS Regions build bot should archive and upload output files
 751         https://bugs.webkit.org/show_bug.cgi?id=65200
 752
 753         Until now the buildbots would only upload the result archive if the 'trigger' parameters was specified. The
 754         upload was needed, because the testbots needed to download and use the archive. For CSS Regions we don't have
 755         a testbot yet, but we want to save the archive on the server for manual testing. Added new parameter
 756         in config.json, called "upload" that when set to "true" will force the upload to the buildmaster server.
 757
 758         The "features" argument is now taken into account when determining the name of the archive on the server. That
 759         was needed in order to avoid the CSS Regions Mac buildbot overwrite the SnowLeopard Mac build.
 760
 761         Reviewed by Adam Roben.
 762
 763         * BuildSlaveSupport/build.webkit.org-config/config.json:
 764         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 765
 766 2011-08-02  Patrick Gansterer  <paroga@webkit.org>
 767
 768         Fix _win32_check_running_pid on 64bit windows python
 769         https://bugs.webkit.org/show_bug.cgi?id=64950
 770
 771         Reviewed by Adam Roben.
 772
 773         Use the correct types for the PROCESSENTRY32 struct.
 774         th32DefaultHeapID is declared as ULONG_PTR and not as DWORD.
 775         Using 32bit for pointers instead of 64bit results in an ERROR_BAD_LENGTH
 776         failure, when calling the Process32First function.
 777         This is covered by the executive unittest.
 778
 779         * Scripts/webkitpy/common/system/executive.py:
 780
 781 2011-08-01  Adam Barth  <abarth@webkit.org>
 782
 783         garden-o-matic should call optimize-baselines when rebaselining tests
 784         https://bugs.webkit.org/show_bug.cgi?id=65499
 785
 786         Reviewed by Dimitri Glazkov.
 787
 788         I took the opportunity to modernize this code to use some of our more
 789         powerful primitives from base.
 790
 791         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
 792         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
 793         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
 794         * Scripts/webkitpy/tool/servers/gardeningserver.py:
 795         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
 796
 797 2011-08-01  Stephanie Lewis  <slewis@apple.com>
 798
 799         Finish reconfiguration started by Lucas Forschler
 800         Reconfigured slaves:
 801         Removed Leopard Intel Release (Build)
 802         Removed Leopard Intel Release (Tests)
 803         Remove apple-pixel-1
 804         Added Lion slaves from disabled Leopard slaves
 805
 806         Added builders:
 807         Lion Intel Release (Build)
 808         Lion Intel Debug (Build)
 809         Lion Intel Release (Tests)
 810         Lion Intel Release WK2 (Tests)
 811         Lion Intel Debug (Tests)
 812         Lion Intel Debug WK2 (Tests)
 813
 814         Added triggers:
 815         lion-intel-debug-tests
 816         lion-intel-debug-test-wk2
 817         lion-intel-release-tests
 818         lion-intel-release-tests-wk2
 819
 820         Removed trigger:
 821         leopard-intel-release-tests
 822
 823         Added PlatformSpecificScheduler:
 824         mac-lion
 825
 826         Added "mac-lion" to build.py and build_unitttest.py
 827
 828         Reviewed by Mark Rowe.
 829
 830         * BuildSlaveSupport/build.webkit.org-config/config.json:
 831         * Scripts/webkitpy/common/config/build.py:
 832         * Scripts/webkitpy/common/config/build_unittest.py:
 833
 834
 835 2011-08-01  Adam Barth  <abarth@webkit.org>
 836
 837         webkit-patch needs to be able to "optimize" the storage of baselines on disk
 838         https://bugs.webkit.org/show_bug.cgi?id=65418
 839
 840         Reviewed by Dimitri Glazkov.
 841
 842         If we're not careful when rebaselining tests, we can end up with lots
 843         of duplicate expected results files in the tree.  This patch adds a
 844         webkit-patch command that optimizes the storage of expected results on
 845         disk.
 846
 847         This command is similar to deduplicate-tests, except that it can move
 848         test results around rather than just remove duplicate results.
 849
 850         Unfortunately, this problem is very tricky because the baseline search
 851         structure is a hypergraph.  This patch include a huerstic optimizer
 852         that appears to work on a bunch of examples I've tried.  We'll likely
 853         need to refine it as gain experience.
 854
 855         * Scripts/webkitpy/common/system/filesystem.py:
 856         * Scripts/webkitpy/tool/commands/rebaseline.py:
 857
 858 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
 859
 860         Teach TestExpectationSerializer about parsed expectations.
 861         https://bugs.webkit.org/show_bug.cgi?id=65444
 862
 863         This is a bit largish in size, but the essentials are:
 864         * TestExpectationSerializer, given a parsed TestExpectationLine, can now spit out a pretty string.
 865         * We now store original content of the expectation line on TestExpectationLine.
 866         * Lots of tests.
 867
 868         Reviewed by Adam Barth.
 869
 870         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Fixed an issue where we didn't
 871             populate macros correctly, also fixed an issue where we incorrectly returned an empty list
 872             for all configurations.
 873         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for those.
 874         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed vestiges of code long gone,
 875             refactored TestExpectationsSerializer to recognize and correctly serialize parsed TestExpectationLine instances,
 876             changed to store and use TestExpectationLine.original_string.
 877         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
 878
 879 2011-08-01  Adam Barth  <abarth@webkit.org>
 880
 881         Remove unused functionality from gardeningserver
 882         https://bugs.webkit.org/show_bug.cgi?id=65479
 883
 884         Reviewed by Dimitri Glazkov.
 885
 886         We now handle these operations directly from the front-end.  That means
 887         they work even without the gardening server running!
 888
 889         Also, add some missing files to the list of static files.
 890
 891         * Scripts/webkitpy/tool/servers/gardeningserver.py:
 892         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
 893
 894 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
 895
 896         Introduce SpecifierSorter, a thing that knows how specifiers should be ordered.
 897         https://bugs.webkit.org/show_bug.cgi?id=65413
 898
 899         Reviewed by Adam Barth.
 900
 901         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added SpecifierSorter and converted
 902             existing code to use it.
 903         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests and cleaned up a bit.
 904
 905 2011-08-01  Adam Barth  <abarth@webkit.org>
 906
 907         Refactor bugzilla.js for use by garden-o-matic
 908         https://bugs.webkit.org/show_bug.cgi?id=65450
 909
 910         Reviewed by Dimitri Glazkov.
 911
 912         This patch refactors bugzilla.js to use the AsynchronousCache and
 913         updates the style to use a module instead of an object.  This patch
 914         then fixes all the existing code that uses this class to use the new
 915         API style.
 916
 917         This main benefit of this patch is we remove the tricky manual caching
 918         and this code is now available to use in garden-o-matic (since the
 919         dependency on Utilities.js is now gone).
 920
 921         I ran all the unit tests and poked around in TestFailures a bit to see
 922         that everything seemed to be working properly.
 923
 924         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
 925         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
 926         (FailingTestsBugForm):
 927         (FailingTestsBugForm.prototype._createBugTitle):
 928         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
 929         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
 930         (FlakyTestBugForm):
 931         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
 932         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:
 933         (NewBugForm):
 934         (NewBugForm.prototype.domElement):
 935         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
 936         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:
 937         (TestRelatedBugForm):
 938         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
 939         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
 940         (ViewController.prototype._displayBuilder.start):
 941         (ViewController.prototype._displayBuilder):
 942         (ViewController.prototype._domForAuxiliaryUIElements):
 943         (ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
 944         (ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
 945         (ViewController.prototype._domForPossiblyFlakyTests):
 946         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
 947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
 948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
 949
 950 2011-08-01  Adam Barth  <abarth@webkit.org>
 951
 952         garden-o-matic shouldn't require local server to determine if compile failed
 953         https://bugs.webkit.org/show_bug.cgi?id=65446
 954
 955         Reviewed by Dimitri Glazkov.
 956
 957         This patch adds some basic bindings for the buildbot JSON API.  I
 958         wanted to use Buildbot.js an Builder.js from the original TestFailures,
 959         but they make a number of WebKit-specific assumptions.  We'll
 960         eventually need to reconcile these pieces of code.
 961
 962         I should really add tests for this code, but that will require me to
 963         build a better mock network.  I'll be happy to do that in a follow-up
 964         patch.
 965
 966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
 967             - It's very unclear to me whether didFail is correct.  Supposedly
 968               the first entry here is the exit code of the step, which is 0 on
 969               success.  I suspect we'll need to improve this function over time.
 970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
 971         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
 972         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
 973
 974 2011-08-01  Adam Barth  <abarth@webkit.org>
 975
 976         garden-o-matic should show all failures, even ones that it can't find a regression range for
 977         https://bugs.webkit.org/show_bug.cgi?id=65447
 978
 979         Reviewed by Dimitri Glazkov.
 980
 981         Previously, we just wouldn't display test failures that we couldn't
 982         identify a regression range for (or whose regression range had fallen
 983         off the page).  This patch just displays them at the end of the list,
 984         which is slightly (but not much) better.
 985
 986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
 987
 988 2011-08-01  Jeff Miller  <jeffm@apple.com>
 989
 990         Windows build fix after r92096.
 991
 992         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
 993         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.
 994
 995 2011-07-31  Anders Carlsson  <andersca@apple.com>
 996
 997         DownloadDecideDestinationCrash WebKit2 API tests crashes
 998         https://bugs.webkit.org/show_bug.cgi?id=65442
 999
1000         Reviewed by Sam Weinig.
1001
1002         Copy the 18-characters.html file to the destination directory so we won't
1003         crash trying to make an URL for it.
1004
1005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1006
1007 2011-07-31  Anders Carlsson  <andersca@apple.com>
1008
1009         Fix SpacebarScrolling WebKit2 API test
1010         https://bugs.webkit.org/show_bug.cgi?id=65431
1011
1012         Reviewed by Sam Weinig.
1013
1014         Add a way to do platform-specific bundle initialization, and use it to disable smooth
1015         scrolling. Also make it possible for a test to load the injected bundle without actually running
1016         a test from it.
1017
1018         * TestWebKitAPI/InjectedBundleController.cpp:
1019         (TestWebKitAPI::InjectedBundleController::initialize):
1020         * TestWebKitAPI/InjectedBundleController.h:
1021         * TestWebKitAPI/PlatformUtilities.cpp:
1022         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1023         * TestWebKitAPI/PlatformUtilities.h:
1024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1025         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1026         (TestWebKitAPI::TEST):
1027         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.
1028         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1029         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
1030         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1031         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1032
1033 2011-07-31  Dimitri Glazkov  <dglazkov@chromium.org>
1034
1035         Use set comparison to find duplicate or overlapping specifiers in test expectations.
1036         https://bugs.webkit.org/show_bug.cgi?id=65430
1037
1038         Reviewed by Adam Barth.
1039
1040         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length
1041             of a set is wrong.
1042         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch
1043             regressions.
1044
1045 2011-07-31  Xan Lopez  <xlopez@igalia.com>
1046
1047         Group dependencies CFLAGS together.
1048
1049         * GNUmakefile.am: ditto.
1050
1051 2011-07-31  Daniel Bates  <dbates@webkit.org>
1052
1053         Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
1054         (https://bugs.webkit.org/show_bug.cgi?id=65419).
1055
1056         * GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
1057
1058 2011-07-30  Patrick Gansterer  <paroga@webkit.org>
1059
1060         Fix ports_unittest.py on native windows
1061         https://bugs.webkit.org/show_bug.cgi?id=64959
1062
1063         Reviewed by Adam Barth.
1064
1065         Replace WebKitPort.script_path with WebKitPort.script_shell_command.
1066         The latter includes the interpreter executable required on native windows.
1067
1068         * Scripts/webkitpy/common/config/ports_unittest.py:
1069
1070 2011-07-30  Adam Barth  <abarth@webkit.org>
1071
1072         Properly escape regular expressions.  (Maybe these shouldn't be regular
1073         expressions?)
1074
1075         * Scripts/webkitpy/tool/commands/rebaseline.py:
1076
1077 2011-07-30  Adam Barth  <abarth@webkit.org>
1078
1079         Add support for Win7 to garden-o-matic.
1080
1081         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
1082         * Scripts/webkitpy/tool/commands/rebaseline.py:
1083
1084 2011-07-30  Adam Barth  <abarth@webkit.org>
1085
1086         garden-o-matic regression ranges expand after fast bots start passing
1087         https://bugs.webkit.org/show_bug.cgi?id=65406
1088
1089         Reviewed by Dimitri Glazkov.
1090
1091         Once the gardener has fixed a problem, the fast bots pick up the fix,
1092         which means we end up using the slow bots to compute the regression
1093         range.  Unfortunately, the slow bots give us large regression ranges,
1094         leading to this strange effect where the regression range quality
1095         degrades as fixes roll in.
1096
1097         This patch causes us to remember the previous regression ranges we've
1098         seen and to use that information in the future, as long as it's
1099         consistent with the new information we receive.
1100
1101         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1102
1103 2011-07-30  Adam Barth  <abarth@webkit.org>
1104
1105         garden-o-matic should have a Refresh button to update its display
1106         https://bugs.webkit.org/show_bug.cgi?id=65403
1107
1108         Reviewed by Dimitri Glazkov.
1109
1110         The refresh button should be faster and less disruptive than the browser's reload button.
1111
1112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1113         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1114
1115 2011-07-30  Adam Barth  <abarth@webkit.org>
1116
1117         garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
1118         https://bugs.webkit.org/show_bug.cgi?id=65231
1119
1120         Reviewed by Dimitri Glazkov.
1121
1122         The human readable name is easier to understand, especially when the patch is landed by the commit-queue.
1123
1124         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
1125
1126 2011-07-30  Adam Barth  <abarth@webkit.org>
1127
1128         garden-o-matic should strikeout revisions that have been rolled out
1129         https://bugs.webkit.org/show_bug.cgi?id=65227
1130
1131         Reviewed by Dimitri Glazkov.
1132
1133         This helps gardeners keep track of which problems have been solved.
1134
1135         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
1136         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
1137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1138         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1139
1140 2011-07-30  Adam Barth  <abarth@webkit.org>
1141
1142         Add missing files to the server.
1143
1144         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1145
1146 2011-07-29  Adam Barth  <abarth@webkit.org>
1147
1148         Actually import the logging module!
1149
1150         * Scripts/webkitpy/common/checkout/scm/git.py:
1151
1152 2011-07-29  Adam Barth  <abarth@webkit.org>
1153
1154         More debug logging.  Maybe we're running the git version of this
1155         function somehow?  (That would explain why it doesn't work!)
1156
1157         * Scripts/webkitpy/common/checkout/scm/git.py:
1158
1159 2011-07-29  Adam Barth  <abarth@webkit.org>
1160
1161         Add some temporary debug logging messages to try to understand why the
1162         windows bots can't figure out their current SVN revision.
1163
1164         * Scripts/webkitpy/common/checkout/scm/svn.py:
1165
1166 2011-07-29  Adam Barth  <abarth@webkit.org>
1167
1168         Chromium try servers should use downstream test_expectations
1169         https://bugs.webkit.org/show_bug.cgi?id=65390
1170
1171         Reviewed by Dirk Pranke.
1172
1173         Otherwise the try servers will report bogus failures.
1174
1175         * Scripts/webkitpy/layout_tests/port/chromium.py:
1176
1177 2011-07-29  Dimitri Glazkov  <dglazkov@chromium.org>
1178
1179         Fix an error in macro collapsing, refactor code to be pretty.
1180         https://bugs.webkit.org/show_bug.cgi?id=65387
1181
1182         My set math was wrong.
1183
1184         Reviewed by Adam Barth.
1185
1186         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Moved collapsing into a classmethod, fixed the math to be correct.
1187         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
1188
1189 2011-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
1190
1191         Style bot complains about EFL-specific forward declaration naming.
1192         https://bugs.webkit.org/show_bug.cgi?id=64680
1193
1194         Exclude EFL-specific forward declarations from indentifiers with underscores checks.
1195
1196         Reviewed by Adam Barth.
1197
1198         * Scripts/webkitpy/style/checkers/cpp.py:
1199         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1200
1201 2011-07-27  Adam Roben  <aroben@apple.com>
1202
1203         Use wacky !svn/bc URLs consistently in Leaks Viewer
1204
1205         This ensures that any resources loaded via relative URLs will still get pulled from the same
1206         revision of Subversion.
1207
1208         Fixes <http://webkit.org/b/65267> Focus/exclude button glyphs don't load on Leaks Viewer
1209
1210         Reviewed by David Kilzer.
1211
1212         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Use the
1213         !svn/bc-style URL for inspector.css, too, just like we do for all other resources we pull
1214         from Subversion.
1215
1216 2011-07-27  Raphael Kubo da Costa  <kubo@profusion.mobi>
1217
1218         [EFL] Drop WorkQueueItemEfl.h in favour of the general WorkQueueItem.h
1219         https://bugs.webkit.org/show_bug.cgi?id=65269
1220
1221         Reviewed by Kent Tamura.
1222
1223         WorkQueueItemEfl.h was being included by efl's
1224         LayoutTestControllerEfl.cpp, however the top-level
1225         LayoutTestController still included WorkQueueItem.h, causing a lot of
1226         type mismatches when running the WorkQueueItem code.
1227
1228         We can stick to the original WorkQueueItem header by making a few
1229         changes to EFL's LayoutTestController.
1230
1231         This should make tests such as
1232         fast/loader/non-deferred-substitute-load.html stop crashing.
1233
1234         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1235         (LayoutTestController::queueLoad):
1236         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1237         (LoadItem::invoke):
1238         (LoadHTMLStringItem::invoke):
1239         (ScriptItem::invoke):
1240         * DumpRenderTree/efl/WorkQueueItemEfl.h: Removed.
1241
1242 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
1243
1244         Re-add unit tests I accidentally zapped in r91878.
1245
1246         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Re-added unit tests.
1247
1248 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
1249
1250         Replace SpecificityCalculator with TestConfiguration-driven logic.
1251         https://bugs.webkit.org/show_bug.cgi?id=65206
1252
1253         Use our newly-acquired ability to expand modifiers into a set of
1254         matching TestConfiguration instances to calculate specificity and
1255         determine whether expectation applies to a given test configuration.
1256
1257         Also, store bug modifier on TestExpectationsLine.
1258
1259         Reviewed by Adam Barth.
1260
1261         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
1262             test configuration matching, removed a bunch of code.
1263         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
1264
1265
1266 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
1267
1268         Allow ports to specify their own test expectation specifier macros.
1269         https://bugs.webkit.org/show_bug.cgi?id=65291
1270
1271         Reviewed by Adam Barth.
1272
1273         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to use port macros.
1274         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
1275         * Scripts/webkitpy/layout_tests/port/base.py: Added configuration_specifier_macros to retrieve the macros.
1276         * Scripts/webkitpy/layout_tests/port/chromium.py: Overrode it to return Chromium's macros.
1277         * Scripts/webkitpy/layout_tests/port/test.py: Added test macros.
1278
1279 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
1280
1281         Allow TestConfigurationConverter report conversion errors.
1282         https://bugs.webkit.org/show_bug.cgi?id=65287
1283
1284         Also, fix a few miscellaneous testing issues.
1285
1286         Reviewed by Adam Barth.
1287
1288         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
1289         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
1290         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
1291             was created. 'default' is not a valid build type.
1292         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
1293
1294 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
1295
1296         Teach all ports about their test configurations.
1297         https://bugs.webkit.org/show_bug.cgi?id=65278
1298
1299         Each Port object should return a valid set of all TestConfiguration instances,
1300         available for this port.
1301
1302         Reviewed by Philippe Normand.
1303
1304         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Removed TestConfiguration.all_test_configurations,
1305             since it is different for each port.
1306         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Removed related test.
1307         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to take a list of
1308             all test configurations as a param.
1309         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted arguments accordingly.
1310         * Scripts/webkitpy/layout_tests/port/base.py: Forced all ports to override generation of all test configurations.
1311         * Scripts/webkitpy/layout_tests/port/chromium.py: Implemented _generate_all_test_configurations for the port.
1312         * Scripts/webkitpy/layout_tests/port/gtk.py: Ditto.
1313         * Scripts/webkitpy/layout_tests/port/mac.py: Ditto.
1314         * Scripts/webkitpy/layout_tests/port/qt.py: Ditto.
1315         * Scripts/webkitpy/layout_tests/port/win.py:
1316         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added an extra test to ensure we're generating a good set.
1317         * Scripts/webkitpy/layout_tests/port/test.py: Implemented a fixed-in-time all_test_configurations for testing.
1318         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added a mock all_test_configurations implementation.
1319         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added a unit test for the port.
1320
1321 2011-07-27  Benjamin Poulain  <benjamin@webkit.org>
1322
1323         [WK2][Qt] Move from QGraphicsView to Qt Scene Graph
1324         https://bugs.webkit.org/show_bug.cgi?id=62969
1325
1326         Reviewed by Andreas Kling.
1327
1328         Co-authored with Simon Hausmann  <simon.hausmann@nokia.com>
1329
1330         With the scene graph, the interface to have a window on screen is
1331         QSGCanvas. QGraphicsView is not used, and openGL is an enforced
1332         dependency.
1333
1334         Both the BrowserView and the WebKitTest runner are changed from
1335         QGraphicsView to QSGCanvas.
1336
1337         * MiniBrowser/qt/BrowserView.cpp:
1338         (BrowserView::BrowserView):
1339         (BrowserView::resizeEvent):
1340         (BrowserView::view):
1341         * MiniBrowser/qt/BrowserView.h:
1342         * MiniBrowser/qt/BrowserWindow.cpp:
1343         (BrowserWindow::BrowserWindow):
1344         (BrowserWindow::urlChanged):
1345         (BrowserWindow::~BrowserWindow):
1346         * MiniBrowser/qt/BrowserWindow.h:
1347         * MiniBrowser/qt/MiniBrowser.pro:
1348         * MiniBrowser/qt/main.cpp:
1349         (main):
1350         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1351         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1352         (WTR::WebView::WebView):
1353         (WTR::PlatformWebView::PlatformWebView):
1354         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1355
1356 2011-07-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1357
1358         Unreviewed, rolling out r91792.
1359         http://trac.webkit.org/changeset/91792
1360         https://bugs.webkit.org/show_bug.cgi?id=65242
1361
1362         It broke NRWT on Qt and GTK (Requested by Ossy_night on
1363         #webkit).
1364
1365         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1366         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1367         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1368         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1369         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1370         * Scripts/webkitpy/layout_tests/port/test.py:
1371
1372 2011-07-26  Adam Barth  <abarth@webkit.org>
1373
1374         Switch to an older idiom that works on Python 2.5.
1375
1376         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1377
1378 2011-07-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1379
1380         Add an exception to coding style check for EFL port.
1381         https://bugs.webkit.org/show_bug.cgi?id=65162
1382
1383         Add an exception of whitespace/declaration for EFL port. Because,
1384         '*' operator is next to variable in EFL coding style.
1385
1386         Reviewed by Kent Tamura.
1387
1388         * Scripts/webkitpy/style/checker.py:
1389
1390 2011-07-26  Keith Kyzivat  <keith.kyzivat@nokia.com>
1391
1392         [Qt] Add option to turn on disk caching in QtTestBrowser
1393         https://bugs.webkit.org/show_bug.cgi?id=65007
1394
1395         Reviewed by Noam Rosenthal.
1396
1397         Add menu item and command line option to turn on disk caching in
1398         QtTestBrowser. Simple QNetworkDiskCache added to the page's
1399         QNetworkAccssManager.
1400
1401         * QtTestBrowser/launcherwindow.cpp:
1402         (LauncherWindow::initializeView):
1403         (LauncherWindow::createChrome):
1404         (LauncherWindow::setDiskCache):
1405         * QtTestBrowser/launcherwindow.h:
1406         (WindowOptions::WindowOptions):
1407         * QtTestBrowser/main.cpp:
1408         (LauncherApplication::handleUserOptions):
1409
1410 2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
1411
1412         Add support for download='filename' attribute in anchors.
1413         https://bugs.webkit.org/show_bug.cgi?id=64580
1414
1415         Reviewed by Adam Barth.
1416
1417         * DumpRenderTree/chromium/WebViewHost.cpp:
1418         (WebViewHost::loadURLExternally):
1419         * DumpRenderTree/chromium/WebViewHost.h:
1420
1421 2011-07-26  Dan Bernstein  <mitz@apple.com>
1422
1423         Rubber-stamped by Anders Carlsson.
1424
1425         Update DumpRenderTree and API tests for the pictograph font family preference.
1426
1427         * DumpRenderTree/mac/DumpRenderTree.mm:
1428         (resetDefaultsToConsistentValues):
1429         * DumpRenderTree/win/DumpRenderTree.cpp:
1430         (resetDefaultsToConsistentValues):
1431         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1432         (TestWebKitAPI::TEST):
1433         * WebKitTestRunner/TestController.cpp:
1434         (WTR::TestController::resetStateToConsistentValues):
1435
1436 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
1437
1438         Replace SpecificityCalculator with TestConfiguration-driven logic.
1439         https://bugs.webkit.org/show_bug.cgi?id=65206
1440
1441         Use our newly-acquired ability to expand modifiers into a set of
1442         matching TestConfiguration instances to calculate specificity and
1443         determine whether expectation applies to a given test configuration.
1444
1445         Also, store bug modifier on TestExpectationsLine.
1446
1447         Reviewed by Adam Barth.
1448
1449         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
1450         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
1451         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
1452             test configuration matching, removed a bunch of code.
1453         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
1454         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
1455             was created. 'default' is not a valid build type.
1456         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
1457
1458 2011-07-26  Adam Barth  <abarth@webkit.org>
1459
1460         Increase the information density in garden-o-matic
1461         https://bugs.webkit.org/show_bug.cgi?id=65141
1462
1463         Reviewed by Dimitri Glazkov.
1464
1465         This patch changes lets us show each revision on a single line,
1466         allowing use to show an entire day's worth of commits at once.
1467
1468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
1469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1471
1472 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
1473
1474         TestConfigurationConverter should not barf on invalid specifiers.
1475         https://bugs.webkit.org/show_bug.cgi?id=65194
1476
1477         Reviewed by Adam Barth.
1478
1479         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Refactored TestConfigurationConverter.to_config_set a bit,
1480             made it return empty set whenever an invalid specifier is encountered.
1481         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added corresponding tests.
1482
1483 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
1484
1485         Introduce a way to convert between specifier lists and TestConfiguration sets.
1486         https://bugs.webkit.org/show_bug.cgi?id=65094
1487
1488         Add TestConfigurationConverter, a facility to convert:
1489         1) a set of specifiers into a set of TestConfiguration instances;
1490         2) a set of TestConfiguration instances into a list of sets of specifiers.
1491
1492         Reviewed by Adam Barth.
1493
1494         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfigurationConverter.
1495         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for it.
1496
1497 2011-07-26  Alexandru Chiculita  <achicu@adobe.com>
1498
1499         CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
1500         https://bugs.webkit.org/show_bug.cgi?id=65171
1501
1502         Added "features" parameter in config.json for "builder" objects. The parameter is optional and must be an array. All the items
1503         of the array will be passed to the build-webkit script. The items will automatically be prefixed with "--".
1504
1505         Reviewed by Adam Roben.
1506
1507         * BuildSlaveSupport/build.webkit.org-config/config.json:
1508         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1509
1510 2011-07-26  Chris Rogers  <crogers@google.com>
1511
1512         Avoid outputting #EOF twice for web audio tests in chromium DRT
1513         https://bugs.webkit.org/show_bug.cgi?id=65201
1514
1515         Reviewed by Dirk Pranke.
1516
1517         * DumpRenderTree/chromium/TestShell.cpp:
1518         (TestShell::dump):
1519
1520 2011-07-26  Adam Barth  <abarth@webkit.org>
1521
1522         Windows bots on build.chromium.org can't figure out the head_svn_revision
1523         https://bugs.webkit.org/show_bug.cgi?id=65156
1524
1525         Reviewed by Tony Chang.
1526
1527         This patch is a bit of a guess as to the issue based on the
1528         investigation in https://bugs.webkit.org/show_bug.cgi?id=65148.  I'm
1529         not sure whether it will fix the issue, but it seems worth a try.
1530
1531         * Scripts/webkitpy/common/checkout/scm/svn.py:
1532
1533 2011-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1534
1535         Unreviewed. Fix WebKitGtk build with GTK+ 3.x after r91707.
1536
1537         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
1538         (getPreferredSizeMethod):
1539
1540 2011-07-26  MORITA Hajime  <morrita@google.com>
1541
1542         [Chromium][DRT] MockSpellCheck.cpp should be clang clean
1543         https://bugs.webkit.org/show_bug.cgi?id=65166
1544
1545         Reviewed by Kent Tamura.
1546
1547         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1548         (MockSpellCheck::spellCheckWord): -Wsign-compare warning.
1549
1550 2011-07-25  Patrick Gansterer  <paroga@webkit.org>
1551
1552         Ignore line endings in ChangeLogTests
1553         https://bugs.webkit.org/show_bug.cgi?id=64956
1554
1555         Reviewed by Adam Barth.
1556
1557         Split the lines of the ChangeLog text before comparing them.
1558         This fixes 3 tests on windows, since only the content importent.
1559
1560         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1561         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1562
1563 2011-07-25  Adam Barth  <abarth@webkit.org>
1564
1565         Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision
1566         https://bugs.webkit.org/show_bug.cgi?id=65148
1567
1568         Reviewed by Tony Chang.
1569
1570         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1571
1572 2011-07-25  Ojan Vafai  <ojan@chromium.org>
1573
1574         Tweak whitespace wrapping to improve readability.
1575         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1576
1577 2011-07-25  Ojan Vafai  <ojan@chromium.org>
1578
1579         Minor tweak to wrap label elements as atomic units.
1580
1581         * TestResultServer/static-dashboards/dashboard_base.js:
1582         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1583
1584 2011-07-25  Ojan Vafai  <ojan@chromium.org>
1585
1586         always show flakiness details on the builder page
1587         https://bugs.webkit.org/show_bug.cgi?id=65139
1588
1589         Reviewed by Tony Chang.
1590
1591         In order to simplify the UI, we hide the flakiness details by default,
1592         but there's no actual use-case for this page without the flakiness details.
1593         So get rid of that option and always show the flakiness details.
1594
1595         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1596
1597 2011-07-25  Ojan Vafai  <ojan@chromium.org>
1598
1599         simplify the UI of the header above the test list table
1600         https://bugs.webkit.org/show_bug.cgi?id=65136
1601
1602         Reviewed by Adam Barth.
1603
1604         Use checkboxes instead of links since this is really about which tests to include.
1605         Ends up using less text and put the checkboxes to the right of the header instead of below it.
1606
1607         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1608         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1609
1610 2011-07-25  Chris Rogers  <crogers@google.com>
1611
1612         Update new-run-webkit-tests to accomodate binary audio data
1613         https://bugs.webkit.org/show_bug.cgi?id=65135
1614
1615         Reviewed by Dirk Pranke.
1616
1617         * Scripts/webkitpy/layout_tests/port/chromium.py:
1618
1619 2011-07-25  Chris Rogers  <crogers@google.com>
1620
1621         Update Chromium DRT to output binary (instead of base64-encoded) data for web audio testing
1622         https://bugs.webkit.org/show_bug.cgi?id=65039
1623
1624         Reviewed by Tony Chang.
1625
1626         * DumpRenderTree/chromium/LayoutTestController.cpp:
1627         (LayoutTestController::LayoutTestController):
1628         (LayoutTestController::setAudioData):
1629         * DumpRenderTree/chromium/LayoutTestController.h:
1630         (LayoutTestController::audioData):
1631         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1632         (DRTPrinter::handleAudioHeader):
1633         (TestShellPrinter::handleAudioHeader):
1634         * DumpRenderTree/chromium/TestShell.cpp:
1635         (TestShell::dump):
1636
1637 2011-06-07  Martin Robinson  <mrobinson@igalia.com>
1638
1639         Reviewed by Gustavo Noronha Silva.
1640
1641         [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
1642         https://bugs.webkit.org/show_bug.cgi?id=62252
1643
1644         Add a new subclass of WebKitWebView that overrides the size request to
1645         return 1 pixel by 1 pixel. This ensure that it operates properly when
1646         not packed into a GtkScrolledWindow. Also construct the WebKitWebView
1647         with self-scrolling set to true.
1648
1649         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1650         (webInspectorInspectWebView): Use the new SelfScrollingWebKitWebview class here.
1651         (createWebView): Ditto.
1652         (main): Pack the widget into a GtkBox instead of a GtkScrolledWindow.
1653         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Added.
1654         (self_scrolling_webkit_web_view_class_init):
1655         (self_scrolling_webkit_web_view_init):
1656         (self_scrolling_webkit_web_view_new):
1657         (sizeRequestMethod):
1658         (getPreferredSizeMethod):
1659         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Added.
1660         * GNUmakefile.am: Added SelfScrollingWebKitWebView files to the source list.
1661
1662 2011-07-25  Ojan Vafai  <ojan@chromium.org>
1663
1664         by default hide tests that have passes for all recorded runs
1665         https://bugs.webkit.org/show_bug.cgi?id=65127
1666
1667         Reviewed by Adam Barth.
1668
1669         This is part of simplifying the default views of the dashboard to
1670         make it show less information for the common use cases.
1671
1672         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1673         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1674
1675 2011-07-25  Ojan Vafai  <ojan@chromium.org>
1676
1677         stop generating expectations.json now that it's unused
1678         https://bugs.webkit.org/show_bug.cgi?id=65130
1679
1680         Reviewed by Adam Barth.
1681
1682         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1683         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1684         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1685         * TestResultServer/handlers/menu.py:
1686         * TestResultServer/static-dashboards/dashboard_base.js:
1687         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1688
1689 2011-07-25  Ojan Vafai  <ojan@chromium.org>
1690
1691         don't show builders in the flakiness dashboard that have stopped running a given test suite
1692         https://bugs.webkit.org/show_bug.cgi?id=65126
1693
1694         Reviewed by Mihai Parparita.
1695
1696         * TestResultServer/static-dashboards/dashboard_base.js:
1697
1698 2011-07-25  Adam Barth  <abarth@webkit.org>
1699
1700         Overhaul garden-o-matic frontend to integrate revision history and failures
1701         https://bugs.webkit.org/show_bug.cgi?id=65089
1702
1703         Reviewed by Dimitri Glazkov.
1704
1705         This is a major overhaul of the garden-o-matic frontend.  The new UI
1706         integrates the revision history information with failures.  Failures
1707         appear in context adjacent to the revisions that caused them (which are
1708         highlighted).  Each buildbot receives a collumn to the left, which
1709         indicates which revisions that bot has tested and whether that bot
1710         showed the indicated failures.
1711
1712         Failures are selectable with checkboxes, and can then either be
1713         examined or rebaselined.
1714
1715         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
1716         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
1717         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1718         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
1719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
1721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
1722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
1724
1725 2011-07-25  Holger Hans Peter Freyther  <zecke@selfish.org>
1726
1727         [buildbot] Add Qt Linux MIPSEL Configuration
1728         https://bugs.webkit.org/show_bug.cgi?id=65116
1729
1730         Reviewed by Adam Roben.
1731
1732         Introduce a Qt Linux MIPS EL build slave. The configuration
1733         is a build only configuration.
1734
1735         * BuildSlaveSupport/build.webkit.org-config/config.json: Add MIPS buildbot.
1736
1737 2011-07-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1738
1739         [Qt][WK2] Add multi-point touch mocking to MiniBrowser
1740         https://bugs.webkit.org/show_bug.cgi?id=64374
1741
1742         Reviewed by Benjamin Poulain.
1743
1744         Each mouse button generate a touch point. The touch point stay
1745         virtually on screen if the mouse release happened while the Ctrl
1746         modifier was pressed.
1747
1748         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1749         (MiniBrowserApplication::notify):
1750         * MiniBrowser/qt/MiniBrowserApplication.h:
1751
1752 2011-07-25  Balazs Kelemen  <kbalazs@webkit.org>
1753
1754         [Qt][WK2] Use NRWT for Qt-WK2
1755         https://bugs.webkit.org/show_bug.cgi?id=65097
1756
1757         Reviewed by Andreas Kling.
1758
1759         * Scripts/run-webkit-tests:
1760         (useNewRunWebKitTests):
1761
1762 2011-07-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1763
1764         Unreviewed, rolling out r91635.
1765         http://trac.webkit.org/changeset/91635
1766         https://bugs.webkit.org/show_bug.cgi?id=65083
1767
1768         It broke the minimal build (Requested by Ossy___OFFLINE on
1769         #webkit).
1770
1771         * QtTestBrowser/launcherwindow.cpp:
1772         (LauncherWindow::initializeView):
1773         (LauncherWindow::createChrome):
1774         * QtTestBrowser/launcherwindow.h:
1775         (WindowOptions::WindowOptions):
1776         * QtTestBrowser/main.cpp:
1777         (LauncherApplication::handleUserOptions):
1778
1779 2011-07-24  Adam Barth  <abarth@webkit.org>
1780
1781         Rename garden-o-matic "alert" to "infobar" and increase the width to 100%.
1782
1783         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1785         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
1786         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1787         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1788         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
1789
1790 2011-07-23  Dimitri Glazkov  <dglazkov@chromium.org>
1791
1792         TestConfiguration should be hashable and comparable for equality.
1793         https://bugs.webkit.org/show_bug.cgi?id=65070
1794
1795         Reviewed by Adam Barth.
1796
1797         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added __hash__ and __eq__ methods.
1798         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
1799
1800 2011-07-23  Dimitri Glazkov  <dglazkov@chromium.org>
1801
1802         Extract TestConfiguration from base and write a few unit tests to capture current behavior.
1803         https://bugs.webkit.org/show_bug.cgi?id=65066
1804
1805         Reviewed by Adam Barth.
1806
1807         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added.
1808         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added.
1809         * Scripts/webkitpy/layout_tests/port/base.py: Moved code to test_configuration.py
1810
1811 2011-07-23  Alok Priyadarshi  <alokp@chromium.org>
1812
1813         Switching off acceleration for small canvas broke gpu tests
1814         https://bugs.webkit.org/show_bug.cgi?id=65053
1815
1816         Reviewed by Stephen White.
1817
1818         * DumpRenderTree/chromium/WebPreferences.cpp:
1819         (WebPreferences::reset):
1820         (WebPreferences::applyTo):
1821         * DumpRenderTree/chromium/WebPreferences.h:
1822
1823 2011-07-23  Keith Kyzivat  <keith.kyzivat@nokia.com>
1824
1825         [Qt] Add option to turn on disk caching in QtTestBrowser
1826         https://bugs.webkit.org/show_bug.cgi?id=65007
1827
1828         Reviewed by Noam Rosenthal.
1829
1830         Add menu item and command line option to turn on disk caching in
1831         QtTestBrowser. Simple QNetworkDiskCache added to the page's
1832         QNetworkAccssManager.
1833
1834         * QtTestBrowser/launcherwindow.cpp:
1835         (LauncherWindow::initializeView):
1836         (LauncherWindow::createChrome):
1837         (LauncherWindow::setDiskCache):
1838         * QtTestBrowser/launcherwindow.h:
1839         (WindowOptions::WindowOptions):
1840         * QtTestBrowser/main.cpp:
1841         (LauncherApplication::handleUserOptions):
1842
1843 2011-07-22  Ojan Vafai  <ojan@chromium.org>
1844
1845         Don't match 'DEBUG' when trying to filter BUG modifiers.
1846         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1847         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1848
1849 2011-07-22  Ojan Vafai  <ojan@chromium.org>
1850
1851         Fix issue loading gtests since there's no g_expectations.
1852         Also, make filing a bug file a webkit.org bug, not a crbug since
1853         the link is only shown for layout tests.
1854         * TestResultServer/static-dashboards/dashboard_base.js:
1855         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1856
1857 2011-07-22  Ojan Vafai  <ojan@chromium.org>
1858
1859         pull test expectations into the dashboard from wvn.webkit.org
1860         https://bugs.webkit.org/show_bug.cgi?id=65054
1861
1862         Reviewed by Adam Barth.
1863
1864         Now that svn.webkit.org supports cors headers, we can just grab the txt
1865         file from there instead of generating a JSON file that we upload
1866         to appengine. We'll stop generating the JSON file in a followup patch.
1867
1868         * TestResultServer/static-dashboards/dashboard_base.js:
1869         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1870         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1871
1872 2011-07-22  Adam Barth  <abarth@webkit.org>
1873
1874         Fix typo so the tool works on a case-sensitive file system.
1875
1876         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1877
1878 2011-07-22  Adam Barth  <abarth@webkit.org>
1879
1880         garden-o-matic should know what patches are landing
1881         https://bugs.webkit.org/show_bug.cgi?id=64978
1882
1883         Reviewed by Dimitri Glazkov.
1884
1885         This patch adds a display of the recently committed patches to
1886         garden-o-matic.  The UI needs iteration, but this patch establishes the
1887         plumbing.
1888
1889         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
1890             - Teach trac how to extract more information from the commit log.
1891         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
1892             - Add a data attribute for storing the revision.
1893         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1894             - Add a container for the recent commit history.
1895         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
1896             - CSS for displaying non-ugly commit history.
1897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1898             - Wire up trac to the UI container.
1899         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1900             - A basic, compact display for a list of commits.
1901
1902 2011-07-22  Ojan Vafai  <ojan@chromium.org>
1903
1904         Fix bug when switching from layout-tests to another test-type if
1905         ToT webkit.org is the selected group.
1906         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1907
1908 2011-07-22  Ojan Vafai  <ojan@chromium.org>
1909
1910         Add back in line accidentally deleted in http://trac.webkit.org/changeset/91612.
1911         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1912
1913 2011-07-22  Ojan Vafai  <ojan@chromium.org>
1914
1915         simplify the flakiness dashboard to only show modifiers/expectations for the current builder
1916         https://bugs.webkit.org/show_bug.cgi?id=65049
1917
1918         Reviewed by Tony Chang.
1919
1920         This communicates less information, but probably makes the dashboard more usable.
1921         Also make it show that bug lines that don't point to bug numbers still
1922         show up in the bugs column (e.g. BUG_TONY) and stop showing the extra/missing
1923         columns in any view. The data is still used, but only in the view that updates
1924         the test_expectations.txt file.
1925
1926         * TestResultServer/static-dashboards/dashboard_base.js:
1927         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1928         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1929
1930 2011-07-21  Ojan Vafai  <ojan@chromium.org>
1931
1932         hook in the rest of the bots to the dashboard now they run NRWT
1933         https://bugs.webkit.org/show_bug.cgi?id=64985
1934
1935         Reviewed by Adam Barth.
1936
1937         * TestResultServer/static-dashboards/builders.js:
1938
1939 2011-07-22  Alexey Proskuryakov  <ap@apple.com>
1940
1941         Adding Tim Horton to contributor list for Bugzilla auto-completion. He is CC'ed quite frequently.
1942
1943         Unreviewed.
1944
1945         * Scripts/webkitpy/common/config/committers.py:
1946
1947 2011-07-22  Michal Pakula vel Rutka  <m.pakula@samsung.com>
1948
1949         [EFL] ewk_frame_hit_test_new enchancement
1950         https://bugs.webkit.org/show_bug.cgi?id=64260
1951
1952         Apply changes done in ewk_frame_hit_test_new in EWebLauncher:
1953         Replacing Ewk_Hit_Test_Result_Context structure 'flags'
1954         in hit test output to by enum 'context'.
1955
1956         Reviewed by Antonio Gomes.
1957
1958         * EWebLauncher/main.c:
1959         (on_key_down):
1960
1961 2011-07-21  Adam Roben  <aroben@apple.com>
1962
1963         Fix typo in TestFailures
1964
1965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1966
1967 2011-07-21  Ojan Vafai  <ojan@chromium.org>
1968
1969         simplify gtest display now that we strip modifiers from the JSON
1970         https://bugs.webkit.org/show_bug.cgi?id=64990
1971
1972         Reviewed by Adam Barth.
1973
1974         Now that names are normalized, we can remove all the code that
1975         handles gtest name changes (e.g. for adding modifiers like DISABLED_).
1976         Instead, if you try to list a test with a modifier in it, we need
1977         to strip the modifier so we get the normalized value.
1978
1979         We also get rid of the concept of extra/missing expectations for gtests.
1980         In a patch soon, we'll stop showing extra/missing expectations from the UI
1981         entirely and only leave it for the special updating test_expectations.txt
1982         view of the dashboard, which doesn't apply to gtests.
1983
1984         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1985         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1986
1987 2011-07-21  Adam Barth  <abarth@webkit.org>
1988
1989         Refactor Trac.js for use in garden-o-matic
1990         https://bugs.webkit.org/show_bug.cgi?id=64998
1991
1992         Reviewed by Adam Roben.
1993
1994         This patch refactors Trac.js to match the architecture and style of
1995         garden-o-matic.  I've also factored AsynchronousCache out of Trac (and
1996         moved it to base) because it was redundant with some other code we
1997         already had.
1998
1999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
2000         (FailingTestsBugForm):
2001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2004         (ViewController.prototype._displayBuilder.start):
2005         (ViewController.prototype._displayBuilder):
2006         (ViewController.prototype._domForRegressionRange.trac.getCommitDataForRevisionRange):
2007         (ViewController.prototype._domForRegressionRange):
2008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2009         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2013
2014 2011-07-21  Ojan Vafai  <ojan@chromium.org>
2015
2016         Fix issue throwing a 500 to the bots. We were modifying
2017         the dictionary during an iteration over it's keys and would get
2018         RuntimeError: dictionary changed size during iteration
2019
2020         * TestResultServer/model/jsonresults.py:
2021
2022 2011-07-21  Adam Barth  <abarth@webkit.org>
2023
2024         ORWT fails to consume some NRWT arguments
2025         https://bugs.webkit.org/show_bug.cgi?id=64988
2026
2027         Reviewed by Adam Roben.
2028
2029         * Scripts/old-run-webkit-tests:
2030
2031 2011-07-21  Adam Barth  <abarth@webkit.org>
2032
2033         Merge TestFailures and garden-o-matic unit tests harness
2034         https://bugs.webkit.org/show_bug.cgi?id=64984
2035
2036         Reviewed by Adam Roben.
2037
2038         One unit testing framework is better than two.
2039
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Removed.
2041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2042
2043 2011-07-21  Adam Barth  <abarth@webkit.org>
2044
2045         Rubber-stamped by Adam Roben.
2046
2047         Move garden-o-matic files into the same directory as TestFailures to
2048         make it easier to integrate the codebases.
2049
2050         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js.
2051         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js.
2052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js.
2053         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js.
2054         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/config.js.
2055         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png.
2056         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png.
2057         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html.
2058         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css.
2059         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js.
2060         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif.
2061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js.
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js.
2063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html.
2064         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js.
2065         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js.
2066         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
2067         * Scripts/webkitpy/tool/commands/gardenomatic.py:
2068         * Scripts/webkitpy/tool/servers/data/gardeningserver: Removed.
2069         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Removed.
2070         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Removed.
2071         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Removed.
2072         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Removed.
2073         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Removed.
2074         * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Removed.
2075         * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Removed.
2076         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Removed.
2077         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Removed.
2078         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Removed.
2079         * Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Removed.
2080         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Removed.
2081         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Removed.
2082         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Removed.
2083         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Removed.
2084         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Removed.
2085         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2086
2087 2011-07-19  Ojan Vafai  <ojan@chromium.org>
2088
2089         fix links on the flakiness dashboard
2090         https://bugs.webkit.org/show_bug.cgi?id=64832
2091
2092         Reviewed by Tony Chang.
2093
2094         Make them actual anchor tags and linkify the test name instead of
2095         adding an extra link. Also simplify the update view since we now
2096         show the linkified test name.
2097
2098         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2099
2100 2011-07-21  Adam Barth  <abarth@webkit.org>
2101
2102         webkit.org builders should upload results to test-results AppEngine instance
2103         https://bugs.webkit.org/show_bug.cgi?id=64979
2104
2105         Reviewed by Adam Roben.
2106
2107         The master just needs to pass some flags to NRWT.  This patch also lets
2108         ORWT consume the flags (ignoring them) so we can pass the flags
2109         unconditionally.
2110
2111         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2112         * Scripts/old-run-webkit-tests:
2113
2114 2011-07-21  Ojan Vafai  <ojan@chromium.org>
2115
2116         normalize gtest names in the result json
2117         https://bugs.webkit.org/show_bug.cgi?id=64971
2118
2119         Reviewed by Eric Seidel.
2120
2121         This will make the resulting JSON smaller and make the
2122         flakiness dashboard much more sane (e.g. we won't need to
2123         show you the FLAKY_ version and the normal version).
2124
2125         * TestResultServer/model/jsonresults.py:
2126         * TestResultServer/model/jsonresults_unittest.py:
2127
2128 2011-07-21  Eric Seidel  <eric@webkit.org>
2129
2130         Unreviewed.  Reenable ORWT for the --leaks bot.
2131         Something is still wrong with the leaks summarizing
2132         but I'm about to head out on vacation for 2 weeks,
2133         so it's best to just revert back to ORWT until I'm back.
2134
2135         * Scripts/run-webkit-tests:
2136         (usingLeaks):
2137         (useNewRunWebKitTests):
2138
2139 2011-07-21  Ojan Vafai  <ojan@chromium.org>
2140
2141         cleanup jsonresults.py style in preparation for making some changes
2142         https://bugs.webkit.org/show_bug.cgi?id=64968
2143
2144         Reviewed by Adam Barth.
2145
2146         No code changes. Unittest still passes. Mostly just removing
2147         useless comments and 80 character wrapping.
2148
2149         * TestResultServer/model/jsonresults.py:
2150         * TestResultServer/model/jsonresults_unittest.py:
2151
2152 2011-07-21  Adam Barth  <abarth@webkit.org>
2153
2154         Add missing column header.
2155
2156         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
2157
2158 2011-07-21  Eric Seidel  <eric@webkit.org>
2159
2160         Unreviewed.  Just fixing (and unittesting) a previous typo.
2161
2162         Fix typo in print_leaks_summary regexp which was causing
2163         leaks summarizing to fail on the --leaks bot.
2164
2165         * Scripts/webkitpy/layout_tests/port/mac.py:
2166         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2167
2168 2011-07-21  Adam Barth  <abarth@webkit.org>
2169
2170         garden-o-matic should be able to rebaseline many tests at once
2171         https://bugs.webkit.org/show_bug.cgi?id=64963
2172
2173         Reviewed by Dimitri Glazkov.
2174
2175         This patch contains some UI for rebaselining tests in bulk.  I don't
2176         expect this UI to be the final UI, but the underlying infrastructure
2177         will be useful.
2178
2179         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
2180         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
2181         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
2182         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
2183         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
2184
2185 2011-07-21  Adam Barth  <abarth@webkit.org>
2186
2187         garden-o-matic has trouble when the same test fails in different ways on diffrent bots
2188         https://bugs.webkit.org/show_bug.cgi?id=64830
2189
2190         Unreviewed.  (Missing the patch is blocking me from fixing the tree.)
2191
2192         This patch is just some minor bug fixes.  One of the bugs results from
2193         the sadness of having two representations (a list and a space-separated
2194         string) for the set of failure types.
2195
2196         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
2197         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
2198         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
2199         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
2200
2201 2011-07-20  Ryosuke Niwa  <rniwa@webkit.org>
2202
2203         Buildbot marks a nrwt bot red when tests are missing results
2204         https://bugs.webkit.org/show_bug.cgi?id=64812
2205
2206         Reviewed by Adam Barth.
2207
2208         The bug was caused by multiple expressions matching on the single output.
2209         Fixed it by exiting the loop as soon as one expression matches.
2210
2211         Because the regular expression for 'failures' is most general,
2212         moved it to the end of the list to avoid it catching other cases.
2213
2214         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2215
2216 2011-07-20  Chang Shu  <cshu@webkit.org>
2217
2218         Adding myself to the reviewers list; No review needed.
2219
2220         * Scripts/webkitpy/common/config/committers.py:
2221
2222 2011-07-20  Eric Seidel  <eric@webkit.org>
2223
2224         new-run-webkit-tests --leaks does not restart DumpRenderTree often enough
2225         https://bugs.webkit.org/show_bug.cgi?id=64912
2226
2227         Reviewed by Adam Barth.
2228
2229         The bug was that set_default_option only works if the option's value
2230         is "None".  So I fixed --batch-size to default to None instead of 0
2231         (which kinda makes sense).
2232
2233         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2234         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2235
2236 2011-07-20  Eric Seidel  <eric@webkit.org>
2237
2238         Make kill-old-processes kill httpd on mac
2239         https://bugs.webkit.org/show_bug.cgi?id=64898
2240
2241         Reviewed by Adam Barth.
2242
2243         * BuildSlaveSupport/kill-old-processes:
2244          - The line endings seem to have flipped again,
2245            Thus making this diff gigantic.  The only line
2246            changed is the "httpd" line.  I suspect we'll need
2247            to set the line ending style from an svn checkout.
2248
2249 2011-07-20  Ojan Vafai  <ojan@chromium.org>
2250
2251         show a list of average test times in the treemap
2252         https://bugs.webkit.org/show_bug.cgi?id=64899
2253
2254         Reviewed by Adam Roben.
2255
2256         For now, you click a link and it replaces the treemap
2257         with a reverse sorted list of directories based on
2258         average test runtime within that directory.
2259
2260         To cut some of the noise, we don't show directories
2261         that only have one test in them or where the average
2262         runtime is less than 100ms.
2263
2264         * TestResultServer/static-dashboards/treemap.html:
2265
2266 2011-07-20  Eric Seidel  <eric@webkit.org>
2267
2268         Teach build.webkit.org how to identify leaks in NRWT output
2269         https://bugs.webkit.org/show_bug.cgi?id=64891
2270
2271         Reviewed by Adam Barth.
2272
2273         This was the last remaining piece blocking turning on
2274         NRWT for the leaks bot, so I did that in this change too.
2275         If for some reason we see trouble on the bots, I'll
2276         revert that part of this change.
2277
2278         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2279         * Scripts/run-webkit-tests:
2280
2281 2011-07-20  Ojan Vafai  <ojan@chromium.org>
2282
2283         make the treemap display more human friendly
2284         https://bugs.webkit.org/show_bug.cgi?id=64896
2285
2286         Reviewed by Tony Chang.
2287
2288         * TestResultServer/static-dashboards/treemap.html:
2289
2290 2011-07-20  Eric Seidel  <eric@webkit.org>
2291
2292         Move HttpLock to using a FileSystem object
2293         https://bugs.webkit.org/show_bug.cgi?id=64885
2294
2295         Reviewed by Adam Barth.
2296
2297         I made a typo in my previous change, taking the value
2298         of read_text_file(pid_file) and setting it to lock_pid_file
2299         instead of current_pid.  Fixed now. :)
2300
2301         In order to test my new change I had to overhaul the unittests
2302         for this class to create a separate set of tests which work off
2303         of Mock objects instead of the real filesystem.
2304
2305         Since Executive doesn't yet wrap os.getpid() I added a FIXME
2306         in several places where we're currently calling os.getpid().  I
2307         felt adding Executive.getpid was outside of the scope of this change
2308         but once it exists some of this code will be much simpler to mock.
2309
2310         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2311         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
2312         * Scripts/webkitpy/tool/mocktool.py:
2313
2314 2011-07-20  Adam Roben  <aroben@apple.com>
2315
2316         Fix typo in TestFailures's Bugzilla constants
2317
2318         This was preventing the "Version" field from being pre-filled when filing new bugs.
2319
2320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:
2321
2322 2011-07-20  Eric Seidel  <eric@webkit.org>
2323
2324         Move HttpLock to using a FileSystem object
2325         https://bugs.webkit.org/show_bug.cgi?id=64885
2326
2327         Reviewed by Adam Barth.
2328
2329         There is no functional change here.  Just moving off
2330         of direct os.foo calls to their filesystem equivalent.
2331
2332         This makes it possible to now unittest HttpLock using a
2333         MockFileSystem instead of needing to talk to the filesystem directly.
2334
2335         This also will have changed any port test cases which were using a
2336         mock file system to now have an HttpLock based on a mock filesystem
2337         instead.  I saw no change in the unittests so it's possible
2338         we're not testing that configuration (or more likely that it "just works").
2339
2340         * Scripts/webkitpy/layout_tests/port/base.py:
2341         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2342         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
2343
2344 2011-07-20  Adam Barth  <abarth@webkit.org>
2345
2346         NRWT results uses too much space per run
2347         https://bugs.webkit.org/show_bug.cgi?id=64845
2348
2349         Reviewed by Ojan Vafai.
2350
2351         Removing these files saves about 750K per build.
2352
2353         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2354
2355 2011-07-20  Zan Dobersek  <zandobersek@gmail.com>
2356
2357         [Gtk] [NRWT] Xvfb produces a lot of stderr output
2358         https://bugs.webkit.org/show_bug.cgi?id=64669
2359
2360         Reviewed by Philippe Normand.
2361
2362         Redirect the stderr output of the driver's Xvfb process
2363         to /dev/null to suppress unneeded output.
2364
2365         * Scripts/webkitpy/layout_tests/port/gtk.py:
2366
2367 2011-07-19  Eric Seidel  <eric@webkit.org>
2368
2369         parse-malloc-history always exits 1, causing NRWT to fail
2370         https://bugs.webkit.org/show_bug.cgi?id=64835
2371
2372         Reviewed by Adam Barth.
2373
2374         ORWT just never checked the return code. :)
2375
2376         * Scripts/parse-malloc-history:
2377         (main):
2378         * Scripts/webkitpy/layout_tests/port/mac.py:
2379
2380 2011-07-19  Kevin Ollivier  <kevino@theolliviers.com>
2381
2382         [wx] Unreviewed build fix, don't add the debug prefix as 2.9 no longer uses one.
2383
2384         * waf/build/wxpresets.py:
2385
2386 2011-07-19  Eric Seidel  <eric@webkit.org>
2387
2388         new-run-webkit-tests should only enable MallocStackLogging for DRT
2389         https://bugs.webkit.org/show_bug.cgi?id=64792
2390
2391         Reviewed by Adam Barth.
2392
2393         The previous code would enable it for all servers launched
2394         by the port, which included Apache, the python websocket server
2395         as well as ImageDiff.  Now only DumpRenderTree will have
2396         MallocStackLogging enabled or the GuardMalloc library injected.
2397
2398         I also cleaned up the websocket_server code to use filesystem
2399         while I was in it.
2400
2401         I also made DRT restart every 1000 tests when running with
2402         --leaks enabled.  I believe this made the --leaks run slightly
2403         faster, but it still takes over an hour on my machine. :(
2404
2405         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2406         * Scripts/webkitpy/layout_tests/port/base.py:
2407         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2408         * Scripts/webkitpy/layout_tests/port/gtk.py:
2409         * Scripts/webkitpy/layout_tests/port/mac.py:
2410         * Scripts/webkitpy/layout_tests/port/qt.py:
2411         * Scripts/webkitpy/layout_tests/port/server_process.py:
2412         * Scripts/webkitpy/layout_tests/port/webkit.py:
2413         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2414         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2415
2416 2011-07-19  Ojan Vafai  <ojan@chromium.org>
2417
2418         remove the concept of platform fallbacks
2419         https://bugs.webkit.org/show_bug.cgi?id=64829
2420
2421         Reviewed by Adam Barth.
2422
2423         In the process, wrote tests for this code and fixed a pretty major
2424         bug (now covered by the test).
2425
2426         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2427         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2428
2429 2011-07-19  Ojan Vafai  <ojan@chromium.org>
2430
2431         cleanup some of the PLATFORM logic in the flakiness dashboard
2432         https://bugs.webkit.org/show_bug.cgi?id=64821
2433
2434         Reviewed by Adam Barth.
2435
2436         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2437         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2438
2439 2011-07-19  Ojan Vafai  <ojan@chromium.org>
2440
2441         cleanup some of the PLATFORM logic in the flakiness dashboard
2442         https://bugs.webkit.org/show_bug.cgi?id=64821
2443
2444         Reviewed by Adam Barth.
2445
2446         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2447         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2448
2449 2011-07-19  Dimitri Glazkov  <dglazkov@chromium.org>
2450
2451         Store line number on TestExpectationLine.
2452         https://bugs.webkit.org/show_bug.cgi?id=64800
2453
2454         Reviewed by Adam Barth.
2455
2456         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored to store line number on TestExpectationLine instances.
2457
2458 2011-07-19  Ojan Vafai  <ojan@chromium.org>
2459
2460         fix flakiness dashboard for XP bots with XP in the name instead of WIN
2461         https://bugs.webkit.org/show_bug.cgi?id=64826
2462
2463         Reviewed by Mihai Parparita.
2464
2465         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2466         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2467
2468 2011-07-19  Cary Clark  <caryclark@google.com>
2469
2470         add myself to committers.py
2471         https://bugs.webkit.org/show_bug.cgi?id=64816
2472
2473         No review needed.
2474
2475         * Scripts/webkitpy/common/config/committers.py:
2476
2477 2011-07-19  Daniel Bates  <dbates@webkit.org>
2478
2479         Rename variable isEmptyTextPatch in svn-{apply, unapply}
2480         https://bugs.webkit.org/show_bug.cgi?id=64648
2481
2482         Reviewed by Adam Roben.
2483
2484         Rename the variable isEmptyTextPatch to hasTextChunks, which is
2485         more descriptive and makes its usage read well in control statements.
2486
2487         * Scripts/svn-apply:
2488         (patch):
2489         * Scripts/svn-unapply:
2490         (patch):
2491
2492 2011-07-19  Adam Roben  <aroben@apple.com>
2493
2494         Make TestFailures show existing bugs and a new bug link for flaky tests
2495
2496         Fixes <http://webkit.org/b/63728> TestFailures page should make it easy to file bugs about
2497         flaky tests
2498         and
2499         <http://webkit.org/b/63830> TestFailures page doesn't show related bugs for possibly-flaky
2500         tests, but should
2501
2502         Reviewed by Sam Weinig.
2503
2504         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
2505         Added. This is what's used to file new bugs about flaky tests.
2506         (FlakyTestBugForm): Calls up to the base class, stores the arguments, and sets our
2507         title, description, and URL.
2508
2509         (FlakyTestBugForm.prototype._createBugDescription):
2510         (FlakyTestBugForm.prototype._createBugTitle):
2511         These do what they say.
2512
2513         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
2514         Added. Tests of the above.
2515
2516         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2517         (#failure-history > li):
2518         (#possibly-flaky-tests > li):
2519         (#failure-history > li, #possibly-flaky-tests > li):
2520         (#possibly-flaky-tests > li > :first-child):
2521         (.flakiness-examples-list):
2522         Styling to account for the new elements.
2523
2524         (.expandable):
2525         (.expanded > .expandable):
2526         Generalized the .flakiness-example-list code to a generic .expandable class. Removed the
2527         transition properties because we can't transition to/from 'auto' (but really would like
2528         to!).
2529
2530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2531         (ViewController.prototype._displayBuilder): Moved code to create the FailingTestsBugForm
2532         here from _domForNewAndExistingBugs. Updated for changes to _domForPossiblyFlakyTests.
2533         (ViewController.prototype._domForNewAndExistingBugs): Changed to take a NewBugForm as an
2534         argument instead of creating one ourselves.
2535         (ViewController.prototype._domForPossiblyFlakyTests): Changed to take all analyzed builds as
2536         an argument instead of just the number of analyzed builds. Put the examples list inside a
2537         container <div>, which is also used to hold the new/existing bugs UI. Removed code to deal
2538         with animating the height of the examples list; we don't do this anymore because it's hard
2539         to make it work correctly with the asynchronous loading of existing bugs. When we populate
2540         the examples list, also set up the new/existing bug UI.
2541
2542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
2543         FlakyTestBugForm.
2544
2545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2546         Pull in FlakyTestBugForm and its tests.
2547
2548 2011-07-19  Ryosuke Niwa  <rniwa@webkit.org>
2549
2550         Buildbot marks a nrwt bot red when tests are missing results
2551         https://bugs.webkit.org/show_bug.cgi?id=64812
2552
2553         Reviewed by Tony Chang.
2554
2555         Added "missing results" label for tests that are missing results.
2556
2557         buildbot Now reports shows a label "X missing results" on a run when X tests were missing
2558         expected results on that run.
2559
2560         Also rephrased "X failed" and "X were flaky" to "X failures" and "X flakes".
2561
2562         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2563
2564 2011-07-19  Adam Roben  <aroben@apple.com>
2565
2566         Extract some of FailingTestsBugForm's code into a base class
2567
2568         Prep work for fixing <http://webkit.org/b/63728> TestFailures page should make it easy to
2569         file bugs about flaky tests
2570
2571         Reviewed by Sam Weinig.
2572
2573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
2574         Moved BugzillaConstants to new WebKitBugzilla file. Moved a bunch of other code from here to
2575         TestRelatedBugForm.js.
2576
2577         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2578         Moved some tests to TestRelatedBugForm_unittests.js.
2579
2580         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Added.
2581         (TestRelatedBugForm):
2582         (TestRelatedBugForm.prototype.domElement):
2583         (TestRelatedBugForm.prototype._computeOperatingSystem):
2584         (TestRelatedBugForm.prototype._computePlatform):
2585         Code came from FailingTestsBugForm.
2586
2587         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
2588         Added. Tests came from FailingTestsBugForm_unittests.js
2589
2590         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:
2591         Added. Code came from FailingTestsBugForm.js.
2592
2593         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
2594         TestRelatedBugForm.js and WebKitBugzilla.js. Moved Bugzilla.js out of the list of files that
2595         need to be pulled in early for parsing reasons.
2596
2597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2598         Pull in TestRelatedBugForm and tests and WebKitBugzilla.
2599
2600 2011-07-19  Sam Weinig  <sam@webkit.org>
2601
2602         Remove obsolete Mac NRWT test bots
2603         https://bugs.webkit.org/show_bug.cgi?id=64806
2604
2605         Reviewed by Adam Roben.
2606
2607         Remove "Leopard Intel Release (NRWT)" and "SnowLeopard Intel Release (NRWT)"
2608         which have been disconnected for some time and have been obsoleted by
2609         the main testers using NRWT.
2610
2611         * BuildSlaveSupport/build.webkit.org-config/config.json:
2612
2613 2011-07-19  Sam Weinig  <sam@webkit.org>
2614
2615         webkit-patch rebaseline crashes on use
2616         https://bugs.webkit.org/show_bug.cgi?id=64775
2617
2618         Reviewed by Adam Roben.
2619
2620         Fix incorrectly spelled attribute name.
2621
2622         * Scripts/webkitpy/common/net/layouttestresults.py:
2623         The attribute is test_name, not filename.
2624
2625         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2626         Add test for tests_matching_failure_types.
2627
2628 2011-07-18  Eric Seidel  <eric@webkit.org>
2629
2630         new-run-webkit-tests should support --leaks
2631         https://bugs.webkit.org/show_bug.cgi?id=63832
2632
2633         Reviewed by Dirk Pranke.
2634
2635         This may not be sufficient to actually transition over the leaks bot,
2636         but this is a huge step in the right direction.
2637
2638         I had to make parse-malloc-history understand being passed more than
2639         one file (to avoid the silly cat | nonsense in old-run-webkit-tests).
2640
2641         I removed some dead code relating to previous iterations of our crash detection.
2642
2643         I created a new class "LeakDetector" to encapsulate all this logic.
2644         Eventually we should consider pulling that class out of mac.py and
2645         sharing with other ports.  However given that ORWT has had
2646         --leaks support on Mac for almost 7 years and no other port has added
2647         it, leaves me to believe we're in no rush to move LeakDetector.
2648
2649         I've tested --leaks locally.  I suspect there are more bugs to shake out
2650         but it seems to work well enough to start.
2651
2652         I also added support for --guard-malloc, but have not tested it much.  It
2653         should be viewed as experimental at this time.
2654
2655         I also fixed various os.path uses to self._filesystem as I was reading
2656         through the various files to understand how best to fix this bug.
2657
2658         * Scripts/old-run-webkit-tests:
2659         (parseLeaksandPrintUniqueLeaks):
2660         * Scripts/parse-malloc-history:
2661         (main):
2662         * Scripts/webkitpy/common/system/crashlogs.py:
2663         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2664         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2665         * Scripts/webkitpy/layout_tests/port/base.py:
2666         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2667         * Scripts/webkitpy/layout_tests/port/gtk.py:
2668         * Scripts/webkitpy/layout_tests/port/mac.py:
2669         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2670         * Scripts/webkitpy/layout_tests/port/server_process.py:
2671         * Scripts/webkitpy/layout_tests/port/webkit.py:
2672         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2673
2674 2011-07-19  Adam Barth  <abarth@webkit.org>
2675
2676         garden-o-matic should have a "Triage Failures" button for iterating over failures
2677         https://bugs.webkit.org/show_bug.cgi?id=64769
2678
2679         Reviewed by Eric Seidel.
2680
2681         This patch adds some global static state and refactors things a bit so
2682         that we can iterate over all the failures in the details pane.
2683
2684         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
2685             - Add a generic callback iterator to iterate through a series of
2686               callbacks. We use this to iterate through the failures we want to
2687               display the details of.
2688         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
2689             - Add a toolbar for the results summary and change the buttons to
2690               be real buttons.
2691         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
2692             - Make the detail pane 75% of the window.
2693             - Make the buttons pretty.
2694             - Allow the failure type badges to apply to the details pane as well.
2695         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
2696             - Restructure how we bring up the details pane so we can iterate
2697               through a bunch of failures.
2698             - Remove the transition between results details because it's
2699               annoying when you want to click through a bunch of failures.
2700         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
2701             - Add some more structure to the title bar for the results details
2702               so it's clearer which results we're currently displaying.
2703
2704 2011-07-19  Adam Barth  <abarth@webkit.org>
2705
2706         garden-o-matic should live update as conditions change on the buildbot
2707         https://bugs.webkit.org/show_bug.cgi?id=64646
2708
2709         Reviewed by Eric Seidel.
2710
2711         This patch causes the garden-o-matic display to update every 10 minutes
2712         to show the latest failures.  This patch required a moderately large
2713         refactoring of main.js to make the display incremental instead of
2714         all-at-once.
2715
2716         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
2717         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
2718         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
2719         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
2720
2721 2011-07-18  Tab Atkins  <jackalmage@gmail.com>
2722
2723         Tab Atkins is not in committers.py (as a non-committer)
2724         https://bugs.webkit.org/show_bug.cgi?id=64770
2725
2726         Reviewed by Eric Seidel.
2727
2728         * Scripts/webkitpy/common/config/committers.py:
2729
2730 2011-07-18  Ojan Vafai  <ojan@chromium.org>
2731
2732         Load ToT chromium bots by default in the flakiness dashboard
2733         https://bugs.webkit.org/show_bug.cgi?id=64756
2734
2735         Reviewed by Adam Barth.
2736
2737         For now, these are the most useful bots to look at. Eventually,
2738         we may want to load the build.webkit.org bots by default once
2739         most of the bots there upload results.
2740
2741         * TestResultServer/static-dashboards/dashboard_base.js:
2742
2743 2011-07-13  Jon Honeycutt  <jhoneycutt@apple.com>
2744
2745         Focus and selection events are not fired when a <select>'s selection
2746         changes
2747         https://bugs.webkit.org/show_bug.cgi?id=64504
2748         <rdar://problem/9319881>
2749
2750         Reviewed by Alice Liu.
2751
2752         * DumpRenderTree/AccessibilityController.h:
2753         Added m_notificationsEventHook for addNotificationListener().
2754         m_allEventsHook will now be used for setLogAccessibilityEvents().
2755
2756         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2757         (AccessibilityController::AccessibilityController):
2758         Initialize m_notificationsEventHook.
2759         (AccessibilityController::~AccessibilityController):
2760         Turn off logging of all accessibility events. If
2761         m_notificationsEventHook is non-null, unhook it.
2762         (logEventProc):
2763         Add handling of EVENT_OBJECT_SELECTION.
2764         (AccessibilityController::setLogAccessibilityEvents):
2765         If the state of logging is not changing, return early. If we're turning
2766         off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
2767         hook for all events.
2768         (AccessibilityController::addNotificationListener):
2769         Use m_notificationsEventHook rather than m_allEventsHook.
2770
2771 2011-07-18  Eric Seidel  <eric@webkit.org>
2772
2773         webkit-patch apply-attachment does not work when not called from the root of the checkout
2774         https://bugs.webkit.org/show_bug.cgi?id=64751
2775
2776         Unreviewed.  Just updating unit test results after bug 64751.
2777
2778         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2779         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2780
2781 2011-07-18  Adam Barth  <abarth@webkit.org>
2782
2783         simplejson has trouble on chromium-linux
2784         https://bugs.webkit.org/show_bug.cgi?id=64757
2785
2786         Reviewed by Eric Seidel.
2787
2788         Use the native JSON, if available.
2789
2790         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2791
2792 2011-07-18  Ojan Vafai  <ojan@chromium.org>
2793
2794         update the flakiness dashboard to understand the new platforms/formats in test_expectations
2795         https://bugs.webkit.org/show_bug.cgi?id=64743
2796
2797         Reviewed by Adam Barth.
2798
2799         The test expectations format changed a long time ago and the flakiness dashboard
2800         was never updated to match.
2801
2802         * TestResultServer/static-dashboards/dashboard_base.js:
2803         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2804         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2805         * TestResultServer/static-dashboards/timeline_explorer.html:
2806
2807 2011-07-18  Eric Seidel  <eric@webkit.org>
2808
2809         webkit-patch apply-attachment does not work when not called from the root of the checkout
2810         https://bugs.webkit.org/show_bug.cgi?id=64751
2811
2812         Reviewed by Adam Barth.
2813
2814         Last week I removed a os.chdir in EnsureWorkingDirectoryClean, which
2815         is a step that we run for most commands (as one of the earliest steps).
2816         EnsureWorkingDirectoryClean was incorrectly calling os.chdir to change
2817         the CWD to the checkout root.  This magically made a bunch of otherwise
2818         wrong code work.
2819
2820         When I realized that apply-attachment no longer worked as expected today,
2821         I went and fixed the bug, then realizing that we were not testing
2822         what the cwd was when running various commands.  I fixed our MockExecutive
2823         to always log what the cwd is and fixed a whole bunch of places
2824         where we needed to be setting the cwd.
2825
2826         Hopefully this will solve our cwd problems once and for-all, and webkit-patch
2827         will again correctly work when called from any directory (including outside
2828         of a webkit checkout).
2829
2830         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2831         * Scripts/webkitpy/common/system/executive.py:
2832         * Scripts/webkitpy/common/system/workspace_unittest.py:
2833         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2834         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2835         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2836         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2837         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2838         * Scripts/webkitpy/tool/bot/irc_command.py:
2839         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2840         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2841         * Scripts/webkitpy/tool/commands/download_unittest.py:
2842         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2843         * Scripts/webkitpy/tool/commands/queues.py:
2844         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2845         * Scripts/webkitpy/tool/commands/queuestest.py:
2846         * Scripts/webkitpy/tool/mocktool.py:
2847         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2848         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2849         * Scripts/webkitpy/tool/steps/build.py:
2850         * Scripts/webkitpy/tool/steps/checkstyle.py:
2851         * Scripts/webkitpy/tool/steps/editchangelog.py:
2852         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2853         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2854         * Scripts/webkitpy/tool/steps/runtests.py:
2855         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2856         * Scripts/webkitpy/tool/steps/update.py:
2857
2858 2011-07-18  Adam Barth  <abarth@webkit.org>
2859
2860         Increase information garden-o-matic information density by switching to a table
2861         https://bugs.webkit.org/show_bug.cgi?id=64642
2862
2863         Reviewed by Dimitri Glazkov.
2864
2865         The old layout couldn't handle the large number of failures we had
2866         today.  This patch switches garden-o-matic to a table-based layout,
2867         which can handle many more failures gracefully.  (I expect we'll need
2868         more UI iterations.)
2869
2870         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
2871         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
2872         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
2873         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
2874
2875 2011-07-18  Adam Barth  <abarth@webkit.org>
2876
2877         garden-o-matic should be able to determine when compile breaks
2878         https://bugs.webkit.org/show_bug.cgi?id=64190
2879
2880         Reviewed by Dimitri Glazkov.
2881
2882         This patch adds a red-ish box to the top of the page whenever there is
2883         a compile error on the bots.  The box automatically opens and closes as
2884         appropriate and links to the waterfall display.  In the future, we
2885         might want to compute a regression range.
2886
2887         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
2888             - Add the build-only bots to the config.  We use these to check
2889               whether the build failed, which is faster than waiting for the
2890               tester bots to cycle.
2891         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
2892             - Add DOM for the alert bar.
2893         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
2894             - CSS to support the alert bar.
2895         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
2896             - Wiring up events to poll the buildbot to see whether compile has
2897               failed.
2898         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
2899             - Infrastructure for fetching and parsing the buildbot status JSON
2900               blob.  This code could be better factored for testability.  :(
2901         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
2902             - UI for displaying compile errors.
2903         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
2904
2905 2011-07-18  Sheriff Bot  <webkit.review.bot@gmail.com>
2906
2907         Unreviewed, rolling out r91132 and r91135.
2908         http://trac.webkit.org/changeset/91132
2909         http://trac.webkit.org/changeset/91135
2910         https://bugs.webkit.org/show_bug.cgi?id=64681
2911
2912         Broke GTK and Chromium debug bots (Requested by rniwa on
2913         #webkit).
2914
2915         * DumpRenderTree/AccessibilityController.h:
2916         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2917         (AccessibilityController::AccessibilityController):
2918         (AccessibilityController::~AccessibilityController):
2919         (logEventProc):
2920         (AccessibilityController::setLogAccessibilityEvents):
2921         (AccessibilityController::addNotificationListener):
2922
2923 2011-07-17  Philippe Normand  <pnormand@igalia.com>
2924
2925         test-webkitpy failing with Python 2.5
2926         https://bugs.webkit.org/show_bug.cgi?id=64594
2927
2928         Reviewed by Eric Seidel.
2929
2930         Updated simplejson to version 2.1.6 that fixes an issue when
2931         dumping slashes. Also use cgi.parse_qs instead of the urlparse
2932         version to be compatible with Python2.5. Verified the fix with
2933         test-webkitpy on python 2.5 and python 2.6.
2934
2935         * Scripts/webkitpy/thirdparty/simplejson/README.txt:
2936         * Scripts/webkitpy/thirdparty/simplejson/__init__.py:
2937         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c:
2938         (json_PyOS_string_to_double):
2939         (_convertPyInt_AsSsize_t):
2940         (_convertPyInt_FromSsize_t):
2941         (ascii_escape_char):
2942         (ascii_escape_unicode):
2943         (ascii_escape_str):
2944         (raise_errmsg):
2945         (join_list_unicode):
2946         (join_list_string):
2947         (_build_rval_index_tuple):
2948         (scanstring_str):
2949         (scanstring_unicode):
2950         (py_scanstring):
2951         (py_encode_basestring_ascii):
2952         (scanner_dealloc):
2953         (scanner_traverse):
2954         (scanner_clear):
2955         (_parse_object_str):
2956         (_parse_object_unicode):
2957         (_parse_array_str):
2958         (_parse_array_unicode):
2959         (_parse_constant):
2960         (_match_number_str):
2961         (_match_number_unicode):
2962         (scan_once_str):
2963         (scan_once_unicode):
2964         (scanner_call):
2965         (scanner_new):
2966         (scanner_init):
2967         (encoder_new):
2968         (encoder_init):
2969         (encoder_call):
2970         (_encoded_const):
2971         (encoder_encode_float):
2972         (encoder_encode_string):
2973         (_steal_list_append):
2974         (encoder_listencode_obj):
2975         (encoder_listencode_dict):
2976         (encoder_listencode_list):
2977         (encoder_dealloc):
2978         (encoder_traverse):
2979         (encoder_clear):
2980         (init_speedups):
2981         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
2982         * Scripts/webkitpy/thirdparty/simplejson/encoder.py:
2983         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Added.
2984         * Scripts/webkitpy/thirdparty/simplejson/scanner.py:
2985         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Added.
2986         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2987
2988 2011-07-17  Dimitri Glazkov  <dglazkov@chromium.org>
2989
2990         Rename ModifierMatcher to SpecificityCalculator.
2991         https://bugs.webkit.org/show_bug.cgi?id=64660
2992
2993         It's a little longer than before, but it is much clearer.
2994
2995         Reviewed by Adam Barth.
2996
2997         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Renamed and adjusted
2998             all callsites, also rewrote the comments.
2999         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted callsites
3000             and renamed tests.
3001
3002 2011-07-15  Adam Barth  <abarth@webkit.org>
3003
3004         gardening server should proxy buildbot status for garden-o-matic
3005         https://bugs.webkit.org/show_bug.cgi?id=64588
3006
3007         Reviewed by Eric Seidel.
3008
3009         This information will be used to detect build breaks.  I took this
3010         opportunity to make ChromiumBuildBot non-static.
3011
3012         * Scripts/webkitpy/common/host.py:
3013         * Scripts/webkitpy/tool/commands/rebaseline.py:
3014         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3015         * Scripts/webkitpy/tool/mocktool.py:
3016         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3017         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3018
3019 2011-07-15  Julien Chaffraix  <jchaffraix@webkit.org>
3020
3021         [NRWT] Add support for --no-http
3022         https://bugs.webkit.org/show_bug.cgi?id=64564
3023
3024         Reviewed by Dirk Pranke.
3025
3026         Added support for --no-http, which disables both HTTP and websockets tests.
3027         It also matches the old-run-webkit-tests behavior if --force is used.
3028
3029         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3030         Fixed HTTP_SUBDIR and WEBSOCKET_SUBDIR as tests do not start with a leading separator.
3031         We check if --no-http is set and add the HTTP / websockets tests to the skipped list prior to looking
3032         at the expectation file. Fixed the  _test_requires_lock function to use the same code path to determine
3033         what is worth have an HTTP lock as --no-http to avoid badness.
3034
3035         * Scripts/webkitpy/layout_tests/port/test.py: Added 2 new tests to our mock filesystem to validate that
3036         we do skip properly HTTP / websocket tests inside platform/.
3037
3038         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3039         Added tests that we properly skip all the tests.
3040
3041         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3042         Added checks for the command line arguments.
3043
3044 2011-07-13  Jon Honeycutt  <jhoneycutt@apple.com>
3045
3046         Focus and selection events are not fired when a <select>'s selection
3047         changes
3048         https://bugs.webkit.org/show_bug.cgi?id=64504
3049         <rdar://problem/9319881>
3050
3051         Reviewed by Alice Liu.
3052
3053         * DumpRenderTree/AccessibilityController.h:
3054         Added m_notificationsEventHook for addNotificationListener().
3055         m_allEventsHook will now be used for setLogAccessibilityEvents().
3056
3057         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3058         (AccessibilityController::AccessibilityController):
3059         Initialize m_notificationsEventHook.
3060         (AccessibilityController::~AccessibilityController):
3061         Turn off logging of all accessibility events. If
3062         m_notificationsEventHook is non-null, unhook it.
3063         (logEventProc):
3064         Add handling of EVENT_OBJECT_SELECTION.
3065         (AccessibilityController::setLogAccessibilityEvents):
3066         If the state of logging is not changing, return early. If we're turning
3067         off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
3068         hook for all events.
3069         (AccessibilityController::addNotificationListener):
3070         Use m_notificationsEventHook rather than m_allEventsHook.
3071
3072 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
3073
3074         Refactor TestExpectationModel to use TestExpectationLine as data item.
3075         https://bugs.webkit.org/show_bug.cgi?id=64635
3076
3077         This is a bit largish in scope. Does the following things:
3078
3079         1) Adds "path" member to TestExpectationLine to hold normalized path to test, computed at parsing,
3080            and changes code that used Port.normalize_test_name to rely on TestExpectationLine.path. As a result, TestExpectationModel no longer
3081            needs to have any port knowledge.
3082
3083         2) Adds "create_passing_expectation" class method to TestExpectationLine to generate a pristine passing expectation out of a test name,
3084            and changes TestExpectations._process_tests_without_expectations to use it, thus eliminating the need for a special API entry point.
3085            Now all expectations are added to the model in the same way!
3086
3087         3) Changes TestExpectationModel's main test index to store a tuple consisting of line number and TestExpectationLine instance.
3088
3089         Reviewed by Adam Barth.
3090
3091         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored code.
3092
3093 2011-07-15  Adam Roben  <aroben@apple.com>
3094
3095         Teach TestFailures how to detect interrupted build steps
3096
3097         Fixes <http://webkit.org/b/64619> TestFailures page thinks all tests passed in
3098         http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/builds/13401
3099
3100         Reviewed by Daniel Bates.
3101
3102         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3103         (Builder.prototype.getNumberOfFailingTests): If the build step has a result code of 4, the
3104         build step was interrupted. Treat it as an error (by returning a failureCount of -1).
3105
3106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
3107         Added a test for the above.
3108
3109         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
3110         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
3111         cache data that was afflicted by the above bug.
3112
3113 2011-07-15  Eric Seidel  <eric@webkit.org>
3114
3115         new-run-webkit-tests crashes on Apple's Windows port when trying to launch Apache
3116         https://bugs.webkit.org/show_bug.cgi?id=64533
3117
3118         Reviewed by Adam Roben.
3119
3120         Blind removal of Chromium-specific code (now that Chromium does not use this file).
3121
3122         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3123
3124 2011-07-15  Adam Roben  <aroben@apple.com>
3125
3126         Make TestFailures's list of possibly-flaky tests not so tall
3127
3128         Fixes <http://webkit.org/b/64618> TestFailures page's list of flaky tests takes up way too
3129         much room
3130
3131         Reviewed by Daniel Bates.
3132
3133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
3134         Removed a no-longer-used .flakiness-example-separator selector.
3135
3136         (#failure-history > li):
3137         (#possibly-flaky-tests > li):
3138         (#failure-history > li, #possibly-flaky-tests > li):
3139         Use a lot less padding for the possibly-flaky tests.
3140
3141 2011-07-15  Tony Chang  <tony@chromium.org>
3142
3143         [chromium] land linux selection color layout test
3144         https://bugs.webkit.org/show_bug.cgi?id=64631
3145
3146         Reviewed by Ojan Vafai.
3147
3148         I had removed this code in r76620 because I thought it wasn't used.
3149         Turns out there was a layout test in the chromium tree that never
3150         got migrated that used it.  Re-add the code and land the layout
3151         test (I will remove it from the chromium tree soon).
3152
3153         * DumpRenderTree/chromium/LayoutTestController.cpp:
3154         (LayoutTestController::LayoutTestController):
3155         (LayoutTestController::forceRedSelectionColors):
3156         * DumpRenderTree/chromium/LayoutTestController.h:
3157
3158 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
3159
3160         Revert http://trac.webkit.org/changeset/91091, since Python 2.5
3161         does not support enumerate() start argument.
3162
3163         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Reverted.
3164
3165 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
3166
3167         Clean up test_expectations.py after refactorings.
3168         https://bugs.webkit.org/show_bug.cgi?id=64620
3169
3170         * Renamed all variables holding TestExpectationLine to expectation_line to avoid confusion with
3171           its sub-part, the actual expectation.
3172         * Renamed all references to options to modifier to eliminate dual terminology.
3173         * Made a bunch of parser constants and changed all callsites to use them.
3174         * Various other minor clean-ups.
3175
3176         Reviewed by Adam Barth.
3177
3178         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Cleaned up stuff.
3179         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed callsites after cleanup.
3180         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.
3181
3182 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
3183
3184         Move expectation parsing code to TestExpectationParser.
3185         https://bugs.webkit.org/show_bug.cgi?id=64605
3186
3187         This is a somewhat mechanical move, with two interesting bits:
3188
3189         1) TestExpectationParser.parse methods renamed to tokenize, to better
3190         reflect what they do
3191
3192         2) TestExpectationLine now carries all of its info, from tokens to parsed data,
3193         and even the list of tests that it matches (a line may refer to more than one test).
3194
3195         Reviewed by Adam Barth.
3196
3197         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved parsing-related TestExpectaions methods
3198             to TestExpectationParser, added more members to TestExpectationLine to carry parsed info, renamed existing parse methods
3199             to "tokenize", changed callsites to use new code.
3200         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed unit tests to reflect renames.
3201
3202 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
3203
3204         Switch to use Python enumerate function to enumerate line numbers.
3205         https://bugs.webkit.org/show_bug.cgi?id=64602
3206
3207         Reviewed by Adam Barth.
3208
3209         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use enumerate.
3210
3211 2011-07-15  Martin Robinson  <mrobinson@igalia.com>
3212
3213         Build fixes for WebKit2. Ensure that all generated sources are
3214         on nodist primaries, that they are on forward declared variables
3215         so that BUILT_SOURCES is calculated properly and that zlib is
3216         included during linking (for WOFF support).
3217
3218         * WebKitTestRunner/GNUmakefile.am:
3219
3220 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
3221
3222         Store error and warning information on TestExpectationLine.
3223         https://bugs.webkit.org/show_bug.cgi?id=64565
3224
3225         Keeping errors and warnings on the TestExpectationLine instance allows us to decouple storing errors
3226         from various parsing and validation mechanisms and have more flexibility in reporting and understanding the origin of the errors.
3227
3228         Reviewed by Adam Barth.
3229
3230         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added TestExpectationLine.warnings list to keep track of non-fatal errors,
3231             converted the code to add errors and warnings to corresponding TestExpectationLine instances, removed the code that used to store
3232             this info on TestExpectations. In the process, had to refactor ModifierMatcher a bit to take in a TestExpdectationLine instance.
3233         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed ModifierMatcher callsite.
3234
3235 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
3236
3237         Plumb the use of TestExpectationLine deeper, clean up.
3238         https://bugs.webkit.org/show_bug.cgi?id=64559
3239
3240         Instead of carrying various bits of TestExpectationLine, plumb it down to its consumers,
3241         also cleaning up names and remove an unused TestExpectations._get_options_list member.
3242
3243         Reviewed by Adam Barth.
3244
3245         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3246
3247 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
3248
3249         Remove the notion of TestExpectationLine.valid, start storing parsing errors in expectations themselves.
3250         https://bugs.webkit.org/show_bug.cgi?id=64554
3251
3252         This moves us toward the world where errors are collected on the expectations, which allows us to
3253         easily enumerate them, keep association with the point of origin, and freely pass TestExpectationLine instances around.
3254
3255         Also eliminate the validator idea, since validation is a context-dependent concept and has to be decoupled from initial
3256         parsing.
3257
3258         Reviewed by Adam Barth.
3259
3260         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed TestExpectation.valid, validator,
3261             changed TestExpectationParser to collect errors in TestExpectationLine, refactored surrounding code.
3262         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to accommodate changes.
3263         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.
3264
3265 2011-07-15  Adam Roben  <aroben@apple.com>
3266
3267         Rename TestFailureBugForm to FailingTestsBugForm
3268
3269         The new name will match better with a forthcoming FlakyTestBugForm class.
3270
3271         Fixes <http://webkit.org/b/64598> TestFailures page's TestFailureBugForm class has a bad
3272         name
3273
3274         Reviewed by Daniel Bates.
3275
3276         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js.
3277         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js.
3278
3279         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3281         Updated for renames.
3282
3283         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Ditto, and
3284         reordered <script>s to put files which others depend on for parsing first.
3285
3286 2011-07-15  Adam Barth  <abarth@webkit.org>
3287
3288         NRWT stores the Chromium revision number in full_results.json
3289         https://bugs.webkit.org/show_bug.cgi?id=64586
3290
3291         I have no earthly idea how to test this change.
3292
3293         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3294         * Scripts/webkitpy/layout_tests/port/base.py:
3295
3296 2011-07-14  Ojan Vafai  <ojan@chromium.org>
3297
3298         fix remaining style issues in the static-dashboards directory
3299         https://bugs.webkit.org/show_bug.cgi?id=64561
3300
3301         Reviewed by Adam Barth.
3302
3303         * TestResultServer/static-dashboards/aggregate_results.html:
3304         * TestResultServer/static-dashboards/builders.js:
3305         * TestResultServer/static-dashboards/dashboard_base.js:
3306         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3307         * TestResultServer/static-dashboards/timeline_explorer.html:
3308         * TestResultServer/static-dashboards/treemap.html:
3309
3310 2011-07-14  Yuta Kitamura  <yutak@chromium.org>
3311
3312         WebSocket: Introduce pywebsocket-0.6b2
3313         https://bugs.webkit.org/show_bug.cgi?id=64534
3314
3315         Reviewed by Kent Tamura.
3316
3317         * Scripts/webkitpy/thirdparty/__init__.py:
3318
3319 2011-07-14  Dimitri Glazkov  <dglazkov@chromium.org>
3320
3321         Introduce TestExpectationsModel, split out of TestExpectations.
3322         https://bugs.webkit.org/show_bug.cgi?id=64531
3323
3324         This is a simple split-and-make-work refactoring, a first step among many.
3325
3326         Reviewed by Adam Barth.
3327
3328         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved all model-related members
3329             out of TestExpectations and into TestExpectationsModel.
3330
3331 2011-07-14  Eric Seidel  <eric@webkit.org>
3332
3333         Move webkitpy off of loose mocks
3334         https://bugs.webkit.org/show_bug.cgi?id=64508
3335
3336         Unreviewed.  Fixing a test which fails under test-webkitpy --all (but not in a normal run).
3337
3338         * Scripts/webkitpy/common/checkout/scm/git.py:
3339
3340 2011-07-14  Adam Barth  <abarth@webkit.org>
3341
3342         garden-o-matic should have a "rebaseline" button
3343         https://bugs.webkit.org/show_bug.cgi?id=64446
3344
3345         Reviewed by Ojan Vafai.
3346
3347         This patch adds a basic Rebaseline button that copies the baselines
3348         displayed in the results pane into the appropriate directory in your
3349         working copy.
3350
3351         There are two main limitations:
3352
3353         1) There is no UI for actually committing the baselines.
3354
3355         2) The baselines are not optimized for redundancy (meaning you can have
3356            identical baselines in both chromium-mac and chromium-win).
3357
3358         * Scripts/webkitpy/tool/commands/rebaseline.py:
3359             - Turns out we need to create the directory for the baseline if it doesn't exist yet.
3360         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
3361             - Add an programatic API to call the server.
3362         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
3363             - Add the rebaseline button itself.
3364         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
3365             - Change the CSS so that the Rebaseline and Close buttons can
3366               appear in the normal order in the DOM.
3367         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3368             - Bind the event and translate the parameters.
3369             - Hide/show the rebaseline button, as appropriate.
3370         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
3371             - Add some helpful utility functions for manipulating failure types.
3372         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
3373
3374 2011-07-14  Ryosuke Niwa  <rniwa@webkit.org>
3375
3376         REGRESSION: webkit-patch roll-chromium-deps is broken
3377         https://bugs.webkit.org/show_bug.cgi?id=64568
3378
3379         Reviewed by Dirk Pranke
3380
3381         Use _filesystem.join.
3382
3383         * Scripts/webkitpy/common/checkout/checkout.py:
3384         * Scripts/webkitpy/common/checkout/checkout_unittests.py:
3385
3386 2011-07-14  Noam Rosenthal  <noam.rosenthal@nokia.com>
3387
3388         Adding myself to the reviewers list; No review needed.
3389
3390         * Scripts/webkitpy/common/config/committers.py:
3391
3392 2011-07-14  Adam Roben  <aroben@apple.com>
3393
3394         Don't use Element.prototype.classList in TestFailures
3395
3396         Safari 5 doesn't support it.
3397
3398         Fixes <http://webkit.org/b/64550> Can't expand flaky tests on TestFailures page in Safari 5
3399
3400         Reviewed by Daniel Bates.
3401
3402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
3403         (Element.prototype.hasStyleClass):
3404         (Element.prototype.addStyleClass):
3405         (Element.prototype.removeStyleClass):
3406         (Element.prototype.toggleStyleClass):
3407         Added these helper functions which simulate classList functionality.
3408
3409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js:
3410         Added. Tests for the above.
3411
3412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3413         (ViewController.prototype._domForPossiblyFlakyTests): Changed to use
3414         toggleStyleClass/hasStyleClass instead of classList.
3415
3416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3417         Added Utilities_unittests.js, and reordered the tested files to be in
3418         roughly dependency order (i.e., the lowest-level files are imported
3419         and tested first).
3420
3421 2011-07-14  Eric Seidel  <eric@webkit.org>
3422
3423         NRWT doesn't store the svn revision in full_results.json on chromium-win
3424         https://bugs.webkit.org/show_bug.cgi?id=64492
3425
3426         Unreviewed.  Just fixing my test-webkitpy regression.
3427
3428         Fix the unit tests.  Unfortunately scm does not use a filesystem
3429         object so we can't control the result of detect_scm_system.
3430         When detect_scm_system would fail, we would log, which would
3431         cause all passing_run integration tests to fail.
3432
3433         * Scripts/webkitpy/common/checkout/scm/scm.py:
3434         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3435         * Scripts/webkitpy/layout_tests/port/base.py:
3436         * Scripts/webkitpy/layout_tests/port/test.py:
3437         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3438
3439 2011-07-14  Eric Seidel  <eric@webkit.org>
3440
3441         NRWT doesn't store the svn revision in full_results.json on chromium-win
3442         https://bugs.webkit.org/show_bug.cgi?id=64492
3443
3444         Reviewed by Ojan Vafai.
3445
3446         This should fix the bug.  Unfortunately this code is currently
3447         impossible to test since it's impossible to mock detect_scm_system at the
3448         moment.  I started re-writing scm.detection.py to be mockable, but decided that
3449         was best left for another day.
3450
3451         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3452         * Scripts/webkitpy/layout_tests/port/base.py:
3453
3454 2011-07-14  Ojan Vafai  <ojan@chromium.org>
3455
3456         fix coding style of dashboard_base.js
3457         https://bugs.webkit.org/show_bug.cgi?id=64545
3458
3459         Reviewed by Adam Roben.
3460
3461         The code changes to the files other than dashboard_base.js
3462         are just fallout from renaming globals in dashboard_base.js.
3463
3464         * TestResultServer/static-dashboards/aggregate_results.html:
3465         * TestResultServer/static-dashboards/builders.js:
3466         * TestResultServer/static-dashboards/dashboard_base.js:
3467         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3468         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3469         * TestResultServer/static-dashboards/timeline_explorer.html:
3470         * TestResultServer/static-dashboards/treemap.html:
3471
3472 2011-07-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3473
3474         Unreviewed. Fix WebKit2 GTK build after r90953.
3475
3476         * WebKitTestRunner/GNUmakefile.am:
3477
3478 2011-07-14  Adam Barth  <abarth@webkit.org>
3479
3480         garden-o-matic results pane should be more discoverable
3481         https://bugs.webkit.org/show_bug.cgi?id=64513
3482
3483         Reviewed by Eric Seidel.
3484
3485         This patch causes us to trigger the results pane on mouse clicks
3486         instead of mousein.  Also, handle the case of no results details more
3487         elegantly.
3488
3489         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
3490         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3491             - Change the binding to "click".
3492         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
3493             - Handle the "no results URLs" case explicitly instead of never
3494               calling the callback.
3495         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
3496         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
3497             - Show a message when there are no result details to show.
3498         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
3499
3500 2011-07-14  Adam Barth  <abarth@webkit.org>
3501
3502         garden-o-matic should badge TIMEOUT failures
3503         https://bugs.webkit.org/show_bug.cgi?id=64435
3504
3505         Reviewed by Eric Seidel.
3506
3507         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
3508         (.regression .what a[draggable].TIMEOUT::before):
3509             - Add TIMEOUT.
3510
3511 2011-07-14  Adam Barth  <abarth@webkit.org>
3512
3513         Fix Python exception blocking the commit-queue.
3514
3515         * Scripts/webkitpy/common/checkout/scm/git.py:
3516
3517 2011-07-13  Eric Seidel  <eric@webkit.org>
3518
3519         Move webkitpy off of loose mocks
3520         https://bugs.webkit.org/show_bug.cgi?id=64508
3521
3522         Reviewed by Adam Barth.
3523
3524         Using Mock has caused us more pain than help.
3525         It's possible that there was a cleaner way to use it
3526         (maybe Mock(class) instead of inheriting from it?).
3527         But for now, I've removed all uses of Mock from mocktool.py.
3528
3529         I also moved run_command into the only 3 files which call it
3530         instead of leaving the deprecated method in executive.py.
3531
3532         I changed various direct calls to os.* to use filesystem instead.
3533
3534         * Scripts/webkitpy/common/checkout/checkout.py:
3535         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3536         * Scripts/webkitpy/common/checkout/scm/git.py:
3537         * Scripts/webkitpy/common/checkout/scm/scm.py:
3538         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3539         * Scripts/webkitpy/common/checkout/scm/svn.py:
3540         * Scripts/webkitpy/common/system/executive.py:
3541         * Scripts/webkitpy/common/system/executive_unittest.py:
3542         * Scripts/webkitpy/tool/mocktool.py:
3543         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
3544         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
3545
3546 2011-07-13  Eric Seidel  <eric@webkit.org>
3547
3548         NRWT doesn't store the svn revision in full_results.json on chromium-win
3549         https://bugs.webkit.org/show_bug.cgi?id=64492
3550
3551         Reviewed by Adam Barth.
3552
3553         Add a warning message in the revision='' case to help us diagnose
3554         what's going wrong on the bot.
3555
3556         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3557
3558 2011-07-13  Dirk Pranke  <dpranke@chromium.org>
3559
3560         new-run-webkit-tests: print baseline search path as part of config output
3561         https://bugs.webkit.org/show_bug.cgi?id=64499
3562
3563         Reviewed by Eric Seidel.
3564
3565         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3566         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3567
3568 2011-07-13  Adam Barth  <abarth@webkit.org>
3569
3570         gardening server should have an API for parsing changelogs
3571         https://bugs.webkit.org/show_bug.cgi?id=64495
3572
3573         Reviewed by Eric Seidel.
3574
3575         This patch exposes much of the same information from CommitInfo in a
3576         dictionary form, which is easier to send over-the-wire as JSON to the
3577         frontend.
3578
3579         * Scripts/webkitpy/common/checkout/checkout.py:
3580         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3581         * Scripts/webkitpy/tool/mocktool.py:
3582         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3583         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3584         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3585
3586 2011-07-13  Eric Seidel  <eric@webkit.org>
3587
3588         REGRESSION: GitTestWithMock.test_create_patch fails
3589         https://bugs.webkit.org/show_bug.cgi?id=62945
3590
3591         Reviewed by Daniel Bates.
3592
3593         I was not able to reproduce the exact failure seen in the bug,
3594         however this test was failing on my machine for other reasons.
3595
3596         I went through and did an audit of our run_command usage, it's
3597         entirely in scm classes after this change.  (Not surprising given
3598         that scm.py was the second file ever created in webkit.py.)
3599
3600         The real bug I'm fixing here is that we were setting executive.should_log
3601         when the value had changed to executive._should_log.  Now we set the right one
3602         and the test works again.
3603
3604         * Scripts/webkitpy/common/checkout/checkout.py:
3605         * Scripts/webkitpy/common/checkout/scm/git.py:
3606         * Scripts/webkitpy/common/checkout/scm/scm.py:
3607         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3608         * Scripts/webkitpy/common/checkout/scm/svn.py:
3609
3610 2011-07-13  Ilya Sherman  <isherman@chromium.org>
3611
3612         Fix WTF header guard style check
3613         https://bugs.webkit.org/show_bug.cgi?id=64488
3614
3615         Reviewed by David Levin.
3616
3617         * Scripts/webkitpy/style/checkers/cpp.py:
3618         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Verify that we don't *always* suggest "WTF_" as a prefix
3619
3620 2011-07-13  Ojan Vafai  <ojan@chromium.org>
3621
3622         bring flakiness_dashboard.html closer to webkit style
3623         https://bugs.webkit.org/show_bug.cgi?id=64477
3624
3625         Reviewed by Adam Barth.
3626
3627         * TestResultServer/static-dashboards/dashboard_base.js:
3628         Fix bad variable name that would hit only when running the tests.
3629         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3630         No code/logic changes. All moving/removing brackets, indents and moving things
3631         to one line.
3632
3633 2011-07-13  Xan Lopez  <xlopez@igalia.com>
3634
3635         [GTK] Fix distcheck
3636
3637         Reviewed by Martin Robinson.
3638
3639         * WebKitTestRunner/GNUmakefile.am: mark built sources as nodist.
3640
3641 2011-07-13  Joseph Pecoraro  <joepeck@webkit.org>
3642
3643         Unreviewed fix. Add a "\n" to a printf that somehow got lost.
3644
3645         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3646         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3647
3648 2011-07-13  Joseph Pecoraro  <joepeck@webkit.org>
3649
3650         ApplicationCache Quota Output is Flakey
3651         https://bugs.webkit.org/show_bug.cgi?id=64410
3652
3653         Reviewed by Alexey Proskuryakov.
3654
3655         Unify the delegate logging for reaching application cache
3656         quotas. Truncate the space needed to the nearest 10000
3657         for less flakey test output. This also better supports
3658         printing NSUInteger on non-64 bit systems by casting to
3659         an unsigned long.
3660
3661         * DumpRenderTree/mac/UIDelegate.mm:
3662         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
3663         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3664         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3665
3666 2011-07-13  Dimitri Glazkov  <dglazkov@chromium.org>
3667
3668         Remove unused TestExpectations._overrides.
3669         https://bugs.webkit.org/show_bug.cgi?id=64470
3670
3671         Reviewed by Adam Barth.
3672
3673         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed unused member.
3674
3675 2011-07-13  Dimitri Glazkov  <dglazkov@chromium.org>
3676
3677         Introduce TestExpectationSerializer.list_to_string.
3678         https://bugs.webkit.org/show_bug.cgi?id=64462
3679
3680         Reviewed by Adam Barth.
3681
3682         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added list_to_string and change the relevant callsite to use it.
3683         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests for it.
3684
3685 2011-07-13  Dimitri Glazkov  <dglazkov@chromium.org>
3686
3687         Consolidate expectations parsing code.
3688         https://bugs.webkit.org/show_bug.cgi?id=64460
3689
3690         Reviewed by Adam Barth.
3691
3692         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationParser._split_expectation_string into TestExpectationParser.parse.
3693
3694 2011-07-12  Brent Fulgham  <bfulgham@webkit.org>
3695
3696         Standardize WinCairo conditionalized code under PLATFORM macro.
3697         https://bugs.webkit.org/show_bug.cgi?id=64377
3698
3699         Reviewed by Maciej Stachowiak.
3700
3701         Update compile-time conditions that had previously used #ifdef
3702         of WIN_CAIRO to consistently use PLATFORM(WIN_CAIRO).
3703
3704         * DumpRenderTree/config.h: Switch to PLATFORM(WIN_CAIRO)
3705         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Remove redundant
3706           define of WIN_CAIRO=1.
3707         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Add
3708           WinCairo.vsprops to set (to match Release build).
3709
3710 2011-07-13  Dimitri Glazkov  <dglazkov@chromium.org>
3711
3712         Eliminate TestExpectationsFile.
3713         https://bugs.webkit.org/show_bug.cgi?id=64458
3714
3715         Turns out, we can just use a Python list.
3716
3717         Reviewed by Adam Barth.
3718
3719         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationsFile.append into TestExpectationParser.parse_list,
3720             removed TestExpectationsFile.
3721         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Moved tests to better reflect new names, removed iterator test,
3722             since there's no more custom iterator machinery.
3723
3724 2011-07-13  Philippe Normand  <pnormand@igalia.com>
3725
3726         Unreviewed, added my other email addresses.
3727
3728         * Scripts/webkitpy/common/config/committers.py:
3729
3730 2011-07-13  Adam Barth  <abarth@webkit.org>
3731
3732         Folks should only be listed once.
3733
3734         * Scripts/webkitpy/common/config/committers.py:
3735
3736 2011-07-13  Philippe Normand  <pnormand@igalia.com>
3737
3738         Unreviewed, adding myself as Reviewer.
3739
3740         * Scripts/webkitpy/common/config/committers.py:
3741
3742 2011-07-13  Adam Barth  <abarth@webkit.org>
3743
3744         Fix flickering bug introduced by my previous patch.  I forgot to change
3745         the name of the class everywhere.
3746
3747         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3748
3749 2011-07-12  Philippe Normand  <pnormand@igalia.com>
3750
3751         [GTK] media/media-blocked-by-willsendrequest.html fails
3752         https://bugs.webkit.org/show_bug.cgi?id=63699
3753
3754         Reviewed by Martin Robinson.
3755
3756         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3757         (willSendRequestCallback): Abort the request if explicitely asked
3758         by the LayoutTestController's willSendRequestReturnsNull() function.
3759
3760 2011-07-13  Adam Barth  <abarth@webkit.org>
3761
3762         Remove "Dismiss" button from garden-o-matic butterbar
3763         https://bugs.webkit.org/show_bug.cgi?id=64443
3764
3765         Reviewed by Dimitri Glazkov.
3766
3767         We don't have any persistent butter bar messages yet, so the dismiss
3768         button is premature (and fairly heavy, visually).
3769
3770         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
3771         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3772
3773 2011-07-13  Adam Barth  <abarth@webkit.org>
3774
3775         Refine garden-o-matic status pane
3776         https://bugs.webkit.org/show_bug.cgi?id=64442
3777
3778         Reviewed by Dimitri Glazkov.
3779
3780         This patch makes two improvements to the status pane:
3781
3782         1) We only query the server for failure types that we're expecting.
3783            This dramatically reduces the number of HTTP requests, making
3784            loading the status pane faster.
3785
3786         2) The status pane now displays which test and which builder it is
3787            showing results for.
3788
3789         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
3790         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
3791         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
3792         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3793         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
3794         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
3795         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
3796
3797 2011-07-13  Adam Barth  <abarth@webkit.org>
3798
3799         garden-o-matic should show test results
3800         https://bugs.webkit.org/show_bug.cgi?id=64440
3801
3802         Reviewed by Adam Roben.
3803
3804         This patch introduces the results detail pane, which appears at the
3805         bottom of the window and contains test results from the bots.
3806         Currently, you can activate the pane by mousing over one of the builder
3807         names associated with a failing test.
3808
3809         This is just a first iteration of the UI.  There's no way to resize or
3810         zoom in on elements of the details pane, and images likely aren't sized
3811         correctly, but it's a place to start.
3812
3813         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
3814             - Add constants for our data attributes so we don't typo them!
3815         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
3816             - Add DOM structure for the details pane.
3817         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
3818         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3819             - Bind events for showing and hiding the details pane.
3820         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
3821             - Reduce the number of result types that we query for to avoid
3822               overfilling the details pane.  We'll probably need another
3823               solution here in the long-term.  For example, we could use tabs
3824               to pack more results into the pane.
3825         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
3826         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
3827             - Now that we're using the config package during testing, we need
3828               to include it in the testing HTML.
3829         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
3830         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
3831             - Change the DOM structure of the results detail to make it fit
3832               nicely in the details pane (rather than flowing freely in the
3833               body, as it did before).
3834
3835 2011-07-13  Adam Roben  <aroben@apple.com>
3836
3837         Make TestFailures show every time a possibly-flaky test failed, but hide it by default
3838
3839         It's useful to be able to see every time a flaky test failed to see whether it failed the
3840         same way every time. But doing so takes a lot of space, so the list of failures is now
3841         collapsed by default and can be revealed using a disclosure triangle.
3842
3843         Fixes <http://webkit.org/b/64455> TestFailures page doesn't show as much information for
3844         flaky tests as I would like, even though the page is already so long
3845
3846         Reviewed by Dimitri Glazkov.
3847
3848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
3849         (FlakyLayoutTestDetector.prototype.allFailures): Replaced flakinessExamples with this
3850         function. Now returns all failures for the given test.
3851
3852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
3853         Added. This just contains some simple tests of the FlakyLayoutTestDetector class. We'll add
3854         more over time.
3855
3856         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
3857         (LayoutTestHistoryAnalyzer.prototype.start): Updated the documentation comment to reflect
3858         that we no longer return passing builds for possibly-flaky tests.
3859
3860         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
3861         (.existing-bugs-list, .suspect-revisions-list, .flakiness-examples-list): Make the list of
3862         flakiness examples small, too, since it can get quite long.
3863
3864         (.disclosure-triangle):
3865         (.expanded > .disclosure-triangle):
3866         Simple styles for the disclosure triangle.
3867
3868         (.flakiness-examples-list): Collapse the list by default.
3869
3870         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3871         (ViewController.prototype._displayBuilder): Pass the total number of builds analyzed to
3872         _domForPossiblyFlakyTests.
3873         (ViewController.prototype._domForPossiblyFlakyTests): Put a disclosure triangle to the left
3874         of each test name, and the number of failures to the right. When the disclosure triangle is
3875         clicked for the first time, we build up the list of failures and expand the element. After
3876         that we just collapse or expand the element on subsequent clicks.
3877
3878         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3879         Pulled in new tests.
3880
3881 2011-07-13  Adam Roben  <aroben@apple.com>
3882
3883         Teach TestFailures to understand NRWT's output when it exits early due to too many failures
3884
3885         Fixes <http://webkit.org/b/64456> TestFailures page reports way too many failures when NRWT
3886         exits early
3887
3888         Reviewed by Dimitri Glazkov.
3889
3890         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3891         (Builder.prototype.getNumberOfFailingTests): Relaxed the "Exiting early" test not to require
3892         it to be at the beginning of the line, since NRWT prints a bunch of junk earlier in the
3893         line. Tightened up the regex that's used to parse the number of failing tests to require the
3894         leading number to be followed by whitespace so that we won't parse the "2011" in
3895         "2011-07-13" as a number of failures.
3896
3897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
3898         Added a test for the above.
3899
3900 2011-07-12  Dimitri Glazkov  <dglazkov@chromium.org>
3901
3902         Extract model-like TestExpectationLine and TestExpectationFile from TestExpectations.
3903         https://bugs.webkit.org/show_bug.cgi?id=64386
3904
3905         This is the first step in converting TestExpectations to a real model.
3906         * TestExpectationsLine represents a line in the test_expectations.txt file, and
3907         * TestExpectationsFile represents the file, which is a collection of lines.
3908
3909         Reviewed by Adam Barth.
3910
3911         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3912         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3913         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3914
3915 2011-07-13  Xan Lopez  <xlopez@igalia.com>
3916
3917         [GTK] Do not grab focus too early in DRT.
3918
3919         Reviewed by Gustavo Noronha.
3920
3921         It causes a layout to happen and a progress signal to be emitted
3922         since r90900, but at this point we don't have a
3923         LayoutTestController object and we'll eventually crash. Since we
3924         already grab focus at the beginning of runTest() this is
3925         redundant, so get rid of it to fix the crash.
3926
3927         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3928         (main): remove call to grab_focus
3929
3930 2011-07-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3931
3932         Unreviewed, rolling out r90893 and r90894.
3933         http://trac.webkit.org/changeset/90893
3934         http://trac.webkit.org/changeset/90894
3935         https://bugs.webkit.org/show_bug.cgi?id=64441
3936
3937         NRWT still doesn't work on qt-mac platform (Requested by Ossy
3938         on #webkit).
3939
3940         * Scripts/run-webkit-tests:
3941         (useNewRunWebKitTests):
3942
3943 2011-07-13  Csaba Osztrogonác  <ossy@webkit.org>
3944
3945         [Qt] NRWT should pick up the right httpd config file
3946         https://bugs.webkit.org/show_bug.cgi?id=64086
3947
3948         * Scripts/run-webkit-tests: Enable NRWT on qt-mac platform after r90810.
3949         (useNewRunWebKitTests):
3950
3951 2011-07-12  Mark Rowe  <mrowe@apple.com>
3952
3953         Fix the 32-bit build.
3954
3955         * DumpRenderTree/mac/UIDelegate.mm:
3956         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
3957         Cast the NSUInteger value to unsigned long to match the format specifier.
3958
3959 2011-07-12  Adam Barth  <abarth@webkit.org>
3960
3961         Improve garden-o-matic UI when the bots fail to report revision numbers
3962         https://bugs.webkit.org/show_bug.cgi?id=64427
3963
3964         Reviewed by Dimitri Glazkov.
3965
3966         At least Win (dbg)(2) seems to fail to report the SVN revision number
3967         in full_results.json.  This patch makes garden-o-matic more robust to
3968         missing revision numbers.
3969
3970         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3971         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
3972         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
3973         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
3974         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
3975
3976 2011-07-12  Adam Barth  <abarth@webkit.org>
3977
3978         Adjust garden-o-matic layout to use fewer lines
3979         https://bugs.webkit.org/show_bug.cgi?id=64422
3980
3981         Reviewed by Ojan Vafai.
3982
3983         This patch effectively merges the test name line with the list of
3984         builders on which the test fails.  Each test failure now occupies two
3985         lines instead of three.
3986
3987         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
3988         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3989         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
3990
3991 2011-07-12  Adam Barth  <abarth@webkit.org>
3992
3993         garden-o-matic should label tests failures of new tests as such
3994         https://bugs.webkit.org/show_bug.cgi?id=64421
3995
3996         Reviewed by Ojan Vafai.
3997
3998         Also, we shouldn't dim failures of new tests, even if we've only seen
3999         them once because they're likely to be real problems that need
4000         attention.
4001
4002         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
4003         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Added.
4004         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Added.
4005         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
4006         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
4007         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
4008         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
4009         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
4010         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
4011         * Scripts/webkitpy/tool/servers/gardeningserver.py:
4012
4013 2011-07-12  Adam Barth  <abarth@webkit.org>
4014
4015         garden-o-matic should display how many times we've seen a failure
4016         https://bugs.webkit.org/show_bug.cgi?id=64417
4017
4018         Reviewed by Ojan Vafai.
4019
4020         This patch adds some UI to display how many times we've seen a given
4021         failure, which can be helpful for determining whether that failure is a
4022         real failure or a flaky test.
4023
4024         When a failure has only been seen once (i.e., only a single run on a
4025         single bot), we set the opacity of to 50% to avoid distracting the
4026         gardener.
4027
4028         This patch also refactors the failure walker to have a simpler API
4029         internally by moving from an object-oriented paradigm to a functional
4030         paradigm.
4031
4032         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
4033         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
4034         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
4035         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
4036         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
4037         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
4038
4039 2011-07-12  Chris Rogers  <crogers@google.com>
4040
4041         Enable Web Audio for chromium DRT
4042         https://bugs.webkit.org/show_bug.cgi?id=64409
4043
4044         Reviewed by James Robinson.
4045
4046         * DumpRenderTree/chromium/TestShell.cpp:
4047         (TestShell::TestShell):
4048
4049 2011-07-12  Adam Barth  <abarth@webkit.org>
4050
4051         Tweak some UI in garden-o-matic now that the tree actually has a
4052         failure and I can see what this all looks like.
4053
4054         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
4055         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
4056         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
4057
4058 2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
4059
4060         Unreviewed. Skipping a few tests which fail due to differing output
4061         in recent ApplicationCache quota tests. Reenabling the tests is
4062         tracked by <http://webkit.org/b/64410>.
4063
4064         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4065         (WebCore::DumpRenderTree::dumpApplicationCacheQuota): This should
4066         have been a space, not a newline.
4067
4068 2011-07-12  Adam Barth  <abarth@webkit.org>
4069
4070         garden-o-matic should display regression ranges
4071         https://bugs.webkit.org/show_bug.cgi?id=64407
4072
4073         Reviewed by Dimitri Glazkov.
4074
4075         This patch computes a regression range for a failure by intersecting
4076         the regression ranges seen by the various bots.  We make the underlying
4077         assumption that a test is only failing due to one revision at any given
4078         moment.  If that's not true, this code probably explodes.
4079
4080         The regression ranges appear asynchronously, which might be a jarring
4081         UI.  We'll have to experiment to see.
4082
4083         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
4084         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
4085         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
4086         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
4087         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
4088         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
4089         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
4090
4091 2011-07-12  Adam Barth  <abarth@webkit.org>
4092
4093         cr-linux-ews should run pixel tests
4094         https://bugs.webkit.org/show_bug.cgi?id=64394
4095
4096         Reviewed by Ojan Vafai.
4097
4098         This patch enabled pixel test on the cr-linux-ews.  Running a quick
4099         test on the bots, it looks like we have five pixel failures, related to
4100         some missing fonts.  I've also made the bots skip failing tests to
4101         avoid uploading huge zip files to bugs.webkit.org (with all the exected
4102         IMAGE failures).
4103
4104         * Scripts/webkitpy/common/config/ports.py:
4105         * Scripts/webkitpy/common/config/ports_unittest.py:
4106
4107 2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
4108
4109         ApplicationCache update should not immediately fail when reaching per-origin quota
4110         https://bugs.webkit.org/show_bug.cgi?id=64177
4111
4112         Reviewed by Alexey Proskuryakov.
4113
4114         Add layoutTestController.disallowIncreaseForApplicationCacheQuota()
4115         to disable the default behavior of raising the default per-origin
4116         quota to 5MB when reached. This allows us to test what happens
4117         when the quota is reached and not increased.
4118
4119         * DumpRenderTree/LayoutTestController.cpp:
4120         (LayoutTestController::LayoutTestController):
4121         (disallowIncreaseForApplicationCacheQuotaCallback):
4122         (LayoutTestController::staticFunctions):
4123         * DumpRenderTree/LayoutTestController.h:
4124         (LayoutTestController::disallowIncreaseForApplicationCacheQuota):
4125         (LayoutTestController::setDisallowIncreaseForApplicationCacheQuota):
4126         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4127         (LayoutTestController::reset):
4128         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4129         (LayoutTestController::disallowIncreaseForApplicationCacheQuota):
4130         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
4131         Expose a function to prevent automatically increasing the per-origin
4132         quota when the quota is reached. This allows us to test what happens
4133         when a user would "disallow" a quota increase.
4134
4135         * DumpRenderTree/mac/UIDelegate.mm:
4136         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
4137         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4138         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
4139         Respect the new disallowIncrease flag and dump the spaceNeeded values
4140         for ports that implement application cache quotas.
4141
4142 2011-07-12  Ojan Vafai  <ojan@chromium.org>
4143
4144         fix flakiness dashboard to work with new crash log filenames
4145         https://bugs.webkit.org/show_bug.cgi?id=64393
4146
4147         Reviewed by Adam Barth.
4148
4149         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4150
4151 2011-07-12  Adam Barth  <abarth@webkit.org>
4152
4153         Add a happy animation to garden-o-matic when there are no failures
4154         https://bugs.webkit.org/show_bug.cgi?id=64382
4155
4156         Reviewed by Ojan Vafai.
4157
4158         As requested by Ojan.
4159
4160         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
4161         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
4162         * Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Added.
4163         * Scripts/webkitpy/tool/servers/gardeningserver.py:
4164
4165 2011-07-12  Adam Barth  <abarth@webkit.org>
4166
4167         sheriffbot can't perform rollouts
4168         https://bugs.webkit.org/show_bug.cgi?id=64370
4169
4170         Reviewed by Eric Seidel.
4171
4172         Now that we're not updating the working copy before processing every
4173         IRC message, the rollout command needs to update it manually.
4174
4175         * Scripts/webkitpy/tool/bot/irc_command.py:
4176         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4177
4178 2011-07-12  Adam Barth  <abarth@webkit.org>
4179
4180         Fix the grammar in the FIXME comment.
4181
4182         * Scripts/webkitpy/common/net/resultsjsonparser.py:
4183
4184 2011-07-12  Eric Seidel  <eric@webkit.org>
4185
4186         NRWT should open test results page with Safari trunk, not the system provided one on Mac
4187         https://bugs.webkit.org/show_bug.cgi?id=64346
4188
4189         Reviewed by Adam Barth.
4190
4191         To fix this I implemented Port.show_results_html_file in Mac, Gtk and Qt ports with
4192         implementations (mostly) matching those found in old-run-webkit-tests.
4193         There are still some minor differences for Qt which Qt hackers may wish to tweak.
4194
4195         I had to add a WebKitPort._port_flag_for_scripts method (similar to flag() in common.config.ports.py)
4196         for the Qt/Gtk ports which always require a flag passed to scripts.
4197
4198         While trying to test this, I found that FactoryTest.test_chromium_gpu_linux
4199         was using a real filesystem (due to assert_platform) which due to
4200         global variables in config.py was causing set-webkit-configuration to have
4201         an affect on unit test results!  So I fixed this by making FactoryTest.assert_port
4202         pass a mock file system whenever calling factory.get.
4203
4204         Unfortunately TestPort was depending on always being passed a None filesystem
4205         and asserting filesystem._tests (only true for unit_test_filesystem()).
4206         So I just removed the FactoryTest.test_test and FactoryTest.test_dryrun tests
4207         deciding that they were pretty much useless anyway.  If others feel strongly
4208         I'm happy to fix this in a different way.
4209
4210         * Scripts/webkitpy/common/system/executive.py:
4211          - default arguments in python are screwy.  They use a single shared
4212            instance, so it's better to use argument=None and then argument = argument or Default()
4213            if you have any chance of mutating (or returning) the default argument.
4214         * Scripts/webkitpy/layout_tests/port/config.py:
4215          - This code is wrong.  We don't need to use a global variable here (as far as I can tell).
4216            I'm not fixing it in this patch, but I've marked it with a FIXME and we can convert to
4217            storing the results of the read on the Config object (which should only be created once during normal operation).
4218            Unit tests shouldn't be hitting the disk anyway.  It's possible Config should move off of Port and onto Tool/Host directly.
4219         * Scripts/webkitpy/layout_tests/port/factory.py:
4220         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4221         * Scripts/webkitpy/layout_tests/port/gtk.py:
4222         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Added.
4223         * Scripts/webkitpy/layout_tests/port/mac.py:
4224         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4225         * Scripts/webkitpy/layout_tests/port/qt.py:
4226         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4227         * Scripts/webkitpy/layout_tests/port/webkit.py:
4228
4229 2011-07-12  Adam Roben  <aroben@apple.com>
4230
4231         Teach TestFailures to recognize when run-webkit-tests gets killed by buildbot
4232
4233         Fixes <http://webkit.org/b/64358> TestFailures page thinks all tests passed in
4234         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14672
4235
4236         Reviewed by Daniel Bates.
4237
4238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
4239         (Builder.prototype.getNumberOfFailingTests): If run-webkit-tests exited with a non-zero
4240         exit status but we didn't find any failure counts, assume that there was some error that
4241         caused run-webkit-tests to die early (like being killed by buildbot due to a timeout).