6f1ee1b321e2abc12f92990b8e0cc5873db3e315
[WebKit-https.git] / Tools / ChangeLog
1 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         Fix options in build-jsc for CMake builds
4         https://bugs.webkit.org/show_bug.cgi?id=145636
5
6         Reviewed by Gyuyoung Kim.
7
8         CMake only accepts -DXXX=YYY style options.
9         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
10
11         * Scripts/build-jsc:
12
13 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
14
15         Added a patch so that the colors displayed on the page could be toggled
16         in case people need accessibility colors displayed in their browser.
17         https://bugs.webkit.org/show_bug.cgi?id=145570
18         <rdar://problem/20994468>
19
20         Added in CSS colors and toggle buttons for checkmarks in the page, so that
21         the page could be rendered in a specific way for accessibility needs if needed.
22
23         Reviewed by Alexey Proskuryakov.
24
25         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
26         (updateHiddenPlatforms):
27         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
28         (toggleAccessibilityColors): Toggle colors on and off
29         (documentReady): Needed to make changes to the initialization
30         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
31         (a:hover):
32         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
33         (div.cellButton.hide, div.accessibilityButton.hide):
34         (div.cellButton.unhide, div.accessibilityButton.unhide):
35         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
36         (.popover-tracking:hover):
37         (.accessibilityButton):
38         (div.cellButton): Deleted.
39         (div.cellButton.hide): Deleted.
40         (div.cellButton.unhide): Deleted.
41         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
42         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
43         (.status-line.neutral .bubble):
44         (.status-line.unauthorized .bubble):
45         (.status-line.danger .bubble.pictogram):
46         (.status-line.bad .bubble.pictogram):
47         (.status-line.no-bubble .message):
48         (.status-line.bad .bubble):
49         (.status-line.good .bubble):
50         (.status-line.good .message):
51         (.status-line.bad .message):
52         (body.accessibility-colors .status-line.good .bubble):
53         (body.accessibility-colors .status-line.bad .bubble):
54         (body.accessibility-colors .status-line.good .message):
55         (body.accessibility-colors .status-line.bad .message):
56         (.status-line.danger .message):
57         (.status-line.unauthorized .message):
58
59 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
60
61         Unreviewed build fix for Dromaeo.
62
63         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
64         (BenchmarkResults._aggregate_results_for_test):
65
66 2015-06-03  Anders Carlsson  <andersca@apple.com>
67
68         Fix build.
69
70         * DumpRenderTree/mac/TestRunnerMac.mm:
71
72 2015-06-03  Daniel Bates  <dabates@apple.com>
73
74         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
75         https://bugs.webkit.org/show_bug.cgi?id=145616
76
77         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
78         of the test. Further investigation is needed.
79
80         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
81         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
82
83 2015-06-03  Brady Eidson  <beidson@apple.com>
84
85         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
86         https://bugs.webkit.org/show_bug.cgi?id=145580
87
88         Reviewed by Mark Lam.
89
90         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
91         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
92
93 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
94
95         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
96
97         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
98         (TestWebKitAPI::TEST): Update the syntax.
99
100 2015-06-02  Mark Lam  <mark.lam@apple.com>
101
102         build-jsc's --cloop option is broken.
103         https://bugs.webkit.org/show_bug.cgi?id=145516
104
105         Reviewed by Darin Adler.
106
107         * Scripts/build-jsc:
108         - Make sure to disable the JIT when --cloop is specified.
109           Did analogous fix for --ftljit.
110
111 2015-06-02  Daniel Bates  <dabates@apple.com>
112
113         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
114
115         Rubber-stamped by Alexey Proskuryakov.
116
117         * MiniBrowser/mac/Info.plist:
118         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
119
120 2015-06-01  Commit Queue  <commit-queue@webkit.org>
121
122         Unreviewed, rolling out r185066.
123         https://bugs.webkit.org/show_bug.cgi?id=145543
124
125         it breaks the FTL JIT builds with a local checkout of llvm
126         (Requested by pizlo on #webkit).
127
128         Reverted changeset:
129
130         "build-jsc's --cloop option is broken."
131         https://bugs.webkit.org/show_bug.cgi?id=145516
132         http://trac.webkit.org/changeset/185066
133
134 2015-06-01  Daniel Bates  <dabates@apple.com>
135
136         Notify client that we began editing when text field is focused
137         https://bugs.webkit.org/show_bug.cgi?id=145439
138         <rdar://problem/21142108>
139
140         Reviewed by Anders Carlsson.
141
142         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
143         a text field is focused and defocused.
144
145         * TestWebKitAPI/CMakeLists.txt:
146         * TestWebKitAPI/PlatformEfl.cmake:
147         * TestWebKitAPI/PlatformGTK.cmake:
148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
149         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
150         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
151         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
152         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
153         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
154         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
155         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
156         (TestWebKitAPI::TEST_F):
157         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
158         (TestWebKitAPI::textFieldDidBeginEditing):
159         (TestWebKitAPI::textFieldDidEndEditing):
160         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
161         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
162         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
163
164 2015-06-01  Alex Christensen  <achristensen@webkit.org>
165
166         [Content Extensions] resource-type and load-type should be independent.
167         https://bugs.webkit.org/show_bug.cgi?id=145528
168         rdar://problem/21190765
169
170         Reviewed by Benjamin Poulain.
171
172         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
173         (TestWebKitAPI::TEST_F):
174
175 2015-06-01  Daniel Bates  <dabates@apple.com>
176
177         Add ATS keys to WebKitTestRunnerApp
178         https://bugs.webkit.org/show_bug.cgi?id=145519
179
180         Reviewed by Alexey Proskuryakov.
181
182         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
183
184         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
185
186 2015-06-01  Brady Eidson  <beidson@apple.com>
187
188         Add WKTR support for "should open external URLs".
189         https://bugs.webkit.org/show_bug.cgi?id=145505
190
191         Reviewed by Darin Adler.
192
193         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
194           "should open external URLs" bit set.
195         
196         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
197           the policy delegate, including whether or not the bit was set.
198         
199         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
200         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
201         (WTR::TestRunner::queueLoad):
202         * WebKitTestRunner/InjectedBundle/TestRunner.h:
203         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
204         (WTR::TestRunner::shouldDumpPolicyCallbacks):
205         
206         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
207         (WTR::InjectedBundle::queueLoad):
208         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
209
210         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
211         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
212
213         * WebKitTestRunner/TestInvocation.cpp:
214         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
215
216         * WebKitTestRunner/WorkQueueManager.cpp:
217         (WTR::WorkQueueManager::queueLoad):
218         * WebKitTestRunner/WorkQueueManager.h:
219
220 2015-06-01  Mark Lam  <mark.lam@apple.com>
221
222         build-jsc's --cloop option is broken.
223         https://bugs.webkit.org/show_bug.cgi?id=145516
224
225         Reviewed by Darin Adler.
226
227         * Scripts/build-jsc:
228         - Make sure to disable the JIT when --cloop is specified.
229           Did analogous fix for --ftljit.
230
231 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
232
233         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
234         https://bugs.webkit.org/show_bug.cgi?id=144959
235
236         Reviewed by Darin Adler.
237
238         * Scripts/webkitpy/style/checkers/cmake.py:
239         (CMakeChecker.check): Use enumerate instead of xrange.
240         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
241         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
242         (CMakeCheckerTest.test_check): Update the expected results.
243
244 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
245
246         Fix the webkitpy scm unittests after r174051
247         https://bugs.webkit.org/show_bug.cgi?id=145511
248
249         Reviewed by Darin Adler.
250
251         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
252         (GitTestWithMock.make_scm):
253
254 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
255
256         EWS provides misleading information for not applyable patches
257         https://bugs.webkit.org/show_bug.cgi?id=145307
258
259         Reviewed by Alexey Proskuryakov.
260
261         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
262
263 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
264
265         Further tweak results of WebKit1.StringTruncator after r184965.
266
267         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
268
269 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
270
271         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
272         https://bugs.webkit.org/show_bug.cgi?id=145264
273
274         Reviewed by Carlos Garcia Campos.
275
276         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
277
278 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
279
280         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
281
282         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
283         (BenchmarkResults._lint_subtest_results):
284         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
285         (test_aggregate_nested_results):
286         (test_lint_results):
287         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
288
289 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
290
291         run-benchmark should print out the results
292         https://bugs.webkit.org/show_bug.cgi?id=145398
293
294         Reviewed by Antti Koivisto.
295
296         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
297         of the output to catch early errors.
298
299         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
300         (BenchmarkResults): Added.
301         (BenchmarkResults.__init__): Added.
302         (BenchmarkResults.format): Added.
303         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
304         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
305         Uses the sample standard deviation to compute the significant figures for the value.
306         (BenchmarkResults._unit_from_metric): Added.
307         (BenchmarkResults._aggregate_results): Added.
308         (BenchmarkResults._aggregate_results_for_test): Added.
309         (BenchmarkResults._flatten_list): Added.
310         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
311         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
312         (BenchmarkResults._aggregate_values): Added.
313         (BenchmarkResults._lint_results): Added.
314         (BenchmarkResults._lint_subtest_results): Added.
315         (BenchmarkResults._lint_aggregator_list): Added.
316         (BenchmarkResults._lint_configuration): Added.
317         (BenchmarkResults._lint_values): Added.
318         (BenchmarkResults._is_numeric): Added.
319         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
320         (BenchmarkResultsTest):
321         (BenchmarkResultsTest.test_init):
322         (BenchmarkResultsTest.test_format):
323         (test_format_values_with_large_error):
324         (test_format_values_with_small_error):
325         (test_format_values_with_time):
326         (test_format_values_with_no_error):
327         (test_format_values_with_small_difference):
328         (test_aggregate_results):
329         (test_aggregate_results_with_gropus):
330         (test_aggregate_nested_results):
331         (test_lint_results):
332         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
333         (BenchmarkRunner.execute): Added a call to show_results
334         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
335         (BenchmarkRunner.show_results): Added.
336
337 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
338
339         run_benchmark should have an option to specify the number of runs
340         https://bugs.webkit.org/show_bug.cgi?id=145091
341
342         Reviewed by Antti Koivisto.
343
344         Added --count option.
345
346         * Scripts/run-benchmark:
347         (main):
348         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
349         (BenchmarkRunner.__init__):
350
351 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
352
353         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
354
355         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
356
357 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
358
359         Update results of WebKit1.StringTruncator after r184965.
360
361         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
362
363 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
364
365         Unreviewed, updated my list of email addresses.
366
367         * Scripts/webkitpy/common/config/contributors.json:
368
369 2015-05-27  Dean Jackson  <dino@apple.com>
370
371         img.currentSrc problem in strict mode with old picturefill
372         https://bugs.webkit.org/show_bug.cgi?id=144095
373         <rdar://problem/21087013>
374
375         Reviewed by Simon Fraser.
376
377         Add a PICTURE_SIZES flag.
378
379         * Scripts/webkitperl/FeatureList.pm:
380
381 2015-05-26  Dana Burkart  <dburkart@apple.com>
382
383         Fixes compatibility issues with recent dashboard cleanup.
384         https://bugs.webkit.org/show_bug.cgi?id=144814
385
386         Reviewed by Alexey Proskuryakov.
387
388         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
389         (BuildbotStaticAnalyzerQueueView):
390         (BuildbotStaticAnalyzerQueueView.prototype.update):
391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
392         (documentReady):
393
394 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
395
396         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
397         https://bugs.webkit.org/show_bug.cgi?id=143091
398         rdar://problem/19330328
399
400         Reviewed by Darin Adler and Timothy Hatcher.
401
402         We have many of these, which are hard to fit on the dashboard. Added a view that
403         collapses to a single green bubble when everything is good, and expands when there
404         are failures (or manually).
405
406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
407
408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
409         (Buildbot.prototype.set isAuthenticated):
410         (Buildbot.prototype._normalizeQueueInfo):
411         (Buildbot.prototype._normalizeQueuesInfo):
412         (Buildbot.prototype.updateQueues):
413         Moved queue info normalization here from BuildbitQueue. The latter is a model class
414         that shouldn't have to know about presentation, and this lets us leep the knowledge
415         about combined queues out if it. Later, we can refactor existing code, and move out
416         all knowledge about headings and such.
417
418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
419         Added the new view. It's not quite universal, and doesn't have as helpful popovers
420         as other views, but we can extend it when/if we use it for more than JSC.
421
422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
423         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
424
425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
426         (documentReady): Added support for combined queues. These are currently always ending up
427         in Other column, but it's easy to customize in the future if we need to.
428
429         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
430         (WebKitBuildbot): Added JSC queus.
431
432         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
433         (.combined-queue-popover):
434         (.combined-queue-popover .revision):
435         Added styles for the combined view.
436
437 2015-05-26  Dan Bernstein  <mitz@apple.com>
438
439         Changed a file to use Unix line endings.
440
441         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
442
443 2015-05-26  Dan Bernstein  <mitz@apple.com>
444
445         <rdar://problem/21104551> Update build settings
446
447         Reviewed by Anders Carlsson.
448
449         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
450         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
451         * MiniBrowser/Configurations/DebugRelease.xcconfig:
452         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
453         * WebEditingTester/Configurations/DebugRelease.xcconfig:
454         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
455         * asan/asan.xcconfig:
456
457 2015-05-26  Anders Carlsson  <andersca@apple.com>
458
459         Fix build.
460
461         * WebKitTestRunner/mac/EventSenderProxy.mm:
462         (WTR::EventSenderProxy::mouseForceDown):
463         (WTR::EventSenderProxy::mouseForceUp):
464         (WTR::EventSenderProxy::mouseForceChanged):
465
466 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
467
468         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
469         https://bugs.webkit.org/show_bug.cgi?id=145342
470
471         Reviewed by Darin Adler.
472
473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
474         (BuildbotIteration.prototype._parseData):
475
476 2015-05-26  Milan Crha  <mcrha@redhat.com>
477
478         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
479         https://bugs.webkit.org/show_bug.cgi?id=138134
480
481         Reviewed by Žan Doberšek.
482
483         * gtk/generate-inspector-gresource-manifest.py:
484         (get_filenames): Command line with expanded resources exceeds 32KB, which
485         is a limit on Windows. It's better to expand wildcards inside the python script.
486
487 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
488
489         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
490         https://bugs.webkit.org/show_bug.cgi?id=140882
491
492         Reviewed by Gustavo Noronha Silva.
493
494         Make sure unit tests write IndexedDB databases to the temporary
495         directory, and add a test case to check that the directory is
496         correctly created at the expected path.
497
498         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
499         (testWebContextConfiguration):
500         (serverCallback):
501         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
502         (Test::Test):
503
504 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
505
506         [GTK] Enable IndexedDB
507         https://bugs.webkit.org/show_bug.cgi?id=98932
508
509         Reviewed by Žan Doberšek.
510
511         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
512
513 2015-05-24  Sam Weinig  <sam@webkit.org>
514
515         Crash when using a removed ScriptMessageHandler
516         <rdar://problem/20888499>
517         https://bugs.webkit.org/show_bug.cgi?id=145359
518
519         Reviewed by Dan Bernstein.
520
521         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
522         Add tests for removing script message handlers.
523
524 2015-05-23  Dan Bernstein  <mitz@apple.com>
525
526         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
527         https://bugs.webkit.org/show_bug.cgi?id=145345
528
529         Reviewed by Sam Weinig.
530
531         * DumpRenderTree/mac/Configurations/Base.xcconfig:
532         * LayoutTestRelay/Configurations/Base.xcconfig:
533         * TestWebKitAPI/Configurations/Base.xcconfig:
534         * WebKitTestRunner/Configurations/Base.xcconfig:
535
536 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
537
538         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
539         https://bugs.webkit.org/show_bug.cgi?id=144848
540
541         Reviewed by Darin Adler.
542
543         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
544
545         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
546
547 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
548
549         Fix one more merge error in static analyzer support.
550
551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
552         (BuildbotStaticAnalyzerQueueView):
553
554 2015-05-22  Dana Burkart  <dburkart@apple.com>
555
556         Fix internal dashboard breakage from recent commit.
557         https://bugs.webkit.org/show_bug.cgi?id=144814
558
559         Unreviewed build fix.
560
561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
562         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
563         (BuildbotStaticAnalyzerQueueView.prototype.update):
564
565 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
566
567         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
568         https://bugs.webkit.org/show_bug.cgi?id=130463
569         rdar://problem/20461342
570
571         Reviewed by Tim Horton.
572
573         This was more of a timing related flakiness than an actual OS version specific bug,
574         we weren't getting window visibility notifications.
575         
576         I will look into adding this function call to DumpRenderTree separately, layout tests
577         might actually rely on the broken behavior.
578
579         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
580         (TestWebKitAPI::TEST_F):
581         * TestWebKitAPI/mac/mainMac.mm:
582         (main):
583
584 2015-05-22  Dana Burkart  <dburkart@apple.com>
585
586         Add missing file from r184804 (mis-applied diff).
587         https://bugs.webkit.org/show_bug.cgi?id=144814
588
589         Reviewed by Alexey Proskuryakov.
590
591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
592         (BuildbotStaticAnalyzerQueueView):
593         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
594         (BuildbotStaticAnalyzerQueueView.prototype.update):
595
596 2015-05-22  Dana Burkart  <dburkart@apple.com>
597
598         Add support to the botwatchers dashboard for a static analyzer bot.
599         https://bugs.webkit.org/show_bug.cgi?id=144814
600
601         Reviewed by Alexey Proskuryakov.
602
603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
604         scan-build should be considered a productive step.
605
606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
607         (BuildbotQueue):
608         Adds support for the staticAnalyzer property
609
610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
611         (BuildbotTestResults.prototype._parseResults):
612         Get bug count from the scan-build step output
613
614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
615         (documentReady):
616         Rename the performance column 'Other', and merge the current 'Other' column with it.
617
618         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
619         (WebKitBuildbot):
620         Now that performance bots are part of the 'Other' column, give them better headings.
621
622 2015-05-22  Tim Horton  <timothy_horton@apple.com>
623
624         Turn on autosaving of toolbar configuration in MiniBrowser
625
626         Rubber-stamped by Dan Bernstein.
627
628         * MiniBrowser/mac/BrowserWindow.xib:
629
630 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
631
632         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
633         https://bugs.webkit.org/show_bug.cgi?id=145297
634
635         Reviewed by Tim Horton.
636
637         This is a refactoring to simplify code, and to make it more logical.
638
639         It is up to the view to decide how to present the queues, and whether to split
640         them into debug and release, or in some different way.
641
642         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
643         (BuildbotBuilderQueueView.filterQueues):
644         (BuildbotBuilderQueueView):
645         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
646         (BuildbotLeaksQueueView):
647         (BuildbotLeaksQueueView.prototype.update):
648         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
649         (BuildbotPerformanceQueueView):
650         (BuildbotPerformanceQueueView.prototype.update):
651         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
652         (BuildbotQueueView):
653         (BuildbotQueueView.prototype._updateQueues):
654         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
655         (BuildbotTesterQueueView):
656         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
657         (documentReady):
658
659 2015-05-22  Tim Horton  <timothy_horton@apple.com>
660
661         Remove action menu support
662         https://bugs.webkit.org/show_bug.cgi?id=145305
663         <rdar://problem/21070771>
664
665         Reviewed by Anders Carlsson.
666
667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
668         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
669         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
670         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
671         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
672         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
673         Remove the tests.
674
675 2015-05-22  Dan Bernstein  <mitz@apple.com>
676
677         Removed the Use Shrink To Fit button from the toolbar’s default set.
678
679         Rubber-stamped by Tim Horton.
680
681         * MiniBrowser/mac/BrowserWindow.xib:
682
683 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
684
685         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
686         https://bugs.webkit.org/show_bug.cgi?id=128420
687
688         Reviewed by Chris Fleizach.
689
690         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
691         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
692
693 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
694
695         [EFL] Bump libsoup version to 2.50.0
696         https://bugs.webkit.org/show_bug.cgi?id=145127
697
698         Reviewed by Gyuyoung Kim.
699
700         * efl/jhbuild.modules:
701         * efl/patches/soup-clang-warning-fix1.patch: Removed.
702         * efl/patches/soup-clang-warning-fix2.patch: Removed.
703
704 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
705
706         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
707         https://bugs.webkit.org/show_bug.cgi?id=145117
708
709         Reviewed by Csaba Osztrogonác.
710
711         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
712         Tools/TestWebKitAPI/Tests/WTF/glib/.
713
714         * TestWebKitAPI/PlatformGTK.cmake:
715         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
716         (TestWebKitAPI::TEST):
717
718 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
719
720         [EFL] fix efreet error
721         https://bugs.webkit.org/show_bug.cgi?id=143670
722
723         Reviewed by Gyuyoung Kim.
724
725         Fix efreet error by using external variable efreet_cache_update.
726         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
727         efreet error for efreet_cache does not occur.
728
729         * MiniBrowser/efl/main.c:
730         (elm_main):
731
732 2015-05-20  Michael Saboff  <msaboff@apple.com>
733
734         Add option to run_jsc_stress_tests to disable JIT testing
735         https://bugs.webkit.org/show_bug.cgi?id=145233
736
737         Reviewed by Mark Lam.
738
739         Added --no-jit option.
740
741         * Scripts/run-jsc-stress-tests:
742
743 2015-05-20  Alex Christensen  <achristensen@webkit.org>
744
745         Use correct String for StringView in WTF API tests
746         https://bugs.webkit.org/show_bug.cgi?id=145226
747         rdar://problem/20361786
748
749         Reviewed by Benjamin Poulain.
750
751         * TestWebKitAPI/Tests/WTF/StringView.cpp:
752         (TestWebKitAPI::TEST):
753         Use patternHolder for pattern.
754
755 2015-05-20  Alex Christensen  <achristensen@webkit.org>
756
757         [Content Extensions] Relax restrictions on triggers that match everything.
758         https://bugs.webkit.org/show_bug.cgi?id=145069
759
760         Reviewed by Benjamin Poulain.
761
762         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
763         (TestWebKitAPI::TEST_F):
764         Update and add tests for new possibilities with .*
765
766 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
767
768         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
769         https://bugs.webkit.org/show_bug.cgi?id=144992
770
771         Reviewed by Gyuyoung Kim.
772
773         * MiniBrowser/efl/main.c:
774         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
775         (on_key_down):
776         (on_fullscreen_enter):
777         (on_fullscreen_exit):
778         (window_create):
779
780 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
781
782         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
783         https://bugs.webkit.org/show_bug.cgi?id=145109
784
785         Reviewed by Darin Adler.
786
787         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
788         (TestWebKitAPI::TEST):
789
790 2015-05-19  Anders Carlsson  <andersca@apple.com>
791
792         Add alternate menu items for performing operations on the default data store
793         https://bugs.webkit.org/show_bug.cgi?id=145184
794
795         Reviewed by Sam Weinig.
796
797         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
798         associated with a data store.
799
800         * MiniBrowser/mac/AppDelegate.m:
801         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
802         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
803         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
804         * MiniBrowser/mac/MainMenu.xib:
805
806 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
807
808         Fix tautological-compare warning in AtomicString.cpp
809         https://bugs.webkit.org/show_bug.cgi?id=145120
810
811         Reviewed by Alexey Proskuryakov.
812
813         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
814         (TestWebKitAPI::TEST): Removed always true assert.
815
816 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
817
818         [EFL] Fix unsequenced warning in MiniBrowser's main.c
819         https://bugs.webkit.org/show_bug.cgi?id=145123
820
821         Reviewed by Gyuyoung Kim.
822
823         * MiniBrowser/efl/main.c:
824         (on_key_down):
825
826 2015-05-18  Daniel Bates  <dabates@apple.com>
827
828         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
829         when staged non-empty file for commit
830         https://bugs.webkit.org/show_bug.cgi?id=145082
831
832         Reviewed by Darin Adler.
833
834         Fixes two issues when running prepare-ChangeLog:
835             1. The function above a deleted function is reported as changed.
836             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
837             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
838             included in this patch).
839
840         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
841         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
842         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
843         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
844         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
845         VCSUtil::parseChunkRange() has existing test coverage.
846
847         * Scripts/prepare-ChangeLog:
848         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
849         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
850         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
851         examine files that only have deletions. Currently this works as a side effect of the behavior of
852         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
853         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
854         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
855         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
856         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
857         We return (-1, -1) when the change represents a deletion.
858         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
859         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
860         We return (-1, -1) when the change represents an addition.
861         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
862         unit tests.
863
864 2015-05-18  Anders Carlsson  <andersca@apple.com>
865
866         Add ATS keys to MiniBrowser
867         https://bugs.webkit.org/show_bug.cgi?id=145141
868
869         Reviewed by Sam Weinig.
870
871         * MiniBrowser/mac/Info.plist:
872
873 2015-05-17  David Kilzer  <ddkilzer@apple.com>
874
875         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
876         <http://webkit.org/b/145100>
877
878         Reviewed by Darin Adler.
879
880         * Scripts/bisect-builds:
881         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
882         - Switch to using PROMPT_RESPONSE_* constants when testing the
883           value of $didReproduceBug.
884         - Add do { } while loops to implement 'retry' mode.
885         (promptForTest):
886         - Switch to returning PROMPT_RESPONSE_* constants.
887         - Add support for 'retry' response.
888
889 2015-05-16  Tanay C  <tanay.c@samsung.com>
890
891         [EFL][WK2] Minibrowser : Add search icon to search bar
892         https://bugs.webkit.org/show_bug.cgi?id=139773
893
894         Reviewed by Gyuyoung Kim.
895
896         * MiniBrowser/efl/main.c: 
897         (search_icon_show): Added.
898         (search_box_show): Modified.
899
900 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
901
902         run_benchmark should have an option to specify the number of runs
903         https://bugs.webkit.org/show_bug.cgi?id=145091
904
905         Reviewed by Stephanie Lewis.
906
907         Added --count option.
908
909         * Scripts/run-benchmark:
910         (main):
911         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
912         (BenchmarkRunner.__init__):
913
914 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
915
916         Temporarily disable failing API test.
917
918         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
919         (TestWebKitAPI::TEST):
920
921 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
922
923         User interruption while running of run-webkit-tests should also generate results.html
924         https://bugs.webkit.org/show_bug.cgi?id=122154
925
926         Reviewed by Csaba Osztrogonác.
927
928         Generation of results.html on execution of run-webkit-tests happens only
929         on completion of entire layout tests run. It should be created even when
930         the execution has been interrupted - either by user (by pressing Ctrl+C)
931         or because of other interruptions (like exit-after-n-failures option).
932
933         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
934         (LayoutTestRunner.run_tests):
935         * Scripts/webkitpy/layout_tests/controllers/manager.py:
936         (Manager.run):
937         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
938         (TestRunResults.__init__):
939         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
940         (main):
941         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
942         (RunTest.test_keyboard_interrupt):
943         (MainTest.test_exception_handling):
944
945 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
946
947         [buildbot] Fix the URL of the performance bots
948         https://bugs.webkit.org/show_bug.cgi?id=145043
949
950         Reviewed by Ryosuke Niwa.
951
952         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
953
954 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
955
956         Add a layout mode that scales down the view to try to fit the document
957         https://bugs.webkit.org/show_bug.cgi?id=145022
958         <rdar://problem/19790341>
959
960         Reviewed by Dean Jackson.
961
962         * MiniBrowser/mac/BrowserWindow.xib:
963         * MiniBrowser/mac/BrowserWindowController.h:
964         * MiniBrowser/mac/WK2BrowserWindowController.m:
965         (-[WK2BrowserWindowController toggleShrinkToFit:]):
966         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
967         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
968
969 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
970
971         [CMake] Don't read the LOCATION property of targets
972         https://bugs.webkit.org/show_bug.cgi?id=145018
973
974         Reviewed by Martin Robinson.
975
976         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
977         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
978         be the same at configure-time as it is at generate-time.
979
980         * TestWebKitAPI/CMakeLists.txt:
981
982 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
983
984         Add String literal overloads to equalIgnoringASCIICase()
985         https://bugs.webkit.org/show_bug.cgi?id=145008
986
987         Reviewed by Benjamin Poulain.
988
989         Test changes to WTF.
990
991         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
992         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
993         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
994         * TestWebKitAPI/Tests/WTF/StringView.cpp:
995         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
996         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
997
998 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
999
1000         SharedBuffer::createWithContentsOfFile should use map file routines
1001         https://bugs.webkit.org/show_bug.cgi?id=144192
1002
1003         Reviewed by Darin Adler.
1004
1005         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
1006
1007         * TestWebKitAPI/PlatformGTK.cmake:
1008         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1009         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
1010         (TestWebKitAPI::FileSystemTest::tempFilePath):
1011         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
1012         (TestWebKitAPI::TEST_F):
1013         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
1014         (TestWebKitAPI::SharedBufferTest::tempFilePath):
1015         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
1016         (TestWebKitAPI::TEST_F):
1017
1018 2015-05-13  Alex Christensen  <achristensen@webkit.org>
1019
1020         [Content Extensions] Test interactions between multiple extensions and multiple domains.
1021         https://bugs.webkit.org/show_bug.cgi?id=144967
1022
1023         Reviewed by Benjamin Poulain.
1024
1025         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1026         Xcode wanted to fix an alphabetization issue.
1027         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1028         (TestWebKitAPI::TEST_F):
1029         Test interactions that worked but were not explicitly tested before.
1030
1031 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1032
1033         Unreviewed build fix.
1034
1035         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
1036
1037         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
1038
1039 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1040
1041         Fix the previous commit, which made both bubbles green.
1042
1043         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1044         (.status-line.good .bubble):
1045         (.status-line.bad .bubble):
1046         (.status-line.good .message):
1047
1048 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1049
1050         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
1051         https://bugs.webkit.org/show_bug.cgi?id=144929
1052
1053         Reviewed by Eric Carlson.
1054
1055         Tweaked colors as I see fit.
1056
1057         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1058         (.status-line.good .bubble):
1059         (.status-line.bad .bubble):
1060
1061 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
1062
1063         [Mac] Share cookie storage between UI process and secondary processes
1064         https://bugs.webkit.org/show_bug.cgi?id=144820
1065         rdar://problem/20572830
1066
1067         Reviewed by Darin Adler.
1068
1069         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1070         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
1071         for testing.
1072
1073 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
1074
1075         Fix internal build configuration issues
1076         https://bugs.webkit.org/show_bug.cgi?id=144762
1077
1078         Reviewed by David Kilzer.
1079
1080         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
1081
1082         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1083         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1084         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1085         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1086         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1087         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1088         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1089         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1090
1091 2015-05-12  David Kilzer  <ddkilzer@apple.com>
1092
1093         Switch to launching iOS Simulator using bundle ID
1094         <rdar://problem/20916096>
1095
1096         This is required to fix the layout tests on internal bots.
1097
1098         * Scripts/webkitdirs.pm:
1099         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
1100         Simulator.  Add FIXME.
1101         (quitIOSSimulator): Add FIXME.
1102         * Scripts/webkitpy/port/ios.py:
1103         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
1104         launch iOS Simulator.  Add FIXME.
1105         (IOSSimulatorPort.check_sys_deps): Add FIXME.
1106
1107 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
1108
1109         Fix run-javascriptcore-tests step on the WinCairo bot
1110         https://bugs.webkit.org/show_bug.cgi?id=144866
1111
1112         Reviewed by Csaba Osztrogonác.
1113
1114         Catch exception when failing to create soft link, so we can fall back to copy.
1115
1116         * Scripts/run-jsc-stress-tests:
1117
1118 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
1119
1120         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
1121         https://bugs.webkit.org/show_bug.cgi?id=116971
1122
1123         Reviewed by Chris Fleizach.
1124
1125         Implement rowAtIndex for ATK.
1126
1127         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1128         (WTR::AccessibilityUIElement::rowAtIndex):
1129
1130 2015-05-11  Dan Bernstein  <mitz@apple.com>
1131
1132         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
1133
1134         Reviewed by Alexey Proskuryakov.
1135
1136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1137         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
1138         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
1139         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
1140
1141 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
1142
1143         Fix internal build configuration issues
1144         https://bugs.webkit.org/show_bug.cgi?id=144762
1145
1146         Reviewed by Darin Adler.
1147
1148         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
1149
1150         * TestWebKitAPI/Configurations/Base.xcconfig:
1151         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1152         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1153         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1154         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1155         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1156         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1157
1158 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
1159
1160         [Win] Move Windows build target to Windows 7 (or newer)
1161         https://bugs.webkit.org/show_bug.cgi?id=144890
1162         <rdar://problem/20707307>
1163
1164         Reviewed by Anders Carlsson.
1165
1166         Update linked SDK and minimal Windows level to be compatible with
1167         Windows 7 or newer.
1168
1169         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1170         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1171         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1172         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1173         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1174         * DumpRenderTree/config.h:
1175         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1176         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1177         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1178         * WinLauncher/stdafx.h:
1179
1180 2015-05-11  Commit Queue  <commit-queue@webkit.org>
1181
1182         Unreviewed, rolling out r184119.
1183         https://bugs.webkit.org/show_bug.cgi?id=144888
1184
1185         broke JSC tests on Apple Windows bots (Requested by kling on
1186         #webkit).
1187
1188         Reverted changeset:
1189
1190         "Fix run-javascriptcore-tests step on the WinCairo bot"
1191         https://bugs.webkit.org/show_bug.cgi?id=144866
1192         http://trac.webkit.org/changeset/184119
1193
1194 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1195
1196         run-benchmark should support Dromaeo
1197         https://bugs.webkit.org/show_bug.cgi?id=144849
1198
1199         Reviewed by Chris Dumez.
1200
1201         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
1202         they can take as much as 15 minutes to run each.
1203
1204         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
1205         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
1206         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
1207         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
1208
1209 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1210
1211         Build fix. jetstream has a local copy, not remote archive.
1212
1213         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1214
1215 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1216
1217         run-benchmark should support SunSpider, Kraken and Octane
1218         https://bugs.webkit.org/show_bug.cgi?id=144840
1219
1220         Reviewed by Darin Adler.
1221
1222         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
1223         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
1224         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
1225         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
1226
1227         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
1228         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
1229
1230         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
1231         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
1232
1233         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
1234         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
1235         now has the ability to run an arbitrary "create script".
1236
1237         * Scripts/run-benchmark:
1238         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
1239         This also overrides the remote archive URL specified in the plan.
1240
1241         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
1242
1243         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
1244         JetStreamBenchmarkBuilder.
1245
1246         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
1247         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
1248         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
1249         _runCreateScript and _applyPatch to clean after themselves.
1250         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
1251         JetStream, SunSpider, Kraken all use this feature.
1252         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
1253         the leaf directory name since the latter is not available when a remote ZIP file is used.
1254         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
1255         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
1256         the benchmark name in the patches.
1257
1258         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
1259
1260         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1261         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
1262         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
1263         the browser opens by planName as the plan file no longer contains that.
1264
1265         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
1266         the top directory of JetStream instead of its parent.
1267         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
1268         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
1269         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
1270         the top directory of JetStream instead of its parent.
1271         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
1272         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
1273         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
1274         done in JetStream.patch.
1275         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
1276         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
1277         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
1278         path from the top directory of JetStream as done in JetStream.patch.
1279         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
1280
1281 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
1282
1283         Fix run-javascriptcore-tests step on the WinCairo bot
1284         https://bugs.webkit.org/show_bug.cgi?id=144866
1285
1286         Reviewed by Darin Adler.
1287
1288         * Scripts/run-jsc-stress-tests:
1289
1290 2015-05-11  Alex Christensen  <achristensen@webkit.org>
1291
1292         [Content Extensions] Support domain-specific rules and exceptions.
1293         https://bugs.webkit.org/show_bug.cgi?id=144833
1294
1295         Reviewed by Darin Adler.
1296
1297         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1298         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1299         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1300         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1301         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
1302         (TestWebKitAPI::mainDocumentRequest):
1303         (TestWebKitAPI::subResourceRequest):
1304         (TestWebKitAPI::TEST_F):
1305         (TestWebKitAPI::checkCompilerError):
1306         Added tests for parsing and functionality of if-domain and unless-domain.
1307
1308 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1309
1310         run-benchmark should support Chrome Canary and Firefox Nightly
1311         https://bugs.webkit.org/show_bug.cgi?id=144850
1312
1313         Reviewed by Darin Adler.
1314
1315         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
1316
1317         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
1318
1319         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
1320         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
1321         (OSXBrowserDriver):
1322         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
1323         (OSXBrowserDriver.closeBrowsers): Ditto.
1324         (OSXBrowserDriver.launchProcess): Ditto.
1325         (OSXBrowserDriver.terminateProcesses): Ditto.
1326         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1327         (OSXChromeDriver): Removed the unused self.chromePreferences.
1328         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
1329         (OSXChromeDriver.closeBrowsers): Ditto.
1330         (OSXChromeDriver.launchUrl):
1331         (OSXChromeCanaryDriver): Added.
1332         (OSXChromeCanaryDriver.launchUrl):
1333         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
1334         (OSXFirefoxDriver): Added.
1335         (OSXFirefoxDriver.launchUrl):
1336         (OSXFirefoxNightlyDriver): Added.
1337         (OSXFirefoxNightlyDriver.launchUrl):
1338         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1339         (OSXSafariDriver):
1340         (OSXSafariDriver.closeBrowsers):
1341
1342 2015-05-11  Tim Horton  <timothy_horton@apple.com>
1343
1344         Page overlay action context override should indicate the source of the request
1345         https://bugs.webkit.org/show_bug.cgi?id=144832
1346         <rdar://problem/20562594>
1347
1348         Reviewed by Darin Adler.
1349
1350         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
1351         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
1352
1353 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
1354
1355         [GTK] fast/events/page-visibility-transition-test.html is timing out
1356         https://bugs.webkit.org/show_bug.cgi?id=114789
1357
1358         Reviewed by Darin Adler.
1359
1360         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1361         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
1362         requests visibility changes.
1363
1364 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
1365
1366         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
1367         https://bugs.webkit.org/show_bug.cgi?id=144798
1368
1369         Reviewed by Darin Adler.
1370
1371         * efl/install-dependencies:
1372
1373 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
1374
1375         Make arguments of run-benchmark more user friendly
1376         https://bugs.webkit.org/show_bug.cgi?id=144835
1377
1378         Reviewed by Darin Adler.
1379
1380         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
1381         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
1382         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
1383         default values from --platform and --browser as they are required arguments.
1384
1385         * Scripts/run-benchmark:
1386         (main): Made --build-directory optional, and removed default values from --platform and --browser.
1387         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
1388         are not dynamically obtained via BrowserDriverFactory.
1389         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1390         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
1391         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
1392         run any benchmark in that case.
1393         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
1394         the specified file isn't a valid relative or an absolute path.
1395         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
1396         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
1397         and browsers.
1398         (BrowserDriverFactory.available_browsers): Ditto.
1399         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1400         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
1401         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
1402         browserBuildPath was None.
1403         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1404         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
1405         so that we can use locally built WebKit to launch Safari.
1406
1407 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
1408
1409         Remove the PICTURE_SIZES build flag
1410         https://bugs.webkit.org/show_bug.cgi?id=144679
1411
1412         Reviewed by Benjamin Poulain.
1413
1414         Removed the PICTURE_SIZES build time flag.
1415
1416         * Scripts/webkitperl/FeatureList.pm:
1417
1418 2015-05-09  David Kilzer  <ddkilzer@apple.com>
1419
1420         Layout tests broke due to unexpected simctl output
1421
1422         * Scripts/webkitpy/xcode/simulator.py:
1423         (Simulator._parse_devices): Handle new Device Pairs header.
1424         * Scripts/webkitpy/xcode/simulator_unittest.py:
1425         (test_device_pairs): Add unit test for Device Pairs header.
1426
1427 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
1428
1429         Remove convenience constructors for TextRun
1430         https://bugs.webkit.org/show_bug.cgi?id=144752
1431
1432         Reviewed by Anders Carlsson.
1433
1434         Test the StringView which takes a StringImpl*.
1435
1436         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1437         (StringView8Bit): Testing is8Bit() on StringView
1438
1439 2015-05-07  Sam Weinig  <sam@webkit.org>
1440
1441         [Content Extensions] Add simple tester that takes an extension and compiles it
1442         https://bugs.webkit.org/show_bug.cgi?id=144781
1443
1444         Reviewed by Dan Bates.
1445
1446         * ContentExtensionTester: Added.
1447         * ContentExtensionTester/Configurations: Added.
1448         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
1449         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
1450         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
1451         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
1452         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
1453         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
1454         * ContentExtensionTester/main.m: Added.
1455         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
1456
1457 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
1458
1459         Build fix.
1460
1461         Reviewed by Dan Bernstein.
1462
1463         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1464         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1465         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
1466         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
1467         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1468         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1469         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
1470         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
1471
1472 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
1473
1474         [GTK] Some tests fail because they do not assume the popup menu captures click events
1475         https://bugs.webkit.org/show_bug.cgi?id=40601
1476
1477         Reviewed by Carlos Garcia Campos.
1478
1479         Popdown all attached menus when moving between tests and between each new
1480         event sent to the WebView. This prevents context and popup menus from eating
1481         events.
1482
1483         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
1484         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
1485         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1486         (WTR::dispatchEvent): Popdown all menus between dispatching events.
1487         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
1488         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
1489         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1490         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
1491         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1492         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
1493         longer in the platform-independent file.
1494         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
1495
1496 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
1497
1498         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
1499         https://bugs.webkit.org/show_bug.cgi?id=144746
1500
1501         Reviewed by Carlos Garcia Campos.
1502
1503         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
1504
1505         * MiniBrowser/gtk/main.c:
1506         (main):
1507
1508 2015-05-08  Commit Queue  <commit-queue@webkit.org>
1509
1510         Unreviewed, rolling out r183996.
1511         https://bugs.webkit.org/show_bug.cgi?id=144806
1512
1513         ASan detected use-after free (Requested by ap on #webkit).
1514
1515         Reverted changeset:
1516
1517         "Remove convenience constructors for TextRun"
1518         https://bugs.webkit.org/show_bug.cgi?id=144752
1519         http://trac.webkit.org/changeset/183996
1520
1521 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
1522
1523         Remove convenience constructors for TextRun
1524         https://bugs.webkit.org/show_bug.cgi?id=144752
1525
1526         Reviewed by Anders Carlsson.
1527
1528         Test the StringView which takes a StringImpl*.
1529
1530         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1531         (StringView8Bit): Testing is8Bit() on StringView
1532
1533 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1534
1535         [GTK] WTR doesn't correctly handle the Escape key
1536         https://bugs.webkit.org/show_bug.cgi?id=144788
1537
1538         Reviewed by Martin Robinson.
1539
1540         Correctly handle 0x001B character code in GTK+ event sender to be
1541         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
1542         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
1543         to dismiss popup menus.
1544
1545         Fixes editing/selection/5354455-1.html.
1546
1547         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1548         (WTR::getGDKKeySymForKeyRef):
1549
1550 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1551
1552         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
1553         https://bugs.webkit.org/show_bug.cgi?id=144748
1554
1555         Reviewed by Sergio Villar Senin.
1556
1557         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1558         (testWebKitSettings): Check the new setting is correctly
1559         initialized and updated.
1560         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1561         (testWebContextSecurityFileXHR): Check XHR to local files is
1562         allowed from file URLs after changing the setting.
1563         (beforeAll): Add new test.
1564
1565 2015-05-08  Commit Queue  <commit-queue@webkit.org>
1566
1567         Unreviewed, rolling out r183945.
1568         https://bugs.webkit.org/show_bug.cgi?id=144789
1569
1570         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
1571
1572         Reverted changeset:
1573
1574         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
1575         https://bugs.webkit.org/show_bug.cgi?id=144746
1576         http://trac.webkit.org/changeset/183945
1577
1578 2015-05-07  Anders Carlsson  <andersca@apple.com>
1579
1580         Build fixes.
1581
1582         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
1583         (TestWebKitAPI::TEST):
1584         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
1585         (TestWebKitAPI::TEST):
1586         Add casts.
1587
1588 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
1589
1590         GC has trouble with pathologically large array allocations
1591         https://bugs.webkit.org/show_bug.cgi?id=144609
1592
1593         Reviewed by Geoffrey Garen.
1594         
1595         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
1596         and it's a frequently requested feature.
1597         
1598         Also add the ability to run a test pretending that your system has a particular RAM size.
1599         This is useful for GC tests, and the new GC test that I added uses this.
1600
1601         * Scripts/run-javascriptcore-tests:
1602         (runJSCStressTests):
1603         * Scripts/run-jsc-stress-tests:
1604
1605 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
1606
1607         [EFL] Bump EFL version to 1.14.0
1608         https://bugs.webkit.org/show_bug.cgi?id=144743
1609
1610         Reviewed by Darin Adler.
1611
1612         Bump EFL and elementary version to 1.14.0 and removed
1613         md5sum, because it isn't used at all if hash is present.
1614
1615         * efl/jhbuild.modules:
1616
1617 2015-05-07  Saam Barati  <saambarati1@gmail.com>
1618
1619         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
1620         https://bugs.webkit.org/show_bug.cgi?id=144753
1621
1622         Reviewed by Mark Lam.
1623
1624         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1625
1626 2015-05-07  Beth Dakin  <bdakin@apple.com>
1627
1628         New force-related DOM events should fire in WK1 views
1629         https://bugs.webkit.org/show_bug.cgi?id=144663
1630         -and corresponding-
1631         rdar://problem/20281886
1632
1633         Reviewed by Sam Weinig.
1634
1635         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
1636         now. Just send nil. 
1637         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1638         (TestWebKitAPI::buildAndPerformTest):
1639
1640 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1641
1642         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
1643         https://bugs.webkit.org/show_bug.cgi?id=144746
1644
1645         Reviewed by Martin Robinson.
1646
1647         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
1648
1649         * MiniBrowser/gtk/main.c:
1650         (main):
1651
1652 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
1653
1654         Revert "Introducing the Platform Abstraction Layer (PAL)"
1655         https://bugs.webkit.org/show_bug.cgi?id=144751
1656
1657         Unreviewed.
1658
1659         PAL should be a new target inside WebCore, rather than a top-level folder.
1660
1661         * Scripts/build-webkit: Add it to build-webkit.
1662
1663 2015-05-07  Ada Chan  <adachan@apple.com>
1664
1665         Add a test for WKPageCopySessionState() with filtering.
1666         https://bugs.webkit.org/show_bug.cgi?id=144666
1667
1668         Reviewed by Darin Adler.
1669
1670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1671         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
1672         (TestWebKitAPI::didFinishLoadForFrame):
1673         (TestWebKitAPI::setPageLoaderClient):
1674         (TestWebKitAPI::filterFirstItemCallback):
1675         (TestWebKitAPI::filterAllItemsCallback):
1676         (TestWebKitAPI::createSessionStates):
1677         (TestWebKitAPI::TEST):
1678
1679 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1680
1681         iOS build fix attempt
1682
1683         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
1684
1685         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1686
1687 2015-05-06  Matt Baker  <mattbaker@apple.com>
1688
1689         Unreviewed, updated my list of email addresses.
1690
1691         * Scripts/webkitpy/common/config/contributors.json:
1692
1693 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1694
1695         Do not link tools to WebKit2.framework
1696         https://bugs.webkit.org/show_bug.cgi?id=144699
1697
1698         Unreviewed build fix.
1699
1700         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1701         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1702         These linked to WebKit2 in two ways, eliminating the other one.
1703
1704 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
1705
1706         Introducing the Platform Abstraction Layer (PAL)
1707         https://bugs.webkit.org/show_bug.cgi?id=143358
1708
1709         Reviewed by Simon Fraser.
1710
1711         * Scripts/build-webkit: Add it to build-webkit.
1712
1713 2015-05-06  Alex Christensen  <achristensen@webkit.org>
1714
1715         Fix api tests after r183877.
1716
1717         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1718         (TestWebKitAPI::TEST_F):
1719         Generate all DFAs before compiling them.
1720
1721 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1722
1723         Do not link tools to WebKit2.framework
1724         https://bugs.webkit.org/show_bug.cgi?id=144699
1725
1726         Reviewed by Tim Horton.
1727
1728         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1730         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1731
1732 2015-05-06  Alex Christensen  <achristensen@webkit.org>
1733
1734         [Content Extensions] Test splitting NFAs by max NFA size.
1735         https://bugs.webkit.org/show_bug.cgi?id=144659
1736
1737         Reviewed by Darin Adler.
1738
1739         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1740         (TestWebKitAPI::createNFAs):
1741         (TestWebKitAPI::TEST_F):
1742         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1743         (TestWebKitAPI::createNFAs):
1744
1745 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
1746
1747         Remove the remaining vestiges of SVG feature define
1748         https://bugs.webkit.org/show_bug.cgi?id=144655
1749
1750         Reviewed by Alexey Proskuryakov.
1751
1752         * Scripts/webkitperl/FeatureList.pm:
1753
1754 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
1755
1756         Add a layout mode for computing fixed layout size from a minimum size
1757         https://bugs.webkit.org/show_bug.cgi?id=144610
1758         <rdar://problem/19790341>
1759
1760         Reviewed by Simon Fraser.
1761
1762         * MiniBrowser/mac/BrowserWindow.xib:
1763         * MiniBrowser/mac/BrowserWindowController.h:
1764         * MiniBrowser/mac/WK1BrowserWindowController.m:
1765         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
1766         * MiniBrowser/mac/WK2BrowserWindowController.m:
1767         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
1768         Add a optional toolbar item to toggle a minimum view size of 1024x0.
1769
1770 2015-05-05  Alex Christensen  <achristensen@webkit.org>
1771
1772         [Content Extensions] Release input NSString when finished copying it.
1773         https://bugs.webkit.org/show_bug.cgi?id=144642
1774
1775         Reviewed by Brian Weinstein.
1776
1777         * WebKitTestRunner/mac/TestControllerMac.mm:
1778         (WTR::TestController::platformConfigureViewForTest):
1779         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
1780
1781 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
1782
1783         Unreviewed test fix after r183798.
1784
1785         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1786         (convertToDRTLabel): Mimic behavior of Mac accessibility output
1787         so we can share results.
1788
1789 2015-05-05  Alex Christensen  <achristensen@webkit.org>
1790
1791         [Content Extensions] Use less memory to store the json input.
1792         https://bugs.webkit.org/show_bug.cgi?id=144604
1793
1794         Reviewed by Benjamin Poulain.
1795
1796         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1797         (-[ExtensionManagerWindowController add:]):
1798         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1799         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1800         * WebKitTestRunner/mac/TestControllerMac.mm:
1801         (WTR::TestController::platformConfigureViewForTest):
1802
1803 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1804
1805         Unreviewed. Make myself a WebKit reviewer.
1806
1807         * Scripts/webkitpy/common/config/contributors.json:
1808
1809 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
1810
1811         [GTK] r183783 breaks build
1812         https://bugs.webkit.org/show_bug.cgi?id=144632
1813
1814         Reviewed by Martin Robinson.
1815
1816         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
1817
1818         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1819         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1820
1821 2015-05-05  Alex Christensen  <achristensen@webkit.org>
1822
1823         [Content Extensions] Combine NFAs properly and free memory as we compile.
1824         https://bugs.webkit.org/show_bug.cgi?id=144485
1825
1826         Reviewed by Benjamin Poulain.
1827
1828         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1829         (TestWebKitAPI::TEST_F):
1830         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
1831         Added tests for deep NFAs.
1832
1833 2015-05-04  Alex Christensen  <achristensen@webkit.org>
1834
1835         [Content Extensions] Use less memory when writing byte code to file
1836         https://bugs.webkit.org/show_bug.cgi?id=144602
1837
1838         Reviewed by Darin Adler.
1839
1840         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1841
1842 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1843
1844         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
1845         https://bugs.webkit.org/show_bug.cgi?id=144541
1846
1847         Reviewed by Žan Doberšek.
1848
1849         Add a test case to WorkQueue unit test, to check that sources of
1850         asynchronous IO operations running in the WorkQueue thread are
1851         dispatched by the WorkQueue main loop.
1852
1853         * TestWebKitAPI/PlatformGTK.cmake:
1854         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
1855         (TestWebKitAPI::TEST):
1856
1857 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
1858
1859         Correct '--show-webview' option for Tiled Drawing tests
1860         https://bugs.webkit.org/show_bug.cgi?id=144621
1861
1862         Reviewed by Simon Fraser.
1863
1864         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
1865         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
1866
1867         * WebKitTestRunner/mac/TestControllerMac.mm:
1868         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
1869         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
1870
1871 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
1872
1873         Large array shouldn't be slow
1874         https://bugs.webkit.org/show_bug.cgi?id=144617
1875
1876         Reviewed by Geoffrey Garen.
1877         
1878         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
1879         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
1880         long-running. So, hash-map sort of belongs here.
1881
1882         * Scripts/run-jsc-benchmarks:
1883
1884 2015-05-04  Doug Russell  <d_russell@apple.com>
1885
1886         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
1887         https://bugs.webkit.org/show_bug.cgi?id=144489
1888
1889         Reviewed by Chris Fleizach.
1890
1891         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
1892         on the returned control.
1893         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
1894         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
1895         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
1896         Add support for setSelectedVisibleTextRange() in accessibility tests.
1897
1898         * DumpRenderTree/AccessibilityUIElement.cpp:
1899         (setSelectedVisibleTextRangeCallback):
1900         (AccessibilityUIElement::setSelectedVisibleTextRange):
1901         (AccessibilityUIElement::getJSClass):
1902         (AccessibilityUIElement::textMarkerForIndex): Deleted.
1903         * DumpRenderTree/AccessibilityUIElement.h:
1904         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1905         (AccessibilityUIElement::setSelectedVisibleTextRange):
1906         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1907         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1908         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
1909         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1910         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1911         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1912         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1913         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1914         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1915         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1916         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1917
1918 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
1919
1920         [Win] Implement the "--show-webview" option for Windows
1921         https://bugs.webkit.org/show_bug.cgi?id=144589
1922
1923         Reviewed by Alex Christensen.
1924
1925         Add another runtime flag (--show-webview) that causes DumpRenderTree
1926         to draw its view on-screen, rather than the standard offscreen mode.
1927
1928         * DumpRenderTree/win/DumpRenderTree.cpp:
1929         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
1930         (initializeGlobalsFromCommandLineOptions): Recognize the new
1931         command-line argument, and set the global 'showWebView' state if
1932         appropriate.
1933
1934 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
1935
1936         Remove dead code from TestInvocationCairo.cpp
1937         https://bugs.webkit.org/show_bug.cgi?id=144564
1938
1939         Reviewed by Gyuyoung Kim.
1940
1941         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
1942
1943         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1944         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1945
1946 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
1947
1948         [GTK] Add libnotify in gtk install-dependencies
1949         https://bugs.webkit.org/show_bug.cgi?id=144379
1950
1951         Reviewed by Csaba Osztrogonác.
1952
1953         * gtk/install-dependencies:
1954
1955 2015-05-01  Dan Bernstein  <mitz@apple.com>
1956
1957         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
1958         https://bugs.webkit.org/show_bug.cgi?id=144501
1959
1960         Reviewed by Darin Adler.
1961
1962         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1963         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
1964         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
1965         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
1966
1967 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
1968
1969         check-webkit-style fails due to system pylint
1970         https://bugs.webkit.org/show_bug.cgi?id=144360
1971
1972         Reviewed by Darin Adler.
1973
1974         Make sure that the directory containing third party autoinstalled modules
1975         is at the beginning of the search path, to avoid conflicts with other
1976         versions of the same modules installed in the system (e.g. pylint).
1977
1978         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
1979         modules directory to sys.path, instead of appending it.
1980
1981 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
1982
1983         Unreviewed, updated my list of email addresses.
1984
1985         * Scripts/webkitpy/common/config/contributors.json: Updated.
1986
1987 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
1988
1989         USE(...) macro should expect unprefixed variables
1990         https://bugs.webkit.org/show_bug.cgi?id=144454
1991
1992         Reviewed by Daniel Bates.
1993
1994         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
1995         * DumpRenderTree/config.h: Ditto.
1996         * TestWebKitAPI/config.h: Ditto.
1997
1998 2015-05-01  Basile Clement  <basile_clement@apple.com>
1999
2000         Unreviewed. Add myself as a commiter in contributors.json.
2001
2002         * Scripts/webkitpy/common/config/contributors.json:
2003
2004 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
2005
2006         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
2007         https://bugs.webkit.org/show_bug.cgi?id=144487
2008
2009         Reviewed by Ryosuke Niwa.
2010
2011         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2012         (BenchmarkRunner.merge): Fix bug.
2013         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
2014
2015 2015-05-01  Brady Eidson  <beidson@apple.com>
2016
2017         Add API to disable meta refreshes.
2018         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
2019
2020         Reviewed by Alexey Proskuryakov.
2021
2022         * DumpRenderTree/mac/DumpRenderTree.mm:
2023         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
2024
2025 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
2026
2027         Provide a runtime flag to run-webkit-tests that shows the test view
2028         https://bugs.webkit.org/show_bug.cgi?id=144079.
2029
2030         Unreviewed correction to r183651.
2031
2032         * WebKitTestRunner/TestController.cpp:
2033         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
2034         flag is included in the options dictionary passed to the PlatformWebView.
2035
2036 2015-05-01  Antti Koivisto  <antti@apple.com>
2037
2038         Remove network process load serialization code
2039         https://bugs.webkit.org/show_bug.cgi?id=144448
2040
2041         Reviewed by Alexey Proskuryakov.
2042
2043         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2044         (WTR::InjectedBundle::beginTesting):
2045         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2046         (WTR::TestRunner::setSerializeHTTPLoads):
2047         (WTR::TestRunner::dispatchPendingLoadRequests):
2048
2049 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2050
2051         [GTK] Add libhyphen-dev to the build dependencies
2052         https://bugs.webkit.org/show_bug.cgi?id=144452
2053
2054         Reviewed by Martin Robinson.
2055
2056         * gtk/install-dependencies: Added hyphen as Fedora and Arch
2057         dependencies.
2058
2059 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
2060
2061         Provide a runtime flag to run-webkit-tests that shows the test view
2062         https://bugs.webkit.org/show_bug.cgi?id=144079.
2063
2064         Reviewed by Dean Jackson.
2065
2066         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
2067         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
2068         option:
2069         
2070         --additional-drt-flag="--show-webview"
2071
2072         * DumpRenderTree/mac/DumpRenderTree.mm:
2073         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
2074         '--show-webview' flag.
2075         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
2076         * WebKitTestRunner/Options.cpp:
2077         (WTR::Options::Options):
2078         (WTR::handleOptionShowWebView):
2079         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
2080         * WebKitTestRunner/Options.h:
2081         * WebKitTestRunner/TestController.cpp:
2082         (WTR::TestController::TestController):
2083         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
2084         * WebKitTestRunner/TestController.h:
2085         (WTR::TestController::shouldShowWebView):
2086         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2087         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
2088         options dictionary. If it is true, display the web view while running the test.
2089
2090 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
2091
2092         r183355 didn't trigger Mac tests
2093         https://bugs.webkit.org/show_bug.cgi?id=144464
2094
2095         Reviewed by Simon Fraser.
2096
2097         Update badly neglected filters and unit tests.
2098
2099         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2100         (_should_file_trigger_build):
2101         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2102         (ShouldBuildTest):
2103         (ShouldBuildTest.test_should_build):
2104
2105 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2106
2107         [GTK] Add libhyphen-dev to the build dependencies
2108         https://bugs.webkit.org/show_bug.cgi?id=144452
2109
2110         Reviewed by Martin Robinson.
2111
2112         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
2113         build dependencies.
2114
2115 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
2116
2117         [GTK] Testing dictionaries are not installed automatically
2118         https://bugs.webkit.org/show_bug.cgi?id=144460
2119
2120         Reviewed by Carlos Garcia Campos.
2121
2122         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
2123
2124 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
2125
2126         Fix return code issue, check return code of safari process and dump results to log
2127         https://bugs.webkit.org/show_bug.cgi?id=144436
2128
2129         Reviewed by Ryosuke Niwa.
2130
2131         * Scripts/run-benchmark:
2132         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2133         (BenchmarkRunner.dump): Correct typo.
2134         (BenchmarkRunner.wrap): Add results to console.
2135         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
2136         (OSXSafariDriver.prepareEnv):
2137         (OSXSafariDriver.launchUrl):
2138         (OSXSafariDriver.closeBrowsers):
2139
2140 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
2141
2142         Should no longer need to worry about very old versions of Xcode
2143         https://bugs.webkit.org/show_bug.cgi?id=144437
2144
2145         Reviewed by Dan Bernstein.
2146
2147         * Scripts/check-for-exit-time-destructors:
2148         * Scripts/check-for-global-initializers:
2149         * Scripts/check-for-weak-vtables-and-externals:
2150
2151 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
2152
2153         REGRESSION(183583): [Mac] make without SDKROOT has issues
2154         https://bugs.webkit.org/show_bug.cgi?id=144431
2155
2156         Reviewed by Dan Bernstein.
2157
2158         * Makefile:
2159         * WebKitTestRunner/Makefile:
2160         Assume an empty SDKROOT means an macosx variant, so only
2161         enable settings if the SDKROOT is not empty and does not
2162         contain "macosx".
2163
2164 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
2165
2166         Expand test infrastructure to support scrolling tests
2167         https://bugs.webkit.org/show_bug.cgi?id=143684
2168         <rdar://problem/20375516>
2169
2170         Reviewed by Simon Fraser.
2171
2172         * DumpRenderTree/mac/DumpRenderTree.mm:
2173         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
2174         reset before the next test run.
2175         * WebKitTestRunner/TestController.cpp:
2176         (WTR::TestController::resetStateToConsistentValues): Ditto."
2177
2178 2015-04-29  Alex Christensen  <achristensen@webkit.org>
2179
2180         Run javascriptcore tests on Windows without cygwin
2181         https://bugs.webkit.org/show_bug.cgi?id=144419
2182
2183         Reviewed by Brent Fulgham.
2184
2185         * Scripts/run-javascriptcore-tests:
2186         (runJSCStressTests):
2187         Just call ruby, not /usr/bin/env ruby.
2188
2189 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
2190
2191         [GTK] Add --enable-shared option to LLVM to build mesa
2192         https://bugs.webkit.org/show_bug.cgi?id=144393
2193
2194         Reviewed by Martin Robinson.
2195
2196         The updated mesa requires the shared LLVM libraries.
2197         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
2198         to LLVM configure script. It will provide shared libraries in addition to static libraries.
2199
2200         * gtk/jhbuild-optional.modules:
2201
2202 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
2203
2204         [GTK] Add support for automatic hyphenation
2205         https://bugs.webkit.org/show_bug.cgi?id=44478
2206
2207         Reviewed by Carlos Garcia Campos.
2208
2209         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
2210         all systems will use the same dictionaries for testing purposes.
2211
2212 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
2213
2214         Failure when building WebKit for appletvsimulator.
2215         https://bugs.webkit.org/show_bug.cgi?id=144356
2216
2217         Reviewed by Alexey Proskuryakov.
2218
2219         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
2220         make TVOS and WatchOS behave correctly.
2221
2222         * Makefile:
2223         * WebKitTestRunner/Makefile:
2224
2225 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
2226
2227         Use-after-free when invalidating WKPageForceRepaint callback
2228         https://bugs.webkit.org/show_bug.cgi?id=144401
2229         rdar://problem/20741111
2230
2231         Reviewed by Tim Horton.
2232
2233         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
2234
2235         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
2236         Don't do anything on error, because the context may be a stale pointer now.
2237
2238 2015-04-29  David Kilzer  <ddkilzer@apple.com>
2239
2240         check-webkit-style: Don't complain about returning value from Objective-C method call in header
2241         <http://webkit.org/b/144395>
2242
2243         Reviewed by Andy Estes.
2244
2245         * Scripts/webkitpy/style/checkers/cpp.py:
2246         (check_spacing): Update regex so 'return' is ignored if it
2247         precedes the whitespace and bracket.  Change category name to
2248         'whitespace/brackets'.  Add period to error message.
2249         (CppChecker): Add 'whitespace/brackets' as a category.
2250         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2251         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
2252         'CppChecker.categories' since that's where the list lives now.
2253         (CppStyleTest.test_spacing_before_brackets): Add tests for
2254         'whitespace/brackets' issues and non-issues.
2255
2256 2015-04-29  Alex Christensen  <achristensen@webkit.org>
2257
2258         Fix WinCairo bot.
2259
2260         * Scripts/webkitdirs.pm:
2261         (determinePassedConfiguration):
2262         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
2263
2264 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
2265
2266         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
2267         https://bugs.webkit.org/show_bug.cgi?id=132159
2268
2269         Reviewed by Darin Adler.
2270
2271         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
2272         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
2273
2274         * DumpRenderTree/mac/DumpRenderTree.mm:
2275         (fontWhitelist):
2276         (adjustFonts):
2277         (createWebViewAndOffscreenWindow):
2278         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2279         (WTR::activateFonts):
2280         * WebKitTestRunner/mac/TestControllerMac.mm:
2281         (WTR::allowedFontFamilySet):
2282         (WTR::systemHiddenFontFamilySet):
2283         (WTR::generateWhitelist):
2284         (WTR::TestController::platformInitializeContext):
2285
2286 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
2287
2288         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2289         https://bugs.webkit.org/show_bug.cgi?id=144155
2290
2291         Reviewed by Andreas Kling.
2292
2293         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2294         Make sure that test window is "visible" before each test. While there is no concrete
2295         evidence that this is the problem indeed, the behavior is consistent with what would
2296         happen for an invisible window. Also, WKTR obviously needs to do this to protect
2297         against potential buggy tests that hide the window and don't show it.
2298
2299 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2300
2301         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
2302
2303         Latest changes in the inspector UI made this test fail. We were
2304         relying that the sidebar was always visible and the first 'li'
2305         element of the inspector was the one containing the title. This is
2306         no longer true, so better use document title that is not likely
2307         to change.
2308
2309         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2310         (openRemoteDebuggingSession):
2311
2312 2015-04-29  Andres Gomez  <agomez@igalia.com>
2313
2314         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
2315
2316         * Scripts/webkitpy/common/config/contributors.json:
2317
2318 2015-04-29  Andres Gomez  <agomez@igalia.com>
2319
2320         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
2321
2322         * Scripts/webkitpy/common/config/watchlist:
2323
2324 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
2325
2326         [EFL] Allow to run the tests on the native X display
2327         https://bugs.webkit.org/show_bug.cgi?id=144247
2328
2329         Reviewed by Gyuyoung Kim.
2330
2331         Added the USE_NATIVE_XDISPLAY option for the WTR.
2332         We can select the Xorg driver if environment variable is set up before running the tests.
2333
2334         * Scripts/webkitpy/port/efl.py:
2335         (EflPort._driver_class):
2336
2337 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
2338
2339         [GTK] Add libnotify-dev in gtk install-dependencies
2340         https://bugs.webkit.org/show_bug.cgi?id=144379
2341
2342         Reviewed by Žan Doberšek.
2343
2344         * gtk/install-dependencies:
2345
2346 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
2347
2348         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
2349         https://bugs.webkit.org/show_bug.cgi?id=143001
2350
2351         Reviewed by Gyuyoung Kim.
2352
2353         * WebKitTestRunner/TestController.cpp:
2354         (WTR::shouldUseFixedLayout):
2355
2356 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
2357
2358         Increase stablility of run-benchmark script
2359         https://bugs.webkit.org/show_bug.cgi?id=144361
2360
2361         Reviewed by Ryosuke Niwa.
2362
2363         * Scripts/run-benchmark:
2364         (main):
2365         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
2366         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2367         (GenericBenchmarkBuilder.clean):
2368         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
2369         (BenchmarkRunner.__init__):
2370         (BenchmarkRunner.execute):
2371         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2372         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
2373         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
2374         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
2375         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
2376         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
2377         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
2378         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2379         (HTTPServerDriver.fetchResult):
2380         (HTTPServerDriver):
2381         (HTTPServerDriver.killServer): Add kill server interface.
2382         (HTTPServerDriver.getReturnCode): Add get return code interface.
2383         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
2384         (SimpleHTTPServerDriver.serve):
2385         (SimpleHTTPServerDriver.fetchResult):
2386         (SimpleHTTPServerDriver):
2387         (SimpleHTTPServerDriver.killServer):
2388         (SimpleHTTPServerDriver.getReturnCode):
2389         * Scripts/webkitpy/benchmark_runner/utils.py:
2390         (forceRemove): Provide python version of 'rm -rf'.
2391
2392 2015-04-28  Sam Weinig  <sam@webkit.org>
2393
2394         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
2395         https://bugs.webkit.org/show_bug.cgi?id=144363
2396
2397         Reviewed by Alex Christensen.
2398
2399         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2400         (TestWebKitAPI::createNFAs):
2401         (TestWebKitAPI::TEST_F):
2402         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2403         (TestWebKitAPI::countLiveNodes):
2404         (TestWebKitAPI::createNFAs):
2405         (TestWebKitAPI::buildDFAFromPatterns):
2406         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
2407
2408 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2409
2410         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2411         https://bugs.webkit.org/show_bug.cgi?id=144304
2412
2413         Reviewed by Geoffrey Garen.
2414
2415         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
2416         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2417         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2418
2419 2015-04-28  Commit Queue  <commit-queue@webkit.org>
2420
2421         Unreviewed, rolling out r183514.
2422         https://bugs.webkit.org/show_bug.cgi?id=144359
2423
2424         It broke cloop test bots (Requested by mcatanzaro on #webkit).
2425
2426         Reverted changeset:
2427
2428         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
2429         https://bugs.webkit.org/show_bug.cgi?id=144304
2430         http://trac.webkit.org/changeset/183514
2431
2432 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2433
2434         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2435         https://bugs.webkit.org/show_bug.cgi?id=144304
2436
2437         Reviewed by Geoffrey Garen.
2438
2439         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
2440         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
2441         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2442         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2443
2444 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2445
2446         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
2447         https://bugs.webkit.org/show_bug.cgi?id=144319
2448
2449         Reviewed by Csaba Osztrogonác.
2450
2451         * TestWebKitAPI/CMakeLists.txt:
2452         * TestWebKitAPI/PlatformEfl.cmake:
2453
2454 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
2455
2456         Fix common typo "targetting" => "targeting"
2457         https://bugs.webkit.org/show_bug.cgi?id=144349
2458
2459         Reviewed by Daniel Bates.
2460
2461         * Scripts/webkitdirs.pm:
2462         (execMacWebKitAppForDebugging):
2463
2464 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2465
2466         [GTK][jhbuild] Mesa build failure with llvm 3.6
2467         https://bugs.webkit.org/show_bug.cgi?id=144250
2468
2469         Reviewed by Žan Doberšek.
2470
2471         Bump the version of Mesa to 10.5.4
2472
2473         * gtk/jhbuild.modules:
2474
2475 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
2476
2477         Disable App Nap in WebKitTestRunner UI process
2478         https://bugs.webkit.org/show_bug.cgi?id=144308
2479
2480         Reviewed by Daniel Bates.
2481
2482         * WebKitTestRunner/mac/main.mm:
2483         (disableAppNapInUIProcess):
2484         (main):
2485
2486 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2487
2488         [GTK] Update JHBuild Mesa download directory
2489         https://bugs.webkit.org/show_bug.cgi?id=144318
2490
2491         Update the download directory of Mesa module since the previous one
2492         doesn't exist any more.
2493
2494         Reviewed by Žan Doberšek.
2495
2496         * gtk/jhbuild.modules:
2497
2498 2015-04-28  Commit Queue  <commit-queue@webkit.org>
2499
2500         Unreviewed, rolling out r183477.
2501         https://bugs.webkit.org/show_bug.cgi?id=144334
2502
2503         Roll back the Mesa dependency bump in fear of uncaught
2504         regressions while the testing bots are no-op. (Requested by
2505         zdobersek on #webkit).
2506
2507         Reverted changeset:
2508
2509         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
2510         https://bugs.webkit.org/show_bug.cgi?id=144250
2511         http://trac.webkit.org/changeset/183477
2512
2513 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2514
2515         [GTK][jhbuild] Mesa build failure with llvm 3.6
2516         https://bugs.webkit.org/show_bug.cgi?id=144250
2517
2518         Reviewed by Žan Doberšek.
2519
2520         Bump the version of Mesa to 10.5.4
2521
2522         * gtk/jhbuild.modules:
2523
2524 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
2525
2526         Add '__init__.py' and fix known bug in benchmark runner.
2527         https://bugs.webkit.org/show_bug.cgi?id=144296
2528
2529         Reviewed by Ryosuke Niwa
2530
2531         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
2532         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
2533         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2534         (BenchmarkRunner.__init__):
2535         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
2536         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
2537         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
2538
2539 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2540
2541         More build fix.
2542
2543         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2544         (-[AccessibilityNotificationHandler _notificationReceived:]):
2545         Use -objectForKey:, not array subscript.
2546
2547 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2548
2549         Catch unexpected exits in DumpRenderTree
2550         https://bugs.webkit.org/show_bug.cgi?id=144288
2551
2552         Reviewed by Tim Horton.
2553
2554         * DumpRenderTree/mac/DumpRenderTree.mm:
2555         (atexitFunction):
2556         (DumpRenderTreeMain):
2557
2558 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2559
2560         Build fix
2561
2562         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2563         (-[AccessibilityNotificationHandler _notificationReceived:]):
2564         Use -objectForKey:, not array subscript.
2565
2566 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2567
2568         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2569         https://bugs.webkit.org/show_bug.cgi?id=144155
2570
2571         Reviewed by Tim Horton.
2572
2573         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
2574         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
2575         and we clearly don't want App Nap while testing.
2576
2577 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
2578
2579         [CMake] Autogenerate cmakeconfig.h.cmake
2580         https://bugs.webkit.org/show_bug.cgi?id=143997
2581
2582         Reviewed by Csaba Osztrogonác.
2583
2584         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
2585         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
2586
2587 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
2588
2589         REGRESSION(r182879): Images and video can no longer be downloaded
2590         https://bugs.webkit.org/show_bug.cgi?id=144267
2591         <rdar://problem/20702844>
2592
2593         Reviewed by Simon Fraser.
2594
2595         Revise tests to check for proper download menu state.
2596         1. Downloading a loal image should be disabled.
2597         2. Downloading a local media file should be disabled.
2598         3. Downloading non-downloadable media should be disabled.
2599
2600         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2601         (TestWebKitAPI::TEST):
2602
2603 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2604
2605         Merge run-launcher into run-minibrowser
2606         https://bugs.webkit.org/show_bug.cgi?id=141928
2607
2608         Reviewed by Darin Adler.
2609
2610         * Scripts/run-iexploder-tests:
2611         (runSafariWithIExploder):
2612         * Scripts/run-launcher: Removed.
2613         * Scripts/run-minibrowser:
2614         * Scripts/webkitdirs.pm:
2615         (launcherPath):
2616         * Scripts/webkitpy/port/efl.py:
2617         (EflPort.show_results_html_file):
2618         * Scripts/webkitpy/port/efl_unittest.py:
2619         (EflPortTest.test_show_results_html_file):
2620         * Scripts/webkitpy/port/gtk.py:
2621         (GtkPort.print_leaks_summary):
2622         (GtkPort.show_results_html_file):
2623         (GtkPort): Deleted.
2624         * Scripts/webkitpy/port/gtk_unittest.py:
2625         (GtkPortTest.test_show_results_html_file):
2626
2627 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2628
2629         [buildbot] Fix the output of perf-test buildstep on timeout
2630         https://bugs.webkit.org/show_bug.cgi?id=144097
2631
2632         Reviewed by Ryosuke Niwa.
2633
2634         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2635         (RunAndUploadPerfTests.getText2):
2636         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2637         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
2638         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
2639
2640 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2641
2642         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
2643         https://bugs.webkit.org/show_bug.cgi?id=143874
2644
2645         Reviewed by Gyuyoung Kim.
2646
2647         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
2648
2649 2015-04-24  Philippe Normand  <pnormand@igalia.com>
2650
2651         [JHBuild] Move to upstream OpenWebRTC
2652         https://bugs.webkit.org/show_bug.cgi?id=144145
2653
2654         Reviewed by Carlos Garcia Campos.
2655
2656         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
2657         and add a new simple patch to gst-plugins-base, required for
2658         OpenWebRTC build.
2659         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
2660         * gtk/jhbuild.modules: Ditto.
2661         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
2662
2663 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2664
2665         [ES6] Implement ES6 template literals
2666         https://bugs.webkit.org/show_bug.cgi?id=142691
2667
2668         Reviewed by Darin Adler.
2669
2670         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
2671
2672         * Scripts/webkitperl/FeatureList.pm:
2673
2674 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2675
2676         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
2677         https://bugs.webkit.org/show_bug.cgi?id=144217
2678
2679         Reviewed by Darin Adler.
2680
2681         * WebKitTestRunner/PlatformEfl.cmake:
2682
2683 2015-04-26  Doug Russell  <d_russell@apple.com>
2684
2685         AX: richer text change notifications (142719)
2686         https://bugs.webkit.org/show_bug.cgi?id=142719
2687
2688         Reviewed by Darin Adler.
2689
2690         Richer accessibility value change notifications. Introduce AXTextEditType,
2691         postTextStateChangeNotification and postTextReplacementNotification to give assistive
2692         tech apps more reliable context for responding to changes in web content. Also implement
2693         a mechanism to post value changes in password form fields in coalesced ticks to thwart
2694         analyzing the cadence of changes.
2695
2696         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
2697         and an overload of postTextReplacementNotification to give assistive tech apps more
2698         reliable context for responding to changes in web content selection. Also block posting
2699         selection changes on password fields.
2700
2701         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
2702         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2703         (-[AccessibilityNotificationHandler stopObserving]):
2704         (-[AccessibilityNotificationHandler _notificationReceived:]):
2705         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2706         (AccessibilityUIElement::removeNotificationListener):
2707         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2708         (-[AccessibilityNotificationHandler _notificationReceived:]):
2709         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2710         (WTR::AccessibilityUIElement::removeNotificationListener):
2711
2712 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
2713
2714         Add myself to contributors.json
2715         https://bugs.webkit.org/show_bug.cgi?id=144204
2716
2717         Reviewed by Darin Adler.
2718
2719         * Scripts/webkitpy/common/config/contributors.json:
2720
2721 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
2722
2723         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
2724         https://bugs.webkit.org/show_bug.cgi?id=144182
2725
2726         Reviewed by Simon Fraser.
2727
2728         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
2729
2730 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
2731
2732         https://bugs.webkit.org/show_bug.cgi?id=144038
2733
2734         Reviewed by Ryosuke Niwa
2735
2736         Add a script to run Speedometer and JetStream on a browser.
2737
2738         * Scripts/run-benchmark: Wrapper script to run benchmark.
2739         (main):
2740         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
2741         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
2742         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
2743         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
2744         (BenchmarkBuilderFactory):
2745         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
2746         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
2747         (GenericBenchmarkBuilder):
2748         (GenericBenchmarkBuilder.prepare):
2749         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
2750         (GenericBenchmarkBuilder._applyPatch):
2751         (GenericBenchmarkBuilder.clean):
2752         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
2753         (JetStreamBenchmarkBuilder):
2754         (JetStreamBenchmarkBuilder.prepare):
2755         (JetStreamBenchmarkBuilder._runCreateScript):
2756         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
2757         (BenchmarkRunner):
2758         (BenchmarkRunner.__init__):
2759         (BenchmarkRunner.execute):
2760         (BenchmarkRunner.dump):
2761         (BenchmarkRunner.wrap):
2762         (BenchmarkRunner.merge):
2763         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
2764         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
2765         (BrowserDriver):
2766         (BrowserDriver.prepareEnv):
2767         (BrowserDriver.launchUrl):
2768         (BrowserDriver.closeBrowser):
2769         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
2770         (BrowserDriverFactory):
2771         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
2772         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
2773         (OSXChromeDriver):
2774         (OSXChromeDriver.prepareEnv):
2775         (OSXChromeDriver.launchUrl):
2776         (OSXChromeDriver.closeBrowsers):
2777         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
2778         (OSXSafariDriver):
2779         (OSXSafariDriver.prepareEnv):
2780         (OSXSafariDriver.launchUrl):
2781         (OSXSafariDriver.closeBrowsers):
2782         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
2783         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
2784         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
2785         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
2786         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
2787         (GenericFactory):
2788         (GenericFactory.iterateGetItem):
2789         (GenericFactory.create):
2790         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
2791         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
2792         (ServerControl):
2793         (ServerControl.render_GET):
2794         (ServerControl.render_POST):
2795         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
2796         (HTTPServerDriver):
2797         (HTTPServerDriver.serve):
2798         (HTTPServerDriver.fetchResult):
2799         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
2800         (HTTPServerDriverFactory):
2801         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
2802         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
2803         (SimpleHTTPServerDriver):
2804         (SimpleHTTPServerDriver.depends):
2805         (SimpleHTTPServerDriver.__init__):
2806         (SimpleHTTPServerDriver.serve):
2807         (SimpleHTTPServerDriver.baseUrl):
2808         (SimpleHTTPServerDriver.fetchResult):
2809         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
2810         (ModuleNotFoundError):
2811         (loadModule):
2812         (getPathFromProjectRoot):
2813         (loadJSONFromFile):
2814         (TimeoutError):
2815         (timeout):
2816         (timeout.__init__):
2817         (timeout.handle_timeout):
2818         (timeout.__enter__):
2819         (timeout.__exit__):
2820
2821 2015-04-24  Commit Queue  <commit-queue@webkit.org>
2822
2823         Unreviewed, rolling out r183303.
2824         https://bugs.webkit.org/show_bug.cgi?id=144181
2825
2826         Change was incorrect, broke builds (Requested by smfr on
2827         #webkit).
2828
2829         Reverted changeset:
2830
2831         "Fix the build."
2832         http://trac.webkit.org/changeset/183303
2833
2834 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
2835
2836         Fix the build.
2837
2838         * MiniBrowser/mac/WK2BrowserWindowController.m:
2839         (-[WK2BrowserWindowController initWithConfiguration:]):
2840
2841 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
2842
2843         Disable ActionMenusPDFTest due to timeout on test bot
2844
2845         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2846         (TestWebKitAPI::TEST):
2847
2848 2015-04-24  Commit Queue  <commit-queue@webkit.org>
2849
2850         Unreviewed, rolling out r183266.
2851         https://bugs.webkit.org/show_bug.cgi?id=144164
2852
2853         Broke 32-bit build and a test. (Requested by ap on #webkit).
2854
2855         Reverted changeset:
2856
2857         "AX: richer text change notifications (142719)"
2858         https://bugs.webkit.org/show_bug.cgi?id=142719
2859         http://trac.webkit.org/changeset/183266
2860
2861 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
2862
2863         REGRESSION: WebKit2.ActionMenusTest API test fails
2864         https://bugs.webkit.org/show_bug.cgi?id=144149
2865         <rdar://problem/20677770>
2866
2867         Reviewed by Tim Horton.
2868
2869         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
2870         as the 'ActionMenusPDFTest'.
2871         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2872         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
2873         to match the hit test on the 'action-menu-target.pdf' test file.
2874
2875 2015-04-24  Daniel Bates  <dabates@apple.com>
2876
2877         Cleanup: Use @memoized for property IOSSimulator.testing_device
2878         https://bugs.webkit.org/show_bug.cgi?id=141715
2879
2880         Reviewed by Darin Adler.
2881
2882         Simplify the caching of the result of IOSSimulator.testing_device
2883         and make the code more readable by making use of the @memoized declarator
2884         instead of explicitly managing a private instance variable,
2885         IOSSimulator._testing_device, for the cached result.
2886
2887         * Scripts/webkitpy/port/ios.py:
2888         (IOSPort.determine_full_port_name):
2889         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
2890         (IOSSimulatorPort):
2891         (IOSSimulatorPort.testing_device): No need to cache the created device object in
2892         IOSSimulatorPort._testing_device since we are marking this function @memoized.
2893         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
2894         of caching in local variable since we only make use of this value exactly once in this function.
2895         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
2896         been used since being added in r178622. So, we can remove this constructor since
2897         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
2898
2899 2015-04-24  Anders Carlsson  <andersca@apple.com>
2900
2901         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
2902         https://bugs.webkit.org/show_bug.cgi?id=144158
2903
2904         Reviewed by Beth Dakin.
2905
2906         * MiniBrowser/mac/WK2BrowserWindowController.m:
2907         (-[WK2BrowserWindowController initWithConfiguration:]):
2908
2909 2015-04-24  Doug Russell  <d_russell@apple.com>
2910
2911         AX: richer text change notifications (142719)
2912         https://bugs.webkit.org/show_bug.cgi?id=142719
2913
2914         Reviewed by Darin Adler.
2915
2916         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
2917
2918         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
2919
2920         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
2921         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2922         (-[AccessibilityNotificationHandler stopObserving]):
2923         (-[AccessibilityNotificationHandler _notificationReceived:]):
2924         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2925         (AccessibilityUIElement::removeNotificationListener):
2926         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2927         (-[AccessibilityNotificationHandler _notificationReceived:]):
2928         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2929         (WTR::AccessibilityUIElement::removeNotificationListener):
2930
2931 2015-04-24  Darin Adler  <darin@apple.com>
2932
2933         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
2934         https://bugs.webkit.org/show_bug.cgi?id=128007
2935
2936         Reviewed by Anders Carlsson.
2937
2938         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
2939         * DumpRenderTree/win/UIDelegate.h: Ditto.
2940
2941         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
2942         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
2943
2944         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
2945
2946         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
2947         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
2948         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
2949         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
2950         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2951         (WebKitDOMDOMWindowTest::create): Ditto.
2952         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2953         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
2954         of smart pointers to DelayedSIgnal objects.
2955         (uriChangedCallback): Ditto.
2956
2957 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
2958
2959         [Mac] Unreviewed test fix.
2960         https://bugs.webkit.org/show_bug.cgi?id=144149
2961
2962         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2963         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
2964         test.
2965
2966 2015-04-23  Darin Adler  <darin@apple.com>
2967
2968         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
2969         https://bugs.webkit.org/show_bug.cgi?id=144090
2970
2971         Reviewed by Anders Carlsson.
2972
2973         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
2974
2975 2015-04-23  Michael Saboff  <msaboff@apple.com>
2976
2977         lldb macro btjs sometimes can't get a frame description
2978         https://bugs.webkit.org/show_bug.cgi?id=144130
2979
2980         Reviewed by Filip Pizlo.
2981
2982         We look to execute ExecState::describeFrame().  It appears that in some contexts the
2983         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
2984         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
2985
2986         * lldb/lldb_webkit.py:
2987         (btjs):
2988
2989 2015-04-23  Alex Christensen  <achristensen@webkit.org>
2990
2991         Use less memory when compiling content extensions.
2992         https://bugs.webkit.org/show_bug.cgi?id=144051
2993
2994         Reviewed by Darin Adler and Benjamin Poulain.
2995
2996         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2997         (TestWebKitAPI::TEST_F):
2998         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2999         (TestWebKitAPI::countLiveNodes):
3000
3001 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3002
3003         [CMake] Clean up JSC JIT options
3004         https://bugs.webkit.org/show_bug.cgi?id=143998
3005
3006         Reviewed by Filip Pizlo.
3007
3008         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
3009         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
3010
3011 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
3012
3013         [Mac] Extend action menus to support PDF
3014         https://bugs.webkit.org/show_bug.cgi?id=143895
3015         <rdar://problem/19003333>
3016
3017         Reviewed by Tim Horton.
3018
3019         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
3020         of PDF content works.
3021
3022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
3023         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
3024         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
3025         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3026         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
3027         Update to support PDF tests.
3028         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
3029         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
3030
3031 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3032
3033         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
3034
3035         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3036         (beforeAll):
3037         (testWebViewAudioOnlyUserMediaPermissionRequests):
3038
3039 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3040
3041         Add myself to watchlist
3042         https://bugs.webkit.org/show_bug.cgi?id=144041
3043
3044         Reviewed by Alex Christensen.
3045
3046         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
3047
3048         * Scripts/webkitpy/common/config/watchlist:
3049
3050 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3051
3052         [GTK] MiniBrowser should use NetworkProcess by default
3053         https://bugs.webkit.org/show_bug.cgi?id=143948
3054
3055         Reviewed by Sergio Villar Senin.
3056
3057         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
3058         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
3059
3060         * MiniBrowser/gtk/main.c:
3061         (main):
3062
3063 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
3064
3065         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
3066
3067         Unreviewed build fix.
3068
3069         * Scripts/prepare-ChangeLog:
3070         (get_function_line_ranges_for_cpp):
3071         Use grep instead of any to determine if a string is an element of an array.
3072
3073 2015-04-21  Anders Carlsson  <andersca@apple.com>
3074
3075         Fix block signatures
3076         https://bugs.webkit.org/show_bug.cgi?id=144002
3077
3078         Reviewed by Andreas Kling.
3079
3080         * MiniBrowser/mac/WK2BrowserWindowController.m:
3081         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3082
3083 2015-04-21  Philippe Normand  <pnormand@igalia.com>
3084
3085         [GTK] jhbuild should not use a branch for openwebrtc
3086         https://bugs.webkit.org/show_bug.cgi?id=143981
3087
3088         Reviewed by Carlos Garcia Campos.
3089
3090         * gtk/jhbuild.modules:
3091
3092 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
3093
3094         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
3095
3096         Unreviewed build fix.
3097
3098         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
3099         However, it has been exposed by List::MoreUtils since its inception. This patch uses
3100         the any function exposed by List::MoreUtils for greater compatibility.
3101
3102         * Scripts/prepare-ChangeLog:
3103         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
3104         the any function in all of versions of Perl used by our infrastructure.
3105
3106 2015-04-20  Alex Christensen  <achristensen@webkit.org>
3107
3108         Remove unnecessary logs when resetting tests.
3109
3110         * WebKitTestRunner/mac/TestControllerMac.mm:
3111         (WTR::TestController::platformResetPreferencesToConsistentValues):
3112         In r183020 I added some logs when compiling or removing content extensions fails.
3113         We often try to remove a content extension that does not exist, and that is not a problem.
3114
3115 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
3116
3117         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
3118         https://bugs.webkit.org/show_bug.cgi?id=143897
3119
3120         Reviewed by David Kilzer.
3121
3122         This is a speculative fix that addresses two issues:
3123
3124         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
3125         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
3126
3127         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
3128         Before: (723, 729)
3129         After: (721, 720)
3130
3131         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
3132         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
3133
3134         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
3135         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
3136
3137         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
3138
3139         2. Creating git diffs from HEAD and not origin/master by default.
3140
3141         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
3142         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
3143
3144         * Scripts/prepare-ChangeLog:
3145         (originalFile):
3146         Use HEAD instead of origin/master in default Git case.
3147
3148         (generateFunctionLists):
3149         Ensure that the end line is not less than the start line.
3150
3151         (extractLineRangeAfterChange):
3152         Set the end line to the start line if the end line is less than the start line.
3153
3154         (extractLineRangeBeforeChange):
3155         Ditto.
3156
3157 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
3158
3159         Suppress warning in prepare-ChangeLog.
3160         https://bugs.webkit.org/show_bug.cgi?id=143882
3161
3162         Reviewed by David Kilzer.
3163
3164         Prune noisy prepare-ChangeLog output by using the List::Util::any function
3165         instead of the deprecated smartmatch operator.
3166
3167         * Scripts/prepare-ChangeLog:
3168         Import the List::Util::any function.
3169
3170         (get_function_line_ranges_for_cpp):
3171         Use the any function instead of smartmatch.
3172
3173 2015-04-20  Anders Carlsson  <andersca@apple.com>
3174
3175         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
3176         https://bugs.webkit.org/show_bug.cgi?id=143966
3177
3178         Reviewed by Dan Bernstein.
3179
3180         * MiniBrowser/mac/WK2BrowserWindowController.m:
3181         (dataTypes):
3182         (-[WK2BrowserWindowController fetchWebsiteData:]):
3183         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3184         (-[WK2BrowserWindowController clearWebsiteData:]):
3185
3186 2015-04-20  Alex Christensen  <achristensen@webkit.org>
3187
3188         Fix content extension test flakiness.
3189         https://bugs.webkit.org/show_bug.cgi?id=143950
3190
3191         Reviewed by Brady Eidson.
3192
3193         * WebKitTestRunner/mac/TestControllerMac.mm:
3194         (WTR::TestController::platformResetPreferencesToConsistentValues):
3195         Remove the TestContentExtensions if it exists.
3196         (WTR::TestController::platformConfigureViewForTest):
3197         Log errors in case there are any.
3198
3199 2015-04-20  Alex Christensen  <achristensen@webkit.org>
3200
3201         Properly report errors from _WKUserContentExtensionStore.
3202         https://bugs.webkit.org/show_bug.cgi?id=143808
3203
3204         Reviewed by Darin Adler.
3205
3206         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3207         (TEST_F):
3208
3209 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3210
3211         Add a rule for NetworkCache to watchlist file
3212         https://bugs.webkit.org/show_bug.cgi?id=143945
3213
3214         Reviewed by Sergio Villar Senin.
3215
3216         And add myself to the list of watchers.
3217
3218         * Scripts/webkitpy/common/config/watchlist:
3219
3220 2015-04-19  Darin Adler  <darin@apple.com>
3221
3222         Update RefPtr documentation and deprecation
3223         https://bugs.webkit.org/show_bug.cgi?id=143936
3224
3225         Reviewed by Andreas Kling.
3226
3227         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
3228
3229 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3230
3231         Introduce bytecode intrinsics
3232         https://bugs.webkit.org/show_bug.cgi?id=143926
3233
3234         Reviewed by Filip Pizlo.
3235
3236         Change cpplint to accept emit_intrinsic_XXX.
3237
3238         * Scripts/webkitpy/style/checkers/cpp.py:
3239         (check_identifier_name_in_declaration):
3240
3241 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
3242
3243         Fix lldb_webkit.py to show StringImpls correctly
3244         https://bugs.webkit.org/show_bug.cgi?id=143920
3245
3246         Reviewed by Andreas Kling.
3247         
3248         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
3249
3250         * lldb/lldb_webkit.py:
3251         (WTFStringImplProvider.is_8bit):
3252
3253 2015-04-17  Daniel Bates  <dabates@apple.com>
3254
3255         Not able to build WebKit against iOS Simulator 8.3 SDK
3256         https://bugs.webkit.org/show_bug.cgi?id=143883
3257
3258         Reviewed by David Kilzer.
3259
3260         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
3261         so that Xcode uses them.
3262
3263         * Scripts/copy-webkitlibraries-to-product-directory:
3264
3265 2015-04-17  Beth Dakin  <bdakin@apple.com>
3266
3267         Force mouse events should go through normal mouse event handling code paths
3268         https://bugs.webkit.org/show_bug.cgi?id=143749
3269         -and corresponding-
3270         rdar://problem/20472895
3271
3272         Reviewed by Dean Jackson.
3273
3274         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
3275         Since there is not a way to create an NSEventTypePressure from scratch, we 
3276         subclass NSEvent and override all of the critical methods.
3277
3278         * WebKitTestRunner/EventSenderProxy.h:
3279         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3280         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3281         (WTR::EventSendingController::mouseForceDown):
3282         (WTR::EventSendingController::mouseForceUp):
3283         (WTR::EventSendingController::mouseForceChanged):
3284         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3285         * WebKitTestRunner/TestController.cpp:
3286         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3287         * WebKitTestRunner/mac/EventSenderProxy.mm:
3288         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3289         (-[EventSenderPressureEvent timestamp]):
3290         (-[EventSenderPressureEvent type]):
3291         (-[EventSenderPressureEvent locationInWindow]):
3292         (-[EventSenderPressureEvent location]):
3293         (-[EventSenderPressureEvent stage]):
3294         (-[EventSenderPressureEvent pressure]):
3295         (-[EventSenderPressureEvent phase]):
3296         (-[EventSenderPressureEvent eventNumber]):
3297         (WTR::EventSenderProxy::mouseForceDown):
3298         (WTR::EventSenderProxy::mouseForceUp):
3299         (WTR::EventSenderProxy::mouseForceChanged):
3300
3301 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
3302
3303         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
3304         https://bugs.webkit.org/show_bug.cgi?id=143885
3305
3306         Reviewed by Tim Horton.
3307
3308         Fixed a case where we have two builds with the same revision(s). An in order build
3309         is one for which the revision is strictly higher.
3310
3311         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3312         (BuildbotQueue.prototype._checkForInOrderResult):
3313         (BuildbotQueue.prototype.compareIterationsByRevisions):
3314
3315 2015-04-17  Commit Queue  <commit-queue@webkit.org>
3316
3317         Unreviewed, rolling out r182912 and r182920.
3318         https://bugs.webkit.org/show_bug.cgi?id=143881
3319
3320         Build breakage in some configurations (Requested by ap on
3321         #webkit).
3322
3323         Reverted changesets:
3324
3325         "Force mouse events should go through normal mouse event
3326         handling code paths"
3327         https://bugs.webkit.org/show_bug.cgi?id=143749
3328         http://trac.webkit.org/changeset/182912
3329
3330         http://trac.webkit.org/changeset/182920
3331
3332 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
3333
3334         [GTK] One more unreviewed fix after r182882.
3335
3336         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
3337
3338 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
3339
3340         [GTK] Unreviewed speculative clean build fix after r182882.
3341
3342         TestWebKitAPI's forwarding header generator depended on WeKit2's
3343         which generated SOUP related forwarding headers too.
3344
3345         This dependency isn't necessary and was removed by r182882 to make
3346         forwarding header generators parallelizable. But in this case
3347         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
3348         should generate SOUP related forwarding headers too similar to EFL.
3349
3350         * TestWebKitAPI/PlatformGTK.cmake:
3351         * WebKitTestRunner/PlatformGTK.cmake:
3352
3353 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3354
3355         [SOUP] Redirect to non HTTP destination is broken
3356         https://bugs.webkit.org/show_bug.cgi?id=143866
3357
3358         Reviewed by Sergio Villar Senin.
3359
3360         Add a unit test to check that redirect to a data URI works.
3361
3362         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3363         (testRedirectToDataURI):
3364         (serverCallback):
3365         (beforeAll):
3366
3367 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
3368
3369         Changes method of quitting iOS Simulator to be more correct.
3370         https://bugs.webkit.org/show_bug.cgi?id=143847
3371         <rdar://problem/20530344>
3372
3373         Reviewed by Darin Adler.
3374
3375         Fixes by addressing the app by ID rather than by name.
3376
3377         * Scripts/webkitdirs.pm:
3378         (quitIOSSimulator):
3379         * Scripts/webkitpy/port/ios.py:
3380         (IOSSimulatorPort.check_sys_deps):
3381
3382 2015-04-16  Anders Carlsson  <andersca@apple.com>
3383
3384         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
3385         https://bugs.webkit.org/show_bug.cgi?id=143844
3386
3387         Reviewed by Dan Bernstein.
3388
3389         * MiniBrowser/mac/AppDelegate.m:
3390         (-[BrowserAppDelegate newPrivateWindow:]):
3391         * MiniBrowser/mac/WK2BrowserWindowController.m:
3392         (-[WK2BrowserWindowController initWithConfiguration:]):
3393         (-[WK2BrowserWindowController fetchWebsiteData:]):
3394         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3395         (-[WK2BrowserWindowController clearWebsiteData:]):
3396
3397 2015-04-16  Alex Christensen  <achristensen@webkit.org>
3398
3399         32-bit build fix.
3400
3401         * WebKitTestRunner/mac/TestControllerMac.mm:
3402         (WTR::TestController::platformResetPreferencesToConsistentValues):
3403         (WTR::TestController::platformConfigureViewForTest):
3404         Added WK_API_ENABLED.
3405
3406 2015-04-16  Alex Christensen  <achristensen@webkit.org>
3407
3408         Removed unused WKUserContentFilterRef.
3409         https://bugs.webkit.org/show_bug.cgi?id=143852
3410
3411         Reviewed by Sam Weinig.
3412
3413         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3414         * WebKitTestRunner/mac/TestControllerMac.mm:
3415         (WTR::TestController::platformResetPreferencesToConsistentValues):
3416         (WTR::TestController::platformConfigureViewForTest):
3417
3418 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
3419
3420         Unreviewed. Adding myself as a commiter in contributers.json.
3421
3422         * Scripts/webkitpy/common/config/contributors.json:
3423
3424 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
3425
3426         It is very hard to attach a debugger to WebProcess to debug tests
3427         https://bugs.webkit.org/show_bug.cgi?id=143837
3428
3429         Reviewed by Chris Dumez.
3430
3431         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
3432         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
3433
3434         Now it disables all timeouts in tools, as is best for debugging tests.
3435
3436         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
3437         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
3438
3439         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
3440         now has the same functionality.
3441
3442 2015-04-16  Beth Dakin  <bdakin@apple.com>
3443
3444         Force mouse events should go through normal mouse event handling code paths
3445         https://bugs.webkit.org/show_bug.cgi?id=143749
3446         -and corresponding-
3447         rdar://problem/20472895
3448
3449         Reviewed by Dean Jackson.
3450
3451         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
3452         Since there is not a way to create an NSEventTypePressure from scratch, we 
3453         subclass NSEvent and override all of the critical methods.
3454
3455         * WebKitTestRunner/EventSenderProxy.h:
3456         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3457         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3458         (WTR::EventSendingController::mouseForceDown):
3459         (WTR::EventSendingController::mouseForceUp):
3460         (WTR::EventSendingController::mouseForceChanged):
3461         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3462         * WebKitTestRunner/TestController.cpp:
3463         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3464         * WebKitTestRunner/mac/EventSenderProxy.mm:
3465         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3466         (-[EventSenderPressureEvent timestamp]):
3467         (-[EventSenderPressureEvent type]):
3468         (-[EventSenderPressureEvent locationInWindow]):
3469         (-[EventSenderPressureEvent location]):
3470         (-[EventSenderPressureEvent stage]):
3471         (-[EventSenderPressureEvent pressure]):
3472         (-[EventSenderPressureEvent phase]):
3473         (-[EventSenderPressureEvent eventNumber]):
3474         (WTR::EventSenderProxy::mouseForceDown):
3475         (WTR::EventSenderProxy::mouseForceUp):
3476         (WTR::EventSenderProxy::mouseForceChanged):
3477
3478 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
3479
3480         [EFL] Bump LLVM to version 3.6.0 on X86_64
3481         https://bugs.webkit.org/show_bug.cgi?id=143604
3482
3483         Reviewed by Gyuyoung Kim.
3484
3485         * efl/jhbuild.modules:
3486         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
3487         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
3488         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
3489         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
3490
3491 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
3492
3493         [EFL] Remove an unnecessary workaround from jhbuildrc
3494         https://bugs.webkit.org/show_bug.cgi?id=143823
3495
3496         Reviewed by Gyuyoung Kim.
3497
3498         * efl/jhbuildrc:
3499
3500 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
3501
3502         [GTK] Run forwarding headers generator unconditionally
3503         https://bugs.webkit.org/show_bug.cgi?id=143819
3504
3505         Reviewed by Carlos Garcia Campos.
3506
3507         * TestWebKitAPI/PlatformGTK.cmake:
3508         * WebKitTestRunner/PlatformGTK.cmake:
3509
3510 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3511
3512         [EFL] Add gnutls to jhbuild.module
3513         https://bugs.webkit.org/show_bug.cgi?id=143777
3514
3515         Reviewed by Csaba Osztrogonác.
3516
3517         EFL port has required at least 3.0.0 version of gnutls since r176712.
3518         However some old linux distributions don't support 3.0.0 version. Besides
3519         other projects sometimes need to use lower version of gnutls.
3520
3521         This patch supports to download gnutls through jhbuild, and use it.
3522
3523         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
3524         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
3525
3526 2015-04-15  Mark Lam  <mark.lam@apple.com>
3527
3528         Remove obsolete VMInspector debugging tool.
3529         https://bugs.webkit.org/show_bug.cgi?id=143798
3530
3531         Reviewed by Michael Saboff.
3532
3533         * TestWebKitAPI/CMakeLists.txt:
3534         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3535         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3537         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
3538
3539 2015-04-15  Jer Noble  <jer.noble@apple.com>
3540
3541         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
3542
3543         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3544
3545 2015-04-15  Jer Noble  <jer.noble@apple.com>
3546
3547         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
3548
3549         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3550         (TestWebKitAPI::TEST_F):
3551
3552 2015-04-15  Chris Dumez  <cdumez@apple.com>
3553
3554         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
3555         https://bugs.webkit.org/show_bug.cgi?id=143779
3556
3557         Reviewed by Brent Fulgham.
3558
3559         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
3560         similarly to what is done on Mac / WK1. Without this, PageCache could
3561         stay enabled after page cache tests and cause weird behaviors.
3562
3563         * DumpRenderTree/win/DumpRenderTree.cpp:
3564         (resetWebPreferencesToConsistentValues):
3565
3566 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
3567
3568         Re-enable custom dilation for antialiased fonts
3569         https://bugs.webkit.org/show_bug.cgi?id=143738
3570
3571         Reviewed by Tim Horton.
3572         
3573         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
3574         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
3575         a private WebKit pref. This pref defaults to YES, enabling the feature by default
3576         in WK1 as we do for WK2.
3577
3578         * DumpRenderTree/mac/DumpRenderTree.mm:
3579         (resetWebPreferencesToConsistentValues):
3580         * WebKitTestRunner/TestController.cpp:
3581         (WTR::TestController::resetPreferencesToConsistentValues):
3582
3583 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
3584
3585         Correct layering violation in DumpRenderTree Build
3586         https://bugs.webkit.org/show_bug.cgi?id=143732
3587
3588         Reviewed by Simon Fraser.
3589
3590         Correct a layering violation in DumpRenderTree by calling functions on the
3591         WebCoreTestSupport library, rather than attempting to work with WebCore
3592         types directly.
3593
3594         * DumpRenderTree/mac/EventSendingController.mm:
3595         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
3596         than WebCore itself.,
3597         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
3598
3599 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
3600
3601         Add a conservative DFA minimizer for the content extension matcher
3602         https://bugs.webkit.org/show_bug.cgi?id=143501
3603
3604         Reviewed by Alex Christensen.
3605
3606         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3607         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3608
3609 2015-04-14  Daniel Bates  <dabates@apple.com>
3610
3611         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
3612         https://bugs.webkit.org/show_bug.cgi?id=143693
3613         <rdar://problem/20530316>
3614
3615         Reviewed by Tim Horton.
3616
3617         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
3618         to use the fixed layout code on iOS at this time.
3619
3620         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
3621
3622 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
3623
3624         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
3625         https://bugs.webkit.org/show_bug.cgi?id=143705
3626
3627         Unreviewed change to watchlist file.
3628
3629         * Scripts/webkitpy/common/config/watchlist:
3630
3631 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
3632
3633         [EFL] favicon wasn't updated for google.com sometimes.
3634         https://bugs.webkit.org/show_bug.cgi?id=141940
3635
3636         Reviewed by Gyuyoung Kim.
3637
3638         As elm_entry_utf8_to_markup can include additional characters, parameter for the
3639         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
3640
3641         * MiniBrowser/efl/main.c:
3642         (on_url_changed):
3643
3644 2015-04-13  Tim Horton  <timothy_horton@apple.com>
3645
3646         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
3647         https://bugs.webkit.org/show_bug.cgi?id=143560
3648         <rdar://problem/16302047>
3649
3650         Reviewed by Darin Adler.
3651
3652         * MiniBrowser/mac/BrowserWindowController.h:
3653         * MiniBrowser/mac/MainMenu.xib:
3654         * MiniBrowser/mac/WK1BrowserWindowController.m:
3655         (-[WK1BrowserWindowController setScale:]):
3656         * MiniBrowser/mac/WK2BrowserWindowController.m:
3657         (viewScaleForMenuItemTag):
3658         (-[WK2BrowserWindowController setScale:]):
3659         (-[WK2BrowserWindowController validateMenuItem:]):
3660         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
3661         When in use, we resize the window so that the view fits correctly, and
3662         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
3663         layout size will not change when scaling down (but will update appropriately
3664         when the view is resized).
3665
3666 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
3667
3668         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
3669         https://bugs.webkit.org/show_bug.cgi?id=138630
3670
3671         Reviewed by Tim Horton.
3672
3673         Make sure that we always load at least one in order productive iteration.
3674
3675         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3676         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
3677         is done loading at least one iteration that wasn't an out of order build.
3678         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
3679         when that's needed to check for out of order builds.
3680         (BuildbotQueue.prototype.update): Ditto.
3681         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
3682         result, and if it does not, load more iterations.
3683         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
3684         an in order iteration loaded too.
3685         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
3686         corrected to always sort loaded iterations before unloaded ones.
3687
3688 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
3689
3690         Expand test infrastructure to support scrolling tests
3691         https://bugs.webkit.org/show_bug.cgi?id=143286
3692         <rdar://problem/20375516>
3693
3694         Reviewed by Simon Fraser.
3695
3696         Extend the WK1 and WK2 test programs to support two new EventSender commands:
3697         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
3698         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
3699         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
3700         relevant rubberband, scroll, and scroll-snap animations are finished.
3701
3702         * DumpRenderTree/mac/EventSendingController.mm:
3703         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
3704         and 'monitorWheelEvents'.
3705         (+[EventSendingController webScriptNameForSelector:]): Ditto.
3706         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
3707         debugging test failures.
3708         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
3709         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
3710         function, then passes it to WebCore to be called once the test deferrals have been cleared.
3711         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
3712         'callAfterScrollingCompletes' method.
3713         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
3714         and 'monitorWheelEvents'.
3715         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3716         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
3717         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
3718         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
3719         'callAfterScrollingComplates' method.
3720         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3721
3722 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
3723
3724         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
3725         https://bugs.webkit.org/show_bug.cgi?id=143656
3726
3727         Reviewed by Darin Adler.
3728
3729         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3730         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3731
3732 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
3733
3734         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
3735         https://bugs.webkit.org/show_bug.cgi?id=142387
3736
3737         Reviewed by Carlos Garcia Campos.
3738
3739         Running mixed content is blocked by default since r181134. Updated
3740         the test case to reflect the new default settings.
3741
3742         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3743         (testInsecureContent):
3744
3745 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3746
3747         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
3748         https://bugs.webkit.org/show_bug.cgi?id=143667
3749
3750         Reviewed by Csaba Osztrogonác.
3751
3752         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
3753         since r169017. Added $hardwareConcurrencySupport for it.
3754
3755         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
3756
3757         * Scripts/webkitperl/FeatureList.pm:
3758
3759 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
3760
3761         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
3762         https://bugs.webkit.org/show_bug.cgi?id=143664
3763
3764         Reviewed by Gyuyoung Kim.
3765
3766         * Scripts/webkitperl/FeatureList.pm:
3767
3768 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3769
3770         [EFL] Enable Media Source
3771         https://bugs.webkit.org/show_bug.cgi?id=143635
3772
3773         Reviewed by Csaba Osztrogonác.
3774
3775         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
3776
3777 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
3778
3779         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
3780         https://bugs.webkit.org/show_bug.cgi?id=143646
3781
3782         Reviewed by David Kilzer.
3783
3784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3785         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3786
3787 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
3788
3789         Use en_US spell checker for tests on Mac instead of Multilingual
3790         https://bugs.webkit.org/show_bug.cgi?id=143641
3791
3792         Reviewed by Dan Bernstein.
3793
3794         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3795         While at it, override NSUserDictionaryReplacementItems, so that user replacements
3796         cannot affect tests.
3797
3798         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
3799         Made this more like WebKit1 version.
3800
3801 2015-04-10  Tim Horton  <timothy_horton@apple.com>
3802
3803         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
3804         https://bugs.webkit.org/show_bug.cgi?id=143576
3805
3806         Reviewed by Simon Fraser.
3807
3808         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
3809         (TEST):
3810         Adopt.
3811
3812 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3813
3814         Update my email address and expertise.
3815         https://bugs.webkit.org/show_bug.cgi?id=143586
3816
3817         Unreviewed, just update my info.
3818
3819         * Scripts/webkitpy/common/config/contributors.json:
3820
3821 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
3822
3823         Flakiness Dashboard not loading insecure content if loaded with https URL
3824         https://bugs.webkit.org/show_bug.cgi?id=143570
3825
3826         Reviewed by Alexey Proskuryakov.
3827
3828         * TestResultServer/app.yaml:
3829         * TestResultServer/static-dashboards/loader.js:
3830         Switch to https scheme.
3831
3832 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
3833
3834         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
3835         https://bugs.webkit.org/show_bug.cgi?id=142907
3836
3837         Reviewed by Carlos Garcia Campos.
3838
3839         * TestWebKitAPI/PlatformEfl.cmake:
3840         * TestWebKitAPI/PlatformGTK.cmake:
3841         * WebKitTestRunner/PlatformEfl.cmake:
3842         * WebKitTestRunner/PlatformGTK.cmake:
3843
3844 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
3845
3846         [Mac] Unreviewed test fix after r182584
3847         https://bugs.webkit.org/show_bug.cgi?id=143452
3848
3849         Put both of these tests back to their original state now that the underlying
3850         problem is fixed.
3851
3852         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
3853         (TestWebKitAPI::TEST):
3854         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3855         (TestWebKitAPI::TEST):
3856
3857 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
3858
3859         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
3860         https://bugs.webkit.org/show_bug.cgi?id=143553
3861
3862         Reviewed by Ryosuke Niwa.
3863         
3864         Remove the spurious printVMs left over from an earlier change.
3865
3866         * Scripts/run-jsc-benchmarks:
3867
3868 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
3869
3870         [Mac] Unreviewed test fix after r182581
3871
3872         The behavior of control-left-click is controlled by a system preference.
3873         Our test bots have this turned off.
3874
3875         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
3876         (TestWebKitAPI::TEST):
3877         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3878         (TestWebKitAPI::TEST):
3879
3880 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
3881
3882         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
3883         https://bugs.webkit.org/show_bug.cgi?id=143452
3884         <rdar://problem/20437483>
3885
3886         Reviewed by Tim Horton.
3887
3888         Add a new API test to confirm that Cocoa mouse button press events are properly
3889         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
3890
3891         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
3892         some registered event handlers that the expected button press and context menu
3893         events are received.
3894
3895         The WK1 unit test creates an NSEvent with the desired button press state, and then
3896         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
3897         We check the resulting PlatformMouseEvent for proper state.
3898
3899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
3900         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
3901         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
3902         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
3903         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
3904         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
3905         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
3906         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3907         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
3908         mouse down events.
3909         * TestWebKitAPI/mac/PlatformWebViewMac.h:
3910
3911 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
3912
3913         [GTK] Add pango to jhbuild-optional.modules
3914         https://bugs.webkit.org/show_bug.cgi?id=143537
3915
3916         Reviewed by Martin Robinson.
3917
3918         * gtk/jhbuild-optional.modules: Add pango.
3919
3920 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3921
3922         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
3923         https://bugs.webkit.org/show_bug.cgi?id=143530
3924
3925         Reviewed by Žan Doberšek.
3926
3927         Assume that the default value for display (:0) is reserved and start checking on :1
3928         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
3929         and for X server named Xorg.bin (previous bug 1376599)
3930
3931         * Scripts/webkitpy/port/xvfbdriver.py:
3932         (XvfbDriver._next_free_display)
3933         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3934         (XvfbDriverTest.test_start_no_pixel_tests):
3935         (XvfbDriverTest.test_start_pixel_tests):
3936         (XvfbDriverTest.test_start_arbitrary_worker_number):
3937         (XvfbDriverTest.test_next_free_display):
3938         (XvfbDriverTest.test_start_next_worker):
3939 2015-04-08  Alex Christensen  <achristensen@webkit.org>
3940
3941         Block popups from content extensions.
3942         https://bugs.webkit.org/show_bug.cgi?id=143497
3943
3944         Reviewed by Brady Eidson.
3945
3946         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3947         (TestWebKitAPI::TEST_F):
3948         Added popup test.
3949
3950 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
3951
3952         Add CMake build system for WinCairo port.
3953         https://bugs.webkit.org/show_bug.cgi?id=115944
3954
3955         Reviewed by Chris Dumez.
3956
3957         * CMakeLists.txt:
3958         * WinLauncher/CMakeLists.txt: Added.
3959
3960 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3961
3962         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
3963         https://bugs.webkit.org/show_bug.cgi?id=143521
3964
3965         Reviewed by Martin Robinson.
3966
3967         Add a way to detect unexpected web process crashes to WebViewTest,
3968         and a test case to testDOMCache to trigger the crash.
3969
3970         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3971         (WebKitDOMNodeTest::testDOMCache):
3972         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3973         (testWebKitWebViewProcessCrashed):
3974         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3975         (WebViewTest::WebViewTest):
3976         (WebViewTest::webProcessCrashed):
3977         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3978
3979 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
3980
3981         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
3982         rdar://problem/20461342
3983
3984         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3985
3986 2015-04-07  Commit Queue  <commit-queue@webkit.org>
3987
3988         Unreviewed, rolling out r182511.
3989         https://bugs.webkit.org/show_bug.cgi?id=143507
3990
3991         caused debug test failures (Requested by alexchristensen on
3992         #webkit).
3993
3994         Reverted changeset:
3995
3996         "Block popups from content extensions."
3997         https://bugs.webkit.org/show_bug.cgi?id=143497
3998         http://trac.webkit.org/changeset/182511
3999
4000 2015-04-07  Alex Christensen  <achristensen@webkit.org>
4001
4002         Block popups from content extensions.
4003         https://bugs.webkit.org/show_bug.cgi?id=143497
4004
4005         Reviewed by Brady Eidson.
4006
4007         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4008         (TestWebKitAPI::TEST_F):
4009         Added popup test.
4010
4011 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
4012
4013         Get the features.json files ready for open contributions
4014         https://bugs.webkit.org/show_bug.cgi?id=143436
4015
4016         Reviewed by Darin Adler.
4017
4018         * Scripts/webkitpy/style/checkers/jsonchecker.py:
4019         (JSONFeaturesChecker.check):
4020         Extend the syntax checking a bit, but leave everything non-mandatory
4021         very loose until we figure what fields are important.
4022
4023 2015-04-07  Tim Horton  <timothy_horton@apple.com>
4024
4025         Expose and test fixedLayoutSize via modern WebKit SPI
4026         https://bugs.webkit.org/show_bug.cgi?id=143500
4027
4028         Reviewed by Simon Fraser.
4029
4030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4031         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
4032         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
4033         (TEST):
4034         Add a test that verifies that fixedLayoutSize works at all, that
4035         it persists through a navigation, and that turning it back off reverts to
4036         laying out at the size of the view.
4037
4038 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
4039
4040         Unreviewed. Add myself as a committer.
4041
4042         * Scripts/webkitpy/common/config/contributors.json:
4043
4044 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
4045
4046         [Win] Bots complain about missing /etc/catalog
4047         https://bugs.webkit.org/show_bug.cgi?id=143484
4048
4049         Reviewed by Chris Dumez.
4050
4051         The libxml2 build on Mac, iOS, and Windows does not provide the set
4052         of default catalog files. We do not actually need these for our
4053         purposes, but we get warnings and some bot flakiness because they
4054         are not present.
4055
4056         We can avoid both problems the same way the Mac and iOS ports do,
4057         by setting the XML_CATALOG_FILES environment variable to 'empty string',
4058         which avoid the warnings and bot problems.
4059
4060         * Scripts/webkitpy/port/win.py:
4061         (WinPort.setup_environ_for_server): Added.
4062
4063 2015-04-06  Sam Weinig  <sam@webkit.org>
4064
4065         Use content extensions in MiniBrowser.
4066         https://bugs.webkit.org/show_bug.cgi?id=143446
4067
4068         Reviewed by Alex Christensen.
4069
4070         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4071         * MiniBrowser/mac/AppDelegate.h:
4072         * MiniBrowser/mac/AppDelegate.m:
4073         (-[BrowserAppDelegate init]):
4074         (-[BrowserAppDelegate showExtensionsManager:]):
4075         (-[BrowserAppDelegate userContentContoller]):
4076         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
4077         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
4078         (-[ExtensionManagerWindowController init]):
4079         (-[ExtensionManagerWindowController windowDidLoad]):
4080         (-[ExtensionManagerWindowController add:]):
4081         (-[ExtensionManagerWindowController remove:]):
4082         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
4083         * MiniBrowser/mac/MainMenu.xib:
4084
4085 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4086
4087         web-platform-tests server should retrieve the modules file relatively to its docroot path
4088         https://bugs.webkit.org/show_bug.cgi?id=142742
4089
4090         Reviewed by Darin Adler.
4091
4092         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
4093         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
4094
4095 2015-04-06  Commit Queue  <commit-queue@webkit.org>
4096
4097         Unreviewed, rolling out r182445.
4098         https://bugs.webkit.org/show_bug.cgi?id=143459
4099
4100         broke 32 bit build (Requested by alexchristensen on #webkit).
4101
4102         Reverted changeset:
4103
4104         "Use content extensions in MiniBrowser."
4105         https://bugs.webkit.org/show_bug.cgi?id=143446
4106         http://trac.webkit.org/changeset/182445
4107
4108 2015-04-06  Sam Weinig  <sam@webkit.org>
4109
4110         Use content extensions in MiniBrowser.
4111         https://bugs.webkit.org/show_bug.cgi?id=143446
4112
4113         Reviewed by Alex Christensen.
4114
4115         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4116         * MiniBrowser/mac/AppDelegate.h:
4117         * MiniBrowser/mac/AppDelegate.m:
4118         (-[BrowserAppDelegate init]):
4119         (-[BrowserAppDelegate showExtensionsManager:]):
4120         (-[BrowserAppDelegate userContentContoller]):
4121         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
4122         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
4123         (-[ExtensionManagerWindowController init]):
4124         (-[ExtensionManagerWindowController windowDidLoad]):
4125         (-[ExtensionManagerWindowController add:]):
4126         (-[ExtensionManagerWindowController remove:]):
4127         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
4128         * MiniBrowser/mac/MainMenu.xib:
4129
4130 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
4131
4132         [GTK] install-dependencies should prefer dnf to yum
4133         https://bugs.webkit.org/show_bug.cgi?id=143441
4134
4135         Reviewed by Martin Robinson.
4136
4137         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
4138
4139         * gtk/install-dependencies:
4140
4141 2015-04-06  Andy Estes  <aestes@apple.com>
4142
4143         [iOS] 'make clean' fails in Tools/WebKitTestRunner
4144         https://bugs.webkit.org/show_bug.cgi?id=143455
4145
4146         Reviewed by Dan Bernstein.
4147
4148         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
4149         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
4150
4151         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
4152
4153 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
4154
4155         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
4156         https://bugs.webkit.org/show_bug.cgi?id=143450
4157
4158         Reviewed by Anders Carlsson.
4159
4160         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
4161         Make sure that the view is actually closed, regardless of anything else that happens beneath.
4162         Also, removed unnecessary get() calls.
4163
4164 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
4165
4166         Reduce the dependency on Flash in regression tests
4167         https://bugs.webkit.org/show_bug.cgi?id=143391
4168
4169         Reviewed by Anders Carlsson.
4170
4171         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
4172         Only allow QuickTime and the test plug-in.
4173
4174 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4175
4176         W3C test importer should generate the modules installed dynamically to run wpt tests
4177         https://bugs.webkit.org/show_bug.cgi?id=142738
4178
4179         Reviewed by Ryosuke Niwa.
4180
4181         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
4182         The implementation is done within TestDownloader and it is activated for the WPT repository.
4183         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
4184
4185         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
4186         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
4187         * Scripts/webkitpy/w3c/test_downloader.py:
4188         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
4189         (TestDownloader):
4190         (TestDownloader._git_submodules_description): Computes submodule description.
4191         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
4192         * Scripts/webkitpy/w3c/test_importer.py:
4193         (TestImporter.do_import): Added the possibility to post process the tests.
4194         (TestImporter):
4195         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
4196         (TestImporter.should_convert_test_harness_links): Updated according new options format.
4197         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4198         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
4199         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
4200         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
4201         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
4202         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
4203
4204 2015-04-05  Antti Koivisto  <antti@apple.com>
4205
4206         Bloom filter should support longer hashes
4207         https://bugs.webkit.org/show_bug.cgi?id=143419
4208
4209         Reviewed by Dan Bernstein.
4210
4211         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
4212         (TestWebKitAPI::generateRandomDigests):
4213         (TestWebKitAPI::TEST):
4214
4215 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
4216
4217         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
4218         https://bugs.webkit.org/show_bug.cgi?id=143372
4219
4220         Reviewed by Darin Adler.
4221
4222         * Scripts/run-jsc-stress-tests:
4223
4224 2015-04-03  Antti Koivisto  <antti@apple.com>
4225
4226         Add non-counting bloom filter class
4227         https://bugs.webkit.org/show_bug.cgi?id=143366
4228
4229         Reviewed by Sam Weinig.
4230
4231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4232         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
4233         (TestWebKitAPI::generateRandomHashes):
4234         (TestWebKitAPI::TEST):
4235
4236 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
4237
4238         FTL JIT tests should fail if LLVM library isn't available
4239         https://bugs.webkit.org/show_bug.cgi?id=143374
4240
4241         Reviewed by Mark Lam.
4242
4243         * Scripts/run-jsc-stress-tests:
4244
4245 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
4246
4247         [EFL] Speedup jhbuild with disable running autogen.sh
4248         https://bugs.webkit.org/show_bug.cgi?id=143369
4249
4250         Reviewed by Gyuyoung Kim.
4251
4252         * efl/jhbuild.modules:
4253
4254 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
4255
4256         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
4257         https://bugs.webkit.org/show_bug.cgi?id=143282
4258
4259         Reviewed by Daniel Bates.
4260
4261         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
4262
4263 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
4264
4265         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
4266         https://bugs.webkit.org/show_bug.cgi?id=143240
4267         rdar://problem/19990425
4268
4269         Reviewed by Tim Horton.
4270
4271         * DumpRenderTree/mac/LayoutTestHelper.m:
4272         (colorProfileURLForDisplay):
4273         (saveDisplayColorProfiles):
4274         Gracefully handle it when the current profile cannot be retrieved, fixing at
4275         least one case when LayoutTestHelper couldn't start.
4276
4277         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4278         (Manager._set_up_run):
4279         (Manager._force_pixel_tests_if_needed):
4280         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
4281         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
4282         Return and check an error from start_helper().
4283
4284 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
4285
4286         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
4287         https://bugs.webkit.org/show_bug.cgi?id=143321
4288
4289         Reviewed by Alexey Proskuryakov.
4290
4291         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
4292
4293 2015-04-01  Enrica Casucci  <enrica@apple.com>
4294
4295         Injected bundle messages should be at the page level.
4296         https://bugs.webkit.org/show_bug.cgi?id=143283
4297
4298         Reviewed by Alexey Proskuryakov.
4299
4300         Updating WebKitTestRunner to use the new page level messaging.
4301         The author of this patch is Tim Horton, I just finished it.
4302
4303         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4304         (WTR::EventSendingController::mouseDown):
4305         (WTR::EventSendingController::mouseUp):
4306         (WTR::EventSendingController::mouseMoveTo):
4307         (WTR::EventSendingController::leapForward):
4308         (WTR::EventSendingController::scheduleAsynchronousClick):
4309         (WTR::EventSendingController::keyDown):
4310         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
4311         (WTR::EventSendingController::mouseScrollBy):
4312         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
4313         (WTR::EventSendingController::continuousMouseScrollBy):
4314         (WTR::EventSendingController::addTouchPoint):
4315         (WTR::EventSendingController::updateTouchPoint):
4316         (WTR::EventSendingController::setTouchModifier):
4317         (WTR::EventSendingController::setTouchPointRadius):
4318         (WTR::EventSendingController::touchStart):
4319         (WTR::EventSendingController::touchMove):
4320         (WTR::EventSendingController::touchEnd):
4321         (WTR::EventSendingController::touchCancel):
4322         (WTR::EventSendingController::clearTouchPoints):
4323         (WTR::EventSendingController::releaseTouchPoint):
4324         (WTR::EventSendingController::cancelTouchPoint):
4325         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4326         (WTR::InjectedBundle::didReceiveMessage):
4327         (WTR::InjectedBundle::didReceiveMessageToPage):
4328         (WTR::InjectedBundle::done):
4329         (WTR::InjectedBundle::outputText):
4330         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
4331         (WTR::InjectedBundle::postAddChromeInputField):
4332         (WTR::InjectedBundle::postRemoveChromeInputField):
4333         (WTR::InjectedBundle::postFocusWebView):
4334         (WTR::InjectedBundle::postSetBackingScaleFactor):
4335         (WTR::InjectedBundle::postSetWindowIsKey):
4336         (WTR::InjectedBundle::postSimulateW