1 2013-09-06 Alexey Proskuryakov <ap@apple.com>
3 Lots of pixel tests are failing on first run, so tests cannot finish
4 https://bugs.webkit.org/show_bug.cgi?id=120755
6 Reviewed by Ryosuke Niwa.
8 For whatever reason, many reftests are color profile sensitive, and we only set
9 color profile to a known one for pixel tests, not for reftests.
11 Pixel testing mode is also enabled when retrying tests, so these failures used to
12 be essentially hidden - the tests were "flaky", but that was not reported loudly enough.
13 But now, so many tests fail that it makes run-webkit-tests stop early, and never retry.
15 This probably shouldn't happen, as reftests should not be color profile sensitive.
16 The fix is a stopgap measure to unblock EWS until a better fix can be investigated.
18 * Scripts/webkitpy/layout_tests/controllers/manager.py:
19 (Manager._set_up_run): Roll out <http://trac.webkit.org/changeset/115601>.
21 2013-09-06 Denis Nomiyama <d.nomiyama@samsung.com>
23 [GTK] AccessibilityUIElement::addNotificationListener() crashes on debug build
24 https://bugs.webkit.org/show_bug.cgi?id=120416
26 Reviewed by Mario Sanchez Prada.
28 Fixed crashes when running debug DRT. Simplified loops at AccessibilityCallbackAtk.cpp where the HashMap
29 iterator was removed inside a loop. Fixed AccessibilityUIElement::addNotificationListener() where
30 m_notificationHandler expected RefPtr.
32 The global notification handler was stored in the HashMap with key 0. And this caused an assertion when
33 HashMap::add() or find() are called. To fix it, moved the global handler to a separated pointer.
35 * DumpRenderTree/atk/AccessibilityCallbacks.h: Removed the global notification key.
36 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
37 (axObjectEventListener): Simplified the code by using HashMap::find() and a separate pointer for the
38 global notification handler.
39 (addAccessibilityNotificationHandler): Simplified the code by using HashMap::find() and a separate pointer
40 for the global notification handler.
41 (removeAccessibilityNotificationHandler): Added the removal for the global notification handler.
42 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
43 (AccessibilityNotificationHandler::create): Added static function to create
44 AccessibilityNotificationHandler.
45 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
46 (AccessibilityUIElement::addNotificationListener): Assigned m_notificationHandler with
47 AccessibilityNotificationHandler::create().
49 2013-09-06 Gabor Abraham <abrhm@inf.u-szeged.hu>
51 [Qt] REGRESSION(r155140) Pixel tests is still broken on Qt with QT_WEBKIT_DISABLE_UIPROCESS_DUMPPIXELS=1
52 https://bugs.webkit.org/show_bug.cgi?id=120847
54 Reviewed by Csaba Osztrogonác.
56 Move the force repaint code back to if (PlatformWebView::windowSnapshotEnabled()) block to support Qt.
57 Typo fixed: windowShapshotEnabled -> windowSnapshotEnabled.
58 Add a default PlatformWebView::windowSnapshotEnabled() to the !PLATFORM(QT).
60 * WebKitTestRunner/PlatformWebView.h:
61 (WTR::PlatformWebView::windowSnapshotEnabled):
62 * WebKitTestRunner/TestInvocation.cpp:
63 (WTR::TestInvocation::dumpResults):
64 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
65 (WTR::WrapperWindow::handleStatusChanged):
66 (WTR::PlatformWebView::windowSnapshotEnabled):
67 * WebKitTestRunner/qt/TestInvocationQt.cpp:
68 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
70 2013-09-06 Allan Sandfeld Jensen <allan.jensen@digia.com>
72 REGRESSION(r155140) Broke pixel tests on EFL/GTK/Qt
73 https://bugs.webkit.org/show_bug.cgi?id=120843
75 Reviewed by Csaba Osztrogonác.
77 Call notifyDone like the platform specific forceRepaintDoneCallback methods
78 it replaced did. The method is empty on the Apple ports.
80 * WebKitTestRunner/TestInvocation.cpp:
81 (WTR::TestInvocation::forceRepaintDoneCallback):
83 2013-09-06 Allan Sandfeld Jensen <allan.jensen@digia.com>
85 [Qt][WK2] Window used by WebKitTestRunner loses active status
86 https://bugs.webkit.org/show_bug.cgi?id=120774
88 Reviewed by Jocelyn Turcotte.
90 When focusing the PlatformWebView which is done at the start of each test, we should
91 ensure the host window of PlatformWebView is also made active, otherwise we will
92 not receive the keyboard events send by EventSenderProxy.
94 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
95 (WTR::PlatformWebView::focus):
97 2013-09-05 Seokju Kwon <seokju@webkit.org>
99 Unreviewed build fix. VectorReverse.cpp was removed after r155151.
101 * TestWebKitAPI/CMakeLists.txt:
103 2013-09-05 Anders Carlsson <andersca@apple.com>
105 Make Vector::uncheckedAppend work with move-only types
106 https://bugs.webkit.org/show_bug.cgi?id=120799
108 Reviewed by Andreas Kling.
110 * TestWebKitAPI/Tests/WTF/Vector.cpp:
111 (TestWebKitAPI::MoveOnly):
112 Add a move-only class.
114 (TestWebKitAPI::TEST):
115 Add a test for Vector<MoveOnly>::uncheckedAppend.
117 2013-09-05 Anders Carlsson <andersca@apple.com>
119 Move all Vector tests into Vector.cpp
120 https://bugs.webkit.org/show_bug.cgi?id=120797
122 Reviewed by Andreas Kling.
124 * TestWebKitAPI/CMakeLists.txt:
125 * TestWebKitAPI/GNUmakefile.am:
126 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
127 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
128 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
129 * TestWebKitAPI/Tests/WTF/Vector.cpp:
130 (TestWebKitAPI::TEST):
131 * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: Removed.
132 * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Removed.
133 * TestWebKitAPI/Tests/WTF/WTF.pro:
135 2013-09-05 Simon Fraser <simon.fraser@apple.com>
137 Expected result images are sometimes blank in WKTR
138 https://bugs.webkit.org/show_bug.cgi?id=120715
140 Reviewed by Tim Horton.
142 In WebKitTestRunner, snapshots obtained via windowSnapshotImage() were
143 sometimes blank if a previous test triggered compositing mode, and the
144 current test or reference did not require compositing. This happened
145 because the UI process didn't wait for the web process to complete
146 its compositing mode switch before snapshotting. Fix by calling
147 WKPageForceRepaint() before we take the snapshot; this is async,
148 so we have to spin the runloop for a while.
150 Remove the Qt/EFL code that does the same thing.
152 * WebKitTestRunner/TestInvocation.cpp:
153 (WTR::TestInvocation::forceRepaintDoneCallback):
154 (WTR::TestInvocation::dumpResults):
155 * WebKitTestRunner/TestInvocation.h:
156 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
157 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
158 * WebKitTestRunner/qt/TestInvocationQt.cpp:
159 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
161 2013-09-05 Csaba Osztrogonác <ossy@webkit.org>
163 Make build.webkit.org report the number of failing run-fast-jsc tests
164 https://bugs.webkit.org/show_bug.cgi?id=120766
166 Reviewed by Filip Pizlo.
168 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
169 (RunJavaScriptCoreTests.commandComplete):
170 (RunJavaScriptCoreTests.getText2):
171 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
172 (RunJavaScriptCoreTestsTest): Added.
173 (RunJavaScriptCoreTestsTest.assertResults):
174 (RunJavaScriptCoreTestsTest.test_no_regressions_old_output):
175 (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
176 (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output):
177 (RunJavaScriptCoreTestsTest.test_fast_js_failure_new_output):
178 (RunJavaScriptCoreTestsTest.test_fast_js_crash_new_output):
179 (RunJavaScriptCoreTestsTest.test_mozilla_and_fast_js_failure_new_output):
181 2013-09-05 Csaba Osztrogonác <ossy@webkit.org>
183 Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
184 https://bugs.webkit.org/show_bug.cgi?id=120759
186 Reviewed by Filip Pizlo.
188 * Scripts/run-fast-jsc: Remove bashisms to make bash, dash and Darwin's /bin/sh happy.
189 * Scripts/run-javascriptcore-tests: Enable run-fast-jsc tests everywhere, except Windows.
191 2013-09-05 Filip Pizlo <fpizlo@apple.com>
193 Unreviewed, green the Mac bots by boosting the timeout on JSC tests. One of the
194 Mozilla tests appears to run for a longer time.
196 I think we want to continue to allow a few tests here and there to be
197 longer-running, rather than excluding them. I seem to recall that those tests
200 * Scripts/run-javascriptcore-tests:
202 2013-09-05 Filip Pizlo <fpizlo@apple.com>
204 Unreviewed, don't run fast/js tests in run-javascriptcore-tests on platforms that
205 can't support it because if non-bourne shells. This fixes part #2 of the Linux
208 * Scripts/run-javascriptcore-tests:
210 2013-09-05 Filip Pizlo <fpizlo@apple.com>
212 Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.
214 * Scripts/run-javascriptcore-tests:
217 2013-09-04 Filip Pizlo <fpizlo@apple.com>
219 jsc tests should have timeouts
220 https://bugs.webkit.org/show_bug.cgi?id=120725
222 Reviewed by Geoffrey Garen.
224 Set the timeout to 20 seconds per test for now.
226 * Scripts/run-javascriptcore-tests:
228 2013-09-04 Filip Pizlo <fpizlo@apple.com>
230 run-javascriptcore-tests should run-fast-jsc as well
231 https://bugs.webkit.org/show_bug.cgi?id=120722
233 Reviewed by Geoffrey Garen.
235 Makes run-javascriptcore-tests run the fast/js tests via run-fast-jsc tool.
236 Integrates run-fast-jsc's error reporting into run-javascriptcore-tests.
238 * Scripts/run-javascriptcore-tests:
241 2013-09-04 Sergio Correia <sergio.correia@openbossa.org>
243 [EFL][WK2] Move ShouldGoToBackForwardListItem to the list of passing API tests
244 https://bugs.webkit.org/show_bug.cgi?id=120646
246 Reviewed by Gyuyoung Kim.
248 * TestWebKitAPI/PlatformEfl.cmake: Move ShouldGoToBackForwardListItem to the
249 list of passing tests, since it started to pass after r154045.
251 2013-09-04 Krzysztof Czech <k.czech@samsung.com>
253 [ATK] Adds an accessibility support to access a value of the color control element
254 https://bugs.webkit.org/show_bug.cgi?id=114354
256 Reviewed by Mario Sanchez Prada.
258 Added accessibility role of the color control element.
260 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
262 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
265 2013-09-04 Mario Sanchez Prada <mario.prada@samsung.com>
267 REGRESSION (r132328): /WebKit2APITests/TestWebKitAccessibility unit test is failing
268 https://bugs.webkit.org/show_bug.cgi?id=100408
270 Unreviewed gardening. Unskip TestWebKitAccessibility after
271 manually checking that it's running properly in the bot.
273 * Scripts/run-gtk-tests:
274 (TestRunner): Unskipped TestWebKitAccessibility.
276 2013-09-04 Zan Dobersek <zdobersek@igalia.com>
278 [GTK] Add support for the Wayland build target
279 https://bugs.webkit.org/show_bug.cgi?id=120627
281 Reviewed by Gustavo Noronha Silva.
283 * GNUmakefile.am: Define the additional macros also if building the Wayland target.
285 2013-09-04 Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk>
287 [GStreamer] cannot play live streams
288 https://bugs.webkit.org/show_bug.cgi?id=116831
290 Reviewed by Philippe Normand.
292 Fix timeout issues with rtspsrc/udpsrc gstreamer elements.
294 * gtk/jhbuild.modules:
295 * gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Added.
296 * gtk/patches/udpsrc-improve-timeouts.patch: Added.
297 Changed gstreamer jhbuild modules to use tarball repos (required to add patches)
298 and added 2 patches to gst-plugins-good to fix timeout issues with rtsp streams.
299 Both patches are applied upstream and can be removed once a new gstreamer release
300 is out (up to 1.0.10 the patches are not included) and we bump the requirements.
302 2013-09-03 Alexey Proskuryakov <ap@apple.com>
304 [Mac] WebKitTestRunner still beeps sometimes
305 https://bugs.webkit.org/show_bug.cgi?id=120652
307 Reviewed by Tim Horton.
309 In bug 107251, we disabled beeping in WebProcess, but some of the beeps happen in
310 UI process (notably, AppKit beeps when handling a key equivalent returns NO).
312 * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
313 Use the same SPI that we use in DRT and in WebProcess to disable beeping.
315 2013-09-03 Krzysztof Czech <k.czech@samsung.com>
317 [AX][ATK] Added support for sort and help attributes
318 https://bugs.webkit.org/show_bug.cgi?id=120456
320 Reviewed by Chris Fleizach.
322 Added missing implementation to AccessibilityUIElement::helpText and support for
325 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
326 (coreAttributeToAtkAttribute):
327 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
328 (WTR::coreAttributeToAtkAttribute):
329 (WTR::AccessibilityUIElement::helpText):
331 2013-09-03 Allan Sandfeld Jensen <allan.jensen@digia.com>
333 [Qt][WK1] PageVisibility tests are flaky
334 https://bugs.webkit.org/show_bug.cgi?id=120418
336 Reviewed by Jocelyn Turcotte.
338 Implement resetPageVisibility so we can reset visibility without
339 emiting visibility state change events.
341 * DumpRenderTree/qt/TestRunnerQt.cpp:
342 (TestRunner::resetPageVisibility):
344 2013-09-03 ChangSeok Oh <changseok.oh@collabora.com>
346 [GTK] libsoup upversion to fix a gstreamer issue, bug115354
347 https://bugs.webkit.org/show_bug.cgi?id=120613
349 Reviewed by Philippe Normand.
351 Up version of libsoup to 2.43.90. But the exact version which we'll use is not 2.43.90.
352 To fix bug115354, we need the Andre's patch for libsoup, but the lastest release
353 does not contain it. https://bugzilla.gnome.org/show_bug.cgi?id=706338
354 For the reason, we'll use libsoup git repo directly for a while until the next
357 * gtk/jhbuild.modules:
359 2013-09-02 Darin Adler <darin@apple.com>
361 [Mac] No need for HardAutorelease, which is same as CFBridgingRelease
362 https://bugs.webkit.org/show_bug.cgi?id=120569
364 Reviewed by Andy Estes.
366 * DumpRenderTree/mac/DumpRenderTree.mm:
367 (dump): Use CFBridgingRelease.
369 2013-09-02 Anton Obzhirov <a.obzhirov@samsung.com>
371 <https://webkit.org/b/98350> [GTK] accessibility/aria-invalid.html times out
373 Reviewed by Mario Sanchez Prada.
375 Added few mappings in DumpRenderTree and WebKitTestRunner for aria-invalid in order to get the tests run properly.
377 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
378 (axObjectEventListener):
379 Added mapping for invalid-entry event parameter.
380 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
381 (coreAttributeToAtkAttribute):
382 Added mapping to aria-invalid.
383 (AccessibilityUIElement::stringAttributeValue):
384 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
385 (WTR::coreAttributeToAtkAttribute):
386 Added mapping to aria-invalid.
388 2013-09-02 Nick Diego Yamane <nick.yamane@openbossa.org>
390 Save md5 correctly when jhbuildPath doesn't exist yet
391 https://bugs.webkit.org/show_bug.cgi?id=120548
393 Reviewed by Gustavo Noronha Silva.
395 After r152605, Md5 for jhbuild files are saved before the update
396 process, this prevents the script to restart update from scratch
397 when initial checkouts fail. However it causes an issue when builddir
398 (or builddir/Dependencies) doesn't exist yet. In that case the
399 saveJhbuildMd5 function fails to create md5 files.
400 This patch adds a checking for the jhbuildPath and creates it if
401 necessary before trying to open the md5 files.
403 * Scripts/update-webkit-libs-jhbuild:
406 2013-09-02 Mario Sanchez Prada <mario.prada@samsung.com>
408 Unreviewed. Move myself to the reviewers list.
410 * Scripts/webkitpy/common/config/contributors.json:
412 2013-09-01 Alexey Proskuryakov <ap@apple.com>
414 [WK2][Mac] Drag and drop tests interfere with user's UI
415 https://bugs.webkit.org/show_bug.cgi?id=120538
417 Reviewed by Dan Bernstein.
419 This makes running WebKit2 regression tests locally more viable. The patch doesn't
420 fix drag and drop tests to work as expected, I posted some thought about that in
421 <https://bugs.webkit.org/show_bug.cgi?id=68552>.
423 * WebKitTestRunner/EventSenderProxy.h:
424 (WTR::EventSenderProxy::position):
425 * WebKitTestRunner/TestController.h:
426 (WTR::TestController::eventSenderProxy):
427 Expose a way to get current mouse position from anywhere in WKTR code.
429 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new files.
431 * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseUp):
432 Copied a FIXME comment from DumpRenderTree.
434 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
435 (-[TestRunnerWKView dragImage:at:offset:event:pasteboard:source:slideBack:]):
436 Override drag initiation, using a custom NSDraggingInfo implementation.
438 * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
439 Replace NSEvent with a custom class.
441 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h: Added.
442 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Added.
443 * WebKitTestRunner/mac/WebKitTestRunnerEvent.h: Added.
444 * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Added.
445 Largely a copy of DumpRenderTree classes, modified to not use global variables.
446 We should consider making these variables static in EventSenderProxy though, as
447 it's strange that mouse state in WKTR is reset between tests without WebKit ever
448 being told about that.
450 2013-08-30 Brent Fulgham <bfulgham@apple.com>
452 [Windows] Unreviewed build fix.
454 * win/AssembleBuildLogs/AssembleLogs.cmd: Make sure WebInspectorUI build output is reported
455 from the build machines.
457 2013-08-30 Gabor Abraham <abrhm@inf.u-szeged.hu>
459 [Qt] Remove qt-5.0-wk2 from the baseline search paths because the migration of expectations to qt-wk2 is done.
460 https://bugs.webkit.org/show_bug.cgi?id=120464
462 Reviewed by Jocelyn Turcotte.
464 * Scripts/webkitpy/port/qt.py:
465 (QtPort._search_paths):
466 * Scripts/webkitpy/port/qt_unittest.py:
469 2013-08-29 Filip Pizlo <fpizlo@apple.com>
471 Just linking LLVM into JSC causes all plugin tests to fail
472 https://bugs.webkit.org/show_bug.cgi?id=113915
474 Reviewed by Oliver Hunt.
476 Hide all LLVM symbols. This should prevent us from exporting LLVM's overrides for
477 raise/abort/__assert_rtn.
479 * Scripts/configure-llvm:
481 2013-08-29 Joseph Pecoraro <pecoraro@apple.com>
483 new-run-webkit-tests does not respect --no-sample-on-timeout switch
484 https://bugs.webkit.org/show_bug.cgi?id=120491
486 Reviewed by Darin Adler.
488 * Scripts/webkitpy/port/server_process.py:
489 (ServerProcess._handle_timeout):
491 2013-08-29 Sam Weinig <sam@webkit.org>
493 Add ENABLE guards for Promises
494 https://bugs.webkit.org/show_bug.cgi?id=120488
496 Reviewed by Andreas Kling.
498 * Scripts/webkitperl/FeatureList.pm:
499 * qmake/mkspecs/features/features.pri:
501 2013-08-29 Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk>
503 [GTK] Should enable WebGL by default on MiniBrowser
504 https://bugs.webkit.org/show_bug.cgi?id=120420
506 Reviewed by Gustavo Noronha Silva.
508 Enable WebGL by default on MiniBrowser.
510 * MiniBrowser/gtk/main.c:
513 2013-08-28 Simon Fraser <simon.fraser@apple.com>
515 Add a Command-R shortcut in MiniBrowser
516 https://bugs.webkit.org/show_bug.cgi?id=120442
518 Reviewed by Dean Jackson.
520 Add a "Reload Page" item to the View menu with a Command-R
523 * MiniBrowser/mac/MainMenu.xib:
525 2013-08-29 Alberto Garcia <berto@igalia.com>
527 [GTK] Update apt dependency list
528 https://bugs.webkit.org/show_bug.cgi?id=120399
530 Reviewed by Philippe Normand.
532 Remove bogus package gail-3.0, add xfonts-utils (needed by
533 xorg-xserver) and switch to the latest versions of libtiff and
536 * gtk/install-dependencies:
538 2013-08-28 Alexey Proskuryakov <ap@apple.com>
540 [WK2][Mac] WebKitTestRunner doesn't force system appearance
541 https://bugs.webkit.org/show_bug.cgi?id=120437
543 Reviewed by Darin Adler.
545 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
546 (WTR::InjectedBundle::platformInitialize): Set AppleAquaColorVariant,
547 AppleHighlightColor and AppleOtherHighlightColor to the same values that DRT uses.
550 2013-08-16 Ryosuke Niwa <rniwa@webkit.org>
552 <https://webkit.org/b/119806> [Mac] Add a way to easily test attributed string generation
554 Reviewed by Darin Adler.
556 Add textInputController.legacyAttributedString to retrieve the attributed string for copy & paste.
558 We can't use textInputController.attributedSubstringFromRange as it uses WebHTMLConverter's static
559 editingAttributedStringFromRange function, which doesn't implement the full converter at the moment.
561 Also NSMutableAttributedString.ranges and WebNSRange so that JavaScript can get a list of all
562 ranges in a given attributed string.
564 * DumpRenderTree/mac/TextInputController.m:
565 (-[WebNSRange initWithNSRange:]):
566 (-[WebNSRange location]):
567 (-[WebNSRange length]):
568 (+[WebNSRange isSelectorExcludedFromWebScript:]):
569 (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
570 (+[NSMutableAttributedString webScriptNameForSelector:]):
571 (-[NSMutableAttributedString ranges]): Added.
572 (+[TextInputController isSelectorExcludedFromWebScript:]):
573 (+[TextInputController webScriptNameForSelector:]):
574 (-[TextInputController legacyAttributedString:]):
576 2013-08-28 Denis Nomiyama <d.nomiyama@samsung.com>
578 [GTK] accessibility/menu-list-sends-change-notification.html has incorrect expected results
579 https://bugs.webkit.org/show_bug.cgi?id=120419
581 Reviewed by Chris Fleizach.
583 Added a notification for AXFocusedUIElementChanged.
585 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
586 (axObjectEventListener): Added a notification for AXFocusedUIElementChanged.
588 2013-08-28 Roger Fong <roger_fong@apple.com>
590 Decrease number of workers used in NRWT by the Windows port.
591 https://bugs.webkit.org/show_bug.cgi?id=120435.
593 Reviewed by Brent Fulgham.
595 * Scripts/webkitpy/port/win.py:
596 (WinPort.default_child_processes):
598 2013-08-28 Allan Sandfeld Jensen <allan.jensen@digia.com>
600 Http tests fails on Debian with Apache 2.4
601 https://bugs.webkit.org/show_bug.cgi?id=120352
605 Remember to update unit-test expectations and old-run-webkit-tests as well.
607 * Scripts/webkitperl/httpd.pm:
608 (getHTTPDConfigPathForTestDirectory):
609 * Scripts/webkitpy/port/port_testcase.py:
610 (test_apache_config_file_name_for_platform):
612 2013-08-28 Allan Sandfeld Jensen <allan.jensen@digia.com>
614 Http tests fails on Debian with Apache 2.4
615 https://bugs.webkit.org/show_bug.cgi?id=120352
617 Reviewed by Andreas Kling.
619 Select httpd.conf file for debian based on version, matching Fedora behavior.
621 * Scripts/webkitpy/port/base.py:
622 (Port._apache_config_file_name_for_platform):
624 2013-08-28 Commit Queue <commit-queue@webkit.org>
626 Unreviewed, rolling out r154593.
627 http://trac.webkit.org/changeset/154593
628 https://bugs.webkit.org/show_bug.cgi?id=120403
630 Caused 50+ flaky tests on WebKit1 bots (Requested by carewolf
633 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
636 2013-08-28 Allan Sandfeld Jensen <allan.jensen@digia.com>
638 [Qt][Wk2] Many tests are flaky on Qt 5.1
639 https://bugs.webkit.org/show_bug.cgi?id=118232
641 Reviewed by Jocelyn Turcotte.
643 We need to set renderToOffscreenBuffer since we won't otherwise get
644 the paint calls necessary to synchronize UI- and Web-Process. It was
645 only disabled in Qt 5.0 because it conflicted with setRenderWithoutShowing
646 which is no longer supported or needed.
648 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
649 (WTR::WrapperWindow::handleStatusChanged):
651 2013-08-27 Alexey Proskuryakov <ap@apple.com>
653 [WK2] Remove USE_WEBPROCESS_EVENT_SIMULATION
654 https://bugs.webkit.org/show_bug.cgi?id=120379
656 Reviewed by Darin Adler.
658 All major platforms have implemented UI process eventSender support, keeping old
659 web process side code only adds confusion.
661 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
662 (WTR::EventSendingController::EventSendingController):
663 (WTR::EventSendingController::mouseDown):
664 (WTR::EventSendingController::mouseUp):
665 (WTR::EventSendingController::mouseMoveTo):
666 (WTR::EventSendingController::leapForward):
667 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
668 * WebKitTestRunner/TestController.cpp:
669 (WTR::TestController::resetStateToConsistentValues):
670 (WTR::TestController::didReceiveMessageFromInjectedBundle):
671 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
672 * WebKitTestRunner/TestController.h:
674 2013-08-27 Roger Fong <roger_fong@apple.com>
676 NRWT on AppleWin port should delete semaphore lock files during cleanup tasks.
677 https://bugs.webkit.org/show_bug.cgi?id=120370.
679 Reviewed by Brent Fulgham.
681 * Scripts/webkitpy/port/win.py:
682 (WinPort.delete_sem_locks):
683 (WinPort.setup_test_run):
685 2013-08-27 Denis Nomiyama <d.nomiyama@samsung.com>
687 [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation
688 https://bugs.webkit.org/show_bug.cgi?id=119883
690 Implemented the notification listener for AccessibilityUIElement. The signal is generated
691 by AXObjectCache::postPlatformNotification() and received by axObjectEventListener().
692 axObjectEventListener will then invoke JSObjectCallAsFunction() with the respective
693 callback function. The global callback function and callbacks for specific elements are
694 stored in a HashMap in AccessibilityCallbacksAtk.cpp.
696 Reviewed by Chris Fleizach.
698 * DumpRenderTree/AccessibilityUIElement.h: Added a notification handler for GTK+
699 * DumpRenderTree/atk/AccessibilityCallbacks.h: Added addAccessibilityNotificationListener()
700 and removeAccessibilityNotificationListener()
701 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
702 (axObjectEventListener): Call JS callback for global notification or for a specific element
703 (disconnectAccessibilityCallbacks): Only disconnect if logging is off and there is no
705 (addAccessibilityNotificationHandler): Add notification listener to the list
706 (removeAccessibilityNotificationHandler): Remove notification listener from the list
707 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
708 (AccessibilityController::setLogAccessibilityEvents): Set logging off before disconnecting
709 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
710 (AccessibilityNotificationHandler::AccessibilityNotificationHandler): Create handler
711 (AccessibilityNotificationHandler::~AccessibilityNotificationHandler): Destroy handler.
712 Remove handler from the list and disconnect callbacks
713 (AccessibilityNotificationHandler::setNotificationFunctionCallback): Set the notification
714 callback and connect callbacks to signals
715 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Added.
716 (AccessibilityNotificationHandler::setPlatformElement): Set platform element
717 (AccessibilityNotificationHandler::platformElement): Get platform element
718 (AccessibilityNotificationHandler::notificationFunctionCallback): Get notification callback
719 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
720 (AccessibilityUIElement::addNotificationListener): Create notification handler, set the
721 platform element and the notification callback
722 (AccessibilityUIElement::removeNotificationListener):
723 * DumpRenderTree/efl/CMakeLists.txt: Added AccessibilityNotificationHandlerAtk.cpp/h
724 * GNUmakefile.am: Added AccessibilityNotificationHandlerAtk.cpp/h
726 2013-08-27 Carlos Garcia Campos <cgarcia@igalia.com>
728 Unreviewed. Fix GTK+ build after r154601.
730 * TestWebKitAPI/GNUmakefile.am: Remove mac specific file from
731 compilation added by mistake in r154601.
733 2013-08-26 Alexey Proskuryakov <ap@apple.com>
735 WebKitTestRunner needs to protect the user's pasteboard contents while running
736 https://bugs.webkit.org/show_bug.cgi?id=81419
737 <rdar://problem/11066794>
739 Reviewed by Darin Adler.
741 Mostly a copy/paste of DRT code.
743 Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
744 doesn't interfere with my clipboard while being run in a loop.
746 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
747 * WebKitTestRunner/mac/PoseAsClass.h: Added.
748 * WebKitTestRunner/mac/PoseAsClass.mm: Added.
749 * WebKitTestRunner/mac/TestControllerMac.mm:
750 (WTR::TestController::platformInitialize):
751 (WTR::TestController::platformDestroy):
752 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
753 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
755 2013-08-26 Commit Queue <commit-queue@webkit.org>
757 Unreviewed, rolling out r154640.
758 http://trac.webkit.org/changeset/154640
759 https://bugs.webkit.org/show_bug.cgi?id=120329
761 Caused flaky crashes on a lot of editing tests (Requested by
764 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
765 * WebKitTestRunner/mac/PoseAsClass.h: Removed.
766 * WebKitTestRunner/mac/PoseAsClass.mm: Removed.
767 * WebKitTestRunner/mac/TestControllerMac.mm:
768 (WTR::TestController::platformInitialize):
769 (WTR::TestController::platformDestroy):
770 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Removed.
771 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Removed.
773 2013-08-26 Dan Bernstein <mitz@apple.com>
775 Automatic bug reports case pain
776 https://bugs.webkit.org/show_bug.cgi?id=120330
778 Reviewed by Anders Carlsson.
780 * Scripts/webkitpy/tool/commands/download.py: Made the following changes to the Description
781 of bugs filed by the bot: changed “the sheriff-bot” to “webkitbot”, changed “case pain” to
782 “fail”, and removed “"Only you can prevent forest fires." -- Smokey the Bear”.
784 2013-08-23 Andy Estes <aestes@apple.com>
786 Fix issues found by the Clang Static Analyzer
787 https://bugs.webkit.org/show_bug.cgi?id=120230
789 Reviewed by Darin Adler.
791 * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
792 (-[LocalPasteboard initWithName:]): Called [super init] first so that we
793 don't later use ivars from the wrong self.
794 * DumpRenderTree/mac/TestRunnerMac.mm:
795 (-[APITestDelegate initWithCompletionCondition:]): Ditto.
796 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
797 (TestWebKitAPI::TEST): Don't leak WKProcessGroups,
798 WKBrowsingContextGroups, and WKViews.
800 2013-08-26 Alexey Proskuryakov <ap@apple.com>
802 WebKitTestRunner needs to protect the user's pasteboard contents while running
803 https://bugs.webkit.org/show_bug.cgi?id=81419
804 <rdar://problem/11066794>
806 Reviewed by Darin Adler.
808 Mostly a copy/paste of DRT code.
810 Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
811 doesn't interfere with my clipboard while being run in a loop.
813 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
814 * WebKitTestRunner/mac/PoseAsClass.h: Added.
815 * WebKitTestRunner/mac/PoseAsClass.mm: Added.
816 * WebKitTestRunner/mac/TestControllerMac.mm:
817 (WTR::TestController::platformInitialize):
818 (WTR::TestController::platformDestroy):
819 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
820 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
822 2013-08-26 Zan Dobersek <zdobersek@igalia.com>
824 [GTK] Include most of the WebKit2 unit tests into the build and testing
825 https://bugs.webkit.org/show_bug.cgi?id=120307
827 Reviewed by Philippe Normand.
829 There are still various unit test source files that are not being included into
830 the build. This patch includes most of these, only leaving out tests that do not
831 compile or test features that are not supported by the GTK port.
833 * Scripts/run-gtk-tests: Skip four newly-added tests that are failing or timing out.
835 * TestWebKitAPI/GNUmakefile.am:
837 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
839 [GTK] Allow to run tests without Xvfb in run-gtk-tests
840 https://bugs.webkit.org/show_bug.cgi?id=120298
842 Reviewed by Philippe Normand.
844 Add --no-xvfb command line option to run tests in the current
847 * Scripts/run-gtk-tests:
848 (TestRunner._run_xvfb): Return early if option --no-xvfb has been
850 (TestRunner._setup_testing_environment): Use helper function
851 _run_xvfb to start Xvfb if needed.
852 (TestRunner._tear_down_testing_environment): Check Xvfb is
853 actually running before trying to terminate it.
855 2013-08-26 Zoltan Arvai <zarvai@inf.u-szeged.hu>
857 Adding Gabor Abraham to contributors.json.
859 Reviewed by Csaba Osztrogonác.
861 * Scripts/webkitpy/common/config/contributors.json:
863 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
865 [GTK] Add support for passing test directories to run-gtk-tests
866 https://bugs.webkit.org/show_bug.cgi?id=120296
868 Reviewed by Philippe Normand.
870 * Scripts/run-gtk-tests:
871 (TestRunner._get_tests_from_dir): Helper function to return all
872 unit tests found in a given directory.
873 (TestRunner._get_tests): Check the given tests passed in the
874 command line, so that if a directory is found the tests contained
875 in the directory are added to the list of tests to run.
877 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
879 [GTK] Improve the stop/reload button implementation in MiniBrowser
880 https://bugs.webkit.org/show_bug.cgi?id=120292
882 Reviewed by Philippe Normand.
884 - Use an instance member of BrowserWindow for the button widget
885 instead of a global variable.
886 - Use notify::is-loading to monitor the WebView load instead of
887 the estimated-load-progress property.
888 - Use webkit_web_view_is_loading() to check whether the view
889 is loading to change the button icon instead of a string
890 comparison of the gtk stock icon id.
891 - Use the right casts to fix compile warning.
893 * MiniBrowser/gtk/BrowserWindow.c:
894 (reloadOrStopCallback):
895 (webViewLoadProgressChanged):
896 (webViewIsLoadingChanged):
897 (browser_window_init):
898 (browserWindowConstructed):
900 2013-08-26 Arunprasad Rajkumar <arurajku@cisco.com>
902 [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433)
903 https://bugs.webkit.org/show_bug.cgi?id=119791
905 Reviewed by Jocelyn Turcotte.
907 Load empty url to send onunload event to currently running page. onunload event is
908 mandatory for LayoutTests/plugins/open-and-close-window-with-plugin.html and
909 LayoutTests/plugins/geturlnotify-during-document-teardown.html.
911 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
914 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
916 [GTK] Silence MiniBrowser compile warnings due to recent GTK+ deprecations
917 https://bugs.webkit.org/show_bug.cgi?id=120290
919 Reviewed by Philippe Normand.
921 * MiniBrowser/gtk/GNUmakefile.am: Add
922 -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6 compile option.
924 2013-08-26 Zan Dobersek <zdobersek@igalia.com>
926 [GTK] Add WillLoad test files to the TestWebKitAPI/TestWebKit2 program
927 https://bugs.webkit.org/show_bug.cgi?id=120288
929 Reviewed by Carlos Garcia Campos.
931 * TestWebKitAPI/GNUmakefile.am: Add the WillLoad.cpp build target that should be compiled
932 into the TestWebKit2 program. The InjectedBundle counterpart file is added to the build as well.
933 These unit tests are at the moment failing in debug configurations, so it would be nice to
934 have the GTK builds report these failures as well.
936 2013-08-25 Ryuan Choi <ryuan.choi@samsung.com>
938 [EFL] EWebLauncher is executed as full screen with device pixel ratio
939 https://bugs.webkit.org/show_bug.cgi?id=120282
941 Reviewed by Gyuyoung Kim.
943 * EWebLauncher/main.c:
944 Use double instead of float for device_pixel_ratio which is passed to ECORE_GETOPT_VALUE_DOUBLE.
946 2013-08-25 Zan Dobersek <zdobersek@igalia.com>
948 [gdb] Remove the pretty printer for KURLGooglePrivate
949 https://bugs.webkit.org/show_bug.cgi?id=120263
951 Reviewed by Benjamin Poulain.
953 Remove the pretty printer for the WebCore::KURLGooglePrivate structure that
954 was usable inside the gdb debugger. The structure was remove from the codebase
955 along with the GoogleURL backend for KURL.
958 (JSCJSStringPrinter.to_string):
959 (add_pretty_printers):
961 2013-08-24 Filip Pizlo <fpizlo@apple.com>
963 Unreviewed, fix build-webkit --ftl-jit in the case that you have your own llvm directory. We need to
964 prune 'libgtest' and friends from the llvm build, since WebKit builds its own and none of the llvm
965 libraries depend on libgtest anyway.
967 * Scripts/copy-webkitlibraries-to-product-directory:
969 2013-08-24 Darin Adler <darin@apple.com>
971 RetainPtr lacks move constructor for case when argument is a RetainPtr of a different type
972 https://bugs.webkit.org/show_bug.cgi?id=120255
974 Reviewed by Andreas Kling.
976 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added four tests covering move assignment and construction.
978 2013-08-24 Anders Carlsson <andersca@apple.com>
980 Don't treat NSLocalizedDescriptionKey and NSLocalizedRecoverySuggestionErrorKey as NSLocalized macros
981 https://bugs.webkit.org/show_bug.cgi?id=120249
983 Reviewed by Andreas Kling.
985 * Scripts/extract-localizable-strings:
987 2013-08-24 Carlos Garcia Campos <cgarcia@igalia.com>
989 [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API
990 https://bugs.webkit.org/show_bug.cgi?id=119743
992 Reviewed by Anders Carlsson.
994 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
995 (WTR::InjectedBundlePage::InjectedBundlePage): Add
998 2013-08-23 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
1000 Move TestWebKitAPI_LIBRARIES before platform specific cmake include
1001 https://bugs.webkit.org/show_bug.cgi?id=120220
1003 Reviewed by Martin Robinson.
1005 * TestWebKitAPI/CMakeLists.txt:
1007 2013-08-22 Filip Pizlo <fpizlo@apple.com>
1009 build-jsc --ftl-jit should work
1010 https://bugs.webkit.org/show_bug.cgi?id=120194
1012 Reviewed by Oliver Hunt.
1014 * Scripts/build-jsc: Need to pass the feature flag to xcodebuild
1016 2013-08-23 Commit Queue <commit-queue@webkit.org>
1018 Unreviewed, rolling out r153534.
1019 http://trac.webkit.org/changeset/153534
1020 https://bugs.webkit.org/show_bug.cgi?id=120216
1022 Too many tests failing just WinEWS bots (Requested by rfong on
1025 * Scripts/webkitpy/common/config/ews.json:
1027 2013-08-23 Alex Christensen <alex.christensen@flexsim.com>
1029 Unreviewed. Added my webkit.org email address.
1031 * Scripts/webkitpy/common/config/contributors.json:
1033 2013-08-23 Peter Gal <galpeter@inf.u-szeged.hu>
1035 [WTR] Should dump as text when the mimetype is text/plain
1036 https://bugs.webkit.org/show_bug.cgi?id=118306
1038 Reviewed by Christophe Dumez.
1040 Check for the text/plain mimetype and if true then mark it as
1043 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1044 (WTR::InjectedBundlePage::dump):
1046 2013-08-22 Filip Pizlo <fpizlo@apple.com>
1048 Update LLVM binary drops and scripts to the latest version from SVN
1049 https://bugs.webkit.org/show_bug.cgi?id=120184
1051 Reviewed by Mark Hahnenberg.
1053 * ReducedFTL/build.sh:
1054 * Scripts/configure-llvm: Added.
1055 * Scripts/copy-webkitlibraries-to-product-directory:
1056 * Scripts/export-llvm-build:
1058 2013-08-22 Andy Estes <aestes@apple.com>
1060 <https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files
1062 Reviewed by David Kilzer.
1064 * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of
1065 OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
1066 DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.
1068 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
1070 NRWT: Add the ability to upload test results to new test results server
1071 https://bugs.webkit.org/show_bug.cgi?id=120146
1073 Reviewed by Andreas Kling.
1075 For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
1076 that contains the full summary of the test run including information about passed tests.
1078 Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
1081 --results-server-host
1083 The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
1084 so we should be able to delete --test-results-server in time.
1086 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1088 (Manager._upload_json_files):
1090 (Manager.upload_results):
1091 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1092 (summarize_results):
1093 * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1094 (summarized_results):
1095 (SummarizedResultsTest.test_summarized_results_wontfix):
1096 (SummarizedResultsTest):
1097 (SummarizedResultsTest.test_summarized_results_include_passes):
1098 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1101 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
1103 WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
1105 * Scripts/webkitpy/tool/bot/irc_command.py:
1108 2013-08-22 Allan Sandfeld Jensen <allan.jensen@digia.com>
1110 [Qt] DRT bug revealed/caused by r154300
1111 https://bugs.webkit.org/show_bug.cgi?id=120151
1113 Reviewed by Simon Hausmann.
1115 Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
1116 the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
1119 DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
1120 between native Qt methods and JSC bound methods. This patch changes the check to see if the
1121 property is writable since the Qt methods are ReadOnly.
1123 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1124 (DumpRenderTree::initJSObjects):
1126 2013-08-21 Joseph Pecoraro <pecoraro@apple.com>
1128 <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
1130 Reviewed by Benjamin Poulain.
1132 WTFString moved the is8bit bit by one in r152201.
1134 * lldb/lldb_webkit.py:
1135 (WTFStringImplProvider.is_8bit):
1137 2013-08-21 Tim Horton <timothy_horton@apple.com>
1139 Revert http://trac.webkit.org/changeset/154022, as it failed to update
1140 a variety of scripts that depended on the old format.
1142 See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
1144 * Scripts/prepare-ChangeLog:
1146 (generateNewChangeLogs):
1148 2013-08-21 Brent Fulgham <bfulgham@apple.com>
1150 [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
1152 * WinLauncher/WinLauncher.cpp:
1153 (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
1155 2013-08-21 Zan Dobersek <zdobersek@igalia.com>
1157 <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
1159 Reviewed by Andreas Kling.
1161 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1162 (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
1163 (WTR::activateFonts): Ditto.
1165 2013-08-21 Brian Holt <brian.holt@samsung.com>
1167 [GTK] Suppress irrelevant or known leaks for Valgrind
1168 https://bugs.webkit.org/show_bug.cgi?id=119448
1170 Reviewed by Martin Robinson.
1172 Add a suppressions file to suppress known leaks for Valgrind.
1173 Valgrind also takes longer when using suppressions and
1174 times out unless the driver timeout is increased.
1176 * Scripts/valgrind/suppressions.txt: Added.
1177 * Scripts/webkitpy/port/gtk.py:
1178 (GtkPort.driver_stop_timeout):
1179 (GtkPort.setup_environ_for_server):
1181 2013-08-20 Alex Christensen <achristensen@apple.com>
1183 [Windows] Linking fix for Win64.
1185 Rubberstamped by Brent Fulgham.
1187 * win/DLLLauncher/DLLLauncherMain.cpp:
1188 (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
1190 2013-08-20 Brent Fulgham <bfulgham@apple.com>
1192 <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
1194 Reviewed by Tim Horton.
1196 * win/DLLLauncher/DLLLauncherMain.cpp:
1197 (getLastErrorString): New method to convert GetLastError to text.
1198 (wWinMain): Use new error formatter to provide useful diagnostic text to user.
1200 2013-08-19 Gustavo Noronha Silva <gns@gnome.org>
1202 <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
1204 Reviewed by Martin Robinson.
1206 * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
1207 from naming/enum_casing rules, since it needs to provide GObject-style APIs.
1209 2013-08-20 Anton Obzhirov <a.obzhirov@samsung.com>
1211 <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
1213 Reviewed by Martin Robinson.
1215 Added stop button in MiniBrowser
1217 * MiniBrowser/gtk/BrowserWindow.c:
1218 (reloadOrStopCallback): Callback to handle stop or reload button click.
1219 (webViewLoadProgressChanged): Update reload or stop button icon.
1220 (browser_window_init): Save button pointer for further icon updates.
1222 2013-08-20 Simon Pena <simon.pena@samsung.com>
1224 <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
1226 Reviewed by Alexey Proskuryakov.
1228 Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
1229 printing didFailLoadWithError.
1231 Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
1232 DumpRenderTree, printing didFailLoadWithError.
1234 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1235 (webFrameLoadStatusNotified):
1237 2013-08-19 Ryosuke Niwa <rniwa@webkit.org>
1239 <https://webkit.org/b/120049> Delete code for Snow Leopard
1241 Reviewed by Benjamin Poulain.
1243 * DumpRenderTree/mac/CheckedMalloc.cpp:
1244 (protectionOfRegion):
1245 (makeLargeMallocFailSilently):
1246 * DumpRenderTree/mac/DumpRenderTree.mm:
1247 (resetDefaultsToConsistentValues):
1248 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1249 (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1250 * DumpRenderTree/mac/FrameLoadDelegate.mm:
1252 (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1253 * DumpRenderTree/mac/LayoutTestHelper.m:
1254 * DumpRenderTree/mac/TestRunnerMac.mm:
1255 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1256 (WTR::InjectedBundle::platformInitialize):
1257 * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
1258 (WTR::testPathFromURL):
1259 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1261 2013-08-19 Alexey Proskuryakov <ap@apple.com>
1263 https://bugs.webkit.org/show_bug.cgi?id=119915
1264 REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
1266 Reviewed by Darin Adler.
1268 The issue was that we ended up having no CFNetwork cache in the testing session due
1269 to an incorrect cache model. There is a number of things not implemented when it
1270 comes to dynamically changing cache model as attempted by WebKitTestRunner, but
1271 the easiest way to get this going is to initialize it to correct value upfront.
1273 * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1275 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
1277 REGRESSION(r154275): webkitpy tests failing
1278 https://bugs.webkit.org/show_bug.cgi?id=120010
1280 Reviewed by Jocelyn Turcotte.
1282 Update unit-tests to tests the new search-path structure,
1283 but reverting the architecture search path addition.
1285 * Scripts/webkitpy/port/qt.py:
1288 (QtPort._generate_all_test_configurations):
1289 (QtPort.qt_architecture):
1290 * Scripts/webkitpy/port/qt_unittest.py:
1292 (QtPortTest._assert_search_path):
1293 (QtPortTest._assert_expectations_files):
1294 (QtPortTest._qt_version):
1296 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
1298 [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
1300 Unreviewed meta gardening.
1302 We need to keep using the qt-5.0-wk2 path until it is fully migrated.
1304 * Scripts/webkitpy/port/qt.py:
1305 (QtPort._search_paths):
1307 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
1309 Restructure Qt test expectations
1311 Unreviewed meta gardening.
1313 Removed 5.0 name from WK1 and WK2 results and made it possible to set
1314 expectations by both Qt version and mayor architectures.
1316 * Scripts/webkitpy/port/qt.py:
1317 (QtPort._wk2_port_name):
1319 (QtPort.qt_version):
1320 (QtPort.architecture):
1321 (QtPort._search_paths):
1322 (QtPort._port_specific_expectations_files):
1324 2013-08-16 Brent Fulgham <bfulgham@apple.com>
1326 [Windows] DRT is not using the same preferences as the Mac build.
1327 https://bugs.webkit.org/show_bug.cgi?id=119822
1329 Reviewed by Darin Adler.
1331 * DumpRenderTree/win/DumpRenderTree.cpp:
1332 (runTest): Process Windows message queue using CFRunLoop to allow
1333 dispatch routines to run properly.
1334 (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
1335 to prevent problems on WinCairo port.
1337 2013-08-16 Brent Fulgham <bfulgham@apple.com>
1339 [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
1340 https://bugs.webkit.org/show_bug.cgi?id=119583
1342 Reviewed by Alexey Proskuryakov.
1344 * DumpRenderTree/win/DumpRenderTree.cpp:
1345 (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
1346 component if the URL does not contain the expected base URL.
1348 2013-08-16 Pratik Solanki <psolanki@apple.com>
1350 <https://webkit.org/b/119852> Frame::scriptController() should return a reference
1352 Reviewed by Andreas Kling.
1354 m_script is never NULL so we can just return a reference. Also remove some pointless null
1355 checks as a result of doing this.
1357 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1358 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1360 2013-08-15 Alexey Proskuryakov <ap@apple.com>
1362 [WK2] NetworkProcess should use a temporary storage session for test
1363 https://bugs.webkit.org/show_bug.cgi?id=119855
1365 Reviewed by Darin Adler.
1367 Use a new API that takes care of both WebProcess and NetworkProcess.
1369 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1370 (WTR::InjectedBundle::initialize):
1371 * WebKitTestRunner/TestController.cpp:
1372 (WTR::TestController::initialize):
1374 2013-08-15 Bem Jones-Bey <bjonesbe@adobe.com>
1376 <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
1378 Reviewed by Dirk Pranke.
1380 This is a port from Blink of
1381 https://src.chromium.org/viewvc/blink?revision=155647&view=revision
1382 originally by Dirk Pranke.
1384 From the original commit:
1386 This gives something like a 15x speedup over compiling and matching
1387 one property at a time and doing multiple passes over the file.
1389 * Scripts/webkitpy/w3c/test_converter.py:
1390 (W3CTestConverter.__init__):
1391 (W3CTestConverter.convert_prefixed_properties):
1392 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
1394 2013-08-15 Dan Bernstein <mitz@apple.com>
1396 <https://webkit.org/b/119856> Improve extract-localizable-strings messages
1398 Reviewed by Darin Adler.
1400 * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
1401 added a message that points to the source code. Removed some unnecessary repetition of what
1402 is already in the file.
1404 2013-08-15 Andy Estes <aestes@apple.com>
1406 <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
1408 Reviewed by Brady Eidson.
1410 Wrote an API test that verifies -[WebView stopLoading:] can be called
1411 inside webView:resource:didFinishLoadingFromDataSource: without crashing.
1413 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1414 * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
1415 (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
1416 (TestWebKitAPI::TEST):
1418 2013-08-15 Alexey Proskuryakov <ap@apple.com>
1420 Adding Myles Maxfield to contributors.json.
1422 Oops, wrong section, fixing.
1424 * Scripts/webkitpy/common/config/contributors.json:
1426 2013-08-15 Alexey Proskuryakov <ap@apple.com>
1428 Adding Myles Maxfield to contributors.json.
1430 * Scripts/webkitpy/common/config/contributors.json:
1432 2013-08-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
1434 [Qt] Do not check specifically for version 5.0
1435 https://bugs.webkit.org/show_bug.cgi?id=119846
1437 Reviewed by Jocelyn Turcotte.
1439 For Qt 5.x we should always use both wk1 and wk2 basepath results.
1441 * Scripts/webkitpy/port/qt.py:
1442 (QtPort._search_paths):
1444 2013-08-15 Simon Pena <simon.pena@samsung.com>
1446 <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
1448 Reviewed by Gustavo Noronha Silva.
1450 Following a similar approach as in r153977, return a path string
1451 that is relative to main frame URL or just file name if the
1452 resource is not in the same directory subtree, and replace empty
1453 strings with "(null)".
1455 Update pathFromSoupURI so it behaves more closely to the other
1456 ports, and remove the unused code after we no longer print
1457 <unknown> in certain cases. Also move
1458 soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
1459 be used both in TestRunnerGtk and in DumpRenderTree.
1461 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1462 (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
1463 we can print Soup URIs with the password, since soup_uri_to_string
1464 doesn't preserve them.
1465 (pathFromSoupURI): Updated following EFL implementation in
1466 r153977, and return a WTFString instead of a CString.
1467 (convertSoupMessageToURLPath): Return "(null)" instead of empty
1468 strings, and handle the new return type of pathFromSoupURI.
1469 (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
1470 reference, and handle the new return type of pathFromSoupURI.
1471 (descriptionSuitableForTestResult): Remove unused code.
1472 (didFinishLoading): Use convertResourceToURLPath.
1473 (didFailLoadingWithError): Use convertResourceToURLPath.
1474 (authenticationCallback): Display the URL of the authentication
1476 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
1477 soupURIToStringPreservingPassword.
1478 * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
1479 soupURIToStringPreservingPassword.
1481 2013-08-14 Tim Horton <timothy_horton@apple.com>
1483 Un-inline dataLog dumpers for IntSize and IntPoint
1484 https://bugs.webkit.org/show_bug.cgi?id=119697
1486 Reviewed by Sam Weinig.
1488 * TestWebKitAPI/GNUmakefile.am:
1490 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
1492 Flakiness dashboard build fix.
1494 * TestResultServer/static-dashboards/flakiness_dashboard.js:
1495 (processTestRunsForBuilder):
1497 2013-08-14 Martin Robinson <mrobinson@igalia.com>
1499 [GTK] [CMake] Add support for building TestWebKitAPI
1500 https://bugs.webkit.org/show_bug.cgi?id=116987
1502 Reviewed by Philippe Normand.
1504 * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
1505 platform-specific file, so that GTK+ can override them.
1506 * TestWebKitAPI/PlatformGTK.cmake: Added.
1508 2013-08-14 Brent Fulgham <bfulgham@apple.com>
1510 [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
1511 https://bugs.webkit.org/show_bug.cgi?id=119775
1513 This bug updates the WinLauncher program with a few useful menu
1514 options to toggle certain debugging and development features of
1517 Reviewed by Tim Horton.
1519 * WinLauncher/WinLauncher.cpp:
1520 (dllLauncherEntryPoint): Clean up preference objects on exit.
1521 (ToggleMenuItem): New function.
1522 (LaunchInspector): New function.
1523 (WndProc): Add handler for new menu items. Also properly terminate
1524 CFRunLoop operation on program exit.
1525 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
1527 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
1528 resource folder to search path.
1529 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
1532 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
1534 Add a hyperlink from build.webkit.org to the flakiness dashboard.
1536 Rubbers-tamped by Simon Fraser.
1538 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1540 2013-08-14 Benjamin Dupont <bdupont@nds.com>
1542 [Qt] Activate visibility API layout tests
1543 https://bugs.webkit.org/show_bug.cgi?id=119790
1545 Reviewed by Allan Sandfeld Jensen.
1547 * DumpRenderTree/qt/TestRunnerQt.cpp:
1548 (TestRunner::resetPageVisibility):
1549 (TestRunner::setPageVisibility):
1551 2013-08-13 Xabier Rodriguez Calvar <calvaris@igalia.com>
1553 [GTK] WK does not link properly against libxslt
1554 https://bugs.webkit.org/show_bug.cgi?id=119688
1556 Reviewed by Gustavo Noronha Silva.
1558 * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
1560 * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
1562 2013-08-13 Alexey Proskuryakov <ap@apple.com>
1564 [Mac] fast/dom/attr-style-too-lazy.html is flaky
1565 https://bugs.webkit.org/show_bug.cgi?id=119763
1567 Reviewed by Darin Adler.
1569 * DumpRenderTree/mac/UIDelegate.mm:
1570 (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
1571 a test, it would just semi-randomly leak to the next one.
1572 (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
1575 2013-08-13 Tim Horton <timothy_horton@apple.com>
1577 [mac] Give MiniBrowser a reasonable bundle identifier
1578 https://bugs.webkit.org/show_bug.cgi?id=119773
1580 Rubber-stamped by Simon Fraser.
1582 Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
1584 * MiniBrowser/mac/Info.plist:
1585 * MiniBrowser/mac/WebBundle/Info.plist:
1587 2013-08-13 Dean Jackson <dino@apple.com>
1589 <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
1591 Reviewed by Mark Rowe.
1593 Have prepare-ChangeLog produce webkit.org/b/id style
1594 URLs rather than exposing the inner workings of our
1595 cgi. I was going to use the term "Future Proofing"
1596 but that seems excessive :)
1598 * Scripts/prepare-ChangeLog:
1599 (main): Generate a more human readable form.
1600 (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
1602 2013-08-13 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
1604 [EFL][DRT] Simplify call to reverseFind()
1605 https://bugs.webkit.org/show_bug.cgi?id=119746
1607 Reviewed by Christophe Dumez.
1609 Follow-up to r153977.
1611 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1612 (pathSuitableForTestResult): Instead of defining a static variable
1613 that's only used in a single place, pass '/' to reverseFind() directly.
1615 2013-08-13 Alberto Garcia <berto@igalia.com>
1617 [GTK] Closing inspector window crashes wk
1618 https://bugs.webkit.org/show_bug.cgi?id=110865
1620 Reviewed by Carlos Garcia Campos.
1622 Disconnect all signal handlers if the inspector window is
1625 * GtkLauncher/LauncherInspectorWindow.c:
1626 (inspectorWindowDestroyed):
1627 (launcherInspectorWindowNew):
1629 2013-08-12 Dan Bernstein <mitz@apple.com>
1631 extract-localizable-strings output is not suited for parsing by Xcode
1632 https://bugs.webkit.org/show_bug.cgi?id=119728
1634 Reviewed by Darin Adler.
1636 Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
1637 removed “ERROR” since messages that refer to a line in a file are shown as error by default,
1638 added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
1641 * Scripts/extract-localizable-strings:
1643 2013-08-12 Ryuan Choi <ryuan.choi@samsung.com>
1645 [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
1646 https://bugs.webkit.org/show_bug.cgi?id=119585
1648 Reviewed by Gyuyoung Kim.
1650 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1651 (pathSuitableForTestResult):
1652 Return path string that's relative to main frame URL, or just file name if
1653 the resource is not in the same directory subtree.
1654 Referenced WebKitTestRunner code in r153852.
1655 (descriptionSuitableForTestResult):
1656 (DumpRenderTreeChrome::onFrameRedirectRequested):
1657 (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
1659 2013-08-12 Dan Bernstein <mitz@apple.com>
1661 extract-localizable-strings doesn't know how to verify an existing strings file
1662 https://bugs.webkit.org/show_bug.cgi?id=119704
1664 Reviewed by Darin Adler.
1666 * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
1667 exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
1668 exceptions file name to omitting the --exceptions option. Added a --skip option, changing
1669 the way directories to skip are specified from prefixing the directory with a “-” to
1670 specifying it with --skip.
1671 Finally, added a --verify option. When specified, the strings file is not written to, but
1672 instead read in and checked for consistency with the comments, keys and values derived from
1673 the source files and the exceptions file. Missing keys, unused keys, mismatching values and
1674 mismatching comments are reported as errors.
1675 * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
1676 directories to skip and no exceptions file.
1678 2013-08-12 Alexey Proskuryakov <ap@apple.com>
1680 http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
1681 https://bugs.webkit.org/show_bug.cgi?id=85522
1683 Reviewed by Andy Estes.
1685 * DumpRenderTree/mac/UIDelegate.mm:
1686 (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
1687 when already done with a test. We already had this check in all UI delegate functions,
1688 except for -webView:addMessageToConsole:withSource: somehow.
1690 2013-08-12 Alexey Proskuryakov <ap@apple.com>
1692 https://bugs.webkit.org/show_bug.cgi?id=119693
1693 [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
1694 because of connect-src-websocket-allowed.html
1696 Reviewed by Darin Adler.
1698 Starting a load of about:blank and immediately stopping it cancels outstanding
1699 resource loads, but the page has to transition to committed state to have timers
1700 or WebSockets stopped too.
1702 * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
1703 ensure that transition to committed state happens before we start the next test.
1705 2013-08-12 Beth Dakin <bdakin@apple.com>
1707 The LayoutMilestones didLayout callback should only fire for the main frame
1708 https://bugs.webkit.org/show_bug.cgi?id=119457
1710 Reviewed by Sam Weinig.
1712 Now that the didLayout callback only fires for the main frame, we want to make
1713 sure it will fire even when all of the content is in a subframe.
1715 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1716 * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
1717 (TestWebKitAPI::didLayout):
1718 (TestWebKitAPI::TEST):
1719 * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
1721 2013-08-12 Beth Dakin <bdakin@apple.com>
1723 Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
1724 https://bugs.webkit.org/show_bug.cgi?id=119658
1726 Reviewed by Darin Adler.
1728 * MiniBrowser/mac/WK2BrowserWindowController.m:
1729 (-[WK2BrowserWindowController awakeFromNib]):
1730 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1731 (WTR::InjectedBundlePage::InjectedBundlePage):
1732 * WebKitTestRunner/TestController.cpp:
1733 (WTR::TestController::createWebViewWithOptions):
1735 2013-08-12 Seokju Kwon <seokju@webkit.org>
1737 Remove glu's libtest rule from checker.py
1738 https://bugs.webkit.org/show_bug.cgi?id=119674
1740 Reviewed by Darin Adler.
1742 * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
1744 2013-08-11 ChangSeok Oh <changseok.oh@collabora.com>
1746 Unreviewed. Change my primary mail address.
1748 * Scripts/webkitpy/common/config/contributors.json:
1750 2013-08-09 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
1752 [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
1753 https://bugs.webkit.org/show_bug.cgi?id=115751
1755 Reviewed by Martin Robinson.
1757 * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
1760 2013-08-09 Beth Dakin <bdakin@apple.com>
1762 AX: Not able to use arrow keys to read text in a WK2 app
1763 https://bugs.webkit.org/show_bug.cgi?id=119605
1765 <rdar://problem/14281275>
1767 Reviewed by Darin Adler.
1769 New test verifies that didNotHandleKeyEvent will be called when there is nothing
1771 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1772 * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
1773 (TestWebKitAPI::didFinishLoadForFrame):
1774 (TestWebKitAPI::didNotHandleKeyEventCallback):
1775 (TestWebKitAPI::TEST):
1777 2013-08-09 Christophe Dumez <ch.dumez@sisa.samsung.com>
1779 Add support for KeyboardEvent.location attribute
1780 https://bugs.webkit.org/show_bug.cgi?id=119326
1782 Reviewed by Benjamin Poulain.
1784 Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
1786 * DumpRenderTree/mac/EventSendingController.mm:
1787 (-[EventSendingController keyDown:withModifiers:withLocation:]):
1788 (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
1789 (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
1790 (-[EventSendingController handleEvent:]):
1791 (-[EventSendingController fireKeyboardEventsToElement:]):
1793 2013-08-09 Alexey Proskuryakov <ap@apple.com>
1795 <unknown> is often dumped instead of path in test output
1796 https://bugs.webkit.org/show_bug.cgi?id=119590
1798 Reviewed by Anders Carlsson.
1800 There were two reasons for <unknown>:
1801 1. When delegate logging is enabled via a testRunner call, that obviously happens
1802 after main resource load starts, so we don't record its URL.
1803 2. Authentication delegate logging relied on URL recording, but it's only turned on
1804 when enabling resource loading delegate logging, not auth one.
1806 URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
1807 landed without posted rationale and unreviewed. Just undoing that change now.
1809 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1810 (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1811 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1812 (WTR::InjectedBundlePage::didInitiateLoadForResource):
1814 2013-08-08 Alex Christensen <achristensen@apple.com>
1816 Windows build fixes.
1818 Rubberstamped by Brent Fulgham.
1820 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1821 Removed /SAFESEH link option which doesn't work with x64.
1823 2013-08-08 Daniel Bates <dabates@apple.com>
1825 Add iOS support to run-javascriptcore-tests
1826 https://bugs.webkit.org/show_bug.cgi?id=119602
1828 Reviewed by Joseph Pecoraro.
1830 Make run-javascriptcore-tests work for iOS WebKit.
1832 * Scripts/run-javascriptcore-tests:
1834 2013-08-08 Alexey Proskuryakov <ap@apple.com>
1836 [WK2] loader/go-back-cached-main-resource.html fails
1837 https://bugs.webkit.org/show_bug.cgi?id=116491
1839 Reviewed by Tim Horton.
1841 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1842 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1843 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1844 * DumpRenderTree/win/DumpRenderTree.cpp:
1845 Added FIXMEs about making path printing normalization more compatible.
1847 * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
1848 Return last path component in cases where we used to return a full path, which is
1849 never desirable. Added a null check to basePath to prevent potentially getting
1850 an Objective C exception.
1852 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1853 (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
1854 for a currently loading one (which is different for tests that use multiple windows).
1855 Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
1856 last path component as last fallback.
1857 (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
1858 frame URL here, and it was potentially a wrong frame.
1859 (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
1860 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
1861 (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
1862 (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
1863 (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
1865 2013-08-08 Alex Christensen <achristensen@apple.com>
1867 WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
1868 https://bugs.webkit.org/show_bug.cgi?id=116125
1870 Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
1872 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1873 (WTR::pathSuitableForTestResult):
1874 Changed string operations to match _drt_descriptionSuitableForTestResult.
1875 (WTR::dumpRequestDescriptionSuitableForTestResult):
1876 (WTR::dumpResponseDescriptionSuitableForTestResult):
1877 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1878 (WTR::InjectedBundlePage::didInitiateLoadForResource):
1879 (WTR::InjectedBundlePage::willSendRequestForFrame):
1880 (WTR::InjectedBundlePage::didReceiveResponseForResource):
1881 Pass the main frame's URL to pathSuitableForTestResult.
1882 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1883 Added WKBundlePageRef to willPerformClientRedirectForFrame.
1885 2013-08-07 Simon Fraser <simon.fraser@apple.com>
1887 Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
1888 https://bugs.webkit.org/show_bug.cgi?id=119317
1890 Reviewed by Tim Horton.
1892 The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
1893 the test to complete, which is not power friendly. Although DRT instances
1894 are generally busy anyway, not sitting in a busy loop should free up some CPU
1895 cycles for other instances of DRT.
1897 Editing tests continue to pass. All Java tests are skipped and were not
1898 tested, but when run fail similarly with and without the patch.
1900 * DumpRenderTree/mac/DumpRenderTree.mm:
1904 2013-08-07 Daniel Bates <dabates@apple.com>
1906 Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
1907 <https://bugs.webkit.org/show_bug.cgi?id=119558>
1909 Reviewed by Martin Robinson.
1911 Currently we build the command line to execute jsDriver.pl twice so as to both
1912 print it to standard output and actually execute it. We should only build up
1913 this command line once. Moreover, we should print to standard output the actual
1914 command line that we are going to use including the GTK- and EFL-specific call
1915 to /Tools/jhbuild/jhbuild-wrapper.
1917 * Scripts/run-javascriptcore-tests:
1919 2013-08-07 Mario Sanchez Prada <mario.prada@samsung.com>
1921 [EFL] REGRESSION after r153432: some accessibility tests crash.
1922 https://bugs.webkit.org/show_bug.cgi?id=119333
1924 Reviewed by Darin Adler.
1926 Use a RefPtr to store a reference to the parent element of
1927 an AccessibilityUIElement instead of the raw pointer, so we
1928 never derefence a function from an invalid pointer.
1930 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1931 (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
1933 2013-08-07 Cosmin Truta <ctruta@blackberry.com>
1935 Unreviewed. Add myself as a committer.
1937 * Scripts/webkitpy/common/config/contributors.json:
1939 2013-08-04 Sam Weinig <sam@webkit.org>
1941 Remove support for HTML5 MicroData
1942 https://bugs.webkit.org/show_bug.cgi?id=119480
1944 Reviewed by Anders Carlsson.
1946 * Scripts/webkitperl/FeatureList.pm:
1947 * qmake/mkspecs/features/features.pri:
1949 2013-07-23 David Farler <dfarler@apple.com>
1951 Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
1952 https://bugs.webkit.org/show_bug.cgi?id=117762
1954 Reviewed by Mark Rowe.
1956 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1957 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1958 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1959 Add ASAN_OTHER_LDFLAGS.
1960 * MiniBrowser/Configurations/DebugRelease.xcconfig:
1961 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1962 * Scripts/check-for-weak-vtables-and-externals:
1963 Ignore ___asan externals, these are populated by compiler-rt.
1964 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1965 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1966 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1967 Add ASAN_OTHER_LDFLAGS.
1968 * WebKitLauncher/Configurations/Base.xcconfig:
1969 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1970 * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
1971 Add ASAN_OTHER_LDFLAGS.
1972 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1973 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1974 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1975 Add ASAN_OTHER_LDFLAGS.
1976 * asan/asan.xcconfig: Added.
1977 * asan/webkit-asan-ignore.txt: Added.
1979 2013-08-05 Brian Holt <brian.holt@samsung.com>
1981 [GTK] Implement leak checking with valgrind
1982 https://bugs.webkit.org/show_bug.cgi?id=118785
1984 Reviewed by Dirk Pranke.
1986 Launch the DRT under Valgrind to generate xml files with details
1989 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1991 * Scripts/webkitpy/port/gtk.py:
1993 (GtkPort.default_timeout_ms): Allow extra time to run under
1995 (GtkPort.setup_environ_for_server): Pass Valgrind instructions
1996 using environment variables.
1998 2013-08-02 Mario Sanchez Prada <mario.prada@samsung.com>
2000 [EFL] REGRESSION after r153432: some accessibility tests crash.
2001 https://bugs.webkit.org/show_bug.cgi?id=119333
2003 Reviewed by Gustavo Noronha Silva.
2005 Add missing null-check to avoid dereferencing a non-existent parent.
2007 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2008 (WTR::attributesOfElement): Ditto.
2010 2013-08-02 Patrick Gansterer <paroga@webkit.org>
2012 Add --rmdir option to git svn dcommit
2013 https://bugs.webkit.org/show_bug.cgi?id=119398
2015 Reviewed by Ryosuke Niwa.
2017 Add this option tells git-svn to remove empty directories
2018 from the svn tree so they do not leave over there.
2020 * Scripts/webkitpy/common/checkout/scm/git.py:
2021 (Git.push_local_commits_to_server):
2023 2013-08-01 Brent Fulgham <bfulgham@apple.com>
2025 [Windows] WebKit1 Fullscreen Video Play is Broken
2026 https://bugs.webkit.org/show_bug.cgi?id=119415
2028 Reviewed by Jer Noble.
2030 * WinLauncher/WinLauncher.cpp:
2031 (dllLauncherEntryPoint): Activate full screen mode via
2032 IWebPreferencesInternal interface.
2034 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
2036 Unreviewed. Add an alternative address to show my affiliation in team.html.
2038 * Scripts/webkitpy/common/config/contributors.json:
2040 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
2042 Duplicate property names can cause test to fail
2043 https://bugs.webkit.org/show_bug.cgi?id=119399
2045 Reviewed by Dirk Pranke.
2047 This problem was noticed when porting the patch for
2048 http://wkb.ug/119357 to Blink: a test would fail because the converted
2049 and test property lists weren't the same length, but they contained
2050 all of the same property names. It looks like this is actually caused
2051 by a bug in converting the HTML, which is being currently rewritten.
2052 In the meantime, as long as this compares the number of unique
2053 properties, it makes the test more robust.
2055 * Scripts/webkitpy/w3c/test_converter_unittest.py:
2056 (verify_prefixed_properties):
2058 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
2060 Unreviewed. Adding my expertise.
2062 * Scripts/webkitpy/common/config/contributors.json:
2064 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
2066 Unreviewed. Add myself as a committer. Yoo-hoo! \o/
2068 * Scripts/webkitpy/common/config/contributors.json:
2070 2013-08-01 Commit Queue <commit-queue@webkit.org>
2072 Unreviewed, rolling out r153518.
2073 http://trac.webkit.org/changeset/153518
2074 https://bugs.webkit.org/show_bug.cgi?id=119386
2076 The Jhbuild dep bump of GTK+ is not actually required by
2077 layout testing, is causing pango dep problems (Requested by
2078 zdobersek on #webkit).
2080 * gtk/jhbuild.modules:
2082 2013-08-01 Xabier Rodriguez Calvar <calvaris@igalia.com>
2084 Unreviewed. Add myself as a committer.
2086 * Scripts/webkitpy/common/config/contributors.json:
2088 2013-08-01 Jaehun Lim <ljaehun.lim@samsung.com>
2090 Unreviewed. Add myself as a committer.
2092 * Scripts/webkitpy/common/config/contributors.json:
2094 2013-07-31 Jinwoo Song <jinwoo7.song@samsung.com>
2096 Unreviewed. Add myself as a committer.
2098 * Scripts/webkitpy/common/config/contributors.json:
2100 2013-08-01 Alberto Garcia <berto@igalia.com>
2102 Unreviewed. Add myself as a committer.
2104 * Scripts/webkitpy/common/config/contributors.json:
2106 2013-07-31 Seokju Kwon <seokju@webkit.org>
2108 Unreviewed. Add myself as a committer.
2110 * Scripts/webkitpy/common/config/contributors.json:
2112 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
2114 W3C test import script prefixes some properties that it shouldn't
2115 https://bugs.webkit.org/show_bug.cgi?id=119357
2117 Reviewed by Dirk Pranke.
2119 Some prefixed properties also have unprefixed implemetations, but when
2120 the implementations aren't identical, they aren't declared in
2121 CSSPropertyNames.in on the same line. This fixes the import script so
2122 that it catches all instances of prefixed properties that have an
2123 unprefixed variant, and does not add the prefix in those cases.
2125 * Scripts/webkitpy/w3c/test_converter.py:
2126 (W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
2127 the properties on every line and record if they are prefixed or not.
2128 Use this information to only return prefixed properties that do not
2129 have any unprefixed variant. The prefixed property list has also
2130 changed to not include the '-webkit-' prefix, making it much easier to
2131 do the comparison, and removing the need to remove the prefix later.
2132 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
2133 longer needs to remove the '-webkit-' prefix, but needs to add it in
2134 the case where a property that needs a prefix is found.
2135 * Scripts/webkitpy/w3c/test_converter_unittest.py:
2136 (W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
2137 for '-webkit-' prefix, as it is no longer included in the properties
2138 in the prefixed property list.
2140 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
2142 Update location of w3c shapes tests to reflect new import location
2143 https://bugs.webkit.org/show_bug.cgi?id=118156
2145 Reviewed by Dirk Pranke.
2147 Partial imports should not be imported to the same place as the full
2148 import, so this adds an option to allow importing to a different
2149 location than the default. In doing that, I found that imports from
2150 contributor directories didn't seem to be working correctly, so I
2151 updated the import to be smarter about both contributor directories
2152 and the test status directories. It should now be more likely that the
2153 script guesses the root directory properly.
2155 * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
2156 script not working with the full set of contributors, as that is
2157 no longer true, and I didn't see a good way to keep that behavior.
2158 Also update documentation to properly explain what happens when a
2159 contributor dir is imported.
2160 (main): Attempt to find the proper repo dir by looking at the
2161 directory above the "test status" in the given path, this is still
2162 not exactly right, but is less error prone than just trimming.
2163 (parse_args): Add -d option to set the import directory.
2164 (TestImporter.__init__): Stop appending the subdirs to the
2165 destination_directory because it was making things more complex
2166 and isn't really needed.
2167 (TestImporter.update_test_status): Remove hardcoded strings and use
2168 the TEST_STATUS constants instead.
2169 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2170 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
2171 support for new option.
2172 (TestImporterTest.test_import_dir_with_no_tests): Ditto.
2174 2013-07-31 Brent Fulgham <bfulgham@apple.com>
2176 [Windows] Winlauncher shouldn't look for Safari Install Directory
2177 https://bugs.webkit.org/show_bug.cgi?id=119351
2179 Reviewed by Darin Adler.
2181 * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
2182 the Safari install location. Instead, use the proper support
2183 library path for the build architecture.
2185 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
2187 Update scripts to reference contributors.json instead of committers.py in messaging
2188 https://bugs.webkit.org/show_bug.cgi?id=119342
2190 Reviewed by Ryosuke Niwa.
2192 Change the scripts to point people to contributors.json instead of
2193 committers.py since the latter no longer contains the list of
2196 * Scripts/webkitpy/common/config/committervalidator.py:
2197 (CommitterValidator._contributors_json_path):
2198 (CommitterValidator._flag_permission_rejection_message):
2199 * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2200 (CommitterValidatorTest.test_flag_permission_rejection_message):
2201 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2202 (Bugzilla._commit_queue_flag):
2203 * Scripts/webkitpy/common/watchlist/watchlistparser.py:
2204 (WatchListParser._validate):
2205 * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
2206 (WatchListParserTest.test_cc_rule_with_invalid_email):
2207 * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2208 * Scripts/webkitpy/tool/commands/queues_unittest.py:
2209 * Scripts/webkitpy/tool/steps/validatereviewer.py:
2210 (ValidateReviewer.run):
2212 2013-07-31 Roger Fong <roger_fong@apple.com>
2214 Unreviewed. Re-enable WinEWS tests following r153527.
2216 * Scripts/webkitpy/common/config/ews.json:
2218 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
2220 Unreviewed: Adding myself to the committers' list.
2222 * Scripts/webkitpy/common/config/contributors.json:
2224 2013-07-31 Allan Sandfeld Jensen <allan.jensen@digia.com>
2226 [Qt] Build WebKit with C++11
2227 https://bugs.webkit.org/show_bug.cgi?id=119337
2229 Reviewed by Csaba Osztrogonác.
2231 Enable building with C++11.
2233 * qmake/mkspecs/features/default_pre.prf:
2234 * qmake/mkspecs/features/unix/default_post.prf:
2235 * qmake/mkspecs/features/unix/default_pre.prf:
2237 2013-07-31 Allan Sandfeld Jensen <allan.jensen@digia.com>
2239 [Qt] ASSERTS trigger in release builds
2240 https://bugs.webkit.org/show_bug.cgi?id=119336
2242 Reviewed by Jocelyn Turcotte.
2244 Ensure the qmake also defaults to release if no configuration is known.
2246 * qmake/mkspecs/features/default_post.prf:
2248 2013-07-31 Zan Dobersek <zdobersek@igalia.com>
2250 [texmap][GStreamer][GTK] composited video shows tearing
2251 https://bugs.webkit.org/show_bug.cgi?id=118253
2253 Reviewed by Martin Robinson.
2255 * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
2256 The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
2257 screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
2259 2013-07-30 Ruth Fong <ruth_fong@apple.com>
2261 Unreviewed: Adding myself to the committers' list.
2263 * Scripts/webkitpy/common/config/contributors.json:
2265 2013-07-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
2267 Unreviewed, add my new email to contributors.json.
2269 * Scripts/webkitpy/common/config/contributors.json:
2271 2013-07-30 Krzysztof Czech <k.czech@samsung.com>
2273 [EFL] REGRESSION after r153439: layout tests do not run.
2274 https://bugs.webkit.org/show_bug.cgi?id=119240
2276 Reviewed by Christophe Dumez.
2278 Changed attribute name from check_xvfb to check_driver.
2280 * Scripts/webkitpy/port/efl.py:
2281 (EflPort.check_sys_deps):
2283 2013-07-29 Commit Queue <commit-queue@webkit.org>
2285 Unreviewed, rolling out r152860.
2286 http://trac.webkit.org/changeset/152860
2287 https://bugs.webkit.org/show_bug.cgi?id=119227
2289 Disable WinEWS tests until tests stop crashing (Requested by
2292 * Scripts/webkitpy/common/config/ews.json:
2294 2013-07-29 Zan Dobersek <zdobersek@igalia.com>
2296 [GTK] Add WestonDriver, use it when appropriate
2297 https://bugs.webkit.org/show_bug.cgi?id=119100
2299 Reviewed by Dirk Pranke.
2301 Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
2302 and sets up an environment that enables the test runner to run inside it.
2304 The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
2305 environment variable is set, that is when NRWT is being run under a Wayland display.
2307 * Scripts/webkitpy/port/base.py:
2308 (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
2309 * Scripts/webkitpy/port/gtk.py:
2311 (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
2312 should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
2313 (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
2314 instead of hard-coding the XvfbDriver class in the check.
2315 * Scripts/webkitpy/port/westondriver.py: Added.
2317 (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
2318 (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
2319 (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
2320 driver and then launches the driver in said environment, using the driver's Weston display.
2321 (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
2322 (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
2323 and returns the absolute path to it.
2324 * Scripts/webkitpy/port/xvfbdriver.py:
2325 (XvfbDriver.check_driver): Renamed from check_xvfb.
2326 (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
2328 2013-07-29 Mario Sanchez Prada <mario.prada@samsung.com>
2330 [ATK] Implement attributesOfChildren() for AccessibilityUIElement
2331 https://bugs.webkit.org/show_bug.cgi?id=118967
2333 Reviewed by Gustavo Noronha Silva.
2335 Implemented AccessibilityUIElement::attributesOfChildren() both
2336 in DumpRenderTree and the WebKitTestRunner.
2338 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2339 (AccessibilityUIElement::attributesOfChildren): Implemented.
2341 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2342 (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
2344 2013-07-29 Mario Sanchez Prada <mario.prada@samsung.com>
2346 [ATK] Implement allAttributes() for AccessibilityUIElement
2347 https://bugs.webkit.org/show_bug.cgi?id=118966
2349 Reviewed by Gustavo Noronha Silva.
2351 Implemented AccessibilityUIElement::allAttributes() both in
2352 DumpRenderTree and the WebKitTestRunner.
2354 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2355 (getAtkAttributeSetAsString): Moved up in the file, and refactored
2356 to use StringBuilder and return a String instead of a gchar*.
2357 (roleToString): Changed not to return the "AXRole: " prefix, so
2358 we can use it as well from attributesOfElement().
2359 (attributesOfElement): New function to dump attributes for an object.
2360 (AccessibilityUIElement::allAttributes): Call attributesOfElement().
2361 (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
2363 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2364 (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
2365 a String instead of a gchar*.
2367 (WTF::roleToString): Changed not to return the "AXRole: " prefix,
2368 so we can use it as well from attributesOfElement().
2369 (WTF::attributesOfElement): New function to dump attributes for an object.
2370 (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
2371 (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
2373 2013-07-29 Daniel Bates <dabates@apple.com>
2375 Add support infrastructure for iOS WebKit port
2376 https://bugs.webkit.org/show_bug.cgi?id=119168
2378 Reviewed by Ryosuke Niwa.
2380 Implement support infrastructure towards building iOS WebKit.
2382 * Scripts/webkitdirs.pm:
2383 (xcodeSDKPlatformName): Added.
2384 (determineConfigurationProductDir):
2385 (builtDylibPathForName):
2386 (willUseIOSDeviceSDKWhenBuilding): Added.
2387 (willUseIOSSimulatorSDKWhenBuilding): Added.
2388 (isIOSWebKit): Added.
2389 (copyInspectorFrontendFiles):
2391 2013-07-29 Sergio Correia <sergio.correia@openbossa.org>
2393 CoordinatedGraphics: Add API to get and set the active state of a WebView
2394 https://bugs.webkit.org/show_bug.cgi?id=119067
2396 Reviewed by Noam Rosenthal.
2398 Added API tests for WKViewIsActive and WKViewSetIsActive.
2400 * TestWebKitAPI/PlatformEfl.cmake:
2401 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
2402 (TestWebKitAPI::didFinishLoadForFrame):
2403 (TestWebKitAPI::webProcessCrashed):
2404 (TestWebKitAPI::webProcessRelaunched):
2405 (TestWebKitAPI::TEST):
2406 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
2407 Bundle added to allow crashing the WebProcess and testing the active state of a view
2408 under such condition.
2409 (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
2410 (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
2412 2013-07-29 Zan Dobersek <zdobersek@igalia.com>
2414 [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
2415 https://bugs.webkit.org/show_bug.cgi?id=119212
2417 Reviewed by Carlos Garcia Campos.
2419 * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
2420 variables that are not defined during the configuration process.
2421 * TestWebKitAPI/GNUmakefile.am: Ditto.
2422 * WebKitTestRunner/GNUmakefile.am: Ditto.
2424 2013-07-28 Andy Estes <aestes@apple.com>
2426 Include <stdio.h> to declare perror()
2427 https://bugs.webkit.org/show_bug.cgi?id=119198
2429 Reviewed by Andreas Kling.
2431 Silences an implicit declaration warning.
2433 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
2435 2013-07-27 Ryuan Choi <ryuan.choi@samsung.com>
2437 [EFL] Bump required version of EFL to 1.7
2438 https://bugs.webkit.org/show_bug.cgi?id=119144
2440 Reviewed by Christophe Dumez.
2442 * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
2444 2013-07-26 Filip Pizlo <fpizlo@apple.com>
2446 WKTR should know about the JSC extensions to testRunner
2447 https://bugs.webkit.org/show_bug.cgi?id=119154
2449 Reviewed by Mark Hahnenberg and Geoffrey Garen.
2451 This makes some fast/js tests pass.
2453 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2454 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2455 (WTR::TestRunner::numberOfDFGCompiles):
2456 (WTR::TestRunner::neverInlineFunction):
2457 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2459 2013-07-25 Mark Rowe <mrowe@apple.com>
2461 Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
2463 * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
2464 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
2465 so they pull the version out of the SDK.
2467 2013-07-25 Anders Carlsson <andersca@apple.com>
2469 Localizable.strings generated by extract-localizable-strings should be UTF-8
2470 https://bugs.webkit.org/show_bug.cgi?id=119106
2472 Reviewed by Mark Rowe.
2474 Output strings as UTF-8.
2476 * Scripts/extract-localizable-strings:
2478 2013-07-25 Sam Weinig <sam@webkit.org>
2480 -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
2481 https://bugs.webkit.org/show_bug.cgi?id=119099
2482 <rdar://problem/13439291>
2484 Reviewed by Enrica Casucci.
2486 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2487 * TestWebKitAPI/Tests/mac/AttributedString.mm:
2488 (TestWebKitAPI::attributedString):
2489 (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2490 (TestWebKitAPI::AttributedStringTest_CustomFont::url):
2491 (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
2492 (TestWebKitAPI::TEST_F):
2493 (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2494 (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
2495 (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
2496 * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
2497 Add tests for attributed strings with strikethrough. Refactor the attributed string tests
2498 to make adding more easier in the future.
2500 2013-07-20 Filip Pizlo <fpizlo@apple.com>
2502 fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
2503 https://bugs.webkit.org/show_bug.cgi?id=118948
2505 Reviewed by Sam Weinig.
2507 - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
2508 by exporting it as a function.
2510 - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
2511 it even if you know that you've already done so. See processIRDump.sh.
2513 - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
2514 runs it through ReducedFTL automatically. You typically want to say something like:
2516 jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
2517 ./processIRDump.sh --timing < jsc-output.txt
2519 * ReducedFTL/ReducedFTL.c:
2521 * ReducedFTL/combineModules.rb:
2522 * ReducedFTL/processIRDump.sh: Added.
2524 2013-07-20 Filip Pizlo <fpizlo@apple.com>
2526 fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
2527 https://bugs.webkit.org/show_bug.cgi?id=118947
2529 Reviewed by Dan Bernstein.
2531 * Scripts/copy-webkitlibraries-to-product-directory:
2533 2013-07-16 Filip Pizlo <fpizlo@apple.com>
2535 fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
2536 https://bugs.webkit.org/show_bug.cgi?id=118647
2538 Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
2540 Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
2541 way that the FTL would.
2543 Also add a tool that combines multiple LLVM modules generated by FTL into a
2546 * ReducedFTL: Added.
2547 * ReducedFTL/ReducedFTL.c: Added.
2551 (mmAllocateCodeSection):
2552 (mmAllocateDataSection):
2553 (mmApplyPermissions):
2555 (symbolLookupCallback):
2557 * ReducedFTL/build.sh: Added.
2558 * ReducedFTL/combineModules.rb: Added.
2560 2013-06-09 Filip Pizlo <fpizlo@apple.com>
2562 Unreviewed, fix minor goof in profiling output layout. We weren't accounting
2563 for the "/" that is printed between engine counts.
2565 * Scripts/display-profiler-output:
2567 2013-05-28 Filip Pizlo <fpizlo@apple.com>
2569 testRunner should have a way of disabling inlining of functions
2570 https://bugs.webkit.org/show_bug.cgi?id=116875
2572 Reviewed by Mark Hahnenberg.
2574 * DumpRenderTree/TestRunner.cpp:
2575 (neverInlineFunction):
2576 (TestRunner::staticFunctions):
2578 2013-05-27 Filip Pizlo <fpizlo@apple.com>
2580 testRunner should be able to tell you if a function is DFG compiled
2581 https://bugs.webkit.org/show_bug.cgi?id=116847
2583 Reviewed by Mark Hahnenberg.
2585 * DumpRenderTree/TestRunner.cpp:
2586 (numberOfDFGCompiles):
2587 (TestRunner::staticFunctions):
2589 2013-05-21 Filip Pizlo <fpizlo@apple.com>
2591 fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
2592 https://bugs.webkit.org/show_bug.cgi?id=116556
2594 Reviewed by Oliver Hunt.
2596 This adds three new capabilities:
2598 - 'display' now accepts negative compilation indices, and allows specifying
2599 wildcard hashes combined with combination indices. Previously you could say
2600 'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
2601 latter would display every compilation. This improves this so that you can
2602 say 'display *-<index>-<engine>'. It also makes it so that you can give a
2603 negative index, which allows you to say things like 'display blah--1-dfg',
2604 which displays just the last DFG compilation. Also you can say
2605 'display *--1-dfg', which displays the last DFG compilation for each code
2606 block. I realize that this is kind of ugly, but gosh is it practical.
2608 - You can now say 'sort hash', which will henceforth sort all of the output
2609 by code hash rather than by the time when it was compiled. This means that
2610 if you're doing 'dispay *--1-dfg' and then want to diff the results against
2611 something else, you can ensure that this doesn't get confused just by
2612 changes in compilation order.
2614 - You can now say 'counts off', which will henceforth disable the display of
2615 execution counts from 'bytecode' and 'display'. This is also useful for
2616 diffs, since if you're trying to figure out why two compilations are
2617 different, they probably have radically different counts. 'counts off' gets
2618 this out of the output so that it doesn't confuse your diff.
2620 Note that to use this effectively you should also have a script that scrubs
2621 pointers from text so that the diff doesn't get confused by pointers. I'll
2622 post my elimptr script to the bug. Maybe at some point I'll integrate that
2623 into display-profiler-output.
2625 Put together this is pretty awesome. I was able to do the following:
2627 (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
2628 (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
2629 diff -u richards-serial.asm richards-concurrent.asm
2631 And this immediately told me that the reason why richards is slower in the
2632 concurrent compilation case is just that we end up compiling *tons* more
2633 functions, most of which are trivially inlineable. Basically, concurrent
2634 compilation breaks our previous heuristics for delaying compilation of
2635 inlineables just enough that they never trigger compilation. We should fix
2636 that in a separate bug.
2638 * Scripts/display-profiler-output:
2640 2013-04-30 Filip Pizlo <fpizlo@apple.com>
2642 fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
2644 Rubber stamped by Mark Rowe.
2646 * Scripts/copy-webkitlibraries-to-product-directory:
2648 2013-07-16 Oliver Hunt <oliver@apple.com>
2650 Merge dfgFourthTier r148853
2652 2013-04-21 Filip Pizlo <fpizlo@apple.com>
2654 fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
2655 https://bugs.webkit.org/show_bug.cgi?id=114933
2657 Reviewed by Andy Estes.
2659 This makes it easy to get set up for tandem LLVM builds.
2661 * Scripts/copy-webkitlibraries-to-product-directory:
2663 2013-07-16 Oliver Hunt <oliver@apple.com>
2665 Merge dfgFourthTier r148850
2667 2013-04-21 Filip Pizlo <fpizlo@apple.com>
2669 fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
2670 https://bugs.webkit.org/show_bug.cgi?id=114926
2672 Reviewed by Geoffrey Garen.
2674 If the LLVM libraries change, then touch a phony header, which will force relink
2677 * Scripts/copy-webkitlibraries-to-product-directory:
2678 (unpackIfNecessary):
2680 2013-07-16 Oliver Hunt <oliver@apple.com>
2682 Merge dfgFourthTier r148848
2684 2013-04-21 Filip Pizlo <fpizlo@apple.com>
2686 fourthTier: developing LLVM in tandem with WebKit should be fun and easy
2687 https://bugs.webkit.org/show_bug.cgi?id=114925
2689 Reviewed by Geoffrey Garen.
2691 This enables building LLVM along with WebKit, so that build-jsc and build-webkit
2692 will also optionally build LLVM and quickly symlink LLVM's built products into
2695 Most WebKit and JSC hackers will want to rely on the checked-in already-built
2696 versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
2697 increasingly common use-case for me, and it may become a common use case for a
2698 handful of others. Currently, this is really painful: you first have to build
2699 LLVM, then you have to export-llvm-build (which takes a while), and then you
2700 have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
2701 variables are set to point to the thing you exported. The whole process loses
2702 track of dependencies very quickly: making a tiny change in LLVM requires
2703 packaging, and then unpackaging, a large number of potentially large headers and
2704 static libraries. Not only is this slow but it then causes the WebKit build
2705 system to rebuild anything that transitively includes any LLVM header, which is
2706 now quite a few files. While this sort of use pattern is still worthwhile if
2707 you're trying to package a binary drop and test it, it's not great if you're
2708 just trying to do experimental development that involves making small changes
2711 This change fixes this use case while keeping the old use cases intact. You can
2712 do tandem development using one of two modes:
2714 Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
2715 the LLVM directory you're using. Once this is done, any invocation of a WebKit
2716 build via build-jsc or build-webkit will also build LLVM, and then quickly
2717 symlink things into place without perturbing dependency tracking.
2719 Internal LLVM directory: if you check out llvm into a directory called 'llvm'
2720 right off of the WebKit source tree, then the build system will automatically
2723 Here's how this takes care of dependencies:
2725 Headers: the include/llvm and include/llvm-c directories are symlinked into
2726 $productsDir/usr/local/include. And then everything just works.
2728 Libraries: the build system detects, by reading LLVM's Makefile.config, which
2729 mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
2730 the .a files into $productsDir/<thingy>. It will ranlib those libraries only
2731 if they have changed, by checking both the modification time and also whether
2732 the last time we had a symlink, that symlink was from the same directory.
2733 This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
2734 but that build wasn't yet ranlib'd.
2736 One problem that this does not yet solve is that xcodebuild will not relink
2737 JavaScriptCore if the only thing that changed was the libraries. I will work
2738 on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
2740 * Scripts/copy-webkitlibraries-to-product-directory:
2741 (unpackIfNecessary):
2743 (fileContentsEquals):
2745 2013-04-15 Filip Pizlo <fpizlo@apple.com>
2747 fourthTier: Update LLVM-related build scripts to copy generated headers as well
2748 https://bugs.webkit.org/show_bug.cgi?id=114551
2750 Reviewed by Oliver Hunt.
2752 Also added the ability to use something other than bzip2 compression, since although
2753 it is great for checking things into the tree, it increases turn-around times when
2756 * Scripts/copy-webkitlibraries-to-product-directory:
2757 (unpackIfNecessary):
2758 * Scripts/export-llvm-build:
2760 2013-04-03 Filip Pizlo <fpizlo@apple.com>
2762 fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
2763 https://bugs.webkit.org/show_bug.cgi?id=113921
2765 Reviewed by Oliver Hunt.
2767 The LLVM community wants us to continue including all of LLVM's C++ headers. Change
2768 the export script to do this.
2770 * Scripts/export-llvm-build:
2772 2013-03-29 Filip Pizlo <fpizlo@apple.com>
2774 fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
2775 https://bugs.webkit.org/show_bug.cgi?id=113452
2777 Rubber stamped by Mark Hahnenberg.
2779 * Scripts/copy-webkitlibraries-to-product-directory:
2780 * Scripts/export-llvm-build:
2782 2013-03-29 Filip Pizlo <fpizlo@apple.com>
2784 fourthTier: FTL JIT should be able run some simple function
2785 https://bugs.webkit.org/show_bug.cgi?id=113481
2787 Reviewed by Geoffrey Garen.
2789 Give the scripts the ability to find an LLVM build and use it.
2791 Also added a script, export-llvm-build, that allows you to take your
2792 own build of LLVM and package it for use by WebKit's build system.
2794 The build system treats a "build" of LLVM as a pair of .tar.bz2's,
2795 one for the library archives and one for the headers. It then unpacks
2796 them into your built products directory in a mannner that is mostly
2797 analogous to how WebKitSystemInterface works.
2799 * Scripts/build-jsc:
2800 * Scripts/copy-webkitlibraries-to-product-directory:
2801 (unpackIfNecessary):
2803 * Scripts/export-llvm-build: Added.
2805 2013-07-24 Anders Carlsson <andersca@apple.com>
2807 Crash when calling WKPageGetProcessIdentifier after aborted process launch
2808 https://bugs.webkit.org/show_bug.cgi?id=119069
2809 <rdar://problem/14494064>
2811 Reviewed by Andreas Kling.
2815 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2816 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
2817 (TestWebKitAPI::didFinishLoadForFrame):
2818 (TestWebKitAPI::TEST):
2820 2013-07-24 Zan Dobersek <zdobersek@igalia.com>
2822 Make KURL::hasPath private
2823 https://bugs.webkit.org/show_bug.cgi?id=118279
2825 Reviewed by Darin Adler.
2827 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2828 (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
2830 2013-07-24 Anton Obzhirov <a.obzhirov@samsung.com>
2832 [GTK] TestInspectorServer unit test is timing out
2833 https://bugs.webkit.org/show_bug.cgi?id=105866
2835 Reviewed by Gustavo Noronha Silva.
2837 * Scripts/run-gtk-tests:
2840 2013-07-24 Anton Obzhirov <a.obzhirov@samsung.com>
2842 [GTK] [WK2] Handle wheel event with delta zero
2843 https://bugs.webkit.org/show_bug.cgi?id=118973
2845 Reviewed by Gustavo Noronha Silva.
2847 Added handling of zero mouse scroll deltas in EventSenderProxy similar
2848 to WK1 and Qt/EFL ports.
2850 fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
2853 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2854 (WTR::EventSenderProxy::mouseScrollBy):
2856 2013-07-23 Andreas Kling <akling@apple.com>
2858 REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
2859 <rdar://problem/14324895>
2860 <http://webkit.org/b/119023>
2862 Reviewed by Simon Fraser.
2864 Add a test for this rather specific problem.
2866 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2867 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
2868 (TestWebKitAPI::TEST):
2869 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
2870 (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
2871 (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
2872 (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
2874 2013-07-23 Tim Horton <timothy_horton@apple.com>
2876 Add a test for plug-in unavailability indicator obscurity detection
2877 https://bugs.webkit.org/show_bug.cgi?id=119007
2879 Reviewed by Anders Carlsson.
2881 Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
2883 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2884 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2885 (WTR::TestRunner::setBlockAllPlugins):
2886 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2887 * WebKitTestRunner/TestInvocation.cpp:
2888 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2889 Add testRunner.setBlockAllPlugins function (and corresponding message to
2890 forward it through to TestController).
2892 * WebKitTestRunner/TestController.cpp:
2893 Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
2895 (WTR::TestController::createWebViewWithOptions):
2896 Register our pluginLoadPolicy callback.
2898 (WTR::TestController::resetStateToConsistentValues):
2899 Reset m_shouldBlockAllPlugins to false.
2901 (WTR::TestController::pluginLoadPolicy):
2902 Return the existing plugin load policy, unless setBlockAllPlugins(true)
2903 was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
2905 * WebKitTestRunner/TestController.h:
2906 (WTR::TestController::setBlockAllPlugins):
2908 2013-07-21 Andreas Kling <akling@apple.com>
2910 KURL creates duplicate strings when completing data: URIs.
2911 <http://webkit.org/b/118952>
2912 <rdar://problem/14504480>
2914 Reviewed by Anders Carlsson.
2916 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2917 (TestWebKitAPI::TEST_F):
2919 2013-07-19 Chris Fleizach <cfleizach@apple.com>
2921 AX: VoiceOver not detecting misspelled words don't work in all cases
2922 https://bugs.webkit.org/show_bug.cgi?id=118924
2924 Reviewed by Tim Horton.
2926 Make the misspelled detection dependent on both types of attributes being present.
2928 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2929 (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2930 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2931 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2933 2013-07-19 Alex Christensen <achristensen@apple.com>
2935 Improved code coverage generation.
2936 https://bugs.webkit.org/show_bug.cgi?id=118926
2938 Reviewed by Tim Horton.
2940 * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
2941 * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
2942 (generateReport): Moved report generation to a subroutine.
2944 2013-07-19 Stephanie Lewis <slewis@apple.com>
2946 <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
2950 Rebaseline pagination test after http://trac.webkit.org/changeset/152911
2952 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2953 (TestWebKitAPI::didLayout):
2955 2013-07-19 Daniel Bates <dabates@apple.com>
2957 Make Perl tools work when using git bisect with Git branch build setup
2958 https://bugs.webkit.org/show_bug.cgi?id=118512
2960 Reviewed by Martin Robinson.
2962 The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
2963 during a git bisect session with a Git branch build setup (i.e. git config
2964 core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
2965 specific build of WebKit because they cannot determine the branch Git is on (since
2966 git bisect puts Git into a detached HEAD state). We should teach our tooling to
2967 parse the file .git/BISECT_START (created by git bisect start) for the name of the
2968 branch Git was on when we began a git bisect session. Then the tools can determine
2969 the path to the built WebKit.
2971 * Scripts/VCSUtils.pm:
2972 (gitDirectory): Added.
2973 (gitBisectStartBranch): Added.
2974 (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
2975 HEAD (e.g. running git bisect).
2976 (determineVCSRoot): Modified to call gitDirectory() to determine the path to
2977 the .git directory in the Git checkout.
2979 2013-07-19 Alex Christensen <achristensen@apple.com>
2981 Added x64 configuration to Visual Studio build.
2982 https://bugs.webkit.org/show_bug.cgi?id=118888
2984 Reviewed by Brent Fulgham.
2986 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2987 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2988 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2989 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2990 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2991 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2992 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2993 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2994 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2995 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2996 * win/record-memory/record-memory.vcxproj:
2998 2013-07-19 Martin Robinson <mrobinson@igalia.com>
3000 Add a couple people to the MathML watchlist
3001 https://bugs.webkit.org/show_bug.cgi?id=118909
3003 Reviewed by Andreas Kling.
3005 Add a couple people to the MathML watchlist and add Kalyan's other
3006 email address to fix style checker warnings about the watchlist
3009 * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
3010 list of contributors and add Kalyan's second email address.
3011 * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
3014 2013-07-19 Simon Pena <simon.pena@samsung.com>
3016 [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
3017 https://bugs.webkit.org/show_bug.cgi?id=118895
3019 Reviewed by Philippe Normand.
3021 In r152782 an uri is used to create an string representation without checking first if it
3022 is valid. That fails later when the string is used to check for existing redirections. This
3023 patch ensures that the uri is valid before using it.
3025 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3026 (willSendRequestCallback): Ensure an uri is valid before using it.
3028 2013-07-18 Timothy Hatcher <timothy@apple.com>
3030 Add extract-localizable-js-strings and use it for WebInspectorUI.
3032 https://bugs.webkit.org/show_bug.cgi?id=118851
3034 Reviewed by Joseph Pecoraro.
3036 * Scripts/extract-localizable-js-strings: Added.
3037 * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
3038 * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
3039 the WebInspectorUI project.
3041 2013-07-18 Brent Fulgham <bfulgham@apple.com>
3043 [Windows] Build correction #2 after r152861.
3045 * WinLauncher/WinLauncher.cpp: Declare proper linkage.
3047 2013-07-18 Brent Fulgham <bfulgham@apple.com>
3049 [Windows] Build correction after r152861.
3051 * WinLauncher/WinLauncher.cpp: Don't reference private header.
3053 2013-07-16 Brent Fulgham <bfulgham@apple.com>
3055 [Win] Support in-band text tracks.
3056 https://bugs.webkit.org/show_bug.cgi?id=103770
3058 Reviewed by Eric Carlson.
3060 Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
3061 libdispatch and CFRunLoop elements are services during the run loop.
3063 * WinLauncher/WinLauncher.cpp:
3064 (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
3065 a CoreFoundation (or CFLite) support library.
3066 * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
3067 * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
3068 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
3069 and WinLauncherCFLite.props.
3071 2013-07-18 Roger Fong <roger_fong@apple.com>
3073 Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
3075 * Scripts/webkitpy/common/config/ews.json:
3077 2013-07-18 Daniel Bates <dabates@apple.com>
3079 REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
3080 https://bugs.webkit.org/show_bug.cgi?id=118854
3081 <rdar://problem/14081339>
3083 Reviewed by David Kilzer.
3085 Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
3086 Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
3087 run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
3088 listen on these ports so that we can run tests that use port 8443 and 8080.
3090 * Scripts/old-run-webkit-tests:
3091 (configureAndOpenHTTPDIfNeeded):
3093 2013-07-17 Tim Horton <timothy_horton@apple.com>
3095 Update blocked/missing plug-in UI
3096 https://bugs.webkit.org/show_bug.cgi?id=118347
3097 <rdar://problem/14209318>
3099 Reviewed by Sam Weinig.
3101 * MiniBrowser/mac/WK2BrowserWindowController.m:
3102 (-[WK2BrowserWindowController awakeFromNib]):
3103 * WebKitTestRunner/TestController.cpp:
3104 (WTR::TestController::createWebViewWithOptions):
3105 Match new WKPageLoaderClient entry.
3107 2013-07-17 Commit Queue <commit-queue@webkit.org>
3109 Unreviewed, rolling out r152701, r152703, r152739, r152754,
3111 http://trac.webkit.org/changeset/152701
3112 http://trac.webkit.org/changeset/152703
3113 http://trac.webkit.org/changeset/152739
3114 http://trac.webkit.org/changeset/152754
3115 http://trac.webkit.org/changeset/152756
3116 https://bugs.webkit.org/show_bug.cgi?id=118821
3118 this was a buggy fix and we're going to try something
3119 different (Requested by thorton on #webkit).
3121 * MiniBrowser/mac/WK2BrowserWindowController.m:
3122 (-[WK2BrowserWindowController awakeFromNib]):
3123 * WebKitTestRunner/TestController.cpp:
3124 (WTR::TestController::createWebViewWithOptions):
3126 2013-07-17 Commit Queue <commit-queue@webkit.org>
3128 Unreviewed, rolling out r151535.
3129 http://trac.webkit.org/changeset/151535
3130 https://bugs.webkit.org/show_bug.cgi?id=118804
3132 Re-disable WinEWS tests (Requested by rfong on #webkit).
3134 * Scripts/webkitpy/common/config/ews.json:
3136 2013-07-17 Simon Pena <simon.pena@samsung.com>
3138 [GTK] Make DRT obbey testRunner's addURLToRedirect
3139 https://bugs.webkit.org/show_bug.cgi?id=118239
3141 Reviewed by Gustavo Noronha Silva.
3143 Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
3144 to the proper URI when indicated.
3146 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3147 (willSendRequestCallback):
3149 2013-07-17 Gabor Abraham <abrhm@inf.u-szeged.hu>
3151 Add a new find-resolved-bugs command to webkit-patch.
3152 https://bugs.webkit.org/show_bug.cgi?id=118060
3154 Reviewed by Csaba Osztrogonác.
3156 * Scripts/webkitpy/tool/commands/queries.py:
3157 (PrintBaselines._platform_for_path):
3159 (FindResolvedBugs.execute):
3161 2013-07-16 Balazs Kelemen <kbalazs@webkit.org>
3163 [CMake] Undefined references should be detected at build time
3164 https://bugs.webkit.org/show_bug.cgi?id=110236
3166 Reviewed by Christophe Dumez.
3168 Add library dependencies that were not defined explicitly before.
3170 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3171 * TestWebKitAPI/CMakeLists.txt:
3172 * WebKitTestRunner/CMakeLists.txt:
3174 2013-07-16 Kwang Yul Seo <skyul@company100.net>
3176 check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
3177 https://bugs.webkit.org/show_bug.cgi?id=118755
3179 Reviewed by Ryosuke Niwa.
3181 Fix r152719 to check "using namespace foo;" only in headers.
3183 * Scripts/webkitpy/style/checkers/cpp.py:
3184 (check_using_namespace):
3186 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3187 (WebKitStyleTest.test_using_namespace):
3189 2013-07-16 Christophe Dumez <ch.dumez@sisa.samsung.com>
3191 Get rid of multiple inheritance support from the bindings generators
3192 https://bugs.webkit.org/show_bug.cgi?id=118353
3194 Reviewed by Kentaro Hara.
3196 Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
3197 deprecated domInterface->parents.
3199 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3202 2013-07-16 Brian Holt <brian.holt@samsung.com>
3204 check-webkit-style: "using namespace foo;" should be flagged as an error in headers
3205 https://bugs.webkit.org/show_bug.cgi?id=57241
3207 Reviewed by Ryosuke Niwa.
3209 Added check for "using namespace foo" and unit test.
3211 * Scripts/webkitpy/style/checkers/cpp.py:
3212 (check_using_namespace):
3215 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3216 (WebKitStyleTest.test_using_namespace):
3218 2013-07-16 Anton Obzhirov <a.obzhirov@samsung.com>
3220 [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
3221 https://bugs.webkit.org/show_bug.cgi?id=110222
3223 Reviewed by Gustavo Noronha Silva.
3225 Added handling of zero mouse scroll deltas in EventSender.
3227 * DumpRenderTree/gtk/EventSender.cpp:
3228 (mouseScrollByCallback):
3230 2013-07-16 Brian Holt <brian.holt@samsung.com>
3232 webkitpy: replace urllib with urllib2 for downloading additional modules
3233 https://bugs.webkit.org/show_bug.cgi?id=118671
3235 Reviewed by Ryosuke Niwa.
3237 Urllib2 is available whereever urllib is, but has better proxy support.
3239 * Scripts/webkitpy/common/system/autoinstall.py:
3240 (AutoInstaller._download_to_stream):
3242 2013-07-16 Krzysztof Czech <k.czech@samsung.com>
3244 [ATK] Adds support for aria-haspopup property.
3245 https://bugs.webkit.org/show_bug.cgi?id=117834
3247 Reviewed by Christophe Dumez.
3249 Adds implementation for testing aria-haspopup property.
3251 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3252 (getAttributeSetValueForId):
3253 (AccessibilityUIElement::stringAttributeValue):
3254 (AccessibilityUIElement::hasPopup):
3255 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3256 (WTR::getAttributeSetValueForId):
3257 (WTR::AccessibilityUIElement::stringAttributeValue):
3258 (WTR::AccessibilityUIElement::hasPopup):
3260 2013-07-16 Michael Brüning <michael.bruning@digia.com>
3262 [Qt] Replace Nokia references.
3263 https://bugs.webkit.org/show_bug.cgi?id=118728
3265 Reviewed by Simon Hausmann.
3267 * MiniBrowser/qt/MiniBrowserApplication.cpp:
3268 (MiniBrowserApplication::MiniBrowserApplication):
3269 * QtTestBrowser/qttestbrowser.cpp:
3270 (LauncherApplication::LauncherApplication):
3272 2013-07-15 Tim Horton <timothy_horton@apple.com>
3274 Update blocked/missing plug-in UI
3275 https://bugs.webkit.org/show_bug.cgi?id=118347
3276 <rdar://problem/14209318>
3278 Reviewed by Sam Weinig.
3280 * MiniBrowser/mac/WK2BrowserWindowController.m:
3281 (-[WK2BrowserWindowController awakeFromNib]):
3282 * WebKitTestRunner/TestController.cpp:
3283 (WTR::TestController::createWebViewWithOptions):
3284 Match new WKPageLoaderClient entry.
3286 2013-07-15 Chris Fleizach <cfleizach@apple.com>
3288 Update James Craig's email address.
3290 * Scripts/webkitpy/common/config/contributors.json:
3292 2013-07-15 Dong-Gwan Kim <donggwan.kim@samsung.com>
3294 [EFL] Add fallback for TestWebKitAPI if opengl is not available.
3295 https://bugs.webkit.org/show_bug.cgi?id=118583
3297 Reviewed by Christophe Dumez.
3299 There're many fails on efl webkit2 API test if opengl is not available.
3300 So, add fallback to non-opengl evas engine.
3302 * TestWebKitAPI/efl/PlatformWebView.cpp:
3303 (TestWebKitAPI::initEcoreEvas):
3305 2013-07-15 Brian Holt <brian.holt@samsung.com>
3307 check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
3308 https://bugs.webkit.org/show_bug.cgi?id=118592
3310 Reviewed by Martin Robinson.
3312 Added a suppression for pylint false positives and a unit test.
3314 * Scripts/webkitpy/style/checkers/python.py:
3316 * Scripts/webkitpy/style/checkers/python_unittest.py:
3317 (PythonCheckerTest.test_check):
3318 (PythonCheckerTest):
3319 (PythonCheckerTest.test_pylint_false_positives):
3320 (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
3321 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
3324 2013-07-15 Xabier Rodriguez Calvar <calvaris@igalia.com>
3326 [GTK] Increase the JHBuild version of GStreamer to 1.0.7
3327 https://bugs.webkit.org/show_bug.cgi?id=115166
3329 Reviewed by Philippe Normand.
3331 * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
3333 2013-07-12 Kwang Yul Seo <skyul@company100.net>
3335 Unreviewed. Add an email address and update my domain of experts.
3337 * Scripts/webkitpy/common/config/contributors.json:
3339 2013-07-12 Emanuele Aina <emanuele.aina@collabora.com>
3341 [jhbuild] Avoid restarting from scratch failed initial checkouts
3342 https://bugs.webkit.org/show_bug.cgi?id=118603
3344 Reviewed by Martin Robinson.
3346 If the initial checkout is interrupted midway (eg. because the internet
3347 connection went down) config files do not get generated and that causes
3348 the next checkout to start from scratch (the missing files cause the
3349 script to delete the build root and the downloaded sources).
3351 By generating the files before invoking jhbuild, subsequent runs are able
3352 to start where the previous run left.
3354 * Scripts/update-webkit-libs-jhbuild:
3355 (saveJhbuildMd5): invoke it before runJhbuild().
3357 2013-07-12 Brent Fulgham <bfulgham@apple.com>
3359 [Windows] Remove single-worker restriction on tests.
3361 * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
3363 2013-07-12 Commit Queue <commit-queue@webkit.org>
3365 Unreviewed, rolling out r152599.
3366 http://trac.webkit.org/changeset/152599
3367 https://bugs.webkit.org/show_bug.cgi?id=118612
3369 This patch includes a failing unit test (Requested by
3370 mrobinson on #webkit).
3372 * Scripts/webkitpy/style/checkers/python.py:
3374 * Scripts/webkitpy/style/checkers/python_unittest.py:
3375 (PythonCheckerTest.test_check):
3376 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
3378 2013-07-12 Emanuele Aina <emanuele.aina@collabora.com>
3380 [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
3381 https://bugs.webkit.org/show_bug.cgi?id=91223
3383 Reviewed by Martin Robinson.
3385 When run on a clean checkout, `build-webkit` complains that no
3386 GNUmakefile exists when trying to detect the previously configured
3387 architecture, but in this case there's no previous configuration so
3388 the warning is pointless.
3390 * Scripts/webkitdirs.pm:
3391 (determineArchitecture): Redirect grep stderr to /dev/null.
3393 2013-07-12 Brian Holt <brian.holt@samsung.com>
3395 check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
3396 https://bugs.webkit.org/show_bug.cgi?id=118592
3398 Reviewed by Martin Robinson.
3400 Added a suppression for pylint false positives and a unit test.
3402 * Scripts/webkitpy/style/checkers/python.py:
3404 * Scripts/webkitpy/style/checkers/python_unittest.py:
3405 (PythonCheckerTest.test_check):
3406 (PythonCheckerTest):
3407 (PythonCheckerTest.test_pylint_false_positives):
3408 (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
3409 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
3412 2013-07-11 Arnaud Renevier <a.renevier@samsung.com>
3414 Unreviewed. Add myself as a committer.
3416 * Scripts/webkitpy/common/config/contributors.json:
3418 2013-07-10 Sergio Correia <sergio.correia@openbossa.org>
3420 Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
3421 https://bugs.webkit.org/show_bug.cgi?id=118538
3423 Reviewed by Christophe Dumez.
3425 When attempting some odd url such as ``foo'', MiniBrowser will now show an
3426 error message such as "Cannot resolve hostname (foo)".
3428 Previously, it had the following behavior if MiniBrowser was started with
3429 such urls, e.g ``./MiniBrowser foo'':
3432 It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
3435 No asserts, naturally, but the view would remain blank, even if we tried to
3436 change to a valid url.
3438 * MiniBrowser/efl/main.c:
3441 2013-07-10 Simon Pena <simon.pena@samsung.com>
3443 [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
3444 https://bugs.webkit.org/show_bug.cgi?id=118509
3446 Reviewed by Martin Robinson.
3448 In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
3449 when trying to remove an event already removed, if another event is
3450 processed in the middle. By using a Deque's takeFirst, we ensure the
3451 element is removed before we dispatch it.
3453 fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
3454 crashes after this fix is added.
3456 * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
3457 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3458 (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
3461 2013-07-09 Ryuan Choi <ryuan.choi@samsung.com>
3463 [EFL] Add ewk_view_device_pixel_ratio_set
3464 https://bugs.webkit.org/show_bug.cgi?id=118521
3466 Reviewed by Gyuyoung Kim.
3468 * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
3470 (parseUserArguments):
3472 2013-07-09 Bruno de Oliveira Abinader <brunoabinader@gmail.com>
3474 Unreviewed change of my email addresses.
3475 https://bugs.webkit.org/show_bug.cgi?id=100122
3477 * Scripts/webkitpy/common/config/contributors.json:
3479 2013-07-09 Anders Carlsson <andersca@apple.com>
3481 DumpRenderTree should stop sending unsupported URLs to NSWorkspace
3482 https://bugs.webkit.org/show_bug.cgi?id=118514
3483 <rdar://problem/13686836>
3485 Reviewed by Sam Weinig.
3487 Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
3489 * DumpRenderTree/DefaultPolicyDelegate.h: Added.
3490 * DumpRenderTree/DefaultPolicyDelegate.m: Added.
3491 (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3492 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3493 Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
3495 * DumpRenderTree/mac/DumpRenderTree.mm:
3496 (allocateGlobalControllers):
3497 Allocate a DefaultPolicyDelegate object.
3499 (resetWebViewToConsistentStateBeforeTesting):
3500 Set the policy delegate to the default policy delegate.
3502 * DumpRenderTree/mac/DumpRenderTreeMac.h:
3503 Declare the defaultPolicyDelegate object.
3505 * DumpRenderTree/mac/TestRunnerMac.mm:
3506 (TestRunner::setCustomPolicyDelegate):
3507 Set the policy delegate to the default delegate if setDelegate is false.
3509 2013-07-08 Zan Dobersek <zdobersek@igalia.com>
3511 KURL unit test fixture class should have a meaningful name
3512 https://bugs.webkit.org/show_bug.cgi?id=118467
3514 Reviewed by Sam Weinig.
3516 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
3517 (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
3518 instead of the generic and inappropriate 'WebCore' name.
3520 2013-07-08 Antti Koivisto <antti@apple.com>
3522 Add Deque::removeLast
3523 https://bugs.webkit.org/show_bug.cgi?id=118466
3525 Reviewed by Andreas Kling.
3527 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3528 * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
3529 (TestWebKitAPI::TEST):
3531 2013-07-08 Brian Holt <brian.holt@samsung.com>
3533 [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
3534 https://bugs.webkit.org/show_bug.cgi?id=118412
3536 Reviewed by Martin Robinson.
3538 An adoptRef is required to balance ref and deref calls.
3540 * DumpRenderTree/gtk/EventSender.cpp:
3541 (beginDragWithFilesCallback):
3543 2013-07-06 Sergio Correia <sergio.correia@openbossa.org>
3545 Update list of EFL WK2 API tests
3546 https://bugs.webkit.org/show_bug.cgi?id=118443
3548 Reviewed by Christophe Dumez.
3550 The following tests were included:
3553 - CloseThenTerminate
3554 - DidAssociateFormControls
3555 - PageVisibilityState
3556 - ResponsivenessTimerDoesntFireEarly
3561 - ResizeReversePaginatedWebView
3562 - ScrollPinningBehaviors
3564 This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
3567 * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
3568 * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
3570 2013-07-05 Tim Horton <timothy_horton@apple.com>
3572 Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
3573 https://bugs.webkit.org/show_bug.cgi?id=118439
3574 <rdar://problem/14366120>
3576 Reviewed by Anders Carlsson.
3578 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
3579 (TestWebKitAPI::didLayout):
3580 (TestWebKitAPI::TEST):
3581 - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
3582 - Assert that we got the right number of pages for sanity.
3583 - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
3584 so much memory that SharedMemory asserts and makes the test time out.
3585 - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
3586 because paint doesn't fire if the window is offscreen.
3588 2013-07-05 Tim Horton <timothy_horton@apple.com>
3590 [wk2] Add API to lock the scroll position at the top or bottom of the page
3591 https://bugs.webkit.org/show_bug.cgi?id=118429
3592 <rdar://problem/14120323>
3594 Reviewed by Anders Carlsson.
3596 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3597 * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
3598 (TestWebKitAPI::didFinishDocumentLoadForFrame):
3599 (TestWebKitAPI::TEST):
3600 Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
3601 all work correctly in the face of resizing the view and scrolling from JS.
3603 2013-07-05 Michael Pruett <michael@68k.org>
3605 Unreviewed. Add myself as a committer.
3607 * Scripts/webkitpy/common/config/contributors.json:
3609 2013-07-05 Xabier Rodriguez Calvar <calvaris@igalia.com>
3611 [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
3612 https://bugs.webkit.org/show_bug.cgi?id=111434
3614 Reviewed by Carlos Garcia Campos.
3616 * Scripts/run-gtk-tests:
3617 (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
3619 2013-07-04 Viatcheslav Ostapenko <sl.ostapenko@samsung.com>
3621 [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
3622 https://bugs.webkit.org/show_bug.cgi?id=118370
3624 Reviewed by Christophe Dumez.
3626 Add fallback to software X11 engine if opengl_x11 engine creation fails.
3628 * DumpRenderTree/efl/DumpRenderTree.cpp:
3631 2013-07-04 Brian Holt <brian.holt@samsung.com>
3633 [ATK] Leak: AtkAttributeSet* should be freed
3634 https://bugs.webkit.org/show_bug.cgi?id=118307
3636 Reviewed by Christophe Dumez.
3638 Fixed memory leaks for AtkAttributeSet by calling
3639 atk_attribute_set_free().
3641 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3642 (AccessibilityController::childElementById):
3643 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3644 (getAtkAttributeSetAsString):
3645 (AccessibilityUIElement::allAttributes):
3646 (AccessibilityUIElement::stringAttributeValue):
3647 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3648 (WTR::childElementById):
3649 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3650 (WTR::getAtkAttributeSetAsString):
3651 (WTR::AccessibilityUIElement::allAttributes):
3652 (WTR::AccessibilityUIElement::stringAttributeValue):
3654 2013-07-03 David Farler <dfarler@apple.com>
3656 Add Makefile to WebKitLauncher
3657 https://bugs.webkit.org/show_bug.cgi?id=118365
3659 Reviewed by Mark Rowe.
3661 * WebKitLauncher/Makefile: Added.
3663 2013-07-03 Brian Holt <brian.holt@samsung.com>
3665 [ATK] Leak: more leaks in AccessibilityUIElement
3666 https://bugs.webkit.org/show_bug.cgi?id=118362
3668 Reviewed by Christophe Dumez.
3670 Free the memory created by g_strdup_printf.
3672 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3673 (AccessibilityUIElement::language):
3674 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3675 (WTR::AccessibilityUIElement::language):
3677 2013-07-03 Jer Noble <jer.noble@apple.com>
3679 Xcode often gets in a state where the debugger is completely unresponsive
3680 https://bugs.webkit.org/show_bug.cgi?id=118157
3682 The GetPointeeData() operations we use to retrieve strings is extremely expensive.
3683 Rather than pull the character data out of the debugger one byte at a time
3684 through the GetPointeeData() API, retrieve the memory contents of the string through
3685 the ReadMemory() API, and convert the retrieved memory into a python string.
3687 Reviewed by Anders Carlsson.
3689 * lldb/lldb_webkit.py:
3690 (__lldb_init_module.lldb_webkit):
3691 (guess_string_length):
3692 (ustring_to_string):
3693 (lstring_to_string):
3695 2013-07-03 Morten Stenshorne <mstensho@opera.com>
3697 [GTK] Let F5 refresh the page in MiniBrowser
3698 https://bugs.webkit.org/show_bug.cgi?id=117638
3700 Reviewed by Carlos Garcia Campos.
3702 Also use the correct icon for the refresh button that was already there.
3704 * MiniBrowser/gtk/BrowserWindow.c:
3705 (browser_window_init):
3707 2013-07-02 Kondapally Kalyan <kalyan.kondapally@intel.com>
3709 Unreviewed. Add my email to a few watchlists.
3711 * Scripts/webkitpy/common/config/watchlist:
3713 2013-07-02 David Farler <dfarler@apple.com>
3715 Unreviewed. Adding myself to contributors.json.
3717 * Scripts/webkitpy/common/config/contributors.json:
3719 2013-07-02 Brian Holt <brian.holt@samsung.com>
3721 [ATK] Leak: leaks in AccessibilityUIElement
3722 https://bugs.webkit.org/show_bug.cgi?id=118297
3726 Reviewed by Christophe Dumez.
3728 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3729 (AccessibilityUIElement::stringValue):
3731 2013-07-02 Byungwoo Lee <bw80.lee@samsung.com>
3733 Fix WebKitTestRunner crashes.
3734 https://bugs.webkit.org/show_bug.cgi?id=117630
3736 Reviewed by Darin Adler.
3738 Create static function to dump for WebProcess unresponsiveness status,
3739 and use it before calling TestController::runTest().
3741 Accessing TestController::m_currentInvocation before calling
3742 TestController::runTest() can make crash because the invocation
3743 instance will be assigned at the function.
3745 * WebKitTestRunner/TestController.cpp:
3746 (WTR::TestController::run):
3747 * WebKitTestRunner/TestInvocation.cpp:
3748 (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
3749 * WebKitTestRunner/TestInvocation.h:
3751 2013-07-02 Allan Sandfeld Jensen <allan.jensen@digia.com>
3753 [Qt][WK1] Support WebGL with EGL on Linux
3754 https://bugs.webkit.org/show_bug.cgi?id=118251
3756 Reviewed by Kenneth Rohde Christiansen.
3758 * qmake/mkspecs/features/features.prf:
3760 2013-07-01 Nick Diego Yamane <nick.yamane@openbossa.org>
3762 [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
3763 https://bugs.webkit.org/show_bug.cgi?id=118267
3765 Reviewed by Gyuyoung Kim.
3767 After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
3768 WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
3769 Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
3774 2013-07-01 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
3776 [GTK] Remove unsupported AC backends
3777 https://bugs.webkit.org/show_bug.cgi?id=117362
3779 Reviewed by Martin Robinson.
3781 * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
3782 and cogl, so removed.
3784 2013-07-01 Timothy Hatcher <timothy@apple.com>
3786 Link to WebInspectorUI.framework at build time instead of soft linking.
3788 https://bugs.webkit.org/show_bug.cgi?id=118261
3790 Reviewed by Joseph Pecoraro.
3792 * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
3794 2013-07-01 Tim Horton <timothy_horton@apple.com>
3796 Maximum scroll position can be negative in some cases
3797 https://bugs.webkit.org/show_bug.cgi?id=118175
3798 <rdar://problem/14301217>
3800 Reviewed by Anders Carlsson.
3802 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3803 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
3804 (TestWebKitAPI::didRunJavaScript):
3805 (TestWebKitAPI::didLayout):
3806 (TestWebKitAPI::TEST):
3807 * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
3808 Add a test that loads a vertical-lr document, paginates it horizontally
3809 from right to left, resizes the view to fit the entire document, and
3810 verifies that the scroll position is negative, as it must be for the
3811 document to be enclosed by the view.
3813 2013-07-01 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
3815 [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
3816 https://bugs.webkit.org/show_bug.cgi?id=117249
3818 Reviewed by Brent Fulgham.
3820 Finish converting all use cases of WEBKITOUTPUTDIR to
3821 WEBKIT_OUTPUTDIR, which seems to be preferred these days.
3823 * DumpRenderTree/efl/FontManagement.cpp:
3824 (getCustomBuildDir):
3825 (getPlatformFontsPath):
3826 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3828 * Scripts/webkitdirs.pm:
3829 (determineBaseProductDir):
3830 (usesPerConfigurationBuildDirectory):
3831 * Scripts/webkitpy/port/base.py:
3832 (Port.to.setup_environ_for_server):
3833 * Scripts/webkitpy/port/driver.py:
3834 (Driver._setup_environ_for_driver):
3835 * Scripts/webkitpy/port/gtk.py:
3836 (GtkPort.setup_environ_for_server):
3837 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3838 (WTR::getOutputDir):
3839 * jhbuild/jhbuildutils.py:
3840 (get_dependencies_path):
3842 2013-07-01 Rafael Brandao <rafael.lobo@webkit.org>
3844 Unreviewed change of my email address.
3846 * Scripts/webkitpy/common/config/contributors.json:
3848 2013-06-28 Andreas Kling <akling@apple.com>
3850 Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
3852 * DumpRenderTree/win/DumpRenderTree.cpp:
3853 (addFontFallbackIfPresent):
3854 (removeFontFallbackIfPresent):
3856 2013-06-28 Anders Carlsson <andersca@apple.com>
3858 Remove String::deprecatedCharactersWithNullTermination() and related code
3859 https://bugs.webkit.org/show_bug.cgi?id=118211
3861 Reviewed by Benjamin Poulain.
3863 Remove all hasTerminatingNullCharacter() checks.
3865 * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
3866 (TestWebKitAPI::TEST):
3867 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3868 (TestWebKitAPI::TEST):
3869 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3870 (TestWebKitAPI::TEST):
3872 2013-06-28 Alexey Proskuryakov <ap@apple.com>
3874 [Mac] Crash when loading is stopped from -didReceiveResponse
3875 https://bugs.webkit.org/show_bug.cgi?id=118209
3876 <rdar://problem/14259249>
3878 Reviewed by Brady Eidson.
3880 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3881 * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
3882 * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
3883 (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
3884 (TestWebKitAPI::TEST):
3886 2013-06-28 Andy Estes <aestes@apple.com>
3888 [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
3889 https://bugs.webkit.org/show_bug.cgi?id=118208
3891 Reviewed by Mark Rowe.
3893 Newer versions of clang use a default template depth of 128, but this
3894 is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
3897 Clang lowered the default to keep recursive template instantiation
3898 from overflowing the stack (see <rdar://problem/13935016>), but
3899 TestWebKitAPI's C++ files don't trigger a stack overflow even with the
3900 higher limit. If for some reason this starts happening then we can
3901 lower the limit back down.
3903 * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
3905 2013-06-28 Nick Diego Yamane <nick.yamane@openbossa.org>
3907 [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
3908 https://bugs.webkit.org/show_bug.cgi?id=118195
3910 Reviewed by Daniel Bates.
3912 Currently, ports that use jhbuild fail to determine jhbuild directory
3913 when "webKitBranchBuild" git configuration property is enabled. To reproduce
3914 that issue in Efl port, enable that flag in .git/config, switch to a git branch
3915 other than "master" and try to build webkit. The build will fail to
3916 locate dependencies due to lack of pkg-config paths which should be set
3919 For more details about "webKitBranchBuild" option, see:
3920 https://trac.webkit.org/wiki/UsingGitWithWebKit
3922 * Scripts/webkitdirs.pm:
3925 2013-06-28 Jessie Berlin <jberlin@apple.com>
3927 WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
3928 https://bugs.webkit.org/show_bug.cgi?id=118201
3930 Reviewed by Dean Jackson.
3932 * WebKitTestRunner/mac/main.mm:
3934 Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
3935 setAutomaticDashSubstitutionEnabled are not exposed on WKView.
3937 2013-06-28 David Farler <dfarler@apple.com>
3939 Upstream WebKit Nightly’s WebKitLauncher
3940 https://bugs.webkit.org/show_bug.cgi?id=117418
3942 Reviewed by Mark Rowe.
3944 Literal patch from Nightly's OpenSource repo.
3946 * WebKitLauncher/Configurations/Base.xcconfig:
3947 * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
3948 * WebKitLauncher/Info.plist:
3949 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3950 * WebKitLauncher/WebKitLauncherURLProtocol.m:
3951 (+[WebKitLauncherURLProtocol load]):
3952 (+[WebKitLauncherURLProtocol canInitWithRequest:]):
3953 (-[WebKitLauncherURLProtocol startLoading]):
3954 (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
3955 (-[WebKitLauncherURLProtocol resourceNotFound]):
3956 * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3957 (initializeSparkle):
3958 * WebKitLauncher/main.m:
3959 (determineExecutablePath):
3960 (currentMacOSXVersion):
3962 * WebKitLauncher/start.html:
3964 2013-06-28 Balazs Kelemen <b.kelemen@samsung.com>
3966 [EFL] back/forward keyboard shortcuts are non-intuitive
3967 https://bugs.webkit.org/show_bug.cgi?id=118193
3969 Reviewed by Christophe Dumez.
3971 Changed shortcuts for go-back/go-forward to alt+left and alt+right.
3973 * EWebLauncher/main.c:
3975 * MiniBrowser/efl/main.c:
3978 2013-06-28 Roger Fong <roger_fong@apple.com>
3980 Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
3981 https://bugs.webkit.org/show_bug.cgi?id=118194.
3983 Reviewed by Brent Fulgham.
3985 * DumpRenderTree/win/DumpRenderTree.cpp:
3986 (dllLauncherEntryPoint):
3987 * WinLauncher/WinLauncher.cpp:
3988 (dllLauncherEntryPoint):
3990 2013-06-28 Roger Fong <roger_fong@apple.com>
3992 Unreviewed build fix for AppleWin port. Fix some file paths.
3994 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3995 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3997 2013-06-27 Roger Fong <roger_fong@apple.com>
3999 Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
4000 https://bugs.webkit.org/show_bug.cgi?id=118160.
4002 Reviewed by Brent Fulgham.
4004 * WinLauncher/AccessibilityDelegate.cpp: Added.
4005 (AccessibilityDelegate::QueryInterface):
4006 (AccessibilityDelegate::AddRef):
4007 (AccessibilityDelegate::Release):
4008 (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
4009 (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
4010 * WinLauncher/AccessibilityDelegate.h: Added.
4011 (AccessibilityDelegate::AccessibilityDelegate):
4012 * WinLauncher/WinLauncher.cpp:
4013 (dllLauncherEntryPoint):
4014 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
4015 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
4017 2013-06-28 Christophe Dumez <ch.dumez@sisa.samsung.com>
4019 Clean up temporary files created by the bindings test script
4020 https://bugs.webkit.org/show_bug.cgi?id=118189
4022 Reviewed by Kentaro Hara.
4024 Remove temporary files created by preprocess-idls.pl script after
4025 the bindings tests are executed.
4027 Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
4029 * Scripts/webkitpy/bindings/main.py:
4030 (BindingsTests.main):
4032 2013-06-26 Dean Jackson <dino@apple.com>
4034 [Mac] Add Mavericks system font to Test systems
4035 https://bugs.webkit.org/show_bug.cgi?id=118109
4037 Reviewed by Simon Fraser.
4039 OS X Mavericks uses a different font for system controls. Tell DRT and
4040 WKTR about them otherwise they use a fallback font. Unfortunately the
4041 fonts are hidden (not found in the list of available fonts) so I
4042 had to add them manually.
4044 Even though there is only one at the moment, I implemented this
4045 as a set so it will be easier to add new fonts if necessary.
4047 * DumpRenderTree/mac/DumpRenderTree.mm:
4048 (allowedFontFamilySet): Fixed typo.
4049 (systemHiddenFontFamilySet): New method that returns the system control font.
4050 (drt_NSFontManager_availableFonts): Merge the hidden fonts.
4051 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
4052 (WTR::allowedFontFamilySet): Fixed typo.
4053 (WTR::systemHiddenFontFamilySet): As above.
4054 (WTR::wtr_NSFontManager_availableFonts):
4056 2013-06-27 Anders Carlsson <andersca@apple.com>
4058 Get rid of the last uses of deprecatedCharactersWithNullTermination()
4059 https://bugs.webkit.org/show_bug.cgi?id=118159
4061 Reviewed by Andreas Kling.
4063 Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
4065 * DumpRenderTree/win/DumpRenderTree.cpp:
4068 2013-06-27 Bem Jones-Bey <bjonesbe@adobe.com>
4070 Sync up w3c import script with changes in Blink
4071 https://bugs.webkit.org/show_bug.cgi?id=118149
4073 Reviewed by Dirk Pranke.
4075 This is a port of the following blink changes:
4077 https://codereview.chromium.org/15366004
4078 https://chromiumcodereview.appspot.com/15592005
4079 https://codereview.chromium.org/16021006
4080 https://codereview.chromium.org/15590004
4081 https://codereview.chromium.org/15901008
4082 https://codereview.chromium.org/16171009
4083 https://codereview.chromium.org/16465007
4084 https://codereview.chromium.org/15981013
4086 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4088 (test_commit_message_for_this_commit):
4089 * Scripts/webkitpy/port/base.py:
4091 * Scripts/webkitpy/port/test.py:
4092 * Scripts/webkitpy/w3c/test_converter.py:
4093 (W3CTestConverter.__init__):
4094 (W3CTestConverter.read_webkit_prefixed_css_property_list):
4095 (W3CTestConverter.convert_for_webkit):
4096 (W3CTestConverter.convert_css):
4097 (W3CTestConverter.convert_html):
4098 (W3CTestConverter.convert_testharness_paths):
4099 (W3CTestConverter.convert_prefixed_properties):
4100 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
4101 * Scripts/webkitpy/w3c/test_converter_unittest.py:
4102 * Scripts/webkitpy/w3c/test_importer.py:
4104 (configure_logging):
4105 (configure_logging.LogHandler):
4106 (configure_logging.LogHandler.format):
4108 (TestImporter.__init__):
4109 (TestImporter.find_importable_tests):
4110 (TestImporter.import_tests):
4111 (TestImporter.setup_destination_directory):
4112 (TestImporter.remove_deleted_files):
4113 * Scripts/webkitpy/w3c/test_importer_unittest.py:
4114 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
4115 (TestImporterTest.test_import_dir_with_no_tests):
4117 * Scripts/webkitpy/w3c/test_parser.py:
4118 (TestParser.load_file):
4119 (TestParser.analyze_test):
4120 (TestParser.support_files):
4121 * Scripts/webkitpy/w3c/test_parser_unittest.py:
4123 2013-06-27 Csaba Osztrogonác <ossy@webkit.org>
4125 [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
4126 https://bugs.webkit.org/show_bug.cgi?id=118128
4128 Reviewed by Ryosuke Niwa.
4130 It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
4131 https://bugs.webkit.org/show_bug.cgi?id=117831
4133 * Scripts/webkitpy/tool/commands/download.py:
4134 (AbstractPatchSequencingCommand):
4135 (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
4136 (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
4137 (AbstractPatchSequencingCommand._prepare_state): Added.
4139 2013-06-27 Brendan Long <b.long@cablelabs.com>
4141 [Qt] Build overrides -j when given --makeargs="-sj40"
4142 https://bugs.webkit.org/show_bug.cgi?id=116897
4144 Reviewed by Csaba Osztrogonác.
4146 * Scripts/webkitdirs.pm:
4147 (buildQMakeProjects):
4148 Change regex checking for -j* to also check for -*j*
4150 2013-06-27 Christophe Dumez <ch.dumez@sisa.samsung.com>
4152 Remove [NoInterfaceObject] from WorkerGlobalScope
4153 https://bugs.webkit.org/show_bug.cgi?id=118071
4155 Reviewed by Kentaro Hara.
4157 Update bindings test script to pass 2 additional parameters
4158 now needed by the preprocess-idls.pl script.
4160 * Scripts/webkitpy/bindings/main.py:
4161 (BindingsTests.generate_supplemental_dependency):
4162 (BindingsTests.main):
4164 2013-06-27 Xabier Rodriguez Calvar <calvaris@igalia.com>
4166 Fixing some compiler warnings
4167 https://bugs.webkit.org/show_bug.cgi?id=117791
4169 Reviewed by Martin Robinson.
4171 * GNUmakefile.am: Silenced format warning.
4172 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4173 (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
4174 Solved warning about uninitialized variable.
4176 2013-06-27 Christophe Dumez <ch.dumez@sisa.samsung.com>
4178 Fix bindings tests after r152080
4179 https://bugs.webkit.org/show_bug.cgi?id=118118
4181 Reviewed by Gyuyoung Kim.
4183 r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
4184 to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
4187 * Scripts/webkitpy/bindings/main.py:
4188 (BindingsTests.generate_supplemental_dependency):
4189 (BindingsTests.main):
4191 2013-06-26 Carlos Garcia Campos <cargarcia@blackberry.com>
4193 [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
4194 https://bugs.webkit.org/show_bug.cgi?id=117982
4196 Reviewed by Rob Buis.
4198 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4199 (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
4200 m_policyDelegateIsPermissive.
4201 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
4202 Reset m_policyDelegateIsPermissive.
4203 (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
4204 m_policyDelegateIsPermissive.
4205 * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
4206 (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
4207 Return whether custom policy is enabled.
4208 (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
4209 Return whether custom policy is permissive.
4211 2013-06-26 Anders Carlsson <andersca@apple.com>
4213 Deprecate StringImpl::charactersWithNullTermination
4214 https://bugs.webkit.org/show_bug.cgi?id=118108
4216 Reviewed by Beth Dakin.
4218 Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
4220 * DumpRenderTree/win/DumpRenderTree.cpp:
4222 (addFontFallbackIfPresent):
4223 (removeFontFallbackIfPresent):
4225 2013-06-26 Nico Weber <thakis@chromium.org>
4227 Remove detect-mismached-virtual-const.
4228 https://bugs.webkit.org/show_bug.cgi?id=117999
4230 Reviewed by Anders Carlsson.
4232 Clang warns on mismatched virtual const, so there's no need for this
4235 * Scripts/detect-mismatched-virtual-const: Removed.
4237 2013-06-26 Alex Christensen <achristensen@apple.com>
4239 Added a code coverage report.
4240 https://bugs.webkit.org/show_bug.cgi?id=117941
4242 Reviewed by Joseph Pecoraro.
4244 * CodeCoverage: Added.
4245 * CodeCoverage/results-template.html: Added.
4246 * Scripts/generate-coverage-data: Generate and open the new report.
4248 2013-06-25 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
4250 gdb: Remove the webcore.py pretty printer.
4251 https://bugs.webkit.org/show_bug.cgi?id=117992
4253 Reviewed by Jochen Eisinger.
4255 webcore.py has been only a placeholder for backwards compatibility
4256 for almost 3 years. It should be safe enough to remove it now.
4258 * gdb/webcore.py: Removed.
4260 2013-05-26 Peter Gal <galpeter@inf.u-szeged.hu>
4262 Creating cURL watchlist and adding myself to it.
4264 Reviewed by Csaba Osztrogonác.
4266 * Scripts/webkitpy/common/config/watchlist:
4268 2013-06-25 Gyuyoung Kim <gyuyoung.kim@samsung.com>
4270 Unreviewed, change my email address for watch list.
4272 * Scripts/webkitpy/common/config/watchlist:
4274 2013-06-25 Byungwoo Lee <bw80.lee@samsung.com>
4276 [EFL] Add a script to install dependencies.
4277 https://bugs.webkit.org/show_bug.cgi?id=117968
4279 Reviewed by Christophe Dumez.
4281 Add a script which installs basic dependencies for building WebKit EFL.
4283 The dependencies are from the current EFLWebKit wiki page.
4284 After this patch is landed, the wiki page will be updated to use
4287 * efl/install-dependencies: Added.
4289 2013-06-24 Dean Jackson <dino@apple.com>
4291 [Mac] Update font used for Chinese in test systems
4292 https://bugs.webkit.org/show_bug.cgi?id=117970
4294 Reviewed by Alexey Proskuryakov.
4296 Add "Songti TC" and "Songti SC" to the list of allowed fonts
4299 * DumpRenderTree/mac/DumpRenderTree.mm:
4300 (allowedFontFamilySet):
4301 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
4302 (WTR::allowedFontFamilySet):
4304 2013-06-24 Tim Horton <timothy_horton@apple.com>
4306 Make MiniBrowser paginated mode work with WebKit1
4307 https://bugs.webkit.org/show_bug.cgi?id=117950
4309 Reviewed by Beth Dakin.
4311 * MiniBrowser/mac/WK1BrowserWindowController.m:
4312 (-[WK1BrowserWindowController isPaginated]):
4313 (-[WK1BrowserWindowController togglePaginationMode:]):
4314 Hook up isPaginated and togglePaginationMode just as for WebKit2.
4316 2013-06-24 David Kilzer <ddkilzer@apple.com>
4318 bisect-builds: improve heuristic for choosing the next build after a broken build
4319 <http://webkit.org/b/117918>
4321 Reviewed by Simon Fraser.
4323 * Scripts/bisect-builds: When a build is broken, use a heuristic
4324 that "bisects" the left side or the right side of the remaining
4325 revisions to pick a revision that's sufficiently different from
4326 the revision of the broken build. This heuristic assumes there
4327 is a sequential range of broken builds whenever one broken build
4330 2013-06-24 Chris Rogers <crogers@google.com>
git://git.webkit.org / WebKit-https.git / blob