[GTK][WPE] install-dependencies should install the required gstreamer packages needed...
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         [GTK][WPE] install-dependencies should install the required gstreamer packages needed for production builds.
4         https://bugs.webkit.org/show_bug.cgi?id=175822
5
6         Reviewed by Xabier Rodriguez-Calvar.
7
8         * gtk/install-dependencies: Add the bad plugins to the list.
9         * wpe/install-dependencies: Add all the gst related packages (copied from GTK listing).
10
11 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
12
13         DataInteractionTests.ExternalSourceAttributedStringToContentEditable hits a debug assertion
14         https://bugs.webkit.org/show_bug.cgi?id=175787
15         <rdar://problem/33996612>
16
17         Reviewed by Wenson Hsieh.
18
19         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
20         (TestWebKitAPI::TEST):
21
22 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
23
24         Typo in "webkit-patch land"
25         https://bugs.webkit.org/show_bug.cgi?id=175788
26
27         Reviewed by Tim Horton.
28
29         * Scripts/webkitpy/tool/steps/commit.py:
30         (Commit._commit_warning):
31
32 2017-08-20  Sam Weinig  <sam@webkit.org>
33
34         StringView could use a function to strip leading/trailing characters without allocation
35         https://bugs.webkit.org/show_bug.cgi?id=175757
36
37         Reviewed by Darin Adler.
38
39         * TestWebKitAPI/Tests/WTF/StringView.cpp:
40         Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().
41
42 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
43
44         [PAL] Move spi/mac directory into PAL
45         https://bugs.webkit.org/show_bug.cgi?id=175649
46
47         Reviewed by Myles C. Maxfield.
48
49         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
50
51 2017-08-21  Per Arne Vollan  <pvollan@apple.com>
52
53         [Win] DRT should only allow any https certificate for localhost.
54         https://bugs.webkit.org/show_bug.cgi?id=175147
55
56         Reviewed by Brent Fulgham.
57
58         Add check to make sure only localhost requests allow any https certificate.
59
60         * DumpRenderTree/win/DumpRenderTree.cpp:
61         (runTest):
62
63 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
64
65         Add WTFLogChannel level to allow runtime log filtering
66         https://bugs.webkit.org/show_bug.cgi?id=175731
67         <rdar://problem/33967234>
68
69         Unreviewed build fix.
70
71         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
72         (TestWebKitAPI::LoggingTest::output): Disable testing output by default because it 
73         fails on some of the bots.
74
75 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
76
77         Add WTFLogChannel level to allow runtime log filtering
78         https://bugs.webkit.org/show_bug.cgi?id=175731
79         <rdar://problem/33967234>
80
81         Reviewed by Jer Noble.
82
83         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
84         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
85         (TestWebKitAPI::LoggingTest::output):
86         (TestWebKitAPI::TEST_F):
87
88 2017-08-19  Wenson Hsieh  <wenson_hsieh@apple.com>
89
90         [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
91         https://bugs.webkit.org/show_bug.cgi?id=175509
92         <rdar://problem/33728169>
93
94         Reviewed by Ryosuke Niwa.
95
96         Removes ExternalSourceAttributedStringToContentEditable and adds
97         ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
98         text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
99         original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
100         debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
101         that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
102         other style attribute, such as color, carries over from the NSAttributedString to the DOM.
103
104         Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.
105
106         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
107         (TestWebKitAPI::TEST):
108
109 2017-08-18  Ryan Haddad  <ryanhaddad@apple.com>
110
111         Unreviewed, rolling out r220938.
112
113         The API tests added with this change are failing.
114
115         Reverted changeset:
116
117         "Add WTFLogChannel level to allow runtime log filtering"
118         https://bugs.webkit.org/show_bug.cgi?id=175731
119         http://trac.webkit.org/changeset/220938
120
121 2017-08-18  Devin Rousso  <webkit@devinrousso.com>
122
123         Unreviewed, change my email.
124
125         * Scripts/webkitpy/common/config/contributors.json:
126
127 2017-08-18  Jonathan Bedard  <jbedard@apple.com>
128
129         Fix leak-checking for iOS Simulators
130         https://bugs.webkit.org/show_bug.cgi?id=175735
131
132         Reviewed by Darin Adler.
133
134         If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
135         Simulator (or device) because the process will have already been killed by the time we
136         check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.
137
138         * Scripts/webkitpy/port/server_process.py:
139         (ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
140         (ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
141         and SimulatorProcess.
142         * Scripts/webkitpy/port/simulator_process.py:
143         (SimulatorProcess.stop): Before closing the process, check for leaks.
144
145 2017-08-18  Eric Carlson  <eric.carlson@apple.com>
146
147         Add WTFLogChannel level to allow runtime log filtering
148         https://bugs.webkit.org/show_bug.cgi?id=175731
149         <rdar://problem/33967234>
150
151         Reviewed by Jer Noble.
152
153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
154         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
155         (TestWebKitAPI::LoggingTest::output):
156         (TestWebKitAPI::TEST_F):
157
158 2017-08-18  Alexey Proskuryakov  <ap@apple.com>
159
160         Add Dean Johnson to contributors.json for Bugzilla autocomplete.
161
162         * Scripts/webkitpy/common/config/contributors.json:
163
164 2017-08-18  Ross Kirsling  <ross.kirsling@sony.com>
165
166         [Tools] Add script to download a GitHub release
167         https://bugs.webkit.org/show_bug.cgi?id=175279
168
169         Reviewed by Brent Fulgham.
170
171         * Scripts/download-latest-github-release.py: Added.
172
173 2017-08-18  Commit Queue  <commit-queue@webkit.org>
174
175         Unreviewed, rolling out r220854.
176         https://bugs.webkit.org/show_bug.cgi?id=175716
177
178         I'm not sure we really need this (Requested by KaL on
179         #webkit).
180
181         Reverted changeset:
182
183         "[GTK][WPE] Add NTLM authentication enabled API"
184         https://bugs.webkit.org/show_bug.cgi?id=122952
185         http://trac.webkit.org/changeset/220854
186
187 2017-08-17  Michael Catanzaro  <mcatanzaro@igalia.com>
188
189         [GTK] Make TestContextMenu work on Fedora
190         https://bugs.webkit.org/show_bug.cgi?id=175708
191
192         Reviewed by Carlos Garcia Campos.
193
194         TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
195         and my student last summer who was trying to work on a context menu API. It's trying to load
196         an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
197         entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
198         don't care to investigate. Let's switch it to WebM so I can move on.
199
200         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
201         (prepareContextMenuTestView):
202         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
203         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
204
205 2017-08-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
206
207         check-webkit-style shouldn't check spacing in #elif preprocessor lines
208         https://bugs.webkit.org/show_bug.cgi?id=175652
209
210         Reviewed by Alex Christensen.
211
212         * Scripts/webkitpy/style/checkers/cpp.py:
213         (check_spacing):
214         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
215         (CppStyleTest.test_spacing_for_binary_ops):
216
217 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
218
219         Fix the build on other platforms after r220865
220         https://bugs.webkit.org/show_bug.cgi?id=175683
221
222         Reviewed by Tim Horton.
223
224         Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
225         availability is determined by SDK version rather than deployment version.
226
227         * TestWebKitAPI/ios/UIKitSPI.h:
228
229 2017-08-17  Andreas Kling  <akling@apple.com>
230
231         Disable CSS regions at compile time
232         https://bugs.webkit.org/show_bug.cgi?id=175630
233
234         Reviewed by Antti Koivisto.
235
236         * Scripts/webkitperl/FeatureList.pm:
237         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
238
239 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
240
241         Unreviewed, try to fix the internal iOS 10 build after r220865.
242
243         * TestWebKitAPI/ios/UIKitSPI.h:
244
245         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
246         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
247         this compiler guard.
248
249 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
250
251         [iOS] Respect type fidelities when copying image elements to the pasteboard
252         https://bugs.webkit.org/show_bug.cgi?id=175638
253         <rdar://problem/26556043>
254
255         Reviewed by Ryosuke Niwa.
256
257         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
258         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
259         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
260
261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
262         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
263         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
264         (TestWebKitAPI::TEST):
265         (TestWebKitAPI::presentActionSheetAndChooseAction):
266         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
267         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
268         (checkEstimatedSize):
269         (checkSuggestedNameAndEstimatedSize):
270
271         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
272
273         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
274         (TestWebKitAPI::TEST):
275         * TestWebKitAPI/ios/DataInteractionSimulator.h:
276         * TestWebKitAPI/ios/UIKitSPI.h: Added.
277
278 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
279
280         Recursively create resource load statistics folder for testing
281         https://bugs.webkit.org/show_bug.cgi?id=175676
282
283         Reviewed by Brady Eidson.
284
285         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
286         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
287
288 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
289
290         [GTK][WPE] Add NTLM authentication enabled API
291         https://bugs.webkit.org/show_bug.cgi?id=122952
292
293         Reviewed by Michael Catanzaro.
294
295         Add a test case to check we can enable/disable NTLM.
296
297         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
298         (testWebViewAuthenticationNTLM):
299         (beforeAll):
300
301 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
302
303         [PAL] Move spi/ios and spi/win directories into PAL
304         https://bugs.webkit.org/show_bug.cgi?id=175171
305
306         Reviewed by Antti Koivisto.
307
308         * DumpRenderTree/mac/EventSendingController.mm:
309
310 2017-08-16  Andy Estes  <aestes@apple.com>
311
312         [Payment Request] Add an ENABLE flag and an experimental feature preference
313         https://bugs.webkit.org/show_bug.cgi?id=175622
314
315         Reviewed by Tim Horton.
316
317         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
318         * WebKitTestRunner/TestController.cpp:
319         (WTR::TestController::resetPreferencesToConsistentValues):
320
321 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
322
323         undefined URL in PopoverTracker for failed step
324         https://bugs.webkit.org/show_bug.cgi?id=175593
325         <rdar://problem/33898769>
326
327         Reviewed by Daniel Bates.
328
329         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
330         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
331
332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
333         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
334         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
336         (BuildbotTestResults): Accept URL in constructor.
337
338 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
339
340         Remove Proximity Events and related code
341         https://bugs.webkit.org/show_bug.cgi?id=175545
342
343         Reviewed by Daniel Bates.
344
345         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
346         and other related code.
347
348         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
349
350 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
351
352         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
353         https://bugs.webkit.org/show_bug.cgi?id=175504
354
355         Reviewed by Sam Weinig.
356
357         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
358
359 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
360
361         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
362         https://bugs.webkit.org/show_bug.cgi?id=175557
363
364         Reviewed by Jon Lee.
365         
366         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
367
368         * DumpRenderTree/TestRunner.cpp:
369         (TestRunner::staticFunctions):
370         (setViewModeMediaFeatureCallback): Deleted.
371         * DumpRenderTree/TestRunner.h:
372         * DumpRenderTree/mac/TestRunnerMac.mm:
373         (TestRunner::setViewModeMediaFeature): Deleted.
374         * DumpRenderTree/win/TestRunnerWin.cpp:
375         (TestRunner::setViewModeMediaFeature): Deleted.
376         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
377
378 2017-08-14  Andy Estes  <aestes@apple.com>
379
380         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
381         https://bugs.webkit.org/show_bug.cgi?id=175548
382         <rdar://problem/33866206>
383
384         Reviewed by Brady Eidson.
385
386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
387         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
388         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
389
390 2017-08-14  Youenn Fablet  <youenn@apple.com>
391
392         WPT server should be able to do logging even if its output folder is not created at launch time
393         https://bugs.webkit.org/show_bug.cgi?id=175543
394
395         Reviewed by Alexey Proskuryakov.
396
397         Removing no longer used stdout/stderr member variables.
398         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
399
400         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
401         (WebPlatformTestServer.__init__):
402         (WebPlatformTestServer._prepare_config):
403         (WebPlatformTestServer._spawn_process):
404         (WebPlatformTestServer._stop_running_server):
405
406 2017-08-14  Daniel Bates  <dabates@apple.com>
407
408         webkit-patch: Passing --no-review should submit patch to EWS by default
409         https://bugs.webkit.org/show_bug.cgi?id=148899
410
411         Reviewed by David Kilzer.
412
413         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
414         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
415         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
416
417         Frequently I want to post a draft of a patch without review to have the EWS bots process
418         it to catch build and test breakage before I clean it up and post it for formal review.
419         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
420         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
421         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
422
423         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
424         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
425         parse the attachment id from the response page after adding an attachment to the bug.
426         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
427         HTTP response after uploading the patch.
428         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
429         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
430         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
431         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
432         * Scripts/webkitpy/tool/commands/upload.py:
433         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
434         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
435         this command.
436         (PostCommits.execute): Submit the patch to EWS, if applicable.
437         * Scripts/webkitpy/tool/commands/upload_unittest.py:
438         (test_upload): Set options.ews to False as the upload command expects this option
439         to be specified.
440         (test_upload_with_no_review_and_ews): Added.
441         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
442         * Scripts/webkitpy/tool/steps/options.py:
443         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
444         * Scripts/webkitpy/tool/steps/postdiff.py:
445         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
446         this command.
447         (PostDiff.run): Submit the patch to EWS, if applicable.
448         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
449         (SubmitToEWS):
450         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
451         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
452
453 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
454
455         Disable two flaky VideoControlsManager API tests.
456
457         Unreviewed test gardening.
458
459         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
460         (TestWebKitAPI::TEST):
461
462 2017-08-14  Tim Horton  <timothy_horton@apple.com>
463
464         Only create directory and sandbox extension handle for storage directories if they are set
465         https://bugs.webkit.org/show_bug.cgi?id=175522
466
467         Reviewed by Brady Eidson.
468
469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
470         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
471         (TEST):
472         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
473         doesn't log anything to stderr.
474
475 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
476
477         sub-categorize Sandbox violation logs
478         https://bugs.webkit.org/show_bug.cgi?id=175536
479         <rdar://problem/33834416>
480
481         Reviewed by David Kilzer.
482
483         * Scripts/webkitpy/common/system/crashlogs.py:
484         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
485         a Sandbox violation.
486         (CrashLogs._find_all_logs_darwin): Update comment.
487         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
488         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
489         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
490         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
491         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
492         * Scripts/webkitpy/port/darwin.py:
493         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
494
495 2017-08-14  Daniel Bates  <dabates@apple.com>
496
497         Add Automator service to copy permalink to Clipboard
498         https://bugs.webkit.org/show_bug.cgi?id=170978
499
500         Reviewed by Joseph Pecoraro.
501
502         It is helpful to reference using a hyperlink a particular line of code when having
503         a discussion on IRC or in a bug. You can get such a link by navigating to the file
504         in the Trac Browse Source viewer and selecting the line your are interested in.
505         I found myself doing this often enough that I wrote an Automator service to do it
506         for me.
507
508         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
509
510         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
511         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
512         * CopyPermalink/README: Added.
513
514 2017-08-14  Chris Dumez  <cdumez@apple.com>
515
516         Address flakiness related to download tests
517         https://bugs.webkit.org/show_bug.cgi?id=175338
518         <rdar://problem/33865119>
519
520         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
521         between tests.
522
523         * WebKitTestRunner/TestController.cpp:
524         (WTR::TestController::resetStateToConsistentValues):
525
526 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
527
528         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
529         https://bugs.webkit.org/show_bug.cgi?id=175474
530         <rdar://problem/33844628>
531
532         Reviewed by Wenson Hsieh.
533
534         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
535
536         * DumpRenderTree/mac/DumpRenderTree.mm:
537         (resetWebPreferencesToConsistentValues):
538         * WebKitTestRunner/TestController.cpp:
539         (WTR::TestController::resetPreferencesToConsistentValues):
540
541 2017-08-12  Chris Dumez  <cdumez@apple.com>
542
543         Address flakiness related to download tests
544         https://bugs.webkit.org/show_bug.cgi?id=175338
545
546         Reviewed by Ryosuke Niwa.
547
548         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
549           is actually queried when a download completes. Previously, this would be
550           identical to a call to testRunner.waitUntilDone() because any download
551           completion would call testRunner.notifyDone().
552         - Disable logging of download callbacks by default and add a
553           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
554           enable such logging.
555
556         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
557         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
558         (WTR::InjectedBundle::didReceiveMessageToPage):
559         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
560         (WTR::TestRunner::setShouldLogDownloadCallbacks):
561         * WebKitTestRunner/InjectedBundle/TestRunner.h:
562         * WebKitTestRunner/TestController.cpp:
563         (WTR::TestController::downloadDidStart):
564         (WTR::TestController::decideDestinationWithSuggestedFilename):
565         (WTR::TestController::downloadDidFinish):
566         (WTR::TestController::downloadDidFail):
567         (WTR::TestController::downloadDidCancel):
568         * WebKitTestRunner/TestController.h:
569         (WTR::TestController::setShouldLogDownloadCallbacks):
570         * WebKitTestRunner/TestInvocation.cpp:
571         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
572
573 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
574
575         Create mock ITP data in testing to prevent grandfathering
576         https://bugs.webkit.org/show_bug.cgi?id=174720
577
578         Unreviewed follow-up fix for r220604.
579
580         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
581         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
582
583 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
584
585         Create mock ITP data in testing to prevent grandfathering
586         https://bugs.webkit.org/show_bug.cgi?id=174720
587         <rdar://problem/33457779>
588
589         Reviewed by Brent Fulgham.
590
591         We don't need to be triggering grandfathering when each test runner starts. On Mac,
592         this may launch plugins which can cause layout tests to fail later if the test
593         runner does not shut-down before the plugins unload.
594
595         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
596         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
597         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
598         prevent grandfathering from being triggered.
599         * WebKitTestRunner/ios/TestControllerIOS.mm:
600         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
601         * WebKitTestRunner/mac/TestControllerMac.mm:
602         (WTR::TestController::platformInitialize): Ditto.
603
604 2017-08-11  Sam Weinig  <sam@webkit.org>
605
606         WTF::Function does not allow for reference / non-default constructible return types
607         https://bugs.webkit.org/show_bug.cgi?id=175244
608         <rdar://problem/33801582>
609
610         Reviewed by Chris Dumez.
611
612         * TestWebKitAPI/Tests/WTF/Function.cpp:
613         (TestWebKitAPI::TEST):
614
615 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
616
617         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
618         https://bugs.webkit.org/show_bug.cgi?id=175378
619
620         Reviewed by Sergio Villar Senin.
621
622         Add two test cases to check proxy authentication.
623
624         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
625         (Tunnel::Tunnel):
626         (Tunnel::~Tunnel):
627         (Tunnel::connect):
628         (Tunnel::connected):
629         (serverCallback):
630         (ProxyAuthenticationTest::ProxyAuthenticationTest):
631         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
632         (ProxyAuthenticationTest::proxyServerPortAsString):
633         (testWebViewAuthenticationProxy):
634         (testWebViewAuthenticationProxyHTTPS):
635         (beforeAll):
636
637 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
638
639         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
640         https://bugs.webkit.org/show_bug.cgi?id=175428
641
642         Both ports share the GStreamer code as multimedia backend and till
643         not so long they were using different versions. Now they do use
644         the same versions and it does not make any sense anymore (and
645         neither had sense before) to have differences in the modulesets.
646
647         In this patch I created a GStreamer moduleset and referenced it
648         from both GTK+'s and WPE's. GStreamer patches were also moved there.
649
650         Reviewed by Žan Doberšek.
651
652         * gstreamer/jhbuild.modules: Added.
653         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
654         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
655         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
656         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
657         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
658         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
659         * gtk/jhbuild.modules:
660         * wpe/jhbuild.modules:
661         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
662         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
663         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
664         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
665         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
666
667 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
668
669         Unreviewed, adding Ross Kirsling to contributors.json
670
671         * Scripts/webkitpy/common/config/contributors.json:
672
673 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
674
675         Unreviewed, attempt to fix build failure with VC2017
676
677         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
678         (TEST):
679
680 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
681
682         Unreviewed, suppress warnings on GCC
683
684         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
685         (TestWebKitAPI::CheckedArithmeticTester::run):
686
687 2017-08-10  Dan Bernstein  <mitz@apple.com>
688
689         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
690         https://bugs.webkit.org/show_bug.cgi?id=173223
691
692         Reviewed by Tim Horton.
693
694         The rebuilds were happening due to a difference in the compiler options that the IDE and
695         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
696         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
697         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
698         Advanced when a Custom Absolute path is selected.
699
700         * Scripts/webkitdirs.pm:
701         (determineBaseProductDir):
702
703 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
704
705         Run more WTF tests
706         https://bugs.webkit.org/show_bug.cgi?id=174970
707
708         Reviewed by Michael Catanzaro.
709
710         Some of WTF tests are not executed in non Apple ports while they are generic ones.
711         This patch adds these tests to non-Apple port TestWebKitAPI.
712         Currently, we do not add Signals.cpp since it depends on signal functionality.
713
714         * TestWebKitAPI/CMakeLists.txt:
715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
716         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
717         (isHigherPriority):
718         (TEST):
719         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
720         (TEST):
721         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
722         (TEST):
723
724 2017-08-10  obinna obike  <oobike@apple.com>
725
726         Remove obsolete link from webkit-queues status page
727         https://bugs.webkit.org/show_bug.cgi?id=175337
728
729         Reviewed by Aakash Jain.
730
731         * QueueStatusServer/templates/recentstatus.html:
732         Removed the link to the ews-watcher server.
733
734 2017-08-10  Brian Burg  <bburg@apple.com>
735
736         WKPreferences should conform to NSCopying
737         https://bugs.webkit.org/show_bug.cgi?id=175303
738         <rdar://problem/33764939>
739
740         Reviewed by Dan Bernstein.
741
742         Add unit test to make sure a WKPreference and its copy are
743         not aliased to each other or affect each other's properties.
744
745         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
746         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
747         (TEST):
748
749 2017-08-10  Tim Horton  <timothy_horton@apple.com>
750
751         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
752         https://bugs.webkit.org/show_bug.cgi?id=175436
753         <rdar://problem/33667497>
754
755         Reviewed by Simon Fraser.
756
757         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
758         (TestWebKitAPI::TEST_F):
759
760 2017-08-10  Lucas Forschler  <lforschler@apple.com>
761
762         Fix duplicated code in r220534.
763
764         Unreviewed cleanup.
765
766         * Scripts/bisect-builds:
767
768 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
769
770         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
771         https://bugs.webkit.org/show_bug.cgi?id=175344
772         <rdar://problem/28507240>
773
774         Reviewed by Alexey Proskuryakov.
775
776         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
777         Finally enable the existing tests for iOS.
778
779         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
780         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
782         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
783
784 2017-08-10  Lucas Forschler  <lforschler@apple.com>
785
786         Write a tool to bisect WebKit builds
787         https://bugs.webkit.org/show_bug.cgi?id=174596
788
789         Reviewed by Dean Johnson and Kocsen Chung.
790
791         * Scripts/bisect-builds: Added.
792         (bisect_builds): main bisection algorithm
793         (download_archive):download an archive from S3 using existing tools
794         (extract_archive):extract an archive using existing tools
795         (find_le):Find rightmost value less than or equal to x
796         (find_ge):Find leftmost item greater than or equal to x
797         (get_api_url):generate url for the rest api/database
798         (get_indices_from_revisions):convert revisions to list indexes for bisection
799         (get_sorted_revisions):retrieve sorted revision list
800         (get_s3_location_for_revision):calculate the S3 archive storage location
801         (parse_args):parse command line arguments
802         (pick_next_build):compute the next build to bisect
803         (prompt_did_reproduce):prompt user for direction for bisection
804         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
805         (test_archive):Platform specific logic to test downloaded archive
806         (minified_platforms):return a list of minified platforms in the database
807         (unminified_platforms):return a list of full platforms in the database
808         (is_supported_platform):check if platform is supported
809         (validate_options):validate command line options
810         (main):
811
812 2017-08-10  Lucas Forschler  <lforschler@apple.com>
813
814         Remove bisect-builds script.
815         https://bugs.webkit.org/show_bug.cgi?id=175433
816         
817         Reviewed by Aakash Jain.
818
819         * Scripts/bisect-builds: Removed.
820
821 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
822
823         Remove ENABLE_GAMEPAD_DEPRECATED
824         https://bugs.webkit.org/show_bug.cgi?id=175361
825
826         Reviewed by Carlos Garcia Campos.
827
828         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
829
830 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
831
832         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
833         https://bugs.webkit.org/show_bug.cgi?id=175426
834
835         Reviewed by Carlos Garcia Campos.
836
837         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
838
839 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
840
841         Add Ms2ger as contributor.
842         https://bugs.webkit.org/show_bug.cgi?id=175325
843
844         Reviewed by Carlos Alberto Lopez Perez.
845
846         * Scripts/webkitpy/common/config/contributors.json:
847
848 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
849
850         Fix run-benchmark after r220483.
851         https://bugs.webkit.org/show_bug.cgi?id=175415
852         <rdar://problem/33803003>
853
854         Reviewed by Ryosuke Niwa.
855
856         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
857
858         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
859         (WebServerBenchmarkRunner._run_one_test):
860
861 2017-08-09  Chris Dumez  <cdumez@apple.com>
862
863         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
864         https://bugs.webkit.org/show_bug.cgi?id=175401
865
866         Reviewed by Brady Eidson.
867
868         * DumpRenderTree/mac/DumpRenderTree.mm:
869         (enableExperimentalFeatures):
870
871 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
872
873         [PAL] Move spi/cocoa and spi/cg directories into PAL
874         https://bugs.webkit.org/show_bug.cgi?id=175175
875
876         Reviewed by Myles C. Maxfield.
877
878         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
879         * DumpRenderTree/mac/DumpRenderTree.mm:
880         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
881         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
882
883         * Scripts/webkitpy/style/checker.py:
884         * Scripts/webkitpy/style/checker_unittest.py:
885         (GlobalVariablesTest.test_path_rules_specifier):
886
887         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
888
889         * Scripts/webkitpy/style/checkers/cpp.py:
890         (check_braces):
891         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
892         (WebKitStyleTest.test_braces.CF_OPTIONS):
893         (WebKitStyleTest.test_braces):
894
895         Prevent CF_OPTIONS() from being handled as funtion definition.
896
897 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
898
899         [WTF] Move TextStream into WTF
900         https://bugs.webkit.org/show_bug.cgi?id=175211
901
902         Reviewed by Myles C. Maxfield.
903
904         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
905
906 2017-08-09  Andy Estes  <aestes@apple.com>
907
908         Part 3 of: Rename DatabaseProcess to StorageProcess
909         https://bugs.webkit.org/show_bug.cgi?id=175034
910
911         Reviewed by Brady Eidson.
912
913         * WebKitTestRunner/TestController.cpp:
914         (WTR::TestController::databaseProcessName): Updated to return
915         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
916
917 2017-08-09  Commit Queue  <commit-queue@webkit.org>
918
919         Unreviewed, rolling out r220466, r220477, and r220487.
920         https://bugs.webkit.org/show_bug.cgi?id=175411
921
922         This change broke existing API tests and follow up fixes did
923         not resolve all the issues. (Requested by ryanhaddad on
924         #webkit).
925
926         Reverted changesets:
927
928         https://bugs.webkit.org/show_bug.cgi?id=175244
929         http://trac.webkit.org/changeset/220466
930
931         "WTF::Function does not allow for reference / non-default
932         constructible return types"
933         https://bugs.webkit.org/show_bug.cgi?id=175244
934         http://trac.webkit.org/changeset/220477
935
936         https://bugs.webkit.org/show_bug.cgi?id=175244
937         http://trac.webkit.org/changeset/220487
938
939 2017-08-09  Sam Weinig  <sam@webkit.org>
940
941         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
942
943         Remove one addition of null Function test.
944
945 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
946
947         Allow nested timeouts in webkitpy
948         https://bugs.webkit.org/show_bug.cgi?id=175390
949         <rdar://problem/33803003>
950
951         Reviewed by David Kilzer.
952
953         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
954         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
955         the executive to detect and recover from any issues connecting with devices.
956
957         * Scripts/webkitpy/benchmark_runner/utils.py:
958         (TimeoutError): Deleted.
959         (timeout): Deleted.
960         * Scripts/webkitpy/common/timeout_context.py: Added.
961         (Timeout): A timeout context designed to be nested.
962         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
963         (Timeout.TimeoutData.__init__):
964         (Timeout.default_handler): Timeout handler used if none is specified.
965         (Timeout.current): Access data about the most urgent timeout.
966         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
967         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
968         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
969         urgent timeout data.
970         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
971         most urgent timeout data, if such data exists.
972         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
973         (TimeoutContextTests):
974         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
975         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
976         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
977         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
978         over a less urgent outer timeout.
979         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
980         over a less urgent inner timeout.
981         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
982         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
983         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
984         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
985         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
986         * Scripts/webkitpy/port/simulator_process.py:
987         (SimulatorProcess._start): Use Timeout class.
988         * Scripts/webkitpy/xcode/simulated_device.py:
989         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
990         (SimulatedDevice.launch_app): Ditto.
991         (SimulatedDevice.launch_app._install_timeout): Deleted.
992         * Scripts/webkitpy/xcode/simulator.py:
993         (Simulator.wait_until_device_is_booted):Use Timeout class.
994         (Simulator.wait_until_device_is_in_state): Ditto.
995
996 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
997
998         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
999         https://bugs.webkit.org/show_bug.cgi?id=175392
1000         <rdar://problem/33783207>
1001
1002         Reviewed by Tim Horton and Megan Gardner.
1003
1004         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
1005
1006         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1007
1008 2017-08-09  Sam Weinig  <sam@webkit.org>
1009
1010         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
1011
1012         * TestWebKitAPI/Tests/WTF/Function.cpp:
1013         Remove tests of null Functions, as they are no longer supported.
1014
1015 2017-08-09  Daniel Bates  <dabates@apple.com>
1016
1017         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1018         https://bugs.webkit.org/show_bug.cgi?id=175247
1019         <rdar://problem/33679804>
1020
1021         Reviewed by Brady Eidson.
1022
1023         Add tests for redirects.
1024
1025         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1026         (TEST):
1027         * TestWebKitAPI/cocoa/TestProtocol.mm:
1028         (createRedirectURL):
1029         (-[TestProtocol startLoading]):
1030
1031 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1032
1033         Unreviewed, rolling out r220393.
1034
1035         This patch regresses the performance of WebPage::editorState.
1036
1037         Reverted changeset:
1038
1039         "[iOS WK2] WKWebView schedules nonstop layout after pressing
1040         cmb+b,i,u inside a contenteditable div"
1041         https://bugs.webkit.org/show_bug.cgi?id=175116
1042         http://trac.webkit.org/changeset/220393
1043
1044 2017-08-08  obinna obike  <oobike@apple.com>
1045
1046         Created Individual EWS Pages
1047         https://bugs.webkit.org/show_bug.cgi?id=174477
1048
1049         Reviewed by Aakash Jain.
1050
1051         Created individual pages for each EWS. Changed the link within each status bubble
1052         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
1053
1054         * QueueStatusServer/handlers/patch.py:
1055         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
1056         * QueueStatusServer/handlers/statusbubble.py:
1057         (StatusBubble._build_bubble): Updated url for specific EWS.
1058         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
1059         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
1060         all ews queues.
1061         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
1062         takes you directly to the individual ews page.
1063
1064 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
1065
1066         Separate jsc stress test script writer from run-jsc-stress-tests
1067         https://bugs.webkit.org/show_bug.cgi?id=175216
1068
1069         Reviewed by Mark Lam.
1070
1071         * Scripts/run-jsc-stress-tests:
1072         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
1073
1074 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1075
1076         Unreviewed, fix Ubuntu LTS build
1077         https://bugs.webkit.org/show_bug.cgi?id=174490
1078
1079         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1080
1081 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1082
1083         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
1084         https://bugs.webkit.org/show_bug.cgi?id=175302
1085         <rdar://problem/33762116>
1086
1087         Reviewed by Tim Horton.
1088
1089         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
1090         See WebKit ChangeLog for more details.
1091
1092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1093         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
1094         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
1095         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
1096         (-[SlowTextInputContext handleEvent:completionHandler:]):
1097         (-[SlowInputWebView inputContext]):
1098         (-[SlowInputWebView _web_superInputContext]):
1099         (TEST):
1100
1101 2017-08-08  John Wilander  <wilander@apple.com>
1102
1103         Resource Load Statistics: Clear web processes' state on history removal
1104         https://bugs.webkit.org/show_bug.cgi?id=175271
1105         <rdar://problem/33756560>
1106
1107         Reviewed by Chris Dumez.
1108
1109         Test infrastructure for asynchronous tests of website data
1110         removal for _WKWebsiteDataTypeResourceLoadStatistics.
1111
1112         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1113         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1114         (WTR::InjectedBundle::didReceiveMessageToPage):
1115         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1116         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1117         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
1118         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1119         * WebKitTestRunner/TestController.cpp:
1120         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1121         * WebKitTestRunner/TestController.h:
1122         * WebKitTestRunner/TestInvocation.cpp:
1123         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1124         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
1125         * WebKitTestRunner/TestInvocation.h:
1126         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1127         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1128
1129 2017-08-08  Alicia Boya García  <aboya@igalia.com>
1130
1131         Add Alicia Boya García as contributor
1132         https://bugs.webkit.org/show_bug.cgi?id=175326
1133
1134         Reviewed by Michael Catanzaro.
1135
1136         * Scripts/webkitpy/common/config/contributors.json:
1137
1138 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1139
1140         [CMake] Properly test if compiler supports compiler flags
1141         https://bugs.webkit.org/show_bug.cgi?id=174490
1142
1143         Reviewed by Konstantin Tokarev.
1144
1145         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1146         * MiniBrowser/gtk/CMakeLists.txt:
1147         * TestRunnerShared/Bindings/JSWrapper.cpp:
1148         (WTR::JSWrapper::initialize):
1149         * TestWebKitAPI/CMakeLists.txt:
1150         * TestWebKitAPI/PlatformGTK.cmake:
1151         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1152         (TestWebKitAPI::CheckedArithmeticTester::run):
1153         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1154         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1155         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1156         (formControlsAssociatedCallback):
1157         * TestWebKitAPI/glib/CMakeLists.txt:
1158         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1159         (Test::getResourcesDir):
1160         * WebKitTestRunner/CMakeLists.txt:
1161         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1162         (WTR::menuItemClickCallback):
1163         (WTR::staticConvertMenuItemToType):
1164         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1165         (WTR::TestRunner::setUseDashboardCompatibilityMode):
1166         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1167         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1168         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1169         (WTR::AccessibilityUIElement::helpText const):
1170         (WTR::AccessibilityUIElement::attributedStringForRange):
1171         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1172         (WTR::EventSenderProxy::updateTouchPoint):
1173         (WTR::EventSenderProxy::releaseTouchPoint):
1174
1175 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1176
1177         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
1178         https://bugs.webkit.org/show_bug.cgi?id=175116
1179         <rdar://problem/28279301>
1180
1181         Reviewed by Darin Adler and Ryosuke Niwa.
1182
1183         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
1184         EditorStateTests run on both iOS and Mac.
1185
1186         * TestWebKitAPI/EditingTestHarness.h: Added.
1187         * TestWebKitAPI/EditingTestHarness.mm: Added.
1188
1189         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
1190         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
1191         the state of the latest observed EditorState.
1192
1193         (-[EditingTestHarness initWithWebView:]):
1194         (-[EditingTestHarness dealloc]):
1195         (-[EditingTestHarness webView]):
1196         (-[EditingTestHarness latestEditorState]):
1197         (-[EditingTestHarness editorStateHistory]):
1198         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
1199         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
1200         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
1201         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
1202         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
1203         (-[EditingTestHarness toggleBold]):
1204         (-[EditingTestHarness toggleItalic]):
1205         (-[EditingTestHarness toggleUnderline]):
1206         (-[EditingTestHarness setForegroundColor:]):
1207         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
1208         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
1209         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
1210         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
1211         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
1212         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
1213         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
1214
1215         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
1216         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
1217         keys and values.
1218
1219         (-[EditingTestHarness latestEditorStateContains:]):
1220         (-[EditingTestHarness _webView:editorStateDidChange:]):
1221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1222         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
1223         (TestWebKitAPI::setUpEditorStateTestHarness):
1224         (TestWebKitAPI::TEST):
1225         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
1226
1227 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
1228
1229         Prevent domain from being set to a TLD
1230         https://bugs.webkit.org/show_bug.cgi?id=175226
1231         <rdar://problem/11079948>
1232
1233         Reviewed by Chris Dumez.
1234
1235         Extend the public suffix tests to include cases used by the
1236         Public Domain 'Public Suffix List'.
1237
1238         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
1239         (TestWebKitAPI::TEST):
1240
1241 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
1242
1243         [XCode] webkit-patch should run sort-Xcode-project-file
1244         https://bugs.webkit.org/show_bug.cgi?id=174036
1245         <rdar://problem/33732709>
1246
1247         Reviewed by Simon Fraser.
1248
1249         * Scripts/webkitpy/common/config/ports.py:
1250         * Scripts/webkitpy/tool/commands/download.py:
1251         * Scripts/webkitpy/tool/commands/download_unittest.py:
1252         * Scripts/webkitpy/tool/commands/upload.py:
1253         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1254         * Scripts/webkitpy/tool/steps/__init__.py:
1255         * Scripts/webkitpy/tool/steps/options.py:
1256         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1257
1258 2017-08-07  Devin Rousso  <drousso@apple.com>
1259
1260         Web Inspector: Preview Canvas path when viewing a recording
1261         https://bugs.webkit.org/show_bug.cgi?id=174967
1262
1263         Reviewed by Brian Burg.
1264
1265         * DumpRenderTree/TestOptions.h:
1266         * DumpRenderTree/TestOptions.mm:
1267         (TestOptions::TestOptions):
1268         * DumpRenderTree/mac/DumpRenderTree.mm:
1269         (setWebPreferencesForTestOptions):
1270         * WebKitTestRunner/TestController.cpp:
1271         (WTR::TestController::resetPreferencesToConsistentValues):
1272         (WTR::updateTestOptionsFromTestHeader):
1273         * WebKitTestRunner/TestOptions.h:
1274         (WTR::TestOptions::hasSameInitializationOptions const):
1275         Add plumbing for new InspectorAdditions runtime flag.
1276
1277 2017-08-07  obinna obike  <oobike@apple.com>
1278
1279         Sorted EWS Queues on Patch page
1280         https://bugs.webkit.org/show_bug.cgi?id=173667
1281
1282         Reviewed by Aakash Jain.
1283
1284         * QueueStatusServer/handlers/patch.py:
1285         (Patch.get): Sorted queue_status.
1286         * QueueStatusServer/templates/patch.html:
1287         Changed queue_status.items to queue_status because it's a list.
1288
1289 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1290
1291         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
1292         https://bugs.webkit.org/show_bug.cgi?id=175286
1293
1294         Reviewed by Myles C. Maxfield.
1295
1296         * Scripts/webkitpy/style/checkers/cpp.py:
1297         (check_braces):
1298         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1299         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
1300         (WebKitStyleTest.test_braces):
1301         (WebKitStyleTest.test_braces.NS_OPTIONS):
1302
1303 2017-08-07  Brian Burg  <bburg@apple.com>
1304
1305         Remove CANVAS_PATH compilation guard
1306         https://bugs.webkit.org/show_bug.cgi?id=175207
1307
1308         Reviewed by Sam Weinig.
1309
1310         * Scripts/webkitperl/FeatureList.pm:
1311         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1312
1313 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
1314
1315         [Win] Use Visual Studio 2017 if installed.
1316         https://bugs.webkit.org/show_bug.cgi?id=175188
1317
1318         Reviewed by Sam Weinig.
1319
1320         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
1321
1322         * Scripts/webkitdirs.pm:
1323         (visualStudioInstallDir):
1324         (msBuildInstallDir):
1325
1326 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1327
1328         [GTK][WPE] Add API to provide browser information required by automation
1329         https://bugs.webkit.org/show_bug.cgi?id=175130
1330
1331         Reviewed by Michael Catanzaro.
1332
1333         * MiniBrowser/gtk/main.c:
1334         (automationStartedCallback): Set browser information when a new automation session is started.
1335         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1336         (testAutomationSessionApplicationInfo):
1337         (beforeAll):
1338
1339 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
1340
1341         Unreviewed, rolling out r220295.
1342
1343         This change introduced 4 errors in webkitpy tests.
1344
1345         Reverted changeset:
1346
1347         "[XCode] webkit-patch should run sort-Xcode-project-file"
1348         https://bugs.webkit.org/show_bug.cgi?id=174036
1349         http://trac.webkit.org/changeset/220295
1350
1351 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1352
1353         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
1354
1355         Unreviewed test gardening.
1356
1357         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1358         (TestWebKitAPI::TEST):
1359
1360 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
1361
1362         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
1363         https://bugs.webkit.org/show_bug.cgi?id=175083
1364
1365         Reviewed by Oliver Hunt.
1366         
1367         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
1368         to wait for VM destructions to finish before running the next test. This makes it easier to 
1369         understand leaks results from workers tests, and leads to fewer reported leaks.
1370
1371         * DumpRenderTree/mac/DumpRenderTree.mm:
1372         (runTest):
1373
1374 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1375
1376         check-webkit-style: fix path-specific rules for WebKit2 rename
1377         https://bugs.webkit.org/show_bug.cgi?id=175182
1378
1379         Reviewed by David Kilzer.
1380
1381         * Scripts/webkitpy/style/checker.py:
1382
1383 2017-08-04  Youenn Fablet  <youenn@apple.com>
1384
1385         [Cache API] Add Cache and CacheStorage IDL definitions
1386         https://bugs.webkit.org/show_bug.cgi?id=175201
1387
1388         Reviewed by Brady Eidson.
1389
1390         * DumpRenderTree/mac/DumpRenderTree.mm:
1391         (enableExperimentalFeatures):
1392         (resetWebPreferencesToConsistentValues):
1393         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1394         (WTR::InjectedBundle::beginTesting):
1395         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1396         (WTR::TestRunner::setCacheAPIEnabled):
1397         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1398
1399 2017-08-04  John Wilander  <wilander@apple.com>
1400
1401         Resource Load Statistics: Report user interaction immediately, but only when needed
1402         https://bugs.webkit.org/show_bug.cgi?id=175090
1403         <rdar://problem/33685546>
1404
1405         Reviewed by Chris Dumez.
1406
1407         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1408         (WTR::InjectedBundle::beginTesting):
1409             Now calls WebCore::ResourceLoadObserver::clearState().
1410
1411 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1412
1413         Add an API test for r220286
1414         https://bugs.webkit.org/show_bug.cgi?id=175206
1415
1416         Reviewed by Simon Fraser.
1417
1418         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1419         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1420         (createAnimatedResizeWebView):
1421         (TEST):
1422         Add a test to ensure that we don't call
1423         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1424         animated resize.
1425
1426 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1427
1428         [XCode] webkit-patch should run sort-Xcode-project-file
1429         https://bugs.webkit.org/show_bug.cgi?id=174036
1430
1431         Reviewed by Simon Fraser.
1432
1433         * Scripts/webkitpy/common/config/ports.py:
1434         * Scripts/webkitpy/tool/commands/download.py:
1435         * Scripts/webkitpy/tool/commands/upload.py:
1436         * Scripts/webkitpy/tool/steps/__init__.py:
1437         * Scripts/webkitpy/tool/steps/options.py:
1438         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1439
1440 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1441
1442         REGRESSION(r219857): run-benchmark --allplans broken
1443         https://bugs.webkit.org/show_bug.cgi?id=175186
1444
1445         Reviewed by Saam Barati.
1446
1447         r219857 forgot to update also the calls to BenchmarkRunner() that
1448         is done when the script is run with --allplans.
1449
1450         To fix this (and avoid future issues like this), let's factorize
1451         the calls to the benchhmark runner in a run_benchmark_plan()
1452         function.
1453
1454         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1455         (run_benchmark_plan):
1456         (start):
1457
1458 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1459
1460         Dashboard bubbles sometimes show failure count instead of crash count
1461         https://bugs.webkit.org/show_bug.cgi?id=175157
1462         <rdar://problem/33709009>
1463
1464         Reviewed by Alexey Proskuryakov.
1465
1466         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1467         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1468
1469 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1470
1471         Add tests for NeverDestroyed
1472         https://bugs.webkit.org/show_bug.cgi?id=175146
1473
1474         Reviewed by Darin Adler.
1475
1476         * CMakeLists.txt:
1477         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1478         New files and sort.
1479
1480         * TestWebKitAPI/Tests/WTF/Logger.h:
1481         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1482         (TestWebKitAPI::log):
1483         (TestWebKitAPI::takeLogStr):
1484         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1485         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1486         (TestWebKitAPI::log): Deleted.
1487         (TestWebKitAPI::takeLogStr): Deleted.
1488         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1489
1490         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1491         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1492         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1493         (TestWebKitAPI::LifecycleLogger::operator=):
1494         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1495         (TestWebKitAPI::LifecycleLogger::setName):
1496         (TestWebKitAPI::TEST):
1497         Add a class that logs construction / assignment / modifications.
1498
1499         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1500         (TestWebKitAPI::TEST):
1501         (TestWebKitAPI::list):
1502         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1503
1504 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1505
1506         minification logic is not implemented for ios builds
1507         <rdar://problem/33726561>
1508
1509         Reviewed by Dean Johnson
1510
1511         * BuildSlaveSupport/built-product-archive:
1512         (minifyDirectory): refactor minifySource -> minifyDirectory
1513         (archiveBuiltProduct): add ios minification logic
1514         (minifySource): Deleted.
1515
1516 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1517
1518         Unreviewed, rolling out r220271.
1519
1520         Rolling out due to Layout Test failing on iOS Simulator.
1521
1522         Reverted changeset:
1523
1524         "Remove STREAMS_API compilation guard"
1525         https://bugs.webkit.org/show_bug.cgi?id=175165
1526         http://trac.webkit.org/changeset/220271
1527
1528 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1529
1530         Unreviewed, rolling out r220268.
1531
1532         This change caused assertion failures on macOS and iOS Debug
1533         WK2.
1534
1535         Reverted changeset:
1536
1537         "Resource Load Statistics: Report user interaction
1538         immediately, but only when needed"
1539         https://bugs.webkit.org/show_bug.cgi?id=175090
1540         http://trac.webkit.org/changeset/220268
1541
1542 2017-08-04  Youenn Fablet  <youenn@apple.com>
1543
1544         Remove STREAMS_API compilation guard
1545         https://bugs.webkit.org/show_bug.cgi?id=175165
1546
1547         Reviewed by Darin Adler.
1548
1549         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1550
1551 2017-08-04  John Wilander  <wilander@apple.com>
1552
1553         Resource Load Statistics: Report user interaction immediately, but only when needed
1554         https://bugs.webkit.org/show_bug.cgi?id=175090
1555         <rdar://problem/33685546>
1556
1557         Reviewed by Chris Dumez.
1558
1559         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1560         (WTR::InjectedBundle::beginTesting):
1561             Now calls WebCore::ResourceLoadObserver::clearState().
1562
1563 2017-08-03  Brian Burg  <bburg@apple.com>
1564
1565         Remove ENABLE(WEB_SOCKET) guards
1566         https://bugs.webkit.org/show_bug.cgi?id=167044
1567
1568         Reviewed by Joseph Pecoraro.
1569
1570         * Scripts/webkitperl/FeatureList.pm:
1571         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1572
1573 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1574
1575         REGRESSION(r219850): run-benchmark script broken on Linux
1576         https://bugs.webkit.org/show_bug.cgi?id=175126
1577
1578         Reviewed by Stephanie Lewis.
1579
1580         The run-benchmark script dynamically generates the list of supported
1581         browsers and platforms (currently Linux and OSX) by loading all
1582         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1583         and getting the browser_name and platform variables from the
1584         classes defined there.
1585
1586         This means that this classes should not raise an exception when
1587         loaded on other platforms or otherwise they will broke the whole
1588         script. Its fine if they raise an exception when executing any of
1589         the methods they implement, but not when just loading/importing
1590         the class.
1591
1592         Move the argument variable definitions that call on the platform
1593         specific OSXBrowserDriver._screen_size() function from beeing
1594         variables that are evaluated when loading the file, to be functions
1595         that are only evaluated when the actual functionality needs to be
1596         executed.
1597
1598         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1599         (OSXChromeDriver.launch_url):
1600         (OSXChromeCanaryDriver.launch_url):
1601         (create_args):
1602         (create_chrome_options):
1603         (create_window_size_arg):
1604         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1605         (OSXFirefoxDriver.launch_url):
1606         (OSXFirefoxNightlyDriver.launch_url):
1607         (OSXFirefoxNightlyDriver.launch_driver):
1608         (create_args):
1609
1610 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1611
1612         [PAL] Move spi/cf directory into PAL
1613         https://bugs.webkit.org/show_bug.cgi?id=175057
1614
1615         Reviewed by Antti Koivisto.
1616
1617         * Scripts/webkitpy/style/checker.py:
1618         * Scripts/webkitpy/style/checker_unittest.py:
1619         (GlobalVariablesTest.test_path_rules_specifier):
1620
1621         Ignore "readability/naming/underscores" style errors for sources
1622         under the WebCore/PAL/pal/spi directory.
1623
1624         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1625
1626 2017-08-03  Youenn Fablet  <youenn@apple.com>
1627
1628         Remove FETCH_API compilation guard
1629         https://bugs.webkit.org/show_bug.cgi?id=175154
1630
1631         Reviewed by Chris Dumez.
1632
1633         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1634
1635 2017-08-03  Lucas Forschler  <lforschler@apple.com>
1636
1637         Enable archive minification on iOS builds
1638         https://bugs.webkit.org/show_bug.cgi?id=174718
1639         
1640         Reviewed by Aakash Jain.
1641
1642         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1643         (BuildFactory.__init__):
1644
1645 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1646
1647         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
1648         https://bugs.webkit.org/show_bug.cgi?id=175140
1649
1650         Reviewed by Alexey Proskuryakov.
1651
1652         We are having lately issues with JSC tests causing problems on
1653         the GTK+ and WPE bots due to the high amount of memory some tests
1654         need to run.
1655
1656         The best thing we can do now is to workaround this by disabling
1657         all the tests marked as memoryLimited on the GTK and WPE bots.
1658         We may revise this on the future.
1659
1660         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1661         (RunJavaScriptCoreTests.start):
1662
1663 2017-08-03  Brady Eidson  <beidson@apple.com>
1664
1665         Add SW IDLs and stub out basic functionality.
1666         https://bugs.webkit.org/show_bug.cgi?id=175115
1667
1668         Reviewed by Chris Dumez.
1669
1670         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1671
1672         * Scripts/webkitpy/bindings/main.py:
1673
1674 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
1675
1676         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
1677         https://bugs.webkit.org/show_bug.cgi?id=159510
1678
1679         Reviewed by Daniel Bates.
1680
1681         Allow any https certificate when running tests.
1682
1683         * DumpRenderTree/win/DumpRenderTree.cpp:
1684         (runTest):
1685
1686 2017-08-02  Youenn Fablet  <youenn@apple.com>
1687
1688         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
1689         https://bugs.webkit.org/show_bug.cgi?id=175089
1690
1691         Reviewed by Chris Dumez.
1692
1693         * DumpRenderTree/TestOptions.mm:
1694         (TestOptions::TestOptions): Using absolutePath if available.
1695         * DumpRenderTree/mac/DumpRenderTree.mm:
1696         (computeTestURL): Removing http/tests/ specific URL computation.
1697         * Scripts/webkitpy/port/driver.py:
1698         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
1699
1700 2017-08-02  Lucas Forschler  <lforschler@apple.com>
1701
1702         download-built-product should allow for a proxy option
1703         https://bugs.webkit.org/show_bug.cgi?id=174875
1704
1705         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
1706
1707         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1708         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
1709         
1710
1711 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1712
1713         check-webkit-style: deleting lines in a file runs the linter on the whole file
1714         https://bugs.webkit.org/show_bug.cgi?id=175078
1715
1716         Reviewed by David Kilzer.
1717
1718         Deleting lines in a file should not cause linter errors to be blamed on the patch.
1719         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
1720
1721         * Scripts/webkitpy/style/checkers/test_expectations.py:
1722         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
1723         * Scripts/webkitpy/style/main_unittest.py:
1724         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
1725         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
1726         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
1727
1728 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1729
1730         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
1731         https://bugs.webkit.org/show_bug.cgi?id=175075
1732
1733         Reviewed by David Kilzer.
1734
1735         We have no way of handling text files with illegal unicode characters. Allow the callers of
1736         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
1737         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
1738
1739         * Scripts/webkitpy/common/system/filesystem.py:
1740         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
1741         (FileSystem.write_text_file): Ditto.
1742         * Scripts/webkitpy/common/system/filesystem_mock.py:
1743         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
1744         (MockFileSystem.write_text_file): Ditto.
1745         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1746         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
1747         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
1748
1749 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
1750
1751         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
1752         https://bugs.webkit.org/show_bug.cgi?id=175072
1753
1754         Reviewed by Alexey Proskuryakov.
1755
1756         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1757         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
1758
1759 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1760
1761         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
1762         https://bugs.webkit.org/show_bug.cgi?id=175019
1763
1764         Reviewed by Darin Adler.
1765
1766         * TestWebKitAPI/CMakeLists.txt:
1767
1768 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1769
1770         Enabling uploading archives to S3
1771         https://bugs.webkit.org/show_bug.cgi?id=174198
1772
1773         Unreviewed unit test fix after r219235.
1774
1775         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1776
1777 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1778
1779         Fix JSCOnly ARM buildbots after r220047
1780         https://bugs.webkit.org/show_bug.cgi?id=174993
1781
1782         Unreviewed fix after r220087.
1783
1784         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1785         (BuildAndRemoteJSCTestsFactory.__init__):
1786
1787 2017-08-01  Chris Dumez  <cdumez@apple.com>
1788
1789         Add initial support for navigator.sendBeacon
1790         https://bugs.webkit.org/show_bug.cgi?id=175007
1791         <rdar://problem/33547728>
1792
1793         Reviewed by Sam Weinig.
1794
1795         Enable the Beacon API at runtime in the context of layout tests since the
1796         feature is currently disabled by default.
1797
1798         * DumpRenderTree/mac/DumpRenderTree.mm:
1799         (enableExperimentalFeatures):
1800         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1801         (WTR::InjectedBundle::beginTesting):
1802         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1803         (WTR::TestRunner::setModernMediaControlsEnabled):
1804         (WTR::TestRunner::setBeaconAPIEnabled):
1805         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1806
1807 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
1808
1809         Update Bot Watcher's Dashboard for Buildbot 0.9
1810         https://bugs.webkit.org/show_bug.cgi?id=174777
1811
1812         Reviewed by Daniel Bates.
1813
1814         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1815         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
1816         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
1817         in a dictionary.
1818         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
1819         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
1820         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1821         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
1822         (parseRevisionProperty): Ditto.
1823         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
1824         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
1825         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
1826         have changed in Buildbot 0.9.
1827         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
1828         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
1829         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
1830         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
1831         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
1832         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
1833         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
1834         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
1835         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
1836         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
1837         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1838         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
1839         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
1840         (BuildbotQueue.prototype.get overviewURL): Ditto.
1841         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
1842         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
1843         Buildbot 0.8 or 0.9.
1844         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
1845         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
1846         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
1847         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
1848         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
1849         Therefore we are fetching information for fixed number of build. 
1850         Also iterating the loop incrementally since the build data is already reverse sorted.
1851         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1852         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
1853         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
1854         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1855         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
1856
1857 2017-08-01  Devin Rousso  <drousso@apple.com>
1858
1859         Web Inspector: simplify WebInspector with WI
1860         https://bugs.webkit.org/show_bug.cgi?id=175058
1861
1862         Reviewed by Joseph Pecoraro.
1863
1864         * Scripts/check-inspector-strings:
1865         (extract_ui_strings):
1866         * Scripts/extract-localizable-js-strings:
1867
1868 2017-08-01  Youenn Fablet  <youenn@apple.com>
1869
1870         Layout tests with 'https' suffix should be run over HTTPS
1871         https://bugs.webkit.org/show_bug.cgi?id=174992
1872
1873         Reviewed by Chris Dumez.
1874
1875         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
1876         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
1877         Covered by corresponding unit tests.
1878
1879         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1880         (run_server):
1881         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1882         (base_http_url):
1883         (base_https_url):
1884         (base_url): Deleted.
1885         * Scripts/webkitpy/port/base.py:
1886         (Port.to.web_platform_test_server_base_http_url):
1887         (Port.to):
1888         (Port.to.web_platform_test_server_base_https_url):
1889         (Port.to.web_platform_test_server_base_url): Deleted.
1890         * Scripts/webkitpy/port/driver.py:
1891         (Driver.__init__):
1892         (Driver.wpt_test_path_to_uri):
1893         (Driver):
1894         (Driver.http_test_path_to_uri):
1895         (Driver.test_to_uri):
1896         (Driver.uri_to_test):
1897         * Scripts/webkitpy/port/driver_unittest.py:
1898         (DriverTest.test_test_to_uri):
1899         (DriverTest.test_uri_to_test):
1900
1901 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1902
1903         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
1904         https://bugs.webkit.org/show_bug.cgi?id=173998
1905
1906         Reviewed by Darin Adler.
1907
1908         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
1909         detect mistakes in backward compatibility in the future when we change it.
1910
1911         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
1912         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
1913         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
1914         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
1915         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
1916         internal key data slot.
1917
1918         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1919         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
1920         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
1921         (getNextMessage):
1922         (TEST):
1923         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
1924         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
1925         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
1926         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
1927         These are the pre-baked databases.
1928         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
1929         This is the actual test that do all the reads and comparisons.
1930         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
1931         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
1932         IndexedDB new stuffs. Then it can be used to bake the database again.
1933
1934 2017-08-01  Brady Eidson  <beidson@apple.com>
1935
1936         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
1937         https://bugs.webkit.org/show_bug.cgi?id=175030
1938
1939         Reviewed by Andy Estes.
1940
1941         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1942         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
1943
1944 2017-08-01  Brady Eidson  <beidson@apple.com>
1945
1946         Part 2 of: Rename DatabaseProcess to StorageProcess.
1947         https://bugs.webkit.org/show_bug.cgi?id=174880
1948
1949         Reviewed by Andy Estes.
1950
1951         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1952         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1953         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1954         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1955         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1956         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1957         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1958         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1959
1960 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
1961
1962         Fix JSCOnly ARM buildbots after r220047
1963         https://bugs.webkit.org/show_bug.cgi?id=174993
1964
1965         Reviewed by Saam Barati.
1966
1967         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1968         (BuildAndRemoteJSCTestsFactory.__init__):
1969
1970 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1971
1972         [WTF] Introduce Private Symbols
1973         https://bugs.webkit.org/show_bug.cgi?id=174935
1974
1975         Reviewed by Darin Adler.
1976
1977         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1978         (TestWebKitAPI::TEST):
1979
1980 2017-07-30  Darin Adler  <darin@apple.com>
1981
1982         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
1983         https://bugs.webkit.org/show_bug.cgi?id=130653
1984
1985         Reviewed by Antti Koivisto.
1986
1987         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1988         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
1989         when calling frameDidChangeLocation.
1990         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
1991         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
1992         thus causing mysterious failures of a couple of tests. There are two remaining issues:
1993         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
1994         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
1995         same logic flaw that causes "top loading frame" to get set to one of the subframes in
1996         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
1997         loading, subframe starts loading. It would be good to clean that up some day, but for now
1998         this patch makes the two work identically rather than changing both.
1999         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
2000
2001 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2002
2003         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
2004         https://bugs.webkit.org/show_bug.cgi?id=174963
2005
2006         Reviewed by Darin Adler.
2007
2008         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
2009         RetainPtr<>. This patch changes them to all use auto.
2010
2011         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2012         (TestWebKitAPI::TEST):
2013
2014 2017-07-30  Brady Eidson  <beidson@apple.com>
2015
2016         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
2017         https://bugs.webkit.org/show_bug.cgi?id=174958
2018
2019         Reviewed by Darin Adler.
2020
2021         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2022         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
2023         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
2024         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
2025         (runUntilTasksInFlight):
2026         (TEST):
2027
2028 2017-07-28  Commit Queue  <commit-queue@webkit.org>
2029
2030         Unreviewed, rolling out r219990.
2031         https://bugs.webkit.org/show_bug.cgi?id=174961
2032
2033         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
2034         estes on #webkit).
2035
2036         Reverted changeset:
2037
2038         "Part 2 of: Rename DatabaseProcess to StorageProcess."
2039         https://bugs.webkit.org/show_bug.cgi?id=174880
2040         http://trac.webkit.org/changeset/219990
2041
2042 2017-07-28  Brady Eidson  <beidson@apple.com>
2043
2044         API tests that use URLSchemeHandler are failing.
2045         https://bugs.webkit.org/show_bug.cgi?id=174950
2046
2047         Reviewed by Alex Christensen.
2048
2049         Fix the NoMIMEType test to be correct.
2050
2051         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2052         (-[SchemeHandler initWithData:mimeType:]):
2053         (-[SchemeHandler webView:startURLSchemeTask:]):
2054         (TEST):
2055
2056 2017-07-28  Daniel Bates  <dabates@apple.com>
2057
2058         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
2059         https://bugs.webkit.org/show_bug.cgi?id=174876
2060
2061         Reviewed by Alex Christensen.
2062
2063         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
2064         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
2065         they provide a more direct way to test the platform abstraction.
2066
2067         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
2068
2069         * Scripts/prepare-ChangeLog:
2070         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
2071         of the current working directory.
2072
2073 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
2074
2075         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2076         https://bugs.webkit.org/show_bug.cgi?id=174930
2077
2078         Unreviewed test fix.
2079
2080         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
2081
2082         * Scripts/prepare-ChangeLog:
2083         (get_function_line_ranges_for_cpp):
2084
2085 2017-07-28  JF Bastien  <jfbastien@apple.com>
2086
2087         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2088         https://bugs.webkit.org/show_bug.cgi?id=174930
2089
2090         Reviewed by Daniel Bates.
2091
2092         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
2093         here also teach it about const and volatile overloads. I didn't do
2094         reference and rvalue reference overloads because we don't really
2095         use them, and the current parser throws away those characters and
2096         it doesn't seem worth making it more complex.
2097
2098         * Scripts/prepare-ChangeLog:
2099         (get_function_line_ranges_for_cpp):
2100         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2101         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2102         (Foo::Arrow::arrow):
2103         (Foo::Arrow::otherArrow):
2104         (Foo::Arrow::otherArrow const):
2105         (Foo::Arrow::otherArrow volatile):
2106         (Foo::Arrow::otherArrow const volatile):
2107
2108 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
2109
2110         [GTK] Building with ENABLE_VIDEO=OFF fails
2111         https://bugs.webkit.org/show_bug.cgi?id=174940
2112
2113         Reviewed by Alex Christensen.
2114
2115         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
2116         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
2117
2118         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2119         (methodCallCallback): Add missing USE(GSTREAMER) guard.
2120
2121 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
2122
2123         [WPE] Implement EventSenderProxy in WTR
2124         https://bugs.webkit.org/show_bug.cgi?id=173419
2125
2126         Reviewed by Žan Doberšek.
2127
2128         Add the implementation of EventSenderProxy to the WTR. This
2129         allows us to extend the coverage of the test suite in WKWPE.
2130
2131         * WebKitTestRunner/EventSenderProxy.h:
2132         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
2133         libxkbcommon needed to deal with key events.
2134         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2135         (WTR::EventSenderProxy::EventSenderProxy):
2136         (WTR::senderButtonToWPEButton):
2137         (WTR::EventSenderProxy::mouseDown):
2138         (WTR::EventSenderProxy::mouseUp):
2139         (WTR::EventSenderProxy::mouseMoveTo):
2140         (WTR::EventSenderProxy::mouseScrollBy):
2141         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2142         (WTR::EventSenderProxy::leapForward):
2143         (WTR::wkEventModifiersToWPE):
2144         (WTR::getXKBKeySymForKeyRef):
2145         (WTR::EventSenderProxy::keyDown):
2146         (WTR::EventSenderProxy::addTouchPoint):
2147         (WTR::EventSenderProxy::updateTouchPoint):
2148         (WTR::EventSenderProxy::setTouchModifier):
2149         (WTR::EventSenderProxy::setTouchPointRadius):
2150         (WTR::EventSenderProxy::getUpdatedTouchEvents):
2151         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
2152         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2153         (WTR::EventSenderProxy::touchStart):
2154         (WTR::EventSenderProxy::touchMove):
2155         (WTR::EventSenderProxy::touchEnd):
2156         (WTR::EventSenderProxy::touchCancel):
2157         (WTR::EventSenderProxy::clearTouchPoints):
2158         (WTR::EventSenderProxy::releaseTouchPoint):
2159         (WTR::EventSenderProxy::cancelTouchPoint):
2160
2161 2017-07-27  Brady Eidson  <beidson@apple.com>
2162
2163         Part 2 of: Rename DatabaseProcess to StorageProcess.
2164         https://bugs.webkit.org/show_bug.cgi?id=174880
2165
2166         Reviewed by Andy Estes.
2167
2168         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2169         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2170         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2171         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2172         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2173         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2174         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2175         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2176
2177 2017-07-26  Mark Lam  <mark.lam@apple.com>
2178
2179         Add ability to only run specific tests in run-javascriptcore-tests.
2180         https://bugs.webkit.org/show_bug.cgi?id=174884
2181
2182         Reviewed by Saam Barati.
2183
2184         For example, if we only want to run testapi, we can do so as follows:
2185             $ run-javascriptcore-tests --testapi
2186
2187         Previously, specifying --testapi effectively does nothing because we run all tests
2188         by default.  Only --no-testapi had the effect of disabling the test set.  This
2189         old behavior for --testapi is not very useful or meaningful.  We're now changing
2190         it to mean that we will only run that test.
2191
2192         With this change, we can also run more than one set of tests.  For example, if we
2193         only want to run testmasm and testair, we can do so as follows:
2194             $ run-javascriptcore-tests --testmasm --testair
2195
2196         By default, if no specific test option is specified, run-javascriptcore-tests will
2197         run all tests.
2198
2199         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
2200         the mozilla tests (--mozilla-tests) even though both are run via the lower level
2201         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
2202         the other set will not run.  For example, the following only runs the mozilla tests:
2203             $ run-javascriptcore-tests --mozilla-tests
2204
2205         Note also that --jit-stress-tests is not for choosing a different set of tests.
2206         Instead, it is used for determining whether we run JIT'ed test configurations
2207         on the jsc stress tests and mozilla tests.  As a result, specifying
2208         --jit-stress-tests will not omit other tests.  For example, the following still
2209         runs all tests:
2210             $ run-javascriptcore-tests --jit-stress-tests
2211
2212         * Scripts/run-javascriptcore-tests:
2213         (defaultStringForTestState):
2214         (enableTestOrNot):
2215         (runJSCStressTests):
2216
2217 2017-07-26  Mark Lam  <mark.lam@apple.com>
2218
2219         Make run-javascriptcore-test run testair, testb3, and testmasm.
2220         https://bugs.webkit.org/show_bug.cgi?id=174837
2221         <rdar://problem/33522927>
2222
2223         Reviewed by Saam Barati and Filip Pizlo.
2224
2225         1. Refactors code for running testapi so that we can use it to run other tests.
2226         2. Added running of testmasm, testair, testb3.
2227
2228         Note: the existing testapi invocation code does not support remote invocation of
2229         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
2230         and testb3 also do not support remote invocation.  If we wish to add remote
2231         invocation support, we should do that in a separate patch.
2232
2233         * Scripts/run-javascriptcore-tests:
2234         (testPath):
2235         (runTest):
2236         (testapiPath): Deleted.
2237
2238 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2239
2240         Remove duplicate code from Buildbot.js in dashboard
2241         https://bugs.webkit.org/show_bug.cgi?id=174870
2242
2243         Reviewed by Daniel Bates.
2244
2245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2246         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
2247         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
2248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
2249         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
2250
2251 2017-07-26  Brady Eidson  <beidson@apple.com>
2252
2253         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
2254         https://bugs.webkit.org/show_bug.cgi?id=174851
2255
2256         Reviewed by Chris Dumez.
2257
2258         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2259         (TEST):
2260
2261 2017-07-26  Brian Burg  <bburg@apple.com>
2262
2263         Remove WEB_TIMING feature flag
2264         https://bugs.webkit.org/show_bug.cgi?id=174795
2265
2266         Reviewed by Alex Christensen.
2267
2268         * Scripts/webkitperl/FeatureList.pm:
2269         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2270
2271 2017-07-26  Chris Dumez  <cdumez@apple.com>
2272
2273         Pressing the Escape key should not be a valid user gesture to enter fullscreen
2274         https://bugs.webkit.org/show_bug.cgi?id=174864
2275         <rdar://problem/33009088>
2276
2277         Reviewed by Geoffrey Garen.
2278
2279         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
2280         WKTR.
2281
2282         * DumpRenderTree/mac/EventSendingController.mm:
2283         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2284
2285 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2286
2287         Unreviewed, added Romain Bellessort to contributors.json.
2288
2289         * Scripts/webkitpy/common/config/contributors.json:
2290
2291 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
2292
2293         [WPE] WebGL2 support
2294         https://bugs.webkit.org/show_bug.cgi?id=174249
2295
2296         Reviewed by Alex Christensen.
2297
2298         * Scripts/webkitperl/FeatureList.pm:
2299         Enable WebGL2 for WPE when building through build-webkit.
2300
2301 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2302
2303         Unreviewed. Fix GTK distcheck.
2304
2305         * gtk/make-dist.py:
2306         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
2307
2308 2017-07-25  Brady Eidson  <beidson@apple.com>
2309
2310         ResourceLoadStatistics grandfathering happens much too often.
2311         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
2312
2313         Reviewed by Chris Dumez.
2314
2315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2316         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
2317         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
2318         (TEST):
2319
2320 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2321
2322         Fix autoinstaller failing on autoinstall_everything
2323         https://bugs.webkit.org/show_bug.cgi?id=174830
2324
2325         Reviewed by Joseph Pecoraro.
2326
2327         * Scripts/webkitpy/thirdparty/__init__.py:
2328         (AutoinstallImportHook.find_module):
2329         (AutoinstallImportHook.install_chromedriver):
2330         (AutoinstallImportHook.install_geckodriver):
2331         (AutoinstallImportHook._install_chromedriver): Deleted.
2332         (AutoinstallImportHook._install_geckodriver): Deleted.
2333
2334 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
2335
2336         Replace --runtime with something for both ios-simulator and ios-device
2337         https://bugs.webkit.org/show_bug.cgi?id=173775
2338         <rdar://problem/32952164>
2339
2340         Reviewed by Aakash Jain.
2341
2342         Add --version flag for both iOS simulator and iOS device.
2343
2344         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2345         (parse_args): Add --version flag and move --no-install.
2346         * Scripts/webkitpy/port/factory.py:
2347         (platform_options): Move --no-intall to run_webkit_tests.py.
2348         * Scripts/webkitpy/port/ios.py:
2349         (IOSPort):
2350         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
2351         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
2352         * Scripts/webkitpy/port/ios_device.py:
2353         (IOSDevicePort.ios_version): Consult --version flag before checking connected
2354         devices for iOS version.
2355         * Scripts/webkitpy/port/ios_device_unittest.py:
2356         (IOSDeviceTest.make_port): Set --version option so that we can generate test
2357         expectation paths without devices connected.
2358         (IOSDeviceTest.test_additional_platform_directory): Deleted.
2359         (IOSDeviceTest.test_baseline_searchpath): Deleted.
2360         (IOSDeviceTest.test_expectations_ordering): Deleted.
2361         * Scripts/webkitpy/port/ios_simulator.py:
2362         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
2363         flag to specify a runtime.
2364         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
2365         flag and then use the default runtime.
2366
2367 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2368
2369         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
2370         https://bugs.webkit.org/show_bug.cgi?id=174815
2371
2372         Reviewed by Carlos Alberto Lopez Perez.
2373
2374         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
2375         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
2376         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
2377         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
2378         think), probably because of a newer CMake version.
2379
2380         * CMakeLists.txt:
2381         * TestWebKitAPI/CMakeLists.txt:
2382         * TestWebKitAPI/PlatformGTK.cmake:
2383
2384 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2385
2386         Fix BenchmarkRunner to only import selenium when needed
2387         https://bugs.webkit.org/show_bug.cgi?id=174808
2388
2389         Reviewed by Stephanie Lewis.
2390
2391         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2392         (LinuxChromeDriver.launch_driver):
2393         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2394         (LinuxFirefoxDriver.launch_driver):
2395         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2396         (OSXChromeDriver.launch_driver):
2397         (OSXChromeCanaryDriver.launch_driver):
2398         (create_chrome_options):
2399         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2400         (OSXFirefoxDriver.launch_driver):
2401         (OSXFirefoxNightlyDriver.launch_driver):
2402         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2403         (OSXSafariDriver.launch_driver):
2404         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2405         (WebDriverBenchmarkRunner._run_one_test):
2406
2407 2017-07-23  Darin Adler  <darin@apple.com>
2408
2409         More NeverDestroyed and related cleanup
2410         https://bugs.webkit.org/show_bug.cgi?id=174745
2411
2412         Reviewed by Alex Christensen.
2413
2414         * DumpRenderTree/JavaScriptThreading.cpp:
2415         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2416         DEPRECATED_DEFINE_STATIC_LOCAL.
2417         (javaScriptThreads): Ditto.
2418
2419 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2420
2421         Subclass Benchmark Runner script for WebDriver support
2422         https://bugs.webkit.org/show_bug.cgi?id=174390
2423
2424         Reviewed by Dewei Zhu, Stephanie Lewis.
2425
2426         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2427
2428         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2429         (BenchmarkBuilder.__init__):
2430         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2431         (BenchmarkRunner.__init__):
2432         (BenchmarkRunner._find_plan_file):
2433         (BenchmarkRunner._run_one_test.and):
2434         (BenchmarkRunner.execute):
2435         (BenchmarkRunner._get_result): Deleted.
2436         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2437         (parse_args):
2438         (start):
2439         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2440         (WebDriverBenchmarkRunner):
2441         (WebDriverBenchmarkRunner._get_result):
2442         (WebDriverBenchmarkRunner._run_one_test):
2443         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2444         (WebServerBenchmarkRunner):
2445         (WebServerBenchmarkRunner.__init__):
2446         (WebServerBenchmarkRunner._get_result):
2447         (WebServerBenchmarkRunner._run_one_test):
2448
2449 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2450
2451         Add BenchmarkRunner patches with WebDriver support for each testing plan
2452         https://bugs.webkit.org/show_bug.cgi?id=174443
2453
2454         Reviewed by Dewei Zhu, Stephanie Lewis.
2455
2456         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2457         (BenchmarkBuilder.__enter__):
2458         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2459         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2460         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2461         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2462         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2463         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2464         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2465         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2466         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2467         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2468         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2469         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2470         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2471         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2472         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2473         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2474         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2475         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2476         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2477         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2478         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2479         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2480         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2481         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2482         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2483         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2484         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2485         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2486         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2487         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2488         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2489         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2490         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2491
2492 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2493
2494         Add functions to autoinstaller needed for Benchmark Runner script
2495         https://bugs.webkit.org/show_bug.cgi?id=174331
2496
2497         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2498
2499         Adds autoinstaller functions to install selenium and webdriver binaries
2500         which will be used by the browser driver part of Benchmark Runner.
2501
2502         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2503         (BrowserDriver.restore_env):
2504         (BrowserDriver):
2505         (BrowserDriver.get_webdriver_binary_path):
2506         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2507         (LinuxChromeDriver.launch_driver):
2508         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2509         (LinuxFirefoxDriver.launch_driver):
2510         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2511         (OSXChromeDriver.launch_driver):
2512         (OSXChromeCanaryDriver.launch_driver):
2513         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2514         (OSXFirefoxDriver.launch_driver):
2515         (OSXFirefoxNightlyDriver.launch_driver):
2516         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2517         * Scripts/webkitpy/benchmark_runner/utils.py:
2518         (get_driver_binary_path):
2519         * Scripts/webkitpy/common/system/autoinstall.py:
2520         (AutoInstaller._unzip):
2521         * Scripts/webkitpy/thirdparty/__init__.py:
2522         (AutoinstallImportHook.find_module):
2523         (AutoinstallImportHook._install_selenium):
2524         (AutoinstallImportHook):
2525         (AutoinstallImportHook._install_chromedriver):
2526         (AutoinstallImportHook._install_geckodriver):
2527         (AutoinstallImportHook.get_latest_pypi_url):
2528         (AutoinstallImportHook.install_binary):
2529         (autoinstall_everything):
2530         (get_driver_filename):
2531         (get_os_info):
2532
2533 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2534
2535         Add WebDriver support in browser driver part of BenchmarkRunner
2536         https://bugs.webkit.org/show_bug.cgi?id=174445
2537
2538         Reviewed by Stephanie Lewis.
2539
2540         Adds a launch_driver function to each BrowserDriver subclass. This
2541         function sets up the arguments for the webdriver and launches the
2542         webdriver specific to that browser.
2543
2544         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2545         (BrowserDriver.launch_webdriver):
2546         (BrowserDriver):
2547         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2548         (LinuxBrowserDriver.launch_webdriver):
2549         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2550         (LinuxChromeDriver.launch_url):
2551         (LinuxChromeDriver):
2552         (LinuxChromeDriver.launch_driver):
2553         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2554         (EpiphanyBrowserDriver.launch_url):
2555         (EpiphanyBrowserDriver):
2556         (EpiphanyBrowserDriver.launch_driver):
2557         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2558         (LinuxFirefoxDriver):
2559         (LinuxFirefoxDriver.launch_url):
2560         (LinuxFirefoxDriver.launch_driver):
2561         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2562         (GTKMiniBrowserDriver.launch_url):
2563         (GTKMiniBrowserDriver):
2564         (GTKMiniBrowserDriver.launch_driver):
2565         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2566         (OSXBrowserDriver._launch_webdriver):
2567         (OSXBrowserDriver):
2568         (OSXBrowserDriver._screen_size):
2569         (OSXBrowserDriver._insert_url):
2570         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2571         (OSXChromeDriver):
2572         (OSXChromeDriver.launch_url):
2573         (OSXChromeDriver.launch_driver):
2574         (OSXChromeCanaryDriver):
2575         (OSXChromeCanaryDriver.launch_url):
2576         (OSXChromeCanaryDriver.launch_driver):
2577         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2578         (OSXFirefoxDriver):
2579         (OSXFirefoxDriver.launch_url):
2580         (OSXFirefoxDriver.launch_driver):
2581         (OSXFirefoxNightlyDriver):
2582         (OSXFirefoxNightlyDriver.launch_url):
2583         (OSXFirefoxNightlyDriver.launch_driver):
2584         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2585         (OSXSafariDriver.launch_driver):
2586
2587 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2588
2589         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
2590         https://bugs.webkit.org/show_bug.cgi?id=174793
2591
2592         Reviewed by Tim Horton.
2593
2594         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
2595         down. Without r219765, this test will dereference null and crash.
2596
2597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2598         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
2599         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
2600         (TEST):
2601
2602 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2603
2604         [Win] Implement Authentication dialog in MiniBrowser
2605         https://bugs.webkit.org/show_bug.cgi?id=174662
2606
2607         Reviewed by Alex Christensen.
2608
2609         * MiniBrowser/win/Common.cpp:
2610         (CustomUserAgent):
2611         (DisplayAuthDialog):
2612         (AuthDialogProc):
2613         * MiniBrowser/win/MiniBrowserLib.rc:
2614         * MiniBrowser/win/MiniBrowserLibResource.h:
2615         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2616         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2617
2618 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
2619
2620         Handle case where line_numbers is None instead of an array of line numbers
2621         https://bugs.webkit.org/show_bug.cgi?id=174775
2622
2623         Reviewed by Aakash Jain.
2624
2625         Added files set line_numbers to None in process_file.
2626
2627         * Scripts/webkitpy/style/filereader.py:
2628         (TextFileReader.process_file): Handle case where line_number is set to None.
2629         * Scripts/webkitpy/style/main_unittest.py:
2630         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
2631
2632 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2633
2634         [WPE] Add libepoxy to the Jhbuild moduleset
2635         https://bugs.webkit.org/show_bug.cgi?id=174711
2636
2637         Reviewed by Carlos Alberto Lopez Perez.
2638
2639         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
2640
2641 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2642
2643         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
2644         https://bugs.webkit.org/show_bug.cgi?id=174780
2645
2646         Reviewed by Carlos Garcia Campos.
2647
2648         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2649         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
2650         in case the eglplatform.h header doesn't provide that macro. This replicates
2651         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
2652
2653 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2654
2655         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
2656         https://bugs.webkit.org/show_bug.cgi?id=174758
2657
2658         Reviewed by Dan Bernstein.
2659
2660         Migrate position-information-related unit tests from the PositionInformationTests suite to
2661         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
2662
2663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2664         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2665         (TestWebKitAPI::checkElementTypeAndBoundingRect):
2666         (TestWebKitAPI::TEST):
2667         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
2668         * TestWebKitAPI/cocoa/TestWKWebView.h:
2669         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2670         (-[TestWKWebView activatedElementAtPosition:]):
2671
2672 2017-07-22  Chris Dumez  <cdumez@apple.com>
2673
2674         REGRESSION(r204565): WKObject is broken
2675         https://bugs.webkit.org/show_bug.cgi?id=174736
2676         <rdar://problem/33246169>
2677
2678         Reviewed by Dan Bernstein.
2679
2680         Add API test that used to crash.
2681
2682         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2683         (TestWebKitAPI::TEST):
2684
2685 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2686
2687         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
2688         https://bugs.webkit.org/show_bug.cgi?id=174705
2689
2690         Reviewed by Mark Lam.
2691
2692         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2693         (TestWebKitAPI::testThreadGroup):
2694         (TestWebKitAPI::TEST):
2695
2696 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
2697
2698         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
2699         https://bugs.webkit.org/show_bug.cgi?id=174724
2700
2701         Reviewed by Aakash Jain.
2702
2703         * Scripts/webkitpy/port/ios_simulator.py:
2704         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
2705         simulator. Errors here should be treated the same as no simulators found.
2706
2707 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
2708
2709         [CMake] Add an option to stop build after generating project files
2710         https://bugs.webkit.org/show_bug.cgi?id=174664
2711
2712         Reviewed by Konstantin Tokarev.
2713
2714         Add "--generate-project-only" to stop build after generating project files.
2715
2716         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
2717         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
2718         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
2719         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
2720         (isGenerateProjectOnly): ditto
2721
2722 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2723
2724         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2725         https://bugs.webkit.org/show_bug.cgi?id=174501
2726
2727         Reviewed by Darin Adler.
2728
2729         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2730         (TestWebKitAPI::TEST):
2731
2732 2017-07-20  David Quesada  <david_quesada@apple.com>
2733
2734         Add SPI to notify WKNavigationDelegate about client redirects
2735         https://bugs.webkit.org/show_bug.cgi?id=174680
2736         rdar://problem/33184886
2737
2738         Reviewed by Brady Eidson.
2739
2740         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2741         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
2742         (TEST):
2743         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
2744
2745 2017-07-20  Brady Eidson  <beidson@apple.com>
2746
2747         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
2748         https://bugs.webkit.org/show_bug.cgi?id=174685
2749
2750         Reviewed by Andy Estes.
2751
2752         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2753         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
2754
2755 2017-07-20  Brady Eidson  <beidson@apple.com>
2756
2757         Deprecate WebIconDatabase in WebKitLegacy/mac.
2758         https://bugs.webkit.org/show_bug.cgi?id=174607
2759
2760         Reviewed by Alex Christensen.
2761
2762         * DumpRenderTree/mac/TestRunnerMac.mm:
2763
2764 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2765
2766         lint-test-expectations should be run during style checking
2767         https://bugs.webkit.org/show_bug.cgi?id=173559
2768         <rdar://problem/32854941>
2769
2770         Reviewed by Aakash Jain.
2771
2772         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2773         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
2774         prevents identifying errors on specific lines in a file.
2775         * Scripts/webkitpy/style/main_unittest.py:
2776         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
2777         case where a linter error is in the file modified, but the line modified is not related to
2778         the linter error.
2779
2780 2017-07-20  Brady Eidson  <beidson@apple.com>
2781
2782         Remove WebIconDatabase from WebKitLegacy/win.
2783         https://bugs.webkit.org/show_bug.cgi?id=174608
2784
2785         Reviewed by Alex Christensen.
2786
2787         * DumpRenderTree/win/DumpRenderTree.cpp:
2788         (main):
2789         * DumpRenderTree/win/TestRunnerWin.cpp:
2790         (TestRunner::setIconDatabaseEnabled):
2791
2792 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
2793
2794         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
2795         https://bugs.webkit.org/show_bug.cgi?id=174671
2796
2797         Reviewed by Carlos Garcia Campos.
2798
2799         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2800         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
2801         priority for this source in order to have it dispatched on the same
2802         priority as the other WebKit-controlled GSource objects.
2803
2804 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2805
2806         lint-test-expectations should be run during style checking
2807         https://bugs.webkit.org/show_bug.cgi?id=173559
2808         <rdar://problem/32854941>
2809
2810         Reviewed by Daniel Bates.
2811
2812         Follow up fix addressing style and a few minor bugs.
2813
2814         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2815         (TestExpectationParser.__init__): Use lambda x: x instead of str
2816         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
2817         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
2818         reduce the calls of _shorten_filename, fix minor bug in appending the current
2819         expectation's line number instead of the previous ones, clarify treatment of None
2820         in file-to-line-number mapping.
2821         (TestExpectations._report_warnings): Collapse call.
2822         * Scripts/webkitpy/style/checkers/test_expectations.py:
2823         (TestExpectationsChecker.lint_test_expectations):
2824         * Scripts/webkitpy/style/filereader.py: Re-write comment.
2825         (TextFileReader.process_file): Add comment explaining treatment of None in
2826         file-to-line-number mapping.
2827         (TextFileReader.delete_file): Collapse call.
2828
2829 2017-07-19  Chris Dumez  <cdumez@apple.com>
2830
2831         Unreviewed attempt to fix API test failure after r219663.
2832
2833         The test was hard-coding an exception string and the string has changed slightly
2834         in r219663.
2835
2836         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2837         (TEST):
2838
2839 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
2840
2841         Don't write file URLs to iOS Pasteboard
2842         https://bugs.webkit.org/show_bug.cgi?id=174647
2843         <rdar://problem/33199730>
2844
2845         Reviewed by Wenson Hsieh.
2846
2847         Updating tests to reflect the lack of file URLs for images.
2848
2849         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2850         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
2851         (checkEstimatedSize):
2852         (TestWebKitAPI::TEST):
2853
2854 2017-07-19  Brady Eidson  <beidson@apple.com>
2855
2856         iBooks sometimes crashes when closing a book.
2857         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
2858
2859         Reviewed by Oliver Hunt.
2860
2861         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2862         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
2863         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
2864         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
2865         (TestWebKitAPI::TEST):
2866
2867         Add a "spin the runloop X number of times" utility:
2868         * TestWebKitAPI/Utilities.h:
2869         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2870         (TestWebKitAPI::Util::spinRunLoop):
2871
2872 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2873
2874         lint-test-expectations should be run during style checking
2875         https://bugs.webkit.org/show_bug.cgi?id=173559
2876         <rdar://problem/32854941>
2877
2878         Reviewed by David Kilzer.
2879
2880         Running the test expectation linter requires reading both files and lines not in the
2881         patch because, for example, deletion of a test can cause a lint failure even though
2882         no test expectations where modified. This means that the linter will occasionally warn
2883         about lines which were not changed in a given patch but whose error is related to a
2884         change made in that patch.
2885
2886         * Scripts/webkitpy/common/system/filesystem_mock.py:
2887         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
2888         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2889         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
2890         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
2891         content, description of the error and the name of the associated test.
2892         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
2893         (TestExpectationParser.__init__): Pass shorten_filename function to
2894         TestExpectationsParser to add a deleted file to the related_files dictionary.
2895         (TestExpectationParser._check_test_exists): If the test does not exist, add the
2896         missing path to the related_files dictionary.
2897         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
2898         files and line numbers related to this test expectation line. This will allow
2899         tracking linter errors in the style checker occurring across multiple files.
2900         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
2901         lines to related_files dictionary.
2902         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
2903         (TestExpectations._report_warnings): Construct warning object instead of string
2904         when adding to warnings list.
2905         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
2906         clean-up log.
2907         * Scripts/webkitpy/style/checker.py:
2908         (ProcessorBase.do_association_check): Add required function for processor classes.
2909         (StyleProcessor):
2910         (StyleProcessor.do_association_check): Run the TestExpectations linter when
2911         checking for errors between associated files.
2912         * Scripts/webkitpy/style/checkers/test_expectations.py:
2913         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
2914         (TestExpectationsChecker):
2915         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
2916         of modified files, the current working directory and the host, determine if the linter
2917         warning is associated with the changes.
2918         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
2919         style checker.
2920         * Scripts/webkitpy/style/filereader.py:
2921         (TextFileReader):
2922         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
2923         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
2924         (TextFileReader.process_file): Track both the number of files changed and which lines
2925         in those files were changed.
2926         (TextFileReader.do_association_check): Run the processor's association check on all
2927         modified or deleted files processed by TextFileReader.
2928         (TextFileReader.delete_file): Track deleted files in _files dictionary.
2929         (TextFileReader.count_delete_only_file): Deleted.
2930         * Scripts/webkitpy/style/filereader_unittest.py:
2931         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
2932         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
2933         * Scripts/webkitpy/style/main.py:
2934         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
2935         explicitly run the association check on the file reader.
2936         * Scripts/webkitpy/style/main_unittest.py:
2937         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
2938         embedded in the style checker.
2939         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
2940         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
2941         construct the TextFileReader object with a StyleProcessor used to run style checks on
2942         specific files.
2943         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
2944         testing the test expectation linter inside the style checker. This host must contain a
2945         mock file system with the basic structure of test expectations.
2946         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
2947         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
2948         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
2949         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
2950         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
2951         * Scripts/webkitpy/style/patchreader.py:
2952         (PatchReader.check): Specify which file was deleted, run the association check.
2953         * Scripts/webkitpy/style/patchreader_unittest.py:
2954         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
2955         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
2956         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
2957
2958 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2959
2960         [WTF] Implement WTF::ThreadGroup
2961         https://bugs.webkit.org/show_bug.cgi?id=174081
2962
2963         Reviewed by Mark Lam.
2964
2965         Add WTF::ThreadGroup tests.
2966
2967         * TestWebKitAPI/CMakeLists.txt:
2968         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2969         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2970         (TestWebKitAPI::testThreadGroup):
2971         (TestWebKitAPI::TEST):
2972
2973 2017-07-18  Andy Estes  <aestes@apple.com>
2974
2975         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2976         https://bugs.webkit.org/show_bug.cgi?id=174631
2977
2978         Reviewed by Tim Horton.
2979
2980         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2981         * MiniBrowser/Configurations/Base.xcconfig:
2982         * MobileMiniBrowser/Configurations/Base.xcconfig:
2983         * TestWebKitAPI/Configurations/Base.xcconfig:
2984         * WebKitTestRunner/Configurations/Base.xcconfig:
2985
2986 2017-07-18  Andy Estes  <aestes@apple.com>
2987
2988         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2989         https://bugs.webkit.org/show_bug.cgi?id=174631
2990
2991         Reviewed by Sam Weinig.
2992
2993         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2994         * MiniBrowser/Configurations/Base.xcconfig:
2995         * MobileMiniBrowser/Configurations/Base.xcconfig:
2996         * TestWebKitAPI/Configurations/Base.xcconfig:
2997         * WebKitTestRunner/Configurations/Base.xcconfig:
2998
2999 2017-07-18  Daniel Bates  <dabates@apple.com>
3000
3001         lldb: Add type summary for StringView
3002         https://bugs.webkit.org/show_bug.cgi?id=174637
3003
3004         Reviewed by Sam Weinig.
3005
3006         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
3007         StringView object will print output that has the form:
3008
3009             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
3010               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
3011               m_length = 2
3012               m_is8Bit = true
3013               m_underlyingString = 0x0000614000000a90
3014             }
3015
3016         * lldb/lldb_webkit.py:
3017         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
3018         (WTFStringView_SummaryProvider):
3019         (WTFStringViewProvider):
3020         (WTFStringViewProvider.__init__):
3021         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
3022         (WTFStringViewProvider.get_length): Access field StringView.m_length.
3023         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
3024         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
3025
3026 2017-07-18  Andy Estes  <aestes@apple.com>
3027
3028         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3029         https://bugs.webkit.org/show_bug.cgi?id=174631
3030
3031         Reviewed by Dan Bernstein.
3032
3033         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3034         * MiniBrowser/Configurations/Base.xcconfig:
3035         * MobileMiniBrowser/Configurations/Base.xcconfig:
3036         * TestWebKitAPI/Configurations/Base.xcconfig:
3037         * WebKitTestRunner/Configurations/Base.xcconfig:
3038
3039 2017-07-18  Devin Rousso  <drousso@apple.com>
3040
3041         Web Inspector: Add memoryCost to Inspector Protocol objects
3042         https://bugs.webkit.org/show_bug.cgi?id=174478
3043
3044         Reviewed by Joseph Pecoraro.
3045
3046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3047         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
3048         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
3049         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
3050         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
3051         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
3052         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
3053         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
3054         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
3055         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
3056         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
3057         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
3058         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
3059         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
3060         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
3061         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
3062         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
3063
3064 2017-07-18  Andy Estes  <aestes@apple.com>
3065
3066         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3067         https://bugs.webkit.org/show_bug.cgi?id=174631
3068
3069         Reviewed by Darin Adler.
3070
3071         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3072         * MiniBrowser/Configurations/Base.xcconfig:
3073         * MobileMiniBrowser/Configurations/Base.xcconfig:
3074         * TestWebKitAPI/Configurations/Base.xcconfig:
3075         * WebKitTestRunner/Configurations/Base.xcconfig:
3076
3077 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3078
3079         Unreviewed, fix the iOS build.
3080
3081         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
3082
3083         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3084         (TestWebKitAPI::TEST):
3085
3086 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3087
3088         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
3089         https://bugs.webkit.org/show_bug.cgi?id=174585
3090         <rdar://problem/33302541>
3091
3092         Reviewed by Tim Horton.
3093
3094         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
3095         being dragged when initiating a drag.
3096
3097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3098         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
3099         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3100         (TestWebKitAPI::TEST):
3101         * TestWebKitAPI/cocoa/TestWKWebView.h:
3102
3103         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
3104
3105         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3106         (-[TestWKWebView synchronouslyLoadHTMLString:]):
3107
3108 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3109
3110         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
3111         https://bugs.webkit.org/show_bug.cgi?id=174547
3112
3113         Reviewed by Alex Christensen.
3114
3115         * DumpRenderTree/PlatformWin.cmake:
3116         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3117
3118 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3119
3120         Update style checker to deal with "final"
3121         https://bugs.webkit.org/show_bug.cgi?id=174528
3122
3123         Reviewed by Alex Christensen.
3124         
3125         check-webkit-style shouldn't complain about an open brace to start a
3126         line after a function definition with "final" or "const final".
3127
3128         * Scripts/webkitpy/style/checkers/cpp.py:
3129         (check_braces):
3130         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3131         (CppStyleTest.test_brace_at_begin_of_line):
3132
3133 2017-07-17  Alex Christensen  <achristensen@webkit.org>
3134
3135         Modernize content extension code
3136         https://bugs.webkit.org/show_bug.cgi?id=174588
3137
3138         Reviewed by Sam Weinig.
3139
3140         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3141         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3142         (TestWebKitAPI::testRequest):
3143         (TestWebKitAPI::makeBackend):
3144         (TestWebKitAPI::TEST_F):
3145
3146 2017-07-17  Brady Eidson  <beidson@apple.com>
3147
3148         WKHTTPCookieStore observing only works on the default cookie store.
3149         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
3150
3151         Reviewed by Sam Weinig.
3152
3153         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3154         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
3155           called for the default store, a non-persistent store, and a custom store.
3156         (TEST):
3157
3158 2017-07-16  Sam Weinig  <sam@webkit.org>
3159
3160         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
3161         https://bugs.webkit.org/show_bug.cgi?id=174575
3162
3163         Reviewed by Brady Eidson.
3164
3165         * Scripts/svn-create-patch:
3166         (findModificationType):
3167         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
3168         default value of "unknown".
3169
3170         (generateFileList):
3171         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
3172         for untracked, which matches our old behavior.
3173
3174 2017-07-17  Charlie Turner  <cturner@igalia.com>
3175
3176         Add some missing build dependencies on Fedora
3177         https://bugs.webkit.org/show_bug.cgi?id=174578
3178
3179         Unreviewed dependency update.
3180
3181         * gtk/install-dependencies:
3182
3183 2017-07-16  Brady Eidson  <beidson@apple.com>
3184
3185         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
3186         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
3187
3188         Reviewed by Tim Horton.
3189
3190         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3191         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
3192         (TEST):
3193
3194 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
3195
3196         [GTK] Sort inspector GResource manifest to ensure reproducible builds
3197         https://bugs.webkit.org/show_bug.cgi?id=174540
3198
3199         Reviewed by Michael Catanzaro.
3200
3201         * gtk/generate-inspector-gresource-manifest.py:
3202         (get_filenames): sort list of input files
3203
3204 2017-07-15  Brady Eidson  <beidson@apple.com>
3205
3206         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
3207         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
3208
3209         Reviewed by Tim Horton.
3210
3211         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3212         (TEST): Make this test more reliable by clearing everything beforehand.
3213
3214 2017-07-15  David Kilzer  <ddkilzer@apple.com>
3215
3216         Make it possible to extend check-webkit-style with Apple-internal checkers
3217         <https://webkit.org/b/174464>
3218         <rdar://problem/25564402>
3219
3220         Reviewed by Darin Adler.
3221
3222         * Scripts/webkitpy/style/checker.py: Import apple_additions.
3223         (_all_categories): Add categories from apple_additions() if it
3224         exists.
3225         (CheckerDispatcher._create_checker): Create python checker
3226         from apple_additions() if it exists.
3227
3228 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3229
3230         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
3231         https://bugs.webkit.org/show_bug.cgi?id=174539
3232         <rdar://problem/33307395>
3233
3234         Reviewed by Darin Adler.
3235
3236         Adds a new unit test suite to cover action sheet popover presentation.
3237
3238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3239         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
3240         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
3241         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
3242
3243         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
3244
3245         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
3246         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3247
3248         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
3249
3250         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3251         (TestWebKitAPI::TEST):
3252
3253 2017-07-15  Sam Weinig  <sam@webkit.org>
3254
3255         [Scripts] Make svn-create-patch work better when called in sub directories
3256         https://bugs.webkit.org/show_bug.cgi?id=174551
3257
3258         Reviewed by Darin Adler.
3259
3260         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
3261           by ensuring that the prefix is applied as is done in generateDiff.
3262         - Silence output of explanatory lines from svn stat (" > move to ...")
3263           that show up in STDERR when running svn-create-patch.
3264         - Add verbose logging that I found useful while debugging this issue.
3265
3266         * Scripts/svn-create-patch:
3267         (findBaseUrl):
3268         (findMimeType):
3269         (findSourceFileAndRevision):
3270         (generateDiff):
3271         (generateFileList):
3272         (manufacturePatchForAdditionWithHistory):
3273
3274 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
3275
3276         Unreviewed build fix after r219537.
3277
3278         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3279
3280 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3281
3282         Add iOS 11 SPI
3283         https://bugs.webkit.org/show_bug.cgi?id=174430
3284         <rdar://problem/33269288>
3285
3286         Reviewed by Tim Horton.
3287
3288         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
3289         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
3290         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
3291
3292 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3293
3294         Failing to install on iPad simulators
3295         https://bugs.webkit.org/show_bug.cgi?id=174532
3296         <rdar://problem/33328347>
3297
3298         Reviewed by Stephanie Lewis.
3299
3300         * Scripts/webkitpy/xcode/simulated_device.py:
3301         (SimulatedDevice.install_app): Place install command in retry try-except block.
3302
3303 2017-07-14  Jeff Miller  <jeffm@apple.com>
3304
3305         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3306         https://bugs.webkit.org/show_bug.cgi?id=174524
3307
3308         Reviewed by Sam Weinig.
3309
3310         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
3311         (TEST):
3312         Renamed TestParameter to TestParameter1.
3313         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3314
3315         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3316         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3317         Observe changes for two bundle parameters.
3318
3319         (-[BundleParametersPlugIn dealloc]):
3320         Remove observers for two bundle parameters.
3321
3322 2017-07-14  Commit Queue  <commit-queue@webkit.org>
3323
3324         Unreviewed, rolling out r219510.
3325         https://bugs.webkit.org/show_bug.cgi?id=174525
3326
3327         Need to revert length() == 0 check for null string (Requested
3328         by yusukesuzuki on #webkit).
3329
3330         Reverted changeset:
3331
3332         "[WTF] Newly added AtomicStringImpl should use BufferInternal
3333         static string if StringImpl is static"
3334         https://bugs.webkit.org/show_bug.cgi?id=174501
3335         http://trac.webkit.org/changeset/219510
3336
3337 2017-07-14  Jer Noble  <jer.noble@apple.com>
3338
3339         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
3340         https://bugs.webkit.org/show_bug.cgi?id=174514
3341
3342         Reviewed by Sam Weinig.
3343
3344         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
3345         (TestWebKitAPI::TEST_F):
3346
3347 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3348
3349         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3350         https://bugs.webkit.org/show_bug.cgi?id=174501
3351
3352         Reviewed by Darin Adler.
3353
3354         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3355         (TestWebKitAPI::TEST):
3356
3357 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3358
3359         Bring mac expectations in-line with other platforms
3360         https://bugs.webkit.org/show_bug.cgi?id=174472
3361         <rdar://problem/33297388>
3362
3363         Reviewed by David Kilzer.
3364
3365         The override order for Mac test expectations does not conform to the pattern used by iOS,
3366         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
3367
3368             platform/mac-wk2
3369             platform/wk2
3370             platform/mac-elcapitan
3371             platform/mac-sierra
3372             generic
3373
3374         After this change, El Capitan's baseline search path looks like this:
3375
3376             platform/mac-sierra-wk2
3377             platform/mac-sierra
3378             platform/mac-wk2
3379             platform/wk2
3380             generic
3381
3382         * Scripts/webkitpy/port/mac.py:
3383         (MacPort.__init__): If a specific version is specified in the port name, use that
3384         as the os version.
3385         (MacPort.default_baseline_search_path): Expectation search paths should work the
3386         same way they do on other ports. Port + version overrides port, port overrides generic
3387         and wk1/wk2 should override expectations for the two combined.
3388         * Scripts/webkitpy/port/mac_unittest.py:
3389         (MacTest.test_tests_for_other_platforms): Deleted.
3390         (MacTest._assert_search_path): Deleted.
3391         (MacTest.test_baseline_search_path): Deleted.
3392         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3393         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
3394         (test_rebaseline_test_and_print_scm_changes): Ditto.
3395         (test_rebaseline_and_copy_test): Ditto.
3396         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
3397         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
3398         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
3399
3400 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3401
3402         Fix style checker unit test
3403
3404         Unreviewed WebKit2 => WebKit fixup.
3405
3406         * Scripts/webkitpy/style/checker_unittest.py:
3407         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3408
3409 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3410
3411         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
3412
3413         Unreviewed build fix.
3414
3415         r219492 missed one hunk from its partial revert of r219489.
3416         This patch reverts that hunk.
3417
3418         * TestWebKitAPI/CMakeLists.txt:
3419
3420 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3421
3422         Use the old WebKit/WebKit2 targets for CMake builds.
3423
3424         Unreviewed build fix.
3425
3426         We can update the target names to match the Framework names in a future patch.
3427         This is a partial revert of r219489.
3428
3429         * TestWebKitAPI/CMakeLists.txt:
3430         WebKitLegacy => WebKit
3431         WebKit => WebKit2
3432
3433 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3434
3435         Fix TestWebKit API.
3436         https://bugs.webkit.org/show_bug.cgi?id=174164
3437         rdar://problem/33137595
3438
3439         Reviewed by Dan Bernstein.
3440
3441         * TestWebKitAPI/CMakeLists.txt:
3442         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3443         * TestWebKitAPI/PlatformGTK.cmake:
3444
3445 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3446
3447         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
3448         https://bugs.webkit.org/show_bug.cgi?id=174164
3449         rdar://problem/33137595
3450
3451         Reviewed by Dan Bernstein.
3452
3453         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3454         (ShouldBuildTest):
3455         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3456         * Scripts/build-webkit:
3457         * Scripts/do-file-rename:
3458         * Scripts/do-webcore-rename:
3459         * Scripts/update-webkit-localizable-strings:
3460         * Scripts/webkitpy/common/config/watchlist:
3461         * Scripts/webkitpy/style/checker.py:
3462         * Scripts/webkitpy/style/checkers/featuredefines.py:
3463         * gtk/make-dist.py:
3464         (ensure_version_if_possible):
3465         * gtk/manifest.txt.in:
3466
3467 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
3468
3469         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
3470         https://bugs.webkit.org/show_bug.cgi?id=174162
3471         rdar://problem/33137594
3472
3473         Reviewed by Dan Bernstein.
3474
3475         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
3476
3477         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3478         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3479         * EWSTools/configure-clang-linux.sh:
3480         * Scripts/build-webkit:
3481         * Scripts/do-file-rename:
3482         * Scripts/do-webcore-rename:
3483         * Scripts/update-webkit-localizable-strings:
3484         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3485         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3486         * Scripts/webkitpy/style/checkers/featuredefines.py:
3487         * gtk/manifest.txt.in:
3488
3489 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
3490
3491         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
3492         https://bugs.webkit.org/show_bug.cgi?id=174438
3493         <rdar://problem/33277112>
3494
3495         Reviewed by Aakash Jain.
3496
3497         Given a patch, this will convert the changes from the path to the new directory structure.
3498
3499         * Scripts/rebase-patch-after-webkit-move: Added.
3500         (append_source): Append 'Source' to the provided path.
3501         (is_editable_line): Return true if a line the script expects to modify.
3502         (needs_rebase): Return if a line needs to be rebased based on it's content.
3503         (rebase_line): Rebase the provided line.
3504         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
3505         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
3506         were provided.
3507
3508 2017-07-12  Nan Wang  <n_wang@apple.com>
3509
3510         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3511         https://bugs.webkit.org/show_bug.cgi?id=174393
3512         <rdar://problem/33248006>
3513
3514         Reviewed by Chris Fleizach.
3515
3516         * DumpRenderTree/AccessibilityUIElement.cpp:
3517         (textMarkerRangeMatchesTextNearMarkersCallback):
3518         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3519         (AccessibilityUIElement::getJSClass):
3520         * DumpRenderTree/AccessibilityUIElement.h:
3521         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3522         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3523         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3524         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3525         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3526         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3527         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3528         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3529
3530 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3531
3532         Unreviewed, rolling out r219409.
3533
3534         The revision caused the Windows builds to fail.
3535
3536         Reverted changeset:
3537
3538         "AX: [iOS] Implement a way to retrieve a text marker range
3539         with desired text that is closest to a position"
3540         https://bugs.webkit.org/show_bug.cgi?id=174393
3541         http://trac.webkit.org/changeset/219409
3542
3543 2017-07-12  Nan Wang  <n_wang@apple.com>
3544
3545         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3546         https://bugs.webkit.org/show_bug.cgi?id=174393
3547         <rdar://problem/33248006>
3548
3549         Reviewed by Chris Fleizach.
3550
3551         * DumpRenderTree/AccessibilityUIElement.cpp:
3552         (textMarkerRangeMatchesTextNearMarkersCallback):
3553         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3554         (AccessibilityUIElement::getJSClass):
3555         * DumpRenderTree/AccessibilityUIElement.h:
3556         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3557         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3558         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3559         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3560         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3561         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3562         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3563         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3564
3565 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
3566
3567         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
3568         https://bugs.webkit.org/show_bug.cgi?id=174197
3569
3570         Reviewed by Darin Adler.
3571
3572         This bit me the first time I tried to submit a patch to WebKit, and still I have
3573         to manually edit the ChangeLog every time I use the script.
3574
3575         This generates a more convenient and standard ChangeLog entry.
3576
3577         * Scripts/prepare-ChangeLog:
3578         (generateNewChangeLogs):
3579
3580 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3581
3582         Unreviewed, rolling out r219401.
3583
3584         This revision rolled out the previous patch, but after talking
3585         with reviewer, a rebaseline is what was needed.Rolling back in
3586         before rebaseline.
3587
3588         Reverted changeset:
3589
3590         "Unreviewed, rolling out r219379."
3591         https://bugs.webkit.org/show_bug.cgi?id=174400
3592         http://trac.webkit.org/changeset/219401
3593
3594 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3595
3596         Unreviewed, rolling out r219379.
3597
3598         This revision caused a consistent failure in the test
3599         fast/dom/Window/property-access-on-cached-window-after-frame-
3600         removed.html.
3601
3602         Reverted changeset:
3603
3604         "Remove NAVIGATOR_HWCONCURRENCY"
3605         https://bugs.webkit.org/show_bug.cgi?id=174400
3606         http://trac.webkit.org/changeset/219379
3607
3608 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3609
3610         [WPE] Use libepoxy