Remove --shark* support from sunspider/run-sunspider now that Shark is dead
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-16  Eric Seidel  <eric@webkit.org>
2
3         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
4         https://bugs.webkit.org/show_bug.cgi?id=99512
5
6         Reviewed by Darin Adler.
7
8         * Scripts/run-sunspider:
9
10 2013-01-16  Eric Seidel  <eric@webkit.org>
11
12         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
13         https://bugs.webkit.org/show_bug.cgi?id=106036
14
15         Reviewed by Darin Adler.
16
17         * Scripts/webkitpy/webkitpy.pyproj: Removed.
18         * Scripts/webkitpy/webkitpy.sln: Removed.
19
20 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
21
22         [Chromium] Remove hardcoded chromium_*.jar in gyp files
23         https://bugs.webkit.org/show_bug.cgi?id=104049
24
25         Reviewed by Eric Seidel.
26
27         Targets with dependencies (direct/indirect) on a java target receive
28         the chromium_*.jar paths in the variable input_jars_paths. Targets
29         should use that rather than hardcoding where they think the jar will
30         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
31         than as --jars to generate_native_test.py.
32
33         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
34         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
35
36 2013-01-16  Dan Carney  <dcarney@google.com>
37
38         [chromium] move setMockDeviceOrientation to TestRunner library
39         https://bugs.webkit.org/show_bug.cgi?id=106895
40
41         Reviewed by Jochen Eisinger.
42
43         * DumpRenderTree/chromium/DRTTestRunner.cpp:
44         (DRTTestRunner::DRTTestRunner):
45         * DumpRenderTree/chromium/DRTTestRunner.h:
46         (DRTTestRunner):
47         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
48         (WebKit):
49         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
50         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
51         (WebTestRunner::TestRunner::TestRunner):
52         (WebTestRunner::TestRunner::setMockDeviceOrientation):
53         (WebTestRunner):
54         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
55         (TestRunner):
56         * DumpRenderTree/chromium/WebViewHost.cpp:
57         (WebViewHost::setDeviceOrientation):
58         * DumpRenderTree/chromium/WebViewHost.h:
59         (WebViewHost):
60
61 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
62
63         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
64         https://bugs.webkit.org/show_bug.cgi?id=106904
65
66         Reviewed by Adam Barth.
67
68         * DumpRenderTree/chromium/DRTTestRunner.cpp:
69         (DRTTestRunner::DRTTestRunner):
70         (DRTTestRunner::notifyDone):
71         (DRTTestRunner::reset):
72         * DumpRenderTree/chromium/DRTTestRunner.h:
73         (DRTTestRunner):
74         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
75         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
76         (WebTestRunner::WebTestDelegate::setFocus):
77         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
78         (WebTestRunner::WebTestDelegate::pathToLocalResource):
79         (WebTestRunner::WebTestDelegate::setLocale):
80         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
81         (WebTestRunner::TestRunner::TestRunner):
82         (WebTestRunner::TestRunner::reset):
83         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
84         (WebTestRunner):
85         (WebTestRunner::TestRunner::setWindowIsKey):
86         (WebTestRunner::TestRunner::pathToLocalResource):
87         (WebTestRunner::TestRunner::setBackingScaleFactor):
88         (WebTestRunner::TestRunner::setPOSIXLocale):
89         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
90         (WebTestRunner::TestRunner::taskList):
91         (TestRunner):
92         * DumpRenderTree/chromium/WebViewHost.cpp:
93         (WebViewHost::setDeviceScaleFactor):
94         (WebViewHost::setFocus):
95         (WebViewHost::setAcceptAllCookies):
96         (WebViewHost::pathToLocalResource):
97         (WebViewHost::setLocale):
98         * DumpRenderTree/chromium/WebViewHost.h:
99         (WebViewHost):
100
101 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
102
103         [GTK] build-webkit fails if the jhbuild wrapper is not used
104         https://bugs.webkit.org/show_bug.cgi?id=106769
105
106         Reviewed by Martin Robinson.
107
108         Return an empty array instead of "" in
109         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
110         will not be recognized as a valid command when the returned array
111         is directly passed to perl's system() call.
112
113         * Scripts/webkitdirs.pm:
114         (jhbuildWrapperPrefixIfNeeded):
115
116 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
117
118         [chromium] add title text direction attribute to TestRunner
119         https://bugs.webkit.org/show_bug.cgi?id=106907
120
121         Reviewed by Adam Barth.
122
123         * DumpRenderTree/chromium/DRTTestRunner.cpp:
124         (DRTTestRunner::DRTTestRunner):
125         (DRTTestRunner::reset):
126         * DumpRenderTree/chromium/DRTTestRunner.h:
127         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
128         (WebTestRunner::WebTestRunner::setTitleTextDirection):
129         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
130         (WebTestRunner::TestRunner::TestRunner):
131         (WebTestRunner::TestRunner::reset):
132         (WebTestRunner::TestRunner::setTitleTextDirection):
133         (WebTestRunner):
134         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
135         (TestRunner):
136         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
137         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
138         * DumpRenderTree/chromium/WebViewHost.cpp:
139         (WebViewHost::didReceiveTitle):
140
141 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
142
143         NRWT still confused about test count with --repeat-each and --iterations
144         https://bugs.webkit.org/show_bug.cgi?id=106562
145
146         Reviewed by Dirk Pranke.
147
148         Fix the printed unique test count and skipped count. This
149         seems to have broken in r127688 ("NRWT lies about the number
150         of tests that it's skipping when used with --repeat-each").
151
152         Also add a test for print_found()
153
154         * Scripts/webkitpy/layout_tests/views/printing.py:
155         (Printer.print_found):
156         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
157         (Testprinter.test_details):
158         (Testprinter):
159         (Testprinter.test_found):
160
161 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
162
163         Unreviewed follow-up to r139769.
164
165         Note that omitting the WebKit1 code from the build now
166         works for GTK as well.
167
168         * Scripts/build-webkit:
169
170 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
171
172         test-webkitpy: truncate output to the terminal width when necessary
173         https://bugs.webkit.org/show_bug.cgi?id=106973
174
175         Reviewed by Ojan Vafai.
176
177         this implements the same logic for test-webkitpy that we have
178         for run-webkit-tests (and ninja).
179
180         No tests written as this is exercised by running test-webkitpy itself.
181
182         * Scripts/webkitpy/test/printer.py:
183         (Printer.configure):
184         (Printer._test_line):
185
186 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
187
188         remove extraneous output in test-webkitpy
189         https://bugs.webkit.org/show_bug.cgi?id=106971
190
191         Reviewed by Ojan Vafai.
192
193         We weren't ignoring or capturing the echoed output from
194         these two tests, and getting noise in the logs as a result.
195
196         * Scripts/webkitpy/common/system/executive_unittest.py:
197         (ExecutiveTest.test_auto_stringify_args):
198         (ExecutiveTest.test_popen_args):
199
200 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
201
202         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
203         https://bugs.webkit.org/show_bug.cgi?id=106974
204
205         Reviewed by Ryosuke Niwa.
206
207         I forgot to stub out the call to check to ensure that the ports were
208         available, so this test could fail if something was listening on 8000 or
209         8443 on the machine.
210
211         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
212         (TestHttpServer.test_win32_start_and_stop):
213
214 2013-01-15  Levi Weintraub  <leviw@chromium.org>
215
216         Unreviewed, rolling out r139792.
217         http://trac.webkit.org/changeset/139792
218         https://bugs.webkit.org/show_bug.cgi?id=106970
219
220         Broke the windows build.
221
222         * DumpRenderTree/chromium/DRTTestRunner.cpp:
223         (DRTTestRunner::DRTTestRunner):
224         (DRTTestRunner::notifyDone):
225         (DRTTestRunner::reset):
226         (DRTTestRunner::setAlwaysAcceptCookies):
227         (DRTTestRunner::setWindowIsKey):
228         (DRTTestRunner::pathToLocalResource):
229         (DRTTestRunner::setPOSIXLocale):
230         (InvokeCallbackTask):
231         (InvokeCallbackTask::InvokeCallbackTask):
232         (InvokeCallbackTask::runIfValid):
233         (DRTTestRunner::setBackingScaleFactor):
234         * DumpRenderTree/chromium/DRTTestRunner.h:
235         (DRTTestRunner):
236         (DRTTestRunner::taskList):
237         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
238         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
239         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
240         (WebTestRunner::TestRunner::TestRunner):
241         (WebTestRunner::TestRunner::reset):
242         (WebTestRunner::TestRunner::setDatabaseQuota):
243         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
244         (TestRunner):
245         * DumpRenderTree/chromium/WebViewHost.cpp:
246         (WebViewHost::setPendingExtraData):
247         (WebViewHost::setDeviceScaleFactor):
248         * DumpRenderTree/chromium/WebViewHost.h:
249         (WebViewHost):
250
251 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
252
253         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
254
255         * Scripts/webkitpy/common/config/ports.py:
256         (MacWK2Port):
257
258 2013-01-15  Alan Cutter  <alancutter@chromium.org>
259
260         Extend sheriffbot's "help" command to be able to get help on individual commands
261         https://bugs.webkit.org/show_bug.cgi?id=106629
262
263         Reviewed by Eric Seidel.
264
265         Added a help command to sheriffbot.
266         Fixed some style issues and ordered the commands alphabetically.
267
268         * Scripts/webkitpy/tool/bot/irc_command.py:
269         (IRCCommand):
270         (IRCCommand.execute):
271         (IRCCommand.usage):
272         (IRCCommand.help):
273         (CreateBug):
274         (CreateBug.execute):
275         (Help):
276         (Help.execute):
277         (Help._post_command_help):
278         (Hi):
279         (Hi.execute):
280         (Restart):
281         (RollChromiumDEPS):
282         (RollChromiumDEPS._parse_args):
283         (RollChromiumDEPS._expand_irc_nickname):
284         (RollChromiumDEPS.execute):
285         (Rollout):
286         (Rollout._extract_revisions):
287         (Rollout.execute):
288         (Sheriffs):
289         (Sheriffs.execute):
290         (Whois):
291         (Whois.execute):
292         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
293         (IRCBotTest.test_help):
294
295 2013-01-15  Enrica Casucci  <enrica@apple.com>
296
297         Add a new set of WebKit2 APIs for text search and
298         search results management.
299         https://bugs.webkit.org/show_bug.cgi?id=106834.
300         <rdar://problem/12597159>
301
302         Added new test for the new WebKit2 API for
303         text search.
304         
305         Reviewed by Simon Fraser.
306
307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
308         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
309
310 2013-01-15  Levi Weintraub  <leviw@chromium.org>
311
312         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
313         https://bugs.webkit.org/show_bug.cgi?id=106904
314
315         Reverting 139794. It broke the build. It appears that a header file,
316         WebTextDirection.h, was left out.
317
318         * DumpRenderTree/chromium/DRTTestRunner.cpp:
319         (DRTTestRunner::DRTTestRunner):
320         (DRTTestRunner::reset):
321         * DumpRenderTree/chromium/DRTTestRunner.h:
322         (DRTTestRunner::setTitleTextDirection):
323         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
324         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
325         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
326         (WebTestRunner::TestRunner::TestRunner):
327         (WebTestRunner::TestRunner::reset):
328         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
329         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
330         (TestRunner):
331         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
332         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
333         * DumpRenderTree/chromium/WebViewHost.cpp:
334         (WebViewHost::didReceiveTitle):
335
336 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
337
338         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
339         https://bugs.webkit.org/show_bug.cgi?id=106904
340
341         Reviewed by Adam Barth.
342
343         * DumpRenderTree/chromium/DRTTestRunner.cpp:
344         (DRTTestRunner::DRTTestRunner):
345         (DRTTestRunner::notifyDone):
346         (DRTTestRunner::reset):
347         * DumpRenderTree/chromium/DRTTestRunner.h:
348         (DRTTestRunner):
349         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
350         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
351         (WebTestRunner::WebTestDelegate::setFocus):
352         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
353         (WebTestRunner::WebTestDelegate::pathToLocalResource):
354         (WebTestRunner::WebTestDelegate::setLocale):
355         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
356         (WebTestRunner::TestRunner::TestRunner):
357         (WebTestRunner::TestRunner::reset):
358         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
359         (WebTestRunner):
360         (WebTestRunner::TestRunner::setWindowIsKey):
361         (WebTestRunner::TestRunner::pathToLocalResource):
362         (WebTestRunner::TestRunner::setBackingScaleFactor):
363         (WebTestRunner::TestRunner::setPOSIXLocale):
364         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
365         (WebTestRunner::TestRunner::taskList):
366         (TestRunner):
367         * DumpRenderTree/chromium/WebViewHost.cpp:
368         (WebViewHost::setDeviceScaleFactor):
369         (WebViewHost::setFocus):
370         (WebViewHost::setAcceptAllCookies):
371         (WebViewHost::pathToLocalResource):
372         (WebViewHost::setLocale):
373         * DumpRenderTree/chromium/WebViewHost.h:
374         (WebViewHost):
375
376 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
377
378         Tests with WontFix expectation are (indirectly) skipped
379         https://bugs.webkit.org/show_bug.cgi?id=105860
380
381         Reviewed by Dirk Pranke.
382
383         Only skip the WontFix expectation if there are no other layout test
384         expectations (like Failure, ImageOnlyFailure) listed for the test.
385         This makes it possible to run an expected failure for which there
386         is no reason or interest to fix. There are some ports that would like
387         to exercise this behavior as well as specific test cases that should use
388         such expectations.
389
390         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
391         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
392         WONTFIX test if there are no expectations listed. The warning is adjusted
393         to reflect the new behavior.
394         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
395         and adjust test cases for these changes.
396         (ExpectationSyntaxTests.test_wontfix):
397         (SemanticTests.test_skip_and_wontfix):
398
399 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
400
401         [chromium] add title text direction attribute to TestRunner
402         https://bugs.webkit.org/show_bug.cgi?id=106907
403
404         Reviewed by Adam Barth.
405
406         * DumpRenderTree/chromium/DRTTestRunner.cpp:
407         (DRTTestRunner::DRTTestRunner):
408         (DRTTestRunner::reset):
409         * DumpRenderTree/chromium/DRTTestRunner.h:
410         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
411         (WebTestRunner::WebTestRunner::setTitleTextDirection):
412         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
413         (WebTestRunner::TestRunner::TestRunner):
414         (WebTestRunner::TestRunner::reset):
415         (WebTestRunner::TestRunner::setTitleTextDirection):
416         (WebTestRunner):
417         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
418         (TestRunner):
419         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
420         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
421         * DumpRenderTree/chromium/WebViewHost.cpp:
422         (WebViewHost::didReceiveTitle):
423
424 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
425
426         nrwt: change the default # of locked shards on chromium_win to 1
427         https://bugs.webkit.org/show_bug.cgi?id=106938
428
429         Reviewed by Eric Seidel.
430
431         It looks like LigHTTPd might be buggy or unstable if we are
432         running multiple http tests in parallel; see
433         http://code.google.com/p/chromium/issues/detail?id=169530 for more
434         context as well. This change will stop running http tests in parallel
435         and we can see if this fixes things.
436
437         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
438         (ChromiumWinPort.default_max_locked_shards):
439         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
440         (ChromiumWinTest.test_path_to_image_diff):
441         (ChromiumWinTest):
442         (ChromiumWinTest.test_default_max_locked_shards):
443
444 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
445
446         [chromium] move WebDatabase related methods to TestRunner library
447         https://bugs.webkit.org/show_bug.cgi?id=106905
448
449         Reviewed by Adam Barth.
450
451         * DumpRenderTree/chromium/DRTTestRunner.cpp:
452         (DRTTestRunner::DRTTestRunner):
453         (DRTTestRunner::reset):
454         * DumpRenderTree/chromium/DRTTestRunner.h:
455         (DRTTestRunner):
456         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
457         (WebTestRunner::WebTestDelegate::clearAllDatabases):
458         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
459         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
460         (WebTestRunner::TestRunner::TestRunner):
461         (WebTestRunner::TestRunner::reset):
462         (WebTestRunner::TestRunner::clearAllDatabases):
463         (WebTestRunner):
464         (WebTestRunner::TestRunner::setDatabaseQuota):
465         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
466         (TestRunner):
467         * DumpRenderTree/chromium/WebViewHost.cpp:
468         (WebViewHost::clearAllDatabases):
469         (WebViewHost::setDatabaseQuota):
470         * DumpRenderTree/chromium/WebViewHost.h:
471         (WebViewHost):
472
473 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
474
475         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
476         functionality match the name.
477         https://bugs.webkit.org/show_bug.cgi?id=106870
478
479         Reviewed by Adam Barth.
480
481         * Scripts/webkitpy/tool/commands/download.py:
482         (Clean):
483         (Update):
484         (Build):
485         (BuildAndTest):
486         (CheckStyle):
487         (BuildAttachment):
488         (BuildAndTestAttachment):
489         (AbstractPatchApplyingCommand):
490         (ApplyWatchList):
491         (AbstractPatchLandingCommand):
492         (CreateRollout):
493         * Scripts/webkitpy/tool/steps/__init__.py:
494         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
495         (CleanWorkingDirectory.options):
496         (CleanWorkingDirectory.run):
497         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
498         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
499         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
500
501 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
502
503         [Autotools] Add support for WebKit2-only builds
504         https://bugs.webkit.org/show_bug.cgi?id=106889
505
506         Reviewed by Gustavo Noronha Silva.
507
508         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
509         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
510         building the GTK port through build-webkit.
511         * Scripts/webkitdirs.pm:
512         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
513         arguments when not building WebKit1.
514         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
515         through the Autotools build system.
516
517 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
518
519         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
520         https://bugs.webkit.org/show_bug.cgi?id=106197
521
522         Reviewed by Martin Robinson.
523
524         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
525         features. Enable them on GTK, meaning they will be enabled in development builds
526         (i.e. when building with build-webkit).
527
528 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
529
530         [GTK] Enable CSS Image Resolution feature
531         https://bugs.webkit.org/show_bug.cgi?id=99038
532
533         Reviewed by Gustavo Noronha Silva.
534
535         Enable the CSS Image Resolution feature for the development
536         builds of the GTK port.
537
538         * Scripts/webkitperl/FeatureList.pm:
539
540 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
541
542         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
543         https://bugs.webkit.org/show_bug.cgi?id=106579
544
545         Reviewed by Gustavo Noronha Silva.
546
547         The --enable-unstable-features flag is not required to be passed anymore
548         to the configure script as it was removed in r138252.
549
550         * Scripts/webkitdirs.pm:
551         (buildAutotoolsProject):
552
553 2013-01-15  Tony Chang  <tony@chromium.org>
554
555         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
556
557         * Scripts/webkitpy/layout_tests/servers/http_server.py:
558         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
559         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
560         (TestHttpServer.test_win32_start_and_stop):
561
562 2013-01-15  Joshua Bell  <jsbell@chromium.org>
563
564         Unreviewed. Adding Michael Pruett as contributor.
565
566         * Scripts/webkitpy/common/config/committers.py:
567
568 2013-01-15  Victor Carbune  <victor@rosedu.org>
569
570         Unreviewed. Update my email addresses.
571
572         * Scripts/webkitpy/common/config/committers.py:
573
574 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
575
576         [GTK] Waiting on the gdb process will lead to deadlock
577         https://bugs.webkit.org/show_bug.cgi?id=106906
578
579         Reviewed by Philippe Normand.
580
581         Use communicate() rather than wait() on the Popen object that's running the gdb
582         command. This avoids the deadlock that occurs on the GTK builders.
583
584         * Scripts/webkitpy/layout_tests/port/gtk.py:
585         (GtkPort._get_gdb_output):
586
587 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
588
589         [GTK] Limit the number of frames printed out when backtracing with gdb
590         https://bugs.webkit.org/show_bug.cgi?id=106901
591
592         Reviewed by Philippe Normand.
593
594         Printing an unlimited number of frames when dumping the gdb backtracing
595         output can cause timeouts in the builders. This patch limits the number
596         of frames that are printed out to 1024.
597
598         * Scripts/webkitpy/layout_tests/port/gtk.py:
599         (GtkPort._get_gdb_output):
600
601 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
602
603         [Qt] Fix ImageDiff's image format conversion
604         https://bugs.webkit.org/show_bug.cgi?id=106880
605
606         Reviewed by Csaba Osztrogonác.
607
608         Besides actually doing the conversion this also silences the suspicious warning:
609         "ignoring return value of function declared with warn_unused_result attribute".
610
611         * ImageDiff/qt/ImageDiff.cpp:
612         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
613         copy of the image in the given format and does not alter the image itself.
614
615 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
616
617         [chromium] move remaining methods that just set a boolean flag to TestRunner library
618         https://bugs.webkit.org/show_bug.cgi?id=106823
619
620         Reviewed by Darin Fisher.
621
622         * DumpRenderTree/chromium/DRTTestRunner.cpp:
623         (DRTTestRunner::DRTTestRunner):
624         (DRTTestRunner::reset):
625         * DumpRenderTree/chromium/DRTTestRunner.h:
626         (DRTTestRunner):
627         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
628         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
629         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
630         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
631         (WebTestRunner::WebTestRunner::testRepaint):
632         (WebTestRunner::WebTestRunner::sweepHorizontally):
633         (WebTestRunner::WebTestRunner::isPrinting):
634         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
635         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
636         (WebTestRunner::TestRunner::TestRunner):
637         (WebTestRunner::TestRunner::reset):
638         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
639         (WebTestRunner):
640         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
641         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
642         (WebTestRunner::TestRunner::testRepaint):
643         (WebTestRunner::TestRunner::sweepHorizontally):
644         (WebTestRunner::TestRunner::isPrinting):
645         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
646         (WebTestRunner::TestRunner::dumpBackForwardList):
647         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
648         (WebTestRunner::TestRunner::dumpSelectionRect):
649         (WebTestRunner::TestRunner::repaintSweepHorizontally):
650         (WebTestRunner::TestRunner::setPrinting):
651         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
652         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
653         (TestRunner):
654
655 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
656
657         nrwt: stub out show_results_html for mock ports
658         https://bugs.webkit.org/show_bug.cgi?id=106848
659
660         Reviewed by Ojan Vafai.
661
662         We were accidentally using the underlying ports'
663         show_results_html_file() implementation, which would, unsurprisingly,
664         fail in many cases (e.g., running mock-efl on the mac).
665
666         No test added since we don't generally add tests for the mock
667         implementation.
668
669         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
670         (MockDRTPort.show_results_html_file):
671
672 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
673
674         Changing clean_working_directory/clean_local_commits and related
675         functions to have consistent naming.
676
677         https://bugs.webkit.org/show_bug.cgi?id=104198
678
679         Reviewed by Adam Barth.
680
681         * Scripts/webkitpy/common/checkout/scm/git.py:
682         * Scripts/webkitpy/common/checkout/scm/scm.py:
683         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
684         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
685         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
686         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
687
688 2013-01-14  Alan Cutter  <alancutter@chromium.org>
689
690         Fix EWS GCE build scripts to detect which zone is available
691         https://bugs.webkit.org/show_bug.cgi?id=106524
692
693         Reviewed by Adam Barth.
694
695         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
696         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
697         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
698         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
699
700 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
701
702         Adding an error string to AmbiguousCommitError.
703         https://bugs.webkit.org/show_bug.cgi?id=106846
704
705         Reviewed by Adam Barth.
706
707         * Scripts/webkitpy/common/checkout/scm/git.py:
708         (AmbiguousCommitError.__init__):
709
710 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
711
712         kill whole lighttpd process tree for chromium win
713         https://bugs.webkit.org/show_bug.cgi?id=106838
714
715         Reviewed by Tony Chang.
716
717         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
718         I think a test is causing a httpd server child process to wedge and
719         killing the parent httpd server process isn't sufficient to ensure
720         that the children are also killed.
721
722         * Scripts/webkitpy/layout_tests/servers/http_server.py:
723         (Lighttpd._check_and_kill):
724         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
725         (TestHttpServer.test_start_cmd):
726         (TestHttpServer):
727         (TestHttpServer.test_win32_start_and_stop):
728         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
729         (TestHttpServer.test_win32_start_and_stop.mock_returns):
730         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
731
732 2013-01-14  Nico Weber  <thakis@chromium.org>
733
734         [chromium] Enable `update-webkit --chromium --ninja` on windows
735         https://bugs.webkit.org/show_bug.cgi?id=106836
736
737         Reviewed by Eric Seidel.
738
739         After running this, build-webkit --chromium will use ninja to build.
740         Apparently there are some minor issues with that still, so it's
741         not quite ready for use yet.
742
743         * Scripts/webkitdirs.pm:
744         (determineIsChromiumNinja):
745         (buildChromium):
746
747 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
748
749         nrwt: use the same search path for baselines and TestExpectations on apple mac
750         https://bugs.webkit.org/show_bug.cgi?id=105599
751
752         Reviewed by Ryosuke Niwa.
753
754         Bug 105583 revealed some confusion due to the fact that the Apple
755         Mac port used a different list of directories to search for baselines
756         and TestExpectations files (actually, pretty much every port does).
757
758         It seems like a good idea to use the same list for both by default, but
759         making this happen will affect every port in slightly different ways, so
760         we'll try this on the Apple Mac port first.
761
762         Note that the effective changes for this are that:
763         1) The apple mac port will look in platform/wk2 for baselines where
764         it didn't before (it will look after looking in mac-wk2 but before
765         the non-wk2 dirs)
766         2) The apple mac-snowleopard port will use the expectations in
767         mac-lion as well as the expectations in mac-snowleopard, although
768         I'm not even sure if mac-snowleopard is still supported ...
769
770         * Scripts/webkitpy/layout_tests/port/mac.py:
771         (MacPort.default_baseline_search_path):
772         (MacPort.expectations_files):
773         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
774         (test_baseline_search_path):
775
776 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
777
778         AX: Need to implement ColorWellRole
779         https://bugs.webkit.org/show_bug.cgi?id=106756
780
781         Reviewed by Chris Fleizach.
782
783         Returns a string representation of the value of a color
784         when the role is Color Well, to make it easy to write layout
785         tests for color controls.
786
787         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
788
789 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
790
791         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
792         https://bugs.webkit.org/show_bug.cgi?id=106682
793
794         Reviewed by Chris Fleizach.
795
796         Modify Chromium's DRT implementation of intValue to return a
797         different value depending on the role.
798
799         There are actually platform-specific differences in what should
800         be returned in the "value" of an object, so Chromium normally keeps
801         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
802         but this is a fine simplification to make cross-platform tests easier.
803
804         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
805         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
806
807 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
808
809         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
810         https://bugs.webkit.org/show_bug.cgi?id=106785
811
812         Reviewed by Adam Barth.
813
814         * DumpRenderTree/chromium/DRTTestRunner.cpp:
815         (DRTTestRunner::DRTTestRunner):
816         (DRTTestRunner::reset):
817         * DumpRenderTree/chromium/DRTTestRunner.h:
818         (DRTTestRunner):
819         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
820         (WebTestProxyBase):
821         (WebTestRunner::WebTestProxy::setStatusText):
822         (WebTestRunner::WebTestProxy::didStopLoading):
823         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
824         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
825         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
826         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
827         (WebTestRunner::TestRunner::TestRunner):
828         (WebTestRunner::TestRunner::reset):
829         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
830         (WebTestRunner):
831         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
832         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
833         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
834         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
835         (TestRunner):
836         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
837         (WebTestRunner::WebTestProxyBase::setStatusText):
838         (WebTestRunner):
839         (WebTestRunner::WebTestProxyBase::didStopLoading):
840         * DumpRenderTree/chromium/WebViewHost.cpp:
841         (WebViewHost::didStopLoading):
842         * DumpRenderTree/chromium/WebViewHost.h:
843         (WebViewHost):
844
845 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
846
847         Web Inspector: devtools front-end doesn't have focus in TestShell
848         https://bugs.webkit.org/show_bug.cgi?id=106778
849
850         Reviewed by Pavel Feldman.
851
852         Focus devTools window after loadURL method.
853
854         * DumpRenderTree/chromium/TestShell.cpp:
855         (TestShell::runFileTest):
856
857 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
858
859         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
860         https://bugs.webkit.org/show_bug.cgi?id=106573
861
862         Reviewed by Philippe Normand.
863
864         Similarly to what's been described in bug 106569, we're building
865         from release tarballs, so there's no reason to regenerate the
866         autoconf-related stuff with autogen.sh, especially since we might
867         run into trouble with automake 1.13 and deprecated macros.
868
869         * efl/jhbuild.modules:
870
871 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
872
873         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
874         https://bugs.webkit.org/show_bug.cgi?id=104909
875
876         Reviewed by Simon Hausmann.
877
878         To be able to build redistribuable binary packages, Qt's configure switches
879         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
880         dynamically link to optional system libraries.
881         QtWebKit is doing its own configure checks for those libraries, thus adding a
882         runtime dependency that might not be fulfilled if the packager's machine had
883         those libraries while the user's machine won't.
884
885         Since in most cases where WebKit will want to use those system libraries, Qt will
886         also be using them, remove these configure tests from WebKit.
887
888         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
889         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
890         * qmake/config.tests/libpng/libpng.cpp: Removed.
891         * qmake/config.tests/libpng/libpng.pro: Removed.
892         * qmake/mkspecs/features/features.prf:
893
894 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
895
896         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
897         https://bugs.webkit.org/show_bug.cgi?id=106574
898
899         Reviewed by Laszlo Gombos.
900
901         Rely on a more recent stable release, which includes support for
902         Lua 5.2 in Edje and other assorted minor fixes.
903
904         While here, also use the "configure" script to build the libraries
905         instead of relying on autogen.sh, which is not really needed with
906         a release tarball and may have problems with automake 1.13.
907
908         * efl/jhbuild.modules:
909
910 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
911
912         Web Inspector: fix DRT to deliver simulated events to devtools front-end
913         https://bugs.webkit.org/show_bug.cgi?id=106650
914
915         Reviewed by Pavel Feldman.
916
917         Add separated m_devToolsTestInterfaces object to testShell which is
918         bind to devTools webview.
919
920         * DumpRenderTree/chromium/TestShell.cpp:
921         (TestShell::initialize):
922         (TestShell::createMainWindow):
923         (TestShell::~TestShell):
924         (TestShell::showDevTools):
925         (TestShell::resetTestController):
926         (TestShell::bindJSObjectsToWindow):
927         (TestShell::createNewWindow):
928         * DumpRenderTree/chromium/TestShell.h:
929         (TestShell):
930
931 2013-01-14  Alan Cutter  <alancutter@chromium.org>
932
933         Sheriffbot command aliases need test cases
934         https://bugs.webkit.org/show_bug.cgi?id=106754
935
936         Reviewed by Eric Seidel.
937
938         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
939         (SheriffBotTest.test_command_aliases):
940
941 2013-01-13  Alan Cutter  <alancutter@chromium.org>
942
943         Allow users to misspell the "sheriffs" command in sheriffbot
944         https://bugs.webkit.org/show_bug.cgi?id=106628
945
946         Reviewed by Steve Block.
947
948         * Scripts/webkitpy/tool/bot/irc_command.py:
949
950 2013-01-13  Alan Cutter  <alancutter@chromium.org>
951
952         Make "gardeners" an alias for "sheriffs" in sherrifbot
953         https://bugs.webkit.org/show_bug.cgi?id=106627
954
955         Reviewed by Eric Seidel.
956
957         * Scripts/webkitpy/tool/bot/irc_command.py:
958
959 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
960
961         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
962         https://bugs.webkit.org/show_bug.cgi?id=105380
963
964         Reviewed by Eric Seidel.
965
966         Fix a regression introduced in r137692 where we were double-encoding
967         the arguments to popen(); this was only an issue on windows, where
968         we would try to encode something to mbcs, then try to encode it
969         to unicode as if the input as ascii.
970
971         * Scripts/webkitpy/common/system/executive.py:
972         (Executive.run_command):
973
974 2013-01-13  Alan Cutter  <alancutter@chromium.org>
975
976         State who told sheriffbot to roll the Chromium deps and to what revision
977         https://bugs.webkit.org/show_bug.cgi?id=106626
978
979         Reviewed by Eric Seidel.
980
981         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
982
983         * Scripts/webkitpy/tool/bot/irc_command.py:
984         (RollChromiumDEPS._expand_irc_nickname):
985         (RollChromiumDEPS.execute):
986         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
987         (IRCCommandTest.test_roll_chromium_deps):
988         * Scripts/webkitpy/tool/bot/sheriff.py:
989         (Sheriff.post_chromium_deps_roll):
990         * Scripts/webkitpy/tool/commands/roll.py:
991         (RollChromiumDEPS._prepare_state):
992         (PostChromiumDEPSRoll):
993         (PostChromiumDEPSRoll._prepare_state):
994         * Scripts/webkitpy/tool/commands/roll_unittest.py:
995         (PostRollCommandsTest.test_prepare_state):
996         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
997         (PrepareChangeLogForDEPSRoll.run):
998
999 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1000
1001         Add Alan Cutter as contributor
1002         https://bugs.webkit.org/show_bug.cgi?id=106747
1003
1004         Reviewed by Eric Seidel.
1005
1006         * Scripts/webkitpy/common/config/committers.py:
1007
1008 2013-01-13  Jonathan Liu  <net147@gmail.com>
1009
1010         Fix CONFIG missing link_pkgconfig on Windows
1011         https://bugs.webkit.org/show_bug.cgi?id=106647
1012
1013         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
1014         properly on Windows because they are added to PKGCONFIG but
1015         CONFIG does not contain link_pkgconfig.
1016
1017         This is because link_pkgconfig is added in unix/default_pre.prf
1018         which is only used for UNIX platforms. To fix this, move it to
1019         the general default_pre.prf.
1020
1021         Reviewed by Simon Hausmann.
1022
1023         * qmake/mkspecs/features/default_pre.prf:
1024         * qmake/mkspecs/features/unix/default_pre.prf:
1025
1026 2013-01-12  Nico Weber  <thakis@chromium.org>
1027
1028         nrwt/chromium: Don't prefer chromium over webkit build directories
1029         https://bugs.webkit.org/show_bug.cgi?id=105597
1030
1031         Reviewed by Dirk Pranke.
1032
1033         Rely on the new timestamp logic instead. Requested by dpranke in
1034         https://bugs.webkit.org/show_bug.cgi?id=105498
1035
1036         * Scripts/webkitpy/layout_tests/port/chromium.py:
1037         (ChromiumPort._static_build_path):
1038         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1039         (ChromiumLinuxPortTest.test_build_path):
1040         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1041         (ChromiumMacPortTest.test_build_path):
1042         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1043         (ChromiumWinTest.test_build_path):
1044
1045 2013-01-12  Nico Weber  <thakis@chromium.org>
1046
1047         Use ninja by default on Linux for build-webkit --chromium, bot edition
1048         https://bugs.webkit.org/show_bug.cgi?id=104434
1049
1050         Reviewed by Eric Seidel.
1051
1052         r139557 changed update-webkit to pick ninja by default on linux, but
1053         the bots run update-webkit-chromium directly so they didn't see this.
1054         Move the default for ninja into update-webkit-chromium so that it's
1055         picked up by the bots, and let update-webkit forward non-default
1056         options to there.
1057
1058         This way, the default is in one place only and both developers (who
1059         usually use update-webkit which then shells out to
1060         updat-webkit-chromium) and bots (which use update-webkit-chromium
1061         directly) see the same behavior.
1062
1063         * Scripts/update-webkit:
1064         * Scripts/update-webkit-chromium:
1065
1066 2013-01-12  Nico Weber  <thakis@chromium.org>
1067
1068         Make ninja the default build system on Linux for build-webkit --chromium
1069         https://bugs.webkit.org/show_bug.cgi?id=104434
1070
1071         Reviewed by Eric Seidel.
1072
1073         * Scripts/update-webkit:
1074
1075 2013-01-12  Alan Cutter  <alancutter@chromium.org>
1076
1077         Migrate the remaining bots in EC2 to Google Compute Engine
1078         https://bugs.webkit.org/show_bug.cgi?id=106005
1079
1080         Reviewed by Eric Seidel.
1081
1082         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
1083
1084         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
1085         * EWSTools/boot.sh:
1086         * EWSTools/build-repo.sh:
1087         * EWSTools/start-queue.sh:
1088
1089 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
1090
1091         [chromium] move inspector related methods to TestRunner library
1092         https://bugs.webkit.org/show_bug.cgi?id=106654
1093
1094         Reviewed by Adam Barth.
1095
1096         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1097         (DRTTestRunner::DRTTestRunner):
1098         * DumpRenderTree/chromium/DRTTestRunner.h:
1099         (DRTTestRunner):
1100         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1101         (WebTestRunner::WebTestDelegate::showDevTools):
1102         (WebTestRunner::WebTestDelegate::closeDevTools):
1103         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
1104         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1105         (WebTestRunner::TestRunner::TestRunner):
1106         (WebTestRunner::TestRunner::showWebInspector):
1107         (WebTestRunner):
1108         (WebTestRunner::TestRunner::closeWebInspector):
1109         (WebTestRunner::TestRunner::evaluateInWebInspector):
1110         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1111         (TestRunner):
1112         * DumpRenderTree/chromium/WebViewHost.cpp:
1113         (WebViewHost::showDevTools):
1114         (WebViewHost::closeDevTools):
1115         (WebViewHost::evaluateInWebInspector):
1116         * DumpRenderTree/chromium/WebViewHost.h:
1117         (WebViewHost):
1118
1119 2013-01-11  Julie Parent  <jparent@chromium.org>
1120
1121         Builder should not be a valid parameter for stats dashboard
1122         https://bugs.webkit.org/show_bug.cgi?id=106698
1123
1124         Reviewed by Dirk Pranke.
1125         
1126         Since builder is a dashboard specific parameter, dashboard_base
1127         should not be handling it in handleValidHashParameterWrapper, rather,
1128         each specific dashboard should in its handleValidHashParameter function.
1129     
1130         Note that the FIXME in dashboard_base about this was actually wrong -
1131         we don't want to move it to g_crossDashboardState, because it isn't
1132         actually cross dashboard state.
1133         
1134         In fact, flakiness and treemap have the code in 
1135         handleValidHashParameter, but it is currently dead code because 
1136         dashboard_base gets to it first.
1137         
1138         Added the proper handling to timeline_explorer, since builder is
1139         valid there.
1140
1141         * TestResultServer/static-dashboards/dashboard_base.js:
1142         * TestResultServer/static-dashboards/timeline_explorer.html:
1143
1144 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1145
1146         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
1147         https://bugs.webkit.org/show_bug.cgi?id=106688
1148
1149         Reviewed by Eric Seidel.
1150
1151         Update the regular expression used to strip the garbage at the beginning.
1152
1153         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1154         (RunWebKitTests.nrwt_log_message_regexp):
1155
1156 2013-01-11  Pratik Solanki  <psolanki@apple.com>
1157
1158         TestRunner leaks when running tests
1159         https://bugs.webkit.org/show_bug.cgi?id=106683
1160
1161         Reviewed by Simon Fraser.
1162
1163         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
1164         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
1165         tests.
1166
1167         * DumpRenderTree/TestRunner.cpp:
1168         (TestRunner::makeWindowObject):
1169
1170 2013-01-11  Julie Parent  <jparent@chromium.org>
1171
1172         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
1173         https://bugs.webkit.org/show_bug.cgi?id=106247
1174
1175         Old code nulled out the loader instance when it completed loading and
1176         then later used the fact that it was null to determine if it had loaded
1177         or not.  This is not only unintuitive, but it also prevents using the
1178         loader object later on.
1179         
1180         Added new method, used it, added unit test for it.
1181         
1182         Reviewed by Dirk Pranke.
1183
1184         * TestResultServer/static-dashboards/dashboard_base.js:
1185         (resourceLoadingComplete):
1186         (handleLocationChange):
1187         * TestResultServer/static-dashboards/loader.js:
1188         (.):
1189         * TestResultServer/static-dashboards/loader_unittests.js:
1190
1191 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1192
1193         Try CRLF to LF change in r139407 again.
1194
1195         * BuildSlaveSupport/delete-stale-build-files:
1196         (main):
1197         (webkitBuildDirectory):
1198         * BuildSlaveSupport/kill-old-processes:
1199         (main):
1200
1201 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1202
1203         [GTK] Disable the unit tests timeout when running from make check
1204         https://bugs.webkit.org/show_bug.cgi?id=106670
1205
1206         Reviewed by Philippe Normand.
1207
1208         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
1209
1210 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1211
1212         Yet another unreviewed fix after r139431.
1213
1214         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
1215         the correct order.
1216
1217 2013-01-11  Dan Carney  <dcarney@google.com>
1218
1219         [chromium] move some whitespace and resize related methods to TestRunner library
1220         https://bugs.webkit.org/show_bug.cgi?id=106655
1221
1222         Reviewed by Jochen Eisinger.
1223
1224         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1225         (DRTTestRunner::DRTTestRunner):
1226         * DumpRenderTree/chromium/DRTTestRunner.h:
1227         (DRTTestRunner):
1228         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1229         (WebKit):
1230         (WebTestRunner::WebTestDelegate::setClientWindowRect):
1231         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
1232         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
1233         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1234         (WebTestRunner::TestRunner::TestRunner):
1235         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
1236         (WebTestRunner):
1237         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
1238         (WebTestRunner::TestRunner::enableAutoResizeMode):
1239         (WebTestRunner::TestRunner::disableAutoResizeMode):
1240         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1241         (TestRunner):
1242         * DumpRenderTree/chromium/WebViewHost.cpp:
1243         (WebViewHost::setClientWindowRect):
1244         * DumpRenderTree/chromium/WebViewHost.h:
1245         (WebViewHost):
1246
1247 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1248
1249         Unreviewed. Update my e-mail addresses.
1250
1251         * Scripts/webkitpy/common/config/committers.py:
1252
1253 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1254
1255         Another unreviewed fix after r139431.
1256
1257         In a way, this is also a generic bug fix, since previously isEfl()
1258         would fail when called from run-efl-tests and we thus did not use
1259         jhbuild to run our tests. This now resulted in us calling
1260         "jhbuild-wrapper run" without specifying a platform.
1261
1262         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
1263         to work.
1264
1265 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1266
1267         [Qt][WK1] Web Audio support
1268         https://bugs.webkit.org/show_bug.cgi?id=106651
1269
1270         Reviewed by Jocelyn Turcotte.
1271
1272         Implements support for dumping audio data in DumpRenderTree.
1273
1274         Adds WebAudio to toggleable features in QtTestBrowser.
1275
1276         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
1277         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
1278
1279         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1280         (WebCore::DumpRenderTree::dump):
1281         * DumpRenderTree/qt/TestRunnerQt.cpp:
1282         (TestRunner::reset):
1283         (TestRunner::overridePreference):
1284         (TestRunner::setAudioData):
1285         * DumpRenderTree/qt/TestRunnerQt.h:
1286         (TestRunner::shouldDumpAsAudio):
1287         (TestRunner::audioData):
1288         (TestRunner):
1289         * QtTestBrowser/launcherwindow.cpp:
1290         (LauncherWindow::applyPrefs):
1291         (LauncherWindow::createChrome):
1292         (LauncherWindow::toggleWebAudio):
1293         * QtTestBrowser/launcherwindow.h:
1294         (WindowOptions::WindowOptions):
1295         (WindowOptions):
1296         (LauncherWindow):
1297         * qmake/mkspecs/features/features.prf:
1298         * qmake/mkspecs/features/features.pri:
1299
1300 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1301
1302         Unreviewed jhbuild-related fix after r139431.
1303
1304         * Scripts/webkitpy/layout_tests/port/efl.py:
1305         (EflPort.__init__): Pass a string to set_option_default(), since
1306         shlex.split() will be called on it later.
1307
1308 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
1309
1310         Unreviewed typo fixes after r139431.
1311
1312         * Scripts/run-javascriptcore-tests:
1313
1314 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1315
1316         [jhbuild] Remove the "run-with-jhbuild" scripts.
1317         https://bugs.webkit.org/show_bug.cgi?id=106572
1318
1319         Reviewed by Martin Robinson.
1320
1321         Both ports which use jhbuild were mostly duplicating the
1322         `run-with-jhbuild' script in their own directories for no clear reason.
1323
1324         The script itself was just a thin wrapper around the `jhbuild-wrapper',
1325         so just start using that directly and get rid of a useless middle man.
1326
1327         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
1328         instead.
1329
1330         * Scripts/run-javascriptcore-tests:
1331         * Scripts/run-launcher:
1332         * Scripts/webkitdirs.pm:
1333         (runAutogenForAutotoolsProjectIfNecessary):
1334         (buildAutotoolsProject):
1335         (jhbuildWrapperPrefixIfNeeded):
1336         (generateBuildSystemFromCMakeProject):
1337         (buildCMakeGeneratedProject):
1338         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1339         (run):
1340         * Scripts/webkitpy/layout_tests/port/efl.py:
1341         (EflPort.__init__):
1342         (EflPort._image_diff_command):
1343         * efl/run-with-jhbuild: Removed.
1344         * gtk/run-with-jhbuild: Removed.
1345
1346 2013-01-11  Alan Cutter  <alancutter@chromium.org>
1347
1348         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
1349         https://bugs.webkit.org/show_bug.cgi?id=106636
1350
1351         Reviewed by Adam Barth.
1352
1353         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
1354
1355         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1356         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1357         * EWSTools/screen-config:
1358         * EWSTools/start-queue.sh:
1359
1360 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1361
1362         kill-old-processes and delete-stale-build-files use CRLF linebreaks
1363         https://bugs.webkit.org/show_bug.cgi?id=106622
1364
1365         Reviewed by Simon Fraser.
1366
1367         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
1368         Also escape clang\+\+ correctly in kill-old-processes.
1369
1370         * BuildSlaveSupport/delete-stale-build-files:
1371         * BuildSlaveSupport/kill-old-processes:
1372
1373 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1374
1375         Build fix after r139357. It was missing a comma.
1376
1377         * QueueStatusServer/model/queues.py:
1378         (Queue):
1379
1380 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1381
1382         Fixing AuthenticationError when running test-webkitpy as a non-committer.
1383         https://bugs.webkit.org/show_bug.cgi?id=106420
1384
1385         Reviewed by Eric Seidel.
1386
1387         * Scripts/webkitpy/common/checkout/scm/git.py:
1388         (Git.push_local_commits_to_server):
1389         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1390         * Scripts/webkitpy/common/checkout/scm/svn.py:
1391         (SVNRepository):
1392         (SVNRepository.has_authorization_for_realm):
1393
1394 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
1395
1396         [EFL][jhbuild] Use tarballs for gstreamer instead of git
1397         https://bugs.webkit.org/show_bug.cgi?id=106552
1398
1399         Reviewed by Laszlo Gombos.
1400
1401         Use tarballs for gstreamer instead of git in EFL's jhbuild
1402         to work around intermittent network issues on our build
1403         bots. Tarballs are fully cached and require no network
1404         operation if their checksum matches.
1405
1406         * efl/jhbuild.modules:
1407
1408 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1409
1410         Add Mac WK2 EWS bots
1411         https://bugs.webkit.org/show_bug.cgi?id=106590
1412
1413         Reviewed by Adam Barth.
1414
1415         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
1416         Also add a deprecated MacWK2Port class.
1417
1418         * QueueStatusServer/model/queues.py:
1419         (Queue):
1420         * Scripts/webkitpy/common/config/ports.py:
1421         (DeprecatedPort.port):
1422         (MacWK2Port):
1423         (MacWK2Port.run_webkit_tests_command):
1424         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1425         (MacEWS):
1426         (MacWK2EWS):
1427         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1428         (_test_ewses):
1429
1430 2013-01-10  Dan Carney  <dcarney@google.com>
1431
1432         [chromium] move webpermissionclient related methods to TestRunner library
1433         https://bugs.webkit.org/show_bug.cgi?id=106548
1434
1435         Reviewed by Jochen Eisinger.
1436
1437         * DumpRenderTree/DumpRenderTree.gypi:
1438         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1439         (DRTTestRunner::DRTTestRunner):
1440         (DRTTestRunner::reset):
1441         * DumpRenderTree/chromium/DRTTestRunner.h:
1442         (DRTTestRunner):
1443         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1444         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
1445         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1446         (WebKit):
1447         (WebTestRunner::WebTestRunner::webPermissions):
1448         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1449         (WebTestRunner::TestRunner::TestRunner):
1450         (WebTestRunner::TestRunner::setDelegate):
1451         (WebTestRunner):
1452         (WebTestRunner::TestRunner::reset):
1453         (WebTestRunner::TestRunner::webPermissions):
1454         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
1455         (WebTestRunner::TestRunner::setImagesAllowed):
1456         (WebTestRunner::TestRunner::setScriptsAllowed):
1457         (WebTestRunner::TestRunner::setStorageAllowed):
1458         (WebTestRunner::TestRunner::setPluginsAllowed):
1459         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
1460         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
1461         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1462         (WebTestRunner):
1463         (TestRunner):
1464         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
1465         (WebTestRunner):
1466         (WebTestRunner::WebPermissions::WebPermissions):
1467         (WebTestRunner::WebPermissions::~WebPermissions):
1468         (WebTestRunner::WebPermissions::allowImage):
1469         (WebTestRunner::WebPermissions::allowScriptFromSource):
1470         (WebTestRunner::WebPermissions::allowStorage):
1471         (WebTestRunner::WebPermissions::allowPlugins):
1472         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
1473         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
1474         (WebTestRunner::WebPermissions::setImagesAllowed):
1475         (WebTestRunner::WebPermissions::setScriptsAllowed):
1476         (WebTestRunner::WebPermissions::setStorageAllowed):
1477         (WebTestRunner::WebPermissions::setPluginsAllowed):
1478         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
1479         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
1480         (WebTestRunner::WebPermissions::setDelegate):
1481         (WebTestRunner::WebPermissions::setDumpCallbacks):
1482         (WebTestRunner::WebPermissions::reset):
1483         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
1484         (WebTestRunner):
1485         (WebPermissions):
1486         * DumpRenderTree/chromium/TestShell.cpp:
1487         (TestShell::initialize):
1488         (TestShell::resetTestController):
1489         (TestShell::createNewWindow):
1490         * DumpRenderTree/chromium/TestShell.h:
1491         (TestShell):
1492         * DumpRenderTree/chromium/WebViewHost.cpp:
1493         (WebViewHost::normalizeLayoutTestURL):
1494         * DumpRenderTree/chromium/WebViewHost.h:
1495         (WebViewHost):
1496
1497 2013-01-10  Alan Cutter  <alancutter@chromium.org>
1498
1499         Split EWS tool cold-boot.sh into modular components
1500         https://bugs.webkit.org/show_bug.cgi?id=106527
1501
1502         Reviewed by Adam Barth.
1503
1504         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
1505         Updated GCE bot build scripts to match.
1506         Unable to test scripts directly as they depend on being in the repository to work!
1507
1508         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1509         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1510         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
1511         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
1512         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
1513
1514 2013-01-10  Julie Parent  <jparent@chromium.org>
1515
1516         Dashboard Cleanup: Do not generate the page if we are about to reload.
1517         https://bugs.webkit.org/show_bug.cgi?id=106584
1518
1519         Reviewed by Dirk Pranke.
1520
1521         Move the logic to determine if we should generate the page into
1522         parseParameters() since that is where we have the knowledge to
1523         determine it, and return that value to handleLocationChange, 
1524         rather than passing the changed parameters back to handleLocationChange
1525         and having it make the decision.
1526         
1527         This is logically equivalent, save one case: when we are about to do
1528         a reload, we know that there is no reason to generate the page.  Old
1529         code was causing an extra page generation in this case.
1530         
1531         * TestResultServer/static-dashboards/dashboard_base.js:
1532         (parseParameters):
1533         (handleLocationChange):
1534
1535 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1536
1537         [jhbuild] Use the "configure" script to build glib
1538         https://bugs.webkit.org/show_bug.cgi?id=106569
1539
1540         Reviewed by Martin Robinson.
1541
1542         So far both EFL and GTK have been using autogen.sh to build glib.
1543         While that does work most of the time, it's not really needed since
1544         we are downloading and building stable releases from tarballs.
1545         Additionally, autogen.sh fails to work with automake 1.13 due to the
1546         usage of some macros that have been removed (this has already been
1547         fixed in glib master).
1548
1549         * efl/jhbuild.modules:
1550         * gtk/jhbuild.modules:
1551
1552 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1553
1554         Changing tests to be consistent and use self.scm rather then recreating the scm object.
1555         (Missed a couple)
1556         https://bugs.webkit.org/show_bug.cgi?id=106536
1557
1558         Reviewed by Eric Seidel.
1559
1560         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1561
1562 2013-01-10  Tony Chang  <tony@chromium.org>
1563
1564         Speed up supplemental dependency computation
1565         https://bugs.webkit.org/show_bug.cgi?id=106503
1566
1567         Reviewed by Adam Barth.
1568
1569         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
1570
1571         * WebKitTestRunner/CMakeLists.txt:
1572
1573 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
1574
1575         Remove the ENABLE_ANIMATION_API feature define occurences
1576         https://bugs.webkit.org/show_bug.cgi?id=106544
1577
1578         Reviewed by Simon Fraser.
1579
1580         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
1581         feature define handling still lingers in various build systems and configurations
1582         but is of no use, so it should be removed.
1583
1584         * Scripts/webkitperl/FeatureList.pm:
1585         * qmake/mkspecs/features/features.pri:
1586
1587 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1588
1589         [GTK] Add support for loading web process extensions
1590         https://bugs.webkit.org/show_bug.cgi?id=105631
1591
1592         Reviewed by Gustavo Noronha Silva.
1593
1594         * MiniBrowser/gtk/GNUmakefile.am:
1595         * MiniBrowser/gtk/main.c:
1596         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
1597         bundle lib from build dir.
1598         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
1599         located in WebProcess/InjectedBundle/API/gtk.
1600         * gtk/generate-gtkdoc:
1601         (get_webkit2_options): Scan also files in
1602         WebProcess/InjectedBundle/API/gtk to generate API docs.
1603         (get_webkit2_options.injected_bundle_src_path): Helper function to
1604         build paths in WebProcess/InjectedBundle/API/gtk.
1605
1606 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1607
1608         [EFL][WK2] Writing immediately to created windows (open) fails
1609         https://bugs.webkit.org/show_bug.cgi?id=105276
1610
1611         Reviewed by Kenneth Rohde Christiansen.
1612
1613         Do not reset 'about:blank' url for the new pages in mini browser.
1614
1615         * MiniBrowser/efl/main.c:
1616         (window_create):
1617
1618 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1619
1620         Changing tests to be consistent and use self.scm rather then recreating the scm object.
1621         https://bugs.webkit.org/show_bug.cgi?id=106536
1622
1623         Reviewed by Eric Seidel.
1624
1625         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1626
1627 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1628
1629         Converting to unittest2 so we can use assertItemsEqual, making tests
1630         not dependent on order of items.
1631         https://bugs.webkit.org/show_bug.cgi?id=106532
1632
1633         Before:
1634         Ran 1733 tests in 38.385s
1635         FAILED (failures=1, errors=22)
1636
1637         After:
1638         Ran 1733 tests in 32.298s
1639         FAILED (failures=0, errors=22)
1640
1641         Reviewed by Eric Seidel.
1642
1643         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1644         * Scripts/webkitpy/thirdparty/__init__.py:
1645         (AutoinstallImportHook._install_unittest2):
1646
1647 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
1648
1649         [EFL] Add gstreamer 1.0.5 to jhbuild
1650         https://bugs.webkit.org/show_bug.cgi?id=106178
1651
1652         Reviewed by Laszlo Gombos.
1653
1654         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
1655
1656         * efl/jhbuild.modules:
1657
1658 2013-01-09  Alan Cutter  <alancutter@chromium.org>
1659
1660         Updated parameters in GCE build scripts so they now work.
1661         https://bugs.webkit.org/show_bug.cgi?id=106523
1662
1663         Reviewed by Adam Barth.
1664
1665         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1666         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1667         * EWSTools/cold-boot.sh:
1668
1669 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
1670
1671         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
1672         https://bugs.webkit.org/show_bug.cgi?id=106520
1673
1674         Reviewed by James Robinson.
1675
1676         Part of a larger refactoring series. See tracking bug 82948.
1677
1678         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1679         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1680
1681 2013-01-09  Julie Parent  <jparent@chromium.org>
1682
1683         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
1684         https://bugs.webkit.org/show_bug.cgi?id=106514
1685
1686         This is old code, as these can no longer get out of sync.
1687         permmaLinkURLHash is generated from currentState, which is set only
1688         from the location.  The commment about how these can get out of sync
1689         refers to a function that no longer exists.
1690         
1691         Reviewed by Dirk Pranke.
1692
1693         * TestResultServer/static-dashboards/dashboard_base.js:
1694         (handleLocationChange):
1695
1696 2013-01-09  Julie Parent  <jparent@chromium.org>
1697
1698         Dashboard Cleanup: Reload the page as soon as we know we need to.
1699         https://bugs.webkit.org/show_bug.cgi?id=106515
1700
1701         No need to continue parsing all of the data once we know that
1702         we need to do a reload.
1703         
1704         Reviewed by Dirk Pranke.
1705
1706         * TestResultServer/static-dashboards/dashboard_base.js:
1707         (parseParameters):
1708
1709 2013-01-09  Eric Seidel  <eric@webkit.org>
1710
1711         run-perf-tests --chromium-android --profile should show symbols for the kernel
1712         https://bugs.webkit.org/show_bug.cgi?id=106498
1713
1714         Reviewed by Adam Barth.
1715
1716         Turns out this was easy, once I finally read the output from "perf report".
1717         It appears there may be a bug in "perf record" on android, as it complains
1718         about not being able to read from /proc/kallsyms even when
1719         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
1720         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
1721         but rather just flip it to 0 long enough to grab the /proc/kallsyms
1722         and then flip it back to whatever the device had.
1723
1724         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
1725         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
1726         to symbol names.  Its world-readable, but will return all 0s if you
1727         don't have permission to see the kernel symbols.  kptr_restrict
1728         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
1729         1 is only a specific group, and 2 is "no one, not even root".
1730         By default kptr_restrict is 2 on Android it seems.
1731         More kptr_restrict docs: http://lwn.net/Articles/420403/
1732
1733         I also took this opportunity to clean up how the perf record command
1734         was built for use/display in AndroidPerf.profile_after_exit and
1735         change to always using long-form names for the arguments (to hopefully help readability).
1736
1737         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1738         (AndroidPerf.__init__):
1739         (profile_after_exit):
1740         (ChromiumAndroidDriver.__init__):
1741         (ChromiumAndroidDriver._update_kallsyms_cache):
1742         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1743
1744 2013-01-09  Julie Parent  <jparent@chromium.org>
1745
1746         Dashboard cleanup: remove dead code.
1747         https://bugs.webkit.org/show_bug.cgi?id=106509
1748
1749         Reviewed by Dirk Pranke.
1750
1751         * TestResultServer/static-dashboards/dashboard_base.js:
1752         (parseParameters):
1753
1754 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
1755
1756         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
1757         https://bugs.webkit.org/show_bug.cgi?id=105638
1758
1759         Reviewed by Martin Robinson.
1760
1761         The test was failing for two reasons:
1762         - AccessibilityRenderObject::correspondingLabelForControlElement() was
1763           not ignoring the ARIA labelled-by property
1764         - AccessibilityController::accessibleElementById() was not implemented
1765
1766         Because getting an element by ID cannot be done in the UIProcess, the
1767         decision was made to expose the element's ID as an accessible attribute
1768         of the object.
1769
1770         In addition, fixing the bug in AccessibilityRenderObject made it possible
1771         to eliminate the Gtk platform-specific expectations for another test.
1772
1773         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1774         (childElementById): Added. Walks the tree looking for the AtkObject
1775         Attribute which exposes the HTML element's ID.
1776         (AccessibilityController::accessibleElementById): Implemented.
1777         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1778         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
1779         when there is no title, as is done with the Mac port.
1780         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1781         (WTR):
1782         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1783         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
1784         Attribute which exposes the HTML element's ID.
1785         (WTR):
1786         (WTR::AccessibilityController::accessibleElementById): Implemented.
1787         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1788         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
1789         even when there is no title, as is done with the Mac port.
1790
1791 2013-01-09  Gregg Tavares  <gman@google.com>
1792
1793         Add Gregg Tavares as a committer
1794         https://bugs.webkit.org/show_bug.cgi?id=106492
1795
1796         Unreviewed.
1797
1798         * Scripts/webkitpy/common/config/committers.py:
1799
1800 2013-01-09  Roger Fong  <roger_fong@apple.com>
1801
1802         Enable seamless iFrames for Windows DRT.
1803         https://bugs.webkit.org/show_bug.cgi?id=106468.
1804
1805         Rubberstamped by Timothy Horton.
1806
1807         * DumpRenderTree/win/DumpRenderTree.cpp:
1808         (resetDefaultsToConsistentValues):
1809
1810 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
1811
1812         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
1813         https://bugs.webkit.org/show_bug.cgi?id=93979
1814
1815         Reviewed by Benjamin Poulain.
1816
1817         Implement eventSender.scheduleAsynchronousKeyDown() in
1818         WebKitTestRunner.
1819
1820         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1821         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1822         (WTR::createKeyDownMessageBody):
1823         (WTR::EventSendingController::keyDown):
1824         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1825         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1826         (EventSendingController):
1827         * WebKitTestRunner/TestController.cpp:
1828         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
1829         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1830         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1831         * WebKitTestRunner/TestController.h:
1832         (TestController):
1833
1834 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
1835
1836         [chromium] move resource load callback dumping to TestRunner library
1837         https://bugs.webkit.org/show_bug.cgi?id=106449
1838
1839         Reviewed by Adam Barth.
1840
1841         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1842         (DRTTestRunner::DRTTestRunner):
1843         (DRTTestRunner::reset):
1844         * DumpRenderTree/chromium/DRTTestRunner.h:
1845         (DRTTestRunner):
1846         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1847         (WebKit):
1848         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
1849         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1850         (WebKit):
1851         (WebTestProxyBase):
1852         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
1853         (WebTestRunner::WebTestProxy::willRequestResource):
1854         (WebTestRunner::WebTestProxy::willSendRequest):
1855         (WebTestRunner::WebTestProxy::didReceiveResponse):
1856         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
1857         (WebTestRunner::WebTestProxy::didFailResourceLoad):
1858         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1859         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
1860         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
1861         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
1862         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1863         (WebTestRunner::TestRunner::TestRunner):
1864         (WebTestRunner::TestRunner::reset):
1865         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
1866         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
1867         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
1868         (WebTestRunner):
1869         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
1870         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
1871         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
1872         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1873         (TestRunner):
1874         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1875         (WebTestRunner::WebTestProxyBase::reset):
1876         (WebTestRunner):
1877         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
1878         (WebTestRunner::WebTestProxyBase::willRequestResource):
1879         (WebTestRunner::WebTestProxyBase::willSendRequest):
1880         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
1881         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
1882         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
1883         * DumpRenderTree/chromium/WebViewHost.cpp:
1884         (WebViewHost::willSendRequest):
1885         (WebViewHost::makeURLErrorDescription):
1886         (WebViewHost::reset):
1887         * DumpRenderTree/chromium/WebViewHost.h:
1888         (WebViewHost):
1889
1890 2013-01-09  Dan Carney  <dcarney@google.com>
1891
1892         [chromium] move dumpcreateview methods to testrunner library
1893         https://bugs.webkit.org/show_bug.cgi?id=106434
1894
1895         Reviewed by Adam Barth.
1896
1897         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1898         (DRTTestRunner::DRTTestRunner):
1899         (DRTTestRunner::reset):
1900         * DumpRenderTree/chromium/DRTTestRunner.h:
1901         (DRTTestRunner):
1902         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1903         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
1904         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1905         (WebTestRunner::TestRunner::TestRunner):
1906         (WebTestRunner::TestRunner::reset):
1907         (WebTestRunner::TestRunner::shouldDumpCreateView):
1908         (WebTestRunner):
1909         (WebTestRunner::TestRunner::dumpCreateView):
1910         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1911         (TestRunner):
1912
1913 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
1914
1915         webkitpy cleanup: Merge additional_comment_text into comment_text
1916         https://bugs.webkit.org/show_bug.cgi?id=106421
1917
1918         Reviewed by Adam Barth.
1919
1920         * Scripts/webkitpy/common/config/committervalidator.py:
1921         (CommitterValidator.reject_patch_from_commit_queue):
1922         (CommitterValidator.reject_patch_from_review_queue):
1923         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1924         (Bugzilla.set_flag_on_attachment):
1925         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1926         (MockBugzilla.set_flag_on_attachment):
1927         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1928         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1929         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
1930         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1931
1932 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1933
1934         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
1935         https://bugs.webkit.org/show_bug.cgi?id=106464
1936
1937         Reviewed by Martin Robinson.
1938
1939         Current version in jhbuild.modules (2.26.0) is giving trouble to
1940         when trying to build WebKitGTK from scratch, due to a segmentation
1941         fault error in gdk-pixbuf-query-loader during the 'make'
1942         phase. Raising the version to 2.26.5 fixes this issue.
1943
1944         * gtk/jhbuild.modules: Version raised, checksums updated.
1945
1946 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
1947
1948         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
1949         https://bugs.webkit.org/show_bug.cgi?id=90968.
1950
1951         Reviewed by Csaba Osztrogonác.
1952
1953         Added functionality in DRT and WTR to use any timeout value while running
1954         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
1955         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
1956         to indicate whether the current port supports setting timeout value
1957         per test (it's False by default; I enabled it only on Qt).
1958         Also corrected a typo in driver.py
1959
1960         * DumpRenderTree/DumpRenderTree.h:
1961         (TestCommand::TestCommand):
1962         (TestCommand):
1963         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1964         (parseInputLine):
1965         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1966         (WebCore::DumpRenderTree::processLine):
1967         * Scripts/webkitpy/layout_tests/port/base.py:
1968         (Port.supports_per_test_timeout):
1969         * Scripts/webkitpy/layout_tests/port/driver.py:
1970         (Driver.run_test):
1971         (Driver._command_from_driver_input):
1972         * Scripts/webkitpy/layout_tests/port/qt.py:
1973         (QtPort.supports_per_test_timeout):
1974         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1975         (WTR::InjectedBundle::InjectedBundle):
1976         (WTR::InjectedBundle::didReceiveMessage):
1977         (WTR::InjectedBundle::beginTesting):
1978         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1979         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1980         (WTR::TestRunner::setCustomTimeout):
1981         (WTR):
1982         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1983         (TestRunner):
1984         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
1985         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1986         * WebKitTestRunner/TestController.cpp:
1987         (WTR::TestController::TestController):
1988         (WTR::TestController::getCustomTimeout):
1989         (WTR):
1990         (WTR::TestCommand::TestCommand):
1991         (TestCommand):
1992         (WTR::parseInputLine):
1993         (WTR::TestController::runTest):
1994         (WTR::TestController::runUntil):
1995         * WebKitTestRunner/TestController.h:
1996         (TestController):
1997         * WebKitTestRunner/TestInvocation.cpp:
1998         (WTR::TestInvocation::TestInvocation):
1999         (WTR::TestInvocation::setCustomTimeout):
2000         (WTR):
2001         (WTR::TestInvocation::invoke):
2002         * WebKitTestRunner/TestInvocation.h:
2003         (TestInvocation):
2004
2005 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2006
2007         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
2008         https://bugs.webkit.org/show_bug.cgi?id=106290
2009
2010         Reviewed by Martin Robinson.
2011
2012         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
2013         the macro isn't enabled.
2014
2015         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2016
2017 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
2018
2019         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
2020         https://bugs.webkit.org/show_bug.cgi?id=103653
2021
2022         Reviewed by Anders Carlsson.
2023
2024         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
2025         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
2026         client callback.
2027
2028         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
2029         methods to the JavaScript API.
2030         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2031         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
2032         (WTR::TestRunner::setAuthenticationUsername): Ditto.
2033         (WTR::TestRunner::setAuthenticationPassword): Ditto.
2034         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2035         (TestRunner): Added new declarations for the above.
2036         * WebKitTestRunner/TestController.cpp:
2037         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
2038         callback.
2039         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
2040         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
2041         the authentication information passed from the InjectedBundle.
2042         * WebKitTestRunner/TestController.h:
2043         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
2044         to communicate with the TestController.
2045         (WTR::TestController::setAuthenticationUsername): Ditto.
2046         (WTR::TestController::setAuthenticationPassword): Ditto.
2047         (TestController):
2048         * WebKitTestRunner/TestInvocation.cpp:
2049         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
2050         information from the InjectedBundle.
2051         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
2052         text to the TestInvocation text output.
2053         * WebKitTestRunner/TestInvocation.h:
2054         (TestInvocation): Added declaration for new method.
2055
2056 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
2057
2058         Add myself as a watcher for Web Geolocation
2059
2060         Unreviewed.
2061
2062         * Scripts/webkitpy/common/config/watchlist:
2063
2064 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2065
2066         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
2067         https://bugs.webkit.org/show_bug.cgi?id=106364
2068
2069         Reviewed by Eric Seidel.
2070
2071         When the setup_test_run method is called on the subclasses of the base Port
2072         interface, the parent method should also be called via super(), despite the
2073         parent method not doing anything at the moment.
2074
2075         The according calls to super() are required in the ChromiumPort, EflPort
2076         and GtkPort implementations.
2077
2078         * Scripts/webkitpy/layout_tests/port/chromium.py:
2079         (ChromiumPort.setup_test_run):
2080         * Scripts/webkitpy/layout_tests/port/efl.py:
2081         (EflPort.setup_test_run):
2082         * Scripts/webkitpy/layout_tests/port/gtk.py:
2083         (GtkPort.setup_test_run):
2084
2085 2013-01-08  Julie Parent  <jparent@chromium.org>
2086
2087         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
2088         https://bugs.webkit.org/show_bug.cgi?id=106356
2089
2090         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
2091         dashboard_base, assigned by Loader, and used only by dashboard_base to
2092         create error messages.  Moved the variables to be privates on the Loader
2093         object, moved error message creation to _getLoadingErrorMessages on the
2094         Loader object, and now pass the errors back to dashboard base via the
2095         resourceLoadingComplete callback.
2096         
2097         Also removed the now unused clearError function, it was only being used
2098         by unit tests to clean up global state.
2099         
2100         Reviewed by Dirk Pranke.
2101
2102         * TestResultServer/static-dashboards/dashboard_base.js:
2103         (resourceLoadingComplete):
2104         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2105         * TestResultServer/static-dashboards/loader.js:
2106         (.):
2107         * TestResultServer/static-dashboards/loader_unittests.js:
2108
2109 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2110
2111         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
2112         https://bugs.webkit.org/show_bug.cgi?id=106354
2113
2114         Reviewed by Eric Seidel.
2115
2116         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
2117         instead of those two inheriting from it. Also add a mock object of the
2118         sanitizer that's used in unit tests.
2119
2120         * Scripts/webkitpy/layout_tests/port/efl.py:
2121         (EflPort):
2122         (EflPort.__init__):
2123         (EflPort.setup_test_run):
2124         (EflPort.clean_up_test_run):
2125         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
2126         importing order.
2127         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
2128         * Scripts/webkitpy/layout_tests/port/gtk.py:
2129         (GtkPort):
2130         (GtkPort.__init__):
2131         (GtkPort.setup_test_run):
2132         (GtkPort.clean_up_test_run):
2133         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
2134         importing order.
2135         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
2136         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
2137         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
2138         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
2139         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
2140         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
2141         (PulseAudioSanitizerMock.unload_pulseaudio_module):
2142         (PulseAudioSanitizerMock.restore_pulseaudio_module):
2143
2144 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
2145
2146         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
2147         https://bugs.webkit.org/show_bug.cgi?id=106324
2148
2149         Reviewed by Adam Barth.
2150
2151         Since the frame load callbacks are part of the WebFrameClient, the
2152         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
2153         methods.
2154
2155         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2156         (DRTTestRunner::DRTTestRunner):
2157         (DRTTestRunner::reset):
2158         * DumpRenderTree/chromium/DRTTestRunner.h:
2159         (DRTTestRunner):
2160         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2161         (WebTestInterfaces):
2162         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2163         (WebKit):
2164         (WebTestProxyBase):
2165         (WebTestRunner):
2166         (WebTestRunner::WebTestProxy::WebTestProxy):
2167         (WebTestProxy):
2168         (WebTestRunner::WebTestProxy::didInvalidateRect):
2169         (WebTestRunner::WebTestProxy::didScrollRect):
2170         (WebTestRunner::WebTestProxy::scheduleComposite):
2171         (WebTestRunner::WebTestProxy::scheduleAnimation):
2172         (WebTestRunner::WebTestProxy::setWindowRect):
2173         (WebTestRunner::WebTestProxy::show):
2174         (WebTestRunner::WebTestProxy::didAutoResize):
2175         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
2176         (WebTestRunner::WebTestProxy::startDragging):
2177         (WebTestRunner::WebTestProxy::shouldBeginEditing):
2178         (WebTestRunner::WebTestProxy::shouldEndEditing):
2179         (WebTestRunner::WebTestProxy::shouldInsertNode):
2180         (WebTestRunner::WebTestProxy::shouldInsertText):
2181         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
2182         (WebTestRunner::WebTestProxy::shouldDeleteRange):
2183         (WebTestRunner::WebTestProxy::shouldApplyStyle):
2184         (WebTestRunner::WebTestProxy::didBeginEditing):
2185         (WebTestRunner::WebTestProxy::didChangeSelection):
2186         (WebTestRunner::WebTestProxy::didChangeContents):
2187         (WebTestRunner::WebTestProxy::didEndEditing):
2188         (WebTestRunner::WebTestProxy::registerIntentService):
2189         (WebTestRunner::WebTestProxy::dispatchIntent):
2190         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
2191         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
2192         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
2193         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
2194         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
2195         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
2196         (WebTestRunner::WebTestProxy::didReceiveTitle):
2197         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
2198         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
2199         (WebTestRunner::WebTestProxy::didFailLoad):
2200         (WebTestRunner::WebTestProxy::didFinishLoad):
2201         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
2202         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
2203         (WebTestRunner::WebTestProxy::didRunInsecureContent):
2204         (WebTestRunner::WebTestProxy::didDetectXSS):
2205         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2206         (WebTestRunner::WebTestRunner::setTestIsRunning):
2207         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
2208         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
2209         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
2210         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
2211         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
2212         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2213         (WebTestRunner::TestRunner::TestRunner):
2214         (WebTestRunner::TestRunner::reset):
2215         (WebTestRunner::TestRunner::setTestIsRunning):
2216         (WebTestRunner):
2217         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
2218         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
2219         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
2220         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
2221         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
2222         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
2223         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
2224         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
2225         (WebTestRunner::TestRunner::dumpTitleChanges):
2226         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2227         (TestRunner):
2228         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2229         (WebTestInterfaces::Internal):
2230         (WebTestRunner::WebTestInterfaces::Internal::webView):
2231         (WebTestRunner::WebTestInterfaces::Internal::Internal):
2232         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
2233         (WebTestRunner):
2234         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
2235         (WebTestRunner::WebTestInterfaces::setWebView):
2236         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
2237         (WebTestRunner::WebTestInterfaces::webView):
2238         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2239         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
2240         (WebTestRunner):
2241         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
2242         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
2243         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
2244         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
2245         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
2246         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2247         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
2248         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
2249         (WebTestRunner::WebTestProxyBase::didFailLoad):
2250         (WebTestRunner::WebTestProxyBase::didFinishLoad):
2251         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
2252         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
2253         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
2254         (WebTestRunner::WebTestProxyBase::didDetectXSS):
2255         * DumpRenderTree/chromium/TestShell.cpp:
2256         (TestShell::runFileTest):
2257         (TestShell::testFinished):
2258         * DumpRenderTree/chromium/TestShell.h:
2259         (TestShell):
2260         * DumpRenderTree/chromium/WebViewHost.cpp:
2261         (WebViewHost::didStartProvisionalLoad):
2262         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
2263         (WebViewHost::didFailProvisionalLoad):
2264         (WebViewHost::didCommitProvisionalLoad):
2265         (WebViewHost::didReceiveTitle):
2266         (WebViewHost::didFailLoad):
2267         (WebViewHost::didFinishLoad):
2268         * DumpRenderTree/chromium/WebViewHost.h:
2269         (WebViewHost):
2270
2271 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2272
2273         [GTK] Lower the default timeout value for WebKitTestRunner
2274         https://bugs.webkit.org/show_bug.cgi?id=106353
2275
2276         Reviewed by Dirk Pranke.
2277
2278         The default timeout value for WebKitTestRunner should be lowered.
2279         The current value (80 seconds) is irrational and just leads to producing
2280         text failures for layout tests that genuinely time out. This just leads
2281         to more deviation from the GTK WK1 port in terms of test expectations.
2282
2283         The value used is the same as when running the DumpRenderTree, that's
2284         6 seconds in release builds and 12 seconds in debug builds.
2285
2286         * Scripts/webkitpy/layout_tests/port/gtk.py:
2287         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2288         (GtkPortTest.test_default_timeout_ms):
2289
2290 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2291
2292         test-webkitpy shows failure output on my linux box
2293         https://bugs.webkit.org/show_bug.cgi?id=101261
2294
2295         Reviewed by Eric Seidel.
2296
2297         Mock out the PulseAudioSanitizer methods when creating testing instances
2298         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
2299         PulseAudio output when the sanitizer was trying to unload modules which
2300         were already unloaded by another unit test that was being run in parallel.
2301
2302         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2303         (EflPortTest):
2304         (EflPortTest.make_port):
2305         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2306         (GtkPortTest):
2307         (GtkPortTest.make_port):
2308
2309 2013-01-08  Julie Parent  <jparent@chromium.org>
2310
2311         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
2312         https://bugs.webkit.org/show_bug.cgi?id=106254
2313
2314         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
2315         only to figure out if we should call addBuilderLoadErrors during
2316         handleLocationChange, which was called when the loader completed and on
2317         any hash change, but we only ever wanted to call addBuilderLoadErrors
2318         on the initial loader load.  Moved the call of addBuilderLoadErrors to
2319         resourceLoadingComplete rather than handleLocationChange, so now we
2320         only call it when we want to, and the check can go away completely.
2321
2322         Reviewed by Dirk Pranke.
2323
2324         * TestResultServer/static-dashboards/dashboard_base.js:
2325         (addBuilderLoadErrors):
2326         (resourceLoadingComplete):
2327         (handleLocationChange):
2328         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2329
2330 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
2331
2332         Add aboxhall@chromium.org to accessibility watchlist.
2333
2334         Unreviewed.
2335
2336         * Scripts/webkitpy/common/config/watchlist:
2337
2338 2013-01-08  Dan Winship  <danw@gnome.org>
2339
2340         Add Apache 2.4 support for Fedora 18
2341         https://bugs.webkit.org/show_bug.cgi?id=104478
2342
2343         Reviewed by Martin Robinson.
2344
2345         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
2346         need a separate config.
2347
2348         * Scripts/webkitpy/layout_tests/port/base.py:
2349         (Port._apache_version):
2350         (Port._apache_config_file_name_for_platform):
2351         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2352         * Scripts/run-webkit-httpd:
2353         * Scripts/webkitperl/httpd.pm:
2354         (getApacheVersion):
2355         (getDefaultConfigForTestDirectory):
2356         (getHTTPDConfigPathForTestDirectory):
2357
2358 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2359
2360         Make the override-feature-defines script compatible with Python v3
2361         https://bugs.webkit.org/show_bug.cgi?id=105742
2362
2363         Reviewed by Martin Robinson.
2364
2365         Instead of printing output through a statement, use the print function and format
2366         the output using the str.format method. This makes the script runnable with Python v3.
2367
2368         * gtk/override-feature-defines:
2369         (adjust_feature_defines_makefile):
2370
2371 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
2372
2373         [Qt] Fix libxml2 config test
2374         https://bugs.webkit.org/show_bug.cgi?id=106317
2375
2376         Reviewed by Simon Hausmann.
2377
2378         Don't assume standard include/libxml2, libxml-2.0.pc should know
2379         where it's headers are.
2380
2381         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
2382
2383 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2384
2385         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
2386         https://bugs.webkit.org/show_bug.cgi?id=106195
2387
2388         Reviewed by Philippe Normand.
2389
2390         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
2391         to make the Python code compatible with Python 3. This includes modifying
2392         print statements, exception handling, dictionary iteration and
2393         byte-sequence-to-string conversion.
2394
2395         * gtk/common.py:
2396         (get_build_path):
2397         (pkg_config_file_variable):
2398         (gtk_version_of_pkg_config_file):
2399         * gtk/generate-gtkdoc:
2400         (print_missing_api):
2401         * gtk/gtkdoc.py:
2402         (GTKDoc.__init__):
2403         (GTKDoc._run_command):
2404
2405 2013-01-02  Steve Block  <steveblock@chromium.org>
2406
2407         Add chromium.org email address for Steve Block.
2408
2409         Unreviewed.
2410
2411         * Scripts/webkitpy/common/config/committers.py:
2412
2413 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
2414
2415         Rationalize closure call heuristics and profiling
2416         https://bugs.webkit.org/show_bug.cgi?id=106270
2417
2418         Reviewed by Oliver Hunt.
2419         
2420         Add ability to use display-profiler-output via a pipe, and add the ability to dump
2421         all generated code ('display *' or 'd *').
2422
2423         * Scripts/display-profiler-output:
2424
2425 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2426
2427         Sorted more xcodeproj files.
2428
2429         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2431         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2432
2433 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2434
2435         Sorted xcodeproj files.
2436
2437         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2438         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2439
2440 2013-01-07  Dan Bernstein  <mitz@apple.com>
2441
2442         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
2443         https://bugs.webkit.org/show_bug.cgi?id=106261
2444
2445         Reviewed by Simon Fraser.
2446
2447         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
2448
2449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2450         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
2451         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
2452         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
2453         (TestWebKitAPI):
2454         (TestWebKitAPI::TEST):
2455
2456 2013-01-07  Ojan Vafai  <ojan@chromium.org>
2457
2458         Add the Apple MountainLion bots to garden-o-matic.
2459         Eventually, we really should move away from hardcoding
2460         the list of bots.
2461
2462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2463
2464 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
2465
2466         [chromium] move web audio related methods to testrunner library
2467         https://bugs.webkit.org/show_bug.cgi?id=106211
2468
2469         Reviewed by Adam Barth.
2470
2471         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2472         (DRTTestRunner::DRTTestRunner):
2473         (DRTTestRunner::reset):
2474         * DumpRenderTree/chromium/DRTTestRunner.h:
2475         (DRTTestRunner):
2476         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2477         (WebKit):
2478         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
2479         (WebTestRunner::WebTestRunner::audioData):
2480         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2481         (WebTestRunner::TestRunner::TestRunner):
2482         (WebTestRunner::TestRunner::reset):
2483         (WebTestRunner::TestRunner::shouldDumpAsAudio):
2484         (WebTestRunner):
2485         (WebTestRunner::TestRunner::audioData):
2486         (WebTestRunner::TestRunner::setAudioData):
2487         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2488         (TestRunner):
2489         * DumpRenderTree/chromium/TestShell.cpp:
2490         (TestShell::dump):
2491
2492 2013-01-07  Mike West  <mkwst@chromium.org>
2493
2494         Make the IFRAME_SEAMLESS flag runtime-enabled.
2495         https://bugs.webkit.org/show_bug.cgi?id=106213
2496
2497         Reviewed by Ojan Vafai.
2498
2499         * DumpRenderTree/chromium/TestShell.cpp:
2500         (TestShell::TestShell):
2501         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2502         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2503         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2504         (resetDefaultsToConsistentValues):
2505         * DumpRenderTree/mac/DumpRenderTree.mm:
2506         (resetDefaultsToConsistentValues):
2507         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2508         (WebCore::WebPage::resetSettings):
2509         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2510         (WTR::InjectedBundle::beginTesting):
2511             Ensure that seamless IFrames are enabled for layout tests in each of
2512             the ports that support seamless IFrames.
2513
2514 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
2515
2516         [chromium] move dumpAsText and friends to the TestRunner library
2517         https://bugs.webkit.org/show_bug.cgi?id=106222
2518
2519         Reviewed by Adam Barth.
2520
2521         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
2522
2523         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2524         (DRTTestRunner::DRTTestRunner):
2525         (DRTTestRunner::reset):
2526         * DumpRenderTree/chromium/DRTTestRunner.h:
2527         (DRTTestRunner):
2528         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2529         (WebTestRunner::WebTestRunner::shouldDumpAsText):
2530         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
2531         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
2532         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
2533         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
2534         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
2535         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2536         (WebTestRunner::TestRunner::TestRunner):
2537         (WebTestRunner::TestRunner::reset):
2538         (WebTestRunner::TestRunner::shouldDumpAsText):
2539         (WebTestRunner):
2540         (WebTestRunner::TestRunner::setShouldDumpAsText):
2541         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
2542         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
2543         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
2544         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
2545         (WebTestRunner::TestRunner::dumpAsText):
2546         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
2547         (WebTestRunner::TestRunner::dumpChildFramesAsText):
2548         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2549         (TestRunner):
2550
2551 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2552
2553         Build fix attempt after r138810.
2554
2555         Apparently python 2.6 is really bad at floating point computation.
2556
2557         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2558         (MainTest.test_run_memory_test):
2559
2560 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2561
2562         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
2563         https://bugs.webkit.org/show_bug.cgi?id=106172
2564
2565         Reviewed by Tony Chang.
2566
2567         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
2568         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
2569         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
2570         test on perf-o-matic and perf. test's results page.
2571
2572         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
2573
2574         * Scripts/webkitpy/performance_tests/perftest.py:
2575         (PerfTestMetric): Added.
2576         (PerfTestMetric.__init__): Added.
2577         (PerfTestMetric.metric): Added.
2578         (PerfTestMetric.has_values): Added.
2579         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
2580         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
2581         conversions to be done on the client side (perf-o-matic and results page).
2582         (PerfTestMetric.append): Added.
2583         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
2584         a result for this metric.
2585         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
2586         (PerfTestMetric.compute_statistics): Moved from PerfTest.
2587
2588         (PerfTest._create_driver): Extracted from PerfTest.run.
2589         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
2590         as needed.
2591         (PerfTest._run_with_driver):
2592         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
2593         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
2594         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
2595
2596         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
2597         from other perf tests, there isn't much point in sharing the code here.
2598
2599         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
2600         statistics for the measured values.
2601
2602         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2603         (TestPerfTestMetric): Added.
2604         (TestPerfTestMetric.test_init_set_missing_unit): Added.
2605         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
2606         (TestPerfTestMetric.test_has_values): Added.
2607         (TestPerfTestMetric.test_append): Added.
2608         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
2609         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
2610
2611         (TestPerfTest._assert_results_are_correct): Updated as needed.
2612         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
2613         in PerfTest.run now after generating the results dictionary.
2614         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
2615
2616 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
2617
2618         Support size_t multiplication and division operators on LayoutUnit
2619         https://bugs.webkit.org/show_bug.cgi?id=83848
2620
2621         Reviewed by Emil A Eklund.
2622
2623         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2624         Added some simple tests for the new operators using size_t.
2625
2626 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2627
2628         [Qt] run-webkit-tests cleanup for parallel NRWT
2629         https://bugs.webkit.org/show_bug.cgi?id=106220
2630
2631         Reviewed by Dirk Pranke.
2632
2633         * Scripts/run-webkit-tests:
2634         (useNewRunWebKitTests):
2635         * Scripts/webkitpy/layout_tests/port/qt.py:
2636         (QtPort):
2637         (QtPort.default_child_processes):
2638
2639 2013-01-07  Philippe Normand  <pnormand@igalia.com>
2640
2641         Create a GStreamerAudio watchlist and add myself to it.
2642
2643         Unreviewed.
2644
2645         * Scripts/webkitpy/common/config/watchlist:
2646
2647 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
2648
2649         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
2650         Also removed the empty mac directory.
2651
2652         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
2653         * BuildSlaveSupport/download-built-product: Added property svn:executable.
2654         * BuildSlaveSupport/mac: Removed.
2655         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
2656
2657 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2658
2659         Add a script to delete stale zero-byte build files
2660         https://bugs.webkit.org/show_bug.cgi?id=106131
2661
2662         Reviewed by Tony Chang.
2663
2664         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
2665
2666         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2667         (DeleteStaleBuildFiles): Added.
2668         (Factory.__init__): Add DeleteStaleBuildFiles step.
2669         * BuildSlaveSupport/delete-stale-build-files: Added.
2670         (main): Delete zero-byte files except ones intentionally generated by our build process.
2671         (webkitBuildDirectory): Copied from build-product-archive.
2672
2673 2013-01-04  Michael Pruett  <michael@68k.org>
2674
2675         [GTK] Fix build error on GTK due to r138836
2676         https://bugs.webkit.org/show_bug.cgi?id=106154
2677
2678         Reviewed by Kentaro Hara.
2679
2680         * GNUmakefile.am:
2681
2682 2013-01-04  Dan Bernstein  <mitz@apple.com>
2683
2684         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
2685         https://bugs.webkit.org/show_bug.cgi?id=106121
2686
2687         Reviewed by Adele Peterson.
2688
2689         Added test for -[DOMTHMLTableCellElement _cellAbove].
2690
2691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2692         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
2693         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
2694         (TestWebKitAPI):
2695         (TestWebKitAPI::expectCellAboveCell):
2696         (TestWebKitAPI::TEST):
2697         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
2698
2699 2013-01-04  Eric Seidel  <eric@webkit.org>
2700
2701         FlakyTestReporter should be re-enabled and taught how to post patches
2702         https://bugs.webkit.org/show_bug.cgi?id=103839
2703
2704         Reviewed by Adam Barth.
2705
2706         This moves LayoutTestResultsReader off of the DeprecatedPort object.
2707         It also adds a real Port object to the EWS and CommitQueue objects
2708         using a new PatchProcessingQueue superclass.
2709         PatchProcessingQueue doesn't seem to be the cleanest insertion point
2710         but works for this purpose.
2711         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
2712         to resolve a FIXME.
2713
2714         This required some hacks/shiming between the non-specific "old"
2715         port names which the EWS system is currently using, and the new
2716         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
2717
2718         Hopefully this will fix the flaky test reporter and results uploading.
2719         Certainly it's another small step towards getting rid of the old ports.py
2720         infrastructure and making the NRWT Port class common webkitpy infrastructure.
2721
2722         Now that DeprecatedPort is no longer used for the results directory
2723         I removed all the explicit results-dir code which webkit-patch was using
2724         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
2725
2726         * Scripts/webkitpy/common/config/ports.py:
2727         (DeprecatedPort.run_perl_unittests_command):
2728         * Scripts/webkitpy/common/config/ports_mock.py:
2729         (MockPort.name):
2730         * Scripts/webkitpy/common/system/outputcapture.py:
2731         (OutputCapture.assert_outputs):
2732         * Scripts/webkitpy/layout_tests/port/apple.py:
2733         (ApplePort.determine_full_port_name):
2734         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2735         (LayoutTestResultsReader.__init__):
2736         (LayoutTestResultsReader):
2737         (LayoutTestResultsReader._read_file_contents):
2738         (LayoutTestResultsReader._create_layout_test_results):
2739         (LayoutTestResultsReader._create_unit_test_results):
2740         (LayoutTestResultsReader.results):
2741         (LayoutTestResultsReader.archive):
2742         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2743         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2744         (LayoutTestResultsReaderTest.test_create_unit_test_results):
2745         (test_missing_unit_test_results_path):
2746         (test_layout_test_results):
2747         (test_archive_last_layout_test_results):
2748         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2749         (AbstractEarlyWarningSystem):
2750         (AbstractEarlyWarningSystem.__init__):
2751         (AbstractEarlyWarningSystem.begin_work_queue):
2752         (AbstractEarlyWarningSystem.run_command):
2753         * Scripts/webkitpy/tool/commands/queues.py:
2754         (AbstractPatchQueue.work_item_log_path):
2755         (PatchProcessingQueue):
2756         (PatchProcessingQueue._new_port_name_from_old):
2757         (PatchProcessingQueue.begin_work_queue):
2758         (PatchProcessingQueue._upload_results_archive_for_patch):
2759         (CommitQueue):
2760         (CommitQueue.begin_work_queue):
2761         (CommitQueue.run_command):
2762         (AbstractReviewQueue):
2763         (AbstractReviewQueue.__init__):
2764         (AbstractReviewQueue.begin_work_queue):
2765         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2766         (AbstractPatchQueueTest.test_next_patch):
2767         (PatchProcessingQueueTest):
2768         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
2769         * Scripts/webkitpy/tool/steps/runtests.py:
2770         (RunTests.run):
2771         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2772
2773 2013-01-04  Dana Jansens  <danakj@chromium.org>
2774
2775         [chromium] Remove lost-compositor-context layout tests
2776         https://bugs.webkit.org/show_bug.cgi?id=106089
2777
2778         Reviewed by James Robinson.
2779
2780         Remove the loseCompositorContext() test function.
2781
2782         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2783         (WebTestRunner::TestRunner::TestRunner):
2784         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2785         (TestRunner):
2786
2787 2013-01-04  Adam Klein  <adamk@chromium.org>
2788
2789         Remove ENABLE_MUTATION_OBSERVERS #define
2790         https://bugs.webkit.org/show_bug.cgi?id=105459
2791
2792         Reviewed by Ryosuke Niwa.
2793
2794         * Scripts/webkitperl/FeatureList.pm:
2795         * qmake/mkspecs/features/features.pri:
2796
2797 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2798
2799         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
2800         https://bugs.webkit.org/show_bug.cgi?id=106078
2801
2802         Reviewed by Tony Chang.
2803
2804         This patch updates values for individual iterations in dummy performance tests used in
2805         perftest_unittest.py and perftest_integrationtest.py so that they match up with
2806         statistics such as stdev and median reported in those tests. This change is required
2807         to resolve the bug 97510.
2808
2809         This patch also refactors integration tests by extracting *TestData classes that
2810         centralizes the definitions of each dummy performance test's text (DRT output),
2811         runner output, and parsed results (JSON) so that we may share more data between
2812         python tests.
2813
2814         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2815         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
2816         Use self.assertAlmostEqual when comparing the standard deviation.
2817         (MainTest.test_parse_output):
2818         (test_parse_output_with_failing_line):
2819         (test_parse_output_with_description): Use _assert_results_are_correct.
2820         (test_parse_output_with_subtests): Ditto.
2821
2822         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2823         (InspectorPassTestData): Extracted from tests below.
2824         (EventTargetWrapperTestData): Ditto.
2825         (SomeParserTestData): Ditto.
2826         (MemoryTestData): Ditto.
2827         (TestDriver.run_test): Moved test definitions out of the method.
2828         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
2829         (MainTest._load_output_json): Extracted from create_runner.
2830         (MainTest.create_runner):
2831         (MainTest.test_run_test_set_for_parser_tests):
2832         (MainTest.test_run_memory_test):
2833         (MainTest._test_run_with_json_output):
2834         (MainTest.test_run_with_json_output):
2835         (MainTest.test_run_with_description):
2836         (MainTest.test_run_generates_json_by_default):
2837         (MainTest.test_run_merges_output_by_default):
2838         (MainTest.test_run_respects_reset_results):
2839         (MainTest.test_run_generates_and_show_results_page):
2840         (MainTest.test_run_with_slave_config_json):
2841         (MainTest.test_run_with_multiple_repositories):
2842
2843 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
2844
2845         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
2846         https://bugs.webkit.org/show_bug.cgi?id=106045
2847
2848         Reviewed by Carlos Garcia Campos.
2849
2850         Update test results to confirm that compositions without preedits do not trigger
2851         a composition confirmation.
2852
2853         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2854         (TestWebKitAPI::verifyCanceledComposition):
2855
2856 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
2857
2858         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
2859         https://bugs.webkit.org/show_bug.cgi?id=105958
2860
2861         Reviewed by Alexey Proskuryakov.
2862
2863         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
2864
2865         * WebKitTestRunner/mac/EventSenderProxy.mm:
2866         (KeyMappingEntry):
2867         (WTR):
2868         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
2869
2870 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
2871
2872         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
2873         https://bugs.webkit.org/show_bug.cgi?id=106073
2874
2875         Reviewed by Ryosuke Niwa.
2876
2877         Check that the element being compared to is not nil. 
2878         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
2879         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
2880         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
2881         sometimes before on parallel WebKitTestRunner runs.
2882
2883         * DumpRenderTree/AccessibilityUIElement.cpp:
2884         (AccessibilityUIElement::isEqual):
2885         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2886         (WTR::AccessibilityUIElement::isEqual):
2887
2888 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
2889
2890         Downloads can be flaky, so try downloading multiple times.
2891         https://bugs.webkit.org/show_bug.cgi?id=105976
2892
2893         Reviewed by Eric Seidel.
2894
2895         * Scripts/webkitpy/common/system/autoinstall.py:
2896         (AutoInstaller._download_to_stream):
2897
2898 2013-01-03  Eric Seidel  <eric@webkit.org>
2899
2900         Rename Tool.port to deprecated_port in preparation for removing more callers
2901         https://bugs.webkit.org/show_bug.cgi?id=106076
2902
2903         Reviewed by Ryosuke Niwa.
2904
2905         This resolves a long-standing FIXME to rename this method. :)
2906
2907         * Scripts/webkitpy/tool/bot/botinfo.py:
2908         (BotInfo.summary_text):
2909         * Scripts/webkitpy/tool/bot/irc_command.py:
2910         (Rollout._update_working_copy):
2911         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2912         (LayoutTestResultsReader._create_layout_test_results):
2913         (LayoutTestResultsReader._create_unit_test_results):
2914         (LayoutTestResultsReader._results_directory):
2915         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2916         (test_missing_unit_test_results_path):
2917         * Scripts/webkitpy/tool/main.py:
2918         (WebKitPatch.deprecated_port):
2919         * Scripts/webkitpy/tool/mocktool.py:
2920         (MockTool.deprecated_port):
2921         * Scripts/webkitpy/tool/steps/build.py:
2922         (Build.build):
2923         * Scripts/webkitpy/tool/steps/checkstyle.py:
2924         (CheckStyle.run):
2925         * Scripts/webkitpy/tool/steps/commit.py:
2926         (Commit._check_test_expectations):
2927         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2928         (PrepareChangeLog.run):
2929         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2930         (PrepareChangeLogForDEPSRoll.run):
2931         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2932         (PrepareChangeLogForRevert.run):
2933         * Scripts/webkitpy/tool/steps/runtests.py:
2934         (RunTests.run):
2935         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2936         (StepsTest.test_runtests_args):
2937         * Scripts/webkitpy/tool/steps/update.py:
2938         (Update._update_command):
2939
2940 2013-01-03  Eric Seidel  <eric@webkit.org>
2941
2942         Add myself to the webkitpy watchlist.
2943
2944         Unreviewed.
2945
2946         * Scripts/webkitpy/common/config/watchlist:
2947
2948 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2949
2950         Cleanup perftest* tests and add a test for computing statistics
2951         https://bugs.webkit.org/show_bug.cgi?id=105685
2952
2953         Reviewed by Eric Seidel.
2954
2955         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
2956         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
2957
2958         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
2959
2960         * Scripts/webkitpy/performance_tests/perftest.py:
2961         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
2962         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
2963         accurate result for the mean.
2964         (PageLoadingPerfTest.run_single):
2965         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2966         (MainTest.test_compute_statistics):
2967         (MainTest.test_compute_statistics.compute_statistics): Added.
2968         (TestPageLoadingPerfTest.test_run): floatify values.
2969         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
2970         correctly recognizes them as integers.
2971
2972         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
2973         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
2974         (TestDriver): Moved out of MainTest.
2975         (MainTest): Got rid of assertWritten and all unit tests.
2976         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
2977         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2978         (MainTest.test_run_test_set_for_parser_tests):
2979         (MainTest.test_run_memory_test):
2980         (MainTest._test_run_with_json_output):
2981         (MainTest.test_run_generates_json_by_default):
2982         (MainTest.test_run_merges_output_by_default):
2983         (MainTest.test_run_respects_reset_results):
2984         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
2985         parsing output JSON files. Just verify that the output path is correct instead.
2986         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2987         (MainTest): Removed all integration tests.
2988         (MainTest.create_runner): Simplified.
2989
2990 2013-01-03  Julie Parent  <jparent@chromium.org>
2991
2992         Dashboard cleanup: remove usage of global g_defaultBuilderName
2993         https://bugs.webkit.org/show_bug.cgi?id=106043
2994
2995         Use now public defaultBuilder() from the BuilderGroup, rather
2996         than global variable.
2997
2998         Also eliminates the setup() and initBuilders() functions since we
2999         no longer need to track the global.
3000
3001         Reviewed by Adam Barth.
3002
3003         * TestResultServer/static-dashboards/builders.js:
3004         (BuilderGroup.prototype.defaultBuilder):
3005         (BuilderGroup.prototype.master):
3006         * TestResultServer/static-dashboards/dashboard_base.js:
3007         (parseParameters):
3008         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3009         (updateDefaultBuilderState):
3010         * TestResultServer/static-dashboards/loader.js:
3011         (.):
3012         * TestResultServer/static-dashboards/loader_unittests.js:
3013
3014 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3015
3016         Disable an intermittently failing unit test for now.
3017         The failure is tracked by the bug 106051.
3018
3019         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
3020         (TestWebKitAPI::TEST):
3021
3022 2013-01-03  Dan Bernstein  <mitz@apple.com>
3023
3024         No way to obtain a DOMNode given a JS wrapper for a Node
3025         https://bugs.webkit.org/show_bug.cgi?id=106033
3026
3027         Added a test for +[DOMNode _nodeFromJSWrapper:].
3028
3029         Reviewed by Sam Weinig.
3030
3031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3032         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
3033         (TestWebKitAPI):
3034         (TestWebKitAPI::TEST):
3035
3036 2013-01-03  Emil A Eklund  <eae@chromium.org>
3037
3038         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
3039         https://bugs.webkit.org/show_bug.cgi?id=105961
3040
3041         Reviewed by Levi Weintraub.
3042         
3043         Add tests for LayoutUnit::ceil and floor.
3044
3045         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3046         (TestWebKitAPI::TEST):
3047         (TestWebKitAPI):
3048
3049 2013-01-03  Julie Parent  <jparent@chromium.org>
3050
3051         Add unit test for default builder for the dashboards.
3052         https://bugs.webkit.org/show_bug.cgi?id=105972
3053
3054         Reviewed by Dirk Pranke.
3055
3056         * TestResultServer/static-dashboards/loader_unittests.js:
3057
3058 2013-01-03  Tony Chang  <tony@chromium.org>
3059
3060         Generate internal.settings from Settings.in
3061         https://bugs.webkit.org/show_bug.cgi?id=104740
3062
3063         Reviewed by Adam Barth.
3064
3065         * GNUmakefile.am: Compile new generated files on GTK+.
3066         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
3067         with both extra_sources and add_output_to_sources=false will still
3068         compile the files in extra_sources. This makes it possible to compile
3069         InternalSettingsGenerated.cpp and not be confused by
3070         InternalSettingsGenerated.idl.
3071
3072 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
3073
3074         [style] WebIDL-reflecting uppercase enums reported as style violation
3075         https://bugs.webkit.org/show_bug.cgi?id=105832
3076
3077         Reviewed by Tony Chang.
3078
3079         Recognize the enum as WebIDL-reflecting one if there's a comment present that
3080         indicates this. In enums spanning over multiple lines, the comment is expected
3081         on the first line. In enums placed in one line, the comment is expected at the
3082         end of that line.
3083
3084         WebIDL-reflecting enum values are required to be written in uppercase and as such
3085         violate the common rule of these values being written in InterCaps. Annotating
3086         enums this way makes it possible to avoid false style violation reports.
3087
3088         The comment is of form '// Web(?:Kit)?IDL enum'.
3089
3090         * Scripts/webkitpy/style/checkers/cpp.py:
3091         (_EnumState.__init__):
3092         (_EnumState.process_clean_line):
3093         (check_enum_casing):
3094         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3095         (NoNonVirtualDestructorsTest.test_enum_casing):
3096
3097 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
3098
3099         Adding favicon.ico to the garden-o-matic.
3100         https://bugs.webkit.org/show_bug.cgi?id=105982
3101
3102         Reviewed by Adam Barth.
3103
3104         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
3106
3107 2013-01-03  Jonathan Liu  <net147@gmail.com>
3108
3109         [Qt] Fix library linking order
3110         https://bugs.webkit.org/show_bug.cgi?id=105818
3111
3112         Some Qt libraries are linked before the private static libraries
3113         that depend on them which results in QtWebKit failing to link.
3114
3115         Copy Qt module dependencies from QT to QT_PRIVATE when creating
3116         module to ensure the Qt libraries are linked after the private
3117         static libraries that depend on them.
3118
3119         Reviewed by Tor Arne Vestbø.
3120
3121         * qmake/mkspecs/features/default_post.prf:
3122
3123 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
3124
3125         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
3126         https://bugs.webkit.org/show_bug.cgi?id=102209
3127
3128         Reviewed by Gyuyoung Kim.
3129
3130         Set tooltip on the elm_window instead of ewk_view, and add delay to
3131         show the tooltip window.
3132
3133         Setting tooltip on the ewk_view makes elementary error message because
3134         ewk_view is not an elementary widget. To remove the error message,
3135         tooltip should be set on the elm_window.
3136
3137         Most browsers show the tooltip after a mouse pointer stays on an
3138         element object that has tooltip text.
3139         But elm_tooltip widget itself doesn't have delay or handle mouse
3140         events to show/hide.
3141
3142         So additional codes are added to show/hide tooltip widget along with
3143         mouse events.
3144           1) When a mouse pointer stays for a second on an element which has
3145              tooltip text, then tooltip widget is displayed.
3146           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
3147              widget.
3148
3149         * MiniBrowser/efl/main.c:
3150         (_Tooltip_Information):
3151         (_Browser_Window):
3152         (on_tooltip_show):
3153         (window_tooltip_hide):
3154         (window_tooltip_update):
3155         (on_mouse_in):
3156         (on_mouse_move):
3157         (on_mouse_out):
3158         (window_free):
3159         (on_tooltip_text_set):
3160         (on_tooltip_text_unset):
3161         (window_create):
3162
3163 2013-01-02  Tony Chang  <tony@chromium.org>
3164
3165         Unreviewed, rolling out r138661.
3166         http://trac.webkit.org/changeset/138661
3167         https://bugs.webkit.org/show_bug.cgi?id=104740
3168
3169         Compile problems on EFL
3170
3171         * GNUmakefile.am:
3172         * qmake/mkspecs/features/default_post.prf:
3173
3174 2013-01-02  Tony Chang  <tony@chromium.org>
3175
3176         Generate internal.settings from Settings.in
3177         https://bugs.webkit.org/show_bug.cgi?id=104740
3178
3179         Reviewed by Adam Barth.
3180
3181         * GNUmakefile.am: Compile new generated files on GTK+.
3182         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
3183         with both extra_sources and add_output_to_sources=false will still
3184         compile the files in extra_sources. This makes it possible to compile
3185         InternalSettingsGenerated.cpp and not be confused by
3186         InternalSettingsGenerated.idl.
3187
3188 2013-01-02  Adam Barth  <abarth@webkit.org>
3189
3190         Remove old-run-webkit-tests support from webkitpy
3191         https://bugs.webkit.org/show_bug.cgi?id=105619
3192
3193         Reviewed by Eric Seidel.
3194
3195         This patch removes support for webkitpy parsing the
3196         old-run-webkit-tests results format. There doesn't seem to be any
3197         reason to keep this code around anymore now that most bots have
3198         switched to new-run-webkit-tests.
3199
3200         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3201         (Builder.fetch_layout_test_results):
3202         * Scripts/webkitpy/common/net/layouttestresults.py:
3203         (path_for_layout_test):
3204         (LayoutTestResults.results_from_string):
3205         (LayoutTestResults):
3206         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3207         (LayoutTestResultsTest.test_results_from_string):
3208         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3209         (test_flaky_test_failure):
3210         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3211         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
3212         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3213         (PatchAnalysisTask._test_patch):
3214         * Scripts/webkitpy/tool/commands/queuestest.py:
3215         (QueuesTest.assert_queue_outputs):
3216
3217 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
3218
3219         [Qt][WK2] Add simple UI to find text from page
3220         https://bugs.webkit.org/show_bug.cgi?id=96481
3221
3222         Reviewed by Jocelyn Turcotte.
3223
3224         Find bar that slides between navigation bar and WebView.
3225
3226         * MiniBrowser/qt/BrowserWindow.cpp:
3227         (BrowserWindow::toggleFind):
3228         * MiniBrowser/qt/BrowserWindow.h:
3229         (BrowserWindow):
3230         * MiniBrowser/qt/MiniBrowser.qrc:
3231         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3232         (MiniBrowserApplication::notify):
3233         * MiniBrowser/qt/icons/find.png: Added.
3234         * MiniBrowser/qt/qml/BrowserWindow.qml:
3235
3236 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
3237
3238         Regression(r138603): Caused 2 webkitpy tests to fail
3239         https://bugs.webkit.org/show_bug.cgi?id=105913
3240
3241         Reviewed by Kentaro Hara.
3242
3243         Fix 2 webkitpy tests that started to fail after
3244         r138603.
3245
3246         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3247         (IRCCommandTest._sheriff_test_data_url): Make sure the
3248         returned test file URL is valid no matter what the
3249         current working directory is.
3250         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3251         (IRCBotTest.test_help): Add "sheriffs" command to the
3252         list of available commands.
3253
3254 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
3255
3256         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
3257         https://bugs.webkit.org/show_bug.cgi?id=105897
3258
3259         Reviewed by Alexey Proskuryakov.
3260
3261         Dump in WebKitTestRunner the message that is expected by layout tests
3262         when the missing plugin button is clicked.
3263
3264         * WebKitTestRunner/TestController.cpp:
3265         (WTR::TestController::createWebViewWithOptions):
3266         (WTR::TestController::unavailablePluginButtonClicked):
3267         (WTR):
3268         * WebKitTestRunner/TestController.h:
3269         (TestController):
3270
3271 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
3272
3273         [EFL] Enable MHTML feature
3274         https://bugs.webkit.org/show_bug.cgi?id=105815
3275
3276         Reviewed by Laszlo Gombos.
3277
3278         Enable MHTML feature for EFL port by default.
3279
3280         * Scripts/webkitperl/FeatureList.pm:
3281
3282 2013-01-01  Alan Cutter  <alancutter@chromium.org>
3283
3284         sheriff-bot should know who the gardeners/sheriffs are
3285         https://bugs.webkit.org/show_bug.cgi?id=105698
3286
3287         Reviewed by Eric Seidel.
3288
3289         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
3290
3291         * Scripts/webkitpy/tool/bot/irc_command.py:
3292         (Current):
3293         (Current._retrieve_webkit_sheriffs):
3294         (Current.execute):
3295         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3296         (IRCCommandTest.test_current):
3297         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
3298         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
3299         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
3300         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
3301         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
3302
3303 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3304
3305         [GTK] Move ImageDiff to the Tools directory root
3306         https://bugs.webkit.org/show_bug.cgi?id=105421
3307
3308         Reviewed by Kenneth Rohde Christiansen.
3309
3310         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
3311         * GNUmakefile.am:
3312         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
3313
3314 2012-12-30  Mike West  <mkwst@chromium.org>
3315
3316         Add myself to watchlists for CSP and console logs.
3317         https://bugs.webkit.org/show_bug.cgi?id=105874
3318
3319         Reviewed by Dirk Pranke.
3320
3321         Because I really, really, really need more email.
3322
3323         * Scripts/webkitpy/common/config/committers.py:
3324             Add mkwst+watchlist@chromium.org as a contributor.
3325         * Scripts/webkitpy/common/config/watchlist:
3326             Create watchlist categories for 1) the various mechanisms used to
3327             generate console messages, and 2) CSP usage and files.
3328
3329 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3330
3331         [EFL] Enable TEMPLATE_ELEMENT feature
3332         https://bugs.webkit.org/show_bug.cgi?id=105865
3333         
3334         Reviewed by Laszlo Gombos.
3335
3336         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
3337
3338 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
3339
3340         Unreviewed GTK gardening of the unit tests.
3341
3342         Skip the TestInspectorServer unit test that's timing out completely.
3343
3344         * Scripts/run-gtk-tests:
3345         (TestRunner):
3346
3347 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
3348
3349         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
3350         https://bugs.webkit.org/show_bug.cgi?id=105855
3351
3352         Reviewed by Vsevolod Vlasov.
3353
3354         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
3355         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
3356
3357         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3358         (ReportMemoryUsageVisitor):
3359         (clang::AddMemberCallVisitor::VisitCallExpr):
3360         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
3361         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
3362
3363 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
3364
3365         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
3366         https://bugs.webkit.org/show_bug.cgi?id=105852
3367
3368         Reviewed by Alexander Pavlov.
3369
3370         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3371         (clang):
3372         (AddMemberCallVisitor):
3373         (ReportMemoryUsageVisitor):
3374         (clang::ReportMemoryUsageAction::ParseArgs):
3375         (clang::AddMemberCallVisitor::VisitCallExpr):
3376         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
3377         (clang::ReportMemoryUsageVisitor::emitWarning):
3378         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
3379         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
3380         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
3381
3382 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
3383
3384         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
3385         https://bugs.webkit.org/show_bug.cgi?id=105835
3386
3387         Reviewed by Dirk Pranke.
3388
3389         The BeautifulSoup module is a third-party import and as such we don't have much control
3390         over its testing. Because of that it should be omitted from code coverage checking.
3391
3392         * Scripts/webkitpy/test/main.py:
3393         (Tester._run_tests):
3394
3395 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
3396
3397         [GTK][WK2] Add support for IME Composition
3398         https://bugs.webkit.org/show_bug.cgi?id=65093
3399
3400         Reviewed by Carlos Garcia Campos.
3401
3402         Update unit tests for GtkInputMethodFilter to note whether or not an event
3403         was a fake event synthesized for composition purposes. This is now used
3404         for WebKit2.
3405
3406         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
3407         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
3408         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
3409         (TestWebKitAPI::TEST):
3410         * gtk/generate-gtkdoc:
3411         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
3412         generation.
3413
3414 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
3415
3416         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
3417         https://bugs.webkit.org/show_bug.cgi?id=105800
3418
3419         Reviewed by Yury Semikhatsky.
3420
3421         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3422         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
3423         (clang):
3424
3425 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
3426
3427         Create a GTK build system watchlist and add myself to it
3428         https://bugs.webkit.org/show_bug.cgi?id=105769
3429
3430         Reviewed by Dirk Pranke.
3431
3432         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
3433         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
3434         omitted on purpose due to relatively high change rate they are exposed to.
3435
3436         The new watchlist would be of use to me as the GTK build system recently went
3437         through a series of changes that included a changed policy on adding configuration
3438         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
3439         mailing list about this change will be published later, but I'd also like to be
3440         notified of any pending changes to these files just so I can check the changes are
3441         in compliance with the new policy.
3442
3443         * Scripts/webkitpy/common/config/watchlist:
3444
3445 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
3446
3447         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
3448         As example ..../DevTools/src/third_party/WebKit
3449
3450         * Scripts/webkitpy/common/webkit_finder.py:
3451         (WebKitFinder.webkit_base):
3452
3453 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
3454
3455         [EFL][WK2] Refactor snapshot taking code
3456         https://bugs.webkit.org/show_bug.cgi?id=105687
3457
3458         Reviewed by Kenneth Rohde Christiansen.
3459
3460         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
3461         since the function was renamed to follow naming style.
3462
3463         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3464         (WTR::PlatformWebView::windowSnapshotImage):
3465
3466 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
3467
3468         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
3469         https://bugs.webkit.org/show_bug.cgi?id=105725
3470
3471         Reviewed by Yury Semikhatsky.
3472
3473         MemberType value names were adjusted according to Style Guide.
3474         Existing tests were extended with link type validation.
3475
3476         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3477
3478 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
3479
3480         [BlackBerry] DRT - Crashed when running pixels tests
3481         https://bugs.webkit.org/show_bug.cgi?id=105711
3482
3483         RIM PR 270003
3484
3485         Reviewed by George Staikos.
3486
3487         Calling window->post() here will result in buffer swapping which is
3488         only allowed in UI thread now, and I found we don't need to call it
3489         for GL renderer.
3490
3491         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3492         (createBitmapContextFromWebView):
3493
3494 2012-12-22  Dan Winship  <danw@gnome.org>
3495
3496         Add a patch to fix libxml2 2.9.0 regression
3497         https://bugs.webkit.org/show_bug.cgi?id=104494
3498
3499         Reviewed by Martin Robinson.
3500
3501         * gtk/jhbuild.modules:
3502         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
3503
3504 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3505
3506         Unreviewed update of status to reviewer.
3507
3508         * Scripts/webkitpy/common/config/committers.py:
3509
3510 2012-12-23  Philippe Normand  <pnormand@igalia.com>
3511
3512         [GTK][jhbuild] Bump GStreamer to 1.0.4
3513         https://bugs.webkit.org/show_bug.cgi?id=105640
3514
3515         Reviewed by Martin Robinson.
3516
3517         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
3518
3519 2012-12-21  Nico Weber  <thakis@chromium.org>
3520
3521         chromium: webkit-build-directory doesn't handle ninja output dirs
3522         https://bugs.webkit.org/show_bug.cgi?id=105671
3523
3524         Reviewed by Daniel Bates.
3525
3526         Teach webkit-build-directory to detect the ninja build directory.
3527
3528         * Scripts/webkitdirs.pm:
3529         (determineBaseProductDir):
3530         (determineIsChromiumNinja):
3531
3532 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
3533
3534         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
3535         https://bugs.webkit.org/show_bug.cgi?id=95477
3536
3537         Reviewed by Sam Weinig.
3538
3539         Co-authored by Jia Pu.
3540
3541         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
3542         we can have consistent autocorrection behavior when running tests.
3543
3544         * DumpRenderTree/mac/DumpRenderTree.mm:
3545         (resetDefaultsToConsistentValues):
3546         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3547         (WTR::InjectedBundle::platformInitialize):
3548
3549 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
3550
3551         [GTK] Add WebKit1-specific TestExpectations file
3552         https://bugs.webkit.org/show_bug.cgi?id=97562
3553
3554         Reviewed by Dirk Pranke.
3555
3556         Implement the expectations_files method inside the GtkPort class that
3557         returns the list of the TestExpectations files the current test configuration
3558         requires. The method is implemented in a similar way as on the EFL port.
3559         A unit test is also added.
3560
3561         * Scripts/webkitpy/layout_tests/port/gtk.py:
3562         (GtkPort._search_paths):
3563         (GtkPort):
3564         (GtkPort.expectations_files):
3565         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3566         (GtkPortTest.test_expectations_files):
3567
3568 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3569
3570         [EFL] Enable feature option for the CSS sticky position
3571         https://bugs.webkit.org/show_bug.cgi?id=105630
3572
3573         Reviewed by Kenneth Rohde Christiansen.
3574
3575         Enable CSS sticky position feature by default for the
3576         EFL port. This feature option was added in r138252.
3577
3578         No new tests. Existing layout tests pass.
3579
3580         * Scripts/webkitperl/FeatureList.pm:
3581
3582 2012-12-21  Jussi Kukkonen  <jussi.kukkonen@intel.com>
3583
3584         [WK2] REGRESSION(r138232): It made 4 tests timeout
3585         https://bugs.webkit.org/show_bug.cgi?id=105623
3586
3587         Reviewed by Kenneth Rohde Christiansen.
3588
3589         r138232 changed functionality so that empty text output
3590         no longer leads to a dump() call, which leads to a timeout.
3591         Instead do a text dump if there is text output or if there
3592         is no audio output.
3593
3594         * WebKitTestRunner/TestInvocation.cpp:
3595         (WTR::TestInvocation::dumpResults):
3596
3597 2012-12-21  Zeno Albisser  <zeno@webkit.org>
3598
3599         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
3600         https://bugs.webkit.org/show_bug.cgi?id=105309
3601
3602         On Windows the library name is Qt5WebKitWidgets as well.
3603         So r138136 should not have adjusted the library name for Windows.
3604
3605         Reviewed by Simon Hausmann.
3606
3607         * Scripts/webkitdirs.pm:
3608         (builtDylibPathForName):
3609
3610 2012-12-21  Zeno Albisser  <zeno@webkit.org>
3611
3612         [Qt] Add new TestExpectations for qt-5.0-mac-wk2.
3613         https://bugs.webkit.org/show_bug.cgi?id=105424
3614
3615         This change will allow us to run a very specific
3616         subset of the available LayoutTests on a mac buildbot.
3617         The new baseline search path for mac will look as follows:
3618         qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
3619
3620         Reviewed by Dirk Pranke.
3621
3622         * Scripts/webkitpy/layout_tests/port/qt.py:
3623         (QtPort._search_paths):
3624         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3625         (QtPortTest):
3626
3627 2012-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3628
3629         [EFL] Build break with latest EFL libraries.
3630         https://bugs.webkit.org/show_bug.cgi?id=104827
3631
3632         Reviewed by Laszlo Gombos.
3633
3634         The eo EFL package is introduced and evas and ecore use it since 1.8.
3635         While introducing Eo, EFL changed several structures of Evas and Ecore
3636         from own specific class to Eo.
3637
3638         So, this patch adds FindEo and changes declaration of Evas, Evas_Object,
3639         Ecore_Timer to build with latest EFL libraries.
3640