2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
2
3         Reviewed by Andreas Kling.
4
5         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
6         https://bugs.webkit.org/show_bug.cgi?id=62385
7
8         Remove duplicate TestNetscapePlugIn implementation. Having two copies
9         of this code makes keeping it in sync much more difficult. The files are
10         almost identical and this change ports the X11 changes to main.cpp.
11
12         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
13         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
14         (handleEventX11): Use the handler to properly convert the keycode. Do not print
15         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
16         it should not be in the results.
17         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
18         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
19         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
20         * GNUmakefile.am: Update source list.
21
22 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
23
24         Reviewed by Tony Chang.
25
26         Test plugin should support event logging on the windows port.
27         https://bugs.webkit.org/show_bug.cgi?id=61721
28
29         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
30         calls to mean the plugin handled the event.
31
32         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
33         (handleEventWin): Return 0 for each event on windows.
34
35 2011-06-09  Chang Shu  <cshu@webkit.org>
36
37         Reviewed by Andreas Kling.
38
39         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
40         https://bugs.webkit.org/show_bug.cgi?id=62381
41
42         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
43         QWKPagePrivate::isViewFocused() will check it later.
44
45         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
46         (WTR::PlatformWebView::PlatformWebView):
47
48 2011-06-09  Robert Hogan  <robert@webkit.org>
49
50         Reviewed by Andreas Kling.
51
52         Teach Qt about window.internals
53         https://bugs.webkit.org/show_bug.cgi?id=61074
54
55         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
56         (WebCore::DumpRenderTree::initJSObjects):
57
58 2011-06-09  Eric Seidel  <eric@webkit.org>
59
60         Reviewed by Adam Barth.
61
62         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
63         https://bugs.webkit.org/show_bug.cgi?id=62362
64
65         The mac bots are failing inspector tests.  We don't know why yet.
66         So for now, turning run-webkit-tests off for the mac-ews.
67
68         Also noticed that due to the wrong variable name the cr-linux
69         bots weren't running tests!
70
71         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
72
73 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
74
75         Reviewed by Csaba Osztrogonac.
76
77         [Qt][WK2] Canvas tests make css2.1 ones failing
78         https://bugs.webkit.org/show_bug.cgi?id=53427
79
80         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
81         Since the Qt port should eventually go to QRawFont, this issue will be resolved
82         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
83         needed for the workaround.
84
85         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
86         (WTR::LayoutTestController::platformInitialize):
87
88 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
89
90         Reviewed by Chris Fleizach.
91
92         [GTK] Provide a way in DRT to check the platform name
93         https://bugs.webkit.org/show_bug.cgi?id=56855
94
95         Patch for adding 'platformName' static property to DRT's
96         LayoutController and provide platform specific implementations.
97
98         In principle, this feature will be only of interest for writing
99         accessibility tests, so that's why it's only implemented in the
100         Mac, Gtk and Win platforms.
101
102         * DumpRenderTree/LayoutTestController.h: New method platformName().
103         * DumpRenderTree/LayoutTestController.cpp:
104         (getPlatformNameCallback): New callback for 'platformName'.
105         (LayoutTestController::staticValues): New static property.
106
107         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
108         (LayoutTestController::platformName): Implemented.
109
110         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
111         (LayoutTestController::platformName): Implemented.
112
113         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
114         (LayoutTestController::platformName): Implemented.
115
116 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
117
118         Reviewed by James Robinson.
119
120         Add mikelawther to committers.py
121         https://bugs.webkit.org/show_bug.cgi?id=62354
122
123         * Scripts/webkitpy/common/config/committers.py:
124
125 2011-06-08  Kent Tamura  <tkent@chromium.org>
126
127         [Chromium] Fix a typo.
128
129         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
130         (WebThemeControlDRTWin::draw):
131
132 2011-06-08  Kent Tamura  <tkent@chromium.org>
133
134         Reviewed by Hajime Morita.
135
136         [Chromium] Support vertical sliders in Windows DRT
137         https://bugs.webkit.org/show_bug.cgi?id=62352
138
139         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
140         (WebThemeControlDRTWin::draw):
141           Paint VerticalSliderThumbType and VerticalSliderTrackType.
142         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
143           Add VerticalSliderTrackType and VerticalSliderThumbType.
144         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
145         (WebThemeEngineDRTWin::paintTrackbar):
146           Convert Windows identifiers to the internal identifiers for vertical sliders.
147
148 2011-06-08  Ojan Vafai  <ojan@chromium.org>
149
150         Reviewed by Tony Chang.
151
152         add a short-flag for --experimental-fully-parallel
153         https://bugs.webkit.org/show_bug.cgi?id=62321
154
155         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
156
157 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
158
159         Reviewed by Tony Chang.
160
161         new-run-webkit-tests: don't turn the tree red when there are new passes
162         https://bugs.webkit.org/show_bug.cgi?id=62311
163
164         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
165         to match commandComplete.
166
167         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
168
169 2011-06-08  Tom Hudson  <tomhudson@google.com>
170
171         Reviewed by Mihai Parparita.
172
173         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
174         https://bugs.webkit.org/show_bug.cgi?id=60964
175
176         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
177         Add 'Sort tests by metric' link.
178         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
179         (disableSorting): Activate 'Sort tests by metric' link.
180         (enableSorting): Deactivate 'Sort tests by metric' link.
181         (selectDirectory): Call enableSorting()/disableSorting() depending
182         on currently selected failure type, and sort tests if requested.
183         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
184         New .disabled-control class for deactivated links.
185
186 2011-06-08  Tom Sepez  <tsepez@chromium.org>
187
188         Reviewed by Adam Barth.
189
190         Add web permissions callbacks for mixed content blocking.
191         https://bugs.webkit.org/show_bug.cgi?id=61946
192
193         * DumpRenderTree/chromium/LayoutTestController.cpp:
194         (LayoutTestController::setAllowDisplayOfInsecureContent):
195         (LayoutTestController::setAllowRunningOfInsecureContent):
196         (LayoutTestController::overridePreference):
197         * DumpRenderTree/chromium/WebPermissions.cpp:
198         (WebPermissions::allowDisplayingInsecureContent):
199         (WebPermissions::allowRunningInsecureContent):
200         (WebPermissions::setDisplayingInsecureContentAllowed):
201         (WebPermissions::setRunningInsecureContentAllowed):
202         (WebPermissions::reset):
203         * DumpRenderTree/chromium/WebPermissions.h:
204
205 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
206
207         Reviewed by Tony Chang.
208
209         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
210         https://bugs.webkit.org/show_bug.cgi?id=62259
211
212         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
213
214 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
215
216         Reviewed by Tony Chang.
217
218         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
219         https://bugs.webkit.org/show_bug.cgi?id=62303
220
221         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
222
223         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
224
225 2011-06-08  Greg Simon  <gregsimon@chromium.org>
226
227         Reviewed by Dimitri Glazkov.
228
229         Control Indexeddb backends from LayoutTestController
230         https://bugs.webkit.org/show_bug.cgi?id=61000
231
232         * DumpRenderTree/chromium/LayoutTestController.cpp:
233         (LayoutTestController::LayoutTestController):
234         (LayoutTestController::setOverrideIndexedDBBackingStore):
235         (LayoutTestController::clearAllDatabases):
236         * DumpRenderTree/chromium/LayoutTestController.h:
237
238 2011-06-08  Andreas Kling  <kling@webkit.org>
239
240         Add Pierre Rossi to contributors list for EZ-CC.
241
242         * Scripts/webkitpy/common/config/committers.py:
243
244 2011-06-08  Ilya Sherman  <isherman@chromium.org>
245
246         Reviewed by Andreas Kling.
247
248         Add Ilya Sherman to list of committers
249         https://bugs.webkit.org/show_bug.cgi?id=62270
250
251         * Scripts/webkitpy/common/config/committers.py:
252
253 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
254
255         Reviewed by Tony Chang.
256
257         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
258         https://bugs.webkit.org/show_bug.cgi?id=62178
259
260         Added commandComplete and evaluateCommand for NewRunWebKitTests class
261         to parse new-run-webkit-tests' results.
262
263         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
264
265 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
266
267         Reviewed by Eric Seidel.
268
269         webkitpy: add a popen() call to executive
270         https://bugs.webkit.org/show_bug.cgi?id=62179
271
272         This change adds a popen() wrapper call to the Executive object.
273         This will allow other webkitpy scripts that currently call
274         subprocess directly to use Executive, instead.
275
276         No additional tests are necessary (the existing tests cover the code).
277
278         * Scripts/webkitpy/common/system/executive.py:
279
280 2011-06-07  Sam Weinig  <sam@webkit.org>
281
282         Reviewed by Anders Carlsson.
283
284         Remove repeated IPC traffic from SetRenderTreeSize message
285         https://bugs.webkit.org/show_bug.cgi?id=62244
286
287         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
288         (WTR::InjectedBundlePage::InjectedBundlePage):
289         Add stub for didLayoutForFrame.
290
291 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
292
293         Reviewed by Tony Chang.
294
295         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
296         https://bugs.webkit.org/show_bug.cgi?id=62241
297
298         * Scripts/webkitpy/layout_tests/port/chromium.py:
299
300 2011-06-07  Adam Barth  <abarth@webkit.org>
301
302         Rubber-stamped by Eric Seidel.
303
304         Enable tests on the mac-ews
305
306         When we bring the mac-ews back up, we're going to try running tests!
307
308         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
309
310 2011-06-07  Dmitry Lomov  <dslomov@google.com>
311
312         Reviewed by David Levin.
313
314         https://bugs.webkit.org/show_bug.cgi?id=62215
315         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
316
317         * Scripts/webkitpy/style/checkers/cpp.py:
318         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
319
320 2011-06-07  Nico Weber  <thakis@chromium.org>
321
322         Reviewed by Dimitri Glazkov.
323
324         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
325         https://bugs.webkit.org/show_bug.cgi?id=62210
326
327         The change to TestEventPrinter fixes a latent bug, because
328         objects are deleted through the TestEventPrinter type, but none
329         of the subclasses have destructors or non-POD members.
330
331         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
332         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
333         discussed at http://codereview.chromium.org/7094005/, we prefer making
334         leaf class destructors virtual over making the leaf classes final.
335
336         * DumpRenderTree/chromium/NotificationPresenter.cpp:
337         (NotificationPresenter::~NotificationPresenter):
338         * DumpRenderTree/chromium/NotificationPresenter.h:
339         * DumpRenderTree/chromium/TestEventPrinter.cpp:
340         (TestEventPrinter::~TestEventPrinter):
341         * DumpRenderTree/chromium/TestEventPrinter.h:
342         * DumpRenderTree/chromium/WebViewHost.h:
343
344 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
345
346         Reviewed by Dirk Pranke.
347
348         [chromium] Chromium bots on build.webkit.org don't upload results.html
349         https://bugs.webkit.org/show_bug.cgi?id=61961
350
351         Don't fix the path on chromium port erroneously.
352
353         * BuildSlaveSupport/test-result-archive:
354
355 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
356
357         Fix the GTK+ build by ensuring that the autogenerated sources
358         necessary for libWebCoreInternals are recorded in a predeclared
359         variable before assigning to BUILT_SOURCES.
360
361         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
362
363 2011-06-06  Yong Li  <yoli@rim.com>
364
365         Reviewed by Eric Seidel.
366
367         https://bugs.webkit.org/show_bug.cgi?id=62097
368         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
369
370         * Scripts/webkitpy/style/checkers/cpp.py:
371         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
372
373 2011-06-06  Xan Lopez  <xlopez@igalia.com>
374
375         Reviewed by Martin Robinson.
376
377         [GTK] Enable feature/symbol detection in NWRT/GTK
378         https://bugs.webkit.org/show_bug.cgi?id=62136
379
380         Disable feature detection through DRT, since we don't support it,
381         and set the libwebcore patch correctly so that symbol detection
382         through 'nm' works.
383
384         * Scripts/webkitpy/layout_tests/port/gtk.py:
385
386 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
387
388         Reviewed by Tony Gentilcore.
389
390         Add a "prerender" state for page visibility.
391         https://bugs.webkit.org/show_bug.cgi?id=62062
392
393         * DumpRenderTree/chromium/LayoutTestController.cpp:
394         (LayoutTestController::setPageVisibility):
395
396 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
397
398         [Qt] Implement download feature for QtTestBrowser
399         https://bugs.webkit.org/show_bug.cgi?id=61865
400
401         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
402
403         * QtTestBrowser/launcherwindow.cpp:
404         (LauncherWindow::LauncherWindow):
405         * QtTestBrowser/launcherwindow.h:
406
407 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
408
409         Reviewed by Csaba Osztrogonác.
410
411         [Qt] Implement download feature for QtTestBrowser
412         https://bugs.webkit.org/show_bug.cgi?id=61865
413
414         * QtTestBrowser/launcherwindow.cpp:
415         (LauncherWindow::LauncherWindow):
416         (LauncherWindow::downloadRequest):
417         (LauncherWindow::fileDownloadFinished):
418         * QtTestBrowser/launcherwindow.h:
419
420 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
421
422         Reviewed by Dimitri Glazkov.
423
424         Make DumpRenderTree initialize window.internals.
425         https://bugs.webkit.org/show_bug.cgi?id=61076
426
427         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
428         * DumpRenderTree/win/FrameLoadDelegate.cpp:
429         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
430
431 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
432
433         Reviewed by Kent Tamura.
434
435         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
436         https://bugs.webkit.org/show_bug.cgi?id=61628
437
438         * Scripts/build-webkit:
439
440 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
441
442         Reviewed by Kent Tamura.
443
444         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
445         https://bugs.webkit.org/show_bug.cgi?id=61631
446
447         * Scripts/build-webkit:
448
449 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
450
451         Unreviewed. Fix the GTK+ build.
452
453         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
454
455 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
456
457         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
458         works properly).
459
460         * Scripts/webkitpy/common/config/committers.py:
461
462 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
463
464         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
465         WebKit scripts expect, so other scripts work properly with wx.
466
467         * waf/build/build_utils.py:
468         * waf/build/settings.py:
469
470 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
471
472         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
473         to build on Mac.
474
475         * waf/build/settings.py:
476         * wx/install-unix-extras:
477
478 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
479
480         [wx] Unreviewed build fixes for recent trunk changes.
481
482         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
483         (LayoutTestController::setTextDirection):
484         * waf/build/settings.py:
485
486 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
487
488         Fix the GTK+ build.
489
490         * GNUmakefile.am: Add some missing newline escape.
491
492 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
493
494         Try to fix the GTK+ bulid.
495
496         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
497         source list.
498
499 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
500
501         Reviewed by Adam Barth.
502
503         nrwt: should skip chromium test expectation overrides on upstream bots
504         https://bugs.webkit.org/show_bug.cgi?id=61888
505
506         * Scripts/webkitpy/layout_tests/port/chromium.py:
507         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
508
509 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
510
511         Reviewed by Ojan Vafai.
512
513         new-run-webkit-tests: minor logging, code cleanup
514         https://bugs.webkit.org/show_bug.cgi?id=62055
515
516         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
517         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
518
519 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
520
521         Try to fix the build failure on the GTK+ 32-bit Release bot.
522
523         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
524
525 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
526
527         Reviewed by Ryosuke Niwa.
528
529         [GTK] Support smart replace for the pasteboard
530         https://bugs.webkit.org/show_bug.cgi?id=61734
531
532         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
533         This is required to produce consistent test results.
534
535         * DumpRenderTree/gtk/DumpRenderTree.cpp:
536         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
537         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
538         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
539         methods which calls into DumpRenderTreeSupportGtk.
540
541 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
542
543         Reviewed by Dimitri Glazkov.
544
545         Teach Gtk build about window.internals
546         https://bugs.webkit.org/show_bug.cgi?id=61071
547
548         * DumpRenderTree/gtk/DumpRenderTree.cpp:
549         (webViewWindowObjectCleared): Inject the new internals object when the
550         window object clears.
551         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
552         Also do a little bit of cleanup.
553
554 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
555
556         Reviewed by Tony Chang.
557
558         Worker may not be stopped after LT.
559         https://bugs.webkit.org/show_bug.cgi?id=61847
560
561         Re-submit a variant of the first fix for this bug. It's possible
562         that actually calling cleanup() in the worker threads was taking
563         too long and we triggered the assertions in the manager thread.
564
565         I've bumped up the timeout in the manager and added better
566         diagnostics. I also cleaned up the cleanup() code a bit because
567         there was some unnecessary if-checks.
568
569         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
570         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
571
572 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
573
574         Reviewed by Tony Chang.
575
576         nrwt: fix duplicate logging regression
577         https://bugs.webkit.org/show_bug.cgi?id=61981
578
579         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
580
581 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
582
583         Reviewed by Adam Barth.
584
585         Modified addTouchPoint to correctly re-use touchPoint id values starting
586         from the lowest not-un-use touchPoint id as is done by the embedder
587         APIs. (Fixes BUGCR36415)
588
589         https://bugs.webkit.org/show_bug.cgi?id=62016
590
591         * DumpRenderTree/chromium/EventSender.cpp:
592         (EventSender::addTouchPoint):
593
594 2011-06-03  Cary Clark  <caryclark@google.com>
595
596         Reviewed by Eric Seidel.
597
598         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
599         https://bugs.webkit.org/show_bug.cgi?id=61534
600
601         Skia on Mac uses Skia to render WebKit, and CG
602         to render UI elements. The CG elements need a
603         transcribed graphics context that preserves the
604         canvas matrix, and the canvas clip.
605
606         The SkiaBitLocker utility class sets up a CGContext
607         from the SkCanvas, locks the bitmap's bits, and
608         releases the lock when the class goes out of scope.
609
610         The SkiaBitLocker implementation is described by
611         this patch:
612         http://codereview.chromium.org/7031006/
613
614         When WebKit uses Skia for rendering, the WebCanvas
615         is an SkCanvas. Create an equivalent CGContext to
616         draw the scrollbar thumb.
617
618         As the Chrome Mac port does not yet use Skia, this
619         patch has no effect and requires no tests.
620
621         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
622         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
623
624 2011-06-03  Andras Becsi  <abecsi@webkit.org>
625
626         Unreviewed build fix.
627
628         Fix typo.
629
630         * Scripts/old-run-webkit-tests:
631
632 2011-06-03  Andras Becsi  <abecsi@webkit.org>
633
634         Reviewed by Csaba Osztrogonác.
635
636         Print error message when there is no httpd present on the system
637         https://bugs.webkit.org/show_bug.cgi?id=61939
638
639         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
640         * Scripts/webkitperl/httpd.pm:
641
642 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
643
644         Reviewed by Yury Semikhatsky.
645
646         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
647         https://bugs.webkit.org/show_bug.cgi?id=61533
648
649         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
650
651         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
652         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
653         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
654         * DumpRenderTree/chromium/LayoutTestController.cpp:
655         (LayoutTestController::LayoutTestController):
656         (LayoutTestController::setJavaScriptProfilingEnabled):
657         * DumpRenderTree/chromium/LayoutTestController.h:
658         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
659         (LayoutTestController::setJavaScriptProfilingEnabled):
660         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
661         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
662         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
663
664 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
665
666         Reviewed by Tony Chang.
667
668         NRWT needs a way to log to a file without including backspaces without needing --verbose
669         https://bugs.webkit.org/show_bug.cgi?id=60328
670
671         This change modifies NRWT so that if it can tell if it is
672         writing to a terminal, it will overwrite any messages printed
673         in the 'one-line-progress' and 'updates' print options, and if
674         not (or if --verbose was specified) the messages will be printed
675         without backspaces.
676
677         If the overwriting updates are disabled, one-line-progress will
678         only print every 10 seconds instead of on every update. This
679         ensures that we still get updates once in a while while the
680         tests are running, even if we're not in --verbose mode. Note
681         that one-line-progress will now still be printed in --verbose,
682         since it's useful as long as you're not flooded with the
683         updates.
684
685         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
686         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
687         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
688
689 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
690
691         Reviewed by Gustavo Noronha Silva.
692
693         [GTK] autogen.sh is run twice for each buld on the bots
694         https://bugs.webkit.org/show_bug.cgi?id=61951
695
696         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
697         for the WebKit project. This prevents build-jsc runs from forcing subsequent
698         build-webkit runs to re-rerun autogen.sh.
699
700 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
701
702         Unreviewed, rolling out r87946.
703         http://trac.webkit.org/changeset/87946
704         https://bugs.webkit.org/show_bug.cgi?id=61965
705
706         Cause NRWT to break (Requested by abarth|gardener on #webkit).
707
708         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
709
710 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
711
712         Reviewed by Darin Adler.
713
714         Add build logistics and plumbing for window.internals object.
715         https://bugs.webkit.org/show_bug.cgi?id=60313
716
717         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
718         * DumpRenderTree/chromium/TestShell.cpp:
719         (TestShell::bindJSObjectsToWindow): Added injection code.
720         * DumpRenderTree/mac/FrameLoadDelegate.mm:
721         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
722
723 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
724
725         Reviewed by Dirk Pranke.
726
727         Call cleanup() explicitly at the end of worker.run().
728         https://bugs.webkit.org/show_bug.cgi?id=61847
729
730         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
731
732 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
733
734         Unreviewed, rolling out r87926.
735         http://trac.webkit.org/changeset/87926
736         https://bugs.webkit.org/show_bug.cgi?id=60313
737
738         Fails to find WebCoreTestSupport.dylib on bots.
739
740         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
741         * DumpRenderTree/chromium/TestShell.cpp:
742         (TestShell::bindJSObjectsToWindow):
743         * DumpRenderTree/mac/FrameLoadDelegate.mm:
744         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
745
746 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
747
748         Reviewed by Darin Adler.
749
750         Add build logistics and plumbing for window.internals object.
751         https://bugs.webkit.org/show_bug.cgi?id=60313
752
753         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
754         * DumpRenderTree/chromium/TestShell.cpp:
755         (TestShell::bindJSObjectsToWindow): Added injection code.
756         * DumpRenderTree/mac/FrameLoadDelegate.mm:
757         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
758
759 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
760
761         Reviewed by Eric Seidel.
762
763         Adjust efl coding style to more efl directories
764         https://bugs.webkit.org/show_bug.cgi?id=61903
765
766         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
767
768 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
769
770         Reviewed by Tony Chang.
771
772         old-run-webkit-tests: add support for audio files
773         https://bugs.webkit.org/show_bug.cgi?id=57992
774
775         * Scripts/old-run-webkit-tests:
776
777 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
778
779         Reviewed by Adam Barth.
780
781         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
782         https://bugs.webkit.org/show_bug.cgi?id=34314
783
784         * DumpRenderTree/DumpRenderTree.gypi:
785         * DumpRenderTree/chromium/LayoutTestController.cpp:
786         (LayoutTestController::LayoutTestController):
787         (LayoutTestController::setImagesAllowed):
788         (LayoutTestController::setStorageAllowed):
789         * DumpRenderTree/chromium/LayoutTestController.h:
790         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
791         (WebPermissions::WebPermissions):
792         (WebPermissions::~WebPermissions):
793         (WebPermissions::allowImages):
794         (WebPermissions::allowStorage):
795         (WebPermissions::setImagesAllowed):
796         (WebPermissions::setStorageAllowed):
797         (WebPermissions::reset):
798         * DumpRenderTree/chromium/WebPermissions.h:
799
800 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
801
802         Reviewed by Tony Chang.
803
804         Test plugin should support event logging on the windows port.
805         https://bugs.webkit.org/show_bug.cgi?id=61721
806
807         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
808         (handleEventWin): Well, handle them.
809
810 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
811
812         Reviewed by Tony Chang.
813
814         [chromium] Use correct file name for dragging out images.
815         https://bugs.webkit.org/show_bug.cgi?id=24887
816
817         * DumpRenderTree/chromium/EventSender.cpp:
818         (EventSender::EventSender):
819         (EventSender::dumpFilenameBeingDragged):
820         * DumpRenderTree/chromium/EventSender.h:
821
822 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
823
824         Reviewed by Tony Chang.
825
826         nrwt: make webaudio work w/o content-length header
827         https://bugs.webkit.org/show_bug.cgi?id=61819
828
829         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
830         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
831         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
832         * Scripts/webkitpy/layout_tests/port/webkit.py:
833
834 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
835
836         Reviewed by Andreas Kling.
837
838         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
839         https://bugs.webkit.org/show_bug.cgi?id=61802
840
841         Add command line parameter and menu item to MiniBrowser application 
842         enabling use of QGLWidget for browser viewport.
843
844         * MiniBrowser/qt/BrowserWindow.cpp:
845         (BrowserWindow::BrowserWindow):
846         (BrowserWindow::toggleGLViewport):
847         * MiniBrowser/qt/BrowserWindow.h:
848         * MiniBrowser/qt/MiniBrowserApplication.cpp:
849         (MiniBrowserApplication::handleUserOptions):
850         * MiniBrowser/qt/MiniBrowserApplication.h:
851         (WindowOptions::WindowOptions):
852
853 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
854
855         Reviewed by Xan Lopez.
856
857         Print out autogen arguments when they differ from the last set, to help
858         with debugging build issues.
859
860         * Scripts/webkitdirs.pm: Print out previous and current build arguments
861         when they differ.
862
863 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
864
865         Reviewed by Martin Robinson.
866
867         [GTK] run-launcher should run MiniBrowser in WebKit2
868         https://bugs.webkit.org/show_bug.cgi?id=61858
869
870         * Scripts/run-launcher: Check whether -2 command line option has
871         been passed and run MiniBrowser instead of GtkLauncher.
872
873 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
874
875         Reviewed by Dirk Pranke.
876
877         Fix exception in verbose printing mode.
878         https://bugs.webkit.org/show_bug.cgi?id=61723
879
880         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
881
882 2011-05-31  Yong Li  <yoli@rim.com>
883
884         Reviewed by Eric Seidel.
885
886         https://bugs.webkit.org/show_bug.cgi?id=54807
887         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
888         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
889         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
890         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
891         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
892         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
893         rule we should have in order to make our code independent from compilers and compiler flags.
894
895         * Scripts/webkitpy/style/checkers/cpp.py:
896
897 2011-05-31  Hironori Bono  <hbono@chromium.org>
898
899         Reviewed by Eric Seidel.
900
901         Add a JavaScript function layoutTestController.setTextDirection().
902         https://bugs.webkit.org/show_bug.cgi?id=50952
903
904         This change adds a new JavaScript function setTextDirection() to the
905         LayoutTestController class of Safari and Chrome to write layout tests
906         that changes the text direction of an editable element.
907
908         * DumpRenderTree/LayoutTestController.cpp:
909         (setTextDirectionCallback):
910         (LayoutTestController::staticFunctions):
911         * DumpRenderTree/LayoutTestController.h:
912         * DumpRenderTree/chromium/LayoutTestController.cpp:
913         (LayoutTestController::LayoutTestController):
914         (LayoutTestController::setTextDirection):
915         * DumpRenderTree/chromium/LayoutTestController.h:
916         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
917         (LayoutTestController::setTextDirection):
918         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
919         (LayoutTestController::setTextDirection):
920         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
921         (LayoutTestController::setTextDirection):
922
923 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
924
925         Reviewed by Simon Hausmann.
926
927         [Qt] User-agent list of Qt test browsers is very outdated
928         https://bugs.webkit.org/show_bug.cgi?id=61531
929
930         The user can edit the user-agent manually, so there's no need to have
931         a super complete and up to date list, but it's nice to have it
932         minimally updated.
933
934         * MiniBrowser/qt/useragentlist.txt:
935         * QtTestBrowser/useragentlist.txt:
936
937 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
938
939         Reviewed by Adam Roben.
940
941         [GTK] [WebKit2] Implement a basic WebKitTestRunner
942         https://bugs.webkit.org/show_bug.cgi?id=57068
943
944         Add an implementation of WebKitTestRunner for GTK+.
945
946         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
947         * Scripts/old-run-webkit-tests: Ditto.
948         * Scripts/run-launcher: Ditto.
949         * Scripts/webkitdirs.pm: Ditto.
950         * WebKitTestRunner/GNUmakefile.am: Added.
951         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
952         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
953         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
954         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
955         * WebKitTestRunner/PlatformWebView.h:
956         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
957         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
958         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
959         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
960         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
961         (main): Added.
962
963 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
964
965         Reviewed by Tony Chang.
966
967         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
968         https://bugs.webkit.org/show_bug.cgi?id=60241
969
970         * Scripts/new-run-webkit-tests:
971
972 2011-05-31  Eric Seidel  <eric@webkit.org>
973
974         Reviewed by David Kilzer.
975
976         webkitpy should create zips with zip -9
977         https://bugs.webkit.org/show_bug.cgi?id=61789
978
979         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
980
981         * Scripts/webkitpy/common/system/workspace.py:
982         * Scripts/webkitpy/common/system/workspace_unittest.py:
983
984 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
985
986         Reviewed by Csaba Osztrogonác.
987
988         [Qt] Implement find feature for QtTestBrowser
989         https://bugs.webkit.org/show_bug.cgi?id=61425
990
991         Buildfix for --minimal and CONFIG+=qt_minimal build.
992
993         * QtTestBrowser/launcherwindow.cpp:
994         (LauncherWindow::LauncherWindow):
995         (LauncherWindow::createChrome):
996         * QtTestBrowser/launcherwindow.h:
997
998 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
999
1000         Reviewed by Csaba Osztrogonác.
1001
1002         [Qt] Implement find feature for QtTestBrowser
1003         https://bugs.webkit.org/show_bug.cgi?id=61425
1004
1005         * QtTestBrowser/launcherwindow.cpp:
1006         (LauncherWindow::LauncherWindow):
1007         (LauncherWindow::createChrome):
1008         (LauncherWindow::showFindBar):
1009         (LauncherWindow::find):
1010         * QtTestBrowser/launcherwindow.h:
1011
1012 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1013
1014         Reviewed by Martin Robinson.
1015
1016         [GTK] Implement JavaScript dialogs in MiniBrowser
1017         https://bugs.webkit.org/show_bug.cgi?id=61725
1018
1019         * MiniBrowser/gtk/BrowserWindow.c:
1020         (WKStringGetCString): Helper function to get a UTF-8 c string from
1021         a WKStringRef.
1022         (WKURLGetCString): Helper function to get a UTF-8 c string from a
1023         WKURLRef.
1024         (browserWindowUpdateURL): Update to use WKURLGetCString.
1025         (didReceiveTitleForFrame): Update to use WKStringGetCString.
1026         (createMessageDialog): Create a GtkMessageDialog.
1027         (runJavaScriptAlert):
1028         (runJavaScriptConfirm):
1029         (runJavaScriptPrompt):
1030         (browserWindowUIClientInit):
1031
1032 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
1033
1034         Reviewed by Kent Tamura.
1035
1036         WebSocket closing handshake
1037         https://bugs.webkit.org/show_bug.cgi?id=35721
1038
1039         * Scripts/webkitpy/thirdparty/__init__.py:
1040         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1041         to get the right behavior of closing handshake.
1042
1043 2011-05-29  Daniel Bates  <dbates@rim.com>
1044
1045         Reviewed by David Kilzer.
1046
1047         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
1048         https://bugs.webkit.org/show_bug.cgi?id=61162
1049
1050         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
1051         that omits a line count. In particular, the chunk range regular expression does
1052         not match a chunk range line that omits a line count. GNU diff(1) will omit the
1053         line count in the chunk range if the line count is exactly 1. For example, appending
1054         a new line to the end of an existing file F that contains exactly one line of text will
1055         be represented in a diff with a chunk range line that omits the line count for F.
1056
1057         * Scripts/VCSUtils.pm:
1058           (parseChunkRange): Added.
1059         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
1060         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1061           - Added unit test "Git: Append new line to the end of an existing file".
1062
1063 2011-05-28  Adam Barth  <abarth@webkit.org>
1064
1065         Reviewed by Eric Seidel.
1066
1067         EWS builds patches that fail to build twice, which seems useless and slows down the bots
1068         https://bugs.webkit.org/show_bug.cgi?id=55585
1069
1070         This patch switches all the early warning system bots over to the new
1071         PatchAnalysisTask-based infrastructure.  This patch makes these bots
1072         more efficient (in the case where patches fail to build) and paves the
1073         way for running tests on these bots!
1074
1075         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1076         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1077         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1078         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1079         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1080         * Scripts/webkitpy/tool/commands/queues.py:
1081
1082 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
1083
1084         Reviewed by Kent Tamura.
1085
1086         Add bashi as a committer.
1087
1088         https://bugs.webkit.org/show_bug.cgi?id=61685
1089
1090         * Scripts/webkitpy/common/config/committers.py:
1091
1092 2011-05-27  Adam Barth  <abarth@webkit.org>
1093
1094         Reviewed by Eric Seidel.
1095
1096         When checking whether the tree is red, the EWS posts a link to the wrong log
1097         https://bugs.webkit.org/show_bug.cgi?id=61072
1098
1099         We need to cache the original script error because that contains the
1100         failure log we want to upload.  If we don't cache that script error,
1101         self._script_error will get overwritten when we sanity check the clean
1102         tree (and it also has test failures).
1103
1104         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1105             - This testing approach is slightly goofy.  We'd like to use
1106               assertRaisesRegexp, but that's not available until Python 2.7.
1107         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1108
1109 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
1110
1111         Reviewed by Adam Barth.
1112
1113         Add layoutTestController.setStorageAllowed() to control whether access
1114         to the localStorage API is enabled via the WebPermissionClient
1115         https://bugs.webkit.org/show_bug.cgi?id=61581
1116
1117         * DumpRenderTree/chromium/LayoutTestController.cpp:
1118         (LayoutTestController::LayoutTestController):
1119         (LayoutTestController::setStorageAllowed):
1120         * DumpRenderTree/chromium/LayoutTestController.h:
1121         * DumpRenderTree/chromium/TestShell.cpp:
1122         (TestShell::TestShell):
1123         (TestShell::createNewWindow):
1124         * DumpRenderTree/chromium/TestShell.h:
1125         * DumpRenderTree/chromium/WebPermissions.h: Added.
1126         (WebPermissions::WebPermissions):
1127         (WebPermissions::allowStorage):
1128         (WebPermissions::setStorageAllowed):
1129         (WebPermissions::reset):
1130
1131 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1132
1133         Reviewed by Eric Seidel.
1134
1135         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
1136         https://bugs.webkit.org/show_bug.cgi?id=60326
1137
1138         This patch removes a lot of the complexity from the
1139         metered_stream implementation that was unnecessary since there
1140         was only one caller and the logic could be coordinated better.
1141
1142         There should be no functional changes in this patch, just code
1143         getting deleted and cleaned up.
1144
1145         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1146         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
1147         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1148         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1149
1150 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1151
1152         Reviewed by Eric Seidel.
1153
1154         NRWT: minor cleanup in printing module
1155         https://bugs.webkit.org/show_bug.cgi?id=60329
1156
1157         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1158
1159 2011-05-27  Steve Lacey  <sjl@chromium.org>
1160
1161         Reviewed by David Levin.
1162
1163         Add sjl@chromium.org as a committer.
1164
1165         https://bugs.webkit.org/show_bug.cgi?id=61672
1166
1167         * Scripts/webkitpy/common/config/committers.py:
1168
1169 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1170
1171         Reviewed by Adam Barth.
1172
1173         NRWT: remove --print detailed-progress
1174         https://bugs.webkit.org/show_bug.cgi?id=60324
1175
1176         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1177         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1178         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1179         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1180
1181 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1182
1183         Reviewed by Ojan Vafai.
1184
1185         NRWT: debug messages from the workers are being logged twice
1186         https://bugs.webkit.org/show_bug.cgi?id=60428
1187
1188         It looks like when the workers are run in separate processes
1189         we end up getting two copies of every log message they print.
1190         This has to do with the multiprocessing module on UNIX cloning
1191         the log configuration in a way I wasn't expecting, and so two
1192         log handlers end up getting registered.
1193
1194         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1195         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1196         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1198
1199 2011-05-27  Adam Roben  <aroben@apple.com>
1200
1201         Always decode tester names from location.hash
1202
1203         When navigating directly to a tester-specific URL (e.g.,
1204         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
1205         with a URL-encoded tester name in the page, and then the encoded name could make its way
1206         into Bugzilla bugs. Bad!
1207
1208         Reviewed by David Kilzer.
1209
1210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1211         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
1212         decodeURIComponent before trying to use it.
1213
1214 2011-05-27  Adam Roben  <aroben@apple.com>
1215
1216         Remove testing code that snuck into r87528
1217
1218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1219         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
1220
1221 2011-05-27  Adam Roben  <aroben@apple.com>
1222
1223         Add links to TestFailures to easily file bugs about failing tests
1224
1225         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
1226         links to file bugs for failing tests
1227
1228         Reviewed by David Kilzer.
1229
1230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1231         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
1232         for a particular build.
1233         (Builder.prototype._getFailingTests): Use resultsPageURL.
1234
1235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1236         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
1237         failures.
1238         (ViewController.prototype._domForBuildName): Use resultsPageURL.
1239         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
1240         new bug link. The bug has a title, description, and URL already filled in for you!
1241
1242 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1243
1244         Unreviewed, rolling out r87464.
1245         http://trac.webkit.org/changeset/87464
1246         https://bugs.webkit.org/show_bug.cgi?id=61643
1247
1248         client-close/server-close tests are flaky on Chromium Mac and
1249         Windows (Requested by aklein on #webkit).
1250
1251         * Scripts/webkitpy/thirdparty/__init__.py:
1252
1253 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
1254
1255         Added Douglas Davidson to contributors list for easier CC'ing.
1256
1257         * Scripts/webkitpy/common/config/committers.py:
1258
1259 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1260
1261         Reviewed by Adam Barth.
1262
1263         Fix worldID and destinationDomain argument names
1264         https://bugs.webkit.org/show_bug.cgi?id=61571
1265
1266         As part of working on r87423, I noticed a couple of inconsistencies in
1267         argument names:
1268         - We would use worldId in .h files but worldID in .cpp files.
1269           Standardize on the latter
1270         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
1271           destinationDomains argument, even though the actual parameter was for
1272           a single domain (renamed to be singular).
1273
1274         * DumpRenderTree/LayoutTestController.h:
1275         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1276         (LayoutTestController::evaluateScriptInIsolatedWorld):
1277
1278 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
1279
1280         Reviewed by Kent Tamura.
1281
1282         WebSocket closing handshake
1283         https://bugs.webkit.org/show_bug.cgi?id=35721
1284
1285         * Scripts/webkitpy/thirdparty/__init__.py:
1286         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1287         to get the right behavior of closing handshake.
1288
1289 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
1290
1291         Reviewed by Andreas Kling.
1292
1293         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
1294         https://bugs.webkit.org/show_bug.cgi?id=42676
1295
1296         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
1297
1298         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1299         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1300         (WTR::InjectedBundle::beginTesting):
1301         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1302         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
1303         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1304
1305 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1306
1307         Reviewed by Andreas Kling.
1308
1309         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
1310         https://bugs.webkit.org/show_bug.cgi?id=61527
1311
1312         The setMaximumHeight() call is unecessary and breaks the dialog at
1313         least on my setup.
1314
1315         * QtTestBrowser/launcherwindow.cpp:
1316         (LauncherWindow::showUserAgentDialog):
1317
1318 2011-05-02  Robert Hogan  <robert@webkit.org>
1319
1320         Reviewed by Adam Roben.
1321
1322         [Qt] Allow popup windows from plugins when initiated by a user gesture
1323
1324         https://bugs.webkit.org/show_bug.cgi?id=41292
1325
1326         Support parameters introduced in plugin-initiate-popup-window.html
1327
1328         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1329         (webkit_test_plugin_new_instance):
1330         (webkit_test_plugin_handle_event):
1331
1332 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1333
1334         Reviewed by Adam Barth.
1335
1336         Support cross-origin XMLHttpRequest in isolated worlds
1337         https://bugs.webkit.org/show_bug.cgi?id=59843
1338
1339         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
1340
1341         * DumpRenderTree/chromium/LayoutTestController.cpp:
1342         (LayoutTestController::LayoutTestController):
1343         (LayoutTestController::setIsolatedWorldSecurityOrigin):
1344         * DumpRenderTree/chromium/LayoutTestController.h:
1345
1346 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
1347
1348         Reviewed by Adam Roben.
1349
1350         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
1351         https://bugs.webkit.org/show_bug.cgi?id=61474
1352         <rdar://problem/9468337>
1353
1354         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1355         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
1356
1357 2011-05-26  Andreas Kling  <kling@webkit.org>
1358
1359         Unreviewed, correct address to webkit-committers mailing list.
1360
1361         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1362
1363 2011-05-25  Adam Roben  <aroben@apple.com>
1364
1365         Don't assume that builds finish in the order they were started
1366
1367         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
1368         build when one slave is taking a long time to finish a build
1369
1370         Reviewed by Antti Koivisto.
1371
1372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1373         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
1374         newer than the oldest in-progress build are also themselves in progress. Just check whether
1375         each build is actually in progress (as signified by its presence in the currentBuilds set).
1376
1377 2011-05-25  Adam Roben  <aroben@apple.com>
1378
1379         Correctly detect cases where only a single test failed/crashed/timed out
1380
1381         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
1382         failing test
1383
1384         Reviewed by Darin Adler.
1385
1386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1387         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
1388         will be singular when only a single test fails/crashes/times out.
1389
1390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1391         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
1392         failed/crashed/timed out.
1393
1394 2011-05-26  Tom Hudson  <tomhudson@google.com>
1395
1396         Reviewed by Tony Chang.
1397
1398         Add flags to Chromium ImageDiff to write image comparison metrics on
1399         stdout.
1400         https://bugs.webkit.org/show_bug.cgi?id=60569
1401
1402         * DumpRenderTree/chromium/ImageDiff.cpp:
1403         (Image::createFromStdin): Fix spelling.
1404         (maxOf3): New function to do 3-way maximum.
1405         (getRedComponent): Extract red component from ABGR packed encoding.
1406         (getGreenComponent): Extract green component from ABGR packed encoding.
1407         (getBlueComponent): Extract blue component from ABGR packed encoding.
1408         (weightedPercentageDifferent): Determine % of pixels different in two
1409         images multiplied by intensity difference of each pixel.
1410         (printHelp): Document new arguments.
1411         (compareImages): Parameterize.
1412         (untestedCompareImages): Parameterize.
1413         (diffImages): Parameterize; write results on stdout if requested.
1414         (main): Parse new arguments.
1415
1416 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1417
1418         Reviewed by Simon Hausmann.
1419
1420         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
1421         https://bugs.webkit.org/show_bug.cgi?id=42697
1422
1423         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
1424
1425         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1426         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1427         (WTR::InjectedBundle::beginTesting):
1428         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1429         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
1430         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1431
1432 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
1433
1434         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
1435         https://bugs.webkit.org/show_bug.cgi?id=61428
1436         <rdar://problem/9457006>
1437
1438         Reviewed by Adam Roben.
1439
1440         The crash occurs when Flash posts a message to a window that it
1441         creates, and in processing the message, it calls NPN_Evaluate to
1442         evaluate JavaScript that removes the plug-in from the page. Flash then
1443         crashes when we return to Flash code.
1444
1445         This test emulates that behavior.
1446
1447         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
1448         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
1449         Initialize member vars.
1450         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
1451         Remove our custom property from the message window, and destroy it.
1452         (CallJSThatDestroysPlugin::NPP_Destroy):
1453         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
1454         layout test controller that we're done.
1455         (wndProc):
1456         Get the PluginTest object, and call its runTest() function.
1457         (CallJSThatDestroysPlugin::NPP_New):
1458         Setup the test: register a class for the message-only window, create
1459         it, and post a message to it to run the test.
1460         (CallJSThatDestroysPlugin::runTest):
1461         Execute JS that removes the plug-in from the page, and if we're not
1462         destroyed, log a success message.
1463
1464         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1465         Add new test to project.
1466
1467 2011-05-25  Tony Chang  <tony@chromium.org>
1468
1469         Reviewed by Adam Barth.
1470
1471         webkitpy's NetworkTransaction shouldn't use mechanize
1472         https://bugs.webkit.org/show_bug.cgi?id=61450
1473
1474         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
1475         use urllib2 directly.  Re-add NetworkTransaction to
1476         test_results_uploader.py (reverting r87124).
1477
1478         * Scripts/webkitpy/common/net/networktransaction.py:
1479         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1480
1481 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1482
1483         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
1484         until the port begins using those export macros.
1485
1486         * DumpRenderTree/chromium/config.h:
1487
1488 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1489
1490         Unreviewed, rolling out r87257.
1491         http://trac.webkit.org/changeset/87257
1492         https://bugs.webkit.org/show_bug.cgi?id=61457
1493
1494         This broke layout tests, see bug 61431. (Requested by
1495         hwennborg on #webkit).
1496
1497         * DumpRenderTree/chromium/LayoutTestController.cpp:
1498         (LayoutTestController::LayoutTestController):
1499         (LayoutTestController::clearAllDatabases):
1500         * DumpRenderTree/chromium/LayoutTestController.h:
1501
1502 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1503
1504         Reviewed by Andreas Kling.
1505
1506         [Qt] fast/css/disabled-author-styles.html failed
1507         https://bugs.webkit.org/show_bug.cgi?id=61438
1508
1509         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
1510
1511         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1512         (WebCore::WebPage::resetSettings):
1513         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1514         (LayoutTestController::setAuthorAndUserStylesEnabled):
1515         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1516
1517 2011-05-25  Adam Roben  <aroben@apple.com>
1518
1519         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
1520
1521         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
1522         started exiting early due to too many crashes, timeouts, or failures
1523
1524         Reviewed by David Kilzer.
1525
1526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1527         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
1528         run-webkit-tests exits early due to too many failures, pass that information in another
1529         argument to the callback.
1530         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
1531         the new structure of the object passed to the callback.
1532         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
1533         getNumberOfFailingTests and to pass that along to our own callbacks.
1534         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
1535         from _getFailingTests and to store that value in the history object.
1536
1537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1538         (.info): Added.
1539
1540         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1541         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
1542         object and to add a note when run-webkit-tests exited early due to too many failures.
1543         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
1544         latestBuildInfos since each entry now contains more than just the tester and failure count.
1545         Now displays a message for testers where the latest build exited early due to too many
1546         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
1547         store that value in latestBuildInfos.
1548
1549 2011-05-24  Keishi Hattori  <keishi@webkit.org>
1550
1551         Reviewed by Kent Tamura.
1552
1553         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
1554         https://bugs.webkit.org/show_bug.cgi?id=61273
1555
1556         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
1557
1558 2011-05-24  Greg Simon  <gregsimon@chromium.org>
1559
1560         Reviewed by Dimitri Glazkov.
1561
1562         Control Indexeddb backends from LayoutTestController
1563         https://bugs.webkit.org/show_bug.cgi?id=61000
1564
1565         * DumpRenderTree/chromium/LayoutTestController.cpp:
1566         (LayoutTestController::LayoutTestController):
1567         (LayoutTestController::setOverrideIndexedDBBackingStore):
1568         (LayoutTestController::clearAllDatabases):
1569         * DumpRenderTree/chromium/LayoutTestController.h:
1570
1571 2011-05-24  Robert Hogan  <robert@webkit.org>
1572
1573         Reviewed by Ryosuke Niwa.
1574
1575         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
1576         https://bugs.webkit.org/show_bug.cgi?id=61393
1577
1578         * DumpRenderTree/qt/EventSenderQt.h:
1579         * DumpRenderTree/qt/EventSenderQt.cpp:
1580         (getModifiers): static function for interpreting modifiers
1581         (EventSender::mouseDown): Respect keyboard modifiers
1582         (EventSender::keyDown): use new static function
1583         (EventSender::sendOrQueueEvent): whitespace fix
1584
1585 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
1586
1587         Reviewed by Adam Barth.
1588
1589         Adding MHTML reading support.
1590         https://bugs.webkit.org/show_bug.cgi?id=7168
1591
1592         * Scripts/build-webkit:
1593         * Scripts/old-run-webkit-tests:
1594         * Scripts/webkitperl/features.pm:
1595         * Scripts/webkitpy/layout_tests/port/test_files.py:
1596         * Scripts/webkitpy/layout_tests/port/webkit.py:
1597
1598 2011-05-24  Stephen White  <senorblanco@chromium.org>
1599
1600         Reviewed by Kenneth Russell.
1601
1602         Remove most style checks on Source/ThirdParty/glu, since it doesn't
1603         follow WebKit style.
1604         https://bugs.webkit.org/show_bug.cgi?id=61365
1605
1606         * Scripts/webkitpy/style/checker.py:
1607
1608 2011-05-24  Adam Roben  <aroben@apple.com>
1609
1610         Don't allow forcing builds through the build.webkit.org web interface
1611
1612         Someone has been forcing bogus builds.
1613
1614         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1615
1616 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
1617
1618         Reviewed by Adam Roben.
1619
1620         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1621         https://bugs.webkit.org/show_bug.cgi?id=42669
1622
1623         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
1624         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
1625         Because that case changed the setting.
1626
1627         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1628         (WTR::InjectedBundle::beginTesting):
1629
1630 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1631
1632         Reviewed by Kenneth Rohde Christiansen.
1633
1634         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
1635         https://bugs.webkit.org/show_bug.cgi?id=61052
1636
1637         * Scripts/old-run-webkit-tests:
1638
1639 2011-05-24  Adam Roben  <aroben@apple.com>
1640
1641         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
1642
1643         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
1644         that don't have any failing tests, which isn't useful
1645
1646         Reviewed by David Kilzer.
1647
1648         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
1649         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
1650         instead of name strings.
1651         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
1652         builder names into an array of builders.
1653
1654         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1655         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
1656         the most recently completed build, or -1 if there is no such build.
1657         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
1658         in the given build, or -1 if the number could not be determined. Some of this code came from
1659         _getFailingTests.
1660         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
1661         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
1662         getNumberOfFailingTests functions.
1663
1664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1665         (ViewController.prototype._displayTesters): Get the current number of test failures for each
1666         tester and show it in the list. Omit testers that have no failures at all. We keep the
1667         testers and failure counts in an array and sort it before displaying the current data, as
1668         the order in which data will be fetched is unpredictable.
1669
1670 2011-05-23  Tony Chang  <tony@chromium.org>
1671
1672         Reviewed by Ojan Vafai.
1673
1674         [nrwt] don't use NetworkTranslation when uploading results
1675         https://bugs.webkit.org/show_bug.cgi?id=61315
1676
1677         This avoids autoinstalling mechanize.  It didn't matter anyway
1678         because test_results_uploader.py wasn't using mechanize to make the
1679         request so NetworkTransaction::run wasn't doing anything extra
1680         (it only matters if it catches mechanize.HTTPError).
1681
1682         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1683
1684 2011-05-23  Tony Chang  <tony@chromium.org>
1685
1686         Reviewed by Dirk Pranke.
1687
1688         [chromium] fix the rebaseline tool to work with Linux GPU failures
1689         https://bugs.webkit.org/show_bug.cgi?id=61312
1690
1691         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1692
1693 2011-05-23  Darin Adler  <darin@apple.com>
1694
1695         Ignore generated .pyc files in a directory full of python code.
1696
1697         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
1698
1699 2011-05-23  Adam Barth  <abarth@webkit.org>
1700
1701         Reviewed by Eric Seidel.
1702
1703         sheriffbot should give more details about the failures in IRC
1704         https://bugs.webkit.org/show_bug.cgi?id=61233
1705
1706         With this patch, sheriffbot will annonce the set of failing tests,
1707         which might help folks triage the problem.
1708
1709         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1710         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1711
1712 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1713
1714         Unreviewed, rolling out r87078.
1715         http://trac.webkit.org/changeset/87078
1716         https://bugs.webkit.org/show_bug.cgi?id=61294
1717
1718         Patch contains errors and seems likely to break a bunch of
1719         bots (Requested by abarth on #webkit).
1720
1721         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1722         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1723         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1724
1725 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
1726
1727         Reviewed by Ojan Vafai.
1728
1729         Convert json_results_generator.py to output version 4 JSON.
1730         https://bugs.webkit.org/show_bug.cgi?id=60869
1731
1732         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1733         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1734         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1735
1736 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
1737
1738         Reviewed by Adam Barth.
1739
1740         Move generation of shell_command from port to executive
1741         https://bugs.webkit.org/show_bug.cgi?id=61251
1742
1743         After move it's possible to use the code in other places too.
1744
1745         * Scripts/webkitpy/common/config/ports.py:
1746         * Scripts/webkitpy/common/system/executive.py:
1747
1748 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
1749
1750         Reviewed by Darin Adler.
1751
1752         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1753         https://bugs.webkit.org/show_bug.cgi?id=42669
1754
1755         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
1756
1757         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1758         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1759         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
1760         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1761
1762 2011-05-22  Robert Hogan  <robert@webkit.org>
1763
1764         Reviewed by Kenneth Rohde Christiansen.
1765
1766         Fix policyDelegate in Qt DRT
1767         https://bugs.webkit.org/show_bug.cgi?id=61247
1768
1769         Use the 'policy delegate' implemented in FrameLoaderClient
1770         for layout tests. The partial implementation in DumpRenderTreeQt
1771         is redundant, so remove it.
1772
1773         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1774         (WebCore::WebPage::acceptNavigationRequest):
1775         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1776         (LayoutTestController::waitForPolicyDelegate):
1777
1778 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
1779
1780         Reviewed by Darin Adler.
1781
1782         Use double quotes for filename arguments
1783         https://bugs.webkit.org/show_bug.cgi?id=61250
1784
1785         Windows does not support single quotes on the command line,
1786         so replace them with double quotes.
1787
1788         * Scripts/prepare-ChangeLog:
1789
1790 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
1791
1792         Reviewed by Sam Weinig.
1793
1794         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
1795         https://bugs.webkit.org/show_bug.cgi?id=42550
1796         
1797         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
1798
1799         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1800         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1801         Copy the code for pausing animations, FIXME comments and all.
1802         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1803         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1804
1805 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
1806
1807         Reviewed by Stephen White.
1808
1809         Adding myself to the committers list.
1810
1811         * Scripts/webkitpy/common/config/committers.py:
1812
1813 2011-05-19  Adam Roben  <aroben@apple.com>
1814
1815         Test that the WebKit2 UI process doesn't crash when starting a download
1816
1817         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
1818         (preceded by assertion) in fastMalloc when downloading a file
1819
1820         Reviewed by Darin Adler.
1821
1822         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
1823
1824         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
1825         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
1826         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
1827         started, cancel the download, and return a bogus string.
1828
1829         (TestWebKitAPI::setContextDownloadClient):
1830         (TestWebKitAPI::setPagePolicyClient):
1831         Simple helper functions.
1832
1833         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
1834         our policy client, and run until we know that the download was started. If we haven't
1835         crashed, we win!
1836
1837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1838         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1839         * TestWebKitAPI/win/copy-resources.cmd:
1840         Added new files.
1841
1842 2011-05-20  Kent Tamura  <tkent@chromium.org>
1843
1844         Reviewed by Ryosuke Niwa.
1845
1846         Fix style errors in DumpRenderTree/chromium/.
1847         https://bugs.webkit.org/show_bug.cgi?id=61172
1848
1849         * DumpRenderTree/chromium/CppBoundClass.cpp:
1850         (CppBoundClass::getAsCppVariant):
1851         (CppBoundClass::bindToJavascript):
1852         * DumpRenderTree/chromium/CppBoundClass.h:
1853         (CppBoundClass::GetterCallback::~GetterCallback):
1854         (CppBoundClass::CppBoundClass):
1855         (CppBoundClass::Callback::~Callback):
1856         (CppBoundClass::MemberCallback::MemberCallback):
1857         (CppBoundClass::MemberCallback::~MemberCallback):
1858         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
1859         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
1860         * DumpRenderTree/chromium/CppVariant.h:
1861         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1862         (DRTDevToolsAgent::~DRTDevToolsAgent):
1863         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1864         (DRTDevToolsClient::sendFrontendLoaded):
1865         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1866         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1867         (main):
1868         * DumpRenderTree/chromium/EventSender.cpp:
1869         (SavedEvent::SavedEvent):
1870         (EventSender::EventSender):
1871         (EventSender::keyDown):
1872         * DumpRenderTree/chromium/EventSender.h:
1873         * DumpRenderTree/chromium/ImageDiff.cpp:
1874         (Image::Image):
1875         * DumpRenderTree/chromium/LayoutTestController.cpp:
1876         (LayoutTestController::LayoutTestController):
1877         (LayoutTestController::WorkQueue::reset):
1878         (WorkItemBackForward::WorkItemBackForward):
1879         (WorkItemLoadingScript::WorkItemLoadingScript):
1880         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
1881         (WorkItemLoad::WorkItemLoad):
1882         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1883         (LayoutTestController::pathToLocalResource):
1884         * DumpRenderTree/chromium/LayoutTestController.h:
1885         (LayoutTestController::WorkItem::~WorkItem):
1886         (LayoutTestController::WorkQueue::WorkQueue):
1887         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1888         (MockSpellCheck::MockSpellCheck):
1889         (MockSpellCheck::~MockSpellCheck):
1890         * DumpRenderTree/chromium/MockSpellCheck.h:
1891         * DumpRenderTree/chromium/NotificationPresenter.h:
1892         (NotificationPresenter::NotificationPresenter):
1893         * DumpRenderTree/chromium/Task.cpp:
1894         (WebTask::WebTask):
1895         * DumpRenderTree/chromium/Task.h:
1896         (TaskList::TaskList):
1897         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1898         (DRTPrinter::DRTPrinter):
1899         (TestShellPrinter::TestShellPrinter):
1900         * DumpRenderTree/chromium/TestNavigationController.cpp:
1901         (TestNavigationEntry::TestNavigationEntry):
1902         (TestNavigationEntry::~TestNavigationEntry):
1903         (TestNavigationController::TestNavigationController):
1904         (TestNavigationController::reload):
1905         (TestNavigationController::loadEntry):
1906         (TestNavigationController::didNavigateToEntry):
1907         * DumpRenderTree/chromium/TestNavigationController.h:
1908         (TestShellExtraData::TestShellExtraData):
1909         * DumpRenderTree/chromium/TestShell.cpp:
1910         (dumpHistoryItem):
1911         * DumpRenderTree/chromium/TestShell.h:
1912         (TestParams::TestParams):
1913         * DumpRenderTree/chromium/TestShellWin.cpp:
1914         (TestShell::waitTestFinished):
1915         * DumpRenderTree/chromium/TestWebWorker.h:
1916         (TestWebWorker::startWorkerContext):
1917         (TestWebWorker::terminateWorkerContext):
1918         (TestWebWorker::postMessageToWorkerContext):
1919         (TestWebWorker::clientDestroyed):
1920         (TestWebWorker::postMessageToWorkerObject):
1921         (TestWebWorker::postExceptionToWorkerObject):
1922         (TestWebWorker::postConsoleMessageToWorkerObject):
1923         (TestWebWorker::confirmMessageFromWorkerObject):
1924         (TestWebWorker::reportPendingActivity):
1925         (TestWebWorker::workerContextClosed):
1926         (TestWebWorker::~TestWebWorker):
1927         * DumpRenderTree/chromium/TextInputController.cpp:
1928         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1929         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1930         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1931         (WebThemeEngineDRTWin::paintButton):
1932         (WebThemeEngineDRTWin::paintMenuList):
1933         (WebThemeEngineDRTWin::paintTrackbar):
1934         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
1935         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1936         * DumpRenderTree/chromium/WebViewHost.cpp:
1937         (WebViewHost::navigate):
1938         (WebViewHost::updateSessionHistory):
1939         (WebViewHost::paintInvalidatedRegion):
1940         * DumpRenderTree/chromium/WebViewHost.h:
1941
1942 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1943
1944         Reviewed by Adam Roben.
1945
1946         Detect hangs in run-api-tests
1947         https://bugs.webkit.org/show_bug.cgi?id=48043
1948
1949         * Scripts/run-api-tests: Added test timeouts
1950
1951 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1952
1953         Reviewed by Adam Roben.
1954
1955         run-api-tests should run one test per process
1956         https://bugs.webkit.org/show_bug.cgi?id=61088
1957
1958         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
1959         return code, and parsing GTest output format.
1960
1961 2011-05-15  Robert Hogan  <robert@webkit.org>
1962
1963         Reviewed by Antonio Gomes.
1964
1965         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
1966         https://bugs.webkit.org/show_bug.cgi?id=60834
1967         Fix unix test plugin for plugins/get-url-with-javascript-url.html
1968
1969         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1970         (webkit_test_plugin_new_stream):
1971         (webkit_test_plugin_write_ready):
1972         (webkit_test_plugin_write):
1973
1974 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1975
1976         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
1977         http://trac.webkit.org/changeset/86869
1978         http://trac.webkit.org/changeset/86873
1979         http://trac.webkit.org/changeset/86875
1980         http://trac.webkit.org/changeset/86877
1981         https://bugs.webkit.org/show_bug.cgi?id=61139
1982
1983         broke builds and debug DRT (Requested by rniwa on #webkit).
1984
1985         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1986         * DumpRenderTree/chromium/TestShell.cpp:
1987         (TestShell::bindJSObjectsToWindow):
1988         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1989         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1990
1991 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
1992
1993         Reviewed by Darin Adler.
1994
1995         Add build logistics and plumbing for window.internals object.
1996         https://bugs.webkit.org/show_bug.cgi?id=60313
1997
1998         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1999         * DumpRenderTree/chromium/TestShell.cpp:
2000         (TestShell::bindJSObjectsToWindow): Added injection code.
2001         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2002         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2003
2004 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2005
2006         Reviewed by Csaba Osztrogonác.
2007
2008         [Qt] Implement eventSender.scalePageBy
2009         https://bugs.webkit.org/show_bug.cgi?id=60015
2010
2011         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2012         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2013         * DumpRenderTree/qt/EventSenderQt.cpp:
2014         (EventSender::scalePageBy):
2015         * DumpRenderTree/qt/EventSenderQt.h:
2016
2017 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
2018
2019         Reviewed by Kent Tamura.
2020
2021         [Chromium] IME candidate window appears wrong position in an iframe
2022         https://bugs.webkit.org/show_bug.cgi?id=61023
2023
2024         Call the focused frame's firstRectForCharacterRange() instead of the
2025         main frame so that DRT behaves as the same as Chromium.
2026
2027         * DumpRenderTree/chromium/TextInputController.cpp:
2028         (TextInputController::firstRectForCharacterRange):
2029
2030 2011-05-18  Adam Roben  <aroben@apple.com>
2031
2032         Add a new page to build.webkit.org to help find when tests started failing
2033
2034         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
2035         right now, but already shows some useful information. It's somewhat similar to webkit-patch
2036         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
2037         little more convenient than either of them, though, because it's all done in the browser
2038         (and thus it's easy to go directly to the relevant test results).
2039
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
2041         (Buildbot): This class represents a Buildbot server.
2042         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
2043         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
2044         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
2045         callback.
2046         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
2047         be implemented by a derived class that understands this server's build naming scheme.
2048         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2049         particular build.
2050
2051         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
2052         (Builder): This class represents one builder on the buildbot.
2053         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
2054         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
2055         information about a particular test failure.
2056         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
2057         information about when tests started failing.
2058         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2059         particular build.
2060         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
2061         callback.
2062         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
2063         extracts all the failing tests listed in it, passing them to the callback.
2064         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
2065         build, merges them into the build history, and calls the callback telling it whether the
2066         next build should be fetched to provide more information.
2067
2068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2069         Added. Just some simple styles.
2070
2071         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
2072         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
2073         (getResource): Wrapper around XMLHttpRequest.
2074         (Array.prototype.findFirst): Finds the first element matching the given predicate and
2075         returns it.
2076         (Array.prototype.last): Returns the last element of the array.
2077
2078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
2079         (ViewController): This class contains the main logic for displaying the page.
2080         (ViewController.loaded): Just calls through to parseHash.
2081         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
2082         shows the list of all testers so one can be chosen. This function is called when the page
2083         loads and whenever we get a hashchange event.
2084         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
2085         as it is fetched. The display ends up grouping tests by when they started failing.
2086         (ViewController._displayTesters): Gets the list of testers and displays it.
2087
2088         (ViewController._domForBuildName):
2089         (ViewController._domForFailedTest):
2090         Helper functions to create descriptions and links for a particular build or failed test.
2091
2092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
2093         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
2094         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
2095
2096         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
2097         loads all the files and sets up a ViewController, which does the rest.
2098
2099         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
2100         page.
2101
2102 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2103
2104         Reviewed by Csaba Osztrogonác.
2105
2106         [Qt] Implement layoutTestController.setValueForUser()
2107         https://bugs.webkit.org/show_bug.cgi?id=60956
2108
2109         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2110         (LayoutTestController::setValueForUser):
2111         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2112
2113 2011-05-16  Robert Hogan  <robert@webkit.org>
2114
2115         Reviewed by Kenneth Rohde Christiansen.
2116
2117         plugins/invalidate_rect.html fails on linux ports
2118
2119         - Make the unix test netscape plugin recognize the onPaintEvent
2120           and windowedPlugin parameters.
2121
2122         https://bugs.webkit.org/show_bug.cgi?id=54051
2123
2124         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2125         (handleEventX11):
2126         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2127         (LayoutTestController::displayInvalidatedRegion):
2128         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2129         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2130         (webkit_test_plugin_new_instance):
2131         (webkit_test_plugin_handle_event):
2132
2133 2011-05-17  Tony Chang  <tony@chromium.org>
2134
2135         Reviewed by Ojan Vafai.
2136
2137         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
2138         https://bugs.webkit.org/show_bug.cgi?id=60895
2139
2140         Update the tools to handle the move.  Lucid 32 results now go in
2141         chromium-linux-x86 and the default platform on Linux is now x86_64.
2142
2143         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
2144         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2145         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
2146         * Scripts/webkitpy/layout_tests/port/base.py: ditto
2147         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
2148         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2149         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
2150         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
2151         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
2152
2153 2011-05-17  Adam Roben  <aroben@apple.com>
2154
2155         Make run-api-tests work on Windows when there are spaces in the path
2156
2157         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
2158         spaces in the path to TestWebKitAPI.exe
2159
2160         Reviewed by David Levin.
2161
2162         * Scripts/run-api-tests:
2163         (runTestTool): Use the "direct object" form of system() to avoid having the path to
2164         TestWebKitAPI.exe be split by the shell.
2165
2166 2011-05-16  Ian Henderson  <ianh@apple.com>
2167
2168         Reviewed by Joseph Pecoraro.
2169
2170         Page::goToItem doesn't work while loading is deferred
2171         https://bugs.webkit.org/show_bug.cgi?id=60412
2172
2173         Add setDefersLoading and goBack methods to LayoutTestController.  We
2174         need to use goBack() instead of history.back() because the latter goes
2175         through NavigationScheduler, hence doesn't exhibit the bug.
2176
2177         * DumpRenderTree/LayoutTestController.cpp:
2178         (goBackCallback):
2179         (setDefersLoadingCallback):
2180         (LayoutTestController::staticFunctions):
2181         * DumpRenderTree/LayoutTestController.h:
2182         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2183         (LayoutTestController::goBack):
2184         (LayoutTestController::setDefersLoading):
2185         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2186         (LayoutTestController::goBack):
2187         (LayoutTestController::setDefersLoading):
2188         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2189         (LayoutTestController::goBack):
2190         (LayoutTestController::setDefersLoading):
2191         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2192         (LayoutTestController::goBack):
2193         (LayoutTestController::setDefersLoading):
2194
2195 2011-05-16  Sam Weinig  <sam@webkit.org>
2196
2197         Reviewed by Anders Carlsson.
2198
2199         TestWebKitAPI should build with clang if it can
2200         https://bugs.webkit.org/show_bug.cgi?id=60918
2201
2202         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2203         Update CompilerVersion.xcconfig to match others.
2204
2205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2206         Add CompilerVersion.xcconfig to the project.
2207
2208         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2209         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2210         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2211         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2212         Add some casts to quiet warnings from clang.
2213
2214 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
2215
2216         Reviewed by David Levin.
2217
2218         add dpranke as a reviewer
2219         https://bugs.webkit.org/show_bug.cgi?id=60919
2220
2221         * Scripts/webkitpy/common/config/committers.py:
2222
2223 2011-05-16  Robert Hogan  <robert@webkit.org>
2224
2225         Reviewed by Anders Carlsson.
2226
2227         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
2228
2229         https://bugs.webkit.org/show_bug.cgi?id=60838
2230
2231         The unix test plugin needs to call the test's NPP_URLNotify
2232         rather than the browsers.
2233
2234         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2235         (webkit_test_plugin_url_notify):
2236
2237 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
2238
2239         Rubber-stamped by Adam Roben.
2240
2241         Adding myself as a reviewer.
2242         * Scripts/webkitpy/common/config/committers.py:
2243
2244 2011-05-16  Sam Weinig  <sam@webkit.org>
2245
2246         Fix typo pointed out by Dave Levin.
2247
2248         * TestWebKitAPI/PlatformUtilities.h:
2249         (TestWebKitAPI::Util::assertWKStringEqual):
2250         Strig -> String.
2251
2252 2011-05-16  Sam Weinig  <sam@webkit.org>
2253
2254         Reviewed by David Levin.
2255
2256         Convert api tester over to using gtest expectations directly
2257         https://bugs.webkit.org/show_bug.cgi?id=60862
2258
2259         * TestWebKitAPI/PlatformUtilities.cpp:
2260         (TestWebKitAPI::Util::toSTD):
2261         * TestWebKitAPI/PlatformUtilities.h:
2262         (TestWebKitAPI::Util::assertWKStrigEqual):
2263         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
2264         the implementation of the macro simpler.
2265
2266         * TestWebKitAPI/Test.h:
2267         Remove TEST_ASSERT forwarder.
2268
2269         [Test changes elided]
2270
2271 2011-05-16  David Kilzer  <ddkilzer@apple.com>
2272
2273         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
2274         <rdar://problem/9446430>
2275
2276         Reviewed by Mark Rowe.
2277
2278         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
2279         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2280         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2281
2282 2011-05-16  Jon Lee  <jonlee@apple.com>
2283
2284         Reviewed by Simon Fraser.
2285
2286         Can't horizontally scroll iframes and overflow because wheel events are always accepted
2287         https://bugs.webkit.org/show_bug.cgi?id=60779
2288
2289         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2290         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
2291
2292 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2293
2294         Reviewed by Csaba Osztrogonác.
2295
2296         [Qt] Tools.pro misses include(common.pri)
2297         https://bugs.webkit.org/show_bug.cgi?id=60883
2298
2299         It includes features.pri, which depends on common.pri (the build is
2300         not broken today with the default options, but this is the right
2301         thing to do).
2302
2303         * Tools.pro:
2304
2305 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
2306
2307         Unreviewed: adding myself to committers.py.
2308
2309         * Scripts/webkitpy/common/config/committers.py:
2310
2311 2011-05-15  Daniel Bates  <dbates@webkit.org>
2312
2313         Reviewed by Chris Jerdonek.
2314
2315         svn-apply can't handle Git diff that only changes executable bit
2316         https://bugs.webkit.org/show_bug.cgi?id=60848
2317
2318         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
2319         that only has an executable bit change.
2320
2321         * Scripts/VCSUtils.pm:
2322           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
2323         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
2324         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
2325         * Scripts/svn-apply:
2326         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
2327         * Scripts/svn-unapply:
2328         (patch): Ditto.
2329         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2330           - Updated expected results for test cases to account for numTextChunks.
2331           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
2332           - Added test case "Git: file that only has an executable bit change".
2333         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2334           - Updated expected results for test cases to account for numTextChunks.
2335
2336 2011-05-15  Sam Weinig  <sam@webkit.org>
2337
2338         Fix windows build.
2339
2340         * TestWebKitAPI/win/main.cpp:
2341         (main):
2342
2343 2011-05-15  Sam Weinig  <sam@webkit.org>
2344
2345         Reviewed by David Levin.
2346
2347         Make API tester more gtest friendly
2348         https://bugs.webkit.org/show_bug.cgi?id=60859
2349
2350         * Scripts/run-api-tests:
2351         Numerous changes:
2352         - Remove logic to run tests one at a time.
2353         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
2354           the test runner and allow gtest to print it for us.
2355         - Forward stdout from the test tool to stdout, even in non-verbose runs.
2356         - Run test tool from the current working directory instead of the root webkit
2357           directory.
2358
2359         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2360         Move plist to be with other bundle sources.
2361
2362         * TestWebKitAPI/TestsController.cpp:
2363         (TestWebKitAPI::TestsController::TestsController):
2364         (TestWebKitAPI::TestsController::run):
2365         * TestWebKitAPI/TestsController.h:
2366         * TestWebKitAPI/mac/main.mm:
2367         Simplify TestController down to a single run function. We should consider removing the class
2368         entirely at some point.
2369
2370 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2371
2372         Unreviewed, rolling out r86504.
2373         http://trac.webkit.org/changeset/86504
2374         https://bugs.webkit.org/show_bug.cgi?id=60853
2375
2376         "Broke Qt EventSender in editing/selection tests" (Requested
2377         by mwenge on #webkit).
2378
2379         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2380         (WebCore::WebPage::WebPage):
2381         (WebCore::DumpRenderTree::DumpRenderTree):
2382         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2383         (WebCore::DumpRenderTree::initJSObjects):
2384         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2385         (WebCore::DumpRenderTree::eventSender):
2386         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2387         (webkit_test_plugin_new_instance):
2388         (webkit_test_plugin_set_window):
2389         (webkit_test_plugin_handle_event):
2390
2391 2011-05-12  Robert Hogan  <robert@webkit.org>
2392
2393         Reviewed by Benjamin Poulain.
2394
2395         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2396
2397         The support for this test added to the unix test plugin here
2398         may allow other platforms to pass it (nearly everyone
2399         skips it). On Qt it required a bit of trickiness with
2400         the page's EventSender object to get it working fully though,
2401         so only unskipping Qt here.
2402
2403         https://bugs.webkit.org/show_bug.cgi?id=60722
2404
2405         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2406         (WebCore::WebPage::WebPage):
2407         (WebCore::WebPage::eventSender):
2408         (WebCore::DumpRenderTree::DumpRenderTree):
2409         (WebCore::DumpRenderTree::initJSObjects):
2410         (WebCore::DumpRenderTree::createWindow):
2411         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2412         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2413         (webkit_test_plugin_new_instance):
2414         (webkit_test_plugin_set_window):
2415         (webkit_test_plugin_handle_event):
2416
2417 2011-05-14  Arno Renevier  <arno@renevier.net>
2418
2419         Reviewed by Martin Robinson.
2420
2421         make run-gtk-tests executable
2422         https://bugs.webkit.org/show_bug.cgi?id=59278
2423
2424         * Scripts/run-gtk-tests:
2425
2426 2011-05-14  Anders Carlsson  <andersca@apple.com>
2427
2428         Reviewed by Kevin Decker.
2429
2430         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2431         https://bugs.webkit.org/show_bug.cgi?id=60823
2432         <rdar://problem/9430386>
2433
2434         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2435
2436         * DumpRenderTree/DumpRenderTree.gypi:
2437         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2438         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2439         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2440         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2441         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2442         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2443         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2444         * GNUmakefile.am:
2445
2446 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2447
2448         Unreviewed, rolling out r86476.
2449         http://trac.webkit.org/changeset/86476
2450         https://bugs.webkit.org/show_bug.cgi?id=60832
2451
2452         It made plugins/get-url-notify-with-url-that-fails-to-
2453         load.html crash on GTK (Requested by Ossy on #webkit).
2454
2455         * DumpRenderTree/DumpRenderTree.gypi:
2456         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2457         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
2458         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2459         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2460         * GNUmakefile.am:
2461
2462 2011-05-13  Anders Carlsson  <andersca@apple.com>
2463
2464         Reviewed by Sam Weinig.
2465
2466         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2467         https://bugs.webkit.org/show_bug.cgi?id=60823
2468         <rdar://problem/9430386>
2469
2470         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2471
2472         * DumpRenderTree/DumpRenderTree.gypi:
2473         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2474         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2475         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2476         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2477         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2478         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2479         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2480         * GNUmakefile.am:
2481
2482 2011-05-13  Anders Carlsson  <andersca@apple.com>
2483
2484         Build fix.
2485
2486         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
2487
2488 2011-05-13  Anders Carlsson  <andersca@apple.com>
2489
2490         Reviewed by Sam Weinig.
2491
2492         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
2493         https://bugs.webkit.org/show_bug.cgi?id=60810
2494
2495         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
2496
2497         * DumpRenderTree/DumpRenderTree.gypi:
2498         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2499         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2500         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2501         * GNUmakefile.am:
2502         Add files.
2503
2504         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2505         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2506         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
2507
2508         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
2509         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
2510         (GetURLWithJavaScriptURL::NPP_New):
2511         (GetURLWithJavaScriptURL::NPP_NewStream):
2512         (GetURLWithJavaScriptURL::NPP_DestroyStream):
2513         (GetURLWithJavaScriptURL::NPP_WriteReady):
2514         (GetURLWithJavaScriptURL::NPP_Write):
2515         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2516         (NPP_NewStream):
2517         (NPP_WriteReady):
2518         (NPP_Write):
2519         (NPP_URLNotify):
2520         call the PluginTest NPP wrappers.
2521
2522 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2523
2524         Unreviewed, rolling out r86447.
2525         http://trac.webkit.org/changeset/86447
2526         https://bugs.webkit.org/show_bug.cgi?id=60809
2527
2528         "Broke some uses of EventSender object on Qt" (Requested by
2529         mwenge on #webkit).
2530
2531         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2532         (WebCore::WebPage::WebPage):
2533         (WebCore::DumpRenderTree::DumpRenderTree):
2534         (WebCore::DumpRenderTree::initJSObjects):
2535         (WebCore::DumpRenderTree::createWindow):
2536         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2537         (WebCore::DumpRenderTree::eventSender):
2538         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2539         (webkit_test_plugin_new_instance):
2540         (webkit_test_plugin_set_window):
2541         (webkit_test_plugin_handle_event):
2542
2543 2011-05-13  Robert Hogan  <robert@webkit.org>
2544
2545         Reviewed by Benjamin Poulain.
2546
2547         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2548
2549         The support for this test added to the unix test plugin here
2550         may allow other platforms to pass it (nearly everyone
2551         skips it). On Qt it required a bit of trickiness with
2552         the page's EventSender object to get it working fully though,
2553         so only unskipping Qt here.
2554
2555         https://bugs.webkit.org/show_bug.cgi?id=60722
2556
2557         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2558         (WebCore::WebPage::WebPage):
2559         (WebCore::WebPage::eventSender):
2560         (WebCore::DumpRenderTree::DumpRenderTree):
2561         (WebCore::DumpRenderTree::initJSObjects):
2562         (WebCore::DumpRenderTree::createWindow):
2563         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2564         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2565         (webkit_test_plugin_new_instance):
2566         (webkit_test_plugin_set_window):
2567         (webkit_test_plugin_handle_event):
2568
2569 2011-05-13  Adam Roben  <aroben@apple.com>
2570
2571         Exclude the Leopard NRWT bot from the core builder set
2572
2573         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
2574
2575         Reviewed by Darin Adler.
2576
2577         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2578         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
2579         in the core builder set.
2580
2581         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2582         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
2583         regexps.
2584
2585 2011-05-13  Adam Roben  <aroben@apple.com>
2586
2587         Group all the NRWT bots together
2588
2589         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
2590         bots are experimental, it seems best not to clutter up the non-experimental bots with
2591         experimental ones.
2592
2593         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
2594         on build.webkit.org
2595
2596         Reviewed by Dan Bernstein.
2597
2598         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
2599         Chromium testers, which also use new-run-webkit-tests.
2600
2601 2011-05-13  Adam Roben  <aroben@apple.com>
2602
2603         Add a plugin test that dumps the plugin window's rect
2604
2605         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
2606         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
2607
2608         Reviewed by Dan Bernstein.
2609
2610         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
2611         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
2612         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
2613         harness window and log it.
2614
2615         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
2616
2617 2011-05-13  Adam Roben  <aroben@apple.com>
2618
2619         Move code required for most tests of plugin window geometry into a base class
2620
2621         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
2622         having all the trickiness in a shared base class, writing new window geometry tests will be
2623         much easier.
2624
2625         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
2626
2627         Reviewed by Anders Carlsson.
2628
2629         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2630         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
2631         WindowGeometryTest base class. Most of the code from this class was moved to the new base
2632         class.
2633         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
2634         This is called by the base class when it is safe to check the window's geometry. Note that
2635         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
2636         just vestigial code from an earlier version of this test.
2637
2638         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
2639         WindowGeometryTest class.
2640
2641         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
2642         WindowRegionIsSetToClipRect.
2643         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
2644         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
2645         Subclasses can implement that function to perform their own tests.
2646
2647         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
2648
2649 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
2650
2651         Reviewed by Csaba Osztrogonác.
2652
2653         Missing 2nd #EOF if WebProcess is killed.
2654         https://bugs.webkit.org/show_bug.cgi?id=60761
2655
2656         If the WebProcess is killed, only one #EOF is yielded
2657         by WebKitTestRunner. However, run-webkit-test wait for
2658         a second #EOF, which signals the finishing of pixel dump.
2659         Since this never happens, run-webkit-test waits forever.
2660
2661         * WebKitTestRunner/TestInvocation.cpp:
2662         (WTR::TestInvocation::dump):
2663         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2664         * WebKitTestRunner/TestInvocation.h:
2665
2666 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2667
2668         Reviewed by Csaba Osztrogonác.
2669
2670         [NRWT] chromium-linux tests shouldn't run on other platforms
2671         https://bugs.webkit.org/show_bug.cgi?id=60162
2672
2673         Remove _tests_for_other_platforms defs because r82753
2674         implemented it properly in the baseclass in webkit.py.
2675
2676         * Scripts/webkitpy/layout_tests/port/gtk.py:
2677         * Scripts/webkitpy/layout_tests/port/qt.py:
2678         * Scripts/webkitpy/layout_tests/port/win.py:
2679
2680 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
2681
2682         Reviewed by Antonio Gomes.
2683
2684         [EFL] Remove unused option of EWeblauncher
2685         https://bugs.webkit.org/show_bug.cgi?id=60747
2686
2687         Remove sudo-workaround option.
2688         This option is not used and make other option wrong.
2689
2690         * EWebLauncher/main.c:
2691
2692 2011-05-12  Lucas Forschler  <lforschler@apple.com>
2693
2694         Reviewed by Stephanie Lewis.
2695
2696         Fix config.json to address missing WK2 builder/tester config.
2697         Fix naming of machines (xserve not macpro)
2698
2699         * BuildSlaveSupport/build.webkit.org-config/config.json:
2700
2701 2011-05-12  Lucas Forschler  <lforschler@apple.com>
2702
2703         Reviewed by Stephanie Lewis.
2704
2705         Add SnowLeopard Debug builder and Test bot.
2706         apple-xserve-8 = SL Debug Tester.
2707         apple-xserve-9 = SL Debug Builder.
2708         
2709         * BuildSlaveSupport/build.webkit.org-config/config.json:
2710
2711 2011-05-12  Adam Barth  <abarth@webkit.org>
2712
2713         This patch disables sheriffbot's bug postings.  He's just been way too
2714         spammy recently due to test flakiness.
2715
2716         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2717         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2718
2719 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2720
2721         Reviewed by Anders Carlsson.
2722
2723         After relaunching an unresponsive web process, web page stops responding to mouse movement
2724         https://bugs.webkit.org/show_bug.cgi?id=60669
2725         <rdar://problem/9409934>
2726         
2727         This test follows the steps needed to reproduce this bug:
2728         1) Hang the web process
2729         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
2730         3) Kill and restart the WebProcess
2731         4) Move the mouse
2732         
2733         We are testing that we receive mouse move events after the WebProcess has restarted.
2734
2735         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
2736         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
2737         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
2738         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
2739         (TestWebKitAPI::setPageLoaderClient):
2740         (TestWebKitAPI::TEST):
2741         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
2742         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
2743         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
2744         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
2745
2746         * TestWebKitAPI/PlatformWebView.h:
2747         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2748         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
2749         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2750         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
2751
2752         Add new files.
2753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2754         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2755         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2756         * TestWebKitAPI/win/copy-resources.cmd:
2757
2758 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
2759
2760         Reviewed by Antonio Gomes.
2761
2762         [EFL] Added initialization/shutdown for ecore_file library
2763         https://bugs.webkit.org/show_bug.cgi?id=60457
2764
2765         Added initialization and shuthown for ecore_file library and replaced
2766         realpath function to ecore_file_realpath.
2767
2768         * EWebLauncher/main.c:
2769         (quit):
2770         (findThemePath):
2771         (main):
2772
2773 2011-05-12  Young Han Lee  <joybro@company100.net>
2774
2775         Reviewed by Kenneth Rohde Christiansen.
2776
2777         [Qt] Implement layoutTestController.layerTreeAsText()
2778         https://bugs.webkit.org/show_bug.cgi?id=60367
2779
2780         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2781         (LayoutTestController::layerTreeAsText):
2782         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2783
2784 2011-05-11  Eric Seidel  <eric@webkit.org>
2785
2786         Reviewed by David Levin.
2787
2788         Teach validate-committer-lists how to validate committers bugzilla_email()
2789         https://bugs.webkit.org/show_bug.cgi?id=60651
2790
2791         It turns out we currently have 9 committers with invalid values for their
2792         bugzilla_email field (meaning we don't know what email is their bugzilla account).
2793         "Alexander Kellett" <lypanov@mac.com>
2794         "Andre Boule" <aboule@apple.com>
2795         "Cameron McCormack" <cam@webkit.org>
2796         "Chris Petersen" <cpetersen@apple.com>
2797         "Eli Fidler" <eli@staikos.net>
2798         "Matt Lilek" <webkit@mattlilek.com>
2799         "Pierre d'Herbemont" <pdherbemont@free.fr>
2800         "Scott Violet" <sky@chromium.org>
2801         "Adam Treat" <treat@kde.org>
2802
2803         Most of those haven't committed in a very long time, so it's not suprising
2804         that we haven't noticed that their bugzilla emails are bogus.
2805
2806         * Scripts/validate-committer-lists:
2807         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2808         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2809
2810 2011-05-11  Dmitry Lomov  <dslomov@google.com>
2811
2812         Reviewed by David Levin.
2813
2814         https://bugs.webkit.org/show_bug.cgi?id=59561
2815         Switch TestWebKitAPI to GTest
2816
2817         Fixes Makefiles and WinCairo build as well
2818
2819         * Makefile:
2820         * Scripts/build-api-tests:
2821         * Scripts/run-api-tests:
2822         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2823         * TestWebKitAPI/Test.h:
2824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2825         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2826         (TestWebKitAPI::TEST):
2827         * TestWebKitAPI/TestsController.cpp:
2828         (TestWebKitAPI::TestsController::TestsController):
2829         (TestWebKitAPI::TestsController::dumpTestNames):
2830         (TestWebKitAPI::TestsController::runTestNamed):
2831         (TestWebKitAPI::TestsController::runAllTests):
2832         * TestWebKitAPI/TestsController.h:
2833         * TestWebKitAPI/mac/main.mm:
2834         (main):
2835
2836 2011-05-11  Eric Seidel  <eric@webkit.org>
2837
2838         Reviewed by Alexey Proskuryakov.
2839
2840         Add Luke Macpherson to committers.py as a Contributor
2841         https://bugs.webkit.org/show_bug.cgi?id=60639
2842
2843         * Scripts/webkitpy/common/config/committers.py:
2844
2845 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
2846
2847         Reviewed by Kenneth Rohde Christiansen.
2848
2849         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
2850         https://bugs.webkit.org/show_bug.cgi?id=60439
2851
2852         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
2853
2854         * Scripts/build-webkit:
2855
2856 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2857
2858         Reviewed by Adam Roben.
2859
2860         REGRESSION (r86161): WKPreferences API test failing on Windows
2861         https://bugs.webkit.org/show_bug.cgi?id=60658
2862
2863         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2864         (TestWebKitAPI::TEST):
2865
2866 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
2867
2868         Reviewed by Ojan Vafai.
2869
2870         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
2871         https://bugs.webkit.org/show_bug.cgi?id=60521
2872
2873         First steps towards making the results JSON all hierarchical.
2874
2875         * TestResultServer/model/jsonresults.py:
2876         * TestResultServer/model/jsonresults_unittest.py:
2877
2878 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
2879
2880         [wx] Build fix, adding new LayoutTestController method stubs.
2881
2882         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2883         (LayoutTestController::localStorageDiskUsageForOrigin):
2884         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2885
2886 2011-05-11  Jessie Berlin  <jberlin@apple.com>
2887
2888         Reviewed by Darin Adler.
2889
2890         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
2891         about the usage for both the origin overall and the database in question.
2892         https://bugs.webkit.org/show_bug.cgi?id=60573
2893
2894         * WebKitTestRunner/TestController.cpp:
2895         (WTR::exceededDatabaseQuota):
2896
2897 2011-05-10  Stephen White  <senorblanco@chromium.org>
2898
2899         Reviewed by David Levin.
2900
2901         Adding myself as a reviewer.
2902         https://bugs.webkit.org/show_bug.cgi?id=60587
2903
2904         * Scripts/webkitpy/common/config/committers.py:
2905
2906 2011-05-11  Eric Seidel  <eric@webkit.org>
2907
2908         Reviewed by Csaba Osztrogonác.
2909
2910         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
2911         https://bugs.webkit.org/show_bug.cgi?id=60614
2912
2913         AppEngine has a result limit of 1000.  We hit that when trying
2914         to find out how many patches the style-queue (and other queues)
2915         have passed in the last 30 days.  So lets display 1000+ instead
2916         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
2917
2918         I also made the status pages show "never" instead of just "ago" when we
2919         haven't seen a pass or boot message in the last 1000 messages.
2920
2921         * QueueStatusServer/handlers/queuestatus.py:
2922         * QueueStatusServer/templates/queuestatus.html:
2923
2924 2011-05-11  Adam Barth  <abarth@webkit.org>
2925
2926         Reviewed by Eric Seidel.
2927
2928         sheriffbot shouldn't spam bugs when it can't figure out who to blame
2929         https://bugs.webkit.org/show_bug.cgi?id=60613
2930
2931         This patch limits the number of bugs sheriffbot will spam to three.
2932         Ideally, we'd come up with some smarter huerstics, but hopefully this
2933         will cut down on the bugmail spam for slow bots.
2934
2935         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2936
2937 2011-05-10  Eric Seidel  <eric@webkit.org>
2938
2939         Reviewed by Adam Barth.
2940
2941         EWS bots should be robust against test-webkitpy hangs
2942         https://bugs.webkit.org/show_bug.cgi?id=60579
2943
2944         Added a killAfterTimeout subroutine, which takes a child_pid
2945         and timeout, and will setup a watchdog process to kill that child
2946         after the timeout.  killAfterTimeout will waitpid on the child.
2947
2948         * EWSTools/start-queue.sh:
2949
2950 2011-05-10  MORITA Hajime  <morrita@google.com>
2951
2952         Unreviewed, moved myself to the reviewers list.
2953
2954         * Scripts/webkitpy/common/config/committers.py:
2955
2956 2011-05-10  Anton D'Auria  <adauria@apple.com>
2957
2958         Reviewed by David Levin.
2959
2960         StorageTracker should report actual local storage usage on disk
2961         https://bugs.webkit.org/show_bug.cgi?id=60558
2962
2963         * DumpRenderTree/LayoutTestController.cpp:
2964         (localStorageDiskUsageForOriginCallback):
2965         (LayoutTestController::staticFunctions):
2966         * DumpRenderTree/LayoutTestController.h:
2967         * DumpRenderTree/chromium/LayoutTestController.cpp:
2968         (LayoutTestController::LayoutTestController):
2969         (LayoutTestController::localStorageDiskUsageForOrigin):
2970         * DumpRenderTree/chromium/LayoutTestController.h:
2971         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2972         (LayoutTestController::localStorageDiskUsageForOrigin):
2973         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2974         (LayoutTestController::localStorageDiskUsageForOrigin):
2975         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2976         (LayoutTestController::localStorageDiskUsageForOrigin):
2977         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2978         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2979         (LayoutTestController::localStorageDiskUsageForOrigin):
2980
2981 2011-05-10  Anton D'Auria  <adauria@apple.com>
2982
2983         Reviewed by Alexey Proskuryakov.
2984
2985         Add ApplicationCache API to get disk usage per origin
2986         https://bugs.webkit.org/show_bug.cgi?id=57127
2987
2988         Added test that loads two frames with ~15Kb image, checks usage,
2989         deletes app cache, verifies usage is 0.
2990
2991         * DumpRenderTree/LayoutTestController.cpp:
2992         (applicationCacheDiskUsageForOriginCallback):
2993         (LayoutTestController::staticFunctions):
2994         * DumpRenderTree/LayoutTestController.h:
2995         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2996         (LayoutTestController::LayoutTestController):
2997         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2998         * DumpRenderTree/chromium/LayoutTestController.h:
2999         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3000         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3001         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3002         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3003         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3004         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3005         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3006         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3007         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3008
3009 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3010
3011         Unreviewed, adding Rafael Antognolli as a committer.
3012
3013         * Scripts/webkitpy/common/config/committers.py:
3014
3015 2011-05-10  Chris Evans  <cevans@chromium.org>
3016
3017         Reviewed by Adam Barth.
3018
3019         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
3020         https://bugs.webkit.org/show_bug.cgi?id=58378
3021
3022         * DumpRenderTree/chromium/LayoutTestController.cpp:
3023         (LayoutTestController::LayoutTestController):
3024         (LayoutTestController::setAllowDisplayOfInsecureContent):
3025         (LayoutTestController::setAllowRunningOfInsecureContent):
3026         * DumpRenderTree/chromium/LayoutTestController.h:
3027         * DumpRenderTree/chromium/WebPreferences.cpp:
3028         (WebPreferences::reset):
3029         (WebPreferences::applyTo):
3030         * DumpRenderTree/chromium/WebPreferences.h:
3031         Add plumbing for new settings to Chromium DRT.
3032
3033 2011-05-10  Enrica Casucci  <enrica@apple.com>
3034
3035         Reviewed by Beth Dakin.
3036
3037         Added my name to the reviewers list and removed my name from
3038         to committer-only list.
3039
3040         * Scripts/webkitpy/common/config/committers.py:
3041
3042 2011-05-10  David Levin  <levin@chromium.org>
3043
3044         Reviewed by Shinichiro Hamaji.
3045
3046         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
3047         https://bugs.webkit.org/show_bug.cgi?id=60466
3048
3049         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
3050         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
3051           that property was removed.
3052         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
3053           filtering for errors.
3054         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
3055           verify that the line filtering is turned off.
3056         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
3057           and remove the unused file_path parameter.
3058         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
3059           line filtering is turned off (and fix test_no_error).
3060         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
3061           of errors based on the lines changed in the patch.
3062         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
3063           the filtering.
3064
3065 2011-05-10  Adam Roben  <aroben@apple.com>
3066
3067         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
3068
3069         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
3070         platform/win/plugins/window-geometry-initialized-before-set-window.html and
3071         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
3072         (WebKit2 Tests)
3073
3074         Reviewed by Anders Carlsson.
3075
3076         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3077         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
3078         WindowedPluginTest::testHarnessWindow function.
3079
3080         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
3081         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
3082         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
3083         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
3084         created for.
3085
3086         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3087         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
3088         WindowedPluginTest, and initialized new members.
3089         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
3090         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
3091         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
3092         then clean up and tell the test harness we're done.
3093         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
3094         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
3095         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
3096         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
3097         window becomes visible.
3098         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
3099         if it was hidden at the start of the test.
3100         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
3101         This should cause our window to become visible and our window region to get set. When we get
3102         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
3103         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
3104         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
3105         "startTest".
3106         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
3107
3108         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
3109         (WindowedPluginTest::testHarnessWindow):
3110         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
3111         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
3112
3113 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
3114
3115         Reviewed by Kenneth Rohde Christiansen.
3116
3117         [Qt] Add new qt-4.8 platform for layout testing
3118         https://bugs.webkit.org/show_bug.cgi?id=60544
3119
3120         * Scripts/old-run-webkit-tests:
3121         * Scripts/webkitdirs.pm:
3122
3123 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3124
3125         Unreviewed, rolling out r86108.
3126         http://trac.webkit.org/changeset/86108
3127         https://bugs.webkit.org/show_bug.cgi?id=60533
3128
3129         Broke makefile based builds and Cairo (Requested by weinig on
3130         #webkit).
3131
3132         * Scripts/build-api-tests:
3133         * Scripts/run-api-tests:
3134         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3135         * TestWebKitAPI/Test.h:
3136         (TestWebKitAPI::Test::~Test):
3137         (TestWebKitAPI::Test::name):
3138         (TestWebKitAPI::Test::Register::Register):
3139         (TestWebKitAPI::Test::Register::create):
3140         (TestWebKitAPI::Test::Test):
3141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3142         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3143         (TestWebKitAPI::TEST):
3144         * TestWebKitAPI/TestsController.cpp:
3145         (TestWebKitAPI::TestsController::TestsController):
3146         (TestWebKitAPI::TestsController::dumpTestNames):
3147         (TestWebKitAPI::TestsController::runTestNamed):
3148         (TestWebKitAPI::TestsController::testFailed):
3149         (TestWebKitAPI::TestsController::registerCreateTestFunction):
3150         * TestWebKitAPI/TestsController.h:
3151         * TestWebKitAPI/mac/main.mm:
3152         (main):
3153
3154 2011-05-09  Hayato Ito  <hayato@chromium.org>
3155
3156         Reviewed by Ojan Vafai.
3157
3158         Skip reftests if pixel tests are disabled.
3159
3160         https://bugs.webkit.org/show_bug.cgi?id=59078
3161
3162         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3163         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3164         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3165         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3166
3167 2011-05-09  Chang Shu  <cshu@webkit.org>
3168
3169         Reviewed by Kenneth Rohde Christiansen.
3170
3171         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
3172         https://bugs.webkit.org/show_bug.cgi?id=60499
3173
3174         The implementation is similar to gtk.
3175
3176         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3177         (TextInputController::unmarkText):
3178         * DumpRenderTree/qt/TextInputControllerQt.h:
3179
3180 2011-05-09  James Robinson  <jamesr@chromium.org>
3181
3182         Reviewed by Eric Seidel.
3183
3184         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
3185         https://bugs.webkit.org/show_bug.cgi?id=60520
3186
3187         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3188
3189 2011-05-09  Dmitry Lomov  <dslomov@google.com>
3190
3191         Reviewed by Sam Weinig.
3192
3193         Switch TestWebKitAPI to GTest
3194         https://bugs.webkit.org/show_bug.cgi?id=59561
3195
3196         * Scripts/build-api-tests:
3197         * Scripts/run-api-tests:
3198         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3199         * TestWebKitAPI/Test.h:
3200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3201         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3202         (TestWebKitAPI::TEST):
3203         * TestWebKitAPI/TestsController.cpp:
3204         (TestWebKitAPI::TestsController::TestsController):
3205         (TestWebKitAPI::TestsController::dumpTestNames):
3206         (TestWebKitAPI::TestsController::runTestNamed):
3207         (TestWebKitAPI::TestsController::runAllTests):
3208         * TestWebKitAPI/TestsController.h:
3209         * TestWebKitAPI/mac/main.mm:
3210         (main):
3211
3212 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
3213
3214         Reviewed by Andreas Kling.
3215
3216         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
3217         https://bugs.webkit.org/show_bug.cgi?id=60487
3218
3219         When adding a new touch point, the start position of this point needs to be set.
3220
3221         * DumpRenderTree/qt/EventSenderQt.cpp:
3222         (EventSender::addTouchPoint):
3223
3224 2011-05-09  Robert Hogan  <robert@webkit.org>
3225
3226         Reviewed by Adam Roben.
3227
3228         https://bugs.webkit.org/show_bug.cgi?id=57137
3229
3230         Unskip plugins/embed-prefers-plugins-for-images.html
3231
3232         Add image/png mime-type to test netscape plugin on Unix.
3233
3234         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3235         (NP_GetMIMEDescription):
3236
3237 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
3238
3239         Reviewed by Ojan Vafai.
3240
3241         Pull jsonresults_unittest test cases out into separate test methods.
3242         https://bugs.webkit.org/show_bug.cgi?id=60418
3243
3244         * TestResultServer/model/jsonresults_unittest.py:
3245
3246 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3247
3248         Reviewed by Andreas Kling.
3249
3250         [Qt] fix fast/dom/Geolocation/window-close-crash.html
3251         https://bugs.webkit.org/show_bug.cgi?id=60458
3252
3253         Update all pages with Mock position/error/permission.
3254
3255         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3256         (LayoutTestController::setGeolocationPermission):
3257         (LayoutTestController::setMockGeolocationError):
3258         (LayoutTestController::setMockGeolocationPosition):
3259
3260 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
3261
3262         Reviewed by Tony Gentilcore.
3263
3264         Implement Page Visibility API.
3265         https://bugs.webkit.org/show_bug.cgi?id=54181
3266
3267         * DumpRenderTree/LayoutTestController.cpp:
3268         (setPageVisibilityCallback):
3269         (resetPageVisibilityCallback):
3270         (LayoutTestController::staticFunctions):
3271         * DumpRenderTree/LayoutTestController.h:
3272         (LayoutTestController::setPageVisibility):
3273         (LayoutTestController::resetPageVisibility):
3274         * DumpRenderTree/chromium/LayoutTestController.cpp:
3275         (LayoutTestController::LayoutTestController):
3276         (LayoutTestController::resetPageVisibility):
3277         (LayoutTestController::setPageVisibility):
3278         * DumpRenderTree/chromium/LayoutTestController.h:
3279
3280 2011-05-07  Adam Barth  <abarth@webkit.org>
3281
3282         Reviewed by Eric Seidel.
3283
3284         Testing EWS spins on patches with a large number of failures
3285         https://bugs.webkit.org/show_bug.cgi?id=60441
3286
3287         In cases where the tree has a small number of persistent failures but a
3288         patch has a large number of failures, we weren't believing any results.
3289         That lead to us retrying the patch forever while we waited for
3290         trustworthy results that would never come.
3291
3292         This patch loosens the semantics of unexpected_failures to return a
3293         subset (rather than the exact set) of unexpected failures.  In the case
3294         where the tree has a bounded number of failures and the patch has an
3295         unbounded number of failures, we can accurately compute such a subset
3296         and reject the patch.
3297
3298         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3299         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3300         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3301         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3302         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3303
3304 2011-05-07  Joe Mason  <jmason@rim.com>
3305
3306         Reviewed by Daniel Bates.
3307
3308         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
3309         https://bugs.webkit.org/show_bug.cgi?id=52211
3310
3311         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
3312         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
3313
3314         * DumpRenderTree/chromium/WebViewHost.cpp:
3315         (WebViewHost::willPerformClientRedirect):
3316         (WebViewHost::didStartProvisionalLoad):
3317         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3318         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3319
3320 2011-05-07  Daniel Bates  <dbates@webkit.org>
3321
3322         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
3323         <http://trac.webkit.org/changeset/86007> (bug #60438).
3324
3325         * Scripts/old-run-webkit-tests:
3326           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
3327             file local variable. 
3328
3329 2011-05-07  Pratik Solanki  <psolanki@apple.com>
3330
3331         Reviewed by Darin Adler.
3332
3333         Remove references to Tiger in scripts
3334         https://bugs.webkit.org/show_bug.cgi?id=60438
3335
3336         Remove isTiger() and all of the code that depends on it.
3337
3338         * Scripts/build-webkit:
3339         * Scripts/ensure-valid-python:
3340         * Scripts/gdb-safari:
3341         * Scripts/webkitdirs.pm:
3342
3343 2011-05-06  David Grogan  <dgrogan@chromium.org>
3344
3345         Reviewed by Eric Seidel.
3346
3347         update link to message about mac 64bit git binaries
3348         https://bugs.webkit.org/show_bug.cgi?id=60411
3349
3350         The original message implied (correctly, at-the-time) that
3351         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
3352         binaries. The new message notes that they do. This might prevent someone
3353         else from spending a few minutes confused.
3354
3355         * Scripts/webkitpy/common/checkout/scm/git.py:
3356
3357 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
3358
3359         Reviewed by Ojan Vafai.
3360
3361         new-run-webkit-tests: crashes in race with crashing DRT
3362         https://bugs.webkit.org/show_bug.cgi?id=60238
3363
3364         This fixes a race where if we wrote the URL to DRT and
3365         DRT crashed immediately, we could get a broken pipe
3366         error back during the write() and not handle it correctly,
3367         causing NRWT to also crash.
3368
3369         * Scripts/webkitpy/layout_tests/port/server_process.py:
3370         * Scripts/webkitpy/layout_tests/port/webkit.py:
3371
3372 2011-05-06  Adam Barth  <abarth@webkit.org>
3373
3374         Reviewed by Eric Seidel.
3375
3376         Add a --skip-integrationtests mode to test-webkitpy
3377         https://bugs.webkit.org/show_bug.cgi?id=60354
3378
3379         These two test suites account for 2/3 of test-webkitpy's running time
3380         because they're not actually unit tests.  They're integration tests.
3381         This patch adds the ability to skip integration tests by passing a
3382         command line argument to test-webkitpy.  The buildbots will continue to
3383         run these integration tests to make sure they don't regress.  This
3384         option is for use by developers when working on parts of the code that
3385         are well-covered by unit tests.
3386
3387         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
3388         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
3389         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
3390         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
3391         * Scripts/webkitpy/test/main.py:
3392
3393 2011-05-06  Adam Barth  <abarth@webkit.org>
3394
3395         Reviewed by Eric Seidel.
3396
3397         The results.zip generated by the Chromium EWS are too big
3398         https://bugs.webkit.org/show_bug.cgi?id=60352
3399
3400         Currently results.zip created by the Chromium EWS bot contain roughly
3401         1000 tests that we expect to fail.  These test results are not helpful
3402         to contributors.
3403
3404         There are several approaches to solving this problem:
3405
3406         1) We could be more selective about which files to include in the zip.
3407         2) We could ask new-run-webkit-tests not to generate results for
3408            expected failures.
3409         3) We could ask new-run-webkit-tests not to run tests that we expect to
3410            fail.
3411
3412         This patch takes approach (3).  Currently, we're ignoring the outcome
3413         of failing tests anyway, so there's not much point in actually running
3414         them.  As a side benefit, this will speed up the test run by about 6%.
3415         In the future, we might revisit this decision and choose another
3416         approach.
3417
3418         * Scripts/webkitpy/common/config/ports.py:
3419         * Scripts/webkitpy/common/config/ports_unittest.py:
3420
3421 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
3422
3423         Reviewed by Csaba Osztrogonác.
3424
3425         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
3426
3427         * Scripts/old-run-webkit-tests:
3428
3429 2011-05-06  Adam Barth  <abarth@webkit.org>
3430
3431         Reviewed by Ojan Vafai.
3432
3433         Add an option to NRWT to skip failing tests
3434         https://bugs.webkit.org/show_bug.cgi?id=60295
3435
3436         This option is similar to the way old-run-webkit-tests works.  We're
3437         planning to use this option on the testing EWS bots because they don't
3438         use information from failing tests yet.
3439
3440         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3441         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3442         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3443
3444 2011-05-04  Philippe Normand  <pnormand@igalia.com>
3445
3446         Reviewed by Dimitri Glazkov.
3447
3448         Implement LayoutTestController::pseudoShadowId()
3449         https://bugs.webkit.org/show_bug.cgi?id=60034
3450
3451         shadowPseudoId support in the various LayoutTestController
3452         implementations.
3453
3454         * DumpRenderTree/LayoutTestController.cpp:
3455         (shadowPseudoIdCallback):
3456         (LayoutTestController::staticFunctions):
3457         * DumpRenderTree/LayoutTestController.h:
3458         * DumpRenderTree/chromium/LayoutTestController.cpp:
3459         (LayoutTestController::LayoutTestController):
3460         (LayoutTestController::shadowPseudoId):
3461         * DumpRenderTree/chromium/LayoutTestController.h:
3462         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3463         (LayoutTestController::shadowPseudoId):
3464         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3465         (LayoutTestController::shadowPseudoId):
3466         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3467         (LayoutTestController::shadowPseudoId):
3468         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3469         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3470         (LayoutTestController::shadowPseudoId):
3471         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3472         (LayoutTestController::shadowPseudoId):
3473         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3474         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3475         (WTR::LayoutTestController::shadowPseudoId):
3476         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3477
3478 2011-05-06  Adam Barth  <abarth@webkit.org>
3479
3480         EWS can't reject patches
3481         https://bugs.webkit.org/show_bug.cgi?id=60345
3482
3483         We're supposed to use patch.id() for the attachment ID, silly.
3484
3485         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3486         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3487
3488 2011-05-05  Steve Lacey  <sjl@chromium.org>
3489
3490         Reviewed by Ojan Vafai.
3491
3492         Fix generation of results html file by passing relative path to scm
3493         methods.
3494         Generate diff images for results html file.
3495
3496         https://bugs.webkit.org/show_bug.cgi?id=60086
3497
3498         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3499         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3500
3501 2011-05-05  Andy Estes  <aestes@apple.com>
3502
3503         Reviewed by Daniel Bates.
3504
3505         update-webkit should handle Internal using a different VCS than OpenSource.
3506         https://bugs.webkit.org/show_bug.cgi?id=60310
3507
3508         isGit() and isSVN() cache their results, so Internal will always be
3509         updated using the VCS commands used for OpenSource. If Internal uses a
3510         different VCS, this will fail. Fix this by calling isGitDirectory() and
3511         isSVNDirectory() instead, which do not cache their results.
3512
3513         * Scripts/update-webkit:
3514
3515 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3516
3517         Reviewed by Ojan Vafai.
3518
3519         nrwt: revamp integration tests incl. tests for servers
3520         https://bugs.webkit.org/show_bug.cgi?id=59985
3521
3522         This change adds the ability to run "integration tests" that
3523         depend on (and affect) the local environment on your machine.
3524         These tests can be run manually by invoking python on the
3525         test file in question and passing the '-i' flag, but are
3526         not run automatically as part of test-webkitpy.
3527
3528         Integration tests are identified by being methods named as
3529         "integration_test_*" instead of "test_*", and we use a
3530         custom TestLoader instead of the default one provided by
3531         unittest.
3532
3533         This change also adds a protected "_default_to_apache" method
3534         to the port object so we can do the right thing when starting
3535         and stopping web servers with less mechanism.
3536
3537         * Scripts/webkitpy/layout_tests/port/base.py:
3538         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3539         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3540         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3541         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3542         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3543
3544 2011-05-05  Adam Roben  <aroben@apple.com>
3545
3546         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
3547
3548         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
3549         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
3550         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
3551         safeguard against this, we fill the alpha channel with constant full opacity after the
3552         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
3553         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
3554         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
3555         results need an alpha channel, too.)
3556
3557         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
3558         generated due to alpha channel weirdness
3559
3560         Reviewed by Sam Weinig.
3561
3562         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3563         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
3564         constant full opacity.
3565         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
3566         in a CGContext or cairo_surface.
3567
3568 2011-05-05  Adam Roben  <aroben@apple.com>
3569
3570         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
3571
3572         Passing true tells the test harness to dump pixels even though we're not dumping a render
3573         tree.
3574
3575         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
3576         WebKitTestRunner doesn't result in pixel results being generated
3577
3578         Reviewed by Sam Weinig.
3579
3580         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
3581         argument to dumpAsText.
3582
3583         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3584         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
3585
3586         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3587         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
3588
3589         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
3590
3591         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
3592         developers.
3593
3594 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3595
3596         Reviewed by Ojan Vafai.
3597
3598         new-run-webkit-tests: merge os, version fields in test config
3599         https://bugs.webkit.org/show_bug.cgi?id=60004
3600
3601         This change removes the 'o/s' field from the TestConfiguration
3602         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
3603         the expectations file to macros that expand to the version names
3604         for each platform.
3605
3606         This means that you can once again put any subset of the
3607         operating system versions on a single line, e.g.:
3608           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
3609
3610         This change will break any existing test_expectations.txt
3611         file that uses the "OS-VERSION" macros, which are no longer
3612         needed. It turns out they were never needed, as just VERSION
3613         by itself was sufficient. The test_expectations.txt file should
3614         be updated accordingly prior to landing this change.
3615
3616         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3617         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3618         * Scripts/webkitpy/layout_tests/port/base.py:
3619
3620 2011-05-05  Tony Chang  <tony@chromium.org>
3621
3622         Reviewed by Adam Barth.
3623
3624         [chromium] switch from Lucida to free fonts for Hindi and Thai
3625         https://bugs.webkit.org/show_bug.cgi?id=60287
3626
3627         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
3628         packages on Lucid. There are actually multiple Thai fonts in the
3629         package, so I just picked one.
3630
3631         * DumpRenderTree/chromium/TestShellGtk.cpp:
3632         (setupFontconfig):
3633
3634 2011-05-05  Tony Chang  <tony@chromium.org>
3635
3636         Reviewed by Ojan Vafai.
3637
3638         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
3639         https://bugs.webkit.org/show_bug.cgi?id=60290
3640
3641         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
3642         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
3643         lucid64.  Because of that, google-chrome-64 used to skip the
3644         chromium-linux-x86_64 results since they were more incorrect.
3645
3646         Now that we're switching to lucid for google-chrome, we want
3647         google-chrome-64 to fall back to chromium-linux-x86_64.
3648
3649         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3650
3651 2011-05-05  Dirk Pranke  <dpranke@chromium.org>