6c94104c09d6ca2d02cd9aaafe7d571411a5ec8c
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2
3         Remove duplicate code from Buildbot.js in dashboard
4         https://bugs.webkit.org/show_bug.cgi?id=174870
5
6         Reviewed by Daniel Bates.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
9         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
10         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
11         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
12         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
13
14 2017-07-26  Brady Eidson  <beidson@apple.com>
15
16         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
17         https://bugs.webkit.org/show_bug.cgi?id=174851
18
19         Reviewed by Chris Dumez.
20
21         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
22         (TEST):
23
24 2017-07-26  Brian Burg  <bburg@apple.com>
25
26         Remove WEB_TIMING feature flag
27         https://bugs.webkit.org/show_bug.cgi?id=174795
28
29         Reviewed by Alex Christensen.
30
31         * Scripts/webkitperl/FeatureList.pm:
32         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
33
34 2017-07-26  Chris Dumez  <cdumez@apple.com>
35
36         Pressing the Escape key should not be a valid user gesture to enter fullscreen
37         https://bugs.webkit.org/show_bug.cgi?id=174864
38         <rdar://problem/33009088>
39
40         Reviewed by Geoffrey Garen.
41
42         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
43         WKTR.
44
45         * DumpRenderTree/mac/EventSendingController.mm:
46         (-[EventSendingController keyDown:withModifiers:withLocation:]):
47
48 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
49
50         Unreviewed, added Romain Bellessort to contributors.json.
51
52         * Scripts/webkitpy/common/config/contributors.json:
53
54 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
55
56         [WPE] WebGL2 support
57         https://bugs.webkit.org/show_bug.cgi?id=174249
58
59         Reviewed by Alex Christensen.
60
61         * Scripts/webkitperl/FeatureList.pm:
62         Enable WebGL2 for WPE when building through build-webkit.
63
64 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
65
66         Unreviewed. Fix GTK distcheck.
67
68         * gtk/make-dist.py:
69         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
70
71 2017-07-25  Brady Eidson  <beidson@apple.com>
72
73         ResourceLoadStatistics grandfathering happens much too often.
74         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
75
76         Reviewed by Chris Dumez.
77
78         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
79         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
80         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
81         (TEST):
82
83 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
84
85         Fix autoinstaller failing on autoinstall_everything
86         https://bugs.webkit.org/show_bug.cgi?id=174830
87
88         Reviewed by Joseph Pecoraro.
89
90         * Scripts/webkitpy/thirdparty/__init__.py:
91         (AutoinstallImportHook.find_module):
92         (AutoinstallImportHook.install_chromedriver):
93         (AutoinstallImportHook.install_geckodriver):
94         (AutoinstallImportHook._install_chromedriver): Deleted.
95         (AutoinstallImportHook._install_geckodriver): Deleted.
96
97 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
98
99         Replace --runtime with something for both ios-simulator and ios-device
100         https://bugs.webkit.org/show_bug.cgi?id=173775
101         <rdar://problem/32952164>
102
103         Reviewed by Aakash Jain.
104
105         Add --version flag for both iOS simulator and iOS device.
106
107         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
108         (parse_args): Add --version flag and move --no-install.
109         * Scripts/webkitpy/port/factory.py:
110         (platform_options): Move --no-intall to run_webkit_tests.py.
111         * Scripts/webkitpy/port/ios.py:
112         (IOSPort):
113         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
114         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
115         * Scripts/webkitpy/port/ios_device.py:
116         (IOSDevicePort.ios_version): Consult --version flag before checking connected
117         devices for iOS version.
118         * Scripts/webkitpy/port/ios_device_unittest.py:
119         (IOSDeviceTest.make_port): Set --version option so that we can generate test
120         expectation paths without devices connected.
121         (IOSDeviceTest.test_additional_platform_directory): Deleted.
122         (IOSDeviceTest.test_baseline_searchpath): Deleted.
123         (IOSDeviceTest.test_expectations_ordering): Deleted.
124         * Scripts/webkitpy/port/ios_simulator.py:
125         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
126         flag to specify a runtime.
127         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
128         flag and then use the default runtime.
129
130 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
131
132         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
133         https://bugs.webkit.org/show_bug.cgi?id=174815
134
135         Reviewed by Carlos Alberto Lopez Perez.
136
137         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
138         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
139         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
140         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
141         think), probably because of a newer CMake version.
142
143         * CMakeLists.txt:
144         * TestWebKitAPI/CMakeLists.txt:
145         * TestWebKitAPI/PlatformGTK.cmake:
146
147 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
148
149         Fix BenchmarkRunner to only import selenium when needed
150         https://bugs.webkit.org/show_bug.cgi?id=174808
151
152         Reviewed by Stephanie Lewis.
153
154         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
155         (LinuxChromeDriver.launch_driver):
156         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
157         (LinuxFirefoxDriver.launch_driver):
158         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
159         (OSXChromeDriver.launch_driver):
160         (OSXChromeCanaryDriver.launch_driver):
161         (create_chrome_options):
162         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
163         (OSXFirefoxDriver.launch_driver):
164         (OSXFirefoxNightlyDriver.launch_driver):
165         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
166         (OSXSafariDriver.launch_driver):
167         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
168         (WebDriverBenchmarkRunner._run_one_test):
169
170 2017-07-23  Darin Adler  <darin@apple.com>
171
172         More NeverDestroyed and related cleanup
173         https://bugs.webkit.org/show_bug.cgi?id=174745
174
175         Reviewed by Alex Christensen.
176
177         * DumpRenderTree/JavaScriptThreading.cpp:
178         (javaScriptThreadsMutex): Use NeverDestroyed instead of
179         DEPRECATED_DEFINE_STATIC_LOCAL.
180         (javaScriptThreads): Ditto.
181
182 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
183
184         Subclass Benchmark Runner script for WebDriver support
185         https://bugs.webkit.org/show_bug.cgi?id=174390
186
187         Reviewed by Dewei Zhu, Stephanie Lewis.
188
189         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
190
191         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
192         (BenchmarkBuilder.__init__):
193         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
194         (BenchmarkRunner.__init__):
195         (BenchmarkRunner._find_plan_file):
196         (BenchmarkRunner._run_one_test.and):
197         (BenchmarkRunner.execute):
198         (BenchmarkRunner._get_result): Deleted.
199         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
200         (parse_args):
201         (start):
202         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
203         (WebDriverBenchmarkRunner):
204         (WebDriverBenchmarkRunner._get_result):
205         (WebDriverBenchmarkRunner._run_one_test):
206         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
207         (WebServerBenchmarkRunner):
208         (WebServerBenchmarkRunner.__init__):
209         (WebServerBenchmarkRunner._get_result):
210         (WebServerBenchmarkRunner._run_one_test):
211
212 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
213
214         Add BenchmarkRunner patches with WebDriver support for each testing plan
215         https://bugs.webkit.org/show_bug.cgi?id=174443
216
217         Reviewed by Dewei Zhu, Stephanie Lewis.
218
219         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
220         (BenchmarkBuilder.__enter__):
221         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
222         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
223         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
224         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
225         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
226         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
227         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
228         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
229         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
230         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
231         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
232         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
233         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
234         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
235         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
236         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
237         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
238         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
239         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
240         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
241         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
242         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
243         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
244         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
245         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
246         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
247         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
248         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
249         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
250         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
251         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
252         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
253         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
254
255 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
256
257         Add functions to autoinstaller needed for Benchmark Runner script
258         https://bugs.webkit.org/show_bug.cgi?id=174331
259
260         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
261
262         Adds autoinstaller functions to install selenium and webdriver binaries
263         which will be used by the browser driver part of Benchmark Runner.
264
265         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
266         (BrowserDriver.restore_env):
267         (BrowserDriver):
268         (BrowserDriver.get_webdriver_binary_path):
269         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
270         (LinuxChromeDriver.launch_driver):
271         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
272         (LinuxFirefoxDriver.launch_driver):
273         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
274         (OSXChromeDriver.launch_driver):
275         (OSXChromeCanaryDriver.launch_driver):
276         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
277         (OSXFirefoxDriver.launch_driver):
278         (OSXFirefoxNightlyDriver.launch_driver):
279         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
280         * Scripts/webkitpy/benchmark_runner/utils.py:
281         (get_driver_binary_path):
282         * Scripts/webkitpy/common/system/autoinstall.py:
283         (AutoInstaller._unzip):
284         * Scripts/webkitpy/thirdparty/__init__.py:
285         (AutoinstallImportHook.find_module):
286         (AutoinstallImportHook._install_selenium):
287         (AutoinstallImportHook):
288         (AutoinstallImportHook._install_chromedriver):
289         (AutoinstallImportHook._install_geckodriver):
290         (AutoinstallImportHook.get_latest_pypi_url):
291         (AutoinstallImportHook.install_binary):
292         (autoinstall_everything):
293         (get_driver_filename):
294         (get_os_info):
295
296 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
297
298         Add WebDriver support in browser driver part of BenchmarkRunner
299         https://bugs.webkit.org/show_bug.cgi?id=174445
300
301         Reviewed by Stephanie Lewis.
302
303         Adds a launch_driver function to each BrowserDriver subclass. This
304         function sets up the arguments for the webdriver and launches the
305         webdriver specific to that browser.
306
307         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
308         (BrowserDriver.launch_webdriver):
309         (BrowserDriver):
310         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
311         (LinuxBrowserDriver.launch_webdriver):
312         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
313         (LinuxChromeDriver.launch_url):
314         (LinuxChromeDriver):
315         (LinuxChromeDriver.launch_driver):
316         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
317         (EpiphanyBrowserDriver.launch_url):
318         (EpiphanyBrowserDriver):
319         (EpiphanyBrowserDriver.launch_driver):
320         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
321         (LinuxFirefoxDriver):
322         (LinuxFirefoxDriver.launch_url):
323         (LinuxFirefoxDriver.launch_driver):
324         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
325         (GTKMiniBrowserDriver.launch_url):
326         (GTKMiniBrowserDriver):
327         (GTKMiniBrowserDriver.launch_driver):
328         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
329         (OSXBrowserDriver._launch_webdriver):
330         (OSXBrowserDriver):
331         (OSXBrowserDriver._screen_size):
332         (OSXBrowserDriver._insert_url):
333         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
334         (OSXChromeDriver):
335         (OSXChromeDriver.launch_url):
336         (OSXChromeDriver.launch_driver):
337         (OSXChromeCanaryDriver):
338         (OSXChromeCanaryDriver.launch_url):
339         (OSXChromeCanaryDriver.launch_driver):
340         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
341         (OSXFirefoxDriver):
342         (OSXFirefoxDriver.launch_url):
343         (OSXFirefoxDriver.launch_driver):
344         (OSXFirefoxNightlyDriver):
345         (OSXFirefoxNightlyDriver.launch_url):
346         (OSXFirefoxNightlyDriver.launch_driver):
347         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
348         (OSXSafariDriver.launch_driver):
349
350 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
351
352         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
353         https://bugs.webkit.org/show_bug.cgi?id=174793
354
355         Reviewed by Tim Horton.
356
357         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
358         down. Without r219765, this test will dereference null and crash.
359
360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
361         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
362         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
363         (TEST):
364
365 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
366
367         [Win] Implement Authentication dialog in MiniBrowser
368         https://bugs.webkit.org/show_bug.cgi?id=174662
369
370         Reviewed by Alex Christensen.
371
372         * MiniBrowser/win/Common.cpp:
373         (CustomUserAgent):
374         (DisplayAuthDialog):
375         (AuthDialogProc):
376         * MiniBrowser/win/MiniBrowserLib.rc:
377         * MiniBrowser/win/MiniBrowserLibResource.h:
378         * MiniBrowser/win/ResourceLoadDelegate.cpp:
379         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
380
381 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
382
383         Handle case where line_numbers is None instead of an array of line numbers
384         https://bugs.webkit.org/show_bug.cgi?id=174775
385
386         Reviewed by Aakash Jain.
387
388         Added files set line_numbers to None in process_file.
389
390         * Scripts/webkitpy/style/filereader.py:
391         (TextFileReader.process_file): Handle case where line_number is set to None.
392         * Scripts/webkitpy/style/main_unittest.py:
393         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
394
395 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
396
397         [WPE] Add libepoxy to the Jhbuild moduleset
398         https://bugs.webkit.org/show_bug.cgi?id=174711
399
400         Reviewed by Carlos Alberto Lopez Perez.
401
402         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
403
404 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
405
406         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
407         https://bugs.webkit.org/show_bug.cgi?id=174780
408
409         Reviewed by Carlos Garcia Campos.
410
411         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
412         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
413         in case the eglplatform.h header doesn't provide that macro. This replicates
414         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
415
416 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
417
418         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
419         https://bugs.webkit.org/show_bug.cgi?id=174758
420
421         Reviewed by Dan Bernstein.
422
423         Migrate position-information-related unit tests from the PositionInformationTests suite to
424         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
425
426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
427         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
428         (TestWebKitAPI::checkElementTypeAndBoundingRect):
429         (TestWebKitAPI::TEST):
430         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
431         * TestWebKitAPI/cocoa/TestWKWebView.h:
432         * TestWebKitAPI/cocoa/TestWKWebView.mm:
433         (-[TestWKWebView activatedElementAtPosition:]):
434
435 2017-07-22  Chris Dumez  <cdumez@apple.com>
436
437         REGRESSION(r204565): WKObject is broken
438         https://bugs.webkit.org/show_bug.cgi?id=174736
439         <rdar://problem/33246169>
440
441         Reviewed by Dan Bernstein.
442
443         Add API test that used to crash.
444
445         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
446         (TestWebKitAPI::TEST):
447
448 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
449
450         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
451         https://bugs.webkit.org/show_bug.cgi?id=174705
452
453         Reviewed by Mark Lam.
454
455         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
456         (TestWebKitAPI::testThreadGroup):
457         (TestWebKitAPI::TEST):
458
459 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
460
461         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
462         https://bugs.webkit.org/show_bug.cgi?id=174724
463
464         Reviewed by Aakash Jain.
465
466         * Scripts/webkitpy/port/ios_simulator.py:
467         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
468         simulator. Errors here should be treated the same as no simulators found.
469
470 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
471
472         [CMake] Add an option to stop build after generating project files
473         https://bugs.webkit.org/show_bug.cgi?id=174664
474
475         Reviewed by Konstantin Tokarev.
476
477         Add "--generate-project-only" to stop build after generating project files.
478
479         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
480         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
481         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
482         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
483         (isGenerateProjectOnly): ditto
484
485 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
486
487         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
488         https://bugs.webkit.org/show_bug.cgi?id=174501
489
490         Reviewed by Darin Adler.
491
492         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
493         (TestWebKitAPI::TEST):
494
495 2017-07-20  David Quesada  <david_quesada@apple.com>
496
497         Add SPI to notify WKNavigationDelegate about client redirects
498         https://bugs.webkit.org/show_bug.cgi?id=174680
499         rdar://problem/33184886
500
501         Reviewed by Brady Eidson.
502
503         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
504         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
505         (TEST):
506         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
507
508 2017-07-20  Brady Eidson  <beidson@apple.com>
509
510         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
511         https://bugs.webkit.org/show_bug.cgi?id=174685
512
513         Reviewed by Andy Estes.
514
515         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
516         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
517
518 2017-07-20  Brady Eidson  <beidson@apple.com>
519
520         Deprecate WebIconDatabase in WebKitLegacy/mac.
521         https://bugs.webkit.org/show_bug.cgi?id=174607
522
523         Reviewed by Alex Christensen.
524
525         * DumpRenderTree/mac/TestRunnerMac.mm:
526
527 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
528
529         lint-test-expectations should be run during style checking
530         https://bugs.webkit.org/show_bug.cgi?id=173559
531         <rdar://problem/32854941>
532
533         Reviewed by Aakash Jain.
534
535         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
536         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
537         prevents identifying errors on specific lines in a file.
538         * Scripts/webkitpy/style/main_unittest.py:
539         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
540         case where a linter error is in the file modified, but the line modified is not related to
541         the linter error.
542
543 2017-07-20  Brady Eidson  <beidson@apple.com>
544
545         Remove WebIconDatabase from WebKitLegacy/win.
546         https://bugs.webkit.org/show_bug.cgi?id=174608
547
548         Reviewed by Alex Christensen.
549
550         * DumpRenderTree/win/DumpRenderTree.cpp:
551         (main):
552         * DumpRenderTree/win/TestRunnerWin.cpp:
553         (TestRunner::setIconDatabaseEnabled):
554
555 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
556
557         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
558         https://bugs.webkit.org/show_bug.cgi?id=174671
559
560         Reviewed by Carlos Garcia Campos.
561
562         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
563         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
564         priority for this source in order to have it dispatched on the same
565         priority as the other WebKit-controlled GSource objects.
566
567 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
568
569         lint-test-expectations should be run during style checking
570         https://bugs.webkit.org/show_bug.cgi?id=173559
571         <rdar://problem/32854941>
572
573         Reviewed by Daniel Bates.
574
575         Follow up fix addressing style and a few minor bugs.
576
577         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
578         (TestExpectationParser.__init__): Use lambda x: x instead of str
579         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
580         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
581         reduce the calls of _shorten_filename, fix minor bug in appending the current
582         expectation's line number instead of the previous ones, clarify treatment of None
583         in file-to-line-number mapping.
584         (TestExpectations._report_warnings): Collapse call.
585         * Scripts/webkitpy/style/checkers/test_expectations.py:
586         (TestExpectationsChecker.lint_test_expectations):
587         * Scripts/webkitpy/style/filereader.py: Re-write comment.
588         (TextFileReader.process_file): Add comment explaining treatment of None in
589         file-to-line-number mapping.
590         (TextFileReader.delete_file): Collapse call.
591
592 2017-07-19  Chris Dumez  <cdumez@apple.com>
593
594         Unreviewed attempt to fix API test failure after r219663.
595
596         The test was hard-coding an exception string and the string has changed slightly
597         in r219663.
598
599         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
600         (TEST):
601
602 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
603
604         Don't write file URLs to iOS Pasteboard
605         https://bugs.webkit.org/show_bug.cgi?id=174647
606         <rdar://problem/33199730>
607
608         Reviewed by Wenson Hsieh.
609
610         Updating tests to reflect the lack of file URLs for images.
611
612         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
613         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
614         (checkEstimatedSize):
615         (TestWebKitAPI::TEST):
616
617 2017-07-19  Brady Eidson  <beidson@apple.com>
618
619         iBooks sometimes crashes when closing a book.
620         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
621
622         Reviewed by Oliver Hunt.
623
624         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
625         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
626         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
627         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
628         (TestWebKitAPI::TEST):
629
630         Add a "spin the runloop X number of times" utility:
631         * TestWebKitAPI/Utilities.h:
632         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
633         (TestWebKitAPI::Util::spinRunLoop):
634
635 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
636
637         lint-test-expectations should be run during style checking
638         https://bugs.webkit.org/show_bug.cgi?id=173559
639         <rdar://problem/32854941>
640
641         Reviewed by David Kilzer.
642
643         Running the test expectation linter requires reading both files and lines not in the
644         patch because, for example, deletion of a test can cause a lint failure even though
645         no test expectations where modified. This means that the linter will occasionally warn
646         about lines which were not changed in a given patch but whose error is related to a
647         change made in that patch.
648
649         * Scripts/webkitpy/common/system/filesystem_mock.py:
650         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
651         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
652         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
653         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
654         content, description of the error and the name of the associated test.
655         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
656         (TestExpectationParser.__init__): Pass shorten_filename function to
657         TestExpectationsParser to add a deleted file to the related_files dictionary.
658         (TestExpectationParser._check_test_exists): If the test does not exist, add the
659         missing path to the related_files dictionary.
660         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
661         files and line numbers related to this test expectation line. This will allow
662         tracking linter errors in the style checker occurring across multiple files.
663         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
664         lines to related_files dictionary.
665         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
666         (TestExpectations._report_warnings): Construct warning object instead of string
667         when adding to warnings list.
668         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
669         clean-up log.
670         * Scripts/webkitpy/style/checker.py:
671         (ProcessorBase.do_association_check): Add required function for processor classes.
672         (StyleProcessor):
673         (StyleProcessor.do_association_check): Run the TestExpectations linter when
674         checking for errors between associated files.
675         * Scripts/webkitpy/style/checkers/test_expectations.py:
676         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
677         (TestExpectationsChecker):
678         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
679         of modified files, the current working directory and the host, determine if the linter
680         warning is associated with the changes.
681         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
682         style checker.
683         * Scripts/webkitpy/style/filereader.py:
684         (TextFileReader):
685         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
686         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
687         (TextFileReader.process_file): Track both the number of files changed and which lines
688         in those files were changed.
689         (TextFileReader.do_association_check): Run the processor's association check on all
690         modified or deleted files processed by TextFileReader.
691         (TextFileReader.delete_file): Track deleted files in _files dictionary.
692         (TextFileReader.count_delete_only_file): Deleted.
693         * Scripts/webkitpy/style/filereader_unittest.py:
694         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
695         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
696         * Scripts/webkitpy/style/main.py:
697         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
698         explicitly run the association check on the file reader.
699         * Scripts/webkitpy/style/main_unittest.py:
700         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
701         embedded in the style checker.
702         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
703         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
704         construct the TextFileReader object with a StyleProcessor used to run style checks on
705         specific files.
706         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
707         testing the test expectation linter inside the style checker. This host must contain a
708         mock file system with the basic structure of test expectations.
709         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
710         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
711         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
712         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
713         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
714         * Scripts/webkitpy/style/patchreader.py:
715         (PatchReader.check): Specify which file was deleted, run the association check.
716         * Scripts/webkitpy/style/patchreader_unittest.py:
717         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
718         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
719         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
720
721 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
722
723         [WTF] Implement WTF::ThreadGroup
724         https://bugs.webkit.org/show_bug.cgi?id=174081
725
726         Reviewed by Mark Lam.
727
728         Add WTF::ThreadGroup tests.
729
730         * TestWebKitAPI/CMakeLists.txt:
731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
732         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
733         (TestWebKitAPI::testThreadGroup):
734         (TestWebKitAPI::TEST):
735
736 2017-07-18  Andy Estes  <aestes@apple.com>
737
738         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
739         https://bugs.webkit.org/show_bug.cgi?id=174631
740
741         Reviewed by Tim Horton.
742
743         * DumpRenderTree/mac/Configurations/Base.xcconfig:
744         * MiniBrowser/Configurations/Base.xcconfig:
745         * MobileMiniBrowser/Configurations/Base.xcconfig:
746         * TestWebKitAPI/Configurations/Base.xcconfig:
747         * WebKitTestRunner/Configurations/Base.xcconfig:
748
749 2017-07-18  Andy Estes  <aestes@apple.com>
750
751         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
752         https://bugs.webkit.org/show_bug.cgi?id=174631
753
754         Reviewed by Sam Weinig.
755
756         * DumpRenderTree/mac/Configurations/Base.xcconfig:
757         * MiniBrowser/Configurations/Base.xcconfig:
758         * MobileMiniBrowser/Configurations/Base.xcconfig:
759         * TestWebKitAPI/Configurations/Base.xcconfig:
760         * WebKitTestRunner/Configurations/Base.xcconfig:
761
762 2017-07-18  Daniel Bates  <dabates@apple.com>
763
764         lldb: Add type summary for StringView
765         https://bugs.webkit.org/show_bug.cgi?id=174637
766
767         Reviewed by Sam Weinig.
768
769         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
770         StringView object will print output that has the form:
771
772             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
773               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
774               m_length = 2
775               m_is8Bit = true
776               m_underlyingString = 0x0000614000000a90
777             }
778
779         * lldb/lldb_webkit.py:
780         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
781         (WTFStringView_SummaryProvider):
782         (WTFStringViewProvider):
783         (WTFStringViewProvider.__init__):
784         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
785         (WTFStringViewProvider.get_length): Access field StringView.m_length.
786         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
787         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
788
789 2017-07-18  Andy Estes  <aestes@apple.com>
790
791         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
792         https://bugs.webkit.org/show_bug.cgi?id=174631
793
794         Reviewed by Dan Bernstein.
795
796         * DumpRenderTree/mac/Configurations/Base.xcconfig:
797         * MiniBrowser/Configurations/Base.xcconfig:
798         * MobileMiniBrowser/Configurations/Base.xcconfig:
799         * TestWebKitAPI/Configurations/Base.xcconfig:
800         * WebKitTestRunner/Configurations/Base.xcconfig:
801
802 2017-07-18  Devin Rousso  <drousso@apple.com>
803
804         Web Inspector: Add memoryCost to Inspector Protocol objects
805         https://bugs.webkit.org/show_bug.cgi?id=174478
806
807         Reviewed by Joseph Pecoraro.
808
809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
810         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
811         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
812         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
813         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
814         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
815         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
816         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
817         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
818         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
819         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
820         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
821         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
822         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
823         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
824         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
825         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
826
827 2017-07-18  Andy Estes  <aestes@apple.com>
828
829         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
830         https://bugs.webkit.org/show_bug.cgi?id=174631
831
832         Reviewed by Darin Adler.
833
834         * DumpRenderTree/mac/Configurations/Base.xcconfig:
835         * MiniBrowser/Configurations/Base.xcconfig:
836         * MobileMiniBrowser/Configurations/Base.xcconfig:
837         * TestWebKitAPI/Configurations/Base.xcconfig:
838         * WebKitTestRunner/Configurations/Base.xcconfig:
839
840 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
841
842         Unreviewed, fix the iOS build.
843
844         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
845
846         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
847         (TestWebKitAPI::TEST):
848
849 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
850
851         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
852         https://bugs.webkit.org/show_bug.cgi?id=174585
853         <rdar://problem/33302541>
854
855         Reviewed by Tim Horton.
856
857         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
858         being dragged when initiating a drag.
859
860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
861         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
862         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
863         (TestWebKitAPI::TEST):
864         * TestWebKitAPI/cocoa/TestWKWebView.h:
865
866         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
867
868         * TestWebKitAPI/cocoa/TestWKWebView.mm:
869         (-[TestWKWebView synchronouslyLoadHTMLString:]):
870
871 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
872
873         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
874         https://bugs.webkit.org/show_bug.cgi?id=174547
875
876         Reviewed by Alex Christensen.
877
878         * DumpRenderTree/PlatformWin.cmake:
879         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
880
881 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
882
883         Update style checker to deal with "final"
884         https://bugs.webkit.org/show_bug.cgi?id=174528
885
886         Reviewed by Alex Christensen.
887         
888         check-webkit-style shouldn't complain about an open brace to start a
889         line after a function definition with "final" or "const final".
890
891         * Scripts/webkitpy/style/checkers/cpp.py:
892         (check_braces):
893         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
894         (CppStyleTest.test_brace_at_begin_of_line):
895
896 2017-07-17  Alex Christensen  <achristensen@webkit.org>
897
898         Modernize content extension code
899         https://bugs.webkit.org/show_bug.cgi?id=174588
900
901         Reviewed by Sam Weinig.
902
903         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
904         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
905         (TestWebKitAPI::testRequest):
906         (TestWebKitAPI::makeBackend):
907         (TestWebKitAPI::TEST_F):
908
909 2017-07-17  Brady Eidson  <beidson@apple.com>
910
911         WKHTTPCookieStore observing only works on the default cookie store.
912         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
913
914         Reviewed by Sam Weinig.
915
916         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
917         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
918           called for the default store, a non-persistent store, and a custom store.
919         (TEST):
920
921 2017-07-16  Sam Weinig  <sam@webkit.org>
922
923         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
924         https://bugs.webkit.org/show_bug.cgi?id=174575
925
926         Reviewed by Brady Eidson.
927
928         * Scripts/svn-create-patch:
929         (findModificationType):
930         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
931         default value of "unknown".
932
933         (generateFileList):
934         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
935         for untracked, which matches our old behavior.
936
937 2017-07-17  Charlie Turner  <cturner@igalia.com>
938
939         Add some missing build dependencies on Fedora
940         https://bugs.webkit.org/show_bug.cgi?id=174578
941
942         Unreviewed dependency update.
943
944         * gtk/install-dependencies:
945
946 2017-07-16  Brady Eidson  <beidson@apple.com>
947
948         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
949         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
950
951         Reviewed by Tim Horton.
952
953         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
954         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
955         (TEST):
956
957 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
958
959         [GTK] Sort inspector GResource manifest to ensure reproducible builds
960         https://bugs.webkit.org/show_bug.cgi?id=174540
961
962         Reviewed by Michael Catanzaro.
963
964         * gtk/generate-inspector-gresource-manifest.py:
965         (get_filenames): sort list of input files
966
967 2017-07-15  Brady Eidson  <beidson@apple.com>
968
969         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
970         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
971
972         Reviewed by Tim Horton.
973
974         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
975         (TEST): Make this test more reliable by clearing everything beforehand.
976
977 2017-07-15  David Kilzer  <ddkilzer@apple.com>
978
979         Make it possible to extend check-webkit-style with Apple-internal checkers
980         <https://webkit.org/b/174464>
981         <rdar://problem/25564402>
982
983         Reviewed by Darin Adler.
984
985         * Scripts/webkitpy/style/checker.py: Import apple_additions.
986         (_all_categories): Add categories from apple_additions() if it
987         exists.
988         (CheckerDispatcher._create_checker): Create python checker
989         from apple_additions() if it exists.
990
991 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
992
993         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
994         https://bugs.webkit.org/show_bug.cgi?id=174539
995         <rdar://problem/33307395>
996
997         Reviewed by Darin Adler.
998
999         Adds a new unit test suite to cover action sheet popover presentation.
1000
1001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1002         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
1003         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
1004         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
1005
1006         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
1007
1008         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
1009         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1010
1011         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
1012
1013         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1014         (TestWebKitAPI::TEST):
1015
1016 2017-07-15  Sam Weinig  <sam@webkit.org>
1017
1018         [Scripts] Make svn-create-patch work better when called in sub directories
1019         https://bugs.webkit.org/show_bug.cgi?id=174551
1020
1021         Reviewed by Darin Adler.
1022
1023         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
1024           by ensuring that the prefix is applied as is done in generateDiff.
1025         - Silence output of explanatory lines from svn stat (" > move to ...")
1026           that show up in STDERR when running svn-create-patch.
1027         - Add verbose logging that I found useful while debugging this issue.
1028
1029         * Scripts/svn-create-patch:
1030         (findBaseUrl):
1031         (findMimeType):
1032         (findSourceFileAndRevision):
1033         (generateDiff):
1034         (generateFileList):
1035         (manufacturePatchForAdditionWithHistory):
1036
1037 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
1038
1039         Unreviewed build fix after r219537.
1040
1041         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1042
1043 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1044
1045         Add iOS 11 SPI
1046         https://bugs.webkit.org/show_bug.cgi?id=174430
1047         <rdar://problem/33269288>
1048
1049         Reviewed by Tim Horton.
1050
1051         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
1052         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
1053         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
1054
1055 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1056
1057         Failing to install on iPad simulators
1058         https://bugs.webkit.org/show_bug.cgi?id=174532
1059         <rdar://problem/33328347>
1060
1061         Reviewed by Stephanie Lewis.
1062
1063         * Scripts/webkitpy/xcode/simulated_device.py:
1064         (SimulatedDevice.install_app): Place install command in retry try-except block.
1065
1066 2017-07-14  Jeff Miller  <jeffm@apple.com>
1067
1068         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1069         https://bugs.webkit.org/show_bug.cgi?id=174524
1070
1071         Reviewed by Sam Weinig.
1072
1073         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1074         (TEST):
1075         Renamed TestParameter to TestParameter1.
1076         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1077
1078         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1079         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1080         Observe changes for two bundle parameters.
1081
1082         (-[BundleParametersPlugIn dealloc]):
1083         Remove observers for two bundle parameters.
1084
1085 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1086
1087         Unreviewed, rolling out r219510.
1088         https://bugs.webkit.org/show_bug.cgi?id=174525
1089
1090         Need to revert length() == 0 check for null string (Requested
1091         by yusukesuzuki on #webkit).
1092
1093         Reverted changeset:
1094
1095         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1096         static string if StringImpl is static"
1097         https://bugs.webkit.org/show_bug.cgi?id=174501
1098         http://trac.webkit.org/changeset/219510
1099
1100 2017-07-14  Jer Noble  <jer.noble@apple.com>
1101
1102         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1103         https://bugs.webkit.org/show_bug.cgi?id=174514
1104
1105         Reviewed by Sam Weinig.
1106
1107         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1108         (TestWebKitAPI::TEST_F):
1109
1110 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1111
1112         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1113         https://bugs.webkit.org/show_bug.cgi?id=174501
1114
1115         Reviewed by Darin Adler.
1116
1117         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1118         (TestWebKitAPI::TEST):
1119
1120 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1121
1122         Bring mac expectations in-line with other platforms
1123         https://bugs.webkit.org/show_bug.cgi?id=174472
1124         <rdar://problem/33297388>
1125
1126         Reviewed by David Kilzer.
1127
1128         The override order for Mac test expectations does not conform to the pattern used by iOS,
1129         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1130
1131             platform/mac-wk2
1132             platform/wk2
1133             platform/mac-elcapitan
1134             platform/mac-sierra
1135             generic
1136
1137         After this change, El Capitan's baseline search path looks like this:
1138
1139             platform/mac-sierra-wk2
1140             platform/mac-sierra
1141             platform/mac-wk2
1142             platform/wk2
1143             generic
1144
1145         * Scripts/webkitpy/port/mac.py:
1146         (MacPort.__init__): If a specific version is specified in the port name, use that
1147         as the os version.
1148         (MacPort.default_baseline_search_path): Expectation search paths should work the
1149         same way they do on other ports. Port + version overrides port, port overrides generic
1150         and wk1/wk2 should override expectations for the two combined.
1151         * Scripts/webkitpy/port/mac_unittest.py:
1152         (MacTest.test_tests_for_other_platforms): Deleted.
1153         (MacTest._assert_search_path): Deleted.
1154         (MacTest.test_baseline_search_path): Deleted.
1155         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1156         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1157         (test_rebaseline_test_and_print_scm_changes): Ditto.
1158         (test_rebaseline_and_copy_test): Ditto.
1159         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1160         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1161         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1162
1163 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1164
1165         Fix style checker unit test
1166
1167         Unreviewed WebKit2 => WebKit fixup.
1168
1169         * Scripts/webkitpy/style/checker_unittest.py:
1170         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1171
1172 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1173
1174         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1175
1176         Unreviewed build fix.
1177
1178         r219492 missed one hunk from its partial revert of r219489.
1179         This patch reverts that hunk.
1180
1181         * TestWebKitAPI/CMakeLists.txt:
1182
1183 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1184
1185         Use the old WebKit/WebKit2 targets for CMake builds.
1186
1187         Unreviewed build fix.
1188
1189         We can update the target names to match the Framework names in a future patch.
1190         This is a partial revert of r219489.
1191
1192         * TestWebKitAPI/CMakeLists.txt:
1193         WebKitLegacy => WebKit
1194         WebKit => WebKit2
1195
1196 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1197
1198         Fix TestWebKit API.
1199         https://bugs.webkit.org/show_bug.cgi?id=174164
1200         rdar://problem/33137595
1201
1202         Reviewed by Dan Bernstein.
1203
1204         * TestWebKitAPI/CMakeLists.txt:
1205         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1206         * TestWebKitAPI/PlatformGTK.cmake:
1207
1208 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1209
1210         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1211         https://bugs.webkit.org/show_bug.cgi?id=174164
1212         rdar://problem/33137595
1213
1214         Reviewed by Dan Bernstein.
1215
1216         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1217         (ShouldBuildTest):
1218         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1219         * Scripts/build-webkit:
1220         * Scripts/do-file-rename:
1221         * Scripts/do-webcore-rename:
1222         * Scripts/update-webkit-localizable-strings:
1223         * Scripts/webkitpy/common/config/watchlist:
1224         * Scripts/webkitpy/style/checker.py:
1225         * Scripts/webkitpy/style/checkers/featuredefines.py:
1226         * gtk/make-dist.py:
1227         (ensure_version_if_possible):
1228         * gtk/manifest.txt.in:
1229
1230 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1231
1232         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1233         https://bugs.webkit.org/show_bug.cgi?id=174162
1234         rdar://problem/33137594
1235
1236         Reviewed by Dan Bernstein.
1237
1238         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
1239
1240         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1241         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1242         * EWSTools/configure-clang-linux.sh:
1243         * Scripts/build-webkit:
1244         * Scripts/do-file-rename:
1245         * Scripts/do-webcore-rename:
1246         * Scripts/update-webkit-localizable-strings:
1247         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1248         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1249         * Scripts/webkitpy/style/checkers/featuredefines.py:
1250         * gtk/manifest.txt.in:
1251
1252 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
1253
1254         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
1255         https://bugs.webkit.org/show_bug.cgi?id=174438
1256         <rdar://problem/33277112>
1257
1258         Reviewed by Aakash Jain.
1259
1260         Given a patch, this will convert the changes from the path to the new directory structure.
1261
1262         * Scripts/rebase-patch-after-webkit-move: Added.
1263         (append_source): Append 'Source' to the provided path.
1264         (is_editable_line): Return true if a line the script expects to modify.
1265         (needs_rebase): Return if a line needs to be rebased based on it's content.
1266         (rebase_line): Rebase the provided line.
1267         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
1268         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
1269         were provided.
1270
1271 2017-07-12  Nan Wang  <n_wang@apple.com>
1272
1273         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1274         https://bugs.webkit.org/show_bug.cgi?id=174393
1275         <rdar://problem/33248006>
1276
1277         Reviewed by Chris Fleizach.
1278
1279         * DumpRenderTree/AccessibilityUIElement.cpp:
1280         (textMarkerRangeMatchesTextNearMarkersCallback):
1281         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1282         (AccessibilityUIElement::getJSClass):
1283         * DumpRenderTree/AccessibilityUIElement.h:
1284         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1285         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1286         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1287         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1288         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1289         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1290         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1291         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1292
1293 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1294
1295         Unreviewed, rolling out r219409.
1296
1297         The revision caused the Windows builds to fail.
1298
1299         Reverted changeset:
1300
1301         "AX: [iOS] Implement a way to retrieve a text marker range
1302         with desired text that is closest to a position"
1303         https://bugs.webkit.org/show_bug.cgi?id=174393
1304         http://trac.webkit.org/changeset/219409
1305
1306 2017-07-12  Nan Wang  <n_wang@apple.com>
1307
1308         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1309         https://bugs.webkit.org/show_bug.cgi?id=174393
1310         <rdar://problem/33248006>
1311
1312         Reviewed by Chris Fleizach.
1313
1314         * DumpRenderTree/AccessibilityUIElement.cpp:
1315         (textMarkerRangeMatchesTextNearMarkersCallback):
1316         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1317         (AccessibilityUIElement::getJSClass):
1318         * DumpRenderTree/AccessibilityUIElement.h:
1319         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1320         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1321         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1322         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1323         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1324         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1325         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1326         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1327
1328 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
1329
1330         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
1331         https://bugs.webkit.org/show_bug.cgi?id=174197
1332
1333         Reviewed by Darin Adler.
1334
1335         This bit me the first time I tried to submit a patch to WebKit, and still I have
1336         to manually edit the ChangeLog every time I use the script.
1337
1338         This generates a more convenient and standard ChangeLog entry.
1339
1340         * Scripts/prepare-ChangeLog:
1341         (generateNewChangeLogs):
1342
1343 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1344
1345         Unreviewed, rolling out r219401.
1346
1347         This revision rolled out the previous patch, but after talking
1348         with reviewer, a rebaseline is what was needed.Rolling back in
1349         before rebaseline.
1350
1351         Reverted changeset:
1352
1353         "Unreviewed, rolling out r219379."
1354         https://bugs.webkit.org/show_bug.cgi?id=174400
1355         http://trac.webkit.org/changeset/219401
1356
1357 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1358
1359         Unreviewed, rolling out r219379.
1360
1361         This revision caused a consistent failure in the test
1362         fast/dom/Window/property-access-on-cached-window-after-frame-
1363         removed.html.
1364
1365         Reverted changeset:
1366
1367         "Remove NAVIGATOR_HWCONCURRENCY"
1368         https://bugs.webkit.org/show_bug.cgi?id=174400
1369         http://trac.webkit.org/changeset/219379
1370
1371 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1372
1373         [WPE] Use libepoxy
1374         https://bugs.webkit.org/show_bug.cgi?id=172104
1375
1376         Reviewed by Michael Catanzaro.
1377
1378         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
1379         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
1380
1381 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1382
1383         [GTK][WPE] Align Jhbuild patches for GStreamer packages
1384         https://bugs.webkit.org/show_bug.cgi?id=174363
1385
1386         Reviewed by Michael Catanzaro.
1387
1388         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
1389         between the GTK+ and WPE port. There's no reason for the two ports to apply
1390         different patches over same versions of GStreamer releases.
1391
1392         This aligns the two ports on this specific issue. Next we'll look into
1393         creating a single GStreamer-specific Jhbuild moduleset that will allow us
1394         to keep these patches in a single place, avoiding duplicate files.
1395
1396         * gtk/jhbuild.modules:
1397         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1398         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
1399         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1400         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
1401
1402 2017-07-11  Dean Jackson  <dino@apple.com>
1403
1404         Remove NAVIGATOR_HWCONCURRENCY
1405         https://bugs.webkit.org/show_bug.cgi?id=174400
1406
1407         Reviewed by Sam Weinig.
1408
1409         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1410
1411 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
1412
1413         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
1414         https://bugs.webkit.org/show_bug.cgi?id=174239
1415
1416         Reviewed by Brady Eidson.
1417
1418         Create windows with specific features set and make sure those are properly reflected in the
1419         WKWindowFeatures object.
1420
1421         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1422         (resetToConsistentState):
1423         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1424         (TEST):
1425
1426 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
1427
1428         Do not duplicate files when deleting directories with svn 1.9
1429         https://bugs.webkit.org/show_bug.cgi?id=174339
1430         <rdar://problem/33226781>
1431
1432         Reviewed by David Kilzer.
1433
1434         * Scripts/svn-create-patch:
1435         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
1436         (generateFileList): Determine which files are deleted because they are part of a
1437         directory being deleted.
1438
1439 2017-07-11  Dean Jackson  <dino@apple.com>
1440
1441         Rolling out r219372.
1442
1443         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1444
1445 2017-07-11  Dean Jackson  <dino@apple.com>
1446
1447         Remove NAVIGATOR_HWCONCURRENCY
1448         https://bugs.webkit.org/show_bug.cgi?id=174400
1449
1450         Reviewed by Sam Weinig.
1451
1452         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1453
1454 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1455
1456         Teach build workers to fetch archives from S3.
1457         https://bugs.webkit.org/show_bug.cgi?id=174384
1458
1459         Reviewed by Aakash Jain.
1460
1461         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1462         (DownloadBuiltProduct):
1463
1464 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1465
1466         Configure buildbot to transfer all archives to S3.
1467         Previously this was Mac only, but it's time to expand!
1468         https://bugs.webkit.org/show_bug.cgi?id=174378
1469         
1470         Reviewed by Aakash Jain.
1471
1472         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1473         (BuildFactory.__init__):
1474
1475 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
1476
1477         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
1478         https://bugs.webkit.org/show_bug.cgi?id=174350
1479
1480         Reviewed by Xabier Rodriguez-Calvar.
1481
1482         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
1483         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
1484         patches are removed. The patches for gst-plugins-good are updated, removing
1485         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
1486         rtpbin elements that will help with the EMEv3 development.
1487
1488         * wpe/jhbuild.modules:
1489         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1490         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1491         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1492         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1493         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1494         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1495         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1496         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1497         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1498
1499 2017-07-10  John Wilander  <wilander@apple.com>
1500
1501         Resource Load Statistics: Prune statistics in orders of importance
1502         https://bugs.webkit.org/show_bug.cgi?id=174215
1503         <rdar://problem/33164403>
1504
1505         Reviewed by Chris Dumez.
1506
1507         Nest infrastructure. Adds these functions:
1508         1. testRunner.setStatisticsLastSeen()
1509         2. setStatisticsMaxStatisticsEntries()
1510         3. setStatisticsPruneEntriesDownTo()
1511
1512         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1513         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1514         (WTR::TestRunner::setStatisticsLastSeen):
1515         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1516         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1517         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1518         * WebKitTestRunner/TestController.cpp:
1519         (WTR::TestController::setStatisticsLastSeen):
1520         (WTR::TestController::setMaxStatisticsEntries):
1521         (WTR::TestController::setPruneEntriesDownTo):
1522         * WebKitTestRunner/TestController.h:
1523         * WebKitTestRunner/TestInvocation.cpp:
1524         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1525         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1526         (WTR::TestController::setStatisticsLastSeen):
1527         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1528         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1529
1530 2017-07-03  Brian Burg  <bburg@apple.com>
1531
1532         Web Replay: remove some unused code
1533         https://bugs.webkit.org/show_bug.cgi?id=173903
1534
1535         Rubber-stamped by Joseph Pecoraro.
1536
1537         * Scripts/run-input-generator-tests: Removed.
1538         * Scripts/webkitpy/replay/__init__.py: Removed.
1539         * Scripts/webkitpy/replay/main.py: Removed.
1540
1541 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1542
1543         [WPE] Fix layout test baseline and TestExpectations hierarchy
1544         https://bugs.webkit.org/show_bug.cgi?id=174092
1545
1546         Reviewed by Michael Catanzaro.
1547
1548         Like for the GTK+ port, override the default_baseline_search_path() and
1549         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1550         Both methods operate on a short list of search paths that defaults to 'wpe' and
1551         'wk2', along with any other user-specified platform directory.
1552
1553         The test_expectations_file_position() method is overridden for testing purposes,
1554         and relevant unit tests are added.
1555
1556         * Scripts/webkitpy/port/wpe.py:
1557         (WPEPort._search_paths):
1558         (WPEPort):
1559         (WPEPort.default_baseline_search_path):
1560         (WPEPort._port_specific_expectations_files):
1561         (WPEPort.test_expectations_file_position):
1562         * Scripts/webkitpy/port/wpe_unittest.py:
1563         (WPEPortTest.test_default_baseline_search_path):
1564         (WPEPortTest):
1565         (WPEPortTest.test_port_specific_expectations_files):
1566
1567 2017-07-10  Chris Dumez  <cdumez@apple.com>
1568
1569         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
1570         https://bugs.webkit.org/show_bug.cgi?id=174301
1571
1572         Reviewed by Brent Fulgham.
1573
1574         Rename some of the testRunner API for clarity and to better match what it calls
1575         internally.
1576
1577         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1578         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1579         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1580         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1581         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1582         * WebKitTestRunner/TestController.cpp:
1583         (WTR::TestController::statisticsUpdateCookiePartitioning):
1584         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1585         * WebKitTestRunner/TestController.h:
1586         * WebKitTestRunner/TestInvocation.cpp:
1587         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1588         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1589         (WTR::TestController::statisticsUpdateCookiePartitioning):
1590         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1591
1592 2017-07-10  Charlie Turner  <cturner@igalia.com>
1593
1594         [GStreamer] Live twitch.tv videos do not play
1595         https://bugs.webkit.org/show_bug.cgi?id=174222
1596
1597         Reviewed by Michael Catanzaro.
1598
1599         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1600         fixes videos not playing on twitch.tv.
1601
1602         * gtk/jhbuild.modules:
1603
1604 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1605
1606         Add WebGL2 configuration option to build-webkit
1607         https://bugs.webkit.org/show_bug.cgi?id=174251
1608
1609         Reviewed by Michael Catanzaro.
1610
1611         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1612         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1613         is marked as enabled for the Apple Cocoa ports.
1614
1615 2017-07-08  Chris Dumez  <cdumez@apple.com>
1616
1617         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1618         https://bugs.webkit.org/show_bug.cgi?id=174290
1619
1620         Reviewed by Brent Fulgham.
1621
1622         Rename testRunner API to match the new internal API names.
1623
1624         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1625         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1626         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1627         (WTR::TestRunner::statisticsSubmitTelemetry):
1628         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1629         * WebKitTestRunner/TestController.cpp:
1630         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1631         (WTR::TestController::statisticsSubmitTelemetry):
1632         * WebKitTestRunner/TestController.h:
1633         * WebKitTestRunner/TestInvocation.cpp:
1634         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1635         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1636         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1637         (WTR::TestController::statisticsSubmitTelemetry):
1638
1639 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1640
1641         Drop NOSNIFF compile flag
1642         https://bugs.webkit.org/show_bug.cgi?id=174289
1643
1644         Reviewed by Michael Catanzaro.
1645
1646         * Scripts/webkitperl/FeatureList.pm:
1647         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1648
1649 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1650
1651         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
1652         https://bugs.webkit.org/show_bug.cgi?id=174219
1653         <rdar://problem/32083177>
1654
1655         Reviewed by Ryosuke Niwa.
1656
1657         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
1658         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
1659         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
1660         place.
1661
1662         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
1663         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
1664         no action is taken when dropping.
1665
1666         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
1667         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1668         (TestWebKitAPI::TEST):
1669         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1670         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1671         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1672         (-[MockDragDropSession allowsMoveOperation]):
1673         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
1674         (-[MockDataInteractionSession initWithWindow:allowMove:]):
1675         (-[DataInteractionSimulator initWithWebView:]):
1676         (-[DataInteractionSimulator runFrom:to:]):
1677         (-[DataInteractionSimulator _advanceProgress]):
1678         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
1679         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
1680         (-[MockDataInteractionSession initWithWindow:]): Deleted.
1681
1682 2017-07-07  Commit Queue  <commit-queue@webkit.org>
1683
1684         Unreviewed, rolling out r219238, r219239, and r219241.
1685         https://bugs.webkit.org/show_bug.cgi?id=174265
1686
1687         "fast/workers/dedicated-worker-lifecycle.html is flaky"
1688         (Requested by yusukesuzuki on #webkit).
1689
1690         Reverted changesets:
1691
1692         "[WTF] Implement WTF::ThreadGroup"
1693         https://bugs.webkit.org/show_bug.cgi?id=174081
1694         http://trac.webkit.org/changeset/219238
1695
1696         "Unreviewed, build fix after r219238"
1697         https://bugs.webkit.org/show_bug.cgi?id=174081
1698         http://trac.webkit.org/changeset/219239
1699
1700         "Unreviewed, CLoop build fix after r219238"
1701         https://bugs.webkit.org/show_bug.cgi?id=174081
1702         http://trac.webkit.org/changeset/219241
1703
1704 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1705
1706         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1707         https://bugs.webkit.org/show_bug.cgi?id=174250
1708
1709         Reviewed by Carlos Alberto Lopez Perez.
1710
1711         * Scripts/webkitperl/FeatureList.pm:
1712
1713 2017-07-07  Charlie Turner  <cturner@igalia.com>
1714         [GStreamer] vid.me videos do not play
1715         https://bugs.webkit.org/show_bug.cgi?id=172240
1716
1717         Reviewed by Xabier Rodriguez-Calvar.
1718
1719         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1720         have the existing libsoup build against GNOME to avoid header drift
1721         against GStreamer's linked Soup library.
1722
1723         * gtk/jhbuild.modules:
1724
1725 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1726
1727         Write a support script to enable buildbot to upload to S3
1728         https://bugs.webkit.org/show_bug.cgi?id=174196
1729         
1730         Reviewed by Stephanie Lewis.
1731
1732         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
1733         (uploadToS3):
1734         (archiveExists):
1735
1736 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1737
1738         Enabling uploading archives to S3.
1739         https://bugs.webkit.org/show_bug.cgi?id=174198
1740         
1741         Reviewed by Stephanie Lewis.
1742
1743         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1744         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1745         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1746         (TransferToS3): Transfer full and minified archives to S3
1747
1748 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1749
1750         [WTF] Implement WTF::ThreadGroup
1751         https://bugs.webkit.org/show_bug.cgi?id=174081
1752
1753         Reviewed by Mark Lam.
1754
1755         Add WTF::ThreadGroup tests.
1756
1757         * TestWebKitAPI/CMakeLists.txt:
1758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1759         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1760         (TestWebKitAPI::TEST):
1761
1762 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1763
1764         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1765         https://bugs.webkit.org/show_bug.cgi?id=174150
1766
1767         Reviewed by Mark Lam.
1768
1769         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1770         (TestWebKitAPI::TEST):
1771         * TestWebKitAPI/TestsController.cpp:
1772         (TestWebKitAPI::TestsController::TestsController):
1773
1774 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1775
1776         Enabling uploading archives to S3.
1777         https://bugs.webkit.org/show_bug.cgi?id=174198
1778         
1779         Reviewed by Lucas Forschler.
1780
1781         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1782         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1783         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1784         (TransferToS3): Transfer full and minified archives to S3
1785
1786 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1787
1788         [GTK][WPE] kill-old-process should kill more webkit related process
1789         https://bugs.webkit.org/show_bug.cgi?id=174220
1790
1791         Reviewed by Michael Catanzaro.
1792
1793         Generate list of possible webkit-related process names and add
1794         them to the list of process to kill.
1795         Also update the possible system related process for GTK+/WPE.
1796
1797         * BuildSlaveSupport/kill-old-processes:
1798         (listAllWebKitPrograms):
1799         (main):
1800
1801 2017-07-06  Chris Dumez  <cdumez@apple.com>
1802
1803         FileMonitor should not be ref counted
1804         https://bugs.webkit.org/show_bug.cgi?id=174166
1805
1806         Reviewed by Brent Fulgham.
1807
1808         Update the API tests to reflect the API change.
1809
1810         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1811         (TestWebKitAPI::TEST_F):
1812
1813 2017-07-06  Commit Queue  <commit-queue@webkit.org>
1814
1815         Unreviewed, rolling out r219194.
1816         https://bugs.webkit.org/show_bug.cgi?id=174207
1817
1818         it broke some layout tests (Requested by clopez on #webkit).
1819
1820         Reverted changeset:
1821
1822         "[GStreamer] vid.me videos do not play"
1823         https://bugs.webkit.org/show_bug.cgi?id=172240
1824         http://trac.webkit.org/changeset/219194
1825
1826 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1827
1828         Unreviewed, rolling out r219178.
1829
1830         This caused a consistent failure with the API test
1831         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1832
1833         Reverted changeset:
1834
1835         "[WTF] Clean up StringStatics.cpp by using
1836         LazyNeverDestroyed<> for Atoms"
1837         https://bugs.webkit.org/show_bug.cgi?id=174150
1838         http://trac.webkit.org/changeset/219178
1839
1840 2017-07-06  Alicia Boya García  <aboya@igalia.com>
1841
1842         Add CWD to Perl library path (no longer the default since 5.26.0)
1843         https://bugs.webkit.org/show_bug.cgi?id=174200
1844
1845         Reviewed by Michael Catanzaro.
1846
1847         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1848         (SetupGitClone._get_username_and_email):
1849
1850 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1851
1852         Unreviewed, update my email address.
1853
1854         * Scripts/webkitpy/common/config/contributors.json:
1855
1856 2017-07-06  Charlie Turner  <cturner@igalia.com>
1857         [GStreamer] vid.me videos do not play
1858         https://bugs.webkit.org/show_bug.cgi?id=172240
1859
1860         Reviewed by Xabier Rodriguez-Calvar.
1861
1862         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1863         have the existing libsoup build against GNOME to avoid header drift
1864         against GStreamer's linked Soup library.
1865
1866         * gtk/jhbuild.modules:
1867
1868 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1869
1870         [WTF] Move SoftLinking.h into WTF
1871         https://bugs.webkit.org/show_bug.cgi?id=174000
1872
1873         Reviewed by Alex Christensen.
1874
1875         * DumpRenderTree/mac/TestRunnerMac.mm:
1876         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1877         (test_primary_header):
1878         (ErrorCollector.__init__): Deleted.
1879         (ErrorCollector.__call__): Deleted.
1880         (ErrorCollector.results): Deleted.
1881         (ErrorCollector.result_list): Deleted.
1882         (ErrorCollector.verify_all_categories_are_seen): Deleted.
1883         (MockIo.open): Deleted.
1884         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
1885         (CppFunctionsTest.test_create_acronym): Deleted.
1886         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
1887         (CppFunctionsTest.test_parameter): Deleted.
1888         (CppFunctionsTest.test_single_line_view): Deleted.
1889         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
1890         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
1891         (CppFunctionsTest.test_parameter_list): Deleted.
1892         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
1893         (CppStyleTestBase.process_file_data): Deleted.
1894         (CppStyleTestBase.perform_lint): Deleted.
1895         (CppStyleTestBase.perform_single_line_lint): Deleted.
1896         (CppStyleTestBase.perform_multi_line_lint): Deleted.
1897         (CppStyleTestBase.perform_language_rules_check): Deleted.
1898         (CppStyleTestBase.perform_function_lengths_check): Deleted.
1899         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
1900         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
1901         (CppStyleTestBase.perform_include_what_you_use): Deleted.
1902         (CppStyleTestBase.perform_header_guard_check): Deleted.
1903         (CppStyleTestBase.assert_lint): Deleted.
1904         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
1905         (CppStyleTestBase.assert_multi_line_lint): Deleted.
1906         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
1907         (CppStyleTestBase.assert_language_rules_check): Deleted.
1908         (CppStyleTestBase.assert_include_what_you_use): Deleted.
1909         (CppStyleTestBase.assert_header_guard): Deleted.
1910         (CppStyleTestBase.assert_blank_lines_check): Deleted.
1911         (CppStyleTestBase.assert_positions_equal): Deleted.
1912         (FunctionDetectionTest.test_basic_function_detection): Deleted.
1913         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
1914         (FunctionDetectionTest.test_pure_function_detection): Deleted.
1915         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
1916         (FunctionDetectionTest.test_ignore_macros): Deleted.
1917         (FunctionDetectionTest.test_non_functions): Deleted.
1918         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
1919         (FunctionDetectionTest.test_parameter_list): Deleted.
1920         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1921         (CppStyleTest.test_asm_lines_ignored): Deleted.
1922         (CppStyleTest.test_get_line_width): Deleted.
1923         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1924         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1925         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1926         (CppStyleTest.test_position): Deleted.
1927         (CppStyleTest.test_rfind_in_lines): Deleted.
1928         (CppStyleTest.test_close_expression): Deleted.
1929         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1930         (CppStyleTest.test_cstyle_cast): Deleted.
1931         (CppStyleTest.test_runtime_casting): Deleted.
1932         (CppStyleTest.test_runtime_selfinit): Deleted.
1933         (CppStyleTest.test_runtime_rtti): Deleted.
1934         (CppStyleTest.test_static_cast_readability): Deleted.
1935         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1936         (CppStyleTest.void): Deleted.
1937         (CppStyleTest.test_deprecated_cast): Deleted.
1938         (CppStyleTest.test_mock_method): Deleted.
1939         (CppStyleTest.test_sizeof_type): Deleted.
1940         (CppStyleTest.cases): Deleted.
1941         (CppStyleTest.for): Deleted.
1942         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1943         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1944         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1945         (CppStyleTest.test_include_what_you_use): Deleted.
1946         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1947         (CppStyleTest.test_cleanse_line): Deleted.
1948         (CppStyleTest.test_multi_line_comments): Deleted.
1949         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1950         (CppStyleTest.test_multiline_strings): Deleted.
1951         (CppStyleTest.test_platformh_comments): Deleted.
1952         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1953         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1954         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1955         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1956         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1957         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1958         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1959         (CppStyleTest.test_check_posix_threading): Deleted.
1960         (CppStyleTest.test_insecure_string_operations): Deleted.
1961         (CppStyleTest.test_format_strings): Deleted.
1962         (CppStyleTest.test_insecure_temp_file): Deleted.
1963         (CppStyleTest.test_variable_length_array_detection): Deleted.
1964         (CppStyleTest.test_braces): Deleted.
1965         (CppStyleTest.test_check_check): Deleted.
1966         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1967         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1968         (CppStyleTest.test_spacing_for_fncall): Deleted.
1969         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1970         (CppStyleTest.test_spacing_before_braces): Deleted.
1971         (CppStyleTest.test_spacing_between_braces): Deleted.
1972         (CppStyleTest.test_spacing_before_brackets): Deleted.
1973         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1974         (CppStyleTest.test_objective_c_block): Deleted.
1975         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1976         (CppStyleTest.test_spacing_around_else): Deleted.
1977         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1978         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
1979         (CppStyleTest.test_operator_methods): Deleted.
1980         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
1981         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
1982         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
1983         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
1984         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
1985         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
1986         (CppStyleTest.test_space_after_comment_marker): Deleted.
1987         (CppStyleTest.test_newline_at_eof): Deleted.
1988         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
1989         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
1990         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
1991         (CppStyleTest.test_invalid_utf8): Deleted.
1992         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
1993         (CppStyleTest.test_is_blank_line): Deleted.
1994         (CppStyleTest.test_blank_lines_check): Deleted.
1995         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
1996         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
1997         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
1998         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
1999         (CppStyleTest.test_comma): Deleted.
2000         (CppStyleTest.test_declaration): Deleted.
2001         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
2002         (CppStyleTest.test_indent): Deleted.
2003         (CppStyleTest.test_indent.Foo): Deleted.
2004         (CppStyleTest.test_not_alabel): Deleted.
2005         (CppStyleTest.test_tab): Deleted.
2006         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
2007         (CppStyleTest.test_build_class): Deleted.
2008         (CppStyleTest.test_build_class.definitions): Deleted.
2009         (CppStyleTest.test_build_class.Foo): Deleted.
2010         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
2011         (CppStyleTest.test_build_end_comment): Deleted.
2012         (CppStyleTest.test_build_forward_decl): Deleted.
2013         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
2014         (CppStyleTest.test_build_header_guard): Deleted.
2015         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
2016         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
2017         (CppStyleTest.test_build_printf_format): Deleted.
2018         (CppStyleTest.test_runtime_printf_format): Deleted.
2019         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
2020         (CppStyleTest.test_build_storage_class): Deleted.
2021         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
2022         (CppStyleTest.test_build_storage_class.declaration): Deleted.
2023         (CppStyleTest.test_build_storage_class.after): Deleted.
2024         (CppStyleTest.test_build_storage_class.is): Deleted.
2025         (CppStyleTest.test_legal_copyright): Deleted.
2026         (CppStyleTest.test_invalid_increment): Deleted.
2027         (CppStyleTest.test_enum_bitfields): Deleted.
2028         (CppStyleTest.test_plain_integral_bitfields): Deleted.
2029         (CleansedLinesTest.test_init_empty): Deleted.
2030         (CleansedLinesTest.test_collapse_strings): Deleted.
2031         (OrderOfIncludesTest.tearDown): Deleted.
2032         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
2033         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
2034         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
2035         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
2036         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
2037         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
2038         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
2039         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
2040         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
2041         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
2042         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
2043         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
2044         (OrderOfIncludesTest.test_primary_header): Deleted.
2045         (OrderOfIncludesTest.test_public_primary_header): Deleted.
2046         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
2047         (OrderOfIncludesTest.test_classify_include): Deleted.
2048         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
2049         (CheckForFunctionLengthsTest.tearDown): Deleted.
2050         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
2051         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
2052         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
2053         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
2054         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
2055         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
2056         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
2057         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
2058         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
2059         (CheckForFunctionLengthsTest.function_body): Deleted.
2060         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
2061         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
2062         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
2063         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
2064         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
2065         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
2066         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
2067         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
2068         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
2069         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2070         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2071         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2072         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2073         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2074         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2075         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2076         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2077         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2078         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2079         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2080         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2081         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2082         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2083         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2084         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2085         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2086         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2087         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2088         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2089         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2090         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2091         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2092         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2093         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2094         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2095         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2096         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2097         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2098         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2099         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2100         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2101         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2102         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2103         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2104         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2105         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2106         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2107         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2108         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2109         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2110         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2111         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2112         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2113         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2114         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2115         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2116         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2117         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2118         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2119         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2120         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2121         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2122         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2123         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2124         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2125         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2126         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2127         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2128         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2129         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2130         (LeakyPatternTest.test_get_dc): Deleted.
2131         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2132         (LeakyPatternTest.test_own_get_dc): Deleted.
2133         (LeakyPatternTest.test_create_dc): Deleted.
2134         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2135         (WebKitStyleTest.test_indentation): Deleted.
2136         (WebKitStyleTest.test_indentation.Foo): Deleted.
2137         (WebKitStyleTest.test_indentation.Document): Deleted.
2138         (WebKitStyleTest.test_spacing): Deleted.
2139         (WebKitStyleTest.test_line_breaking): Deleted.
2140         (WebKitStyleTest.test_braces): Deleted.
2141         (WebKitStyleTest.test_braces.MyClass): Deleted.
2142         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2143         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2144         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2145         (WebKitStyleTest.test_null_false_zero): Deleted.
2146         (WebKitStyleTest.test_directive_indentation): Deleted.
2147         (WebKitStyleTest.test_using_std): Deleted.
2148         (WebKitStyleTest.test_using_namespace): Deleted.
2149         (WebKitStyleTest.test_max_macro): Deleted.
2150         (WebKitStyleTest.test_min_macro): Deleted.
2151         (WebKitStyleTest.test_wtf_move): Deleted.
2152         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2153         (WebKitStyleTest.test_names): Deleted.
2154         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2155         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2156         (WebKitStyleTest.test_names.declarations): Deleted.
2157         (WebKitStyleTest.test_names.struct): Deleted.
2158         (WebKitStyleTest.test_names.VectorType): Deleted.
2159         (WebKitStyleTest.test_parameter_names): Deleted.
2160         (WebKitStyleTest.test_comments): Deleted.
2161         (WebKitStyleTest.test_webkit_export_check): Deleted.
2162         (WebKitStyleTest.test_member_initialization_list): Deleted.
2163         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2164         (WebKitStyleTest.test_other): Deleted.
2165         (CppCheckerTest.mock_handle_style_error): Deleted.
2166         (CppCheckerTest._checker): Deleted.
2167         (CppCheckerTest.test_init): Deleted.
2168         (CppCheckerTest.test_eq): Deleted.
2169         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2170         (CppCheckerTest.test_ne): Deleted.
2171         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2172         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2173         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2174         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2175         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2176         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2177
2178 2017-07-05  Saam Barati  <sbarati@apple.com>
2179
2180         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2181         https://bugs.webkit.org/show_bug.cgi?id=174188
2182         <rdar://problem/30581423>
2183
2184         Reviewed by Mark Lam.
2185
2186         * Scripts/run-jsc-stress-tests:
2187
2188 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2189
2190         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2191         https://bugs.webkit.org/show_bug.cgi?id=174150
2192
2193         Reviewed by Mark Lam.
2194
2195         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2196         (TestWebKitAPI::TEST):
2197
2198 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2199
2200         Remove copy of ICU headers from WebKit
2201         https://bugs.webkit.org/show_bug.cgi?id=116407
2202
2203         Reviewed by Alex Christensen.
2204
2205         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2206         * TestWebKitAPI/Configurations/Base.xcconfig:
2207         * WebKitTestRunner/Configurations/Base.xcconfig:
2208
2209 2017-07-05  Chris Dumez  <cdumez@apple.com>
2210
2211         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2212         https://bugs.webkit.org/show_bug.cgi?id=174163
2213         <rdar://problem/33067518>
2214
2215         Reviewed by Alex Christensen.
2216
2217         Add API test coverage.
2218
2219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2220         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
2221         (TEST):
2222
2223 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2224
2225         When dragging a selection, clearing the selection in dragstart should not crash the web process
2226         https://bugs.webkit.org/show_bug.cgi?id=174142
2227         <rdar://problem/33067501>
2228
2229         Reviewed by Tim Horton.
2230
2231         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
2232         drag is starting up.
2233
2234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2235         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
2236         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2237         (TestWebKitAPI::TEST):
2238
2239 2017-07-05  Daniel Bates  <dabates@apple.com>
2240
2241         Do not pass API::FrameInfo for source frame or clear out page of target frame on
2242         API navigation
2243         https://bugs.webkit.org/show_bug.cgi?id=174170
2244         <rdar://problem/33140328>
2245
2246         Reviewed by Brady Eidson.
2247
2248         Update tests as needed for the behavior change.
2249
2250         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2251         (TEST):
2252
2253 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2254
2255         Add WebKitPrivateFrameworkStubs for iOS 11
2256         https://bugs.webkit.org/show_bug.cgi?id=173988
2257
2258         Reviewed by David Kilzer.
2259
2260         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
2261         should use the same directory for private framework stubs.
2262         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2263
2264 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
2265
2266         [MediaStream] Protect request and web view during gUM client callback
2267         https://bugs.webkit.org/show_bug.cgi?id=174096
2268         <rdar://problem/32833102>
2269
2270         Reviewed by Youenn Fablet.
2271
2272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2273         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2274
2275 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2276
2277         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
2278
2279         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2280
2281 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2282
2283         Unreviewed, rolling out r219128.
2284
2285         Spoke with engineer who originally submitted, Patch for APi
2286         test to follow.
2287
2288         Reverted changeset:
2289
2290         "Unreviewed, rolling out r219070."
2291         https://bugs.webkit.org/show_bug.cgi?id=174082
2292         http://trac.webkit.org/changeset/219128
2293
2294 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2295
2296         Unreviewed, rolling out r219070.
2297
2298         This revision caused consistent failures of the API test
2299         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
2300
2301         Reverted changeset:
2302
2303         "Pasting single words copied to UIPasteboard inserts URLs in
2304         editable areas"
2305         https://bugs.webkit.org/show_bug.cgi?id=174082
2306         http://trac.webkit.org/changeset/219070
2307
2308 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2309
2310         Remove unused EFL logo from bot watcher dashboard
2311         https://bugs.webkit.org/show_bug.cgi?id=174136
2312
2313         Reviewed by Alexey Proskuryakov.
2314
2315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
2316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
2317
2318 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2319
2320         [GTK] Add more GTK bots to dashboard
2321         https://bugs.webkit.org/show_bug.cgi?id=174129
2322
2323         Reviewed by Carlos Alberto Lopez Perez.
2324
2325         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
2326         them.
2327
2328         This also changes the sort order to put WPE above GTK so that it's not buried under all the
2329         less-essential GTK bots.
2330
2331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2333         (WebKitBuildbot):
2334
2335 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2336
2337         [WPE] Add WPE to bot watcher dashboard
2338         https://bugs.webkit.org/show_bug.cgi?id=174119
2339
2340         Reviewed by Alexey Proskuryakov.
2341
2342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
2343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
2344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
2345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2346         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2347         (WebKitBuildbot):
2348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2349         (table.queue-grid tr.platform.linux-wpe img.logo):
2350
2351 2017-07-03  Lucas Forschler  <lforschler@apple.com>
2352
2353         https://bugs.webkit.org/show_bug.cgi?id=174105
2354         
2355         Reviewed by Stephanie Lewis.
2356
2357         * BuildSlaveSupport/built-product-archive:
2358         (main): Add a -minify parser option
2359         (createZip): Pass along the optional Minify argument if requested
2360         (minifySource): This will trim down archives, logic limited to Mac platform.
2361
2362 2017-07-03  Matt Rajca  <mrajca@apple.com>
2363
2364         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
2365         https://bugs.webkit.org/show_bug.cgi?id=174103
2366
2367         Reviewed by Alex Christensen.
2368
2369         Added an API test.
2370
2371         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
2372         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2373         (TEST): Added test.
2374         * TestWebKitAPI/cocoa/TestWKWebView.h:
2375         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2376         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
2377
2378 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2379
2380         Unreviewed, rolling out r219103.
2381
2382         Caused multiple build failures.
2383
2384         Reverted changeset:
2385
2386         "Remove copy of ICU headers from WebKit"
2387         https://bugs.webkit.org/show_bug.cgi?id=116407
2388         http://trac.webkit.org/changeset/219103
2389
2390 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2391
2392         Remove copy of ICU headers from WebKit
2393         https://bugs.webkit.org/show_bug.cgi?id=116407
2394
2395         Reviewed by Alex Christensen.
2396
2397         Use WTF's copy of ICU headers.
2398
2399         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2400         * TestWebKitAPI/Configurations/Base.xcconfig:
2401         * WebKitTestRunner/Configurations/Base.xcconfig:
2402
2403 2017-07-03  Brady Eidson  <beidson@apple.com>
2404
2405         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2406         https://bugs.webkit.org/show_bug.cgi?id=174073
2407
2408         Reviewed by Andy Estes.
2409
2410         * DumpRenderTree/mac/TestRunnerMac.mm:
2411         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
2412
2413         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
2414         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2415
2416 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2417
2418         Unreviewed, rolling out r219083.
2419
2420         The revision caused an API failure on all testing platforms.
2421
2422         Reverted changeset:
2423
2424         "[MediaStream] Protect request and web view during gUM client
2425         callback"
2426         https://bugs.webkit.org/show_bug.cgi?id=174096
2427         http://trac.webkit.org/changeset/219083
2428
2429 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
2430
2431         webkitpy: Properly number duplicated crashlogs
2432         https://bugs.webkit.org/show_bug.cgi?id=172002
2433
2434         Reviewed by Aakash Jain.
2435
2436         * Scripts/webkitpy/common/system/crashlogs.py:
2437         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
2438         an increasing integer.
2439         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2440         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
2441         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
2442         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
2443
2444 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
2445
2446         WebContent processes crash when the network process crashes with pending connection requests
2447         https://bugs.webkit.org/show_bug.cgi?id=174065
2448         <rdar://problem/30359835>
2449
2450         Reviewed by Tim Horton.
2451
2452         Add a API to ensure UI process tries to relaunch a new network process when the network process
2453         crashes with pending network connection requests.
2454
2455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2456         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
2457         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2458         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2459         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
2460
2461 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
2462
2463         [MediaStream] Protect request and web view during gUM client callback
2464         https://bugs.webkit.org/show_bug.cgi?id=174096
2465         <rdar://problem/32833102>
2466
2467         Reviewed by Youenn Fablet.
2468
2469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2470         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2471
2472 2017-07-03  Andy Estes  <aestes@apple.com>
2473
2474         [Xcode] Add an experimental setting to build with ccache
2475         https://bugs.webkit.org/show_bug.cgi?id=173875
2476
2477         Reviewed by Tim Horton.
2478
2479         On systems that already have ccache(1) installed, this patch adds experimental support for
2480         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
2481
2482         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
2483         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
2484         find the toolchain from which to run clang, and then invokes ccache with the required
2485         arguments.
2486
2487         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
2488         precompiled headers to work properly [1].
2489
2490         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
2491         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
2492         during linking.
2493         
2494         [1] https://ccache.samba.org/manual.html#_precompiled_headers
2495
2496         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2497         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2498         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2499         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2500         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
2501         * ccache/README.md: Added.
2502         * ccache/ccache-clang: Added.
2503         * ccache/ccache-clang++: Added.
2504         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
2505
2506 2017-07-03  Alex Christensen  <achristensen@webkit.org>
2507
2508         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2509         https://bugs.webkit.org/show_bug.cgi?id=174051
2510
2511         Reviewed by Tim Horton.
2512
2513         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2514         (TestWebKitAPI::TEST_F):
2515
2516 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2517
2518         Unreviewed, rolling out r219024.
2519
2520         This patch cause 3 didferent test to fail.
2521
2522         Reverted changeset:
2523
2524         "REGRESSION(r215096) Queries of URLs with non-special schemes
2525         should not percent-encode single quotes"
2526         https://bugs.webkit.org/show_bug.cgi?id=174051
2527         http://trac.webkit.org/changeset/219024
2528
2529 2017-07-03  Chris Dumez  <cdumez@apple.com>
2530
2531         Drop ResourceLoadStatisticsStore's statisticsLock
2532         https://bugs.webkit.org/show_bug.cgi?id=174080
2533
2534         Reviewed by Brent Fulgham.
2535
2536         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2537
2538         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2539         (WTR::TestController::isStatisticsPrevalentResource):
2540         (WTR::TestController::isStatisticsHasHadUserInteraction):
2541         (WTR::TestController::isStatisticsGrandfathered):
2542
2543 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2544
2545         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2546         https://bugs.webkit.org/show_bug.cgi?id=174082
2547         <rdar://problem/33046992>
2548
2549         Reviewed by Tim Horton.
2550
2551         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2552
2553         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2554         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2555         (TestWebKitAPI::TEST):
2556
2557 2017-07-02  Brady Eidson  <beidson@apple.com>
2558
2559         Add API test for all parts of WebKit1 API related to favicons.
2560         https://bugs.webkit.org/show_bug.cgi?id=174069
2561
2562         Reviewed by Andy Estes.
2563
2564         These two API tests cover all WebKit1 API related to icons.
2565         
2566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2567         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2568         (mainResourceData):
2569         (defaultFaviconData):
2570         (customFaviconData):
2571         (imageFromData):
2572         (+[IconLoadingProtocol canInitWithRequest:]):
2573         (+[IconLoadingProtocol canonicalRequestForRequest:]):
2574         (-[IconLoadingProtocol startLoading]):
2575         (-[IconLoadingProtocol stopLoading]):
2576         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2577         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2578         (TestWebKitAPI::TEST):
2579
2580 2017-07-01  Dan Bernstein  <mitz@apple.com>
2581
2582         [iOS] Remove code only needed when building for iOS 9.x
2583         https://bugs.webkit.org/show_bug.cgi?id=174068
2584
2585         Reviewed by Tim Horton.
2586
2587         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2588         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2589         (WTR::initializeWebViewConfiguration):
2590         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2591         (-[HIDEventGenerator _createIOHIDEventType:]):
2592
2593 2017-07-01  Brady Eidson  <beidson@apple.com>
2594
2595         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2596         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2597
2598         Reviewed by Alex Christensen.
2599
2600         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2601
2602 2017-07-01  Dan Bernstein  <mitz@apple.com>
2603
2604         [macOS] Remove code only needed when building for OS X Yosemite
2605         https://bugs.webkit.org/show_bug.cgi?id=174067
2606
2607         Reviewed by Tim Horton.
2608
2609         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2610         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2611         * DumpRenderTree/mac/DumpRenderTree.mm:
2612         (setDefaultsToConsistentValuesForTesting):
2613         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2614         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2615         * MiniBrowser/Configurations/Base.xcconfig:
2616         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2617         * TestWebKitAPI/Configurations/Base.xcconfig:
2618         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2619         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2620         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2621         (TestWebKitAPI::TEST_F):
2622         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2623         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2624         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2625         (TestWebKitAPI::TEST_F):
2626         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2627         (TestWebKitAPI::TEST):
2628         * WebKitTestRunner/Configurations/Base.xcconfig:
2629         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2630         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2631         (WTR::InjectedBundle::platformInitialize):
2632         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2633         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2634
2635 2017-07-01  Chris Dumez  <cdumez@apple.com>
2636
2637         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
2638         https://bugs.webkit.org/show_bug.cgi?id=174060
2639
2640         Reviewed by Brent Fulgham.
2641
2642         Port WebKitTestRunner over to the new Cocoa SPI.
2643
2644         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2645         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2646         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2647         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
2648         no-ops since this code runs in the WebContent process, not the
2649         UIProcess.
2650
2651         * WebKitTestRunner/TestController.cpp:
2652         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2653
2654 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2655
2656         Unreviewed mac build fix.
2657
2658         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2659         (TestWebKitAPI::TEST):
2660
2661 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2662
2663         Add API to get WKActivatedElementInfo
2664         https://bugs.webkit.org/show_bug.cgi?id=174001
2665         <rdar://problem/29165518>
2666         
2667         Tests for now SPI to get activatedElementInfo.
2668
2669         Reviewed by Tim Horton.
2670
2671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2672         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
2673         (TestWebKitAPI::TEST):
2674
2675 2017-06-30  Chris Dumez  <cdumez@apple.com>
2676
2677         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
2678         https://bugs.webkit.org/show_bug.cgi?id=174038
2679
2680         Reviewed by Brent Fulgham.
2681
2682         Fix typo in API name.
2683
2684         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2685         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2686         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2687         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2688         * WebKitTestRunner/TestController.cpp:
2689         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2690         * WebKitTestRunner/TestController.h:
2691         * WebKitTestRunner/TestInvocation.cpp:
2692         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2693
2694 2017-06-30  Alex Christensen  <achristensen@webkit.org>
2695
2696         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2697         https://bugs.webkit.org/show_bug.cgi?id=174051
2698         <rdar://problem/33002846>
2699
2700         Reviewed by Tim Horton.
2701
2702         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2703         (TestWebKitAPI::TEST_F):
2704
2705 2017-06-30  Daniel Bates  <dabates@apple.com>
2706
2707         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2708         https://bugs.webkit.org/show_bug.cgi?id=165160
2709         <rdar://problem/29451999>
2710
2711         Reviewed by Brady Eidson.
2712
2713         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
2714         for navigations and window creation.
2715
2716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2717         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
2718         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2719         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
2720         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2721         (TEST):
2722
2723 2017-06-29  Jer Noble  <jer.noble@apple.com>
2724
2725         Make Legacy EME API controlled by RuntimeEnabled setting.
2726         https://bugs.webkit.org/show_bug.cgi?id=173994
2727
2728         Reviewed by Sam Weinig.
2729
2730         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2731
2732 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2733
2734         Follow-up fix for r218996
2735
2736         Unreviewed infrastructure fix.
2737
2738         Repeated calls to 'ios_version' make the log noisy, memoize the function.
2739
2740         * Scripts/webkitpy/port/ios_simulator.py:
2741         (IOSSimulatorPort): Memoize ios_version().
2742
2743 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2744
2745         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2746         https://bugs.webkit.org/show_bug.cgi?id=174017
2747         <rdar://problem/32959782>
2748
2749         Reviewed by Simon Fraser.
2750
2751         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
2752         changes, the caret would appear outside of the iframe.
2753
2754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2755         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
2756         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2757         (checkDragCaretRectIsContainedInRect):
2758         (TestWebKitAPI::TEST):
2759         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2760         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2761         (-[DataInteractionSimulator _resetSimulatedState]):
2762         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2763         (-[DataInteractionSimulator _advanceProgress]):
2764         (-[DataInteractionSimulator lastKnownDragCaretRect]):
2765
2766 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2767
2768         Add support for different versions of iOS when loading test expectations
2769         https://bugs.webkit.org/show_bug.cgi?id=173774
2770         <rdar://problem/32951132>
2771
2772         Rubber-stamped by Aakash Jain.
2773
2774         When running layout tests, we should support multiple version of iOS the same way we do Mac.
2775
2776         * Scripts/webkitpy/port/ios.py:
2777         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
2778         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
2779         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
2780         * Scripts/webkitpy/port/ios_device.py:
2781         (IOSDevicePort.ios_version): Ask connected devices for implementation.
2782         * Scripts/webkitpy/port/ios_device_unittest.py:
2783         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
2784         (IOSDeviceTest.test_baseline_searchpath): Ditto.
2785         (IOSDeviceTest.test_expectations_ordering): Ditto.
2786         * Scripts/webkitpy/port/ios_simulator.py:
2787         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
2788         ask the platform.
2789
2790 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
2791
2792         Fontconfig build breaks with glibc 2.15+
2793         https://bugs.webkit.org/show_bug.cgi?id=174019
2794
2795         Reviewed by Carlos Alberto Lopez Perez.
2796
2797         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
2798
2799         * wpe/jhbuild.modules:
2800         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
2801
2802 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2803
2804         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
2805         https://bugs.webkit.org/show_bug.cgi?id=174010
2806         <rdar://problem/32597802>
2807
2808         Reviewed by Tim Horton.
2809
2810         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
2811         snapshot fails for any reason.
2812
2813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2814         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
2815         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2816         (TestWebKitAPI::TEST):
2817
2818 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
2819
2820         AX: Cannot call setValue() on contenteditable or ARIA text controls
2821         https://bugs.webkit.org/show_bug.cgi?id=173520
2822
2823         Reviewed by Ryosuke Niwa.
2824
2825         Add setValue() method to WKTR (already existed in DRT).
2826
2827         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2828         (WTR::AccessibilityUIElement::setValue):
2829         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2830         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2831         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2832         (WTR::AccessibilityUIElement::setValue):
2833
2834 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2835
2836         getBoundingClientRect returns wrong value for combination of page zoom and scroll
2837         https://bugs.webkit.org/show_bug.cgi?id=173841
2838         rdar://problem/32983841
2839
2840         Reviewed by Dean Jackson.
2841
2842         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
2843         always did text zooming.
2844
2845         * MiniBrowser/mac/WK1BrowserWindowController.m:
2846         (-[WK1BrowserWindowController zoomIn:]):
2847         (-[WK1BrowserWindowController zoomOut:]):
2848         (-[WK1BrowserWindowController canResetZoom]):
2849         (-[WK1BrowserWindowController resetZoom:]):
2850
2851 2017-06-29  John Wilander  <wilander@apple.com>
2852
2853         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
2854         https://bugs.webkit.org/show_bug.cgi?id=173940
2855         <rdar://problem/33018125>
2856
2857         Reviewed by Brent Fulgham.
2858
2859         This change allows the TestController to turn off
2860         regular resource load statistics telemetry submission
2861         and to manually control when telemetry is calculated
2862         and submitted.
2863
2864         * WebKitTestRunner/TestController.cpp:
2865         (WTR::TestController::initialize):
2866             Turns off automatic resource load statistics telemetry submission.
2867
2868 2017-06-29  Commit Queue  <commit-queue@webkit.org>
2869
2870         Unreviewed, rolling out r218512.
2871         https://bugs.webkit.org/show_bug.cgi?id=173981
2872
2873         "It changes the behavior of the JS API's JSEvaluateScript
2874         which breaks TurboTax" (Requested by saamyjoon on #webkit).
2875
2876         Reverted changeset:
2877
2878         "test262: Completion values for control flow do not match the
2879         spec"
2880         https://bugs.webkit.org/show_bug.cgi?id=171265
2881         http://trac.webkit.org/changeset/218512
2882
2883 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2884
2885         Add WebKitSystemInterface for iOS 11
2886         https://bugs.webkit.org/show_bug.cgi?id=173936
2887
2888         Reviewed by Lucas Forschler.
2889
2890         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
2891
2892 2017-06-28  Keith Miller  <keith_miller@apple.com>
2893
2894         VMTraps has some races
2895         https://bugs.webkit.org/show_bug.cgi?id=173941
2896
2897         Reviewed by Michael Saboff.
2898
2899         Add new testing mode for testing the Watchdog with our stress
2900         tests.
2901
2902         * Scripts/run-jsc-stress-tests:
2903
2904 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2905
2906         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
2907         https://bugs.webkit.org/show_bug.cgi?id=173877
2908
2909         Reviewed by Brady Eidson.
2910
2911         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
2912         the next tests.
2913
2914         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2915         (testGetFavicon):
2916
2917 2017-06-28  Tim Horton  <timothy_horton@apple.com>
2918
2919         MobileSafari was constantly using 10-15% CPU viewing a PDF
2920         https://bugs.webkit.org/show_bug.cgi?id=173944
2921         <rdar://problem/33039910>
2922
2923         Reviewed by Simon Fraser.
2924
2925         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2926         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2927         Add a test that we ever call the stable presentation update callback
2928         when we have a WKPDFView up, instead of infinitely looping.
2929
2930 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2931
2932         Prevent displaying URLs with small capital letters
2933         https://bugs.webkit.org/show_bug.cgi?id=173949
2934         <rdar://problem/32952058>
2935
2936         Reviewed by Brent Fulgham.
2937
2938         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2939         (TestWebKitAPI::TEST):
2940
2941 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2942
2943         Unreviewed test fix.
2944
2945         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2946
2947         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2948
2949 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2950
2951         Teach ResourceLoadStatistics to recognize changes in the file system
2952         https://bugs.webkit.org/show_bug.cgi?id=173800
2953         <rdar://problem/32937842>
2954
2955         Reviewed by Chris Dumez.
2956
2957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2958         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2959         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2960         (TestWebKitAPI::handleFileModification):
2961         (TestWebKitAPI::handleFileDeletion):
2962         (TestWebKitAPI::resetTestState):
2963         (TestWebKitAPI::TEST_F):
2964
2965 2017-06-28  Brady Eidson  <beidson@apple.com>
2966
2967         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2968         https://bugs.webkit.org/show_bug.cgi?id=173874
2969
2970         Reviewed by Alex Christensen.
2971
2972         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2973
2974 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2975
2976         Unreviewed, adding Don Olmstead to contributors.json
2977
2978         * Scripts/webkitpy/common/config/contributors.json:
2979
2980 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2981
2982         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
2983         https://bugs.webkit.org/show_bug.cgi?id=173886
2984         <rdar://problem/32543191>
2985
2986         Reviewed by Andy Estes.
2987
2988         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2989         (ParsedRange::ParsedRange):
2990         (-[TestSchemeHandler initWithVideoData:]):
2991         (-[TestSchemeHandler webView:startURLSchemeTask:]):
2992         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
2993         (TEST):
2994
2995 2017-06-27  JF Bastien  <jfbastien@apple.com>
2996
2997         WebAssembly: running out of executable memory should throw OoM
2998         https://bugs.webkit.org/show_bug.cgi?id=171537
2999         <rdar://problem/32963338>
3000
3001         Reviewed by Saam Barati.
3002
3003         * Scripts/run-jsc-stress-tests: add a configuration which runs the
3004         tests under limited executable memory and avoids non-WebAssembly
3005         code generation so that we more reliably run out of executable
3006         memory in WebAssembly.
3007
3008 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3009
3010         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
3011         https://bugs.webkit.org/show_bug.cgi?id=173854
3012         <rdar://problem/32236827>
3013
3014         Reviewed by Ryosuke Niwa and Tim Horton.
3015
3016         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
3017
3018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3019         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
3020         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3021         (TestWebKitAPI::TEST):
3022
3023 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
3024
3025         [PAL] Add symbol export macros for PAL
3026         https://bugs.webkit.org/show_bug.cgi?id=171519
3027
3028         Reviewed by Konstantin Tokarev.
3029
3030         * DumpRenderTree/config.h:
3031         * TestWebKitAPI/CMakeLists.txt:
3032         * TestWebKitAPI/config.h:
3033         * WebKitTestRunner/config.h:
3034
3035 2017-06-27  John Wilander  <wilander@apple.com>
3036
3037         Resource Load Statistics: Add telemetry
3038         https://bugs.webkit.org/show_bug.cgi?id=173499
3039         <rdar://problem/32826094>
3040
3041         Reviewed by Brent Fulgham.
3042
3043         Adds three new testRunner functions:
3044         - installStatisticsDidRunTelemetryCallback()
3045         - statisticsFireTelemetryHandler()
3046         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
3047
3048         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3049         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3050         (WTR::InjectedBundle::didReceiveMessageToPage):
3051         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3052         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
3053         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
3054         (WTR::TestRunner::statisticsFireTelemetryHandler):
3055         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3056         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3057         * WebKitTestRunner/TestController.cpp:
3058         (WTR::TestController::resetStateToConsistentValues):
3059         (WTR::TestController::statisticsFireTelemetryHandler):
3060         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3061         * WebKitTestRunner/TestController.h:
3062         * WebKitTestRunner/TestInvocation.cpp:
3063         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3064
3065 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
3066
3067         Add missing includes to fix compilation error on FreeBSD
3068         https://bugs.webkit.org/show_bug.cgi?id=172919
3069
3070         Reviewed by Mark Lam.
3071
3072         * ImageDiff/cairo/PlatformImageCairo.cpp:
3073
3074 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
3075
3076         Unreviewed, rolling out r218783.
3077
3078         Causing accessibility/mac/setting-attributes-is-
3079         asynchronous.html to crash consistently on mac-wk2 Debug
3080
3081         Reverted changeset:
3082
3083         "AX: Cannot call setValue() on contenteditable or ARIA text
3084         controls"
3085         https://bugs.webkit.org/show_bug.cgi?id=173520
3086         http://trac.webkit.org/changeset/218783
3087
3088 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3089
3090         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
3091         https://bugs.webkit.org/show_bug.cgi?id=173825
3092
3093         Reviewed by Saam Barati.
3094
3095         * DumpRenderTree/JavaScriptThreading.cpp:
3096         (runJavaScriptThread):
3097         (startJavaScriptThreads):
3098         * DumpRenderTree/mac/DumpRenderTree.mm:
3099         (runThread):
3100         (runPthread):
3101         (testThreadIdentifierMap):
3102
3103 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3104
3105         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
3106         <https://webkit.org/b/173837>
3107
3108         Reviewed by Geoffrey Garen.
3109
3110         The clang static analyzer can't reason about objects that are
3111         assigned to a delegate as +1 retained, and then released
3112         later in a different method when the delegate is cleared.
3113
3114         Instead, use a common idiom where the object setting the
3115         delegate retains it as an instance variable on initialization.
3116         Then the same object clears the delegate and releases its
3117         instance variable during teardown.
3118
3119         Also add EXPECT_TRUE() tests to make sure the delegate objects
3120         match before teardown.
3121
3122         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3123         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3124         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
3125         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3126         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
3127         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
3128
3129 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3130
3131         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
3132         <https://webkit.org/b/173836>
3133
3134         Reviewed by Brady Eidson.
3135
3136         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3137         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
3138         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
3139         objects in this test.
3140
3141 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
3142
3143         [ATK] Add support for aria-details and aria-errormessage
3144         https://bugs.webkit.org/show_bug.cgi?id=172588
3145
3146         Reviewed by Chris Fleizach.
3147
3148         Add additional methods to test ARIA properties which are exposed via
3149         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
3150         to versions which support the details and error-message relation types.
3151
3152         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3153         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3154         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3155         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3156         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3157         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3158         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3159         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3160         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3161         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3162         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3163         * gtk/jhbuild.modules:
3164
3165 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3166
3167         Unreviewed. Add libfii to GTK+ install dependencies script.
3168
3169         * gtk/install-dependencies:
3170
3171 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3172
3173         Unreviewed, rolling out r215190.
3174
3175         Broke product select element on GNOME Bugzilla
3176
3177         Reverted changeset:
3178
3179         "[GTK] Misplaced right click menu on web page due to
3180         deprecated gtk_menu_popup()"
3181         https://bugs.webkit.org/show_bug.cgi?id=170553
3182         http://trac.webkit.org/changeset/215190
3183
3184 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
3185
3186         Remove Reflect.enumerate
3187         https://bugs.webkit.org/show_bug.cgi?id=173806
3188
3189         Reviewed by Yusuke Suzuki.
3190
3191         * Scripts/run-jsc-stress-tests:
3192
3193 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
3194
3195         AX: Cannot call setValue() on contenteditable or ARIA text controls
3196         https://bugs.webkit.org/show_bug.cgi?id=173520
3197
3198         Reviewed by Ryosuke Niwa.
3199
3200         Add setValue() method to WKTR (already existed in DRT).
3201
3202         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3203         (WTR::AccessibilityUIElement::setValue):
3204         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3205         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3206         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3207         (WTR::AccessibilityUIElement::setValue):
3208
3209 2017-06-23  Keith Miller  <keith_miller@apple.com>
3210
3211         Switch VMTraps to use halt instructions rather than breakpoint instructions
3212         https://bugs.webkit.org/show_bug.cgi?id=173677
3213
3214         Reviewed by JF Bastien.
3215
3216         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3217         (TEST):
3218
3219 2017-06-23  Youenn Fablet  <youenn@apple.com>
3220
3221         Set getUserMedia permission to true by default on WTR
3222         https://bugs.webkit.org/show_bug.cgi?id=173610
3223
3224         Reviewed by Alex Christensen.
3225
3226         Adding a way to reset the getUserMedia permission to pending.
3227
3228         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3229         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3230         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
3231         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3232         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3233         (WTR::TestRunner::setUserMediaPermissionAsUnset):
3234         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3235         * WebKitTestRunner/TestController.cpp:
3236         (WTR::TestController::resetStateToConsistentValues):
3237         (WTR::TestController::setUserMediaPermissionAsUnset):
3238         * WebKitTestRunner/TestController.h:
3239         * WebKitTestRunner/TestInvocation.cpp:
3240         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3241
3242 2017-06-23  Alex Christensen  <achristensen@webkit.org>
3243
3244         Add SPI to WKURLSchemeTask for redirection
3245         https://bugs.webkit.org/show_bug.cgi?id=173730
3246
3247         Reviewed by Brady Eidson.
3248
3249         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3250         (-[SchemeHandler webView:startURLSchemeTask:]):
3251         (-[SchemeHandler webView:stopURLSchemeTask:]):
3252         (TEST):
3253         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
3254         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
3255         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
3256         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
3257         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
3258
3259 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3260
3261         [WPE] Use JSC API to send script messages from web extension in tests
3262         https://bugs.webkit.org/show_bug.cgi?id=173757
3263
3264         Reviewed by Žan Doberšek.
3265
3266         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
3267         to run postMessage().
3268
3269         Fixes: /wpe/WebKitSecurityManager/file-xhr
3270                /wpe/WebKitConsoleMessage/console-api
3271                /wpe/WebKitConsoleMessage/js-exception
3272                /wpe/WebKitConsoleMessage/network-error
3273                /wpe/WebKitConsoleMessage/security-error
3274
3275         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3276         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
3277         (beforeAll): Ditto.
3278         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3279         (testWebContextSecurityFileXHR): Ditto.
3280         (beforeAll): Ditto.
3281         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3282         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
3283         (pageCreatedCallback): Remove ifdefs.
3284
3285 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3286
3287         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
3288
3289         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
3290         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
3291         doesn't exist yet in WPE.
3292
3293         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3294         (testWebViewJavaScriptDialogs):
3295         (testWebViewWindowProperties):
3296
3297 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3298
3299         [GTK] Upgrade pixman and cairo in jhbuild
3300         https://bugs.webkit.org/show_bug.cgi?id=173710
3301
3302         Reviewed by Carlos Alberto Lopez Perez.
3303
3304         * gtk/jhbuild.modules:
3305
3306 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3307
3308         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
3309         https://bugs.webkit.org/show_bug.cgi?id=173711
3310
3311         Reviewed by Carlos Alberto Lopez Perez.
3312
3313         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
3314         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
3315
3316         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3317         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
3318
3319 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3320
3321         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
3322         <https://webkit.org/b/173721>
3323
3324         Reviewed by Joseph Pecoraro.
3325
3326         Use RetainPtr<> to create NSMutableDictionary and NSNumber
3327         objects to fix leaks and to avoid the autoreleasepool.
3328
3329         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
3330         (TEST):
3331
3332 2017-06-22  Matt Lewis  <jlewis3@apple.com>
3333
3334         Unreviewed, rolling out r218633.
3335
3336         The test is failing frequently on Sierra Debug and Windows
3337
3338         Reverted changeset:
3339
3340         "AX: Cannot call setValue() on contenteditable or ARIA text
3341         controls"
3342         https://bugs.webkit.org/show_bug.cgi?id=173520
3343         http://trac.webkit.org/changeset/218633
3344
3345 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3346
3347         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
3348         <https://webkit.org/b/173690>
3349
3350         Reviewed by Chris Dumez.
3351
3352         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
3353         ownership of malloc()-ed memory, then frees it when it's
3354         released.  These tests were passing global variables into the
3355         method, which is not malloc()-ed memory, which violates the API
3356         contract.
3357
3358         The fix is to switch to use
3359         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
3360         NO for the last argument.
3361
3362         Caught by the clang static analyzer.
3363
3364         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3365         (TEST):
3366         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3367         (TEST):
3368
3369 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3370
3371         [GTK] Upgrade Harfbuzz to version 1.4.2
3372         https://bugs.webkit.org/show_bug.cgi?id=173592
3373
3374         Reviewed by Carlos Alberto Lopez Perez.
3375
3376         * gtk/jhbuild.modules:
3377
3378 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3379
3380         [WPE] Update WPEBackend-mesa
3381         https://bugs.webkit.org/show_bug.cgi?id=173705
3382
3383         Reviewed by Carlos Alberto Lopez Perez.
3384
3385         A crash has been fixed, needed for unit tests to work.
3386
3387         * wpe/jhbuild.modules:
3388
3389 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3390
3391         Remove unused coordinated graphics C API
3392         https://bugs.webkit.org/show_bug.cgi?id=173706
3393
3394         Reviewed by Žan Doberšek.
3395
3396         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
3397         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
3398         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
3399         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
3400         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
3401         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
3402
3403 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3404
3405         [WPE] Build glib API tests
3406         https://bugs.webkit.org/show_bug.cgi?id=173702
3407
3408         Reviewed by Žan Doberšek.
3409
3410         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
3411         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
3412         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
3413         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
3414         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
3415         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
3416         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
3417         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
3418         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
3419         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
3420         and implement the missing features.
3421
3422         * CMakeLists.txt:
3423         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
3424         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3425         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3426         (testAutomationSessionRequestSession):
3427         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3428         (testWebKitWebViewSessionState):
3429         (testWebKitWebViewSessionStateWithFormData):
3430         (testWebKitWebViewNavigationAfterSessionRestore):
3431         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3432         (beforeAll):
3433         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3434         (testCookieManagerEphemeral):
3435         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3436         (testBlobDownload):
3437         (beforeAll):
3438         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3439         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3440         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3441         (testProcessPerWebView):
3442         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3443         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3444         (testWebViewCreateNavigationData):
3445         (testWebViewJavaScriptDialogs):
3446         (testWebViewWindowProperties):
3447         (testWebViewMouseTarget):
3448         (testWebViewGeolocationPermissionRequests):
3449         (testWebViewUserMediaPermissionRequests):
3450         (testWebViewAudioOnlyUserMediaPermissionRequests):
3451         (testWebViewFileChooserRequest):
3452         (beforeAll):
3453         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3454         (beforeAll):
3455         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3456         (testPrivateBrowsing):
3457         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3458         (testFindControllerHide):
3459         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3460         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3461         (testWebKitSettings):
3462         (beforeAll):
3463         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3464         (testWebViewNewWithUserContentManager):
3465         (beforeAll):
3466         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3467         (testWebContextEphemeral):
3468         (testWebContextProxySettings):
3469         (beforeAll):
3470         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3471         (testWebViewWebContext):
3472         (testWebViewWebContextLifetime):
3473         (testWebViewEphemeral):
3474         (testWebViewSettings):
3475         (testWebViewCanShowMIMEType):
3476         (testWebViewPageVisibility):
3477         (testWebViewIsPlayingAudio):
3478         (beforeAll):
3479         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3480         (testWebsiteDataEphemeral):
3481         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3482         (documentLoadedCallback):
3483         (pageCreatedCallback):
3484         (methodCallCallback):
3485         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
3486         * TestWebKitAPI/glib/CMakeLists.txt:
3487         * TestWebKitAPI/glib/PlatformGTK.cmake:
3488         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3489         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3490         (main):
3491         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3492         (Test::adoptView):
3493         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3494         (WebKitTestBus::run):
3495         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3496         (WebViewTest::~WebViewTest):
3497         (WebViewTest::initializeWebView):
3498         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3499         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
3500         (WebViewTest::platformDestroy):
3501         (WebViewTest::platformInitializeWebView):
3502         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3503         (WebViewTest::resizeView):
3504         (WebViewTest::hideView):
3505         (parentWindowMapped):
3506         (WebViewTest::showInWindow):
3507         (WebViewTest::showInWindowAndWaitUntilMapped):
3508         (WebViewTest::mouseMoveTo):
3509         (WebViewTest::clickMouseButton):
3510         (WebViewTest::emitPopupMenuSignal):
3511         (WebViewTest::keyStroke):
3512         (WebViewTest::doMouseButtonEvent):
3513         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
3514         (WebViewTest::platformDestroy):
3515         (WebViewTest::platformInitializeWebView):
3516         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3517         (WebViewTest::resizeView):
3518         (WebViewTest::hideView):
3519         (WebViewTest::mouseMoveTo):
3520         (WebViewTest::clickMouseButton):
3521         (WebViewTest::keyStroke):
3522
3523 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3524
3525         [GTK] Move WebKit2 GLib API tests to glib directories
3526         https://bugs.webkit.org/show_bug.cgi?id=173642
3527
3528         Reviewed by Žan Doberšek.
3529
3530         * CMakeLists.txt:
3531         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
3532         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
3533         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
3534         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
3535         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
3536         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
3537         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
3538         (testWebKitConsoleMessageNetworkError):
3539         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
3540         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
3541         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
3542         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
3543         (testLoadFromGResource):
3544         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
3545         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
3546         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
3547         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
3548         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
3549         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
3550         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
3551         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
3552         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
3553         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
3554         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
3555         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
3556         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
3557         (testWebViewRunJavaScript):
3558         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
3559         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
3560         (registerGResource):
3561         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
3562         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
3563         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
3564         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
3565         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
3566         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
3567         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
3568         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
3569         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
3570         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
3571         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
3572         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
3573         * TestWebKitAPI/glib/CMakeLists.txt: Added.
3574         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
3575         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
3576         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
3577         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
3578         (registerGResource):
3579         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
3580         (Test::getResourcesDir):
3581         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
3582         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
3583         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
3584         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
3585         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
3586         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
3587
3588 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3589
3590         [WPE] Add initial web extensions API
3591         https://bugs.webkit.org/show_bug.cgi?id=173640
3592
3593         Reviewed by Žan Doberšek.
3594
3595         Add style checker exceptions for WPE web extensions API files.
3596
3597         * Scripts/webkitpy/style/checker.py:
3598
3599 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3600
3601         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
3602         https://bugs.webkit.org/show_bug.cgi?id=173659
3603         <rdar://problem/32879788>
3604
3605         Reviewed by Tim Horton.
3606
3607         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
3608
3609         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
3610
3611         Augment this test page to log dragend and dragstart events on the drag source as well.
3612
3613         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3614         (checkStringArraysAreEqual):
3615         (TestWebKitAPI::TEST):
3616
3617 2017-06-21  Antoine Quint  <graouts@apple.com>
3618
3619         Ensure DRT always logs rAF suspension debugging code
3620         https://bugs.webkit.org/show_bug.cgi?id=173681
3621
3622         Reviewed by Tim "Mr. T" Horton.
3623
3624         * DumpRenderTree/mac/DumpRenderTree.mm:
3625         (resetWebPreferencesToConsistentValues):
3626
3627 2017-06-21  Chris Dumez  <cdumez@apple.com>
3628
3629         Allow constructing a WTF:Function from a function pointer
3630         https://bugs.webkit.org/show_bug.cgi?id=173660
3631
3632         Reviewed by Alex Christensen.
3633
3634         Add API test coverage.
3635
3636         * TestWebKitAPI/Tests/WTF/Function.cpp:
3637         (TestWebKitAPI::returnThree):
3638         (TestWebKitAPI::returnFour):
3639         (TestWebKitAPI::returnPassedValue):
3640         (TestWebKitAPI::TEST):
3641
3642 2017-06-21  Antoine Quint  <graouts@apple.com>
3643
3644         Add logging to identify when the Page suspends scripted animations
3645         https://bugs.webkit.org/show_bug.cgi?id=173626
3646
3647         Reviewed by Tim Horton.
3648
3649         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
3650
3651         * DumpRenderTree/mac/DumpRenderTree.mm:
3652         (resetWebPreferencesToConsistentValues):
3653
3654 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
3655
3656         AX: Cannot call setValue() on contenteditable or ARIA text controls
3657         https://bugs.webkit.org/show_bug.cgi?id=173520
3658
3659         Reviewed by Ryosuke Niwa.
3660
3661         Add setValue() method to WKTR (already existed in DRT).
3662
3663         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3664         (WTR::AccessibilityUIElement::setValue):
3665         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3666         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3667         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3668         (WTR::AccessibilityUIElement::setValue):
3669
3670 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
3671
3672         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
3673         as one of the dependencies required to build the product.
3674
3675         Rubber-stamped by Carlos Garcia Campos.
3676
3677         * gtk/install-dependencies:
3678         * wpe/install-dependencies:
3679
3680 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3681
3682         Disable font variations on macOS Sierra and iOS 10
3683         https://bugs.webkit.org/show_bug.cgi?id=173618
3684         <rdar://problem/32879164>
3685
3686         Reviewed by Jon Lee.
3687
3688         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3689
3690 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3691
3692         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
3693         https://bugs.webkit.org/show_bug.cgi?id=173578
3694         <rdar://problem/32825028>
3695
3696         Reviewed by Tim Horton.
3697
3698         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
3699         a custom popover does not cause dragging to fail when the popover is presented.
3700
3701         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3702         (-[DataInteractionSimulator _advanceProgress]):
3703
3704 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3705
3706         [WPE] Add initial implementation of glib API
3707         https://bugs.webkit.org/show_bug.cgi?id=173546
3708
3709         Reviewed by Žan Doberšek.
3710
3711         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
3712         include WPE glib API files.
3713
3714         * Scripts/webkitperl/FeatureList.pm:
3715         * Scripts/webkitpy/style/checker.py:
3716         * Scripts/webkitpy/style/checkers/cpp.py:
3717         (check_identifier_name_in_declaration):
3718
3719 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3720
3721         [GTK] Upgrade to ICU to version 57.1
3722         https://bugs.webkit.org/show_bug.cgi?id=173538
3723
3724         Reviewed by Žan Doberšek.
3725
3726         * gtk/jhbuild.modules:
3727
3728 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3729
3730         [GTK] Remove unneeded modules from the jhbuild
3731         https://bugs.webkit.org/show_bug.cgi?id=170540
3732
3733         Reviewed by Michael Catanzaro.
3734
3735         We are building libxslt and libffi that we don't really need to build from sources.
3736
3737         * gtk/jhbuild.modules:
3738
3739 2017-06-19  Frederic Wang  <fwang@igalia.com>
3740
3741         [Mac] Add an experimental feature setting for async frame scrolling
3742         https://bugs.webkit.org/show_bug.cgi?id=173359
3743
3744         Reviewed by Simon Fraser.
3745
3746         * DumpRenderTree/mac/DumpRenderTree.mm:
3747         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
3748         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
3749         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3750         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
3751
3752 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
3753
3754         Unreviewed, adding myself to contributors.json
3755
3756         * Scripts/webkitpy/common/config/contributors.json:
3757
3758 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
3759
3760         test262: Completion values for control flow do not match the spec
3761         https://bugs.webkit.org/show_bug.cgi?id=171265
3762
3763         Reviewed by Saam Barati.
3764
3765         * Scripts/run-jsc-stress-tests:
3766         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
3767
3768 2017-06-19  Zalan Bujtas  <zalan@apple.com>
3769
3770         Opening certain mails brings up a mail that grows indefinitely.
3771         https://bugs.webkit.org/show_bug.cgi?id=173562
3772         <rdar://problem/32766579>
3773
3774         Reviewed by Tim Horton.
3775
3776         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3777         (TEST):
3778
3779 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3780
3781         [iOS DnD] Support .zip archives for file uploads via drag and drop
3782         https://bugs.webkit.org/show_bug.cgi?id=173511
3783         <rdar://problem/32521025>
3784
3785         Reviewed by Tim Horton.
3786
3787         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
3788         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
3789
3790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3791         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
3792         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3793         (testZIPArchive):
3794         (TestWebKitAPI::TEST):
3795
3796 2017-06-18  Darin Adler  <darin@apple.com>
3797
3798         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
3799         https://bugs.webkit.org/show_bug.cgi?id=173526
3800
3801         Reviewed by Sam Weinig.
3802
3803         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
3804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3805
3806         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
3807         tests for assignment before destruction ones.
3808
3809         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
3810         as a function, so it can be used in WTF::Function tests.
3811
3812         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
3813         Added tests for swap and for assignment before deref.
3814
3815         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
3816         to inline everything. Also removed the unnecessary clearing of the log every time
3817         the DerivedRefLogger constructor is called.
3818         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
3819
3820         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
3821         Added tests for assignment before deref and similar for releaseNonNull.
3822
3823 2017-06-19  Sam Weinig  <sam@webkit.org>
3824
3825         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
3826         https://bugs.webkit.org/show_bug.cgi?id=173513
3827
3828         Reviewed by Alex Christensen.
3829
3830         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3831         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3832         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
3833
3834 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
3835
3836         [Win] fast/dom/assign-to-window-status.html is flaky.
3837         https://bugs.webkit.org/show_bug.cgi?id=173512
3838
3839         Reviewed by Alex Christensen.
3840
3841         We should not dump status callbacks when test is done.
3842
3843         * DumpRenderTree/win/UIDelegate.cpp:
3844         (UIDelegate::setStatusText):
3845
3846 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3847
3848         [WPE][JHBuild] Update WPEBackend-mesa
3849         https://bugs.webkit.org/show_bug.cgi?id=173433
3850
3851         Unreviewed.
3852
3853         Update WPEBackend-mesa back (like it was done originally in r218344)
3854         after fixing the issue with the DISPLAY environment variables that
3855         caused the crashes.
3856
3857         * wpe/jhbuild.modules:
3858
3859 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3860
3861         Rename unit test file after r218482
3862         https://bugs.webkit.org/show_bug.cgi?id=173483
3863
3864         Unreviewed.
3865
3866         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
3867
3868 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3869
3870         Unreviewed. Fix wrong style checker condition added in r218487.
3871
3872         * Scripts/webkitpy/style/checkers/cpp.py:
3873         (check_identifier_name_in_declaration):
3874
3875 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
3876
3877         Missing <functional> includes make builds fail with GCC 7.x
3878         https://bugs.webkit.org/show_bug.cgi?id=173544
3879
3880         Unreviewed gardening.
3881
3882         Fix compilation with GCC 7.
3883
3884         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3885         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3886
3887 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3888
3889         [GTK] Move GTK+ API files that could be shared to glib dirs
3890         https://bugs.webkit.org/show_bug.cgi?id=173545
3891
3892         Reviewed by Žan Doberšek.
3893
3894         Update paths of GTK+ API in watchlist and style checker.
3895
3896         * Scripts/webkitpy/common/config/watchlist:
3897         * Scripts/webkitpy/style/checker.py:
3898         * Scripts/webkitpy/style/checkers/cpp.py:
3899         (check_identifier_name_in_declaration):
3900
3901 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3902
3903         Port setup_environ_for_server should not set environment variables related with the driver.
3904         https://bugs.webkit.org/show_bug.cgi?id=173483
3905
3906         Reviewed by Carlos Garcia Campos.
3907
3908         The port setup_environ_for_server() should not set environment variables
3909         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
3910         This varibles should be only set on the driver setup_environ_for_test().
3911
3912         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
3913         into the test environment even when running the tests with a driver
3914         that is not the Xorg or Xvfb one.
3915
3916         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
3917         (Port.to.setup_environ_for_server):
3918         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
3919         (Driver._setup_environ_for_driver):
3920         * Scripts/webkitpy/port/driver_unittest.py:
3921         (DriverTest.test_setup_environ_for_test):
3922         (DriverTest):
3923         (DriverTest.test_setup_environ_base_vars):
3924         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
3925         (GtkPort.setup_environ_for_server):
3926         * Scripts/webkitpy/port/wayland_unittest.py: Added.
3927         (WaylandDriverTest):
3928         (WaylandDriverTest.make_driver):
3929         (WaylandDriverTest.make_environment):
3930         (WaylandDriverTest.test_checkdriver):
3931         (WaylandDriverTest.test_environment_needed_variables):
3932         (WaylandDriverTest.test_environment_forbidden_variables):
3933         (WaylandDriverTest.test_environment_optional_variables):
3934         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
3935         (WaylandDriver.check_driver):
3936         (WaylandDriver._setup_environ_for_test):
3937         * Scripts/webkitpy/port/xorgdriver.py:
3938         (XorgDriver.check_driver):
3939         (XorgDriver._setup_environ_for_test):
3940         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
3941         (XorgDriverTest):
3942         (XorgDriverTest.make_driver):
3943         (XorgDriverTest.make_environment):
3944         (XorgDriverTest.test_checkdriver):
3945         (XorgDriverTest.test_environment_needed_variables):
3946         (XorgDriverTest.test_environment_forbidden_variables):
3947         (XorgDriverTest.test_environment_optional_variables):
3948         * Scripts/webkitpy/port/xvfbdriver.py:
3949         (XvfbDriver._setup_environ_for_test):
3950         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3951         (XvfbDriverTest.assertDriverStartSuccessful):
3952
3953
3954 2017-05-14 Frederic Wang  <fwang@igalia.com>
3955
3956         Add heuristic to avoid flattening "fullscreen" iframes
3957         https://bugs.webkit.org/show_bug.cgi?id=171914
3958
3959         Reviewed by Simon Fraser.
3960
3961         * DumpRenderTree/mac/DumpRenderTree.mm:
3962         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
3963
3964 2017-06-18  Chris Dumez  <cdumez@apple.com>
3965
3966         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
3967         https://bugs.webkit.org/show_bug.cgi?id=173522
3968         <rdar://problem/31185739>
3969
3970         Reviewed by Darin Adler.
3971
3972         Add API test for re-entering Function's assignment operators.
3973
3974         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3975         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
3976         (TestWebKitAPI::TestObject::TestObject):
3977         (TestWebKitAPI::TestObject::~TestObject):
3978         (TestWebKitAPI::TestObject::operator()):
3979         (TestWebKitAPI::TEST):
3980
3981 2017-06-16  Dan Bernstein  <mitz@apple.com>
3982
3983         [Cocoa] Some declarations have missing or incorrect availability attributes
3984         https://bugs.webkit.org/show_bug.cgi?id=173508
3985
3986         Reviewed by Tim Horton.
3987
3988         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3989         (TestWebKitAPI::TEST): Updated for renames.
3990
3991 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3992
3993         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3994         https://bugs.webkit.org/show_bug.cgi?id=173366
3995         <rdar://problem/32767014>
3996
3997         Reviewed by Tim Horton.
3998
3999         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
4000         change in behavior.
4001
4002         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4004         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
4005         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
4006         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
4007         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
4008         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
4009         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
4010         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
4011         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
4012         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
4013         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
4014         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
4015         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
4016         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
4017         (-[MockDragDropSession initWithItems:location:window:]):
4018         (-[MockDragDropSession allowsMoveOperation]):
4019         (-[MockDragDropSession isRestrictedToDraggingApplication]):
4020         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
4021         (-[MockDragDropSession canLoadObjectsOfClass:]):
4022         (-[MockDragDropSession canLoadObjectsOfClasses:]):
4023         (-[MockDragDropSession items]):
4024         (-[MockDragDropSession setItems:]):
4025         (-[MockDragDropSession locationInView:]):
4026         (-[MockDataOperationSession initWithProviders:location:window:]):
4027         (-[MockDataOperationSession session]):
4028         (-[MockDataOperationSession isLocal]):
4029         (-[MockDataOperationSession progress]):
4030         (-[MockDataOperationSession setProgressIndicatorStyle:]):
4031         (-[MockDataOperationSession progressIndicatorStyle]):
4032         (-[MockDataOperationSession operationMask]):
4033         (-[MockDataOperationSession localDragSession]):
4034         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
4035         (-[MockDataOperationSession canCreateItemsOfClass:]):
4036         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
4037         (-[MockDataInteractionSession initWithWindow:]):
4038         (-[MockDataInteractionSession localOperationMask]):
4039         (-[MockDataInteractionSession externalOperationMask]):
4040         (-[MockDataInteractionSession session]):
4041         (-[DataInteractionSimulator _advanceProgress]):
4042
4043 2017-06-16  Alex Christensen  <achristensen@webkit.org>
4044
4045         Show punycode to user if a URL has dotless i or j followed by diacritic dot
4046         https://bugs.webkit.org/show_bug.cgi?id=173431
4047
4048         Reviewed by Darin Adler.
4049
4050         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
4051         (TestWebKitAPI::TEST):
4052
4053 2017-06-16  Chris Dumez  <cdumez@apple.com>
4054
4055         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
4056         https://bugs.webkit.org/show_bug.cgi?id=173472
4057         <rdar://problem/28858817>
4058
4059         Reviewed by Brady Eidson.
4060
4061         Add API test coverage.
4062
4063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4064         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
4065         (TEST):
4066
4067 2017-06-16  Brady Eidson  <beidson@apple.com>
4068
4069         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
4070         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
4071
4072         Reviewed by Daniel Bates.
4073
4074         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
4075
4076 2017-06-16  Chris Dumez  <cdumez@apple.com>
4077
4078         DRT fails to reset page visibility between tests
4079         https://bugs.webkit.org/show_bug.cgi?id=173485
4080
4081         Reviewed by Alexey Proskuryakov.
4082
4083         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
4084         Fix this to address flakiness.
4085
4086         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
4087         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
4088         The test became flaky without the DRT change and was no longer flaky with the DRT
4089         change.
4090
4091         WebKitTestRunner already does this.
4092
4093         * DumpRenderTree/mac/DumpRenderTree.mm:
4094         (resetWebViewToConsistentStateBeforeTesting):
4095
4096 2017-06-16  Alex Christensen  <achristensen@webkit.org>
4097
4098         Implement basic authentication in MiniBrowser
4099         https://bugs.webkit.org/show_bug.cgi?id=173443
4100
4101         Reviewed by Tim Horton.
4102
4103         * MiniBrowser/mac/WK2BrowserWindowController.m:
4104         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
4105
4106 2017-06-16  Jer Noble  <jer.noble@apple.com>
4107
4108         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
4109         https://bugs.webkit.org/show_bug.cgi?id=173398
4110         <rdar://problem/32592961>
4111
4112         Reviewed by Eric Carlson.
4113
4114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4115         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
4116         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4117         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4118         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
4119         (TestWebKitAPI::TEST):
4120         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
4121
4122 2017-06-16  Matt Lewis  <jlewis3@apple.com>
4123
4124         Unreviewed, rolling out r218375.
4125
4126         The API test MediaStreamTrackDetached is still timing out
4127         after the patch
4128
4129         Reverted changeset:
4130
4131         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
4132         reports no recording to WebKit clients"
4133         https://bugs.webkit.org/show_bug.cgi?id=173398
4134         http://trac.webkit.org/changeset/218375
4135
4136 2017-06-15  Jer Noble  <jer.noble@apple.com>
4137
4138         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
4139         https://bugs.webkit.org/show_bug.cgi?id=173398
4140         <rdar://problem/32592961>
4141
4142         Reviewed by Eric Carlson.
4143
4144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4145         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
4146         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4147         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4148         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
4149         (TestWebKitAPI::TEST):
4150         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
4151
4152 2017-06-15  Matt Lewis  <jlewis3@apple.com>
4153
4154         Unreviewed, rolling out r218365.
4155
4156         The revision caused API timeouts on all builds.
4157
4158         Reverted changeset:
4159
4160         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
4161         reports no recording to WebKit clients"
4162         https://bugs.webkit.org/show_bug.cgi?id=173398
4163         http://trac.webkit.org/changeset/218365
4164
4165 2017-06-15  Jer Noble  <jer.noble@apple.com>
4166
4167         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
4168         https://bugs.webkit.org/show_bug.cgi?id=173398
4169         <rdar://problem/32592961>
4170
4171         Reviewed by Eric Carlson.
4172
4173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4174         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
4175         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4176         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4177         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
4178         (TestWebKitAPI::TEST):
4179         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
4180
4181 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4182
4183         REGRESSION(r218344): [WPE] Thousands of layout test crashes
4184         https://bugs.webkit.org/show_bug.cgi?id=173433
4185
4186         Unreviewed.
4187
4188         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
4189
4190 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4191
4192         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
4193         https://bugs.webkit.org/show_bug.cgi?id=173061
4194
4195         Reviewed by Žan Doberšek.
4196
4197         Launch dyz <https://github.com/Igalia/dyz> with the script
4198         run-minibrowser for the wpe port. It is now built as part of the
4199         WPE dependencies with JHBuild.
4200
4201         * Scripts/run-minibrowser:
4202         * Scripts/webkitdirs.pm:
4203         (launcherPath):
4204         (launcherName):
4205         * wpe/install-dependencies: Luajit is needed for building dyz.
4206         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
4207
4208 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4209
4210         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
4211         https://bugs.webkit.org/show_bug.cgi?id=173338
4212         <rdar://problem/32777720>
4213
4214         Reviewed by Tim Horton.
4215
4216         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
4217         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
4218         these remaining items on drop.
4219
4220         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4221         (TestWebKitAPI::TEST):
4222         * TestWebKitAPI/ios/DataInteractionSimulator.h:
4223         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
4224
4225         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
4226
4227         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
4228
4229 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
4230
4231         [Win] Crash in accessibility layout test.
4232         https://bugs.webkit.org/show_bug.cgi?id=173401
4233
4234         Reviewed by Brent Fulgham.
4235
4236         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
4237         member will be automatically released when the _variant_t object goes out of scope if the vt member
4238         does not equal VT_UNKNOWN | VT_BYREF.
4239         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
4240
4241         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4242         (AccessibilityUIElement::titleUIElement):
4243
4244 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
4245
4246         [GTK] Add API to allow overriding popup menus
4247         https://bugs.webkit.org/show_bug.cgi?id=172905
4248
4249         Reviewed by Michael Catanzaro.
4250
4251         Add a unit test to check the new API.
4252
4253         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4254         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
4255         (OptionMenuTest::OptionMenuTest):
4256         (OptionMenuTest::~OptionMenuTest):
4257         (OptionMenuTest::destroyMenu):
4258         (OptionMenuTest::showOptionMenuCallback):
4259         (OptionMenuTest::menuCloseCallback):
4260         (OptionMenuTest::showOptionMenu):
4261         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
4262         (OptionMenuTest::close):
4263         (OptionMenuTest::activateItem):
4264         (OptionMenuTest::selectItem):
4265         (testOptionMenuSimple):
4266         (testOptionMenuGroups):