6c5504bed49c4a2037fec6a9b188207cde7b7765
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         REGRESSION(r219850): run-benchmark script broken on Linux
4         https://bugs.webkit.org/show_bug.cgi?id=175126
5
6         Reviewed by Stephanie Lewis.
7
8         The run-benchmark script dynamically generates the list of supported
9         browsers and platforms (currently Linux and OSX) by loading all
10         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
11         and getting the browser_name and platform variables from the
12         classes defined there.
13
14         This means that this classes should not raise an exception when
15         loaded on other platforms or otherwise they will broke the whole
16         script. Its fine if they raise an exception when executing any of
17         the methods they implement, but not when just loading/importing
18         the class.
19
20         Move the argument variable definitions that call on the platform
21         specific OSXBrowserDriver._screen_size() function from beeing
22         variables that are evaluated when loading the file, to be functions
23         that are only evaluated when the actual functionality needs to be
24         executed.
25
26         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
27         (OSXChromeDriver.launch_url):
28         (OSXChromeCanaryDriver.launch_url):
29         (create_args):
30         (create_chrome_options):
31         (create_window_size_arg):
32         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
33         (OSXFirefoxDriver.launch_url):
34         (OSXFirefoxNightlyDriver.launch_url):
35         (OSXFirefoxNightlyDriver.launch_driver):
36         (create_args):
37
38 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
39
40         [PAL] Move spi/cf directory into PAL
41         https://bugs.webkit.org/show_bug.cgi?id=175057
42
43         Reviewed by Antti Koivisto.
44
45         * Scripts/webkitpy/style/checker.py:
46         * Scripts/webkitpy/style/checker_unittest.py:
47         (GlobalVariablesTest.test_path_rules_specifier):
48
49         Ignore "readability/naming/underscores" style errors for sources
50         under the WebCore/PAL/pal/spi directory.
51
52         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
53
54 2017-08-03  Youenn Fablet  <youenn@apple.com>
55
56         Remove FETCH_API compilation guard
57         https://bugs.webkit.org/show_bug.cgi?id=175154
58
59         Reviewed by Chris Dumez.
60
61         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
62
63 2017-08-03  Lucas Forschler  <lforschler@apple.com>
64
65         Enable archive minification on iOS builds
66         https://bugs.webkit.org/show_bug.cgi?id=174718
67         
68         Reviewed by Aakash Jain.
69
70         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
71         (BuildFactory.__init__):
72
73 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
74
75         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
76         https://bugs.webkit.org/show_bug.cgi?id=175140
77
78         Reviewed by Alexey Proskuryakov.
79
80         We are having lately issues with JSC tests causing problems on
81         the GTK+ and WPE bots due to the high amount of memory some tests
82         need to run.
83
84         The best thing we can do now is to workaround this by disabling
85         all the tests marked as memoryLimited on the GTK and WPE bots.
86         We may revise this on the future.
87
88         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
89         (RunJavaScriptCoreTests.start):
90
91 2017-08-03  Brady Eidson  <beidson@apple.com>
92
93         Add SW IDLs and stub out basic functionality.
94         https://bugs.webkit.org/show_bug.cgi?id=175115
95
96         Reviewed by Chris Dumez.
97
98         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
99
100         * Scripts/webkitpy/bindings/main.py:
101
102 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
103
104         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
105         https://bugs.webkit.org/show_bug.cgi?id=159510
106
107         Reviewed by Daniel Bates.
108
109         Allow any https certificate when running tests.
110
111         * DumpRenderTree/win/DumpRenderTree.cpp:
112         (runTest):
113
114 2017-08-02  Youenn Fablet  <youenn@apple.com>
115
116         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
117         https://bugs.webkit.org/show_bug.cgi?id=175089
118
119         Reviewed by Chris Dumez.
120
121         * DumpRenderTree/TestOptions.mm:
122         (TestOptions::TestOptions): Using absolutePath if available.
123         * DumpRenderTree/mac/DumpRenderTree.mm:
124         (computeTestURL): Removing http/tests/ specific URL computation.
125         * Scripts/webkitpy/port/driver.py:
126         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
127
128 2017-08-02  Lucas Forschler  <lforschler@apple.com>
129
130         download-built-product should allow for a proxy option
131         https://bugs.webkit.org/show_bug.cgi?id=174875
132
133         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
134
135         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
136         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
137         
138
139 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
140
141         check-webkit-style: deleting lines in a file runs the linter on the whole file
142         https://bugs.webkit.org/show_bug.cgi?id=175078
143
144         Reviewed by David Kilzer.
145
146         Deleting lines in a file should not cause linter errors to be blamed on the patch.
147         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
148
149         * Scripts/webkitpy/style/checkers/test_expectations.py:
150         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
151         * Scripts/webkitpy/style/main_unittest.py:
152         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
153         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
154         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
155
156 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
157
158         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
159         https://bugs.webkit.org/show_bug.cgi?id=175075
160
161         Reviewed by David Kilzer.
162
163         We have no way of handling text files with illegal unicode characters. Allow the callers of
164         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
165         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
166
167         * Scripts/webkitpy/common/system/filesystem.py:
168         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
169         (FileSystem.write_text_file): Ditto.
170         * Scripts/webkitpy/common/system/filesystem_mock.py:
171         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
172         (MockFileSystem.write_text_file): Ditto.
173         * Scripts/webkitpy/common/system/filesystem_unittest.py:
174         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
175         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
176
177 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
178
179         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
180         https://bugs.webkit.org/show_bug.cgi?id=175072
181
182         Reviewed by Alexey Proskuryakov.
183
184         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
185         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
186
187 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
188
189         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
190         https://bugs.webkit.org/show_bug.cgi?id=175019
191
192         Reviewed by Darin Adler.
193
194         * TestWebKitAPI/CMakeLists.txt:
195
196 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
197
198         Enabling uploading archives to S3
199         https://bugs.webkit.org/show_bug.cgi?id=174198
200
201         Unreviewed unit test fix after r219235.
202
203         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
204
205 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
206
207         Fix JSCOnly ARM buildbots after r220047
208         https://bugs.webkit.org/show_bug.cgi?id=174993
209
210         Unreviewed fix after r220087.
211
212         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
213         (BuildAndRemoteJSCTestsFactory.__init__):
214
215 2017-08-01  Chris Dumez  <cdumez@apple.com>
216
217         Add initial support for navigator.sendBeacon
218         https://bugs.webkit.org/show_bug.cgi?id=175007
219         <rdar://problem/33547728>
220
221         Reviewed by Sam Weinig.
222
223         Enable the Beacon API at runtime in the context of layout tests since the
224         feature is currently disabled by default.
225
226         * DumpRenderTree/mac/DumpRenderTree.mm:
227         (enableExperimentalFeatures):
228         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
229         (WTR::InjectedBundle::beginTesting):
230         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
231         (WTR::TestRunner::setModernMediaControlsEnabled):
232         (WTR::TestRunner::setBeaconAPIEnabled):
233         * WebKitTestRunner/InjectedBundle/TestRunner.h:
234
235 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
236
237         Update Bot Watcher's Dashboard for Buildbot 0.9
238         https://bugs.webkit.org/show_bug.cgi?id=174777
239
240         Reviewed by Daniel Bates.
241
242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
243         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
244         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
245         in a dictionary.
246         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
247         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
249         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
250         (parseRevisionProperty): Ditto.
251         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
252         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
253         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
254         have changed in Buildbot 0.9.
255         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
256         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
257         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
258         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
259         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
260         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
261         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
262         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
263         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
264         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
266         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
267         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
268         (BuildbotQueue.prototype.get overviewURL): Ditto.
269         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
270         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
271         Buildbot 0.8 or 0.9.
272         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
273         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
274         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
275         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
276         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
277         Therefore we are fetching information for fixed number of build. 
278         Also iterating the loop incrementally since the build data is already reverse sorted.
279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
280         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
281         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
283         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
284
285 2017-08-01  Devin Rousso  <drousso@apple.com>
286
287         Web Inspector: simplify WebInspector with WI
288         https://bugs.webkit.org/show_bug.cgi?id=175058
289
290         Reviewed by Joseph Pecoraro.
291
292         * Scripts/check-inspector-strings:
293         (extract_ui_strings):
294         * Scripts/extract-localizable-js-strings:
295
296 2017-08-01  Youenn Fablet  <youenn@apple.com>
297
298         Layout tests with 'https' suffix should be run over HTTPS
299         https://bugs.webkit.org/show_bug.cgi?id=174992
300
301         Reviewed by Chris Dumez.
302
303         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
304         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
305         Covered by corresponding unit tests.
306
307         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
308         (run_server):
309         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
310         (base_http_url):
311         (base_https_url):
312         (base_url): Deleted.
313         * Scripts/webkitpy/port/base.py:
314         (Port.to.web_platform_test_server_base_http_url):
315         (Port.to):
316         (Port.to.web_platform_test_server_base_https_url):
317         (Port.to.web_platform_test_server_base_url): Deleted.
318         * Scripts/webkitpy/port/driver.py:
319         (Driver.__init__):
320         (Driver.wpt_test_path_to_uri):
321         (Driver):
322         (Driver.http_test_path_to_uri):
323         (Driver.test_to_uri):
324         (Driver.uri_to_test):
325         * Scripts/webkitpy/port/driver_unittest.py:
326         (DriverTest.test_test_to_uri):
327         (DriverTest.test_uri_to_test):
328
329 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
330
331         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
332         https://bugs.webkit.org/show_bug.cgi?id=173998
333
334         Reviewed by Darin Adler.
335
336         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
337         detect mistakes in backward compatibility in the future when we change it.
338
339         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
340         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
341         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
342         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
343         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
344         internal key data slot.
345
346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
347         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
348         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
349         (getNextMessage):
350         (TEST):
351         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
352         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
353         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
354         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
355         These are the pre-baked databases.
356         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
357         This is the actual test that do all the reads and comparisons.
358         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
359         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
360         IndexedDB new stuffs. Then it can be used to bake the database again.
361
362 2017-08-01  Brady Eidson  <beidson@apple.com>
363
364         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
365         https://bugs.webkit.org/show_bug.cgi?id=175030
366
367         Reviewed by Andy Estes.
368
369         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
370         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
371
372 2017-08-01  Brady Eidson  <beidson@apple.com>
373
374         Part 2 of: Rename DatabaseProcess to StorageProcess.
375         https://bugs.webkit.org/show_bug.cgi?id=174880
376
377         Reviewed by Andy Estes.
378
379         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
380         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
381         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
382         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
383         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
384         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
385         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
386         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
387
388 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
389
390         Fix JSCOnly ARM buildbots after r220047
391         https://bugs.webkit.org/show_bug.cgi?id=174993
392
393         Reviewed by Saam Barati.
394
395         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
396         (BuildAndRemoteJSCTestsFactory.__init__):
397
398 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
399
400         [WTF] Introduce Private Symbols
401         https://bugs.webkit.org/show_bug.cgi?id=174935
402
403         Reviewed by Darin Adler.
404
405         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
406         (TestWebKitAPI::TEST):
407
408 2017-07-30  Darin Adler  <darin@apple.com>
409
410         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
411         https://bugs.webkit.org/show_bug.cgi?id=130653
412
413         Reviewed by Antti Koivisto.
414
415         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
416         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
417         when calling frameDidChangeLocation.
418         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
419         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
420         thus causing mysterious failures of a couple of tests. There are two remaining issues:
421         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
422         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
423         same logic flaw that causes "top loading frame" to get set to one of the subframes in
424         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
425         loading, subframe starts loading. It would be good to clean that up some day, but for now
426         this patch makes the two work identically rather than changing both.
427         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
428
429 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
430
431         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
432         https://bugs.webkit.org/show_bug.cgi?id=174963
433
434         Reviewed by Darin Adler.
435
436         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
437         RetainPtr<>. This patch changes them to all use auto.
438
439         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
440         (TestWebKitAPI::TEST):
441
442 2017-07-30  Brady Eidson  <beidson@apple.com>
443
444         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
445         https://bugs.webkit.org/show_bug.cgi?id=174958
446
447         Reviewed by Darin Adler.
448
449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
450         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
451         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
452         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
453         (runUntilTasksInFlight):
454         (TEST):
455
456 2017-07-28  Commit Queue  <commit-queue@webkit.org>
457
458         Unreviewed, rolling out r219990.
459         https://bugs.webkit.org/show_bug.cgi?id=174961
460
461         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
462         estes on #webkit).
463
464         Reverted changeset:
465
466         "Part 2 of: Rename DatabaseProcess to StorageProcess."
467         https://bugs.webkit.org/show_bug.cgi?id=174880
468         http://trac.webkit.org/changeset/219990
469
470 2017-07-28  Brady Eidson  <beidson@apple.com>
471
472         API tests that use URLSchemeHandler are failing.
473         https://bugs.webkit.org/show_bug.cgi?id=174950
474
475         Reviewed by Alex Christensen.
476
477         Fix the NoMIMEType test to be correct.
478
479         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
480         (-[SchemeHandler initWithData:mimeType:]):
481         (-[SchemeHandler webView:startURLSchemeTask:]):
482         (TEST):
483
484 2017-07-28  Daniel Bates  <dabates@apple.com>
485
486         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
487         https://bugs.webkit.org/show_bug.cgi?id=174876
488
489         Reviewed by Alex Christensen.
490
491         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
492         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
493         they provide a more direct way to test the platform abstraction.
494
495         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
496
497         * Scripts/prepare-ChangeLog:
498         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
499         of the current working directory.
500
501 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
502
503         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
504         https://bugs.webkit.org/show_bug.cgi?id=174930
505
506         Unreviewed test fix.
507
508         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
509
510         * Scripts/prepare-ChangeLog:
511         (get_function_line_ranges_for_cpp):
512
513 2017-07-28  JF Bastien  <jfbastien@apple.com>
514
515         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
516         https://bugs.webkit.org/show_bug.cgi?id=174930
517
518         Reviewed by Daniel Bates.
519
520         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
521         here also teach it about const and volatile overloads. I didn't do
522         reference and rvalue reference overloads because we don't really
523         use them, and the current parser throws away those characters and
524         it doesn't seem worth making it more complex.
525
526         * Scripts/prepare-ChangeLog:
527         (get_function_line_ranges_for_cpp):
528         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
529         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
530         (Foo::Arrow::arrow):
531         (Foo::Arrow::otherArrow):
532         (Foo::Arrow::otherArrow const):
533         (Foo::Arrow::otherArrow volatile):
534         (Foo::Arrow::otherArrow const volatile):
535
536 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
537
538         [GTK] Building with ENABLE_VIDEO=OFF fails
539         https://bugs.webkit.org/show_bug.cgi?id=174940
540
541         Reviewed by Alex Christensen.
542
543         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
544         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
545
546         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
547         (methodCallCallback): Add missing USE(GSTREAMER) guard.
548
549 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
550
551         [WPE] Implement EventSenderProxy in WTR
552         https://bugs.webkit.org/show_bug.cgi?id=173419
553
554         Reviewed by Žan Doberšek.
555
556         Add the implementation of EventSenderProxy to the WTR. This
557         allows us to extend the coverage of the test suite in WKWPE.
558
559         * WebKitTestRunner/EventSenderProxy.h:
560         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
561         libxkbcommon needed to deal with key events.
562         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
563         (WTR::EventSenderProxy::EventSenderProxy):
564         (WTR::senderButtonToWPEButton):
565         (WTR::EventSenderProxy::mouseDown):
566         (WTR::EventSenderProxy::mouseUp):
567         (WTR::EventSenderProxy::mouseMoveTo):
568         (WTR::EventSenderProxy::mouseScrollBy):
569         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
570         (WTR::EventSenderProxy::leapForward):
571         (WTR::wkEventModifiersToWPE):
572         (WTR::getXKBKeySymForKeyRef):
573         (WTR::EventSenderProxy::keyDown):
574         (WTR::EventSenderProxy::addTouchPoint):
575         (WTR::EventSenderProxy::updateTouchPoint):
576         (WTR::EventSenderProxy::setTouchModifier):
577         (WTR::EventSenderProxy::setTouchPointRadius):
578         (WTR::EventSenderProxy::getUpdatedTouchEvents):
579         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
580         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
581         (WTR::EventSenderProxy::touchStart):
582         (WTR::EventSenderProxy::touchMove):
583         (WTR::EventSenderProxy::touchEnd):
584         (WTR::EventSenderProxy::touchCancel):
585         (WTR::EventSenderProxy::clearTouchPoints):
586         (WTR::EventSenderProxy::releaseTouchPoint):
587         (WTR::EventSenderProxy::cancelTouchPoint):
588
589 2017-07-27  Brady Eidson  <beidson@apple.com>
590
591         Part 2 of: Rename DatabaseProcess to StorageProcess.
592         https://bugs.webkit.org/show_bug.cgi?id=174880
593
594         Reviewed by Andy Estes.
595
596         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
597         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
598         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
599         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
600         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
601         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
602         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
603         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
604
605 2017-07-26  Mark Lam  <mark.lam@apple.com>
606
607         Add ability to only run specific tests in run-javascriptcore-tests.
608         https://bugs.webkit.org/show_bug.cgi?id=174884
609
610         Reviewed by Saam Barati.
611
612         For example, if we only want to run testapi, we can do so as follows:
613             $ run-javascriptcore-tests --testapi
614
615         Previously, specifying --testapi effectively does nothing because we run all tests
616         by default.  Only --no-testapi had the effect of disabling the test set.  This
617         old behavior for --testapi is not very useful or meaningful.  We're now changing
618         it to mean that we will only run that test.
619
620         With this change, we can also run more than one set of tests.  For example, if we
621         only want to run testmasm and testair, we can do so as follows:
622             $ run-javascriptcore-tests --testmasm --testair
623
624         By default, if no specific test option is specified, run-javascriptcore-tests will
625         run all tests.
626
627         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
628         the mozilla tests (--mozilla-tests) even though both are run via the lower level
629         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
630         the other set will not run.  For example, the following only runs the mozilla tests:
631             $ run-javascriptcore-tests --mozilla-tests
632
633         Note also that --jit-stress-tests is not for choosing a different set of tests.
634         Instead, it is used for determining whether we run JIT'ed test configurations
635         on the jsc stress tests and mozilla tests.  As a result, specifying
636         --jit-stress-tests will not omit other tests.  For example, the following still
637         runs all tests:
638             $ run-javascriptcore-tests --jit-stress-tests
639
640         * Scripts/run-javascriptcore-tests:
641         (defaultStringForTestState):
642         (enableTestOrNot):
643         (runJSCStressTests):
644
645 2017-07-26  Mark Lam  <mark.lam@apple.com>
646
647         Make run-javascriptcore-test run testair, testb3, and testmasm.
648         https://bugs.webkit.org/show_bug.cgi?id=174837
649         <rdar://problem/33522927>
650
651         Reviewed by Saam Barati and Filip Pizlo.
652
653         1. Refactors code for running testapi so that we can use it to run other tests.
654         2. Added running of testmasm, testair, testb3.
655
656         Note: the existing testapi invocation code does not support remote invocation of
657         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
658         and testb3 also do not support remote invocation.  If we wish to add remote
659         invocation support, we should do that in a separate patch.
660
661         * Scripts/run-javascriptcore-tests:
662         (testPath):
663         (runTest):
664         (testapiPath): Deleted.
665
666 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
667
668         Remove duplicate code from Buildbot.js in dashboard
669         https://bugs.webkit.org/show_bug.cgi?id=174870
670
671         Reviewed by Daniel Bates.
672
673         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
674         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
675         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
676         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
677         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
678
679 2017-07-26  Brady Eidson  <beidson@apple.com>
680
681         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
682         https://bugs.webkit.org/show_bug.cgi?id=174851
683
684         Reviewed by Chris Dumez.
685
686         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
687         (TEST):
688
689 2017-07-26  Brian Burg  <bburg@apple.com>
690
691         Remove WEB_TIMING feature flag
692         https://bugs.webkit.org/show_bug.cgi?id=174795
693
694         Reviewed by Alex Christensen.
695
696         * Scripts/webkitperl/FeatureList.pm:
697         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
698
699 2017-07-26  Chris Dumez  <cdumez@apple.com>
700
701         Pressing the Escape key should not be a valid user gesture to enter fullscreen
702         https://bugs.webkit.org/show_bug.cgi?id=174864
703         <rdar://problem/33009088>
704
705         Reviewed by Geoffrey Garen.
706
707         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
708         WKTR.
709
710         * DumpRenderTree/mac/EventSendingController.mm:
711         (-[EventSendingController keyDown:withModifiers:withLocation:]):
712
713 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
714
715         Unreviewed, added Romain Bellessort to contributors.json.
716
717         * Scripts/webkitpy/common/config/contributors.json:
718
719 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
720
721         [WPE] WebGL2 support
722         https://bugs.webkit.org/show_bug.cgi?id=174249
723
724         Reviewed by Alex Christensen.
725
726         * Scripts/webkitperl/FeatureList.pm:
727         Enable WebGL2 for WPE when building through build-webkit.
728
729 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
730
731         Unreviewed. Fix GTK distcheck.
732
733         * gtk/make-dist.py:
734         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
735
736 2017-07-25  Brady Eidson  <beidson@apple.com>
737
738         ResourceLoadStatistics grandfathering happens much too often.
739         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
740
741         Reviewed by Chris Dumez.
742
743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
744         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
745         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
746         (TEST):
747
748 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
749
750         Fix autoinstaller failing on autoinstall_everything
751         https://bugs.webkit.org/show_bug.cgi?id=174830
752
753         Reviewed by Joseph Pecoraro.
754
755         * Scripts/webkitpy/thirdparty/__init__.py:
756         (AutoinstallImportHook.find_module):
757         (AutoinstallImportHook.install_chromedriver):
758         (AutoinstallImportHook.install_geckodriver):
759         (AutoinstallImportHook._install_chromedriver): Deleted.
760         (AutoinstallImportHook._install_geckodriver): Deleted.
761
762 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
763
764         Replace --runtime with something for both ios-simulator and ios-device
765         https://bugs.webkit.org/show_bug.cgi?id=173775
766         <rdar://problem/32952164>
767
768         Reviewed by Aakash Jain.
769
770         Add --version flag for both iOS simulator and iOS device.
771
772         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
773         (parse_args): Add --version flag and move --no-install.
774         * Scripts/webkitpy/port/factory.py:
775         (platform_options): Move --no-intall to run_webkit_tests.py.
776         * Scripts/webkitpy/port/ios.py:
777         (IOSPort):
778         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
779         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
780         * Scripts/webkitpy/port/ios_device.py:
781         (IOSDevicePort.ios_version): Consult --version flag before checking connected
782         devices for iOS version.
783         * Scripts/webkitpy/port/ios_device_unittest.py:
784         (IOSDeviceTest.make_port): Set --version option so that we can generate test
785         expectation paths without devices connected.
786         (IOSDeviceTest.test_additional_platform_directory): Deleted.
787         (IOSDeviceTest.test_baseline_searchpath): Deleted.
788         (IOSDeviceTest.test_expectations_ordering): Deleted.
789         * Scripts/webkitpy/port/ios_simulator.py:
790         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
791         flag to specify a runtime.
792         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
793         flag and then use the default runtime.
794
795 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
796
797         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
798         https://bugs.webkit.org/show_bug.cgi?id=174815
799
800         Reviewed by Carlos Alberto Lopez Perez.
801
802         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
803         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
804         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
805         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
806         think), probably because of a newer CMake version.
807
808         * CMakeLists.txt:
809         * TestWebKitAPI/CMakeLists.txt:
810         * TestWebKitAPI/PlatformGTK.cmake:
811
812 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
813
814         Fix BenchmarkRunner to only import selenium when needed
815         https://bugs.webkit.org/show_bug.cgi?id=174808
816
817         Reviewed by Stephanie Lewis.
818
819         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
820         (LinuxChromeDriver.launch_driver):
821         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
822         (LinuxFirefoxDriver.launch_driver):
823         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
824         (OSXChromeDriver.launch_driver):
825         (OSXChromeCanaryDriver.launch_driver):
826         (create_chrome_options):
827         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
828         (OSXFirefoxDriver.launch_driver):
829         (OSXFirefoxNightlyDriver.launch_driver):
830         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
831         (OSXSafariDriver.launch_driver):
832         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
833         (WebDriverBenchmarkRunner._run_one_test):
834
835 2017-07-23  Darin Adler  <darin@apple.com>
836
837         More NeverDestroyed and related cleanup
838         https://bugs.webkit.org/show_bug.cgi?id=174745
839
840         Reviewed by Alex Christensen.
841
842         * DumpRenderTree/JavaScriptThreading.cpp:
843         (javaScriptThreadsMutex): Use NeverDestroyed instead of
844         DEPRECATED_DEFINE_STATIC_LOCAL.
845         (javaScriptThreads): Ditto.
846
847 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
848
849         Subclass Benchmark Runner script for WebDriver support
850         https://bugs.webkit.org/show_bug.cgi?id=174390
851
852         Reviewed by Dewei Zhu, Stephanie Lewis.
853
854         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
855
856         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
857         (BenchmarkBuilder.__init__):
858         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
859         (BenchmarkRunner.__init__):
860         (BenchmarkRunner._find_plan_file):
861         (BenchmarkRunner._run_one_test.and):
862         (BenchmarkRunner.execute):
863         (BenchmarkRunner._get_result): Deleted.
864         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
865         (parse_args):
866         (start):
867         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
868         (WebDriverBenchmarkRunner):
869         (WebDriverBenchmarkRunner._get_result):
870         (WebDriverBenchmarkRunner._run_one_test):
871         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
872         (WebServerBenchmarkRunner):
873         (WebServerBenchmarkRunner.__init__):
874         (WebServerBenchmarkRunner._get_result):
875         (WebServerBenchmarkRunner._run_one_test):
876
877 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
878
879         Add BenchmarkRunner patches with WebDriver support for each testing plan
880         https://bugs.webkit.org/show_bug.cgi?id=174443
881
882         Reviewed by Dewei Zhu, Stephanie Lewis.
883
884         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
885         (BenchmarkBuilder.__enter__):
886         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
887         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
888         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
889         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
890         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
891         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
892         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
893         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
894         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
895         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
896         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
897         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
898         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
899         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
900         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
901         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
902         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
903         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
904         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
905         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
906         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
907         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
908         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
909         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
910         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
911         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
912         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
913         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
914         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
915         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
916         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
917         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
918         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
919
920 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
921
922         Add functions to autoinstaller needed for Benchmark Runner script
923         https://bugs.webkit.org/show_bug.cgi?id=174331
924
925         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
926
927         Adds autoinstaller functions to install selenium and webdriver binaries
928         which will be used by the browser driver part of Benchmark Runner.
929
930         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
931         (BrowserDriver.restore_env):
932         (BrowserDriver):
933         (BrowserDriver.get_webdriver_binary_path):
934         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
935         (LinuxChromeDriver.launch_driver):
936         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
937         (LinuxFirefoxDriver.launch_driver):
938         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
939         (OSXChromeDriver.launch_driver):
940         (OSXChromeCanaryDriver.launch_driver):
941         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
942         (OSXFirefoxDriver.launch_driver):
943         (OSXFirefoxNightlyDriver.launch_driver):
944         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
945         * Scripts/webkitpy/benchmark_runner/utils.py:
946         (get_driver_binary_path):
947         * Scripts/webkitpy/common/system/autoinstall.py:
948         (AutoInstaller._unzip):
949         * Scripts/webkitpy/thirdparty/__init__.py:
950         (AutoinstallImportHook.find_module):
951         (AutoinstallImportHook._install_selenium):
952         (AutoinstallImportHook):
953         (AutoinstallImportHook._install_chromedriver):
954         (AutoinstallImportHook._install_geckodriver):
955         (AutoinstallImportHook.get_latest_pypi_url):
956         (AutoinstallImportHook.install_binary):
957         (autoinstall_everything):
958         (get_driver_filename):
959         (get_os_info):
960
961 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
962
963         Add WebDriver support in browser driver part of BenchmarkRunner
964         https://bugs.webkit.org/show_bug.cgi?id=174445
965
966         Reviewed by Stephanie Lewis.
967
968         Adds a launch_driver function to each BrowserDriver subclass. This
969         function sets up the arguments for the webdriver and launches the
970         webdriver specific to that browser.
971
972         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
973         (BrowserDriver.launch_webdriver):
974         (BrowserDriver):
975         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
976         (LinuxBrowserDriver.launch_webdriver):
977         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
978         (LinuxChromeDriver.launch_url):
979         (LinuxChromeDriver):
980         (LinuxChromeDriver.launch_driver):
981         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
982         (EpiphanyBrowserDriver.launch_url):
983         (EpiphanyBrowserDriver):
984         (EpiphanyBrowserDriver.launch_driver):
985         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
986         (LinuxFirefoxDriver):
987         (LinuxFirefoxDriver.launch_url):
988         (LinuxFirefoxDriver.launch_driver):
989         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
990         (GTKMiniBrowserDriver.launch_url):
991         (GTKMiniBrowserDriver):
992         (GTKMiniBrowserDriver.launch_driver):
993         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
994         (OSXBrowserDriver._launch_webdriver):
995         (OSXBrowserDriver):
996         (OSXBrowserDriver._screen_size):
997         (OSXBrowserDriver._insert_url):
998         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
999         (OSXChromeDriver):
1000         (OSXChromeDriver.launch_url):
1001         (OSXChromeDriver.launch_driver):
1002         (OSXChromeCanaryDriver):
1003         (OSXChromeCanaryDriver.launch_url):
1004         (OSXChromeCanaryDriver.launch_driver):
1005         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1006         (OSXFirefoxDriver):
1007         (OSXFirefoxDriver.launch_url):
1008         (OSXFirefoxDriver.launch_driver):
1009         (OSXFirefoxNightlyDriver):
1010         (OSXFirefoxNightlyDriver.launch_url):
1011         (OSXFirefoxNightlyDriver.launch_driver):
1012         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1013         (OSXSafariDriver.launch_driver):
1014
1015 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1016
1017         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
1018         https://bugs.webkit.org/show_bug.cgi?id=174793
1019
1020         Reviewed by Tim Horton.
1021
1022         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
1023         down. Without r219765, this test will dereference null and crash.
1024
1025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1026         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
1027         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
1028         (TEST):
1029
1030 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1031
1032         [Win] Implement Authentication dialog in MiniBrowser
1033         https://bugs.webkit.org/show_bug.cgi?id=174662
1034
1035         Reviewed by Alex Christensen.
1036
1037         * MiniBrowser/win/Common.cpp:
1038         (CustomUserAgent):
1039         (DisplayAuthDialog):
1040         (AuthDialogProc):
1041         * MiniBrowser/win/MiniBrowserLib.rc:
1042         * MiniBrowser/win/MiniBrowserLibResource.h:
1043         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1044         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1045
1046 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
1047
1048         Handle case where line_numbers is None instead of an array of line numbers
1049         https://bugs.webkit.org/show_bug.cgi?id=174775
1050
1051         Reviewed by Aakash Jain.
1052
1053         Added files set line_numbers to None in process_file.
1054
1055         * Scripts/webkitpy/style/filereader.py:
1056         (TextFileReader.process_file): Handle case where line_number is set to None.
1057         * Scripts/webkitpy/style/main_unittest.py:
1058         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
1059
1060 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1061
1062         [WPE] Add libepoxy to the Jhbuild moduleset
1063         https://bugs.webkit.org/show_bug.cgi?id=174711
1064
1065         Reviewed by Carlos Alberto Lopez Perez.
1066
1067         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
1068
1069 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1070
1071         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
1072         https://bugs.webkit.org/show_bug.cgi?id=174780
1073
1074         Reviewed by Carlos Garcia Campos.
1075
1076         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1077         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
1078         in case the eglplatform.h header doesn't provide that macro. This replicates
1079         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
1080
1081 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1082
1083         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
1084         https://bugs.webkit.org/show_bug.cgi?id=174758
1085
1086         Reviewed by Dan Bernstein.
1087
1088         Migrate position-information-related unit tests from the PositionInformationTests suite to
1089         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
1090
1091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1092         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1093         (TestWebKitAPI::checkElementTypeAndBoundingRect):
1094         (TestWebKitAPI::TEST):
1095         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
1096         * TestWebKitAPI/cocoa/TestWKWebView.h:
1097         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1098         (-[TestWKWebView activatedElementAtPosition:]):
1099
1100 2017-07-22  Chris Dumez  <cdumez@apple.com>
1101
1102         REGRESSION(r204565): WKObject is broken
1103         https://bugs.webkit.org/show_bug.cgi?id=174736
1104         <rdar://problem/33246169>
1105
1106         Reviewed by Dan Bernstein.
1107
1108         Add API test that used to crash.
1109
1110         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1111         (TestWebKitAPI::TEST):
1112
1113 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1114
1115         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
1116         https://bugs.webkit.org/show_bug.cgi?id=174705
1117
1118         Reviewed by Mark Lam.
1119
1120         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1121         (TestWebKitAPI::testThreadGroup):
1122         (TestWebKitAPI::TEST):
1123
1124 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
1125
1126         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
1127         https://bugs.webkit.org/show_bug.cgi?id=174724
1128
1129         Reviewed by Aakash Jain.
1130
1131         * Scripts/webkitpy/port/ios_simulator.py:
1132         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
1133         simulator. Errors here should be treated the same as no simulators found.
1134
1135 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
1136
1137         [CMake] Add an option to stop build after generating project files
1138         https://bugs.webkit.org/show_bug.cgi?id=174664
1139
1140         Reviewed by Konstantin Tokarev.
1141
1142         Add "--generate-project-only" to stop build after generating project files.
1143
1144         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
1145         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
1146         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
1147         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
1148         (isGenerateProjectOnly): ditto
1149
1150 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1151
1152         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1153         https://bugs.webkit.org/show_bug.cgi?id=174501
1154
1155         Reviewed by Darin Adler.
1156
1157         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1158         (TestWebKitAPI::TEST):
1159
1160 2017-07-20  David Quesada  <david_quesada@apple.com>
1161
1162         Add SPI to notify WKNavigationDelegate about client redirects
1163         https://bugs.webkit.org/show_bug.cgi?id=174680
1164         rdar://problem/33184886
1165
1166         Reviewed by Brady Eidson.
1167
1168         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1169         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
1170         (TEST):
1171         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
1172
1173 2017-07-20  Brady Eidson  <beidson@apple.com>
1174
1175         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
1176         https://bugs.webkit.org/show_bug.cgi?id=174685
1177
1178         Reviewed by Andy Estes.
1179
1180         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1181         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
1182
1183 2017-07-20  Brady Eidson  <beidson@apple.com>
1184
1185         Deprecate WebIconDatabase in WebKitLegacy/mac.
1186         https://bugs.webkit.org/show_bug.cgi?id=174607
1187
1188         Reviewed by Alex Christensen.
1189
1190         * DumpRenderTree/mac/TestRunnerMac.mm:
1191
1192 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
1193
1194         lint-test-expectations should be run during style checking
1195         https://bugs.webkit.org/show_bug.cgi?id=173559
1196         <rdar://problem/32854941>
1197
1198         Reviewed by Aakash Jain.
1199
1200         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1201         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
1202         prevents identifying errors on specific lines in a file.
1203         * Scripts/webkitpy/style/main_unittest.py:
1204         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
1205         case where a linter error is in the file modified, but the line modified is not related to
1206         the linter error.
1207
1208 2017-07-20  Brady Eidson  <beidson@apple.com>
1209
1210         Remove WebIconDatabase from WebKitLegacy/win.
1211         https://bugs.webkit.org/show_bug.cgi?id=174608
1212
1213         Reviewed by Alex Christensen.
1214
1215         * DumpRenderTree/win/DumpRenderTree.cpp:
1216         (main):
1217         * DumpRenderTree/win/TestRunnerWin.cpp:
1218         (TestRunner::setIconDatabaseEnabled):
1219
1220 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
1221
1222         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
1223         https://bugs.webkit.org/show_bug.cgi?id=174671
1224
1225         Reviewed by Carlos Garcia Campos.
1226
1227         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1228         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
1229         priority for this source in order to have it dispatched on the same
1230         priority as the other WebKit-controlled GSource objects.
1231
1232 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1233
1234         lint-test-expectations should be run during style checking
1235         https://bugs.webkit.org/show_bug.cgi?id=173559
1236         <rdar://problem/32854941>
1237
1238         Reviewed by Daniel Bates.
1239
1240         Follow up fix addressing style and a few minor bugs.
1241
1242         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1243         (TestExpectationParser.__init__): Use lambda x: x instead of str
1244         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
1245         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
1246         reduce the calls of _shorten_filename, fix minor bug in appending the current
1247         expectation's line number instead of the previous ones, clarify treatment of None
1248         in file-to-line-number mapping.
1249         (TestExpectations._report_warnings): Collapse call.
1250         * Scripts/webkitpy/style/checkers/test_expectations.py:
1251         (TestExpectationsChecker.lint_test_expectations):
1252         * Scripts/webkitpy/style/filereader.py: Re-write comment.
1253         (TextFileReader.process_file): Add comment explaining treatment of None in
1254         file-to-line-number mapping.
1255         (TextFileReader.delete_file): Collapse call.
1256
1257 2017-07-19  Chris Dumez  <cdumez@apple.com>
1258
1259         Unreviewed attempt to fix API test failure after r219663.
1260
1261         The test was hard-coding an exception string and the string has changed slightly
1262         in r219663.
1263
1264         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1265         (TEST):
1266
1267 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
1268
1269         Don't write file URLs to iOS Pasteboard
1270         https://bugs.webkit.org/show_bug.cgi?id=174647
1271         <rdar://problem/33199730>
1272
1273         Reviewed by Wenson Hsieh.
1274
1275         Updating tests to reflect the lack of file URLs for images.
1276
1277         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1278         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
1279         (checkEstimatedSize):
1280         (TestWebKitAPI::TEST):
1281
1282 2017-07-19  Brady Eidson  <beidson@apple.com>
1283
1284         iBooks sometimes crashes when closing a book.
1285         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1286
1287         Reviewed by Oliver Hunt.
1288
1289         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1290         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1291         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1292         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1293         (TestWebKitAPI::TEST):
1294
1295         Add a "spin the runloop X number of times" utility:
1296         * TestWebKitAPI/Utilities.h:
1297         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1298         (TestWebKitAPI::Util::spinRunLoop):
1299
1300 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1301
1302         lint-test-expectations should be run during style checking
1303         https://bugs.webkit.org/show_bug.cgi?id=173559
1304         <rdar://problem/32854941>
1305
1306         Reviewed by David Kilzer.
1307
1308         Running the test expectation linter requires reading both files and lines not in the
1309         patch because, for example, deletion of a test can cause a lint failure even though
1310         no test expectations where modified. This means that the linter will occasionally warn
1311         about lines which were not changed in a given patch but whose error is related to a
1312         change made in that patch.
1313
1314         * Scripts/webkitpy/common/system/filesystem_mock.py:
1315         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1316         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1317         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1318         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1319         content, description of the error and the name of the associated test.
1320         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1321         (TestExpectationParser.__init__): Pass shorten_filename function to
1322         TestExpectationsParser to add a deleted file to the related_files dictionary.
1323         (TestExpectationParser._check_test_exists): If the test does not exist, add the
1324         missing path to the related_files dictionary.
1325         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1326         files and line numbers related to this test expectation line. This will allow
1327         tracking linter errors in the style checker occurring across multiple files.
1328         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1329         lines to related_files dictionary.
1330         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1331         (TestExpectations._report_warnings): Construct warning object instead of string
1332         when adding to warnings list.
1333         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1334         clean-up log.
1335         * Scripts/webkitpy/style/checker.py:
1336         (ProcessorBase.do_association_check): Add required function for processor classes.
1337         (StyleProcessor):
1338         (StyleProcessor.do_association_check): Run the TestExpectations linter when
1339         checking for errors between associated files.
1340         * Scripts/webkitpy/style/checkers/test_expectations.py:
1341         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1342         (TestExpectationsChecker):
1343         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1344         of modified files, the current working directory and the host, determine if the linter
1345         warning is associated with the changes.
1346         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1347         style checker.
1348         * Scripts/webkitpy/style/filereader.py:
1349         (TextFileReader):
1350         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1351         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1352         (TextFileReader.process_file): Track both the number of files changed and which lines
1353         in those files were changed.
1354         (TextFileReader.do_association_check): Run the processor's association check on all
1355         modified or deleted files processed by TextFileReader.
1356         (TextFileReader.delete_file): Track deleted files in _files dictionary.
1357         (TextFileReader.count_delete_only_file): Deleted.
1358         * Scripts/webkitpy/style/filereader_unittest.py:
1359         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1360         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1361         * Scripts/webkitpy/style/main.py:
1362         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1363         explicitly run the association check on the file reader.
1364         * Scripts/webkitpy/style/main_unittest.py:
1365         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1366         embedded in the style checker.
1367         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1368         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1369         construct the TextFileReader object with a StyleProcessor used to run style checks on
1370         specific files.
1371         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1372         testing the test expectation linter inside the style checker. This host must contain a
1373         mock file system with the basic structure of test expectations.
1374         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1375         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1376         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1377         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1378         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1379         * Scripts/webkitpy/style/patchreader.py:
1380         (PatchReader.check): Specify which file was deleted, run the association check.
1381         * Scripts/webkitpy/style/patchreader_unittest.py:
1382         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1383         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1384         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1385
1386 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1387
1388         [WTF] Implement WTF::ThreadGroup
1389         https://bugs.webkit.org/show_bug.cgi?id=174081
1390
1391         Reviewed by Mark Lam.
1392
1393         Add WTF::ThreadGroup tests.
1394
1395         * TestWebKitAPI/CMakeLists.txt:
1396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1397         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1398         (TestWebKitAPI::testThreadGroup):
1399         (TestWebKitAPI::TEST):
1400
1401 2017-07-18  Andy Estes  <aestes@apple.com>
1402
1403         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1404         https://bugs.webkit.org/show_bug.cgi?id=174631
1405
1406         Reviewed by Tim Horton.
1407
1408         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1409         * MiniBrowser/Configurations/Base.xcconfig:
1410         * MobileMiniBrowser/Configurations/Base.xcconfig:
1411         * TestWebKitAPI/Configurations/Base.xcconfig:
1412         * WebKitTestRunner/Configurations/Base.xcconfig:
1413
1414 2017-07-18  Andy Estes  <aestes@apple.com>
1415
1416         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1417         https://bugs.webkit.org/show_bug.cgi?id=174631
1418
1419         Reviewed by Sam Weinig.
1420
1421         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1422         * MiniBrowser/Configurations/Base.xcconfig:
1423         * MobileMiniBrowser/Configurations/Base.xcconfig:
1424         * TestWebKitAPI/Configurations/Base.xcconfig:
1425         * WebKitTestRunner/Configurations/Base.xcconfig:
1426
1427 2017-07-18  Daniel Bates  <dabates@apple.com>
1428
1429         lldb: Add type summary for StringView
1430         https://bugs.webkit.org/show_bug.cgi?id=174637
1431
1432         Reviewed by Sam Weinig.
1433
1434         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
1435         StringView object will print output that has the form:
1436
1437             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
1438               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
1439               m_length = 2
1440               m_is8Bit = true
1441               m_underlyingString = 0x0000614000000a90
1442             }
1443
1444         * lldb/lldb_webkit.py:
1445         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
1446         (WTFStringView_SummaryProvider):
1447         (WTFStringViewProvider):
1448         (WTFStringViewProvider.__init__):
1449         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
1450         (WTFStringViewProvider.get_length): Access field StringView.m_length.
1451         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
1452         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
1453
1454 2017-07-18  Andy Estes  <aestes@apple.com>
1455
1456         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1457         https://bugs.webkit.org/show_bug.cgi?id=174631
1458
1459         Reviewed by Dan Bernstein.
1460
1461         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1462         * MiniBrowser/Configurations/Base.xcconfig:
1463         * MobileMiniBrowser/Configurations/Base.xcconfig:
1464         * TestWebKitAPI/Configurations/Base.xcconfig:
1465         * WebKitTestRunner/Configurations/Base.xcconfig:
1466
1467 2017-07-18  Devin Rousso  <drousso@apple.com>
1468
1469         Web Inspector: Add memoryCost to Inspector Protocol objects
1470         https://bugs.webkit.org/show_bug.cgi?id=174478
1471
1472         Reviewed by Joseph Pecoraro.
1473
1474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1475         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
1476         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
1477         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
1478         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
1479         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
1480         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
1481         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
1482         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
1483         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
1484         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
1485         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
1486         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
1487         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
1488         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
1489         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
1490         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
1491
1492 2017-07-18  Andy Estes  <aestes@apple.com>
1493
1494         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1495         https://bugs.webkit.org/show_bug.cgi?id=174631
1496
1497         Reviewed by Darin Adler.
1498
1499         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1500         * MiniBrowser/Configurations/Base.xcconfig:
1501         * MobileMiniBrowser/Configurations/Base.xcconfig:
1502         * TestWebKitAPI/Configurations/Base.xcconfig:
1503         * WebKitTestRunner/Configurations/Base.xcconfig:
1504
1505 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1506
1507         Unreviewed, fix the iOS build.
1508
1509         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
1510
1511         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1512         (TestWebKitAPI::TEST):
1513
1514 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1515
1516         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
1517         https://bugs.webkit.org/show_bug.cgi?id=174585
1518         <rdar://problem/33302541>
1519
1520         Reviewed by Tim Horton.
1521
1522         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
1523         being dragged when initiating a drag.
1524
1525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1526         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
1527         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1528         (TestWebKitAPI::TEST):
1529         * TestWebKitAPI/cocoa/TestWKWebView.h:
1530
1531         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
1532
1533         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1534         (-[TestWKWebView synchronouslyLoadHTMLString:]):
1535
1536 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1537
1538         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
1539         https://bugs.webkit.org/show_bug.cgi?id=174547
1540
1541         Reviewed by Alex Christensen.
1542
1543         * DumpRenderTree/PlatformWin.cmake:
1544         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1545
1546 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1547
1548         Update style checker to deal with "final"
1549         https://bugs.webkit.org/show_bug.cgi?id=174528
1550
1551         Reviewed by Alex Christensen.
1552         
1553         check-webkit-style shouldn't complain about an open brace to start a
1554         line after a function definition with "final" or "const final".
1555
1556         * Scripts/webkitpy/style/checkers/cpp.py:
1557         (check_braces):
1558         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1559         (CppStyleTest.test_brace_at_begin_of_line):
1560
1561 2017-07-17  Alex Christensen  <achristensen@webkit.org>
1562
1563         Modernize content extension code
1564         https://bugs.webkit.org/show_bug.cgi?id=174588
1565
1566         Reviewed by Sam Weinig.
1567
1568         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1569         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1570         (TestWebKitAPI::testRequest):
1571         (TestWebKitAPI::makeBackend):
1572         (TestWebKitAPI::TEST_F):
1573
1574 2017-07-17  Brady Eidson  <beidson@apple.com>
1575
1576         WKHTTPCookieStore observing only works on the default cookie store.
1577         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
1578
1579         Reviewed by Sam Weinig.
1580
1581         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1582         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
1583           called for the default store, a non-persistent store, and a custom store.
1584         (TEST):
1585
1586 2017-07-16  Sam Weinig  <sam@webkit.org>
1587
1588         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
1589         https://bugs.webkit.org/show_bug.cgi?id=174575
1590
1591         Reviewed by Brady Eidson.
1592
1593         * Scripts/svn-create-patch:
1594         (findModificationType):
1595         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
1596         default value of "unknown".
1597
1598         (generateFileList):
1599         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
1600         for untracked, which matches our old behavior.
1601
1602 2017-07-17  Charlie Turner  <cturner@igalia.com>
1603
1604         Add some missing build dependencies on Fedora
1605         https://bugs.webkit.org/show_bug.cgi?id=174578
1606
1607         Unreviewed dependency update.
1608
1609         * gtk/install-dependencies:
1610
1611 2017-07-16  Brady Eidson  <beidson@apple.com>
1612
1613         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
1614         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
1615
1616         Reviewed by Tim Horton.
1617
1618         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1619         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
1620         (TEST):
1621
1622 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
1623
1624         [GTK] Sort inspector GResource manifest to ensure reproducible builds
1625         https://bugs.webkit.org/show_bug.cgi?id=174540
1626
1627         Reviewed by Michael Catanzaro.
1628
1629         * gtk/generate-inspector-gresource-manifest.py:
1630         (get_filenames): sort list of input files
1631
1632 2017-07-15  Brady Eidson  <beidson@apple.com>
1633
1634         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
1635         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
1636
1637         Reviewed by Tim Horton.
1638
1639         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1640         (TEST): Make this test more reliable by clearing everything beforehand.
1641
1642 2017-07-15  David Kilzer  <ddkilzer@apple.com>
1643
1644         Make it possible to extend check-webkit-style with Apple-internal checkers
1645         <https://webkit.org/b/174464>
1646         <rdar://problem/25564402>
1647
1648         Reviewed by Darin Adler.
1649
1650         * Scripts/webkitpy/style/checker.py: Import apple_additions.
1651         (_all_categories): Add categories from apple_additions() if it
1652         exists.
1653         (CheckerDispatcher._create_checker): Create python checker
1654         from apple_additions() if it exists.
1655
1656 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1657
1658         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
1659         https://bugs.webkit.org/show_bug.cgi?id=174539
1660         <rdar://problem/33307395>
1661
1662         Reviewed by Darin Adler.
1663
1664         Adds a new unit test suite to cover action sheet popover presentation.
1665
1666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1667         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
1668         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
1669         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
1670
1671         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
1672
1673         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
1674         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1675
1676         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
1677
1678         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1679         (TestWebKitAPI::TEST):
1680
1681 2017-07-15  Sam Weinig  <sam@webkit.org>
1682
1683         [Scripts] Make svn-create-patch work better when called in sub directories
1684         https://bugs.webkit.org/show_bug.cgi?id=174551
1685
1686         Reviewed by Darin Adler.
1687
1688         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
1689           by ensuring that the prefix is applied as is done in generateDiff.
1690         - Silence output of explanatory lines from svn stat (" > move to ...")
1691           that show up in STDERR when running svn-create-patch.
1692         - Add verbose logging that I found useful while debugging this issue.
1693
1694         * Scripts/svn-create-patch:
1695         (findBaseUrl):
1696         (findMimeType):
1697         (findSourceFileAndRevision):
1698         (generateDiff):
1699         (generateFileList):
1700         (manufacturePatchForAdditionWithHistory):
1701
1702 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
1703
1704         Unreviewed build fix after r219537.
1705
1706         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1707
1708 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1709
1710         Add iOS 11 SPI
1711         https://bugs.webkit.org/show_bug.cgi?id=174430
1712         <rdar://problem/33269288>
1713
1714         Reviewed by Tim Horton.
1715
1716         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
1717         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
1718         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
1719
1720 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1721
1722         Failing to install on iPad simulators
1723         https://bugs.webkit.org/show_bug.cgi?id=174532
1724         <rdar://problem/33328347>
1725
1726         Reviewed by Stephanie Lewis.
1727
1728         * Scripts/webkitpy/xcode/simulated_device.py:
1729         (SimulatedDevice.install_app): Place install command in retry try-except block.
1730
1731 2017-07-14  Jeff Miller  <jeffm@apple.com>
1732
1733         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1734         https://bugs.webkit.org/show_bug.cgi?id=174524
1735
1736         Reviewed by Sam Weinig.
1737
1738         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1739         (TEST):
1740         Renamed TestParameter to TestParameter1.
1741         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1742
1743         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1744         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1745         Observe changes for two bundle parameters.
1746
1747         (-[BundleParametersPlugIn dealloc]):
1748         Remove observers for two bundle parameters.
1749
1750 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1751
1752         Unreviewed, rolling out r219510.
1753         https://bugs.webkit.org/show_bug.cgi?id=174525
1754
1755         Need to revert length() == 0 check for null string (Requested
1756         by yusukesuzuki on #webkit).
1757
1758         Reverted changeset:
1759
1760         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1761         static string if StringImpl is static"
1762         https://bugs.webkit.org/show_bug.cgi?id=174501
1763         http://trac.webkit.org/changeset/219510
1764
1765 2017-07-14  Jer Noble  <jer.noble@apple.com>
1766
1767         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1768         https://bugs.webkit.org/show_bug.cgi?id=174514
1769
1770         Reviewed by Sam Weinig.
1771
1772         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1773         (TestWebKitAPI::TEST_F):
1774
1775 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1776
1777         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1778         https://bugs.webkit.org/show_bug.cgi?id=174501
1779
1780         Reviewed by Darin Adler.
1781
1782         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1783         (TestWebKitAPI::TEST):
1784
1785 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1786
1787         Bring mac expectations in-line with other platforms
1788         https://bugs.webkit.org/show_bug.cgi?id=174472
1789         <rdar://problem/33297388>
1790
1791         Reviewed by David Kilzer.
1792
1793         The override order for Mac test expectations does not conform to the pattern used by iOS,
1794         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1795
1796             platform/mac-wk2
1797             platform/wk2
1798             platform/mac-elcapitan
1799             platform/mac-sierra
1800             generic
1801
1802         After this change, El Capitan's baseline search path looks like this:
1803
1804             platform/mac-sierra-wk2
1805             platform/mac-sierra
1806             platform/mac-wk2
1807             platform/wk2
1808             generic
1809
1810         * Scripts/webkitpy/port/mac.py:
1811         (MacPort.__init__): If a specific version is specified in the port name, use that
1812         as the os version.
1813         (MacPort.default_baseline_search_path): Expectation search paths should work the
1814         same way they do on other ports. Port + version overrides port, port overrides generic
1815         and wk1/wk2 should override expectations for the two combined.
1816         * Scripts/webkitpy/port/mac_unittest.py:
1817         (MacTest.test_tests_for_other_platforms): Deleted.
1818         (MacTest._assert_search_path): Deleted.
1819         (MacTest.test_baseline_search_path): Deleted.
1820         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1821         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1822         (test_rebaseline_test_and_print_scm_changes): Ditto.
1823         (test_rebaseline_and_copy_test): Ditto.
1824         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1825         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1826         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1827
1828 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1829
1830         Fix style checker unit test
1831
1832         Unreviewed WebKit2 => WebKit fixup.
1833
1834         * Scripts/webkitpy/style/checker_unittest.py:
1835         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1836
1837 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1838
1839         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1840
1841         Unreviewed build fix.
1842
1843         r219492 missed one hunk from its partial revert of r219489.
1844         This patch reverts that hunk.
1845
1846         * TestWebKitAPI/CMakeLists.txt:
1847
1848 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1849
1850         Use the old WebKit/WebKit2 targets for CMake builds.
1851
1852         Unreviewed build fix.
1853
1854         We can update the target names to match the Framework names in a future patch.
1855         This is a partial revert of r219489.
1856
1857         * TestWebKitAPI/CMakeLists.txt:
1858         WebKitLegacy => WebKit
1859         WebKit => WebKit2
1860
1861 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1862
1863         Fix TestWebKit API.
1864         https://bugs.webkit.org/show_bug.cgi?id=174164
1865         rdar://problem/33137595
1866
1867         Reviewed by Dan Bernstein.
1868
1869         * TestWebKitAPI/CMakeLists.txt:
1870         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1871         * TestWebKitAPI/PlatformGTK.cmake:
1872
1873 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1874
1875         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1876         https://bugs.webkit.org/show_bug.cgi?id=174164
1877         rdar://problem/33137595
1878
1879         Reviewed by Dan Bernstein.
1880
1881         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1882         (ShouldBuildTest):
1883         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1884         * Scripts/build-webkit:
1885         * Scripts/do-file-rename:
1886         * Scripts/do-webcore-rename:
1887         * Scripts/update-webkit-localizable-strings:
1888         * Scripts/webkitpy/common/config/watchlist:
1889         * Scripts/webkitpy/style/checker.py:
1890         * Scripts/webkitpy/style/checkers/featuredefines.py:
1891         * gtk/make-dist.py:
1892         (ensure_version_if_possible):
1893         * gtk/manifest.txt.in:
1894
1895 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1896
1897         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1898         https://bugs.webkit.org/show_bug.cgi?id=174162
1899         rdar://problem/33137594
1900
1901         Reviewed by Dan Bernstein.
1902
1903         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
1904
1905         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1906         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1907         * EWSTools/configure-clang-linux.sh:
1908         * Scripts/build-webkit:
1909         * Scripts/do-file-rename:
1910         * Scripts/do-webcore-rename:
1911         * Scripts/update-webkit-localizable-strings:
1912         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1913         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1914         * Scripts/webkitpy/style/checkers/featuredefines.py:
1915         * gtk/manifest.txt.in:
1916
1917 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
1918
1919         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
1920         https://bugs.webkit.org/show_bug.cgi?id=174438
1921         <rdar://problem/33277112>
1922
1923         Reviewed by Aakash Jain.
1924
1925         Given a patch, this will convert the changes from the path to the new directory structure.
1926
1927         * Scripts/rebase-patch-after-webkit-move: Added.
1928         (append_source): Append 'Source' to the provided path.
1929         (is_editable_line): Return true if a line the script expects to modify.
1930         (needs_rebase): Return if a line needs to be rebased based on it's content.
1931         (rebase_line): Rebase the provided line.
1932         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
1933         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
1934         were provided.
1935
1936 2017-07-12  Nan Wang  <n_wang@apple.com>
1937
1938         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1939         https://bugs.webkit.org/show_bug.cgi?id=174393
1940         <rdar://problem/33248006>
1941
1942         Reviewed by Chris Fleizach.
1943
1944         * DumpRenderTree/AccessibilityUIElement.cpp:
1945         (textMarkerRangeMatchesTextNearMarkersCallback):
1946         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1947         (AccessibilityUIElement::getJSClass):
1948         * DumpRenderTree/AccessibilityUIElement.h:
1949         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1950         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1951         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1952         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1953         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1954         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1955         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1956         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1957
1958 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1959
1960         Unreviewed, rolling out r219409.
1961
1962         The revision caused the Windows builds to fail.
1963
1964         Reverted changeset:
1965
1966         "AX: [iOS] Implement a way to retrieve a text marker range
1967         with desired text that is closest to a position"
1968         https://bugs.webkit.org/show_bug.cgi?id=174393
1969         http://trac.webkit.org/changeset/219409
1970
1971 2017-07-12  Nan Wang  <n_wang@apple.com>
1972
1973         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1974         https://bugs.webkit.org/show_bug.cgi?id=174393
1975         <rdar://problem/33248006>
1976
1977         Reviewed by Chris Fleizach.
1978
1979         * DumpRenderTree/AccessibilityUIElement.cpp:
1980         (textMarkerRangeMatchesTextNearMarkersCallback):
1981         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1982         (AccessibilityUIElement::getJSClass):
1983         * DumpRenderTree/AccessibilityUIElement.h:
1984         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1985         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1986         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1987         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1988         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1989         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1990         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1991         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1992
1993 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
1994
1995         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
1996         https://bugs.webkit.org/show_bug.cgi?id=174197
1997
1998         Reviewed by Darin Adler.
1999
2000         This bit me the first time I tried to submit a patch to WebKit, and still I have
2001         to manually edit the ChangeLog every time I use the script.
2002
2003         This generates a more convenient and standard ChangeLog entry.
2004
2005         * Scripts/prepare-ChangeLog:
2006         (generateNewChangeLogs):
2007
2008 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2009
2010         Unreviewed, rolling out r219401.
2011
2012         This revision rolled out the previous patch, but after talking
2013         with reviewer, a rebaseline is what was needed.Rolling back in
2014         before rebaseline.
2015
2016         Reverted changeset:
2017
2018         "Unreviewed, rolling out r219379."
2019         https://bugs.webkit.org/show_bug.cgi?id=174400
2020         http://trac.webkit.org/changeset/219401
2021
2022 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2023
2024         Unreviewed, rolling out r219379.
2025
2026         This revision caused a consistent failure in the test
2027         fast/dom/Window/property-access-on-cached-window-after-frame-
2028         removed.html.
2029
2030         Reverted changeset:
2031
2032         "Remove NAVIGATOR_HWCONCURRENCY"
2033         https://bugs.webkit.org/show_bug.cgi?id=174400
2034         http://trac.webkit.org/changeset/219379
2035
2036 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2037
2038         [WPE] Use libepoxy
2039         https://bugs.webkit.org/show_bug.cgi?id=172104
2040
2041         Reviewed by Michael Catanzaro.
2042
2043         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
2044         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
2045
2046 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2047
2048         [GTK][WPE] Align Jhbuild patches for GStreamer packages
2049         https://bugs.webkit.org/show_bug.cgi?id=174363
2050
2051         Reviewed by Michael Catanzaro.
2052
2053         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
2054         between the GTK+ and WPE port. There's no reason for the two ports to apply
2055         different patches over same versions of GStreamer releases.
2056
2057         This aligns the two ports on this specific issue. Next we'll look into
2058         creating a single GStreamer-specific Jhbuild moduleset that will allow us
2059         to keep these patches in a single place, avoiding duplicate files.
2060
2061         * gtk/jhbuild.modules:
2062         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2063         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
2064         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2065         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
2066
2067 2017-07-11  Dean Jackson  <dino@apple.com>
2068
2069         Remove NAVIGATOR_HWCONCURRENCY
2070         https://bugs.webkit.org/show_bug.cgi?id=174400
2071
2072         Reviewed by Sam Weinig.
2073
2074         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2075
2076 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
2077
2078         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
2079         https://bugs.webkit.org/show_bug.cgi?id=174239
2080
2081         Reviewed by Brady Eidson.
2082
2083         Create windows with specific features set and make sure those are properly reflected in the
2084         WKWindowFeatures object.
2085
2086         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2087         (resetToConsistentState):
2088         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2089         (TEST):
2090
2091 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
2092
2093         Do not duplicate files when deleting directories with svn 1.9
2094         https://bugs.webkit.org/show_bug.cgi?id=174339
2095         <rdar://problem/33226781>
2096
2097         Reviewed by David Kilzer.
2098
2099         * Scripts/svn-create-patch:
2100         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
2101         (generateFileList): Determine which files are deleted because they are part of a
2102         directory being deleted.
2103
2104 2017-07-11  Dean Jackson  <dino@apple.com>
2105
2106         Rolling out r219372.
2107
2108         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2109
2110 2017-07-11  Dean Jackson  <dino@apple.com>
2111
2112         Remove NAVIGATOR_HWCONCURRENCY
2113         https://bugs.webkit.org/show_bug.cgi?id=174400
2114
2115         Reviewed by Sam Weinig.
2116
2117         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2118
2119 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2120
2121         Teach build workers to fetch archives from S3.
2122         https://bugs.webkit.org/show_bug.cgi?id=174384
2123
2124         Reviewed by Aakash Jain.
2125
2126         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2127         (DownloadBuiltProduct):
2128
2129 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2130
2131         Configure buildbot to transfer all archives to S3.
2132         Previously this was Mac only, but it's time to expand!
2133         https://bugs.webkit.org/show_bug.cgi?id=174378
2134         
2135         Reviewed by Aakash Jain.
2136
2137         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2138         (BuildFactory.__init__):
2139
2140 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
2141
2142         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
2143         https://bugs.webkit.org/show_bug.cgi?id=174350
2144
2145         Reviewed by Xabier Rodriguez-Calvar.
2146
2147         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
2148         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
2149         patches are removed. The patches for gst-plugins-good are updated, removing
2150         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
2151         rtpbin elements that will help with the EMEv3 development.
2152
2153         * wpe/jhbuild.modules:
2154         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2155         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2156         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
2157         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2158         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2159         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2160         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2161         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2162         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2163
2164 2017-07-10  John Wilander  <wilander@apple.com>
2165
2166         Resource Load Statistics: Prune statistics in orders of importance
2167         https://bugs.webkit.org/show_bug.cgi?id=174215
2168         <rdar://problem/33164403>
2169
2170         Reviewed by Chris Dumez.
2171
2172         Nest infrastructure. Adds these functions:
2173         1. testRunner.setStatisticsLastSeen()
2174         2. setStatisticsMaxStatisticsEntries()
2175         3. setStatisticsPruneEntriesDownTo()
2176
2177         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2178         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2179         (WTR::TestRunner::setStatisticsLastSeen):
2180         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2181         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2182         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2183         * WebKitTestRunner/TestController.cpp:
2184         (WTR::TestController::setStatisticsLastSeen):
2185         (WTR::TestController::setMaxStatisticsEntries):
2186         (WTR::TestController::setPruneEntriesDownTo):
2187         * WebKitTestRunner/TestController.h:
2188         * WebKitTestRunner/TestInvocation.cpp:
2189         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2190         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2191         (WTR::TestController::setStatisticsLastSeen):
2192         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2193         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2194
2195 2017-07-03  Brian Burg  <bburg@apple.com>
2196
2197         Web Replay: remove some unused code
2198         https://bugs.webkit.org/show_bug.cgi?id=173903
2199
2200         Rubber-stamped by Joseph Pecoraro.
2201
2202         * Scripts/run-input-generator-tests: Removed.
2203         * Scripts/webkitpy/replay/__init__.py: Removed.
2204         * Scripts/webkitpy/replay/main.py: Removed.
2205
2206 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
2207
2208         [WPE] Fix layout test baseline and TestExpectations hierarchy
2209         https://bugs.webkit.org/show_bug.cgi?id=174092
2210
2211         Reviewed by Michael Catanzaro.
2212
2213         Like for the GTK+ port, override the default_baseline_search_path() and
2214         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
2215         Both methods operate on a short list of search paths that defaults to 'wpe' and
2216         'wk2', along with any other user-specified platform directory.
2217
2218         The test_expectations_file_position() method is overridden for testing purposes,
2219         and relevant unit tests are added.
2220
2221         * Scripts/webkitpy/port/wpe.py:
2222         (WPEPort._search_paths):
2223         (WPEPort):
2224         (WPEPort.default_baseline_search_path):
2225         (WPEPort._port_specific_expectations_files):
2226         (WPEPort.test_expectations_file_position):
2227         * Scripts/webkitpy/port/wpe_unittest.py:
2228         (WPEPortTest.test_default_baseline_search_path):
2229         (WPEPortTest):
2230         (WPEPortTest.test_port_specific_expectations_files):
2231
2232 2017-07-10  Chris Dumez  <cdumez@apple.com>
2233
2234         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
2235         https://bugs.webkit.org/show_bug.cgi?id=174301
2236
2237         Reviewed by Brent Fulgham.
2238
2239         Rename some of the testRunner API for clarity and to better match what it calls
2240         internally.
2241
2242         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2243         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2244         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2245         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2246         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2247         * WebKitTestRunner/TestController.cpp:
2248         (WTR::TestController::statisticsUpdateCookiePartitioning):
2249         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2250         * WebKitTestRunner/TestController.h:
2251         * WebKitTestRunner/TestInvocation.cpp:
2252         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2253         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2254         (WTR::TestController::statisticsUpdateCookiePartitioning):
2255         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2256
2257 2017-07-10  Charlie Turner  <cturner@igalia.com>
2258
2259         [GStreamer] Live twitch.tv videos do not play
2260         https://bugs.webkit.org/show_bug.cgi?id=174222
2261
2262         Reviewed by Michael Catanzaro.
2263
2264         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
2265         fixes videos not playing on twitch.tv.
2266
2267         * gtk/jhbuild.modules:
2268
2269 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
2270
2271         Add WebGL2 configuration option to build-webkit
2272         https://bugs.webkit.org/show_bug.cgi?id=174251
2273
2274         Reviewed by Michael Catanzaro.
2275
2276         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
2277         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
2278         is marked as enabled for the Apple Cocoa ports.
2279
2280 2017-07-08  Chris Dumez  <cdumez@apple.com>
2281
2282         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
2283         https://bugs.webkit.org/show_bug.cgi?id=174290
2284
2285         Reviewed by Brent Fulgham.
2286
2287         Rename testRunner API to match the new internal API names.
2288
2289         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2290         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2291         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2292         (WTR::TestRunner::statisticsSubmitTelemetry):
2293         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2294         * WebKitTestRunner/TestController.cpp:
2295         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2296         (WTR::TestController::statisticsSubmitTelemetry):
2297         * WebKitTestRunner/TestController.h:
2298         * WebKitTestRunner/TestInvocation.cpp:
2299         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2300         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2301         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2302         (WTR::TestController::statisticsSubmitTelemetry):
2303
2304 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2305
2306         Drop NOSNIFF compile flag
2307         https://bugs.webkit.org/show_bug.cgi?id=174289
2308
2309         Reviewed by Michael Catanzaro.
2310
2311         * Scripts/webkitperl/FeatureList.pm:
2312         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2313
2314 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2315
2316         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2317         https://bugs.webkit.org/show_bug.cgi?id=174219
2318         <rdar://problem/32083177>
2319
2320         Reviewed by Ryosuke Niwa.
2321
2322         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2323         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2324         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2325         place.
2326
2327         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2328         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2329         no action is taken when dropping.
2330
2331         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2332         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2333         (TestWebKitAPI::TEST):
2334         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2335         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2336         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2337         (-[MockDragDropSession allowsMoveOperation]):
2338         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2339         (-[MockDataInteractionSession initWithWindow:allowMove:]):
2340         (-[DataInteractionSimulator initWithWebView:]):
2341         (-[DataInteractionSimulator runFrom:to:]):
2342         (-[DataInteractionSimulator _advanceProgress]):
2343         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2344         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2345         (-[MockDataInteractionSession initWithWindow:]): Deleted.
2346
2347 2017-07-07  Commit Queue  <commit-queue@webkit.org>
2348
2349         Unreviewed, rolling out r219238, r219239, and r219241.
2350         https://bugs.webkit.org/show_bug.cgi?id=174265
2351
2352         "fast/workers/dedicated-worker-lifecycle.html is flaky"
2353         (Requested by yusukesuzuki on #webkit).
2354
2355         Reverted changesets:
2356
2357         "[WTF] Implement WTF::ThreadGroup"
2358         https://bugs.webkit.org/show_bug.cgi?id=174081
2359         http://trac.webkit.org/changeset/219238
2360
2361         "Unreviewed, build fix after r219238"
2362         https://bugs.webkit.org/show_bug.cgi?id=174081
2363         http://trac.webkit.org/changeset/219239
2364
2365         "Unreviewed, CLoop build fix after r219238"
2366         https://bugs.webkit.org/show_bug.cgi?id=174081
2367         http://trac.webkit.org/changeset/219241
2368
2369 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2370
2371         [GTK][WPE] Enable X-Content-Type-Options: nosniff
2372         https://bugs.webkit.org/show_bug.cgi?id=174250
2373
2374         Reviewed by Carlos Alberto Lopez Perez.
2375
2376         * Scripts/webkitperl/FeatureList.pm:
2377
2378 2017-07-07  Charlie Turner  <cturner@igalia.com>
2379         [GStreamer] vid.me videos do not play
2380         https://bugs.webkit.org/show_bug.cgi?id=172240
2381
2382         Reviewed by Xabier Rodriguez-Calvar.
2383
2384         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2385         have the existing libsoup build against GNOME to avoid header drift
2386         against GStreamer's linked Soup library.
2387
2388         * gtk/jhbuild.modules:
2389
2390 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2391
2392         Write a support script to enable buildbot to upload to S3
2393         https://bugs.webkit.org/show_bug.cgi?id=174196
2394         
2395         Reviewed by Stephanie Lewis.
2396
2397         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2398         (uploadToS3):
2399         (archiveExists):
2400
2401 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2402
2403         Enabling uploading archives to S3.
2404         https://bugs.webkit.org/show_bug.cgi?id=174198
2405         
2406         Reviewed by Stephanie Lewis.
2407
2408         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2409         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2410         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2411         (TransferToS3): Transfer full and minified archives to S3
2412
2413 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2414
2415         [WTF] Implement WTF::ThreadGroup
2416         https://bugs.webkit.org/show_bug.cgi?id=174081
2417
2418         Reviewed by Mark Lam.
2419
2420         Add WTF::ThreadGroup tests.
2421
2422         * TestWebKitAPI/CMakeLists.txt:
2423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2424         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2425         (TestWebKitAPI::TEST):
2426
2427 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2428
2429         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2430         https://bugs.webkit.org/show_bug.cgi?id=174150
2431
2432         Reviewed by Mark Lam.
2433
2434         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2435         (TestWebKitAPI::TEST):
2436         * TestWebKitAPI/TestsController.cpp:
2437         (TestWebKitAPI::TestsController::TestsController):
2438
2439 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2440
2441         Enabling uploading archives to S3.
2442         https://bugs.webkit.org/show_bug.cgi?id=174198
2443         
2444         Reviewed by Lucas Forschler.
2445
2446         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2447         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2448         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2449         (TransferToS3): Transfer full and minified archives to S3
2450
2451 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2452
2453         [GTK][WPE] kill-old-process should kill more webkit related process
2454         https://bugs.webkit.org/show_bug.cgi?id=174220
2455
2456         Reviewed by Michael Catanzaro.
2457
2458         Generate list of possible webkit-related process names and add
2459         them to the list of process to kill.
2460         Also update the possible system related process for GTK+/WPE.
2461
2462         * BuildSlaveSupport/kill-old-processes:
2463         (listAllWebKitPrograms):
2464         (main):
2465
2466 2017-07-06  Chris Dumez  <cdumez@apple.com>
2467
2468         FileMonitor should not be ref counted
2469         https://bugs.webkit.org/show_bug.cgi?id=174166
2470
2471         Reviewed by Brent Fulgham.
2472
2473         Update the API tests to reflect the API change.
2474
2475         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2476         (TestWebKitAPI::TEST_F):
2477
2478 2017-07-06  Commit Queue  <commit-queue@webkit.org>
2479
2480         Unreviewed, rolling out r219194.
2481         https://bugs.webkit.org/show_bug.cgi?id=174207
2482
2483         it broke some layout tests (Requested by clopez on #webkit).
2484
2485         Reverted changeset:
2486
2487         "[GStreamer] vid.me videos do not play"
2488         https://bugs.webkit.org/show_bug.cgi?id=172240
2489         http://trac.webkit.org/changeset/219194
2490
2491 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2492
2493         Unreviewed, rolling out r219178.
2494
2495         This caused a consistent failure with the API test
2496         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2497
2498         Reverted changeset:
2499
2500         "[WTF] Clean up StringStatics.cpp by using
2501         LazyNeverDestroyed<> for Atoms"
2502         https://bugs.webkit.org/show_bug.cgi?id=174150
2503         http://trac.webkit.org/changeset/219178
2504
2505 2017-07-06  Alicia Boya García  <aboya@igalia.com>
2506
2507         Add CWD to Perl library path (no longer the default since 5.26.0)
2508         https://bugs.webkit.org/show_bug.cgi?id=174200
2509
2510         Reviewed by Michael Catanzaro.
2511
2512         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2513         (SetupGitClone._get_username_and_email):
2514
2515 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2516
2517         Unreviewed, update my email address.
2518
2519         * Scripts/webkitpy/common/config/contributors.json:
2520
2521 2017-07-06  Charlie Turner  <cturner@igalia.com>
2522         [GStreamer] vid.me videos do not play
2523         https://bugs.webkit.org/show_bug.cgi?id=172240
2524
2525         Reviewed by Xabier Rodriguez-Calvar.
2526
2527         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2528         have the existing libsoup build against GNOME to avoid header drift
2529         against GStreamer's linked Soup library.
2530
2531         * gtk/jhbuild.modules:
2532
2533 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2534
2535         [WTF] Move SoftLinking.h into WTF
2536         https://bugs.webkit.org/show_bug.cgi?id=174000
2537
2538         Reviewed by Alex Christensen.
2539
2540         * DumpRenderTree/mac/TestRunnerMac.mm:
2541         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2542         (test_primary_header):
2543         (ErrorCollector.__init__): Deleted.
2544         (ErrorCollector.__call__): Deleted.
2545         (ErrorCollector.results): Deleted.
2546         (ErrorCollector.result_list): Deleted.
2547         (ErrorCollector.verify_all_categories_are_seen): Deleted.
2548         (MockIo.open): Deleted.
2549         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
2550         (CppFunctionsTest.test_create_acronym): Deleted.
2551         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
2552         (CppFunctionsTest.test_parameter): Deleted.
2553         (CppFunctionsTest.test_single_line_view): Deleted.
2554         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
2555         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
2556         (CppFunctionsTest.test_parameter_list): Deleted.
2557         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
2558         (CppStyleTestBase.process_file_data): Deleted.
2559         (CppStyleTestBase.perform_lint): Deleted.
2560         (CppStyleTestBase.perform_single_line_lint): Deleted.
2561         (CppStyleTestBase.perform_multi_line_lint): Deleted.
2562         (CppStyleTestBase.perform_language_rules_check): Deleted.
2563         (CppStyleTestBase.perform_function_lengths_check): Deleted.
2564         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
2565         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
2566         (CppStyleTestBase.perform_include_what_you_use): Deleted.
2567         (CppStyleTestBase.perform_header_guard_check): Deleted.
2568         (CppStyleTestBase.assert_lint): Deleted.
2569         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
2570         (CppStyleTestBase.assert_multi_line_lint): Deleted.
2571         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
2572         (CppStyleTestBase.assert_language_rules_check): Deleted.
2573         (CppStyleTestBase.assert_include_what_you_use): Deleted.
2574         (CppStyleTestBase.assert_header_guard): Deleted.
2575         (CppStyleTestBase.assert_blank_lines_check): Deleted.
2576         (CppStyleTestBase.assert_positions_equal): Deleted.
2577         (FunctionDetectionTest.test_basic_function_detection): Deleted.
2578         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
2579         (FunctionDetectionTest.test_pure_function_detection): Deleted.
2580         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
2581         (FunctionDetectionTest.test_ignore_macros): Deleted.
2582         (FunctionDetectionTest.test_non_functions): Deleted.
2583         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
2584         (FunctionDetectionTest.test_parameter_list): Deleted.
2585         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
2586         (CppStyleTest.test_asm_lines_ignored): Deleted.
2587         (CppStyleTest.test_get_line_width): Deleted.
2588         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
2589         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
2590         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
2591         (CppStyleTest.test_position): Deleted.
2592         (CppStyleTest.test_rfind_in_lines): Deleted.
2593         (CppStyleTest.test_close_expression): Deleted.
2594         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
2595         (CppStyleTest.test_cstyle_cast): Deleted.
2596         (CppStyleTest.test_runtime_casting): Deleted.
2597         (CppStyleTest.test_runtime_selfinit): Deleted.
2598         (CppStyleTest.test_runtime_rtti): Deleted.
2599         (CppStyleTest.test_static_cast_readability): Deleted.
2600         (CppStyleTest.test_check_for_unnamed_params): Deleted.
2601         (CppStyleTest.void): Deleted.
2602         (CppStyleTest.test_deprecated_cast): Deleted.
2603         (CppStyleTest.test_mock_method): Deleted.
2604         (CppStyleTest.test_sizeof_type): Deleted.
2605         (CppStyleTest.cases): Deleted.
2606         (CppStyleTest.for): Deleted.
2607         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
2608         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
2609         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
2610         (CppStyleTest.test_include_what_you_use): Deleted.
2611         (CppStyleTest.test_files_belong_to_same_module): Deleted.
2612         (CppStyleTest.test_cleanse_line): Deleted.
2613         (CppStyleTest.test_multi_line_comments): Deleted.
2614         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
2615         (CppStyleTest.test_multiline_strings): Deleted.
2616         (CppStyleTest.test_platformh_comments): Deleted.
2617         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
2618         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
2619         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
2620         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
2621         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
2622         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
2623         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
2624         (CppStyleTest.test_check_posix_threading): Deleted.
2625         (CppStyleTest.test_insecure_string_operations): Deleted.
2626         (CppStyleTest.test_format_strings): Deleted.
2627         (CppStyleTest.test_insecure_temp_file): Deleted.
2628         (CppStyleTest.test_variable_length_array_detection): Deleted.
2629         (CppStyleTest.test_braces): Deleted.
2630         (CppStyleTest.test_check_check): Deleted.
2631         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
2632         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
2633         (CppStyleTest.test_spacing_for_fncall): Deleted.
2634         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
2635         (CppStyleTest.test_spacing_before_braces): Deleted.
2636         (CppStyleTest.test_spacing_between_braces): Deleted.
2637         (CppStyleTest.test_spacing_before_brackets): Deleted.
2638         (CppStyleTest.test_cpp_lambda_functions): Deleted.
2639         (CppStyleTest.test_objective_c_block): Deleted.
2640         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
2641         (CppStyleTest.test_spacing_around_else): Deleted.
2642         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
2643         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
2644         (CppStyleTest.test_operator_methods): Deleted.
2645         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
2646         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
2647         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
2648         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
2649         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
2650         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
2651         (CppStyleTest.test_space_after_comment_marker): Deleted.
2652         (CppStyleTest.test_newline_at_eof): Deleted.
2653         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
2654         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
2655         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
2656         (CppStyleTest.test_invalid_utf8): Deleted.
2657         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
2658         (CppStyleTest.test_is_blank_line): Deleted.
2659         (CppStyleTest.test_blank_lines_check): Deleted.
2660         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
2661         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
2662         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
2663         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
2664         (CppStyleTest.test_comma): Deleted.
2665         (CppStyleTest.test_declaration): Deleted.
2666         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
2667         (CppStyleTest.test_indent): Deleted.
2668         (CppStyleTest.test_indent.Foo): Deleted.
2669         (CppStyleTest.test_not_alabel): Deleted.
2670         (CppStyleTest.test_tab): Deleted.
2671         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
2672         (CppStyleTest.test_build_class): Deleted.
2673         (CppStyleTest.test_build_class.definitions): Deleted.
2674         (CppStyleTest.test_build_class.Foo): Deleted.
2675         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
2676         (CppStyleTest.test_build_end_comment): Deleted.
2677         (CppStyleTest.test_build_forward_decl): Deleted.
2678         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
2679         (CppStyleTest.test_build_header_guard): Deleted.
2680         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
2681         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
2682         (CppStyleTest.test_build_printf_format): Deleted.
2683         (CppStyleTest.test_runtime_printf_format): Deleted.
2684         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
2685         (CppStyleTest.test_build_storage_class): Deleted.
2686         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
2687         (CppStyleTest.test_build_storage_class.declaration): Deleted.
2688         (CppStyleTest.test_build_storage_class.after): Deleted.
2689         (CppStyleTest.test_build_storage_class.is): Deleted.
2690         (CppStyleTest.test_legal_copyright): Deleted.
2691         (CppStyleTest.test_invalid_increment): Deleted.
2692         (CppStyleTest.test_enum_bitfields): Deleted.
2693         (CppStyleTest.test_plain_integral_bitfields): Deleted.
2694         (CleansedLinesTest.test_init_empty): Deleted.
2695         (CleansedLinesTest.test_collapse_strings): Deleted.
2696         (OrderOfIncludesTest.tearDown): Deleted.
2697         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
2698         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
2699         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
2700         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
2701         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
2702         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
2703         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
2704         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
2705         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
2706         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
2707         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
2708         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
2709         (OrderOfIncludesTest.test_primary_header): Deleted.
2710         (OrderOfIncludesTest.test_public_primary_header): Deleted.
2711         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
2712         (OrderOfIncludesTest.test_classify_include): Deleted.
2713         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
2714         (CheckForFunctionLengthsTest.tearDown): Deleted.
2715         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
2716         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
2717         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
2718         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
2719         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
2720         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
2721         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
2722         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
2723         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
2724         (CheckForFunctionLengthsTest.function_body): Deleted.
2725         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
2726         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
2727         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
2728         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
2729         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
2730         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
2731         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
2732         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
2733         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
2734         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2735         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2736         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2737         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2738         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2739         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2740         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2741         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2742         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2743         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2744         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2745         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2746         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2747         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2748         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2749         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2750         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2751         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2752         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2753         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2754         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2755         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2756         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2757         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2758         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2759         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2760         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2761         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2762         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2763         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2764         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2765         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2766         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2767         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2768         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2769         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2770         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2771         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2772         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2773         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2774         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2775         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2776         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2777         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2778         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2779         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2780         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2781         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2782         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2783         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2784         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2785         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2786         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2787         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2788         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2789         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2790         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2791         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2792         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2793         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2794         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2795         (LeakyPatternTest.test_get_dc): Deleted.
2796         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2797         (LeakyPatternTest.test_own_get_dc): Deleted.
2798         (LeakyPatternTest.test_create_dc): Deleted.
2799         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2800         (WebKitStyleTest.test_indentation): Deleted.
2801         (WebKitStyleTest.test_indentation.Foo): Deleted.
2802         (WebKitStyleTest.test_indentation.Document): Deleted.
2803         (WebKitStyleTest.test_spacing): Deleted.
2804         (WebKitStyleTest.test_line_breaking): Deleted.
2805         (WebKitStyleTest.test_braces): Deleted.
2806         (WebKitStyleTest.test_braces.MyClass): Deleted.
2807         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2808         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2809         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2810         (WebKitStyleTest.test_null_false_zero): Deleted.
2811         (WebKitStyleTest.test_directive_indentation): Deleted.
2812         (WebKitStyleTest.test_using_std): Deleted.
2813         (WebKitStyleTest.test_using_namespace): Deleted.
2814         (WebKitStyleTest.test_max_macro): Deleted.
2815         (WebKitStyleTest.test_min_macro): Deleted.
2816         (WebKitStyleTest.test_wtf_move): Deleted.
2817         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2818         (WebKitStyleTest.test_names): Deleted.
2819         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2820         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2821         (WebKitStyleTest.test_names.declarations): Deleted.
2822         (WebKitStyleTest.test_names.struct): Deleted.
2823         (WebKitStyleTest.test_names.VectorType): Deleted.
2824         (WebKitStyleTest.test_parameter_names): Deleted.
2825         (WebKitStyleTest.test_comments): Deleted.
2826         (WebKitStyleTest.test_webkit_export_check): Deleted.
2827         (WebKitStyleTest.test_member_initialization_list): Deleted.
2828         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2829         (WebKitStyleTest.test_other): Deleted.
2830         (CppCheckerTest.mock_handle_style_error): Deleted.
2831         (CppCheckerTest._checker): Deleted.
2832         (CppCheckerTest.test_init): Deleted.
2833         (CppCheckerTest.test_eq): Deleted.
2834         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2835         (CppCheckerTest.test_ne): Deleted.
2836         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2837         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2838         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2839         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2840         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2841         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2842
2843 2017-07-05  Saam Barati  <sbarati@apple.com>
2844
2845         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2846         https://bugs.webkit.org/show_bug.cgi?id=174188
2847         <rdar://problem/30581423>
2848
2849         Reviewed by Mark Lam.
2850
2851         * Scripts/run-jsc-stress-tests:
2852
2853 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2854
2855         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2856         https://bugs.webkit.org/show_bug.cgi?id=174150
2857
2858         Reviewed by Mark Lam.
2859
2860         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2861         (TestWebKitAPI::TEST):
2862
2863 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2864
2865         Remove copy of ICU headers from WebKit
2866         https://bugs.webkit.org/show_bug.cgi?id=116407
2867
2868         Reviewed by Alex Christensen.
2869
2870         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2871         * TestWebKitAPI/Configurations/Base.xcconfig:
2872         * WebKitTestRunner/Configurations/Base.xcconfig:
2873
2874 2017-07-05  Chris Dumez  <cdumez@apple.com>
2875
2876         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2877         https://bugs.webkit.org/show_bug.cgi?id=174163
2878         <rdar://problem/33067518>
2879
2880         Reviewed by Alex Christensen.
2881
2882         Add API test coverage.
2883
2884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2885         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
2886         (TEST):
2887
2888 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2889
2890         When dragging a selection, clearing the selection in dragstart should not crash the web process
2891         https://bugs.webkit.org/show_bug.cgi?id=174142
2892         <rdar://problem/33067501>
2893
2894         Reviewed by Tim Horton.
2895
2896         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
2897         drag is starting up.
2898
2899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2900         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
2901         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2902         (TestWebKitAPI::TEST):
2903
2904 2017-07-05  Daniel Bates  <dabates@apple.com>
2905
2906         Do not pass API::FrameInfo for source frame or clear out page of target frame on
2907         API navigation
2908         https://bugs.webkit.org/show_bug.cgi?id=174170
2909         <rdar://problem/33140328>
2910
2911         Reviewed by Brady Eidson.
2912
2913         Update tests as needed for the behavior change.
2914
2915         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2916         (TEST):
2917
2918 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2919
2920         Add WebKitPrivateFrameworkStubs for iOS 11
2921         https://bugs.webkit.org/show_bug.cgi?id=173988
2922
2923         Reviewed by David Kilzer.
2924
2925         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
2926         should use the same directory for private framework stubs.
2927         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2928
2929 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
2930
2931         [MediaStream] Protect request and web view during gUM client callback
2932         https://bugs.webkit.org/show_bug.cgi?id=174096
2933         <rdar://problem/32833102>
2934
2935         Reviewed by Youenn Fablet.
2936
2937         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2938         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2939
2940 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2941
2942         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
2943
2944         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2945
2946 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2947
2948         Unreviewed, rolling out r219128.
2949
2950         Spoke with engineer who originally submitted, Patch for APi
2951         test to follow.
2952
2953         Reverted changeset:
2954
2955         "Unreviewed, rolling out r219070."
2956         https://bugs.webkit.org/show_bug.cgi?id=174082
2957         http://trac.webkit.org/changeset/219128
2958
2959 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2960
2961         Unreviewed, rolling out r219070.
2962
2963         This revision caused consistent failures of the API test
2964         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
2965
2966         Reverted changeset:
2967
2968         "Pasting single words copied to UIPasteboard inserts URLs in
2969         editable areas"
2970         https://bugs.webkit.org/show_bug.cgi?id=174082
2971         http://trac.webkit.org/changeset/219070
2972
2973 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2974
2975         Remove unused EFL logo from bot watcher dashboard
2976         https://bugs.webkit.org/show_bug.cgi?id=174136
2977
2978         Reviewed by Alexey Proskuryakov.
2979
2980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
2981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
2982
2983 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2984
2985         [GTK] Add more GTK bots to dashboard
2986         https://bugs.webkit.org/show_bug.cgi?id=174129
2987
2988         Reviewed by Carlos Alberto Lopez Perez.
2989
2990         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
2991         them.
2992
2993         This also changes the sort order to put WPE above GTK so that it's not buried under all the
2994         less-essential GTK bots.
2995
2996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2997         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2998         (WebKitBuildbot):
2999
3000 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3001
3002         [WPE] Add WPE to bot watcher dashboard
3003         https://bugs.webkit.org/show_bug.cgi?id=174119
3004
3005         Reviewed by Alexey Proskuryakov.
3006
3007         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
3008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
3009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
3010         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3011         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3012         (WebKitBuildbot):
3013         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3014         (table.queue-grid tr.platform.linux-wpe img.logo):
3015
3016 2017-07-03  Lucas Forschler  <lforschler@apple.com>
3017
3018         https://bugs.webkit.org/show_bug.cgi?id=174105
3019         
3020         Reviewed by Stephanie Lewis.
3021
3022         * BuildSlaveSupport/built-product-archive:
3023         (main): Add a -minify parser option
3024         (createZip): Pass along the optional Minify argument if requested
3025         (minifySource): This will trim down archives, logic limited to Mac platform.
3026
3027 2017-07-03  Matt Rajca  <mrajca@apple.com>
3028
3029         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
3030         https://bugs.webkit.org/show_bug.cgi?id=174103
3031
3032         Reviewed by Alex Christensen.
3033
3034         Added an API test.
3035
3036         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
3037         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3038         (TEST): Added test.
3039         * TestWebKitAPI/cocoa/TestWKWebView.h:
3040         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3041         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
3042
3043 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3044
3045         Unreviewed, rolling out r219103.
3046
3047         Caused multiple build failures.
3048
3049         Reverted changeset:
3050
3051         "Remove copy of ICU headers from WebKit"
3052         https://bugs.webkit.org/show_bug.cgi?id=116407
3053         http://trac.webkit.org/changeset/219103
3054
3055 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3056
3057         Remove copy of ICU headers from WebKit
3058         https://bugs.webkit.org/show_bug.cgi?id=116407
3059
3060         Reviewed by Alex Christensen.
3061
3062         Use WTF's copy of ICU headers.
3063
3064         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3065         * TestWebKitAPI/Configurations/Base.xcconfig:
3066         * WebKitTestRunner/Configurations/Base.xcconfig:
3067
3068 2017-07-03  Brady Eidson  <beidson@apple.com>
3069
3070         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3071         https://bugs.webkit.org/show_bug.cgi?id=174073
3072
3073         Reviewed by Andy Estes.
3074
3075         * DumpRenderTree/mac/TestRunnerMac.mm:
3076         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
3077
3078         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
3079         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3080
3081 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3082
3083         Unreviewed, rolling out r219083.
3084
3085         The revision caused an API failure on all testing platforms.
3086
3087         Reverted changeset:
3088
3089         "[MediaStream] Protect request and web view during gUM client
3090         callback"
3091         https://bugs.webkit.org/show_bug.cgi?id=174096
3092         http://trac.webkit.org/changeset/219083
3093
3094 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
3095
3096         webkitpy: Properly number duplicated crashlogs
3097         https://bugs.webkit.org/show_bug.cgi?id=172002
3098
3099         Reviewed by Aakash Jain.
3100
3101         * Scripts/webkitpy/common/system/crashlogs.py:
3102         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
3103         an increasing integer.
3104         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3105         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
3106         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
3107         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
3108
3109 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
3110
3111         WebContent processes crash when the network process crashes with pending connection requests
3112         https://bugs.webkit.org/show_bug.cgi?id=174065
3113         <rdar://problem/30359835>
3114
3115         Reviewed by Tim Horton.
3116
3117         Add a API to ensure UI process tries to relaunch a new network process when the network process
3118         crashes with pending network connection requests.
3119
3120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3121         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
3122         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3123         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3124         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
3125
3126 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
3127
3128         [MediaStream] Protect request and web view during gUM client callback
3129         https://bugs.webkit.org/show_bug.cgi?id=174096
3130         <rdar://problem/32833102>
3131
3132         Reviewed by Youenn Fablet.
3133
3134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3135         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3136
3137 2017-07-03  Andy Estes  <aestes@apple.com>
3138
3139         [Xcode] Add an experimental setting to build with ccache
3140         https://bugs.webkit.org/show_bug.cgi?id=173875
3141
3142         Reviewed by Tim Horton.
3143
3144         On systems that already have ccache(1) installed, this patch adds experimental support for
3145         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
3146
3147         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
3148         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
3149         find the toolchain from which to run clang, and then invokes ccache with the required
3150         arguments.
3151
3152         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
3153         precompiled headers to work properly [1].
3154
3155         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
3156         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
3157         during linking.
3158         
3159         [1] https://ccache.samba.org/manual.html#_precompiled_headers
3160
3161         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3162         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3163         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3164         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3165         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
3166         * ccache/README.md: Added.
3167         * ccache/ccache-clang: Added.
3168         * ccache/ccache-clang++: Added.
3169         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
3170
3171 2017-07-03  Alex Christensen  <achristensen@webkit.org>
3172
3173         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3174         https://bugs.webkit.org/show_bug.cgi?id=174051
3175
3176         Reviewed by Tim Horton.
3177
3178         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3179         (TestWebKitAPI::TEST_F):
3180
3181 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3182
3183         Unreviewed, rolling out r219024.
3184
3185         This patch cause 3 didferent test to fail.
3186
3187         Reverted changeset:
3188
3189         "REGRESSION(r215096) Queries of URLs with non-special schemes
3190         should not percent-encode single quotes"
3191         https://bugs.webkit.org/show_bug.cgi?id=174051
3192         http://trac.webkit.org/changeset/219024
3193
3194 2017-07-03  Chris Dumez  <cdumez@apple.com>
3195
3196         Drop ResourceLoadStatisticsStore's statisticsLock
3197         https://bugs.webkit.org/show_bug.cgi?id=174080
3198
3199         Reviewed by Brent Fulgham.
3200
3201         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
3202
3203         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3204         (WTR::TestController::isStatisticsPrevalentResource):
3205         (WTR::TestController::isStatisticsHasHadUserInteraction):
3206         (WTR::TestController::isStatisticsGrandfathered):
3207
3208 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3209
3210         Pasting single words copied to UIPasteboard inserts URLs in editable areas
3211         https://bugs.webkit.org/show_bug.cgi?id=174082
3212         <rdar://problem/33046992>
3213
3214         Reviewed by Tim Horton.
3215
3216         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
3217
3218         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3219         (TestWebKitAPI::setUpWebViewForPasteboardTests):
3220         (TestWebKitAPI::TEST):
3221
3222 2017-07-02  Brady Eidson  <beidson@apple.com>
3223
3224         Add API test for all parts of WebKit1 API related to favicons.
3225         https://bugs.webkit.org/show_bug.cgi?id=174069
3226
3227         Reviewed by Andy Estes.
3228
3229         These two API tests cover all WebKit1 API related to icons.
3230         
3231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3232         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
3233         (mainResourceData):
3234         (defaultFaviconData):
3235         (customFaviconData):
3236         (imageFromData):
3237         (+[IconLoadingProtocol canInitWithRequest:]):
3238         (+[IconLoadingProtocol canonicalRequestForRequest:]):
3239         (-[IconLoadingProtocol startLoading]):
3240         (-[IconLoadingProtocol stopLoading]):
3241         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3242         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3243         (TestWebKitAPI::TEST):
3244
3245 2017-07-01  Dan Bernstein  <mitz@apple.com>
3246
3247         [iOS] Remove code only needed when building for iOS 9.x
3248         https://bugs.webkit.org/show_bug.cgi?id=174068
3249
3250         Reviewed by Tim Horton.
3251
3252         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3253         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3254         (WTR::initializeWebViewConfiguration):
3255         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3256         (-[HIDEventGenerator _createIOHIDEventType:]):
3257
3258 2017-07-01  Brady Eidson  <beidson@apple.com>
3259
3260         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
3261         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
3262
3263         Reviewed by Alex Christensen.
3264
3265         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3266
3267 2017-07-01  Dan Bernstein  <mitz@apple.com>
3268
3269         [macOS] Remove code only needed when building for OS X Yosemite
3270         https://bugs.webkit.org/show_bug.cgi?id=174067
3271
3272         Reviewed by Tim Horton.
3273
3274         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3275         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3276         * DumpRenderTree/mac/DumpRenderTree.mm:
3277         (setDefaultsToConsistentValuesForTesting):
3278         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3279         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3280         * MiniBrowser/Configurations/Base.xcconfig:
3281         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3282         * TestWebKitAPI/Configurations/Base.xcconfig:
3283         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3284         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3285         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3286         (TestWebKitAPI::TEST_F):
3287         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3288         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3289         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3290         (TestWebKitAPI::TEST_F):
3291         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3292         (TestWebKitAPI::TEST):
3293         * WebKitTestRunner/Configurations/Base.xcconfig:
3294         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3295         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3296         (WTR::InjectedBundle::platformInitialize):
3297         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3298         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3299
3300 2017-07-01  Chris Dumez  <cdumez@apple.com>
3301
3302         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
3303         https://bugs.webkit.org/show_bug.cgi?id=174060
3304
3305         Reviewed by Brent Fulgham.
3306
3307         Port WebKitTestRunner over to the new Cocoa SPI.
3308
3309         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3310         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3311         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3312         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
3313         no-ops since this code runs in the WebContent process, not the
3314         UIProcess.
3315
3316         * WebKitTestRunner/TestController.cpp:
3317         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3318
3319 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3320
3321         Unreviewed mac build fix.
3322
3323         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3324         (TestWebKitAPI::TEST):
3325
3326 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3327
3328         Add API to get WKActivatedElementInfo
3329         https://bugs.webkit.org/show_bug.cgi?id=174001
3330         <rdar://problem/29165518>
3331         
3332         Tests for now SPI to get activatedElementInfo.
3333
3334         Reviewed by Tim Horton.
3335
3336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3337         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
3338         (TestWebKitAPI::TEST):
3339
3340 2017-06-30  Chris Dumez  <cdumez@apple.com>
3341
3342         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
3343         https://bugs.webkit.org/show_bug.cgi?id=174038
3344
3345         Reviewed by Brent Fulgham.
3346
3347         Fix typo in API name.
3348
3349         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3350         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3351         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3352         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3353         * WebKitTestRunner/TestController.cpp:
3354         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3355         * WebKitTestRunner/TestController.h:
3356         * WebKitTestRunner/TestInvocation.cpp:
3357         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3358
3359 2017-06-30  Alex Christensen  <achristensen@webkit.org>
3360
3361         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3362         https://bugs.webkit.org/show_bug.cgi?id=174051
3363         <rdar://problem/33002846>
3364
3365         Reviewed by Tim Horton.
3366
3367         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3368         (TestWebKitAPI::TEST_F):
3369
3370 2017-06-30  Daniel Bates  <dabates@apple.com>
3371
3372         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3373         https://bugs.webkit.org/show_bug.cgi?id=165160
3374         <rdar://problem/29451999>
3375
3376         Reviewed by Brady Eidson.
3377
3378         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
3379         for navigations and window creation.
3380
3381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3382         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
3383         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3384         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
3385         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3386         (TEST):
3387
3388 2017-06-29  Jer Noble  <jer.noble@apple.com>
3389
3390         Make Legacy EME API controlled by RuntimeEnabled setting.
3391         https://bugs.webkit.org/show_bug.cgi?id=173994
3392
3393         Reviewed by Sam Weinig.
3394
3395         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3396
3397 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3398
3399         Follow-up fix for r218996
3400
3401         Unreviewed infrastructure fix.
3402
3403         Repeated calls to 'ios_version' make the log noisy, memoize the function.
3404
3405         * Scripts/webkitpy/port/ios_simulator.py:
3406         (IOSSimulatorPort): Memoize ios_version().
3407
3408 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3409
3410         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3411         https://bugs.webkit.org/show_bug.cgi?id=174017
3412         <rdar://problem/32959782>
3413
3414         Reviewed by Simon Fraser.
3415
3416         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
3417         changes, the caret would appear outside of the iframe.
3418
3419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3420         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
3421         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3422         (checkDragCaretRectIsContainedInRect):
3423         (TestWebKitAPI::TEST):
3424         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3425         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3426         (-[DataInteractionSimulator _resetSimulatedState]):
3427         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3428         (-[DataInteractionSimulator _advanceProgress]):
3429         (-[DataInteractionSimulator lastKnownDragCaretRect]):
3430
3431 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3432
3433         Add support for different versions of iOS when loading test expectations
3434         https://bugs.webkit.org/show_bug.cgi?id=173774
3435         <rdar://problem/32951132>
3436
3437         Rubber-stamped by Aakash Jain.
3438
3439         When running layout tests, we should support multiple version of iOS the same way we do Mac.
3440
3441         * Scripts/webkitpy/port/ios.py:
3442         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
3443         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
3444         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
3445         * Scripts/webkitpy/port/ios_device.py:
3446         (IOSDevicePort.ios_version): Ask connected devices for implementation.
3447         * Scripts/webkitpy/port/ios_device_unittest.py:
3448         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
3449         (IOSDeviceTest.test_baseline_searchpath): Ditto.
3450         (IOSDeviceTest.test_expectations_ordering): Ditto.
3451         * Scripts/webkitpy/port/ios_simulator.py:
3452         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
3453         ask the platform.
3454
3455 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
3456
3457         Fontconfig build breaks with glibc 2.15+
3458         https://bugs.webkit.org/show_bug.cgi?id=174019
3459
3460         Reviewed by Carlos Alberto Lopez Perez.
3461
3462         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
3463
3464         * wpe/jhbuild.modules:
3465         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
3466
3467 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3468
3469         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
3470         https://bugs.webkit.org/show_bug.cgi?id=174010
3471         <rdar://problem/32597802>
3472
3473         Reviewed by Tim Horton.
3474
3475         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
3476         snapshot fails for any reason.
3477
3478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3479         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
3480         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3481         (TestWebKitAPI::TEST):
3482
3483 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
3484
3485         AX: Cannot call setValue() on contenteditable or ARIA text controls
3486         https://bugs.webkit.org/show_bug.cgi?id=173520
3487
3488         Reviewed by Ryosuke Niwa.
3489
3490         Add setValue() method to WKTR (already existed in DRT).
3491
3492         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3493         (WTR::AccessibilityUIElement::setValue):
3494         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3495         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3496         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3497         (WTR::AccessibilityUIElement::setValue):
3498
3499 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
3500
3501         getBoundingClientRect returns wrong value for combination of page zoom and scroll
3502         https://bugs.webkit.org/show_bug.cgi?id=173841
3503         rdar://problem/32983841
3504
3505         Reviewed by Dean Jackson.
3506
3507         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
3508         always did text zooming.
3509
3510         * MiniBrowser/mac/WK1BrowserWindowController.m:
3511         (-[WK1BrowserWindowController zoomIn:]):
3512         (-[WK1BrowserWindowController zoomOut:]):
3513         (-[WK1BrowserWindowController canResetZoom]):
3514         (-[WK1BrowserWindowController resetZoom:]):
3515
3516 2017-06-29  John Wilander  <wilander@apple.com>
3517
3518         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
3519         https://bugs.webkit.org/show_bug.cgi?id=173940
3520         <rdar://problem/33018125>
3521
3522         Reviewed by Brent Fulgham.
3523
3524         This change allows the TestController to turn off
3525         regular resource load statistics telemetry submission
3526         and to manually control when telemetry is calculated
3527         and submitted.
3528
3529         * WebKitTestRunner/TestController.cpp:
3530         (WTR::TestController::initialize):
3531             Turns off automatic resource load statistics telemetry submission.
3532
3533 2017-06-29  Commit Queue  <commit-queue@webkit.org>
3534
3535         Unreviewed, rolling out r218512.
3536         https://bugs.webkit.org/show_bug.cgi?id=173981
3537
3538         "It changes the behavior of the JS API's JSEvaluateScript
3539         which breaks TurboTax" (Requested by saamyjoon on #webkit).
3540
3541         Reverted changeset:
3542
3543         "test262: Completion values for control flow do not match the
3544         spec"
3545         https://bugs.webkit.org/show_bug.cgi?id=171265
3546         http://trac.webkit.org/changeset/218512
3547
3548 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
3549
3550         Add WebKitSystemInterface for iOS 11
3551         https://bugs.webkit.org/show_bug.cgi?id=173936
3552
3553         Reviewed by Lucas Forschler.
3554
3555         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
3556
3557 2017-06-28  Keith Miller  <keith_miller@apple.com>
3558
3559         VMTraps has some races
3560         https://bugs.webkit.org/show_bug.cgi?id=173941
3561
3562         Reviewed by Michael Saboff.
3563
3564         Add new testing mode for testing the Watchdog with our stress
3565         tests.
3566
3567         * Scripts/run-jsc-stress-tests:
3568
3569 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3570
3571         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
3572         https://bugs.webkit.org/show_bug.cgi?id=173877
3573
3574         Reviewed by Brady Eidson.
3575
3576         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
3577         the next tests.
3578
3579         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3580         (testGetFavicon):
3581
3582 2017-06-28  Tim Horton  <timothy_horton@apple.com>
3583
3584         MobileSafari was constantly using 10-15% CPU viewing a PDF
3585         https://bugs.webkit.org/show_bug.cgi?id=173944
3586         <rdar://problem/33039910>
3587
3588         Reviewed by Simon Fraser.
3589
3590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3591         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
3592         Add a test that we ever call the stable presentation update callback
3593         when we have a WKPDFView up, instead of infinitely looping.
3594
3595 2017-06-28  Alex Christensen  <achristensen@webkit.org>