Tools/ChangeLog

   1 2012-06-27  Sergio Villar Senin  <svillar@igalia.com>
   2
   3         [WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
   4         https://bugs.webkit.org/show_bug.cgi?id=90061
   5
   6         Reviewed by Gustavo Noronha Silva.
   7
   8         Add "-no-install -no-fast-install" to the LDFLAGS in bots. With
   9         this flag libtool tells the linker to set the rpath for the output
  10         file to the full path of the .libs directory, instead of using a
  11         wrapper script to set up the LD_LIBRARY_PATH. This will allow us
  12         to directly reuse builds in the pure testing bots.
  13
  14         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
  15
  16 2012-06-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
  17
  18         [Qt] No need to save and restore TEMPLATE in a function
  19
  20         This was a leftover from when the logic was not in its own function scope.
  21
  22         QMAKE_FRAMEWORK_BUNDLE_NAME on the other hand is exported in qtLibraryTarget, which
  23         will surprisingly affect the global scope as well, so we have to save and restore it.
  24
  25         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
  26
  27         Reviewed by Tor Arne Vestbø.
  28
  29         * qmake/mkspecs/features/functions.prf:
  30
  31 2012-06-27  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
  32
  33         [Qt] Fix lookup location for sqlite sources
  34
  35         Don't look in the install dir - we are unlikely to find anything there
  36         unless we are doing a developer build.
  37
  38         Reviewed by Tor Arne Vestbø.
  39
  40         * qmake/mkspecs/features/features.prf:
  41
  42 2012-06-27  Zan Dobersek  <zandobersek@gmail.com>
  43
  44         [Gtk] Add support for the Gamepad API
  45         https://bugs.webkit.org/show_bug.cgi?id=87503
  46
  47         Reviewed by Carlos Garcia Campos.
  48
  49         Enable the gamepad support for the GTK port.
  50
  51         * Scripts/webkitperl/FeatureList.pm:
  52
  53 2012-06-27  Ryosuke Niwa  <rniwa@webkit.org>
  54
  55         Fix gcc build after r121302
  56         https://bugs.webkit.org/show_bug.cgi?id=90055
  57
  58         Reviewed by Mark Rowe.
  59
  60         Assume RTTI is always disabled so that gtest builds on XCode 3.2.6.
  61
  62         It appears that gcc doesn't like window.get().* inside a template so replace that by [window.get() *] instead.
  63
  64         * TestWebKitAPI/Configurations/Base.xcconfig:
  65         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
  66         (TestWebKitAPI::AcceptsFirstMouse::runTest):
  67
  68 2012-06-27  Csaba Osztrogonác  <ossy@webkit.org>
  69
  70         Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
  71         https://bugs.webkit.org/show_bug.cgi?id=89564
  72
  73         Reviewed by Tony Chang.
  74
  75         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
  76         (BuildStepsConstructorTest):
  77         (BuildStepsConstructorTest.generateTests):
  78         (BuildStepsConstructorTest.createTest):
  79         (BuildStepsConstructorTest.createTest.doTest):
  80
  81 2012-06-26  Mark Hahnenberg  <mhahnenberg@apple.com>
  82
  83         Add support for preciseTime() to WebKitTestRunner
  84         https://bugs.webkit.org/show_bug.cgi?id=90027
  85
  86         Reviewed by Darin Adler.
  87
  88         It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
  89
  90         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  91         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  92         (WTR::LayoutTestController::preciseTime):
  93         (WTR):
  94         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  95         (LayoutTestController):
  96
  97 2012-06-26  Lucas Forschler  <lforschler@apple.com>
  98
  99       Teach the Apple port how to build the test tools in build-webkit
 100       https://bugs.webkit.org/show_bug.cgi?id=89540
 101
 102       Reviewed by Jon Lee & Simon Fraser.
 103
 104       * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 105       (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive
 106       (RunUnitTests.start): ditto
 107       * Scripts/build-webkit: add tools to the projects build list
 108
 109 2012-06-26  Ojan Vafai  <ojan@chromium.org>
 110
 111         Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
 112         https://bugs.webkit.org/show_bug.cgi?id=90025
 113
 114         Reviewed by Simon Fraser.
 115
 116         Move the chromium-specific filtering code into config.js and replace it with a method on each platform
 117         config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).
 118
 119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
 120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
 121         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
 122
 123 2012-06-26  Ojan Vafai  <ojan@chromium.org>
 124
 125         Fix failing garden-o-matic unittests
 126         https://bugs.webkit.org/show_bug.cgi?id=90021
 127
 128         Reviewed by Adam Barth.
 129
 130         These had all just fallen out of date.
 131
 132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
 133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
 134         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
 135
 136 2012-06-26  Ojan Vafai  <ojan@chromium.org>
 137
 138         Fix platform picker change handler in garden-o-matic
 139         https://bugs.webkit.org/show_bug.cgi?id=90010
 140
 141         Reviewed by Simon Fraser.
 142
 143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
 144         The old code never worked. This is hard to test because change handlers require
 145         a user-initiated action and the code is changing the window's location, which would
 146         navigate the test page.
 147
 148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
 149         Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
 150         due to the large margin-bottom.
 151
 152 2012-06-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
 153
 154         webkitpy: Make webkit-patch patches-to-review useful
 155         https://bugs.webkit.org/show_bug.cgi?id=89470
 156
 157         Reviewed by Eric Seidel.
 158
 159         webkit-patch patches-to-review will now output the list of
 160         bugs with patches pending for review that has the user on CC,
 161         excluding patches with cq-, sorted by the age of the patch.
 162
 163         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 164         (BugzillaQueries.fetch_bugs_from_review_queue):
 165         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
 166         (MockBugzillaQueries.fetch_bugs_from_review_queue):
 167         (MockBugzilla.__init__):
 168         (MockBugzilla.authenticate):
 169         * Scripts/webkitpy/tool/commands/queries.py:
 170         (PatchesToReview):
 171         (PatchesToReview.__init__):
 172         (PatchesToReview._print_report):
 173         (PatchesToReview._generate_report):
 174         (PatchesToReview.execute):
 175         * Scripts/webkitpy/tool/commands/queries_unittest.py:
 176         (QueryCommandsTest.test_patches_to_review):
 177
 178 2012-06-26  Dirk Pranke  <dpranke@chromium.org>
 179
 180         nrwt: broken for chromium on vista
 181         https://bugs.webkit.org/show_bug.cgi?id=89988
 182
 183         Reviewed by Tony Chang.
 184
 185         r121194 removed support for 'chromium-win-vista' as a separate
 186         port, but this actually prevented the code from running on vista
 187         at all, which is unduly harsh and broke the websocket tests on
 188         the (non-webkit) chromium bots that are still running on vista.
 189
 190         It's probably good enough to pretend that vista is win7 instead;
 191         some layout tests will still fail but at least things'll run.
 192
 193         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 194         (ChromiumWinPort.determine_full_port_name):
 195         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
 196         (ChromiumWinTest.test_versions):
 197
 198 2012-06-26  Csaba Osztrogonác  <ossy@webkit.org>
 199
 200         master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
 201         https://bugs.webkit.org/show_bug.cgi?id=89215
 202
 203         We need it because it is deprecated and will be dropped in buildbot 0.8.7
 204
 205         Reviewed by Tony Chang.
 206
 207         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 208         (CheckOutSource.__init__):
 209         (Factory.__init__):
 210
 211 2012-06-26  Simon Hausmann  <simon.hausmann@nokia.com>
 212
 213         [Qt][Win] Symbols are not exported in QtWebKit5.dll
 214         https://bugs.webkit.org/show_bug.cgi?id=88873
 215
 216         Reviewed by Tor Arne Vestbø.
 217
 218         When linking the target dll make sure to re-export the symbols from
 219         the static libraries marked as export, with the help of a little python
 220         script and a qmake extra compiler.
 221
 222         * Scripts/generate-win32-export-forwards: Added.
 223         * qmake/mkspecs/features/win32/default_post.prf:
 224
 225 2012-06-25  Jocelyn Turcotte  <turcotte.j@gmail.com>
 226
 227         Add a note about hostname completion not working well with --cc completion
 228
 229         Reviewed by Simon Hausmann.
 230
 231         Hostname completion tries to resolve anything after an @ sign which is present
 232         in the completed list of contributor emails to CC.
 233
 234         * Scripts/webkit-tools-completion.sh:
 235
 236 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
 237
 238         Unreviewed, rolling out r121244.
 239         http://trac.webkit.org/changeset/121244
 240         https://bugs.webkit.org/show_bug.cgi?id=89966
 241
 242         skip list path is incorrect now. (Requested by Ossy on
 243         #webkit).
 244
 245         * Scripts/webkitpy/layout_tests/port/qt.py:
 246         (QtPort.baseline_search_path):
 247         (QtPort._skipped_file_search_paths):
 248         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
 249         (QtPortTest.test_baseline_search_path):
 250
 251 2012-06-26  János Badics  <jbadics@inf.u-szeged.hu>
 252
 253         [Qt][NRWT] Fix baseline and skipped file search path.
 254         https://bugs.webkit.org/show_bug.cgi?id=89882
 255
 256         Reviewed by Csaba Osztrogonác.
 257
 258         * Scripts/webkitpy/layout_tests/port/qt.py:
 259         (QtPort.baseline_search_path):
 260         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
 261         (QtPortTest.test_baseline_search_path):
 262
 263 2012-06-26  Tony Chang  <tony@chromium.org>
 264
 265         [Qt] Enable grid layout LayoutTests
 266         https://bugs.webkit.org/show_bug.cgi?id=89909
 267
 268         Reviewed by Csaba Osztrogonác.
 269
 270         These tests pass, we just need to hook up the overridePreference.
 271
 272         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 273         (WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.
 274         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 275         (LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.
 276
 277 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
 278
 279         Unreviewed, rolling out r121236.
 280         http://trac.webkit.org/changeset/121236
 281         https://bugs.webkit.org/show_bug.cgi?id=89956
 282
 283         It's broke the nrwt on qt and gtk platform (Requested by
 284         kkristof on #webkit).
 285
 286         * Scripts/webkitpy/layout_tests/port/qt.py:
 287         (QtPort._build_driver):
 288         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
 289         (XvfbDriver._start):
 290         (XvfbDriver._start.x_filter):
 291         (XvfbDriver.stop):
 292
 293 2012-06-26  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
 294
 295         [NRWT] XvfbDriver should choose the next free display
 296         https://bugs.webkit.org/show_bug.cgi?id=88414
 297
 298         Reviewed by Dirk Pranke.
 299
 300         * Scripts/webkitpy/layout_tests/port/qt.py:
 301         (QtPort._driver_class):
 302         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
 303         (XvfbDriver.__init__):
 304         (XvfbDriver._start):
 305         (XvfbDriver._start.next_free_id):
 306         (XvfbDriver.stop):
 307
 308 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
 309
 310         [Qt] Make it possible to build WebKit without QtWidgets
 311         https://bugs.webkit.org/show_bug.cgi?id=78109
 312
 313         Reviewed by Tor Arne Vestbø.
 314
 315         * Tools.pro: Disable various tools that depend on WK1.
 316         * qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT
 317         * qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built.
 318         * qmake/mkspecs/modules/webkit1.prf: Added.
 319
 320 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
 321
 322         put vista back for chromium (non-webkit) bots ...
 323         https://bugs.webkit.org/show_bug.cgi?id=89929
 324
 325         Unreviewed, build fix.
 326
 327         Turns out we've only gotten rid of vista on the webkit tests so
 328         far. Put vista back for the other chromium bots ...
 329
 330         * TestResultServer/static-dashboards/flakiness_dashboard.js:
 331         (chromiumPlatform):
 332         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
 333         (test):
 334
 335 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
 336
 337         update flakiness dashboard after removing chromium-vista bots
 338         https://bugs.webkit.org/show_bug.cgi?id=89925
 339
 340         Unreviewed, build fix.
 341
 342         More changes missed in r121194 :(.
 343
 344         * TestResultServer/static-dashboards/flakiness_dashboard.js:
 345         (chromiumPlatform):
 346         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
 347         (test):
 348
 349 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
 350
 351         remove support for chromium vista from tools
 352         https://bugs.webkit.org/show_bug.cgi?id=89915
 353
 354         Reviewed by Tony Chang.
 355
 356         This change is all deleting code and updating tests to handle
 357         the configuration being gone. All tests now pass except for a
 358         few unittests for the flakiness dashboard which were failing
 359         before this patch.
 360
 361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
 362         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
 363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
 364         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
 365         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
 366         (BaselineOptimizerTest.test_complex_shadowing):
 367         * Scripts/webkitpy/layout_tests/port/builders.py:
 368         * Scripts/webkitpy/layout_tests/port/chromium.py:
 369         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 370         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 371         (ChromiumWinPort):
 372         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
 373         (ChromiumWinTest.test_versions):
 374         (ChromiumWinTest.test_baseline_path):
 375         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 376         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
 377         (BuildCoverageExtrapolatorTest.test_extrapolate):
 378
 379 2012-06-25  Scott Graham  <scottmg@chromium.org>
 380
 381         [Chromium] add empty impl of WebThemeEngine::getSize() for DRT
 382         https://bugs.webkit.org/show_bug.cgi?id=89907
 383
 384         Not reviewed. Fix build in Chromium.
 385
 386         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
 387         (WebThemeEngineDRTWin::getSize):
 388         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
 389         (WebThemeEngineDRTWin):
 390
 391 2012-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 392
 393         [EFL] Implement Network Information API
 394         https://bugs.webkit.org/show_bug.cgi?id=87067
 395
 396         Reviewed by Kenneth Rohde Christiansen.
 397
 398         * efl/jhbuild.modules: Add eeze library dependency.
 399
 400 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
 401
 402         [Qt] Fix Win32 debug build
 403
 404         Reviewed by Tor Arne Vestbø.
 405
 406         Consolidate use_all_in_one_files into mac/unix/win32 default_pre.prf.
 407
 408         * qmake/mkspecs/features/unix/default_pre.prf:
 409         * qmake/mkspecs/features/win32/default_pre.prf: Added.
 410
 411 2012-06-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
 412
 413         [Qt] Enable <input type="color"> support by default
 414         https://bugs.webkit.org/show_bug.cgi?id=89653
 415
 416         Reviewed by Kenneth Rohde Christiansen.
 417
 418         This feature is complete for Qt WebKit2. Enabling by default
 419         will help to mature the implementation.
 420
 421         * Scripts/webkitperl/FeatureList.pm:
 422         * qmake/mkspecs/features/features.pri:
 423
 424 2012-06-24  Dan Bernstein  <mitz@apple.com>
 425
 426         Made debug-{minibrowser,safari,test-runner} work with LLDB.
 427
 428         Reviewed by Sam Weinig.
 429
 430         * Scripts/debug-minibrowser: Pass INCLUDE_OPTIONS_FOR_DEBUGGING to
 431         printHelpAndExitForRunAndDebugWebKitAppIfNeeded().
 432         * Scripts/debug-safari: Ditto.
 433         * Scripts/debug-test-runner: Ditto.
 434         * Scripts/webkitdirs.pm:
 435         (debugger): Added. Calls determineDebugger() if needed and returns the chosen debugger.
 436         (determineDebugger): Added. Sets the debugger to "lldb" if the --use-lldb switch is present,
 437         and to "gdb" otherwise.
 438         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Changed to print help for the
 439         --target-web-process and --use-lldb switches if passed INCLUDE_OPTIONS_FOR_DEBUGGING.
 440         (execMacWebKitAppForDebugging): Changed to use the chosen debugger.
 441
 442 2012-06-24  Adam Barth  <abarth@webkit.org>
 443
 444         [Chromium] Release media resources after each LayoutTest on Android
 445         https://bugs.webkit.org/show_bug.cgi?id=89720
 446
 447         Reviewed by Eric Carlson.
 448
 449         The LayoutTests can hang when run on Android because we sometimes run
 450         out of media resources. This patch causes us to release our media
 451         resources after each test in order to avoid running out of this
 452         resource. In production, there are other mechanisms that manage this
 453         resource.
 454
 455         * DumpRenderTree/chromium/TestShell.cpp:
 456         (TestShell::resetTestController):
 457
 458 2012-06-23  Zan Dobersek  <zandobersek@gmail.com>
 459
 460         [Gtk] REGRESSION(r120918): Causes flaky DND tests
 461         https://bugs.webkit.org/show_bug.cgi?id=89770
 462
 463         Reviewed by Martin Robinson.
 464
 465         Connect to the run-file-chooser signal of the WebKitWebView and
 466         return TRUE so no file chooser dialog is run. This prevents certain
 467         test failures.
 468
 469         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 470         (webViewRunFileChooser):
 471         (createWebView):
 472
 473 2012-06-23  Dan Bernstein  <mitz@apple.com>
 474
 475         debug-{minibrowser,safari,test-runner} fail when gdb is not installed in /usr/bin.
 476
 477         Reviewed by Sam Weinig.
 478
 479         * Scripts/webkitdirs.pm:
 480         (execMacWebKitAppForDebugging): Use xcrun to locate gdb.
 481
 482 2012-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
 483
 484         Unreviewed. Skip GTK+ unit test /webkit2/WebKitFindController/hide.
 485
 486         It fails always when running it in Xvfb.
 487
 488         * gtk/run-api-tests:
 489         (TestRunner):
 490
 491 2012-06-23  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>
 492
 493         [GTK][WK2]Mis-spelt defaultWindowTitle
 494         https://bugs.webkit.org/show_bug.cgi?id=89808
 495
 496         Reviewed by Carlos Garcia Campos.
 497
 498         * MiniBrowser/gtk/BrowserWindow.c:
 499
 500 2012-06-23  Sergio Villar Senin  <svillar@igalia.com>
 501
 502         [GTK] Add a new webkit2 tests slave bot
 503         https://bugs.webkit.org/show_bug.cgi?id=89336
 504
 505         Reviewed by Csaba Osztrogonác.
 506
 507         Slave configuration for a new GTK 64 bit release bot that will run
 508         WebKit2 tests.
 509
 510         Also BuildAndTest now accepts the "triggers" parametter,
 511         this means that apart from building and testing it can trigger
 512         some other build/test sequences in other slaves.
 513
 514         * BuildSlaveSupport/build.webkit.org-config/config.json:
 515         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 516         (BuildAndTestFactory.__init__):
 517
 518 2012-06-23  Kwang Yul Seo  <skyul@company100.net>
 519
 520         Unreviewed. Update my email.
 521
 522         * Scripts/webkitpy/common/config/committers.py:
 523
 524 2012-06-22  Adam Barth  <abarth@webkit.org>
 525
 526         [Chromium] DumpRenderTree on Android needs to configure fonts for testing
 527         https://bugs.webkit.org/show_bug.cgi?id=89721
 528
 529         Reviewed by Nate Chapin.
 530
 531         This patch teaches DumpRenderTree to configure Skia to use the fallback
 532         fonts that the LayoutTests assume. This patch reduces the number result
 533         differences between chromium-android and chromium-linux.
 534
 535         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
 536         * DumpRenderTree/chromium/TestShellAndroid.cpp:
 537         (platformInit):
 538         * DumpRenderTree/chromium/android_fallback_fonts.xml: Added.
 539         * DumpRenderTree/chromium/android_main_fonts.xml: Added.
 540         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
 541
 542 2012-06-22  Alexandru Chiculita  <achicu@adobe.com>
 543
 544         [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
 545         https://bugs.webkit.org/show_bug.cgi?id=89781
 546
 547         Reviewed by Dean Jackson.
 548
 549         Added CSS Shaders as enabled by default on Safari for Mac.
 550
 551         * Scripts/webkitperl/FeatureList.pm:
 552
 553 2012-06-22  Adam Barth  <abarth@webkit.org>
 554
 555         Add support for test_expectations_android.txt for overriding test expecations on the chromium-android branch
 556         https://bugs.webkit.org/show_bug.cgi?id=89791
 557
 558         Reviewed by Dirk Pranke.
 559
 560         Downstream, the chromium-android port maintains a test expectations
 561         file to keep track of which tests pass or fail. That causes them to
 562         keep a patch in chromium_android.py in their branch.
 563
 564         This patch teaches chromium_android.py to use test_expectations_android.txt.
 565         We don't intend to use this file upstream, but having this code patch
 566         upstream lets us unfork webkitpy.
 567
 568         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
 569         (ChromiumAndroidPort.expectations_files):
 570
 571 2012-06-22  Dirk Pranke  <dpranke@chromium.org>
 572
 573         run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'')
 574         https://bugs.webkit.org/show_bug.cgi?id=89734
 575
 576         Reviewed by Ryosuke Niwa.
 577
 578         Fix a crash in ServerProcess if you called .pid() after it
 579         crashed during a write(). We had a test for this case but the
 580         test wasn't calling pid(), just has_crashed(). Fixed the problem
 581         and the test.
 582
 583         * Scripts/webkitpy/layout_tests/port/server_process.py:
 584         (ServerProcess.__init__):
 585         (ServerProcess.pid):
 586         (ServerProcess._start):
 587         (ServerProcess.stop):
 588         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
 589         (FakeServerProcess._start):
 590         (TestServerProcess.test_broken_pipe):
 591
 592 2012-06-22  Peter Beverloo  <peter@chromium.org>
 593
 594         [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
 595         https://bugs.webkit.org/show_bug.cgi?id=88853
 596
 597         Reviewed by Steve Block.
 598
 599         The Android exclusions were necessary to fix a gyp generation error, as
 600         the gcc_version variable wasn't being defined for Android. Remove these
 601         exceptions when Chromium is able to define the gcc_version variable.
 602
 603         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
 604
 605 2012-06-22  Mario Sanchez Prada  <msanchez@igalia.com>
 606
 607         Unreviewed gardening. Unskipping test passing after fixing bug 88419.
 608
 609         * gtk/run-api-tests:
 610         (TestRunner): Unskip WTF.HashMap.
 611
 612 2012-06-22  Zoltan Horvath  <zoltan@webkit.org>
 613
 614         [Qt] Allow DumpRenderTree to dump about:blank
 615         https://bugs.webkit.org/show_bug.cgi?id=89685
 616
 617         Reviewed by Ryosuke Niwa.
 618
 619         We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports,
 620         additionaly this behavior is required for running WTR performance tests.
 621
 622         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 623         (WebCore::DumpRenderTree::processLine):
 624
 625 2012-06-21  Adam Barth  <abarth@webkit.org>
 626
 627         [Chromium] Reset mediaPlaybackRequiresUserGesture WebSettings after each test
 628         https://bugs.webkit.org/show_bug.cgi?id=89718
 629
 630         Reviewed by Kent Tamura.
 631
 632         We should reset this WebSetting to its default value so that it behaves
 633         consistently across tests.
 634
 635         * DumpRenderTree/chromium/WebPreferences.cpp:
 636         (WebPreferences::reset):
 637         (WebPreferences::applyTo):
 638         * DumpRenderTree/chromium/WebPreferences.h:
 639         (WebPreferences):
 640
 641 2012-06-21  Zoltan Horvath  <zoltan@webkit.org>
 642
 643         DRT/WTR python interface handles about:blank incorrectly
 644         https://bugs.webkit.org/show_bug.cgi?id=89563
 645
 646         Reviewed by Dirk Pranke.
 647
 648         Currently DRT/WTR python interface's _command_from_driver_input function
 649         puts the test directory path before about:blank. Remove this incorrect behavior.
 650
 651         * Scripts/webkitpy/layout_tests/port/webkit.py:
 652         (WebKitDriver._command_from_driver_input):
 653
 654 2012-06-21  Dirk Pranke  <dpranke@chromium.org>
 655
 656         reenable perf tests on win
 657         https://bugs.webkit.org/show_bug.cgi?id=89690
 658
 659         Reviewed by Ryosuke Niwa.
 660
 661         Only the replay tests don't work, and those are disabled by
 662         default. This change also fixes the undefined _log reference
 663         that was causing a crash.
 664
 665         * Scripts/run-perf-tests:
 666
 667 2012-06-21  Sheriff Bot  <webkit.review.bot@gmail.com>
 668
 669         Unreviewed, rolling out r120937.
 670         http://trac.webkit.org/changeset/120937
 671         https://bugs.webkit.org/show_bug.cgi?id=89679
 672
 673         This patch brought buildbot master down (Requested by svillar
 674         on #webkit).
 675
 676         * BuildSlaveSupport/build.webkit.org-config/config.json:
 677
 678 2012-06-21  Martin Robinson  <mrobinson@igalia.com>
 679
 680         [GTK] Combine WebKit API tests into fewer binaries
 681         https://bugs.webkit.org/show_bug.cgi?id=88458
 682
 683         Reviewed by Carlos Garcia Campos.
 684
 685         Instead of creating one binary per-test file, create binaries for each
 686         category of tests. Right now this includes WTF and the WebKit2 C API,
 687         but later tests can be added for the GTK+ platform layer and the WebKit1
 688         and WebKit2 API layers.
 689
 690         * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2
 691           C API and one for WTF. Refresh the source list to ensure that new test are active.
 692         * gtk/run-api-tests: Change the way that tests are skipped by splitting out the
 693         concept of skipping a test and skipping a suite (program) of tests. Test cases are
 694         skipped because of legitimate failures, but entire programs are skipped because of
 695         problems in the harness. As of right now a test program is only skipped if the
 696         accessibility bus cannot be started.
 697         (SkippedTest.__init__): Make the test case a required argument and have one skipped
 698         test case per SkippedTest instance.
 699         (SkippedTest.__str__): Ditto.
 700         (TestRunner): Update the directory list. We only have two gtest binaries now and they are
 701         in one directory. Reformat the test list to make it slightly easier to read.
 702         (TestRunner.__init__): Add the _skipped_test_program member, which handles entire
 703         test programs that are skipped.
 704         (TestRunner._setup_testing_environment): Use the new member.
 705         (TestRunner._test_cases_to_skip): Collect all skipped test cases now instead of just
 706         the first SkippedTest that matches.
 707         (TestRunner._should_run_test_program): Take a look at the new member to make this
 708         decision.
 709         (TestRunner._run_test_command): Use the name test_program instead of test
 710         to disambiguate between test cases and test suites.
 711         (TestRunner._run_test_glib): ditto.
 712         (TestRunner._run_test_google): Ditto.
 713         (TestRunner._run_test): Ditto.
 714         (TestRunner.run_tests): Ditto.
 715
 716 2012-06-21  Yong Li  <yoli@rim.com>
 717
 718         Unreviewed. Moving myself from committer to reviewer.
 719
 720         * Scripts/webkitpy/common/config/committers.py:
 721
 722 2012-06-21  Sergio Villar Senin  <svillar@igalia.com>
 723
 724         [GTK] Add a new webkit2 tests slave bot
 725         https://bugs.webkit.org/show_bug.cgi?id=89336
 726
 727         Reviewed by Philippe Normand.
 728
 729         Slave configuration for a new GTK bot that will run WebKit2 tests.
 730
 731         * BuildSlaveSupport/build.webkit.org-config/config.json:
 732
 733 2012-06-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
 734
 735         [Qt] Add a custom Color Chooser widget to MiniBrowser
 736         https://bugs.webkit.org/show_bug.cgi?id=87988
 737
 738         Reviewed by Alexis Menard.
 739
 740         Added custom color chooser example for the MiniBrowser.
 741
 742         * MiniBrowser/qt/MiniBrowser.qrc:
 743         * MiniBrowser/qt/qml/BrowserWindow.qml:
 744         * MiniBrowser/qt/qml/ColorChooser.qml: Added.
 745
 746 2012-06-21  Vivek Galatage  <vivekgalatage@gmail.com>
 747
 748         Remove the warning "File not found" in MiniBrowser post-build event
 749         https://bugs.webkit.org/show_bug.cgi?id=89601
 750
 751         Reviewed by Adam Roben.
 752
 753         * MiniBrowser/MiniBrowserPostBuild.cmd:
 754
 755 2012-06-21  Balazs Kelemen  <kbalazs@webkit.org>
 756
 757         [Qt] DRT in standalone mode hangs after the first test
 758         https://bugs.webkit.org/show_bug.cgi?id=89613
 759
 760         Reviewed by Csaba Osztrogonác.
 761
 762         Break an inline signal slot chain that ends up in setting
 763         LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
 764         we emit done() which starts the chain that finishes in DumpRenderTree::open().
 765         The next line in maybeDump sets m_hasDumped to true. We could simply reorder
 766         these two lines but it seems to be wrong in general to start the next load
 767         from this call chain. The server mode (when DRT is runned by the test harness)
 768         also uses a queued connection to read the next test from stdin.
 769
 770         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 771         (WebCore::DumpRenderTree::processArgsLine):
 772
 773 2012-06-20  Hans Wennborg  <hans@chromium.org>
 774
 775         Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more
 776         https://bugs.webkit.org/show_bug.cgi?id=89217
 777
 778         Reviewed by Adam Barth.
 779
 780         Add a method for checking whether the mock speech
 781         recognition was aborted.
 782
 783         Also redo the way the mock posts tasks. Instead of posting them all at once,
 784         maintain an internal queue of task objects, and call postTask() for them
 785         once at the time. This means that for example when the page is navigated
 786         away and abort() is called, that call doesn't end up after a bunch
 787         of previously posted events on the event loop.
 788
 789         * DumpRenderTree/chromium/LayoutTestController.cpp:
 790         (LayoutTestController::LayoutTestController):
 791         (LayoutTestController::wasMockSpeechRecognitionAborted):
 792         * DumpRenderTree/chromium/LayoutTestController.h:
 793         (LayoutTestController):
 794         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
 795         (WebKit::ClientCallTask::ClientCallTask):
 796         (WebKit::ResultTask::ResultTask):
 797         (WebKit::NoMatchTask::NoMatchTask):
 798         (WebKit::ErrorTask::ErrorTask):
 799         (MockWebSpeechRecognizer::start):
 800         (MockWebSpeechRecognizer::abort):
 801         (MockWebSpeechRecognizer::setError):
 802         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
 803         (MockWebSpeechRecognizer::startTaskQueue):
 804         (MockWebSpeechRecognizer::StepTask::runIfValid):
 805         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
 806         (MockWebSpeechRecognizer::hasBeenAborted):
 807         (MockWebSpeechRecognizer):
 808         (MockWebSpeechRecognizer::taskList):
 809         (Task):
 810         (MockWebSpeechRecognizer::Task::Task):
 811         (MockWebSpeechRecognizer::Task::~Task):
 812         (StepTask):
 813         (MockWebSpeechRecognizer::StepTask::StepTask):
 814
 815 2012-06-21  Mario Sanchez Prada  <msanchez@igalia.com>
 816
 817         [GTK] Add support for window.showModalDialog in WebKit2GTK+
 818         https://bugs.webkit.org/show_bug.cgi?id=79500
 819
 820         Reviewed by Carlos Garcia Campos.
 821
 822         Add support for modal dialogs in GTK's MiniBrowser.
 823
 824         * MiniBrowser/gtk/BrowserWindow.c:
 825         (webViewRunAsModal):
 826         (webViewCreate):
 827         (webViewDecidePolicy):
 828         (browser_window_new):
 829         * MiniBrowser/gtk/BrowserWindow.h:
 830         * MiniBrowser/gtk/main.c:
 831         (createBrowserWindow):
 832
 833 2012-06-20  Brent Fulgham  <bfulgham@webkit.org>
 834
 835         [WinCairo] Unreviewed build fix.
 836         The wrapper script that launched new- and old-run-webkit-tests
 837         was discarding the --wincairo argument needed to get the proper
 838         test infrastructure to build under WinCairo.
 839
 840         * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
 841         behavior to chain the --wincairo flag through to the new build
 842         and test scripts.
 843
 844 2012-06-20  Mark Rowe  <mrowe@apple.com>
 845
 846         <http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
 847
 848         Reviewed by Dan Bernstein.
 849
 850         * Scripts/webkitdirs.pm:
 851         (executableHasEntitlements):
 852         (safariPathFromSafariBundle):
 853
 854 2012-06-20  Sheriff Bot  <webkit.review.bot@gmail.com>
 855
 856         Unreviewed, rolling out r120821.
 857         http://trac.webkit.org/changeset/120821
 858         https://bugs.webkit.org/show_bug.cgi?id=89605
 859
 860         It made duplicated reviewer entries (Requested by Ossy on
 861         #webkit).
 862
 863         * Scripts/webkitpy/common/checkout/changelog.py:
 864         (ChangeLog.set_reviewer):
 865         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
 866         (test_set_reviewer):
 867         (test_set_short_description_and_bug_url):
 868
 869 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
 870
 871         nrwt outputs empty files for wdiff output if wdiff is not installed
 872         https://bugs.webkit.org/show_bug.cgi?id=88709
 873
 874         Reviewed by Tony Chang.
 875
 876         Reviewed by Tony Chang.
 877
 878         Don't write -wdiff or -pretty.html files if wdiff or prettypatch
 879         aren't available, and clean up the handling for them in the port
 880         code.
 881
 882         * Scripts/webkitpy/run_webkit_tests_integrationtest.py:
 883         (MainTest.test_output_diffs):
 884         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
 885         (TestResultWriter.create_text_diff_and_write_result):
 886         * Scripts/webkitpy/layout_tests/port/base.py:
 887         (Port.check_pretty_patch):
 888         (Port.check_wdiff):
 889         (Port._wdiff_missing_message):
 890         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 891         (ChromiumLinuxPort.check_build):
 892         (ChromiumLinuxPort._wdiff_missing_message):
 893         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 894         (ChromiumMacPort.check_build):
 895         (ChromiumMacPort):
 896         (ChromiumMacPort._wdiff_missing_message):
 897         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
 898         (ChromiumMacPortTest):
 899
 900 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
 901
 902         nrwt: fix unit tests for ensuring svn revision is correct
 903         https://bugs.webkit.org/show_bug.cgi?id=89498
 904
 905         Reviewed by Eric Seidel.
 906
 907         Reviewed by Eric Seidel.
 908
 909         Fix the unit tests for testing that we are embedding the SVN
 910         revision in the results json for NRWT properly; this was broken
 911         in r120646 but because the MockHost worked differently than the
 912         real one (by always initializing the MockSCM object) we didn't
 913         notice. Unfortunately, just changing the default breaks all
 914         sorts of unit tests ...
 915
 916         * Scripts/webkitpy/common/host_mock.py:
 917         (MockHost.__init__):
 918         (MockHost._initialize_scm):
 919         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
 920         (ResultSummaryTest.test_no_svn_revision):
 921         (ResultSummaryTest.test_svn_revision):
 922
 923 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
 924
 925         new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
 926         https://bugs.webkit.org/show_bug.cgi?id=69360
 927
 928         Reviewed by Eric Seidel.
 929
 930         Reviewed by Eric Seidel.
 931
 932         Propagate the 'port_implementation' part of the platform (i.e.,
 933         gtk,qt,chromium) to webkit-build-directory so that we can pick
 934         up the gtk-specific handling of WEBKITOUTPUTDIR ...
 935
 936         I didn't write any additional tests for this; testing it
 937         properly is an integration test between the python code and the
 938         perl code, which I verified by hand.
 939
 940         * Scripts/webkitpy/layout_tests/port/base.py:
 941         (Port.__init__):
 942         * Scripts/webkitpy/layout_tests/port/config.py:
 943         (Config.__init__):
 944         (Config.build_directory):
 945         * Scripts/webkitpy/layout_tests/port/config_mock.py:
 946         (MockConfig.__init__):
 947         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
 948         (ConfigTest.test_build_directory_passes_port_implementation):
 949
 950 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
 951
 952         Fix import sorting missed in r120846
 953
 954         Reviewed by Tony Chang.
 955
 956         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
 957
 958 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
 959
 960         Fix chromium win http servers after breakage introduced in r120846.
 961
 962         Unreviewed, build fix.
 963
 964         * Scripts/webkitpy/layout_tests/port/base.py:
 965         (Port.to.start_http_server):
 966         * Scripts/webkitpy/layout_tests/servers/http_server.py:
 967         (Lighttpd.__init__):
 968
 969 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
 970
 971         tweak output of webkit-patch print-{baselines,expectations}
 972         https://bugs.webkit.org/show_bug.cgi?id=89588
 973
 974         Reviewed by Tony Chang.
 975
 976         Minor tweaks to the output to make it more readable, including
 977         turning off csv by default for print-baselines with multiple ports.
 978
 979         * Scripts/webkitpy/layout_tests/port/test.py:
 980         (TestPort):
 981         * Scripts/webkitpy/tool/commands/queries.py:
 982         (PrintExpectations.execute):
 983         (PrintBaselines.execute):
 984         * Scripts/webkitpy/tool/commands/queries_unittest.py:
 985         (PrintExpectationsTest.run_test):
 986         (PrintExpectationsTest.test_multiple):
 987         (PrintBaselinesTest.setUp):
 988         (PrintBaselinesTest.test_multiple):
 989
 990 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
 991
 992         new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
 993         https://bugs.webkit.org/show_bug.cgi?id=88134
 994
 995         Reviewed by Tony Chang.
 996
 997         Change NRWT to spin up 2*min(child_processes, locked_shards)
 998         http servers by default so that we are less likely to get a
 999         bunch of http timeouts at the beginning of a test run.
1000
1001         Note that I had to tweak executive_mock to support mocked stderr
1002         because the apache_http_server code reads stderr when starting a
1003         process to ensure it started okay.
1004
1005         * Scripts/webkitpy/common/system/executive_mock.py:
1006         (MockProcess.__init__):
1007         * Scripts/webkitpy/common/system/outputcapture.py:
1008         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1009         (Manager._run_tests):
1010         (Manager.start_servers_with_lock):
1011         * Scripts/webkitpy/layout_tests/port/base.py:
1012         (Port.to.start_http_server):
1013         * Scripts/webkitpy/layout_tests/port/test.py:
1014         (TestPort.start_http_server):
1015         (TestPort._path_to_apache):
1016         (TestPort):
1017         (TestPort._path_to_apache_config_file):
1018         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1019         (LayoutTestApacheHttpd.__init__):
1020         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
1021         (LayoutTestApacheHttpd.__init__):
1022         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1023         (Lighttpd.__init__):
1024         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1025         (HttpServerBase.__init__):
1026
1027 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
1028
1029         Unreviewed: Back out accidentally checked in debug print which broke a test
1030
1031         * Scripts/webkitpy/performance_tests/perftest.py:
1032         (PerfTest.parse_output):
1033
1034 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
1035
1036         Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
1037         https://bugs.webkit.org/show_bug.cgi?id=78789
1038
1039         Reviewed by Ryosuke Niwa.
1040
1041         Updated parser to include fps as a valid unit.
1042
1043         * Scripts/webkitpy/performance_tests/perftest.py:
1044         (PerfTest):
1045         (PerfTest.parse_output):
1046
1047 2012-06-20  Balazs Ankes  <bank@inf.u-szeged.hu>
1048
1049         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
1050         https://bugs.webkit.org/show_bug.cgi?id=67935
1051
1052         Reviewed by Ryosuke Niwa.
1053
1054         * Scripts/webkitpy/common/checkout/changelog.py:
1055         (ChangeLog.set_reviewer):
1056         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1057         (test_set_reviewer):
1058         (test_set_short_description_and_bug_url):
1059
1060 2012-06-20  Simon Hausmann  <simon.hausmann@nokia.com>
1061
1062         Unreviewed trivial permissions fix.
1063
1064         * qmake/mkspecs/features/features.prf: Don't mark this file as executable.
1065
1066 2012-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
1067
1068         [EFL][Regression] Build break after r120786
1069         https://bugs.webkit.org/show_bug.cgi?id=89549
1070
1071         Unreviewed build fix for Efl port.
1072
1073         * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
1074
1075 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1076
1077         NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
1078         https://bugs.webkit.org/show_bug.cgi?id=64489
1079
1080         Reviewed by Tony Chang.
1081
1082         This change changes NRWT so that we don't start the websocket
1083         server if we aren't running websocket tests and don't start the
1084         HTTP server if we aren't running http tests.
1085
1086         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1087         (Manager._websocket_tests):
1088         (Manager.start_servers_with_lock):
1089         (Manager.stop_servers_with_lock):
1090         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1091         (ManagerTest.test_servers_started):
1092
1093 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1094
1095         test-webkitpy: add a -p flag to pass through captured output to enable debugging
1096         https://bugs.webkit.org/show_bug.cgi?id=89158
1097
1098         Reviewed by Eric Seidel.
1099
1100         Normally when outputcapture runs it intercepts stdout/stderr,
1101         which makes running under the debugger difficult and mostly
1102         pointless (since you can't see any output). This change adds a
1103         flag to test-webkitpy (-p) that will cause outputcapture to pass
1104         through the output as well as capture it.
1105
1106         * Scripts/webkitpy/common/system/outputcapture.py:
1107         (OutputCapture.stream_wrapper):
1108         (OutputCapture._capture_output_with_name):
1109         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
1110         (OutputCaptureTest.setUp):
1111         * Scripts/webkitpy/test/main.py:
1112         (Tester._parse_args):
1113         (Tester._run_tests):
1114         (Tester._log_exception):
1115         (_CaptureAndPassThroughStream):
1116         (_CaptureAndPassThroughStream.__init__):
1117         (_CaptureAndPassThroughStream.write):
1118         (_CaptureAndPassThroughStream._message_is_from_pdb):
1119         (_CaptureAndPassThroughStream.flush):
1120         (_CaptureAndPassThroughStream.getvalue):
1121
1122 2012-06-19  Adam Barth  <abarth@webkit.org>
1123
1124         garden-o-matic fails to rebaseline tests with MISSING results
1125         https://bugs.webkit.org/show_bug.cgi?id=89521
1126
1127         Reviewed by Kenneth Russell.
1128
1129         If the bots report "MISSING", we should try to find PNG and TXT results on the server.
1130
1131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1132
1133 2012-06-19  Adam Barth  <abarth@webkit.org>
1134
1135         svn.delete_list fails to delete empty parent directories
1136         https://bugs.webkit.org/show_bug.cgi?id=89520
1137
1138         Reviewed by Dirk Pranke.
1139
1140         These functions were calling scm.delete and scm.add, which already
1141         delete the parent directory. We'd get an exception when we tried to
1142         delete the parent directory again.
1143
1144         * Scripts/webkitpy/common/checkout/scm/svn.py:
1145         (SVN._add_parent_directories):
1146         (SVN._delete_parent_directories):
1147
1148 2012-06-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1149
1150         webkitpy: Simplify fetch_bugs_matching_search()
1151         https://bugs.webkit.org/show_bug.cgi?id=89497
1152
1153         Reviewed by Adam Barth.
1154
1155         Removed parameter with default value. It's not being used
1156         and the handling of the parameter was wrong. Saves a check.
1157
1158         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1159         (BugzillaQueries.fetch_bugs_matching_search):
1160         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1161         (MockBugzillaQueries.fetch_bugs_matching_search):
1162
1163 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1164
1165         webkitpy: remove unneeded imports in layout_tests/port/chromium.py
1166         https://bugs.webkit.org/show_bug.cgi?id=89522
1167
1168         Reviewed by Eric Seidel.
1169
1170         They were no longer being used. No tests necessary.
1171
1172         * Scripts/webkitpy/layout_tests/port/chromium.py:
1173
1174 2012-06-19  Adam Barth  <abarth@webkit.org>
1175
1176         Missing results aren't shown in garden-o-matic
1177
1178         Reviewed by Kenneth Russell.
1179
1180         Previously we didn't know to look for text and image results when the
1181         bot told us that results were missing.
1182
1183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1184
1185 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1186
1187         Fix regression introduced in r120646 where the svn revision isn't saved in results.json
1188
1189         Unreviewed, build fix.
1190
1191         It turns out that we store the svn revision two different ways
1192         in the JSON, and I only caught one of them :(. This should fix
1193         the other.
1194
1195         Also, this part of the code is poorly tested. I will investigate
1196         adding at least a basic test for this in a separate fix.
1197
1198         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1199         (summarize_results):
1200
1201 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1202
1203         REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
1204         https://bugs.webkit.org/show_bug.cgi?id=78127
1205
1206         Reviewed by Ryosuke Niwa.
1207
1208         Add the --add-platform-exceptions flag from ORWT, and ensure
1209         that --new-baseline is equivalent to --reset-results
1210         --add-platform-exceptions. Also fix the default logic for where to
1211         put PNGs and render tree dumps if --new-test-results is true:
1212         if --add-platform-exceptions is False, baselines should go in
1213         the least-specific platform directory (e.g., platform/mac)
1214         rather than the most-specific (platform/mac-snowleopard).
1215
1216         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1217         (SingleTestRunner):
1218         (SingleTestRunner.run):
1219         (SingleTestRunner._run_rebaseline):
1220         (SingleTestRunner._add_missing_baselines):
1221         (SingleTestRunner._location_for_new_baseline):
1222         (SingleTestRunner._overwrite_baselines):
1223         (SingleTestRunner._save_baseline_data):
1224         * Scripts/webkitpy/layout_tests/port/base.py:
1225         (Port.baseline_path):
1226         (Port):
1227         (Port.baseline_platform_dir):
1228         (Port.baseline_version_dir):
1229         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1230         (_set_up_derived_options):
1231         (parse_args):
1232         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1233         (RebaselineTest.assertBaselines):
1234         (RebaselineTest.test_reset_results):
1235         (RebaselineTest.test_missing_results):
1236         (RebaselineTest.test_new_baseline):
1237
1238 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1239
1240         NRWT should not take memory used as disk cache into account when deciding how many processes to launch
1241         https://bugs.webkit.org/show_bug.cgi?id=81379
1242
1243         Reviewed by Eric Seidel.
1244
1245         The 'free memory' calculation we were running on the mac seemed
1246         to underestimate how many children we can run in parallel, and
1247         it was complex. This patch replaces that calculation with a
1248         simpler one that reserves 2GB for overhead and assumes 256MB per
1249         DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
1250
1251         Also, there was a bug where we were truncating the memory
1252         installed on the machine to 4GB by casting to an int instead of
1253         a long; this was probably the source of some of the earlier
1254         problems when using total memory.
1255
1256         This patch also removes the no-longer-needed restrictions on the
1257         number of workers on beefy Lion boxes for both Apple Mac and Chromium
1258         Mac; we should now use all of the cores by default.
1259
1260         The memory calculations have only been implemented on the mac;
1261         having the calculation in base.default_child_processes() was IMO
1262         misleading, and so this patch also moves the computation into
1263         the MacPort. I have not heard of the # of workers being an issue
1264         on any other ports, so this should be fine.
1265
1266         * Scripts/webkitpy/common/system/platforminfo.py:
1267         (PlatformInfo.total_bytes_memory):
1268         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1269         (PlatformInfo.total_bytes_memory):
1270         (PlatformInfo.total_bytes_memory):
1271         (PlatformInfo._win_version_tuple_from_cmd):
1272         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1273         (TestPlatformInfo.test_total_bytes_memory):
1274         * Scripts/webkitpy/layout_tests/port/base.py:
1275         (Port.default_child_processes):
1276         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1277         (PortTest.test_default_child_processes):
1278         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1279         (ChromiumMacPort.operating_system):
1280         * Scripts/webkitpy/layout_tests/port/mac.py:
1281         (MacPort.default_child_processes):
1282         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1283         (TestMacPort.test_default_child_processes):
1284
1285 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
1286
1287         new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
1288         https://bugs.webkit.org/show_bug.cgi?id=85446
1289
1290         Reviewed by Simon Fraser.
1291
1292         Embed whether pixel testing was enabled into the results.json.
1293
1294         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1295         (summarize_results):
1296
1297 2012-06-19  Zoltan Horvath  <zoltan@webkit.org>
1298
1299         [Qt] Modify HTTPS port to 8443 for performance tests
1300         https://bugs.webkit.org/show_bug.cgi?id=89442
1301
1302         Reviewed by Ryosuke Niwa.
1303
1304         We should be consistent with the default HTTPS port and with the changelog of r119188.
1305
1306         * Scripts/webkitpy/performance_tests/perftest.py:
1307         (ReplayServer.__init__):
1308
1309 2012-06-19  Mike West  <mkwst@chromium.org>
1310
1311         Introduce ENABLE_CSP_NEXT configuration flag.
1312         https://bugs.webkit.org/show_bug.cgi?id=89300
1313
1314         Reviewed by Adam Barth.
1315
1316         The 1.0 draft of the Content Security Policy spec is just about to
1317         move to Last Call. We'll hide work on the upcoming 1.1 spec behind
1318         this ENABLE flag, disabled by default.
1319
1320         Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
1321
1322         * Scripts/webkitperl/FeatureList.pm:
1323         * qmake/mkspecs/features/features.pri:
1324
1325 2012-06-19  Christophe Dumez  <christophe.dumez@intel.com>
1326
1327         [EFL] EFL's LayoutTestController does not support setTextDirection
1328         https://bugs.webkit.org/show_bug.cgi?id=87481
1329
1330         Reviewed by Hajime Morita.
1331
1332         Implement setTextDirection in EFL's LayoutTestController and
1333         properly reset its value between test cases to avoid flakiness.
1334
1335         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1336         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1337         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1338         (LayoutTestController::setTextDirection):
1339
1340 2012-06-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1341
1342         [Qt] Temporarily disable xvfb driver in nrwt
1343         https://bugs.webkit.org/show_bug.cgi?id=88414
1344
1345         Reviewed by Csaba Osztrogonác.
1346
1347         * Scripts/webkitpy/layout_tests/port/qt.py:
1348         (QtPort._build_driver):
1349
1350 2012-06-18  Joone Hur  <joone.hur@intel.com>
1351
1352         [EFL] Fontconfig can't be linked properly
1353         https://bugs.webkit.org/show_bug.cgi?id=89418
1354
1355         Unreviewed build fix.
1356
1357         Make Fontconfig be linked correctly.
1358
1359         * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
1360
1361 2012-06-18  Joone Hur  <joone.hur@intel.com>
1362
1363         Unreviewed. Updating email for committers.py script.
1364
1365         * Scripts/webkitpy/common/config/committers.py:
1366
1367 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1368
1369         Fix a typo that caused TestFailures to have a syntax error.
1370
1371         Sadly TestFailures is broken for another reason now too:
1372         https://bugs.webkit.org/show_bug.cgi?id=89419
1373
1374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1375         (ViewController.prototype._domForBuildName):
1376
1377 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1378
1379         Provide bug links for suspicious commits
1380         https://bugs.webkit.org/show_bug.cgi?id=89408
1381
1382         Reviewed by Adam Barth.
1383
1384         Add links to bugs for the suspicious commits if we have bug data.
1385
1386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
1387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1389         (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
1390         (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
1391
1392 2012-06-18  Amy Ousterhout  <aousterh@chromium.org>
1393
1394         [Chromium] DeviceOrientation Cleanup
1395         https://bugs.webkit.org/show_bug.cgi?id=89354
1396
1397         Reviewed by Kent Tamura.
1398
1399         * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
1400         (WebViewHost):
1401
1402 2012-06-18  James Robinson  <jamesr@chromium.org>
1403
1404         [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
1405         https://bugs.webkit.org/show_bug.cgi?id=89254
1406
1407         Reviewed by Adrienne Walker.
1408
1409         This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
1410         upstream.
1411
1412         * DumpRenderTree/chromium/WebViewHost.cpp:
1413         (WebViewHost::createGraphicsContext3D):
1414
1415 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1416
1417         Minor fix suggested by Adam Barth.
1418
1419         Use $(this._what).empty(); rather than removing children one at a time.
1420         For some reason removeAllChildren() is undefined on this node.
1421
1422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1423
1424 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1425
1426         Show TOT revision in garden-o-matic, and make the revisions into links
1427         https://bugs.webkit.org/show_bug.cgi?id=89396
1428
1429         Reviewed by Adam Barth.
1430
1431         The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
1432         where the revisions are links to trac.
1433
1434         To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
1435         the knock-on effect of flipping the target and href attributes for anchors in some test output.
1436
1437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1438         (ViewController.prototype._displayTesters.updateList.list):
1439         (ViewController.prototype._displayTesters.updateList):
1440         (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
1441         (ViewController.prototype._domForRegressionRange):
1442         (ViewController.prototype._domForAuxiliaryUIElements):
1443         (ViewController.prototype._domForBuildName):
1444         (ViewController.prototype):
1445         (ViewController.prototype.):
1446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1451
1452 2012-06-18  Csaba Osztrogonác  <ossy@webkit.org>
1453
1454         REGRESSION(r100558): NRWT should work without SVN or GIT
1455         https://bugs.webkit.org/show_bug.cgi?id=76630
1456
1457         Reviewed by Dirk Pranke.
1458
1459         NRWT is not supposed to have a requirement that we have an
1460         actual SVN or Git checkout, and we were unnecessarily
1461         initializing the checkout. This patch removes that line :).
1462
1463         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1464         (main):
1465
1466 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
1467
1468         [garden-o-matic] Add support for the GTK builders
1469         https://bugs.webkit.org/show_bug.cgi?id=89360
1470
1471         Reviewed by Adam Barth.
1472
1473         Add the 'gtk' platform, essentially a copy of the 'apple' platform since
1474         both get their data from build.webkit.org.
1475
1476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1477         (.):
1478
1479 2012-06-18  Nico Weber  <thakis@chromium.org>
1480
1481         [chromium/mac] Unbreak smooth scrolling.
1482         https://bugs.webkit.org/show_bug.cgi?id=89327
1483
1484         Reviewed by Dimitri Glazkov.
1485
1486         Broken by Sam in r115589 / r115591.
1487
1488         * DumpRenderTree/mac/DumpRenderTree.mm:
1489         (resetDefaultsToConsistentValues):
1490         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1491         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1492         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1493         (WTR::InjectedBundle::platformInitialize):
1494
1495 2012-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1496
1497         Unreviewed, rolling out r120541, r120547, and r120548.
1498         http://trac.webkit.org/changeset/120541
1499         http://trac.webkit.org/changeset/120547
1500         http://trac.webkit.org/changeset/120548
1501         https://bugs.webkit.org/show_bug.cgi?id=89383
1502
1503         This approach doesn't work for WebKit2 (Requested by abarth on
1504         #webkit).
1505
1506         * DumpRenderTree/LayoutTestController.cpp:
1507         (setBackingScaleFactorCallback):
1508         (LayoutTestController::staticFunctions):
1509         * DumpRenderTree/LayoutTestController.h:
1510         (LayoutTestController):
1511         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1512         (LayoutTestController::setBackingScaleFactor):
1513         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1514         (LayoutTestController::setBackingScaleFactor):
1515         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1516         (LayoutTestController::setBackingScaleFactor):
1517         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1518         (LayoutTestController::setBackingScaleFactor):
1519         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1520         (LayoutTestController::setBackingScaleFactor):
1521         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1522         (LayoutTestController::setBackingScaleFactor):
1523         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1524         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1525         (WTR::InjectedBundle::didReceiveMessage):
1526         (WTR::InjectedBundle::postSetBackingScaleFactor):
1527         (WTR):
1528         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1529         (InjectedBundle):
1530         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1531         (WTR::LayoutTestController::setBackingScaleFactor):
1532         (WTR):
1533         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
1534         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1535         (LayoutTestController):
1536         * WebKitTestRunner/TestInvocation.cpp:
1537         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1538
1539 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
1540
1541         REGRESSION(r120546): It made 3 webkitpy tests fail
1542         https://bugs.webkit.org/show_bug.cgi?id=89332
1543
1544         Reviewed by Adam Barth.
1545
1546         Update the BaselineOptimizer unittest after r120546.
1547
1548         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1549         (BaselineOptimizerTest.test_no_add_mac_future):
1550         (BaselineOptimizerTest.test_mac_future):
1551         (BaselineOptimizerTest.test_complex_shadowing):
1552
1553 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
1554
1555         new-run-webkit-tests output gets confused when logging
1556         https://bugs.webkit.org/show_bug.cgi?id=63793
1557
1558         Reviewed by Adam Barth.
1559
1560         Ship all of the log messages generated in the worker back
1561         to the manager; this allows the messages to be properly
1562         serialized to stderr and for the meter to flush its output correctly.
1563
1564         Note however that this will likely result in messages to be
1565         logged out of order between workers; I'm not sure that there's
1566         an easy way to fix this short of buffering a potentially
1567         unbounded amount of data. It might be better to just log through
1568         stderr unless we're in 'metering' mode, but it's also worth
1569         noting that we already get messages out of order through stderr
1570         on Windows.
1571
1572         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1573         (Manager.handle_done):
1574         (Manager.handle_finished_test):
1575         (Manager._log_messages):
1576         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1577         (Worker.__init__):
1578         (Worker._set_up_logging):
1579         (Worker.run):
1580         (Worker._run_test):
1581         (Worker.cleanup):
1582         (Worker.run_single_test):
1583         (_WorkerLogHandler):
1584         (_WorkerLogHandler.__init__):
1585         (_WorkerLogHandler.emit):
1586         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1587         (MeteredStream.write):
1588         (MeteredStream.writeln):
1589         * Scripts/webkitpy/layout_tests/views/printing.py:
1590         (Printer.writeln):
1591
1592 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
1593
1594         [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
1595         https://bugs.webkit.org/show_bug.cgi?id=89362
1596
1597         Reviewed by Simon Fraser.
1598
1599         Replace white spaces, braces and dots in the builder name with underscores. This
1600         way the JQuery tabs will be properly matched with the according container.
1601
1602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1603
1604 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
1605
1606         nrwt: metered output doesn't handle ^C cleanly
1607         https://bugs.webkit.org/show_bug.cgi?id=89249
1608
1609         Reviewed by Tony Chang.
1610
1611         If you ctrl-c a running nrwt (w/o --verbose), then all but
1612         two characters of the last update are erased, and then we print
1613         "interrupted, exiting" as an update, which itself then gets
1614         erased. Fix this so that we flush the meter (making the last
1615         update persistent, so that we print the ^C for a visual clue),
1616         print the interrupt message, and move on ...
1617
1618         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1619         (Manager._run_tests):
1620         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1621         (MeteredStream.flush):
1622         * Scripts/webkitpy/layout_tests/views/printing.py:
1623         (Printer._write):
1624         (Printer):
1625         (Printer.flush):
1626
1627 2012-06-18  Xianzhu Wang  <wangxianzhu@chromium.org>
1628
1629         [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
1630         https://bugs.webkit.org/show_bug.cgi?id=89228
1631
1632         Reviewed by Tony Chang.
1633
1634         * DumpRenderTree/chromium/LayoutTestController.cpp:
1635         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1636
1637 2012-06-18  Mario Sanchez Prada  <msanchez@igalia.com>
1638
1639         [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
1640         https://bugs.webkit.org/show_bug.cgi?id=89226
1641
1642         Reviewed by Martin Robinson.
1643
1644         Implement increment() and decrement() functions in term of the AtkValue interface,
1645         instead of using DumpRenderTreeSupportGtk helper class.
1646
1647         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1648         (AccessibilityUIElement::intValue):
1649         (AccessibilityUIElement::minValue):
1650         (AccessibilityUIElement::maxValue):
1651         (alterCurrentValue):
1652         (AccessibilityUIElement::increment):
1653         (AccessibilityUIElement::decrement):
1654
1655 2012-06-17  Simon Fraser  <simon.fraser@apple.com>
1656
1657         garden-o-matic 'Results' panel is broken for the Apple platform
1658         https://bugs.webkit.org/show_bug.cgi?id=89310
1659
1660         Reviewed by Adam Barth.
1661
1662         For platforms that don't use accumulated build directories on the server,
1663         carry along buildLocation data with buildInfo, so that we know where to
1664         look for the test results files for a given test.
1665
1666         Renamed historicalResultsSummaryURLs to historicalResultsLocations because
1667         it now returns an array of objects with buildNumber, revision and url info.
1668
1669         Fixed results.fetchResultsURLs() to use this data to find results.
1670
1671         Fixed the results display to not scroll when you click on a test to see the results.
1672         Made the h3s look less ugly
1673
1674         Don't try to show the flakiness dashboard for the Apple platform.
1675
1676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1678         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1681         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1682         (.results-view .top-panel):
1683         (.results-view h3):
1684
1685 2012-06-16  Simon Fraser  <simon.fraser@apple.com>
1686
1687         Make garden-o-matic work for the Apple Mac port
1688         https://bugs.webkit.org/show_bug.cgi?id=84642
1689
1690         Reviewed by Adam Barth.
1691
1692         Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
1693         educating the scripts in various ways:
1694         * Wrap up platform-related differences in config.kPlatforms[]
1695         * Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
1696         * The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do,
1697           so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most
1698           recent build with valid results.
1699         * The webkit.org bots often generate results directories with no layout test data (e.g. when testers
1700           try to test a build that has already been deleted). Make walkHistory() more robust here.
1701         * webkit.org uses differently named test result directories, that include the SVN revision as
1702           well as the build number. That forces us to fetch more build info before we can get the
1703           result directory URL.
1704         * chromium.org serves raw directory listings for a builder's results directories. webkit.org serves
1705           those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results
1706           dirs.
1707         * Various URLs differ between webkit.org and chromium.org
1708         * Better UI for the failures info, so that some info is visible even when not hovered.
1709
1710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1711         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
1712         (LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
1713         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1714         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1715         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1716         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1717         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1718         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
1724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1726         (ol.notifications>li table.failures):
1727         (ol.notifications>li:hover table.failures):
1728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
1729         (#onebar #platform-picker):
1730         * Scripts/webkitpy/layout_tests/port/builders.py:
1731
1732 2012-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1733
1734         Unreviewed, rolling out r120536.
1735         http://trac.webkit.org/changeset/120536
1736         https://bugs.webkit.org/show_bug.cgi?id=89296
1737
1738         Does not compile on chromium-linux (Requested by abarth on
1739         #webkit).
1740
1741         * DumpRenderTree/chromium/LayoutTestController.cpp:
1742         (LayoutTestController::reset):
1743         (LayoutTestController::setTextSubpixelPositioning):
1744         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1745
1746 2012-06-16  Adam Barth  <abarth@webkit.org>
1747
1748         layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
1749         https://bugs.webkit.org/show_bug.cgi?id=89274
1750
1751         Reviewed by Levi Weintraub.
1752
1753         Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
1754         Note: The WebKit2 API that setBackingScaleFactor exercises is still
1755         tested by API-level tests.
1756
1757         * DumpRenderTree/LayoutTestController.cpp:
1758         (LayoutTestController::staticFunctions):
1759         * DumpRenderTree/LayoutTestController.h:
1760         (LayoutTestController):
1761         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1762         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1763         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1764         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1765         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1766         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1767         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1768         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1769         (WTR::InjectedBundle::didReceiveMessage):
1770         (WTR):
1771         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1772         (InjectedBundle):
1773         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1774         (WTR):
1775         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1776         (LayoutTestController):
1777         * WebKitTestRunner/TestInvocation.cpp:
1778         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1779
1780 2012-06-16  Xianzhu Wang  <wangxianzhu@chromium.org>
1781
1782         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1783         https://bugs.webkit.org/show_bug.cgi?id=89228
1784
1785         Reviewed by Tony Chang.
1786
1787         * DumpRenderTree/chromium/LayoutTestController.cpp:
1788         (LayoutTestController::reset):
1789         (LayoutTestController::setTextSubpixelPositioning):
1790         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1791
1792 2012-06-15  Adam Barth  <abarth@webkit.org>
1793
1794         garden-o-matic's results.js should use RequestTracker
1795         https://bugs.webkit.org/show_bug.cgi?id=89257
1796
1797         Reviewed by Dimitri Glazkov.
1798
1799         We wrote results.js before we recognized the RequestTracker pattern.
1800         This patch replaces the manual implementations of RequestTracker with
1801         the real deal.
1802
1803         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1804
1805 2012-06-15  Darin Adler  <darin@apple.com>
1806
1807         * Scripts/webkitpy/bindings: Added property svn:ignore.
1808
1809 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1810
1811         Unreviewed, rolling out r120511.
1812         http://trac.webkit.org/changeset/120511
1813         https://bugs.webkit.org/show_bug.cgi?id=89255
1814
1815         Breaks at least Android builder (Requested by wangxianzhu on
1816         #webkit).
1817
1818         * DumpRenderTree/chromium/LayoutTestController.cpp:
1819         (LayoutTestController::reset):
1820         (LayoutTestController::setTextSubpixelPositioning):
1821
1822 2012-06-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1823
1824         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1825         https://bugs.webkit.org/show_bug.cgi?id=89228
1826
1827         Reviewed by Tony Chang.
1828
1829         * DumpRenderTree/chromium/LayoutTestController.cpp:
1830         (LayoutTestController::reset):
1831         (LayoutTestController::setTextSubpixelPositioning):
1832
1833 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1834
1835         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
1836         https://bugs.webkit.org/show_bug.cgi?id=89135
1837
1838         Re-land change in r120370 with fix in
1839         PortFactory.get_from_builder_name() that changes BuilderOptions
1840         to an actual optparse.Values object.
1841
1842         * Scripts/webkitpy/layout_tests/port/base.py:
1843         (Port.__init__):
1844         (Port.get_option):
1845         (Port.set_option_default):
1846         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1847         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1848         * Scripts/webkitpy/layout_tests/port/factory.py:
1849         (_builder_options):
1850         (PortFactory.get_from_builder_name):
1851         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1852         (FactoryTest.test_get_from_builder_name):
1853         * Scripts/webkitpy/style/checkers/test_expectations.py:
1854         (TestExpectationsChecker._determine_port_from_expectations_path):
1855         * Scripts/webkitpy/tool/mocktool.py:
1856         (MockOptions.ensure_value):
1857
1858 2012-06-15  Bill Budge  <bbudge@chromium.org>
1859
1860         Add bbudge@chromium.org to committers.py
1861
1862         Unreviewed.
1863
1864         * Scripts/webkitpy/common/config/committers.py:
1865
1866 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1867
1868         Unreviewed style fix after r120351.
1869
1870         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1871         (body.interface):
1872
1873 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1874
1875         master.cfg cleanup, remove unnecessary workaround
1876         https://bugs.webkit.org/show_bug.cgi?id=88994
1877
1878         Reviewed by Lucas Forschler.
1879
1880         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1881         (loadBuilderConfig):
1882
1883 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1884
1885         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
1886         https://bugs.webkit.org/show_bug.cgi?id=88581
1887
1888         Reviewed by Adam Barth.
1889
1890         Make sure we only optimize the suffixes we rebaselined during
1891         rebaseline-expectations, and not all suffixes for a test.
1892         While optimizing is somewhere between harmless and good, it's also confusing :)
1893
1894         * Scripts/webkitpy/tool/commands/rebaseline.py:
1895         (RebaselineExpectations._rebaseline_port):
1896         (RebaselineExpectations.execute):
1897         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1898
1899 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1900
1901         Update builder.html template for newer buildmaster
1902         https://bugs.webkit.org/show_bug.cgi?id=89207
1903
1904         Rebasing builder.html template from v0.8.3 to v0.8.6p1.
1905
1906         Reviewed by Zoltan Herczeg.
1907
1908         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
1909
1910 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1911
1912         Add ForceScheduler to build.webkit.org
1913         https://bugs.webkit.org/show_bug.cgi?id=88982
1914
1915         Reviewed by Ryosuke Niwa.
1916
1917         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1918         (loadBuilderConfig):
1919
1920 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1921
1922         [EFL][WK2] Add title support to Ewk_View
1923         https://bugs.webkit.org/show_bug.cgi?id=89095
1924
1925         Reviewed by Kenneth Rohde Christiansen.
1926
1927         Update the MiniBrowser so it listens for the "title,change"
1928         signal on the view and keeps the browser window title
1929         up-to-date.
1930
1931         * MiniBrowser/efl/main.c:
1932         (on_title_changed):
1933         (browserCreate):
1934
1935 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1936
1937         [WK2][EFL] Implement navigation back/forward in Ewk_View
1938         https://bugs.webkit.org/show_bug.cgi?id=89173
1939
1940         Reviewed by Kenneth Rohde Christiansen.
1941
1942         Implement navigation back / forward in MiniBrowser. Use
1943         'F1' to navigate back and 'F2' to navigate forward.
1944
1945         * MiniBrowser/efl/main.c:
1946         (on_key_down):
1947
1948 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1949
1950         [EFL] EFL's LayoutTestController does not support titleTextDirection
1951         https://bugs.webkit.org/show_bug.cgi?id=86475
1952
1953         Reviewed by Hajime Morita.
1954
1955         Add titleTextDirection getter and setter to LayoutTestController and
1956         expose its value to JavaScript.
1957         Update the titleTextDirection value from EFL's "title,changed"
1958         callback in DumpRenderTree.
1959
1960         * DumpRenderTree/LayoutTestController.cpp:
1961         (LayoutTestController::LayoutTestController):
1962         (getTitleTextDirectionCallback):
1963         (LayoutTestController::staticValues):
1964         * DumpRenderTree/LayoutTestController.h:
1965         (LayoutTestController::titleTextDirection):
1966         (LayoutTestController::setTitleTextDirection):
1967         (LayoutTestController):
1968         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1969         (DumpRenderTreeChrome::onFrameTitleChanged):
1970
1971 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1972
1973         [EFL][WK2] Implement reload / stop in Ewk_View
1974         https://bugs.webkit.org/show_bug.cgi?id=89168
1975
1976         Reviewed by Kenneth Rohde Christiansen.
1977
1978         Implement view reload / stop loading in MiniBrowser.
1979         Use 'F5' for reload and 'F6' for stopping the load.
1980
1981         * MiniBrowser/efl/main.c:
1982         (on_key_down):
1983         (browserCreate):
1984
1985 2012-06-15  Hironori Bono  <hbono@chromium.org>
1986
1987         Allow platforms to choose whether to remove markers on editing
1988         https://bugs.webkit.org/show_bug.cgi?id=88838
1989
1990         Reviewed by Hajime Morita.
1991
1992         This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
1993         run grammar tests.
1994
1995         * DumpRenderTree/chromium/WebViewHost.cpp:
1996         (WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
1997         * DumpRenderTree/chromium/WebViewHost.h:
1998         (WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
1999
2000 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2001
2002         Unreviewed, rolling out r120370.
2003         http://trac.webkit.org/changeset/120370
2004         https://bugs.webkit.org/show_bug.cgi?id=89183
2005
2006         Broke webkit-patch rebaseline (Requested by zdobersek on
2007         #webkit).
2008
2009         * Scripts/webkitpy/layout_tests/port/base.py:
2010         (DummyOptions):
2011         (DummyOptions.__init__):
2012         (DummyOptions.__init__.this):
2013         (Port.__init__):
2014         (Port.get_option):
2015         (Port.set_option_default):
2016         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2017         (ChromiumWinTest.RegisterCygwinOption):
2018         (ChromiumWinTest.RegisterCygwinOption.__init__):
2019         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
2020         * Scripts/webkitpy/style/checkers/test_expectations.py:
2021         (TestExpectationsChecker._determine_port_from_expectations_path):
2022         * Scripts/webkitpy/tool/mocktool.py:
2023         (MockOptions.update):
2024
2025 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
2026
2027         [Chromium-Android] Initialize font rendering in DumpRenderTree
2028         https://bugs.webkit.org/show_bug.cgi?id=89133
2029
2030         Reviewed by Adam Barth.
2031
2032         * DumpRenderTree/chromium/LayoutTestController.cpp:
2033         (LayoutTestController::reset):
2034         (LayoutTestController::setTextSubpixelPositioning):
2035         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2036         (platformInit):
2037
2038 2012-06-14  Dongwoo Im  <dw.im@samsung.com>
2039
2040         [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
2041         https://bugs.webkit.org/show_bug.cgi?id=88622
2042
2043         Reviewed by Philippe Normand.
2044
2045         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
2046         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2047
2048 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
2049
2050         [Chromium-Android] Should retry a few times when failed to start DumpRenderTree
2051         https://bugs.webkit.org/show_bug.cgi?id=89124
2052
2053         Reviewed by Dirk Pranke.
2054
2055         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2056         (ChromiumAndroidDriver._start):
2057         (ChromiumAndroidDriver):
2058         (ChromiumAndroidDriver._start_once):
2059
2060 2012-06-14  Tony Gentilcore  <tonyg@chromium.org>
2061
2062         Update webpagereplay to 1.1.2
2063         https://bugs.webkit.org/show_bug.cgi?id=89118
2064
2065         This includes the following patch which avoids pkg_resources import errors:
2066         http://code.google.com/p/web-page-replay/source/detail?r=476
2067
2068         Reviewed by Dirk Pranke.
2069
2070         * Scripts/webkitpy/thirdparty/__init__.py:
2071         (AutoinstallImportHook._install_webpagereplay):
2072
2073 2012-06-14  Ryosuke Niwa  <rniwa@webkit.org>
2074
2075         Get rid of FAIL test expectation
2076         https://bugs.webkit.org/show_bug.cgi?id=89137
2077
2078         Reviewed by Dirk Pranke.
2079
2080         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2081         (ResultSummaryTest.test_summarized_results_wontfix):
2082         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2083         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2084         (JSONLayoutResultsGenerator):
2085         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2086         (result_was_expected):
2087         (suffixes_for_expectations):
2088         (TestExpectationsModel._add_test):
2089         (TestExpectations):
2090         (TestExpectations.get_rebaselining_failures):
2091         (TestExpectations.remove_configuration_from_test):
2092         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2093         (FunctionsTest.test_result_was_expected):
2094         (FunctionsTest.test_suffixes_for_expectations):
2095         (TestExpectationSerializerTests.test_parsed_expectations_string):
2096         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2097         (test_test_expectations):
2098         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2099         (TestExpectationsTestCase.test_valid_expectations):
2100
2101 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
2102
2103         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
2104         https://bugs.webkit.org/show_bug.cgi?id=89135
2105
2106         Reviewed by Ryosuke Niwa.
2107
2108         This patch is just some minor cleanup and simplification. There
2109         should be no functional changes here.
2110
2111         * Scripts/webkitpy/layout_tests/port/base.py:
2112         (Port.__init__):
2113         (Port.get_option):
2114         (Port.set_option_default):
2115         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2116         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
2117         * Scripts/webkitpy/style/checkers/test_expectations.py:
2118         (TestExpectationsChecker._determine_port_from_expectations_path):
2119         * Scripts/webkitpy/tool/mocktool.py:
2120         (MockOptions.ensure_value):
2121
2122 2012-06-14  Ian Vollick  <vollick@chromium.org>
2123
2124         [chromium] Certain settings in CCSettings could be global
2125         https://bugs.webkit.org/show_bug.cgi?id=88384
2126
2127         Reviewed by James Robinson.
2128
2129         * DumpRenderTree/chromium/TestShell.cpp:
2130         (TestShell::TestShell):
2131         (TestShell::resetWebSettings):
2132         (TestShell::setPerTilePaintingEnabled):
2133         * DumpRenderTree/chromium/TestShell.h:
2134         (TestShell):
2135         * DumpRenderTree/chromium/WebPreferences.cpp:
2136         (WebPreferences::reset):
2137         (WebPreferences::applyTo):
2138         * DumpRenderTree/chromium/WebPreferences.h:
2139         (WebPreferences):
2140
2141 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2142
2143         Unreviewed, rolling out r120352.
2144         http://trac.webkit.org/changeset/120352
2145         https://bugs.webkit.org/show_bug.cgi?id=89120
2146
2147         It seems something is still wrong with it :/ (Requested by
2148         Ossy on #webkit).
2149
2150         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2151         (Factory.__init__):
2152         (BuildFactory.__init__):
2153         (TestFactory.__init__):
2154         (BuildAndTestFactory.__init__):
2155         (BuildAndPerfTestFactory.__init__):
2156         (BuildAndPerfTestWebKit2Factory.__init__):
2157         (DownloadAndPerfTestFactory.__init__):
2158         (DownloadAndPerfTestWebKit2Factory.__init__):
2159
2160 2012-06-14  Jia Pu  <jpu@apple.com>
2161
2162         Mark text with text alternative with blue underline.
2163         https://bugs.webkit.org/show_bug.cgi?id=83047
2164
2165         Reviewed by NOBODY Enrica Casucci.
2166
2167         * DumpRenderTree/mac/TextInputController.m:
2168         (+[TextInputController isSelectorExcludedFromWebScript:]):
2169         (+[TextInputController webScriptNameForSelector:]):
2170         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
2171
2172 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2173
2174         Unreviewed, rolling out r120353.
2175         http://trac.webkit.org/changeset/120353
2176         https://bugs.webkit.org/show_bug.cgi?id=89119
2177
2178         It seems we still need this workaround (Requested by Ossy on
2179         #webkit).
2180
2181         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2182         (loadBuilderConfig):
2183
2184 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
2185
2186         master.cfg cleanup, remove unnecessary workaround
2187         https://bugs.webkit.org/show_bug.cgi?id=88994
2188
2189         Reviewed by Lucas Forschler.
2190
2191         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2192         (loadBuilderConfig):
2193
2194 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
2195
2196         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
2197         https://bugs.webkit.org/show_bug.cgi?id=89001
2198
2199         Reviewed by Lucas Forschler.
2200
2201         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2202         (Factory.__init__):
2203         (BuildFactory.__init__):
2204         (TestFactory.__init__):
2205         (BuildAndTestFactory.__init__):
2206         (BuildAndPerfTestFactory.__init__):
2207         (BuildAndPerfTestWebKit2Factory.__init__):
2208         (DownloadAndPerfTestFactory.__init__):
2209         (DownloadAndPerfTestWebKit2Factory.__init__):
2210
2211 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
2212
2213         Unhide login form on the build.webkit.org
2214         https://bugs.webkit.org/show_bug.cgi?id=88981
2215
2216         Reviewed by Lucas Forschler.
2217
2218         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2219
2220 2012-06-14  Zan Dobersek  <zandobersek@gmail.com>
2221
2222         [Gtk] Add support in DumpRenderTree for tracking repaints
2223         https://bugs.webkit.org/show_bug.cgi?id=87658
2224
2225         Reviewed by Martin Robinson.
2226
2227         Reimplement the displayWebView method in DumpRenderTree - force a
2228         repaint before starting tracking repaints and resetting them.
2229
2230         When gathering pixel output from a web view, if tracking repaints,
2231         paint an overlay over the output with the overlay being clear in the
2232         areas where the repaints occurred.
2233
2234         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2235         (displayWebView):
2236         (resetDefaultsToConsistentValues):
2237         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2238         (paintOverlay):
2239         (fillRepaintOverlayIntoContext):
2240         (createBitmapContextFromWebView):
2241
2242 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
2243
2244         new-run-webkit-tests doesn't find similar platform tests for a keyword
2245         https://bugs.webkit.org/show_bug.cgi?id=37956
2246
2247         Reviewed by Ryosuke Niwa.
2248
2249         This patches adds support for NRWT so that if you type
2250         "new-run-webkit-tests foo" it will run all the tests in foo as
2251         well as platform/foo for all of the platforms that are normally
2252         searched (this only applies to directories, not to individual tests).
2253
2254         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2255         (Manager.collect_tests):
2256         * Scripts/webkitpy/layout_tests/port/base.py:
2257         (Port.tests):
2258         (Port):
2259         (Port._expanded_paths):
2260         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2261         (MainTest.test_no_http_tests):
2262         (MainTest):
2263         (MainTest.test_platform_tests_are_found):
2264
2265 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
2266
2267         NRWT should honor --skipped=[default|ignore|only], like ORWT does
2268         https://bugs.webkit.org/show_bug.cgi?id=66308
2269
2270         Reviewed by Ryosuke Niwa.
2271
2272         This patch adds support for ORWT's --skipped=(default|ignore|only)
2273         flag and cleans up the interaction between that and --ignore.
2274
2275         Individual tests (but not directories) explicitly listed on the
2276         command line will always be run regardless of what is passed
2277         for --skipped and --ignore.
2278
2279         This patch also changes the "found" and "running" log messages
2280         since it wasn't clear how the skipped tests were included in those numbers.
2281
2282         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2283         (Manager.__init__):
2284         (Manager.collect_tests):
2285         (Manager.prepare_lists_and_print_output):
2286         * Scripts/webkitpy/layout_tests/port/test.py:
2287         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2288         (_set_up_derived_options):
2289         (parse_args):
2290         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2291         (MainTest.test_ignore_flag):
2292         (MainTest):
2293         (MainTest.test_skipped_flag):
2294
2295 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
2296
2297         new-run-webkit-websocketserver must handle TLS related arguments
2298         https://bugs.webkit.org/show_bug.cgi?id=89079
2299
2300         Reviewed by Dirk Pranke.
2301
2302         PyWebSocket class must accept private_key, certificate, and
2303         ca_certificate arguments and pass them to launching pywebsocket.
2304         Also add ca_certificate handling to new-run-webkit-websocketserver.
2305
2306         * Scripts/new-run-webkit-websocketserver:
2307         (main):
2308         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2309         (PyWebSocket.__init__):
2310         (PyWebSocket._prepare_config):
2311
2312 2012-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
2313
2314         Unreviewed. Update my email.
2315
2316         * Scripts/webkitpy/common/config/committers.py:
2317
2318 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
2319
2320         Update pywebsocket to 0.7.6 from 0.7.4
2321         https://bugs.webkit.org/show_bug.cgi?id=88975
2322
2323         Reviewed by Kent Tamura.
2324
2325         This new version of pywebsocket introduce following features.
2326          - Allow handlers to send a close frame with empty body in response of
2327              a client initiated closing handshake
2328          - Implement perframe compression extension
2329          - Support client certificate authentication
2330
2331         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
2332         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
2333         (_create_control_frame):
2334         (Stream._receive_frame):
2335         (Stream.send_message):
2336         (Stream.receive_message):
2337         (Stream._send_closing_handshake):
2338         (Stream.close_connection):
2339         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
2340         (ExtensionParsingException):
2341         (ExtensionParsingException.__init__):
2342         (_parse_extension_param):
2343         (_parse_extension):
2344         (parse_extensions):
2345         (format_extension):
2346         (format_extensions):
2347         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
2348         (_parse_compression_method):
2349         (_create_accepted_method_desc):
2350         (PerFrameCompressionExtensionProcessor):
2351         (PerFrameCompressionExtensionProcessor.__init__):
2352         (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
2353         (PerFrameCompressionExtensionProcessor._get_compression_processor_response):
2354         (PerFrameCompressionExtensionProcessor.get_extension_response):
2355         (PerFrameCompressionExtensionProcessor.setup_stream_options):
2356         (PerFrameCompressionExtensionProcessor.get_compression_processor):
2357         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
2358         (parse_token_list):
2359         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
2360         (Handshaker._parse_extensions):
2361         (Handshaker._send_handshake):
2362         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
2363         (WebSocketServer._create_sockets):
2364         (_get_logger_from_class):
2365         (_configure_logging):
2366         (_build_option_parser):
2367         (_main.if):
2368         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
2369         (RepeatedXorMasker.mask):
2370
2371 2012-06-14  Zoltan Horvath  <zoltan@webkit.org>
2372
2373         [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore
2374
2375         Reviewed by Noam Rosenthal.
2376
2377         * qmake/mkspecs/features/features.prf:
2378
2379 2012-06-14  Christophe Dumez  <christophe.dumez@intel.com>
2380
2381         [WK2] Add implementation for registerIntentService in WebFrameLoaderClient
2382         https://bugs.webkit.org/show_bug.cgi?id=88399
2383
2384         Reviewed by Kenneth Rohde Christiansen.
2385
2386         Update initialization of WKPageLoaderClient.
2387
2388         * MiniBrowser/mac/BrowserWindowController.m:
2389         (-[BrowserWindowController awakeFromNib]):
2390         * WebKitTestRunner/TestController.cpp:
2391         (WTR::TestController::initialize):
2392
2393 2012-06-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2394
2395         [EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
2396         https://bugs.webkit.org/show_bug.cgi?id=84577
2397
2398         Reviewed by Ryosuke Niwa.
2399
2400         Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
2401         LayoutTestController.
2402
2403         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2404         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2405
2406 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
2407
2408         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
2409         https://bugs.webkit.org/show_bug.cgi?id=88340
2410
2411         Reviewed by Kenneth Rohde Christiansen.
2412
2413         Update initialization of WKPageLoaderClient.
2414
2415         * MiniBrowser/mac/BrowserWindowController.m:
2416         (-[BrowserWindowController awakeFromNib]):
2417         * WebKitTestRunner/TestController.cpp:
2418         (WTR::TestController::initialize):
2419
2420 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2421
2422         Unreviewed, rolling out r120268.
2423         http://trac.webkit.org/changeset/120268
2424         https://bugs.webkit.org/show_bug.cgi?id=89060
2425
2426         WebCompositor::setPerTilePaintingEnabled hits an assertion in
2427         DEBUG (Requested by dominicc|work on #webkit).
2428
2429         * DumpRenderTree/chromium/WebPreferences.cpp:
2430         (WebPreferences::applyTo):
2431
2432 2012-06-13  Tim Horton  <timothy_horton@apple.com>
2433
2434         REGRESSION (r120252): run-webkit-tests on Mac fails
2435         https://bugs.webkit.org/show_bug.cgi?id=89057
2436
2437         Reviewed by Dan Bernstein.
2438
2439         get_option will happily return None (the default only kicks in if
2440         the option is actually *not set*). We should instead check get_option's
2441         return value and default to "x86_64" architecture ourselves.
2442
2443         * Scripts/webkitpy/layout_tests/port/mac.py:
2444         (MacPort.__init__):
2445
2446 2012-06-13  Ian Vollick  <vollick@chromium.org>
2447
2448         [chromium] Certain settings in CCSettings could be global
2449         https://bugs.webkit.org/show_bug.cgi?id=88384
2450
2451         Reviewed by James Robinson.
2452
2453         * DumpRenderTree/chromium/WebPreferences.cpp:
2454         (WebPreferences::applyTo):
2455
2456 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2457
2458         new-run-webkit-tests does not support --32-bit like ORWT did
2459         https://bugs.webkit.org/show_bug.cgi?id=71634
2460
2461         Reviewed by Ojan Vafai.
2462
2463         This patch adds support for 32-bit apple mac builds, adding the
2464         --32-bit flag for compatibility with ORWT and fixing the port
2465         architecture() definition to actually return the correct values.
2466
2467         * Scripts/webkitpy/layout_tests/port/apple.py:
2468         (ApplePort._generate_all_test_configurations):
2469         * Scripts/webkitpy/layout_tests/port/factory.py:
2470         (port_options):
2471         * Scripts/webkitpy/layout_tests/port/mac.py:
2472         (MacPort):
2473         (MacPort.__init__):
2474         (MacPort._build_driver_flags):
2475         (MacPort.setup_environ_for_server):
2476         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2477         (test_sample_process_throws_exception):
2478         (test_32bit):
2479         (test_32bit.run_script):
2480         (test_64bit):
2481         (test_64bit.run_script):
2482         * Scripts/webkitpy/layout_tests/port/webkit.py:
2483         (WebKitPort._build_driver):
2484         (WebKitPort._build_driver_flags):
2485         * Scripts/webkitpy/layout_tests/port/win.py:
2486         (WinPort):
2487
2488 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
2489
2490         Remove webkitpy code to support legacy test_expectations.txt files
2491         https://bugs.webkit.org/show_bug.cgi?id=89038
2492
2493         Reviewed by Dirk Pranke.
2494
2495         * Scripts/webkitpy/layout_tests/port/base.py:
2496         (Port.path_to_test_expectations_file):
2497         (Port.expectations_dict):
2498         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2499         (PortTest.test_uses_test_expectations_file):
2500         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2501         (WebKitPortTest.test_path_to_test_expectations_file):
2502         (test_test_expectations):
2503         * Scripts/webkitpy/style/checker.py:
2504         (CheckerDispatcher.should_skip_without_warning):
2505         (CheckerDispatcher._create_checker):
2506         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2507         (TestExpectationsTestCase._expect_port_for_expectations_path):
2508         * Scripts/webkitpy/tool/steps/commit.py:
2509         (Commit._check_test_expectations):
2510         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2511         (CommitTest.test_check_test_expectations):
2512
2513 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2514
2515         nrwt: remove port.test_expectations() and port.test_expectations_overrides()
2516         https://bugs.webkit.org/show_bug.cgi?id=88948
2517
2518         Reviewed by Ojan Vafai.
2519
2520         In the final patch of this run, we remove the
2521         test_expectations() and test_expectation_overrides() methods
2522         from the Port class - callers must now use just
2523         expectations_dict().
2524
2525         Note that support for the cascade in new-run-webkit-tests is
2526         complete but only Chromium uses it; webkit-patch
2527         rebaseline-expectations still does not support updating entries
2528         in any file other than the first expectations file, however.
2529
2530         * Scripts/webkitpy/layout_tests/port/base.py:
2531         (Port.path_to_test_expectations_file):
2532         (Port.uses_test_expectations_file):
2533         (Port.expectations_files):
2534         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2535         (PortTest.test_additional_expectations):
2536         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2537         (ChromiumPortTest.test_expectations_files):
2538         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2539         (TestGoogleChromePort.test_get_google_chrome_port):
2540         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2541         (test_test_expectations):
2542         (test_legacy_test_expectations):
2543
2544 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2545
2546         nrwt: implement the actual cascade of TestExpectations
2547         https://bugs.webkit.org/show_bug.cgi?id=88947
2548
2549         Reviewed by Ojan Vafai.
2550
2551         This change implements the actual cascade by removing the
2552         concept of 'overrides' from the TestExpectations object and
2553         parsing each file separately.
2554
2555         There is an actual semantic change in this patch, in that
2556         setting an expectation on a directory in one file will override
2557         the expectations on any individual tests set in prior files. The
2558         test_overrides__directory() unit test verifies this.
2559
2560         Otherwise, this patch mostly consists of deleting code :).
2561
2562         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2563         (TestExpectationsModel.__init__):
2564         (TestExpectationsModel.add_expectation_line):
2565         (TestExpectationsModel._add_test):
2566         (TestExpectationsModel._already_seen_better_match):
2567         (TestExpectations.__init__):
2568         (TestExpectations._add_expectations):
2569         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2570         (test_overrides__directory):
2571
2572 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2573
2574         webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
2575         https://bugs.webkit.org/show_bug.cgi?id=88946
2576
2577         Reviewed by Ojan Vafai.
2578
2579         In preparation for fully supporting cascading expectations files
2580         and removing the 'overrides' concept.
2581
2582         There should be no functional changes in this patch.
2583
2584         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2585         (ManagerTest.test_update_summary_with_result):
2586         (ResultSummaryTest.get_result_summary):
2587         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2588         (TestExpectations.__init__):
2589         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2590         (parse_exp):
2591         (SkippedTests.check):
2592         (RemoveConfigurationsTest.test_remove):
2593         (test_remove_line):
2594         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2595         (LintTest.test_all_configurations.FakePort.__init__):
2596         (LintTest.test_all_configurations.FakePort.expectations_dict):
2597         (LintTest.test_lint_test_files__errors):
2598         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2599         (test_overrides_are_included_correctly):
2600
2601 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2602
2603         webkitpy: rework the TestExpectations style checker in preparation for the cascade
2604         https://bugs.webkit.org/show_bug.cgi?id=88945
2605
2606         Reviewed by Ojan Vafai.
2607
2608         This patch changes the style checker to call the
2609         TestExpectations parser directly and be oblivious as to what the
2610         port's actual expectations are.
2611
2612         * Scripts/webkitpy/style/checkers/test_expectations.py:
2613         (TestExpectationsChecker.__init__):
2614         (TestExpectationsChecker.check_test_expectations):
2615
2616 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2617
2618         nrwt: restructure the port classes to handle multiple expectations files
2619         https://bugs.webkit.org/show_bug.cgi?id=88944
2620
2621         Reviewed by Ojan Vafai.
2622
2623         This patch restructures the Port classes so that each port
2624         returns a list of TestExpectations files to be used (in a new, public,
2625         expectations_files() method), and the base implementation rolls them
2626         up into the ordered expectations_dict(), which becomes a public
2627         method.
2628
2629         port.path_to_test_expectations_file(), port.test_expectations(),
2630         and port.test_expectations_overrides() are then reimplemented as
2631         wrappers around port.expectations_dict().
2632         port.test_expectations() and port.test_expectations_overrides()
2633         will eventually be removed when the cascade is fully completed,
2634         and port.path_to_test_expectations_file() will be removed when
2635         the rebaselining tool supports the cascade
2636         (expectations_files() may also become private at that point).
2637
2638         There should be no functional changes in this patch, but a bunch
2639         of custom logic gets deleted!
2640
2641         * Scripts/webkitpy/layout_tests/port/base.py:
2642         (Port.expectations_dict):
2643         (Port):
2644         (Port.expectations_files):
2645         (Port.test_expectations):
2646         (Port.test_expectations_overrides):
2647         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2648         (PortTest.test_additional_expectations):
2649         (PortTest.test_uses_test_expectations_file):
2650         * Scripts/webkitpy/layout_tests/port/chromium.py:
2651         (ChromiumPort.all_baseline_variants):
2652         (ChromiumPort.expectations_files):
2653         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2654         (ChromiumPortTest.test_overrides_and_builder_names):
2655         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2656         (_expectations_files):
2657         (GoogleChromeLinux32Port.expectations_files):
2658         (GoogleChromeLinux64Port.expectations_files):
2659         (GoogleChromeMacPort.expectations_files):
2660         (GoogleChromeWinPort.expectations_files):
2661         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2662         (TestGoogleChromePort._verify_expectations_overrides):
2663         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2664         (PortTestCase.test_expectations_ordering):
2665         * Scripts/webkitpy/layout_tests/port/webkit.py:
2666         (WebKitPort._skipped_file_search_paths):
2667         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2668         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2669         (test_rebaseline_updates_expectations_file):
2670         (test_rebaseline_does_not_include_overrides):
2671         (test_rebaseline_expectations):
2672         (test_overrides_are_included_correctly):
2673
2674 2012-06-13  Brent Fulgham  <bfulgham@webkit.org>
2675
2676         [WinCairo] Update URL of WinCairoRequirements.zip download.
2677         https://bugs.webkit.org/show_bug.cgi?id=89009
2678
2679         Reviewed by Martin Robinson.
2680
2681         * Tools/Scripts/update-webkit-dependency: Put fallback code
2682         to download a "last update" time from servers that don't properly
2683         report Last-Modified in their HTTP header.
2684         * Tools/Scripts/update-webkit-wincairo-libs: Change download link
2685         for the WinCairo build requirements bundle.
2686
2687 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2688
2689         nrwt: preliminary cleanup before supporting cascading expectations files
2690         https://bugs.webkit.org/show_bug.cgi?id=88942
2691
2692         Reviewed by Ojan Vafai.
2693
2694         This change just prepares the TestExpectations parser to get filenames
2695         along with the expectations, and improves the warning messages so that
2696         they contain the filenames along with the line numbers.
2697
2698         There should be no functional changes in this patch.
2699
2700         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2701         (TestExpectationEditorTests.make_parsed_expectation_lines):
2702         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2703         (TestExpectationParser.parse):
2704         (TestExpectationParser.expectation_for_skipped_test):
2705         (TestExpectationParser._tokenize):
2706         (TestExpectationParser._tokenize_list):
2707         (TestExpectationLine):
2708         (TestExpectationsModel.__init__):
2709         (TestExpectationsModel._already_seen_better_match):
2710         (TestExpectations.__init__):
2711         (TestExpectations._shorten_filename):
2712         (TestExpectations._report_warnings):
2713         (TestExpectations._add_skipped_tests):
2714         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2715         (TestExpectationParserTests._tokenize):
2716         (TestExpectationParserTests.test_tokenize_blank):
2717         (TestExpectationParserTests.test_tokenize_missing_colon):
2718         (TestExpectationParserTests.test_tokenize_extra_colon):
2719         (TestExpectationParserTests.test_tokenize_empty_comment):
2720         (TestExpectationParserTests.test_tokenize_comment):
2721         (TestExpectationParserTests.test_tokenize_missing_equal):
2722         (TestExpectationParserTests.test_tokenize_extra_equal):
2723         (TestExpectationParserTests.test_tokenize_valid):
2724         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2725         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2726         (TestExpectationParserTests.test_parse_empty_string):
2727         (TestExpectationSerializerTests._tokenize):
2728         (TestExpectationSerializerTests.assert_round_trip):
2729         (TestExpectationSerializerTests.assert_list_round_trip):
2730         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2731         (GardeningExpectationsUpdater.update_expectations):
2732
2733 2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
2734
2735         [Gtk] Enable link prefetch support in the developer builds
2736         https://bugs.webkit.org/show_bug.cgi?id=89011
2737
2738         Reviewed by Martin Robinson.
2739
2740         Enable the link prefetch support for Gtk by default in developer
2741         builds.
2742
2743         * Scripts/webkitperl/FeatureList.pm:
2744
2745 2012-06-13  Csaba Osztrogonác  <ossy@webkit.org>
2746
2747         Update buildbot master in autoinstaller to match build.webkit.org
2748         https://bugs.webkit.org/show_bug.cgi?id=88992
2749
2750         Reviewed by Adam Barth.
2751
2752         * Scripts/webkitpy/thirdparty/__init__.py:
2753         (AutoinstallImportHook._install_buildbot):
2754
2755 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2756
2757         Unreviewed, rolling out r120209.
2758         http://trac.webkit.org/changeset/120209
2759         https://bugs.webkit.org/show_bug.cgi?id=89007
2760
2761         Broke the WebKit2 mac build. (Requested by andersca on
2762         #webkit).
2763
2764         * MiniBrowser/mac/BrowserWindowController.m:
2765         (-[BrowserWindowController awakeFromNib]):
2766         * WebKitTestRunner/TestController.cpp:
2767         (WTR::TestController::initialize):
2768
2769 2012-06-13  Zoltan Horvath  <zoltan@webkit.org>
2770
2771         check-webkit-style needs to respect Qt API coding style
2772         https://bugs.webkit.org/show_bug.cgi?id=88995
2773
2774         Reviewed by Csaba Osztrogonác.
2775
2776         Add -whitespace/declaration exception to Qt API files.
2777
2778         * Scripts/webkitpy/style/checker.py:
2779
2780 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
2781
2782         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
2783         https://bugs.webkit.org/show_bug.cgi?id=88340
2784
2785         Reviewed by Kenneth Rohde Christiansen.
2786
2787         Update initialization of WKPageLoaderClient.
2788
2789         * MiniBrowser/mac/BrowserWindowController.m:
2790         (-[BrowserWindowController awakeFromNib]):
2791         * WebKitTestRunner/TestController.cpp:
2792         (WTR::TestController::initialize):
2793
2794 2012-06-13  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2795
2796         [Qt] Handle multiple held buttons in touch mocking.
2797         https://bugs.webkit.org/show_bug.cgi?id=88865
2798
2799         Reviewed by Kenneth Rohde Christiansen.
2800
2801         Add handling for multiple held mouse-buttons in the appropiate places.
2802         To do this last-pos and start-pos are now also read from the last recorded
2803         touch-point instead from object-global variables.
2804
2805         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2806         (MiniBrowserApplication::notify):
2807         (MiniBrowserApplication::updateTouchPoint):
2808         * MiniBrowser/qt/MiniBrowserApplication.h:
2809         (MiniBrowserApplication):
2810
2811 2012-06-13  Simon Hausmann  <simon.hausmann@nokia.com>
2812
2813         [Qt] Make it possible to disable -Werror in production builds
2814
2815         Reviewed by Tor Arne Vestbø.
2816
2817         Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
2818         something qt5.git's qtwebkit.pri will soon do.
2819
2820         * qmake/mkspecs/features/unix/default_post.prf:
2821
2822 2012-06-13  Dominik Röttsches  <dominik.rottsches@intel.com>
2823
2824         [EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
2825         https://bugs.webkit.org/show_bug.cgi?id=85790
2826
2827         Reviewed by Gustavo Noronha Silva.
2828
2829         Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
2830         code in webkitdirs.pm.
2831
2832         * Scripts/webkitdirs.pm:
2833         (jhbuildConfigurationChanged):
2834         (saveJhbuildMd5):
2835         (cleanJhbuild):
2836         (buildAutotoolsProject):
2837         (generateBuildSystemFromCMakeProject):
2838
2839 2012-06-13  Qi Zhang  <qi.2.zhang@nokia.com>
2840
2841         [Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
2842         https://bugs.webkit.org/show_bug.cgi?id=88763
2843
2844         Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
2845         extension.
2846
2847         Reviewed by Simon Hausmann.
2848
2849         * qmake/config.tests/libzlib: Added.
2850         * qmake/config.tests/libzlib/libzlib.cpp: Added.
2851         (main):
2852         * qmake/config.tests/libzlib/libzlib.pro: Added.
2853         * qmake/mkspecs/features/features.prf:
2854         * qmake/sync.profile:
2855
2856 2012-06-13  Robin Cao  <robin.cao@torchmobile.com.cn>
2857
2858         [BlackBerry] Enable MEDIA_STREAM by default
2859         https://bugs.webkit.org/show_bug.cgi?id=88849
2860
2861         Reviewed by Antonio Gomes.
2862
2863         * Scripts/webkitperl/FeatureList.pm:
2864
2865 2012-06-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2866
2867         Prevent stderr output from messing up detection of build path
2868
2869         https://bugs.webkit.org/show_bug.cgi?id=88075
2870
2871         Warnings such as 'perl: warning: Setting locale failed' will otherwise
2872         end up as the build path when calling out to webkit-build-directory.
2873
2874         Reviewed by Ojan Vafai.
2875
2876         * Scripts/webkitpy/layout_tests/port/config.py:
2877         (Config.build_directory):
2878
2879 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
2880
2881         Update the builder name for Apple Lion builders.
2882
2883         * Scripts/webkitpy/layout_tests/port/builders.py:
2884
2885 2012-06-13  Joel Dillon  <joel.dillon@codethink.co.uk>
2886
2887         [Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
2888         https://bugs.webkit.org/show_bug.cgi?id=88874
2889
2890         Reviewed by Simon Hausmann.
2891
2892         Rename main.cpp in QtTestBrowser because on Windows
2893         it conflicts with main.cpp from DumpRenderTree.
2894
2895         * QtTestBrowser/QtTestBrowser.pro:
2896         * QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.
2897         (launcherMain):
2898         (LauncherApplication):
2899         (LauncherApplication::urls):
2900         (LauncherApplication::isRobotized):
2901         (LauncherApplication::robotTimeout):
2902         (LauncherApplication::robotExtraTime):
2903         (LauncherApplication::applyDefaultSettings):
2904         (LauncherApplication::LauncherApplication):
2905         (requiresGraphicsView):
2906         (LauncherApplication::handleUserOptions):
2907         (main):
2908
2909 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2910
2911         Wrap bot types inside ().
2912         https://bugs.webkit.org/show_bug.cgi?id=88893
2913
2914         Reviewed by Stephanie Lewis.
2915
2916         * BuildSlaveSupport/build.webkit.org-config/config.json:
2917
2918 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2919
2920         [soup] Prevent setting or editing httpOnly cookies from JavaScript
2921         https://bugs.webkit.org/show_bug.cgi?id=88760
2922
2923         Reviewed by Gustavo Noronha Silva.
2924
2925         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
2926         to v2.33.2 for both GTK and EFL ports.
2927
2928         * efl/jhbuild.modules:
2929         * gtk/jhbuild.modules:
2930
2931 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2932
2933         [EFL] Enable SHADOW_DOM flag
2934         https://bugs.webkit.org/show_bug.cgi?id=87732
2935
2936         Reviewed by Kentaro Hara.
2937
2938         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2939         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
2940         SHADOW_DOM by default in DRT.
2941         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2942         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
2943         Chromium and Mac ports.
2944         (drtViewAdd):
2945         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
2946         at compile time for EFL port.
2947
2948 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2949
2950         WinLauncher should show loading errors
2951         https://bugs.webkit.org/show_bug.cgi?id=80760
2952
2953         Reviewed by Brent Fulgham.
2954
2955         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
2956         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2957         * WinLauncher/WinLauncher.h:
2958         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2959         (WinLauncherWebHost):
2960
2961 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
2962
2963         [EFL][WK2] Add MiniBrowserEfl.
2964         https://bugs.webkit.org/show_bug.cgi?id=61850
2965
2966         Reviewed by Chang Shu.
2967
2968         Implement MiniBrowser for EFL.
2969
2970         * CMakeLists.txt:
2971         * MiniBrowser/efl/CMakeLists.txt: Added.
2972         * MiniBrowser/efl/main.c: Added.
2973         (_MiniBrowser):
2974         (main_signal_exit):
2975         (on_ecore_evas_resize):
2976         (browserCreate):
2977         (main):
2978
2979 2012-06-12  Helder Correia  <helder.correia@nokia.com>
2980
2981         Unreviewed. Update my email address in committers.py.
2982
2983         * Scripts/webkitpy/common/config/committers.py:
2984
2985 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
2986
2987         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
2988         https://bugs.webkit.org/show_bug.cgi?id=84707
2989
2990         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
2991         use_lib64 variable is preconfigured to True by jhbuild.
2992
2993         Reviewed by Dirk Pranke.
2994
2995         * efl/jhbuildrc:
2996
2997 2012-06-12  Dana Jansens  <danakj@chromium.org>
2998
2999         Add zlieber@chromium.org to contributors list
3000         https://bugs.webkit.org/show_bug.cgi?id=88904
3001
3002         Unreviewed.
3003
3004         * Scripts/webkitpy/common/config/committers.py:
3005
3006 2012-06-12  Lucas Forschler  <lforschler@apple.com>
3007
3008         Rename Apple bots to a standard convention.
3009         https://bugs.webkit.org/show_bug.cgi?id=88893
3010
3011         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
3012
3013         Reviewed by Simon Fraser.
3014
3015         * BuildSlaveSupport/build.webkit.org-config/config.json:
3016
3017 2012-06-12  Mike West  <mkwst@chromium.org>
3018
3019         Make document.documentURI readonly from JavaScript
3020         https://bugs.webkit.org/show_bug.cgi?id=65187
3021
3022         Reviewed by Alexey Proskuryakov.
3023
3024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3025         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
3026         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
3027         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
3028         (TestWebKitAPI):
3029         (TestWebKitAPI::TEST):
3030
3031 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
3032
3033         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
3034         https://bugs.webkit.org/show_bug.cgi?id=88715
3035
3036         Reviewed by Noam Rosenthal.
3037
3038         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
3039
3040         * Scripts/webkitperl/FeatureList.pm:
3041
3042 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3043
3044         [Qt] Fix -Werror for the buildbots
3045         https://bugs.webkit.org/show_bug.cgi?id=88223
3046
3047         Rubber-stamped by Tor Arne Vestbø.
3048
3049         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
3050
3051         * qmake/mkspecs/features/unix/default_post.prf:
3052
3053 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
3054
3055         [REGRESSION][WTR] Build fail with werror after r120054
3056         https://bugs.webkit.org/show_bug.cgi?id=88862
3057
3058         Reviewed by Csaba Osztrogonác.
3059
3060         Some static helpers become unused after counterValueForElementById
3061         has moved to Internals. Let's remove them.
3062
3063         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3064         (WTR):
3065
3066 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3067
3068         [Qt] Slave losts cause build break on bots
3069         https://bugs.webkit.org/show_bug.cgi?id=38980
3070
3071         Minor fix after r59261.
3072
3073         Reviewed by Tor Arne Vestbø.
3074
3075         * Scripts/build-webkit:
3076         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
3077
3078 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3079
3080         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
3081         https://bugs.webkit.org/show_bug.cgi?id=84406
3082
3083         Reviewed by Hajime Morita.
3084
3085         Move the counterValueForElementById from LayoutTestCotroller to Internals and
3086         remove the old platform specific implementations as it exclusively tests WebCore functionality.
3087
3088         * DumpRenderTree/LayoutTestController.cpp:
3089         (LayoutTestController::staticFunctions):
3090         * DumpRenderTree/LayoutTestController.h:
3091         (LayoutTestController):
3092         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3093         * DumpRenderTree/chromium/LayoutTestController.cpp:
3094         (LayoutTestController::LayoutTestController):
3095         (LayoutTestController::setPOSIXLocale):
3096         * DumpRenderTree/chromium/LayoutTestController.h:
3097         (LayoutTestController):
3098         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3099         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3100         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3101         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3102         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3103         (LayoutTestController):
3104         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3105         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3106         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3107         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3108         (WTR):
3109         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3110         (LayoutTestController):
3111
3112 2012-06-11  Hans Wennborg  <hans@chromium.org>
3113
3114         Speech JavaScript API: Make SpeechRecognitionError an Event
3115         https://bugs.webkit.org/show_bug.cgi?id=88784
3116
3117         Reviewed by Adam Barth.
3118
3119         Make it possible to have MockWebSpeechRecognizer fire error events.
3120
3121         * DumpRenderTree/chromium/LayoutTestController.cpp:
3122         (LayoutTestController::LayoutTestController):
3123         (LayoutTestController::setMockSpeechRecognitionError):
3124         * DumpRenderTree/chromium/LayoutTestController.h:
3125         (LayoutTestController):
3126         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
3127         (WebKit):
3128         (ErrorTask):
3129         (WebKit::ErrorTask::ErrorTask):
3130         (MockWebSpeechRecognizer::addMockResult):
3131         (MockWebSpeechRecognizer::setError):
3132         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
3133         (MockWebSpeechRecognizer):
3134
3135 2012-06-11  Ojan Vafai  <ojan@chromium.org>
3136
3137         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
3138         https://bugs.webkit.org/show_bug.cgi?id=88836
3139
3140         Reviewed by Dirk Pranke.
3141
3142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
3143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3144
3145 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
3146
3147         [EFL] Remove CMakeCache.txt before building
3148         https://bugs.webkit.org/show_bug.cgi?id=88717
3149
3150         Reviewed by Antonio Gomes.
3151
3152         Remove CMake cache file before every build to avoid using outdated
3153         build flags when new features get enabled. This will avoid unexpected
3154         failures on the bots due to outdated build flags.
3155
3156         * Scripts/webkitdirs.pm:
3157         (generateBuildSystemFromCMakeProject):
3158
3159 2012-06-11  Vincent Scheib  <scheib@chromium.org>
3160
3161         Add new Pointer Lock spec attribute webkitPointerLockElement.
3162         https://bugs.webkit.org/show_bug.cgi?id=88799
3163
3164         Reviewed by Dimitri Glazkov.
3165
3166         Part of a series of refactoring changes to update pointer lock API to
3167         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
3168
3169         New attribute webkitPointerLockElement added. Follow up patches
3170         will remove the previous isLocked attribute. Tests updated to use
3171         the new attribute.
3172
3173         WebViewHost logic required modification to correctly repond to
3174         a lock, unlock, pointerLockElement call series. Specifically,
3175         unlocking must be queued after a lock command is issued always
3176         as the lock state may not be set yet with a lock request in flight.
3177
3178         * DumpRenderTree/chromium/WebViewHost.cpp:
3179         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
3180         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
3181
3182 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
3183
3184         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
3185         https://bugs.webkit.org/show_bug.cgi?id=88804
3186
3187         Reviewed by Tony Chang.
3188
3189         Protect box-decoration-break behind a feature flag enabled by default.
3190
3191         * Scripts/webkitperl/FeatureList.pm:
3192         * qmake/mkspecs/features/features.pri:
3193
3194 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3195
3196         [CMAKE][EFL] Remove duplicated executable output path
3197         https://bugs.webkit.org/show_bug.cgi?id=88765
3198
3199         Reviewed by Daniel Bates.
3200
3201         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
3202         need to define again because it is already defined in top-level CMake file.
3203
3204         * DumpRenderTree/efl/CMakeLists.txt:
3205         * EWebLauncher/CMakeLists.txt:
3206
3207 2012-06-11  Ojan Vafai  <ojan@chromium.org>
3208
3209         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
3210         https://bugs.webkit.org/show_bug.cgi?id=88816
3211
3212         Reviewed by Dirk Pranke.
3213
3214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3215         Expose a way to clear AsynchronousCaches.
3216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
3217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3218         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
3219
3220 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
3221
3222         nrwt exits early too frequently
3223         https://bugs.webkit.org/show_bug.cgi?id=73843
3224
3225         Reviewed by Ryosuke Niwa.
3226
3227         Change the defaults for new-run-webkit-tests for both
3228         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
3229         to zero (i.e., we will never exit early by default).
3230
3231         If people want their buildbots to exit early it is their
3232         responsibility to update their buildbot configs appropriately.
3233
3234         Note that we have tests that ensure that these flags work for
3235         non-zero numbers, but we don't have tests that either test the
3236         default or ensure that zero means "run all of the tests". I
3237         think that's okay but can add tests if others disagree.
3238
3239         Also note that it looks like no changes on the build.webkit.org
3240         master.cfg are necessary; all of the bots seem to be using the
3241         RunWebKitTests wrapper which is already setting the flags. There
3242         is a NewRunWebKitTests wrapper, but that looks to be unused; I
3243         will delete that in a separate patch.
3244
3245         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3246         (parse_args):
3247
3248 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3249
3250         [EFL] [DRT] Reset CacheModel before running each test
3251         https://bugs.webkit.org/show_bug.cgi?id=87534
3252
3253         Reviewed by Gustavo Noronha Silva.
3254
3255         Reset cache model to default before running each test to fix some
3256         flaky tests on EFL build bots. Also fix case value in setCacheModel.
3257
3258         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3259         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3260         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3261         (LayoutTestController::setCacheModel):
3262
3263 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3264
3265         [GTK] Memory leaks in DRT EventSender.cpp
3266         https://bugs.webkit.org/show_bug.cgi?id=88774
3267
3268         Reviewed by Martin Robinson.
3269
3270         Fix a few possible memory leaks in EventSender code.
3271
3272         * DumpRenderTree/gtk/EventSender.cpp:
3273         (contextClickCallback): Free the event returned by gdk_event_new().
3274         (mouseDownCallback): Ditto.
3275         (mouseUpCallback): Ditto.
3276
3277 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3278
3279         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
3280         https://bugs.webkit.org/show_bug.cgi?id=88661
3281
3282         Reviewed by Dirk Pranke.
3283
3284         Pass string length explicitly when creating String object from
3285         non-null-terminated UChar* returned by characters().
3286
3287         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3288         (LayoutTestController::pathToLocalResource):
3289
3290 2012-06-11  David Dorwin  <ddorwin@chromium.org>
3291
3292         [chromium] Provide access to the WebPlugin created by the helper plugin widget
3293         https://bugs.webkit.org/show_bug.cgi?id=88028
3294
3295         Reviewed by Adam Barth.
3296
3297         Added isPlaceholder() to WebPlugin.
3298
3299         * DumpRenderTree/chromium/TestWebPlugin.h:
3300         (TestWebPlugin::isPlaceholder):
3301
3302 2012-06-11  Tony Chang  <tony@chromium.org>
3303
3304         rebaseline from garden-o-matic leaves N processes each time it is run
3305         https://bugs.webkit.org/show_bug.cgi?id=88586
3306
3307         Reviewed by Dirk Pranke.
3308
3309         This appears to only be a problem on python 2.7. Maybe a bug causing
3310         pools to not be garbage collected?
3311
3312         * Scripts/webkitpy/common/system/executive.py:
3313         (Executive.run_in_parallel): close() and join() the process pool.
3314         * Scripts/webkitpy/common/system/executive_unittest.py:
3315         (ExecutiveTest.test_run_in_parallel):
3316
3317 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
3318
3319         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
3320         https://bugs.webkit.org/show_bug.cgi?id=87841
3321
3322         Reviewed by Simon Hausmann.
3323
3324         * qmake/config.tests/libwebp/libwebp.cpp: Added.
3325         (main):
3326         * qmake/config.tests/libwebp/libwebp.pro: Added.
3327         * qmake/sync.profile:
3328
3329 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
3330
3331         Expose layoutTestController as testRunner
3332         https://bugs.webkit.org/show_bug.cgi?id=88210
3333
3334         Reviewed by Darin Adler.
3335
3336         * DumpRenderTree/LayoutTestController.cpp:
3337         (LayoutTestController::makeWindowObject):
3338         * DumpRenderTree/chromium/TestShell.cpp:
3339         (TestShell::bindJSObjectsToWindow):
3340         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3341         (WebCore::DumpRenderTree::initJSObjects):
3342         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3343         (WTR::LayoutTestController::makeWindowObject):
3344
3345 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
3346
3347         [Chromium] Remove JavaScriptCore dependencies from gyp
3348         https://bugs.webkit.org/show_bug.cgi?id=88510
3349
3350         Reviewed by Adam Barth.
3351
3352         Chromium doesn't support JSC any more and there doesn't seem to be
3353         a strong interest in using GYP as the common build system in other
3354         ports.
3355
3356         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3357         * Scripts/generate-project-files: Removed.
3358
3359 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
3360
3361         Add UNDO_MANAGER flag
3362         https://bugs.webkit.org/show_bug.cgi?id=87908
3363
3364         Reviewed by Tony Chang.
3365
3366         * Scripts/webkitperl/FeatureList.pm:
3367         * qmake/mkspecs/features/features.pri:
3368
3369 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3370
3371         webkit-patch land-safely should set cq? if the patch author is not in committers.py
3372         https://bugs.webkit.org/show_bug.cgi?id=88689
3373
3374         Reviewed by Dirk Pranke.
3375
3376         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
3377         in committers.py or the contributor cannot commit. If anything, the contributor can still
3378         set cq+ on thier patches manually so I don't think this will be an issue for people who
3379         don't list their Bugzille email on committers.py.
3380
3381         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3382         (Bugzilla._commit_queue_flag):
3383         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3384         (test_commit_queue_flag):
3385         (test_commit_queue_flag.assert_commit_queue_flag):
3386
3387 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
3388
3389         remove obsolete NewRunWebKitTests buildbot master factory classes
3390         https://bugs.webkit.org/show_bug.cgi?id=88693
3391
3392         Reviewed by Ryosuke Niwa.
3393
3394         I believe these aren't used any more ...
3395
3396         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3397         (RunWebKitTests.getText2):
3398         (BuildAndTestLeaksFactory):
3399
3400 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
3401
3402         [Chromium-Android] Build DumpRenderTree with Android SDK
3403         https://bugs.webkit.org/show_bug.cgi?id=88598
3404
3405         Change WebKit side of DRT related code according to some recent changes at chromium side.
3406
3407         Reviewed by Adam Barth.
3408
3409         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3410         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3411         (ChromiumAndroidPort.__init__):
3412         (ChromiumAndroidPort._path_to_driver):
3413
3414 2012-06-08  Wei James  <james.wei@intel.com>
3415
3416         Add app_abi option for DumpRenderTree_apk
3417         https://bugs.webkit.org/show_bug.cgi?id=88626
3418
3419         Reviewed by Adam Barth.
3420
3421         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3422
3423 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3424
3425         [GTK] Add API to get the library version to WebKit2 GTK+
3426         https://bugs.webkit.org/show_bug.cgi?id=88426
3427
3428         Reviewed by Martin Robinson.
3429
3430         * gtk/generate-gtkdoc:
3431         (get_webkit2_options): Add built sources to the list of files, but
3432         ignore enum types and marshallers.
3433
3434 2012-06-07  Vincent Scheib  <scheib@chromium.org>
3435
3436         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
3437         https://bugs.webkit.org/show_bug.cgi?id=88604
3438
3439         Reviewed by Kent Tamura.
3440
3441         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
3442         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
3443
3444         * DumpRenderTree/chromium/WebViewHost.cpp:
3445         (WebViewHost::requestPointerUnlock):
3446
3447 2012-06-08  Hans Wennborg  <hans@chromium.org>
3448
3449         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
3450         https://bugs.webkit.org/show_bug.cgi?id=87976
3451
3452         Reviewed by Kent Tamura.
3453
3454         Provide a mock implementation of WebSpeechRecognizer for
3455         DumpRenderTree. This will allow better testing of the API via layout
3456         tests.
3457
3458         * DumpRenderTree/DumpRenderTree.gypi:
3459         * DumpRenderTree/chromium/LayoutTestController.cpp:
3460         (LayoutTestController::LayoutTestController):
3461         (LayoutTestController::addMockSpeechRecognitionResult):
3462         * DumpRenderTree/chromium/LayoutTestController.h:
3463         (LayoutTestController):
3464         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
3465         (MockWebSpeechRecognizer::create):
3466         (MockWebSpeechRecognizer::start):
3467         (MockWebSpeechRecognizer::stop):
3468         (MockWebSpeechRecognizer::abort):
3469         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
3470         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
3471         (MockWebSpeechRecognizer::ResultTask::runIfValid):
3472         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
3473         (WebKit):
3474         (MockWebSpeechRecognizer):
3475         (MockWebSpeechRecognizer::addMockResult):
3476         (MockWebSpeechRecognizer::taskList):
3477         (ClientCallTask):
3478         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
3479         (ResultTask):
3480         (MockWebSpeechRecognizer::ResultTask::ResultTask):
3481         (NoMatchTask):
3482         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
3483         * DumpRenderTree/chromium/WebViewHost.cpp:
3484         (WebViewHost::speechRecognizer):
3485         * DumpRenderTree/chromium/WebViewHost.h:
3486         (WebViewHost):
3487         (WebViewHost::mockSpeechRecognizer):
3488
3489 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
3490
3491         check-webkit-style needs to be taught about <public/Foo.h>
3492         https://bugs.webkit.org/show_bug.cgi?id=88524
3493
3494         Reviewed by David Levin.
3495
3496         * Scripts/webkitpy/style/checkers/cpp.py:
3497         (_classify_include):
3498         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3499         (OrderOfIncludesTest.test_public_primary_header):
3500         (OrderOfIncludesTest.test_classify_include):
3501
3502 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
3503
3504         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
3505         https://bugs.webkit.org/show_bug.cgi?id=67255
3506
3507         Reviewed by Dirk Pranke.
3508
3509         Implement pathToLocalResource to redirect file:///tmp URL's to
3510         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
3511         LayoutTests sub-directory of the WebKit source tree.
3512
3513         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3514         (LayoutTestController::pathToLocalResource):
3515
3516 2012-06-07  Tony Payne  <tpayne@chromium.org>
3517
3518         [chromium] Allow LayoutTests under new git workflow
3519         https://bugs.webkit.org/show_bug.cgi?id=88575
3520
3521         On Windows, chromium indirects through git.bat. Adds the same hack that
3522         is currently used for discovering svn.bat to support the new git
3523         workflow.
3524
3525         Reviewed by Dirk Pranke.
3526
3527         * Scripts/webkitpy/common/checkout/scm/git.py:
3528         (Git): Replaces all hard-coded references to 'git' with the class
3529         variable executable_name.
3530         (Git._check_git_architecture):
3531         (Git.in_working_directory):
3532         (Git.find_checkout_root):
3533         (Git.read_git_config):
3534         (Git.discard_local_commits):
3535         (Git.local_commits):
3536         (Git.working_directory_is_clean):
3537         (Git.clean_working_directory):
3538         (Git.status_command):
3539         (Git.add_list):
3540         (Git.delete_list):
3541         (Git.exists):
3542         (Git._current_branch):
3543         (Git.changed_files):
3544         (Git._changes_files_for_commit):
3545         (Git.revisions_changing_file):
3546         (Git.conflicted_files):
3547         (Git.svn_revision):
3548         (Git.create_patch):
3549         (Git._run_git_svn_find_rev):
3550         (Git.contents_at_revision):
3551         (Git.diff_for_file):
3552         (Git.show_head):
3553         (Git.committer_email_for_revision):
3554         (Git.apply_reverse_diff):
3555         (Git.revert_files):
3556         (Git.commit_with_message):
3557         (Git._commit_on_branch):
3558         (Git.svn_commit_log):
3559         (Git.last_svn_commit_log):
3560         (Git.svn_blame):
3561         (Git._branch_ref_exists):
3562         (Git.delete_branch):
3563         (Git.remote_merge_base):
3564         (Git.commit_locally_with_message):
3565         (Git.push_local_commits_to_server):
3566         (Git.commit_ids_from_commitish_arguments):
3567         (Git.commit_message_for_local_commit):
3568         (Git.files_changed_summary_for_commit):
3569         * Scripts/webkitpy/common/host.py:
3570         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
3571         that duplicates the logic in the existing 'svn.bat' hack.
3572
3573 2012-06-07  Ojan Vafai  <ojan@chromium.org>
3574
3575         Style build architectures like build versions for non-layout test failures
3576         https://bugs.webkit.org/show_bug.cgi?id=88590
3577
3578         Reviewed by Tony Chang.
3579
3580         Since we show the list of failing tests after the architecture, we want the
3581         buildtype and architecture to be grouped together visually.
3582
3583         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3584         (.effects a.failing-builder>span.architecture):
3585
3586 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
3587
3588         [Chromium] Remove header dependency of ImageDiff to WTF
3589         https://bugs.webkit.org/show_bug.cgi?id=88422
3590
3591         Reviewed by Ryosuke Niwa.
3592
3593         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3594         * DumpRenderTree/chromium/ImageDiff.cpp:
3595         (untestedCompareImages):
3596
3597 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
3598
3599         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
3600         https://bugs.webkit.org/show_bug.cgi?id=88491
3601
3602         Reviewed by Dirk Pranke.
3603
3604         DRT should enable WebAudio when WebAudio feature is enabled,
3605         so that the WebAudio feature could be tested by the Layouttest.
3606
3607         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
3608         (LayoutTestController::overridePreference):
3609
3610 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
3611
3612         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
3613         https://bugs.webkit.org/show_bug.cgi?id=88581
3614
3615         Reviewed by Ojan Vafai.
3616
3617         webkit-paptch rebaseline-expectations was ignoring what the
3618         expected results for a test were and pulling down all the result
3619         files from a bot. This could lead to us pulling down old,
3620         incorrect .txt or .png files. With this patch we will now only
3621         pull down expectations of the appropriate file types (so an
3622         IMAGE failure will only pull the png and not the txt file).
3623
3624         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3625         (has_pixel_failures):
3626         (suffixes_for_expectations):
3627         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3628         (FunctionsTest.test_suffixes_for_expectations):
3629         * Scripts/webkitpy/tool/commands/rebaseline.py:
3630         (AbstractRebaseliningCommand.__init__):
3631         (RebaselineExpectations._is_supported_port):
3632         (RebaselineExpectations._update_expectations_file):
3633         (RebaselineExpectations._tests_to_rebaseline):
3634         (RebaselineExpectations._rebaseline_port):
3635         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3636         (test_overrides_are_included_correctly):
3637
3638 2012-06-07  Ojan Vafai  <ojan@chromium.org>
3639
3640         Fix recent null pointer error regression in the flakiness dashboard
3641         https://bugs.webkit.org/show_bug.cgi?id=88573
3642
3643         Reviewed by Dirk Pranke.
3644
3645         * TestResultServer/static-dashboards/builders.js:
3646         (requestBuilderList):
3647         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3648
3649 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
3650
3651         Add Konrad Piascik to committers.py
3652         https://bugs.webkit.org/show_bug.cgi?id=88560
3653
3654         Unreviewed.
3655
3656         * Scripts/webkitpy/common/config/committers.py:
3657
3658 2012-06-07  Tony Chang  <tony@chromium.org>
3659
3660         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
3661         https://bugs.webkit.org/show_bug.cgi?id=77368
3662
3663         Reviewed by Ojan Vafai.
3664
3665         It doesn't look like we ever get a rect with width or height of 0.
3666         I ran css1, css2.1, fast/forms, and tables without any crashes.
3667
3668         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3669         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
3670
3671 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
3672
3673         run-webkit-tests --lint-test-files gives an error when run on linux
3674         https://bugs.webkit.org/show_bug.cgi?id=88551
3675
3676         Reviewed by Ojan Vafai.
3677
3678         We weren't mapping the expectations properly for the
3679         google-chrome ports.
3680
3681         * Scripts/webkitpy/layout_tests/port/base.py:
3682         (Port.path_to_test_expectations_file):
3683         * Scripts/webkitpy/layout_tests/port