6ae58a52828588ef4fdb56c42558aa7d9360917c
[WebKit-https.git] / Tools / ChangeLog
1 2011-02-06  Andreas Kling  <kling@webkit.org>
2
3         Reviewed by Antonio Gomes.
4
5         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
6         https://bugs.webkit.org/show_bug.cgi?id=53869
7
8         * MiniBrowser/qt/BrowserView.cpp:
9         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
10         * MiniBrowser/qt/BrowserWindow.cpp:
11         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
12         * MiniBrowser/qt/BrowserWindow.h:
13
14 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
15
16         Reviewed by Dan Bernstein.
17
18         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
19         https://bugs.webkit.org/show_bug.cgi?id=42690
20         <rdar://problem/8213851>
21
22         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
23         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
24         (WTR::InjectedBundlePage::willSendRequestForFrame):
25         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
26         (WTR::LayoutTestController::LayoutTestController):
27         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
28         (WTR::LayoutTestController::willSendRequestReturnsNull):
29         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
30
31 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
32
33         Unreviewed, rolling out r77720.
34         http://trac.webkit.org/changeset/77720
35         https://bugs.webkit.org/show_bug.cgi?id=53854
36
37         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
38         #webkit).
39
40         * Scripts/webkitpy/common/system/executive.py:
41
42 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
43
44         Unreviewed, rolling out r77725.
45         http://trac.webkit.org/changeset/77725
46         https://bugs.webkit.org/show_bug.cgi?id=53844
47
48         It broke Qt minimal build (Requested by Ossy_ on #webkit).
49
50         * QtTestBrowser/launcherwindow.cpp:
51         (LauncherWindow::createChrome):
52         * QtTestBrowser/launcherwindow.h:
53         (WindowOptions::WindowOptions):
54         * QtTestBrowser/main.cpp:
55         (LauncherApplication::handleUserOptions):
56
57 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
58
59         Reviewed by Adam Barth.
60
61         [GTK] plugins/plugin-document-back-forward.html fails
62         https://bugs.webkit.org/show_bug.cgi?id=53833
63
64         Add the new "alert on load" functionality for the Unix version of the
65         test plugin. This functionality was originally introduced in r77706.
66
67         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
68         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
69
70 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
71
72         Reviewed by Andreas Kling.
73
74         Local Storage settings can be enable/disable from "Develop" menu
75         https://bugs.webkit.org/show_bug.cgi?id=52296
76
77         * QtTestBrowser/launcherwindow.cpp:
78         (LauncherWindow::createChrome):
79         (LauncherWindow::toggleLocalStorage):
80         (LauncherWindow::toggleOfflineStorageDatabase):
81         (LauncherWindow::toggleOfflineWebApplicationCache):
82         (LauncherWindow::setOfflineStorageDefaultQuota):
83         * QtTestBrowser/launcherwindow.h:
84         (WindowOptions::WindowOptions):
85         * QtTestBrowser/main.cpp:
86         (LauncherApplication::handleUserOptions):
87
88 2011-02-04  Tony Chang  <tony@chromium.org>
89
90         Reviewed by Eric Seidel.
91
92         get test-webkitpy running on win32 python
93         https://bugs.webkit.org/show_bug.cgi?id=53822
94
95         The test harness crashes with a WindowsError because it can't find
96         'svn' when using subprocess.Popen.  This gets us past the error
97         so we can see the failing tests on the Chromium Win Release Tests
98         bot.
99
100         * Scripts/webkitpy/common/system/executive.py:
101
102 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
103
104         Reviewed by Gustavo Noronha Silva.
105
106         [GTK] fast/events/pagehide-timeout.html fails
107         https://bugs.webkit.org/show_bug.cgi?id=53771
108
109         Add knowledge of the document browser cache model the DRT. When resetting
110         WebKit settings to consistent values between tests, default to the document
111         browser cache model.
112
113         * DumpRenderTree/gtk/DumpRenderTree.cpp:
114         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
115         cache model between tests.
116         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
117         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
118         document browser cache model.
119
120 2011-02-04  Adam Barth  <abarth@webkit.org>
121
122         Reviewed by Eric Seidel.
123
124         PluginDocuments don't create widgets for plugins on back/forward
125         https://bugs.webkit.org/show_bug.cgi?id=53474
126
127         Teach the test plugin how to call alert on load.
128
129         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
130         (NPP_New):
131
132 2011-02-04  Adam Roben  <aroben@apple.com>
133
134         Add a test case for encode/decode of FormData/FormDataElement
135
136         If the fix made in r77401 is broken, this new test will crash.
137
138         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
139
140         Reviewed by Sam Weinig.
141
142         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
143         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
144
145         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
146         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
147         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
148         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
149         form, an return the session state data.
150         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
151         and restore it into another WKPage.
152
153         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
154
155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
156         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
157         * TestWebKitAPI/win/copy-resources.cmd:
158         Added new files.
159
160 2011-02-04  Adam Roben  <aroben@apple.com>
161
162         Move code to run JavaScript tests into its own files
163
164         This will allow other tests to use this mechanism.
165
166         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
167         world
168
169         Reviewed by Sam Weinig.
170
171         * TestWebKitAPI/JavaScriptTest.cpp: Added.
172         * TestWebKitAPI/JavaScriptTest.h: Added.
173         Moved code here...
174
175         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
176
177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
178         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
179         Added the new files.
180
181 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
182
183         Reviewed by Mihai Parparita.
184
185         merge test expectations for chromium, chromium-gpu. The
186         chromium-gpu port will no longer maintain its own
187         test expectations file.
188
189         Also add in a graphics_type() call on the port object to
190         determine what graphics type to use in the test configuration,
191         and log the configuration as a config setting.
192
193         https://bugs.webkit.org/show_bug.cgi?id=53562
194
195         * Scripts/webkitpy/layout_tests/port/base.py:
196         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
197         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
198         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
199
200 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
201
202         Reviewed by Pavel Feldman.
203
204         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
205         https://bugs.webkit.org/show_bug.cgi?id=53781
206
207         * Scripts/check-inspector-strings:
208
209 2011-02-04  Adam Roben  <aroben@apple.com>
210
211         Include the crashing function in the link to a crash log on Mac
212
213         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
214         function that crashed on Mac
215
216         Reviewed by David Kilzer.
217
218         * Scripts/old-run-webkit-tests:
219         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
220         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
221         the crash log.
222
223 2011-02-04  Adam Roben  <aroben@apple.com>
224
225         Link to Mac crash logs from results.html
226
227         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
228         results.html
229
230         Reviewed by David Kilzer.
231
232         * Scripts/old-run-webkit-tests:
233         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
234         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
235
236 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
237
238         Reviewed by Dan Bernstein.
239
240         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
241         https://bugs.webkit.org/show_bug.cgi?id=52897
242         <rdar://problem/8898294>
243
244         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
245         (WTR::InjectedBundlePage::InjectedBundlePage):
246         (WTR::InjectedBundlePage::willSendRequestForFrame):
247         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
248
249 2011-02-03  Ivan Krstić  <ike@apple.com>
250
251         Unreviewed.
252
253         Adding myself to committers.py.
254
255         * Scripts/webkitpy/common/config/committers.py:
256
257 2011-02-03  James Kozianski  <koz@chromium.org>
258
259         Reviewed by Dimitri Glazkov.
260
261         Add navigator.registerProtocolHandler behind a flag.
262         https://bugs.webkit.org/show_bug.cgi?id=52609
263
264         * Scripts/build-webkit:
265
266 2011-02-03  Hayato Ito  <hayato@chromium.org>
267
268         Reviewed by Eric Seidel.
269
270         [NRWT] Remove TestArgs class, which is wrongly used.
271
272         https://bugs.webkit.org/show_bug.cgi?id=53063
273
274         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
275         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
276         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
277         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
278         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
279         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
280
281 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
282
283         Reviewed by Kenneth Russell.
284
285         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
286         https://bugs.webkit.org/show_bug.cgi?id=53714
287
288         * Scripts/build-webkit: change --3d-canvas build option
289           to set ENABLE_WEBGL
290
291 2011-02-03  Hayato Ito  <hayato@chromium.org>
292
293         Reviewed by Tony Chang.
294
295         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
296         move _run_single_test() and _process_output() functions from
297         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
298
299         This is clean up and acts as a preparation for elimination of test_types/*
300         classes. These classes will move to the single_test_runner module introduced
301         in this patch.
302
303         https://bugs.webkit.org/show_bug.cgi?id=53004
304
305         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
306         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
307         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
308         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
309         * Scripts/webkitpy/layout_tests/port/base.py:
310         * Scripts/webkitpy/layout_tests/port/chromium.py:
311         * Scripts/webkitpy/layout_tests/port/dryrun.py:
312         * Scripts/webkitpy/layout_tests/port/test.py:
313         * Scripts/webkitpy/layout_tests/port/webkit.py:
314         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
315         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
316         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
317
318 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
319
320         Unreviewed, build fix.
321
322         Delete a line that was accidentally missed in r77586; without it
323         there is still a race between the two threads.
324
325         https://bugs.webkit.org/show_bug.cgi?id=51572
326
327         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
328
329 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
330
331         Reviewed by Tony Chang.
332
333         nrwt: handle "broken pipe" notifications from DRT more cleanly.
334
335         https://bugs.webkit.org/show_bug.cgi?id=52927
336
337         * Scripts/webkitpy/layout_tests/port/server_process.py:
338         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
339
340 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
341
342         Reviewed by Kenneth Russell.
343
344         Update, resubmit change to bug 51572. I think the race that was
345         fixed in r76703 caused the hang that caused us to roll this
346         patch out before, so I'd like to try again.
347
348         https://bugs.webkit.org/show_bug.cgi?id=51572
349
350         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
351         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
352
353 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
354
355         Unreviewed.
356
357         Adding myself to committers.py.
358
359         * Scripts/webkitpy/common/config/committers.py:
360
361 2011-02-03  Adam Roben  <aroben@apple.com>
362
363         Include the crashing function in the link to a crash log
364
365         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
366         function that crashed
367
368         Reviewed by David Kilzer.
369
370         * Scripts/old-run-webkit-tests:
371         (crashLocation): Added. Returns the location of the crash.
372         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
373         could be determined.
374
375 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
376
377         Unreviewed, build fix.
378
379         Actually make the changes suggested by Mihai in his review
380         of bug 53720 :(
381
382         https://bugs.webkit.org/show_bug.cgi?id=53720
383
384         * Scripts/webkitpy/layout_tests/port/test_files.py:
385         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
386
387 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
388
389         Reviewed by Mihai Parparita.
390
391         new-run-webkit-tests: Fix bug introduced in r77434 that was
392         causing us to run the canvas GPU tests on the Mac GPU port. This
393         bug revealed that we were not setting the port.name() field
394         properly in many cases, so I've cleaned up all of that code, and
395         removed a few comments about "version-specific" GPU ports that
396         don't exist and just confused things.
397
398         Testing also revealed that port.abspath_for_test() wasn't
399         normalizing paths on Windows properly, so I fixed that as well.
400
401         https://bugs.webkit.org/show_bug.cgi?id=53719
402
403         * Scripts/webkitpy/layout_tests/port/base.py:
404         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
405         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
406
407 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
408
409         Reviewed by Mihai Parparita.
410
411         new-run-webkit-tests: fix normalization of paths on windows when gathering files
412
413         r77434 introduced a bug that was causing the test expectations
414         for the GPU ports to not be treated properly. It turns out that
415         when we gathered the list of test files on Windows, we would
416         return paths of the form "c:\LayoutTests/fast/canvas", and the
417         mixture of backslashes and forward slashes was confusing things.
418
419         This patch normalizes all of the filenames returned from
420         test_files.find(), and adds better tests for this (fixing a
421         couple of other bugs found in the meantime).
422
423         https://bugs.webkit.org/show_bug.cgi?id=53720
424
425         * Scripts/webkitpy/layout_tests/port/test.py:
426         * Scripts/webkitpy/layout_tests/port/test_files.py:
427         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
428
429 2011-02-03  Adam Roben  <aroben@apple.com>
430
431         Add links to Windows crash logs in results.html
432
433         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
434         results.html
435
436         Reviewed by David Kilzer.
437
438         * Scripts/old-run-webkit-tests:
439         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
440         createDebuggerCommandFile).
441         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
442         tool has exited.
443         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
444         it into the test results directory tree. Only implemented for Cygwin currently.
445         (findNewestFileMatchingGlob): Added. Does what it says.
446         (htmlForResultsSection): Only link to files that exist.
447         (linksForErrorTest): Add a link to the crash log.
448         (deleteExpectedAndActualResults): Delete any old crash log for this test.
449         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
450         hardcoding it here.
451
452 2011-02-03  Adam Roben  <aroben@apple.com>
453
454         Tell the debugger the path to the WebKit source tree when saving a crash log
455
456         This allows the debugger to include the crashing line of code in the log.
457
458         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
459         of code
460
461         Reviewed by Sam Weinig.
462
463         * Scripts/old-run-webkit-tests:
464         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
465         file and returns the path to that file. The commands we pass came from
466         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
467         WebKit source code lives.
468         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
469         line using -c, save them to a file and specify the path to that file using -cf. This works
470         around what is presumably a bug in Windows's command line parsing, where having multiple
471         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
472         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
473         together to make them easier to modify in the future.
474
475 2011-02-02  Sam Weinig  <sam@webkit.org>
476
477         Reviewed by Anders Carlsson.
478
479         Add notification of the end of a rubber band.
480         <rdar://problem/8940648>
481
482         * MiniBrowser/mac/BrowserWindowController.m:
483         (-[BrowserWindowController awakeFromNib]):
484         * WebKitTestRunner/TestController.cpp:
485         (WTR::TestController::createOtherPage):
486         (WTR::TestController::initialize):
487         Stub out the new WKUIClient function.
488
489 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
490
491         Unreviewed.
492
493         Adding myself to committers.py.
494
495         * Scripts/webkitpy/common/config/committers.py:
496
497 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
498
499         Reviewed by Csaba Osztrogonác.
500
501         [Qt][WK2] MiniBrowser's window size should be 800x600
502         https://bugs.webkit.org/show_bug.cgi?id=53670
503
504         Make layout test failure debugging easier.
505         * MiniBrowser/qt/BrowserWindow.cpp:
506         (BrowserWindow::BrowserWindow):
507
508 2011-02-02  Andy Estes  <aestes@apple.com>
509
510         Reviewed by Mark Rowe.
511
512         'update-webkit' should handle OpenSource and Internal using different
513         VCSs.
514
515         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
516         Internal directory.
517
518 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
519
520         Reviewed by Mihai Parparita.
521
522         new-run-webkit-tests: hardcode the directories to scan for tests
523         for GPU bots instead of SKIPping them. See bug 53562 for some
524         context, but we will now hard-code the list of directories to
525         use by default instead of skipping over directories in the
526         expectations file. We do this so that we will be able to merge
527         the expectations files without getting conflicting SKIP
528         directives. Note that this change will reduce the # of tests
529         being run on the Mac GPU bots, because we're accidentally
530         including some today.
531
532         https://bugs.webkit.org/show_bug.cgi?id=53631
533
534         * Scripts/webkitpy/layout_tests/port/base.py:
535         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
536         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
537
538 2011-02-02  Sam Weinig  <sam@webkit.org>
539
540         Reviewed by Beth Dakin.
541
542         Add ChromeClient function to paint custom overhang areas.
543         https://bugs.webkit.org/show_bug.cgi?id=53639
544
545         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
546         (WTR::InjectedBundlePage::InjectedBundlePage):
547         Stub out new callback.
548
549 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
550
551         Reviewed by Tony Chang.
552
553         new-run-webkit-tests: support chromium code paths in mock_drt
554
555         https://bugs.webkit.org/show_bug.cgi?id=53471
556
557         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
558         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
559
560 2011-02-02  Adam Klein  <adamk@chromium.org>
561
562         Reviewed by Tony Chang.
563
564         Update new-run-webkit-tests --chromium to put output under Source/...
565         https://bugs.webkit.org/show_bug.cgi?id=53612
566
567         * BuildSlaveSupport/test-result-archive:
568         * Scripts/webkitpy/layout_tests/port/chromium.py:
569
570 2011-01-28  Tony Chang  <tony@chromium.org>
571
572         Reviewed by Eric Seidel.
573
574         [chromium] remove --use-test-shell from NRWT
575         https://bugs.webkit.org/show_bug.cgi?id=53346
576
577         I've already started removing some of the bindings like eventSender so
578         this already doesn't work isn't useful.  Also updated some comments to
579         refer to DRT instead of test_shell.
580
581         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
582         * Scripts/webkitpy/layout_tests/port/chromium.py:
583         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
584         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
585         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
586         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
587         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
588         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
589
590 2011-02-02  Steve Lacey  <sjl@chromium.org>
591
592         Reviewed by Eric Carlson.
593
594         Implement basic media statistics on media elements.
595         https://bugs.webkit.org/show_bug.cgi?id=53322
596
597         * Scripts/build-webkit:
598
599 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
600
601         [wx] Build fixes for wxWebKit.
602
603         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
604         (LayoutTestController::setSerializeHTTPLoads):
605         * wx/browser/wscript:
606         * wx/build/build_utils.py:
607         * wx/build/settings.py:
608
609 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
610
611         Reviewed by Mihai Parparita.
612
613         new-run-webkit-tests: stop skipping so many tests
614
615         r77163 introduced a regression where we weren't resetting test
616         expectations properly and were skipping too many tests as a
617         result. This patch fixes that and adds a test for it.
618
619         https://bugs.webkit.org/show_bug.cgi?id=53551
620
621         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
622         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
623
624 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
625
626         Reviewed by Tony Chang.
627
628         new-run-webkit-tests: add first stub of test_runner2. This
629         will add support for the 'inline', 'threads', and 'processes'
630         flags to --worker-model, but for now the implementatios just
631         fall back on the old ones.
632
633         https://bugs.webkit.org/show_bug.cgi?id=53157
634
635         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
636         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
637
638 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
639
640         Reviewed by James Robinson.
641
642         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
643         https://bugs.webkit.org/show_bug.cgi?id=53522
644
645         * Scripts/run-chromium-webkit-unit-tests:
646
647 2011-02-01  Adam Barth  <abarth@webkit.org>
648
649         Reviewed by Mihai Parparita.
650
651         Using Control-C to cancel webkit-patch or other python tools causes
652         unpleasant traceback console spew
653         https://bugs.webkit.org/show_bug.cgi?id=53462
654
655         Catch the exception and don't print the stack trace.
656
657         * Scripts/webkit-patch:
658
659 2011-02-01  Scott Cameron  <sccameron@rim.com>
660
661         Reviewed by Daniel Bates.
662
663         Use Windows format for MinGW HTTPD path.
664         https://bugs.webkit.org/show_bug.cgi?id=53503
665
666         * Scripts/webkitperl/httpd.pm:
667           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
668             so that we don't have to escape the space characters in the path. Also,
669             changed path to Windows-style path and removed FIXME comment.
670
671 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
672
673         Reviewed by Andreas Kling.
674
675         [Qt][WK2] Add a way to use shared process model in MiniBrowser
676         https://bugs.webkit.org/show_bug.cgi?id=53090
677
678         * MiniBrowser/qt/BrowserView.cpp:
679         (BrowserView::BrowserView): Removed the m_context member.
680         From now the context is guaranteed to be non-null and we
681         don't need to store that in the object.
682         * MiniBrowser/qt/BrowserView.h:
683         * MiniBrowser/qt/BrowserWindow.cpp:
684         Added static bool to determine that new windows need to be
685         created with their own context or not. Use the same context
686         and web process by default to be inilne with the other ports.
687         (BrowserWindow::BrowserWindow):
688         (BrowserWindow::newWindow):
689         * MiniBrowser/qt/BrowserWindow.h:
690         * MiniBrowser/qt/main.cpp:
691         (main): Added command line switch to be able to use the
692         non-shared process model. Simplify the handling of the command line
693         switches a little bit.
694
695 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
696
697         Reviewed by Andreas Kling.
698
699         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
700         https://bugs.webkit.org/show_bug.cgi?id=53491
701
702         * MiniBrowser/qt/BrowserWindow.cpp:
703         (BrowserWindow::BrowserWindow):
704         (BrowserWindow::toggleFullScreenMode):
705         * MiniBrowser/qt/BrowserWindow.h:
706
707 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
708
709         Reviewed by Andreas Kling.
710
711         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
712         https://bugs.webkit.org/show_bug.cgi?id=53489
713
714         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
715         to Settings menu.
716
717         * MiniBrowser/qt/BrowserWindow.cpp:
718         (BrowserWindow::BrowserWindow):
719         (BrowserWindow::toggleFrameFlattening):
720         (BrowserWindow::toggleDisableJavaScript):
721         (BrowserWindow::toggleAutoLoadImages):
722         * MiniBrowser/qt/BrowserWindow.h:
723
724 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
725
726         Reviewed by Tony Chang.
727
728         [Chromium] Switch chromium-mac to use ChromiumDriver
729         https://bugs.webkit.org/show_bug.cgi?id=53461
730         
731         For the sake of consistency with the other Chromium platforms (and so
732         that chromium-mac picks up special flags like --enable-hardware-gpu),
733         switch chromium-mac from the WebKitDriver to ChromiumDriver.
734
735         * Scripts/webkitpy/layout_tests/port/chromium.py:
736
737 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
738
739         Reviewed by Mihai Parparita.
740
741         The current modifier parsing code in test_expectations is
742         fragile and hard-coded, so it's not easy to understand the logic
743         or easily add new types of modifiers (like GPU vs. CPU testing
744         for graphics tests, or 32-bit vs. 64-bit differences).
745
746         This is the first of two patches that will add in more generic
747         support and then eliminate the GPU-specific test expectations
748         files for Chromium.
749
750         This patch adds two standalone objects for handling modifiers. The
751         rules for interpreting modifiers, precedence, and conflicts are
752         given in the docstring to the ModifierMatcher class, which
753         returns ModifierMatchResult objects.
754         
755         This patch also adds routines to the Port interface and a
756         default set of values in the base object, in order to obtain the
757         values needed on a given test run. These values are then passed
758         to the expectation parser. This also allows us to clean up the
759         logic used to lint all of the different configurations in a
760         single test_expectations.txt file.
761
762         The next patch will merge in the separate GPU expectations file.
763
764         https://bugs.webkit.org/show_bug.cgi?id=51222
765
766         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
767         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
768         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
769         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
770         * Scripts/webkitpy/layout_tests/port/base.py:
771         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
772         * Scripts/webkitpy/layout_tests/port/chromium.py:
773         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
774         * Scripts/webkitpy/layout_tests/port/test.py:
775         * Scripts/webkitpy/layout_tests/port/webkit.py:
776         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
777         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
778         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
779         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
780         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
781
782 2011-01-31  Scott Cameron  <sccameron@rim.com>
783
784         Reviewed by Daniel Bates.
785
786         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
787         https://bugs.webkit.org/show_bug.cgi?id=50036
788
789         This will add an Apache2.2 configuration file and modifies scripts to allow
790         running an httpd server in an MSYS environment.
791
792         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
793         in order to allow for simple installation/execution.  Simply install the latest
794         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
795         be able to execute run-webkit-httpd.
796         
797
798         * Scripts/run-webkit-httpd:
799         * Scripts/webkitperl/httpd.pm:
800
801 2011-01-31  Tony Chang  <tony@chromium.org>
802
803         Reviewed by Eric Seidel.
804
805         mac DRT should report RTL scroll offset relative to top right corner
806         https://bugs.webkit.org/show_bug.cgi?id=53324
807
808         * DumpRenderTree/mac/DumpRenderTree.mm:
809         (dumpFrameScrollPosition):
810
811 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
812
813         Reviewed by Andreas Kling.
814
815         [Qt] Add Take Screen Shot action to MiniBrowser
816         https://bugs.webkit.org/show_bug.cgi?id=53422
817
818         Add Take Screen Shot action to MiniBrowser's view menu.
819
820         * MiniBrowser/qt/BrowserWindow.cpp:
821         (BrowserWindow::BrowserWindow):
822         (BrowserWindow::screenshot):
823         * MiniBrowser/qt/BrowserWindow.h:
824
825 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
826
827         Reviewed by Xan Lopez.
828
829         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
830         https://bugs.webkit.org/show_bug.cgi?id=53379
831
832         Remove left over #ifdef's. I thought all of the conditional code
833         had been freed from the condition, but I forgot to check DRT.
834
835         * DumpRenderTree/gtk/DumpRenderTree.cpp:
836         (resetDefaultsToConsistentValues):
837         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
838         (LayoutTestController::setAlwaysAcceptCookies):
839
840 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
841
842         Unreviewed, build fix.
843
844         Fix regression introduced in r77093 - path.rsplit() doesn't
845         take keyword arguments.
846
847         https://bugs.webkit.org/show_bug.cgi?id=53326
848
849         * Scripts/webkitpy/common/system/filesystem_mock.py:
850
851 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
852
853         Reviewed by Mihai Parparita.
854
855         Add more unit tests for rebaseline-chromium-webkit-tests. This
856         change involves restructuring a bunch of r-c-w-t code to make it
857         more testable as well. We also add wrapper classes for handling
858         testing zip files and fetching URLs.
859
860         https://bugs.webkit.org/show_bug.cgi?id=53040
861
862         * Scripts/webkitpy/common/system/urlfetcher.py:
863         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
864         * Scripts/webkitpy/common/system/zipfileset_mock.py:
865         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
866         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
867         * Scripts/webkitpy/tool/mocktool.py:
868
869 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
870
871         Reviewed by Eric Seidel.
872
873         Clean up of the filesystem-related modules used in webkitpy.
874         I've added relpath() to the filesystem interface, modified
875         ospath.relpath() so that it could work with the filesystem
876         interface, and modified the fileset* routines to use the
877         filesystem interface consistently.
878
879         This patch also adds a close() routine to the fileset routines
880         to indicate that the caller is done with the fileset. This
881         allows zipfileset to clean up after itself when it creates
882         tempfiles to store downloads.
883
884         https://bugs.webkit.org/show_bug.cgi?id=53326
885
886         * Scripts/webkitpy/common/system/directoryfileset.py:
887         * Scripts/webkitpy/common/system/fileset.py:
888         * Scripts/webkitpy/common/system/filesystem.py:
889         * Scripts/webkitpy/common/system/filesystem_mock.py:
890         * Scripts/webkitpy/common/system/filesystem_unittest.py:
891         * Scripts/webkitpy/common/system/ospath.py:
892         * Scripts/webkitpy/common/system/zipfileset.py:
893         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
894
895 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
896
897         Reviewed by Csaba Osztrogonác.
898
899         [Qt][WK2]REGRESSION (r76991): Fix build errors
900         https://bugs.webkit.org/show_bug.cgi?id=53400
901
902         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
903         and remove WebKit2Prefix.h from the build.
904         * MiniBrowser/qt/MiniBrowser.pro:
905
906 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
907
908         Unreviewed.
909
910         [Qt][WK2] Buildfix.
911
912         * MiniBrowser/qt/MiniBrowser.pro:
913
914 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
915
916         Reviewed by Adam Roben.
917         
918         define NOMINMAX when building ImageDiff, as we do elsewhere.
919
920         Add various clampToInt() methods to MathExtras.h
921         https://bugs.webkit.org/show_bug.cgi?id=52910
922
923         * DumpRenderTree/win/ImageDiffCommon.vsprops:
924
925 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
926
927         Reviewed by Darin Adler.
928
929         WebKitTestRunner needs layoutTestController.setPOSIXLocale
930         https://bugs.webkit.org/show_bug.cgi?id=42682
931
932         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
933         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
934         (WTR::InjectedBundle::resetLocalSettings):
935         (WTR::InjectedBundle::didReceiveMessage):
936         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
937         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
938         (WTR::LayoutTestController::setPOSIXLocale):
939         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
940
941 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
942  
943          Reviewed by Mihai Parparita.
944  
945          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
946  
947          This patch re-enables this test and changes it to
948          handle all of the mac platform versions, not just the one
949          it is running on.
950  
951          https://bugs.webkit.org/show_bug.cgi?id=53356
952  
953          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
954  
955 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
956
957         Unreviewed, build fix.
958
959         Take two. The fix in 77023 didn't work, because we were
960         still calling path.abspath_to_uri, which calls _cygpath under
961         the covers, and it appears the cygpath on the bots does
962         something different than it does on my machine. This patch
963         removes the calls to path.abspath_to_uri, so it should be safe.
964         If it doesn't work, I'll roll it out along with r76982 and 77023.
965
966         https://bugs.webkit.org/show_bug.cgi?id=53126
967
968         * Scripts/webkitpy/layout_tests/port/test.py:
969
970 2011-01-28  David Kilzer  <ddkilzer@apple.com>
971
972         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
973         <http://webkit.org/b/53353>
974
975         Reviewed by Mark Rowe.
976
977         * Scripts/webkitdirs.pm:
978         (checkRequiredSystemConfig): Check the Xcode marketing version
979         in addition to the DevCoreTools build version before complaining
980         about an old version of Xcode.  Also make the Mac OS X version
981         check use Perl's built-in version string comparitor.
982
983 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
984
985         Unreviewed, build fix.
986
987         Work around breakage on Win 7 Release bot caused by r76982
988         and the fact that windows ports use "file:////" instead of
989         "file:///". Ideally the test code should be isolated from
990         this, but it isn't yet. Will fix properly in a bit.
991
992         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
993
994 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
995
996         Reviewed by Tony Chang.
997
998         new-run-webkit-tests: change worker model values to
999         "old-inline", "old-threads" in preparation for test_runner2 /
1000         multiprocessing changes.
1001
1002         https://bugs.webkit.org/show_bug.cgi?id=53156
1003
1004         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1005         * Scripts/webkitpy/layout_tests/port/base.py:
1006         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1007         * Scripts/webkitpy/layout_tests/port/mac.py:
1008         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1009
1010 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1011
1012         Reviewed by Tony Chang.
1013
1014         committers.py - add an IRC nickname for dpranke
1015         https://bugs.webkit.org/show_bug.cgi?id=53335
1016
1017         * Scripts/webkitpy/common/config/committers.py:
1018
1019 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1020
1021         Reviewed by Tony Chang.
1022
1023         new-run-webkit-tests: add a "mock DRT" port implementation
1024         and a separate class that emulates what we expect the
1025         DumpRenderTree behavior to be.
1026
1027         This will eventually replace port/dryrun.py and allow us to get
1028         better test coverage of the new-run-webkit-tests code as well as
1029         a reference for what new-run-webkit-tests expects from DRT.
1030
1031         This is the first attempt at this, and it is pretty bare-boned. It
1032         really only has been tested on the 'mac' port (and a little on
1033         the 'chromium-mac' port.
1034
1035         https://bugs.webkit.org/show_bug.cgi?id=53126
1036
1037         * Scripts/webkitpy/common/system/filesystem_mock.py:
1038         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1039         * Scripts/webkitpy/layout_tests/port/factory.py:
1040         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1041         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1042         * Scripts/webkitpy/layout_tests/port/test.py:
1043
1044 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1045
1046         Unreviewed. Removing .swp file checked in by mistake.
1047
1048         * Scripts/.webkitdirs.pm.swp: Removed.
1049
1050 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1051
1052         Reviewed by David Kilzer.
1053
1054         Space not necessary for undefined feature
1055         https://bugs.webkit.org/show_bug.cgi?id=53317
1056
1057         * Scripts/build-webkit:
1058
1059 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1060
1061         Reviewed by Andreas Kling.
1062
1063         Reset NetworkAccessManager to clean up credentials from previous tests.
1064         This change causes no performance overhead either.
1065         https://bugs.webkit.org/show_bug.cgi?id=36688
1066
1067         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1068         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1069         (WebCore::DumpRenderTree::open):
1070         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1071
1072 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1073
1074         Reviewed by Andreas Kling.
1075
1076         [Qt] Add Zoom Text Only action to MiniBrowser
1077         https://bugs.webkit.org/show_bug.cgi?id=53297
1078
1079         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1080
1081         * MiniBrowser/qt/BrowserWindow.cpp:
1082         (BrowserWindow::BrowserWindow):
1083         (BrowserWindow::zoomIn):
1084         (BrowserWindow::zoomOut):
1085         (BrowserWindow::resetZoom):
1086         (BrowserWindow::toggleZoomTextOnly):
1087         (BrowserWindow::applyZoom):
1088         * MiniBrowser/qt/BrowserWindow.h:
1089
1090 2011-01-28  Adam Barth  <abarth@webkit.org>
1091
1092         Reviewed by Eric Seidel.
1093
1094         Add webkit-patch roll-chromium-deps
1095         https://bugs.webkit.org/show_bug.cgi?id=53288
1096
1097         This command updates the Source/WebKit/chromium/DEPS file with the
1098         last-known good revision of Chromium (or a revision specified on the
1099         command line).  I'd eventually like to turn this into a SheriffBot
1100         command, but this is the first step.
1101
1102         This patch somewhat sprawled because I needed to move a bunch of code
1103         out of ChangeLog that should never have been there in the first place.
1104         Also, I had to fix a bug in MockUser in order to test the new command.
1105
1106         * Scripts/webkitpy/common/checkout/api.py:
1107         * Scripts/webkitpy/common/checkout/changelog.py:
1108         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1109         * Scripts/webkitpy/common/checkout/deps.py: Added.
1110         * Scripts/webkitpy/common/config/urls.py:
1111         * Scripts/webkitpy/tool/commands/__init__.py:
1112         * Scripts/webkitpy/tool/commands/download_unittest.py:
1113         * Scripts/webkitpy/tool/commands/roll.py: Added.
1114         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1115         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1116         * Scripts/webkitpy/tool/mocktool.py:
1117         * Scripts/webkitpy/tool/steps/__init__.py:
1118         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1119         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1120         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1121         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1122         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1123         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1124
1125 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1126
1127         Reviewed by Laszlo Gombos.
1128
1129         Get rid of prefix header dependency for WebKit2 build system
1130         https://bugs.webkit.org/show_bug.cgi?id=50174
1131
1132         Change the style checker so that it enforces config.h include for
1133         WebKit2.
1134
1135         * Scripts/webkitpy/style/checker.py:
1136
1137 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1138
1139         Reviewed by Darin Adler.
1140
1141         execCommand("Paste") doesn't work in WebKitTestRunner
1142         https://bugs.webkit.org/show_bug.cgi?id=52785
1143
1144         Enable both of the settings needed to allow paste.
1145         
1146         * WebKitTestRunner/TestController.cpp:
1147         (WTR::TestController::resetStateToConsistentValues):
1148
1149 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1150
1151         Reviewed by Andreas Kling.
1152
1153         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1154         https://bugs.webkit.org/show_bug.cgi?id=48440
1155
1156         Preserve user input when toggling use of QGraphicsView
1157
1158         * QtTestBrowser/launcherwindow.cpp:
1159         (LauncherWindow::initializeView):
1160         (LauncherWindow::loadFinished):
1161         * QtTestBrowser/launcherwindow.h:
1162         * QtTestBrowser/mainwindow.cpp:
1163         (MainWindow::addressUrl):
1164         * QtTestBrowser/mainwindow.h:
1165
1166 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1167
1168         Reviewed by Mihai Parparita.
1169
1170         new-run-webkit-tests: turn off pixel tests correctly by default
1171         for webkit-based ports. r70013 (bug 47510) used
1172         port.set_option_default() to attempt to set default values, but
1173         that didn't work correctly. I have removed set_option_default
1174         for now since it was only being used in two places and in three
1175         useless unit tests. There is a separate bug open to fix the
1176         option parsing (48095), so this workaround is fine for now.
1177
1178         https://bugs.webkit.org/show_bug.cgi?id=53217
1179
1180         * Scripts/webkitpy/layout_tests/port/webkit.py:
1181         * Scripts/webkitpy/layout_tests/port/base.py:
1182         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1183
1184 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1185
1186         Rubber-stamped by Ariya Hidayat.
1187
1188         Trivial crash fix in WTR.
1189
1190         * WebKitTestRunner/TestController.cpp:
1191         (WTR::TestController::initialize): Increase the size
1192         of the vector by one to be able to store the null character.
1193
1194 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1195
1196         Reviewed by Csaba Osztrogonác.
1197
1198         [Qt][WK2] WTR should be initialized in the same way as DRT
1199         https://bugs.webkit.org/show_bug.cgi?id=53240
1200
1201         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1202         (WTR::activateFonts): Added missing initialization steps.
1203
1204 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1205
1206         Unreviewed. 
1207
1208         Adding myself to committers.py.
1209
1210         * Scripts/webkitpy/common/config/committers.py:
1211
1212 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1213
1214         Reviewed by Csaba Osztrogonác.
1215
1216         [Qt] [Symbian] Move project files into Source
1217         https://bugs.webkit.org/show_bug.cgi?id=52891
1218
1219         Fix the Symbian build after the project files
1220         are moved to Source directory. On Symbian qmake
1221         needs to run in the same directory where the main
1222         pro files (WebKit.pro, Tools.pro) are located.
1223
1224         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1225         is located before running qmake for Symbian. Qmake on Symbian
1226         does not properly honor the "-o" option, work it around by setting
1227         the name of the Makefile to bld.inf.
1228
1229 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1230
1231         Reviewed by Andreas Kling.
1232
1233         [Qt] Add simple zooming features to MiniBrowser
1234         https://bugs.webkit.org/show_bug.cgi?id=53231
1235
1236         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1237
1238         * MiniBrowser/qt/BrowserWindow.cpp:
1239         (BrowserWindow::BrowserWindow):
1240         (BrowserWindow::zoomIn):
1241         (BrowserWindow::zoomOut):
1242         (BrowserWindow::resetZoom):
1243         (BrowserWindow::updateUserAgentList):
1244         (BrowserWindow::applyZoom):
1245         * MiniBrowser/qt/BrowserWindow.h:
1246
1247 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1248
1249         Reviewed by Dan Bernstein.
1250
1251         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1252         https://bugs.webkit.org/show_bug.cgi?id=42319
1253         
1254         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1255
1256         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1257         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1258         (WTR::LayoutTestController::showWebInspector):
1259         (WTR::LayoutTestController::closeWebInspector):
1260         (WTR::LayoutTestController::evaluateInWebInspector):
1261         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1262         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1263         * WebKitTestRunner/TestInvocation.cpp:
1264         (WTR::shouldOpenWebInspector):
1265         (WTR::TestInvocation::invoke):
1266         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1267
1268 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1269
1270         Reviewed by Xan Lopez.
1271
1272         [GTK] Pixel dumps do not include scrollbars in output images
1273         https://bugs.webkit.org/show_bug.cgi?id=53216
1274
1275         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1276         that have scrollbars.
1277
1278         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1279         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1280         instead of the web view itself.
1281
1282 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1283
1284         Reviewed by Mihai Parparita.
1285
1286         Fix regression introduced in r76322 ... new-run-webkit-tests
1287         was attempting to save the image diff output as a UTF-8-encoded
1288         file.
1289
1290         https://bugs.webkit.org/show_bug.cgi?id=53210
1291
1292         * Scripts/webkitpy/layout_tests/port/webkit.py:
1293
1294 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1295
1296         Unreviewed, rolling out r76709.
1297         http://trac.webkit.org/changeset/76709
1298         https://bugs.webkit.org/show_bug.cgi?id=53194
1299
1300         "broke python tests on non-snowleopard platforms" (Requested
1301         by dpranke on #webkit).
1302
1303         * Scripts/webkitpy/layout_tests/port/factory.py:
1304         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1305         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1306
1307 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1308
1309         Reviewed by Tony Chang.
1310
1311         new-run-webkit-tests: add a "mock DRT" port implementation
1312         and a separate class that emulates what we expect the
1313         DumpRenderTree behavior to be.
1314
1315         This will eventually replace port/dryrun.py and allow us to get
1316         better test coverage of the new-run-webkit-tests code as well as
1317         a reference for what new-run-webkit-tests expects from DRT.
1318
1319         This is the first attempt at this, and it is pretty bare-boned. It
1320         really only has been tested on the 'mac' port (and a little on
1321         the 'chromium-mac' port.
1322
1323         https://bugs.webkit.org/show_bug.cgi?id=53126
1324
1325         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1326         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1327         * Scripts/webkitpy/layout_tests/port/factory.py:
1328
1329 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1330
1331         Reviewed by Tony Chang.
1332
1333         Add '--no-timeout' option to Chromium DRT to ease debugging.
1334         https://bugs.webkit.org/show_bug.cgi?id=52873
1335
1336         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1337         (main):
1338
1339 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1340
1341         Reviewed by Andreas Kling.
1342
1343         [Qt] Fix qt_minimal build
1344         https://bugs.webkit.org/show_bug.cgi?id=53172
1345
1346         * QtTestBrowser/locationedit.h:
1347
1348 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1349
1350         Reviewed by Antonio Gomes.
1351
1352         QtTestBrowser should have a UI Setting to disable plugins
1353         https://bugs.webkit.org/show_bug.cgi?id=52408
1354         
1355         Added a new action item named "Disable Plugins"
1356         under the "Settings" menu. 
1357
1358         * QtTestBrowser/launcherwindow.cpp:
1359         (LauncherWindow::createChrome):
1360         (LauncherWindow::togglePlugins):
1361         * QtTestBrowser/launcherwindow.h:
1362
1363 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1364
1365         Reviewed by Adam Barth.
1366
1367         Move main CMakeLists.txt into Source directory
1368         https://bugs.webkit.org/show_bug.cgi?id=52888
1369
1370         * Scripts/webkitdirs.pm:
1371
1372 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1373
1374         Reviewed by Eric Seidel.
1375
1376         Improve label text in submit-to-ews
1377         https://bugs.webkit.org/show_bug.cgi?id=53130
1378
1379         * QueueStatusServer/templates/submittoews.html:
1380
1381 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1382
1383         Reviewed by Antonio Gomes.
1384
1385         QtTestBrowser should have a UI Settings to prevent loading images
1386         https://bugs.webkit.org/show_bug.cgi?id=52409
1387         
1388         Added a new action item named "DisableAutoLoadImages"
1389         under the "Settings" menu 
1390
1391         * QtTestBrowser/launcherwindow.cpp:
1392         (LauncherWindow::createChrome):
1393         (LauncherWindow::toggleAutoLoadImages):
1394         * QtTestBrowser/launcherwindow.h:
1395
1396 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1397
1398         Reviewed by Tony Chang.
1399
1400         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1401         classes, test_expectations.py. This change adds "test-win" and
1402         "test-mac" variants to the test port so that we can better test
1403         rebaselining, and adds a MockUser() object for reuse in testing.
1404
1405         https://bugs.webkit.org/show_bug.cgi?id=53036
1406
1407         * Scripts/webkitpy/common/system/filesystem.py:
1408         * Scripts/webkitpy/common/system/filesystem_mock.py:
1409         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1410         * Scripts/webkitpy/layout_tests/port/factory.py:
1411         * Scripts/webkitpy/layout_tests/port/base.py:
1412         * Scripts/webkitpy/layout_tests/port/test.py:
1413         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1414         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1415         * Scripts/webkitpy/tool/mocktool.py:
1416
1417 2011-01-25  Tony Chang  <tony@chromium.org>
1418
1419         Reviewed by Dimitri Glazkov.
1420
1421         [chromium] remove unused layoutTestController callback
1422         https://bugs.webkit.org/show_bug.cgi?id=53103
1423
1424         This method is used by a test_shell_test, but not needed by DRT.
1425
1426         * DumpRenderTree/chromium/LayoutTestController.cpp:
1427         (LayoutTestController::LayoutTestController):
1428         * DumpRenderTree/chromium/LayoutTestController.h:
1429
1430 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1431
1432         Reviewed by Andreas Kling.
1433
1434         [GTK] Remove 64 bits release bot from the buildbot master
1435         https://bugs.webkit.org/show_bug.cgi?id=52899
1436
1437         Removes the 64 bits release slave from the buildbot configuration,
1438         so that we can use it as an EWS.
1439
1440         * BuildSlaveSupport/build.webkit.org-config/config.json:
1441
1442 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1443
1444         Reviewed by Dan Bernstein.
1445
1446         Implement database quota callback to fix storage tests on WebKit2 bot
1447         https://bugs.webkit.org/show_bug.cgi?id=53064
1448
1449         * WebKitTestRunner/TestController.cpp:
1450         (WTR::exceededDatabaseQuota):
1451         (WTR::TestController::createOtherPage):
1452         (WTR::TestController::initialize):
1453
1454 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1455
1456         Reviewed by Anders Carlsson.
1457
1458         Use designated temp directory for the database for WebKit2
1459         https://bugs.webkit.org/show_bug.cgi?id=53052
1460         
1461         Adopt the new WK2 API for this.
1462
1463         * WebKitTestRunner/TestController.cpp:
1464         (WTR::TestController::libraryPathForTesting):
1465         (WTR::TestController::initialize):
1466         * WebKitTestRunner/TestController.h:
1467         * WebKitTestRunner/mac/TestControllerMac.mm:
1468         (WTR::TestController::platformLibraryPathForTesting):
1469         * WebKitTestRunner/qt/TestControllerQt.cpp:
1470         (WTR::TestController::platformLibraryPathForTesting):
1471         * WebKitTestRunner/win/TestControllerWin.cpp:
1472         (WTR::TestController::platformLibraryPathForTesting):
1473
1474 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1475
1476         Reviewed by Stephanie Lewis.
1477
1478         Add a new Leopard test bot.
1479
1480         * BuildSlaveSupport/build.webkit.org-config/config.json:
1481
1482 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1483
1484         Reviewed by Adam Barth.
1485
1486         Add EFL Builder to core waterfall
1487         https://bugs.webkit.org/show_bug.cgi?id=52704
1488
1489         Add EFL Builder to the core waterfall again.
1490
1491         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1492         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1493
1494 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1495
1496         Reviewed by Tony Chang.
1497
1498         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1499         https://bugs.webkit.org/show_bug.cgi?id=52872
1500
1501         Force disabling proxy to resolve the problem.
1502
1503         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1504         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1505
1506 2011-01-24  Andreas Kling  <kling@webkit.org>
1507
1508         Reviewed by Darin Adler.
1509
1510         check-webkit-style: Update exemptions following Source/ move.
1511         https://bugs.webkit.org/show_bug.cgi?id=53017
1512
1513         * Scripts/webkitpy/style/checker.py:
1514         * Scripts/webkitpy/style/checker_unittest.py:
1515
1516 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1517
1518         Rubber-stamped by Csaba Osztrogonác.
1519
1520         [Qt] Move project files into Source
1521         https://bugs.webkit.org/show_bug.cgi?id=52891
1522
1523         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1524
1525 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1526
1527         Reviewed by Yury Semikhatsky.
1528
1529         Web Inspector: Find duplicate strings in localizedStrings.js
1530
1531         https://bugs.webkit.org/show_bug.cgi?id=53005
1532
1533         * Scripts/check-inspector-strings:
1534
1535 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1536
1537         Reviewed by Andreas Kling.
1538
1539         [Qt] Regroup MiniBrowser's menubar and add open file action
1540         https://bugs.webkit.org/show_bug.cgi?id=53000
1541
1542         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1543
1544         * MiniBrowser/qt/BrowserWindow.cpp:
1545         (BrowserWindow::BrowserWindow):
1546         (BrowserWindow::openFile):
1547         (BrowserWindow::~BrowserWindow):
1548         * MiniBrowser/qt/BrowserWindow.h:
1549
1550 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1551
1552         Unreviewed fix after r76496
1553
1554         [Qt] Move project files into Source
1555         https://bugs.webkit.org/show_bug.cgi?id=52891
1556
1557         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1558         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1559         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1560
1561 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1562
1563         Reviewed by Csaba Osztrogonác.
1564
1565         [Qt] Move project files into Source
1566         https://bugs.webkit.org/show_bug.cgi?id=52891
1567
1568         * DerivedSources.pro: Renamed from DerivedSources.pro.
1569         * DumpRenderTree/qt/DumpRenderTree.pro:
1570         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1571         * MiniBrowser/DerivedSources.pro:
1572         * MiniBrowser/qt/MiniBrowser.pro:
1573         * QtTestBrowser/QtTestBrowser.pro:
1574         * Scripts/webkitdirs.pm:
1575         * Tools.pro: Added.
1576         * WebKitTestRunner/DerivedSources.pro:
1577         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1578         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1579
1580 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1581
1582         Reviewed by Dan Bernstein.
1583
1584         Beefed up --threaded mode to catch even more kinds of errors.
1585         https://bugs.webkit.org/show_bug.cgi?id=52971
1586
1587         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1588         context group to force JSC to mark multiple threads. (This used to be
1589         the default, but it changed in SnowLeopard.)
1590         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1591         to give threading mistakes more chances to show themselves.
1592         (startJavaScriptThreads):
1593         (stopJavaScriptThreads):
1594
1595 2011-01-22  Robert Hogan  <robert@webkit.org>
1596
1597         Reviewed by Andreas Kling.
1598
1599         [Qt] Support layoutTestController.addURLToRedirect()
1600         https://bugs.webkit.org/show_bug.cgi?id=52956
1601
1602         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1603         (LayoutTestController::addURLToRedirect):
1604         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1605
1606 2011-01-22  Robert Hogan  <robert@webkit.org>
1607
1608         Reviewed by Kenneth Rohde Christiansen.
1609
1610         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1611         https://bugs.webkit.org/show_bug.cgi?id=49802
1612
1613         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1614         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1615         (WebCore::DumpRenderTree::open):
1616
1617 2011-01-21  Adam Barth  <abarth@webkit.org>
1618
1619         Reviewed by Maciej Stachowiak.
1620
1621         Disable mac_unittest.py that fails on some of the Mac bots
1622         https://bugs.webkit.org/show_bug.cgi?id=52947
1623
1624         As noted in the comment, this test does not appear to be correct
1625         because the function this test is testing returns different results
1626         depending on which flavor of Mac the test is run on.  This patch
1627         disable the test.  Hopefully we can re-enable the test once we've
1628         probably insulated the test from its environment.
1629
1630         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1631
1632 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1633
1634         Reviewed by Mihai Parparita.
1635
1636         Fix bug introduced in r76322 that caused NRWT to not actually
1637         read the Skipped files properly.
1638
1639         https://bugs.webkit.org/show_bug.cgi?id=52771
1640
1641         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1642         * Scripts/webkitpy/layout_tests/port/webkit.py:
1643         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1644
1645 2011-01-21  Sam Weinig  <sam@webkit.org>
1646
1647         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1648
1649         WebKitTestRunner needs the HOME environment variable to be set.
1650         <rdar://problem/8896573>
1651
1652         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1653         it exists.
1654
1655 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1656
1657         Reviewed by Eric Seidel.
1658
1659         Suppress a few remaining integration tests so that none of the
1660         layout_test unit tests ever read from the filesystem or launch
1661         subprocesses that aren't part of the unit tests.
1662
1663         Also fix a minor bug in the printing unit tests that was
1664         incorrectly relying on sys.argv.
1665
1666         https://bugs.webkit.org/show_bug.cgi?id=52863
1667
1668         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1669         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1670         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1671
1672 2011-01-21  Darin Adler  <darin@apple.com>
1673
1674        Fix Mac build.
1675
1676         * MiniBrowser/mac/BrowserWindowController.m:
1677         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1678
1679 2011-01-20  Darin Adler  <darin@apple.com>
1680
1681         Reviewed by Dan Bernstein.
1682
1683         WebKit2: Implement showModalDialog
1684         https://bugs.webkit.org/show_bug.cgi?id=52855
1685
1686         This fixes WebKitTestRunner to compile, but more work is probably
1687         needed to get it to pass the tests.
1688
1689         * WebKitTestRunner/TestController.cpp:
1690         (WTR::TestController::runModal): Added. Calls through to the
1691         platform-specific version of runModal.
1692         (WTR::TestController::createOtherPage): Changed to be a private
1693         static member function so it can refer to runModal, which is
1694         a private static member function.
1695         (WTR::TestController::initialize): Pass 0 for the runModal
1696         function since we don't need to run the main window modal.
1697         I suspect this is wrong and will need to change.
1698         * WebKitTestRunner/TestController.h: Added declarations for
1699         the functions added above.
1700         * WebKitTestRunner/mac/TestControllerMac.mm:
1701         (WTR::TestController::runModal): Added. Untested implementation.
1702         * WebKitTestRunner/qt/TestControllerQt.cpp:
1703         (WTR::TestController::runModal): Added.
1704         * WebKitTestRunner/win/TestControllerWin.cpp:
1705         (WTR::TestController::runModal): Added.
1706
1707 2011-01-21  Eric Seidel  <eric@webkit.org>
1708
1709         Reviewed by Adam Barth.
1710
1711         Split Host object off from WebKitPatch for easier re-use
1712         https://bugs.webkit.org/show_bug.cgi?id=52284
1713
1714         new-run-webkit-tests and other tools are eventually going to want one of these.
1715         Basically you need to inherit from this class if you want to pretend to be a
1716         self.tool object for Steps/Commands.
1717
1718         * Scripts/webkitpy/common/host.py: Added.
1719         * Scripts/webkitpy/tool/main.py:
1720
1721 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1722
1723         Reviewed by Adam Barth.
1724
1725         Disable the tests that start and stop the http server and web
1726         server, so that we don't have to worry about port collisions on
1727         the bots.
1728
1729         https://bugs.webkit.org/show_bug.cgi?id=52861
1730
1731         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1732
1733 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1734
1735         Reviewed by Eric Seidel.
1736
1737         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1738         
1739         https://bugs.webkit.org/show_bug.cgi?id=52772
1740         
1741         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1742
1743 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1744
1745         Reviewed by Eric Siedel.
1746
1747         nrwt: clean up almost all remaining port references, remove
1748         unnecessary import clauses. The only remaining references are
1749         in places where a mock filesystem makes no sense or can't be
1750         used, and in one routine in port/google_chrome_unittest that
1751         I'll rewrite in a separate patch.
1752
1753         https://bugs.webkit.org/show_bug.cgi?id=52771
1754
1755         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1756         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1757         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1758         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1759         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1760         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1761         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1762         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1763         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1764         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1765         * Scripts/webkitpy/layout_tests/port/gtk.py:
1766         * Scripts/webkitpy/layout_tests/port/mac.py:
1767         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1768         * Scripts/webkitpy/layout_tests/port/qt.py:
1769         * Scripts/webkitpy/layout_tests/port/webkit.py:
1770         * Scripts/webkitpy/layout_tests/port/win.py:
1771         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1772
1773 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1774
1775         Reviewed by Mihai Parparita.
1776
1777         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1778
1779         https://bugs.webkit.org/show_bug.cgi?id=52762
1780
1781         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1782         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1783
1784 2011-01-20  Tony Chang  <tony@chromium.org>
1785
1786         Reviewed by Ojan Vafai.
1787
1788         [chromium] fix the paths used for the rebaseline tool
1789         https://bugs.webkit.org/show_bug.cgi?id=52857
1790
1791         Some of the bots were renamed so the path to grab the results zip
1792         file has changed.
1793
1794         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1795
1796 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1797
1798         Reviewed by Tony Chang.
1799
1800         Fix bug introduced in r72688 / bug 52768 that broke the
1801         generation of the output filename links in the results.html
1802         output. Apparently none of the unit tests actually checked to
1803         make sure the generated links were correct :(
1804
1805         https://bugs.webkit.org/show_bug.cgi?id=52854
1806
1807         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1808         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1809
1810 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1811
1812         Reviewed by Darin Adler.
1813
1814         https://bugs.webkit.org/show_bug.cgi?id=52849
1815         Make window.print work with WebKit2
1816
1817         * MiniBrowser/mac/BrowserWindowController.m:
1818         (-[BrowserWindowController awakeFromNib]):
1819         * WebKitTestRunner/TestController.cpp:
1820         (WTR::createOtherPage):
1821         (WTR::TestController::initialize):
1822         Added zeroes to WKPageUIClient structures to avoid build failures.
1823
1824 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1825
1826         Reviewed by Eric Seidel.
1827
1828         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1829
1830         https://bugs.webkit.org/show_bug.cgi?id=52756
1831
1832         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1833         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1834         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1835         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1836         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1837         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1838
1839 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1840
1841         Reviewed by Antonio Gomes.
1842
1843         QtTestBrowser should have a seperate menu for Settings
1844         https://bugs.webkit.org/show_bug.cgi?id=52817
1845         
1846         Added a new menu item named "Settings"
1847         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1848
1849         * QtTestBrowser/launcherwindow.cpp:
1850         (LauncherWindow::createChrome):
1851
1852 2011-01-20  Sam Weinig  <sam@webkit.org>
1853
1854         Reviewed by John Sullivan.
1855
1856         Update update-webkit-localizable-strings with new path to WebKit.
1857
1858         * Scripts/update-webkit-localizable-strings:
1859
1860 2011-01-20  James Robinson  <jamesr@chromium.org>
1861
1862         Reviewed by Darin Fisher.
1863
1864         Implement mozilla's requestAnimationFrame API
1865         https://bugs.webkit.org/show_bug.cgi?id=51218
1866
1867         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1868
1869         * DumpRenderTree/chromium/WebViewHost.cpp:
1870         (invokeScheduleComposite):
1871         (WebViewHost::scheduleAnimation):
1872         (WebViewHost::paintInvalidatedRegion):
1873         * DumpRenderTree/chromium/WebViewHost.h:
1874
1875 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1876
1877         Reviewed by Adam Roben.
1878
1879         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1880         https://bugs.webkit.org/show_bug.cgi?id=42327
1881
1882         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1883         for methods that take their normal arguments but also a JSContextRef.
1884         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1885         for evaluateScriptInIsolatedWorld.
1886         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1887         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1888         this call is for an isolated world.
1889         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1890         (WTR::worldMap): Helper to create a world map.
1891         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1892         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1893         added LayoutTestController API.
1894         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1895
1896 2011-01-19  Adam Roben  <aroben@apple.com>
1897
1898         Convert paths in environment variables back to msys-style inside commit-log-editor
1899
1900         When this script gets run from inside git commit, msys-style paths in the environment will
1901         have been turned into Windows-style paths with forward slashes. This screws up functions
1902         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1903         the paths back to msys-style before doing anything else.
1904
1905         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1906         using msysgit's Perl and multiple ChangeLogs have been edited
1907
1908         Reviewed by David Kilzer.
1909
1910         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1911         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1912         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1913
1914 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1915
1916         [Win] Unreviewed build fix after r76248.
1917
1918         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1919
1920 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1921
1922         Reviewed by Csaba Osztrogonác.
1923
1924         Refactoring of the custom allocation framework
1925         https://bugs.webkit.org/show_bug.cgi?id=49897
1926
1927         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1928         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1929         equivalent macro implementation at the necessary places.
1930 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1931
1932         Unreviewed. 
1933
1934         Adding myself to committers.py.
1935
1936         * Scripts/webkitpy/common/config/committers.py:
1937
1938 2011-01-20  Adam Barth  <abarth@webkit.org>
1939
1940         Reviewed by Tony Chang.
1941
1942         Chromium builders don't delete unversioned directories when DEPS change
1943         https://bugs.webkit.org/show_bug.cgi?id=52745
1944
1945         If we pass this option to gclient sync, gclient will delete directories
1946         that are no longer part of DEPS instead of leaving them around to
1947         confuse us later.  Apparently, the downstream buildbots use this option
1948         already.
1949
1950         * Scripts/update-webkit-chromium:
1951
1952 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1953
1954         Unreviewed, build fix - I pulled this patch in to fix an issue
1955         revealed by r76195 running on some new bots). Also fix a couple
1956         of other issues revealed in testing.
1957
1958         nrwt: remove fs refs from layout_package/json*
1959
1960         https://bugs.webkit.org/show_bug.cgi?id=52754
1961
1962         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1963         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1964         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1965         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1966         * Scripts/webkitpy/layout_tests/port/base.py:
1967
1968 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1969
1970         Unreviewed, build fix.
1971
1972         Fix a couple of minor bugs discovered while bringing up new bots
1973         for testing.
1974
1975         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1976         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1977
1978 2011-01-19  James Robinson  <jamesr@chromium.org>
1979
1980         Unreviewed, rolling out r76194.
1981         http://trac.webkit.org/changeset/76194
1982         https://bugs.webkit.org/show_bug.cgi?id=51218
1983
1984         Caused mysterious compile failure on the chromium win
1985         build.webkit.org bots
1986
1987         * DumpRenderTree/chromium/WebViewHost.cpp:
1988         (WebViewHost::paintInvalidatedRegion):
1989         * DumpRenderTree/chromium/WebViewHost.h:
1990
1991 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1992
1993         Reviewed by Mihai Parparita.
1994
1995         remove fs refs from test_runner, dump_render_tree_thread
1996
1997         https://bugs.webkit.org/show_bug.cgi?id=52753
1998
1999         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2000         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2001         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2002         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2003
2004 2011-01-19  James Robinson  <jamesr@chromium.org>
2005
2006         Reviewed by Darin Fisher.
2007
2008         Implement mozilla's requestAnimationFrame API
2009         https://bugs.webkit.org/show_bug.cgi?id=51218
2010
2011         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2012
2013         * DumpRenderTree/chromium/WebViewHost.cpp:
2014         (invokeScheduleComposite):
2015         (WebViewHost::scheduleAnimation):
2016         (WebViewHost::paintInvalidatedRegion):
2017         * DumpRenderTree/chromium/WebViewHost.h:
2018
2019 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2020
2021         Unreviewed, build fix.
2022
2023         Fix a few incorrect "self._filesystem" references introduced in
2024         r76184.
2025
2026         * Scripts/webkitpy/layout_tests/port/chromium.py:
2027         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2028
2029 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2030
2031         Reviewed by Mihai Parparita.
2032
2033         add a .sep property, abspath(), isabs(), mtime(), and
2034         open_text_file_for_writing() to filesystem modules. Some of
2035         these properties are not needed in this patch but will be needed
2036         in subsequent patches (I'm doing this to avoid having to track
2037         multiple versions of a single file).
2038
2039         Also, change most of the port/* modules to use the filesystem
2040         objects instead of referencing the filesystem directly.
2041
2042         https://bugs.webkit.org/show_bug.cgi?id=52748
2043
2044         * Scripts/webkitpy/common/system/filesystem.py:
2045         * Scripts/webkitpy/common/system/filesystem_mock.py:
2046         * Scripts/webkitpy/layout_tests/port/__init__.py:
2047         * Scripts/webkitpy/layout_tests/port/base.py:
2048         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2049         * Scripts/webkitpy/layout_tests/port/chromium.py:
2050         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2051         * Scripts/webkitpy/layout_tests/port/config.py:
2052         * Scripts/webkitpy/layout_tests/port/test.py:
2053         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2054
2055 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2056
2057         Reviewed by Anders Carlsson.
2058
2059         If resetting between tests times out, treat it as a WebProcess crash
2060         https://bugs.webkit.org/show_bug.cgi?id=52757
2061
2062         * WebKitTestRunner/TestController.cpp:
2063         (WTR::TestController::runTest):
2064
2065 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2066
2067         Reviewed by Darin Adler.
2068
2069         https://bugs.webkit.org/show_bug.cgi?id=52739
2070         Make it possible for a WebKit2 client to print headers and footers
2071
2072         Added dummy implementations for new printing UIClient calls.
2073
2074         * MiniBrowser/mac/BrowserWindowController.m:
2075         (-[BrowserWindowController awakeFromNib]):
2076         * WebKitTestRunner/TestController.cpp:
2077         (WTR::createOtherPage):
2078         (WTR::TestController::initialize):
2079
2080 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2081
2082         Reviewed by Ojan Vafai.
2083
2084         Change webkitpy/layout_tests/port/test.py to use the
2085         in-memory filesystem for cleaner unit testing. This
2086         change allows us to kill a lot of code that was
2087         specific to the test port, at the cost of being a
2088         little less clear about how things would work if
2089         you didn't have a filesystem.
2090
2091         https://bugs.webkit.org/show_bug.cgi?id=52605
2092
2093         * Scripts/webkitpy/layout_tests/port/test.py:
2094
2095 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2096
2097         Unreviewed, build fix.
2098
2099         Fix test failure caused by committing attachment 79368 instead
2100         of attachment 79461 on bug 52604.
2101
2102         * Scripts/webkitpy/common/system/filesystem_mock.py:
2103
2104 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2105
2106         Reviewed by Mihai Parparita.
2107
2108         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2109         unit testing. os.walk() is too much of a hassle to implement on
2110         top of the in-memory mock filesystem and adding the necessary
2111         interface to files_under() gives clients a cleaner API anyway
2112         (for this particular usage model).
2113
2114         https://bugs.webkit.org/show_bug.cgi?id=52691
2115
2116         * Scripts/webkitpy/common/system/filesystem.py:
2117         * Scripts/webkitpy/common/system/filesystem_mock.py:
2118         * Scripts/webkitpy/layout_tests/port/test_files.py:
2119         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2120
2121 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2122
2123         Reviewed by Tony Chang.
2124
2125         Change more modules in the layout-tests code to use the
2126         filesystem wrapper for cleaner unit testing.
2127
2128         This patch also adds the glob() wrapper to the filesystem
2129         abstraction.
2130         
2131         https://bugs.webkit.org/show_bug.cgi?id=52604
2132
2133         * Scripts/webkitpy/layout_tests/port/test_files.py:
2134         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2135         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2136         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2137         * Scripts/webkitpy/common/system/filesystem.py:
2138         * Scripts/webkitpy/common/system/filesystem_mock.py:
2139
2140 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2141
2142         Unreviewed.
2143
2144         Updating my email addresses and irc nick.
2145
2146         * Scripts/webkitpy/common/config/committers.py:
2147
2148 2011-01-19  Tony Chang  <tony@chromium.org>
2149
2150         Reviewed by Mihai Parparita.
2151
2152         [chromium] [linux] if check-sys-deps fails, output the failure reason
2153         https://bugs.webkit.org/show_bug.cgi?id=52671
2154
2155         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2156             error handler functions.
2157         * Scripts/webkitpy/layout_tests/port/chromium.py:
2158             output the error text from --check-sys-deps
2159         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2160
2161 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2162
2163         Reviewed by Andreas Kling.
2164
2165         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2166         https://bugs.webkit.org/show_bug.cgi?id=52554
2167         
2168         QtNetworkAccessManager is created in a thread and set as
2169         member variable in QWebPage. When the thread is destroyed
2170         the object is still used. So fix will set the object to
2171         NULL once the thread is destroyed.
2172
2173         * QtTestBrowser/launcherwindow.cpp:
2174         (LauncherWindow::~LauncherWindow):
2175
2176 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2177
2178         Rubber stamped by Csaba Osztrogonac
2179
2180         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2181
2182 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2183
2184         Reviewed by Tony Chang.
2185
2186         new-run-webkit-tests: add a --build-directory command line argument
2187
2188         Official Google Chrome builds use a non-standard build directory
2189         location. This patch adds a --build-directory argument that
2190         allows that location to be specified on the command line. Only
2191         Chromium-based builds will use this flag for now, but anyone can
2192         in the future.
2193
2194         There are no unit tests for this since it's difficult to test
2195         until mock filesystems are fully supported in the code. This was
2196         tested by hand for now.
2197
2198         https://bugs.webkit.org/show_bug.cgi?id=52694
2199
2200         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2201         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2202         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2203         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2204
2205 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2206
2207         Not reviewed. Bot fix.
2208
2209         Remove an inadvertently committed debugging print.
2210
2211         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2212         (LayoutTestController::notifyDone):
2213
2214 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2215
2216         Reviewed by Sam Weinig.
2217
2218         WebKitTestRunner should track loading more like DumpRenderTree
2219         https://bugs.webkit.org/show_bug.cgi?id=52692
2220
2221         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2222         This makes some tests that call notifyDone multiple times pass.
2223         
2224         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2225         (WTR::InjectedBundle::InjectedBundle):
2226         (WTR::InjectedBundle::done):
2227         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2228         (WTR::InjectedBundle::topLoadingFrame):
2229         (WTR::InjectedBundle::setTopLoadingFrame):
2230         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2231         (WTR::InjectedBundlePage::InjectedBundlePage):
2232         (WTR::InjectedBundlePage::stopLoading):
2233         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2234         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2235         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2236         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2237         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2238         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2239         (WTR::LayoutTestController::notifyDone):
2240         * WebKitTestRunner/TestController.cpp:
2241         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2242
2243 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2244
2245         Reviewed by Kent Tamura.
2246
2247         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2248         https://bugs.webkit.org/show_bug.cgi?id=52678
2249         
2250         Update path now that WebKit is inside Source.
2251
2252         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2253
2254 2011-01-18  Robert Hogan  <robert@webkit.org>
2255
2256         Reviewed by Simon Hausmann.
2257
2258         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2259         https://bugs.webkit.org/show_bug.cgi?id=44282
2260
2261         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2262         (WebCore::DumpRenderTree::dump):
2263
2264 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2265
2266         Reviewed by Mihai Parparita.
2267
2268         Fix a small race condition that could cause the unit tests for
2269         new-run-webkit-tests to fail in a multithreaded environment.
2270         There was a small window in the code where one thread would
2271         check to see if a thread had raised an exception, do something,
2272         and then check to see if the thread was alive. If the other
2273         thread raised an exception and exited in between these two
2274         steps, the exception would be lost. Flipping the order of the
2275         two checks fixes the race, since we will now always check for an
2276         exception on the thread before exiting.
2277
2278         https://bugs.webkit.org/show_bug.cgi?id=51579
2279
2280         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2281
2282 2011-01-18  Eric Seidel  <eric@webkit.org>
2283
2284         Reviewed by Adam Barth.
2285
2286         commit-queue dies when test archiving fails
2287         https://bugs.webkit.org/show_bug.cgi?id=52617
2288
2289         I looked at the machine and it had 10 archives already
2290         thus find_unused_name was returning None.  I've upped
2291         the limit to 100 (per bug) and tested the case where
2292         find_unused_name returns None (making archive return None).
2293
2294         * Scripts/webkitpy/common/system/workspace.py:
2295         * Scripts/webkitpy/common/system/workspace_unittest.py:
2296         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2297         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2298         * Scripts/webkitpy/tool/commands/queues.py:
2299
2300 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2301
2302         Reviewed by Ojan Vafai.
2303
2304         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2305         filesystem. Also fix a couple of "with" statements missed by
2306         r76050.
2307
2308         https://bugs.webkit.org/show_bug.cgi?id=52487
2309
2310         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2311
2312 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2313
2314         Reviewed by Martin Robinson.
2315
2316         [Gtk] Build fixes for gtk3 build
2317         https://bugs.webkit.org/show_bug.cgi?id=52648
2318
2319         * DumpRenderTree/gtk/EventSender.cpp:
2320         (beginDragWithFilesCallback):
2321
2322 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2323
2324         Reviewed by Mihai Parparita.
2325
2326         Update rebaseline-chromium-webkit-tests to use filesystem objects
2327         instead of direct references to os.path, shutil, tempfile, etc.
2328
2329         This patch doesn't change anything, but will allow subsequent
2330         patches to change the unit tests to no longer use the real
2331         filesystem.
2332
2333         This patch adds a bunch more methods to the filesystem object as
2334         well.
2335
2336         https://bugs.webkit.org/show_bug.cgi?id=52482
2337
2338         * Scripts/webkitpy/common/system/filesystem.py:
2339         * Scripts/webkitpy/common/system/filesystem_mock.py:
2340         * Scripts/webkitpy/tool/commands/queues.py:
2341         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2342         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2343
2344 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2345
2346         Reviewed by Mihai Parparita.
2347
2348         new-run-webkit-tests shouldn't crash when you try to run a
2349         directory containing only skipped files.
2350
2351         https://bugs.webkit.org/show_bug.cgi?id=52478
2352         
2353         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2354         * Scripts/webkitpy/layout_tests/port/test.py:
2355         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2356
2357 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2358
2359         Reviewed by Gustavo Noronha Silva.
2360
2361         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2362         https://bugs.webkit.org/show_bug.cgi?id=40833
2363
2364         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2365         GTK+ event sender.
2366         (dragWithFilesDragDataGetCallback): Added.
2367         (dragWithFilesDragEndCallback): Added.
2368         (beginDragWithFilesCallback): Added.
2369
2370 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2371
2372         Reviewed by Adam Barth.
2373
2374         ews: Add additional watcher to efl ews
2375         https://bugs.webkit.org/show_bug.cgi?id=52613
2376
2377         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2378
2379         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2380
2381 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2382
2383         Reviewed by Alexey Proskuryakov.
2384
2385         Fix some headers with missing or misspelled #ifndef guards
2386         https://bugs.webkit.org/show_bug.cgi?id=52545
2387
2388         * DumpRenderTree/chromium/TestEventPrinter.h:
2389         * DumpRenderTree/chromium/WebPreferences.h:
2390
2391 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2392
2393         Reviewed by Anders Carlsson.
2394
2395         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2396         navigating back to an unreachable URL
2397         https://bugs.webkit.org/show_bug.cgi?id=52388
2398
2399         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2400
2401         * DumpRenderTree/LayoutTestController.cpp:
2402         (queueLoadHTMLStringCallback):
2403         (LayoutTestController::queueLoadHTMLString):
2404         (LayoutTestController::queueLoadAlternateHTMLString):
2405         * DumpRenderTree/LayoutTestController.h:
2406
2407         * DumpRenderTree/WorkQueueItem.h:
2408         (LoadHTMLStringItem::LoadHTMLStringItem):
2409
2410         * DumpRenderTree/chromium/LayoutTestController.cpp:
2411         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2412         (WorkItemLoadHTMLString::run):
2413         (LayoutTestController::queueLoadHTMLString):
2414
2415         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2416         (LoadHTMLStringItem::invoke):
2417         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2418         (LoadHTMLStringItem::invoke):
2419         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2420         (LoadHTMLStringItem::invoke):
2421
2422 2011-01-17  Dan Bernstein  <mitz@apple.com>
2423
2424         Rubber-stamped by Mark Rowe.
2425
2426         Update xcodeproj svn:ignore to include xcuserdata.
2427
2428         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2429         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2430         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2431         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2432         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2433
2434 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2435
2436         Unreviewed fix after r75908.
2437
2438         Move WebKit into Source
2439         https://bugs.webkit.org/show_bug.cgi?id=52530
2440
2441         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2442
2443 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2444
2445         Unreviewed.
2446
2447         Remove accidentally committed debug printing after r75908.
2448
2449         * Scripts/webkitdirs.pm:
2450
2451 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2452
2453         Unreviewed.
2454
2455         Add myself to committers list
2456         https://bugs.webkit.org/show_bug.cgi?id=52566
2457
2458         * Scripts/webkitpy/common/config/committers.py:
2459
2460 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2461
2462         Reviewed by Jeremy Orlow.
2463
2464         GeolocationController should call stopUpdating on destruction
2465         https://bugs.webkit.org/show_bug.cgi?id=52216
2466
2467         fast/dom/Geolocation/window-close-crash.html requires that a
2468         Geolocation watch be started in a secondary window. Consequently,
2469         we need to allow geolocation permission and provide a mock
2470         geolocation position for the secondary window's
2471         GeolocationClientMock.
2472
2473         * DumpRenderTree/chromium/LayoutTestController.cpp:
2474         (LayoutTestController::setGeolocationPermission):
2475         (LayoutTestController::setMockGeolocationPosition):
2476         (LayoutTestController::setMockGeolocationError):
2477         * DumpRenderTree/chromium/TestShell.h:
2478         (TestShell::windowList):
2479
2480 2011-01-16  Adam Barth  <abarth@webkit.org>
2481
2482         Update more include paths to reflect WebKit move.
2483
2484         * DumpRenderTree/chromium/EventSender.cpp:
2485         (EventSender::keyDown):
2486         (EventSender::needsShiftModifier):
2487         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2488         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2489
2490 2011-01-16  Kent Tamura  <tkent@chromium.org>
2491
2492         Unreviewed, Chromium build fix.
2493
2494         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2495
2496 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2497
2498         Build fix for GTK+ after source directory movement.
2499
2500         * GNUmakefile.am: Correct include paths.
2501
2502 2011-01-16  Adam Barth  <abarth@webkit.org>
2503
2504         Teach svn-apply about WebKit move.
2505
2506         * Scripts/VCSUtils.pm:
2507
2508 2011-01-16  Adam Barth  <abarth@webkit.org>
2509
2510         Rubber-stamped by Eric Seidel.
2511
2512         Move WebKit into Source
2513         https://bugs.webkit.org/show_bug.cgi?id=52530
2514
2515         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2516         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2517         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2518         * DumpRenderTree/qt/GCControllerQt.cpp:
2519         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2520         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2521         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2522         * DumpRenderTree/wscript:
2523         * QtTestBrowser/launcherwindow.h:
2524         * Scripts/build-webkit:
2525         * Scripts/webkitdirs.pm:
2526
2527 2011-01-15  Adam Barth  <abarth@webkit.org>
2528
2529         Teach svn-apply about WebKit2 move.
2530
2531         * Scripts/VCSUtils.pm:
2532
2533 2011-01-15  Adam Barth  <abarth@webkit.org>
2534
2535         Rubber-stamped by Eric Seidel.
2536
2537         Move WebKit2 into Source
2538         https://bugs.webkit.org/show_bug.cgi?id=52438
2539
2540         * MiniBrowser/qt/MiniBrowser.pro:
2541         * Scripts/build-webkit:
2542         * Scripts/do-file-rename:
2543         * Scripts/do-webcore-rename:
2544         * Scripts/test-webkitpy:
2545         * Scripts/webkitdirs.pm:
2546         * Scripts/webkitpy/style/checker.py:
2547         * WebKitTestRunner/DerivedSources.pro:
2548         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2549         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2550
2551 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2552
2553         Reviewed by David Levin.
2554
2555         [chromium] remove obsolete createView method
2556         https://bugs.webkit.org/show_bug.cgi?id=52437
2557
2558         * DumpRenderTree/chromium/WebViewHost.cpp:
2559         (WebViewHost::createView):
2560         * DumpRenderTree/chromium/WebViewHost.h:
2561
2562 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2563
2564         Reviewed by Geoff Garen.
2565
2566         ShouldLoadResourceForFrame should use strings, not URLs.
2567         https://bugs.webkit.org/show_bug.cgi?id=52476
2568
2569         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2570         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2571         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2572
2573 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2574
2575         Reviewed by David Levin.
2576
2577         Add Tony Gentilcore as a reviewer
2578         https://bugs.webkit.org/show_bug.cgi?id=52480
2579
2580         * Scripts/webkitpy/common/config/committers.py:
2581
2582 2011-01-14  David Levin  <levin@chromium.org>
2583
2584         Reviewed by Eric Seidel.
2585
2586         check-webkit-style: _FunctionState should keep track of where the function name starts.
2587         https://bugs.webkit.org/show_bug.cgi?id=52454
2588
2589         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2590         _FunctionState and logic for setting it correctly.
2591         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2592
2593 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2594
2595         Reviewed by David Levin.
2596
2597         Add support to DumpRenderTree to use the GPU rather than software renderer
2598         https://bugs.webkit.org/show_bug.cgi?id=52333
2599
2600         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2601         (main):
2602         * Scripts/webkitpy/layout_tests/port/chromium.py:
2603         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2604
2605 2011-01-14  Tony Chang  <tony@chromium.org>
2606
2607         Reviewed by Kent Tamura.
2608
2609         [chromium] update fonts.conf to fix 6 linux tests in drt
2610         https://bugs.webkit.org/show_bug.cgi?id=52411
2611
2612         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2613             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2614
2615 2011-01-14  Eric Seidel  <eric@webkit.org>
2616
2617         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2618
2619         Reviewed by Adam Barth.
2620
2621         Fix when running Tools/Scripts/check-webkit-style without arguments.
2622         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2623
2624         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2625         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2626
2627 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2628
2629         Reviewed by David Levin.
2630
2631         Store the tempdir object in a variable so it doesn't get deleted too early.
2632         https://bugs.webkit.org/show_bug.cgi?id=51875
2633
2634         * Scripts/update-webkit-auxiliary-libs:
2635         * Scripts/update-webkit-support-libs:
2636
2637 2011-01-14  Eric Seidel  <eric@webkit.org>
2638
2639         Unreviewed.  Make it work in python 2.5.
2640
2641         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2642         https://bugs.webkit.org/show_bug.cgi?id=49158
2643
2644         * Scripts/webkitpy/common/checkout/api_unittest.py:
2645
2646 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2647
2648         Unreviewed, rolling out r75774.
2649         http://trac.webkit.org/changeset/75774
2650         https://bugs.webkit.org/show_bug.cgi?id=52431
2651
2652         gtk builds were broken (Requested by loislo2 on #webkit).
2653
2654         * Scripts/webkitpy/common/checkout/scm.py:
2655
2656 2011-01-14  David Levin  <levin@chromium.org>
2657
2658         Reviewed by Shinichiro Hamaji.
2659
2660         check-webkit-style: _FunctionState should detect pure functions.
2661         https://bugs.webkit.org/show_bug.cgi?id=52428
2662
2663         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2664         is a pure virtual function.
2665         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2666         virtual functions are correctly detected.
2667
2668 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2669
2670         Reviewed by Yury Semikhatsky.
2671
2672         Just small fix for problem with check-webkit-style.
2673         It just didn't work for this patch.
2674         Old code can't concatenate a list of strings with None.
2675
2676         * Scripts/webkitpy/common/checkout/scm.py:
2677
2678 2011-01-13  David Levin  <levin@chromium.org>
2679
2680         Reviewed by Shinichiro Hamaji.
2681
2682         check-webkit-style: _FunctionState should use Position to know where items are.
2683         https://bugs.webkit.org/show_bug.cgi?id=52424
2684
2685         * Scripts/webkitpy/style/checkers/cpp.py:
2686         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2687         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2688         did some minor clean-up.
2689         (*): Other changes are simply about converting to use the Position's in_FunctionState
2690         instead of line numbers.
2691         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2692         to verify the positions stored in _FunctionState.
2693
2694 2011-01-13  Eric Seidel  <eric@webkit.org>
2695
2696         Reviewed by David Levin.
2697
2698         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2699         https://bugs.webkit.org/show_bug.cgi?id=49158
2700
2701         This is not the most elegant, but it is a very safe fix to this bug.
2702         One advantage of catching ScriptError like this instead of adding a
2703         new added_or_modified_files or fixing all changed_files callers
2704         to use a more specific change_files variant, is that we catch
2705         all kinds of ScriptErrors which might cause our (non-essential)
2706         suggest-reviewers code to fail out.  This should make passing
2707         --suggest-reviewers to webkit-patch upload much more robust
2708         and may even make it possible for us to make it default.
2709
2710         The root of the problem here is that SCM.changed_files includes
2711         deleted ChangeLog paths (from moves, etc) which then when we ask
2712         SVN/Git for the contents of the file at that revision, the command
2713         errors out and Executive.run_command raises a ScriptError.
2714
2715         In the future we might fix this differently by making all current
2716         callers of chagned_files use a more specific method for requesting
2717         what types of changes they're interested in (adds, modifies, deletes, etc.)
2718
2719         * Scripts/webkitpy/common/checkout/api.py:
2720         * Scripts/webkitpy/common/checkout/api_unittest.py:
2721
2722 2011-01-13  Dan Bernstein  <mitz@apple.com>
2723
2724         Reviewed by Alexey Proskuryakov.
2725
2726         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2727         https://bugs.webkit.org/show_bug.cgi?id=52419
2728
2729         Allow to further control the behavior of the willSendRequest delegate callback by making it
2730         set a different URL in the new request.
2731
2732         * DumpRenderTree/LayoutTestController.cpp:
2733         (addURLToRedirectCallback): Added.
2734         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2735         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2736         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2737         * DumpRenderTree/LayoutTestController.h:
2738         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2739         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2740         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2741         change the URL in the new request to the redirect destination.
2742
2743 2011-01-13  Eric Seidel  <eric@webkit.org>
2744
2745         Reviewed by Mihai Parparita.
2746
2747         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2748         https://bugs.webkit.org/show_bug.cgi?id=52416
2749
2750         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2751         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2752
2753         I also added FIXMEs about the changed_files returning deleted files problem
2754         which is causing the other most common exception for suggest-reviewers
2755         (and is probably breaking sheriff-bots blame detection).
2756
2757         * Scripts/webkitpy/common/checkout/api.py:
2758         * Scripts/webkitpy/common/checkout/api_unittest.py:
2759         * Scripts/webkitpy/common/checkout/scm.py:
2760
2761 2011-01-13  Eric Seidel  <eric@webkit.org>
2762
2763         Reviewed by Adam Barth.
2764
2765         results archives from commit-queue are too large to upload
2766         https://bugs.webkit.org/show_bug.cgi?id=52405
2767
2768         * Scripts/webkitpy/common/system/filesystem.py:
2769         * Scripts/webkitpy/common/system/filesystem_mock.py:
2770         * Scripts/webkitpy/tool/commands/queues.py:
2771
2772 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2773
2774         Reviewed by Martin Robinson.
2775
2776         [gtk] Zero-sized font does not yet work
2777         https://bugs.webkit.org/show_bug.cgi?id=49793
2778
2779         Set minimum-font-size to 0 for the DRT.
2780
2781         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2782         (resetDefaultsToConsistentValues):
2783
2784 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2785
2786         Reviewed by Darin Adler.
2787
2788         Make old-run-webkit-tests more robust on buildbots
2789         https://bugs.webkit.org/show_bug.cgi?id=52364
2790
2791         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2792
2793 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2794
2795         Reviewed by Darin Adler.
2796
2797         Make old-run-webkit-tests more robust on buildbots
2798         https://bugs.webkit.org/show_bug.cgi?id=52364
2799
2800         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2801
2802 2011-01-13  Tony Chang  <tony@chromium.org>
2803
2804         Reviewed by Kent Tamura.
2805
2806         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2807         https://bugs.webkit.org/show_bug.cgi?id=52332
2808
2809         Forked Info.plist is not longer needed.
2810
2811         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2812
2813 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2814
2815         Reviewed by Timothy Hatcher.
2816
2817         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2818         to be passed directly to WebInspector.UIString
2819
2820         https://bugs.webkit.org/show_bug.cgi?id=52365
2821
2822         * Scripts/check-inspector-strings:
2823
2824 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2825
2826         Unreviewed, rolling out r74881.
2827         http://trac.webkit.org/changeset/74881
2828         https://bugs.webkit.org/show_bug.cgi?id=52357
2829
2830         The EFL builder has been red for days (Requested by abarth on
2831         #webkit).
2832
2833         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2834         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2835
2836 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2837
2838         Reviewed by David Levin.
2839
2840         Add beforeunload support to WebKitTestRunner
2841         https://bugs.webkit.org/show_bug.cgi?id=52353
2842         
2843         This makes a number of currently failing tests pass.
2844
2845         * WebKitTestRunner/TestController.cpp:
2846         (WTR::runBeforeUnloadConfirmPanel):
2847         (WTR::createOtherPage):
2848         (WTR::TestController::initialize):
2849
2850 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2851
2852         Reviewed by Sam Weinig.
2853
2854         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2855         https://bugs.webkit.org/show_bug.cgi?id=52330
2856
2857         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2858         a web process crash.
2859         * WebKitTestRunner/TestController.cpp:
2860         (WTR::TestController::initialize): Set up a processDidCrash
2861         callback.
2862         (WTR::TestController::processDidCrash): Report that the Web process
2863         crashed.
2864         * WebKitTestRunner/TestController.h:
2865
2866 2011-01-12  David Levin  <levin@chromium.org>
2867
2868         Reviewed by Shinichiro Hamaji.
2869
2870         check-webkit-style -- close_expression function doesn't work correctly.
2871         https://bugs.webkit.org/show_bug.cgi?id=52272
2872
2873         * Scripts/webkitpy/style/checkers/cpp.py:
2874         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2875         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2876         generally useful (for upcoming code changes).
2877         (close_expression): Changed to use Position for input and output.
2878         Also, fixed many bugs such as only working correctly for parenthesis,
2879         not working correctly if given an offset in a line and not finding
2880         the real closing element if there were multiple closing elements in
2881         the same line.
2882         (detect_functions): Adjusted due to the change in arguments for
2883         close_expression.
2884         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2885         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2886         two positions are the same.
2887         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2888         (CppStyleTest.test_close_expression): Added tests to catch the issues
2889         that were fixed.
2890
2891 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2892
2893         Unreviewed, rolling out r75576.
2894         http://trac.webkit.org/changeset/75576
2895         https://bugs.webkit.org/show_bug.cgi?id=52304
2896
2897         broke rebaseline-chromium-webkit-test (Requested by thakis on
2898         #webkit).
2899
2900         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2901         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2902         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2903         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2904         * Scripts/webkitpy/layout_tests/port/base.py:
2905         * Scripts/webkitpy/layout_tests/port/chromium.py:
2906         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2907         * Scripts/webkitpy/layout_tests/port/test.py:
2908         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2909         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2910         * Scripts/webkitpy/style/checkers/test_expectations.py:
2911         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2912
2913 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2914
2915         Reviewed by Darin Adler.
2916
2917         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2918         https://bugs.webkit.org/show_bug.cgi?id=52307
2919
2920         * Scripts/old-run-webkit-tests:
2921
2922 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2923
2924         Reviewed by Martin Robinson.
2925
2926         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2927         https://bugs.webkit.org/show_bug.cgi?id=50867
2928
2929         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2930         TestNetscapePlugin.cpp 
2931
2932         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2933         * Scripts/webkitdirs.pm:
2934
2935 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2936
2937         Reviewed by Pavel Feldman.
2938
2939         Add check-inspector-strings script.
2940
2941         https://bugs.webkit.org/show_bug.cgi?id=52295
2942
2943         * Scripts/check-inspector-strings: Added.
2944
2945 2011-01-12  Adam Roben  <aroben@apple.com>
2946
2947         Advertise the .testnetscape file extension on Windows
2948
2949         Fixes <http://webkit.org/b/52298>
2950         plugins/no-mime-with-valid-extension.html fails on Windows
2951
2952         Reviewed by Dan Bernstein.
2953
2954         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2955         FileExtents field to map the .testnetscape file extension to the
2956         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2957
2958 2011-01-12  Adam Barth  <abarth@webkit.org>
2959
2960         Reviewed by Eric Seidel.
2961
2962         Make webkit-patch support subdirectories for SVN checkouts
2963         https://bugs.webkit.org/show_bug.cgi?id=52261
2964
2965         os.relpath does not exist on Python 2.5, so we need to call our version
2966         of the API.
2967
2968         * Scripts/webkitpy/common/checkout/scm.py:
2969
2970 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2971
2972         Reviewed by Eric Seidel.
2973
2974         Close additional pages opened during a test once the test completes.
2975         https://bugs.webkit.org/show_bug.cgi?id=52276
2976
2977         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2978         (WTR::InjectedBundle::done):
2979
2980 2011-01-11  David Levin  <levin@chromium.org>
2981
2982         Reviewed by Eric Seidel.
2983
2984         Errors should be separated from the command line in bot messages.
2985         https://bugs.webkit.org/show_bug.cgi?id=52275
2986
2987         * Scripts/webkitpy/common/system/executive.py:
2988         (ScriptError.message_with_output): Added a newline to separate the command
2989         line from the errors.
2990         * Scripts/webkitpy/common/system/executive_unittest.py:
2991         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2992         paths in message_with_output.
2993
2994 2011-01-11  Eric Seidel  <eric@webkit.org>
2995
2996         Unreviewed.
2997
2998         commit-queue should know how to upload archived results (for test flakes or general failures)
2999         https://bugs.webkit.org/show_bug.cgi?id=52048
3000
3001         The zips are mostly empty due to forgetting -r.
3002         Expected diffs were not being pulled from the archive due
3003         to the archive having longer paths than I realized.
3004
3005         * Scripts/webkitpy/common/system/workspace.py:
3006         * Scripts/webkitpy/common/system/workspace_unittest.py:
3007         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3008         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3009
3010 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3011
3012         Reviewed by Ojan Vafai.
3013
3014         The current modifier parsing code in test_expectations is
3015         fragile and hard-coded, so it's not easy to understand the logic
3016         or easily add new types of modifiers (like GPU vs. CPU testing
3017         for graphics tests, or 32-bit vs. 64-bit differences).
3018
3019         This is the first of two patches that will add in more generic
3020         support and then eliminate the GPU-specific test expectations
3021         files for Chromium.
3022
3023         This patch adds two standalone objects for handling modifiers. The
3024         rules for interpreting modifiers, precedence, and conflicts are
3025         given in the docstring to the ModifierMatcher class, which
3026         returns ModifierMatchResult objects.
3027         
3028         This patch also adds routines to the Port interface and a
3029         default set of values in the base object, in order to obtain the
3030         values needed on a given test run. These values are then passed
3031         to the expectation parser. This also allows us to clean up the
3032         logic used to lint all of the different configurations in a
3033         single test_expectations.txt file.
3034
3035         The next patch will merge in the separate GPU expectations file.
3036
3037         https://bugs.webkit.org/show_bug.cgi?id=51222
3038
3039         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3040         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3041         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3042         * Scripts/webkitpy/layout_tests/port/base.py:
3043         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3044         * Scripts/webkitpy/layout_tests/port/chromium.py:
3045         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3046         * Scripts/webkitpy/layout_tests/port/test.py:
3047         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3048         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3049
3050 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3051
3052         Reviewed by Adam Barth.
3053
3054         Make webkit-patch support subdirectories for SVN checkouts
3055         https://bugs.webkit.org/show_bug.cgi?id=52261
3056
3057         * Scripts/webkitpy/common/checkout/scm.py:
3058         * Scripts/webkitpy/style_references.py:
3059         * Scripts/webkitpy/tool/main.py:
3060         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3061
3062 2011-01-11  Eric Seidel  <eric@webkit.org>
3063
3064         Unreviewed.
3065
3066         commit-queue should know how to upload archived results (for test flakes or general failures)
3067         https://bugs.webkit.org/show_bug.cgi?id=52048
3068
3069         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3070         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3071
3072         * Scripts/webkitpy/common/system/workspace.py:
3073         * Scripts/webkitpy/common/system/workspace_unittest.py:
3074         * Scripts/webkitpy/tool/commands/queues.py:
3075
3076 2011-01-11  Sam Weinig  <sam@webkit.org>
3077
3078         Roll r75474 back in.
3079
3080 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3081
3082         Reviewed by Kenneth Rohde Christiansen.
3083
3084         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3085         https://bugs.webkit.org/show_bug.cgi?id=51204
3086
3087         * QtTestBrowser/webpage.h:
3088         (QtNAMThread::QtNAMThread):
3089         (QtNAMThread::networkAccessManager):
3090         (QtNAMThread::run):
3091
3092 2011-01-11  Peter Varga  <pvarga@webkit.org>
3093
3094         Unreviewed.
3095
3096         Add myself to committers' list.
3097
3098         * Scripts/webkitpy/common/config/committers.py:
3099
3100 2011-01-11  Eric Seidel  <eric@webkit.org>
3101
3102         Reviewed by Adam Barth.
3103
3104         commit-queue should know how to upload archived results (for test flakes or general failures)
3105         https://bugs.webkit.org/show_bug.cgi?id=52048
3106
3107         Now the queue will always upload results.  Either the entire zip, or just
3108         the diffs.txt in the case of text failures.
3109
3110         This should make understanding flakes much easier, and paves the way
3111         for having the EWS run layout tests (and upload failures).
3112
3113         In order to upload .zip files I had to teach bugzilla.py to autodetect
3114         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3115         for .patch files, I have it add one before calling guess_type.
3116
3117         We may find that always uploading the whole zip instead of just the -diffs.txt
3118         file is preferable, but for now I'm keeping the old behavior because it makes
3119         quickly understanding text failures easy.
3120
3121         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3122         * Scripts/webkitpy/common/system/workspace.py: Added.
3123         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3124         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3125         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3126         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3127         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3128         * Scripts/webkitpy/tool/commands/queues.py:
3129         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3130
3131 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3132
3133         Unreviewed, rolling out r75464.
3134         http://trac.webkit.org/changeset/75464
3135         https://bugs.webkit.org/show_bug.cgi?id=52193
3136
3137         Followup rollout for 75474 (Requested by Ossy on #webkit).
3138
3139         * MiniBrowser/mac/BrowserWindowController.m:
3140         (-[BrowserWindowController awakeFromNib]):
3141         * MiniBrowser/win/BrowserView.cpp:
3142         (BrowserView::create):
3143         * WebKitTestRunner/TestController.cpp:
3144         (WTR::createOtherPage):
3145         (WTR::TestController::initialize):
3146
3147 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3148
3149         Reviewed by Csaba Osztrogonác.
3150
3151         [Qt] Baseline qt_minimal configuration
3152         https://bugs.webkit.org/show_bug.cgi?id=51313
3153
3154         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3155         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3156         QT_NO_UNDOSTACK guard.
3157
3158         * QtTestBrowser/launcherwindow.cpp:
3159         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3160         guards.
3161         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3162         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3163         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3164         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3165
3166         * QtTestBrowser/launcherwindow.h:
3167         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3168         * QtTestBrowser/locationedit.h: Ditto.
3169
3170         * QtTestBrowser/mainwindow.cpp:
3171         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3172         QT_NO_UNDOSTACK guards.
3173         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3174         (MainWindow::changeLocation): Ditto.
3175         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3176         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3177
3178         * QtTestBrowser/webpage.cpp:
3179         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3180         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3181
3182         * QtTestBrowser/webview.cpp:
3183         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3184         (WebViewGraphicsBased::animatedYFlip): Ditto.
3185
3186 2011-01-10  Sam Weinig  <sam@webkit.org>
3187
3188         Fix build.
3189
3190         * MiniBrowser/mac/BrowserWindowController.m:
3191         (-[BrowserWindowController awakeFromNib]):
3192         * MiniBrowser/win/BrowserView.cpp:
3193         (BrowserView::create):
3194         * WebKitTestRunner/TestController.cpp:
3195         (WTR::createOtherPage):
3196         (WTR::TestController::initialize):
3197
3198 2011-01-10  Eric Seidel  <eric@webkit.org>
3199
3200         Reviewed by Ojan Vafai.
3201
3202         style-queue messages are way too long for big patches
3203         https://bugs.webkit.org/show_bug.cgi?id=52161
3204
3205         We definitely could build much fancier list-to-string-with-limit functions
3206         but this should be sufficient for our needs at the moment.
3207
3208         * Scripts/webkitpy/common/system/executive.py:
3209         * Scripts/webkitpy/common/system/executive_unittest.py:
3210
3211 2011-01-10  Tony Chang  <tony@chromium.org>
3212
3213         Unreviewed, rolling out r75398.
3214         http://trac.webkit.org/changeset/75398
3215         https://bugs.webkit.org/show_bug.cgi?id=52008
3216
3217         Some layout tests are crashing on Chromium Win.
3218
3219         * DumpRenderTree/chromium/WebViewHost.cpp:
3220         (WebViewHost::updatePaintRect):
3221         * DumpRenderTree/chromium/WebViewHost.h:
3222
3223 2011-01-10  Adam Roben  <aroben@apple.com>
3224
3225         Roll out r75392
3226
3227         It isn't needed now that r75289 has been rolled out.
3228
3229         * Scripts/run-javascriptcore-tests:
3230
3231 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3232
3233         Reviewed by Anders Carlsson.
3234
3235         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3236         https://bugs.webkit.org/show_bug.cgi?id=52160
3237
3238         * WebKitTestRunner/mac/TestControllerMac.mm:
3239         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3240         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3241         anyway.
3242
3243 2011-01-10  Tony Chang  <tony@chromium.org>
3244
3245         Reviewed by Mihai Parparita.
3246
3247         [chromium] fix for animated gif layout tests
3248         https://bugs.webkit.org/show_bug.cgi?id=52008
3249
3250         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3251             to trigger gif animations.
3252         (WebViewHostPaintTask::WebViewHostPaintTask):
3253         (WebViewHostPaintTask::runIfValid):
3254         (WebViewHost::updatePaintRect):
3255         * DumpRenderTree/chromium/WebViewHost.h:
3256         (WebViewHost::taskList):
3257
3258 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3259
3260         Reviewed by Xan Lopez.
3261
3262         [GTK] Fix gtk2 compilation for master
3263         https://bugs.webkit.org/show_bug.cgi?id=51885
3264
3265         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3266         (createBitmapContextFromWebView): Replaced the old
3267         gdk_drawable_get_size with gdk_pixmap_get_size.
3268
3269 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3270
3271         Reviewed by Laszlo Gombos.
3272
3273         [WINCE] Reenable NPAPI after r75203
3274         https://bugs.webkit.org/show_bug.cgi?id=52109
3275
3276         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3277         it with !isEfl(), because EFL port does not support NPAPI (yet).
3278
3279         * Scripts/build-webkit:
3280
3281 2011-01-10  Adam Roben  <aroben@apple.com>
3282
3283         Skip some asserting JS tests
3284
3285         See <http://webkit.org/b/52156>.
3286
3287         * Scripts/run-javascriptcore-tests:
3288
3289 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3290
3291         Reviewed by Xan Lopez.
3292
3293         [GTK] build-webkit disable Blob support via arguments passed to automake
3294         https://bugs.webkit.org/show_bug.cgi?id=52097
3295
3296         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3297         build-webkit.
3298
3299 2011-01-10  Adam Roben  <aroben@apple.com>
3300
3301         Use the same name and description for TestNetscapePlugin on Windows and
3302         Mac
3303
3304         Fixes <http://webkit.org/b/52151>
3305         fast/frames/iframe-reparenting-plugins.html fails on Windows
3306
3307         Reviewed by Steve Falkenburg.
3308
3309         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3310         the name and description from Mac's Info.plist.
3311
3312 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3313
3314         Reviewed by Laszlo Gombos.
3315
3316         [Qt][WK2] Guard gcc-specific syntax
3317
3318         Non-gcc based compliers choke on the "-include"
3319         syntax for preinclude, place guard around it.
3320
3321         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3322         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3323
3324 2011-01-10  Andreas Kling  <kling@webkit.org>
3325
3326         Reviewed by Simon Hausmann.
3327
3328         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3329         https://bugs.webkit.org/show_bug.cgi?id=52111
3330
3331         When getting a createNewPage() callback from QWKPage, create the
3332         new page with the same QWKContext as the page that is passed to
3333         the callback.
3334
3335         * MiniBrowser/qt/BrowserView.h:
3336         * MiniBrowser/qt/BrowserWindow.cpp:
3337         (newPageFunction):
3338         (BrowserWindow::BrowserWindow):
3339         * MiniBrowser/qt/BrowserWindow.h:
3340
3341 2011-01-10  Andreas Kling  <kling@webkit.org>
3342
3343         Reviewed by Kenneth Rohde Christiansen.
3344
3345         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3346
3347         BrowserView set its own useless createNewPage() callback on QWKPage.
3348         This was immediately overridden by BrowserWindow anyway, so remove
3349         the BrowserView one.
3350
3351         * MiniBrowser/qt/BrowserView.cpp:
3352         (BrowserView::BrowserView):
3353
3354 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3355
3356         Reviewed by Jeremy Orlow.
3357
3358         [Chromium] Remove non-client-based Geolocation code
3359         https://bugs.webkit.org/show_bug.cgi?id=50921
3360
3361         * DumpRenderTree/chromium/LayoutTestController.cpp:
3362         (LayoutTestController::setGeolocationPermission):
3363         (LayoutTestController::setMockGeolocationPosition):
3364         (LayoutTestController::setMockGeolocationError):
3365         * DumpRenderTree/chromium/WebViewHost.cpp:
3366         (WebViewHost::geolocationClientMock):
3367         (WebViewHost::reset):
3368         * DumpRenderTree/chromium/WebViewHost.h:
3369
3370 2011-01-10  Eric Seidel  <eric@webkit.org>
3371
3372         Reviewed by Adam Barth.
3373
3374         Commit bot tried to land r? cq+ patch
3375         https://bugs.webkit.org/show_bug.cgi?id=36638
3376
3377         It should now be possible to post a patch with r? and cq+ and the
3378         commit-queue will correctly wait for the r+ before attempting to land the patch.
3379         (This was a feature requested by several users.)
3380
3381         One caveat: We don't actually reject r-, cq+ patches from the queue
3382         (we just ignore them), but I think that's OK for now.
3383
3384         I also noticed that setting r- once a commit-queue node had grabbed
3385         a patch would not properly cancel the landing.  That's fixed and
3386         tested in this patch.
3387
3388         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3389         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3390         * Scripts/webkitpy/tool/bot/feeders.py:
3391         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3392
3393 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3394
3395         Reviewed by Kenneth Rohde Christiansen.
3396
3397         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3398         https://bugs.webkit.org/show_bug.cgi?id=51934
3399
3400         When accessing the network from the destructor of QWebPage, the network access manager
3401         was already deleted because the object WebPage was already destructed.
3402
3403         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3404         The object is now destructed in the destructor of QObject.
3405
3406         * QtTestBrowser/webpage.cpp:
3407         (WebPage::WebPage):
3408         (WebPage::setQnamThreaded):
3409         * QtTestBrowser/webpage.h:
3410         (QtNAMThread::QtNAMThread):
3411
3412 2011-01-08  Eric Seidel  <eric@webkit.org>
3413
3414         Reviewed by Ojan Vafai.
3415
3416         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3417         https://bugs.webkit.org/show_bug.cgi?id=52067
3418
3419         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3420         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3421
3422         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3423
3424 2011-01-08  Eric Seidel  <eric@webkit.org>
3425
3426         Reviewed by Mihai Parparita.
3427
3428         commit-queue hangs when the ChangeLog diff is bad
3429         https://bugs.webkit.org/show_bug.cgi?id=52072
3430
3431         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3432         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3433
3434 2011-01-08  Adam Barth  <abarth@webkit.org>
3435
3436         Teach svn-apply how to re-write WebCore to Source/WebCore.
3437
3438         * Scripts/VCSUtils.pm:
3439
3440 2011-01-07  Adam Barth  <abarth@webkit.org>
3441
3442         Rubber-stamped by Eric Seidel.
3443
3444         Move WebCore to Source
3445         https://bugs.webkit.org/show_bug.cgi?id=52050
3446
3447         Update the tools to understand WebCore's new location.
3448
3449         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3450         * DumpRenderTree/wscript:
3451         * GNUmakefile.am:
3452         * Scripts/build-webkit:
3453         * Scripts/do-file-rename:
3454         * Scripts/do-webcore-rename:
3455         * Scripts/generate-qt-inspector-resource:
3456         * Scripts/prepare-ChangeLog:
3457         * Scripts/run-bindings-tests:
3458         * Scripts/update-iexploder-cssproperties:
3459         * Scripts/update-sources-list.py:
3460         * Scripts/update-webkit-localizable-strings:
3461         * Scripts/webkitdirs.pm:
3462         * Scripts/webkitpy/common/config/build.py:
3463         * Scripts/webkitpy/common/config/build_unittest.py:
3464         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3465         * Scripts/webkitpy/style/checker.py:
3466         * Scripts/webkitpy/style/checker_unittest.py:
3467         * WebKitTestRunner/DerivedSources.pro:
3468         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3469         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3470         * wx/browser/wscript:
3471         * wx/build/settings.py:
3472
3473 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3474
3475         Reviewed by Sam Weinig.
3476
3477         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3478         https://bugs.webkit.org/show_bug.cgi?id=52086
3479
3480         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3481         (WTR::InjectedBundle::didReceiveMessage):
3482         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3483         (WTR::LayoutTestController::notifyDone):
3484         * WebKitTestRunner/TestController.cpp:
3485         (WTR::TestController::resetStateToConsistentValues):
3486         (WTR::TestController::run):
3487
3488 2011-01-07  James Robinson  <jamesr@chromium.org>
3489
3490         Revert "Implement mozilla's animationTime property"
3491         https://bugs.webkit.org/show_bug.cgi?id=51952
3492
3493         This approach isn't quite right.
3494
3495         * DumpRenderTree/chromium/WebViewHost.cpp:
3496         (WebViewHost::paintInvalidatedRegion):
3497
3498 2011-01-07  Adam Roben  <aroben@apple.com>
3499
3500         Build master fix
3501
3502         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3503         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3504
3505 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3506
3507         Reviewed by Csaba Osztrogonác.
3508
3509         run-qtwebkit-tests should be able to kill a testsuite.
3510
3511         Add new option in the script that can setup a timeout for a test.
3512         If the test execution takes more then specified time then the test
3513         would be terminated.
3514
3515         [Qt] run-qtwebkit-tests needs timeout
3516         https://bugs.webkit.org/show_bug.cgi?id=51894
3517
3518         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3519         * Scripts/run-qtwebkit-tests:
3520
3521 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3522
3523         Unreviewed fix after r75233.
3524
3525         Based on idea from Eric Seidel.
3526
3527         Add remote zip file handling to webkitpy.
3528         https://bugs.webkit.org/show_bug.cgi?id=50901
3529
3530         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3531
3532 2011-01-07  Shane Stephens  <shanestephens@google.com>
3533
3534         Reviewed by Eric Seidel.
3535
3536         svn-apply: should support git binary delta diffs
3537         https://bugs.webkit.org/show_bug.cgi?id=38864
3538
3539         * Scripts/VCSUtils.pm:
3540         * Scripts/svn-apply:
3541
3542 2011-01-06  Julie Parent  <jparent@chromium.org>
3543
3544         Reviewed by Eric Seidel.
3545
3546         Test Result Server not removing old results.
3547         https://bugs.webkit.org/show_bug.cgi?id=52012
3548
3549         * TestResultServer/model/jsonresults.py:
3550         Fix off-by-one: Truncate if >= num_runs, not just >.
3551         * TestResultServer/model/jsonresults_unittest.py:
3552         Add unit test to test that merging in a new result with the same value
3553         as the last result causes previous result to fall off.
3554
3555 2011-01-06  James Kozianski  <koz@chromium.org>
3556
3557         Reviewed by Mihai Parparita.
3558
3559         Add classes to provide a consistent interface to a set of files.
3560         https://bugs.webkit.org/show_bug.cgi?id=50901
3561
3562         These classes allow us to write code that is agnostic to whether a
3563         particular set of files resides in a local directory or in a zip file
3564         on a remote machine.
3565
3566         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3567         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3568         * Scripts/webkitpy/common/system/fileset.py: Added.
3569         * Scripts/webkitpy/common/system/filesystem.py:
3570         * Scripts/webkitpy/common/system/filesystem_mock.py:
3571         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3572         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3573
3574 2011-01-06  Eric Seidel  <eric@webkit.org>
3575
3576         Reviewed by Adam Barth.
3577
3578         NetworkTransaction should log the url it is retrying
3579         https://bugs.webkit.org/show_bug.cgi?id=52043
3580
3581         * Scripts/webkitpy/common/net/networktransaction.py:
3582         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3583
3584 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3585
3586         Windows build fix.
3587         Import os before using it.
3588
3589         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3590
3591 2011-01-06  Eric Seidel  <eric@webkit.org>
3592
3593         Reviewed by Adam Barth.
3594
3595         StyleQueue fails to report errors when patches have many files
3596         https://bugs.webkit.org/show_bug.cgi?id=52042
3597
3598         This is one of at least two errors preventing style error reporting at the moment.
3599         When we moved to passing the list of files to check explicitly,
3600         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3601         We could change the type of the QueueStatus.message type, or we could
3602         just teach statusserver.py how to clamp values (and warn when it does).
3603         I chose the latter path.
3604
3605         * Scripts/webkitpy/common/net/statusserver.py:
3606
3607 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3608
3609         Reviewed by Stephanie Lewis.
3610         
3611         Fix syntax error in script.
3612
3613         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3614         https://bugs.webkit.org/show_bug.cgi?id=51996
3615
3616         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3617
3618 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3619
3620         Unreviewed, fixing WinCE build after r75196.
3621
3622         WinCE port does not (yet) support NPAPI.
3623
3624         * Scripts/build-webkit:
3625
3626 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3627
3628         Reviewed by Darin Adler.
3629
3630         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3631         https://bugs.webkit.org/show_bug.cgi?id=52015
3632
3633         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3634         after the platform has been detected, otherwise the script will
3635         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3636         detection.
3637
3638 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3639
3640         Reviewed by Eric Seidel.
3641
3642         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3643         https://bugs.webkit.org/show_bug.cgi?id=51346
3644
3645         * Scripts/build-webkit:
3646
3647 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3648
3649         Reviewed by Adam Roben.
3650
3651         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3652         https://bugs.webkit.org/show_bug.cgi?id=51996
3653         
3654         After the configuration directory change, we were archiving the incorrect directory for
3655         build product, so we were running tests on the wrong binaries.
3656         
3657         This change archives the correct directory, and also unarchives it into a configuration-
3658         specific directory.
3659
3660         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3661         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3662
3663 2011-01-06  Eric Seidel  <eric@webkit.org>
3664
3665         Reviewed by Mihai Parparita.
3666
3667         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3668         https://bugs.webkit.org/show_bug.cgi?id=52002
3669
3670         See an example of this here:
3671         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3672
3673         It's due to the fact that we pass around TestFailure() instance
3674         objects and yet expect them to all compare to be the same.
3675
3676         This is bad.  We should either have shared instances of these values
3677         or we should just pass around the class names.  There are already hacks
3678         in place to make TestFailure objects pass equality tests, I just added
3679         a __hash__ implementation so they can be used in sets as expected.
3680
3681         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3682         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3683
3684 2011-01-06  Evan Martin  <evan@chromium.org>
3685
3686         Reviewed by Tony Chang.
3687
3688         [gdb] handle inaccessible memory and UChar*
3689         https://bugs.webkit.org/show_bug.cgi?id=52003
3690
3691         To pretty-print a UChar*, we just grope around in the memory
3692         looking for a terminating NUL.  We need to handle the exception
3693         that can occur when we poke into an invalid location.
3694
3695         Additionally, the logic for choosing which pretty-printer would
3696         early return before hitting the point where we'd use the UChar*
3697         printer.  (Did this ever work?  How did it regress?)
3698
3699         * gdb/webkit.py:
3700
3701 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3702
3703         Reviewed by Ada Chan.
3704
3705         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3706         https://bugs.webkit.org/show_bug.cgi?id=51969
3707         
3708         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3709
3710         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3711         (WTR::InjectedBundlePage::InjectedBundlePage):
3712         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3713         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3714
3715 2011-01-06  James Robinson  <jamesr@chromium.org>
3716
3717         Reviewed by Simon Fraser.
3718
3719         Implement mozilla's animationTime property
3720         https://bugs.webkit.org/show_bug.cgi?id=51952
3721
3722         Chromium DRT support for webkitAnimationTime.
3723
3724         * DumpRenderTree/chromium/WebViewHost.cpp:
3725         (WebViewHost::paintInvalidatedRegion):
3726
3727 2011-01-06  Julie Parent  <jparent@chromium.org>
3728
3729         Reviewed by Tony Chang.
3730
3731         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3732         https://bugs.webkit.org/show_bug.cgi?id=51217
3733
3734         * TestResultServer/model/jsonresults.py:
3735         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3736         Adds missing documentation.
3737         * TestResultServer/model/jsonresults_unittest.py:
3738         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3739         Update test_merge to take a number of builds to truncate at.
3740
3741 2011-01-06  Adam Barth  <abarth@webkit.org>
3742
3743         Reviewed by Eric Seidel.
3744
3745         The EWS should log outside of the working directory
3746         https://bugs.webkit.org/show_bug.cgi?id=51986
3747
3748         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3749         script, which will actually clean the working copy back to a pristine
3750         state instead of leaving untracked directories and ignored files.
3751
3752         * Scripts/webkitpy/tool/commands/queues.py:
3753         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3754
3755 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3756
3757         Windows build fix.
3758         Back out attempted change to built-product-archive.
3759
3760         * BuildSlaveSupport/built-product-archive:
3761
3762 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3763
3764         Windows build fix.
3765         Include configuration name when unpacking a build archive.
3766
3767         Needed, since we split Windows build results into configuration-specific directories
3768         under WebKitOutputDir.
3769
3770         * BuildSlaveSupport/built-product-archive:
3771
3772 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3773
3774         Reviewed by Darin Adler.
3775
3776         Debug and Release builds on Windows clobber each other
3777         https://bugs.webkit.org/show_bug.cgi?id=49185
3778
3779         Changes the structure of WebKitBuild build products directory so we
3780         completely separate each build configuration into independent directories.
3781         
3782         Although we previously had per-configuration directories for obj, this change adds
3783         per-configuration directories for bin, lib, obj, and include. Each configuration's
3784         build products are stored within a directory inside of WebKitBuild.
3785         
3786         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3787         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3788
3789         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3790         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3791         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3792         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3793         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3794         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3795         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3796         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3797         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3798         * FindSafari/FindSafari.vcproj:
3799         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3800         * MiniBrowser/MiniBrowserPostBuild.cmd:
3801         * MiniBrowser/MiniBrowserPreBuild.cmd:
3802         * Scripts/webkitdirs.pm:
3803         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3804         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3805         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3806         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3807         * TestWebKitAPI/win/copy-resources.cmd:
3808         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3809         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3810         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3811         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3812         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3813         * WebKitTestRunner/win/InjectedBundle.vcproj:
3814         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3815         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3816         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3817         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3818         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3819         * WinLauncher/WinLauncherCommon.vsprops:
3820         * WinLauncher/WinLauncherPostBuild.cmd:
3821         * WinLauncher/WinLauncherPreBuild.cmd:
3822
3823 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3824
3825         Reviewed by Ariya Hidayat.
3826
3827         [Qt] TestNetscapePlugin doesn't link on OS X
3828         https://bugs.webkit.org/show_bug.cgi?id=51948
3829
3830         Only add a dependency on libX11 on X11 systems
3831
3832         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3833
3834 2011-01-05  Jeff Miller  <jeffm@apple.com>
3835
3836         Reviewed by Adam Roben.
3837
3838         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3839         https://bugs.webkit.org/show_bug.cgi?id=51970
3840
3841         * Scripts/webkitpy/style/checker.py:
3842         Add -readability/naming for WebKit2 C API directories.
3843
3844 2011-01-05  Eric Seidel  <eric@webkit.org>
3845
3846         Unreviewed, just fixing one more log error from my previous python patch.
3847
3848         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3849         https://bugs.webkit.org/show_bug.cgi?id=51802
3850
3851         webkit-patch failure-reason was logging about parsing errors
3852         due to my misunderstanding of how BeautifulSoup.findAll worked.
3853
3854         Fixed, and added a unit test.
3855
3856         * Scripts/webkitpy/common/net/layouttestresults.py:
3857         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3858
3859 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3860
3861         Reviewed by Kenneth Rohde Christiansen.
3862
3863         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3864         https://bugs.webkit.org/show_bug.cgi?id=51951
3865
3866         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3867         to create new window from WebKit.
3868
3869         * MiniBrowser/qt/BrowserWindow.cpp:
3870         (newPageFunction):
3871         (BrowserWindow::BrowserWindow):
3872         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3873         (BrowserWindow::newWindow):
3874         (BrowserWindow::updateUserAgentList):
3875         (BrowserWindow::showUserAgentDialog):
3876         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3877         define the type of the backing store used for new windows.
3878         * MiniBrowser/qt/main.cpp:
3879         (main):
3880
3881 2011-01-05  Eric Seidel  <eric@webkit.org>
3882
3883         Reviewed by Ojan Vafai.
3884
3885         commit-queue should report failure type when reporting flaky tests
3886         https://bugs.webkit.org/show_bug.cgi?id=51900
3887
3888         This patch was a ridiculous amount of plumbing.  In the end I like
3889         the NRWT-style TestResult class even less.  But now we're passing
3890         a list of TestResult objects from the queue to the FlakyTestReporter.
3891         Thus the FlakyTestReporter can more easily report what type of failure
3892         occurred.
3893
3894         In the process, I found that I was not alone in finding TestResult
3895         cumbersome to use.  A bunch of code was trying to create a TestResult
3896         object with default values.  However since the constructor didn't make
3897         this easy, some places were getting it wrong (including the TestResult unit test)!
3898         I've fixed the TestResult constructor to have default values for non-essential
3899         arguments.
3900
3901         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3902         * Scripts/webkitpy/common/net/layouttestresults.py:
3903         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3904         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3905         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3906         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3907         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3908         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3909         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3910         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3911         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3912         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3913         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3914         * Scripts/webkitpy/tool/commands/queues.py:
3915         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3916
3917 2011-01-05  Eric Seidel  <eric@webkit.org>
3918
3919         Unreviewed.
3920
3921         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3922         https://bugs.webkit.org/show_bug.cgi?id=51802
3923
3924         Add another unit test to cover a previously missing import.
3925
3926         * Scripts/webkitpy/common/net/layouttestresults.py:
3927         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3928
3929 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3930
3931         Reviewed by David Levin.
3932
3933         Add mihaip@chromium.org as a reviewer
3934         https://bugs.webkit.org/show_bug.cgi?id=51966
3935         
3936         Add myself as a reviewer.
3937
3938         * Scripts/webkitpy/common/config/committers.py:
3939
3940 2011-01-05  James Simonsen  <simonjam@chromium.org>
3941
3942         Unreviewed. Adding myself to the list of committers.
3943
3944         * Scripts/webkitpy/common/config/committers.py:
3945
3946 2011-01-05  Eric Seidel  <eric@webkit.org>
3947
3948         Unreviewed.
3949
3950         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3951         https://bugs.webkit.org/show_bug.cgi?id=51802
3952
3953         Fix two exceptions seen on the bots after my original commit.
3954
3955         * Scripts/webkitpy/common/net/layouttestresults.py:
3956         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3957
3958 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3959
3960         Reviewed by Andreas Kling.
3961
3962         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3963         https://bugs.webkit.org/show_bug.cgi?id=51750
3964
3965         * QtTestBrowser/main.cpp:
3966         (LauncherApplication::handleUserOptions):
3967          Local storage settings can be enable form command line arguments for
3968          QtTestBrowser.
3969
3970 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3971
3972         Reviewed by Martin Robinson.
3973
3974         GTK: AX: DRT needs to use correct root object method.
3975         https://bugs.webkit.org/show_bug.cgi?id=51911
3976
3977         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3978         (AccessibilityController::rootElement):
3979
3980 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3981
3982         Rubber-stamped by Csaba Osztrogonác.
3983
3984         Based on idea from Péter Gál.
3985
3986         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3987
3988 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3989
3990         Reviewed by Adam Barth.
3991
3992         sheriff-bot should be able to do multi-revision rollouts
3993         https://bugs.webkit.org/show_bug.cgi?id=51176
3994
3995         * Scripts/webkitpy/tool/bot/irc_command.py:
3996         * Scripts/webkitpy/tool/bot/sheriff.py:
3997         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3998
3999 2011-01-05  Eric Seidel  <eric@webkit.org>
4000
4001         Reviewed by Adam Barth.
4002
4003         queues.webkit.org should have per-bot status pages
4004         https://bugs.webkit.org/show_bug.cgi?id=51906
4005
4006         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
4007         statuses from a single queue.  Now that we have many bots servicing
4008         some queues (commit-queue, win-ews, etc.) its easy to have the messages
4009         you care about scroll off the end of the 15-message limit on the main page.
4010
4011         Eventually we should probably rename /queue-status to /queue or /queues,
4012         but that's fodder for another patch.
4013
4014         * QueueStatusServer/handlers/queuestatus.py:
4015         * QueueStatusServer/index.yaml:
4016         * QueueStatusServer/main.py:
4017         * QueueStatusServer/templates/includes/singlequeuestatus.html:
4018          - This probably should use a custom filter instead of hard-coding
4019            the URL scheme here, but I couldn't figure out how to easily
4020            create such a filter.  Most filters work with "strings" so we can't
4021            pass the status object.  We could add a method to the status
4022            object and call that, but that seemed a bit strange too.
4023         * QueueStatusServer/templates/queuestatus.html:
4024
4025 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4026
4027         Unreviewed. Adding myself to the list of committers.
4028
4029         * Scripts/webkitpy/common/config/committers.py:
4030
4031 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
4032
4033         Reviewed by David Levin.
4034
4035         check-webkit-style treated some macros with parentheses after #elif as function calls
4036         https://bugs.webkit.org/show_bug.cgi?id=51695
4037
4038         Ingore function call space checking in any preprocessor directives
4039         (things starting with #). Change search() to match() because 
4040         preprocessor directives are supposed to be in the beginning of lines.
4041
4042         * Scripts/webkitpy/style/checkers/cpp.py:
4043         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
4044
4045 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
4046
4047         Reviewed by Tony Chang.
4048
4049         Change the --multi-load test option to --stress-opt
4050         https://bugs.webkit.org/show_bug.cgi?id=50751
4051
4052         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4053         (runTest):
4054         (main):
4055         * DumpRenderTree/chromium/TestShell.cpp:
4056         (TestShell::TestShell):
4057         * DumpRenderTree/chromium/TestShell.h:
4058         (TestShell::stressOpt):
4059         (TestShell::setStressOpt):
4060         (TestShell::stressDeopt):
4061         (TestShell::setStressDeopt):
4062         (TestShell::javaScriptFlags):
4063         (TestShell::setJavaScriptFlags):
4064         * Scripts/webkitpy/layout_tests/port/chromium.py:
4065         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4066
4067 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
4068
4069         Reviewed by Sam Weinig.
4070
4071         WK2: Support Accessibility
4072         https://bugs.webkit.org/show_bug.cgi?id=51859
4073
4074         Use rootObject() method to get top of accessibility tree.
4075
4076         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4077         (AccessibilityController::focusedElement):
4078         (AccessibilityController::rootElement):
4079
4080 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
4081
4082         Reviewed by Darin Adler.
4083
4084         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
4085         https://bugs.webkit.org/show_bug.cgi?id=51846
4086
4087         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
4088         back to GRefPtr.
4089
4090 2011-01-04  Zhe Su  <suzhe@chromium.org>
4091
4092         Reviewed by Kenneth Russell.
4093
4094         Fix insertText, setMarkedText and unmarkText methods of
4095         TextInputController to call corresponding methods of WebKit::WebView
4096         rather than WebKit::WebFrame. This change matches the behavior of
4097         chromium browser.
4098         insertText corresponds to WebView::confirmComposition(text)
4099         setMarkedText corresponds to WebView::setComposition(...)
4100         unmarkText corresponds to WebView::confirmComposition()
4101         https://bugs.webkit.org/show_bug.cgi?id=51693
4102
4103         * DumpRenderTree/chromium/TextInputController.cpp:
4104         (TextInputController::insertText):
4105         (TextInputController::setMarkedText):
4106         (TextInputController::unmarkText):
4107
4108 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
4109
4110         Reviewed by Laszlo Gombos.
4111
4112         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
4113
4114         On Symbian productDir points to the source directory. Removing all the
4115         empty files from the productDir directory corrupts the svn repository.
4116
4117         * Scripts/build-webkit:
4118
4119 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
4120
4121         Reviewed by Adam Barth.
4122
4123         [Qt] Add SelectAll option to the context menu for the editor
4124         https://bugs.webkit.org/show_bug.cgi?id=50049
4125
4126         Set shortcut for the SelectAll action.
4127
4128         * QtTestBrowser/mainwindow.cpp:
4129         (MainWindow::buildUI):
4130
4131 2011-01-03  David Levin  <levin@chromium.org>
4132
4133         Reviewed by Eric Seidel.
4134
4135         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
4136         https://bugs.webkit.org/show_bug.cgi?id=51842
4137
4138         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
4139         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
4140
4141 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
4142
4143         Reviewed by David Kilzer.
4144
4145         [WINCE] Adds a build slave.
4146         https://bugs.webkit.org/show_bug.cgi?id=50523
4147
4148         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
4149         entry for a release build of the WinCE port.
4150         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
4151         flag to build the WinCE port.
4152
4153 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
4154
4155         Reviewed by David Kilzer.
4156
4157         Add WinCE support to build-webkit
4158         https://bugs.webkit.org/show_bug.cgi?id=51642
4159
4160         * Scripts/build-webkit:
4161         * Scripts/webkitdirs.pm:
4162
4163 2011-01-03  Eric Seidel  <eric@webkit.org>
4164
4165         Reviewed by Adam Barth.
4166
4167         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
4168         https://bugs.webkit.org/show_bug.cgi?id=51802
4169
4170         I'm not the biggest fan of the test_failures or test_results classes,
4171         but it's better to have one shared set of classes, than separate ones
4172         for new vs. old run-webkit-test result handling.
4173
4174         This moves the ORWT results class "LayoutTestResults" over to using
4175         TestResult and TestFailure classes, making it easy for us to
4176         make all our sheriff-bot and other webkitpy code NRWT ready.
4177
4178         This also makes it a trivial patch to generate results.json information
4179         from ORWT results.html files (for flaky test analysis, etc.) as well
4180         as making it a one-liner to report test failure types when the
4181         commit-queue sees flaky tests.
4182
4183         This patch tried not to add new functionality, but only to replace
4184         the guts of LayoutTestResults, while adding unit tests and hoping
4185         not to break anything.
4186
4187         I also moved callers which assumed User.prompt* were static/class methods
4188         to using them as instance methods (since we'll eventually want to make them such).
4189
4190         In the process of re-writing things, I broke the rebaseline command, so I wrote
4191         a unit test to catch my breakage were I do do so again in the future.
4192
4193         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4194         * Scripts/webkitpy/common/net/layouttestresults.py:
4195         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4196         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
4197         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
4198         * Scripts/webkitpy/tool/commands/queries.py:
4199         * Scripts/webkitpy/tool/commands/rebaseline.py:
4200         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4201         * Scripts/webkitpy/tool/mocktool.py:
4202
4203 2011-01-03  Adam Barth  <abarth@webkit.org>
4204
4205         Reviewed by Simon Fraser.
4206
4207         webkit-patch shouldn't waste time cleaning a working directory that's already clean
4208         https://bugs.webkit.org/show_bug.cgi?id=51840
4209
4210         * Scripts/webkitpy/common/checkout/scm.py:
4211
4212 2011-01-03  Adam Barth  <abarth@webkit.org>
4213
4214         Reviewed by Simon Fraser.
4215
4216         webkit-patch should only hide update output if --quiet
4217         https://bugs.webkit.org/show_bug.cgi?id=51838
4218
4219         As requested by smfr.
4220
4221         * Scripts/webkitpy/tool/steps/update.py:
4222
4223 2011-01-03  Adam Barth  <abarth@webkit.org>
4224
4225         Reviewed by David Levin.
4226
4227         commit-queue shouldn't reject patches twice if two bots process the same patch
4228         https://bugs.webkit.org/show_bug.cgi?id=51805
4229
4230         Before raising an error, we first check whether the patch is still in
4231         the commit-queue.  This check is still racy, of course, but the time
4232         window is much smaller.
4233
4234         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4235
4236 2011-01-03  Sam Weinig  <sam@webkit.org>
4237
4238         Reviewed by Anders Carlsson.
4239
4240         Make run-api-tests less chatty.
4241         https://bugs.webkit.org/show_bug.cgi?id=51831
4242
4243         - Make script quiet by default and add --verbose option (replacing --quiet).
4244         - When not verbose, pipe stdout and stderr to devnull.
4245
4246         * Scripts/run-api-tests:
4247
4248 2011-01-03  Pratik Solanki  <psolanki@apple.com>
4249
4250         Unreviewed. Adding myself to committers.py.
4251
4252         * Scripts/webkitpy/common/config/committers.py:
4253
4254 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
4255
4256         Reviewed by Xan Lopez.
4257
4258         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
4259         https://bugs.webkit.org/show_bug.cgi?id=51806
4260
4261         Originally, the $libraryName is 'JavaScriptCore'. When building release 
4262         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
4263         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
4264         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
4265         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
4266         so make it 'WebKitBuild/Release/.libs'
4267
4268         * Scripts/webkitdirs.pm: 
4269
4270 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
4271
4272         Reviewed by Adam Barth.
4273
4274         Make EFL a core builder
4275         https://bugs.webkit.org/show_bug.cgi?id=51804
4276
4277         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4278         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4279
4280 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4281
4282         [Qt] Unreviewed fix after r74855 and r74875.
4283
4284         * BuildSlaveSupport/built-product-archive:
4285          - Create directories explicitly.
4286          - Pass shell=True to subprocess.call().
4287
4288 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4289
4290         [Qt] Unreviewed fix after r74855.
4291
4292         Move JavaScriptCore to Source
4293         https://bugs.webkit.org/show_bug.cgi?id=51604
4294
4295         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
4296
4297 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4298
4299         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
4300
4301         Move JavaScriptCore to Source
4302         https://bugs.webkit.org/show_bug.cgi?id=51604
4303
4304         * Scripts/webkitdirs.pm:
4305
4306 2011-01-02  Robert Hogan  <robert@webkit.org>
4307
4308         Unreviewed, build fix.
4309
4310         [Qt] Fix DRT build after 74855
4311
4312         * DumpRenderTree/qt/DumpRenderTree.pro:
4313
4314 2011-01-01  Adam Barth  <abarth@webkit.org>
4315
4316         Remove the assumption from the Qt and Gtk builds that every project is
4317         in the root directory.
4318
4319         * Scripts/build-webkit:
4320
4321 2011-01-01  Adam Barth  <abarth@webkit.org>
4322
4323         Reviewed by Eric Seidel.
4324
4325         Teach svn-apply how to apply patches even though JavaScriptCore has moved
4326         https://bugs.webkit.org/show_bug.cgi?id=51796
4327
4328         After this change, svn-apply will magically apply patches to
4329         JavaScriptCore/foo to Source/JavaScriptCore/foo.
4330
4331         * Scripts/VCSUtils.pm:
4332
4333 2011-01-01  Adam Barth  <abarth@webkit.org>
4334
4335         Reviewed by Eric Seidel.
4336
4337         Move JavaScriptCore to Source
4338         https://bugs.webkit.org/show_bug.cgi?id=51604
4339
4340         Update references to JavaScriptCore to point to the new location.
4341
4342         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4343         * DumpRenderTree/qt/DumpRenderTree.pro:
4344         * DumpRenderTree/qt/ImageDiff.pro:
4345         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4346         * DumpRenderTree/wscript:
4347         * Scripts/build-jsc:
4348         * Scripts/build-webkit:
4349         * Scripts/do-file-rename:
4350         * Scripts/do-webcore-rename:
4351         * Scripts/run-javascriptcore-tests:
4352         * Scripts/update-javascriptcore-test-results:
4353         * Scripts/webkitdirs.pm:
4354         * Scripts/webkitpy/common/config/build_unittest.py:
4355         * Scripts/webkitpy/style/checker.py:
4356         * Scripts/webkitpy/style/checker_unittest.py:
4357         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4358         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4359         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4360         * wx/build/settings.py:
4361
4362 2011-01-01  Adam Barth  <abarth@webkit.org>
4363
4364         Reviewed by Eric Seidel.
4365
4366         Move Sources to Source
4367         https://bugs.webkit.org/show_bug.cgi?id=51794
4368
4369         Update scripts to point to the new location.
4370
4371         * Scripts/build-webkit:
4372         * Scripts/do-file-rename:
4373         * Scripts/do-webcore-rename:
4374         * Scripts/webkitpy/common/config/build.py:
4375         * Scripts/webkitpy/common/config/build_unittest.py:
4376
4377 2010-12-31  Kent Tamura  <tkent@chromium.org>
4378
4379         Reviewed by Eric Seidel.
4380
4381         [DRT/Chromium] Enable mock spell checker on non-OSX
4382         https://bugs.webkit.org/show_bug.cgi?id=51401
4383
4384         * DumpRenderTree/chromium/WebViewHost.cpp:
4385         (WebViewHost::spellCheck):
4386
4387 2010-12-31  Adam Barth  <abarth@webkit.org>
4388
4389         Reviewed by Ariya Hidayat.
4390
4391         Remove Tools/Scripts/wkstyle
4392         https://bugs.webkit.org/show_bug.cgi?id=51774
4393
4394         This script appears to not have been touched in a while and seems to
4395         have been replaced by check-webkit-style.
4396
4397         * Scripts/wkstyle: Removed.
4398
4399 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4400
4401         Unreviewed. Coding style fix.