1 2016-08-26 Jer Noble <jer.noble@apple.com>
3 Add a test harness for running UI tests on the iOS Simulator
4 https://bugs.webkit.org/show_bug.cgi?id=161265
6 Reviewed by Simon Fraser.
8 Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
9 can serve as a test harness for WebKit UI tests.
11 Also add a basic media playback test which verifies that a <video> element will begin playing in
12 fullscreen on an iPhone device, but will play inline on an iPad device.
14 * Makefile: Add MobileMiniBrowser as a Module for iOS builds.
15 * MobileMiniBrowser/Configurations/Base.xcconfig: Added.
16 * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
17 * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
18 * MobileMiniBrowser/Makefile: Added.
19 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
20 * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
21 * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
22 (-[AppDelegate application:didFinishLaunchingWithOptions:]):
23 (-[AppDelegate applicationWillResignActive:]):
24 (-[AppDelegate applicationDidEnterBackground:]):
25 (-[AppDelegate applicationWillEnterForeground:]):
26 (-[AppDelegate applicationDidBecomeActive:]):
27 (-[AppDelegate applicationWillTerminate:]):
28 * MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
29 * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
30 * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
31 * MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
32 * MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
33 * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
34 (-[TabViewController dealloc]):
35 (-[TabViewController viewDidLoad]):
36 (-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
37 (-[TabViewController tableView:cellForRowAtIndexPath:]):
38 (-[TabViewController tableView:numberOfRowsInSection:]):
39 (-[TabViewController numberOfSectionsInTableView:]):
40 (-[TabViewController tableView:canEditRowAtIndexPath:]):
41 (-[TabViewController tableView:canMoveRowAtIndexPath:]):
42 (-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
43 (-[TabViewController tableView:didSelectRowAtIndexPath:]):
44 * MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
45 * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
46 (-[WebViewController viewDidLoad]):
47 (-[WebViewController didReceiveMemoryWarning]):
48 (-[WebViewController reload:]):
49 (-[WebViewController goBack:]):
50 (-[WebViewController goForward:]):
51 (-[WebViewController urlFieldEditingBegan:]):
52 (-[WebViewController navigateTo:]):
53 (-[WebViewController showTabs:]):
54 (-[WebViewController selectWebViewAtIndex:]):
55 (-[WebViewController removeWebViewAtIndex:]):
56 (-[WebViewController addWebView]):
57 (-[WebViewController createWebView]):
58 (-[WebViewController removeWebView:]):
59 (-[WebViewController setCurrentWebView:]):
60 (-[WebViewController webView:didFailNavigation:withError:]):
61 (-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
62 * MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
64 * MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
65 * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
66 (-[MobileMiniBrowserUITests setUp]):
67 (-[MobileMiniBrowserUITests tearDown]):
68 (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
70 2016-08-26 Aakash Jain <aakash_jain@apple.com>
72 webkit-queues queue-status page should should list more recent statuses
73 https://bugs.webkit.org/show_bug.cgi?id=161220
75 Reviewed by Daniel Bates.
77 * QueueStatusServer/handlers/queuestatus.py:
78 (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
80 2016-08-26 Dan Bernstein <mitz@apple.com>
82 [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
83 https://bugs.webkit.org/show_bug.cgi?id=161258
85 Reviewed by Anders Carlsson.
87 * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
88 (TestWebKitAPI::TEST):
90 2016-08-26 Csaba Osztrogonác <ossy@webkit.org>
92 Fix the ENABLE(WEBASSEMBLY) build on Linux
93 https://bugs.webkit.org/show_bug.cgi?id=161197
99 2016-08-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
101 [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
102 https://bugs.webkit.org/show_bug.cgi?id=161149
104 Reviewed by Carlos Garcia Campos.
106 Add a new function for waiting for the accesibility bus. It sets
107 the test environment variables before starting the GLib mainloop.
108 And restores the previous environment after it has finished.
109 It also adds a timeout (5 seconds) to abort in case it has not
110 been able to detect the accesibility bus before the timeout expires.
112 * Scripts/run-gtk-tests:
114 (TestRunner._wait_for_accessibility_bus):
115 (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
116 (TestRunner._start_accessibility_daemons):
117 (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
119 2016-08-26 Per Arne Vollan <pvollan@apple.com>
122 https://bugs.webkit.org/show_bug.cgi?id=161236
124 Reviewed by Brent Fulgham.
126 The & operator in the Test struct has no body.
128 * TestWebKitAPI/Tests/WTF/Vector.cpp:
129 (TestWebKitAPI::TEST):
131 2016-08-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
133 [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
134 https://bugs.webkit.org/show_bug.cgi?id=160736
136 Reviewed by Carlos Garcia Campos.
138 This plugs run-gtk-tests into the webkitpy testing infrastructure.
139 As a benefit of this, run-gtk-tests now can be executed over any of
140 the existing supported gtk test display servers (xvfb, weston-over-xvfb,
141 or native xorg). A new command line switch --wayland is added for
144 * Scripts/run-gtk-tests:
145 (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
146 Add a --wayland command line switch.
147 (TestRunner._start_accessibility_daemons):
149 (TestRunner.__init__):
150 (TestRunner._run_xvfb): Deleted.
151 (TestRunner._create_driver):
152 (TestRunner._setup_testing_environment): Delete the environment variable definitions that
153 are now done by driver._setup_environ_for_test().
154 (TestRunner._tear_down_testing_environment):
155 * Scripts/webkitpy/port/driver.py:
156 (Driver.__init__): Define self._server_name in the constructor of the base class.
157 It is used by several functions, so it makes sense to store once the value here.
158 (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
159 (Driver._start): Get the environment from self._setup_environ_for_test()
160 * Scripts/webkitpy/port/driver_unittest.py:
162 (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
163 * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
165 (GtkPort._driver_class):
166 * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
167 (WestonDriver._setup_environ_for_test):
168 (WestonDriver._start):
169 * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
170 (XorgDriver._setup_environ_for_test):
172 * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
173 (XvfbDriver._setup_environ_for_test):
176 2016-08-26 Csaba Osztrogonác <ossy@webkit.org>
178 [EFL][GTK] REGRESSION(204877): Fix the clean build
179 https://bugs.webkit.org/show_bug.cgi?id=161240
181 Reviewed by Carlos Garcia Campos.
183 * WebKitTestRunner/PlatformEfl.cmake:
184 * WebKitTestRunner/PlatformGTK.cmake:
186 2016-08-26 Aakash Jain <aakash_jain@apple.com>
188 EWS should indicate which bot processed the patch
189 https://bugs.webkit.org/show_bug.cgi?id=161222
191 Reviewed by Daniel Bates.
193 * QueueStatusServer/handlers/statusbubble.py:
194 (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
195 after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
196 Also added "Started processing patch" message to progress_statuses.
197 I might consider displaying bot id in other statuses as well later on.
199 2016-08-26 Gyuyoung Kim <gyuyoung.kim@webkit.org>
201 [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
202 https://bugs.webkit.org/show_bug.cgi?id=161184
204 Reviewed by Carlos Garcia Campos.
206 * MiniBrowser/efl/main.c: Set www.ewebkit.org.
208 2016-08-25 Aakash Jain <aakash_jain@apple.com>
210 ews queues should update status server when they start processing patch
211 https://bugs.webkit.org/show_bug.cgi?id=161223
213 Reviewed by Daniel Bates.
215 * Scripts/webkitpy/tool/commands/queues.py:
216 (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
217 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
218 (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
219 * Scripts/webkitpy/tool/commands/queues_unittest.py:
220 (StyleQueueTest.test_style_queue_with_style_exception): Same.
221 (test_style_queue_with_watch_list_exception): Same.
222 (test_non_valid_patch): Same.
224 2016-08-25 Alex Christensen <achristensen@webkit.org>
228 * DumpRenderTree/PlatformMac.cmake:
230 2016-08-25 Alex Christensen <achristensen@webkit.org>
232 Fix URLParserTest with GuardMalloc
233 https://bugs.webkit.org/show_bug.cgi?id=161214
234 rdar://problem/28014390
236 Reviewed by Tim Horton.
238 The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
239 This just does the comparison of the CStrings instead to keep them in scope during the comparison.
241 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
243 (TestWebKitAPI::checkURL):
244 (TestWebKitAPI::checkURLDifferences):
245 (TestWebKitAPI::s): Deleted.
247 2016-08-25 Wenson Hsieh <wenson_hsieh@apple.com>
249 Dragging against the end of the inline media scrubber causes the media scrubber to hide
250 https://bugs.webkit.org/show_bug.cgi?id=161207
252 Reviewed by Eric Carlson.
254 Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
255 controls in this case, we should actually continue showing them. This is because seeking due to user gestures
256 similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
258 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
259 (TestWebKitAPI::TEST):
261 2016-08-25 Daniel Bates <dabates@apple.com>
265 * Scripts/webkitpy/common/config/watchlist:
267 2016-08-25 Daniel Bates <dabates@apple.com>
269 Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
270 (https://bugs.webkit.org/show_bug.cgi?id=148437)
272 Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
273 and is not installed on the GTK Linux bots.
275 * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
276 (writeFileWithContent): Added.
278 2016-08-25 Per Arne Vollan <pvollan@apple.com>
280 [Win] run-api-tests is failing.
281 https://bugs.webkit.org/show_bug.cgi?id=161140
283 Reviewed by Brent Fulgham.
285 Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
287 * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
288 (TestWebKitAPI::TEST):
290 2016-08-24 Per Arne Vollan <pvollan@apple.com>
292 [Win] run-api-tests is failing.
293 https://bugs.webkit.org/show_bug.cgi?id=161140
295 Reviewed by Brent Fulgham.
297 The number of times the move constructor is called is different on Windows in this test. This seems
298 to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
300 * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
301 (TestWebKitAPI::TEST):
303 2016-08-24 Simon Fraser <simon.fraser@apple.com>
307 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
308 (WTR::UIScriptController::zoomToScale):
310 2016-08-24 Simon Fraser <simon.fraser@apple.com>
312 [iOS DRT] Hook up uiController.zoomToScale() for DRT
313 https://bugs.webkit.org/show_bug.cgi?id=161173
315 Reviewed by Tim Horton.
317 Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
318 UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
320 UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
321 the WebThread!), but queue up the callback first.
323 * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
324 * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
325 (-[DumpRenderTreeWebScrollView initWithFrame:]):
326 (-[DumpRenderTreeWebScrollView dealloc]):
327 (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
328 (-[DumpRenderTreeWebScrollView completedZoomToScale]):
329 (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
330 (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
331 (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
332 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
333 (WTR::UIScriptController::zoomToScale):
334 * DumpRenderTree/mac/DumpRenderTree.mm:
335 (createWebViewAndOffscreenWindow):
336 * TestRunnerShared/UIScriptContext/UIScriptController.h:
337 (WTR::UIScriptController::context):
339 2016-08-24 Ryan Haddad <ryanhaddad@apple.com>
341 Attempt to fix Windows build after r204918.
343 Unreviewed build fix.
345 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
346 (ResourceLoadDelegate::willSendRequest):
348 2016-08-24 Simon Fraser <simon.fraser@apple.com>
350 [iOS DRT] Get basic viewport tests working in DRT
351 https://bugs.webkit.org/show_bug.cgi?id=161160
353 Reviewed by Tim Horton.
355 Hook up enough of UIScriptController in iOS DRT to be able to read viewport
356 scale, and get the contentVisibleRect.
358 Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
359 requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
361 One test has different results between DRT and WTR, but DRT behavior seems to differ
362 from UIWebView here, so just give it a WK1-specific result.
364 * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
365 * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
366 (-[DumpRenderTreeBrowserView documentVisibleRect]):
367 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
368 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
369 (WTR::UIScriptController::zoomScale):
370 (WTR::UIScriptController::minimumZoomScale):
371 (WTR::UIScriptController::maximumZoomScale):
372 (WTR::UIScriptController::contentVisibleRect):
373 * DumpRenderTree/mac/DumpRenderTree.mm:
374 (createWebViewAndOffscreenWindow):
375 * DumpRenderTree/mac/DumpRenderTreeMac.h:
377 2016-08-24 Simon Fraser <simon.fraser@apple.com>
379 Minor project rearrangement.
381 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
383 2016-08-24 Simon Fraser <simon.fraser@apple.com>
385 [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
386 https://bugs.webkit.org/show_bug.cgi?id=161124
388 Reviewed by Daniel Bates.
390 Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
391 and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
393 Remove some unnecessary zero initializations of static variables.
395 Change _setVisibleSize to use the window size, which should not be a behavior change
396 because this it just used for text autosizing, which is disabled by default,
397 and only the width is consulted.
399 * DumpRenderTree/mac/DumpRenderTree.mm:
400 (adjustWebDocumentForFlexibleViewport):
401 (adjustWebDocumentForStandardViewport):
402 (createWebViewAndOffscreenWindow):
404 2016-08-24 Jonathan Bedard <jbedard@apple.com>
406 WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
407 https://bugs.webkit.org/show_bug.cgi?id=42777
409 Reviewed by Darin Adler.
411 The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called. Removed function and test.
413 * DumpRenderTree/TestRunner.cpp:
414 (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
415 * DumpRenderTree/TestRunner.h:
416 (TestRunner::deferMainResourceDataLoad): Ditto.
417 (TestRunner::setDeferMainResourceDataLoad): Ditto.
418 * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
420 2016-08-23 Anders Carlsson <andersca@apple.com>
422 Add enum traits and use them in the IPC::Decoder
423 https://bugs.webkit.org/show_bug.cgi?id=161103
425 Reviewed by Sam Weinig.
429 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
430 * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
431 (TestWebKitAPI::TEST):
433 2016-08-24 Filip Pizlo <fpizlo@apple.com>
435 Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
437 * DumpRenderTree/TestRunner.cpp:
438 * DumpRenderTree/mac/DumpRenderTree.mm:
439 (DumpRenderTreeMain):
440 * Scripts/run-jsc-stress-tests:
441 * TestWebKitAPI/Tests/WTF/Vector.cpp:
442 (TestWebKitAPI::TEST):
444 2016-08-24 Simon Fraser <simon.fraser@apple.com>
446 Try to fix Production builds.
448 PRODUCTION_FRAMEWORKS_DIR was undefined here.
450 * DumpRenderTree/mac/Configurations/Base.xcconfig:
452 2016-08-24 Dan Bernstein <mitz@apple.com>
454 Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
455 https://bugs.webkit.org/show_bug.cgi?id=161152
457 Reviewed by Anders Carlsson.
459 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
460 * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
461 (TestWebKitAPI::didFinishLoadForFrame):
462 (TestWebKitAPI::TEST):
464 2016-08-24 Nan Wang <n_wang@apple.com>
466 AX: Add test for line text marker range on iOS
467 https://bugs.webkit.org/show_bug.cgi?id=161108
468 <rdar://problem/27976405>
470 Reviewed by Chris Fleizach.
472 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
473 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
474 (AccessibilityUIElement::textMarkerRangeForElement):
475 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
476 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
477 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
479 2016-08-24 Per Arne Vollan <pvollan@apple.com>
482 https://bugs.webkit.org/show_bug.cgi?id=161079
484 Reviewed by Brent Fulgham.
486 * MiniBrowser/win/WebDownloadDelegate.cpp:
487 * MiniBrowser/win/WinMain.cpp:
488 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
489 (TestWebKitAPI::TEST):
491 2016-08-23 Simon Fraser <simon.fraser@apple.com>
493 Fix Windows DRT build.
495 * DumpRenderTree/win/TestRunnerWin.cpp:
496 (TestRunner::mainFrameJSContext):
498 2016-08-23 Simon Fraser <simon.fraser@apple.com>
500 Try to fix Windows build.
502 Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
503 so that perl finds CodeGeneratorDumpRenderTree.pm.
505 * DumpRenderTree/CMakeLists.txt:
507 2016-08-23 Simon Fraser <simon.fraser@apple.com>
509 Hook up UIScriptController in DumpRenderTree
510 https://bugs.webkit.org/show_bug.cgi?id=161064
512 Reviewed by Sam Weinig.
514 Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
515 Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
516 in fast/harness which test this.
518 Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
520 Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
521 WK2-isms. Fix the makefiles to refer to the new location.
523 Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
524 by ID and firing them once they are complete.
526 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
527 * DumpRenderTree/CMakeLists.txt:
528 * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
529 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
530 * DumpRenderTree/TestRunner.cpp:
531 (runUIScriptCallback):
532 (TestRunner::staticFunctions):
533 (TestRunner::cacheTestRunnerCallback):
534 (TestRunner::callTestRunnerCallback):
535 (TestRunner::clearTestRunnerCallbacks):
536 (nextUIScriptCallbackID):
537 (TestRunner::runUIScript):
538 (TestRunner::callUIScriptCallback):
539 (TestRunner::uiScriptDidComplete):
540 (TestRunner::cleanup):
541 * DumpRenderTree/TestRunner.h:
542 * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
543 * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
544 * DumpRenderTree/mac/DumpRenderTree.mm:
546 * DumpRenderTree/mac/TestRunnerMac.mm:
547 (TestRunner::mainFrameJSContext):
548 * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
549 (WTR::UIScriptController::doAsyncTask):
550 * DumpRenderTree/win/DumpRenderTree.cpp:
551 * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
552 (WTR::JSWrappable::~JSWrappable):
553 (WTR::JSValueMakeStringOrNull):
554 * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
555 (WTR::JSWrapper::wrap):
556 (WTR::JSWrapper::unwrap):
558 (WTR::JSWrapper::initialize):
559 (WTR::JSWrapper::finalize):
560 * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
563 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
564 * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
565 * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
566 (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
567 * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
568 * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
569 * WebKitTestRunner/CMakeLists.txt:
570 * WebKitTestRunner/DerivedSources.make:
571 * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
572 (WTR::JSWrappable::~JSWrappable): Deleted.
573 (WTR::JSValueMakeStringOrNull): Deleted.
574 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
575 (WTR::JSWrapper::wrap): Deleted.
576 (WTR::JSWrapper::unwrap): Deleted.
577 (WTR::unwrapObject): Deleted.
578 (WTR::JSWrapper::initialize): Deleted.
579 (WTR::JSWrapper::finalize): Deleted.
580 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
581 (WTR::toJS): Deleted.
582 (WTR::setProperty): Deleted.
583 * WebKitTestRunner/TestInvocation.cpp:
584 (WTR::TestInvocation::runUISideScript):
585 (WTR::TestInvocation::uiScriptDidComplete):
586 * WebKitTestRunner/TestInvocation.h:
587 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
588 * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
589 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
590 * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
591 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
592 * WebKitTestRunner/config.h:
593 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
594 (WTR::UIScriptController::contentVisibleRect):
596 2016-08-23 Saam Barati <sbarati@apple.com>
598 JSC should have a "microbenchmarks" directory instead of "regress" directory
599 https://bugs.webkit.org/show_bug.cgi?id=161096
601 Rubber stamped by Mark Lam.
603 This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
604 directory and removes all the related html and txt files. I did this because
605 that directory was only there for microbenchmarks, and not for "regression"
606 tests. I also changed the various scripts to point to it.
608 * Scripts/run-javascriptcore-tests:
610 * Scripts/run-jsc-benchmarks:
612 2016-08-23 Alex Christensen <achristensen@webkit.org>
616 * TestWebKitAPI/CMakeLists.txt:
617 Include new directory.
619 2016-08-22 Filip Pizlo <fpizlo@apple.com>
621 Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
622 https://bugs.webkit.org/show_bug.cgi?id=160125
624 Reviewed by Geoffrey Garen.
626 * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
627 * Scripts/run-jsc-stress-tests: New test flag!
629 2016-08-23 Brady Eidson <beidson@apple.com>
631 WK2 Gamepad layout test support.
632 https://bugs.webkit.org/show_bug.cgi?id=134671
634 Reviewed by Alex Christensen.
636 Have the injected bundle expose the MockGamepadProvider to the UI process, which will then
637 feed back into the UIGamepadProvider.
639 Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
640 as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
642 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
644 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
645 (WTR::TestRunner::setMockGamepadDetails):
646 (WTR::TestRunner::setMockGamepadAxisValue):
647 (WTR::TestRunner::setMockGamepadButtonValue):
649 * WebKitTestRunner/PlatformWebView.h:
651 * WebKitTestRunner/TestController.cpp:
652 (WTR::TestController::initialize):
654 * WebKitTestRunner/TestInvocation.cpp:
655 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
656 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
658 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
660 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
661 (-[WebKitTestRunnerWindow initWithFrame:]):
662 (-[WebKitTestRunnerWindow dealloc]):
663 (WTR::PlatformWebView::keyWindow):
665 * WebKitTestRunner/ios/TestControllerIOS.mm:
666 (WTR::wtr_NSApplication_keyWindow):
667 (WTR::TestController::platformInitialize):
669 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
670 (+[WebKitTestRunnerWindow _WTR_keyWindow]):
671 (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
672 (-[WebKitTestRunnerWindow dealloc]):
673 (WTR::PlatformWebView::keyWindow):
675 * WebKitTestRunner/mac/TestControllerMac.mm:
676 (WTR::wtr_NSApplication_keyWindow):
677 (WTR::TestController::platformInitialize):
678 * WebKitTestRunner/mac/main.mm:
680 2016-08-23 Alexey Proskuryakov <ap@apple.com>
682 REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
683 https://bugs.webkit.org/show_bug.cgi?id=161047
684 rdar://problem/27434307
686 Reviewed by Lucas Forschler.
688 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
690 2016-08-23 Chris Dumez <cdumez@apple.com>
692 Unreviewed, rolling out r204243.
694 Caused some layout test failures
698 "Write API test to cover crash fix in r204135"
699 https://bugs.webkit.org/show_bug.cgi?id=160587
700 http://trac.webkit.org/changeset/204243
702 2016-08-23 Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au>
704 Order feature option list in FeatureList.pm
705 https://bugs.webkit.org/show_bug.cgi?id=161074
707 Reviewed by Michael Catanzaro.
709 Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
711 * Scripts/webkitperl/FeatureList.pm:
713 2016-08-22 Dewei Zhu <dewei_zhu@apple.com>
715 Stop python icon bouncing in the dock while running browser benchmarks.
716 https://bugs.webkit.org/show_bug.cgi?id=161066
718 Reviewed by Ryosuke Niwa.
720 Bouncing python icon may impact browser benchmark results.
721 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
722 (OSXBrowserDriver.prepare_env):
723 (OSXBrowserDriver.restore_env):
725 2016-08-22 Simon Fraser <simon.fraser@apple.com>
727 <select> menu on iPad causes shifting of hit-testing areas
728 https://bugs.webkit.org/show_bug.cgi?id=150079
730 Reviewed by Tim Horton.
732 -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
733 so when it changes we have to update visible rects. We were doing this on focus, but failing
736 Added the ability to test by:
737 1. Making it possible to initiate an animated scroll in the UI process
738 2. Adding callbacks for starting and ending interaction with a form control. Sadly
739 the "ending interaction" for <select> popovers on iPad isn't late enough, since we
740 have no way currently to know when the dimming view behind the popover animates out,
741 so for now the test keeps trying to tap a button.
743 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
744 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
745 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
746 (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
747 (WTR::UIScriptController::didStartFormControlInteractionCallback):
748 (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
749 (WTR::UIScriptController::didEndFormControlInteractionCallback):
750 (WTR::UIScriptController::scrollToOffset):
751 (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
752 (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
753 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
754 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
755 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
756 (-[TestRunnerWKWebView dealloc]):
757 (-[TestRunnerWKWebView didStartFormControlInteraction]):
758 (-[TestRunnerWKWebView didEndFormControlInteraction]):
759 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
760 (WTR::contentOffsetBoundedInValidRange):
761 (WTR::UIScriptController::scrollToOffset):
762 (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
763 (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
765 2016-08-22 Carlos Alberto Lopez Perez <clopez@igalia.com>
767 [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
768 https://bugs.webkit.org/show_bug.cgi?id=160927
770 Reviewed by Daniel Bates.
772 * Scripts/process-linux-coredump: Removed.
773 * Scripts/webkitpy/port/efl.py:
774 (EflPort._get_crash_log):
775 * Scripts/webkitpy/port/gtk.py:
776 (GtkPort._get_crash_log):
777 * Scripts/webkitpy/port/linux_get_crash_log.py:
778 (GDBCrashLogGenerator.__init__):
779 (GDBCrashLogGenerator.generate_crash_log):
780 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
781 (GDBCrashLogGeneratorTest.test_generate_crash_log):
783 2016-08-22 Jonathan Bedard <jbedard@apple.com>
785 check-webkit-style does not work with Lambda functions in C++
786 https://bugs.webkit.org/show_bug.cgi?id=160910
788 Reviewed by Darin Adler.
790 This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
792 * Scripts/webkitpy/style/checkers/cpp.py:
793 (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
794 (check_for_non_standard_constructs): Added lambda function check.
795 (check_spacing_for_function_call): Added lambda function check.
796 (check_braces): Added lambda function check.
797 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
798 (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
800 2016-08-21 Alex Christensen <achristensen@webkit.org>
802 URLParser should parse IPv4 addresses
803 https://bugs.webkit.org/show_bug.cgi?id=161023
805 Reviewed by Darin Adler.
807 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
808 (TestWebKitAPI::TEST_F):
809 (TestWebKitAPI::checkURLDifferences):
810 We are already getting differences between the old URL::parse and the new URLParser.
811 (TestWebKitAPI::shouldFail):
813 2016-08-21 Daniel Bates <dabates@apple.com>
815 prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
816 https://bugs.webkit.org/show_bug.cgi?id=148437
818 Reviewed by Dan Bernstein.
820 * Scripts/prepare-ChangeLog:
821 (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
822 This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
823 assumes that its line ranges were from a unified diff without any context lines.
824 (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
825 (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
826 * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
827 based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
828 * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
829 (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
830 to /dev/null for the duration of the function call.
832 2016-08-20 Gyuyoung Kim <gyuyoung.kim@navercorp.com>
834 [EFL] Remove unnecessary a patch to mute ecore warnings
835 https://bugs.webkit.org/show_bug.cgi?id=160997
837 Reviewed by Darin Adler.
839 There is no warning messages during the layout test and perf test
840 after bumping efl version from 1.17 to 1.18. Remove it.
842 * efl/patches/ecore_remove_warnings.patch: Removed.
844 2016-08-20 Simon Fraser <simon.fraser@apple.com>
846 REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
847 https://bugs.webkit.org/show_bug.cgi?id=160985
849 Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
850 device shutdown seems to happen as result of killing Simulator.apps, and we're racing
853 * Scripts/webkitpy/layout_tests/views/printing.py:
854 (Printer.print_config):
855 * Scripts/webkitpy/port/base.py:
856 (Port.driver_cmd_line_for_logging):
857 (Port.driver_cmd_line): Deleted.
858 * Scripts/webkitpy/port/driver.py:
859 (IOSSimulatorDriver.cmd_line):
860 * Scripts/webkitpy/port/ios.py:
861 (IOSSimulatorPort.__init__):
862 (IOSSimulatorPort.driver_cmd_line_for_logging):
863 (IOSSimulatorPort._create_simulators):
864 (IOSSimulatorPort.setup_test_run):
865 (IOSSimulatorPort._quit_ios_simulator):
866 (IOSSimulatorPort.clean_up_test_run):
867 (IOSSimulatorPort._create_device):
869 (IOSSimulatorPort._remove_device):
870 (IOSSimulatorPort._testing_device):
871 (IOSSimulatorPort.device_id_for_worker_number):
872 (IOSSimulatorPort._set_device_class): Deleted.
873 (IOSSimulatorPort.testing_device): Deleted.
874 * Scripts/webkitpy/port/port_testcase.py:
875 (PortTestCase.test_driver_cmd_line):
876 * Scripts/webkitpy/xcode/simulator.py:
882 (Simulator.create_device):
883 (Simulator.remove_device):
884 (Simulator.device_number):
885 (Simulator.device_state_description):
886 (Simulator.wait_until_device_is_in_state):
888 2016-08-19 Ryan Haddad <ryanhaddad@apple.com>
890 Unreviewed, rolling out r204659.
892 This change appears to have caused ios-simulator LayoutTests
893 to fail when shutting down the simulator
897 "REGRESSION (r204477): Running LayoutTests on ios-simulator
898 became ~15 minutes slower"
899 https://bugs.webkit.org/show_bug.cgi?id=160985
900 http://trac.webkit.org/changeset/204659
902 2016-08-19 Alexey Proskuryakov <ap@apple.com>
904 Build fix for non-USE_SIM_SERVICE_CONTEXT builds
905 * LayoutTestRelay/LayoutTestRelay/main.m: (main):
907 2016-08-18 Simon Fraser <simon.fraser@apple.com>
909 REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
910 https://bugs.webkit.org/show_bug.cgi?id=160985
912 Reviewed by Alexey Proskuryakov.
914 r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
915 a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
916 must not be @memoized, because their return value depends on the value of simulator_device_type().
918 Fix by adding some global state in simulator.py that tracks the created devices
919 in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
920 and delete them in clean_up_test_run().
922 Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
923 that killing the Simulator apps isn't enough.
925 Simulator tracks the devices in a global dictionary, since state needs to persist
926 across different instances of IOSSimulatorPort.
928 Annoyingly, the "Command line:" dumping tried to access a device before we'd done
929 any setup. Rather than implicitly creating a device here (which the old code did),
930 override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
931 and set flag to say that device_id_for_worker_number() doesn't need to return a real
934 * Scripts/webkitpy/layout_tests/views/printing.py:
936 (Printer.print_config):
937 * Scripts/webkitpy/port/base.py:
938 (Port.driver_cmd_line_for_logging):
939 (Port.driver_cmd_line): Deleted.
940 * Scripts/webkitpy/port/driver.py:
941 (IOSSimulatorDriver.cmd_line):
942 * Scripts/webkitpy/port/ios.py:
943 (IOSSimulatorPort.__init__):
944 (IOSSimulatorPort.driver_cmd_line_for_logging):
945 (IOSSimulatorPort._create_simulators):
946 (IOSSimulatorPort.setup_test_run):
947 (IOSSimulatorPort.clean_up_test_run):
948 (IOSSimulatorPort._create_device):
950 (IOSSimulatorPort._remove_device):
951 (IOSSimulatorPort._testing_device):
952 (IOSSimulatorPort.device_id_for_worker_number):
953 (IOSSimulatorPort._set_device_class): Deleted.
954 (IOSSimulatorPort.testing_device): Deleted.
955 * Scripts/webkitpy/port/port_testcase.py:
956 (PortTestCase.test_driver_cmd_line):
957 * Scripts/webkitpy/xcode/simulator.py:
961 (Simulator.create_device):
962 (Simulator.remove_device):
963 (Simulator.device_number):
964 (Simulator.device_state_description):
965 (Simulator.wait_until_device_is_in_state):
967 2016-08-19 Alexey Proskuryakov <ap@apple.com>
969 Adopt SimServiceContext in LayoutTestRelay
970 https://bugs.webkit.org/show_bug.cgi?id=161000
971 <rdar://problem/25765594>
973 Reviewed by Daniel Bates.
975 * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
976 * LayoutTestRelay/LayoutTestRelay/main.m:
978 2016-08-19 Lucas Forschler <lforschler@apple.com>
980 Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
982 Reviewed by Kocsen Chung.
984 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
987 2016-08-19 Alexey Proskuryakov <ap@apple.com>
989 Partial revert of r203811 - this key is not needed.
991 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
993 2016-08-19 Daniel Bates <dabates@apple.com>
995 Another attempt to fix the iOS 9.3 build
997 Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
999 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1000 * WebKitTestRunner/Configurations/Base.xcconfig:
1002 2016-08-19 Lucas Forschler <lforschler@apple.com>
1004 Remove Yosemite Leaks bot from config.json
1006 Reviewed by Alexey Proskuryakov.
1008 * BuildSlaveSupport/build.webkit.org-config/config.json:
1010 2016-08-18 Dan Bernstein <mitz@apple.com>
1012 [Cocoa] API::Number needs to be wrapped by an NSNumber
1013 https://bugs.webkit.org/show_bug.cgi?id=160977
1014 <rdar://problem/27877735>
1016 Reviewed by Anders Carlsson.
1018 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1019 * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
1020 (TestWebKitAPI::TEST):
1022 2016-08-17 Myles C. Maxfield <mmaxfield@apple.com>
1024 [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
1025 https://bugs.webkit.org/show_bug.cgi?id=160895
1027 Reviewed by Dean Jackson.
1029 Link to the existing CoreText framework.
1031 * DumpRenderTree/PlatformWin.cmake:
1032 * TestWebKitAPI/PlatformWin.cmake:
1034 2016-08-17 Brent Fulgham <bfulgham@apple.com>
1036 [Win] Remove old libraries from build inputs
1037 https://bugs.webkit.org/show_bug.cgi?id=160949
1039 Reviewed by Dean Jackson.
1041 Modify the download script to remove the old 'icuuc.lib' and
1042 'icuin.lib' files for Windows builds.
1044 * Scripts/update-webkit-auxiliary-libs:
1046 2016-08-17 Jonathan Bedard <jbedard@apple.com>
1048 Extra logging for crash reason
1049 https://bugs.webkit.org/show_bug.cgi?id=160943
1051 Reviewed by Alexey Proskuryakov.
1053 A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
1055 * Scripts/webkitpy/port/server_process.py:
1056 (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
1057 (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
1058 (ServerProcess.has_crashed): Ditto.
1060 2016-08-17 Dan Bernstein <mitz@apple.com>
1062 [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
1063 https://bugs.webkit.org/show_bug.cgi?id=160938
1064 <rdar://problem/27876652>
1066 Reviewed by Anders Carlsson.
1068 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1069 * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
1070 (TestWebKitAPI::TEST):
1072 2016-08-17 Chris Fleizach <cfleizach@apple.com>
1074 AX: Support abbreviations in iOS
1075 https://bugs.webkit.org/show_bug.cgi?id=160907
1077 Reviewed by Joanmarie Diggs.
1079 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1080 (AccessibilityUIElement::stringAttributeValue):
1081 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1082 (WTR::AccessibilityUIElement::stringAttributeValue):
1084 2016-08-17 Gyuyoung Kim <gyuyoung.kim@navercorp.com>
1086 [EFL] Bump efl version from 1.17 to 1.18
1087 https://bugs.webkit.org/show_bug.cgi?id=160899
1089 Reviewed by Antonio Gomes.
1091 To use efl-1.18, EFL port needs to update install dependencies as well.
1093 * efl/install-dependencies:
1094 * efl/jhbuild.modules:
1096 2016-08-17 Per Arne Vollan <pvollan@apple.com>
1098 [Win] Add tests for linked fonts.
1099 https://bugs.webkit.org/show_bug.cgi?id=160898
1101 Reviewed by Brent Fulgham.
1103 Add tests for https://trac.webkit.org/changeset/204502.
1105 * TestWebKitAPI/PlatformWin.cmake:
1106 * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
1107 (TestWebKitAPI::TEST):
1109 2016-08-16 Daniel Bates <dabates@apple.com>
1111 prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
1112 https://bugs.webkit.org/show_bug.cgi?id=160924
1114 Reviewed by Stephanie Lewis.
1116 Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
1117 and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
1118 We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
1119 test the generate function list machinery without requiring a SCM checkout by substituting a delegate
1120 object that mocks out the file system and SCM operations.
1122 * Scripts/VCSUtils.pm:
1123 (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
1124 * Scripts/prepare-ChangeLog:
1125 (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
1126 abstracting the logic to query the file system and SCM into functions on a delegate object that
1128 (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
1129 (diffHeaderFormat): Deleted.
1131 2016-08-16 Alex Christensen <achristensen@webkit.org>
1133 URLParser should parse URLs without credentials
1134 https://bugs.webkit.org/show_bug.cgi?id=160913
1136 Reviewed by Brady Eidson.
1138 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1140 (TestWebKitAPI::checkURL):
1141 (TestWebKitAPI::TEST_F):
1143 2016-08-16 Anders Carlsson <andersca@apple.com>
1146 https://bugs.webkit.org/show_bug.cgi?id=160908
1148 Reviewed by Geoffrey Garen.
1150 * TestWebKitAPI/CMakeLists.txt:
1151 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1152 * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
1153 (TestWebKitAPI::TEST):
1155 2016-08-16 Aakash Jain <aakash_jain@apple.com>
1157 EWS logs file are rotated too quickly
1158 https://bugs.webkit.org/show_bug.cgi?id=160724
1160 Reviewed by Daniel Bates.
1162 Currently we are rotating the log file after 10 iterations of queue. If the queue
1163 doesn't have any pending patches, these iterations result in very small amount of
1164 logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
1165 This results in a lot of log files in a day. This patch ensures that we rotate the
1166 log file when its file size is greater than or equal to 100 KB.
1168 * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
1170 2016-08-16 Daniel Bates <dabates@apple.com>
1172 WKSI static library should be named by major iOS revision, not individual updates
1173 https://bugs.webkit.org/show_bug.cgi?id=160727
1174 <rdar://problem/22274848>
1176 Reviewed by Alexey Proskuryakov.
1178 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1179 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1180 * Scripts/copy-webkitlibraries-to-product-directory:
1181 * WebKitTestRunner/Configurations/Base.xcconfig:
1182 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1184 2016-08-16 Simon Fraser <simon.fraser@apple.com>
1186 Make it possible to test iOS select elements, and add iPhone and iPad tests for them
1187 https://bugs.webkit.org/show_bug.cgi?id=160909
1189 Reviewed by Enrica Casucci.
1191 Add functions to UIScriptController to dismiss the form accessory view for iOS,
1192 and to programmatically pick a row from a <select> picker.
1194 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1195 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1196 (WTR::UIScriptController::dismissFormAccessoryView):
1197 (WTR::UIScriptController::selectFormAccessoryPickerRow):
1198 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1199 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1200 (WTR::UIScriptController::dismissFormAccessoryView):
1201 (WTR::UIScriptController::selectFormAccessoryPickerRow):
1203 2016-08-15 Simon Fraser <simon.fraser@apple.com>
1205 [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
1206 https://bugs.webkit.org/show_bug.cgi?id=160878
1208 Reviewed by Tim Horton.
1210 Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
1211 now that we have the ability to run tests in the iPad simulator.
1213 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1214 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1215 (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1216 (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1217 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1218 * WebKitTestRunner/ios/TestControllerIOS.mm:
1219 (WTR::TestController::platformResetStateToConsistentValues): Deleted.
1220 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1221 (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1222 (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1224 2016-08-15 Anders Carlsson <andersca@apple.com>
1226 Add an address-of operator to RetainPtr
1227 https://bugs.webkit.org/show_bug.cgi?id=160879
1229 Reviewed by Tim Horton.
1231 Test HashMap and HashSet with an object whose operator& is deleted.
1233 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1234 Sort the Xcode project.
1236 * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
1237 (DeletedAddressOfOperator::DeletedAddressOfOperator):
1238 (DeletedAddressOfOperator::value):
1239 (DeletedAddressOfOperator::operator==):
1240 (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
1241 (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
1242 (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
1243 (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
1244 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1245 (TestWebKitAPI::TEST):
1246 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1247 (TestWebKitAPI::TEST):
1249 2016-08-16 Jonathan Bedard <jbedard@apple.com>
1251 False crashes in fast/text/emoji-gender-* tests
1252 https://bugs.webkit.org/show_bug.cgi?id=160779
1254 Reviewed by Alexey Proskuryakov.
1256 Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
1258 * Scripts/webkitpy/port/driver.py:
1259 (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
1260 * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
1261 * Scripts/webkitpy/port/server_process.py:
1262 (ServerProcess.write): Allow caller to disable crash flag on exception.
1264 2016-08-15 Simon Fraser <simon.fraser@apple.com>
1266 webkitpy error in TestRunResults.merge()
1267 https://bugs.webkit.org/show_bug.cgi?id=160882
1269 Reviewed by Daniel Bates.
1271 The argument to TestRunResults.merge() can be None if there are no device-specifc
1272 initial results or retry results in Manager.run(), so just return early in that case.
1274 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1275 (TestRunResults.merge):
1277 2016-08-15 Sam Weinig <sam@webkit.org>
1279 Speed up compile times by not including wtf/Variant.h so much
1280 https://bugs.webkit.org/show_bug.cgi?id=160847
1282 Reviewed by Alex Christensen and Saam Barati.
1284 * TestWebKitAPI/Tests/WTF/Variant.cpp:
1285 (TestWebKitAPI::TEST):
1286 Explicitly use std::experimental::variant.
1288 2016-08-15 Simon Fraser <simon.fraser@apple.com>
1290 Allow a port to run tests with a custom device setup
1291 https://bugs.webkit.org/show_bug.cgi?id=160833
1293 Reviewed by Daniel Bates.
1295 These changes allow the IOSSimulator port to run tests in iPad mode.
1297 This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
1298 in this case 'ipad'. When specified, any test in a directory with a suffix that matches
1299 a custom device will be collected into a set, and run in that device's environment after
1300 the other tests have run.
1302 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1303 (Manager._custom_device_for_test): If the test contains a directory matching a
1304 custom device suffix, return that custom device.
1305 (Manager._set_up_run): Push the custom device class, if any, into options so
1306 that the Worker can get to it.
1307 (Manager.run): Go through the list of tests, and break it down into device-generic
1308 tests, and tests for each device class. _run_test_subset is then called for
1309 each collection of tests, and the results merged.
1310 (Manager._run_test_subset): Some lines unwrapped.
1311 (Manager._end_test_run):
1312 (Manager._run_tests):
1313 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1314 (SingleTestRunner.__init__): Unwrapped a line.
1315 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1316 (TestRunResults.merge): Add this function to merge TestRunResults
1317 * Scripts/webkitpy/layout_tests/views/printing.py:
1318 (Printer.print_workers_and_shards): Print the custom device, if any.
1319 * Scripts/webkitpy/port/base.py:
1320 (Port): Base port has empty array of custom devices.
1321 (Port.setup_test_run): Add device_class argument.
1322 * Scripts/webkitpy/port/driver.py:
1323 (DriverInput.__repr__):
1324 (Driver.check_driver.implementation):
1325 * Scripts/webkitpy/port/efl.py:
1326 (EflPort.setup_test_run):
1327 * Scripts/webkitpy/port/gtk.py:
1328 (GtkPort.setup_test_run):
1329 * Scripts/webkitpy/port/ios.py:
1330 (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
1331 (IOSSimulatorPort.__init__):
1332 (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
1333 based on the custom device class.
1334 (IOSSimulatorPort._set_device_class):
1335 (IOSSimulatorPort._create_simulators): Factor some code into this function.
1336 (IOSSimulatorPort.setup_test_run):
1337 (IOSSimulatorPort.testing_device):
1338 (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
1339 seemed wrong for this function. That was moved to setup_test_run().
1340 (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
1341 but this happened too early, before we knew which kind of devices to create. Devices
1342 are now created in setup_test_run().
1343 * Scripts/webkitpy/port/win.py:
1344 (WinPort.setup_test_run):
1346 2016-08-15 Daniel Bates <dabates@apple.com>
1348 Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
1349 private frameworks and libraries
1350 https://bugs.webkit.org/show_bug.cgi?id=155931
1351 <rdar://problem/25807989>
1353 Reviewed by Dan Bernstein.
1355 Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
1356 where X is the major version of the active iOS SDK.
1358 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1359 * WebKitTestRunner/Configurations/Base.xcconfig:
1361 2016-08-15 Simon Fraser <simon.fraser@apple.com>
1363 Add a setting and preferences to enable visual viewport mode
1364 https://bugs.webkit.org/show_bug.cgi?id=160843
1366 Reviewed by Sam Weinig.
1368 Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
1370 * MiniBrowser/mac/SettingsController.h:
1371 * MiniBrowser/mac/SettingsController.m:
1372 (-[SettingsController _populateMenu]):
1373 (-[SettingsController validateMenuItem:]):
1374 (-[SettingsController visualViewportEnabled]):
1375 (-[SettingsController toggleVisualViewportEnabled:]):
1376 * MiniBrowser/mac/WK1BrowserWindowController.m:
1377 (-[WK1BrowserWindowController didChangeSettings]):
1378 * MiniBrowser/mac/WK2BrowserWindowController.m:
1379 (-[WK2BrowserWindowController didChangeSettings]):
1381 2016-08-15 Konstantin Tokarev <annulen@yandex.ru>
1383 Allow using make-dist with non-GTK ports
1384 https://bugs.webkit.org/show_bug.cgi?id=160842
1386 Reviewed by Michael Catanzaro.
1388 This patch adds support for setting base name of tarball and argument
1389 passed to cmake's -DPORT= via command line arguments.
1392 (Distcheck.configure):
1394 (get_tarball_root_and_output_filename_from_arguments):
1396 2016-08-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
1398 [GTK] Install script lacks gstreamer related dependencies
1399 https://bugs.webkit.org/show_bug.cgi?id=160814
1401 Reviewed by Carlos Garcia Campos.
1403 * gtk/install-dependencies: Fedora case had already listed this dependencies,
1404 but both Arch and Debian/Ubuntu were missing them.
1406 2016-08-13 Konstantin Tokarev <annulen@yandex.ru>
1408 make-dist.py should not allow unknown rules in manifest
1409 https://bugs.webkit.org/show_bug.cgi?id=160841
1411 Reviewed by Carlos Garcia Campos.
1414 (Manifest.process_line):
1416 2016-08-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
1418 [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
1419 https://bugs.webkit.org/show_bug.cgi?id=160809
1421 Reviewed by Carlos Garcia Campos.
1423 * efl/install-dependencies: Factorize the previous logic for handling the php5/7
1424 case, and use it also for the new package names of libpng and libgeoclue.
1425 * gtk/install-dependencies: Ditto.
1427 2016-08-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1429 Skip to check directories existence in build-webkit
1430 https://bugs.webkit.org/show_bug.cgi?id=160691
1432 Reviewed by Alex Christensen.
1434 CMake checks if directories are there itself. So CMake ports
1435 don't need to check it in the build-webkit script.
1437 * Scripts/build-webkit:
1438 * Scripts/webkitdirs.pm:
1439 (determineSourceDir):
1442 2016-08-12 Alex Christensen <achristensen@webkit.org>
1444 Make URLParser work with URLs missing URL parts
1445 https://bugs.webkit.org/show_bug.cgi?id=160824
1447 Reviewed by Brady Eidson.
1449 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1451 (TestWebKitAPI::checkURL):
1452 (TestWebKitAPI::TEST_F):
1453 (TestWebKitAPI::eq): Deleted.
1455 2016-08-12 John Wilander <wilander@apple.com>
1457 Add HashCountedSet API tests to TestWTFLibrary target
1458 https://bugs.webkit.org/show_bug.cgi?id=160815
1460 Reviewed by Alex Christensen.
1462 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1463 Added HashCountedSet.cpp and sorted the file reference section
1464 according to UNIX sort.
1466 2016-08-12 Ryosuke Niwa <rniwa@webkit.org>
1468 run-benchmark should run JetStream 1.1 instead of 1.0.1
1469 https://bugs.webkit.org/show_bug.cgi?id=160816
1471 Reviewed by Filip Pizlo.
1473 Use the latest JetStream 1.1 in run-benchmark.
1475 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1476 (BenchmarkBuilder.__exit__):
1477 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
1478 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
1479 change to JetStream directory.
1481 2016-08-12 Alex Christensen <achristensen@webkit.org>
1483 Initial URLParser implementation
1484 https://bugs.webkit.org/show_bug.cgi?id=160811
1486 Reviewed by Brady Eidson.
1488 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1489 (TestWebKitAPI::eq):
1490 (TestWebKitAPI::checkURL):
1491 (TestWebKitAPI::TEST_F):
1493 2016-08-12 Brady Eidson <beidson@apple.com>
1495 Fix the 32-bit Mac build after:
1496 Add WK2 ExperimentalFeature support to MiniBrowser
1497 https://bugs.webkit.org/show_bug.cgi?id=160788
1501 Sprinkle "#if WK_API_ENABLED"s liberally.
1503 * MiniBrowser/mac/AppDelegate.m:
1504 (defaultConfiguration):
1505 * MiniBrowser/mac/SettingsController.m:
1506 (-[SettingsController _populateMenu]):
1507 (-[SettingsController validateMenuItem:]):
1509 2016-08-12 Philippe Normand <pnormand@igalia.com>
1511 [GStreamer][OWR] Video rendering fixes
1512 https://bugs.webkit.org/show_bug.cgi?id=160764
1514 Reviewed by Xabier Rodriguez-Calvar.
1516 * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
1518 2016-08-12 Per Arne Vollan <pvollan@apple.com>
1520 Add missing return statement in convertFast function added in r204376.
1524 * Scripts/webkitpy/common/system/path.py:
1525 (_CygPath.convertFast):
1527 2016-08-11 Brady Eidson <beidson@apple.com>
1529 Add WK2 ExperimentalFeature support to MiniBrowser.
1530 https://bugs.webkit.org/show_bug.cgi?id=160788
1532 Reviewed by Alex Christensen.
1534 * MiniBrowser/mac/AppDelegate.h:
1535 * MiniBrowser/mac/AppDelegate.m:
1536 (defaultConfiguration):
1537 (defaultPreferences):
1539 * MiniBrowser/mac/SettingsController.m:
1540 (-[SettingsController _populateMenu]):
1541 (-[SettingsController validateMenuItem:]):
1542 (-[SettingsController toggleExperimentalFeature:]):
1544 2016-08-11 Aakash Jain <aakash_jain@apple.com>
1546 Keep EWS logs for longer
1547 https://bugs.webkit.org/show_bug.cgi?id=160776
1549 Reviewed by Daniel Bates.
1551 * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
1553 2016-08-11 Simon Fraser <simon.fraser@apple.com>
1555 iOS DRT/WTR project cleanup
1556 https://bugs.webkit.org/show_bug.cgi?id=160778
1558 Reviewed by Tim Horton.
1560 Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
1562 Remove AppDelegate.* which were unused.
1564 Exclude ios/Launch.storyboard on more platforms.
1566 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1567 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1568 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1569 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1570 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
1571 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
1572 (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
1574 2016-08-11 Alex Christensen <achristensen@webkit.org>
1576 Fix Yosemite bots' cookie accept policies after r204365.
1577 https://bugs.webkit.org/show_bug.cgi?id=160758
1579 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1581 This makes the test fully clean up after itself.
1583 2016-08-11 Alex Christensen <achristensen@webkit.org>
1585 Fix Yosemite bots' cookie accept policies after r204365.
1586 https://bugs.webkit.org/show_bug.cgi?id=160758
1588 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1590 I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
1591 On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
1592 On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
1593 causing any problems because there are no other API tests that do anything with cookies.
1594 My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
1595 but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
1596 to reset any bots that have run tests since r204365. I will commit a followup that sets it to originalCookieAcceptPolicy.
1598 2016-08-11 Aakash Jain <aakash_jain@apple.com>
1600 EWS should check if the patch is still valid before executing every major step
1601 https://bugs.webkit.org/show_bug.cgi?id=160739
1602 rdar://problem/27768813
1604 Reviewed by Alexey Proskuryakov.
1606 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1607 (CommitQueueTask.run): validate method is now executed in base class.
1608 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1609 (EarlyWarningSystemTask.run): validate method is now executed in base class.
1610 * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1611 (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
1612 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1613 (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
1614 that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
1615 * Scripts/webkitpy/tool/commands/perfalizer.py:
1616 (PerfalizerTask.validate): Added.
1617 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1618 (test_manual_reject_during_processing): Updated test case.
1620 2016-08-11 Alex Christensen <achristensen@webkit.org>
1623 https://bugs.webkit.org/show_bug.cgi?id=160770
1625 Reviewed by Sam Weinig.
1627 * TestWebKitAPI/PlatformGTK.cmake:
1628 * TestWebKitAPI/PlatformWin.cmake:
1629 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1630 * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
1631 (TestWebKitAPI::TEST_F):
1633 2016-08-10 Simon Fraser <simon.fraser@apple.com>
1635 [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
1636 https://bugs.webkit.org/show_bug.cgi?id=160761
1638 Reviewed by Tim Horton.
1640 Give iOS DRT a Launch storyboard.
1642 Have it use a UIViewController so future forms testing works correctly.
1644 Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
1645 can run in iPad mode.
1647 Remove empty InfoPlist.strings files.
1649 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1650 * DumpRenderTree/ios/Info.plist:
1651 * DumpRenderTree/ios/Launch.storyboard: Added.
1652 * DumpRenderTree/mac/DumpRenderTree.mm:
1653 (createWebViewAndOffscreenWindow):
1654 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1655 * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
1656 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1657 (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
1659 2016-08-11 Per Arne Vollan <pvollan@apple.com>
1661 [Win] Unable to reliably run tests in parallel
1662 https://bugs.webkit.org/show_bug.cgi?id=140914
1664 Reviewed by Brent Fulgham.
1666 The cygpath utility function can fail badly when running with multiple DumpRenderTree
1667 processes. We can use string replacement to convert the Cygwin path to a Windows path
1670 * Scripts/webkitpy/common/system/path.py:
1672 * Scripts/webkitpy/port/driver.py:
1673 (Driver._command_from_driver_input):
1675 2016-08-10 Alex Christensen <achristensen@webkit.org>
1677 Fix crash when changing cookie accept policy after r204327
1678 https://bugs.webkit.org/show_bug.cgi?id=160758
1680 Reviewed by Simon Fraser.
1682 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1683 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
1684 (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
1686 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
1688 2016-08-10 Simon Fraser <simon.fraser@apple.com>
1690 [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
1691 https://bugs.webkit.org/show_bug.cgi?id=160757
1693 Reviewed by Tim Horton.
1695 When programmatically creating the test UIWindow, make a root UIViewController and parent
1696 the WKWebView in its view. This makes the app more like a normal UIKit application.
1698 Move the WKWebView down 20px to avoid the status bar.
1700 Give the UIWindow a gray background so it's obvious where the window and view positioned.
1702 Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
1704 Remove duplicate references to Launch.storyboard.
1706 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1707 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
1708 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
1709 (-[AppDelegate applicationWillResignActive:]): Deleted.
1710 (-[AppDelegate applicationDidEnterBackground:]): Deleted.
1711 (-[AppDelegate applicationWillEnterForeground:]): Deleted.
1712 (-[AppDelegate applicationDidBecomeActive:]): Deleted.
1713 (-[AppDelegate applicationWillTerminate:]): Deleted.
1714 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1715 (WTR::viewRectForWindowRect):
1716 (WTR::PlatformWebView::PlatformWebView):
1717 (WTR::PlatformWebView::setWindowFrame):
1719 2016-08-10 Simon Fraser <simon.fraser@apple.com>
1721 [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
1722 https://bugs.webkit.org/show_bug.cgi?id=160748
1724 Reviewed by Tim Horton.
1726 Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1727 opens the door for tests using other device sizes.
1729 * WebKitTestRunner/ios/TestControllerIOS.mm:
1730 (WTR::TestController::platformConfigureViewForTest):
1732 2016-08-10 Simon Fraser <simon.fraser@apple.com>
1734 Sort the feature flags in the FEATURE_DEFINES lines
1735 https://bugs.webkit.org/show_bug.cgi?id=160742
1737 Reviewed by Anders Carlsson.
1739 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1741 2016-08-09 Simon Fraser <simon.fraser@apple.com>
1743 Logging and other minor improvements to iOS webkitpy
1744 https://bugs.webkit.org/show_bug.cgi?id=160722
1746 Reviewed by Dan Bates.
1748 Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1749 to make it easier to debug launching issues.
1751 Have reset_preferences() reset the device, rather than just nuking the data
1752 directory (which broke some versions of the simulator).
1754 Make the Simulator.app launch in the background with open -g.
1756 Wait for the simulator device to be in a known state in some more places.
1758 * Scripts/webkitpy/port/ios.py:
1759 (IOSSimulatorPort.setup_test_run):
1760 (IOSSimulatorPort._quit_ios_simulator):
1761 (IOSSimulatorPort.clean_up_test_run):
1762 (IOSSimulatorPort.setup_environ_for_server):
1763 (IOSSimulatorPort.reset_preferences):
1764 * Scripts/webkitpy/xcode/simulator.py:
1769 (Simulator.wait_until_device_is_booted):
1770 (Simulator.wait_until_device_is_in_state):
1772 (Simulator.delete_device):
1773 (Simulator.reset_device):
1774 (Simulator.lookup_or_create_device):
1776 2016-08-10 Carlos Alberto Lopez Perez <clopez@igalia.com>
1778 [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1779 https://bugs.webkit.org/show_bug.cgi?id=160697
1781 Reviewed by Antonio Gomes.
1783 * Scripts/webkitpy/port/base.py:
1784 (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1785 list of environment variables to copy.
1787 2016-08-09 George Ruan <gruan@apple.com>
1789 Implement functionality of media capture on iOS
1790 https://bugs.webkit.org/show_bug.cgi?id=158945
1791 <rdar://problem/26893343>
1793 Reviewed by Tim Horton.
1795 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1796 Capture feature on iOS.
1798 2016-08-09 Saam Barati <sbarati@apple.com>
1800 Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1801 https://bugs.webkit.org/show_bug.cgi?id=160671
1802 <rdar://problem/27756112>
1804 Reviewed by Mark Lam.
1806 * Scripts/run-jsc-stress-tests:
1808 2016-08-09 Alexey Proskuryakov <ap@apple.com>
1810 Make directory reading code in iOSSimulatorDevices() more strict
1811 https://bugs.webkit.org/show_bug.cgi?id=160702
1813 Reviewed by Tim Horton.
1815 * Scripts/webkitdirs.pm:
1816 (iOSSimulatorDevices):
1818 2016-08-06 Sam Weinig <sam@webkit.org>
1820 Replace NodeOrString with std::variant<RefPtr<Node>, String>
1821 https://bugs.webkit.org/show_bug.cgi?id=160638
1823 Reviewed by Anders Carlsson.
1825 * TestWebKitAPI/CMakeLists.txt:
1826 * TestWebKitAPI/Tests/WTF/Variant.cpp:
1827 Add additional tests for the initial state of std::variant and using
1828 makeVisitor for visiting.
1830 2016-08-09 Aakash Jain <aakash_jain@apple.com>
1832 EWS logging should ensure the logging to file is stopped on queue termination
1833 https://bugs.webkit.org/show_bug.cgi?id=160698
1834 rdar://problem/24464570
1836 Reviewed by Daniel Bates.
1838 * Scripts/webkitpy/tool/bot/queueengine.py:
1839 (QueueEngine._stopping): Stop logging to file on queue termination.
1840 (QueueEngine._begin_logging): Configure the Python logger to log to file.
1841 * Scripts/webkitpy/common/system/logutils.py:
1842 (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1843 * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1844 (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1845 * Scripts/webkitpy/tool/commands/queues.py:
1846 (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1847 (AbstractQueue.queue_log_path): Same.
1848 (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1849 (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1850 which moved to QueueEngine now.
1851 (PatchProcessingQueue.__init__): Same.
1852 (CommitQueue.__init__): Same.
1853 (AbstractReviewQueue.__init__): Same.
1854 (StyleQueue.__init__): Same.
1855 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1856 (TestCommitQueue): Removed host parameter.
1857 (TestCommitQueue.__init__): Same.
1858 (AbstractPatchQueueTest.test_next_patch): Same.
1859 (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1860 (test_commit_queue_failure): Same.
1861 (mock_run_webkit_patch):
1862 (MockCommitQueueTask.results_from_patch_test_run): Same.
1863 (test_rollout_lands): Same.
1864 (test_non_valid_patch): Same.
1865 (test_auto_retry): Same.
1866 (test_style_queue_with_watch_list_exception): Same.
1867 (TestQueue.__init__): Deleted.
1868 (TestReviewQueue.__init__): Deleted.
1869 (TestFeederQueue.__init__): Deleted.
1871 2016-08-09 Konstantin Tokarev <annulen@yandex.ru>
1873 webkit-gtk tarball fails to build due to missing files
1874 https://bugs.webkit.org/show_bug.cgi?id=160684
1876 Reviewed by Alex Christensen.
1878 * gtk/manifest.txt.in: Added back spi directories.
1880 2016-08-09 Carlos Alberto Lopez Perez <clopez@igalia.com>
1882 [GTK] Build the jhbuild with -O2 optimization level by default
1883 https://bugs.webkit.org/show_bug.cgi?id=160544
1885 Reviewed by Michael Catanzaro.
1887 * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1888 which don't increases the required disk space significatively and
1889 provides better debug information than no passing it.
1891 2016-08-09 Csaba Osztrogonác <ossy@webkit.org>
1893 Allow more --cmakeargs option in build-jsc and build-webkit
1894 https://bugs.webkit.org/show_bug.cgi?id=160340
1896 Reviewed by Michael Catanzaro.
1898 * Scripts/build-jsc:
1899 * Scripts/build-webkit:
1901 2016-08-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1903 Do not check if WebKitLibraries folder exists on EFL and GTK
1904 https://bugs.webkit.org/show_bug.cgi?id=160659
1906 Reviewed by Csaba Osztrogonác.
1908 Though WebKitLibraries is only needed by mac and win ports,
1909 EFL and GTK ports have checked whether it exists.
1911 * Scripts/build-webkit:
1913 2016-08-08 Aakash Jain <aakash_jain@apple.com>
1915 Some EWS console logs doesn't go to log file
1916 https://bugs.webkit.org/show_bug.cgi?id=160585
1917 rdar://problem/24464570
1919 Reviewed by Daniel Bates.
1921 * Scripts/webkitpy/common/system/logutils.py:
1922 (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1923 any possible overwriting.
1924 * Scripts/webkitpy/common/system/filesystem.py:
1925 (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1926 * Scripts/webkitpy/common/system/filesystem_mock.py:
1927 (MockFileSystem.open_text_file_for_writing): Same.
1928 * Scripts/webkitpy/common/system/filesystem_unittest.py:
1929 (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1930 (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1931 * Scripts/webkitpy/tool/commands/queues.py:
1932 (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1933 This will ensure that all the sub-modules inside webkitpy will log to file.
1935 2016-08-08 Simon Fraser <simon.fraser@apple.com>
1937 Have the iOS platform interit from the Apple platform in webkitpy
1938 https://bugs.webkit.org/show_bug.cgi?id=160672
1940 Reviewed by Dan Bates.
1942 The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1943 Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1946 Since WinPort also inherits from ApplePort, it needs to stub out some things
1947 that are unavailable on Windows (leaks, sampling).
1949 Some SnowLeopard-related code and the associated test were removed.
1951 * Scripts/webkitpy/port/apple.py:
1952 (ApplePort.__init__):
1954 (ApplePort._make_leak_detector):
1955 (ApplePort.default_timeout_ms):
1956 (ApplePort.supports_per_test_timeout):
1957 (ApplePort.should_retry_crashes):
1958 (ApplePort._generate_all_test_configurations):
1959 (ApplePort.check_for_leaks):
1960 (ApplePort.print_leaks_summary):
1961 (ApplePort._path_to_webcore_library):
1962 (ApplePort.show_results_html_file):
1963 (ApplePort._merge_crash_logs):
1964 (ApplePort._look_for_all_crash_logs_in_log_dir):
1965 (ApplePort._get_crash_log):
1966 (ApplePort.look_for_new_crash_logs):
1967 (ApplePort.sample_process):
1968 (ApplePort.sample_file_path):
1969 (ApplePort.look_for_new_samples):
1970 (ApplePort._path_to_helper):
1971 (ApplePort.determine_full_port_name): Deleted.
1972 * Scripts/webkitpy/port/ios.py:
1974 (IOSSimulatorPort.__init__):
1975 (IOSSimulatorPort.default_timeout_ms): Deleted.
1976 (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1977 (IOSSimulatorPort.should_retry_crashes): Deleted.
1978 (IOSSimulatorPort.check_for_leaks): Deleted.
1979 (IOSSimulatorPort.print_leaks_summary): Deleted.
1980 (IOSSimulatorPort._path_to_webcore_library): Deleted.
1981 (IOSSimulatorPort.show_results_html_file): Deleted.
1982 (IOSSimulatorPort.sample_file_path): Deleted.
1983 (IOSSimulatorPort._merge_crash_logs): Deleted.
1984 (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1985 (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1986 (IOSSimulatorPort.look_for_new_samples): Deleted.
1987 (IOSSimulatorPort.sample_process): Deleted.
1988 (IOSSimulatorPort._path_to_helper): Deleted.
1989 (IOSSimulatorPort.make_command): Deleted.
1990 * Scripts/webkitpy/port/mac.py:
1992 (MacPort.make_command):
1993 (MacPort._build_java_test_support):
1995 (MacPort.default_timeout_ms): Deleted.
1996 (MacPort.supports_per_test_timeout): Deleted.
1997 (MacPort.should_retry_crashes): Deleted.
1998 (MacPort.default_child_processes): Deleted.
1999 (MacPort.check_for_leaks): Deleted.
2000 (MacPort.print_leaks_summary): Deleted.
2001 (MacPort._path_to_webcore_library): Deleted.
2002 (MacPort.show_results_html_file): Deleted.
2003 (MacPort.sample_file_path): Deleted.
2004 (MacPort._merge_crash_logs): Deleted.
2005 (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
2006 (MacPort.look_for_new_crash_logs): Deleted.
2007 (MacPort.look_for_new_samples): Deleted.
2008 (MacPort.sample_process): Deleted.
2009 (MacPort._path_to_helper): Deleted.
2010 * Scripts/webkitpy/port/mac_unittest.py:
2011 (MacTest.test_default_child_processes): Deleted.
2012 * Scripts/webkitpy/port/win.py:
2013 (WinPort.look_for_new_samples):
2015 (WinPort.sample_process):
2016 (WinPort._make_leak_detector):
2017 (WinPort.check_for_leaks):
2018 (WinPort.print_leaks_summary):
2019 (WinPort._path_to_webcore_library):
2021 2016-08-08 Matt Baker <mattbaker@apple.com>
2023 Unreviewed: moved myself to the reviewers list.
2025 * Scripts/webkitpy/common/config/contributors.json:
2027 2016-08-08 Chris Dumez <cdumez@apple.com>
2029 Update API tests in mac/SetDocumentURI.mm after r204247
2030 https://bugs.webkit.org/show_bug.cgi?id=160660
2032 Reviewed by Alex Christensen.
2034 * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
2035 (TestWebKitAPI::TEST):
2037 2016-08-08 Jonathan Bedard <jbedard@apple.com>
2039 run-webkit-tests should trigger a spindump when WebContent process is unresponsive
2040 https://bugs.webkit.org/show_bug.cgi?id=159827
2042 Reviewed by Daniel Bates.
2044 This change was spurred by a process hang which occurred between tests and did
2045 not produce a meaningful crashlog.
2047 * Scripts/webkitpy/port/driver.py:
2048 (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
2050 * Scripts/webkitpy/port/ios.py:
2052 (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
2053 * Scripts/webkitpy/port/mac.py:
2055 (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
2057 * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
2058 * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
2060 * WebKitTestRunner/TestController.h:
2061 (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
2062 * WebKitTestRunner/TestInvocation.cpp:
2063 (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
2065 2016-08-07 Dan Bernstein <mitz@apple.com>
2067 [Cocoa] Reply block leaks if the remote object doesn’t call it
2068 https://bugs.webkit.org/show_bug.cgi?id=160642
2070 Reviewed by Sam Weinig.
2072 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
2073 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2074 (TEST): Added a test case that checks that the reply block is released even when it’s not
2076 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2077 (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
2078 calling the completion handler.
2080 2016-08-07 Chris Dumez <cdumez@apple.com>
2082 Write API test to cover crash fix in r204135
2083 https://bugs.webkit.org/show_bug.cgi?id=160587
2085 Reviewed by Darin Adler.
2087 Add API test to cover crash fix in r204135. This reproduces the crash
2088 by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2091 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2092 (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2095 2016-08-06 Chris Dumez <cdumez@apple.com>
2097 Unreviewed, rolling out r204226.
2099 Broke some API tests
2103 "Write API test to cover crash fix in r204135"
2104 https://bugs.webkit.org/show_bug.cgi?id=160587
2105 http://trac.webkit.org/changeset/204226
2107 2016-08-06 Aakash Jain <aakash_jain@apple.com>
2109 EWS Style Queue fails to process patches which fails validation
2110 https://bugs.webkit.org/show_bug.cgi?id=160632
2112 Reviewed by Alexey Proskuryakov.
2114 * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2115 (StyleQueueTask.validate): Add more information about validation failure.
2116 (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2117 * Scripts/webkitpy/tool/commands/queues_unittest.py:
2118 (test_non_valid_patch): Add a unit test to test the above code path.
2120 2016-08-06 Sam Weinig <sam@webkit.org>
2122 WTF needs a variant implementation
2123 https://bugs.webkit.org/show_bug.cgi?id=160618
2125 Reviewed by Darin Adler.
2127 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2128 * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
2129 Add tests for the variant implementation.
2131 2016-08-06 Chris Dumez <cdumez@apple.com>
2133 Write API test to cover crash fix in r204135
2134 https://bugs.webkit.org/show_bug.cgi?id=160587
2136 Reviewed by Darin Adler.
2138 Add API test to cover crash fix in r204135. This reproduces the crash
2139 by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2142 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2143 (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2146 2016-08-05 Tim Horton <timothy_horton@apple.com>
2148 run-api-tests should use a headed simulator
2149 https://bugs.webkit.org/show_bug.cgi?id=160611
2151 Reviewed by Sam Weinig.
2153 CADisplayLink doesn't work in a headless simulator, but is
2154 vital for the proper functioning of WebKit2 painting on iOS.
2155 So, we should not use a headless simulator.
2157 * Scripts/run-api-tests:
2158 Launch a simulator app, don't just boot the simulator.
2160 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2161 Re-enable a test that works now.
2163 2016-08-05 Dan Bernstein <mitz@apple.com>
2165 [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
2166 https://bugs.webkit.org/show_bug.cgi?id=160589
2168 Reviewed by Tim Horton.
2170 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
2171 (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
2172 blocks, which wasn’t caught because the test wasn’t run correctly.
2173 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2174 (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
2175 added a test that sends over an NSRange.
2176 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2177 (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
2178 handler with the range‘s location and length.
2180 2016-08-05 Enrica Casucci <enrica@apple.com>
2182 Fixing tests failing after r204175.
2186 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
2188 2016-08-05 Enrica Casucci <enrica@apple.com>
2190 Build fix after 204053.
2194 * TestWebKitAPI/Configurations/Base.xcconfig:
2195 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2196 (-[MockContentFilterEnabler initWithCoder:]):
2197 (-[MockContentFilterEnabler dealloc]):
2199 2016-08-05 Konstantin Tokarev <annulen@yandex.ru>
2201 Print test name in "Last character read from DRT..." error message.
2202 https://bugs.webkit.org/show_bug.cgi?id=160559
2204 Reviewed by Michael Catanzaro.
2206 * Scripts/webkitpy/port/driver.py:
2208 (Driver._read_first_block):
2209 (Driver._read_optional_image_block):
2210 (Driver._read_block):
2211 * Scripts/webkitpy/port/driver_unittest.py:
2212 (DriverTest.test_read_block):
2213 (DriverTest.test_read_binary_block):
2214 (DriverTest.test_read_base64_block):
2216 2016-08-05 Commit Queue <commit-queue@webkit.org>
2218 Unreviewed, rolling out r204123.
2219 https://bugs.webkit.org/show_bug.cgi?id=160597
2221 Caused layout test timeouts on Windows. (Requested by perarne
2226 "[Win] Unable to reliably run tests in parallel"
2227 https://bugs.webkit.org/show_bug.cgi?id=140914
2228 http://trac.webkit.org/changeset/204123
2230 2016-08-04 Saam Barati <sbarati@apple.com>
2232 Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
2233 https://bugs.webkit.org/show_bug.cgi?id=151241
2235 Reviewed by Benjamin Poulain.
2237 * Scripts/run-jsc-stress-tests:
2239 2016-08-04 Dean Johnson <dean_johnson@apple.com>
2241 UI improvements to Flakiness Dashboard.
2242 https://bugs.webkit.org/show_bug.cgi?id=153295
2244 Reviewed by Alexey Proskuryakov.
2246 * TestResultServer/static-dashboards/flakiness_dashboard.css:
2247 (td.options-container): Center text in most fields.
2248 * TestResultServer/static-dashboards/flakiness_dashboard.js:
2249 (createBugHTML): Text/Grammar updates.
2250 (tableHeaders): Ditto.
2251 (htmlForSingleTestRow): Ditto.
2252 (headerForTestTableHtml): Ditto.
2253 * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
2254 (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
2256 2016-08-04 Carlos Alberto Lopez Perez <clopez@igalia.com>
2258 [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
2259 https://bugs.webkit.org/show_bug.cgi?id=160518
2261 Reviewed by Michael Catanzaro.
2263 * Scripts/webkitpy/thirdparty/__init__.py:
2264 (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
2265 * gtk/install-dependencies:
2267 2016-08-04 Alexey Proskuryakov <ap@apple.com>
2269 Optimize bot watcher's dashboard a little
2270 https://bugs.webkit.org/show_bug.cgi?id=160515
2271 rdar://problem/26096900
2273 Reviewed by Lucas Forschler.
2275 Made re-sorting after loading an iteration more efficient.
2277 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2278 (BuildbotIteration.prototype._updateWithData):
2279 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2280 (BuildbotQueue.prototype.updateIterationPosition):
2282 2016-08-04 Per Arne Vollan <pvollan@apple.com>
2284 [Win] Unable to reliably run tests in parallel
2285 https://bugs.webkit.org/show_bug.cgi?id=140914
2287 Reviewed by Brent Fulgham.
2289 The cygpath utility function can fail badly when running with multiple DumpRenderTree
2290 processes. We can use string replacement to convert the Cygwin path to a Windows path
2293 * Scripts/webkitpy/common/system/path.py:
2295 * Scripts/webkitpy/port/driver.py:
2296 (Driver._command_from_driver_input):
2298 2016-08-03 Aakash Jain <aakash_jain@apple.com>
2300 Document instructions for increasing process and file limits
2301 https://bugs.webkit.org/show_bug.cgi?id=160528
2302 rdar://problem/24777576
2304 Reviewed by Alexey Proskuryakov.
2306 * Scripts/webkitpy/port/ios.py:
2307 (IOSSimulatorPort.default_child_processes):
2309 2016-08-03 Anders Carlsson <andersca@apple.com>
2311 Remove the Objective-C bindings generator
2312 https://bugs.webkit.org/show_bug.cgi?id=160526
2314 Reviewed by Sam Weinig.
2316 * Scripts/run-bindings-tests:
2319 2016-08-03 Tim Horton <timothy_horton@apple.com>
2321 Revise a TestWebKitAPI comment to mention the actual underlying problem
2323 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2324 Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
2326 2016-08-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
2328 Benchmark test content-animation timeouts always
2329 https://bugs.webkit.org/show_bug.cgi?id=160057
2331 Reviewed by Simon Fraser.
2333 * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
2334 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2337 2016-08-02 Nan Wang <n_wang@apple.com>
2339 AX: Simulated touch events are not working on iOS
2340 https://bugs.webkit.org/show_bug.cgi?id=160395
2341 <rdar://problem/27633597>
2343 Reviewed by Chris Fleizach.
2345 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2346 (WTR::AccessibilityUIElement::press):
2347 (WTR::AccessibilityUIElement::setSelectedChild):
2349 2016-08-02 Filip Pizlo <fpizlo@apple.com>
2351 run-javascriptcore-tests should accept multiple --extra-tests
2352 https://bugs.webkit.org/show_bug.cgi?id=160486
2354 Reviewed by Saam Barati.
2356 We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
2357 test suites. This does it by using GetOpt::Long's array support.
2359 * Scripts/run-javascriptcore-tests:
2360 (runJSCStressTests):
2362 2016-08-02 Enrica Casucci <enrica@apple.com>
2364 Allow building with content filtering disabled.
2365 https://bugs.webkit.org/show_bug.cgi?id=160454
2367 Reviewed by Simon Fraser.
2369 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2371 2016-08-02 Brady Eidson <beidson@apple.com>
2373 Removing IndexedDB WebsiteData can fail for some users.
2374 https://bugs.webkit.org/show_bug.cgi?id=160463
2376 Reviewed by Alex Christensen.
2378 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2380 2016-08-01 Alex Christensen <achristensen@webkit.org>
2382 _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
2383 https://bugs.webkit.org/show_bug.cgi?id=160437
2384 <rdar://problem/27578272>
2386 Reviewed by Brady Eidson.
2388 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2389 (-[DownloadDelegate _download:didReceiveResponse:]):
2390 (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2392 Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
2394 2016-08-01 Carlos Alberto Lopez Perez <clopez@igalia.com>
2396 [Tools] The GDB backtrace report tool don't checks the gdb return code.
2397 https://bugs.webkit.org/show_bug.cgi?id=160414
2399 Reviewed by Michael Catanzaro.
2401 * Scripts/webkitpy/port/linux_get_crash_log.py:
2402 (GDBCrashLogGenerator._wait_for_corefile):
2404 2016-08-01 Youenn Fablet <youenn@apple.com>
2406 Make wpt server generate its certificates in layout test results folder
2407 https://bugs.webkit.org/show_bug.cgi?id=160422
2409 Reviewed by Chris Dumez.
2411 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2412 (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
2414 2016-08-01 Jonathan Bedard <jbedard@apple.com>
2416 Function Call on NULL Object
2417 https://bugs.webkit.org/show_bug.cgi?id=160325
2419 Reviewed by Darin Adler.
2421 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2422 (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
2423 * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
2425 2016-08-01 Keith Miller <keith_miller@apple.com>
2427 We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
2428 https://bugs.webkit.org/show_bug.cgi?id=160372
2430 Rubber stamped by Geoffrey Garen.
2432 This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
2433 a new top level directory, JSTests. Having the tests in the Source directory
2434 was both confusing an inconvenient for people that just want to checkout the
2435 source code of WebKit. Since there is no other obvious place to put all the
2436 JavaScript tests a new top level directory seemed the most sensible.
2438 * Scripts/import-test262-tests:
2439 * Scripts/run-javascriptcore-tests:
2440 * Scripts/update-javascriptcore-test-res:
2442 2016-07-31 Nan Wang <n_wang@apple.com>
2444 AX: Add a check for touch event listener on iOS accessibility object
2445 https://bugs.webkit.org/show_bug.cgi?id=160388
2447 Reviewed by Chris Fleizach.
2449 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2450 (AccessibilityUIElement::boolAttributeValue):
2451 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2452 (WTR::AccessibilityUIElement::boolAttributeValue):
2454 2016-07-30 Manuel Rego Casasnovas <rego@igalia.com>
2456 Unreviewed: add myself to the reviewers list.
2458 * Scripts/webkitpy/common/config/contributors.json:
2460 2016-07-29 Alexey Proskuryakov <ap@apple.com>
2462 Undo r203939, and copy over a rule that clips the logos.
2464 Sierra wasn't the only logo without transparency.
2466 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2467 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2468 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2470 2016-07-29 Alan Sien Wei Hshieh <hshieh@apple.com>
2472 The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
2473 https://bugs.webkit.org/show_bug.cgi?id=160377
2475 Reviewed by Brian Weinstein.
2477 Update assets to remove the white background and use a transparent background instead.
2479 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2480 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2482 2016-07-29 David Kilzer <ddkilzer@apple.com>
2484 Ignore most check-webkit-style checks for ANGLE project
2485 <https://webkit.org/b/160333>
2487 Reviewed by Daniel Bates.
2489 * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
2491 - No spaces at the end of lines.
2492 - No carriage returns (DOS line endings).
2494 2016-07-29 Wenson Hsieh <wenson_hsieh@apple.com>
2496 Media controls are not displayed for some autoplaying videos at certain browser dimensions
2497 https://bugs.webkit.org/show_bug.cgi?id=160360
2498 <rdar://problem/27179484>
2500 Reviewed by Myles C. Maxfield.
2502 Adds two tests verifying that videos may be considered main content as long as they
2503 are large enough and cover a majority of the mainframe's viewport.
2505 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2506 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2507 (TestWebKitAPI::TEST):
2508 * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
2509 * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
2511 2016-07-29 Mark Lam <mark.lam@apple.com>
2513 Gardening: removed unused variable.
2517 * TestWebKitAPI/Tests/WTF/StringView.cpp:
2518 (TestWebKitAPI::TEST):
2520 2016-07-29 Wenson Hsieh <wenson_hsieh@apple.com>
2522 Add TestWebKitAPI support for interacting with media controls
2523 https://bugs.webkit.org/show_bug.cgi?id=160342
2524 <rdar://problem/27610246>
2526 Reviewed by Beth Dakin.
2528 Adds support for testing interaction with some media controls, as well as a basic test
2529 verifying that media control teardown after interaction does not result in a crash.
2531 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2532 (-[WKWebView mouseDownAtPoint:]):
2533 (-[WKWebView performAfterLoading:]):
2534 (TestWebKitAPI::TEST):
2536 2016-07-29 Jonathan Bedard <jbedard@apple.com>
2538 Crash Log Clobbering on Unbound Crashes
2539 https://bugs.webkit.org/show_bug.cgi?id=160198
2540 <rdar://problem/27472618>
2542 Reviewed by Alexey Proskuryakov.
2544 * Scripts/webkitpy/common/system/crashlogs.py:
2545 (CrashLogs): Fix header order.
2546 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2547 (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
2549 2016-07-29 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
2551 Update for contributors.json
2552 https://bugs.webkit.org/show_bug.cgi?id=160294
2554 * Scripts/webkitpy/common/config/contributors.json:
2556 2016-07-28 Myles C. Maxfield <mmaxfield@apple.com>
2558 Remove deprecated SPI for video inline / fullscreen controls
2559 https://bugs.webkit.org/show_bug.cgi?id=160318
2561 Reviewed by Tim Horton.
2563 * DumpRenderTree/mac/DumpRenderTree.mm:
2564 (setDefaultsToConsistentValuesForTesting): Deleted.
2565 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2566 (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2567 * WebKitTestRunner/TestController.cpp:
2568 (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2569 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2570 (WTR::initializeWebViewConfiguration): Deleted.
2572 2016-07-28 Daniel Bates <dabates@apple.com>
2574 [iOS] TestWebKitAPI bundle targets are not code signed
2575 https://bugs.webkit.org/show_bug.cgi?id=160328
2576 <rdar://problem/27409246>
2578 Reviewed by Andy Estes.
2580 Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
2581 CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
2582 the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
2584 * TestWebKitAPI/Configurations/Base.xcconfig:
2586 2016-07-28 Tim Horton <timothy_horton@apple.com>
2588 Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
2590 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2591 (animatedResizeWebView):
2593 This test times out only when run in the WebKit Testing simulator environment,
2594 but not in a fresh simulator. Disabling to keep the bots green while under investigation.
2596 2016-07-28 Tim Horton <timothy_horton@apple.com>
2598 Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
2599 https://bugs.webkit.org/show_bug.cgi?id=160289
2600 <rdar://problem/27553464>
2602 Reviewed by Simon Fraser.
2604 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2605 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2606 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
2607 (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
2608 (-[AnimatedResizeWebView _endAnimatedResize]):
2609 (animatedResizeWebView):
2611 * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
2612 Add two tests that ensure that hidden-content and animated resizes
2613 don't cause unnecessary synchronous waits. Only the hidden-content
2614 one fails before my patch, but it seemed reasonable to add both anyway.
2616 2016-07-28 David Kilzer <ddkilzer@apple.com>
2618 webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
2619 <https://webkit.org/b/83342>
2621 Reviewed by Ryosuke Niwa.
2623 * Scripts/webkitpy/common/checkout/scm/git.py:
2624 (Git.revisions_changing_file): Remove code to raise an exception
2625 when the file doesn't exist. If a file was moved or renamed,
2626 then this caused the script to terminate, which was very
2627 frustrating when you wanted a list of reviewers.
2628 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2629 (SCMTest._shared_test_revisions_changing_file): Update test
2630 expectation to return an empty list of revisions.
2631 (test_create_patch_is_full_patch): Drive-by fix when running all
2632 webkitpy tests (including scm tests).
2633 * Scripts/webkitpy/common/checkout/scm/svn.py:
2634 (SVN.revisions_changing_file): Catch ScriptError exceptions and
2635 return an empty array of revisions if this occurs.
2637 2016-07-28 Aakash Jain <aakash_jain@apple.com>
2639 EWS error message "Error: * did not process patch" should include explanation
2640 https://bugs.webkit.org/show_bug.cgi?id=159903
2641 <rdar://problem/27410788>
2643 Reviewed by Alexey Proskuryakov.
2645 * QueueStatusServer/handlers/statusbubble.py:
2646 (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
2648 * QueueStatusServer/handlers/processingtimesjson.py:
2649 (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
2651 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2652 (CommitQueueTask.validate): Add more information about validation failure.
2653 (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2654 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2655 (EarlyWarningSystemTask.validate): Add more information about validation failure.
2656 (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
2657 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2658 (PatchIsNotValid.__init__): Add the failure_message argument.
2659 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2660 (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
2662 * Scripts/webkitpy/tool/commands/queues.py:
2663 (CommitQueue.process_work_item): Same.
2664 (StyleQueue.review_patch): Same.
2665 * Scripts/webkitpy/tool/commands/queues_unittest.py:
2666 (test_non_valid_patch): Updated test-cases messages to match the above changes.
2668 2016-07-27 Alexey Proskuryakov <ap@apple.com>
2670 LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
2671 https://bugs.webkit.org/show_bug.cgi?id=160262
2673 Reviewed by Daniel Bates.
2675 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2676 (-[LTRelayController installApp]):
2678 2016-07-27 Ryan Haddad <ryanhaddad@apple.com>
2680 Disable WebCoreNSURLSessionTest API tests on ios-simulator
2681 https://bugs.webkit.org/show_bug.cgi?id=160225
2683 Reviewed by Alexey Proskuryakov.
2685 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2687 2016-07-27 Miguel Gomez <magomez@igalia.com>
2689 [GTK] Fix some video/canvas tests that should be passing
2690 https://bugs.webkit.org/show_bug.cgi?id=160023
2692 Reviewed by Carlos Garcia Campos.
2694 Add a platform identifier to the TestRunner's page user agent when the tests are run on the
2695 EFL or GTK platforms.
2697 * WebKitTestRunner/efl/TestControllerEfl.cpp:
2698 (WTR::TestController::platformConfigureViewForTest):
2699 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2700 (WTR::TestController::platformConfigureViewForTest):
2702 2016-07-27 Carlos Alberto Lopez Perez <clopez@igalia.com>
2704 [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
2705 https://bugs.webkit.org/show_bug.cgi?id=160247
2707 Reviewed by Michael Catanzaro.
2709 * BuildSlaveSupport/built-product-archive:
2712 (archiveBuiltProduct):
2714 2016-07-26 Alex Christensen <achristensen@webkit.org>
2716 Fix tests after r203743.
2717 https://bugs.webkit.org/show_bug.cgi?id=156947
2719 * WebKitTestRunner/TestController.cpp:
2720 (WTR::TestController::resetStateToConsistentValues):
2721 Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
2723 2016-07-26 Myles C. Maxfield <mmaxfield@apple.com>
2725 [iPhone] Playing a video on tudou.com plays only sound, no video
2726 https://bugs.webkit.org/show_bug.cgi?id=160178
2727 <rdar://problem/27535468>
2729 Reviewed by Dan Bernstein.
2731 * DumpRenderTree/mac/DumpRenderTree.mm:
2732 (setDefaultsToConsistentValuesForTesting):
2733 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2734 (RequiresUserActionForPlaybackTest::SetUp):
2735 * WebKitTestRunner/TestController.cpp:
2736 (WTR::TestController::resetPreferencesToConsistentValues):
2737 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2738 (WTR::initializeWebViewConfiguration):
2740 2016-07-26 Simon Fraser <simon.fraser@apple.com>
2742 Allow LOG macros to be used outside the namespace, and other logging cleanup
2743 https://bugs.webkit.org/show_bug.cgi?id=160216
2745 Reviewed by Anders Carlsson.
2747 initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2749 * DumpRenderTree/TestRunner.cpp:
2750 * DumpRenderTree/mac/DumpRenderTree.mm:
2751 (resetWebViewToConsistentStateBeforeTesting):
2753 2016-07-26 David Kilzer <ddkilzer@apple.com>
2755 Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2756 https://bugs.webkit.org/show_bug.cgi?id=156947
2757 <rdar://problem/23325160>
2759 Reviewed by Alex Christensen.
2761 * DumpRenderTree/TestRunner.cpp:
2762 (TestRunner::TestRunner):
2763 (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2764 * DumpRenderTree/TestRunner.h:
2765 (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2766 (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2767 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2768 (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2769 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2770 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2771 (WTR::TestRunner::queueNonLoadingScript):
2772 (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2773 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2774 * WebKitTestRunner/TestController.cpp:
2775 (WTR::TestController::didReceiveAuthenticationChallenge):
2776 * WebKitTestRunner/TestController.h:
2777 (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2778 * WebKitTestRunner/TestInvocation.cpp:
2779 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2780 Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2782 2016-07-26 David Kilzer <ddkilzer@apple.com>
2784 check-for-exit-time-destructors should be usable outside Xcode
2785 <https://webkit.org/b/160195>
2787 Reviewed by Darin Adler.
2789 * Scripts/check-for-exit-time-destructors: Update to parse
2790 -h|--help switch, or to take one argument to a binary to check
2791 for exit time destructors on the command-line. The clang
2792 compiler will find these at compile-time with the
2793 -Wexit-time-destructors switch, but this script will check for
2794 them after-the-fact.
2796 2016-07-26 Lucas Forschler <lforschler@apple.com>
2798 Test svn.webkit.org functionality after maintenance.
2800 2016-07-25 Brady Eidson <beidson@apple.com>
2802 Modern IDB: Make sure IndexedDB works from file:// url documents by default
2803 https://bugs.webkit.org/show_bug.cgi?id=153783
2805 Reviewed by Alex Christensen.
2807 Previously, to grant IndexedDB access to file:// urls for testing purposes,
2808 we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2810 As of https://trac.webkit.org/changeset/203695 this is no longer required.
2812 Change the relevant API tests to make sure this continues to be no longer required.
2814 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2815 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2816 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2817 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2818 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2819 * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2821 2016-07-25 Wenson Hsieh <wenson_hsieh@apple.com>
2823 Media controls should not be displayed for a video until it starts playing
2824 https://bugs.webkit.org/show_bug.cgi?id=160092
2825 <rdar://problem/26986673>
2827 Reviewed by Beth Dakin.
2829 Verify that multiple videos do or don't show the media controller depending on whether videos
2830 are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2831 passing because we were always showing media controls for large videos with audio, even if they
2832 had not played back yet. This change ensures that large videos with audio show media controls
2833 only after they begin to play back, and not by virtue of being large enough for main content.
2835 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2836 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2837 (TestWebKitAPI::TEST):
2838 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2839 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2840 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2842 2016-07-25 Wenson Hsieh <wenson_hsieh@apple.com>
2844 Media controls on apple.com don't disappear when movie finishes playing
2845 https://bugs.webkit.org/show_bug.cgi?id=160068
2846 <rdar://problem/26668526>
2848 Reviewed by Darin Adler.
2850 Adds new API tests. Please see WebCore ChangeLog for more details.
2852 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2853 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2854 (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2855 (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2856 (TestWebKitAPI::TEST):
2857 (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2858 (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2859 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2860 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2861 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2863 2016-07-25 Philippe Normand <pnormand@igalia.com>
2865 Unreviewed, fix test-webkitpy after r203674.
2867 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2868 (GDBCrashLogGeneratorTest.test_generate_crash_log):
2870 2016-07-24 Philippe Normand <pnormand@igalia.com>
2872 Unreviewed, forgot to commit this file in r203674.
2874 * Scripts/process-linux-coredump: Added.
2877 2016-07-25 Philippe Normand <pnormand@igalia.com>
2879 Improve GDB backtrace generation for GTK/EFL
2880 https://bugs.webkit.org/show_bug.cgi?id=128928
2882 Reviewed by Carlos Garcia Campos.
2884 The PID of the crashed process is now correctly supplied to the
2885 crash log reporter. The kernel core_pattern needs to be updated
2886 after this change to something like:
2888 echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2890 * Scripts/process-linux-coredump: Added.
2891 (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2892 * Scripts/webkitpy/port/efl.py:
2893 (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2894 * Scripts/webkitpy/port/gtk.py:
2895 (GtkPort._get_crash_log): Ditto.
2896 * Scripts/webkitpy/port/linux_get_crash_log.py:
2897 (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2898 (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2899 (GDBCrashLogGenerator): Deleted.
2900 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2901 (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2902 * WebKitTestRunner/TestController.cpp:
2903 (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2904 (WTR::TestController::databaseProcessDidCrash): Ditto.
2905 (WTR::TestController::processDidCrash): Ditto.
2907 2016-07-23 Youenn Fablet <youenn@apple.com>
2909 WPT stash server should be kept running when launching wpt server
2910 https://bugs.webkit.org/show_bug.cgi?id=160052
2912 Reviewed by Sam Weinig.
2914 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2915 (main): waiting to read stdin while stash server is started.
2917 2016-07-22 Wenson Hsieh <wenson_hsieh@apple.com>
2919 Media controls should be displayed for media in media documents
2920 https://bugs.webkit.org/show_bug.cgi?id=160104
2921 <rdar://problem/27438936>
2923 Reviewed by Myles C. Maxfield.
2925 Verifies that even a small video with audio in a media document gets media controls.
2927 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2928 (TestWebKitAPI::TEST):
2930 2016-07-22 Michael Saboff <msaboff@apple.com>
2932 REGRESSION(203616): no FTL testing was inadvertently removed
2933 https://bugs.webkit.org/show_bug.cgi?id=160100
2935 Rubber-stamped by Filip Pizlo.
2937 Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2938 Renamed runLayoutTestNoFTL to runLayoutTestDefault. Restructured the test
2939 logic for the runLayout and runNoisy variants to match the run test logic,
2940 that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2943 * Scripts/run-jsc-stress-tests:
2945 2016-07-22 Brady Eidson <beidson@apple.com>
2947 Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2948 https://bugs.webkit.org/show_bug.cgi?id=160089
2950 Reviewed by Darin Adler.
2952 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2953 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2954 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2956 2016-07-22 Konstantin Tokarev <annulen@yandex.ru>
2958 [GTK] Improved exclusion patterns in make-dist.py manifest.
2959 https://bugs.webkit.org/show_bug.cgi?id=160094
2961 Reviewed by Michael Catanzaro.
2963 * gtk/manifest.txt.in:
2964 Exclude Platform*.cmake files for more ports.
2965 Removed obsolete .gyp and .pro.user patterns.
2966 Exclude 'Configurations' and 'spi' directories.
2967 Exclude CMakeLists.txt.user (Qt Creator IDE).
2969 2016-07-22 Michael Saboff <msaboff@apple.com>
2971 Don't run FTL related JSC stress tests on non-FTL platforms
2972 https://bugs.webkit.org/show_bug.cgi?id=160033
2974 Reviewed by Mark Lam.
2976 Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2977 Refactored several of the runXXX test methods to always runXXXDefault and made those
2978 runXXXDefault to pass FTL_OPTIONS. For platforms that don't enable the FTL, FTL_OPTIONS
2979 doesn't cause a problem.
2981 * Scripts/run-jsc-stress-tests:
2983 2016-07-22 Per Arne Vollan <pvollan@apple.com>
2985 IWebView::mainFrame crashes if called after IWebView::close
2986 https://bugs.webkit.org/show_bug.cgi?id=32868
2988 Reviewed by Brent Fulgham.
2990 * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2991 (TestWebKitAPI::TEST_F): Added test.
2993 2016-07-22 Carlos Garcia Campos <cgarcia@igalia.com>
2995 [GTK] Enable threaded compositor by default
2996 https://bugs.webkit.org/show_bug.cgi?id=160079
2998 Reviewed by Žan Doberšek.
3000 * Scripts/webkitperl/FeatureList.pm:
3002 2016-07-22 Youenn Fablet <youenn@apple.com>
3004 run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
3005 https://bugs.webkit.org/show_bug.cgi?id=159921
3007 Reviewed by Brian Burg.
3009 Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
3011 * Scripts/webkitpy/codegen/main.py:
3012 (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
3013 (BuiltinsGeneratorTests):
3014 (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
3015 (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
3016 (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
3017 (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
3019 2016-07-21 Dan Bernstein <mitz@apple.com>
3021 [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
3022 https://bugs.webkit.org/show_bug.cgi?id=160072
3024 Reviewed by Andy Estes.
3026 * Scripts/webkitdirs.pm:
3027 (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
3028 for old Xcode versions.
3029 (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
3030 to readXcodeUserDefault.
3031 (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
3033 (determineDebugger): Ditto.
3034 (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
3036 (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
3038 (execMacWebKitAppForDebugging): Removed support for GDB.
3040 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
3042 Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
3043 https://bugs.webkit.org/show_bug.cgi?id=160066
3045 Reviewed by Dean Jackson.
3047 * DumpRenderTree/mac/DumpRenderTree.mm:
3048 (setDefaultsToConsistentValuesForTesting): Deleted.
3049 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3050 (RequiresUserActionForPlaybackTest::SetUp): Deleted.
3051 * WebKitTestRunner/TestController.cpp:
3052 (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
3053 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3054 (WTR::initializeWebViewConfiguration): Deleted.
3056 2016-07-21 Chelsea Pugh <cpugh@apple.com>
3058 [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
3059 https://bugs.webkit.org/show_bug.cgi?id=159980
3060 rdar://problem/27450825
3062 Reviewed by Dan Bernstein.
3064 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3065 * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
3066 (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
3067 when our delegate has hit -dealloc.
3068 (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
3069 and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
3070 will not be messaged.
3072 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
3074 Follow-up patch to r203520
3075 https://bugs.webkit.org/show_bug.cgi?id=159967
3076 <rdar://problem/26964090>
3080 * DumpRenderTree/mac/DumpRenderTree.mm:
3081 (setDefaultsToConsistentValuesForTesting):
3082 * WebKitTestRunner/TestController.cpp:
3083 (WTR::TestController::resetPreferencesToConsistentValues):
3085 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
3087 [iPhone] Playing a video on tudou.com plays only sound, no video
3088 https://bugs.webkit.org/show_bug.cgi?id=159967
3089 <rdar://problem/26964090>
3091 Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
3093 Migrate tests to use new SPI.
3095 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3096 (RequiresUserActionForPlaybackTest::SetUp):
3097 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3098 (WTR::initializeWebViewConfiguration):
3100 2016-07-21 Csaba Osztrogonác <ossy@webkit.org>
3102 Clarify testing mode names in run-jsc-stress-tests
3103 https://bugs.webkit.org/show_bug.cgi?id=160021
3105 Reviewed by Mark Lam.
3107 Default should mean really default, not default with disabled FTL, renamed
3108 - runMozillaTestDefault to runMozillaTestNoFTL
3109 - runMozillaTestDefaultFTL to runMozillaTestDefault
3110 - runDefault to runNoFTL
3111 - runDefaultFTL to runDefault
3112 - runLayoutTestDefault to runLayoutTestNoFTL
3113 - runLayoutTestDefaultFTL to runLayoutTestDefault
3114 - runNoisyTestDefault to runNoisyTestNoFTL
3115 - runNoisyTestDefaultFTL to runNoisyTestDefault
3117 * Scripts/run-jsc-stress-tests:
3119 2016-07-21 Yongjun Zhang <yongjun_zhang@apple.com>
3121 WebBackForwardList's currentIndex could get out of bounds when filtering items.
3122 https://bugs.webkit.org/show_bug.cgi?id=159986
3124 Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
3127 Reviewed by Dan Bernstein.
3129 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130 * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
3131 (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
3134 2016-07-21 Carlos Garcia Campos <cgarcia@igalia.com>
3136 [GTK] Web view background colors don't work in accelerated compositing mode
3137 https://bugs.webkit.org/show_bug.cgi?id=159455
3139 Reviewed by Michael Catanzaro.
3141 Set always RGBA visual to the view widget when setting a background color.
3143 * MiniBrowser/gtk/BrowserWindow.c:
3144 (browser_window_set_background_color):
3146 2016-07-20 Youenn Fablet <youenn@apple.com>
3148 Bots should run built-ins generator tests
3149 https://bugs.webkit.org/show_bug.cgi?id=159971
3151 Reviewed by Alexey Proskuryakov.
3153 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3154 (RunBuiltinsTests): New step to run built-in generator tests.
3155 (TestFactory.__init__): Adding an additional step for bultin generator tests.
3156 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
3157 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
3159 2016-07-20 Aakash Jain <aakash_jain@apple.com>
3161 Revert temporary fix r203417
3162 https://bugs.webkit.org/show_bug.cgi?id=160001
3164 Reviewed by Alexey Proskuryakov.
3166 * EWSTools/start-queue-mac.sh: Revert the temporary fix.
3168 2016-07-20 Aakash Jain <aakash_jain@apple.com>
3170 REGRESSION(r148588): ews classes might get garbage collected
3171 https://bugs.webkit.org/show_bug.cgi?id=159990
3173 Reviewed by Ryosuke Niwa.
3175 * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
3176 in a variable so that they do not get garbage collected.
3178 2016-07-20 Jeremy Jones <jeremyj@apple.com>
3180 Add API test for layout constraints after exit fullscreen
3181 https://bugs.webkit.org/show_bug.cgi?id=159900
3183 Reviewed by Jon Lee.
3185 Added Fullscreen.LaytoutConstraints API test.
3186 Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
3188 This test compares layout constraints on the web view before and after fullscreen to make sure
3191 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
3192 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
3193 (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3194 (TestWebKitAPI::TEST):
3196 2016-07-20 Ryan Haddad <ryanhaddad@apple.com>
3198 Disable two failing API tests.
3200 Unreviewed test gardening.
3202 * TestWebKitAPI/Tests/mac/CandidateTests.mm:
3203 (TestWebKitAPI::TEST):
3205 2016-07-20 Wenson Hsieh <wenson_hsieh@apple.com>
3207 Unreviewed iOS build fix.
3209 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
3211 2016-07-20 Wenson Hsieh <wenson_hsieh@apple.com>
3213 Media controls don't appear when pausing a small autoplaying video
3214 https://bugs.webkit.org/show_bug.cgi?id=159972
3215 <rdar://problem/27180657>
3217 Reviewed by Beth Dakin.
3219 Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
3220 for simulating basic user interaction in VideoControlsManager.
3222 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3223 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3224 (-[WKWebView mouseDownAtPoint:]):
3225 (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
3226 (-[OnLoadMessageHandler initWithWKWebView:handler:]):
3227 (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
3228 (TestWebKitAPI::TEST):
3229 * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
3231 2016-07-20 Per Arne Vollan <pvollan@apple.com>
3233 [Win] MathML fonts are not found.
3234 https://bugs.webkit.org/show_bug.cgi?id=159920
3236 Reviewed by Alex Christensen.
3238 When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
3239 for a specific registry key value.
3241 * Scripts/webkitdirs.pm:
3244 2016-07-20 Joseph Pecoraro <pecoraro@apple.com>
3246 Improve prepare-ChangeLog for @media blocks
3247 https://bugs.webkit.org/show_bug.cgi?id=159907
3249 Reviewed by Timothy Hatcher.
3251 * Scripts/prepare-ChangeLog:
3252 (get_selector_line_ranges_for_css):
3253 Get a range for @media blocks just like a selector.
3254 Start Line = line with '{'
3255 End line = line with '}'
3258 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
3259 Improved error messages for unbalanced portions.
3261 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
3262 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
3263 (.media-query::before):
3264 (@media only screen and (max-width: 980px)):
3266 (@media (-webkit-min-device-pixel-ratio: 2)):
3270 (.media-query::after):
3272 2016-07-20 Csaba Osztrogonác <ossy@webkit.org>
3274 Fix expectedFailErrorHandler in run-jsc-stress-tests
3275 https://bugs.webkit.org/show_bug.cgi?id=159811
3277 Reviewed by Yusuke Suzuki.
3279 * Scripts/run-jsc-stress-tests:
3281 2016-07-20 Csaba Osztrogonác <ossy@webkit.org>
3283 Unreviewed Mac cmake buildfix after r203426. Just for fun.
3285 * TestWebKitAPI/PlatformMac.cmake:
3287 2016-07-19 Filip Pizlo <fpizlo@apple.com>
3289 The default testing mode should not involve disabling the FTL JIT
3290 https://bugs.webkit.org/show_bug.cgi?id=159929
3292 Rubber stamped by Mark Lam and Saam Barati.
3294 It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
3295 Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
3296 FTL was not the default. You had to enable it with an option.
3298 For some reason we have kept this arrangement even though the FTL JIT is now the default on
3299 all of the major ports. This has become a serious pain. For example, it's useful to be able
3300 to say that a test should only run in the default config that is representative of what a
3301 normal user would see if they ran JSC. Clearly, this would be a config that does not
3302 explicitly disable the FTL JIT on the command line. However, if you try to specify this then
3303 your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
3305 So, this change gets rid of all of this logic. I think it's better to get rid of it then to
3306 try to fix it, because:
3308 - I don't know what the fix would look like. Presumably it would ensure that ports that don't
3309 have the FTL enabled never run any tests that explicitly disable the FTL, since that
3310 doesn't do anything. The code is not really structured to allow this.
3312 - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
3313 disabled in testing. On the other hand there are already build bots that do FTL tests
3314 despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
3315 preserving this broken feature, we should create something that (a) acknowledges the fact
3316 that the FTL is the default on those platforms that support it and (b) avoids running
3317 no-ftl tests on precisely those platforms that don't have FTL.
3319 - To the extent that some bots benefited from disabling FTL tests, they were doing it by
3320 relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
3321 default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
3322 pretending that the FTL JIT is not the default just because some bots used that as an
3325 This change allows me to speed up some debug tests and paint some bots green.
3327 * Scripts/run-javascriptcore-tests:
3328 (runJSCStressTests):
3329 * Scripts/run-jsc-stress-tests:
3331 2016-07-19 Alex Christensen <achristensen@webkit.org>
3333 Fix API test after r203426.
3334 https://bugs.webkit.org/show_bug.cgi?id=159949
3336 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3338 If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
3339 This is no problem. We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
3341 2016-07-19 Andy Estes <aestes@apple.com>
3343 Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
3344 https://bugs.webkit.org/show_bug.cgi?id=159956
3346 Reviewed by Dan Bernstein.
3348 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
3349 (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3350 Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
3351 * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
3353 2016-07-19 Alex Christensen <achristensen@webkit.org>
3355 Add regression test for r203392
3356 https://bugs.webkit.org/show_bug.cgi?id=159949
3358 Reviewed by Brady Eidson.
3360 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3362 (swizzledBundleIdentifierWebBookmarksD):
3363 (defaultApplicationCacheDirectory):
3365 (swizzledBundleIdentifierMobileSafari): Deleted.
3366 This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
3367 I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
3368 problems with the static bools that are set once in RuntimeApplicationChecks.mm.
3370 2016-07-19 Alex Christensen <achristensen@webkit.org>
3372 Add regression test for r203392
3373 https://bugs.webkit.org/show_bug.cgi?id=159949
3375 Reviewed by Brady Eidson.
3377 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3378 * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
3379 * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
3380 * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
3381 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3384 (swizzledBundleIdentifierMobileSafari):
3385 (swizzledBundleIdentifierWebBookmarksD):
3386 (defaultApplicationCacheDirectory):
3387 * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
3388 * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
3389 * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
3390 * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
3392 2016-07-19 Keith Miller <keith_miller@apple.com>
3394 Test262 should have a file with the revision and url
3395 https://bugs.webkit.org/show_bug.cgi?id=159937
3397 Reviewed by Mark Lam.
3399 The import script should update the information from
3400 the path to the test262 repository it gets.
3402 * Scripts/import-test262-tests:
3404 2016-07-19 Alexey Proskuryakov <ap@apple.com>
3406 Temporary workaround for iOS EWS failing after the fix for bug 159539.
3407 To be deleted once the root cause is found and addressed.
3409 * EWSTools/start-queue-mac.sh:
3411 2016-07-19 Frederic Wang <fwang@igalia.com>
3413 [win] Fixup the register name for STIX Math and Latin Modern Math
3415 Unreviewed follow-up of r203406
3417 * Scripts/webkitdirs.pm:
3418 (checkInstalledTools):
3420 2016-07-19 Frederic Wang <fwang@igalia.com>
3422 [win] Update the list of MathML fonts
3423 https://bugs.webkit.org/show_bug.cgi?id=156838
3425 The set of recommended math fonts is now described at
3426 https://trac.webkit.org/wiki/MathML/Fonts
3427 We update the Perl script to use the latest list of fonts.
3429 Reviewed by Brent Fulgham.
3431 * Scripts/webkitdirs.pm:
3432 (checkInstalledTools):
3434 2016-07-19 Per Arne Vollan <pvollan@apple.com>
3436 [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
3437 https://bugs.webkit.org/show_bug.cgi?id=159342
3439 Reviewed by Darin Adler.
3441 Implement required functions in event sender.
3443 * DumpRenderTree/PlatformWin.cmake:
3444 * DumpRenderTree/win/EventSender.cpp:
3445 (monitorWheelEvents): Added.
3446 (callAfterScrollingCompletes): Added.
3448 2016-07-19 Youenn Fablet <youenn@apple.com>
3450 Add new aliases to http test server
3451 https://bugs.webkit.org/show_bug.cgi?id=159878
3453 Reviewed by Darin Adler.
3455 Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
3456 Adding explicitly these links to perl script.
3457 Extracting default alias in an aliases.json file.
3458 Reading that file from python scripts to initialize aliases from that file.
3460 Python script changes covered by unit tests and changed layout test.
3462 * Scripts/webkitperl/httpd.pm:
3463 (getDefaultConfigForTestDirectory): Adding 3 new aliases
3464 * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
3465 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3466 (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3467 Adding -c directives for each alias.
3468 * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3469 (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
3470 * Scripts/webkitpy/layout_tests/servers/http_server.py:
3471 (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3472 Adding alias directive for each alias.
3473 (Lighttpd._prepare_config):
3474 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3475 (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
3476 (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
3477 layout tests directory.
3478 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3479 (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
3480 (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
3482 2016-07-18 Aakash Jain <aakash_jain@apple.com>
3484 EWS console logs doesn't go to log file
3485 https://bugs.webkit.org/show_bug.cgi?id=159539
3486 <rdar://problem/24464570>
3488 Reviewed by David Kilzer.
3490 * Scripts/webkitpy/common/system/logutils.py:
3491 (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
3492 (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
3493 to filesystem. It also supports passing MockFilesystem.
3494 (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
3495 (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
3496 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3497 (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
3499 * Scripts/webkitpy/tool/commands/queues.py:
3500 (AbstractQueue.begin_work_queue): Configure the logger to log to file.
3501 (AbstractQueue._log_directory): Using filesystem object instead of os.
3502 (AbstractQueue.queue_log_path): Same.
3503 (AbstractQueue.__init__): Passed host parameter.
3504 (PatchProcessingQueue.__init__): Same.
3505 (CommitQueue.__init__): Same.
3506 (AbstractReviewQueue.__init__): Same.
3507 (StyleQueue.__init__): Same.
3508 * Scripts/webkitpy/tool/commands/queues_unittest.py:
3509 (TestCommitQueue): Passed MockHost() as host.
3510 (TestCommitQueue.__init__): Same.
3511 (TestQueue.__init__): Same.
3512 (TestReviewQueue.__init__): Same.
3513 (TestFeederQueue.__init__): Same.
3514 (AbstractPatchQueueTest.test_next_patch): Same.
3515 (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3516 (test_commit_queue_failure): Same.
3517 (MockCommitQueueTask.results_from_patch_test_run): Same.
3518 (test_rollout_lands): Same.
3519 (test_non_valid_patch): Same.
3520 (test_auto_retry): Same.
3521 (test_style_queue_with_watch_list_exception): Same.
3523 2016-07-02 Filip Pizlo <fpizlo@apple.com>
3525 WTF::Lock should be fair eventually
3526 https://bugs.webkit.org/show_bug.cgi?id=159384
3528 Reviewed by Geoffrey Garen.
3530 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3532 2016-07-17 Sam Weinig <sam@webkit.org>
3534 [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3535 <rdar://problem/26554137>
3536 https://bugs.webkit.org/show_bug.cgi?id=159856
3538 Reviewed by Dan Bernstein.
3540 * MiniBrowser/mac/WK2BrowserWindowController.m:
3541 (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3542 Add basic window.open implementation.
3544 (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
3545 Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
3546 to open a single non-web URL, all others are dropped.
3548 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3549 * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
3550 * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
3551 Add API for the new SPI.
3553 2016-07-17 Yusuke Suzuki <utatane.tea@gmail.com>
3555 [JSC] Enable test262 module tests
3556 https://bugs.webkit.org/show_bug.cgi?id=159854
3558 Reviewed by Saam Barati.
3560 Use --module-file instead.
3562 * Scripts/run-jsc-stress-tests:
3564 2016-07-16 Chris Dumez <cdumez@apple.com>
3566 Unreviewed, rolling out r203318.
3568 Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
3573 "[JSC] Change some parameters based on a random search"
3574 https://bugs.webkit.org/show_bug.cgi?id=158514
3575 http://trac.webkit.org/changeset/203318
3577 2016-07-16 Chris Dumez <cdumez@apple.com>
3579 Add move constructor / assignment operator to ListHashSet
3580 https://bugs.webkit.org/show_bug.cgi?id=159837
3582 Reviewed by Darin Adler.
3586 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3587 (TestWebKitAPI::TEST):
3589 2016-07-15 Benjamin Poulain <bpoulain@apple.com>
3591 [JSC] Change some parameters based on a random search
3592 https://bugs.webkit.org/show_bug.cgi?id=158514
3594 Reviewed by Saam Barati.
3596 * Scripts/run-jsc-stress-tests:
3598 2016-07-15 Jon Davis <jond@apple.com>
3600 Changed the start page URL for WebKit Nightly builds.
3601 https://bugs.webkit.org/show_bug.cgi?id=159816
3603 Reviewed by Timothy Hatcher.
3605 * WebKitLauncher/start.html:
3607 2016-07-15 Per Arne Vollan <pvollan@apple.com>
3609 Uninitialized variable in DIBPixelData can cause a dangerous memory write
3610 https://bugs.webkit.org/show_bug.cgi?id=159414
3612 Reviewed by Brent Fulgham.
3614 Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
3615 when the HDC parameter is invalid.
3617 * TestWebKitAPI/PlatformWin.cmake:
3618 * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
3619 (TestWebKitAPI::TEST):
3621 2016-07-15 Carlos Garcia Campos <cgarcia@igalia.com>
3623 [GTK] Add basic tabs support to MiniBrowser