6933a4df754feeb0da776ed68e065661cd183a44
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-10  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by James Robinson.
4
5         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
6         https://bugs.webkit.org/show_bug.cgi?id=62489
7
8         * Scripts/webkitpy/tool/bot/sheriff.py:
9         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
10
11 2011-06-10  Tony Chang  <tony@chromium.org>
12
13         Reviewed by Ojan Vafai.
14
15         add a compile guard ENABLE(FLEXBOX)
16         https://bugs.webkit.org/show_bug.cgi?id=62049
17
18         * Scripts/build-webkit:
19
20 2011-06-10  Mark Rowe  <mrowe@apple.com>
21
22         Reviewed by Dimitri Glazkov.
23
24         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
25
26         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
27         header file.
28
29         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
30         * DumpRenderTree/mac/Configurations/Base.xcconfig:
31
32 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
33
34         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
35
36         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
37         (handleEventX11):
38         (NPP_GetValue):
39         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
40         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
41         (webkit_test_plugin_new_instance):
42         (webkit_test_plugin_destroy_instance):
43         (webkit_test_plugin_set_window):
44         (executeScript):
45         (webkit_test_plugin_new_stream):
46         (webkit_test_plugin_destroy_stream):
47         (webkit_test_plugin_stream_as_file):
48         (webkit_test_plugin_write_ready):
49         (webkit_test_plugin_write):
50         (webkit_test_plugin_print):
51         (keyEventToChar):
52         (webkit_test_plugin_handle_event):
53         (webkit_test_plugin_url_notify):
54         (webkit_test_plugin_get_value):
55         (webkit_test_plugin_set_value):
56         (NP_GetMIMEDescription):
57         (NP_Initialize):
58         (NP_Shutdown):
59         (NP_GetValue):
60         * GNUmakefile.am:
61
62 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
63
64         Reviewed by Eric Seidel.
65
66         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
67         https://bugs.webkit.org/show_bug.cgi?id=55603
68
69         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
70         TextInputController support.
71
72         * DumpRenderTree/gtk/TextInputController.cpp:
73         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
74         of start and end. This matches the other ports. Do not use GLib style early returns.
75         (hasMarkedTextCallback): Added.
76         (markedRangeCallback): Added.
77         (insertTextCallback): Cleanup as described above.
78         (unmarkTextCallback): Cleanup as described above.
79         (firstRectForCharacterRangeCallback): Cleanup as described above.
80         (selectedRangeCallback): Cleanup as described above.
81
82 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
83
84         Reviewed by Tony Chang.
85
86         nrwt: support webaudio in chromium driver
87         https://bugs.webkit.org/show_bug.cgi?id=62226
88
89         * Scripts/webkitpy/layout_tests/port/chromium.py:
90
91 2011-06-09  Dan Bernstein  <mitz@apple.com>
92
93         Reviewed by Anders Carlsson.
94
95         Added a test for Vector::reverse()
96         https://bugs.webkit.org/show_bug.cgi?id=62393
97
98         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
99         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
100         (TestWebKitAPI::TEST):
101         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
102
103 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
104
105         Reviewed by Andreas Kling.
106
107         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
108         https://bugs.webkit.org/show_bug.cgi?id=62385
109
110         Remove duplicate TestNetscapePlugIn implementation. Having two copies
111         of this code makes keeping it in sync much more difficult. The files are
112         almost identical and this change ports the X11 changes to main.cpp.
113
114         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
115         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
116         (handleEventX11): Use the handler to properly convert the keycode. Do not print
117         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
118         it should not be in the results.
119         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
120         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
121         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
122         * GNUmakefile.am: Update source list.
123
124 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
125
126         Reviewed by Tony Chang.
127
128         Test plugin should support event logging on the windows port.
129         https://bugs.webkit.org/show_bug.cgi?id=61721
130
131         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
132         calls to mean the plugin handled the event.
133
134         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
135         (handleEventWin): Return 0 for each event on windows.
136
137 2011-06-09  Chang Shu  <cshu@webkit.org>
138
139         Reviewed by Andreas Kling.
140
141         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
142         https://bugs.webkit.org/show_bug.cgi?id=62381
143
144         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
145         QWKPagePrivate::isViewFocused() will check it later.
146
147         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
148         (WTR::PlatformWebView::PlatformWebView):
149
150 2011-06-09  Robert Hogan  <robert@webkit.org>
151
152         Reviewed by Andreas Kling.
153
154         Teach Qt about window.internals
155         https://bugs.webkit.org/show_bug.cgi?id=61074
156
157         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
158         (WebCore::DumpRenderTree::initJSObjects):
159
160 2011-06-09  Eric Seidel  <eric@webkit.org>
161
162         Reviewed by Adam Barth.
163
164         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
165         https://bugs.webkit.org/show_bug.cgi?id=62362
166
167         The mac bots are failing inspector tests.  We don't know why yet.
168         So for now, turning run-webkit-tests off for the mac-ews.
169
170         Also noticed that due to the wrong variable name the cr-linux
171         bots weren't running tests!
172
173         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
174
175 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
176
177         Reviewed by Csaba Osztrogonac.
178
179         [Qt][WK2] Canvas tests make css2.1 ones failing
180         https://bugs.webkit.org/show_bug.cgi?id=53427
181
182         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
183         Since the Qt port should eventually go to QRawFont, this issue will be resolved
184         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
185         needed for the workaround.
186
187         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
188         (WTR::LayoutTestController::platformInitialize):
189
190 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
191
192         Reviewed by Chris Fleizach.
193
194         [GTK] Provide a way in DRT to check the platform name
195         https://bugs.webkit.org/show_bug.cgi?id=56855
196
197         Patch for adding 'platformName' static property to DRT's
198         LayoutController and provide platform specific implementations.
199
200         In principle, this feature will be only of interest for writing
201         accessibility tests, so that's why it's only implemented in the
202         Mac, Gtk and Win platforms.
203
204         * DumpRenderTree/LayoutTestController.h: New method platformName().
205         * DumpRenderTree/LayoutTestController.cpp:
206         (getPlatformNameCallback): New callback for 'platformName'.
207         (LayoutTestController::staticValues): New static property.
208
209         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
210         (LayoutTestController::platformName): Implemented.
211
212         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
213         (LayoutTestController::platformName): Implemented.
214
215         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
216         (LayoutTestController::platformName): Implemented.
217
218 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
219
220         Reviewed by James Robinson.
221
222         Add mikelawther to committers.py
223         https://bugs.webkit.org/show_bug.cgi?id=62354
224
225         * Scripts/webkitpy/common/config/committers.py:
226
227 2011-06-08  Kent Tamura  <tkent@chromium.org>
228
229         [Chromium] Fix a typo.
230
231         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
232         (WebThemeControlDRTWin::draw):
233
234 2011-06-08  Kent Tamura  <tkent@chromium.org>
235
236         Reviewed by Hajime Morita.
237
238         [Chromium] Support vertical sliders in Windows DRT
239         https://bugs.webkit.org/show_bug.cgi?id=62352
240
241         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
242         (WebThemeControlDRTWin::draw):
243           Paint VerticalSliderThumbType and VerticalSliderTrackType.
244         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
245           Add VerticalSliderTrackType and VerticalSliderThumbType.
246         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
247         (WebThemeEngineDRTWin::paintTrackbar):
248           Convert Windows identifiers to the internal identifiers for vertical sliders.
249
250 2011-06-08  Ojan Vafai  <ojan@chromium.org>
251
252         Reviewed by Tony Chang.
253
254         add a short-flag for --experimental-fully-parallel
255         https://bugs.webkit.org/show_bug.cgi?id=62321
256
257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
258
259 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
260
261         Reviewed by Tony Chang.
262
263         new-run-webkit-tests: don't turn the tree red when there are new passes
264         https://bugs.webkit.org/show_bug.cgi?id=62311
265
266         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
267         to match commandComplete.
268
269         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
270
271 2011-06-08  Tom Hudson  <tomhudson@google.com>
272
273         Reviewed by Mihai Parparita.
274
275         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
276         https://bugs.webkit.org/show_bug.cgi?id=60964
277
278         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
279         Add 'Sort tests by metric' link.
280         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
281         (disableSorting): Activate 'Sort tests by metric' link.
282         (enableSorting): Deactivate 'Sort tests by metric' link.
283         (selectDirectory): Call enableSorting()/disableSorting() depending
284         on currently selected failure type, and sort tests if requested.
285         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
286         New .disabled-control class for deactivated links.
287
288 2011-06-08  Tom Sepez  <tsepez@chromium.org>
289
290         Reviewed by Adam Barth.
291
292         Add web permissions callbacks for mixed content blocking.
293         https://bugs.webkit.org/show_bug.cgi?id=61946
294
295         * DumpRenderTree/chromium/LayoutTestController.cpp:
296         (LayoutTestController::setAllowDisplayOfInsecureContent):
297         (LayoutTestController::setAllowRunningOfInsecureContent):
298         (LayoutTestController::overridePreference):
299         * DumpRenderTree/chromium/WebPermissions.cpp:
300         (WebPermissions::allowDisplayingInsecureContent):
301         (WebPermissions::allowRunningInsecureContent):
302         (WebPermissions::setDisplayingInsecureContentAllowed):
303         (WebPermissions::setRunningInsecureContentAllowed):
304         (WebPermissions::reset):
305         * DumpRenderTree/chromium/WebPermissions.h:
306
307 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
308
309         Reviewed by Tony Chang.
310
311         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
312         https://bugs.webkit.org/show_bug.cgi?id=62259
313
314         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
315
316 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
317
318         Reviewed by Tony Chang.
319
320         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
321         https://bugs.webkit.org/show_bug.cgi?id=62303
322
323         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
324
325         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
326
327 2011-06-08  Greg Simon  <gregsimon@chromium.org>
328
329         Reviewed by Dimitri Glazkov.
330
331         Control Indexeddb backends from LayoutTestController
332         https://bugs.webkit.org/show_bug.cgi?id=61000
333
334         * DumpRenderTree/chromium/LayoutTestController.cpp:
335         (LayoutTestController::LayoutTestController):
336         (LayoutTestController::setOverrideIndexedDBBackingStore):
337         (LayoutTestController::clearAllDatabases):
338         * DumpRenderTree/chromium/LayoutTestController.h:
339
340 2011-06-08  Andreas Kling  <kling@webkit.org>
341
342         Add Pierre Rossi to contributors list for EZ-CC.
343
344         * Scripts/webkitpy/common/config/committers.py:
345
346 2011-06-08  Ilya Sherman  <isherman@chromium.org>
347
348         Reviewed by Andreas Kling.
349
350         Add Ilya Sherman to list of committers
351         https://bugs.webkit.org/show_bug.cgi?id=62270
352
353         * Scripts/webkitpy/common/config/committers.py:
354
355 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
356
357         Reviewed by Tony Chang.
358
359         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
360         https://bugs.webkit.org/show_bug.cgi?id=62178
361
362         Added commandComplete and evaluateCommand for NewRunWebKitTests class
363         to parse new-run-webkit-tests' results.
364
365         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
366
367 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
368
369         Reviewed by Eric Seidel.
370
371         webkitpy: add a popen() call to executive
372         https://bugs.webkit.org/show_bug.cgi?id=62179
373
374         This change adds a popen() wrapper call to the Executive object.
375         This will allow other webkitpy scripts that currently call
376         subprocess directly to use Executive, instead.
377
378         No additional tests are necessary (the existing tests cover the code).
379
380         * Scripts/webkitpy/common/system/executive.py:
381
382 2011-06-07  Sam Weinig  <sam@webkit.org>
383
384         Reviewed by Anders Carlsson.
385
386         Remove repeated IPC traffic from SetRenderTreeSize message
387         https://bugs.webkit.org/show_bug.cgi?id=62244
388
389         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
390         (WTR::InjectedBundlePage::InjectedBundlePage):
391         Add stub for didLayoutForFrame.
392
393 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
394
395         Reviewed by Tony Chang.
396
397         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
398         https://bugs.webkit.org/show_bug.cgi?id=62241
399
400         * Scripts/webkitpy/layout_tests/port/chromium.py:
401
402 2011-06-07  Adam Barth  <abarth@webkit.org>
403
404         Rubber-stamped by Eric Seidel.
405
406         Enable tests on the mac-ews
407
408         When we bring the mac-ews back up, we're going to try running tests!
409
410         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
411
412 2011-06-07  Dmitry Lomov  <dslomov@google.com>
413
414         Reviewed by David Levin.
415
416         https://bugs.webkit.org/show_bug.cgi?id=62215
417         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
418
419         * Scripts/webkitpy/style/checkers/cpp.py:
420         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
421
422 2011-06-07  Nico Weber  <thakis@chromium.org>
423
424         Reviewed by Dimitri Glazkov.
425
426         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
427         https://bugs.webkit.org/show_bug.cgi?id=62210
428
429         The change to TestEventPrinter fixes a latent bug, because
430         objects are deleted through the TestEventPrinter type, but none
431         of the subclasses have destructors or non-POD members.
432
433         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
434         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
435         discussed at http://codereview.chromium.org/7094005/, we prefer making
436         leaf class destructors virtual over making the leaf classes final.
437
438         * DumpRenderTree/chromium/NotificationPresenter.cpp:
439         (NotificationPresenter::~NotificationPresenter):
440         * DumpRenderTree/chromium/NotificationPresenter.h:
441         * DumpRenderTree/chromium/TestEventPrinter.cpp:
442         (TestEventPrinter::~TestEventPrinter):
443         * DumpRenderTree/chromium/TestEventPrinter.h:
444         * DumpRenderTree/chromium/WebViewHost.h:
445
446 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
447
448         Reviewed by Dirk Pranke.
449
450         [chromium] Chromium bots on build.webkit.org don't upload results.html
451         https://bugs.webkit.org/show_bug.cgi?id=61961
452
453         Don't fix the path on chromium port erroneously.
454
455         * BuildSlaveSupport/test-result-archive:
456
457 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
458
459         Fix the GTK+ build by ensuring that the autogenerated sources
460         necessary for libWebCoreInternals are recorded in a predeclared
461         variable before assigning to BUILT_SOURCES.
462
463         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
464
465 2011-06-06  Yong Li  <yoli@rim.com>
466
467         Reviewed by Eric Seidel.
468
469         https://bugs.webkit.org/show_bug.cgi?id=62097
470         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
471
472         * Scripts/webkitpy/style/checkers/cpp.py:
473         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
474
475 2011-06-06  Xan Lopez  <xlopez@igalia.com>
476
477         Reviewed by Martin Robinson.
478
479         [GTK] Enable feature/symbol detection in NWRT/GTK
480         https://bugs.webkit.org/show_bug.cgi?id=62136
481
482         Disable feature detection through DRT, since we don't support it,
483         and set the libwebcore patch correctly so that symbol detection
484         through 'nm' works.
485
486         * Scripts/webkitpy/layout_tests/port/gtk.py:
487
488 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
489
490         Reviewed by Tony Gentilcore.
491
492         Add a "prerender" state for page visibility.
493         https://bugs.webkit.org/show_bug.cgi?id=62062
494
495         * DumpRenderTree/chromium/LayoutTestController.cpp:
496         (LayoutTestController::setPageVisibility):
497
498 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
499
500         [Qt] Implement download feature for QtTestBrowser
501         https://bugs.webkit.org/show_bug.cgi?id=61865
502
503         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
504
505         * QtTestBrowser/launcherwindow.cpp:
506         (LauncherWindow::LauncherWindow):
507         * QtTestBrowser/launcherwindow.h:
508
509 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
510
511         Reviewed by Csaba Osztrogonác.
512
513         [Qt] Implement download feature for QtTestBrowser
514         https://bugs.webkit.org/show_bug.cgi?id=61865
515
516         * QtTestBrowser/launcherwindow.cpp:
517         (LauncherWindow::LauncherWindow):
518         (LauncherWindow::downloadRequest):
519         (LauncherWindow::fileDownloadFinished):
520         * QtTestBrowser/launcherwindow.h:
521
522 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
523
524         Reviewed by Dimitri Glazkov.
525
526         Make DumpRenderTree initialize window.internals.
527         https://bugs.webkit.org/show_bug.cgi?id=61076
528
529         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
530         * DumpRenderTree/win/FrameLoadDelegate.cpp:
531         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
532
533 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
534
535         Reviewed by Kent Tamura.
536
537         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
538         https://bugs.webkit.org/show_bug.cgi?id=61628
539
540         * Scripts/build-webkit:
541
542 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
543
544         Reviewed by Kent Tamura.
545
546         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
547         https://bugs.webkit.org/show_bug.cgi?id=61631
548
549         * Scripts/build-webkit:
550
551 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
552
553         Unreviewed. Fix the GTK+ build.
554
555         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
556
557 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
558
559         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
560         works properly).
561
562         * Scripts/webkitpy/common/config/committers.py:
563
564 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
565
566         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
567         WebKit scripts expect, so other scripts work properly with wx.
568
569         * waf/build/build_utils.py:
570         * waf/build/settings.py:
571
572 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
573
574         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
575         to build on Mac.
576
577         * waf/build/settings.py:
578         * wx/install-unix-extras:
579
580 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
581
582         [wx] Unreviewed build fixes for recent trunk changes.
583
584         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
585         (LayoutTestController::setTextDirection):
586         * waf/build/settings.py:
587
588 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
589
590         Fix the GTK+ build.
591
592         * GNUmakefile.am: Add some missing newline escape.
593
594 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
595
596         Try to fix the GTK+ bulid.
597
598         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
599         source list.
600
601 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
602
603         Reviewed by Adam Barth.
604
605         nrwt: should skip chromium test expectation overrides on upstream bots
606         https://bugs.webkit.org/show_bug.cgi?id=61888
607
608         * Scripts/webkitpy/layout_tests/port/chromium.py:
609         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
610
611 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
612
613         Reviewed by Ojan Vafai.
614
615         new-run-webkit-tests: minor logging, code cleanup
616         https://bugs.webkit.org/show_bug.cgi?id=62055
617
618         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
619         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
620
621 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
622
623         Try to fix the build failure on the GTK+ 32-bit Release bot.
624
625         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
626
627 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
628
629         Reviewed by Ryosuke Niwa.
630
631         [GTK] Support smart replace for the pasteboard
632         https://bugs.webkit.org/show_bug.cgi?id=61734
633
634         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
635         This is required to produce consistent test results.
636
637         * DumpRenderTree/gtk/DumpRenderTree.cpp:
638         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
639         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
640         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
641         methods which calls into DumpRenderTreeSupportGtk.
642
643 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
644
645         Reviewed by Dimitri Glazkov.
646
647         Teach Gtk build about window.internals
648         https://bugs.webkit.org/show_bug.cgi?id=61071
649
650         * DumpRenderTree/gtk/DumpRenderTree.cpp:
651         (webViewWindowObjectCleared): Inject the new internals object when the
652         window object clears.
653         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
654         Also do a little bit of cleanup.
655
656 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
657
658         Reviewed by Tony Chang.
659
660         Worker may not be stopped after LT.
661         https://bugs.webkit.org/show_bug.cgi?id=61847
662
663         Re-submit a variant of the first fix for this bug. It's possible
664         that actually calling cleanup() in the worker threads was taking
665         too long and we triggered the assertions in the manager thread.
666
667         I've bumped up the timeout in the manager and added better
668         diagnostics. I also cleaned up the cleanup() code a bit because
669         there was some unnecessary if-checks.
670
671         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
672         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
673
674 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
675
676         Reviewed by Tony Chang.
677
678         nrwt: fix duplicate logging regression
679         https://bugs.webkit.org/show_bug.cgi?id=61981
680
681         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
682
683 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
684
685         Reviewed by Adam Barth.
686
687         Modified addTouchPoint to correctly re-use touchPoint id values starting
688         from the lowest not-un-use touchPoint id as is done by the embedder
689         APIs. (Fixes BUGCR36415)
690
691         https://bugs.webkit.org/show_bug.cgi?id=62016
692
693         * DumpRenderTree/chromium/EventSender.cpp:
694         (EventSender::addTouchPoint):
695
696 2011-06-03  Cary Clark  <caryclark@google.com>
697
698         Reviewed by Eric Seidel.
699
700         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
701         https://bugs.webkit.org/show_bug.cgi?id=61534
702
703         Skia on Mac uses Skia to render WebKit, and CG
704         to render UI elements. The CG elements need a
705         transcribed graphics context that preserves the
706         canvas matrix, and the canvas clip.
707
708         The SkiaBitLocker utility class sets up a CGContext
709         from the SkCanvas, locks the bitmap's bits, and
710         releases the lock when the class goes out of scope.
711
712         The SkiaBitLocker implementation is described by
713         this patch:
714         http://codereview.chromium.org/7031006/
715
716         When WebKit uses Skia for rendering, the WebCanvas
717         is an SkCanvas. Create an equivalent CGContext to
718         draw the scrollbar thumb.
719
720         As the Chrome Mac port does not yet use Skia, this
721         patch has no effect and requires no tests.
722
723         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
724         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
725
726 2011-06-03  Andras Becsi  <abecsi@webkit.org>
727
728         Unreviewed build fix.
729
730         Fix typo.
731
732         * Scripts/old-run-webkit-tests:
733
734 2011-06-03  Andras Becsi  <abecsi@webkit.org>
735
736         Reviewed by Csaba Osztrogonác.
737
738         Print error message when there is no httpd present on the system
739         https://bugs.webkit.org/show_bug.cgi?id=61939
740
741         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
742         * Scripts/webkitperl/httpd.pm:
743
744 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
745
746         Reviewed by Yury Semikhatsky.
747
748         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
749         https://bugs.webkit.org/show_bug.cgi?id=61533
750
751         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
752
753         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
754         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
755         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
756         * DumpRenderTree/chromium/LayoutTestController.cpp:
757         (LayoutTestController::LayoutTestController):
758         (LayoutTestController::setJavaScriptProfilingEnabled):
759         * DumpRenderTree/chromium/LayoutTestController.h:
760         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
761         (LayoutTestController::setJavaScriptProfilingEnabled):
762         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
763         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
764         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
765
766 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
767
768         Reviewed by Tony Chang.
769
770         NRWT needs a way to log to a file without including backspaces without needing --verbose
771         https://bugs.webkit.org/show_bug.cgi?id=60328
772
773         This change modifies NRWT so that if it can tell if it is
774         writing to a terminal, it will overwrite any messages printed
775         in the 'one-line-progress' and 'updates' print options, and if
776         not (or if --verbose was specified) the messages will be printed
777         without backspaces.
778
779         If the overwriting updates are disabled, one-line-progress will
780         only print every 10 seconds instead of on every update. This
781         ensures that we still get updates once in a while while the
782         tests are running, even if we're not in --verbose mode. Note
783         that one-line-progress will now still be printed in --verbose,
784         since it's useful as long as you're not flooded with the
785         updates.
786
787         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
788         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
789         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
790
791 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
792
793         Reviewed by Gustavo Noronha Silva.
794
795         [GTK] autogen.sh is run twice for each buld on the bots
796         https://bugs.webkit.org/show_bug.cgi?id=61951
797
798         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
799         for the WebKit project. This prevents build-jsc runs from forcing subsequent
800         build-webkit runs to re-rerun autogen.sh.
801
802 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
803
804         Unreviewed, rolling out r87946.
805         http://trac.webkit.org/changeset/87946
806         https://bugs.webkit.org/show_bug.cgi?id=61965
807
808         Cause NRWT to break (Requested by abarth|gardener on #webkit).
809
810         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
811
812 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
813
814         Reviewed by Darin Adler.
815
816         Add build logistics and plumbing for window.internals object.
817         https://bugs.webkit.org/show_bug.cgi?id=60313
818
819         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
820         * DumpRenderTree/chromium/TestShell.cpp:
821         (TestShell::bindJSObjectsToWindow): Added injection code.
822         * DumpRenderTree/mac/FrameLoadDelegate.mm:
823         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
824
825 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
826
827         Reviewed by Dirk Pranke.
828
829         Call cleanup() explicitly at the end of worker.run().
830         https://bugs.webkit.org/show_bug.cgi?id=61847
831
832         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
833
834 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
835
836         Unreviewed, rolling out r87926.
837         http://trac.webkit.org/changeset/87926
838         https://bugs.webkit.org/show_bug.cgi?id=60313
839
840         Fails to find WebCoreTestSupport.dylib on bots.
841
842         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
843         * DumpRenderTree/chromium/TestShell.cpp:
844         (TestShell::bindJSObjectsToWindow):
845         * DumpRenderTree/mac/FrameLoadDelegate.mm:
846         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
847
848 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
849
850         Reviewed by Darin Adler.
851
852         Add build logistics and plumbing for window.internals object.
853         https://bugs.webkit.org/show_bug.cgi?id=60313
854
855         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
856         * DumpRenderTree/chromium/TestShell.cpp:
857         (TestShell::bindJSObjectsToWindow): Added injection code.
858         * DumpRenderTree/mac/FrameLoadDelegate.mm:
859         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
860
861 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
862
863         Reviewed by Eric Seidel.
864
865         Adjust efl coding style to more efl directories
866         https://bugs.webkit.org/show_bug.cgi?id=61903
867
868         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
869
870 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
871
872         Reviewed by Tony Chang.
873
874         old-run-webkit-tests: add support for audio files
875         https://bugs.webkit.org/show_bug.cgi?id=57992
876
877         * Scripts/old-run-webkit-tests:
878
879 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
880
881         Reviewed by Adam Barth.
882
883         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
884         https://bugs.webkit.org/show_bug.cgi?id=34314
885
886         * DumpRenderTree/DumpRenderTree.gypi:
887         * DumpRenderTree/chromium/LayoutTestController.cpp:
888         (LayoutTestController::LayoutTestController):
889         (LayoutTestController::setImagesAllowed):
890         (LayoutTestController::setStorageAllowed):
891         * DumpRenderTree/chromium/LayoutTestController.h:
892         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
893         (WebPermissions::WebPermissions):
894         (WebPermissions::~WebPermissions):
895         (WebPermissions::allowImages):
896         (WebPermissions::allowStorage):
897         (WebPermissions::setImagesAllowed):
898         (WebPermissions::setStorageAllowed):
899         (WebPermissions::reset):
900         * DumpRenderTree/chromium/WebPermissions.h:
901
902 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
903
904         Reviewed by Tony Chang.
905
906         Test plugin should support event logging on the windows port.
907         https://bugs.webkit.org/show_bug.cgi?id=61721
908
909         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
910         (handleEventWin): Well, handle them.
911
912 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
913
914         Reviewed by Tony Chang.
915
916         [chromium] Use correct file name for dragging out images.
917         https://bugs.webkit.org/show_bug.cgi?id=24887
918
919         * DumpRenderTree/chromium/EventSender.cpp:
920         (EventSender::EventSender):
921         (EventSender::dumpFilenameBeingDragged):
922         * DumpRenderTree/chromium/EventSender.h:
923
924 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
925
926         Reviewed by Tony Chang.
927
928         nrwt: make webaudio work w/o content-length header
929         https://bugs.webkit.org/show_bug.cgi?id=61819
930
931         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
932         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
933         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
934         * Scripts/webkitpy/layout_tests/port/webkit.py:
935
936 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
937
938         Reviewed by Andreas Kling.
939
940         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
941         https://bugs.webkit.org/show_bug.cgi?id=61802
942
943         Add command line parameter and menu item to MiniBrowser application 
944         enabling use of QGLWidget for browser viewport.
945
946         * MiniBrowser/qt/BrowserWindow.cpp:
947         (BrowserWindow::BrowserWindow):
948         (BrowserWindow::toggleGLViewport):
949         * MiniBrowser/qt/BrowserWindow.h:
950         * MiniBrowser/qt/MiniBrowserApplication.cpp:
951         (MiniBrowserApplication::handleUserOptions):
952         * MiniBrowser/qt/MiniBrowserApplication.h:
953         (WindowOptions::WindowOptions):
954
955 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
956
957         Reviewed by Xan Lopez.
958
959         Print out autogen arguments when they differ from the last set, to help
960         with debugging build issues.
961
962         * Scripts/webkitdirs.pm: Print out previous and current build arguments
963         when they differ.
964
965 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
966
967         Reviewed by Martin Robinson.
968
969         [GTK] run-launcher should run MiniBrowser in WebKit2
970         https://bugs.webkit.org/show_bug.cgi?id=61858
971
972         * Scripts/run-launcher: Check whether -2 command line option has
973         been passed and run MiniBrowser instead of GtkLauncher.
974
975 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
976
977         Reviewed by Dirk Pranke.
978
979         Fix exception in verbose printing mode.
980         https://bugs.webkit.org/show_bug.cgi?id=61723
981
982         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
983
984 2011-05-31  Yong Li  <yoli@rim.com>
985
986         Reviewed by Eric Seidel.
987
988         https://bugs.webkit.org/show_bug.cgi?id=54807
989         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
990         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
991         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
992         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
993         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
994         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
995         rule we should have in order to make our code independent from compilers and compiler flags.
996
997         * Scripts/webkitpy/style/checkers/cpp.py:
998
999 2011-05-31  Hironori Bono  <hbono@chromium.org>
1000
1001         Reviewed by Eric Seidel.
1002
1003         Add a JavaScript function layoutTestController.setTextDirection().
1004         https://bugs.webkit.org/show_bug.cgi?id=50952
1005
1006         This change adds a new JavaScript function setTextDirection() to the
1007         LayoutTestController class of Safari and Chrome to write layout tests
1008         that changes the text direction of an editable element.
1009
1010         * DumpRenderTree/LayoutTestController.cpp:
1011         (setTextDirectionCallback):
1012         (LayoutTestController::staticFunctions):
1013         * DumpRenderTree/LayoutTestController.h:
1014         * DumpRenderTree/chromium/LayoutTestController.cpp:
1015         (LayoutTestController::LayoutTestController):
1016         (LayoutTestController::setTextDirection):
1017         * DumpRenderTree/chromium/LayoutTestController.h:
1018         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1019         (LayoutTestController::setTextDirection):
1020         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1021         (LayoutTestController::setTextDirection):
1022         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1023         (LayoutTestController::setTextDirection):
1024
1025 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1026
1027         Reviewed by Simon Hausmann.
1028
1029         [Qt] User-agent list of Qt test browsers is very outdated
1030         https://bugs.webkit.org/show_bug.cgi?id=61531
1031
1032         The user can edit the user-agent manually, so there's no need to have
1033         a super complete and up to date list, but it's nice to have it
1034         minimally updated.
1035
1036         * MiniBrowser/qt/useragentlist.txt:
1037         * QtTestBrowser/useragentlist.txt:
1038
1039 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
1040
1041         Reviewed by Adam Roben.
1042
1043         [GTK] [WebKit2] Implement a basic WebKitTestRunner
1044         https://bugs.webkit.org/show_bug.cgi?id=57068
1045
1046         Add an implementation of WebKitTestRunner for GTK+.
1047
1048         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
1049         * Scripts/old-run-webkit-tests: Ditto.
1050         * Scripts/run-launcher: Ditto.
1051         * Scripts/webkitdirs.pm: Ditto.
1052         * WebKitTestRunner/GNUmakefile.am: Added.
1053         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1054         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
1055         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1056         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1057         * WebKitTestRunner/PlatformWebView.h:
1058         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
1059         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
1060         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1061         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1062         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1063         (main): Added.
1064
1065 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
1066
1067         Reviewed by Tony Chang.
1068
1069         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
1070         https://bugs.webkit.org/show_bug.cgi?id=60241
1071
1072         * Scripts/new-run-webkit-tests:
1073
1074 2011-05-31  Eric Seidel  <eric@webkit.org>
1075
1076         Reviewed by David Kilzer.
1077
1078         webkitpy should create zips with zip -9
1079         https://bugs.webkit.org/show_bug.cgi?id=61789
1080
1081         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
1082
1083         * Scripts/webkitpy/common/system/workspace.py:
1084         * Scripts/webkitpy/common/system/workspace_unittest.py:
1085
1086 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1087
1088         Reviewed by Csaba Osztrogonác.
1089
1090         [Qt] Implement find feature for QtTestBrowser
1091         https://bugs.webkit.org/show_bug.cgi?id=61425
1092
1093         Buildfix for --minimal and CONFIG+=qt_minimal build.
1094
1095         * QtTestBrowser/launcherwindow.cpp:
1096         (LauncherWindow::LauncherWindow):
1097         (LauncherWindow::createChrome):
1098         * QtTestBrowser/launcherwindow.h:
1099
1100 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1101
1102         Reviewed by Csaba Osztrogonác.
1103
1104         [Qt] Implement find feature for QtTestBrowser
1105         https://bugs.webkit.org/show_bug.cgi?id=61425
1106
1107         * QtTestBrowser/launcherwindow.cpp:
1108         (LauncherWindow::LauncherWindow):
1109         (LauncherWindow::createChrome):
1110         (LauncherWindow::showFindBar):
1111         (LauncherWindow::find):
1112         * QtTestBrowser/launcherwindow.h:
1113
1114 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1115
1116         Reviewed by Martin Robinson.
1117
1118         [GTK] Implement JavaScript dialogs in MiniBrowser
1119         https://bugs.webkit.org/show_bug.cgi?id=61725
1120
1121         * MiniBrowser/gtk/BrowserWindow.c:
1122         (WKStringGetCString): Helper function to get a UTF-8 c string from
1123         a WKStringRef.
1124         (WKURLGetCString): Helper function to get a UTF-8 c string from a
1125         WKURLRef.
1126         (browserWindowUpdateURL): Update to use WKURLGetCString.
1127         (didReceiveTitleForFrame): Update to use WKStringGetCString.
1128         (createMessageDialog): Create a GtkMessageDialog.
1129         (runJavaScriptAlert):
1130         (runJavaScriptConfirm):
1131         (runJavaScriptPrompt):
1132         (browserWindowUIClientInit):
1133
1134 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
1135
1136         Reviewed by Kent Tamura.
1137
1138         WebSocket closing handshake
1139         https://bugs.webkit.org/show_bug.cgi?id=35721
1140
1141         * Scripts/webkitpy/thirdparty/__init__.py:
1142         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1143         to get the right behavior of closing handshake.
1144
1145 2011-05-29  Daniel Bates  <dbates@rim.com>
1146
1147         Reviewed by David Kilzer.
1148
1149         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
1150         https://bugs.webkit.org/show_bug.cgi?id=61162
1151
1152         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
1153         that omits a line count. In particular, the chunk range regular expression does
1154         not match a chunk range line that omits a line count. GNU diff(1) will omit the
1155         line count in the chunk range if the line count is exactly 1. For example, appending
1156         a new line to the end of an existing file F that contains exactly one line of text will
1157         be represented in a diff with a chunk range line that omits the line count for F.
1158
1159         * Scripts/VCSUtils.pm:
1160           (parseChunkRange): Added.
1161         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
1162         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1163           - Added unit test "Git: Append new line to the end of an existing file".
1164
1165 2011-05-28  Adam Barth  <abarth@webkit.org>
1166
1167         Reviewed by Eric Seidel.
1168
1169         EWS builds patches that fail to build twice, which seems useless and slows down the bots
1170         https://bugs.webkit.org/show_bug.cgi?id=55585
1171
1172         This patch switches all the early warning system bots over to the new
1173         PatchAnalysisTask-based infrastructure.  This patch makes these bots
1174         more efficient (in the case where patches fail to build) and paves the
1175         way for running tests on these bots!
1176
1177         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1178         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1179         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1180         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1181         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1182         * Scripts/webkitpy/tool/commands/queues.py:
1183
1184 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
1185
1186         Reviewed by Kent Tamura.
1187
1188         Add bashi as a committer.
1189
1190         https://bugs.webkit.org/show_bug.cgi?id=61685
1191
1192         * Scripts/webkitpy/common/config/committers.py:
1193
1194 2011-05-27  Adam Barth  <abarth@webkit.org>
1195
1196         Reviewed by Eric Seidel.
1197
1198         When checking whether the tree is red, the EWS posts a link to the wrong log
1199         https://bugs.webkit.org/show_bug.cgi?id=61072
1200
1201         We need to cache the original script error because that contains the
1202         failure log we want to upload.  If we don't cache that script error,
1203         self._script_error will get overwritten when we sanity check the clean
1204         tree (and it also has test failures).
1205
1206         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1207             - This testing approach is slightly goofy.  We'd like to use
1208               assertRaisesRegexp, but that's not available until Python 2.7.
1209         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1210
1211 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
1212
1213         Reviewed by Adam Barth.
1214
1215         Add layoutTestController.setStorageAllowed() to control whether access
1216         to the localStorage API is enabled via the WebPermissionClient
1217         https://bugs.webkit.org/show_bug.cgi?id=61581
1218
1219         * DumpRenderTree/chromium/LayoutTestController.cpp:
1220         (LayoutTestController::LayoutTestController):
1221         (LayoutTestController::setStorageAllowed):
1222         * DumpRenderTree/chromium/LayoutTestController.h:
1223         * DumpRenderTree/chromium/TestShell.cpp:
1224         (TestShell::TestShell):
1225         (TestShell::createNewWindow):
1226         * DumpRenderTree/chromium/TestShell.h:
1227         * DumpRenderTree/chromium/WebPermissions.h: Added.
1228         (WebPermissions::WebPermissions):
1229         (WebPermissions::allowStorage):
1230         (WebPermissions::setStorageAllowed):
1231         (WebPermissions::reset):
1232
1233 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1234
1235         Reviewed by Eric Seidel.
1236
1237         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
1238         https://bugs.webkit.org/show_bug.cgi?id=60326
1239
1240         This patch removes a lot of the complexity from the
1241         metered_stream implementation that was unnecessary since there
1242         was only one caller and the logic could be coordinated better.
1243
1244         There should be no functional changes in this patch, just code
1245         getting deleted and cleaned up.
1246
1247         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1248         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
1249         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1250         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1251
1252 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1253
1254         Reviewed by Eric Seidel.
1255
1256         NRWT: minor cleanup in printing module
1257         https://bugs.webkit.org/show_bug.cgi?id=60329
1258
1259         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1260
1261 2011-05-27  Steve Lacey  <sjl@chromium.org>
1262
1263         Reviewed by David Levin.
1264
1265         Add sjl@chromium.org as a committer.
1266
1267         https://bugs.webkit.org/show_bug.cgi?id=61672
1268
1269         * Scripts/webkitpy/common/config/committers.py:
1270
1271 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1272
1273         Reviewed by Adam Barth.
1274
1275         NRWT: remove --print detailed-progress
1276         https://bugs.webkit.org/show_bug.cgi?id=60324
1277
1278         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1279         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1280         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1281         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1282
1283 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1284
1285         Reviewed by Ojan Vafai.
1286
1287         NRWT: debug messages from the workers are being logged twice
1288         https://bugs.webkit.org/show_bug.cgi?id=60428
1289
1290         It looks like when the workers are run in separate processes
1291         we end up getting two copies of every log message they print.
1292         This has to do with the multiprocessing module on UNIX cloning
1293         the log configuration in a way I wasn't expecting, and so two
1294         log handlers end up getting registered.
1295
1296         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1297         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1298         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1299         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1300
1301 2011-05-27  Adam Roben  <aroben@apple.com>
1302
1303         Always decode tester names from location.hash
1304
1305         When navigating directly to a tester-specific URL (e.g.,
1306         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
1307         with a URL-encoded tester name in the page, and then the encoded name could make its way
1308         into Bugzilla bugs. Bad!
1309
1310         Reviewed by David Kilzer.
1311
1312         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1313         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
1314         decodeURIComponent before trying to use it.
1315
1316 2011-05-27  Adam Roben  <aroben@apple.com>
1317
1318         Remove testing code that snuck into r87528
1319
1320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1321         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
1322
1323 2011-05-27  Adam Roben  <aroben@apple.com>
1324
1325         Add links to TestFailures to easily file bugs about failing tests
1326
1327         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
1328         links to file bugs for failing tests
1329
1330         Reviewed by David Kilzer.
1331
1332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1333         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
1334         for a particular build.
1335         (Builder.prototype._getFailingTests): Use resultsPageURL.
1336
1337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1338         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
1339         failures.
1340         (ViewController.prototype._domForBuildName): Use resultsPageURL.
1341         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
1342         new bug link. The bug has a title, description, and URL already filled in for you!
1343
1344 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1345
1346         Unreviewed, rolling out r87464.
1347         http://trac.webkit.org/changeset/87464
1348         https://bugs.webkit.org/show_bug.cgi?id=61643
1349
1350         client-close/server-close tests are flaky on Chromium Mac and
1351         Windows (Requested by aklein on #webkit).
1352
1353         * Scripts/webkitpy/thirdparty/__init__.py:
1354
1355 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
1356
1357         Added Douglas Davidson to contributors list for easier CC'ing.
1358
1359         * Scripts/webkitpy/common/config/committers.py:
1360
1361 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1362
1363         Reviewed by Adam Barth.
1364
1365         Fix worldID and destinationDomain argument names
1366         https://bugs.webkit.org/show_bug.cgi?id=61571
1367
1368         As part of working on r87423, I noticed a couple of inconsistencies in
1369         argument names:
1370         - We would use worldId in .h files but worldID in .cpp files.
1371           Standardize on the latter
1372         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
1373           destinationDomains argument, even though the actual parameter was for
1374           a single domain (renamed to be singular).
1375
1376         * DumpRenderTree/LayoutTestController.h:
1377         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1378         (LayoutTestController::evaluateScriptInIsolatedWorld):
1379
1380 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
1381
1382         Reviewed by Kent Tamura.
1383
1384         WebSocket closing handshake
1385         https://bugs.webkit.org/show_bug.cgi?id=35721
1386
1387         * Scripts/webkitpy/thirdparty/__init__.py:
1388         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1389         to get the right behavior of closing handshake.
1390
1391 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
1392
1393         Reviewed by Andreas Kling.
1394
1395         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
1396         https://bugs.webkit.org/show_bug.cgi?id=42676
1397
1398         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
1399
1400         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1401         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1402         (WTR::InjectedBundle::beginTesting):
1403         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1404         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
1405         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1406
1407 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1408
1409         Reviewed by Andreas Kling.
1410
1411         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
1412         https://bugs.webkit.org/show_bug.cgi?id=61527
1413
1414         The setMaximumHeight() call is unecessary and breaks the dialog at
1415         least on my setup.
1416
1417         * QtTestBrowser/launcherwindow.cpp:
1418         (LauncherWindow::showUserAgentDialog):
1419
1420 2011-05-02  Robert Hogan  <robert@webkit.org>
1421
1422         Reviewed by Adam Roben.
1423
1424         [Qt] Allow popup windows from plugins when initiated by a user gesture
1425
1426         https://bugs.webkit.org/show_bug.cgi?id=41292
1427
1428         Support parameters introduced in plugin-initiate-popup-window.html
1429
1430         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1431         (webkit_test_plugin_new_instance):
1432         (webkit_test_plugin_handle_event):
1433
1434 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1435
1436         Reviewed by Adam Barth.
1437
1438         Support cross-origin XMLHttpRequest in isolated worlds
1439         https://bugs.webkit.org/show_bug.cgi?id=59843
1440
1441         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
1442
1443         * DumpRenderTree/chromium/LayoutTestController.cpp:
1444         (LayoutTestController::LayoutTestController):
1445         (LayoutTestController::setIsolatedWorldSecurityOrigin):
1446         * DumpRenderTree/chromium/LayoutTestController.h:
1447
1448 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
1449
1450         Reviewed by Adam Roben.
1451
1452         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
1453         https://bugs.webkit.org/show_bug.cgi?id=61474
1454         <rdar://problem/9468337>
1455
1456         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1457         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
1458
1459 2011-05-26  Andreas Kling  <kling@webkit.org>
1460
1461         Unreviewed, correct address to webkit-committers mailing list.
1462
1463         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1464
1465 2011-05-25  Adam Roben  <aroben@apple.com>
1466
1467         Don't assume that builds finish in the order they were started
1468
1469         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
1470         build when one slave is taking a long time to finish a build
1471
1472         Reviewed by Antti Koivisto.
1473
1474         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1475         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
1476         newer than the oldest in-progress build are also themselves in progress. Just check whether
1477         each build is actually in progress (as signified by its presence in the currentBuilds set).
1478
1479 2011-05-25  Adam Roben  <aroben@apple.com>
1480
1481         Correctly detect cases where only a single test failed/crashed/timed out
1482
1483         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
1484         failing test
1485
1486         Reviewed by Darin Adler.
1487
1488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1489         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
1490         will be singular when only a single test fails/crashes/times out.
1491
1492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1493         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
1494         failed/crashed/timed out.
1495
1496 2011-05-26  Tom Hudson  <tomhudson@google.com>
1497
1498         Reviewed by Tony Chang.
1499
1500         Add flags to Chromium ImageDiff to write image comparison metrics on
1501         stdout.
1502         https://bugs.webkit.org/show_bug.cgi?id=60569
1503
1504         * DumpRenderTree/chromium/ImageDiff.cpp:
1505         (Image::createFromStdin): Fix spelling.
1506         (maxOf3): New function to do 3-way maximum.
1507         (getRedComponent): Extract red component from ABGR packed encoding.
1508         (getGreenComponent): Extract green component from ABGR packed encoding.
1509         (getBlueComponent): Extract blue component from ABGR packed encoding.
1510         (weightedPercentageDifferent): Determine % of pixels different in two
1511         images multiplied by intensity difference of each pixel.
1512         (printHelp): Document new arguments.
1513         (compareImages): Parameterize.
1514         (untestedCompareImages): Parameterize.
1515         (diffImages): Parameterize; write results on stdout if requested.
1516         (main): Parse new arguments.
1517
1518 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1519
1520         Reviewed by Simon Hausmann.
1521
1522         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
1523         https://bugs.webkit.org/show_bug.cgi?id=42697
1524
1525         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
1526
1527         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1528         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1529         (WTR::InjectedBundle::beginTesting):
1530         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1531         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
1532         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1533
1534 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
1535
1536         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
1537         https://bugs.webkit.org/show_bug.cgi?id=61428
1538         <rdar://problem/9457006>
1539
1540         Reviewed by Adam Roben.
1541
1542         The crash occurs when Flash posts a message to a window that it
1543         creates, and in processing the message, it calls NPN_Evaluate to
1544         evaluate JavaScript that removes the plug-in from the page. Flash then
1545         crashes when we return to Flash code.
1546
1547         This test emulates that behavior.
1548
1549         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
1550         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
1551         Initialize member vars.
1552         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
1553         Remove our custom property from the message window, and destroy it.
1554         (CallJSThatDestroysPlugin::NPP_Destroy):
1555         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
1556         layout test controller that we're done.
1557         (wndProc):
1558         Get the PluginTest object, and call its runTest() function.
1559         (CallJSThatDestroysPlugin::NPP_New):
1560         Setup the test: register a class for the message-only window, create
1561         it, and post a message to it to run the test.
1562         (CallJSThatDestroysPlugin::runTest):
1563         Execute JS that removes the plug-in from the page, and if we're not
1564         destroyed, log a success message.
1565
1566         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1567         Add new test to project.
1568
1569 2011-05-25  Tony Chang  <tony@chromium.org>
1570
1571         Reviewed by Adam Barth.
1572
1573         webkitpy's NetworkTransaction shouldn't use mechanize
1574         https://bugs.webkit.org/show_bug.cgi?id=61450
1575
1576         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
1577         use urllib2 directly.  Re-add NetworkTransaction to
1578         test_results_uploader.py (reverting r87124).
1579
1580         * Scripts/webkitpy/common/net/networktransaction.py:
1581         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1582
1583 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1584
1585         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
1586         until the port begins using those export macros.
1587
1588         * DumpRenderTree/chromium/config.h:
1589
1590 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1591
1592         Unreviewed, rolling out r87257.
1593         http://trac.webkit.org/changeset/87257
1594         https://bugs.webkit.org/show_bug.cgi?id=61457
1595
1596         This broke layout tests, see bug 61431. (Requested by
1597         hwennborg on #webkit).
1598
1599         * DumpRenderTree/chromium/LayoutTestController.cpp:
1600         (LayoutTestController::LayoutTestController):
1601         (LayoutTestController::clearAllDatabases):
1602         * DumpRenderTree/chromium/LayoutTestController.h:
1603
1604 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1605
1606         Reviewed by Andreas Kling.
1607
1608         [Qt] fast/css/disabled-author-styles.html failed
1609         https://bugs.webkit.org/show_bug.cgi?id=61438
1610
1611         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
1612
1613         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1614         (WebCore::WebPage::resetSettings):
1615         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1616         (LayoutTestController::setAuthorAndUserStylesEnabled):
1617         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1618
1619 2011-05-25  Adam Roben  <aroben@apple.com>
1620
1621         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
1622
1623         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
1624         started exiting early due to too many crashes, timeouts, or failures
1625
1626         Reviewed by David Kilzer.
1627
1628         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1629         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
1630         run-webkit-tests exits early due to too many failures, pass that information in another
1631         argument to the callback.
1632         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
1633         the new structure of the object passed to the callback.
1634         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
1635         getNumberOfFailingTests and to pass that along to our own callbacks.
1636         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
1637         from _getFailingTests and to store that value in the history object.
1638
1639         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1640         (.info): Added.
1641
1642         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1643         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
1644         object and to add a note when run-webkit-tests exited early due to too many failures.
1645         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
1646         latestBuildInfos since each entry now contains more than just the tester and failure count.
1647         Now displays a message for testers where the latest build exited early due to too many
1648         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
1649         store that value in latestBuildInfos.
1650
1651 2011-05-24  Keishi Hattori  <keishi@webkit.org>
1652
1653         Reviewed by Kent Tamura.
1654
1655         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
1656         https://bugs.webkit.org/show_bug.cgi?id=61273
1657
1658         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
1659
1660 2011-05-24  Greg Simon  <gregsimon@chromium.org>
1661
1662         Reviewed by Dimitri Glazkov.
1663
1664         Control Indexeddb backends from LayoutTestController
1665         https://bugs.webkit.org/show_bug.cgi?id=61000
1666
1667         * DumpRenderTree/chromium/LayoutTestController.cpp:
1668         (LayoutTestController::LayoutTestController):
1669         (LayoutTestController::setOverrideIndexedDBBackingStore):
1670         (LayoutTestController::clearAllDatabases):
1671         * DumpRenderTree/chromium/LayoutTestController.h:
1672
1673 2011-05-24  Robert Hogan  <robert@webkit.org>
1674
1675         Reviewed by Ryosuke Niwa.
1676
1677         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
1678         https://bugs.webkit.org/show_bug.cgi?id=61393
1679
1680         * DumpRenderTree/qt/EventSenderQt.h:
1681         * DumpRenderTree/qt/EventSenderQt.cpp:
1682         (getModifiers): static function for interpreting modifiers
1683         (EventSender::mouseDown): Respect keyboard modifiers
1684         (EventSender::keyDown): use new static function
1685         (EventSender::sendOrQueueEvent): whitespace fix
1686
1687 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
1688
1689         Reviewed by Adam Barth.
1690
1691         Adding MHTML reading support.
1692         https://bugs.webkit.org/show_bug.cgi?id=7168
1693
1694         * Scripts/build-webkit:
1695         * Scripts/old-run-webkit-tests:
1696         * Scripts/webkitperl/features.pm:
1697         * Scripts/webkitpy/layout_tests/port/test_files.py:
1698         * Scripts/webkitpy/layout_tests/port/webkit.py:
1699
1700 2011-05-24  Stephen White  <senorblanco@chromium.org>
1701
1702         Reviewed by Kenneth Russell.
1703
1704         Remove most style checks on Source/ThirdParty/glu, since it doesn't
1705         follow WebKit style.
1706         https://bugs.webkit.org/show_bug.cgi?id=61365
1707
1708         * Scripts/webkitpy/style/checker.py:
1709
1710 2011-05-24  Adam Roben  <aroben@apple.com>
1711
1712         Don't allow forcing builds through the build.webkit.org web interface
1713
1714         Someone has been forcing bogus builds.
1715
1716         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1717
1718 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
1719
1720         Reviewed by Adam Roben.
1721
1722         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1723         https://bugs.webkit.org/show_bug.cgi?id=42669
1724
1725         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
1726         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
1727         Because that case changed the setting.
1728
1729         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1730         (WTR::InjectedBundle::beginTesting):
1731
1732 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1733
1734         Reviewed by Kenneth Rohde Christiansen.
1735
1736         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
1737         https://bugs.webkit.org/show_bug.cgi?id=61052
1738
1739         * Scripts/old-run-webkit-tests:
1740
1741 2011-05-24  Adam Roben  <aroben@apple.com>
1742
1743         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
1744
1745         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
1746         that don't have any failing tests, which isn't useful
1747
1748         Reviewed by David Kilzer.
1749
1750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
1751         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
1752         instead of name strings.
1753         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
1754         builder names into an array of builders.
1755
1756         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1757         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
1758         the most recently completed build, or -1 if there is no such build.
1759         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
1760         in the given build, or -1 if the number could not be determined. Some of this code came from
1761         _getFailingTests.
1762         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
1763         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
1764         getNumberOfFailingTests functions.
1765
1766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1767         (ViewController.prototype._displayTesters): Get the current number of test failures for each
1768         tester and show it in the list. Omit testers that have no failures at all. We keep the
1769         testers and failure counts in an array and sort it before displaying the current data, as
1770         the order in which data will be fetched is unpredictable.
1771
1772 2011-05-23  Tony Chang  <tony@chromium.org>
1773
1774         Reviewed by Ojan Vafai.
1775
1776         [nrwt] don't use NetworkTranslation when uploading results
1777         https://bugs.webkit.org/show_bug.cgi?id=61315
1778
1779         This avoids autoinstalling mechanize.  It didn't matter anyway
1780         because test_results_uploader.py wasn't using mechanize to make the
1781         request so NetworkTransaction::run wasn't doing anything extra
1782         (it only matters if it catches mechanize.HTTPError).
1783
1784         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1785
1786 2011-05-23  Tony Chang  <tony@chromium.org>
1787
1788         Reviewed by Dirk Pranke.
1789
1790         [chromium] fix the rebaseline tool to work with Linux GPU failures
1791         https://bugs.webkit.org/show_bug.cgi?id=61312
1792
1793         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1794
1795 2011-05-23  Darin Adler  <darin@apple.com>
1796
1797         Ignore generated .pyc files in a directory full of python code.
1798
1799         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
1800
1801 2011-05-23  Adam Barth  <abarth@webkit.org>
1802
1803         Reviewed by Eric Seidel.
1804
1805         sheriffbot should give more details about the failures in IRC
1806         https://bugs.webkit.org/show_bug.cgi?id=61233
1807
1808         With this patch, sheriffbot will annonce the set of failing tests,
1809         which might help folks triage the problem.
1810
1811         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1812         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1813
1814 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1815
1816         Unreviewed, rolling out r87078.
1817         http://trac.webkit.org/changeset/87078
1818         https://bugs.webkit.org/show_bug.cgi?id=61294
1819
1820         Patch contains errors and seems likely to break a bunch of
1821         bots (Requested by abarth on #webkit).
1822
1823         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1824         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1825         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1826
1827 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
1828
1829         Reviewed by Ojan Vafai.
1830
1831         Convert json_results_generator.py to output version 4 JSON.
1832         https://bugs.webkit.org/show_bug.cgi?id=60869
1833
1834         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1835         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1836         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1837
1838 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
1839
1840         Reviewed by Adam Barth.
1841
1842         Move generation of shell_command from port to executive
1843         https://bugs.webkit.org/show_bug.cgi?id=61251
1844
1845         After move it's possible to use the code in other places too.
1846
1847         * Scripts/webkitpy/common/config/ports.py:
1848         * Scripts/webkitpy/common/system/executive.py:
1849
1850 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
1851
1852         Reviewed by Darin Adler.
1853
1854         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1855         https://bugs.webkit.org/show_bug.cgi?id=42669
1856
1857         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
1858
1859         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1860         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1861         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
1862         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1863
1864 2011-05-22  Robert Hogan  <robert@webkit.org>
1865
1866         Reviewed by Kenneth Rohde Christiansen.
1867
1868         Fix policyDelegate in Qt DRT
1869         https://bugs.webkit.org/show_bug.cgi?id=61247
1870
1871         Use the 'policy delegate' implemented in FrameLoaderClient
1872         for layout tests. The partial implementation in DumpRenderTreeQt
1873         is redundant, so remove it.
1874
1875         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1876         (WebCore::WebPage::acceptNavigationRequest):
1877         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1878         (LayoutTestController::waitForPolicyDelegate):
1879
1880 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
1881
1882         Reviewed by Darin Adler.
1883
1884         Use double quotes for filename arguments
1885         https://bugs.webkit.org/show_bug.cgi?id=61250
1886
1887         Windows does not support single quotes on the command line,
1888         so replace them with double quotes.
1889
1890         * Scripts/prepare-ChangeLog:
1891
1892 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
1893
1894         Reviewed by Sam Weinig.
1895
1896         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
1897         https://bugs.webkit.org/show_bug.cgi?id=42550
1898         
1899         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
1900
1901         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1902         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1903         Copy the code for pausing animations, FIXME comments and all.
1904         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1905         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1906
1907 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
1908
1909         Reviewed by Stephen White.
1910
1911         Adding myself to the committers list.
1912
1913         * Scripts/webkitpy/common/config/committers.py:
1914
1915 2011-05-19  Adam Roben  <aroben@apple.com>
1916
1917         Test that the WebKit2 UI process doesn't crash when starting a download
1918
1919         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
1920         (preceded by assertion) in fastMalloc when downloading a file
1921
1922         Reviewed by Darin Adler.
1923
1924         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
1925
1926         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
1927         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
1928         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
1929         started, cancel the download, and return a bogus string.
1930
1931         (TestWebKitAPI::setContextDownloadClient):
1932         (TestWebKitAPI::setPagePolicyClient):
1933         Simple helper functions.
1934
1935         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
1936         our policy client, and run until we know that the download was started. If we haven't
1937         crashed, we win!
1938
1939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1940         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1941         * TestWebKitAPI/win/copy-resources.cmd:
1942         Added new files.
1943
1944 2011-05-20  Kent Tamura  <tkent@chromium.org>
1945
1946         Reviewed by Ryosuke Niwa.
1947
1948         Fix style errors in DumpRenderTree/chromium/.
1949         https://bugs.webkit.org/show_bug.cgi?id=61172
1950
1951         * DumpRenderTree/chromium/CppBoundClass.cpp:
1952         (CppBoundClass::getAsCppVariant):
1953         (CppBoundClass::bindToJavascript):
1954         * DumpRenderTree/chromium/CppBoundClass.h:
1955         (CppBoundClass::GetterCallback::~GetterCallback):
1956         (CppBoundClass::CppBoundClass):
1957         (CppBoundClass::Callback::~Callback):
1958         (CppBoundClass::MemberCallback::MemberCallback):
1959         (CppBoundClass::MemberCallback::~MemberCallback):
1960         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
1961         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
1962         * DumpRenderTree/chromium/CppVariant.h:
1963         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1964         (DRTDevToolsAgent::~DRTDevToolsAgent):
1965         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1966         (DRTDevToolsClient::sendFrontendLoaded):
1967         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1968         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1969         (main):
1970         * DumpRenderTree/chromium/EventSender.cpp:
1971         (SavedEvent::SavedEvent):
1972         (EventSender::EventSender):
1973         (EventSender::keyDown):
1974         * DumpRenderTree/chromium/EventSender.h:
1975         * DumpRenderTree/chromium/ImageDiff.cpp:
1976         (Image::Image):
1977         * DumpRenderTree/chromium/LayoutTestController.cpp:
1978         (LayoutTestController::LayoutTestController):
1979         (LayoutTestController::WorkQueue::reset):
1980         (WorkItemBackForward::WorkItemBackForward):
1981         (WorkItemLoadingScript::WorkItemLoadingScript):
1982         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
1983         (WorkItemLoad::WorkItemLoad):
1984         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1985         (LayoutTestController::pathToLocalResource):
1986         * DumpRenderTree/chromium/LayoutTestController.h:
1987         (LayoutTestController::WorkItem::~WorkItem):
1988         (LayoutTestController::WorkQueue::WorkQueue):
1989         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1990         (MockSpellCheck::MockSpellCheck):
1991         (MockSpellCheck::~MockSpellCheck):
1992         * DumpRenderTree/chromium/MockSpellCheck.h:
1993         * DumpRenderTree/chromium/NotificationPresenter.h:
1994         (NotificationPresenter::NotificationPresenter):
1995         * DumpRenderTree/chromium/Task.cpp:
1996         (WebTask::WebTask):
1997         * DumpRenderTree/chromium/Task.h:
1998         (TaskList::TaskList):
1999         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2000         (DRTPrinter::DRTPrinter):
2001         (TestShellPrinter::TestShellPrinter):
2002         * DumpRenderTree/chromium/TestNavigationController.cpp:
2003         (TestNavigationEntry::TestNavigationEntry):
2004         (TestNavigationEntry::~TestNavigationEntry):
2005         (TestNavigationController::TestNavigationController):
2006         (TestNavigationController::reload):
2007         (TestNavigationController::loadEntry):
2008         (TestNavigationController::didNavigateToEntry):
2009         * DumpRenderTree/chromium/TestNavigationController.h:
2010         (TestShellExtraData::TestShellExtraData):
2011         * DumpRenderTree/chromium/TestShell.cpp:
2012         (dumpHistoryItem):
2013         * DumpRenderTree/chromium/TestShell.h:
2014         (TestParams::TestParams):
2015         * DumpRenderTree/chromium/TestShellWin.cpp:
2016         (TestShell::waitTestFinished):
2017         * DumpRenderTree/chromium/TestWebWorker.h:
2018         (TestWebWorker::startWorkerContext):
2019         (TestWebWorker::terminateWorkerContext):
2020         (TestWebWorker::postMessageToWorkerContext):
2021         (TestWebWorker::clientDestroyed):
2022         (TestWebWorker::postMessageToWorkerObject):
2023         (TestWebWorker::postExceptionToWorkerObject):
2024         (TestWebWorker::postConsoleMessageToWorkerObject):
2025         (TestWebWorker::confirmMessageFromWorkerObject):
2026         (TestWebWorker::reportPendingActivity):
2027         (TestWebWorker::workerContextClosed):
2028         (TestWebWorker::~TestWebWorker):
2029         * DumpRenderTree/chromium/TextInputController.cpp:
2030         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2031         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2032         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2033         (WebThemeEngineDRTWin::paintButton):
2034         (WebThemeEngineDRTWin::paintMenuList):
2035         (WebThemeEngineDRTWin::paintTrackbar):
2036         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2037         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2038         * DumpRenderTree/chromium/WebViewHost.cpp:
2039         (WebViewHost::navigate):
2040         (WebViewHost::updateSessionHistory):
2041         (WebViewHost::paintInvalidatedRegion):
2042         * DumpRenderTree/chromium/WebViewHost.h:
2043
2044 2011-05-19  Dmitry Lomov  <dslomov@google.com>
2045
2046         Reviewed by Adam Roben.
2047
2048         Detect hangs in run-api-tests
2049         https://bugs.webkit.org/show_bug.cgi?id=48043
2050
2051         * Scripts/run-api-tests: Added test timeouts
2052
2053 2011-05-19  Dmitry Lomov  <dslomov@google.com>
2054
2055         Reviewed by Adam Roben.
2056
2057         run-api-tests should run one test per process
2058         https://bugs.webkit.org/show_bug.cgi?id=61088
2059
2060         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
2061         return code, and parsing GTest output format.
2062
2063 2011-05-15  Robert Hogan  <robert@webkit.org>
2064
2065         Reviewed by Antonio Gomes.
2066
2067         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
2068         https://bugs.webkit.org/show_bug.cgi?id=60834
2069         Fix unix test plugin for plugins/get-url-with-javascript-url.html
2070
2071         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2072         (webkit_test_plugin_new_stream):
2073         (webkit_test_plugin_write_ready):
2074         (webkit_test_plugin_write):
2075
2076 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2077
2078         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
2079         http://trac.webkit.org/changeset/86869
2080         http://trac.webkit.org/changeset/86873
2081         http://trac.webkit.org/changeset/86875
2082         http://trac.webkit.org/changeset/86877
2083         https://bugs.webkit.org/show_bug.cgi?id=61139
2084
2085         broke builds and debug DRT (Requested by rniwa on #webkit).
2086
2087         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2088         * DumpRenderTree/chromium/TestShell.cpp:
2089         (TestShell::bindJSObjectsToWindow):
2090         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2091         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2092
2093 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
2094
2095         Reviewed by Darin Adler.
2096
2097         Add build logistics and plumbing for window.internals object.
2098         https://bugs.webkit.org/show_bug.cgi?id=60313
2099
2100         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2101         * DumpRenderTree/chromium/TestShell.cpp:
2102         (TestShell::bindJSObjectsToWindow): Added injection code.
2103         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2104         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2105
2106 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2107
2108         Reviewed by Csaba Osztrogonác.
2109
2110         [Qt] Implement eventSender.scalePageBy
2111         https://bugs.webkit.org/show_bug.cgi?id=60015
2112
2113         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2114         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2115         * DumpRenderTree/qt/EventSenderQt.cpp:
2116         (EventSender::scalePageBy):
2117         * DumpRenderTree/qt/EventSenderQt.h:
2118
2119 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
2120
2121         Reviewed by Kent Tamura.
2122
2123         [Chromium] IME candidate window appears wrong position in an iframe
2124         https://bugs.webkit.org/show_bug.cgi?id=61023
2125
2126         Call the focused frame's firstRectForCharacterRange() instead of the
2127         main frame so that DRT behaves as the same as Chromium.
2128
2129         * DumpRenderTree/chromium/TextInputController.cpp:
2130         (TextInputController::firstRectForCharacterRange):
2131
2132 2011-05-18  Adam Roben  <aroben@apple.com>
2133
2134         Add a new page to build.webkit.org to help find when tests started failing
2135
2136         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
2137         right now, but already shows some useful information. It's somewhat similar to webkit-patch
2138         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
2139         little more convenient than either of them, though, because it's all done in the browser
2140         (and thus it's easy to go directly to the relevant test results).
2141
2142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
2143         (Buildbot): This class represents a Buildbot server.
2144         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
2145         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
2146         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
2147         callback.
2148         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
2149         be implemented by a derived class that understands this server's build naming scheme.
2150         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2151         particular build.
2152
2153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
2154         (Builder): This class represents one builder on the buildbot.
2155         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
2156         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
2157         information about a particular test failure.
2158         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
2159         information about when tests started failing.
2160         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2161         particular build.
2162         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
2163         callback.
2164         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
2165         extracts all the failing tests listed in it, passing them to the callback.
2166         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
2167         build, merges them into the build history, and calls the callback telling it whether the
2168         next build should be fetched to provide more information.
2169
2170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2171         Added. Just some simple styles.
2172
2173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
2174         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
2175         (getResource): Wrapper around XMLHttpRequest.
2176         (Array.prototype.findFirst): Finds the first element matching the given predicate and
2177         returns it.
2178         (Array.prototype.last): Returns the last element of the array.
2179
2180         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
2181         (ViewController): This class contains the main logic for displaying the page.
2182         (ViewController.loaded): Just calls through to parseHash.
2183         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
2184         shows the list of all testers so one can be chosen. This function is called when the page
2185         loads and whenever we get a hashchange event.
2186         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
2187         as it is fetched. The display ends up grouping tests by when they started failing.
2188         (ViewController._displayTesters): Gets the list of testers and displays it.
2189
2190         (ViewController._domForBuildName):
2191         (ViewController._domForFailedTest):
2192         Helper functions to create descriptions and links for a particular build or failed test.
2193
2194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
2195         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
2196         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
2197
2198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
2199         loads all the files and sets up a ViewController, which does the rest.
2200
2201         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
2202         page.
2203
2204 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2205
2206         Reviewed by Csaba Osztrogonác.
2207
2208         [Qt] Implement layoutTestController.setValueForUser()
2209         https://bugs.webkit.org/show_bug.cgi?id=60956
2210
2211         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2212         (LayoutTestController::setValueForUser):
2213         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2214
2215 2011-05-16  Robert Hogan  <robert@webkit.org>
2216
2217         Reviewed by Kenneth Rohde Christiansen.
2218
2219         plugins/invalidate_rect.html fails on linux ports
2220
2221         - Make the unix test netscape plugin recognize the onPaintEvent
2222           and windowedPlugin parameters.
2223
2224         https://bugs.webkit.org/show_bug.cgi?id=54051
2225
2226         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2227         (handleEventX11):
2228         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2229         (LayoutTestController::displayInvalidatedRegion):
2230         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2231         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2232         (webkit_test_plugin_new_instance):
2233         (webkit_test_plugin_handle_event):
2234
2235 2011-05-17  Tony Chang  <tony@chromium.org>
2236
2237         Reviewed by Ojan Vafai.
2238
2239         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
2240         https://bugs.webkit.org/show_bug.cgi?id=60895
2241
2242         Update the tools to handle the move.  Lucid 32 results now go in
2243         chromium-linux-x86 and the default platform on Linux is now x86_64.
2244
2245         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
2246         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2247         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
2248         * Scripts/webkitpy/layout_tests/port/base.py: ditto
2249         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
2250         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2251         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
2252         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
2253         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
2254
2255 2011-05-17  Adam Roben  <aroben@apple.com>
2256
2257         Make run-api-tests work on Windows when there are spaces in the path
2258
2259         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
2260         spaces in the path to TestWebKitAPI.exe
2261
2262         Reviewed by David Levin.
2263
2264         * Scripts/run-api-tests:
2265         (runTestTool): Use the "direct object" form of system() to avoid having the path to
2266         TestWebKitAPI.exe be split by the shell.
2267
2268 2011-05-16  Ian Henderson  <ianh@apple.com>
2269
2270         Reviewed by Joseph Pecoraro.
2271
2272         Page::goToItem doesn't work while loading is deferred
2273         https://bugs.webkit.org/show_bug.cgi?id=60412
2274
2275         Add setDefersLoading and goBack methods to LayoutTestController.  We
2276         need to use goBack() instead of history.back() because the latter goes
2277         through NavigationScheduler, hence doesn't exhibit the bug.
2278
2279         * DumpRenderTree/LayoutTestController.cpp:
2280         (goBackCallback):
2281         (setDefersLoadingCallback):
2282         (LayoutTestController::staticFunctions):
2283         * DumpRenderTree/LayoutTestController.h:
2284         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2285         (LayoutTestController::goBack):
2286         (LayoutTestController::setDefersLoading):
2287         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2288         (LayoutTestController::goBack):
2289         (LayoutTestController::setDefersLoading):
2290         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2291         (LayoutTestController::goBack):
2292         (LayoutTestController::setDefersLoading):
2293         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2294         (LayoutTestController::goBack):
2295         (LayoutTestController::setDefersLoading):
2296
2297 2011-05-16  Sam Weinig  <sam@webkit.org>
2298
2299         Reviewed by Anders Carlsson.
2300
2301         TestWebKitAPI should build with clang if it can
2302         https://bugs.webkit.org/show_bug.cgi?id=60918
2303
2304         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2305         Update CompilerVersion.xcconfig to match others.
2306
2307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2308         Add CompilerVersion.xcconfig to the project.
2309
2310         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2311         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2312         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2313         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2314         Add some casts to quiet warnings from clang.
2315
2316 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
2317
2318         Reviewed by David Levin.
2319
2320         add dpranke as a reviewer
2321         https://bugs.webkit.org/show_bug.cgi?id=60919
2322
2323         * Scripts/webkitpy/common/config/committers.py:
2324
2325 2011-05-16  Robert Hogan  <robert@webkit.org>
2326
2327         Reviewed by Anders Carlsson.
2328
2329         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
2330
2331         https://bugs.webkit.org/show_bug.cgi?id=60838
2332
2333         The unix test plugin needs to call the test's NPP_URLNotify
2334         rather than the browsers.
2335
2336         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2337         (webkit_test_plugin_url_notify):
2338
2339 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
2340
2341         Rubber-stamped by Adam Roben.
2342
2343         Adding myself as a reviewer.
2344         * Scripts/webkitpy/common/config/committers.py:
2345
2346 2011-05-16  Sam Weinig  <sam@webkit.org>
2347
2348         Fix typo pointed out by Dave Levin.
2349
2350         * TestWebKitAPI/PlatformUtilities.h:
2351         (TestWebKitAPI::Util::assertWKStringEqual):
2352         Strig -> String.
2353
2354 2011-05-16  Sam Weinig  <sam@webkit.org>
2355
2356         Reviewed by David Levin.
2357
2358         Convert api tester over to using gtest expectations directly
2359         https://bugs.webkit.org/show_bug.cgi?id=60862
2360
2361         * TestWebKitAPI/PlatformUtilities.cpp:
2362         (TestWebKitAPI::Util::toSTD):
2363         * TestWebKitAPI/PlatformUtilities.h:
2364         (TestWebKitAPI::Util::assertWKStrigEqual):
2365         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
2366         the implementation of the macro simpler.
2367
2368         * TestWebKitAPI/Test.h:
2369         Remove TEST_ASSERT forwarder.
2370
2371         [Test changes elided]
2372
2373 2011-05-16  David Kilzer  <ddkilzer@apple.com>
2374
2375         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
2376         <rdar://problem/9446430>
2377
2378         Reviewed by Mark Rowe.
2379
2380         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
2381         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2382         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2383
2384 2011-05-16  Jon Lee  <jonlee@apple.com>
2385
2386         Reviewed by Simon Fraser.
2387
2388         Can't horizontally scroll iframes and overflow because wheel events are always accepted
2389         https://bugs.webkit.org/show_bug.cgi?id=60779
2390
2391         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2392         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
2393
2394 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2395
2396         Reviewed by Csaba Osztrogonác.
2397
2398         [Qt] Tools.pro misses include(common.pri)
2399         https://bugs.webkit.org/show_bug.cgi?id=60883
2400
2401         It includes features.pri, which depends on common.pri (the build is
2402         not broken today with the default options, but this is the right
2403         thing to do).
2404
2405         * Tools.pro:
2406
2407 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
2408
2409         Unreviewed: adding myself to committers.py.
2410
2411         * Scripts/webkitpy/common/config/committers.py:
2412
2413 2011-05-15  Daniel Bates  <dbates@webkit.org>
2414
2415         Reviewed by Chris Jerdonek.
2416
2417         svn-apply can't handle Git diff that only changes executable bit
2418         https://bugs.webkit.org/show_bug.cgi?id=60848
2419
2420         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
2421         that only has an executable bit change.
2422
2423         * Scripts/VCSUtils.pm:
2424           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
2425         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
2426         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
2427         * Scripts/svn-apply:
2428         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
2429         * Scripts/svn-unapply:
2430         (patch): Ditto.
2431         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2432           - Updated expected results for test cases to account for numTextChunks.
2433           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
2434           - Added test case "Git: file that only has an executable bit change".
2435         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2436           - Updated expected results for test cases to account for numTextChunks.
2437
2438 2011-05-15  Sam Weinig  <sam@webkit.org>
2439
2440         Fix windows build.
2441
2442         * TestWebKitAPI/win/main.cpp:
2443         (main):
2444
2445 2011-05-15  Sam Weinig  <sam@webkit.org>
2446
2447         Reviewed by David Levin.
2448
2449         Make API tester more gtest friendly
2450         https://bugs.webkit.org/show_bug.cgi?id=60859
2451
2452         * Scripts/run-api-tests:
2453         Numerous changes:
2454         - Remove logic to run tests one at a time.
2455         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
2456           the test runner and allow gtest to print it for us.
2457         - Forward stdout from the test tool to stdout, even in non-verbose runs.
2458         - Run test tool from the current working directory instead of the root webkit
2459           directory.
2460
2461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2462         Move plist to be with other bundle sources.
2463
2464         * TestWebKitAPI/TestsController.cpp:
2465         (TestWebKitAPI::TestsController::TestsController):
2466         (TestWebKitAPI::TestsController::run):
2467         * TestWebKitAPI/TestsController.h:
2468         * TestWebKitAPI/mac/main.mm:
2469         Simplify TestController down to a single run function. We should consider removing the class
2470         entirely at some point.
2471
2472 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2473
2474         Unreviewed, rolling out r86504.
2475         http://trac.webkit.org/changeset/86504
2476         https://bugs.webkit.org/show_bug.cgi?id=60853
2477
2478         "Broke Qt EventSender in editing/selection tests" (Requested
2479         by mwenge on #webkit).
2480
2481         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2482         (WebCore::WebPage::WebPage):
2483         (WebCore::DumpRenderTree::DumpRenderTree):
2484         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2485         (WebCore::DumpRenderTree::initJSObjects):
2486         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2487         (WebCore::DumpRenderTree::eventSender):
2488         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2489         (webkit_test_plugin_new_instance):
2490         (webkit_test_plugin_set_window):
2491         (webkit_test_plugin_handle_event):
2492
2493 2011-05-12  Robert Hogan  <robert@webkit.org>
2494
2495         Reviewed by Benjamin Poulain.
2496
2497         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2498
2499         The support for this test added to the unix test plugin here
2500         may allow other platforms to pass it (nearly everyone
2501         skips it). On Qt it required a bit of trickiness with
2502         the page's EventSender object to get it working fully though,
2503         so only unskipping Qt here.
2504
2505         https://bugs.webkit.org/show_bug.cgi?id=60722
2506
2507         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2508         (WebCore::WebPage::WebPage):
2509         (WebCore::WebPage::eventSender):
2510         (WebCore::DumpRenderTree::DumpRenderTree):
2511         (WebCore::DumpRenderTree::initJSObjects):
2512         (WebCore::DumpRenderTree::createWindow):
2513         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2514         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2515         (webkit_test_plugin_new_instance):
2516         (webkit_test_plugin_set_window):
2517         (webkit_test_plugin_handle_event):
2518
2519 2011-05-14  Arno Renevier  <arno@renevier.net>
2520
2521         Reviewed by Martin Robinson.
2522
2523         make run-gtk-tests executable
2524         https://bugs.webkit.org/show_bug.cgi?id=59278
2525
2526         * Scripts/run-gtk-tests:
2527
2528 2011-05-14  Anders Carlsson  <andersca@apple.com>
2529
2530         Reviewed by Kevin Decker.
2531
2532         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2533         https://bugs.webkit.org/show_bug.cgi?id=60823
2534         <rdar://problem/9430386>
2535
2536         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2537
2538         * DumpRenderTree/DumpRenderTree.gypi:
2539         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2540         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2541         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2542         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2543         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2544         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2545         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2546         * GNUmakefile.am:
2547
2548 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2549
2550         Unreviewed, rolling out r86476.
2551         http://trac.webkit.org/changeset/86476
2552         https://bugs.webkit.org/show_bug.cgi?id=60832
2553
2554         It made plugins/get-url-notify-with-url-that-fails-to-
2555         load.html crash on GTK (Requested by Ossy on #webkit).
2556
2557         * DumpRenderTree/DumpRenderTree.gypi:
2558         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2559         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
2560         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2561         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2562         * GNUmakefile.am:
2563
2564 2011-05-13  Anders Carlsson  <andersca@apple.com>
2565
2566         Reviewed by Sam Weinig.
2567
2568         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2569         https://bugs.webkit.org/show_bug.cgi?id=60823
2570         <rdar://problem/9430386>
2571
2572         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2573
2574         * DumpRenderTree/DumpRenderTree.gypi:
2575         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2576         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2577         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2578         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2579         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2580         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2581         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2582         * GNUmakefile.am:
2583
2584 2011-05-13  Anders Carlsson  <andersca@apple.com>
2585
2586         Build fix.
2587
2588         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
2589
2590 2011-05-13  Anders Carlsson  <andersca@apple.com>
2591
2592         Reviewed by Sam Weinig.
2593
2594         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
2595         https://bugs.webkit.org/show_bug.cgi?id=60810
2596
2597         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
2598
2599         * DumpRenderTree/DumpRenderTree.gypi:
2600         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2601         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2602         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2603         * GNUmakefile.am:
2604         Add files.
2605
2606         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2607         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2608         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
2609
2610         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
2611         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
2612         (GetURLWithJavaScriptURL::NPP_New):
2613         (GetURLWithJavaScriptURL::NPP_NewStream):
2614         (GetURLWithJavaScriptURL::NPP_DestroyStream):
2615         (GetURLWithJavaScriptURL::NPP_WriteReady):
2616         (GetURLWithJavaScriptURL::NPP_Write):
2617         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2618         (NPP_NewStream):
2619         (NPP_WriteReady):
2620         (NPP_Write):
2621         (NPP_URLNotify):
2622         call the PluginTest NPP wrappers.
2623
2624 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2625
2626         Unreviewed, rolling out r86447.
2627         http://trac.webkit.org/changeset/86447
2628         https://bugs.webkit.org/show_bug.cgi?id=60809
2629
2630         "Broke some uses of EventSender object on Qt" (Requested by
2631         mwenge on #webkit).
2632
2633         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2634         (WebCore::WebPage::WebPage):
2635         (WebCore::DumpRenderTree::DumpRenderTree):
2636         (WebCore::DumpRenderTree::initJSObjects):
2637         (WebCore::DumpRenderTree::createWindow):
2638         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2639         (WebCore::DumpRenderTree::eventSender):
2640         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2641         (webkit_test_plugin_new_instance):
2642         (webkit_test_plugin_set_window):
2643         (webkit_test_plugin_handle_event):
2644
2645 2011-05-13  Robert Hogan  <robert@webkit.org>
2646
2647         Reviewed by Benjamin Poulain.
2648
2649         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2650
2651         The support for this test added to the unix test plugin here
2652         may allow other platforms to pass it (nearly everyone
2653         skips it). On Qt it required a bit of trickiness with
2654         the page's EventSender object to get it working fully though,
2655         so only unskipping Qt here.
2656
2657         https://bugs.webkit.org/show_bug.cgi?id=60722
2658
2659         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2660         (WebCore::WebPage::WebPage):
2661         (WebCore::WebPage::eventSender):
2662         (WebCore::DumpRenderTree::DumpRenderTree):
2663         (WebCore::DumpRenderTree::initJSObjects):
2664         (WebCore::DumpRenderTree::createWindow):
2665         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2666         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2667         (webkit_test_plugin_new_instance):
2668         (webkit_test_plugin_set_window):
2669         (webkit_test_plugin_handle_event):
2670
2671 2011-05-13  Adam Roben  <aroben@apple.com>
2672
2673         Exclude the Leopard NRWT bot from the core builder set
2674
2675         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
2676
2677         Reviewed by Darin Adler.
2678
2679         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2680         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
2681         in the core builder set.
2682
2683         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2684         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
2685         regexps.
2686
2687 2011-05-13  Adam Roben  <aroben@apple.com>
2688
2689         Group all the NRWT bots together
2690
2691         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
2692         bots are experimental, it seems best not to clutter up the non-experimental bots with
2693         experimental ones.
2694
2695         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
2696         on build.webkit.org
2697
2698         Reviewed by Dan Bernstein.
2699
2700         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
2701         Chromium testers, which also use new-run-webkit-tests.
2702
2703 2011-05-13  Adam Roben  <aroben@apple.com>
2704
2705         Add a plugin test that dumps the plugin window's rect
2706
2707         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
2708         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
2709
2710         Reviewed by Dan Bernstein.
2711
2712         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
2713         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
2714         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
2715         harness window and log it.
2716
2717         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
2718
2719 2011-05-13  Adam Roben  <aroben@apple.com>
2720
2721         Move code required for most tests of plugin window geometry into a base class
2722
2723         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
2724         having all the trickiness in a shared base class, writing new window geometry tests will be
2725         much easier.
2726
2727         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
2728
2729         Reviewed by Anders Carlsson.
2730
2731         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2732         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
2733         WindowGeometryTest base class. Most of the code from this class was moved to the new base
2734         class.
2735         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
2736         This is called by the base class when it is safe to check the window's geometry. Note that
2737         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
2738         just vestigial code from an earlier version of this test.
2739
2740         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
2741         WindowGeometryTest class.
2742
2743         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
2744         WindowRegionIsSetToClipRect.
2745         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
2746         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
2747         Subclasses can implement that function to perform their own tests.
2748
2749         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
2750
2751 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
2752
2753         Reviewed by Csaba Osztrogonác.
2754
2755         Missing 2nd #EOF if WebProcess is killed.
2756         https://bugs.webkit.org/show_bug.cgi?id=60761
2757
2758         If the WebProcess is killed, only one #EOF is yielded
2759         by WebKitTestRunner. However, run-webkit-test wait for
2760         a second #EOF, which signals the finishing of pixel dump.
2761         Since this never happens, run-webkit-test waits forever.
2762
2763         * WebKitTestRunner/TestInvocation.cpp:
2764         (WTR::TestInvocation::dump):
2765         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2766         * WebKitTestRunner/TestInvocation.h:
2767
2768 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2769
2770         Reviewed by Csaba Osztrogonác.
2771
2772         [NRWT] chromium-linux tests shouldn't run on other platforms
2773         https://bugs.webkit.org/show_bug.cgi?id=60162
2774
2775         Remove _tests_for_other_platforms defs because r82753
2776         implemented it properly in the baseclass in webkit.py.
2777
2778         * Scripts/webkitpy/layout_tests/port/gtk.py:
2779         * Scripts/webkitpy/layout_tests/port/qt.py:
2780         * Scripts/webkitpy/layout_tests/port/win.py:
2781
2782 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
2783
2784         Reviewed by Antonio Gomes.
2785
2786         [EFL] Remove unused option of EWeblauncher
2787         https://bugs.webkit.org/show_bug.cgi?id=60747
2788
2789         Remove sudo-workaround option.
2790         This option is not used and make other option wrong.
2791
2792         * EWebLauncher/main.c:
2793
2794 2011-05-12  Lucas Forschler  <lforschler@apple.com>
2795
2796         Reviewed by Stephanie Lewis.
2797
2798         Fix config.json to address missing WK2 builder/tester config.
2799         Fix naming of machines (xserve not macpro)
2800
2801         * BuildSlaveSupport/build.webkit.org-config/config.json:
2802
2803 2011-05-12  Lucas Forschler  <lforschler@apple.com>
2804
2805         Reviewed by Stephanie Lewis.
2806
2807         Add SnowLeopard Debug builder and Test bot.
2808         apple-xserve-8 = SL Debug Tester.
2809         apple-xserve-9 = SL Debug Builder.
2810         
2811         * BuildSlaveSupport/build.webkit.org-config/config.json:
2812
2813 2011-05-12  Adam Barth  <abarth@webkit.org>
2814
2815         This patch disables sheriffbot's bug postings.  He's just been way too
2816         spammy recently due to test flakiness.
2817
2818         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2819         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2820
2821 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2822
2823         Reviewed by Anders Carlsson.
2824
2825         After relaunching an unresponsive web process, web page stops responding to mouse movement
2826         https://bugs.webkit.org/show_bug.cgi?id=60669
2827         <rdar://problem/9409934>
2828         
2829         This test follows the steps needed to reproduce this bug:
2830         1) Hang the web process
2831         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
2832         3) Kill and restart the WebProcess
2833         4) Move the mouse
2834         
2835         We are testing that we receive mouse move events after the WebProcess has restarted.
2836
2837         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
2838         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
2839         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
2840         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
2841         (TestWebKitAPI::setPageLoaderClient):
2842         (TestWebKitAPI::TEST):
2843         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
2844         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
2845         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
2846         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
2847
2848         * TestWebKitAPI/PlatformWebView.h:
2849         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2850         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
2851         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2852         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
2853
2854         Add new files.
2855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2856         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2857         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2858         * TestWebKitAPI/win/copy-resources.cmd:
2859
2860 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
2861
2862         Reviewed by Antonio Gomes.
2863
2864         [EFL] Added initialization/shutdown for ecore_file library
2865         https://bugs.webkit.org/show_bug.cgi?id=60457
2866
2867         Added initialization and shuthown for ecore_file library and replaced
2868         realpath function to ecore_file_realpath.
2869
2870         * EWebLauncher/main.c:
2871         (quit):
2872         (findThemePath):
2873         (main):
2874
2875 2011-05-12  Young Han Lee  <joybro@company100.net>
2876
2877         Reviewed by Kenneth Rohde Christiansen.
2878
2879         [Qt] Implement layoutTestController.layerTreeAsText()
2880         https://bugs.webkit.org/show_bug.cgi?id=60367
2881
2882         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2883         (LayoutTestController::layerTreeAsText):
2884         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2885
2886 2011-05-11  Eric Seidel  <eric@webkit.org>
2887
2888         Reviewed by David Levin.
2889
2890         Teach validate-committer-lists how to validate committers bugzilla_email()
2891         https://bugs.webkit.org/show_bug.cgi?id=60651
2892
2893         It turns out we currently have 9 committers with invalid values for their
2894         bugzilla_email field (meaning we don't know what email is their bugzilla account).
2895         "Alexander Kellett" <lypanov@mac.com>
2896         "Andre Boule" <aboule@apple.com>
2897         "Cameron McCormack" <cam@webkit.org>
2898         "Chris Petersen" <cpetersen@apple.com>
2899         "Eli Fidler" <eli@staikos.net>
2900         "Matt Lilek" <webkit@mattlilek.com>
2901         "Pierre d'Herbemont" <pdherbemont@free.fr>
2902         "Scott Violet" <sky@chromium.org>
2903         "Adam Treat" <treat@kde.org>
2904
2905         Most of those haven't committed in a very long time, so it's not suprising
2906         that we haven't noticed that their bugzilla emails are bogus.
2907
2908         * Scripts/validate-committer-lists:
2909         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2910         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2911
2912 2011-05-11  Dmitry Lomov  <dslomov@google.com>
2913
2914         Reviewed by David Levin.
2915
2916         https://bugs.webkit.org/show_bug.cgi?id=59561
2917         Switch TestWebKitAPI to GTest
2918
2919         Fixes Makefiles and WinCairo build as well
2920
2921         * Makefile:
2922         * Scripts/build-api-tests:
2923         * Scripts/run-api-tests:
2924         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2925         * TestWebKitAPI/Test.h:
2926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2927         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2928         (TestWebKitAPI::TEST):
2929         * TestWebKitAPI/TestsController.cpp:
2930         (TestWebKitAPI::TestsController::TestsController):
2931         (TestWebKitAPI::TestsController::dumpTestNames):
2932         (TestWebKitAPI::TestsController::runTestNamed):
2933         (TestWebKitAPI::TestsController::runAllTests):
2934         * TestWebKitAPI/TestsController.h:
2935         * TestWebKitAPI/mac/main.mm:
2936         (main):
2937
2938 2011-05-11  Eric Seidel  <eric@webkit.org>
2939
2940         Reviewed by Alexey Proskuryakov.
2941
2942         Add Luke Macpherson to committers.py as a Contributor
2943         https://bugs.webkit.org/show_bug.cgi?id=60639
2944
2945         * Scripts/webkitpy/common/config/committers.py:
2946
2947 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
2948
2949         Reviewed by Kenneth Rohde Christiansen.
2950
2951         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
2952         https://bugs.webkit.org/show_bug.cgi?id=60439
2953
2954         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
2955
2956         * Scripts/build-webkit:
2957
2958 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2959
2960         Reviewed by Adam Roben.
2961
2962         REGRESSION (r86161): WKPreferences API test failing on Windows
2963         https://bugs.webkit.org/show_bug.cgi?id=60658
2964
2965         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2966         (TestWebKitAPI::TEST):
2967
2968 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
2969
2970         Reviewed by Ojan Vafai.
2971
2972         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
2973         https://bugs.webkit.org/show_bug.cgi?id=60521
2974
2975         First steps towards making the results JSON all hierarchical.
2976
2977         * TestResultServer/model/jsonresults.py:
2978         * TestResultServer/model/jsonresults_unittest.py:
2979
2980 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
2981
2982         [wx] Build fix, adding new LayoutTestController method stubs.
2983
2984         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2985         (LayoutTestController::localStorageDiskUsageForOrigin):
2986         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2987
2988 2011-05-11  Jessie Berlin  <jberlin@apple.com>
2989
2990         Reviewed by Darin Adler.
2991
2992         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
2993         about the usage for both the origin overall and the database in question.
2994         https://bugs.webkit.org/show_bug.cgi?id=60573
2995
2996         * WebKitTestRunner/TestController.cpp:
2997         (WTR::exceededDatabaseQuota):
2998
2999 2011-05-10  Stephen White  <senorblanco@chromium.org>
3000
3001         Reviewed by David Levin.
3002
3003         Adding myself as a reviewer.
3004         https://bugs.webkit.org/show_bug.cgi?id=60587
3005
3006         * Scripts/webkitpy/common/config/committers.py:
3007
3008 2011-05-11  Eric Seidel  <eric@webkit.org>
3009
3010         Reviewed by Csaba Osztrogonác.
3011
3012         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
3013         https://bugs.webkit.org/show_bug.cgi?id=60614
3014
3015         AppEngine has a result limit of 1000.  We hit that when trying
3016         to find out how many patches the style-queue (and other queues)
3017         have passed in the last 30 days.  So lets display 1000+ instead
3018         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
3019
3020         I also made the status pages show "never" instead of just "ago" when we
3021         haven't seen a pass or boot message in the last 1000 messages.
3022
3023         * QueueStatusServer/handlers/queuestatus.py:
3024         * QueueStatusServer/templates/queuestatus.html:
3025
3026 2011-05-11  Adam Barth  <abarth@webkit.org>
3027
3028         Reviewed by Eric Seidel.
3029
3030         sheriffbot shouldn't spam bugs when it can't figure out who to blame
3031         https://bugs.webkit.org/show_bug.cgi?id=60613
3032
3033         This patch limits the number of bugs sheriffbot will spam to three.
3034         Ideally, we'd come up with some smarter huerstics, but hopefully this
3035         will cut down on the bugmail spam for slow bots.
3036
3037         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3038
3039 2011-05-10  Eric Seidel  <eric@webkit.org>
3040
3041         Reviewed by Adam Barth.
3042
3043         EWS bots should be robust against test-webkitpy hangs
3044         https://bugs.webkit.org/show_bug.cgi?id=60579
3045
3046         Added a killAfterTimeout subroutine, which takes a child_pid
3047         and timeout, and will setup a watchdog process to kill that child
3048         after the timeout.  killAfterTimeout will waitpid on the child.
3049
3050         * EWSTools/start-queue.sh:
3051
3052 2011-05-10  MORITA Hajime  <morrita@google.com>
3053
3054         Unreviewed, moved myself to the reviewers list.
3055
3056         * Scripts/webkitpy/common/config/committers.py:
3057
3058 2011-05-10  Anton D'Auria  <adauria@apple.com>
3059
3060         Reviewed by David Levin.
3061
3062         StorageTracker should report actual local storage usage on disk
3063         https://bugs.webkit.org/show_bug.cgi?id=60558
3064
3065         * DumpRenderTree/LayoutTestController.cpp:
3066         (localStorageDiskUsageForOriginCallback):
3067         (LayoutTestController::staticFunctions):
3068         * DumpRenderTree/LayoutTestController.h:
3069         * DumpRenderTree/chromium/LayoutTestController.cpp:
3070         (LayoutTestController::LayoutTestController):
3071         (LayoutTestController::localStorageDiskUsageForOrigin):
3072         * DumpRenderTree/chromium/LayoutTestController.h:
3073         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3074         (LayoutTestController::localStorageDiskUsageForOrigin):
3075         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3076         (LayoutTestController::localStorageDiskUsageForOrigin):
3077         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3078         (LayoutTestController::localStorageDiskUsageForOrigin):
3079         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3080         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3081         (LayoutTestController::localStorageDiskUsageForOrigin):
3082
3083 2011-05-10  Anton D'Auria  <adauria@apple.com>
3084
3085         Reviewed by Alexey Proskuryakov.
3086
3087         Add ApplicationCache API to get disk usage per origin
3088         https://bugs.webkit.org/show_bug.cgi?id=57127
3089
3090         Added test that loads two frames with ~15Kb image, checks usage,
3091         deletes app cache, verifies usage is 0.
3092
3093         * DumpRenderTree/LayoutTestController.cpp:
3094         (applicationCacheDiskUsageForOriginCallback):
3095         (LayoutTestController::staticFunctions):
3096         * DumpRenderTree/LayoutTestController.h:
3097         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3098         (LayoutTestController::LayoutTestController):
3099         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3100         * DumpRenderTree/chromium/LayoutTestController.h:
3101         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3102         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3103         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3104         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3105         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3106         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3107         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3108         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3109         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3110
3111 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3112
3113         Unreviewed, adding Rafael Antognolli as a committer.
3114
3115         * Scripts/webkitpy/common/config/committers.py:
3116
3117 2011-05-10  Chris Evans  <cevans@chromium.org>
3118
3119         Reviewed by Adam Barth.
3120
3121         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
3122         https://bugs.webkit.org/show_bug.cgi?id=58378
3123
3124         * DumpRenderTree/chromium/LayoutTestController.cpp:
3125         (LayoutTestController::LayoutTestController):
3126         (LayoutTestController::setAllowDisplayOfInsecureContent):
3127         (LayoutTestController::setAllowRunningOfInsecureContent):
3128         * DumpRenderTree/chromium/LayoutTestController.h:
3129         * DumpRenderTree/chromium/WebPreferences.cpp:
3130         (WebPreferences::reset):
3131         (WebPreferences::applyTo):
3132         * DumpRenderTree/chromium/WebPreferences.h:
3133         Add plumbing for new settings to Chromium DRT.
3134
3135 2011-05-10  Enrica Casucci  <enrica@apple.com>
3136
3137         Reviewed by Beth Dakin.
3138
3139         Added my name to the reviewers list and removed my name from
3140         to committer-only list.
3141
3142         * Scripts/webkitpy/common/config/committers.py:
3143
3144 2011-05-10  David Levin  <levin@chromium.org>
3145
3146         Reviewed by Shinichiro Hamaji.
3147
3148         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
3149         https://bugs.webkit.org/show_bug.cgi?id=60466
3150
3151         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
3152         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
3153           that property was removed.
3154         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
3155           filtering for errors.
3156         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
3157           verify that the line filtering is turned off.
3158         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
3159           and remove the unused file_path parameter.
3160         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
3161           line filtering is turned off (and fix test_no_error).
3162         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
3163           of errors based on the lines changed in the patch.
3164         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
3165           the filtering.
3166
3167 2011-05-10  Adam Roben  <aroben@apple.com>
3168
3169         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
3170
3171         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
3172         platform/win/plugins/window-geometry-initialized-before-set-window.html and
3173         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
3174         (WebKit2 Tests)
3175
3176         Reviewed by Anders Carlsson.
3177
3178         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3179         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
3180         WindowedPluginTest::testHarnessWindow function.
3181
3182         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
3183         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
3184         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
3185         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
3186         created for.
3187
3188         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3189         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
3190         WindowedPluginTest, and initialized new members.
3191         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
3192         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
3193         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
3194         then clean up and tell the test harness we're done.
3195         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
3196         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
3197         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
3198         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
3199         window becomes visible.
3200         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
3201         if it was hidden at the start of the test.
3202         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
3203         This should cause our window to become visible and our window region to get set. When we get
3204         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
3205         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
3206         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
3207         "startTest".
3208         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
3209
3210         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
3211         (WindowedPluginTest::testHarnessWindow):
3212         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
3213         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
3214
3215 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
3216
3217         Reviewed by Kenneth Rohde Christiansen.
3218
3219         [Qt] Add new qt-4.8 platform for layout testing
3220         https://bugs.webkit.org/show_bug.cgi?id=60544
3221
3222         * Scripts/old-run-webkit-tests:
3223         * Scripts/webkitdirs.pm:
3224
3225 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3226
3227         Unreviewed, rolling out r86108.
3228         http://trac.webkit.org/changeset/86108
3229         https://bugs.webkit.org/show_bug.cgi?id=60533
3230
3231         Broke makefile based builds and Cairo (Requested by weinig on
3232         #webkit).
3233
3234         * Scripts/build-api-tests:
3235         * Scripts/run-api-tests:
3236         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3237         * TestWebKitAPI/Test.h:
3238         (TestWebKitAPI::Test::~Test):
3239         (TestWebKitAPI::Test::name):
3240         (TestWebKitAPI::Test::Register::Register):
3241         (TestWebKitAPI::Test::Register::create):
3242         (TestWebKitAPI::Test::Test):
3243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3244         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3245         (TestWebKitAPI::TEST):
3246         * TestWebKitAPI/TestsController.cpp:
3247         (TestWebKitAPI::TestsController::TestsController):
3248         (TestWebKitAPI::TestsController::dumpTestNames):
3249         (TestWebKitAPI::TestsController::runTestNamed):
3250         (TestWebKitAPI::TestsController::testFailed):
3251         (TestWebKitAPI::TestsController::registerCreateTestFunction):
3252         * TestWebKitAPI/TestsController.h:
3253         * TestWebKitAPI/mac/main.mm:
3254         (main):
3255
3256 2011-05-09  Hayato Ito  <hayato@chromium.org>
3257
3258         Reviewed by Ojan Vafai.
3259
3260         Skip reftests if pixel tests are disabled.
3261
3262         https://bugs.webkit.org/show_bug.cgi?id=59078
3263
3264         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3265         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3266         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3267         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3268
3269 2011-05-09  Chang Shu  <cshu@webkit.org>
3270
3271         Reviewed by Kenneth Rohde Christiansen.
3272
3273         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
3274         https://bugs.webkit.org/show_bug.cgi?id=60499
3275
3276         The implementation is similar to gtk.
3277
3278         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3279         (TextInputController::unmarkText):
3280         * DumpRenderTree/qt/TextInputControllerQt.h:
3281
3282 2011-05-09  James Robinson  <jamesr@chromium.org>
3283
3284         Reviewed by Eric Seidel.
3285
3286         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
3287         https://bugs.webkit.org/show_bug.cgi?id=60520
3288
3289         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3290
3291 2011-05-09  Dmitry Lomov  <dslomov@google.com>
3292
3293         Reviewed by Sam Weinig.
3294
3295         Switch TestWebKitAPI to GTest
3296         https://bugs.webkit.org/show_bug.cgi?id=59561
3297
3298         * Scripts/build-api-tests:
3299         * Scripts/run-api-tests:
3300         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3301         * TestWebKitAPI/Test.h:
3302         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3303         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3304         (TestWebKitAPI::TEST):
3305         * TestWebKitAPI/TestsController.cpp:
3306         (TestWebKitAPI::TestsController::TestsController):
3307         (TestWebKitAPI::TestsController::dumpTestNames):
3308         (TestWebKitAPI::TestsController::runTestNamed):
3309         (TestWebKitAPI::TestsController::runAllTests):
3310         * TestWebKitAPI/TestsController.h:
3311         * TestWebKitAPI/mac/main.mm:
3312         (main):
3313
3314 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
3315
3316         Reviewed by Andreas Kling.
3317
3318         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
3319         https://bugs.webkit.org/show_bug.cgi?id=60487
3320
3321         When adding a new touch point, the start position of this point needs to be set.
3322
3323         * DumpRenderTree/qt/EventSenderQt.cpp:
3324         (EventSender::addTouchPoint):
3325
3326 2011-05-09  Robert Hogan  <robert@webkit.org>
3327
3328         Reviewed by Adam Roben.
3329
3330         https://bugs.webkit.org/show_bug.cgi?id=57137
3331
3332         Unskip plugins/embed-prefers-plugins-for-images.html
3333
3334         Add image/png mime-type to test netscape plugin on Unix.
3335
3336         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3337         (NP_GetMIMEDescription):
3338
3339 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
3340
3341         Reviewed by Ojan Vafai.
3342
3343         Pull jsonresults_unittest test cases out into separate test methods.
3344         https://bugs.webkit.org/show_bug.cgi?id=60418
3345
3346         * TestResultServer/model/jsonresults_unittest.py:
3347
3348 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3349
3350         Reviewed by Andreas Kling.
3351
3352         [Qt] fix fast/dom/Geolocation/window-close-crash.html
3353         https://bugs.webkit.org/show_bug.cgi?id=60458
3354
3355         Update all pages with Mock position/error/permission.
3356
3357         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3358         (LayoutTestController::setGeolocationPermission):
3359         (LayoutTestController::setMockGeolocationError):
3360         (LayoutTestController::setMockGeolocationPosition):
3361
3362 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
3363
3364         Reviewed by Tony Gentilcore.
3365
3366         Implement Page Visibility API.
3367         https://bugs.webkit.org/show_bug.cgi?id=54181
3368
3369         * DumpRenderTree/LayoutTestController.cpp:
3370         (setPageVisibilityCallback):
3371         (resetPageVisibilityCallback):
3372         (LayoutTestController::staticFunctions):
3373         * DumpRenderTree/LayoutTestController.h:
3374         (LayoutTestController::setPageVisibility):
3375         (LayoutTestController::resetPageVisibility):
3376         * DumpRenderTree/chromium/LayoutTestController.cpp:
3377         (LayoutTestController::LayoutTestController):
3378         (LayoutTestController::resetPageVisibility):
3379         (LayoutTestController::setPageVisibility):
3380         * DumpRenderTree/chromium/LayoutTestController.h:
3381
3382 2011-05-07  Adam Barth  <abarth@webkit.org>
3383
3384         Reviewed by Eric Seidel.
3385
3386         Testing EWS spins on patches with a large number of failures
3387         https://bugs.webkit.org/show_bug.cgi?id=60441
3388
3389         In cases where the tree has a small number of persistent failures but a
3390         patch has a large number of failures, we weren't believing any results.
3391         That lead to us retrying the patch forever while we waited for
3392         trustworthy results that would never come.
3393
3394         This patch loosens the semantics of unexpected_failures to return a
3395         subset (rather than the exact set) of unexpected failures.  In the case
3396         where the tree has a bounded number of failures and the patch has an
3397         unbounded number of failures, we can accurately compute such a subset
3398         and reject the patch.
3399
3400         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3401         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3402         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3403         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3404         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3405
3406 2011-05-07  Joe Mason  <jmason@rim.com>
3407
3408         Reviewed by Daniel Bates.
3409
3410         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
3411         https://bugs.webkit.org/show_bug.cgi?id=52211
3412
3413         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
3414         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
3415
3416         * DumpRenderTree/chromium/WebViewHost.cpp:
3417         (WebViewHost::willPerformClientRedirect):
3418         (WebViewHost::didStartProvisionalLoad):
3419         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3420         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3421
3422 2011-05-07  Daniel Bates  <dbates@webkit.org>
3423
3424         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
3425         <http://trac.webkit.org/changeset/86007> (bug #60438).
3426
3427         * Scripts/old-run-webkit-tests:
3428           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
3429             file local variable. 
3430
3431 2011-05-07  Pratik Solanki  <psolanki@apple.com>
3432
3433         Reviewed by Darin Adler.
3434
3435         Remove references to Tiger in scripts
3436         https://bugs.webkit.org/show_bug.cgi?id=60438
3437
3438         Remove isTiger() and all of the code that depends on it.
3439
3440         * Scripts/build-webkit:
3441         * Scripts/ensure-valid-python:
3442         * Scripts/gdb-safari:
3443         * Scripts/webkitdirs.pm:
3444
3445 2011-05-06  David Grogan  <dgrogan@chromium.org>
3446
3447         Reviewed by Eric Seidel.
3448
3449         update link to message about mac 64bit git binaries
3450         https://bugs.webkit.org/show_bug.cgi?id=60411
3451
3452         The original message implied (correctly, at-the-time) that
3453         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
3454         binaries. The new message notes that they do. This might prevent someone
3455         else from spending a few minutes confused.
3456
3457         * Scripts/webkitpy/common/checkout/scm/git.py:
3458
3459 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
3460
3461         Reviewed by Ojan Vafai.
3462
3463         new-run-webkit-tests: crashes in race with crashing DRT
3464         https://bugs.webkit.org/show_bug.cgi?id=60238
3465
3466         This fixes a race where if we wrote the URL to DRT and
3467         DRT crashed immediately, we could get a broken pipe
3468         error back during the write() and not handle it correctly,
3469         causing NRWT to also crash.
3470
3471         * Scripts/webkitpy/layout_tests/port/server_process.py:
3472         * Scripts/webkitpy/layout_tests/port/webkit.py:
3473
3474 2011-05-06  Adam Barth  <abarth@webkit.org>
3475
3476         Reviewed by Eric Seidel.
3477
3478         Add a --skip-integrationtests mode to test-webkitpy
3479         https://bugs.webkit.org/show_bug.cgi?id=60354
3480
3481         These two test suites account for 2/3 of test-webkitpy's running time
3482         because they're not actually unit tests.  They're integration tests.
3483         This patch adds the ability to skip integration tests by passing a
3484         command line argument to test-webkitpy.  The buildbots will continue to
3485         run these integration tests to make sure they don't regress.  This
3486         option is for use by developers when working on parts of the code that
3487         are well-covered by unit tests.
3488
3489         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
3490         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
3491         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
3492         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
3493         * Scripts/webkitpy/test/main.py:
3494
3495 2011-05-06  Adam Barth  <abarth@webkit.org>
3496
3497         Reviewed by Eric Seidel.
3498
3499         The results.zip generated by the Chromium EWS are too big
3500         https://bugs.webkit.org/show_bug.cgi?id=60352
3501
3502         Currently results.zip created by the Chromium EWS bot contain roughly
3503         1000 tests that we expect to fail.  These test results are not helpful
3504         to contributors.
3505
3506         There are several approaches to solving this problem:
3507
3508         1) We could be more selective about which files to include in the zip.
3509         2) We could ask new-run-webkit-tests not to generate results for
3510            expected failures.
3511         3) We could ask new-run-webkit-tests not to run tests that we expect to
3512            fail.
3513
3514         This patch takes approach (3).  Currently, we're ignoring the outcome
3515         of failing tests anyway, so there's not much point in actually running
3516         them.  As a side benefit, this will speed up the test run by about 6%.
3517         In the future, we might revisit this decision and choose another
3518         approach.
3519
3520         * Scripts/webkitpy/common/config/ports.py:
3521         * Scripts/webkitpy/common/config/ports_unittest.py:
3522
3523 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
3524
3525         Reviewed by Csaba Osztrogonác.
3526
3527         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
3528
3529         * Scripts/old-run-webkit-tests:
3530
3531 2011-05-06  Adam Barth  <abarth@webkit.org>
3532
3533         Reviewed by Ojan Vafai.
3534
3535         Add an option to NRWT to skip failing tests
3536         https://bugs.webkit.org/show_bug.cgi?id=60295
3537
3538         This option is similar to the way old-run-webkit-tests works.  We're
3539         planning to use this option on the testing EWS bots because they don't
3540         use information from failing tests yet.
3541
3542         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3543         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3544         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3545
3546 2011-05-04  Philippe Normand  <pnormand@igalia.com>
3547
3548         Reviewed by Dimitri Glazkov.
3549
3550         Implement LayoutTestController::pseudoShadowId()
3551         https://bugs.webkit.org/show_bug.cgi?id=60034
3552
3553         shadowPseudoId support in the various LayoutTestController
3554         implementations.
3555
3556         * DumpRenderTree/LayoutTestController.cpp:
3557         (shadowPseudoIdCallback):
3558         (LayoutTestController::staticFunctions):
3559         * DumpRenderTree/LayoutTestController.h:
3560         * DumpRenderTree/chromium/LayoutTestController.cpp:
3561         (LayoutTestController::LayoutTestController):
3562         (LayoutTestController::shadowPseudoId):
3563         * DumpRenderTree/chromium/LayoutTestController.h:
3564         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3565         (LayoutTestController::shadowPseudoId):
3566         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3567         (LayoutTestController::shadowPseudoId):
3568         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3569         (LayoutTestController::shadowPseudoId):
3570         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3571         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3572         (LayoutTestController::shadowPseudoId):
3573         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3574         (LayoutTestController::shadowPseudoId):
3575         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3576         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3577         (WTR::LayoutTestController::shadowPseudoId):
3578         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3579
3580 2011-05-06  Adam Barth  <abarth@webkit.org>
3581
3582         EWS can't reject patches
3583         https://bugs.webkit.org/show_bug.cgi?id=60345
3584
3585         We're supposed to use patch.id() for the attachment ID, silly.
3586
3587         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3588         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3589
3590 2011-05-05  Steve Lacey  <sjl@chromium.org>
3591
3592         Reviewed by Ojan Vafai.
3593
3594         Fix generation of results html file by passing relative path to scm
3595         methods.
3596         Generate diff images for results html file.
3597
3598         https://bugs.webkit.org/show_bug.cgi?id=60086
3599
3600         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3601         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3602
3603 2011-05-05  Andy Estes  <aestes@apple.com>
3604
3605         Reviewed by Daniel Bates.
3606
3607         update-webkit should handle Internal using a different VCS than OpenSource.
3608         https://bugs.webkit.org/show_bug.cgi?id=60310
3609
3610         isGit() and isSVN() cache their results, so Internal will always be
3611         updated using the VCS commands used for OpenSource. If Internal uses a
3612         different VCS, this will fail. Fix this by calling isGitDirectory() and
3613         isSVNDirectory() instead, which do not cache their results.
3614
3615         * Scripts/update-webkit:
3616
3617 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3618
3619         Reviewed by Ojan Vafai.
3620
3621         nrwt: revamp integration tests incl. tests for servers
3622         https://bugs.webkit.org/show_bug.cgi?id=59985
3623
3624         This change adds the ability to run "integration tests" that
3625         depend on (and affect) the local environment on your machine.
3626         These tests can be run manually by invoking python on the
3627         test file in question and passing the '-i' flag, but are
3628         not run automatically as part of test-webkitpy.
3629
3630         Integration tests are identified by being methods named as
3631         "integration_test_*" instead of "test_*", and we use a
3632         custom TestLoader instead of the default one provided by
3633         unittest.
3634
3635         This change also adds a protected "_default_to_apache" method
3636         to the port object so we can do the right thing when starting
3637         and stopping web servers with less mechanism.
3638
3639         * Scripts/webkitpy/layout_tests/port/base.py:
3640         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3641         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3642         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3643         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3644         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3645
3646 2011-05-05  Adam Roben  <aroben@apple.com>
3647
3648         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
3649
3650         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
3651         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
3652         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
3653         safeguard against this, we fill the alpha channel with constant full opacity after the
3654         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
3655         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
3656         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
3657         results need an alpha channel, too.)
3658
3659         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
3660         generated due to alpha channel weirdness
3661
3662         Reviewed by Sam Weinig.
3663
3664         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3665         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
3666         constant full opacity.
3667         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
3668         in a CGContext or cairo_surface.
3669
3670 2011-05-05  Adam Roben  <aroben@apple.com>
3671
3672         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
3673
3674         Passing true tells the test harness to dump pixels even though we're not dumping a render
3675         tree.
3676
3677         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
3678         WebKitTestRunner doesn't result in pixel results being generated
3679
3680         Reviewed by Sam Weinig.
3681
3682         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
3683         argument to dumpAsText.
3684
3685         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3686         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
3687
3688         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3689         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
3690
3691         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
3692
3693         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
3694         developers.
3695
3696 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3697
3698         Reviewed by Ojan Vafai.
3699
3700         new-run-webkit-tests: merge os, version fields in test config
3701         https://bugs.webkit.org/show_bug.cgi?id=60004
3702
3703         This change removes the 'o/s' field from the TestConfiguration
3704         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
3705         the expectations file to macros that expand to the version names
3706         for each platform.
3707
3708         This means that you can once again put any subset of the
3709         operating system versions on a single line, e.g.:
3710           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
3711
3712         This change will break any existing test_expectations.txt
3713         file that uses the "OS-VERSION" macros, which are no longer
3714         needed. It turns out they were never needed, as just VERSION
3715         by itself was sufficient. The test_expectations.txt file should
3716         be updated accordingly prior to landing this change.
3717
3718         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3719         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3720         * Scripts/webkitpy/layout_tests/port/base.py:
3721
3722 2011-05-05  Tony Chang  <tony@chromium.org>
3723
3724         Reviewed by Adam Barth.
3725
3726         [chromium] switch from Lucida to free fonts for Hindi and Thai
3727         https://bugs.webkit.org/show_bug.cgi?id=60287
3728
3729         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
3730         packages on Lucid. There are actually multiple Thai fonts in the
3731         package, so I just picked one.
3732
3733         * DumpRenderTree/chromium/TestShellGtk.cpp:
3734         (setupFontconfig):
3735
3736 2011-05-05  Tony Chang  <tony@chromium.org>
3737
3738         Reviewed by Ojan Vafai.
3739
3740         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
3741         https://bugs.webkit.org/show_bug.cgi?id=60290
3742
3743         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
3744         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
3745         lucid64.  Because of that, google-chrome-64 used to skip the
3746         chromium-linux-x86_64 results since they were more incorrect.
3747
3748         Now that we're switching to lucid for google-chrome, we want
3749         google-chrome-64 to fall back to chromium-linux-x86_64.
3750
3751         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3752
3753 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3754
3755         Reviewed by Ojan Vafai.
3756
3757         new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
3758         https://bugs.webkit.org/show_bug.cgi?id=60002
3759
3760         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3761         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3762         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3763         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3764         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3765         * Scripts/webkitpy/style/checkers/test_expectations.py:
3766
3767 2011-05-05  Eric Seidel  <eric@webkit.org>
3768
3769         Reviewed by Adam Barth.
3770
3771         commit-queue should reject patches which fail ewses
3772         https://bugs.webkit.org/show_bug.cgi?id=47534
3773
3774         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3775         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3776         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3777
3778 2011-05-05  Chang Shu  <cshu@webkit.org>
3779
3780         Reviewed by Andreas Kling.
3781
3782         [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
3783         https://bugs.webkit.org/show_bug.cgi?id=59638
3784
3785         1. Call QGraphicsWKView constructor with pageGroupRef.
3786         2. Disable setFontFamily calls as it breaks Qt test fonts.
3787
3788         * WebKitTestRunner/TestController.cpp:
3789         (WTR::TestController::resetStateToConsistentValues):
3790         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3791         (WTR::WebView::WebView):
3792         (WTR::PlatformWebView::PlatformWebView):
3793
3794 2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>
3795
3796         Reviewed by David Kilzer.
3797
3798         Add --only-webkit option to build-webkit
3799         https://bugs.webkit.org/show_bug.cgi?id=60245
3800
3801         * Scripts/build-webkit: If --only-webkit was specified
3802         just build the WebKit project, and not its dependencies.
3803
3804 2011-05-05  Jeff Miller  <jeffm@apple.com>
3805
3806         Reviewed by Darin Adler.
3807
3808         Add didNotHandleWheelEvent callback to WKPageUIClient
3809         https://bugs.webkit.org/show_bug.cgi?id=60203
3810
3811         * MiniBrowser/gtk/BrowserWindow.c:
3812         (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
3813         * MiniBrowser/mac/BrowserWindowController.m:
3814         (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
3815         * MiniBrowser/win/BrowserView.cpp:
3816         (BrowserView::create): Stub out didNotHandleWheelEvent callback.
3817         * WebKitTestRunner/TestController.cpp:
3818         (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
3819         (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
3820
3821 2011-05-04  Eric Seidel  <eric@webkit.org>
3822
3823         Reviewed by Adam Barth.
3824
3825         Add more missing imports from scm refactor
3826         https://bugs.webkit.org/show_bug.cgi?id=60239
3827
3828         * Scripts/webkitpy/common/checkout/scm/git.py:
3829         * Scripts/webkitpy/common/checkout/scm/svn.py:
3830
3831 2011-05-04  Eric Seidel  <eric@webkit.org>
3832
3833         Reviewed by Adam Barth.
3834
3835         sheriff-bot is having more exception trouble
3836         https://bugs.webkit.org/show_bug.cgi?id=60233
3837
3838         A webpage-forced build was causing SB to throw an exception.
3839         We've long had this bug, but we just didn't notice it until now.
3840
3841         In debugging this I found we fetch an absurd amount of data now
3842         that we use buildbot's json (instead of xmlrpc), so I added
3843         the filter=1 parameter to reduce it a little.  That required
3844         me to handle the case where filter=1 would strip
3845         result=0 in some cases (it's unclear why it does that).
3846
3847         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3848         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3849
3850 2011-05-04  Cris Neckar  <cdn@chromium.org>
3851
3852         Unreviewed, Adding Cris Neckar as a committer
3853
3854         * Scripts/webkitpy/common/config/committers.py:
3855
3856 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
3857
3858         Reviewed by Laszlo Gombos.
3859
3860         [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
3861         https://bugs.webkit.org/show_bug.cgi?id=59462
3862
3863         * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging. 
3864
3865 2011-05-04  Eric Seidel  <eric@webkit.org>
3866
3867         Reviewed by Adam Barth.
3868
3869         The testing EWS bots should upload layout-test-results.zip to bugs after failures
3870         https://bugs.webkit.org/show_bug.cgi?id=60223
3871
3872         This required sharing a bit of code between the commit-queue
3873         (which already knew how to do this) and the new EWS testing bots.
3874
3875         In the process I also cleaned up EWS testing a little and
3876         removed some dead code from the commit-queue.
3877
3878         * Scripts/webkitpy/common/config/committervalidator.py:
3879         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3880         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3881         * Scripts/webkitpy/tool/commands/queues.py:
3882         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3883
3884 2011-05-04  James Kozianski  <koz@chromium.org>
3885
3886         Reviewed by Eric Seidel.
3887
3888         Add method to make a Port able to retrieve TestOutputSets from its builders.
3889         https://bugs.webkit.org/show_bug.cgi?id=58211
3890
3891         This will be used in the new rebaseline script - TestOutputs are
3892         potential new baselines.
3893
3894         * Scripts/webkitpy/common/config/urls.py:
3895         * Scripts/webkitpy/layout_tests/port/base.py:
3896         * Scripts/webkitpy/layout_tests/port/chromium.py:
3897         * Scripts/webkitpy/layout_tests/port/factory.py:
3898         * Scripts/webkitpy/layout_tests/port/webkit.py:
3899
3900 2011-05-04  Eric Seidel  <eric@webkit.org>
3901
3902         Reviewed by Ojan Vafai.
3903
3904         sheriff-bot can't parse results.html
3905         https://bugs.webkit.org/show_bug.cgi?id=60196
3906
3907         The problem was that the NRWT bots are currently core
3908         and so sheriff-bot was trying to diagnose failures on
3909         them.  It was trying to parse their results.html file
3910         and BeautifulSoup was throwing an exception.
3911
3912         It seems our version of BeautifulSoup was quite old
3913         and unable to handle <script> tags correctly.
3914         This moves us to 3.2 which doesn't seem to have this bug.
3915
3916         * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
3917
3918 2011-05-04  Adam Barth  <abarth@webkit.org>
3919
3920         Reviewed by Eric Seidel.
3921
3922         Make the EWS test logging less verbose
3923         https://bugs.webkit.org/show_bug.cgi?id=60201
3924
3925         This should help us generate less than a hundred MB of logs per hour.
3926
3927         * Scripts/webkitpy/common/config/ports.py:
3928         * Scripts/webkitpy/common/config/ports_unittest.py:
3929
3930 2011-05-04  Tao Bai  <michaelbai@chromium.org>
3931
3932         Reviewed by David Kilzer.
3933
3934         Populate touch-icon url to FrameLoaderClient
3935         https://bugs.webkit.org/show_bug.cgi?id=59143
3936
3937         Disable touch icon by default. 
3938
3939         * Scripts/build-webkit:
3940
3941 2011-05-04  Justin Novosad  <junov@chromium.org>
3942
3943         Reviewed by Kenneth Russell.
3944
3945         [Chromium] Add gpu acceleration flags to DumpRenderTree
3946         https://bugs.webkit.org/show_bug.cgi?id=60168
3947         Adding support for command line flags 
3948         enable-accelerated-2d-canvas an
3949         enable-accelerated-drawing in DumpRenderTree.
3950
3951         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3952         (main):
3953         * DumpRenderTree/chromium/TestShell.cpp:
3954         (TestShell::TestShell):
3955         (TestShell::resetWebSettings):
3956         * DumpRenderTree/chromium/TestShell.h:
3957         (TestShell::setLegacyAccelerated2dCanvasEnabled):
3958         (TestShell::setAcceleratedDrawingEnabled):
3959         * DumpRenderTree/chromium/WebPreferences.cpp:
3960         (WebPreferences::reset):
3961         (WebPreferences::applyTo):
3962         * DumpRenderTree/chromium/WebPreferences.h:
3963
3964 2011-05-04  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3965
3966         Reviewed by Csaba Osztrogonác.
3967
3968         [Qt] run-qtwebkit-tests misses exec bit
3969         https://bugs.webkit.org/show_bug.cgi?id=60188
3970
3971         Also removing an unecessary import (mostly to let this bugfix goes
3972         through the system, as this is just a chmod).
3973
3974         * Scripts/run-qtwebkit-tests:
3975
3976 2011-05-04  Adam Barth  <abarth@webkit.org>
3977
3978         Fix import of ircproxy module to actually import the module.  I don't
3979         really understand how this code could have worked before.
3980
3981         * Scripts/webkitpy/common/host.py:
3982
3983 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
3984
3985         Reviewed by Andreas Kling.
3986
3987         [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
3988         https://bugs.webkit.org/show_bug.cgi?id=60172
3989
3990         * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
3991         (BrowserWindow::BrowserWindow):
3992
3993 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
3994
3995         Reviewed by Ojan Vafai.
3996
3997         [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
3998         https://bugs.webkit.org/show_bug.cgi?id=60088
3999         
4000         Makes --new-baseline put new baselines into the first entry in the
4001         baseline search path, including any additional directories passed in via
4002         --additional-platform-directory.
4003         
4004         Simplifies baseline_path() by making it return the first entry in the
4005         baseline search path instead of requiring each port to have an
4006         implementation (should not result in any behavior change).
4007
4008         * Scripts/webkitpy/layout_tests/port/base.py:
4009         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4010         * Scripts/webkitpy/layout_tests/port/chromium.py:
4011         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4012         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4013         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4014         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4015         * Scripts/webkitpy/layout_tests/port/mac.py:
4016         * Scripts/webkitpy/layout_tests/port/test.py:
4017         * Scripts/webkitpy/layout_tests/port/webkit.py:
4018
4019 2011-05-04  Adam Barth  <abarth@webkit.org>
4020
4021         Reviewed by Eric Seidel.
4022
4023         Fix circular dependency in webkitpy
4024         https://bugs.webkit.org/show_bug.cgi?id=60075
4025
4026         These functions don't belong in bugzilla.py.  They only exist there
4027         because they are old.  Really, these functions shouldn't be free
4028         functions at all, but that's a patch for another day.
4029
4030         * Scripts/webkitpy/common/checkout/changelog.py:
4031         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4032         * Scripts/webkitpy/common/checkout/checkout.py:
4033         * Scripts/webkitpy/common/config/urls.py:
4034         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
4035         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4036         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4037         * Scripts/webkitpy/style/checkers/changelog.py:
4038         * Scripts/webkitpy/tool/bot/irc_command.py:
4039         * Scripts/webkitpy/tool/bot/sheriff.py:
4040         * Scripts/webkitpy/tool/commands/upload.py:
4041
4042 2011-05-03  Pratik Solanki  <psolanki@apple.com>
4043
4044         Reviewed by Dan Bernstein.
4045
4046         https://bugs.webkit.org/show_bug.cgi?id=60141
4047         Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
4048
4049         * Scripts/build-webkit:
4050
4051 2011-05-03  Mihai Parparita  <mihaip@chromium.org>
4052
4053         Reviewed by Ojan Vafai.
4054
4055         Update rebaseline queue server to handle hierarchical test results
4056         https://bugs.webkit.org/show_bug.cgi?id=60063
4057         
4058         Update test result parsing done by the rebaseline queue server to handle
4059         the hierarchical test result output that is generated as of r85254.
4060
4061         * RebaselineQueueServer/templates/builder-queue-edit.html:
4062
4063 2011-05-03  Eric Seidel  <eric@webkit.org>
4064
4065         Reviewed by Adam Roben.
4066
4067         webkit-patch post-commits HEAD^.. throws an exception
4068         https://bugs.webkit.org/show_bug.cgi?id=60027
4069
4070         * Scripts/webkitpy/common/checkout/scm/git.py:
4071
4072 2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
4073
4074         Reviewed by Kenneth Rohde Christiansen.
4075
4076         [Qt] Layout tests may timeout if loadFinished receives false
4077         https://bugs.webkit.org/show_bug.cgi?id=60064
4078
4079         When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
4080         then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
4081         a response is ignored, like it should be for 204 responses. It is a problem for creating
4082         tests for 204 responses for example.
4083
4084         This change has been tested and it causes no regressions in layout tests.
4085
4086         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4087         (LayoutTestController::maybeDump):
4088
4089 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
4090
4091         Unreviewed, rolling out r85659.
4092         http://trac.webkit.org/changeset/85659
4093         https://bugs.webkit.org/show_bug.cgi?id=59977
4094
4095         restarting isn't working correctly
4096
4097         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
4098         * Scripts/webkitpy/layout_tests/port/http_server.py:
4099         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
4100         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
4101
4102 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
4103
4104         Reviewed by Ojan Vafai.
4105
4106         new-run-webkit-tests: fix http server startup/shutdown
4107
4108         Previous versions of the code had three problems that made startup
4109         and shutdown flaky. The first is that it would throw exceptions
4110         if it couldn't delete stale log files, which was overly
4111         paranoid. The second is that some of the exceptions weren't
4112         defined properly. The third, and most important, is that it was
4113         using urllib to check if ports were available, which was leaving
4114         sockets in a half-closed state, and keeping ports from being
4115         reused. By switching to raw sockets, we are able to now reliably
4116         restart.
4117
4118         This change also switches the code to using Executives to stop
4119         processes, which will let us delete a bunch of code in the
4120         port/* implementations and fix a weird layering problem in a
4121         subsequent patch.
4122
4123         https://bugs.webkit.org/show_bug.cgi?id=59977
4124
4125         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
4126         * Scripts/webkitpy/layout_tests/port/http_server.py:
4127         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
4128         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
4129
4130 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
4131
4132         Reviewed by Adam Barth.
4133
4134         fix failing printing_unittest on win32
4135         https://bugs.webkit.org/show_bug.cgi?id=59963
4136
4137         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
4138
4139 2011-05-03  Adam Roben  <aroben@apple.com>
4140
4141         Fix most strict PassOwnPtr violations on Windows
4142
4143         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
4144         enabled
4145
4146         Reviewed by Anders Carlsson.
4147
4148         * WebKitAPITest/Test.h: Use adoptPtr.
4149
4150 2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
4151
4152         Reviewed by Andreas Kling.
4153
4154         Add myself to the committers list.
4155
4156         * Scripts/webkitpy/common/config/committers.py:
4157
4158 2011-05-03  James Robinson  <jamesr@chromium.org>
4159
4160         Reviewed by Kenneth Russell.
4161
4162         [chromium] Layout test animations/3d/replace-filling-transform.html failing
4163         https://bugs.webkit.org/show_bug.cgi?id=59839
4164
4165         Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.
4166
4167         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4168
4169 2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
4170
4171         Unreviewed, rolling out r85471.
4172         http://trac.webkit.org/changeset/85471
4173         https://bugs.webkit.org/show_bug.cgi?id=59922
4174
4175         The rule of thumb in EFL is that you init in all the places
4176         you use it. So, if in your application you call ecore_evas_*
4177         functions, you have to call ecore_evas_init() first.
4178
4179         * EWebLauncher/main.c: always call *_init() functions when you use
4180         that namespace.
4181         (quit):
4182         (main):
4183
4184 2011-05-02  Ojan Vafai  <ojan@chromium.org>
4185
4186         Reviewed by Tony Chang.
4187
4188         remove no longer used method
4189         https://bugs.webkit.org/show_bug.cgi?id=59981
4190
4191         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4192         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4193
4194 2011-05-02  Ojan Vafai  <ojan@chromium.org>
4195
4196         Reviewed by Tony Chang.
4197
4198         add image toggling behavior from old-run-webkit-tests
4199         https://bugs.webkit.org/show_bug.cgi?id=59978
4200
4201         Output -diffs.html files. This matches old-run-webkit-tests.
4202         In theory, we could use data urls in the results.html file, but
4203         data urls don't currently have access to local files.
4204
4205         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
4206
4207 2011-05-02  Tony Chang  <tony@chromium.org>
4208
4209         Reviewed by Ojan Vafai.
4210
4211         [nrwt] remove some obsolete references to .checksum files
4212         https://bugs.webkit.org/show_bug.cgi?id=59971
4213
4214         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
4215         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
4216         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
4217         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
4218         * Scripts/webkitpy/layout_tests/port/test.py:
4219         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4220
4221 2011-05-02  Adam Roben  <aroben@apple.com>
4222
4223         Take advantage of implicit nullptr_t -> PassOwnPtr conversion
4224
4225         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
4226         doesn't work, but should
4227
4228         Reviewed by Adam Barth.
4229
4230         * DumpRenderTree/chromium/CppBoundClass.h:
4231         * DumpRenderTree/chromium/WebViewHost.cpp:
4232
4233 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
4234
4235         Reviewed by Xan Lopez.
4236
4237         [GTK] Compiler warning in Tools/MiniBrowser/main.c
4238         https://bugs.webkit.org/show_bug.cgi?id=59986
4239
4240         Remove a compiler warning.
4241
4242         * MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers
4243         from complaining.
4244
4245 2011-05-02  Adam Barth  <abarth@webkit.org>
4246
4247         Reviewed by Eric Seidel.
4248
4249         Add runtests_unittest.py
4250         https://bugs.webkit.org/show_bug.cgi?id=59955
4251
4252         I forgot to add this file in a previous patch.
4253
4254         * Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
4255
4256 2011-05-02  Adam Barth  <abarth@webkit.org>
4257
4258         Change the testing EWS to log failures explicitly to avoid an infinite loop.
4259
4260         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4261
4262 2011-05-02  Adrienne Walker  <enne@google.com>
4263
4264         Unreviewed, fix misspelled contributor name.
4265
4266         * Scripts/webkitpy/common/config/committers.py:
4267
4268 2011-05-02  Adam Barth  <abarth@webkit.org>
4269
4270         Reviewed by Eric Seidel.
4271
4272         cr-linux-ews should run tests
4273         https://bugs.webkit.org/show_bug.cgi?id=59272
4274
4275         This patch turns on testing for the cr-linux-ews.  Yay!
4276
4277         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4278         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4279         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4280         * Scripts/webkitpy/tool/steps/runtests.py:
4281         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4282
4283 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
4284
4285         Incorporate a review comment that I mistakenly omitted from my last commit.
4286
4287         * DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
4288
4289 2011-05-02  Adam Barth  <abarth@webkit.org>
4290
4291         Reviewed by Eric Seidel.
4292
4293         EWS should report the list of unexpected failures
4294         https://bugs.webkit.org/show_bug.cgi?id=59923
4295
4296         We cache the results of the first layout test results run on the task
4297         so the EWS can grab them later.  Another option is to include them in
4298         the exception that's thrown, but this approach seemed slightly more
4299         aesthetic.
4300
4301         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4302         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
4303
4304 2011-05-02  Adam Barth  <abarth@webkit.org>
4305
4306         Reviewed by Eric Seidel.
4307
4308         Add base case for a test-running EWS
4309         https://bugs.webkit.org/show_bug.cgi?id=59920
4310
4311         Later I will subclass this to run the Chromium Linux EWS.
4312
4313         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
4314         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4315         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4316
4317 2011-05-02  Anders Carlsson  <andersca@apple.com>
4318
4319         Build fix.
4320
4321         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4322         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4323
4324 2011-05-02  Nico Weber  <thakis@chromium.org>
4325
4326         Reviewed by Mihai Parparita.
4327
4328         Add --no-webkit2 to the output of "build-webkit -h"
4329         https://bugs.webkit.org/show_bug.cgi?id=59942
4330
4331         * Scripts/build-webkit:
4332
4333 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
4334
4335         Reviewed by Xan Lopez.
4336
4337         [GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar