update-webkit-support-libraries is broken with the change from http to https on devel...
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2
3         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
4         https://bugs.webkit.org/show_bug.cgi?id=77785
5
6         Fix the build bots.
7         
8         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
9
10         * Scripts/update-webkit-support-libs:
11         (downloadExpectedVersionNumber):
12
13 2012-02-03  Lucas Forschler  <lforschler@apple.com>
14
15         Add a Mac Lion Performance bot.
16         https://bugs.webkit.org/show_bug.cgi?id=77765
17
18         Reviewed by Adam Roben.
19
20         This will update the master configuration in the following ways:
21             Add a new performance slave (apple-xseve-11)
22             Add a new Factory to download a build and run perf tests.
23             
24         * BuildSlaveSupport/build.webkit.org-config/config.json:
25         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
26         (DownloadAndPerfTestFactory):
27         (DownloadAndPerfTestFactory.__init__):
28
29 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
30
31         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
32         https://bugs.webkit.org/show_bug.cgi?id=77752
33
34         Reviewed by James Robinson.
35
36         Delete unneeded file accidentally checked in in r106481.
37
38         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
39
40 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
41
42         Ref Tests should support plain SVG files
43         https://bugs.webkit.org/show_bug.cgi?id=77685
44
45         Reviewed by Tony Chang.
46
47         Don't assume reference files always use .html as the extension.
48         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
49
50         Also fix various bugs in MockFileSystem and TestPort.
51
52         * Scripts/webkitpy/common/system/filesystem_mock.py:
53         (MockFileSystem.isdir):
54         * Scripts/webkitpy/layout_tests/port/base.py:
55         (Port.reference_files):
56         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
57         (PortTest.test_is_test_file):
58         (PortTest.test_reference_files):
59         * Scripts/webkitpy/layout_tests/port/test.py:
60         (TestInstance.__init__):
61
62 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
63
64         perf-o-matic should store chromium svn revision
65         https://bugs.webkit.org/show_bug.cgi?id=77725
66
67         Reviewed by Dirk Pranke.
68
69         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
70         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
71         is implemented in terms of newly added svn_revision.
72
73         * Scripts/webkitpy/common/checkout/scm/git.py:
74         (Git.svn_revision):
75         * Scripts/webkitpy/common/checkout/scm/scm.py:
76         (SCM.head_svn_revision):
77         (SCM):
78         (SCM.svn_revision):
79         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
80         (MockSCM.svn_revision):
81         * Scripts/webkitpy/common/checkout/scm/svn.py:
82         (SVN.svn_revision):
83         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
84         (JSONLayoutResultsGenerator.__init__):
85         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
86         (JSONResultsGeneratorBase._insert_generic_metadata):
87         * Scripts/webkitpy/layout_tests/port/base.py:
88         (Port.repository_paths):
89         * Scripts/webkitpy/layout_tests/port/chromium.py:
90         (ChromiumPort.repository_paths):
91         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
92         (PerfTestsRunner._generate_json):
93         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
94         (test_run_test_set_with_json_output):
95         (test_run_test_set_with_json_source):
96         (test_run_test_set_with_multiple_repositories):
97
98 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
99
100         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
101         https://bugs.webkit.org/show_bug.cgi?id=77632
102
103         Reviewed by Kenneth Rohde Christiansen.
104
105         * MiniBrowser/qt/BrowserWindow.cpp:
106         (BrowserWindow::BrowserWindow):
107         * MiniBrowser/qt/MiniBrowserApplication.cpp:
108         (MiniBrowserApplication::sendTouchEvent):
109         (MiniBrowserApplication::handleUserOptions):
110         * MiniBrowser/qt/MiniBrowserApplication.h:
111         (WindowOptions):
112         (WindowOptions::WindowOptions):
113         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
114         (WTR::PlatformWebView::PlatformWebView):
115         * WebKitTestRunner/qt/main.cpp:
116         (main):
117         * qmake/mkspecs/features/default_post.prf:
118
119 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
120
121         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
122         https://bugs.webkit.org/show_bug.cgi?id=77723
123
124         Reviewed by Tor Arne Vestbø.
125
126         * Tools.pro: Compile WTR again on all platforms with WK2.
127
128 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
129
130         Ensure that inspector disabled build works
131         https://bugs.webkit.org/show_bug.cgi?id=77604
132
133         Reviewed by Tor Arne Vestbø.
134
135         * qmake/mkspecs/features/features.prf:
136
137 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
138
139         [chromium] add support for --makeargs to the ninja-based build
140         https://bugs.webkit.org/show_bug.cgi?id=77688
141
142         Reviewed by Adam Barth.
143
144         * Scripts/webkitdirs.pm:
145         (buildChromiumNinja):
146
147 2012-02-02  Eric Seidel  <eric@webkit.org>
148
149         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
150         https://bugs.webkit.org/show_bug.cgi?id=75145
151
152         Reviewed by Dirk Pranke.
153
154         * Scripts/webkitpy/layout_tests/port/mac.py:
155         (MacPort.default_child_processes):
156         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
157         (test_operating_system):
158         (test_default_child_processes):
159
160 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
161
162        nrwt shouldn't blow up when there are errors in test_expectations.txt
163        https://bugs.webkit.org/show_bug.cgi?id=73603
164
165        Reviewed by Ojan Vafai.
166
167        This change removes the distinction between 'errors' and 'warnings'
168        in the test expectations parser. Now, any problem is a
169        'warning', and if we are linting the file, warnings become fatal (errors).
170
171         This will allow a normal run-webkit-tests run to proceed even if
172         there are bad lines.
173
174         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
175         (ParseError.__init__):
176         (ParseError.__str__):
177         (ParseError.__repr__):
178         (TestExpectationSerializer.to_string):
179         (TestExpectationParser._parse_modifiers):
180         (TestExpectationParser._parse_expectations):
181         (TestExpectationParser._check_modifiers_against_expectations):
182         (TestExpectationParser._tokenize):
183         (TestExpectationLine.__init__):
184         (TestExpectationLine.is_invalid):
185         (TestExpectationsModel.add_expectation_line):
186         (TestExpectationsModel._already_seen_better_match):
187         (TestExpectations.__init__):
188         (TestExpectations._report_warnings):
189         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
190         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
191         (assert_bad_expectations):
192         (test_parse_warning):
193         (test_overrides__duplicate):
194         (ExpectationSyntaxTests.test_missing_expectation):
195         (ExpectationSyntaxTests.test_missing_colon):
196         (ExpectationSyntaxTests.test_too_many_colons):
197         (ExpectationSyntaxTests.test_too_many_equals_signs):
198         (ExpectationSyntaxTests.test_unrecognized_expectation):
199         (SemanticTests.test_bug_format):
200         (SemanticTests.test_bad_bugid):
201         (SemanticTests.test_slow_and_timeout):
202         (test_ambiguous):
203         (test_more_modifiers):
204         (test_order_in_file):
205         (test_macro_overrides):
206         (RebaseliningTest.assertRemove):
207         (TestExpectationParserTests.test_tokenize_blank):
208         (TestExpectationParserTests.test_tokenize_missing_colon):
209         (TestExpectationParserTests.test_tokenize_extra_colon):
210         (TestExpectationParserTests.test_tokenize_empty_comment):
211         (TestExpectationParserTests.test_tokenize_comment):
212         (TestExpectationParserTests.test_tokenize_missing_equal):
213         (TestExpectationParserTests.test_tokenize_extra_equal):
214         (TestExpectationParserTests.test_tokenize_valid):
215         (TestExpectationParserTests.test_tokenize_valid_with_comment):
216         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
217         (TestExpectationSerializerTests.test_unparsed_to_string):
218         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
219         (lint):
220         * Scripts/webkitpy/style/checkers/test_expectations.py:
221         (TestExpectationsChecker.check_test_expectations):
222
223 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
224
225         Unreviewed, rolling out r106543.
226         http://trac.webkit.org/changeset/106543
227         https://bugs.webkit.org/show_bug.cgi?id=77671
228
229         Made tests less stable (Requested by rniwa on #webkit).
230
231         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
232         (PerfTestsRunner):
233         (PerfTestsRunner.__init__):
234         (PerfTestsRunner._run_tests_set):
235         (PerfTestsRunner._run_single_test):
236         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
237         (MainTest.TestDriver.run_test):
238         (run_test):
239
240 2012-02-02  Beth Dakin  <bdakin@apple.com>
241
242         https://bugs.webkit.org/show_bug.cgi?id=77664
243         Add API tests for didNewFirstVisuallyNonEmptyLayout
244
245         Reviewed by Darin Adler.
246
247         Two new tests.
248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
249         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
250         (TestWebKitAPI):
251         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
252         (TestWebKitAPI::setPageLoaderClient):
253         (TestWebKitAPI::TEST):
254         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
255         (TestWebKitAPI):
256         (TestWebKitAPI::didForceRepaint):
257         (TestWebKitAPI::didFinishLoadForFrame):
258         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
259         (TestWebKitAPI::setPageLoaderClient):
260         (TestWebKitAPI::TEST):
261         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
262         (TestWebKitAPI):
263         (NewFirstVisuallyNonEmptyLayoutFailsTest):
264         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
265         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
266         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
267         (TestWebKitAPI):
268         (NewFirstVisuallyNonEmptyLayoutTest):
269         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
270         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
271
272 2012-02-02  Michael Saboff  <msaboff@apple.com>
273
274         Add Michael Saboff to reviewers list.
275
276         Rubber-stamped by Gavin Barraclough.
277
278         * Scripts/webkitpy/common/config/committers.py:
279
280 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
281
282         Add myself as a committer
283
284         Unreviewed
285
286         * Scripts/webkitpy/common/config/committers.py:
287
288 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
289
290         [PerformanceTests] tests have dependencies
291         https://bugs.webkit.org/show_bug.cgi?id=77506
292
293         Reviewed by Hajime Morita.
294
295         Load an initialization page before each test after starting a DRT so that
296         warming up DRT won't affect the performance test results.
297
298         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
299         (PerfTestsRunner):
300         (PerfTestsRunner.__init__):
301         (PerfTestsRunner._run_tests_set):
302         (PerfTestsRunner._run_single_test):
303         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
304         (MainTest.TestDriver.run_test):
305         (test_initial_page_loaded):
306         (test_initial_page_loaded.run_test):
307
308 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
309
310         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
311
312         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
313         (PerfTestsRunner._run_tests_set):
314         (PerfTestsRunner._run_single_test):
315         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
316         (create_runner):
317         (test_run_passing_test):
318         (test_run_silent_test):
319         (test_run_failed_test):
320         (test_run_tonguey_test):
321         (test_run_timeout_test):
322         (test_run_crash_test):
323         (test_run_test_set_kills_drt_per_run):
324         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
325         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
326         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
327
328 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
329
330         Webkit generate-coverage-data script needs update to use new test script
331         https://bugs.webkit.org/show_bug.cgi?id=77597
332
333         Reviewed by Dirk Schulze.
334
335         * Scripts/generate-coverage-data:
336
337 2012-02-01  Adam Barth  <abarth@webkit.org>
338
339         Update the tests to show that the mac-ews processes patches from
340         non-committers.
341
342         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
343         (EarlyWarningSytemTest.test_committer_only_ewses):
344         (EarlyWarningSytemTest.test_builder_ewses):
345
346 2012-02-01  Adam Barth  <abarth@webkit.org>
347
348         Mac-ews logs are huge
349         https://bugs.webkit.org/show_bug.cgi?id=77045
350
351         Reviewed by Eric Seidel.
352
353         In order to get the cr-linux-ews bot to run tests on EC2, we created
354         the chromium-xvfb port, which contained a number of tweaks to the
355         Chromium port's behavior.  This patch refactors those tweaks so they
356         can be shared with the mac-ews, mostly by moving them into the
357         non-interactive mode of RunTests.
358
359         * Scripts/webkitpy/common/config/ports.py:
360         (WebKitPort):
361         (WebKitPort.layout_tests_results_path):
362         (ChromiumPort.run_javascriptcore_tests_command):
363         (ChromiumXVFBPort):
364         (ChromiumXVFBPort.run_webkit_tests_command):
365         * Scripts/webkitpy/common/config/ports_mock.py:
366         (MockPort):
367         (MockPort.layout_tests_results_path):
368         * Scripts/webkitpy/common/config/ports_unittest.py:
369         (WebKitPortTest.test_chromium_xvfb_port):
370         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
371         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
372         * Scripts/webkitpy/tool/commands/queues_unittest.py:
373         (CommitQueueTest.test_commit_queue):
374         (test_rollout):
375         (test_manual_reject_during_processing):
376         * Scripts/webkitpy/tool/steps/runtests.py:
377         (RunTests.run):
378         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
379         (RunTestsTest.test_no_unit_tests):
380         * Scripts/webkitpy/tool/steps/steps_unittest.py:
381         (StepsTest.test_runtests_args):
382
383 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
384
385         Roll out r106442. It made some tests more stable but others less stable.
386
387         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
388         (PerfTestsRunner._run_tests_set):
389         (PerfTestsRunner._run_single_test):
390         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
391         (create_runner):
392         (test_run_passing_test):
393         (test_run_silent_test):
394         (test_run_failed_test):
395         (test_run_tonguey_test):
396         (test_run_timeout_test):
397         (test_run_crash_test):
398         (test_run_test_set):
399
400 2012-02-01  Lucas Forschler  <lforschler@apple.com>
401
402         Enable EWS for non-contributers.
403         https://bugs.webkit.org/show_bug.cgi?id=77576
404         
405         Reviewed by Adam Barth.
406
407         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
408         (MacEWS):
409
410 2012-02-01  Beth Dakin  <bdakin@apple.com>
411
412         https://bugs.webkit.org/show_bug.cgi?id=77383
413         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
414         -and corresponding-
415         <rdar://problem/10709560>
416
417         Reviewed by Sam Weinig.
418
419         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
420         for.
421         * MiniBrowser/mac/BrowserWindowController.m:
422         (-[BrowserWindowController awakeFromNib]):
423         * WebKitTestRunner/TestController.cpp:
424         (WTR::TestController::initialize):
425
426 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
427
428         TestWebKitAPI isn't being built on chromium bots any more
429         https://bugs.webkit.org/show_bug.cgi?id=77563
430
431         Reviewed by Dimitri Glazkov.
432
433         I accidentally dropped it in the refactoring in r105449.
434
435         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
436
437 2012-02-01  Hans Wennborg  <hans@chromium.org>
438
439         Rename WebSpeechInputResult::set() to assign()
440         https://bugs.webkit.org/show_bug.cgi?id=77540
441
442         Reviewed by Darin Fisher.
443
444         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
445         (MockWebSpeechInputController::addMockRecognitionResult):
446         (MockWebSpeechInputController::speechTaskFired):
447
448 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
449
450         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
451         https://bugs.webkit.org/show_bug.cgi?id=77542
452
453         Reviewed by Martin Robinson.
454
455         * gtk/generate-gtkdoc: Check first whether there's
456         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
457         instead.
458         (get_webkit2_options): Return just the options since the
459         pkg_config_path doesn't depend on options
460         (get_webkit1_options): Ditto.
461         (generate_doc): Helper function to create a generator and generate
462         documentation for the given pkg-config file with the given options.
463         * gtk/gtkdoc.py:
464         (GTKDoc.__init__): Don't use ** for args parameter, since it's
465         used as a dict and never expanded.
466         (PkgConfigGTKDoc.__init__): Ditto.
467
468 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
469
470         [GTK] API documentation is not installed even when building with --enable-gtk-doc
471         https://bugs.webkit.org/show_bug.cgi?id=77094
472
473         Reviewed by Martin Robinson.
474
475         * GNUmakefile.am: Add install-data-local and uninstall-local rules
476         to install/uninstall WebKit1 and WebKit2 API documentation.
477
478 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
479
480         Unreviewed, rolling out r106460.
481         http://trac.webkit.org/changeset/106460
482         https://bugs.webkit.org/show_bug.cgi?id=77552
483
484         It break unit tests if WEBKIT_TESTFONTS isn't defined.
485         (Requested by Ossy on #webkit).
486
487         * Scripts/webkitpy/layout_tests/port/qt.py:
488
489 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
490
491         [Qt] Automatic clean build feature always do clean build with --no-webkit2
492         https://bugs.webkit.org/show_bug.cgi?id=74519
493
494         Reviewed by Tor Arne Vestbø.
495
496         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
497
498         * qmake/mkspecs/features/features.prf:
499
500 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
501
502         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
503         https://bugs.webkit.org/show_bug.cgi?id=77466
504
505         Reviewed by Kenneth Rohde Christiansen.
506
507         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
508         is set or if we should raise an error.
509
510         * Scripts/webkitpy/layout_tests/port/qt.py:
511         (QtPort.setup_environ_for_server):
512
513 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
514
515         Reviewed by Martin Robinson.
516
517         [GTK] Improve FrameLoader signals. Resource loading
518         https://bugs.webkit.org/show_bug.cgi?id=49543
519
520         Support for the new loader signals in DRT.
521
522         * DumpRenderTree/gtk/DumpRenderTree.cpp:
523         (urlPath):
524         (willSendRequestCallback):
525         (urlSuitableForTestResult):
526         (descriptionSuitableForTestResult):
527         (didReceiveResponse):
528         (didFinishLoading):
529         (didFailLoadingWithError):
530         (createWebView):
531
532 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
533
534         run-perf-tests should restart DRT for each test
535         https://bugs.webkit.org/show_bug.cgi?id=77506
536
537         Reviewed by Adam Barth.
538
539         Always restart DRT when running performance tests in order to minimize the dependency between tests.
540
541         * Scripts/webkitpy/layout_tests/port/chromium.py:
542         (ChromiumDriver.stop):
543         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
544         (PerfTestsRunner._run_tests_set):
545         (PerfTestsRunner._run_single_test):
546         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
547         (create_runner):
548         (test_run_passing_test):
549         (test_run_silent_test):
550         (test_run_failed_test):
551         (test_run_tonguey_test):
552         (test_run_timeout_test):
553         (test_run_crash_test):
554         (test_run_test_set_kills_drt_per_run):
555         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
556         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
557         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
558
559 2012-01-31  Hans Wennborg  <hans@chromium.org>
560
561         Speech Input: Report speech element rect relative to window rather than frame
562         https://bugs.webkit.org/show_bug.cgi?id=76443
563
564         Reviewed by Darin Fisher.
565
566         Update LayoutTestController to allow for retrieving the speech
567         element's position used in a request.
568
569         In Chromium this is handled by the MockWebSpeechInputController;
570         adding stubs for the other implementations.
571
572         * DumpRenderTree/LayoutTestController.cpp:
573         (setMockSpeechInputDumpRectCallback):
574         (LayoutTestController::staticFunctions):
575         * DumpRenderTree/LayoutTestController.h:
576         (LayoutTestController):
577         * DumpRenderTree/chromium/LayoutTestController.cpp:
578         (LayoutTestController::LayoutTestController):
579         (LayoutTestController::setMockSpeechInputDumpRect):
580         * DumpRenderTree/chromium/LayoutTestController.h:
581         (LayoutTestController):
582         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
583         (MockWebSpeechInputController::setDumpRect):
584         (MockWebSpeechInputController::clearResults):
585         (MockWebSpeechInputController::startRecognition):
586         (MockWebSpeechInputController::MockWebSpeechInputController):
587         (makeRectResult):
588         (MockWebSpeechInputController::speechTaskFired):
589         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
590         (MockWebSpeechInputController):
591         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
592         (LayoutTestController::setMockSpeechInputDumpRect):
593         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
594         (LayoutTestController::setMockSpeechInputDumpRect):
595         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
596         (LayoutTestController::setMockSpeechInputDumpRect):
597         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
598         (LayoutTestController::setMockSpeechInputDumpRect):
599         * DumpRenderTree/qt/LayoutTestControllerQt.h:
600         (LayoutTestController):
601         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
602         (LayoutTestController::setMockSpeechInputDumpRect):
603         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
604         (LayoutTestController::setMockSpeechInputDumpRect):
605
606 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
607
608         [EFL] Add basic DRT/Efl implementation to support viewport test.
609         https://bugs.webkit.org/show_bug.cgi?id=77320
610
611         Reviewed by Andreas Kling.
612
613         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
614         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
615
616 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
617
618         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
619         https://bugs.webkit.org/show_bug.cgi?id=77473
620         <rdar://problem/10751357>
621
622         Reviewed by Darin Adler.
623
624         * DumpRenderTree/mac/EventSendingController.mm:
625         (-[EventSendingController keyDown:withModifiers:withLocation:]):
626         * WebKitTestRunner/mac/EventSenderProxy.mm:
627         (WTR::EventSenderProxy::keyDown):
628         Added a new special keyDown value to test this.
629
630 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
631
632         nrwt: fix the mock port to work with DriverProxy, reftests
633         https://bugs.webkit.org/show_bug.cgi?id=77170
634
635         Reviewed by Eric Seidel.
636
637         The DryrunPort used for benchmarking and testing NRWT has been
638         broken since we added the DriverProxy code. It isn't really
639         needed any more, so I've removed it.
640
641         The MockDRT port was also broken by DriverProxy, and moreover,
642         never worked w/ reftests. Since we don't exercise this module in
643         the unit tests, the code had also bitrotted some. I have cleaned
644         it up and made it use DriverInput and DriverOutput for
645         consistency.
646
647         * Scripts/webkitpy/layout_tests/port/dryrun.py:
648         (DryRunPort.__init__):
649         (DryRunPort):
650         (DryRunPort.real_name):
651         (DryRunPort.create_driver):
652         (DryRunPort.driver_cmd_line):
653         (DryRunPort._driver_class):
654         (DryrunDriver):
655         (DryrunDriver.run_test):
656         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
657         (MockDRTPort.create_driver):
658         (MockChromiumDRT.run_one_test):
659
660 2012-01-31  Ojan Vafai  <ojan@chromium.org>
661
662         run-webkit-tests calls out to webkit-build-directory twice
663         https://bugs.webkit.org/show_bug.cgi?id=77248
664
665         Reviewed by Dirk Pranke.
666
667         * Scripts/webkit-build-directory:
668         If called with no arguments, print out both the top-level directory and the 
669         configuration directory
670
671         * Scripts/webkitpy/layout_tests/port/config.py:
672         (Config.build_directory):
673         When called with no arguments, get and cache both the top-level and configuration directories.
674
675         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
676         (main):
677         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
678         (ConfigTest.assert_configuration):
679         (ConfigTest.test_build_directory.mock_webkit_build_directory):
680         (ConfigTest.test_build_directory):
681         (ConfigTest.test_default_configuration__notfound):
682         * Scripts/webkitpy/layout_tests/port/webkit.py:
683         (WebKitPort._build_path):
684         Cache the build directory in the options object so that other users
685         of the options object don't need to call out to webkit-build-directory.
686         Also, properly support the existing --build-directory argument.
687
688 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
689
690         Bump up the timeout for performance tests since DOM/DOMTable.html
691         and Parser/html5-full-render.html are timing out on the bot.
692
693         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
694         (PerfTestsRunner._parse_args):
695
696 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
697
698         Fix the update_webgl_conformance_tests.py script in order to enable it
699         to detect the SCM being used correctly.
700         https://bugs.webkit.org/show_bug.cgi?id=77462
701
702         Reviewed by Kenneth Russell.
703
704         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
705         (default_out_dir):
706
707 2012-01-31  Eric Seidel  <eric@webkit.org>
708
709         webkit-patch apply-from-bug should work regardless of your CWD
710         https://bugs.webkit.org/show_bug.cgi?id=77482
711
712         Reviewed by Adam Barth.
713
714         webkit-patch only ever works with patches made from the root
715         directory.  We should pass the CWD to svn-apply in the case
716         where we're running not from the webkit root.  I believe
717         this used to work in the past and regressed.
718
719         * Scripts/webkitpy/common/checkout/checkout.py:
720         (Checkout.apply_patch):
721         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
722         (CheckoutTest.test_apply_patch):
723
724 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
725
726         Unreviewed, rolling out r106302.
727         http://trac.webkit.org/changeset/106302
728         https://bugs.webkit.org/show_bug.cgi?id=77472
729
730         Broke building DRT before running the tests (Requested by ojan
731         on #webkit).
732
733         * Scripts/webkit-build-directory:
734         * Scripts/webkitpy/layout_tests/port/config.py:
735         (Config.build_directory):
736         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
737         (main):
738         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
739         (ConfigTest.assert_configuration):
740         (ConfigTest.test_build_directory.mock_webkit_build_directory):
741         (ConfigTest.test_build_directory):
742         (ConfigTest.test_default_configuration__notfound):
743         * Scripts/webkitpy/layout_tests/port/webkit.py:
744         (WebKitPort._build_path):
745
746 2012-01-31  Antoine Labour  <piman@chromium.org>
747
748         Merge WebGraphicsContext3D creation and initialization, and move it to
749         WebViewClient.
750         https://bugs.webkit.org/show_bug.cgi?id=76593
751
752         Reviewed by Darin Fisher.
753
754         * DumpRenderTree/chromium/TestWebPlugin.cpp:
755         (TestWebPlugin::TestWebPlugin):
756         (TestWebPlugin::initialize):
757         * DumpRenderTree/chromium/TestWebPlugin.h:
758         * DumpRenderTree/chromium/WebViewHost.cpp:
759         (WebViewHost::createGraphicsContext3D):
760         (WebViewHost::createPlugin):
761         * DumpRenderTree/chromium/WebViewHost.h:
762
763 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
764
765         [GTK] build-webkit warning.
766         https://bugs.webkit.org/show_bug.cgi?id=77411
767
768         Reviewed by Philippe Normand.
769
770         * Scripts/webkitdirs.pm:
771         (isCrossCompilation):
772
773 2012-01-31  Dan Bernstein  <mitz@apple.com>
774
775         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
776
777         Reviewed by Anders Carlsson.
778
779         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
780
781 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
782
783         If the QTDIR environment variable is set, the build system fails to compile WinCairo
784         https://bugs.webkit.org/show_bug.cgi?id=77112
785
786         Reviewed by Daniel Bates.
787
788         * Scripts/webkitdirs.pm:
789         (determineIsQt):
790
791 2012-01-31  Adam Roben  <aroben@apple.com>
792
793         Only call -typingAttributes on WebViews, not WebHTMLViews
794
795         Looks like this case was just missed in r105908.
796
797         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
798
799         Reviewed by Antti Koivisto.
800
801         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
802         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
803         earlier.
804
805 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
806
807         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
808         https://bugs.webkit.org/show_bug.cgi?id=77221
809
810         Reviewed by Kenneth Rohde Christiansen.
811
812         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
813
814         * MiniBrowser/qt/MiniBrowserApplication.cpp:
815         (MiniBrowserApplication::sendTouchEvent):
816
817 2012-01-26  Hans Wennborg  <hans@chromium.org>
818
819         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
820         https://bugs.webkit.org/show_bug.cgi?id=77083
821
822         Reviewed by Darin Fisher.
823
824         Add MockWebSpeechInputController which provides a mock implementation
825         of the WebSpeechInputController interface, and use that in
826         DumpRenderTree.
827
828         * DumpRenderTree/DumpRenderTree.gypi:
829         * DumpRenderTree/chromium/LayoutTestController.cpp:
830         (LayoutTestController::addMockSpeechInputResult):
831         * DumpRenderTree/chromium/LayoutTestController.h:
832         ():
833         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
834         (MockWebSpeechInputController::create):
835         (MockWebSpeechInputController::addMockRecognitionResult):
836         (MockWebSpeechInputController::clearResults):
837         (MockWebSpeechInputController::startRecognition):
838         (MockWebSpeechInputController::cancelRecognition):
839         (MockWebSpeechInputController::stopRecording):
840         (MockWebSpeechInputController::MockWebSpeechInputController):
841         (MockWebSpeechInputController::speechTaskFired):
842         (MockWebSpeechInputController::SpeechTask::SpeechTask):
843         (MockWebSpeechInputController::SpeechTask::stop):
844         (MockWebSpeechInputController::SpeechTask::runIfValid):
845         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
846         (WebKit):
847         (MockWebSpeechInputController):
848         (MockWebSpeechInputController::taskList):
849         (SpeechTask):
850         * DumpRenderTree/chromium/TestShell.cpp:
851         * DumpRenderTree/chromium/WebViewHost.cpp:
852         (WebViewHost::speechInputController):
853         * DumpRenderTree/chromium/WebViewHost.h:
854         (WebKit):
855         (WebViewHost::speechInputControllerMock):
856         (WebViewHost):
857         ():
858
859 2012-01-31  Hajime Morrita  <morrita@chromium.org>
860
861         [PerformanceTests] Add landing html for Dromaeo dom-query test
862         https://bugs.webkit.org/show_bug.cgi?id=77329
863
864         Reviewed by Ryosuke Niwa.
865
866         Added some more ignorable output patterns to allow warnings
867         from a third party test suite.
868
869         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
870         (PerfTestsRunner):
871         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
872
873 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
874
875         [wx] Unreviewed. Update download URLs to new domain.
876         
877         * waf/build/build_utils.py:
878         (update_wx_deps):
879
880 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
881
882         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
883         to the list of build directories.
884         
885         * waf/build/settings.py:
886
887 2012-01-30  Kentaro Hara  <haraken@chromium.org>
888
889         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
890         output an empty method name (i.e. "()")
891         https://bugs.webkit.org/show_bug.cgi?id=77336
892
893         Reviewed by Darin Adler.
894
895         r105797 tried to detect a change outside methods, but it causes a bug that
896         prepare-ChangeLog can output an empty method name, like this:
897
898             * foo/bar/baz.cpp:
899             (method1):
900             ():
901             (method2):
902
903         This is because the cpp parser in prepare-ChangeLog cannot distinguish
904         '{' as the beginning of a method with '{' as the beginning of an array definition
905         at the top level.
906
907             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
908
909             void func() { // This '{' is the beginning of a method.
910                 ...;
911             }
912
913         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
914
915         * Scripts/prepare-ChangeLog:
916         (get_function_line_ranges_for_cpp): Modified as described above.
917         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
918         an empty method name. Ideally this should not happen but may happen, since the
919         parsers are not perfect.
920         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
921         (NameSpace7):
922         (NameSpace8):
923         (Class109):
924         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
925
926 2012-01-30  Ojan Vafai  <ojan@chromium.org>
927
928         run-webkit-tests calls out to webkit-build-directory twice
929         https://bugs.webkit.org/show_bug.cgi?id=77248
930
931         Reviewed by Dirk Pranke.
932
933         This reduces to calls to webkit-build-directory to one call and
934         saves 500ms for run-webkit-tests over a single file.
935
936         * Scripts/webkit-build-directory:
937         If called with no arguments, print out both the top-level directory and the 
938         configuration directory.
939
940         * Scripts/webkit-build-directory:
941         * Scripts/webkitpy/layout_tests/port/config.py:
942         (Config.build_directory):
943         When called with no arguments, get and cache both the top-level and configuration directories.
944
945         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
946         (main):
947         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
948         (ConfigTest.assert_configuration):
949         (ConfigTest.test_build_directory.mock_webkit_build_directory):
950         (ConfigTest.test_build_directory):
951         (ConfigTest.test_default_configuration__notfound):
952         * Scripts/webkitpy/layout_tests/port/webkit.py:
953         (WebKitPort._build_path):
954         Cache the root directory in the options object so that other users
955         of the options object don't need to call out to webkit-build-directory.
956
957 2012-01-30  Ojan Vafai  <ojan@chromium.org>
958
959         Parsing test_expecations.txt + Skipped lists takes too long
960         https://bugs.webkit.org/show_bug.cgi?id=77059
961
962         Reviewed by Dirk Pranke.
963
964         This saves ~100ms on the Apple Mac port.
965         -memoize a bunch of path methods.
966         -Avoid doing multiple disk accesses per line.
967         -Parse the skipped list directly instead of turning it into a test_expecations.txt
968         formatting string and parsing that.
969
970         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
971         (TestExpectationParser):
972         (TestExpectationParser.expectation_for_skipped_test):
973         (TestExpectationParser._parse_line):
974         (TestExpectationParser._collect_matching_tests):
975         (TestExpectations.__init__):
976         (TestExpectations._add_skipped_tests):
977         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
978         (test_add_skipped_tests):
979         (test_add_skipped_tests_duplicate):
980         * Scripts/webkitpy/layout_tests/port/base.py:
981         (Port):
982         (Port.test_isfile):
983         (Port.normalize_test_name):
984         (Port.layout_tests_dir):
985         (Port.abspath_for_test):
986         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
987
988 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
989
990         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
991         
992         * Scripts/webkitpy/common/config/watchlist:
993
994 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
995
996         Unreviewed build fix following bug#76855
997
998         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
999         ():
1000         (TestWebKitAPI::TEST_F):
1001
1002 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1003
1004         [Qt] WKTR: Use a software rendering pipiline when running tests.
1005         https://bugs.webkit.org/show_bug.cgi?id=76708
1006
1007         Reviewed by Kenneth Rohde Christiansen.
1008
1009         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1010         (WTR::WrapperWindow::WrapperWindow):
1011         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1012
1013 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1014
1015         [Qt] Store build config immediately instead of waiting for a successfull build
1016
1017         Otherwise we will not pick up changes to the config if the build is aborted,
1018         for example due to build errors or if the user pressed Ctrl+Z. We now write
1019         the new config before starting a build, but still defer to write the SVN
1020         revision once the build completes successfully.
1021
1022         Reviewed by Ossy.
1023
1024         * Scripts/webkitdirs.pm:
1025         (buildQMakeProjects):
1026
1027 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
1028
1029         [Qt] Add "New Window" button to the Qt MiniBrowser
1030         https://bugs.webkit.org/show_bug.cgi?id=77281
1031
1032         Reviewed by Tor Arne Vestbø.
1033
1034         * MiniBrowser/qt/BrowserWindow.cpp:
1035         (BrowserWindow::BrowserWindow):
1036         * MiniBrowser/qt/MiniBrowser.qrc:
1037         * MiniBrowser/qt/icons/plus.png: Added.
1038         * MiniBrowser/qt/qml/BrowserWindow.qml:
1039
1040 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
1041
1042         Unreviewed rolling out r106222.
1043
1044         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1045         (SingleTestRunner.__init__):
1046         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1047         (Worker.handle_test_list):
1048         * Scripts/webkitpy/layout_tests/models/test_input.py:
1049         (TestInput.__init__):
1050         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1051         (_set_up_derived_options):
1052         (parse_args):
1053         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1054         (MainTest.test_repeat_each):
1055         * WebKitTestRunner/TestInvocation.cpp:
1056         (WTR::TestInvocation::setIsPixelTest):
1057
1058 2012-01-30  Hans Wennborg  <hans@chromium.org>
1059
1060         Unreviewed, rolling out r106219.
1061         http://trac.webkit.org/changeset/106219
1062         https://bugs.webkit.org/show_bug.cgi?id=77083
1063
1064         This broke Chromium's test_shell.
1065
1066         * DumpRenderTree/DumpRenderTree.gypi:
1067         * DumpRenderTree/chromium/LayoutTestController.cpp:
1068         (LayoutTestController::addMockSpeechInputResult):
1069         * DumpRenderTree/chromium/LayoutTestController.h:
1070         (WebKit):
1071         (LayoutTestController):
1072         ():
1073         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
1074         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
1075         * DumpRenderTree/chromium/TestShell.cpp:
1076         * DumpRenderTree/chromium/WebViewHost.cpp:
1077         (WebViewHost::speechInputController):
1078         * DumpRenderTree/chromium/WebViewHost.h:
1079         (WebKit):
1080         (WebViewHost::speechInputControllerMock):
1081         (WebViewHost):
1082         ():
1083
1084 2012-01-26  Hans Wennborg  <hans@chromium.org>
1085
1086         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
1087         https://bugs.webkit.org/show_bug.cgi?id=77083
1088
1089         Reviewed by Darin Fisher.
1090
1091         Add MockWebSpeechInputController which provides a mock implementation
1092         of the WebSpeechInputController interface, and use that in
1093         DumpRenderTree.
1094
1095         * DumpRenderTree/DumpRenderTree.gypi:
1096         * DumpRenderTree/chromium/LayoutTestController.cpp:
1097         (LayoutTestController::addMockSpeechInputResult):
1098         * DumpRenderTree/chromium/LayoutTestController.h:
1099         ():
1100         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
1101         (MockWebSpeechInputController::create):
1102         (MockWebSpeechInputController::addMockRecognitionResult):
1103         (MockWebSpeechInputController::clearResults):
1104         (MockWebSpeechInputController::startRecognition):
1105         (MockWebSpeechInputController::cancelRecognition):
1106         (MockWebSpeechInputController::stopRecording):
1107         (MockWebSpeechInputController::MockWebSpeechInputController):
1108         (MockWebSpeechInputController::speechTaskFired):
1109         (MockWebSpeechInputController::SpeechTask::SpeechTask):
1110         (MockWebSpeechInputController::SpeechTask::stop):
1111         (MockWebSpeechInputController::SpeechTask::runIfValid):
1112         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
1113         (WebKit):
1114         (MockWebSpeechInputController):
1115         (MockWebSpeechInputController::taskList):
1116         (SpeechTask):
1117         * DumpRenderTree/chromium/TestShell.cpp:
1118         * DumpRenderTree/chromium/WebViewHost.cpp:
1119         (WebViewHost::speechInputController):
1120         * DumpRenderTree/chromium/WebViewHost.h:
1121         (WebKit):
1122         (WebViewHost::speechInputControllerMock):
1123         (WebViewHost):
1124         ():
1125
1126 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1127
1128         Unreviewed, rolling out r106109.
1129         http://trac.webkit.org/changeset/106109
1130         https://bugs.webkit.org/show_bug.cgi?id=77302
1131
1132         It made tests crash (Requested by Ossy_weekend on #webkit).
1133
1134         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1135         (WTR::WrapperWindow::WrapperWindow):
1136         (WTR::PlatformWebView::PlatformWebView):
1137
1138 2012-01-28  Nico Weber  <thakis@chromium.org>
1139
1140         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
1141         https://bugs.webkit.org/show_bug.cgi?id=77243
1142
1143         Reviewed by Adam Barth.
1144
1145         * Scripts/update-webkit:
1146         * Scripts/webkitdirs.pm:
1147         (isChromiumNinja):
1148         (determineIsChromiumNinja):
1149         (buildChromiumNinja):
1150         (buildChromium):
1151
1152 2012-01-27  Kentaro Hara  <haraken@chromium.org>
1153
1154         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
1155         https://bugs.webkit.org/show_bug.cgi?id=77241
1156
1157         Reviewed by Ryosuke Niwa.
1158
1159         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
1160         in a method in some namespace or class is treated as a method.
1161         This patch fixes the bug.
1162
1163             class C {
1164                 void func()
1165                 {
1166                     if (1) {    // This should not be treated as a method.
1167                     }
1168                 }
1169             };
1170
1171         * Scripts/prepare-ChangeLog:
1172         (get_function_line_ranges_for_cpp):
1173         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1174         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1175         (Class108):
1176         (Class108::func35):
1177
1178 2012-01-27  Enrica Casucci  <enrica@apple.com>
1179
1180         Followup to http://trac.webkit.org/changeset/106171.
1181         Dan Bernstein pointed out correctly that I should
1182         have used copy instead of initWithString.
1183
1184         Reviewed by Dan Bernstein.
1185
1186         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1187         (-[LocalPasteboard initWithName:]):
1188
1189 2012-01-27  Enrica Casucci  <enrica@apple.com>
1190
1191         DRT pasteboard object should return the correct pasteboard name.
1192         https://bugs.webkit.org/show_bug.cgi?id=77260
1193         
1194         Currently the name property always returns nil.
1195         Adding a memeber variable to store the pasteboard name and return its
1196         value from the name method instead of returning nil always.
1197
1198         Reviewed by Dan Bernstein.
1199
1200         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1201         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1202         (-[LocalPasteboard initWithName:]):
1203         (-[LocalPasteboard name]):
1204
1205 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
1206
1207         [GTK] [WK2] Implement the policy client
1208         https://bugs.webkit.org/show_bug.cgi?id=76343
1209
1210         Reviewed by Gustavo Noronha Silva.
1211
1212         * gtk/generate-gtkdoc:
1213         (get_webkit2_options): Update the list of skipped source files to include all clients.
1214
1215 2012-01-27  Ada Chan  <adachan@apple.com>
1216
1217         Add test for WKBundleFrameGetParentFrame().
1218         https://bugs.webkit.org/show_bug.cgi?id=77161
1219
1220         Reviewed by Anders Carlsson.
1221
1222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
1223         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
1224         (TestWebKitAPI):
1225         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
1226         (TestWebKitAPI::setInjectedBundleClient):
1227         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
1228         Make sure the check is successful.
1229         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
1230         (TestWebKitAPI):
1231         (ParentFrameTest):
1232         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
1233         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
1234         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
1235         to the test controller.
1236         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
1237
1238 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
1239
1240         [Gtk] DumpRenderTree lacks --no-timeout command line option
1241         https://bugs.webkit.org/show_bug.cgi?id=77196
1242
1243         Reviewed by Martin Robinson.
1244
1245         Add the --no-timeout command line option and reorganize
1246         watchdog code to make running DumpRenderTree without
1247         timeout possible.
1248
1249         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1250         (setWaitToDumpWatchdog):
1251         (shouldSetWaitToDumpWatchdog):
1252         (initializeGlobalsFromCommandLineOptions):
1253         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1254         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1255         (waitToDumpWatchdogFired):
1256         (LayoutTestController::setWaitToDump):
1257
1258 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
1259
1260         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
1261         https://bugs.webkit.org/show_bug.cgi?id=77122
1262
1263         Reviewed by Kenneth Rohde Christiansen.
1264
1265         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1266         (MiniBrowserApplication::MiniBrowserApplication):
1267
1268 2012-01-27  Zeno Albisser  <zeno@webkit.org>
1269
1270         [Qt][Mac] Build fails after adding ICU support (r105997).
1271         https://bugs.webkit.org/show_bug.cgi?id=77118
1272
1273         Define WTF_USE_ICU_UNICODE if we are on mac.
1274
1275         Reviewed by Tor Arne Vestbø.
1276
1277         * qmake/mkspecs/features/features.prf:
1278
1279 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
1280
1281         Update committers.py with new contributors.
1282         https://bugs.webkit.org/show_bug.cgi?id=77207
1283
1284         I added six new contributors into committers.py:
1285
1286         - Adam Kallai
1287         - Balazs Ankes
1288         - Janos Badics
1289         - Nandor Huszka
1290         - Roland Takacs
1291         - Szilard Ledan-Muntean
1292
1293         * Scripts/webkitpy/common/config/committers.py:
1294
1295 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
1296
1297         Add Vsevolod Vlasov to reviewers list.
1298
1299         Reviewed by Pavel Feldman.
1300
1301         * Scripts/webkitpy/common/config/committers.py:
1302
1303 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1304
1305         [Qt] WKTR: Use a software rendering pipiline when running tests.
1306         https://bugs.webkit.org/show_bug.cgi?id=76708
1307
1308         Reviewed by Kenneth Rohde Christiansen.
1309
1310         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1311         (WTR::WrapperWindow::WrapperWindow):
1312         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1313
1314 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1315
1316         [wx] Unreviewed. Build fix, add WebCore/testing/js
1317         to the list of source directories we build.
1318
1319         * waf/build/settings.py:
1320
1321 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
1322
1323         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
1324         https://bugs.webkit.org/show_bug.cgi?id=77177
1325
1326         Reviewed by Jon Honeycutt.
1327
1328         * Scripts/commit-log-editor:
1329
1330 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1331
1332         Decrease sleep time when killing server_process on Mac.
1333         https://bugs.webkit.org/show_bug.cgi?id=77169
1334
1335         Reviewed by Eric Seidel.
1336
1337         This shaves another ~70ms off single test runtime.
1338
1339         * Scripts/webkitpy/layout_tests/port/server_process.py:
1340         (ServerProcess.stop):
1341
1342 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1343
1344         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
1345         https://bugs.webkit.org/show_bug.cgi?id=77164
1346
1347         Reviewed by Dirk Pranke.
1348
1349         http://trac.webkit.org/changeset/106035 depends on builder_name being
1350         falsey by default. There's other code that requires it to be iterable
1351         by default. So, make it be the empty string.
1352
1353         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1354         (parse_args):
1355
1356 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
1357
1358         run-perf-test should include relative file paths in test names
1359         https://bugs.webkit.org/show_bug.cgi?id=77144
1360
1361         Reviewed by Adam Birth.
1362
1363         Include all directory names in the test name separated by "/".
1364         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
1365
1366         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1367         (PerfTestsRunner):
1368         (PerfTestsRunner._process_parser_test_result):
1369         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1370         (test_run_test_set_with_json_output):
1371         (test_run_test_set_with_json_source):
1372
1373 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
1374
1375         webkitpy: re-land cleanup of test scaffolding
1376         https://bugs.webkit.org/show_bug.cgi?id=77153
1377
1378         Reviewed by Eric Seidel.
1379
1380         This is an attempt to reland the change in bug 76973 / 
1381         r105935. My earlier attempt to manipulate PYTHONPATH
1382         seems to only work some of the time, for reasons that
1383         elude me. Directly adding Tools/Scripts to sys.path from
1384         inside the test script appears to work (more?) reliably.
1385
1386         Also, it seemed like the files didn't actually get deleted
1387         the last time; I don't know why.
1388
1389         * Scripts/test-webkitpy:
1390         * Scripts/webkitpy/common/system/executive_unittest.py:
1391         (command_line):
1392         (ExecutiveTest):
1393         (ExecutiveTest.test_run_command_args_type):
1394         (ExecutiveTest.test_run_command_with_unicode):
1395         (ExecutiveTest.test_running_pids):
1396         (main):
1397         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1398         * Scripts/webkitpy/test/cat.py: Removed.
1399         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1400         * Scripts/webkitpy/test/echo.py: Removed.
1401         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1402
1403 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1404
1405         run-webkit-tests calls "nm" when it doesn't need to
1406         https://bugs.webkit.org/show_bug.cgi?id=77143
1407
1408         Reviewed by Dirk Pranke.
1409
1410         If we are not running any test that can be skipped by checking
1411         the DRT feature list or looking at the list of symbols, avoid calling
1412         out to DRT or calling "nm".
1413
1414         This saves ~700ms on my Mac Pro. In cases where you still have to call out
1415         to "nm" it's only a couple ms slower.
1416
1417         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1418         (TestExpectations.__init__):
1419         * Scripts/webkitpy/layout_tests/port/base.py:
1420         (Port.skipped_tests):
1421         * Scripts/webkitpy/layout_tests/port/webkit.py:
1422         (WebKitPort._should_check_for_missing_features):
1423         (WebKitPort):
1424         (WebKitPort._should_check_for_missing_symbols):
1425         (WebKitPort._skipped_tests_for_unsupported_features):
1426         (WebKitPort.skipped_layout_tests):
1427         (WebKitPort.skipped_tests):
1428         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1429         (WebKitPortTest.test_skipped_directories_for_symbols):
1430         (test_skipped_directories_for_features):
1431         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
1432         (test_skipped_layout_tests):
1433
1434 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
1435
1436         Support a suffix on ChangeLog filenames based on a configuration file
1437         https://bugs.webkit.org/show_bug.cgi?id=76956
1438
1439         Reviewed by Kentaro Hara.
1440
1441         Modify the tools used to generate, edit and resolve ChangeLogs to support
1442         the addition of a suffix to the ChangeLog filename.
1443
1444         This patch makes it easier to support alternate ChangeLog files in branches.
1445
1446         * Scripts/VCSUtils.pm:
1447         (changeLogSuffix):
1448         (changeLogFileName):
1449         * Scripts/commit-log-editor:
1450         * Scripts/prepare-ChangeLog:
1451         (getLatestChangeLogs):
1452         (generateNewChangeLogs):
1453         (generateFileList):
1454         * Scripts/resolve-ChangeLogs:
1455         (findChangeLog):
1456
1457 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1458
1459         Unreviewed, rolling out r106038.
1460         http://trac.webkit.org/changeset/106038
1461         https://bugs.webkit.org/show_bug.cgi?id=77142
1462
1463         Caused a bunch of skipped tests to not be skipped. (Requested
1464         by ojan on #webkit).
1465
1466         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1467         (TestExpectationParser):
1468         (TestExpectationParser.parse):
1469         (TestExpectationParser._parse_line):
1470         (TestExpectationParser._collect_matching_tests):
1471         (TestExpectations.__init__):
1472         (TestExpectations._add_skipped_tests):
1473         * Scripts/webkitpy/layout_tests/port/base.py:
1474         (Port.test_dirs):
1475         (Port.normalize_test_name):
1476         (Port.update_baseline):
1477         (Port.layout_tests_dir):
1478         (Port.relative_perf_test_filename):
1479         (Port.abspath_for_test):
1480
1481 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1482
1483         Parsing test_expecations.txt + Skipped lists takes too long
1484         https://bugs.webkit.org/show_bug.cgi?id=77059
1485
1486         Reviewed by Dirk Pranke.
1487
1488         This saves ~100ms on the Apple Mac port.
1489         -memoize a bunch of path methods.
1490         -Avoid doing multiple disk accesses per line.
1491         -Parse the skipped list directly instead of turning it into a test_expecations.txt
1492         formatting string and parsing that.
1493
1494         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1495         (TestExpectationParser):
1496         (TestExpectationParser.parse_skipped_tests):
1497         (TestExpectationParser._parse_line):
1498         (TestExpectationParser._collect_matching_tests):
1499         (TestExpectations.__init__):
1500         (TestExpectations._add_skipped_tests):
1501         * Scripts/webkitpy/layout_tests/port/base.py:
1502         (Port):
1503         (Port.test_isfile):
1504         (Port.normalize_test_name):
1505         (Port.layout_tests_dir):
1506         (Port.abspath_for_test):
1507
1508 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1509
1510         Only store the SVN revision in the summarized results if we're on a builder
1511         https://bugs.webkit.org/show_bug.cgi?id=76976
1512
1513         Reviewed by Dirk Pranke.
1514
1515         This shaves another ~130ms off the single test run-webkit-tests runtime.
1516
1517         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1518         (summarize_results):
1519         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1520         (ResultSummaryTest.get_result):
1521         (ResultSummaryTest):
1522         (ResultSummaryTest.get_result_summary):
1523         (ResultSummaryTest.get_unexpected_results):
1524         (ResultSummaryTest.test_no_svn_revision):
1525         (ResultSummaryTest.test_svn_revision):
1526         * Scripts/webkitpy/layout_tests/port/base.py:
1527         (Port.use_trac_links_in_results_html):
1528
1529 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
1530
1531         [Qt][WK2] fast/loader tests failed after r94178
1532         https://bugs.webkit.org/show_bug.cgi?id=67388
1533
1534         Reviewed by Simon Hausmann.
1535
1536         Applying the same fix used for Qt-WebKit1 from bug #67254 -
1537         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1538         https://bugs.webkit.org/show_bug.cgi?id=67254
1539         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1540         derived from the running location of DumpRenderTree binary.
1541
1542         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1543         (WTR::LayoutTestController::pathToLocalResource):
1544
1545 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1546
1547         Implement overridePreference for boolean preferences in WebKitTestRunner
1548         https://bugs.webkit.org/show_bug.cgi?id=77033
1549
1550         Reviewed by Alexey Proskuryakov.
1551
1552         For now overridePreference supports boolean values.
1553
1554         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1555         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1556         (WTR::LayoutTestController::setXSSAuditorEnabled):
1557         (WTR::LayoutTestController::overridePreference):
1558         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1559         * WebKitTestRunner/TestController.cpp:
1560         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
1561         explicitly and properly disable the use of PageCache when resetting the
1562         state. Tests that use PageCache can now enable it via overridePreference.
1563
1564 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1565
1566         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
1567         https://bugs.webkit.org/show_bug.cgi?id=77100
1568
1569         Reviewed by Simon Hausmann.
1570
1571         This patch makes the MiniBrowser read multiple URL's from the command
1572         line such that there will be one browser window opened for each URL.
1573
1574         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1575         (MiniBrowserApplication::handleUserOptions):
1576
1577 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1578
1579         [Qt] The Qt MiniBrowser crashes when given multiple URL's
1580         https://bugs.webkit.org/show_bug.cgi?id=77009
1581
1582         Reviewed by Simon Hausmann.
1583
1584         This patch fixes a crash in BrowserWindow::newWindow() where a
1585         BrowserWindow-object is constructed with a 0 pointer as the
1586         WindowOptions parameter which leads to a crash.
1587
1588         * MiniBrowser/qt/BrowserWindow.cpp:
1589         (BrowserWindow::BrowserWindow):
1590         (BrowserWindow::newWindow):
1591         * MiniBrowser/qt/BrowserWindow.h:
1592
1593 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1594
1595         [Qt] Use ICU if available
1596         https://bugs.webkit.org/show_bug.cgi?id=76821
1597
1598         Reviewed by Simon Hausmann.
1599
1600         Adding unicode defines for a Qt 5 based build.
1601
1602         * qmake/mkspecs/features/features.prf:
1603
1604 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1605
1606         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
1607         https://bugs.webkit.org/show_bug.cgi?id=42545
1608
1609         Reviewed by Zoltan Herczeg.
1610
1611         Implement the setGeolocationPermission method.
1612
1613         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1614         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1615         (WTR::LayoutTestController::setGeolocationPermission):
1616         (WTR):
1617         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1618         (LayoutTestController):
1619
1620 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
1621
1622         [NRWT] Support --ignore-metrics
1623         https://bugs.webkit.org/show_bug.cgi?id=76278
1624
1625         Reviewed by Tony Chang.
1626
1627         Port the feature from ORWT.
1628
1629         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1630         (SingleTestRunner._run_compare_test):
1631         * Scripts/webkitpy/layout_tests/port/driver.py:
1632         (DriverOutput):
1633         (DriverOutput.strip_metrics):
1634         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1635         (DriverOutputTest):
1636         (DriverOutputTest.test_strip_metrics):
1637         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1638         (_set_up_derived_options):
1639         (parse_args):
1640
1641 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1642
1643         Unreviewed, rolling out r105935 and r105954.
1644         http://trac.webkit.org/changeset/105935
1645         http://trac.webkit.org/changeset/105954
1646         https://bugs.webkit.org/show_bug.cgi?id=77080
1647
1648         test-webkitpy is still broken (Requested by abarth on
1649         #webkit).
1650
1651         * Scripts/test-webkitpy:
1652         * Scripts/webkitpy/common/system/executive_unittest.py:
1653         (never_ending_command):
1654         (ExecutiveTest.test_run_command_args_type):
1655         (ExecutiveTest.test_run_command_with_unicode):
1656         (ExecutiveTest.test_running_pids):
1657         * Scripts/webkitpy/common/system/fileutils.py:
1658         (make_stdout_binary):
1659         * Scripts/webkitpy/test/cat.py:
1660         (command_arguments):
1661         (main):
1662         * Scripts/webkitpy/test/cat_unittest.py:
1663         (CatTest):
1664         (CatTest.assert_cat):
1665         (CatTest.test_basic):
1666         (CatTest.test_no_newline):
1667         (CatTest.test_unicode):
1668         (CatTest.test_as_command):
1669         * Scripts/webkitpy/test/echo.py:
1670         (command_arguments):
1671         (main):
1672         * Scripts/webkitpy/test/echo_unittest.py:
1673         (EchoTest):
1674         (EchoTest.test_basic):
1675         (EchoTest.test_no_newline):
1676         (EchoTest.test_unicode):
1677         (EchoTest.test_argument_order):
1678         (EchoTest.test_empty_arguments):
1679         (EchoTest.test_no_arguments):
1680         (EchoTest.test_as_command):
1681
1682 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
1683
1684         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
1685         https://bugs.webkit.org/show_bug.cgi?id=76138
1686
1687         Reviewed by Martin Robinson.
1688
1689         * Scripts/webkitdirs.pm:
1690         (isCrossCompilation):
1691         (buildAutotoolsProject):
1692
1693 2012-01-25  Adam Barth  <abarth@webkit.org>
1694
1695         Kentaro is a reviewer now.  Yay!
1696
1697         * Scripts/webkitpy/common/config/committers.py:
1698
1699 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1700
1701         nrwt: running w/ no arguments fails
1702         https://bugs.webkit.org/show_bug.cgi?id=77064
1703
1704         Unreviewed, build fix.
1705
1706         This change fixes a regression introduced in r105944
1707         where running without --platform <foo> or one of the other
1708         platform switches would cause a null deref :(.
1709
1710         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1711         (main):
1712
1713 2012-01-25  Eric Seidel  <eric@webkit.org>
1714
1715         Automatically CC someone from Apple on any changes to Obj-C public API
1716         https://bugs.webkit.org/show_bug.cgi?id=77053
1717
1718         Reviewed by Timothy Hatcher.
1719
1720         This has long been de-facto practice, seems now that we have
1721         fancy watchlist support, we should just make the tools
1722         do this automatically.
1723
1724         * Scripts/webkitpy/common/config/watchlist:
1725
1726 2012-01-25  Antoine Labour  <piman@chromium.org>
1727
1728         Updating status in committers.py.
1729
1730         Unreviewed.
1731
1732         * Scripts/webkitpy/common/config/committers.py:
1733
1734 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1735
1736         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
1737         https://bugs.webkit.org/show_bug.cgi?id=77058
1738
1739         Reviewed by Eric Seidel.
1740
1741         r105935 broke executive_unittest by changing which script we
1742         were running and not ensuring that the PYTHONPATH was set up
1743         properly.
1744
1745         This change also fixes a regression introduced recently where
1746         test-webkitpy wasn't figuring out the path to Tools/Scripts
1747         right, either (so running ./test-webkitpy would fail).
1748
1749         * Scripts/test-webkitpy:
1750         * Scripts/webkitpy/common/system/executive_unittest.py:
1751         (script_dir):
1752         (ExecutiveTest.setUp):
1753         (ExecutiveTest):
1754         (ExecutiveTest.tearDown):
1755
1756 2012-01-25  Adam Barth  <abarth@webkit.org>
1757
1758         Disable tests on the mac-ews while we sort out hte stability issues.
1759
1760         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1761         (MacEWS):
1762
1763 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1764
1765         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
1766         https://bugs.webkit.org/show_bug.cgi?id=76475
1767
1768         Reviewed by Eric Seidel.
1769
1770         This patch cleans up the internal usage of port names for the
1771         Apple mac and Apple win ports so that 'mac' and 'win are never
1772         considered "fully specified" port names: they are still legal
1773         input to the PortFactory.get() routine, but only if run on the given
1774         platform (i.e. trying to PortFactory.get('mac') on windows or
1775         linux will return an error, since we don't know which version of
1776         the port is desired.
1777
1778         This also cleans up handling of the webkit2 variants, so that
1779         the full port names consistently follow the
1780         <operating_system>-<version>[-<wk2>] convention.
1781
1782         Lastly this patch adds some assertions and removes some
1783         try/catch logic to catch more programming and usage errors;
1784         previously mac-tiger might've been allowed -- and it would've
1785         translated into using just the baselines in platform/mac -- but
1786         now it should fail.
1787
1788         * Scripts/webkitpy/layout_tests/port/apple.py:
1789         (ApplePort.determine_full_port_name):
1790         (ApplePort.__init__):
1791         (ApplePort):
1792         (ApplePort._port_name_with_version):
1793         * Scripts/webkitpy/layout_tests/port/builders.py:
1794         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1795         (FactoryTest.test_mac):
1796         (FactoryTest.test_win):
1797         * Scripts/webkitpy/layout_tests/port/mac.py:
1798         (MacPort.baseline_search_path):
1799         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1800         (MacTest.test_versions):
1801         * Scripts/webkitpy/layout_tests/port/win.py:
1802         (WinPort.baseline_search_path):
1803         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1804         (WinTest.test_versions):
1805
1806 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1807
1808         webkitpy: print nicer errors while linting expectations files, remove redundant tests
1809         https://bugs.webkit.org/show_bug.cgi?id=76955
1810
1811         Reviewed by Adam Barth.
1812
1813         This change cleans up the errors that are printed so that the
1814         are more "quickfix" compatible (path:lineno).
1815
1816         Also, there were a bunch of redundant tests between
1817         layout_tests.models.test_expectations_unittest and
1818         style.checkers.test_expectations_unittest. The latter should
1819         just expect the former to do most of the testing.
1820
1821         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1822         (TestExpectationParser._parse_modifiers):
1823         (TestExpectations._report_errors):
1824         (TestExpectations._add_skipped_tests):
1825         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1826         (test_parse_error_nonfatal):
1827         (SemanticTests.test_bad_bugid):
1828         * Scripts/webkitpy/style/checkers/test_expectations.py:
1829         (TestExpectationsChecker.__init__):
1830         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1831         (TestExpectationsTestCase.assert_lines_lint):
1832         (TestExpectationsTestCase.test_valid_expectations):
1833         (TestExpectationsTestCase.test_invalid_expectations):
1834         (TestExpectationsTestCase.test_tab):
1835
1836 2012-01-25  Eric Seidel  <eric@webkit.org>
1837
1838         webkit-patch apply-* should always continue after failures
1839         https://bugs.webkit.org/show_bug.cgi?id=77057
1840
1841         Reviewed by Adam Barth.
1842
1843         As far as I can tell there is only one potential drawback to always
1844         forcing: that if you're somehow in the wrong directory it will create new
1845         directories for new files.  Since webkit-patch always cd's to the root
1846         it seems that's not a drawback.  The drawback of not using --force for
1847         svn-apply, is that it will stop after the first failure, which is rarely
1848         (if ever) the desired behavior.  This just removes the force option
1849         (which was strangely hidden behind --non-interactive).  This should
1850         make for a better user experiance.
1851
1852         * Scripts/webkitpy/common/checkout/checkout.py:
1853         (Checkout.apply_patch):
1854         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1855         (MockCheckout.apply_patch):
1856         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1857         (CheckoutTest.test_chromium_deps):
1858         (CheckoutTest):
1859         (CheckoutTest.test_apply_patch):
1860         * Scripts/webkitpy/tool/commands/download_unittest.py:
1861         (DownloadCommandsTest._default_options):
1862         * Scripts/webkitpy/tool/steps/applypatch.py:
1863         (ApplyPatch.options):
1864         (ApplyPatch.run):
1865         * Scripts/webkitpy/tool/steps/options.py:
1866         (Options):
1867
1868 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1869
1870         nrwt: should be able to run --platform test interactively
1871         https://bugs.webkit.org/show_bug.cgi?id=76959
1872
1873         Reviewed by Adam Barth.
1874
1875         As part of refactoring the Port interfaces, in r103254 I made
1876         passing a Host object to the Port mandatory; previously TestPort
1877         objects would create their own (mock) hosts. However,
1878         new-run-webkit-tests always passed a real Host, not a MockHost,
1879         and so you couldn't run new-run-webkit-tests --platform test
1880         interactively to debug test failures.
1881
1882         This change fixes that by creating a MockHost instead of a real
1883         host if you say --platform test*.
1884
1885         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1886         (main):
1887
1888 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1889
1890         run-webkit-tests --lint-test-files should lint all the ports by default
1891         https://bugs.webkit.org/show_bug.cgi?id=76749
1892
1893         Reviewed by Ojan Vafai.
1894
1895         Currently run-webkit-tests --lint-test-files will only lint the
1896         test_expectations for the single port determined by the command
1897         line options. This is not obvious and can produce unintended results
1898         if you want to lint the chromium port (probably the normal case
1899         for using --lint-test-files) but don't specify a port name or
1900         --chromium.
1901
1902         I think we should probably lint *all* of the ports if no port
1903         name is supplied. This change implements that, and also moves
1904         the linting logic out of the Manager class, since this really
1905         has nothing to do with Managers. It has little to do with
1906         run-webkit-tests, but splitting it into a different script would
1907         introduce compatibility issues. It might make sense to do that
1908         anyway, in a separate patch and combining that with cleaning up
1909         the style checker to share more code.
1910
1911         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1912         (Manager._strip_test_dir_prefix):
1913         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1914         (lint):
1915         (run):
1916         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1917         (LintTest.test_all_configurations): added.
1918         (LintTest.test_lint_test_files): added.
1919         (LintTest.test_lint_test_files__errors): added.
1920         (MainTest.test_lint_test_files): removed.
1921         (MainTest.test_lint_test_files__errors): removed.
1922
1923 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1924
1925         webkitpy: clean up a bunch of test scaffolding
1926         https://bugs.webkit.org/show_bug.cgi?id=76973
1927
1928         Reviewed by Eric Seidel.
1929
1930         There were several helper modules in the webkitpy.test package
1931         that appear to only be used by executive_unittest.py. I am
1932         rolling them all into that file to make that clearer.
1933
1934         * Scripts/webkitpy/common/system/executive_unittest.py:
1935         (ExecutiveTest.test_run_command_args_type):
1936         (ExecutiveTest.test_run_command_with_unicode):
1937         (ExecutiveTest.test_running_pids):
1938         (command_line):
1939         (main):
1940         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1941         * Scripts/webkitpy/test/cat.py: Removed.
1942         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1943         * Scripts/webkitpy/test/echo.py: Removed.
1944         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1945
1946 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1947
1948         webkitpy: clean up a bunch of test scaffolding
1949         https://bugs.webkit.org/show_bug.cgi?id=76973
1950
1951         Reviewed by Eric Seidel.
1952
1953         There were several helper modules in the webkitpy.test package
1954         that appear to only be used by executive_unittest.py. I am
1955         rolling them all into that file to make that clearer.
1956
1957         * Scripts/webkitpy/common/system/executive_unittest.py:
1958         (ExecutiveTest.test_run_command_args_type):
1959         (ExecutiveTest.test_run_command_with_unicode):
1960         (ExecutiveTest.test_running_pids):
1961         (command_line):
1962         (main):
1963         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1964         * Scripts/webkitpy/test/cat.py: Removed.
1965         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1966         * Scripts/webkitpy/test/echo.py: Removed.
1967         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1968
1969 2012-01-25  Eric Seidel  <eric@webkit.org>
1970
1971         Remove Python 2.5 support from WebKit
1972         https://bugs.webkit.org/show_bug.cgi?id=71593
1973
1974         Reviewed by Adam Barth.
1975
1976         Just removing support from this one core file.
1977         I'll commit the rest of the (large) change once we've
1978         gone 24 hours and seen that no bots have exploded.
1979         We can roll out this one change if we break bots
1980         and then roll in the rest once those bots are fixed.
1981
1982         * Scripts/webkitpy/common/system/executive.py:
1983         (Executive.cpu_count):
1984
1985 2012-01-25  Hajime Morita  <morrita@google.com>
1986
1987         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
1988         https://bugs.webkit.org/show_bug.cgi?id=76863
1989
1990         Reviewed by Dimitri Glazkov.
1991
1992         Added a feature flag.
1993
1994         * Scripts/build-webkit:
1995         * qmake/mkspecs/features/features.prf:
1996
1997 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
1998
1999         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
2000         https://bugs.webkit.org/show_bug.cgi?id=76344
2001
2002         Reviewed by Sam Weinig.
2003
2004         Add a test verifying that the mouse button during policy decisions for
2005         events not triggered by mouse events is NoButton.
2006
2007         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2008         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
2009         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
2010
2011 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2012
2013         run-perf-tests should timeout sooner
2014         https://bugs.webkit.org/show_bug.cgi?id=77026
2015
2016         Reviewed by Adam Barth.
2017
2018         Bump off the timeout from 10 minutes to 4 minutes.
2019
2020         Also use float instead of str in test result values to compress the size of json files bots upload.
2021
2022         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2023         (PerfTestsRunner._parse_args):
2024         (PerfTestsRunner._process_chromium_style_test_result):
2025         (PerfTestsRunner._process_parser_test_result):
2026         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2027         (test_run_test_set_for_parser_tests):
2028         (test_run_test_set_with_json_output):
2029         (test_run_test_set_with_json_source):
2030
2031 2012-01-25  Enrica Casucci  <enrica@apple.com>
2032
2033         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2034         https://bugs.webkit.org/show_bug.cgi?id=76951
2035         <rdar://problem/9325158>
2036
2037         Reviewed by Alexey Proskuryakov.
2038
2039         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
2040         and WebHTMLView.
2041         (TestWebKitAPI::TEST):
2042
2043 2012-01-23  MORITA Hajime  <morrita@google.com>
2044
2045         [Refactoring][Internals] Should have InternalSettings
2046         https://bugs.webkit.org/show_bug.cgi?id=76424
2047
2048         Reviewed by Kent Tamura.
2049
2050         * GNUmakefile.am: Added so new files.
2051
2052 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
2053
2054         webkitpy: new-run-webkit-websocket is broken
2055         https://bugs.webkit.org/show_bug.cgi?id=76999
2056
2057         Reviewed by Dirk Pranke.
2058
2059         r105674 broke new-run-webkit-websocket, since options.chromium
2060         doesn't exist any more. new-run-webkit-httpd was also broken
2061         and already fixed at r105835.
2062         * Scripts/new-run-webkit-websocketserver:
2063         (main):
2064
2065 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
2066
2067         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
2068         https://bugs.webkit.org/show_bug.cgi?id=63458
2069
2070         Reviewed by Adam Roben.
2071
2072         Implement the setPopupBlockingEnabled method.
2073
2074         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2075         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2076         (WTR::LayoutTestController::setPopupBlockingEnabled):
2077         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2078
2079 2012-01-24  Balazs Kelemen  <kbalazs@webkit.org>
2080
2081         [Qt] Cleanup testfonts handling
2082         https://bugs.webkit.org/show_bug.cgi?id=76068
2083
2084         Reviewed by Simon Hausmann.
2085
2086         Factor test font initialization into it's own file  so test
2087         font users can share the implementation by adding the file
2088         to their build.
2089         Use fonts.conf from the test font directory to not require the
2090         current directory to be the WebKit root.
2091         Fix the -use-test-fonts option of QtTestBrowser by initializing
2092         the fonts earlier, before it is too late (namely before calling
2093         show on the main window).
2094
2095         * DumpRenderTree/qt/DumpRenderTree.pro:
2096         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2097         (WebCore::DumpRenderTree::open):
2098         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2099         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
2100         (WebKit::initializeTestFonts):
2101         * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
2102         * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
2103         we will use the one from the test fonts directory.
2104         * DumpRenderTree/qt/main.cpp:
2105         (main): Fix the ifdefs to make it clear that the code to
2106         set up the Dpi has not been ported to Qt5 yet.
2107         * QtTestBrowser/QtTestBrowser.pro:
2108         * QtTestBrowser/launcherwindow.h:
2109         (WindowOptions::WindowOptions):
2110         * QtTestBrowser/main.cpp:
2111         (launcherMain):
2112         (LauncherApplication::handleUserOptions):
2113         * WebKitTestRunner/InjectedBundle/Target.pri:
2114         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2115         (WTR::activateFonts): Remove the code to set up the Dpi
2116         because it does not work with Qt5.
2117
2118 2012-01-25  Simon Hausmann  <simon.hausmann@nokia.com>
2119
2120         [Qt] build-webkit --qt requires a git-svn or SVN checkout.
2121
2122         Reviewed by Tor Arne Vestø.
2123
2124         Don't require it by making svnRevisionForDirectory return "unknown"
2125         instead of bailing out with an error.
2126
2127         * Scripts/VCSUtils.pm:
2128         (svnRevisionForDirectory):
2129
2130 2012-01-25  Adam Barth  <abarth@webkit.org>
2131
2132         Temporarily disable running the unit tests on the Chromium EWS.  These
2133         tests don't work properly (see
2134         https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
2135         blocking the EWS.
2136
2137         * Scripts/webkitpy/common/config/ports.py:
2138         (ChromiumPort):
2139
2140 2012-01-25  Adam Barth  <abarth@webkit.org>
2141
2142         Update results.html version of PixelZoomer
2143         https://bugs.webkit.org/show_bug.cgi?id=76965
2144
2145         Reviewed by Ojan Vafai.
2146
2147         Improve readability as suggested by Ojan.
2148
2149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2150
2151 2012-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2152
2153         [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
2154         https://bugs.webkit.org/show_bug.cgi?id=76899
2155
2156         Reviewed by Martin Robinson.
2157
2158         * gtk/generate-gtkdoc:
2159         (get_webkit2_options): WebKitWebLoaderClient has been renamed to
2160         WebKitLoaderClient.
2161
2162 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2163
2164         Build fix. Trigger Chromium Mac Release (Perf) on new commits.
2165
2166         * BuildSlaveSupport/build.webkit.org-config/config.json:
2167
2168 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2169
2170         WebKit needs public performance tests running on public bots
2171         https://bugs.webkit.org/show_bug.cgi?id=10266
2172
2173         Reviewed by Adam Barth.
2174
2175         Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
2176         and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
2177
2178         * BuildSlaveSupport/build.webkit.org-config/config.json:
2179         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2180         (RunAndUploadPerfTests):
2181         (RunAndUploadPerfTests.start):
2182         (UploadPerfTestResults):
2183         (BuildAndPerfTestFactory):
2184         (BuildAndPerfTestFactory.__init__):
2185
2186 2012-01-24  Ojan Vafai  <ojan@chromium.org>
2187
2188         Initializing the browser property of the Bugzilla class takes too long
2189         https://bugs.webkit.org/show_bug.cgi?id=76960
2190
2191         Reviewed by Adam Barth.
2192
2193         Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
2194         on my Mac Pro.
2195
2196         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2197         (Bugzilla.__init__):
2198         (Bugzilla._get_browser):
2199         (Bugzilla):
2200         (Bugzilla._set_browser):
2201
2202 2012-01-24  Mark Rowe  <mrowe@apple.com>
2203
2204         Death to JavaScriptGlue.
2205
2206         Rubber-stamped by Geoffrey Garen.
2207
2208         * BuildSlaveSupport/build-launcher-app:
2209         (copyNightlyLauncher):
2210         * Scripts/build-webkit:
2211         * Scripts/do-file-rename:
2212         * Scripts/do-webcore-rename:
2213         * Scripts/webkitpy/common/config/build.py:
2214         (_should_file_trigger_build):
2215         * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
2216         path in conjunction with a cross-platform path.
2217         (ShouldBuildTest):
2218
2219 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2220
2221         webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
2222         https://bugs.webkit.org/show_bug.cgi?id=75836
2223
2224         Reviewed by David Kilzer.
2225
2226         Previously parser_unittests.pl can just test the returned value of
2227         get_function_line_ranges() in prepare-ChangeLog. This patch fixes
2228         parser_unittests.pl so that it also tests the stdout and stderr of
2229         get_function_line_ranges().
2230
2231         This patch adds css_unittests_warning.css, which contains test cases
2232         for warning messages of the CSS parser of prepare-ChangeLog.
2233
2234         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2235         (captureOutput): Captures the stdout and stderr of a given method.
2236         (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
2237         string to relative paths.
2238
2239         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
2240         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
2241         (element1):
2242         (element2):
2243         (element3):
2244         (element4):
2245         ():
2246         (element5):
2247         (element6):
2248
2249         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2250         Just updated the test results, i.e. added stdout and stderr results.
2251         No essential changes in the test results.
2252         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
2253         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
2254         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
2255         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
2256         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
2257
2258 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2259
2260         webkitpy: new-run-webkit-httpd is broken
2261         https://bugs.webkit.org/show_bug.cgi?id=76963
2262
2263         Reviewed by Adam Barth.
2264
2265         r105674 broke new-run-webkit-httpd, since options.chromium
2266         doesn't exist any more. We didn't catch this because we don't
2267         run the integration tests by default anywhere :(.
2268
2269         * Scripts/new-run-webkit-httpd:
2270         (run):
2271         (main):
2272
2273 2012-01-24  Adam Barth  <abarth@webkit.org>
2274
2275         garden-o-matic pixel zoomer should let you look at every pixel of the image
2276         https://bugs.webkit.org/show_bug.cgi?id=76962
2277
2278         Reviewed by Ojan Vafai.
2279
2280         Previously, you couldn't get up to the right and bottom pixels.
2281
2282         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2283
2284 2012-01-24  Enrica Casucci  <enrica@apple.com>
2285
2286         WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2287         https://bugs.webkit.org/show_bug.cgi?id=76951
2288         <rdar://problem/9325158>
2289
2290         Added test to verify that WebHTMLView supports the typingAttributes method and that it
2291         works as expected.
2292         
2293         Reviewed by Alexey Proskuryakov.
2294
2295         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2296         (TestWebKitAPI::TEST):
2297
2298 2012-01-24  James Robinson  <jamesr@chromium.org>
2299
2300         Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
2301         https://bugs.webkit.org/show_bug.cgi?id=76884
2302
2303         Reviewed by Adam Barth.
2304
2305         * Scripts/webkitpy/tool/bot/irc_command.py:
2306         (Rollout.execute):
2307         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2308         (SheriffIRCBotTest.test_rollout):
2309         (SheriffIRCBotTest.test_revert):
2310         (SheriffIRCBotTest.test_multi_rollout):
2311         (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
2312         (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2313         (SheriffIRCBotTest.test_rollout_invalidate_reason):
2314         (test_multi_rollout_invalidate_reason):
2315
2316 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2317
2318         The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
2319         https://bugs.webkit.org/show_bug.cgi?id=75531
2320
2321         Reviewed by David Kilzer.
2322
2323         Previously, the cpp parser of prepare-ChangeLog could not detect a change
2324         outside methods. Consider the following cpp file.
2325
2326             namespace N {
2327             int a;     // this change does not appear on ChangeLog.
2328             class C {
2329                 int b;     // this change does not appear on ChangeLog.
2330                 void f()
2331                 {
2332                     int c;     // this change appears on ChangeLog.
2333                 }
2334                 int d;     // this change does not appear on ChangeLog.
2335             };
2336             int e;     // this change does not appear on ChangeLog.
2337             };
2338
2339         The previous prepare-ChangeLog outputs just methods in which a change is found:
2340             (N::C::f):
2341
2342         This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
2343         and methods in which a change is found:
2344             (N):
2345             (N::C):
2346             (N::C::f):
2347
2348         * Scripts/prepare-ChangeLog:
2349         (get_function_line_ranges_for_cpp): Modified as described above.
2350
2351         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
2352         (Class104):
2353         (Class105):
2354         (Class106):
2355         (Class106::func32):
2356         (Class106::func33):
2357         (NameSpace3):
2358         (NameSpace4):
2359         (NameSpace5):
2360         (NameSpace6):
2361         (Class107):
2362         (NameSpace5::NameSpace6::Class107::func34):
2363         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2364
2365 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2366
2367         prepare-ChangeLog outputs warnings for top-level { ... } blocks
2368         https://bugs.webkit.org/show_bug.cgi?id=75943
2369
2370         Reviewed by David Kilzer.
2371
2372         Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
2373         because it does not distinguish '}' at the end of a subroutine
2374         with '}' at the end of a if or for statement.
2375
2376         foo.pl:
2377             if (1) {
2378             }
2379             for (@v) {
2380             }
2381
2382         output:
2383             nested functions found at top-level at foo.pl:2
2384             nested functions found at top-level at foo.pl:4
2385
2386         This patch fixes the bug.
2387
2388         * Scripts/prepare-ChangeLog:
2389         (get_function_line_ranges_for_perl):
2390         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2391         Added test cases. No change in the test results.
2392
2393 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2394
2395         r105674 broke check-webkit-style for chromium's test_expectations.
2396
2397         Unreviewed, build fix.
2398         
2399         We now need to pass in a platform name of 'chromium' if we want
2400         the chromium port; options.chromium is no longer recognized. I
2401         will follow this patch up with a separate patch that has a test,
2402         but this at least fixes the build.
2403
2404         * Scripts/webkitpy/style/checkers/test_expectations.py:
2405         (TestExpectationsChecker._determine_port_from_exepectations_path):
2406
2407 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2408
2409         check-webkit-style of the chromium test_expectations.txt file takes too long
2410         https://bugs.webkit.org/show_bug.cgi?id=76745
2411
2412         Reviewed by Dimitri Glazkov.
2413
2414         When in lint mode, have TestExpectations test all configurations instead
2415         of looping over each configuration. This also has the benefit of making
2416         the error output considerably more concise.
2417
2418         Also, got rid of the double-printing of errors when linting through check-webkit-style.
2419
2420         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2421         (Manager.lint):
2422         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2423         (TestExpectations._report_errors):
2424         (TestExpectations._add_expectations):
2425         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2426         (test_parse_error_nonfatal):
2427         (test_error_on_different_platform):
2428         * Scripts/webkitpy/style/checkers/test_expectations.py:
2429         (TestExpectationsChecker.check_test_expectations):
2430         (TestExpectationsChecker.check):
2431         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2432         (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
2433         (TestExpectationsTestCase.assert_lines_lint):
2434
2435 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2436
2437         Another build fix attempt after r105543.
2438
2439         * Scripts/webkitpy/common/net/file_uploader.py:
2440         (FileUploader.upload_as_multipart_form_data):
2441
2442 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2443
2444         Build fix attempt after r105543.
2445
2446         * Scripts/webkitpy/common/net/file_uploader.py:
2447         (FileUploader.upload_as_multipart_form_data):
2448
2449 2012-01-24  Vincent Scheib  <scheib@chromium.org>
2450
2451         [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
2452         https://bugs.webkit.org/show_bug.cgi?id=76411
2453
2454         Reviewed by Adam Barth.
2455
2456         Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
2457         into a series of patches, this change adds a trivial
2458         pointer lock implementation to the Chromium port's DumpRenderTree
2459         and exposes LayoutTestController hooks to force failure conditions.
2460
2461         * DumpRenderTree/chromium/LayoutTestController.cpp:
2462         (LayoutTestController::LayoutTestController):
2463         (LayoutTestController::didLosePointerLock):
2464         (LayoutTestController::setPointerLockWillFailAsynchronously):
2465         (LayoutTestController::setPointerLockWillFailSynchronously):
2466         * DumpRenderTree/chromium/LayoutTestController.h:
2467         * DumpRenderTree/chromium/WebViewHost.cpp:
2468         (WebViewHost::requestPointerLock):
2469         (WebViewHost::requestPointerUnlock):
2470         (WebViewHost::isPointerLocked):
2471         (WebViewHost::didCompletePointerLock):
2472         (WebViewHost::didNotCompletePointerLock):
2473         (WebViewHost::didLosePointerLock):
2474         (WebViewHost::reset):
2475         * DumpRenderTree/chromium/WebViewHost.h:
2476         (WebViewHost::setPointerLockWillFailAsynchronously):
2477         (WebViewHost::setPointerLockWillFailSynchronously):
2478
2479 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
2480
2481         Unreviewed, skip WK2 API test timing out on some GTK bots.
2482
2483         WebKit2APITests/TestDownloads is consistently timing out on the
2484         32bit release and 64bit debug bots.
2485
2486         * Scripts/run-gtk-tests:
2487         (TestRunner): Skip WebKit2APITests/TestDownloads.
2488
2489 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2490
2491         [Qt] Fix the build with the newes Qt5 hashes
2492         https://bugs.webkit.org/show_bug.cgi?id=76657
2493
2494         Reviewed by Simon Hausmann.
2495
2496         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2497         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
2498         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
2499
2500 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2501
2502         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
2503
2504         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
2505         building with MinGW inside cmd.exe will require the same construct. Instead
2506         we assume that when the first character in PWD is a '/' we're running under
2507         Cygwin, and use the normal unix way of setting environment variables.
2508
2509         Reviewed by Simon Hausmann.
2510
2511         * qmake/mkspecs/features/default_pre.prf:
2512
2513 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
2514
2515         Some qmake build files must include Qt5's "quick" module.
2516         https://bugs.webkit.org/show_bug.cgi?id=76671
2517
2518         Unreviewed build fix.
2519
2520         * MiniBrowser/qt/MiniBrowser.pro:
2521         * WebKitTestRunner/Target.pri:
2522
2523 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2524
2525         [Qt] Fix the event timestamps for touch mocking
2526
2527         Reviewed by Simon Hausmann.
2528
2529         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2530         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
2531         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
2532
2533 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2534
2535         [GTK] Implement DownloadClient in WebKit2 GTK+ API
2536         https://bugs.webkit.org/show_bug.cgi?id=72952
2537
2538         Reviewed by Martin Robinson.
2539
2540         * gtk/generate-gtkdoc:
2541         (get_webkit2_options): Ignore WebKitDownloadClient.
2542
2543 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
2544
2545         [GTK] editing/deleting/5408255.html results are incorrect
2546         https://bugs.webkit.org/show_bug.cgi?id=53644
2547
2548         Reviewed by Martin Robinson.
2549
2550         WEBKIT_TOP_LEVEL environment variable is now set directly in either
2551         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
2552         macro. This way both tools can be run outside the test harness without
2553         the need to manually set the environment variable.
2554
2555         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2556         (getTopLevelPath):
2557         * GNUmakefile.am:
2558         * Scripts/webkitpy/layout_tests/port/gtk.py:
2559         (GtkPort.setup_environ_for_server):
2560         * WebKitTestRunner/GNUmakefile.am:
2561         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2562         (WTR::InjectedBundle::platformInitialize):
2563
2564 2012-01-23  Dmitry Lomov  <dslomov@google.com>
2565
2566         [Chromium] Implement layoutTestController.workerThreadCount in DRT
2567         https://bugs.webkit.org/show_bug.cgi?id=74653.
2568
2569         Reviewed by Darin Fisher.
2570
2571         * DumpRenderTree/chromium/LayoutTestController.cpp:
2572         (LayoutTestController::LayoutTestController):
2573         (LayoutTestController::workerThreadCount):
2574         * DumpRenderTree/chromium/LayoutTestController.h:
2575
2576 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2577
2578         nrwt: make --chromium work like --qt
2579         https://bugs.webkit.org/show_bug.cgi?id=76875
2580
2581         Reviewed by Adam Barth.
2582
2583         --chromium used to have to be handled differently from --qt
2584         due to the way the PortFactory was implemented; there's not
2585         really a good reason for that any more so this patch makes
2586         things slightly more consistent and eliminates the
2587         options.chromium flag (--chromium is now truly a synonym for
2588         --platform chromium).
2589
2590         * Scripts/webkitpy/layout_tests/port/factory.py:
2591         (PortFactory._default_port):
2592         (PortFactory.get):
2593         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2594         (FactoryTest.setUp):
2595         (FactoryTest.test_chromium_mac):
2596         (FactoryTest.test_chromium_linux):
2597         (FactoryTest.test_chromium_win):
2598         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2599         (parse_args):
2600
2601 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2602
2603         run-webkit-tests needs to propagate --chromium
2604         https://bugs.webkit.org/show_bug.cgi?id=76870
2605
2606         Reviewed by Eric Seidel.
2607
2608         run-webkit-tests removes '--chromium' argument from @ARGV when
2609         determining which port to run, which means that that doesn't
2610         propagate to new-run-webkit-tests. That's bad (and is handled
2611         for the other ports by re-adding the flag, but apparently we're
2612         just now noticing for Chromium).
2613
2614         * Scripts/run-webkit-tests:
2615
2616 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
2617
2618         More build fixing after r105646.
2619
2620         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2621         (TestWebKitAPI::TestNode::key):
2622
2623 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
2624
2625         Unreviewed build fix - r105646 broke this.
2626
2627         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2628         (TestWebKitAPI::TestNode::TestNode):
2629         (TestWebKitAPI::TestNode::key):
2630         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
2631         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
2632         (TestWebKitAPI::RedBlackTreeTest::testDriver):
2633
2634 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2635
2636         Unreviewed, rolling out r105658.
2637         http://trac.webkit.org/changeset/105658
2638         https://bugs.webkit.org/show_bug.cgi?id=76883
2639
2640         We want this eventually, but not right at this moment
2641         (Requested by abarth on #webkit).
2642
2643         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2644
2645 2012-01-23  Adam Barth  <abarth@webkit.org>
2646
2647         garden-o-matic should support Chromium Mac Lion
2648         https://bugs.webkit.org/show_bug.cgi?id=76880
2649
2650         Reviewed by Eric Seidel.
2651
2652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2653
2654 2012-01-23  Emil A Eklund  <eae@chromium.org>
2655
2656         check-webkit-style whitespace/operators triggers on overloaded division operator
2657         https://bugs.webkit.org/show_bug.cgi?id=76650
2658
2659         Reviewed by Darin Adler.
2660
2661         * Scripts/webkitpy/style/checkers/cpp.py:
2662         (check_spacing):
2663         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2664         (CppStyleTest.test_operator_methods):
2665
2666 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2667
2668         run-perf-tests should report server-side errors
2669         https://bugs.webkit.org/show_bug.cgi?id=76802
2670
2671         Reviewed by Tony Chang.
2672
2673         Report errors whenever server's response doesn't match "OK".
2674
2675         * Scripts/webkitpy/common/net/file_uploader.py:
2676         (FileUploader.upload_single_text_file):
2677         (FileUploader.upload_as_multipart_form_data):
2678         (FileUploader._upload_data.callback):
2679         (FileUploader):
2680         (FileUploader._upload_data):
2681         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2682         (PerfTestsRunner._upload_json):
2683         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2684         (test_upload_json):
2685         (test_upload_json.MockFileUploader.upload_single_text_file):
2686
2687 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2688
2689         run-perf-tests ignore Skipped list on chromium
2690         https://bugs.webkit.org/show_bug.cgi?id=76764
2691
2692         Reviewed by Dirk Pranke.
2693
2694         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
2695         can also find skipped list. Chromium port only uses test_expectations.txt for
2696         layout tests but performacne tests don't use test_expectations.txt so Chromium port
2697         also needs to use Skipped list.
2698
2699         * Scripts/webkitpy/layout_tests/port/base.py:
2700         (Port._tests_from_skipped_file_contents):
2701         (Port):
2702         (Port._expectations_from_skipped_files):
2703         (Port.skipped_perf_tests):
2704         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2705         (PortTest.test_skipped_perf_tests):
2706         (PortTest.test_skipped_perf_tests.add_text_file):
2707         * Scripts/webkitpy/layout_tests/port/webkit.py:
2708         (WebKitPort._skipped_tests_for_unsupported_features):
2709         (WebKitPort._skipped_file_search_paths):
2710         (WebKitPort.skipped_layout_tests):
2711
2712 2012-01-23  Andy Estes  <aestes@apple.com>
2713
2714         Fix the build after r105635.
2715
2716         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2717         (TestWebKitAPI::TEST):
2718
2719 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2720
2721         Basic enhancements to StringBuilder
2722         https://bugs.webkit.org/show_bug.cgi?id=67081
2723
2724         Reviewed by Darin Adler.
2725
2726         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2727         (TestWebKitAPI::TEST):
2728
2729 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2730
2731         [GTK] run-gtk-tests randomly fails while running the xprop comand
2732         https://bugs.webkit.org/show_bug.cgi?id=76817
2733
2734         Reviewed by Gustavo Noronha Silva.
2735
2736         No need to use xprop to remove the AT_SPI_BUS property since
2737         run-gtk-tests will always run new instances of Xvfb.
2738
2739         * Scripts/run-gtk-tests:
2740         (TestRunner): Unskip TestWebKitAccessibility.
2741         (TestRunner.run): Uncomment lines for launching the accessibility
2742         bus and registry daemon, and remove lines for running xprop.
2743
2744 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2745
2746         [Qt] Don't warn about override and final being C++11 extensions
2747
2748         Clang will emit a warning when these extensions are used without passing
2749         --std=c++11, but we use feature checking to decide if we have the right
2750         extensions, so we can safely ignore these warnings. The XCode and Windows
2751         project files have the same workaround.
2752
2753         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
2754         we only have one extra compiler for Objective-C, which is also used for
2755         Objective-C++ sources, so we have to pass the flag, even if it doesn't
2756         make sense for Objective-C.
2757
2758         Reviewed by Simon Hausmann.
2759
2760         * qmake/mkspecs/features/unix/default_post.prf:
2761
2762 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2763
2764         [Qt] Change how build-webkit decides when to do full incremental builds
2765
2766         Instead of relying on update-webkit (which isn't run on the bots) to
2767         decide when to do a full incremental build (make qmake), we let the
2768         build-webkit script itself check the current SVN revision against the
2769         previous build (by storing it in .webkit.config).
2770
2771         If the two differ we assume a full incremental build is needed, since
2772         the new revisions might have introduced problematic things like new
2773         Q_OBJECT macros. If not, we assume the developer is doing changes
2774         locally, and revert to doing a plain 'make'.
2775
2776         In addition, when the build fails in the latter case, we inform the
2777         developer of possible pitfalls and how to manually run 'make qmake'.
2778
2779         Reviewed by Ossy.
2780
2781         * Scripts/update-webkit:
2782         * Scripts/webkitdirs.pm:
2783         (buildQMakeProjects):
2784
2785 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2786
2787         [GTK] run-gtk-tests randomly fails while running the xprop comand
2788         https://bugs.webkit.org/show_bug.cgi?id=76817
2789
2790         Reviewed by Philippe Normand.
2791
2792         Temporarily comment the lines related to launching the ATSPI bus
2793         and registry daemon, which are making the bots to fail randomly.
2794
2795         * Scripts/run-gtk-tests:
2796         (TestRunner): Skip TestWebKitAccessibility, as it won't run
2797         properly if the ATSPI infrastructure is not properly initialized.
2798         (TestRunner.run): Comment lines related to initialization of ATSPI.
2799
2800 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2801
2802         Windows python test build fix.
2803
2804         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2805         (PerfTestsRunner.__init__):
2806
2807 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
2808
2809         [GTK] DumpRenderTree converts "file:///" to a path differently
2810         https://bugs.webkit.org/show_bug.cgi?id=76631
2811
2812         Reviewed by Martin Robinson.
2813
2814         DumpRenderTree should print "/" as the last path component if the
2815         path is a lone slash instead of empty output.
2816
2817         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2818         (webViewConsoleMessage):
2819
2820 2012-01-20  David Levin  <levin@chromium.org>
2821
2822         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
2823         https://bugs.webkit.org/show_bug.cgi?id=76752
2824
2825         Reviewed by Eric Seidel.
2826
2827         * Scripts/webkitpy/style/checkers/cpp.py:
2828         (check_for_leaky_patterns):
2829         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2830         (LeakyPatternTest.test_create_dc):
2831         (LeakyPatternTest.test_create_compatible_dc):
2832
2833 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
2834
2835         Changed my status in commiters.py
2836
2837         Unreviewed.
2838
2839         * Scripts/webkitpy/common/config/committers.py:
2840
2841 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2842
2843         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
2844         https://bugs.webkit.org/show_bug.cgi?id=76748
2845
2846         Reviewed by Ryosuke Niwa.
2847
2848         It crawls the whole subtree and then doesn't use the data. Cutting this out
2849         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
2850
2851         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2852         (run):
2853
2854 2012-01-20  Adam Barth  <abarth@webkit.org>
2855
2856         Another tiny tweak to the garden-o-matic CSS.  This makes things line
2857         up slightly nicer when there aren't any failures.
2858
2859         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2860         (#summary):
2861
2862 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2863
2864         run-perf-tests should support --test-results-server option
2865         https://bugs.webkit.org/show_bug.cgi?id=76680
2866
2867         Reviewed by Adam Barth.
2868
2869         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
2870         to be used by perf bots. Also refactor file_uploader as needed.
2871
2872         * Scripts/webkitpy/common/net/file_uploader.py:
2873         (FileUploader.__init__):
2874         (FileUploader.upload_single_file):
2875         (FileUploader.upload_as_multipart_form_data):
2876         (FileUploader):
2877         (FileUploader._upload_data):
2878         (FileUploader._upload_data.callback):
2879         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2880         (JSONResultsGeneratorBase.upload_json_files):
2881         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2882         (PerfTestsRunner):
2883         (PerfTestsRunner._parse_args):
2884         (PerfTestsRunner.run):
2885         (PerfTestsRunner._generate_json):
2886         (PerfTestsRunner._upload_json):
2887         (PerfTestsRunner._run_tests_set):
2888         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2889         (create_runner):
2890         (test_run_with_upload_json):
2891         (test_run_with_upload_json.mock_upload_json):
2892         (test_upload_json):
2893         (test_upload_json.MockFileUploader):
2894         (test_upload_json.MockFileUploader.__init__):
2895         (test_upload_json.MockFileUploader.upload_single_file):
2896         (test_parse_args):
2897
2898 2012-01-20  Adam Barth  <abarth@webkit.org>
2899
2900         The party time image overlaps real content!  This patch makes the
2901         image centered vertically.
2902
2903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2904         (#onebar.partytime #summary):
2905
2906 2012-01-19  Ojan Vafai  <ojan@chromium.org>
2907
2908         Refactor TestExpectationsParser in preparation for caching the results
2909         https://bugs.webkit.org/show_bug.cgi?id=76669
2910
2911         Reviewed by Dimitri Glazkov.
2912
2913         Make everything private expect for the parse method. 
2914         Eventually, we'll need the expectations lines to not be modified
2915         outside of TestExpectationsParser so we can cache the results.
2916         This makes check-webkit-style of the chromium test_expectations.txt file
2917         go from ~17 seconds to ~12 seconds on my Mac Pro.
2918
2919         This patch is just a refactor in preparation, so no new tests.
2920
2921         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2922         (TestExpectationEditorTests.make_parsed_expectation_lines):
2923         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2924         (TestExpectationParser.parse):
2925         (TestExpectationParser):
2926         (TestExpectationParser._parse_line):
2927         (TestExpectationParser._tokenize):
2928         (TestExpectationParser._tokenize_list):
2929         (TestExpectationsModel._clear_expectations_for_test):
2930         (TestExpectations.__init__):
2931         (TestExpectations._add_expectations):
2932         (TestExpectations._add_skipped_tests):
2933         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2934         (TestExpectationParserTests.test_tokenize_blank):
2935         (TestExpectationParserTests.test_tokenize_missing_colon):
2936         (TestExpectationParserTests.test_tokenize_extra_colon):
2937         (TestExpectationParserTests.test_tokenize_empty_comment):
2938         (TestExpectationParserTests.test_tokenize_comment):
2939         (TestExpectationParserTests.test_tokenize_missing_equal):
2940         (TestExpectationParserTests.test_tokenize_extra_equal):
2941         (TestExpectationParserTests.test_tokenize_valid):
2942         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2943         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2944         (TestExpectationParserTests.test_parse_empty_string):
2945         (TestExpectationSerializerTests.assert_round_trip):
2946         (TestExpectationSerializerTests.assert_list_round_trip):
2947         * Scripts/webkitpy/tool/commands/expectations.py:
2948         (OptimizeExpectations.execute):
2949         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2950         (GardeningExpectationsUpdater.update_expectations):
2951
2952 2012-01-20  Adam Barth  <abarth@webkit.org>
2953
2954         Follow-up to previous patch: don't produce NaN when the revision number
2955         is missing.
2956
2957         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2958         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2959
2960 2012-01-20  Adam Barth  <abarth@webkit.org>
2961
2962         Garden-o-matic should tell me which revisions have been checked by all the bots
2963         https://bugs.webkit.org/show_bug.cgi?id=76722
2964
2965         Reviewed by Dimitri Glazkov.
2966
2967         This information helps me know when it's safe for me to roll a
2968         candidate revision.
2969
2970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2971         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2972         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2973
2974 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2975
2976         build-webkit: Don't spit out congratulations message on Ctrl+C
2977
2978         Reviewed by Andreas Kling.
2979
2980         * Scripts/build-webkit:
2981
2982 2012-01-20  Philippe Normand  <pnormand@igalia.com>
2983
2984         [GTK] Allow extra jhbuild modulesets
2985         https://bugs.webkit.org/show_bug.cgi?id=76691
2986
2987         Reviewed by Gustavo Noronha Silva.
2988
2989         * gtk/jhbuildrc: Extra modulesets and modules can be added in
2990         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
2991         env variables respectively. Use comma-separated values. Example:
2992         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
2993
2994 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2995
2996         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
2997         https://bugs.webkit.org/show_bug.cgi?id=72589
2998
2999         Reviewed by Martin Robinson.
3000
3001         Ensure the accessibility infrastructure is available when running
3002         the unit tests, otherwise WK2's accessibility tests won't work.
3003
3004         * Scripts/run-gtk-tests:
3005         (TestRunner):
3006         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
3007         where at-spi2's stuff is located (like at-spi-bus-launcher and
3008         at-spi2-registryd).
3009         (TestRunner.run): Initialize the accessibility infrastructure.
3010
3011         * gtk/generate-gtkdoc:
3012         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
3013
3014         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
3015
3016 2012-01-20  Hayato Ito  <hayato@chromium.org>
3017
3018         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
3019         https://bugs.webkit.org/show_bug.cgi?id=76353
3020
3021         Reviewed by Hajime Morita.
3022
3023         Add ShadowRoot.idl, which is enabled only on chromium port since this is
3024         under development feature.
3025         ShadowRoot.idl contains minimum API so that we can test it.
3026         Other APIs should be added on other changes so that we can isolate issues.
3027
3028         * DumpRenderTree/chromium/TestShell.cpp:
3029         (TestShell::TestShell):
3030
3031 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
3032
3033         [GTK] GTK's DRT not to log events for already defunct objects
3034         https://bugs.webkit.org/show_bug.cgi?id=76620
3035
3036         Reviewed by Martin Robinson.
3037
3038         Do not log 'state-change:defunct' events.
3039
3040         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
3041         (printAccessibilityEvent): Early return if a
3042         'state-change:defunct' signal is passed.
3043         (axObjectEventListener): Pass the signal name and value in
3044         separate parameters to printAccessibilityEvent.
3045
3046 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
3047
3048         Unreviewed build fix. Wrong variable being used as the cwd for git
3049         remote update command.
3050
3051         * gtk/run-with-jhbuild:
3052         (update_jhbuild):
3053
3054 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
3055
3056         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
3057         https://bugs.webkit.org/show_bug.cgi?id=76585
3058
3059         Reviewed by Martin Robinson.
3060
3061         This allows us to specify a minimum version of jhbuild required,
3062         while also providing stability against changes done to the master
3063         branch, by letting us choose what is the exact version that will
3064         be used.
3065
3066         * gtk/run-with-jhbuild: refactored for more hackability and easier
3067         reading
3068         (jhbuild_installed): checks whether jhbuild is installed
3069         (jhbuild_cloned): checks whether jhbuild has been cloned
3070         (jhbuild_at_expected_revision): checks whether jhbuild is at the
3071         expected revision
3072         (update_jhbuild): brings jhbuild to the expected revision
3073         (clone_jhbuild): clones jhbuild
3074         (install_jhbuild): build and installs jhbuild
3075         (update_webkitgtk_libs): runs update-webkitgtk-libs
3076         (ensure_jhbuild): high-level logic to decide whether and which of
3077         the steps above are executed
3078
3079 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3080
3081         [WK2] DumpRenderTree converts "file:///" to a path differently
3082         https://bugs.webkit.org/show_bug.cgi?id=76653
3083
3084         Reviewed by John Sullivan.
3085
3086         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
3087         Do print a slash if there are no path components.
3088
3089 2012-01-19  Eric Seidel  <eric@webkit.org>
3090
3091         webkit-patch cannot rollout patches without changelog/bug number
3092         https://bugs.webkit.org/show_bug.cgi?id=75962
3093
3094         Reviewed by Adam Barth.
3095
3096         * Scripts/webkitpy/tool/commands/download.py:
3097         (AbstractRolloutPrepCommand._prepare_state):
3098         * Scripts/webkitpy/tool/commands/download_unittest.py:
3099         (AbstractRolloutPrepCommandTest.test_prepare_state):
3100
3101 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3102
3103         [WK2] fast/url/degenerate-file-base.html fails
3104         https://bugs.webkit.org/show_bug.cgi?id=76619
3105
3106         Reviewed by Adam Roben.
3107
3108         A URL generated form local path for loading had an extra slash, making document.URL
3109         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
3110
3111         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
3112
3113 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3114
3115         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
3116         https://bugs.webkit.org/show_bug.cgi?id=76510
3117
3118         Reviewed by Adam Barth.
3119
3120         Unlike other style rules, if you get the syntax of the test_expectations.txt
3121         file wrong, the layout tests won't run. Also, this check is simple and only
3122         slows down committing if you actually modify one of the test_expectations.txt files.
3123
3124         * Scripts/webkitpy/style/checkers/test_expectations.py:
3125         (TestExpectationsChecker.check_test_expectations):
3126         (TestExpectationsChecker.check):
3127         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3128         (TestExpectationsTestCase.test_check_covers_all_configurations):
3129         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
3130         (TestExpectationsTestCase):
3131         (assert_lines_lint):
3132
3133 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3134
3135         Build fix. Revert an unintentional change to WebKitDriver in r105443.
3136
3137         * Scripts/webkitpy/layout_tests/port/driver.py:
3138         (DriverProxy.__init__):
3139
3140 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
3141
3142         remove the duplicated build rules from WebKit.gyp, Tools.gyp
3143         https://bugs.webkit.org/show_bug.cgi?id=73384
3144
3145         Reviewed by Tony Chang.
3146
3147         This patch removes the no-longer-necessary conditional logic for
3148         build_webkit_exes_from_webkit_gyp; we now always build the exes
3149         from their own dedicated gyp files.
3150
3151         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3152
3153 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3154
3155         make-new-script-test should work with HTTP tests
3156         https://bugs.webkit.org/show_bug.cgi?id=76603
3157
3158         Reviewed by Adam Roben.
3159
3160         * Scripts/make-new-script-test:
3161         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
3162         now also creates absolute paths for HTTP.
3163
3164 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3165
3166         Some perf tests time out when ran by run-perf-tests
3167         https://bugs.webkit.org/show_bug.cgi?id=76612
3168
3169         Reviewed by Dirk Pranke and Eric Seidel.
3170
3171         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
3172         Otherwise some tests such as Parser/xml-parser.html will timeout.
3173
3174         --no-timeout option is currently supported by Chromium and Mac ports.
3175
3176         * Scripts/webkitpy/layout_tests/port/base.py:
3177         (Port.to.create_driver):
3178         * Scripts/webkitpy/layout_tests/port/chromium.py:
3179         (ChromiumDriver.__init__):
3180         (ChromiumDriver._wrapper_options):
3181         * Scripts/webkitpy/layout_tests/port/driver.py:
3182         (Driver.__init__):
3183         (DriverProxy.__init__):
3184         * Scripts/webkitpy/layout_tests/port/webkit.py:
3185         (WebKitDriver.__init__):
3186         (WebKitDriver.cmd_line):
3187         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3188         (WebKitDriverTest.test_read_binary_block):
3189         (WebKitDriverTest):
3190         (WebKitDriverTest.test_no_timeout):
3191         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3192         (get_tests_run.RecordingTestDriver.__init__):
3193         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3194         (PerfTestsRunner._parse_args):
3195         (PerfTestsRunner._run_tests_set):
3196         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3197         (create_runner):
3198
3199 2012-01-19  Ben Wells  <benwells@chromium.org>
3200
3201         Add support for window.print to chromium DRT
3202         https://bugs.webkit.org/show_bug.cgi?id=76479
3203
3204         When used in a test window.print goes into print mode and then
3205         straight out again. This will allow the afterprint event to be
3206         tested by having the afterprint event happen before the dump
3207         happens.
3208
3209         Reviewed by Mihai Parparita.
3210
3211         * DumpRenderTree/chromium/WebViewHost.cpp:
3212         (WebViewHost::printPage):
3213         * DumpRenderTree/chromium/WebViewHost.h:
3214
3215 2012-01-18  Enrica Casucci  <enrica@apple.com>
3216
3217         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
3218         https://bugs.webkit.org/show_bug.cgi?id=76588
3219         <rdar://problem/9325183>
3220
3221         Added test.
3222         
3223         Reviewed by Dan Bernstein.
3224
3225         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3226         (TestWebKitAPI::TEST):
3227
3228 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3229
3230         [Qt] Do full incremental builds until bots use update-webkit
3231
3232         Rubber-stamped by Simon Hausmann.
3233
3234         * Scripts/webkitdirs.pm:
3235         (buildQMakeProjects):
3236
3237 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3238
3239         Fix the Qt build
3240
3241         Unreviewed build fix.
3242
3243         * Scripts/webkitdirs.pm:
3244         (buildQMakeProjects):
3245
3246 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3247
3248         [Qt] Make build-webkit always do safe incremental builds after update-webkit
3249
3250         When building against Qt5 with GCC we would just run 'make' in the build dir,
3251         and rely on the dependency files output by GCC (-MD) to handle dependency
3252         tracking, but that fails for special-cases like adding a Q_OBJECT macro
3253         to a header.
3254
3255         To guarantee that an incrmental build will work, we have to run 'make qmake',
3256         which we now do on every build-webkit that's followed by a successful run
3257         of update-webkit. The reasoning is that update-webkit can result in such
3258         potential corner-cases being applied, and since we can't know for sure
3259         unless we inspect the diff and account for all the corner cases we assume
3260         the worst and always run 'make qmake'.
3261
3262         After a succesful run of build-webkit we proceed to do just 'make' for any
3263         subsequent runs, since we assume that the developer knows what kind of
3264         changes he/she is doing, and when a 'make qmake' is needed.
3265
3266         Reviewed by Simon Hausmann.
3267
3268         * Scripts/update-webkit:
3269         * Scripts/webkitdirs.pm:
3270         (determineCurrentSVNRevision):
3271         (currentSVNRevision):
3272         (buildQMakeProjects):
3273         * qmake/mkspecs/features/default_post.prf:
3274
3275 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3276
3277         run-perf-tests should support Skipped list
3278         https://bugs.webkit.org/show_bug.cgi?id=76594
3279
3280         Reviewed by Adam Barth.
3281
3282         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
3283
3284         * Scripts/webkitpy/layout_tests/port/base.py:
3285         (Port.perf_tests_dir):
3286         (Port.skipped_perf_tests):
3287         (Port.skips_perf_test):
3288         (Port.relative_perf_test_filename):
3289         * Scripts/webkitpy/layout_tests/port/test.py:
3290         (TestPort.perf_tests_dir):
3291         * Scripts/webkitpy/layout_tests/port/webkit.py:
3292         (WebKitPort._expectations_from_skipped_files):
3293         (WebKitPort):
3294         (WebKitPort.skipped_layout_tests):
3295         (WebKitPort.skipped_perf_tests):
3296         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3297         (PerfTestsRunner._collect_tests):
3298         (PerfTestsRunner.run):
3299         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3300         (test_run_test_set_with_json_output):
3301         (test_run_test_set_with_json_source):
3302         (test_collect_tests_with_skipped_list):
3303         (test_collect_tests_with_skipped_list.add_file):
3304
3305 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3306
3307         Fix path to chromium_src_dir introduced in previous change.
3308
3309         Unreviewed, build fix.
3310
3311         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3312
3313 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
3314
3315         Need infrastructure to test Content-Disposition filename encoding support
3316         https://bugs.webkit.org/show_bug.cgi?id=76572
3317         <rdar://problem/6421825>
3318
3319         Reviewed by Sam Weinig.
3320
3321         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
3322
3323         WebKitTestRunner does not have a policy delegate yet, bug 42546.
3324
3325         * DumpRenderTree/mac/PolicyDelegate.mm:
3326         (dispositionTypeFromContentDispositionHeader):
3327         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
3328
3329 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3330
3331         Fix tests from http://trac.webkit.org/changeset/105332.
3332
3333         The code assumed that if you passed an options object with a configuration
3334         attribute that it would have a valid value. A bunch of the testing mocks
3335         do things like having a configuration value of None.
3336
3337         * Scripts/webkitpy/layout_tests/port/base.py:
3338         (Port.__init__):
3339
3340 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3341
3342         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
3343         https://bugs.webkit.org/show_bug.cgi?id=76576
3344
3345         Reviewed by Adam Barth.
3346
3347         Avoid calling default_configuration in base.py. We don't need it for
3348         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
3349         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
3350         from common.executive.
3351
3352         At some point someone should probably look into why that call is so slow
3353         since it's on the critical path for run-webkit-tests and build-webkit startup.
3354
3355         * Scripts/webkitpy/layout_tests/port/base.py:
3356         (Port.__init__):
3357         * Scripts/webkitpy/style/checkers/test_expectations.py:
3358         (TestExpectationsChecker._determine_port_from_exepectations_path):
3359
3360 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3361
3362         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
3363         https://bugs.webkit.org/show_bug.cgi?id=76505
3364
3365         Reviewed by Tony Chang.
3366
3367         Update chromium build script to use All.gyp instead of WebKit.gyp
3368
3369         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
3370         * Scripts/webkitdirs.pm:
3371
3372 2012-01-18  Sam Weinig  <sam@webkit.org>
3373
3374         Don’t hardcode the path to ‘make‘.
3375
3376         Reviewed by Dan Bernstein.
3377
3378         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3379
3380 2012-01-18  Joshua Bell  <jsbell@chromium.org>
3381
3382         Adding myself to committers.py
3383         https://bugs.webkit.org/show_bug.cgi?id=76569
3384
3385         Unreviewed.
3386
3387         * Scripts/webkitpy/common/config/committers.py:
3388
3389 2012-01-18  Adam Barth  <abarth@webkit.org>
3390
3391         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
3392         https://bugs.webkit.org/show_bug.cgi?id=76567
3393
3394         Reviewed by Eric Seidel.
3395
3396         Current the AppleMac port has slightly more failures than we allow on
3397         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
3398         which should hopefully let the mac-ews run to completion.  Once
3399         AppleMac has fewer failures, we can lower the cap again.
3400
3401         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3402         (LayoutTestResultsReaderTest.test_layout_test_results):
3403         * Scripts/webkitpy/tool/steps/runtests.py:
3404         (RunTests):
3405         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3406
3407 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
3408
3409         Provide access to user's list of preferred languages
3410         https://bugs.webkit.org/show_bug.cgi?id=76138
3411
3412         Reviewed by Alexey Proskuryakov.
3413
3414         * GNUmakefile.am: Add JSInternalsCustom.cpp.
3415
3416 2012-01-18  Adam Barth  <abarth@webkit.org>
3417
3418         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
3419         configurations.
3420
3421         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3422         (ChromiumLinuxPort.__init__):
3423
3424 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
3425
3426         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3427         https://bugs.webkit.org/show_bug.cgi?id=73460
3428
3429         Reviewed by Chris Fleizach.
3430
3431         * DumpRenderTree/AccessibilityUIElement.h:
3432         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3433         (AccessibilityUIElement::AccessibilityUIElement):
3434         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3435         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3436         (AccessibilityUIElement::scrollToGlobalPointCallback):
3437         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3438         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3439         (AccessibilityUIElement::scrollToMakeVisible):
3440         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3441         (AccessibilityUIElement::scrollToGlobalPoint):
3442         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3443         (AccessibilityUIElement::scrollToMakeVisible):
3444         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3445         (AccessibilityUIElement::scrollToGlobalPoint):
3446         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3447         (AccessibilityUIElement::scrollToMakeVisible):
3448         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3449         (AccessibilityUIElement::scrollToGlobalPoint):
3450
3451 2012-01-17  Enrica Casucci  <enrica@apple.com>
3452
3453         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
3454         https://bugs.webkit.org/show_bug.cgi?id=76490
3455         <rdar://problem/9460733>
3456
3457         Added TestWebKitAPI test.
3458         
3459         Reviewed by Dan Bernstein.
3460
3461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
3462         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
3463         changeAttributes to the WebView.
3464         
3465 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
3466
3467         [Qt] Consolidate layout test crash logging
3468         https://bugs.webkit.org/show_bug.cgi?id=75088
3469
3470         Reviewed by Simon Hausmann.
3471
3472         Move backtrace generating logic into WTFReportBacktrace
3473         and add a way to deinstall signal handlers if we know
3474         that we have already printed the backtrace.
3475
3476         * DumpRenderTree/qt/main.cpp:
3477         (crashHandler):
3478         (setupSignalHandlers):
3479         (WTFCrashHook):
3480         (main):
3481         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3482         (WTR::crashHandler):
3483         (WTR::setupSignalHandlers):
3484         (WTR::crashHook):
3485         (WTR::InjectedBundle::platformInitialize):
3486
3487 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
3488
3489         Unreviewed build fix after r105256.
3490
3491         There was a cyclic dependency between self._port and self._host assigments.
3492
3493         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3494         (PerfTestsRunner.__init__):
3495
3496 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3497
3498         Add new watchlist rule for the Qt build system
3499
3500         Reviewed by Simon Hausmann.
3501
3502         * Scripts/webkitpy/common/config/watchlist:
3503
3504 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3505
3506         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
3507
3508         Reviewed by Simon Hausmann.
3509
3510         * Tools.pro:
3511
3512 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3513
3514         [Qt] Allow building only a subset of the WebKit sub-projects
3515
3516         Fixes build-jsc, broken in r104825.
3517
3518         We no longer need the intermediate buildQMakeQtProject(), as we're the
3519         only port using qmake, and buildQMakeProject is now highly Qt specific.
3520
3521         <http://webkit.org/b/76179>
3522
3523         Reviewed by Simon Hausmann.
3524
3525         * Scripts/build-jsc:
3526         * Scripts/build-webkit:
3527         * Scripts/webkitdirs.pm:
3528         (buildQMakeProjects):
3529
3530 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3531
3532         run-perf-tests should generate a json file that summaries the result
3533         https://bugs.webkit.org/show_bug.cgi?id=76504
3534
3535         Reviewed by Adam Barth.
3536
3537         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
3538         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
3539         another json file to be merged into the generated json file.
3540
3541         Also fixed a bug that --build wasn't set by default.
3542
3543         * Scripts/webkitpy/layout_tests/port/test.py:
3544         (TestPort.webkit_base):
3545         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3546         (PerfTestsRunner.__init__):
3547         (PerfTestsRunner):
3548         (PerfTestsRunner._parse_args):
3549         (PerfTestsRunner.run):
3550         (PerfTestsRunner._generate_json_if_specified):
3551         (PerfTestsRunner._process_chromium_style_test_result):
3552         (PerfTestsRunner._process_parser_test_result):
3553         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3554         (MainTest):
3555         (create_runner):
3556         (test_run_test_set):
3557         (test_run_test_set_for_parser_tests):
3558         (test_run_test_set_with_summary_json):
3559         (test_collect_tests):
3560         (test_parse_args):
3561
3562 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3563
3564         Unreviewed, rolling out r105244.
3565         http://trac.webkit.org/changeset/105244
3566         https://bugs.webkit.org/show_bug.cgi?id=76518
3567
3568         broke Chromium Mac (Requested by rolandsteiner on #webkit).
3569
3570         * DumpRenderTree/AccessibilityUIElement.h:
3571         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3572         (AccessibilityUIElement::AccessibilityUIElement):
3573         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3574         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3575         (AccessibilityUIElement::removeSelection):
3576         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3577         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3578         (AccessibilityUIElement::removeSelection):
3579
3580 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
3581
3582         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3583         https://bugs.webkit.org/show_bug.cgi?id=73460
3584
3585         Reviewed by Chris Fleizach.
3586
3587         * DumpRenderTree/AccessibilityUIElement.h:
3588         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3589         (AccessibilityUIElement::AccessibilityUIElement):
3590         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3591         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3592         (AccessibilityUIElement::scrollToGlobalPointCallback):
3593         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3594         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3595         (AccessibilityUIElement::scrollToMakeVisible):
3596         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3597         (AccessibilityUIElement::scrollToGlobalPoint):
3598         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3599         (AccessibilityUIElement::scrollToMakeVisible):
3600         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3601         (AccessibilityUIElement::scrollToGlobalPoint):
3602         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3603         (AccessibilityUIElement::scrollToMakeVisible):
3604         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3605         (AccessibilityUIElement::scrollToGlobalPoint):
3606
3607 2012-01-17  Adam Barth  <abarth@webkit.org>
3608
3609         Enable tests on the mac-ews
3610         https://bugs.webkit.org/show_bug.cgi?id=76502
3611
3612         Reviewed by Simon Fraser.
3613
3614         Apple now has five machines running the mac-ews.  Lucas Forschler has
3615         asked that we try enabling tests to see if we have enough bandwidth.
3616
3617         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3618         (MacEWS):
3619
3620 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
3621
3622         Add a check-webkit-style exception for GDBInterface.cpp
3623         https://bugs.webkit.org/show_bug.cgi?id=76187
3624
3625         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
3626         that it does not fail the style check.
3627
3628         Reviewed by Martin Robinson.
3629
3630         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
3631         readability/naming tests on
3632         Source/JavaScriptCore/jit/GDBInterface.cpp.
3633         * Scripts/webkitpy/style/checker_unittest.py:
3634         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
3635         the above exception.
3636
3637 2012-01-17  Hajime Morrita  <morrita@chromium.org>
3638
3639         https://bugs.webkit.org/show_bug.cgi?id=76245
3640         [Mac][DRT] should allow query string for the file URL.
3641
3642         Reviewed by Tony Chang.
3643
3644         Taught DRT about file:// as a url instead of a file path.
3645         We are now able to use a path file:///foo/bar.html?baz as a url
3646         with which DRT opens "/foo/bar.html" with "baz" as a query string.
3647
3648         * DumpRenderTree/mac/DumpRenderTree.mm:
3649         (runTest):
3650
3651 2012-01-17  Ojan Vafai  <ojan@chromium.org>
3652
3653         Check style on test_expectations.txt files before commit
3654         https://bugs.webkit.org/show_bug.cgi?id=76484
3655
3656         Reviewed by Adam Barth.
3657
3658         Unlike other style rules, if you get the syntax of the test_expectations.txt
3659         file wrong, the layout tests won't run. Also, this check is simple and only
3660         slows down committing if you actually modify one of the test_expectations.txt files.
3661
3662         * Scripts/webkitpy/tool/steps/commit.py:
3663         (Commit._check_test_expectations):
3664         (Commit.run):
3665         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
3666         (CommitTest):
3667         (CommitTest.test_check_test_expectations):
3668
3669 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3670
3671         [Qt] Debug build fails with debug qt5
3672         https://bugs.webkit.org/show_bug.cgi?id=76463
3673
3674         Reviewed by Simon Hausmann.
3675
3676         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
3677
3678         * QtTestBrowser/cookiejar.h:
3679
3680 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3681
3682         webkitpy: fix json import on linux
3683         h