1 2015-09-14 Dewei Zhu <dewei_zhu@apple.com>
3 Unreviewed, add myself to committers list.
5 * Scripts/webkitpy/common/config/contributors.json:
7 2015-09-12 Myles C. Maxfield <mmaxfield@apple.com>
9 [Cocoa] Allow testing with the system language
10 https://bugs.webkit.org/show_bug.cgi?id=148671
12 Reviewed by Anders Carlsson and Alexey Proskuryakov.
14 React to tests marked with language=lang1,lang2,etc in their header.
15 Once this information is parsed, pass it to
16 WKContextConfigurationSetOverrideLanguages().
18 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
19 (WTR::InjectedBundle::platformInitialize): Don't clobber the language
21 * WebKitTestRunner/TestController.cpp:
22 (WTR::TestController::createWebViewWithOptions): Call
23 WKContextConfigurationSetOverrideLanguages().
24 (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
25 * WebKitTestRunner/TestOptions.h:
26 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
27 (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
28 option to restart the web process.
29 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
30 (WTR::PlatformWebView::viewSupportsOptions): Ditto.
32 2015-09-12 Myles C. Maxfield <mmaxfield@apple.com>
34 [WKTR] Allow changing the WKContextConfiguration between successive tests
35 https://bugs.webkit.org/show_bug.cgi?id=148833
37 Reviewed by Tim Horton.
39 Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
40 However, there are certain tests which require specifying options in this object. This patch makes
41 our existing code for recreating the test runner web view also recreate the WKContext.
43 As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
46 * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
47 * WebKitTestRunner/PlatformWebView.h:
48 (WTR::PlatformWebView::options):
49 * WebKitTestRunner/TestController.cpp:
50 (WTR::TestController::initialize):
51 (WTR::TestController::generateContextConfiguration):
52 (WTR::TestController::generatePageConfiguration):
53 (WTR::TestController::createWebViewWithOptions):
54 (WTR::TestController::ensureViewSupportsOptionsForTest):
55 (WTR::updateContextConfigurationOptionsFromTestHeader):
56 (WTR::TestController::contextConfigurationOptionsForTest):
57 (WTR::TestController::platformCreateWebView):
58 (WTR::TestController::platformCreateOtherPage):
59 (WTR::updateViewOptionsFromTestHeader): Deleted.
60 (WTR::TestController::viewOptionsForTest): Deleted.
61 * WebKitTestRunner/TestController.h:
62 (WTR::TestController::injectedBundlePath):
63 (WTR::TestController::testPluginDirectory):
64 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
65 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
66 (WTR::TestController::platformCreateWebView):
67 (WTR::TestController::platformCreateOtherPage):
68 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
69 (WTR::PlatformWebView::PlatformWebView):
70 (WTR::PlatformWebView::viewSupportsOptions):
71 * WebKitTestRunner/efl/TestControllerEfl.cpp:
72 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
73 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
74 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
75 (WTR::PlatformWebView::PlatformWebView):
76 (WTR::PlatformWebView::viewSupportsOptions):
77 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
78 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
79 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
80 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
81 (WTR::PlatformWebView::PlatformWebView):
82 (WTR::PlatformWebView::viewSupportsOptions):
83 * WebKitTestRunner/ios/TestControllerIOS.mm:
84 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
85 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
86 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
87 (WTR::PlatformWebView::PlatformWebView):
88 (WTR::PlatformWebView::viewSupportsOptions):
89 * WebKitTestRunner/mac/TestControllerMac.mm:
90 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
91 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
93 2015-09-11 Michael Saboff <msaboff@apple.com>
95 LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
96 https://bugs.webkit.org/show_bug.cgi?id=149083
98 Reviewed by Alexey Proskuryakov.
100 Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
102 * DumpRenderTree/mac/LayoutTestHelper.m:
103 (colorProfileURLForDisplay):
105 2015-09-11 Saam barati <sbarati@apple.com>
107 There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
108 https://bugs.webkit.org/show_bug.cgi?id=149058
110 Reviewed by Geoffrey Garen.
112 * Scripts/run-jsc-stress-tests:
114 2015-09-10 Commit Queue <commit-queue@webkit.org>
116 Unreviewed, rolling out r189595.
117 https://bugs.webkit.org/show_bug.cgi?id=149052
119 The tests still fail (Requested by ap on #webkit).
123 "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
125 https://bugs.webkit.org/show_bug.cgi?id=142929
126 http://trac.webkit.org/changeset/189595
128 2015-09-10 Alexey Proskuryakov <ap@apple.com>
130 Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
131 https://bugs.webkit.org/show_bug.cgi?id=142929
133 Reviewed by Brent Fulgham.
135 Silence the logging. We'll track fixing the root cause in Radar.
137 * Scripts/webkitpy/port/mac.py:
138 (MacPort.stderr_patterns_to_strip): Added a FIXME.
140 * Scripts/webkitpy/port/win.py:
141 (WinPort.logging_patterns_to_strip): Added.
143 2015-09-09 Andy Estes <aestes@apple.com>
145 [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
146 https://bugs.webkit.org/show_bug.cgi?id=149022
148 Reviewed by Daniel Bates.
150 Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
151 did not account for this.
153 * Scripts/webkitpy/xcode/simulator.py:
154 (Simulator): Optionally matched a revision at the end of a runtime version number.
155 * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
157 2015-09-09 Andy Estes <aestes@apple.com>
159 [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
160 https://bugs.webkit.org/show_bug.cgi?id=149029
161 <rdar://problem/22432624>
163 Reviewed by Daniel Bates.
165 * Scripts/webkitpy/xcode/simulator.py:
166 (Simulator): Taught to parse tvOS runtimes.
167 * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
169 2015-09-09 Alexey Proskuryakov <ap@apple.com>
171 Fix bit rot on bot watcher's dashboard page
172 https://bugs.webkit.org/show_bug.cgi?id=149012
174 Reviewed by Tim Horton.
176 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
177 The code path used by the metrics page was trying to add properties to an undefined.
179 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
180 Silence an expection that would occur when the step has no logs. This should never
181 happen, but it did (perhaps buildbot was misconfigured for a while).
183 2015-09-09 Alexey Proskuryakov <ap@apple.com>
185 Update LayoutTestRelay xcconfig file.
187 Rubber-stamped by Dan Bernstein.
189 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
191 2015-09-09 Saam barati <sbarati@apple.com>
193 DFG should have a debugging option that runs a phase that flushes all locals
194 https://bugs.webkit.org/show_bug.cgi?id=148916
196 Reviewed by Filip Pizlo.
198 * Scripts/run-jsc-stress-tests:
200 2015-09-09 Commit Queue <commit-queue@webkit.org>
202 Unreviewed, rolling out r189530 and r189534.
203 https://bugs.webkit.org/show_bug.cgi?id=148996
205 Caused assertion failures on Yosemite (Requested by litherum
210 "[WKTR] Allow changing the WKContextConfiguration between
212 https://bugs.webkit.org/show_bug.cgi?id=148833
213 http://trac.webkit.org/changeset/189530
215 "[Cocoa] Fix the tests after r189530"
216 http://trac.webkit.org/changeset/189534
218 2015-09-08 Myles C. Maxfield <mmaxfield@apple.com>
220 [Cocoa] Fix the tests after r189530
224 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
225 (WTR::initializeWebViewConfiguration):
227 2015-09-08 Myles C. Maxfield <mmaxfield@apple.com>
229 [WKTR] Allow changing the WKContextConfiguration between successive tests
230 https://bugs.webkit.org/show_bug.cgi?id=148833
232 Reviewed by Tim Horton.
234 Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
235 However, there are certain tests which require specifying options in this object. This patch makes
236 our existing code for recreating the test runner web view also recreate the WKContext.
238 As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
241 * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
242 * WebKitTestRunner/PlatformWebView.h:
243 (WTR::PlatformWebView::options):
244 * WebKitTestRunner/TestController.cpp:
245 (WTR::TestController::initialize):
246 (WTR::TestController::generateContextConfiguration):
247 (WTR::TestController::generatePageConfiguration):
248 (WTR::TestController::createWebViewWithOptions):
249 (WTR::TestController::ensureViewSupportsOptionsForTest):
250 (WTR::updateContextConfigurationOptionsFromTestHeader):
251 (WTR::TestController::contextConfigurationOptionsForTest):
252 (WTR::TestController::platformCreateWebView):
253 (WTR::TestController::platformCreateOtherPage):
254 (WTR::updateViewOptionsFromTestHeader): Deleted.
255 (WTR::TestController::viewOptionsForTest): Deleted.
256 * WebKitTestRunner/TestController.h:
257 (WTR::TestController::injectedBundlePath):
258 (WTR::TestController::testPluginDirectory):
259 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
260 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
261 (WTR::TestController::platformCreateWebView):
262 (WTR::TestController::platformCreateOtherPage):
263 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
264 (WTR::PlatformWebView::PlatformWebView):
265 (WTR::PlatformWebView::viewSupportsOptions):
266 * WebKitTestRunner/efl/TestControllerEfl.cpp:
267 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
268 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
269 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
270 (WTR::PlatformWebView::PlatformWebView):
271 (WTR::PlatformWebView::viewSupportsOptions):
272 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
273 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
274 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
275 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
276 (WTR::PlatformWebView::PlatformWebView):
277 (WTR::PlatformWebView::viewSupportsOptions):
278 * WebKitTestRunner/ios/TestControllerIOS.mm:
279 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
280 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
281 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
282 (WTR::PlatformWebView::PlatformWebView):
283 (WTR::PlatformWebView::viewSupportsOptions):
284 * WebKitTestRunner/mac/TestControllerMac.mm:
285 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
286 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
288 2015-09-08 Daniel Bates <dabates@apple.com>
290 [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
291 https://bugs.webkit.org/show_bug.cgi?id=148980
293 Reviewed by Alexey Proskuryakov.
295 Add setting to enable/disable accelerated drawing so as to support testing
296 this feature in MiniBrowser on Mac.
298 * MiniBrowser/mac/SettingsController.h:
299 * MiniBrowser/mac/SettingsController.m:
300 (-[SettingsController _populateMenu]): Add menu item.
301 (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
302 (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
303 (-[SettingsController acceleratedDrawingEnabled]): Added.
304 * MiniBrowser/mac/WK1BrowserWindowController.m:
305 (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
306 * MiniBrowser/mac/WK2BrowserWindowController.m:
307 (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
309 2015-09-08 Jason Marcell <jmarcell@apple.com>
311 Unreviewed. Added myself as a commiter in contributors.json.
313 * Scripts/webkitpy/common/config/contributors.json:
315 2015-09-08 Keith Miller <keith_miller@apple.com>
317 Unreviewed, added myself to the list of contributors.
319 * Scripts/webkitpy/common/config/contributors.json:
321 2015-09-08 Daniel Bates <dabates@apple.com>
323 Dashboard: Remove use of z-index for ring overlay; use DOM ordering
324 https://bugs.webkit.org/show_bug.cgi?id=148921
326 Reviewed by Alexey Proskuryakov.
328 The ring image is positioned above the platform icon in markup and we specify the CSS
329 property z-index for the ring image so that it is painted on top of the platform icon
330 instead of below it (by DOM ordering). Instead we can take advantage of the transparency
331 of the ring image, switch the order of these DOM elements and remove the use of the CSS
332 property z-index to achieve a similar effect.
334 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
335 (documentReady): Create the platform icon image element before the ring image such that
336 the ring image is painted on top of the platform icon.
337 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
338 (table.queue-grid td.logo img.ring): Removed property z-index.
340 2015-09-08 Daniel Bates <dabates@apple.com>
342 Dashboard: Remove duplicate gear icon data URLs
343 https://bugs.webkit.org/show_bug.cgi?id=148920
345 Reviewed by Alexey Proskuryakov.
347 Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
348 background-image associated with each of the three gear icon states: collapsed (.settings), hover
349 (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
350 as a mask and make use of the CSS background-color to define the fill color for each of these three
353 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
354 (.settings): Use gear icon as mask and define CSS background-color for collapsed state.
355 (.settings:hover): Override CSS background-color for hover state.
356 (.settings-visible .settings): Override CSS background-color for expanded state.
358 2015-09-07 Andy Estes <aestes@apple.com>
360 [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
361 https://bugs.webkit.org/show_bug.cgi?id=148946
362 <rdar://problem/22603981>
364 Reviewed by Dan Bernstein.
366 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
367 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
369 2015-09-07 Hunseop Jeong <hs85.jeong@samsung.com>
371 [EFL] Many of the css3/device-adapt/* tests failed after r188548.
372 https://bugs.webkit.org/show_bug.cgi?id=148927
374 Reviewed by Csaba Osztrogonác.
376 device-adapt/* tests need the fixedLayout option but useFixedLayout option is
377 overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
379 * WebKitTestRunner/TestController.cpp:
380 (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
381 * WebKitTestRunner/efl/TestControllerEfl.cpp:
382 (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
384 2015-09-07 Andy Estes <aestes@apple.com>
386 Fix the Production build after r189455.
388 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
389 In-App Purchase template instead of the Aggregate template. Whoops.
391 2015-09-06 Andy Estes <aestes@apple.com>
393 WebKit.xcworkspace should be be able to build iOS platforms
394 https://bugs.webkit.org/show_bug.cgi?id=148881
396 Reviewed by Daniel Bates.
398 Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
399 for all supported platforms.
401 * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
402 * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
403 * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
404 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
406 2015-09-06 Andy Estes <aestes@apple.com>
408 WebKitTestRunner should build for iOS using the default target
409 https://bugs.webkit.org/show_bug.cgi?id=148918
411 Reviewed by Daniel Bates.
413 When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
414 iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
415 non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
417 This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
418 both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
419 and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
420 WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
421 WebKitTestRunner is skipped when installing on iOS.
423 The target dependency graph now looks like this:
427 WebKitTestRunner (Library)
428 WebKitTestRunnerInjectedBundle
431 WebKitTestRunner (Library)
432 WebKitTestRunnerInjectedBundle
435 * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
436 * Scripts/build-webkittestrunner: Ditto.
437 * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
438 * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
439 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
440 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
441 excluded iOS-only files, and skipped installing on iOS.
442 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
443 excluded Mac-only files, and skipped installing on Mac.
444 * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
445 * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
446 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
447 Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
448 new configuration files.
450 2015-09-05 Joseph Pecoraro <pecoraro@apple.com>
452 Web Inspector: Improve prepare-ChangeLog for multiple cases
453 https://bugs.webkit.org/show_bug.cgi?id=148875
455 Reviewed by Timothy Hatcher.
457 * Scripts/prepare-ChangeLog:
458 (get_function_line_ranges_for_javascript):
459 - We were ignoring everything inside of an anonymous function expression,
460 such as (function(){ ... }), which made InjectedScriptSource produce nothing.
461 Better handle this by inserting a few tweaks.
462 - Allow method syntax outside of classes as long as they are at the global level.
463 - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
465 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
466 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
467 (Foo.prototype.method1):
468 (Foo.prototype.method2):
469 (Foo.prototype.method3.innerFunction):
470 (Foo.prototype.method3):
471 (insideGlobalAnonymousFunctionExpression):
472 (foo.insideGlobalFunctionExpression):
473 (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
474 (IssueWithMapGetAndSet.prototype.method1):
475 (IssueWithMapGetAndSet.prototype.method2):
476 (IssueWithMapGetAndSet.prototype.method3):
477 (IssueWithMapGetAndSet):
479 2015-09-05 Yusuke Suzuki <utatane.tea@gmail.com>
481 [ES6] Enable ES6 Module in JSC shell by default
482 https://bugs.webkit.org/show_bug.cgi?id=148689
484 Reviewed by Geoffrey Garen.
486 * Scripts/run-javascriptcore-tests:
488 * Scripts/run-jsc-stress-tests:
490 2015-09-04 Basile Clement <basile_clement@apple.com>
492 Unreviewed, change my email address.
494 * Scripts/webkitpy/common/config/contributors.json:
496 2015-09-04 Beth Dakin <bdakin@apple.com>
498 Should have a test to make sure links don't navigate after a cancelled force
500 https://bugs.webkit.org/show_bug.cgi?id=148846
502 Reviewed by Tim Horton.
504 New EventSender function for a started then cancelled force click.
505 * WebKitTestRunner/EventSenderProxy.h:
506 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
507 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
508 (WTR::EventSendingController::mouseForceClick):
509 (WTR::EventSendingController::startAndCancelMouseForceClick):
510 (WTR::EventSendingController::mouseForceDown):
511 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
512 * WebKitTestRunner/TestController.cpp:
513 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
514 * WebKitTestRunner/mac/EventSenderProxy.mm:
515 (WTR::EventSenderProxy::mouseForceClick):
516 (WTR::EventSenderProxy::startAndCancelMouseForceClick):
517 (WTR::EventSenderProxy::mouseForceDown):
518 (WTR::EventSenderProxy::mouseMoveTo):
520 2015-09-04 Tim Horton <timothy_horton@apple.com>
522 Add a test for r179736 (programmatic navigation during swipe causing a crash)
523 https://bugs.webkit.org/show_bug.cgi?id=148830
525 Reviewed by Beth Dakin.
527 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
528 (WTR::InjectedBundle::beginTesting):
529 Make sure that TestRunner callbacks don't leak between tests!
531 2015-09-04 Anders Carlsson <andersca@apple.com>
533 It should be possible to pass relative HTTP test paths to DumpRenderTree
534 https://bugs.webkit.org/show_bug.cgi?id=148825
535 <rdar://problem/22583866>
537 Reviewed by Tim Horton.
539 Convert the path to an absolute path if needed.
541 * DumpRenderTree/mac/DumpRenderTree.mm:
544 2015-09-04 Jason Marcell <jmarcell@apple.com>
546 Fix Swift unit tests for prepare-ChangeLog.
547 https://bugs.webkit.org/show_bug.cgi?id=148817
549 Reviewed by Alexey Proskuryakov.
551 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
552 Swift unit tests for prepare-ChangeLog.
554 2015-09-04 Lucas Forschler <lforschler@apple.com>
556 Modifications to the webkit-nightly logic.
558 * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
560 * WebKitLauncher/main.m:
561 (displayErrorAndQuit):
563 2015-09-04 Beth Dakin <bdakin@apple.com>
565 Speculative build fix.
567 * WebKitTestRunner/mac/EventSenderProxy.mm:
569 2015-09-04 Brian Burg <bburg@apple.com>
571 Web Inspector: InspectorController should support multiple frontend channels
572 https://bugs.webkit.org/show_bug.cgi?id=148538
574 Reviewed by Joseph Pecoraro.
576 InspectorClients must explicitly disconnect their frontend channel(s) from the
577 inspected page's InspectorController.
579 To make this possible, DumpRenderTree should not destroy non-primary views until
580 it has tried to close any abandoned Web Inspector instances. Performing teardown
581 in the reverse order prevents disconnection of the frontend channel because that
582 prematurely destroys the inspector frontend client.
584 * DumpRenderTree/mac/DumpRenderTree.mm:
586 * DumpRenderTree/win/DumpRenderTree.cpp:
589 2015-09-04 Beth Dakin <bdakin@apple.com>
591 Need to be able to test default behaviors on force click
592 https://bugs.webkit.org/show_bug.cgi?id=148758
594 Reviewed by Tim Horton.
596 This patch adds a new eventSender method to do a full, completed force click,
597 and it re-works all of the existing force methods to dispatch their events in
598 such a way that they will trigger the NSImmediateAction gesture recognizer.
599 To do this, first we need to send the events to the app rather than straight
600 to the view, and also needed to tweak some state and send the events in a
603 New public function mouseForceClick() and private helper functions to make
605 * WebKitTestRunner/EventSenderProxy.h:
607 New public function mouseForceClick().
608 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
609 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
610 (WTR::EventSendingController::mouseMoveTo):
611 (WTR::EventSendingController::mouseForceClick):
612 (WTR::EventSendingController::mouseForceDown):
613 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
614 * WebKitTestRunner/TestController.cpp:
615 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
617 initPressureEventAtLocation needs to take a stageTransition and a window.
618 * WebKitTestRunner/mac/EventSenderProxy.mm:
619 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
620 (-[EventSenderSyntheticEvent stageTransition]):
621 (-[EventSenderSyntheticEvent timestamp]):
622 (-[EventSenderSyntheticEvent _cgsEventRecord]):
623 (-[EventSenderSyntheticEvent window]):
625 In order to enter the gesture recognizer, we need to start with a mouse down
626 that has a NSEventMaskPressure modifier.
627 (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
629 This ensures that the events queue properly for the force monitor in AppKit.
630 (WTR::spinRunLoopForForce):
632 We need to start the pressure change events with a began.
633 (WTR::EventSenderProxy::beginPressureEvent):
635 These functions can be used to create the NSEvent for a pressure change every
637 (WTR::EventSenderProxy::pressureChangeEvent):
639 Send the right series of events to emulate a full, completed force click.
640 (WTR::EventSenderProxy::mouseForceClick):
642 Use all of the new things for these existing functions.
643 (WTR::EventSenderProxy::mouseForceDown):
644 (WTR::EventSenderProxy::mouseForceUp):
645 (WTR::EventSenderProxy::mouseForceChanged):
647 Set NSFakeForceTouchDevice to YES.
648 * WebKitTestRunner/mac/main.mm:
649 (setDefaultsToConsistentValuesForTesting):
651 2015-09-04 Jason Marcell <jmarcell@apple.com>
653 prepare-ChangeLog needs to know how to parse Swift files.
654 https://bugs.webkit.org/show_bug.cgi?id=148784
655 <rdar://problem/22510062>
657 Reviewed by Darin Adler.
659 * Scripts/prepare-ChangeLog:
660 (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
661 (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
662 (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
663 * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
664 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
665 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
666 (freeFunction): Ditto.
667 (MyClass.function): Ditto.
668 (MyClass.functionWithArgument(_:)): Ditto.
669 (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
670 (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
671 (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
672 (MyClass.classFunction): Ditto.
673 (MyClass.readWriteComputedVariable): Ditto.
674 (MyClass.readOnlyComputedVariable): Ditto.
676 2015-09-04 Ryosuke Niwa <rniwa@webkit.org>
678 Import css/css-color-3
679 https://bugs.webkit.org/show_bug.cgi?id=148803
681 Reviewed by Chris Dumez.
683 Fixed a bug that the imported reference files used the same extention as tests.
684 This would result in parsing errors if the tests were XML and references were HTML and vice versa.
686 * Scripts/webkitpy/w3c/test_importer.py:
687 (TestImporter.find_importable_tests):
689 2015-09-03 Commit Queue <commit-queue@webkit.org>
691 Unreviewed, rolling out r189338.
692 https://bugs.webkit.org/show_bug.cgi?id=148785
694 Caused tons of crashes (Requested by cdumez on #webkit).
698 "Web Inspector: InspectorController should support multiple
700 https://bugs.webkit.org/show_bug.cgi?id=148538
701 http://trac.webkit.org/changeset/189338
703 2015-09-03 Brian Burg <bburg@apple.com>
705 Web Inspector: InspectorController should support multiple frontend channels
706 https://bugs.webkit.org/show_bug.cgi?id=148538
708 Reviewed by Joseph Pecoraro.
710 InspectorClients must explicitly disconnect their frontend channel(s) from the
711 inspected page's InspectorController.
713 To make this possible, DumpRenderTree should not destroy non-primary views until
714 it has tried to close any abandoned Web Inspector instances. Performing teardown
715 in the reverse order prevents disconnection of the frontend channel because that
716 prematurely destroys the inspector frontend client.
718 * DumpRenderTree/mac/DumpRenderTree.mm:
720 * DumpRenderTree/win/DumpRenderTree.cpp:
723 2015-09-03 Timothy Hatcher <timothy@apple.com>
725 Update WebKit nightly icon to be more like Safari
726 https://bugs.webkit.org/show_bug.cgi?id=148768
728 Reviewed by Joseph Pecoraro.
730 * WebKitLauncher/webkit.icns:
732 2015-09-03 Geoffrey Garen <ggaren@apple.com>
734 JavaScriptCore should have some ES6 conformance tests
735 https://bugs.webkit.org/show_bug.cgi?id=148771
737 Reviewed by Chris Dumez.
739 * Scripts/run-javascriptcore-tests:
740 (runJSCStressTests): Added es6 as a test suite.
742 * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
744 Some of these tests currently fail, so I also added a way to expect
745 failure for now. We'll migrate failing tests to expected passes as we
748 2015-09-03 Tim Horton <timothy_horton@apple.com>
750 Add a test for swipe-start hysteresis
751 https://bugs.webkit.org/show_bug.cgi?id=148756
753 Reviewed by Anders Carlsson.
755 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
756 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
757 (WTR::cacheTestRunnerCallback):
758 (WTR::TestRunner::clearTestRunnerCallbacks):
759 * WebKitTestRunner/InjectedBundle/TestRunner.h:
760 Make sure that we log if a client tries to install a callback twice
761 (since we use .add, the second call would not work).
763 Also, add clearTestRunnerCallbacks so tests can swap out installed
766 2015-09-03 Anders Carlsson <andersca@apple.com>
768 DumpRenderTree should automatically compute HTTP URLs for HTTP tests
769 https://bugs.webkit.org/show_bug.cgi?id=148746
770 rdar://problem/22568073
772 Reviewed by Tim Horton.
774 * DumpRenderTree/mac/DumpRenderTree.mm:
776 Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests.
782 Get rid of this; computeTestURL does this for us now.
784 * Scripts/webkitpy/port/driver.py:
785 (Driver._command_from_driver_input):
786 Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
788 2015-09-03 Tim Horton <timothy_horton@apple.com>
790 Swipe tests fail on Mavericks
791 https://bugs.webkit.org/show_bug.cgi?id=148752
793 Reviewed by Beth Dakin.
795 * WebKitTestRunner/mac/EventSenderProxy.mm:
797 2015-09-03 Tim Horton <timothy_horton@apple.com>
801 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
802 (WTR::PlatformWebView::setNavigationGesturesEnabled):
804 2015-09-03 Tim Horton <timothy_horton@apple.com>
806 Remove some logging that wasn't meant to be in the tree
808 * WebKitTestRunner/mac/EventSenderProxy.mm:
809 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
811 2015-09-03 Tim Horton <timothy_horton@apple.com>
813 [Mac] Add support for testing swipes
814 https://bugs.webkit.org/show_bug.cgi?id=148700
816 Reviewed by Beth Dakin.
818 * WebKitTestRunner/EventSenderProxy.h:
819 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
820 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
821 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
822 (WTR::cgEventPhaseFromString):
823 (WTR::cgEventMomentumPhaseFromString):
824 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
825 (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
826 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
827 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
828 (WTR::InjectedBundle::didReceiveMessageToPage):
829 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
830 (WTR::TestRunner::installDidBeginSwipeCallback):
831 (WTR::TestRunner::installWillEndSwipeCallback):
832 (WTR::TestRunner::installDidEndSwipeCallback):
833 (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
834 (WTR::TestRunner::callDidBeginSwipeCallback):
835 (WTR::TestRunner::callWillEndSwipeCallback):
836 (WTR::TestRunner::callDidEndSwipeCallback):
837 (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
838 * WebKitTestRunner/InjectedBundle/TestRunner.h:
839 * WebKitTestRunner/TestController.cpp:
840 (WTR::TestController::createOtherPage):
841 (WTR::TestController::createWebViewWithOptions):
842 (WTR::TestController::didReceiveMessageFromInjectedBundle):
843 (WTR::TestController::didBeginNavigationGesture):
844 (WTR::TestController::willEndNavigationGesture):
845 (WTR::TestController::didEndNavigationGesture):
846 (WTR::TestController::didRemoveNavigationGestureSnapshot):
847 * WebKitTestRunner/TestController.h:
848 * WebKitTestRunner/TestInvocation.cpp:
849 (WTR::TestInvocation::didBeginSwipe):
850 (WTR::TestInvocation::willEndSwipe):
851 (WTR::TestInvocation::didEndSwipe):
852 (WTR::TestInvocation::didRemoveSwipeSnapshot):
853 * WebKitTestRunner/TestInvocation.h:
854 Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
855 when the snapshot is removed.
857 Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
858 mouseScrollBy function.
860 * WebKitTestRunner/mac/EventSenderProxy.mm:
861 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
862 (-[EventSenderSyntheticEvent type]):
863 (-[EventSenderSyntheticEvent subtype]):
864 (-[EventSenderSyntheticEvent locationInWindow]):
865 (-[EventSenderSyntheticEvent location]):
866 (-[EventSenderSyntheticEvent momentumPhase]):
867 (-[EventSenderSyntheticEvent _isTouchesEnded]):
868 (-[EventSenderSyntheticEvent _cgsEventRecord]):
869 Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
870 more adjustable values.
872 (WTR::EventSenderProxy::mouseForceDown):
873 (WTR::EventSenderProxy::mouseForceUp):
874 (WTR::EventSenderProxy::mouseForceChanged):
875 Adopt EventSenderSyntheticEvent.
877 (WTR::nsEventPhaseFromCGEventPhase):
878 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
879 Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
881 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
882 (WTR::PlatformWebView::PlatformWebView):
885 2015-09-03 Myles C. Maxfield <mmaxfield@apple.com>
887 [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
888 https://bugs.webkit.org/show_bug.cgi?id=148723
890 Reviewed by Anders Carlsson.
892 * WebKitTestRunner/TestController.cpp:
894 (WTR::updateViewOptionsFromTestHeader):
895 (WTR::TestController::viewOptionsForTest):
897 2015-09-03 Lucas Forschler <lforschler@apple.com>
901 2015-09-02 Tim Horton <timothy_horton@apple.com>
903 Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
904 https://bugs.webkit.org/show_bug.cgi?id=148693
906 Reviewed by Anders Carlsson.
908 * WebKitTestRunner/TestController.cpp:
909 (WTR::TestController::createOtherPage):
910 (WTR::TestController::createWebViewWithOptions):
912 2015-09-02 Carlos Garcia Campos <cgarcia@igalia.com>
914 REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
915 https://bugs.webkit.org/show_bug.cgi?id=148529
917 Reviewed by Darin Adler.
919 When there are pending EventSender messages after a test finishes,
920 they could be processed in the main loop started by the
921 resetStateToConsistentValues(), but the old EventSender has been
922 replaced by a new one at that point. The new Eventsender can crash
923 when processing messages that were sent to the old one. To avoid
924 this, we return early when receiving an EventSender message and
925 the TestController state is not RunningTest.
927 * WebKitTestRunner/TestController.cpp:
928 (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
929 (WTR::TestController::didReceiveMessageFromInjectedBundle):
931 2015-09-02 Carlos Garcia Campos <cgarcia@igalia.com>
933 REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
934 https://bugs.webkit.org/show_bug.cgi?id=148528
936 Reviewed by Darin Adler.
938 Before r188548 resetStateToConsistentValues() was called in
939 TestController::run(), before tests are run, but now it's called
940 for every test in TestInvocation::invoke(), after m_status has
941 changed to RunningTest.
943 * WebKitTestRunner/TestController.cpp:
944 (WTR::TestController::resetStateToConsistentValues): Use
945 TemporaryChange to reset m_state ot its previous value after reset
948 2015-08-31 Jason Marcell <jmarcell@apple.com>
950 Modify prepare-Changelog to be aware of files that are marked as tests as well as files
951 that are marked as requiring corresponding tests.
952 https://bugs.webkit.org/show_bug.cgi?id=148498
953 <rdar://problem/21555314>
955 Reviewed by Dan Bernstein and David Kilzer.
957 * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
958 simulate Git's attribute behevaior.
959 (main): Added "requiresTests" array to contain files that require tests.
960 (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
961 section in ChangeLog.
962 (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
963 however, we check if the file or any containing folder has the given property set to "1" and
964 return 1 if so; return 0 otherwise.
965 (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
966 adds files to "addedRegressionTests" array if "test" attribute is set to "1".
968 2015-08-26 Andy Estes <aestes@apple.com>
970 [Content Filtering] Determine navigation and content policy before continuing to filter a load
971 https://bugs.webkit.org/show_bug.cgi?id=148506
973 Reviewed by Brady Eidson.
975 Added download API tests covering every decision and decision point.
976 Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
978 * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
979 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
980 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
981 (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
982 returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
983 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
984 decision and decision point as a bundle parameter.
985 (+[MockContentFilterEnabler supportsSecureCoding]):
986 (-[MockContentFilterEnabler copyWithZone:]):
987 (-[MockContentFilterEnabler initWithCoder:]):
988 (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
989 (-[MockContentFilterEnabler encodeWithCoder:]):
990 (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
991 (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
992 (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
993 (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
994 (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
995 (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
996 (downloadTest): Added a helper function to test downloads with a given decision and decision point.
997 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
998 the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
999 singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
1000 (+[MockContentFilterEnabler supportsSecureCoding]):
1001 (-[MockContentFilterEnabler copyWithZone:]):
1002 (-[MockContentFilterEnabler initWithCoder:]):
1003 (-[MockContentFilterEnabler dealloc]):
1004 (-[MockContentFilterEnabler encodeWithCoder:]):
1005 (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
1006 (-[ContentFilteringPlugIn dealloc]): Stop observing.
1007 (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
1008 (+[ServerRedirectPlugIn initialize]): Deleted.
1009 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1010 (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1011 (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
1014 2015-08-31 Filip Pizlo <fpizlo@apple.com>
1016 Skip slow lock tests on Windows/debug
1017 https://bugs.webkit.org/show_bug.cgi?id=148643
1019 Reviewed by Alexey Proskuryakov.
1021 The lock tests simulate a critical section by doing some floating point math, and then either
1022 make those critical sections very long or invoke them many times. This appears to be
1023 particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
1024 that kind of computation slow.
1026 These tests are almost as useful in release as they are in debug, so it's probably better to
1027 just skip the in debug on platforms where this causes timeouts.
1029 * TestWebKitAPI/Tests/WTF/Lock.cpp:
1030 (TestWebKitAPI::runLockTest):
1031 (TestWebKitAPI::skipSlow):
1032 (TestWebKitAPI::TEST):
1034 2015-08-29 Chris Fleizach <cfleizach@apple.com>
1036 AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
1037 https://bugs.webkit.org/show_bug.cgi?id=125720
1039 Reviewed by Daniel Bates.
1041 Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
1043 * DumpRenderTree/AccessibilityUIElement.cpp:
1045 (scrollToMakeVisibleWithSubFocusCallback):
1046 (scrollToGlobalPointCallback):
1047 (scrollToMakeVisibleCallback):
1048 (AccessibilityUIElement::getJSClass):
1049 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1050 (AccessibilityUIElement::scrollToMakeVisible):
1051 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1052 (AccessibilityUIElement::scrollToGlobalPoint):
1053 (AccessibilityUIElement::selectedTextRange):
1054 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1055 (AccessibilityUIElement::AccessibilityUIElement):
1056 (AccessibilityUIElement::mathPrescriptsDescription):
1057 (AccessibilityUIElement::scrollToMakeVisible):
1058 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1059 (AccessibilityUIElement::scrollToGlobalPoint):
1060 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1061 (WTR::AccessibilityUIElement::isTextMarkerValid):
1062 (WTR::AccessibilityUIElement::textMarkerForIndex):
1063 (WTR::AccessibilityUIElement::scrollToMakeVisible):
1064 (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1065 (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1066 (WTR::AccessibilityUIElement::supportedActions):
1067 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1068 (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1069 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1070 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1071 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1072 (WTR::AccessibilityUIElement::scrollToMakeVisible):
1073 (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1074 (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1075 (WTR::AccessibilityUIElement::selectedTextRange):
1076 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1077 (WTR::AccessibilityUIElement::scrollToMakeVisible):
1078 (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1079 (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1080 (WTR::AccessibilityUIElement::selectedTextRange):
1082 2015-08-28 Timothy Horton <timothy_horton@apple.com>
1084 Add a mysteriously nonproblematic missing comma.
1086 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1087 (TestExpectationParser._collect_matching_tests):
1088 (TestExpectationParser):
1090 2015-08-28 Timothy Horton <timothy_horton@apple.com>
1092 Remove an old temporary script that has served its purpose
1094 * Scripts/convert-test-expectations: Removed.
1096 2015-08-28 Jer Noble <jer.noble@apple.com>
1098 [iOS] Add WebKit/WebKit2 settings to control automatic data loading
1099 https://bugs.webkit.org/show_bug.cgi?id=148579
1101 Reviewed by Anders Carlsson.
1103 In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
1105 In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
1106 and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
1108 * DumpRenderTree/mac/DumpRenderTree.mm:
1109 (resetWebPreferencesToConsistentValues):
1110 (resetWebViewToConsistentStateBeforeTesting):
1111 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1112 (WTR::initializeWebViewConfiguration):
1114 2015-08-28 Alexey Proskuryakov <ap@apple.com>
1116 Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
1117 https://bugs.webkit.org/show_bug.cgi?id=148592
1119 Reviewed by Tim Horton.
1121 * Scripts/webkitpy/port/base.py:
1122 (Port.to.setup_environ_for_server):
1124 (Port.to._append_value_colon_separated):
1125 (Port.to.show_results_html_file):
1126 * Scripts/webkitpy/port/ios.py:
1127 (IOSSimulatorPort.setup_environ_for_server):
1128 * Scripts/webkitpy/port/mac.py:
1129 (MacPort.setup_environ_for_server):
1131 2015-08-28 Filip Pizlo <fpizlo@apple.com>
1133 LICM should be sound even if the CFG has changed
1134 https://bugs.webkit.org/show_bug.cgi?id=148259
1136 Reviewed by Benjamin Poulain.
1138 Add a utility for creating tests that set some uncommon option.
1140 * Scripts/run-jsc-stress-tests:
1142 2015-08-28 Brent Fulgham <bfulgham@apple.com>
1144 [Win] Unreviewed EWS correction.
1146 * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
1148 2015-08-28 Jer Noble <jer.noble@apple.com>
1150 [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
1151 https://bugs.webkit.org/show_bug.cgi?id=147512
1153 Reviewed by Anders Carlsson.
1155 Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
1156 to a consistent (true) value.
1158 * DumpRenderTree/mac/DumpRenderTree.mm:
1159 (setDefaultsToConsistentValuesForTesting):
1160 * WebKitTestRunner/TestController.cpp:
1161 (WTR::TestController::resetPreferencesToConsistentValues):
1163 2015-08-28 Tim Horton <timothy_horton@apple.com>
1165 Add navigation gesture callbacks to WKPageNavigationClient
1166 https://bugs.webkit.org/show_bug.cgi?id=148568
1167 <rdar://problem/22371346>
1169 Reviewed by Anders Carlsson.
1171 * WebKitTestRunner/TestController.cpp:
1172 (WTR::TestController::createOtherPage):
1173 (WTR::TestController::createWebViewWithOptions):
1176 2015-08-28 Alexey Proskuryakov <ap@apple.com>
1178 [Mac] kill-old-processes should kill more processes
1179 https://bugs.webkit.org/show_bug.cgi?id=148577
1181 Reviewed by Tim Horton.
1183 * BuildSlaveSupport/kill-old-processes:
1185 2015-08-28 Jason Marcell <jmarcell@apple.com>
1187 The status message for combined builder queues should say "all builds succeeded" if everything
1189 https://bugs.webkit.org/show_bug.cgi?id=148535
1191 Reviewed by David Kilzer and Alexey Proskuryakov.
1193 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1194 (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
1195 say "all builds succeeded" if everything built correctly.
1197 2015-08-28 Carlos Garcia Campos <cgarcia@igalia.com>
1199 [GTK] Simplify the internal API to create a WebView
1200 https://bugs.webkit.org/show_bug.cgi?id=148570
1202 Reviewed by Žan Doberšek.
1204 * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
1205 * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1206 (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
1207 PlatformWebView constructors that end up calling initialize with a PageConfiguration.
1208 (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
1209 passing the received PageConfiguration.
1210 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1211 (WTR::PlatformWebView::PlatformWebView): Create the WebView
1212 passing the received PageConfiguration.
1214 2015-08-27 Aakash Jain <aakash_jain@apple.com>
1216 iOS Simulator API tests fails as Simulator is not running
1217 https://bugs.webkit.org/show_bug.cgi?id=148501
1218 rdar://problem/22447525
1220 Reviewed by Daniel Bates.
1222 This change is a workaround for <rdar://problem/22388812>.
1224 * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
1225 and quit it on program termination when running tests on the iOS port.
1226 * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
1227 SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
1229 2015-08-27 Alex Christensen <achristensen@webkit.org>
1231 Make DLLLauncherMain executables dependent on dll
1232 https://bugs.webkit.org/show_bug.cgi?id=148548
1234 Reviewed by Brent Fulgham.
1236 * DumpRenderTree/CMakeLists.txt:
1237 * DumpRenderTree/PlatformWin.cmake:
1238 * MiniBrowser/win/CMakeLists.txt:
1239 * TestWebKitAPI/CMakeLists.txt:
1240 * TestWebKitAPI/PlatformWin.cmake:
1242 2015-08-27 Lucas Forschler <lforschler@apple.com>
1244 Remove Mac slaves 188/189 after being replaced with 400/401.
1248 * BuildSlaveSupport/build.webkit.org-config/config.json:
1250 2015-08-27 Lucas Forschler <lforschler@apple.com>
1252 Add two bots to the Mac Yosemite queue.
1253 This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
1257 * BuildSlaveSupport/build.webkit.org-config/config.json:
1259 2015-08-27 Alex Christensen <achristensen@webkit.org>
1261 [Win CMake] Fix incremental build after r188673
1262 https://bugs.webkit.org/show_bug.cgi?id=148539
1264 Reviewed by Brent Fulgham.
1266 * TestWebKitAPI/PlatformWin.cmake:
1267 Copy forwarding headers from WebCore before building in case that was not yet done.
1268 It used to be done when running CMake, but now it's a build step.
1270 2015-08-27 Nan Wang <n_wang@apple.com>
1272 AX: Fix accessibility/select-element-at-index.html test
1273 https://bugs.webkit.org/show_bug.cgi?id=148516
1275 Reviewed by Chris Fleizach.
1277 Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
1279 * DumpRenderTree/AccessibilityUIElement.cpp:
1280 (setSelectedChildCallback):
1281 (setSelectedChildAtIndexCallback):
1282 (removeSelectionAtIndexCallback):
1283 (elementAtPointCallback):
1284 (sentenceAtOffsetCallback):
1285 (stringForSelectionCallback):
1286 (AccessibilityUIElement::getJSClass):
1287 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1288 (AccessibilityUIElement::setSelectedChild):
1289 (AccessibilityUIElement::setSelectedChildAtIndex):
1290 (AccessibilityUIElement::removeSelectionAtIndex):
1291 (AccessibilityUIElement::accessibilityValue):
1292 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1293 (WTR::AccessibilityUIElement::wordAtOffset):
1294 (WTR::AccessibilityUIElement::lineAtOffset):
1295 (WTR::AccessibilityUIElement::sentenceAtOffset):
1296 (WTR::AccessibilityUIElement::isSelectable):
1297 (WTR::AccessibilityUIElement::isMultiSelectable):
1298 (WTR::AccessibilityUIElement::setSelectedChild):
1299 (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1300 (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1301 (WTR::AccessibilityUIElement::selectedChildrenCount):
1302 (WTR::AccessibilityUIElement::selectedChildAtIndex):
1303 (WTR::AccessibilityUIElement::isExpanded):
1304 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1305 (WTR::AccessibilityUIElement::setSelectedChild):
1306 (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1307 (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1308 (WTR::AccessibilityUIElement::accessibilityValue):
1310 2015-08-27 Alex Christensen <achristensen@webkit.org>
1312 Build fix after r188982
1314 * MiniBrowser/win/CMakeLists.txt:
1315 The directory structure changed in the move.
1317 2015-08-27 Michael Catanzaro <mcatanzaro@igalia.com>
1319 [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
1321 geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
1323 * gtk/install-dependencies:
1325 2015-08-27 Carlos Garcia Campos <cgarcia@igalia.com>
1327 Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
1329 * Scripts/run-gtk-tests:
1332 2015-08-27 Carlos Garcia Campos <cgarcia@igalia.com>
1334 Fix GTK+ WTR crashes in initializeMainRunLoop()
1336 Rubber-stamped by Žan Doberšek.
1338 Initialize threading and main thread before
1339 RunLoop::initializeMainRunLoop(), since the GLib implementation of
1340 the RunLoop uses isMainThread() to decide whether to create a new
1341 GMainContext or use the default one. Also use RunLoop::run() and
1342 ::stop() instead of gtk_main/quit.
1344 * WebKitTestRunner/TestController.cpp:
1345 (WTR::TestController::initialize):
1346 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1347 (WTR::TestController::notifyDone):
1348 (WTR::TestController::platformRunUntil):
1350 2015-08-27 Filip Pizlo <fpizlo@apple.com>
1352 Unreviewed, further shorten a test that times out because it's very long
1355 I've locally run these tests on repeat for 24 hours and found no genuine
1356 failures, like deadlocks. So, the timeouts are probably because the test
1357 machine is slow and debug is slow. We should just run this test for fewer
1360 * TestWebKitAPI/Tests/WTF/Lock.cpp:
1361 (TestWebKitAPI::TEST):
1363 2015-08-26 Ryuan Choi <ryuan.choi@navercorp.com>
1365 Unreviewed build fix attempt on EFL
1367 * WebKitTestRunner/PlatformEfl.cmake:
1369 2015-08-26 Alex Christensen <achristensen@webkit.org>
1371 Build fix after r188982
1373 * MiniBrowser/win/CMakeLists.txt:
1374 Find .rc files in correct directory.
1376 2015-08-26 Ryuan Choi <ryuan.choi@navercorp.com>
1378 [EFL] Bump cairo version to 1.14.2
1379 https://bugs.webkit.org/show_bug.cgi?id=148474
1381 Reviewed by Csaba Osztrogonác.
1383 * efl/jhbuild.modules:
1385 2015-08-26 Andy Estes <aestes@apple.com>
1387 Crash when following a Google search link to Twitter with Limit Adult Content enabled
1388 https://bugs.webkit.org/show_bug.cgi?id=147651
1390 Rubber-stamped by Brady Eidson.
1392 Taught TestRunner how to decide the navigation policy after a delay.
1394 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1395 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1396 (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1397 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1398 (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1399 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1400 (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
1401 * WebKitTestRunner/TestController.cpp:
1402 (WTR::TestController::initialize):
1403 (WTR::TestController::resetStateToConsistentValues):
1404 (WTR::TestController::decidePolicyForNavigationAction):
1405 * WebKitTestRunner/TestController.h:
1406 (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
1407 * WebKitTestRunner/TestInvocation.cpp:
1408 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1410 2015-08-26 Brent Fulgham <bfulgham@apple.com>
1412 [Win] Rename 'WinLauncher' to 'MiniBrowser'
1413 https://bugs.webkit.org/show_bug.cgi?id=148485
1415 Reviewed by Alex Christensen
1417 Move the WinLauncher project and source files to a subdirectory
1418 of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
1419 source code and project files.
1421 * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
1422 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
1423 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
1424 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
1425 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
1426 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
1427 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
1428 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
1429 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
1430 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
1431 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
1432 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
1433 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
1434 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
1435 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
1436 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
1437 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
1438 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
1439 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
1440 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
1441 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
1442 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
1443 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
1444 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
1445 * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
1446 * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
1447 * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
1448 * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
1449 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
1450 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
1451 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
1452 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
1453 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
1454 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
1455 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1456 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
1457 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
1458 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1459 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1460 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
1461 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
1462 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
1463 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
1464 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
1465 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
1466 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
1467 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
1468 * MiniBrowser/win: Copied from WinLauncher.
1469 * MiniBrowser/win/Common.cpp:
1470 * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
1471 * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
1472 * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
1473 * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
1474 * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
1475 * MiniBrowser/win/PageLoadTestClient.cpp:
1476 * MiniBrowser/win/PageLoadTestClient.h:
1477 * MiniBrowser/win/ResourceLoadDelegate.cpp:
1478 * MiniBrowser/win/ResourceLoadDelegate.h:
1479 * MiniBrowser/win/WinLauncher.cpp: Removed.
1480 * MiniBrowser/win/WinLauncher.h: Removed.
1481 * MiniBrowser/win/WinLauncher.vcxproj: Removed.
1482 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
1483 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
1484 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
1485 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
1486 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
1487 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
1488 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
1489 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
1490 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
1491 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
1492 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1493 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
1494 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
1495 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1496 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1497 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
1498 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
1499 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
1500 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
1501 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
1502 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
1503 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
1504 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
1505 * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
1506 * MiniBrowser/win/WinLauncherReplace.h: Removed.
1507 * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
1508 * MiniBrowser/win/WinLauncherWebHost.h: Removed.
1509 * MiniBrowser/win/WinMain.cpp:
1510 * WinLauncher: Removed.
1511 * WinLauncher/AccessibilityDelegate.cpp: Removed.
1512 * WinLauncher/AccessibilityDelegate.h: Removed.
1513 * WinLauncher/CMakeLists.txt: Removed.
1514 * WinLauncher/Common.cpp: Removed.
1515 * WinLauncher/DOMDefaultImpl.cpp: Removed.
1516 * WinLauncher/DOMDefaultImpl.h: Removed.
1517 * WinLauncher/PageLoadTestClient.cpp: Removed.
1518 * WinLauncher/PageLoadTestClient.h: Removed.
1519 * WinLauncher/PrintWebUIDelegate.cpp: Removed.
1520 * WinLauncher/PrintWebUIDelegate.h: Removed.
1521 * WinLauncher/ResourceLoadDelegate.cpp: Removed.
1522 * WinLauncher/ResourceLoadDelegate.h: Removed.
1523 * WinLauncher/WebDownloadDelegate.cpp: Removed.
1524 * WinLauncher/WebDownloadDelegate.h: Removed.
1525 * WinLauncher/WinLauncher.cpp: Removed.
1526 * WinLauncher/WinLauncher.h: Removed.
1527 * WinLauncher/WinLauncher.vcxproj: Removed.
1528 * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
1529 * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
1530 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
1531 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
1532 * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
1533 * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
1534 * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
1535 * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
1536 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
1537 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
1538 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1539 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
1540 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
1541 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1542 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1543 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
1544 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
1545 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
1546 * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
1547 * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
1548 * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
1549 * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
1550 * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
1551 * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
1552 * WinLauncher/WinLauncherReplace.h: Removed.
1553 * WinLauncher/WinLauncherWebHost.cpp: Removed.
1554 * WinLauncher/WinLauncherWebHost.h: Removed.
1555 * WinLauncher/WinMain.cpp: Removed.
1556 * WinLauncher/resource.h: Removed.
1557 * WinLauncher/stdafx.cpp: Removed.
1558 * WinLauncher/stdafx.h: Removed.
1559 * win/AssembleBuildLogs/AssembleLogs.cmd:
1561 2015-08-26 Brent Fulgham <bfulgham@apple.com>
1563 [Win] Simplify menu handling code in WinLauncher
1564 https://bugs.webkit.org/show_bug.cgi?id=148461
1566 Reviewed by Zalan Bujtas.
1568 Revise 'ToggleMenuItem' to return a boolean value indicating if
1569 it handled the message. Revise WndProc to use this to decide if it
1570 should pass the message on to the default handler, rather than
1571 duplicating the logic in both places.
1573 * WinLauncher/Common.cpp:
1574 (ToggleMenuItem): Return true if the menu item message was handled.
1575 (WndProc): If 'ToggleMenuItem' did not handle the message, pass
1576 the message tothe default handler.
1578 2015-08-26 Csaba Osztrogonác <ossy@webkit.org>
1580 Remove unused code after r188948
1581 https://bugs.webkit.org/show_bug.cgi?id=148467
1583 Reviewed by Gyuyoung Kim.
1585 * WebKitTestRunner/TestController.cpp:
1586 (WTR::TestController::platformPreferences): Deleted.
1588 2015-08-26 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1590 [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
1591 https://bugs.webkit.org/show_bug.cgi?id=148377
1593 Reviewed by Carlos Garcia Campos.
1595 EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
1596 It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
1597 TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
1598 EFL and GTK at the moment.
1600 * WebKitTestRunner/TestController.cpp:
1601 (WTR::TestController::platformWillRunTest):
1602 * WebKitTestRunner/efl/TestControllerEfl.cpp:
1603 (WTR::TestController::platformPreferences):
1604 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1605 (WTR::TestController::platformPreferences):
1607 2015-08-25 Nan Wang <n_wang@apple.com>
1609 AX: Enable accessibility/aria-controls.html test for mac
1610 https://bugs.webkit.org/show_bug.cgi?id=148458
1612 Reviewed by Chris Fleizach.
1614 Implemented ariaControlsElementAtIndex(unsigned index).
1616 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1617 (AccessibilityUIElement::ariaControlsElementAtIndex):
1618 (AccessibilityUIElement::disclosedRowAtIndex):
1619 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1620 (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1622 2015-08-25 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1624 Remove python tests for PassRefPtr
1625 https://bugs.webkit.org/show_bug.cgi?id=148463
1627 Reviewed by Andy Estes.
1629 As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
1631 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1632 (PassPtrTest): Deleted.
1633 (PassPtrTest.assert_pass_ptr_check): Deleted.
1634 (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
1635 (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
1636 (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
1637 (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
1638 (PassPtrTest.test_ref_ptr_member_variable): Deleted.
1639 (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
1641 2015-08-25 Andy Estes <aestes@apple.com>
1643 [iOS] run-webkit-tests fails if watchOS SDK is installed
1644 https://bugs.webkit.org/show_bug.cgi?id=148453
1646 Reviewed by David Kilzer.
1648 * Scripts/webkitpy/xcode/simulator.py:
1649 (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
1650 * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
1652 2015-08-25 Aakash Jain <aakash_jain@apple.com>
1654 iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
1655 https://bugs.webkit.org/show_bug.cgi?id=148197
1656 rdar://problem/22334382
1658 Reviewed by Daniel Bates.
1660 * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
1661 * Scripts/webkitpy/port/ios.py:
1662 (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
1663 (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
1664 (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
1665 (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
1666 (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
1668 2015-08-25 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1670 Remove PassRefPtr style check rule
1671 https://bugs.webkit.org/show_bug.cgi?id=148432
1673 Reviewed by Andreas Kling.
1675 PassRefPtr is being removed. Thus style rule needs to be removed as well.
1677 * Scripts/webkitpy/style/checkers/cpp.py:
1678 (_check_parameter_name_against_text): Deleted.
1679 (check_function_definition_and_pass_ptr): Deleted.
1680 (check_function_definition): Deleted.
1681 (check_pass_ptr_usage): Deleted.
1682 (process_line): Deleted.
1683 (CppChecker): Deleted.
1685 2015-08-25 Brent Fulgham <bfulgham@apple.com>
1687 [Win] Expose "Inverted Colors" option in WinLauncher
1688 https://bugs.webkit.org/show_bug.cgi?id=148451
1690 Reviewed by Tim Horton.
1692 Add the ability to toggle the "Inverted Colors" preference
1695 * WinLauncher/Common.cpp:
1696 (ToggleMenuItem): Toggle the feature when the menu item
1698 (WndProc): Recognize the new menu option.
1699 * WinLauncher/WinLauncher.cpp:
1700 (WinLauncher::setToDefaultPreferences): Launch with "Invert
1702 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
1703 entry for "Invert Colors".
1704 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1706 2015-08-25 Nan Wang <n_wang@apple.com>
1708 [Mac] accessibility/document-attributes.html fails
1709 https://bugs.webkit.org/show_bug.cgi?id=116636
1711 Reviewed by Chris Fleizach.
1713 Implemented documentURI() and documentEncoding().
1715 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1716 (AccessibilityUIElement::documentEncoding):
1717 (AccessibilityUIElement::documentURI):
1718 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1719 (WTR::AccessibilityUIElement::documentEncoding):
1720 (WTR::AccessibilityUIElement::documentURI):
1722 2015-08-24 Brent Fulgham <bfulgham@apple.com>
1724 [Win] Unreviewed test gardening.
1726 Fix another case where the logging string is constructed using the variable 'frame',
1727 but the method argument is not given a name. This causes the global 'frame' value to
1728 be used, producing incorrect output.
1730 * DumpRenderTree/win/FrameLoadDelegate.cpp:
1731 (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
1734 2015-08-24 Tim Horton <timothy_horton@apple.com>
1736 (Finally...) get rid of WKViewIOS
1737 https://bugs.webkit.org/show_bug.cgi?id=148404
1739 Reviewed by Anders Carlsson.
1741 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1742 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1743 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1744 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1745 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1746 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1747 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1748 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1749 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1750 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
1751 Mark tests that use WKBrowsingContextController as Mac-only.
1753 * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1754 (WTR::AccessibilityController::addNotificationListener):
1755 * WebKitTestRunner/ios/mainIOS.mm:
1756 (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
1757 Import UIKit instead of depending on WKView.h to do so.
1759 2015-08-24 Jason Marcell <jmarcell@apple.com>
1761 Add support to dashboard for displaying Git SHA's as revisions.
1762 https://bugs.webkit.org/show_bug.cgi?id=148387
1764 Reviewed by Daniel Bates.
1766 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1767 (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
1768 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1769 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1770 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
1771 "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
1773 2015-08-24 Andy Estes <aestes@apple.com>
1775 REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
1777 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
1779 2015-08-23 Andy Estes <aestes@apple.com>
1781 Addressed a missed piece of review feedback from r188851.
1783 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1785 2015-08-23 Andy Estes <aestes@apple.com>
1787 [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
1788 https://bugs.webkit.org/show_bug.cgi?id=147872
1789 rdar://problem/22044000
1791 Reviewed by Dan Bernstein.
1795 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
1796 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1797 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
1798 (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
1799 (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
1800 (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
1801 (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
1802 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
1803 (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
1804 * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
1805 * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
1807 2015-08-23 Andy Estes <aestes@apple.com>
1809 Fixed the 32-bit Mac build after r188844.
1811 * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1812 * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1814 2015-08-22 Andy Estes <aestes@apple.com>
1816 [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
1817 https://bugs.webkit.org/show_bug.cgi?id=148317
1819 Reviewed by Dan Bernstein.
1821 Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
1822 creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
1823 WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
1824 when creating WKWebViews.
1826 Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
1827 added a new API test for bundle parameters.
1829 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
1830 named its executable TestWebKitAPI.bundle.
1831 * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
1832 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
1833 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
1834 (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
1835 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
1836 (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
1837 bundle parameter and asked for an initial notification.
1838 (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
1839 (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
1840 mirror its value in the main frame's JSContext.
1841 * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
1842 * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
1843 (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
1844 TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
1845 * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
1846 * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
1847 * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
1848 (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
1849 (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
1850 (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
1852 2015-08-23 Csaba Osztrogonác <ossy@webkit.org>
1854 URTBF after r188828.
1856 * WebKitTestRunner/PlatformWebView.h:
1858 2015-08-23 Alexey Proskuryakov <ap@apple.com>
1860 build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
1861 https://bugs.webkit.org/show_bug.cgi?id=148356
1863 Reviewed by Darin Adler.
1865 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1866 (BuildbotCombinedQueueView.prototype.update):
1868 2015-08-23 Alexey Proskuryakov <ap@apple.com>
1870 build.webkit.org/dashboard: Respect step's hidden flag
1871 https://bugs.webkit.org/show_bug.cgi?id=148357
1873 Reviewed by Darin Adler.
1875 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1876 (BuildbotIteration.prototype._parseData):
1878 2015-08-23 Nan Wang <n_wang@apple.com>
1880 AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
1881 https://bugs.webkit.org/show_bug.cgi?id=148328
1883 Reviewed by Darin Adler.
1885 We should only expose stringValue() when value attribute is set.
1887 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1888 (AccessibilityUIElement::stringValue):
1889 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1890 (WTR::AccessibilityUIElement::stringValue):
1892 2015-08-23 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1894 Remove style checking rule regarding OwnPtr and PassOwnPtr
1895 https://bugs.webkit.org/show_bug.cgi?id=148360
1897 Reviewed by Darin Adler.
1899 OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
1902 * Scripts/do-webcore-rename:
1903 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1904 (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
1905 (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
1906 (PassPtrTest.test_own_ptr_parameter_value): Deleted.
1907 (WebKitStyleTest.test_names): Deleted.
1909 2015-08-22 Timothy Horton <timothy_horton@apple.com>
1911 WebKitTestRunner should use WKWebView on OS X and iOS
1912 https://bugs.webkit.org/show_bug.cgi?id=143743
1913 <rdar://problem/16947123>
1915 Reviewed by Anders Carlsson.
1916 Patch by Enrica Casucci and myself.
1918 * WebKitTestRunner/PlatformWebView.h:
1919 (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
1920 Add a PlatformWebView constructor that takes a WKWebViewConfiguration
1921 instead of WKContext and WKPageGroup.
1923 Remove the unused, always-true windowSnapshotEnabled().
1924 While technically some platforms don't have window snapshotting,
1925 they just return null instead of implementing windowSnapshotEnabled().
1927 * WebKitTestRunner/TestController.h:
1928 * WebKitTestRunner/TestController.cpp:
1929 (WTR::TestController::createOtherPage):
1930 (WTR::TestController::initialize):
1931 (WTR::TestController::createWebViewWithOptions):
1932 Delegate to the various platforms for creating PlatformWebView instances,
1933 for creating WKContexts, and for accessing WKPreferences,
1934 so that they can do special things (like, use WKWebView instead!).
1936 (WTR::TestController::resetPreferencesToConsistentValues):
1937 Make explicit WebKitTestRunner's desired default for two preferences
1938 which have differing defaults between the antique and modern API,
1939 for consistency's sake.
1941 (WTR::TestController::resetStateToConsistentValues):
1942 Add platformResetStateToConsistentValues.
1944 * WebKitTestRunner/TestInvocation.cpp:
1945 (WTR::TestInvocation::dumpResults):
1946 Adjust to the aforementioned removal of windowSnapshotEnabled().
1948 * WebKitTestRunner/ios/TestControllerCocoa.mm:
1949 (WTR::TestController::platformResetStateToConsistentValues):
1950 (WTR::TestController::platformPreferences):
1951 (WTR::TestController::platformCreateWebView):
1952 (WTR::TestController::platformCreateOtherPage):
1953 (WTR::TestController::platformInitializeConfiguration):
1954 Implement the new platform functions for the Modern WebKit2 API,
1955 in a new TestControllerCocoa file that is shared between iOS and Mac.
1957 For platformMaybeCreateContext, use the trick that we know we can cast
1958 the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
1959 WKWebView's configuration.
1961 Ditto for WKPreferencesRef and WKPreferences.
1963 Remove user content filters on the WKWebView's userContentController.
1965 * WebKitTestRunner/mac/TestControllerMac.mm:
1966 * WebKitTestRunner/ios/TestControllerIOS.mm:
1967 Move code into TestControllerCocoa.
1969 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1970 (WTR::InjectedBundle::beginTesting):
1971 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1972 (WTR::TestRunner::addUserScript):
1973 (WTR::TestRunner::addUserStyleSheet):
1974 Adopt WKBundlePage API for user scripts/sheets.
1976 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1977 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1978 Make and keep a WKWebView instead of a WKView.
1980 * WebKitTestRunner/mac/EventSenderProxy.mm:
1981 (WTR::EventSenderProxy::mouseUp):
1982 (WTR::EventSenderProxy::mouseMoveTo):
1983 Reach inside the WKWebView to the WKView when dispatching events.
1984 This is fairly ugly and we should come up with a better solution.
1985 Also, fix some flipping and style errors.
1987 2015-08-22 Michael Catanzaro <mcatanzaro@igalia.com>
1989 Unreviewed, attempt to fix GTK build after r188718
1991 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1992 (WTR::PlatformWebView::PlatformWebView):
1994 2015-08-21 Commit Queue <commit-queue@webkit.org>
1996 Unreviewed, rolling out r188807, r188813, and r188815.
1997 https://bugs.webkit.org/show_bug.cgi?id=148349
1999 lots of 32-bit build problems, better to resolve separately
2000 and try again (Requested by thorton on #webkit).
2002 Reverted changesets:
2004 "WebKitTestRunner should use WKWebView on OS X and iOS"
2005 https://bugs.webkit.org/show_bug.cgi?id=143743
2006 http://trac.webkit.org/changeset/188807
2008 "Stop building WebKitTestRunner for 32-bit platforms"
2009 https://bugs.webkit.org/show_bug.cgi?id=143743
2010 http://trac.webkit.org/changeset/188813
2012 "Stop building WebKitTestRunner for 32-bit platforms"
2013 https://bugs.webkit.org/show_bug.cgi?id=143743
2014 http://trac.webkit.org/changeset/188815
2016 2015-08-21 Tim Horton <timothy_horton@apple.com>
2018 Stop building WebKitTestRunner for 32-bit platforms
2019 https://bugs.webkit.org/show_bug.cgi?id=143743
2020 <rdar://problem/16947123>
2022 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2023 This is a restriction on the valid set, not the desired set.
2025 2015-08-21 Jason Marcell <jmarcell@apple.com>
2027 Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
2028 to work with these new objects.
2029 https://bugs.webkit.org/show_bug.cgi?id=148188
2031 Reviewed by Daniel Bates.
2033 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2034 (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
2035 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2036 (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
2037 (repository, "branch name")-pair.
2038 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
2039 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2040 (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
2041 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2042 (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
2043 objects which represent a (repository, "branch name")-pair.
2044 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2045 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2046 (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
2047 (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
2048 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
2049 BuildbotQueue.branch to BuildbotQueue.branches.
2050 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2051 (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
2053 2015-08-21 Tim Horton <timothy_horton@apple.com>
2055 Stop building WebKitTestRunner for 32-bit platforms
2056 https://bugs.webkit.org/show_bug.cgi?id=143743
2057 <rdar://problem/16947123>
2059 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2060 WKWebView is not available on 32-bit OS X.
2062 2015-08-21 Brent Fulgham <bfulgham@apple.com>
2064 [Win] Unreviewed test correction after r188709.
2066 I removed a function argument that happened to be mirrored by a global
2067 value with the same name. This prevented a compile error, but testing
2068 showed that the wrong value was being used in the function.
2070 * DumpRenderTree/win/FrameLoadDelegate.cpp:
2071 (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
2074 2015-08-21 Timothy Horton <timothy_horton@apple.com>
2076 WebKitTestRunner should use WKWebView on OS X and iOS
2077 https://bugs.webkit.org/show_bug.cgi?id=143743
2078 <rdar://problem/16947123>
2080 Reviewed by Anders Carlsson.
2081 Patch by Enrica Casucci and myself.
2083 * WebKitTestRunner/PlatformWebView.h:
2084 (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
2085 Add a PlatformWebView constructor that takes a WKWebViewConfiguration
2086 instead of WKContext and WKPageGroup.
2088 Remove the unused, always-true windowSnapshotEnabled().
2089 While technically some platforms don't have window snapshotting,
2090 they just return null instead of implementing windowSnapshotEnabled().
2092 * WebKitTestRunner/TestController.h:
2093 * WebKitTestRunner/TestController.cpp:
2094 (WTR::TestController::createOtherPage):
2095 (WTR::TestController::initialize):
2096 (WTR::TestController::createWebViewWithOptions):
2097 Delegate to the various platforms for creating PlatformWebView instances,
2098 for creating WKContexts, and for accessing WKPreferences,
2099 so that they can do special things (like, use WKWebView instead!).
2101 (WTR::TestController::resetPreferencesToConsistentValues):
2102 Make explicit WebKitTestRunner's desired default for two preferences
2103 which have differing defaults between the antique and modern API,
2104 for consistency's sake.
2106 (WTR::TestController::resetStateToConsistentValues):
2107 Add platformResetStateToConsistentValues.
2109 * WebKitTestRunner/TestInvocation.cpp:
2110 (WTR::TestInvocation::dumpResults):
2111 Adjust to the aforementioned removal of windowSnapshotEnabled().
2113 * WebKitTestRunner/ios/TestControllerCocoa.mm:
2114 (WTR::TestController::platformResetStateToConsistentValues):
2115 (WTR::TestController::platformPreferences):
2116 (WTR::TestController::platformCreateWebView):
2117 (WTR::TestController::platformCreateOtherPage):
2118 (WTR::TestController::platformInitializeConfiguration):
2119 Implement the new platform functions for the Modern WebKit2 API,
2120 in a new TestControllerCocoa file that is shared between iOS and Mac.
2122 For platformMaybeCreateContext, use the trick that we know we can cast
2123 the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
2124 WKWebView's configuration.
2126 Ditto for WKPreferencesRef and WKPreferences.
2128 Remove user content filters on the WKWebView's userContentController.
2130 * WebKitTestRunner/mac/TestControllerMac.mm:
2131 * WebKitTestRunner/ios/TestControllerIOS.mm:
2132 Move code into TestControllerCocoa.
2134 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2135 (WTR::InjectedBundle::beginTesting):
2136 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2137 (WTR::TestRunner::addUserScript):
2138 (WTR::TestRunner::addUserStyleSheet):
2139 Adopt WKBundlePage API for user scripts/sheets.
2141 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2142 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2143 Make and keep a WKWebView instead of a WKView.
2145 * WebKitTestRunner/mac/EventSenderProxy.mm:
2146 (WTR::EventSenderProxy::mouseUp):
2147 (WTR::EventSenderProxy::mouseMoveTo):
2148 Reach inside the WKWebView to the WKView when dispatching events.
2149 This is fairly ugly and we should come up with a better solution.
2150 Also, fix some flipping and style errors.
2152 2015-08-21 Alexey Proskuryakov <ap@apple.com>
2154 Improve how UI events are dispatched by WebKitTestRunner
2155 https://bugs.webkit.org/show_bug.cgi?id=148326
2157 Reviewed by Anders Carlsson.
2159 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2160 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2161 Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
2162 asynchronous (and really, it has always been for the most part).
2164 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2165 (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
2166 (WTR::EventSendingController::mouseUp): Ditto.
2167 (WTR::EventSendingController::mouseMoveTo): Ditto.
2168 (WTR::EventSendingController::mouseForceDown): Ditto.
2169 (WTR::EventSendingController::mouseForceUp): Ditto.
2170 (WTR::EventSendingController::mouseForceChanged): Ditto.
2171 (WTR::EventSendingController::leapForward): Ditto.
2172 (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
2173 (WTR::EventSendingController::keyDown): Ditto.
2174 (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
2175 (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
2176 to be done in custom WebKit2 code for test wheel event handling.
2177 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
2178 (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
2179 (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
2180 (WTR::EventSendingController::addTouchPoint): Ditto.
2181 (WTR::EventSendingController::updateTouchPoint): Ditto.
2182 (WTR::EventSendingController::setTouchModifier): Ditto.
2183 (WTR::EventSendingController::setTouchPointRadius): Ditto.
2184 (WTR::EventSendingController::touchStart): Ditto.
2185 (WTR::EventSendingController::touchMove): Ditto.
2186 (WTR::EventSendingController::touchEnd): Ditto.
2187 (WTR::EventSendingController::touchCancel): Ditto.
2188 (WTR::EventSendingController::clearTouchPoints): Ditto.
2189 (WTR::EventSendingController::releaseTouchPoint): Ditto.
2190 (WTR::EventSendingController::cancelTouchPoint): Ditto.
2192 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2193 (WTR::InjectedBundle::postSetWindowIsKey):
2194 (WTR::InjectedBundle::postSimulateWebNotificationClick):
2195 (WTR::InjectedBundle::isGeolocationProviderActive):
2196 (WTR::InjectedBundle::shouldProcessWorkQueue):
2197 Updated for WKBundlePagePostSynchronousMessage renaming.
2199 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2200 (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
2202 * WebKitTestRunner/TestController.cpp:
2203 (WTR::TestController::initialize): Allow handling the new test style messages.
2204 (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
2205 to WKPageSetShouldSendEventsSynchronously, which we no longer need.
2206 (WTR::TestController::didReceiveMessageFromInjectedBundle):
2207 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
2208 "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
2210 * WebKitTestRunner/mac/EventSenderProxy.mm:
2211 (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
2212 (WTR::EventSenderProxy::keyDown): Ditto.
2213 (WTR::EventSenderProxy::mouseScrollBy): Ditto.
2214 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2216 2015-08-21 Yusuke Suzuki <utatane.tea@gmail.com>
2218 Skip no-llint tests that fail due to running out of executable memory after r188969
2219 https://bugs.webkit.org/show_bug.cgi?id=148273
2221 Reviewed by Michael Saboff.
2223 * Scripts/run-jsc-stress-tests:
2225 2015-08-21 Nan Wang <n_wang@apple.com>
2227 [Mac] accessibility/selection-states.html fails
2228 https://bugs.webkit.org/show_bug.cgi?id=116637
2230 Reviewed by Chris Fleizach.
2232 Implemented isSelectable() and isMultiSelectable().
2234 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2235 (AccessibilityUIElement::isSelectable):
2236 (AccessibilityUIElement::isMultiSelectable):
2237 (AccessibilityUIElement::isSelectedOptionActive):
2238 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2239 (WTR::AccessibilityUIElement::isSelectable):
2240 (WTR::AccessibilityUIElement::isMultiSelectable):
2241 (WTR::AccessibilityUIElement::isVisible):
2243 2015-08-21 Jason Marcell <jmarcell@apple.com>
2245 Fix iteration over repositories on bot watcher's dashboard.
2247 Reviewed by Alexey Proskuryakov.
2249 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2250 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
2252 2015-08-20 Joonghun Park <jh718.park@samsung.com>
2254 [EFL] Revise PlatformWebView ctor according to r188718
2255 https://bugs.webkit.org/show_bug.cgi?id=148282
2257 This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
2258 instead of WKContextRef and WKPageGroupRef respectively.
2260 Reviewed by Gyuyoung Kim.
2262 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2263 (WTR::PlatformWebView::PlatformWebView):
2265 2015-08-20 Devin Rousso <dcrousso+webkit@gmail.com>
2267 Unreviewed, changed Devin Rousso's email.
2269 * Scripts/webkitpy/common/config/contributors.json:
2271 2015-08-20 Anders Carlsson <andersca@apple.com>
2273 Use WKPageConfigurationRef in WebKitTestRunner
2274 https://bugs.webkit.org/show_bug.cgi?id=147996
2276 Reviewed by Tim Horton.
2278 * WebKitTestRunner/TestController.cpp:
2279 (WTR::TestController::createOtherPage):
2280 (WTR::TestController::initialize):
2281 (WTR::TestController::createWebViewWithOptions):
2282 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2283 (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
2284 (WTR::PlatformWebView::PlatformWebView):
2285 (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
2287 2015-08-20 Brent Fulgham <bfulgham@apple.com>
2289 [Win] Update Windows tools for revised MIDL interfaces
2290 https://bugs.webkit.org/show_bug.cgi?id=148249
2292 Reviewed by Dean Jackson.
2294 This is a follow-up to Bug 148001.
2296 Revise the testing software to use compatible signatures and
2297 implementations to match the requirements of the IDL generated
2298 with the SAL annotations.
2300 * DumpRenderTree/win/DRTDataObject.cpp:
2301 * DumpRenderTree/win/DRTDataObject.h:
2302 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2303 * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2304 * DumpRenderTree/win/DRTDropSource.cpp:
2305 * DumpRenderTree/win/DRTDropSource.h:
2306 * DumpRenderTree/win/DumpRenderTree.cpp:
2307 * DumpRenderTree/win/EditingDelegate.cpp:
2308 * DumpRenderTree/win/EditingDelegate.h:
2309 * DumpRenderTree/win/FrameLoadDelegate.cpp:
2310 * DumpRenderTree/win/FrameLoadDelegate.h:
2311 * DumpRenderTree/win/HistoryDelegate.cpp:
2312 * DumpRenderTree/win/HistoryDelegate.h:
2313 * DumpRenderTree/win/PolicyDelegate.cpp:
2314 * DumpRenderTree/win/PolicyDelegate.h:
2315 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2316 * DumpRenderTree/win/ResourceLoadDelegate.h:
2317 * DumpRenderTree/win/TestRunnerWin.cpp:
2318 * DumpRenderTree/win/UIDelegate.cpp:
2319 * DumpRenderTree/win/UIDelegate.h:
2320 * WinLauncher/AccessibilityDelegate.cpp:
2321 * WinLauncher/AccessibilityDelegate.h:
2322 * WinLauncher/Common.cpp:
2323 * WinLauncher/DOMDefaultImpl.cpp:
2324 * WinLauncher/DOMDefaultImpl.h:
2325 * WinLauncher/PageLoadTestClient.cpp:
2326 * WinLauncher/PageLoadTestClient.h:
2327 * WinLauncher/PrintWebUIDelegate.cpp:
2328 * WinLauncher/PrintWebUIDelegate.h:
2329 * WinLauncher/ResourceLoadDelegate.cpp:
2330 * WinLauncher/ResourceLoadDelegate.h:
2331 * WinLauncher/WebDownloadDelegate.cpp:
2332 * WinLauncher/WebDownloadDelegate.h:
2333 * WinLauncher/WinLauncherWebHost.cpp:
2334 * WinLauncher/WinLauncherWebHost.h:
2335 * WinLauncher/WinMain.cpp:
2336 * win/DLLLauncher/DLLLauncherMain.cpp:
2338 2015-08-20 Filip Pizlo <fpizlo@apple.com>
2340 Unreviewed, shorten a test that runs too long and times out.
2342 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2343 (TestWebKitAPI::TEST):
2345 2015-08-20 Alex Christensen <achristensen@webkit.org>
2347 Clean up CMake build after r188673
2348 https://bugs.webkit.org/show_bug.cgi?id=148234
2350 Reviewed by Tim Horton.
2352 * DumpRenderTree/PlatformWin.cmake:
2353 * TestWebKitAPI/CMakeLists.txt:
2354 * TestWebKitAPI/PlatformWin.cmake:
2355 Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
2356 gtest needs to be a static library on Windows to not crash.
2358 2015-08-19 Alex Christensen <achristensen@webkit.org>
2360 CMake Windows build should not include files directly from other Source directories
2361 https://bugs.webkit.org/show_bug.cgi?id=148198
2363 Reviewed by Brent Fulgham.
2365 * DumpRenderTree/DumpRenderTreePrefix.h:
2366 Include cmakeconfig.h to properly define all enabled features.
2367 * DumpRenderTree/PlatformWin.cmake:
2368 * TestWebKitAPI/PlatformWin.cmake:
2370 2015-08-19 Alex Christensen <achristensen@webkit.org>
2372 Build TestWTF on Mac with CMake.
2373 https://bugs.webkit.org/show_bug.cgi?id=147972
2375 Reviewed by Tim Horton.
2377 TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
2378 Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
2380 * TestWebKitAPI/CMakeLists.txt:
2381 Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
2382 WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
2383 * TestWebKitAPI/PlatformMac.cmake: Added.
2384 * TestWebKitAPI/config.h:
2385 Postpone some build fixes until WebKit builds completely on Mac with CMake.
2387 2015-08-19 Brian Burg <bburg@apple.com>
2389 Unreviewed, add Aleksandr Skachkov to the list of contributors.
2391 * Scripts/webkitpy/common/config/contributors.json:
2393 2015-08-18 Carlos Alberto Lopez Perez <clopez@igalia.com>
2395 REGRESSION(r188548): [GTK] Build broken.
2396 https://bugs.webkit.org/show_bug.cgi?id=148154
2398 Reviewed by Martin Robinson.
2400 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2401 (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2402 Even if we don't need to add/override any settings in ViewOptions,
2403 we need to define this as an empty function to make it build.
2405 2015-08-18 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2407 Fix conversion-null warning in conversion.cpp of TestWebKitAPI
2408 https://bugs.webkit.org/show_bug.cgi?id=148073
2410 Reviewed by Alexey Proskuryakov.
2412 * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
2413 (TestWebKitAPI::TEST):
2415 2015-08-18 Anders Carlsson <andersca@apple.com>
2417 Fix test failure fallout from r188602 by using a V5 page ui client struct.
2419 * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2420 (TestWebKitAPI::setUpClients):
2422 2015-08-18 Brian Burg <bburg@apple.com>
2424 Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
2425 https://bugs.webkit.org/show_bug.cgi?id=147955
2427 Reviewed by Timothy Hatcher.
2429 To enable sharing of common test code between protocol and model tests,
2430 start loading the protocol TestStub.js through the WebInspectorUI bundle.
2432 This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
2433 protocol-test.js uses to load the inspector frontend stub into its iframe
2434 from an arbitrary local file URL.
2436 * DumpRenderTree/TestRunner.cpp:
2437 (getInspectorTestStubURLCallback):
2438 (TestRunner::staticValues):
2439 * DumpRenderTree/TestRunner.h:
2440 * DumpRenderTree/mac/TestRunnerMac.mm:
2441 (SOFT_LINK_STAGED_FRAMEWORK):
2442 (TestRunner::inspectorTestStubURL):
2443 * DumpRenderTree/win/TestRunnerWin.cpp:
2444 (TestRunner::inspectorTestStubURL):
2445 * WebKitTestRunner/Configurations/Base.xcconfig:
2446 Since WebKitTestRunner now includes WebCore private headers, also search
2447 for the WebCore framework inside the WebKit umbrella framework.
2449 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2450 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2451 * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2452 (WTR::TestRunner::inspectorTestStubURL):
2453 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2454 (WTR::TestRunner::inspectorTestStubURL):
2455 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2456 (WTR::TestRunner::inspectorTestStubURL):
2458 2015-08-18 Filip Pizlo <fpizlo@apple.com>
2460 Unreviewed, fix GTK build.
2462 * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2463 (TestWebKitAPI::TEST):
2465 2015-08-17 Filip Pizlo <fpizlo@apple.com>
2467 Replace all remaining uses of WTF::Mutex with WTF::Lock
2468 https://bugs.webkit.org/show_bug.cgi?id=148089
2470 Reviewed by Geoffrey Garen.
2472 * DumpRenderTree/JavaScriptThreading.cpp:
2473 (javaScriptThreadsMutex):
2474 (runJavaScriptThread):
2475 (startJavaScriptThreads):
2476 (stopJavaScriptThreads):
2477 * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
2478 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2479 (TestWebKitAPI::TEST):
2480 * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2481 (TestWebKitAPI::TEST):
2483 2015-08-17 Commit Queue <commit-queue@webkit.org>
2485 Unreviewed, rolling out r188539, r188544, r188552, and
2487 https://bugs.webkit.org/show_bug.cgi?id=148122
2489 Broke tests and some build styles (Requested by ap on
2492 Reverted changesets:
2494 "Web Inspector: load ProtocolTestStub from the WebInspectorUI
2496 https://bugs.webkit.org/show_bug.cgi?id=147955
2497 http://trac.webkit.org/changeset/188539
2499 "Web Inspector: split TestStub.js into multiple files and
2501 https://bugs.webkit.org/show_bug.cgi?id=148077
2502 http://trac.webkit.org/changeset/188544
2504 "Web Inspector: InspectorTest should be a subclass of
2506 https://bugs.webkit.org/show_bug.cgi?id=148079
2507 http://trac.webkit.org/changeset/188552
2509 "Unreviewed internal build fix attempt after r188539."
2510 http://trac.webkit.org/changeset/188564
2512 2015-08-17 Myles C. Maxfield <mmaxfield@apple.com>
2514 [OS X] Remove support for composite fonts
2515 https://bugs.webkit.org/show_bug.cgi?id=147920
2517 Reviewed by Dan Bernstein.
2519 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2520 * DumpRenderTree/fonts/SampleFont.sfont: Removed.
2521 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2522 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2523 * DumpRenderTree/mac/DumpRenderTree.mm:
2524 (allowedFontFamilySet): Deleted.
2525 (activateTestingFonts): Deleted.
2526 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2527 (WTR::allowedFontFamilySet): Deleted.
2528 (WTR::activateFonts): Deleted.
2529 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2530 * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
2531 * WebKitTestRunner/mac/TestControllerMac.mm:
2532 (WTR::allowedFontFamilySet): Deleted.
2534 2015-08-17 Jon Honeycutt <jhoneycutt@apple.com>
2536 Unreviewed internal build fix attempt after r188539.
2538 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2540 2015-08-17 Myles C. Maxfield <mmaxfield@apple.com>
2546 * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2548 2015-08-17 Alex Christensen <achristensen@webkit.org>
2550 Build Debug Suffix on Windows with CMake
2551 https://bugs.webkit.org/show_bug.cgi?id=148083
2553 Reviewed by Brent Fulgham.
2555 * TestWebKitAPI/CMakeLists.txt:
2556 * TestWebKitAPI/PlatformWin.cmake:
2559 2015-08-17 Anders Carlsson <andersca@apple.com>
2561 Simplify how PlatformWebViews are created when view options change
2562 https://bugs.webkit.org/show_bug.cgi?id=148093
2564 Reviewed by Sam Weinig.
2566 Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
2568 TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
2569 TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
2570 ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
2572 If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
2574 Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
2575 always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
2577 * WebKitTestRunner/TestController.cpp:
2578 (WTR::TestController::ensureViewSupportsOptionsForTest):
2579 (WTR::shouldUseFixedLayout):
2580 (WTR::TestController::viewOptionsForTest):
2581 (WTR::TestController::updateWebViewSizeForTest):
2582 (WTR::TestController::updateWindowScaleForTest):
2583 (WTR::TestController::configureViewForTest):
2584 (WTR::TestController::initialize): Deleted.
2585 (WTR::TestController::ensureViewSupportsOptions): Deleted.
2586 (WTR::TestController::updateLayoutTypeForTest): Deleted.
2587 (WTR::TestController::platformConfigureViewForTest): Deleted.
2588 (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
2589 (WTR::TestController::run): Deleted.
2590 * WebKitTestRunner/TestController.h:
2591 * WebKitTestRunner/efl/TestControllerEfl.cpp:
2592 (WTR::shouldUseFixedLayout):
2593 (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2594 (WTR::TestController::platformConfigureViewForTest):
2595 (WTR::TestController::platformResetPreferencesToConsistentValues):
2596 * WebKitTestRunner/ios/TestControllerIOS.mm:
2597 (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2598 * WebKitTestRunner/mac/TestControllerMac.mm:
2599 (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2600 (WTR::TestController::platformConfigureViewForTest):
2602 2015-08-17 Sam Weinig <sam@webkit.org>
2604 API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
2605 https://bugs.webkit.org/show_bug.cgi?id=148097
2607 Reviewed by Anders Carlsson.
2609 * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
2610 Add tests for WebsiteDataStores in the WKPageConfiguration.
2612 2015-08-17 Brian Burg <bburg@apple.com>
2614 Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
2615 https://bugs.webkit.org/show_bug.cgi?id=147955
2617 Reviewed by Timothy Hatcher.
2619 To enable sharing of common test code between protocol and model tests,
2620 start loading the protocol TestStub.js through the WebInspectorUI bundle.
2622 This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
2623 protocol-test.js uses to load the inspector frontend stub into its iframe
2624 from an arbitrary local file URL.
2626 * DumpRenderTree/TestRunner.cpp:
2627 (getInspectorTestStubURLCallback):
2628 (TestRunner::staticValues):
2629 * DumpRenderTree/TestRunner.h:
2630 * DumpRenderTree/mac/TestRunnerMac.mm:
2631 (SOFT_LINK_STAGED_FRAMEWORK):
2632 (TestRunner::inspectorTestStubURL):
2633 * DumpRenderTree/win/TestRunnerWin.cpp:
2634 (TestRunner::inspectorTestStubURL):
2635 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2636 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2637 * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2638 (WTR::TestRunner::inspectorTestStubURL):
2639 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2640 (WTR::TestRunner::inspectorTestStubURL):
2641 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2642 (WTR::TestRunner::inspectorTestStubURL):
2644 2015-08-17 Saam barati <sbarati@apple.com>
2646 Change email address from saambarati1@gmail.com to sbarati@apple.com
2648 * Scripts/webkitpy/common/config/contributors.json:
2650 2015-08-17 Jason Marcell <jmarcell@apple.com>
2652 Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
2653 repositories other than "openSource" and "internal".
2654 https://bugs.webkit.org/show_bug.cgi?id=147961
2656 Reviewed by Daniel Bates.
2658 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2659 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
2660 generically with repositories other than "openSource" and "internal".
2662 2015-08-17 Alexey Proskuryakov <ap@apple.com>
2664 build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
2665 https://bugs.webkit.org/show_bug.cgi?id=148081
2667 Reviewed by Tim Horton.
2669 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2670 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2672 2015-08-11 Andy Estes <aestes@apple.com>
2674 [Cocoa] Add redirect support to CustomProtocolManager
2675 https://bugs.webkit.org/show_bug.cgi?id=147871
2677 Reviewed by Dan Bernstein.
2679 Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
2681 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2682 (TestWebKitAPI::TEST): Unregesitered TestProtocol.
2683 * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
2684 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2685 (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
2686 (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
2687 (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
2688 (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
2689 (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
2690 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2691 (TestWebKitAPI::TEST): Unregistered TestProtocol.
2692 * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
2693 (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
2694 (-[TestProtocol startLoading]): Taught to handle redirect responses.
2696 2015-08-13 Andy Estes <aestes@apple.com>
2698 [Cocoa] Downloads do not start if policy decision is made asynchronously
2699 https://bugs.webkit.org/show_bug.cgi?id=147985
2701 Reviewed by Brady Eidson.
2703 Added a new API test.
2705 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2706 (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2707 (-[AsynchronousDownloadDelegate _downloadDidStart:]):
2710 2015-08-14 Commit Queue <commit-queue@webkit.org>
2712 Unreviewed, rolling out r187357.
2713 https://bugs.webkit.org/show_bug.cgi?id=148032
2715 webkit-patch generates incorrect patches that cannot be
2716 applied (Requested by dydz on #webkit).
2720 "Call fixChangeLogPatch when generating patches from webkit-
2722 https://bugs.webkit.org/show_bug.cgi?id=147248
2723 http://trac.webkit.org/changeset/187357
2725 2015-08-14 Jason Marcell <jmarcell@apple.com>
2727 Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
2728 other than "openSource" and "internal".
2729 https://bugs.webkit.org/show_bug.cgi?id=147938
2731 Reviewed by Daniel Bates.
2733 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2734 (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
2735 repositories other than "openSource" and "internal".
2737 2015-08-14 Filip Pizlo <fpizlo@apple.com>
2739 Unreviewed, shorten another test that is timing out.
2741 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2742 (TestWebKitAPI::TEST):
2744 2015-08-13 Aakash Jain <aakash_jain@apple.com>
2746 AppScale: Assertion hit when hovering a webkit-queue bubble
2747 https://bugs.webkit.org/show_bug.cgi?id=147997
2749 Reviewed by Alexey Proskuryakov.
2751 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
2752 (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
2754 2015-08-13 Lucas Forschler <lforschler@apple.com>
2756 Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
2760 * Scripts/copy-webkitlibraries-to-product-directory:
2762 2015-08-13 Dewei Zhu <dewei_zhu@apple.com>
2764 Run benchmark customized Dromaeo should not assume there is an internet connection.
2765 https://bugs.webkit.org/show_bug.cgi?id=147995
2767 Reviewed by Ryosuke Niwa.
2769 Add several dependency js libs to local.
2771 * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
2773 2015-08-13 Filip Pizlo <fpizlo@apple.com>
2775 WTF should have a compact Condition object to use with Lock
2776 https://bugs.webkit.org/show_bug.cgi?id=147986
2778 Reviewed by Geoffrey Garen.
2780 Add a test for WTF::Condition.
2782 * TestWebKitAPI/CMakeLists.txt:
2783 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2784 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2785 * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
2786 (TestWebKitAPI::TEST):
2787 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2788 (TestWebKitAPI::runLockTest): Change the name of the thread.
2790 2015-08-13 Filip Pizlo <fpizlo@apple.com>
2792 Unreviewed, shorten another test. It's timing out in debug on some bot.
2794 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2795 (TestWebKitAPI::TEST):
2797 2015-08-12 Filip Pizlo <fpizlo@apple.com>
2799 WTF::Lock should not suffer from the thundering herd
2800 https://bugs.webkit.org/show_bug.cgi?id=147947
2802 Reviewed by Geoffrey Garen.
2804 Add testing that checks that locks return to a pristine state after contention is over.
2806 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2807 (TestWebKitAPI::LockInspector::isFullyReset):
2808 (TestWebKitAPI::runLockTest):
2809 (TestWebKitAPI::TEST):
2811 2015-08-12 Dewei Zhu <dewei_zhu@apple.com>
2813 Benchmarks supported by run_benchmark script should not assume we have internet access.
2814 https://bugs.webkit.org/show_bug.cgi?id=147959
2816 Reviewed by Ryosuke Niwa.
2818 For JSBench we should not request jquery.min.js from google through the internet.
2820 * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
2822 2015-08-12 Jason Marcell <jmarcell@apple.com>
2824 Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
2825 other than "openSource" and "internal".
2826 https://bugs.webkit.org/show_bug.cgi?id=147796
2828 Reviewed by Daniel Bates.
2830 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2831 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
2832 is now a repository object instead of the repository name, thus we don't have to pass the "trac"
2833 object in separately. Also added an assertion to see if the given repository is in iteration.revision,
2834 and another assertion that, if the previousIteration is non-null, the given repository is in
2835 previousIteration.revision.
2836 (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
2837 with repositories other than "openSource" and "internal". Also added an assertion that the returned
2838 fragment has at least one child node.
2840 2015-08-12 Simon Fraser <simon.fraser@apple.com>
2842 Add a tool that dumps class and struct member layout, showing padding
2843 https://bugs.webkit.org/show_bug.cgi?id=147898
2845 Reviewed by Zalan Bujtas.
2847 This 'dump-class-layout' script uses the lldb Python bindings to collect data
2848 about data member layout, and displays it.
2852 +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
2853 +0 < 56> WebCore::URL m_value;
2854 +0 < 8> WTF::String m_string;
2855 +0 < 8> WTF::RefPtr<WTF::StringImpl> m_impl;
2856 +0 < 8> WTF::StringImpl * m_ptr;
2857 +8 < 1> bool:1 m_isValid;
2858 +8 < 1> bool:1 m_protocolIsInHTTPFamily;
2860 +12 < 4> int m_schemeEnd;
2861 +16 < 4> int m_userStart;
2862 +20 < 4> int m_userEnd;
2863 +24 < 4> int m_passwordEnd;
2864 +28 < 4> int m_hostEnd;
2865 +32 < 4> int m_portEnd;
2866 +36 < 4> int m_pathAfterLastSlash;
2867 +40 < 4> int m_pathEnd;
2868 +44 < 4> int m_queryEnd;
2869 +48 < 4> int m_fragmentEnd;
2872 +56 < 8> WTF::ListHashSetNode<WebCore::URL> * m_prev;
2873 +64 < 8> WTF::ListHashSetNode<WebCore::URL> * m_next;
2876 Padding percentage: 15.28 %
2878 * Scripts/dump-class-layout: Added.
2882 (find_build_directory):
2884 (verify_type_recursive):
2889 2015-08-12 Alex Christensen <achristensen@webkit.org>
2891 Fix Debug CMake builds on Windows
2892 https://bugs.webkit.org/show_bug.cgi?id=147940
2894 Reviewed by Chris Dumez.
2896 * DumpRenderTree/PlatformWin.cmake:
2897 * TestWebKitAPI/PlatformWin.cmake:
2898 The BitmapImage test is not enabled on the AppleWin port.
2899 * WinLauncher/CMakeLists.txt:
2900 Debug builds need /NODEFAULTLIB:MSVCRTD, too.
2902 2015-08-12 Carlos Garcia Campos <cgarcia@igalia.com>
2904 Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
2906 In r188125 I added a way to mark tests as slow to use a longer
2907 timeout. But it seems it was not enough for
2908 WTF_Lock.ContendedShortSection, so let's try again with a longer
2911 * Scripts/run-gtk-tests:
2912 (TestRunner._run_google_test):
2914 2015-08-12 Yusuke Suzuki <utatane.tea@gmail.com>
2916 Allow --debug option in run-jsc
2917 https://bugs.webkit.org/show_bug.cgi?id=147923
2919 Reviewed by Csaba Osztrogonác.
2921 When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
2925 2015-08-11 Alex Christensen <achristensen@webkit.org>
2927 Fix test after build fix in r188286.
2928 https://bugs.webkit.org/show_bug.cgi?id=147907
2930 Reviewed by Anders Carlsson.
2932 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2933 sleep_for can now be used, but we need to include <thread>
2935 2015-08-11 Filip Pizlo <fpizlo@apple.com>
2937 Always use a byte-sized lock implementation
2938 https://bugs.webkit.org/show_bug.cgi?id=147908
2940 Reviewed by Geoffrey Garen.
2942 All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
2945 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2946 (TestWebKitAPI::runLockTest):
2947 (TestWebKitAPI::TEST):
2949 2015-08-11 Alexey Proskuryakov <ap@apple.com>
2951 Make ASan build not depend on asan.xcconfig
2952 https://bugs.webkit.org/show_bug.cgi?id=147840
2953 rdar://problem/21093702
2955 Reviewed by Daniel Bates.
2957 * asan/asan.xcconfig:
2958 * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
2959 are now marked in source code.
2961 2015-08-11 Filip Pizlo <fpizlo@apple.com>
2963 Unreviewed, shorten another test since it timed out.
2965 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2966 (TestWebKitAPI::TEST):
2968 2015-08-11 Mark Lam <mark.lam@apple.com>
2970 Fix names of Lock tests: should be "Contended", not "Contented".
2971 https://bugs.webkit.org/show_bug.cgi?id=147905
2973 Reviewed by Saam Barati.
2975 We're testing the behavior of lock contention (i.e. when threads contend), not
2976 whether the locks are happy (contented).
2978 * Scripts/run-gtk-tests:
2980 (TestRunner.__init__): Deleted.
2981 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2982 (TestWebKitAPI::runLockTest):
2983 (TestWebKitAPI::TEST):
2985 2015-08-11 Alex Christensen <achristensen@webkit.org>
2987 Update WinCairoRequirements to VS2015.
2989 * Scripts/update-webkit-wincairo-libs:
2990 Update WinCairoRequirements location.
2992 2015-08-11 Jason Marcell <jmarcell@apple.com>
2994 Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
2996 https://bugs.webkit.org/show_bug.cgi?id=147805
2998 Reviewed by Daniel Bates.
3000 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3001 (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
3002 Dashboard.Repository.Internal.trac for internalTrac.
3003 (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
3004 and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
3006 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3007 (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
3008 Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
3010 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
3011 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
3012 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3014 (Analyzer.prototype.analyze): Ditto.
3016 2015-08-11 Filip Pizlo <fpizlo@apple.com>
3018 Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
3020 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3021 (TestWebKitAPI::TEST):
3023 2015-08-11 Brent Fulgham <bfulgham@apple.com>
3025 [Win] Switch Windows build to Visual Studio 2015
3026 https://bugs.webkit.org/show_bug.cgi?id=147887
3027 <rdar://problem/22235098>
3029 Reviewed by Alex Christensen.
3031 Update Visual Studio project file settings to use the current Visual
3032 Studio and compiler. Continue targeting binaries to run on our minimum
3033 supported configuration of Windows 7.
3035 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3036 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3037 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3038 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3039 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3040 * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
3041 prefer the newer MSBuild included in Visual Studio 2015.
3042 (visualStudioInstallDir):
3043 (msBuildInstallDir):
3044 (visualStudioVersion):
3045 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3046 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3047 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3048 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3049 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3050 * win/record-memory/record-memory.vcxproj:
3052 2015-08-11 Alex Christensen <achristensen@webkit.org>
3054 Another speculative build fix after r188280.
3056 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3057 std::this_thread is too modern c++ for VS2013 and supported GCC versions,
3058 so let's go back to usleep and I made something close to usleep, but with much lower resolution.
3060 2015-08-11 Alex Christensen <achristensen@webkit.org>
3062 Unreviewed build fix after r188280.
3064 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3065 Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
3067 2015-08-10 Filip Pizlo <fpizlo@apple.com>
3069 WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
3070 https://bugs.webkit.org/show_bug.cgi?id=147665
3072 Reviewed by Mark Lam.
3074 * TestWebKitAPI/CMakeLists.txt:
3075 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3076 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3077 * TestWebKitAPI/Tests/WTF/Lock.cpp:
3078 (TestWebKitAPI::TEST):
3079 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
3080 (TestWebKitAPI::TEST):
3082 2015-08-11 Brian Burg <bburg@apple.com>
3084 webkit-patch should not explode when $EDITOR is set incorrectly
3085 https://bugs.webkit.org/show_bug.cgi?id=147884
3087 Reviewed by Darin Adler.
3089 If $EDITOR doesn't exist, log a warning and continue.
3091 * Scripts/webkitpy/common/system/user.py:
3093 (User.edit_changelog):
3095 2015-08-11 Dan Bernstein <mitz@apple.com>
3097 Reverted r188255, because it turned out that delegates do nonot need this information.
3099 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3100 * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
3102 2015-08-11 Dan Bernstein <mitz@apple.com>
3104 [Cocoa] The UI delegate can't tell if printing was user-initiated
3105 https://bugs.webkit.org/show_bug.cgi?id=147869
3107 Reviewed by Sam Weinig.
3109 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3110 * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
3111 (-[PrintFrameController webView:didFinishNavigation:]):
3112 (-[PrintFrameController _webView:printFrame:userInitiated:]):
3115 2015-08-10 Alex Christensen <achristensen@webkit.org>
3117 Another build fix after r188239.
3119 * TestWebKitAPI/PlatformWin.cmake:
3120 Link with more libraries.
3121 * WinLauncher/CMakeLists.txt:
3122 /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
3124 2015-08-10 Ryosuke Niwa <rniwa@webkit.org>
3126 Build fix after r188237.
3128 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
3129 (BenchmarkBuilder.__enter__):
3131 2015-08-10 Dewei Zhu <dewei_zhu@apple.com>
3133 Update ReadMe and correct the way to use abstract abstract class.
3134 https://bugs.webkit.org/show_bug.cgi?id=147860
3136 Reviewed by Ryosuke Niwa.
3138 Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
3139 so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
3141 * Scripts/webkitpy/benchmark_runner/README.md:
3142 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3144 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3145 (OSXBrowserDriver.restore_env):
3146 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
3148 (HTTPServerDriver.set_device_id):
3149 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3150 (SimpleHTTPServerDriver.get_return_code):
3151 (SimpleHTTPServerDriver):
3152 (SimpleHTTPServerDriver.set_device_id):
3154 2015-08-10 Alex Christensen <achristensen@webkit.org>
3156 Build TestWebKitAPI with CMake on Windows
3157 https://bugs.webkit.org/show_bug.cgi?id=147851
3159 Reviewed by Chris Dumez.
3162 * TestWebKitAPI/CMakeLists.txt:
3163 Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
3164 Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
3165 Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win
3166 before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
3167 * TestWebKitAPI/PlatformEfl.cmake:
3168 * TestWebKitAPI/PlatformGTK.cmake:
3169 Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
3170 I did this without changing the directory structure of the existing EFL and GTK builds.
3171 * TestWebKitAPI/PlatformWin.cmake: Added.
3172 * TestWebKitAPI/win/main.cpp:
3174 (dllLauncherEntryPoint):
3175 Added so we can launch TestWebKitAPI executables after finding the AAS directory.
3176 * WinLauncher/CMakeLists.txt:
3177 AppleWin port needs /NODEFAULTLIB:MSVCRT.
3179 2015-08-10 Dewei Zhu <dewei_zhu@apple.com>
3181 Make cleanup more robust and minor code cleaning in run benchmark script.
3182 https://bugs.webkit.org/show_bug.cgi?id=147800
3184 Reviewed by Ryosuke Niwa.
3186 Use 'finnaly' block to make sure cleanup code is always executed.
3188 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3190 (built_benchmark.__init__):
3191 (built_benchmark.__enter__):
3192 (built_benchmark.__exit__):
3194 (test_environment.__init__):
3195 (test_environment.__enter__):
3196 (test_environment.__exit__):
3197 (BenchmarkRunner.__init__):
3198 (BenchmarkRunner.execute):
3199 (BenchmarkRunner._dump):
3200 (BenchmarkRunner._wrap):
3201 (BenchmarkRunner): Deleted.
3202 (BenchmarkRunner._cleanup): Deleted.
3203 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3204 (BrowserDriver.close_browsers):
3206 (BrowserDriver.restore_env):
3207 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3208 (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
3210 2015-08-10 Youenn Fablet <youenn.fablet@crf.canon.fr>
3212 Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
3213 https://bugs.webkit.org/show_bug.cgi?id=146414
3215 Reviewed by Darin Adler.
3217 * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3218 (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
3220 2015-08-10 Carlos Garcia Campos <cgarcia@igalia.com>
3222 [GTK] Test /webkit2/WebKitWebView/submit-form is flaky
3223 https://bugs.webkit.org/show_bug.cgi?id=147727
3225 Reviewed by Sergio Villar Senin.
3227 I think it was not this test in particular, but
3228 /webkit2/WebKitWebView/custom-charset that is affecting the
3229 others. This is because changing the encoding reloads the page,
3230 but we don't wait for the page to be reloaded, so when the test
3231 finishes and other test starts the web process is still reloading
3234 * Scripts/run-gtk-tests:
3235 (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
3236 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3237 (testWebViewCustomCharset): Wait until page is reloaded after
3238 changing the charset.
3240 2015-08-09 Carlos Garcia Campos <cgarcia@igalia.com>
3242 Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
3244 It's timing out in the bots. My guess is that there's no installer
3245 installed in the bots and gst_install_plugins_supported() returns
3246 false, so we don't even get a permission request because no
3247 installer will be launched.
3249 * Scripts/run-gtk-tests:
3252 2015-08-07 Alex Christensen <achristensen@webkit.org>
3254 [GTK] Another build fix after r188157.
3256 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3257 (WTR::PlatformWebView::viewSupportsOptions):
3258 Name all the things correctly!
3260 2015-08-07 Alex Christensen <achristensen@webkit.org>
3262 [EFL, GTK] Build fix after r188176.
3264 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3265 I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
3267 2015-08-07 Alex Christensen <achristensen@webkit.org>
3269 [GTK] Speculative build fix after r188157.
3271 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3272 (WTR::PlatformWebView::PlatformWebView):
3273 Update parameter list.
3275 2015-08-07 Alex Christensen <achristensen@webkit.org>
3277 Build more testing binaries with CMake on Windows
3278 https://bugs.webkit.org/show_bug.cgi?id=147799
3280 Reviewed by Brent Fulgham.
3282 * DumpRenderTree/CMakeLists.txt:
3283 Build TestNetscapePlugin.
3284 * DumpRenderTree/PlatformWin.cmake:
3285 Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
3286 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
3287 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
3288 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
3289 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
3290 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
3291 * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
3292 * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
3293 * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
3295 2015-08-07 Jason Marcell <jmarcell@apple.com>
3297 Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
3298 https://bugs.webkit.org/show_bug.cgi?id=147667
3300 Reviewed by Daniel Bates.
3302 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3303 (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
3304 other than "openSource" and "internal".
3305 (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
3306 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3307 (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
3308 (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
3309 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3310 (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
3311 (sortedPlatforms): Deleted.
3312 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3313 (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
3314 (sortedPlatforms): Deleted.
3315 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3316 (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
3317 and sorts them by this property returning the new sorted array.
3319 2015-08-07 Filip Pizlo <fpizlo@apple.com>
3321 Lightweight locks should be adaptive
3322 https://bugs.webkit.org/show_bug.cgi?id=147545
3324 Reviewed by Geoffrey Garen.
3326 * TestWebKitAPI/CMakeLists.txt:
3327 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3328 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3329 * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
3330 (TestWebKitAPI::runLockTest):
3331 (TestWebKitAPI::TEST):
3333 2015-08-07 Anders Carlsson <andersca@apple.com>
3337 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3338 (WTR::PlatformWebView::viewSupportsOptions):
3340 2015-08-07 Alexey Proskuryakov <ap@apple.com>
3342 Update AppEngine app version numbers to the latest commit.
3344 * QueueStatusServer/app.yaml:
3345 * TestResultServer/app.yaml:
3347 2015-08-07 Anders Carlsson <andersca@apple.com>
3349 Simplify WKTR's view options
3350 https://bugs.webkit.org/show_bug.cgi?id=147791
3352 Reviewed by Sam Weinig.
3354 Instead of using a WKDictionaryRef, just use a struct for the options.
3356 * WebKitTestRunner/PlatformWebView.h:
3357 (WTR::PlatformWebView::options):
3358 (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3359 * WebKitTestRunner/TestController.cpp:
3360 (WTR::TestController::initialize):
3361 (WTR::TestController::createWebViewWithOptions):
3362 (WTR::TestController::ensureViewSupportsOptions):
3363 (WTR::TestController::updateLayoutTypeForTest):
3364 * WebKitTestRunner/TestController.h:
3365 * WebKitTestRunner/ViewOptions.h: Added.
3366 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3367 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3368 (WTR::PlatformWebView::PlatformWebView):
3369 (WTR::PlatformWebView::viewSupportsOptions):
3370 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3371 (WTR::PlatformWebView::viewSupportsOptions):
3372 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3373 (WTR::PlatformWebView::viewSupportsOptions):
3374 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3375 (WTR::PlatformWebView::PlatformWebView):
3376 (WTR::PlatformWebView::viewSupportsOptions):
3377 * WebKitTestRunner/mac/TestControllerMac.mm:
3378 (WTR::TestController::platformConfigureViewForTest):
3380 2015-08-07 Joseph Pecoraro <pecoraro@apple.com>
3382 Running tests for a long time results in some tests running very slowly (throttling)
3383 https://bugs.webkit.org/show_bug.cgi?id=147718
3385 Reviewed by Chris Dumez.
3387 Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
3388 Although COCOA ports default this setting to be disabled in WebKit1,
3389 we should make both test harnesses disable the setting for consistency.
3391 * DumpRenderTree/mac/DumpRenderTree.mm:
3392 (resetWebPreferencesToConsistentValues):
3394 2015-08-07 Ryosuke Niwa <rniwa@webkit.org>
3396 Use a specific version of Speedometer in run-benchmark
3397 https://bugs.webkit.org/show_bug.cgi?id=147769
3399 Reviewed by Chris Dumez.
3401 Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
3403 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
3405 2015-08-07 Ryosuke Niwa <rniwa@webkit.org>
3407 twisted_http_server.py should support --port
3408 https://bugs.webkit.org/show_bug.cgi?id=147771
3410 Reviewed by Chris Dumez.
3412 Added the option. This makes the script more useful on its own.
3414 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3416 2015-08-07 Carlos Garcia Campos <cgarcia@igalia.com>
3418 [GTK] WTF unit tests are timing out in the bots
3419 https://bugs.webkit.org/show_bug.cgi?id=147777
3421 Reviewed by Filip Pizlo.
3423 Add a way to mark google unit tests as slow and add
3424 WTF_Lock.ContentedShortSection to the list. In case of slow test
3425 we use the double of the given timeout for that particular test.
3427 * Scripts/run-gtk-tests:
3429 (TestRunner._run_google_test):
3431 2015-08-07 Carlos Garcia Campos <cgarcia@igalia.com>
3433 [GTK] run-gtk-tests should not stop when a google test case fails
3434 https://bugs.webkit.org/show_bug.cgi?id=147778
3436 Reviewed by Philippe Normand.
3438 For glib based tests we run the test runner with the -k option,
3439 but for google tests we are aborting as soon as we find a failure.
3441 * Scripts/run-gtk-tests:
3442 (TestRunner._run_google_test_suite): Use a global return code that
3443 is set to 1 when any test has failed.
3445 2015-08-07 Carlos Garcia Campos <cgarcia@igalia.com>
3447 [GStreamer] Do not automatically show PackageKit codec installation notifications
3448 https://bugs.webkit.org/show_bug.cgi?id=135973
3450 Reviewed by Philippe Normand.
3452 Handle the missing media plugins installation permission request
3453 in MiniBrowser and add a test case for the new API.
3455 * MiniBrowser/gtk/BrowserWindow.c:
3456 (webViewDecidePermissionRequest):
3457 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3458 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3459 (permissionRequestCallback):
3460 (testInstallMissingPluginsPermissionRequest):
3462 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3463 (methodCallCallback):
3465 2015-08-06 Joseph Pecoraro <pecoraro@apple.com>
3467 Running tests for a long time results in some tests running very slowly (throttling)
3468 https://bugs.webkit.org/show_bug.cgi?id=147718
3470 Reviewed by Alexey Proskuryakov.
3472 * WebKitTestRunner/TestController.cpp:
3473 (WTR::TestController::resetPreferencesToConsistentValues):
3474 Ensure throttling settings are disabled for tests for all ports, as
3475 COCOA ports default to having these setting enabled. Note, there is
3476 still other timer throttling not covered by these setting.
3478 2015-08-06 Ryosuke Niwa <rniwa@webkit.org>
3480 http_server_driver and benchmark_builder should not be in run-benchmark's plan files
3481 https://bugs.webkit.org/show_bug.cgi?id=147752
3483 Reviewed by Chris Dumez.
3485 Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
3487 Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
3488 This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
3490 * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
3491 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
3492 * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
3493 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
3494 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
3495 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3496 (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
3497 HTTPServerDriverFactory taking the platform name as an argument.
3498 (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
3499 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
3500 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
3501 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
3502 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
3503 * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
3504 * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
3505 * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
3506 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
3507 * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
3508 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
3509 (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
3510 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
3511 (HTTPServerDriver): Replaced name by platforms.
3512 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3513 (SimpleHTTPServerDriver): Ditto.
3514 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3515 (parse_args): Removed --http-server-driver option.
3518 2015-08-06 Chris Dumez <cdumez@apple.com>
3520 Toggle GPS state based on page visibility to save battery
3521 https://bugs.webkit.org/show_bug.cgi?id=147685
3523 Reviewed by Benjamin Poulain.
3525 Add testRunner.isGeolocationProviderActive() test support function.
3527 * DumpRenderTree/TestRunner.cpp:
3528 (isGeolocationProviderActiveCallback):
3529 (TestRunner::staticFunctions):
3530 * DumpRenderTree/TestRunner.h:
3531 * DumpRenderTree/mac/MockGeolocationProvider.h:
3532 * DumpRenderTree/mac/MockGeolocationProvider.mm:
3533 (-[MockGeolocationProvider isActive]):
3534 * DumpRenderTree/mac/TestRunnerMac.mm:
3535 (TestRunner::isGeolocationProviderActive):
3536 * DumpRenderTree/win/TestRunnerWin.cpp:
3537 (TestRunner::isGeolocationProviderActive):
3538 * WebKitTestRunner/GeolocationProviderMock.h:
3539 (WTR::GeolocationProviderMock::isActive):
3540 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3541 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3542 (WTR::InjectedBundle::isGeolocationProviderActive):
3543 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3544 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3545 (WTR::TestRunner::isGeolocationProviderActive):
3546 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3547 * WebKitTestRunner/TestController.cpp:
3548 (WTR::TestController::isGeolocationProviderActive):
3549 * WebKitTestRunner/TestController.h:
3550 * WebKitTestRunner/TestInvocation.cpp:
3551 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3553 2015-08-06 Ryosuke Niwa <rniwa@webkit.org>
3555 Automate JSBench with run-benchmark
3556 https://bugs.webkit.org/show_bug.cgi?id=147716
3558 Reviewed by Chris Dumez.
3560 Added JSBench plan to run-benchmark.
3562 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
3563 (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
3564 (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
3565 * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
3566 * Scripts/webkitpy/benchmark_runner/data/