new-run-webkit-tests hung while acquiring http lock on snow leopard bots
[WebKit-https.git] / Tools / ChangeLog
1 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
2
3         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
4         https://bugs.webkit.org/show_bug.cgi?id=64886
5
6         Temporarily disable the http locking to work around the issue.
7         I'm not actually sure if this is going to work or improve things
8         much.
9
10         Reviewed by Ryosuke Niwa.
11
12         * Scripts/webkitpy/layout_tests/port/mac.py:
13
14 2011-08-18  Tony Chang  <tony@chromium.org>
15
16         add embedded png checksums to WebKitTestRunner
17         https://bugs.webkit.org/show_bug.cgi?id=66494
18
19         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
20         some code from DRT and adds it to the WebKitTestRunner.
21
22         Reviewed by Darin Adler.
23
24         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
25         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
26         * WebKitTestRunner/GNUmakefile.am: Add new files
27         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
28         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
29         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
30         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
31         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
32         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
33         * WebKitTestRunner/cg/TestInvocationCG.cpp:
34         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
35         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
36         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
37
38 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
39
40         https://bugs.webkit.org/show_bug.cgi?id=47240
41
42         Fixed a cygwin path problem in the chromium port of diff_image;
43         Also made the return values of the diff_image function more consistent.
44
45         Reviewed by Dirk Pranke.
46
47         * Scripts/webkitpy/layout_tests/port/chromium.py:
48
49 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
50
51         [GTK] Fix compilation problems with deprecations in gtk+
52         https://bugs.webkit.org/show_bug.cgi?id=66073
53
54         Reviewed by Martin Robinson.
55
56         * DumpRenderTree/gtk/DumpRenderTree.cpp:
57         (main): G_CONST_RETURN was deprecated
58         * GtkLauncher/main.c:
59         (createWindow): Added gtk_box_new conditional compilation for
60         gtk+-3.
61         * MiniBrowser/gtk/BrowserWindow.c:
62         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
63         are just supporting gtk+-3 for WebKit2.
64
65 2011-08-18  Anders Carlsson  <andersca@apple.com>
66
67         Fix libc++ C++0x build
68         https://bugs.webkit.org/show_bug.cgi?id=66479
69
70         Reviewed by Adam Roben.
71
72         Add missing includes.
73
74         * DumpRenderTree/LayoutTestController.cpp:
75         * DumpRenderTree/mac/CheckedMalloc.cpp:
76
77 2011-08-18  Adam Roben  <aroben@apple.com>
78
79         Test that WebKit updates style when a WebView is moved between differently-scaled windows
80
81         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
82         WebView is moved between windows with different backing scale factors
83
84         Reviewed by Anders Carlsson.
85
86         * TestWebKitAPI/JavaScriptTest.cpp:
87         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
88         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
89         gtest's built-in error messages.
90
91         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
92         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
93         those overloads.
94
95         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
96
97         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
98         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
99         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
100         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
101         (TestWebKitAPI::setPageLoaderClient): Set up the client.
102         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
103         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
104         SyntheticBackingScaleFactorWindow and returns it.
105         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
106         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
107         window, is moved to a differently-scaled window, and is taken out of the window.
108         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
109         WebKit1 and WebKit2.
110         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
111
112         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
113
114         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
115         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
116
117         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
118         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
119         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
120         initializer.
121         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
122
123         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
124         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
125         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
126
127 2011-08-18  Dmitry Lomov  <dslomov@google.com>
128
129         https://bugs.webkit.org/show_bug.cgi?id=66425
130         check-webkit-style should detect incorrectly formatted file change descriptions.
131         Description, if present, should be separated from colon with a space.
132
133         Reviewed by David Levin.
134
135         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
136         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
137
138 2011-08-18  Adam Barth  <abarth@webkit.org>
139
140         webkit-patch pretty-diff should be shown in main help
141         https://bugs.webkit.org/show_bug.cgi?id=66404
142
143         Reviewed by Dimitri Glazkov.
144
145         As requested by dglazkov.
146
147         * Scripts/webkitpy/tool/commands/prettydiff.py:
148
149 2011-08-17  Dmitry Lomov  <dslomov@google.com>
150
151         https://bugs.webkit.org/show_bug.cgi?id=66400
152         Fix TestWebKitAPI build on Mac OS.
153
154         Reviewed by David Levin.
155
156         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
157
158 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
159
160         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
161         https://bugs.webkit.org/show_bug.cgi?id=66427
162
163         Reviewed by Adam Barth.
164
165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
167         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
180         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
181         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
182         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
189         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
190         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
195         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
197         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
205         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
207         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
211         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
212         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
223         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
226         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
227         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
229         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
233         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
239         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
249         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
253         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
255         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
257         ():
258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
260         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
261         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
271         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
272         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
273         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
274         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
275         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
276         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
277         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
278         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
279         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
280
281 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
282
283         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
284         https://bugs.webkit.org/show_bug.cgi?id=65877
285
286         Reviewed by Eric Seidel.
287
288         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
289
290 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
291
292         Remove base.keys and replace it with Object.keys.
293         https://bugs.webkit.org/show_bug.cgi?id=66422
294
295         Reviewed by Adam Barth.
296
297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
298         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
300
301 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
302
303         garden-o-matic Summary view should have items in descending chronological order.
304         https://bugs.webkit.org/show_bug.cgi?id=66403
305
306         Reviewed by Adam Barth.
307
308         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
309         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
310         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
311
312 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
313
314         Fix a few errors in garden-o-matic frontend unit tests.
315         https://bugs.webkit.org/show_bug.cgi?id=66421
316
317         Reviewed by Adam Barth.
318
319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
321         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
322
323 2011-08-17  Adam Barth  <abarth@webkit.org>
324
325         Update Tools to account for (CG) being added to Chromium builder names
326         https://bugs.webkit.org/show_bug.cgi?id=66410
327
328         Reviewed by Adam Barth.
329
330         Some of these names will change back once we turn on Skia bots.
331
332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
335         * Scripts/webkitpy/layout_tests/port/builders.py:
336         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
337         * TestResultServer/static-dashboards/builders.js:
338         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
339
340 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
341
342         Wire up relative time to garden-o-matic summary view.
343         https://bugs.webkit.org/show_bug.cgi?id=66343
344
345         Reviewed by Adam Barth.
346
347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
348         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
350         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
351         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
352
353 2011-08-17  Adam Roben  <aroben@apple.com>
354
355         Make run-api-tests run tests in alphabetical order
356
357         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
358
359         Reviewed by David Kilzer.
360
361         * Scripts/run-api-tests:
362         (runAllTests):
363         (runAllTestsInSuite):
364         Sort the lists of tests and suites before iterating over them.
365
366 2011-08-17  Adam Barth  <abarth@webkit.org>
367
368         garden-o-matic should be able to rebaseline expected failures
369         https://bugs.webkit.org/show_bug.cgi?id=66204
370
371         Reviewed by Dimitri Glazkov.
372
373         This patch introduces a new view for displaying expect, actual, and
374         differences between results.  The new view also has a fledgling
375         controller that handles some basic operations.  The new view is
376         exercised by rebaseline.html, which lets you rebaselines expected
377         failures, but the new view is not fully integrated into
378         garden-o-matic.html
379
380         More patches will be required to make this stuff fully working, but
381         this patch was already somewhat spiraling out of control.  Hopefully
382         this patch will serve as a good starting point for further development.
383
384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
396
397 2011-08-16  Chang Shu  <cshu@webkit.org>
398
399         Support reset in WebCore::Internals
400         https://bugs.webkit.org/show_bug.cgi?id=66307
401
402         Reviewed by Dimitri Glazkov.
403
404         Added call to resetInternalsObject in DRT.
405
406         * DumpRenderTree/chromium/TestShell.cpp:
407         (TestShell::resetTestController):
408         * DumpRenderTree/mac/DumpRenderTree.mm:
409         (resetWebViewToConsistentStateBeforeTesting):
410         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
411         (WebCore::WebPage::resetSettings):
412
413 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
414
415         Add a new build slave for the Qt port on Mac OS SnowLeopard.
416         https://bugs.webkit.org/show_bug.cgi?id=66392
417
418         Modify the config file to include the new build slave.
419
420         Reviewed by Adam Roben.
421
422         * BuildSlaveSupport/build.webkit.org-config/config.json:
423
424 2011-08-17  Sam White  <samuel.white@rochester.edu>
425
426         AccessibilityObject levels are inconsistent
427         https://bugs.webkit.org/show_bug.cgi?id=66180
428         
429         Added the ability to get numeric attribute values using numberAttributeValue. This
430         function complements the existing stringAttributeValue and boolAttributeValue functions.
431         The addition of numberAttributeValue was necessary because the stringAttributeValue
432         function does a type check and will only return strings. This limitation made it
433         impossible to get values for attributes that returned an NSNumber.
434
435         Reviewed by Chris Fleizach.
436
437         * DumpRenderTree/AccessibilityUIElement.cpp:
438         (numberAttributeValueCallback):
439         (AccessibilityUIElement::getJSClass):
440         * DumpRenderTree/AccessibilityUIElement.h:
441         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
442         (AccessibilityUIElement::numberAttributeValue):
443         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
444         (AccessibilityUIElement::numberAttributeValue):
445         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
446         (AccessibilityUIElement::numberAttributeValue):
447
448 2011-08-17  Adam Roben  <aroben@apple.com>
449
450         Tell Trac logs always to display all specified revisions in a single page
451
452         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
453         revisions than that.
454
455         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
456         relevant revisions
457
458         Reviewed by Daniel Bates.
459
460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
461         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
462         a single page.
463
464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
466         Updated tests for the above.
467
468 2011-08-17  Adam Roben  <aroben@apple.com>
469
470         Fix TestFailures's link to file a bug about TestFailures itself
471
472         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
473         bug about itself is broken
474
475         Reviewed by Dan Bates.
476
477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
478         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
479         the host from the path.
480
481 2011-08-17  Adam Roben  <aroben@apple.com>
482
483         Teach TestFailures to ignore unbelievably short test runs
484
485         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
486         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
487
488         Reviewed by Dan Bates.
489
490         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
491         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
492         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
493         that caused it not to run any tests at all (as happened for a while due to
494         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
495
496         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
497         Test for the above.
498
499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
500         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
501
502 2011-08-16  Adam Barth  <abarth@webkit.org>
503
504         Add a CG qualifier similar to the GPU qualifier
505         https://bugs.webkit.org/show_bug.cgi?id=66359
506
507         Reviewed by Eric Seidel.
508
509         Once we have a Skia configuration on Chromium Mac, we'll use this CG
510         qualifier to note that expectations apply only to the CG configuration.
511
512         * Scripts/webkitpy/layout_tests/port/chromium.py:
513         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
514
515 2011-08-16  Eric Seidel  <eric@webkit.org>
516
517         REGRESSION(92717): WinPort needs to parse version information from port_name
518         https://bugs.webkit.org/show_bug.cgi?id=66325
519
520         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
521
522         * Scripts/webkitpy/layout_tests/port/mac.py:
523         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
524
525 2011-08-16  Adam Barth  <abarth@webkit.org>
526
527         Change webkit-patch analyze-baselines to print in a more unix-friendly way
528         https://bugs.webkit.org/show_bug.cgi?id=66349
529
530         Reviewed by James Robinson.
531
532         As requested by jamesr.
533
534         * Scripts/webkitpy/tool/commands/rebaseline.py:
535
536 2011-08-16  Eric Seidel  <eric@webkit.org>
537
538         REGRESSION(92717): WinPort needs to parse version information from port_name
539         https://bugs.webkit.org/show_bug.cgi?id=66325
540
541         Reviewed by Adam Barth.
542
543         WinPort didn't have any port_name parsing logic.
544         Seemed it was best to just share the logic from MacPort.
545         Sharing the logic from MacPort seemed easiest with a shared superclass.
546         Once I created ApplePort (the superclass) there was a bunch of logic to share.
547         I found LeakDetector was just in the way when switching back and forth
548         between win.py and mac.py so I moved it into its own file.
549
550         The only logic change here is that WinPort should now be
551         able to parse port_name values like MacPort (and other ports)
552         can.  The fact that ports do this in their constructors is
553         wrong and a source of many bugs.  But at least now WinPort
554         matches the status-quo.
555
556         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
557         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
558         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
559         * Scripts/webkitpy/layout_tests/port/mac.py:
560         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
561         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
562         * Scripts/webkitpy/layout_tests/port/win.py:
563         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
564
565 2011-08-16  Adam Barth  <abarth@webkit.org>
566
567         Add webkit-patch analyze-baselines, as requested by jamesr.
568
569         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
570         * Scripts/webkitpy/tool/commands/rebaseline.py:
571
572 2011-08-16  Adam Barth  <abarth@webkit.org>
573
574         Fold bulk-optimize-baselines into optimize-baselines
575         https://bugs.webkit.org/show_bug.cgi?id=66345
576
577         Reviewed by James Robinson.
578
579         bulk-optimize-baselines is now a superset of optimize-baselines, so
580         they can be combined.
581
582         * Scripts/webkitpy/tool/commands/rebaseline.py:
583
584 2011-08-16  Adam Barth  <abarth@webkit.org>
585
586         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
587         https://bugs.webkit.org/show_bug.cgi?id=66334
588
589         Reviewed by Tony Chang.
590
591         This patch moves us closer to switching the Chromium port from
592         CoreGraphics to Skia.  This patch teaches our tools that the current
593         Chromium Mac configuration is actually chromium-cg-mac, which makes
594         room for a future chromium-mac configuration that uses Skia.
595
596         Shortly after this patch lands, I'll do a server-side move of the
597         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
598         and chromium-cg-mac-leopard.
599
600         * BuildSlaveSupport/build.webkit.org-config/config.json:
601         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
602         * Scripts/webkitpy/common/config/build.py:
603         * Scripts/webkitpy/common/config/build_unittest.py:
604         * Scripts/webkitpy/layout_tests/port/base.py:
605         * Scripts/webkitpy/layout_tests/port/builders.py:
606         * Scripts/webkitpy/layout_tests/port/chromium.py:
607         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
608         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
609         * Scripts/webkitpy/layout_tests/port/dryrun.py:
610         * Scripts/webkitpy/layout_tests/port/factory.py:
611         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
612         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
613         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
614         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
615         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
616         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
617         * TestResultServer/static-dashboards/flakiness_dashboard.html:
618
619 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
620
621         garden-o-matic frontend needs a friendly relative time description method.
622         https://bugs.webkit.org/show_bug.cgi?id=66324
623
624         Reviewed by Adam Barth.
625
626         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
627         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
628         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
629
630 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
631
632         Summary view should not add multiple entries for the same test failure.
633         https://bugs.webkit.org/show_bug.cgi?id=66318
634
635         Reviewed by Adam Barth.
636
637         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
638         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
639             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
640         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
641
642 2011-08-16  Adam Roben  <aroben@apple.com>
643
644         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
645
646         The basic strategy here is that once a test has failed or passed many times in a row we
647         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
648         in many fewer false positives than our current behavior.
649
650         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
651         flaky, including tests that failed for a while but then were fixed
652
653         Reviewed by Dan Bates.
654
655         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
656         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
657         number of non-too-many-failure builds we've seen.
658         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
659         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
660         tests, keep track of how many times they have passed or failed in a row. If they pass or
661         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
662         considered flaky it doesn't matter how many times it passes or fails.)
663
664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
665         Added tests for the above.
666
667 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
668
669         garden-o-matic needs a summary view with actions for each problem.
670         https://bugs.webkit.org/show_bug.cgi?id=66144
671
672         Reviewed by Adam Barth.
673
674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
678         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
680
681 2011-08-16  Dean Jackson  <dino@apple.com>
682
683         Adding Ted "hober" O'Connor as a non-committing contributor.
684
685         * Scripts/webkitpy/common/config/committers.py:
686
687 2011-08-16  Adam Roben  <aroben@apple.com>
688
689         Teach TestFailures how to interpret unfinished test runs
690
691         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
692         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
693
694         Reviewed by David Kilzer.
695
696         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
697         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
698         rather than "isStarted" so that we don't count builds for which the test run never finished.
699         Bumped the cache version to evict old, buggy cached data.
700
701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
702         Added a test for the above, and made a somewhat synthetic test more realistic by including
703         more of the actual JSON data from build.webkit.org.
704
705         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
706         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
707         cached data.
708
709 2011-08-16  Adam Roben  <aroben@apple.com>
710
711         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
712
713         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
714         should match Lion's behavior.
715
716         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
717         but doesn't use Lion results
718
719         Reviewed by David Kilzer.
720
721         * Scripts/old-run-webkit-tests:
722         (expectedDirectoryForTest):
723         * Scripts/webkitpy/layout_tests/port/win.py:
724         (WinPort.baseline_search_path):
725         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
726         (WinPortTest.test_baseline_search_path):
727         Replaced mac-snowleopard with mac-lion.
728
729         * Scripts/webkitpy/common/config/build.py:
730         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
731         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
732         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
733         will no longer look there for results.
734
735         * Scripts/webkitpy/common/config/build_unittest.py:
736         (ShouldBuildTest.test_should_build): Tests for the above changes.
737
738 2011-08-16  Dean Jackson  <dino@apple.com>
739
740         Move me from contributor to reviewer.
741
742         * Scripts/webkitpy/common/config/committers.py:
743
744 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
745
746         garden-o-matic frontend needs model.commitDataForRevisionRange function.
747         https://bugs.webkit.org/show_bug.cgi?id=66252
748
749         Reviewed by Adam Barth.
750
751         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
752         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
753
754 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
755
756         garden-o-matic frontend needs a generic way to track updates.
757         https://bugs.webkit.org/show_bug.cgi?id=66245
758
759         Reviewed by Adam Barth.
760
761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
762         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
763
764 2011-08-15  Adam Roben  <aroben@apple.com>
765
766         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
767
768         Failures now give output of the form: foo should be bar but is baz
769
770         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
771         test is in TestWebKitAPI's output
772
773         Reviewed by David Levin.
774
775         * TestWebKitAPI/JavaScriptTest.cpp:
776         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
777         members.
778         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
779         object, rather than doing any testing of it here.
780         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
781         to use a pretty error message when the test fails.
782
783         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
784         gtest-style macros that wrap it.
785
786         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
787
788         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
789         (TestWebKitAPI::TEST): Changed to use the new macros.
790
791         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
792         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
793         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
794         the test passes, though. Returning early seems to have been an unnecessary optimization.
795
796         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
797         (TestWebKitAPI::TEST): Changed to use the new macros.
798
799 2011-08-15  Eric Seidel  <eric@webkit.org>
800
801         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
802
803         Unreviewed.
804
805         * Scripts/run-webkit-tests:
806         (usingLeaks):
807         (useNewRunWebKitTests):
808
809 2011-08-14  Adam Barth  <abarth@webkit.org>
810
811         Switch results detail view over to new-style object-oriented UI widgets
812         https://bugs.webkit.org/show_bug.cgi?id=66200
813
814         Reviewed by Dimitri Glazkov.
815
816         This patch replaces my goofy template-based UI for the results
817         comparison screen with new object-oriented UI widgets.
818
819         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
820         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
821         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
822         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
823         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
824         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
825         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
826
827 2011-08-13  Dimitri Glazkov  <dglazkov@chromium.org>
828
829         garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
830         https://bugs.webkit.org/show_bug.cgi?id=66166
831
832         Also changed base.RequestTracker to:
833         a) fire callback immediately if requestsInFlight is 0;
834         b) not barf if callback is not supplied.
835
836         Reviewed by Adam Barth.
837
838         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
841         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
842
843 2011-08-12  Mark Rowe  <mrowe@apple.com>
844
845         Be more forward-looking in the choice of compiler.
846
847         Rubber-stamped by Jon Honeycutt.
848
849         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
850         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
851         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
852         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
853
854 2011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
855
856         DRT: Add support for gesture events.
857         https://bugs.webkit.org/show_bug.cgi?id=66105
858
859         Reviewed by Darin Fisher.
860
861         * DumpRenderTree/chromium/EventSender.cpp:
862         (EventSender::EventSender):
863         (EventSender::gestureScrollBegin):
864         (EventSender::gestureScrollEnd):
865         (EventSender::gestureTap):
866         (EventSender::gestureEvent):
867         * DumpRenderTree/chromium/EventSender.h:
868
869 2011-08-12  Andy Estes  <aestes@apple.com>
870
871         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
872         https://bugs.webkit.org/show_bug.cgi?id=66158
873
874         Reviewed by Dan Bernstein.
875
876         * DumpRenderTree/LayoutTestController.cpp:
877         (allowRoundingHacksCallback): The third argument is the 'this'
878         JSObjectRef, not the second.
879
880 2011-08-12  Andy Estes  <aestes@apple.com>
881
882         Cancel in onbeforeunload dialog sometime causes a button to stop working.
883         https://bugs.webkit.org/show_bug.cgi?id=26211
884
885         Reviewed by Alexey Proskuryakov.
886
887         Implement a new LayoutTestController method that a test can call to set
888         the return value of DumpRenderTree's beforeunload UI delegate.
889
890         * DumpRenderTree/LayoutTestController.cpp:
891         (LayoutTestController::LayoutTestController): Initialize
892         m_shouldStayOnPageAfterHandlingBeforeUnload.
893         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
894         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
895         (LayoutTestController::staticFunctions): Register
896         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
897         * DumpRenderTree/LayoutTestController.h: 
898         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
899         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
900         * DumpRenderTree/chromium/LayoutTestController.cpp:
901         (LayoutTestController::LayoutTestController): Initialize
902         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
903         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
904         (LayoutTestController::reset): Reset
905         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
906         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
907         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
908         from JavaScript.
909         * DumpRenderTree/chromium/LayoutTestController.h:
910         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
911         * DumpRenderTree/chromium/WebViewHost.cpp:
912         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
913         return the inverse of
914         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
915         * DumpRenderTree/mac/UIDelegate.mm:
916         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
917         * DumpRenderTree/win/UIDelegate.cpp:
918         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
919         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
920         Define setShouldStayOnPageAfterHandlingBeforeUnload().
921         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
922         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
923         to the Test Controller telling it what value it should return in its
924         onbeforeunload UI delegate.
925         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
926         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
927         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
928         Call InjectedBundle::postNewBeforeUnloadReturnValue().
929         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
930         * WebKitTestRunner/TestController.cpp:
931         (WTR::TestController::TestController): Initialize
932         m_beforeUnloadReturnValue to true.
933         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
934         the value of TestController::beforeUnloadReturnValue().
935         (WTR::TestController::resetStateToConsistentValues): Reset
936         m_beforeUnloadReturnValue to true.
937         * WebKitTestRunner/TestController.h:
938         (WTR::TestController::beforeUnloadReturnValue):
939         (WTR::TestController::setBeforeUnloadReturnValue):
940         * WebKitTestRunner/TestInvocation.cpp:
941         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
942         message posted from the injected bundle by retrieving the message body
943         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
944
945 2011-08-12  Sam Weinig  <sam@webkit.org>
946
947         Move compiler specific macros to their own header
948         https://bugs.webkit.org/show_bug.cgi?id=66119
949
950         Reviewed by Anders Carlsson.
951
952         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
953
954 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
955
956         Add a way to extend DOM objects in garden-o-matic.
957         https://bugs.webkit.org/show_bug.cgi?id=66096
958
959         Reviewed by Adam Barth.
960
961         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
963
964 2011-08-11  MORITA Hajime  <morrita@google.com>
965
966         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
967         https://bugs.webkit.org/show_bug.cgi?id=45438
968
969         Reviewed by Kent Tamura.
970
971         MockSpellCheck was assuming the input of spellCheckWord() is a word.
972         But it can be a series of word. This change made spellCheckWord()
973         understand simple word boundary which appears in tests.
974         
975         * DumpRenderTree/chromium/MockSpellCheck.cpp:
976         (MockSpellCheck::spellCheckWord):
977
978 2011-08-11  Mark Rowe  <mrowe@apple.com>
979
980         Rework some Makefile logic to remove a double-negative.
981
982         Reviewed by Jon Honeycutt.
983
984         * DumpRenderTree/mac/PerlSupport/Makefile:
985
986 2011-08-11  Anders Carlsson  <andersca@apple.com>
987
988         Add a FIXME.
989
990         * TestWebKitAPI/TestsController.cpp:
991         (TestWebKitAPI::TestsController::TestsController):
992
993 2011-08-11  Anders Carlsson  <andersca@apple.com>
994
995         Initialize threading before running any tests
996         https://bugs.webkit.org/show_bug.cgi?id=66112
997
998         Reviewed by Adam Barth.
999
1000         * TestWebKitAPI/TestsController.cpp:
1001         (TestWebKitAPI::TestsController::TestsController):
1002
1003 2011-08-11  Adam Barth  <abarth@webkit.org>
1004
1005         Add unexpected-passes.html to TestFailures for marking tests as passing
1006         https://bugs.webkit.org/show_bug.cgi?id=66102
1007
1008         Reviewed by Dimitri Glazkov.
1009
1010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1012             - Move some code into the library so it can be shared.
1013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1014         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
1016             - Add round-trip unit tests.
1017         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
1018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
1019             - I'm not entirely sure this feature should remain a separate HTML
1020               file, but it seemed better than cluttering up the main HTML file
1021               with too much extra stuff.
1022         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1023         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1024             - The gardening server couldn't handle adding PASS expectations.  Now it can.
1025
1026 2011-08-11  Eric Seidel  <eric@webkit.org>
1027
1028         NRWT has wrong fallback order for Mac now that Lion exists
1029         https://bugs.webkit.org/show_bug.cgi?id=66093
1030
1031         Reviewed by Adam Barth.
1032
1033         ORWT used a different system for fallback orders than NRWT did.
1034         I moved win.py to match ORWT fallback orders in bug 64486.
1035         This bug moves mac.py to match ORWT fallback order
1036         and adds 'lion' as a supported OS version.
1037
1038         Because ChromiumMac shares OS version detection code with AppleMac
1039         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
1040
1041         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1042         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1043         * Scripts/webkitpy/layout_tests/port/mac.py:
1044         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1045         * Scripts/webkitpy/layout_tests/port/win.py:
1046
1047 2011-08-11  Adam Barth  <abarth@webkit.org>
1048
1049         Update test results now that we use absolute URLs.
1050
1051         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
1052
1053 2011-08-11  Adam Barth  <abarth@webkit.org>
1054
1055         garden-o-matic should be able to determine when tests unexpectedly pass
1056         https://bugs.webkit.org/show_bug.cgi?id=66092
1057
1058         Reviewed by Dimitri Glazkov.
1059
1060         This patch just contains the library methods for extracting this
1061         information.  I'll add some UI in a subsequent patch.
1062
1063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
1064         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
1065
1066 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1067
1068         New expectation entries should be placed next to existing ones.
1069         https://bugs.webkit.org/show_bug.cgi?id=66066
1070
1071         Reviewed by Adam Barth.
1072
1073         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
1074             which is computed as the last found reference to the same test.
1075         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
1076
1077 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1078
1079         Unreviewed, rolling out r92847.
1080         http://trac.webkit.org/changeset/92847
1081         https://bugs.webkit.org/show_bug.cgi?id=65986
1082
1083         Broke check-webkit-style
1084
1085         * Scripts/webkitpy/style/checker.py:
1086         * Scripts/webkitpy/style/checker_unittest.py:
1087
1088 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1089
1090         Unreviewed, rolling out r92847.
1091         http://trac.webkit.org/changeset/92847
1092         https://bugs.webkit.org/show_bug.cgi?id=65986
1093
1094         Broke check-webkit-style
1095
1096         * Scripts/webkitpy/style/checker.py:
1097         * Scripts/webkitpy/style/checker_unittest.py:
1098
1099 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
1100
1101         [Qt] autotests shouldn't require config.h in the style check
1102         https://bugs.webkit.org/show_bug.cgi?id=65986
1103
1104         Remove the include rules from the style-check for Qt tests.
1105         Since for the most part it's just a matter of using the
1106         API provided by QtWebKit, enforcing the WebCore set of rules
1107         only seems to make sense in the case of MIMESniffing.
1108
1109         Reviewed by Benjamin Poulain.
1110
1111         * Scripts/webkitpy/style/checker.py:
1112         * Scripts/webkitpy/style/checker_unittest.py:
1113
1114 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
1115
1116         [WK2] Implement waitForPolicyDelegate
1117         https://bugs.webkit.org/show_bug.cgi?id=42330
1118
1119         Reviewed by Csaba Osztrogonác.
1120
1121         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1122         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1123         (WTR::navigationTypeToString):
1124         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1125         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1126         (WTR::LayoutTestController::LayoutTestController):
1127         (WTR::LayoutTestController::setCustomPolicyDelegate):
1128         (WTR::LayoutTestController::waitForPolicyDelegate):
1129         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1130         (WTR::LayoutTestController::isPolicyDelegateEnabled):
1131         (WTR::LayoutTestController::isPolicyDelegatePermissive):
1132
1133 2011-08-11  Adam Barth  <abarth@webkit.org>
1134
1135         rebaseline-expectations should use the release bots, not the debug
1136         bots.  The debug bots don't all run all the tests.  Also, delay
1137         updating test_expectations a long as possible to avoid clearing out
1138         lines that we'll need for other ports.
1139
1140         * Scripts/webkitpy/layout_tests/port/builders.py:
1141         * Scripts/webkitpy/tool/commands/rebaseline.py:
1142         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1143
1144 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
1145
1146         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
1147         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
1148
1149         * BuildSlaveSupport/build.webkit.org-config/config.json:
1150
1151 2011-08-10  Eric Seidel  <eric@webkit.org>
1152
1153         new-run-webkit-test's WinPort has no fallback logic
1154         https://bugs.webkit.org/show_bug.cgi?id=64486
1155
1156         Unreviewed.
1157
1158         Turns out that we've long had a subtle bug whereby if you didn't
1159         already have DumpRenderTree built, we might end up running unsupported tests
1160         because the DumpRenderTree --print-supported-features check would silently fail.
1161
1162         When I moved the call from using popen to using Executive.run_command, this silent
1163         failure became noisy.  (Breaking some bots.)
1164
1165         This re-orders our steps so that we always build DRT before collecting expectations,
1166         as well as adds a warning message when DumpRenderTree can't be found.
1167
1168         * Scripts/webkitpy/layout_tests/port/webkit.py:
1169         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1170
1171 2011-08-10  Eric Seidel  <eric@webkit.org>
1172
1173         new-run-webkit-test's WinPort has no fallback logic
1174         https://bugs.webkit.org/show_bug.cgi?id=64486
1175
1176         Unreviewed.  Fix test-webkitpy under Python 2.5.
1177
1178         * Scripts/webkitpy/layout_tests/port/win.py:
1179
1180 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
1181
1182         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
1183         https://bugs.webkit.org/show_bug.cgi?id=65875
1184
1185         Reviewed by Kenneth Rohde Christiansen.
1186
1187         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
1188
1189         This causes mouse events to be sent twice in some cases. We work around the problem
1190         by defining the first touch point to be a primary touch point (case which hit some
1191         weird condition in QWidget, skipping the generation of fake mouse events).
1192
1193         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1194         (MiniBrowserApplication::notify):
1195
1196 2011-08-10  David Hyatt  <hyatt@apple.com>
1197
1198         https://bugs.webkit.org/show_bug.cgi?id=66004
1199
1200         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
1201         the code on by default.
1202
1203         Reviewed by Adam Roben.
1204
1205         * BuildSlaveSupport/build.webkit.org-config/config.json:
1206         * Scripts/build-webkit:
1207
1208 2011-08-10  Oliver Hunt  <oliver@apple.com>
1209
1210         JSEvaluteScript does not return the correct object when given JSONP data
1211         https://bugs.webkit.org/show_bug.cgi?id=66003
1212
1213         Reviewed by Gavin Barraclough.
1214
1215         Add a test case.
1216
1217         * DumpRenderTree/mac/DumpRenderTree.mm:
1218         (testStringByEvaluatingJavaScriptFromString):
1219
1220 2011-08-10  Eric Seidel  <eric@webkit.org>
1221
1222         WIN: NRWT runs compositing tests on configurations that don't support compositing
1223         https://bugs.webkit.org/show_bug.cgi?id=64472
1224
1225         Reviewed by Adam Barth.
1226
1227         I think the code was just wrong.  It was never splitting the string
1228         into list pieces before.
1229         I've now tested the supported_features code and theoretically it
1230         should now work with Windows DRT.
1231
1232         I also made the list-lookup functions always return lists, to make
1233         it possible to clean up the list-transform code in the future
1234         (I opted not to do that cleanup in this patch, but at least now
1235         both types of feature lookup functions match return types.)
1236
1237         * Scripts/webkitpy/layout_tests/port/webkit.py:
1238         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1239
1240 2011-08-10  Eric Seidel  <eric@webkit.org>
1241
1242         Clean up ChromiumDriver a little
1243         https://bugs.webkit.org/show_bug.cgi?id=65995
1244
1245         Unreviewed.
1246
1247         Fix NRWT for chromium.  Silly python.
1248
1249         * Scripts/webkitpy/layout_tests/port/chromium.py:
1250
1251 2011-08-10  Eric Seidel  <eric@webkit.org>
1252
1253         Clean up ChromiumDriver a little
1254         https://bugs.webkit.org/show_bug.cgi?id=65995
1255
1256         Reviewed by Adam Barth.
1257
1258         - We no longer support threading, so remove threading specific code.
1259         - Add FIXMEs about using ServerProcess instead.
1260         - Condense option-mapping if-cascade into a for loop.
1261         - Unindent long if blocks by using early return.
1262         - Unwrap lines which are needlessly wrapped.
1263
1264         There should be no functional changes here, just code cleanup/dead-code removal.
1265
1266         * Scripts/webkitpy/layout_tests/port/chromium.py:
1267
1268 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
1269
1270         Unmuddle construction options for TestConfiguration.
1271         https://bugs.webkit.org/show_bug.cgi?id=65988
1272
1273         The TestConfiguration instance is now constructed only using actual values.
1274         Port-based construction is split into a "from_port" class method.
1275
1276         Reviewed by Eric Seidel.
1277
1278         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
1279         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
1280         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
1281         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
1282         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
1283
1284 2011-08-10  Eric Seidel  <eric@webkit.org>
1285
1286         Leaks bot shows python logging prefixes as part of summary display
1287         https://bugs.webkit.org/show_bug.cgi?id=65931
1288
1289         Reviewed by Adam Barth.
1290
1291         The big part of this change is adding a unittesting system for
1292         master.cfg, so mere-mortals can make changes to build.webkit.org
1293         with greatly-reduced risk of breaking the world.
1294
1295         Turns out that in typing up my trival logging fix I made 2 typos,
1296         so hopefully the hour spent getting master.cfg to load was worth it. :)
1297
1298         I also tried to make mastercfg_unittest run as part of test-webkitpy
1299         but right now test-webkitpy requires that unittest files be located in
1300         a module-name-compatible directory.  'build.webkit.org-config' is not
1301         a valid module name.
1302
1303         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1304          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
1305            by using a new _strip_python_logging_prefix function.
1306          - Also fixed this function to file to work with a more modern
1307            simplejson version (which returns unicode objects instead of str objects)
1308            and filed a related bug with buildbot.net due to their handling of unicode builder names.
1309         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
1310          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
1311          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
1312         * Scripts/webkitpy/thirdparty/__init__.py:
1313          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
1314
1315 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
1316
1317         garden-o-matic should extrapolate failures given a set of known results
1318         https://bugs.webkit.org/show_bug.cgi?id=65882
1319
1320         Reviewed by Adam Barth.
1321
1322         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
1323         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
1324             adjusted all call sites.
1325         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
1326             makes wider net for specific failures.
1327         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
1328
1329 2011-08-10  Adam Barth  <abarth@webkit.org>
1330
1331         The URL we were computing for retrieving baselines was missing a slash
1332         character because our mocks had an extra slash character.  I've
1333         corrected both the code and the mock.
1334
1335         * Scripts/webkitpy/tool/commands/rebaseline.py:
1336         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1337         * Scripts/webkitpy/tool/mocktool.py:
1338
1339 2011-08-09  Adam Barth  <abarth@webkit.org>
1340
1341         Move the quote mark to the right place.
1342
1343         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1344
1345 2011-08-09  Adam Barth  <abarth@webkit.org>
1346
1347         garden-o-matic should use huerstics to narrow regression range
1348         https://bugs.webkit.org/show_bug.cgi?id=65948
1349
1350         Reviewed by Dimitri Glazkov.
1351
1352         When analyzing a regression range, if one of the commit messages
1353         mentions the test in question, we now hueristically assume that
1354         revision caused the failure.  (I'm shamelessly stealing this idea from
1355         TestFailures.)
1356
1357         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1358
1359 2011-07-13  Eric Seidel  <eric@webkit.org>
1360
1361         new-run-webkit-test's WinPort has no fallback logic
1362         https://bugs.webkit.org/show_bug.cgi?id=64486
1363
1364         Reviewed by Adam Roben.
1365
1366         I've tried to write a patch for bug 64439 twice now, and both times
1367         I've ended up re-writing half the port system.  So I'm breaking
1368         things up into smaller pieces, this being the first.
1369
1370         WinPort still does not have any port_name parsing, so when instantiated
1371         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
1372         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
1373
1374         Otherwise this should "just work" for windows.  I've not been able to test the
1375         version detection on my mac, but the unit tests show the code behaving as designed.
1376
1377         * Scripts/webkitpy/layout_tests/port/win.py:
1378         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
1379
1380 2011-08-09  Adam Barth  <abarth@webkit.org>
1381
1382         Teach build.webkit.org's garden-o-matic how to talk to the local server
1383         https://bugs.webkit.org/show_bug.cgi?id=65940
1384
1385         Reviewed by Dimitri Glazkov.
1386
1387         After this patch, the version of garden-o-matic on build.webkit.org is
1388         fully functional.  It can interact with the local server via CORS.
1389
1390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
1392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1393         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1394         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1395
1396 2011-08-09  Adam Barth  <abarth@webkit.org>
1397
1398         Enable CORS for garden-o-matic
1399         https://bugs.webkit.org/show_bug.cgi?id=65936
1400
1401         Reviewed by Dimitri Glazkov.
1402
1403         This patch will allow the hosted instance of garden-o-matic to
1404         communicate with the local server.
1405
1406         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1407         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1408
1409 2011-08-09  Adam Barth  <abarth@webkit.org>
1410
1411         Upgrade jquery in TestFailures
1412         https://bugs.webkit.org/show_bug.cgi?id=65935
1413
1414         Reviewed by Dimitri Glazkov.
1415
1416         Upgrade to a newer version of jQuery with better support for CORS and CSP.
1417
1418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
1420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1421
1422 2011-08-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1423
1424         Unreviewed, rolling out r92683.
1425         http://trac.webkit.org/changeset/92683
1426         https://bugs.webkit.org/show_bug.cgi?id=65921
1427
1428          "Breaks Qt --minimal build. Revert pending update of the Qt
1429         minimal configuration" (Requested by simathur on #webkit).
1430
1431         * QtTestBrowser/cookiejar.cpp:
1432         (TestBrowserCookieJar::TestBrowserCookieJar):
1433         * QtTestBrowser/launcherwindow.cpp:
1434         (LauncherWindow::createChrome):
1435         (LauncherWindow::setDiskCache):
1436         * QtTestBrowser/main.cpp:
1437         (LauncherApplication::handleUserOptions):
1438         * QtTestBrowser/webpage.cpp:
1439         (WebPage::openUrlInDefaultBrowser):
1440
1441 2011-08-09  Siddharth Mathur  <siddharth.mathur@nokia.com>
1442
1443         [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
1444         https://bugs.webkit.org/show_bug.cgi?id=65880
1445
1446         Reviewed by Andreas Kling.
1447
1448         QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
1449         check for their feature flags. Assume that any reasonable Qt build provides them. 
1450         * QtTestBrowser/cookiejar.cpp:
1451         (TestBrowserCookieJar::TestBrowserCookieJar):
1452         * QtTestBrowser/launcherwindow.cpp:
1453         (LauncherWindow::createChrome):
1454         (LauncherWindow::setDiskCache):
1455         * QtTestBrowser/main.cpp:
1456         (LauncherApplication::handleUserOptions):
1457         * QtTestBrowser/webpage.cpp:
1458         (WebPage::openUrlInDefaultBrowser):
1459
1460 2011-08-09  Adam Barth  <abarth@webkit.org>
1461
1462         BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
1463         https://bugs.webkit.org/show_bug.cgi?id=65891
1464
1465         Reviewed by Eric Seidel.
1466
1467         The problem was that platform/chromium contained a bogus expectation
1468         file that needed to be removed, but by the time we got around to
1469         removing it, we'd already moved the correct baseline into its place.
1470         After this patch, we copy the gold results into memory before
1471         reshuffling things on disk (and we delete bad things before adding good
1472         things).
1473
1474         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1475         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1476
1477 2011-08-08  Adam Barth  <abarth@webkit.org>
1478
1479         Chromium Windows bots can't figure out what SVN revision they're running
1480         https://bugs.webkit.org/show_bug.cgi?id=65893
1481
1482         Reviewed by Eric Seidel.
1483
1484         The comment in _engage_awesome_windows_hacks explains why we're making
1485         this change.  It's ugly and rediculous, but this approach seems better
1486         than using shell=True when calling popen.
1487
1488         * Scripts/webkitpy/common/checkout/scm/svn.py:
1489         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1490
1491 2011-08-08  Adam Barth  <abarth@webkit.org>
1492
1493         Remove deduplicate-tests
1494         https://bugs.webkit.org/show_bug.cgi?id=65886
1495
1496         Reviewed by Tony Chang.
1497
1498         This script is redundant with "webkit-patch bulk-optimize-baselines",
1499         which can find many more duplicates than deduplicate-tests because
1500         bulk-optimize-baselines can move results around whereas
1501         deduplicate-tests can only remove results.
1502
1503         * Scripts/deduplicate-tests: Removed.
1504         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
1505         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
1506
1507 2011-08-08  Adam Barth  <abarth@webkit.org>
1508
1509         scm.delete should delete empty parent directories as well
1510         https://bugs.webkit.org/show_bug.cgi?id=65878
1511
1512         Reviewed by Eric Seidel.
1513
1514         This behavior makes SVN match GIT (which has no concept of empty
1515         directories).  This bug comes up a lot when optimizing baselines, which
1516         often create empty directories when we're able to optimize everything
1517         out of a given folder.
1518
1519         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1520         * Scripts/webkitpy/common/checkout/scm/svn.py:
1521
1522 2011-08-08  Lucas Forschler  <lforschler@apple.com>
1523
1524         Add triggers for Lion WK2 test bots.
1525
1526         Reviewed by Stephanie Lewis.
1527
1528         * BuildSlaveSupport/build.webkit.org-config/config.json:
1529
1530 2011-08-08  Adam Barth  <abarth@webkit.org>
1531
1532         bulk-optimize-baselines should take directories on the command line
1533         https://bugs.webkit.org/show_bug.cgi?id=65879
1534
1535         Reviewed by Dimitri Glazkov.
1536
1537         Passing lists of tests via stdin is a pain.  It's easier if the command
1538         takes a list of tests on the command line, like run-webkit-tests.
1539
1540         * Scripts/webkitpy/tool/commands/rebaseline.py:
1541
1542 2011-08-08  Adam Barth  <abarth@webkit.org>
1543
1544         Deprecate rebaseline-chromium-webkit-tests
1545         https://bugs.webkit.org/show_bug.cgi?id=65873
1546
1547         Reviewed by Dimitri Glazkov.
1548
1549         This script never worked correctly and now is redundant with more
1550         modern infrastructure for rebaselining tests.  This patch deprecates
1551         the script in order to flush out any issues with the new tools.  Once
1552         folks are happy with the new tools, we'll delete this script.
1553
1554         * Scripts/rebaseline-chromium-webkit-tests:
1555
1556 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
1557
1558         garden-o-matic should only touch expectations that need updating.
1559         https://bugs.webkit.org/show_bug.cgi?id=65876
1560
1561         Reviewed by Adam Barth.
1562
1563         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,
1564             so that a caller could influence which lines to serialize from values.
1565         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
1566         * Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
1567         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
1568
1569 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
1570
1571         TestExpectationsEditor should return a list of updated expectations.
1572         https://bugs.webkit.org/show_bug.cgi?id=65872
1573
1574         Reviewed by Adam Barth.
1575
1576         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
1577         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
1578
1579 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
1580
1581         Fix SCM webkitpy unit test failures
1582         https://bugs.webkit.org/show_bug.cgi?id=65823
1583
1584         Reviewed by Eric Seidel.
1585
1586         * Scripts/webkitpy/common/checkout/scm/git.py:
1587         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1588
1589 2011-08-08  Eric Seidel  <eric@webkit.org>
1590
1591         Move the --leaks bot back over to NRWT now that I'm back
1592         from vacation and able to debug it.
1593
1594         Unreviewed.
1595
1596         * Scripts/run-webkit-tests:
1597         (usingWebKit2):
1598         (useNewRunWebKitTests):
1599
1600 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
1601
1602         Wire up updating expectations in garden-o-matic.
1603         https://bugs.webkit.org/show_bug.cgi?id=65794
1604
1605         Reviewed by Adam Barth.
1606
1607         * Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
1608         * Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
1609         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
1610         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
1611
1612 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
1613
1614         webkit-patch doesn't get along with renamed files
1615         https://bugs.webkit.org/show_bug.cgi?id=48075
1616
1617         Possibly a bit heavy handed - I removed all instances of -C and
1618         changed every instance of -M with '--no-renames' in git.py. This
1619         forces git to not try to tell us about renames at all, which is
1620         ultimately the behaviour we want. The old file is shown deleted,
1621         then the new file is shown added, followed by any changes that
1622         occurred. Also gets rid of the problem where deleting one file
1623         and adding another file which has similar content would
1624         unexpectedly show up as a rename, and fall out of a diff.
1625
1626         Based on a patch by Wyatt Carss.
1627
1628         Reviewed by Eric Seidel.
1629
1630         * Scripts/webkitpy/common/checkout/scm/git.py:
1631
1632 2011-08-07  Sam White  <samuel.white@rochester.edu>
1633
1634         Add the ability to search the AccessibilityObject cache
1635         https://bugs.webkit.org/show_bug.cgi?id=64994
1636         
1637         Added testing support for AccessibilityObject cache searching. Currently,
1638         only the mac platform is full supported and has had API exposed. Other
1639         platforms have only have this new functionality stubbed. Full implementation
1640         is a job suited only for an accessibility expert of each respective platform.
1641
1642         Reviewed by Chris Fleizach.
1643
1644         * DumpRenderTree/AccessibilityUIElement.cpp:
1645         (uiElementForSearchPredicateCallback):
1646         (AccessibilityUIElement::getJSClass):
1647         * DumpRenderTree/AccessibilityUIElement.h:
1648         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1649         (AccessibilityUIElement::uiElementForSearchPredicate):
1650         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1651         (AccessibilityUIElement::uiElementForSearchPredicate):
1652         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1653         (AccessibilityUIElement::uiElementForSearchPredicate):
1654
1655 2011-08-06  Adam Barth  <abarth@webkit.org>
1656
1657         Remove dead code in webkitpy
1658         https://bugs.webkit.org/show_bug.cgi?id=65818
1659
1660         Reviewed by Dimitri Glazkov.
1661
1662         This code was added to support the rebaseline2 command six months ago,
1663         but the rebaseline2 command was never finished and no one else has used
1664         this code since it was landed.  This patch removes the dead code.  If
1665         we revive rebaseline2, then we can revert this patch and recover the
1666         code.  Until then, this code is just dead weight.
1667
1668         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1669         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1670         * Scripts/webkitpy/common/net/testoutput.py: Removed.
1671         * Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
1672         * Scripts/webkitpy/common/net/testoutputset.py: Removed.
1673         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
1674         * Scripts/webkitpy/common/system/directoryfileset.py: Removed.
1675         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
1676         * Scripts/webkitpy/layout_tests/port/base.py:
1677         * Scripts/webkitpy/layout_tests/port/chromium.py:
1678         * Scripts/webkitpy/layout_tests/port/webkit.py:
1679
1680 2011-08-06  Adam Barth  <abarth@webkit.org>
1681
1682         webkit-patch optimize-baselines can't handle promotions to base results directory
1683         https://bugs.webkit.org/show_bug.cgi?id=65819
1684
1685         Reviewed by Dimitri Glazkov.
1686
1687         This bug came up when testing the optimizer on some editing baselines.
1688
1689         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1690         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1691
1692 2011-08-06  Adam Barth  <abarth@webkit.org>
1693
1694         Add a small command to optimize baselines in bulk.
1695
1696         * Scripts/webkitpy/tool/commands/rebaseline.py:
1697
1698 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
1699
1700         Fix unit test breakage by plumbing convert_404_to_None in MockWeb.
1701
1702         * Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
1703
1704 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
1705
1706         Garden-o-matic updateexpectations needs a unit test.
1707         https://bugs.webkit.org/show_bug.cgi?id=65780
1708
1709         Reviewed by Adam Barth.
1710
1711         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
1712
1713 2011-08-05  Anders Carlsson  <andersca@apple.com>
1714
1715         Future proof an Objective-C test
1716         https://bugs.webkit.org/show_bug.cgi?id=65788
1717
1718         Reviewed by Dan Bernstein.
1719
1720         Add isObjectInstanceOf to ObjCController.
1721
1722         * DumpRenderTree/mac/ObjCController.m:
1723         (+[ObjCController isSelectorExcludedFromWebScript:]):
1724         (+[ObjCController webScriptNameForSelector:]):
1725         (-[ObjCController isObject:instanceOf:]):
1726
1727 2011-08-05  Adam Barth  <abarth@webkit.org>
1728
1729         trac.js needs unittests
1730         https://bugs.webkit.org/show_bug.cgi?id=65673
1731
1732         Reviewed by Dimitri Glazkov.
1733
1734         This tests also have somewhat large fixtures.  I've trimmed the example
1735         XML down a bunch while still hitting interesting cases in the parsing.
1736
1737         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1738         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
1739
1740 2011-08-05  Adam Barth  <abarth@webkit.org>
1741
1742         Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
1743         https://bugs.webkit.org/show_bug.cgi?id=65759
1744
1745         Reviewed by Dimitri Glazkov.
1746
1747         rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
1748         architecture, is poorly tested, and has a bunch of quirks.  This patch
1749         rebuilds the core functionality of rebaseline-chromium-webkit-tests on
1750         top of more modern infrastructure.  In the process, we get more code
1751         re-use and better testing.
1752
1753         Once we're satisfied with this new implementation, we can delete the
1754         old implementation.
1755
1756         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1757         * Scripts/webkitpy/common/net/web.py:
1758         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1759         * Scripts/webkitpy/layout_tests/port/builders.py:
1760         * Scripts/webkitpy/layout_tests/port/chromium.py:
1761         * Scripts/webkitpy/layout_tests/port/factory.py:
1762         * Scripts/webkitpy/layout_tests/port/webkit.py:
1763         * Scripts/webkitpy/tool/commands/rebaseline.py:
1764         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1765
1766 2011-08-05  Anders Carlsson  <andersca@apple.com>
1767
1768         Remove PluginHalter
1769         https://bugs.webkit.org/show_bug.cgi?id=65729
1770
1771         Reviewed by Darin Adler.
1772
1773         Remove call to set the allowed plug-in run time.
1774
1775         * DumpRenderTree/mac/DumpRenderTree.mm:
1776         (resetDefaultsToConsistentValues):
1777
1778 2011-08-05  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1779
1780         Unreviewed build fix for Qt-Minimal buildbot
1781
1782         Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
1783         is disabled.
1784
1785         Rubber-stamped by Holger Freyther.
1786
1787         * QtTestBrowser/cookiejar.cpp:
1788         (TestBrowserCookieJar::TestBrowserCookieJar):
1789
1790 2011-08-05  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1791
1792         [Qt] QtTestBrowser: Add support for saving cookies on disk
1793         https://bugs.webkit.org/show_bug.cgi?id=65328
1794
1795         Simple cookiejar that saves cookies on disk.
1796
1797         Added menu options to clear cookies (Edit->Clear cookies) and
1798         disable disk cookies (Settings->[ ]Save Cookies on Disk).
1799
1800         Option -no-disk-cookies is also available.
1801
1802         Reviewed by Andreas Kling.
1803
1804         * QtTestBrowser/QtTestBrowser.pro:
1805         * QtTestBrowser/cookiejar.cpp: Added.
1806         * QtTestBrowser/cookiejar.h: Added.
1807         * QtTestBrowser/launcherwindow.cpp:
1808         * QtTestBrowser/launcherwindow.h:
1809         * QtTestBrowser/main.cpp:
1810
1811 2011-08-04  Adam Barth  <abarth@webkit.org>
1812
1813         model.js needs some unit testing
1814         https://bugs.webkit.org/show_bug.cgi?id=65730
1815
1816         Reviewed by Dimitri Glazkov.
1817
1818         These tests do not cover all the functions exported by the model
1819         module.  We'll need to add the remaining ones in the future.
1820
1821         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
1822         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1823
1824 2011-08-04  Adam Barth  <abarth@webkit.org>
1825
1826         Another speculative fix for the "svn revision on Windows" problem.
1827
1828         * Scripts/webkitpy/common/checkout/scm/git.py:
1829
1830 2011-08-04  Mark Rowe  <mrowe@apple.com>
1831
1832         Future-proof Xcode configuration settings.
1833
1834         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1835         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
1836         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1837         * MiniBrowser/Configurations/Base.xcconfig:
1838         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
1839         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1840         * TestWebKitAPI/Configurations/Base.xcconfig:
1841         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
1842         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1843         * WebKitTestRunner/Configurations/Base.xcconfig:
1844         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
1845         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1846
1847 2011-08-04  Adam Barth  <abarth@webkit.org>
1848
1849         Fancier debug logging.
1850
1851         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1852
1853 2011-08-04  David Levin  <levin@chromium.org>
1854
1855         [chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
1856         https://bugs.webkit.org/show_bug.cgi?id=65685
1857
1858         Reviewed by Dmitry Titov.
1859
1860         * DumpRenderTree/chromium/WebViewHost.cpp:
1861         (WebViewHost::WebViewHost): Intialize WTF threading before
1862         anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
1863         but in some cases code may use WTF without creating WebViewImpl and
1864         WTF code functionality may call WTF::currentThread, which requires
1865         this initialization now.
1866
1867 2011-08-04  Adam Barth  <abarth@webkit.org>
1868
1869         An educated guess at causing the Windows bots on build.webkit.org to
1870         find the SVN revision number.
1871
1872         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1873         * Scripts/webkitpy/layout_tests/port/base.py:
1874
1875 2011-08-04  Adam Barth  <abarth@webkit.org>
1876
1877         More logging to help debug the "no SVN rev on Chromium Windows bots"
1878         bug.  My current theory is that we're trying to detect the SCM system
1879         in the wrong directory.
1880
1881         * Scripts/webkitpy/layout_tests/port/base.py:
1882
1883 2011-08-04  Dimitri Glazkov  <dglazkov@chromium.org>
1884
1885         Speed up webkit-patch optimize-expectations significantly by not collecting test files.
1886         https://bugs.webkit.org/show_bug.cgi?id=65697
1887
1888         I neglected to realize that collecting test names is not necessary for this operation.
1889
1890         Reviewed by Adam Barth.
1891
1892         * Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
1893
1894 2011-08-04  Adam Barth  <abarth@webkit.org>
1895
1896         checkout_unittest.js should have better coverage of checkout.js
1897         https://bugs.webkit.org/show_bug.cgi?id=65671
1898
1899         Reviewed by Dimitri Glazkov.
1900
1901         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1902             - Remove unused functions.
1903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
1904             - Test remaining public functions in the checkout module.
1905
1906 2011-08-04  Dmitry Lomov  <dslomov@google.com>
1907
1908         https://bugs.webkit.org/show_bug.cgi?id=65706
1909         Run run-unit-tests on release mode test bots.
1910         Reenabling after 61812 is fixed.
1911
1912         Reviewed by Adam Roben.
1913
1914         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1915
1916 2011-08-04  Adam Barth  <abarth@webkit.org>
1917
1918         builders.js needs unit tests
1919         https://bugs.webkit.org/show_bug.cgi?id=65670
1920
1921         Reviewed by Dimitri Glazkov.
1922
1923         This test requires somewhat large test fixtures, but using real
1924         examples seemed better than trimming them down too much.
1925
1926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
1927         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
1928         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1929             - Note: trac_unittests.js doesn't exist (yet!).
1930
1931 2011-08-04  Alexis Menard  <alexis.menard@openbossa.org>
1932
1933         [Qt] Make navigation actions properly usable in QML.
1934         https://bugs.webkit.org/show_bug.cgi?id=65624
1935
1936         Fix compilation after the introduction of QWebNavigationController.
1937
1938         Reviewed by Benjamin Poulain.
1939
1940         * MiniBrowser/qt/BrowserView.cpp:
1941         (BrowserView::navigationAction):
1942
1943 2011-08-04  Adam Barth  <abarth@webkit.org>
1944
1945         Another subtle bug due to lack of testing in main.js.  :(
1946
1947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1948
1949 2011-08-04  Adam Barth  <abarth@webkit.org>
1950
1951         Fix types.  Sadly, main.js has no test coverage.  (I need to think
1952         about how to test this part of the code.)
1953
1954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1955
1956 2011-08-04  Adam Barth  <abarth@webkit.org>
1957
1958         bugzilla.js is missing unit tests
1959         https://bugs.webkit.org/show_bug.cgi?id=65656
1960
1961         Reviewed by Adam Roben.
1962
1963         Testing makes perfect.
1964
1965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added.
1966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
1967         (NetworkSimulator.prototype.runTest.get if):
1968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1969
1970 2011-08-04  Adam Barth  <abarth@webkit.org>
1971
1972         Add missing license blocks to garden-o-matic
1973         https://bugs.webkit.org/show_bug.cgi?id=65654
1974
1975         Reviewed by Dimitri Glazkov.
1976
1977         This patch is entirely boilerplate.
1978
1979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
1981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
1982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1984         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
1985         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
1986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1987         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
1988         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1990         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
1991         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
1992         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
1993         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
1994         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1996         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
1997
1998 2011-08-04  Adam Barth  <abarth@webkit.org>
1999
2000         garden-o-matic needs a way to mock out the network
2001         https://bugs.webkit.org/show_bug.cgi?id=65653
2002
2003         Reviewed by Dimitri Glazkov.
2004
2005         This patch introduces the net module, which is a useful mock point for
2006         abstracting away the network.  Future patches will use this
2007         infrastructure to test some currently untested code.
2008
2009         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
2010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
2013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2014         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
2017         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.
2018         (NetworkSimulator):
2019         (NetworkSimulator.prototype.scheduleCallback):
2020         (NetworkSimulator.prototype.runTest):
2021         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2024         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2025
2026 2011-08-03  Adam Barth  <abarth@webkit.org>
2027
2028         Use failureInfo more pervasively in garden-o-matic
2029         https://bugs.webkit.org/show_bug.cgi?id=65650
2030
2031         Reviewed by Dimitri Glazkov.
2032
2033         These three variable appears in concert together many places.  This
2034         patch unifies the remaining uses into being failureInfo objects, which
2035         saves some marshalling.
2036
2037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2038         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2039         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2042
2043 2011-08-03  Adam Barth  <abarth@webkit.org>
2044
2045         garden-o-matic should be able to update expecations from the details pane
2046         https://bugs.webkit.org/show_bug.cgi?id=65648
2047
2048         Reviewed by Dimitri Glazkov.
2049
2050         The new button queues up the updates, which get executed all at once.
2051
2052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2053         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2054         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2055
2056 2011-08-03  Adam Barth  <abarth@webkit.org>
2057
2058         Add UI to garden-o-matic for updating expectations
2059         https://bugs.webkit.org/show_bug.cgi?id=65644
2060
2061         Reviewed by Dimitri Glazkov.
2062
2063         The patch plumbs the UI back to the gardening server, but the gardening
2064         server endpoint is just a stub at this point.
2065
2066         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2067         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2069         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2070         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2071         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2072
2073 2011-08-03  Adam Barth  <abarth@webkit.org>
2074
2075         garden-o-matic details view should queue rebaselines for later execution
2076         https://bugs.webkit.org/show_bug.cgi?id=65636
2077
2078         Reviewed by Dimitri Glazkov.
2079
2080         This patch doesn't contain any confirmation UI, but we'll probably want
2081         that at some point.
2082
2083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2087
2088 2011-08-03  Kentaro Hara  <haraken@google.com>
2089
2090         Implement EventSender.scalePageBy()
2091         https://bugs.webkit.org/show_bug.cgi?id=58013
2092
2093         Reviewed by Darin Fisher.
2094
2095         Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
2096         and then sets a scroll position to (x, y). Enabled the tests that had been waiting
2097         for the implementation of EventSender.scalePageBy(f, x, y).
2098
2099         Tests: compositing/scaling/tiled-layer-recursion.html
2100                fast/repaint/scale-page-shrink.html
2101                fast/dom/Element/scale-page-client-rects.html
2102                fast/dom/Range/scale-page-client-rects.html
2103                fast/events/scroll-in-scaled-page-with-overflow-hidden.html
2104                fast/dom/Element/scale-page-bounding-client-rect.html
2105                fast/dom/Range/scale-page-bounding-client-rect.html
2106
2107         * DumpRenderTree/chromium/EventSender.cpp:
2108         (EventSender::EventSender): Added bindings for scalePageBy().
2109         (EventSender::scalePageBy): A wrapper method for scalePage() in WebView.
2110         * DumpRenderTree/chromium/EventSender.h:
2111         * DumpRenderTree/chromium/TestShell.cpp:
2112         (TestShell::resetTestController): Resets the scale factor to 1.
2113
2114 2011-08-03  David Levin  <levin@chromium.org>
2115
2116         Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
2117         https://bugs.webkit.org/show_bug.cgi?id=65652
2118
2119         Reviewed by Adam Barth.
2120
2121         * Scripts/webkitpy/style/checkers/cpp.py:
2122         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2123
2124 2011-08-03  Filip Pizlo  <fpizlo@apple.com>
2125
2126         Adding Filip Pizlo to committer list.
2127
2128         Unreviewed.
2129
2130         * Scripts/webkitpy/common/config/committers.py:
2131
2132 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
2133
2134         Add "optimize-expectations" command to webkit-patch.
2135         https://bugs.webkit.org/show_bug.cgi?id=65633
2136
2137         For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.
2138
2139         Reviewed by Adam Barth.
2140
2141         * Scripts/webkitpy/tool/commands/__init__.py: Added command.
2142         * Scripts/webkitpy/tool/commands/expectations.py: Added.
2143
2144 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
2145
2146         Allow multiple bug identifiers in test expectations.
2147         https://bugs.webkit.org/show_bug.cgi?id=65642
2148
2149         Reviewed by Adam Barth.
2150
2151         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
2152         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
2153
2154 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
2155
2156         Teach BuilderToPort to distinguish between Release and Debug builders.
2157         https://bugs.webkit.org/show_bug.cgi?id=65628
2158
2159         Reviewed by Adam Barth.
2160
2161         * Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
2162         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.
2163
2164 2011-08-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2165
2166         [Qt] Fix running qmltests for WK2 in the bot
2167         https://bugs.webkit.org/show_bug.cgi?id=65621
2168
2169         Reviewed by Csaba Osztrogonác.
2170
2171         The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
2172         but now there's the case for WK2 UIProcess tests as well.
2173
2174         * Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.
2175
2176 2011-08-02  Dimitri Glazkov  <dglazkov@chromium.org>
2177
2178         Add a way to edit test expectations.
2179         https://bugs.webkit.org/show_bug.cgi?id=64922
2180
2181         Implements a TestExpectationsEditor, which provides a standard way to
2182         update and remove test expectations.
2183
2184         Reviewed by Adam Barth.
2185
2186         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,
2187             added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
2188             enchilada.
2189         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.
2190
2191 2011-08-03  Andreas Kling  <kling@webkit.org>
2192
2193         [Qt] MiniBrowser: Unbreak load progress indication.
2194         https://bugs.webkit.org/show_bug.cgi?id=65614
2195
2196         Reviewed by Kenneth Rohde Christiansen.
2197
2198         loadProgress() was renamed to loadProgressChanged().
2199
2200         * MiniBrowser/qt/BrowserWindow.cpp:
2201         (BrowserWindow::BrowserWindow):
2202         (BrowserWindow::onLoadProgressChanged):
2203         * MiniBrowser/qt/BrowserWindow.h:
2204
2205 2011-08-03  Martin Robinson  <mrobinson@igalia.com>
2206
2207         Build fix for WebKit2GTK+.
2208
2209         * WebKitTestRunner/GNUmakefile.am: Include libInternals as one of
2210         of the library dependencies of the injected bundle.
2211
2212 2011-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2213
2214         [GTK] Install web and plugin processes in libexecdir instead of bindir
2215         https://bugs.webkit.org/show_bug.cgi?id=65600
2216
2217         Reviewed by Martin Robinson.
2218
2219         Set WEBKIT_EXEC_PATH environment variable to use web and plugin
2220         process from current directory instead of the intalled ones.
2221
2222         * MiniBrowser/gtk/GNUmakefile.am:
2223         * MiniBrowser/gtk/main.c:
2224         (main):
2225         * WebKitTestRunner/GNUmakefile.am:
2226         * WebKitTestRunner/gtk/main.cpp:
2227         (main):
2228
2229 2011-08-02  Anders Carlsson  <andersca@apple.com>
2230
2231         Add mac-lion platform to old-run-webkit-tests
2232         https://bugs.webkit.org/show_bug.cgi?id=65577
2233
2234         * Scripts/old-run-webkit-tests:
2235         * Scripts/webkitdirs.pm:
2236         (isLion):
2237
2238 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
2239
2240         Buildbot: The Properties object has no "hasProperty" method in buildbot 8.3
2241         https://bugs.webkit.org/show_bug.cgi?id=65554
2242
2243         Using "has_key" instead of "hasProperty" in order to support buildbot 8.3.
2244
2245         Reviewed by Adam Roben.
2246
2247         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2248
2249 2011-08-02  Jochen Eisinger  <jochen@chromium.org>
2250
2251         Implement WebPermissionClient::allowPlugins for layout tests
2252         https://bugs.webkit.org/show_bug.cgi?id=33991
2253
2254         Reviewed by Adam Barth.
2255
2256         * DumpRenderTree/chromium/LayoutTestController.cpp:
2257         (LayoutTestController::LayoutTestController):
2258         (LayoutTestController::setPluginsAllowed):
2259         * DumpRenderTree/chromium/LayoutTestController.h:
2260         * DumpRenderTree/chromium/WebPermissions.cpp:
2261         (WebPermissions::allowPlugins):
2262         (WebPermissions::setPluginsAllowed):
2263         (WebPermissions::reset):
2264         * DumpRenderTree/chromium/WebPermissions.h:
2265
2266 2011-08-02  Adam Barth  <abarth@webkit.org>
2267
2268         TestFailures unit tests leak a global variable
2269         https://bugs.webkit.org/show_bug.cgi?id=65500
2270
2271         Reviewed by Adam Roben.
2272
2273         qunit detects the leak if you check the "noglobals" box on run-unittests.html.
2274
2275         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2276
2277 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
2278
2279         CSS Regions build bot should archive and upload output files
2280         https://bugs.webkit.org/show_bug.cgi?id=65200
2281
2282         Until now the buildbots would only upload the result archive if the 'trigger' parameters was specified. The
2283         upload was needed, because the testbots needed to download and use the archive. For CSS Regions we don't have
2284         a testbot yet, but we want to save the archive on the server for manual testing. Added new parameter
2285         in config.json, called "upload" that when set to "true" will force the upload to the buildmaster server.
2286
2287         The "features" argument is now taken into account when determining the name of the archive on the server. That
2288         was needed in order to avoid the CSS Regions Mac buildbot overwrite the SnowLeopard Mac build.
2289
2290         Reviewed by Adam Roben.
2291
2292         * BuildSlaveSupport/build.webkit.org-config/config.json:
2293         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2294
2295 2011-08-02  Patrick Gansterer  <paroga@webkit.org>
2296
2297         Fix _win32_check_running_pid on 64bit windows python
2298         https://bugs.webkit.org/show_bug.cgi?id=64950
2299
2300         Reviewed by Adam Roben.
2301
2302         Use the correct types for the PROCESSENTRY32 struct.
2303         th32DefaultHeapID is declared as ULONG_PTR and not as DWORD.
2304         Using 32bit for pointers instead of 64bit results in an ERROR_BAD_LENGTH
2305         failure, when calling the Process32First function.
2306         This is covered by the executive unittest.
2307
2308         * Scripts/webkitpy/common/system/executive.py:
2309
2310 2011-08-01  Adam Barth  <abarth@webkit.org>
2311
2312         garden-o-matic should call optimize-baselines when rebaselining tests
2313         https://bugs.webkit.org/show_bug.cgi?id=65499
2314
2315         Reviewed by Dimitri Glazkov.
2316
2317         I took the opportunity to modernize this code to use some of our more
2318         powerful primitives from base.
2319
2320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2321         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
2322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2323         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2324         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2325
2326 2011-08-01  Stephanie Lewis  <slewis@apple.com>
2327
2328         Finish reconfiguration started by Lucas Forschler
2329         Reconfigured slaves:
2330         Removed Leopard Intel Release (Build)
2331         Removed Leopard Intel Release (Tests)
2332         Remove apple-pixel-1
2333         Added Lion slaves from disabled Leopard slaves
2334
2335         Added builders:
2336         Lion Intel Release (Build)
2337         Lion Intel Debug (Build)
2338         Lion Intel Release (Tests)
2339         Lion Intel Release WK2 (Tests)
2340         Lion Intel Debug (Tests)
2341         Lion Intel Debug WK2 (Tests)
2342
2343         Added triggers:
2344         lion-intel-debug-tests
2345         lion-intel-debug-test-wk2
2346         lion-intel-release-tests
2347         lion-intel-release-tests-wk2
2348         
2349         Removed trigger:
2350         leopard-intel-release-tests
2351
2352         Added PlatformSpecificScheduler:
2353         mac-lion
2354
2355         Added "mac-lion" to build.py and build_unitttest.py
2356
2357         Reviewed by Mark Rowe.
2358
2359         * BuildSlaveSupport/build.webkit.org-config/config.json:
2360         * Scripts/webkitpy/common/config/build.py:
2361         * Scripts/webkitpy/common/config/build_unittest.py:
2362
2363  
2364 2011-08-01  Adam Barth  <abarth@webkit.org>
2365
2366         webkit-patch needs to be able to "optimize" the storage of baselines on disk
2367         https://bugs.webkit.org/show_bug.cgi?id=65418
2368
2369         Reviewed by Dimitri Glazkov.
2370
2371         If we're not careful when rebaselining tests, we can end up with lots
2372         of duplicate expected results files in the tree.  This patch adds a
2373         webkit-patch command that optimizes the storage of expected results on
2374         disk.
2375
2376         This command is similar to deduplicate-tests, except that it can move
2377         test results around rather than just remove duplicate results.
2378
2379         Unfortunately, this problem is very tricky because the baseline search
2380         structure is a hypergraph.  This patch include a huerstic optimizer
2381         that appears to work on a bunch of examples I've tried.  We'll likely
2382         need to refine it as gain experience.
2383
2384         * Scripts/webkitpy/common/system/filesystem.py:
2385         * Scripts/webkitpy/tool/commands/rebaseline.py:
2386
2387 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
2388
2389         Teach TestExpectationSerializer about parsed expectations.
2390         https://bugs.webkit.org/show_bug.cgi?id=65444
2391
2392         This is a bit largish in size, but the essentials are:
2393         * TestExpectationSerializer, given a parsed TestExpectationLine, can now spit out a pretty string.
2394         * We now store original content of the expectation line on TestExpectationLine.
2395         * Lots of tests.
2396
2397         Reviewed by Adam Barth.
2398
2399         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Fixed an issue where we didn't
2400             populate macros correctly, also fixed an issue where we incorrectly returned an empty list
2401             for all configurations.
2402         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for those.
2403         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed vestiges of code long gone,
2404             refactored TestExpectationsSerializer to recognize and correctly serialize parsed TestExpectationLine instances,
2405             changed to store and use TestExpectationLine.original_string.
2406         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
2407
2408 2011-08-01  Adam Barth  <abarth@webkit.org>
2409
2410         Remove unused functionality from gardeningserver
2411         https://bugs.webkit.org/show_bug.cgi?id=65479
2412
2413         Reviewed by Dimitri Glazkov.
2414
2415         We now handle these operations directly from the front-end.  That means
2416         they work even without the gardening server running!
2417
2418         Also, add some missing files to the list of static files.
2419
2420         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2421         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2422
2423 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
2424
2425         Introduce SpecifierSorter, a thing that knows how specifiers should be ordered.
2426         https://bugs.webkit.org/show_bug.cgi?id=65413
2427
2428         Reviewed by Adam Barth.
2429
2430         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added SpecifierSorter and converted
2431             existing code to use it.
2432         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests and cleaned up a bit.
2433
2434 2011-08-01  Adam Barth  <abarth@webkit.org>
2435
2436         Refactor bugzilla.js for use by garden-o-matic
2437         https://bugs.webkit.org/show_bug.cgi?id=65450
2438
2439         Reviewed by Dimitri Glazkov.
2440
2441         This patch refactors bugzilla.js to use the AsynchronousCache and
2442         updates the style to use a module instead of an object.  This patch
2443         then fixes all the existing code that uses this class to use the new
2444         API style.
2445
2446         This main benefit of this patch is we remove the tricky manual caching
2447         and this code is now available to use in garden-o-matic (since the
2448         dependency on Utilities.js is now gone).
2449
2450         I ran all the unit tests and poked around in TestFailures a bit to see
2451         that everything seemed to be working properly.
2452
2453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
2454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
2455         (FailingTestsBugForm):
2456         (FailingTestsBugForm.prototype._createBugTitle):
2457         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
2459         (FlakyTestBugForm):
2460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
2461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:
2462         (NewBugForm):
2463         (NewBugForm.prototype.domElement):
2464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
2465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:
2466         (TestRelatedBugForm):
2467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
2468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2469         (ViewController.prototype._displayBuilder.start):
2470         (ViewController.prototype._displayBuilder):
2471         (ViewController.prototype._domForAuxiliaryUIElements):
2472         (ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
2473         (ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
2474         (ViewController.prototype._domForPossiblyFlakyTests):
2475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2478
2479 2011-08-01  Adam Barth  <abarth@webkit.org>
2480
2481         garden-o-matic shouldn't require local server to determine if compile failed
2482         https://bugs.webkit.org/show_bug.cgi?id=65446
2483
2484         Reviewed by Dimitri Glazkov.
2485
2486         This patch adds some basic bindings for the buildbot JSON API.  I
2487         wanted to use Buildbot.js an Builder.js from the original TestFailures,
2488         but they make a number of WebKit-specific assumptions.  We'll
2489         eventually need to reconcile these pieces of code.
2490
2491         I should really add tests for this code, but that will require me to
2492         build a better mock network.  I'll be happy to do that in a follow-up
2493         patch.
2494
2495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
2496             - It's very unclear to me whether didFail is correct.  Supposedly
2497               the first entry here is the exit code of the step, which is 0 on
2498               success.  I suspect we'll need to improve this function over time.
2499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2502
2503 2011-08-01  Adam Barth  <abarth@webkit.org>
2504
2505         garden-o-matic should show all failures, even ones that it can't find a regression range for
2506         https://bugs.webkit.org/show_bug.cgi?id=65447
2507
2508         Reviewed by Dimitri Glazkov.
2509
2510         Previously, we just wouldn't display test failures that we couldn't
2511         identify a regression range for (or whose regression range had fallen
2512         off the page).  This patch just displays them at the end of the list,
2513         which is slightly (but not much) better.
2514
2515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2516
2517 2011-08-01  Jeff Miller  <jeffm@apple.com>
2518
2519         Windows build fix after r92096.
2520
2521         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
2522         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.
2523
2524 2011-07-31  Anders Carlsson  <andersca@apple.com>
2525
2526         DownloadDecideDestinationCrash WebKit2 API tests crashes
2527         https://bugs.webkit.org/show_bug.cgi?id=65442
2528
2529         Reviewed by Sam Weinig.
2530
2531         Copy the 18-characters.html file to the destination directory so we won't
2532         crash trying to make an URL for it.
2533
2534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2535
2536 2011-07-31  Anders Carlsson  <andersca@apple.com>
2537
2538         Fix SpacebarScrolling WebKit2 API test
2539         https://bugs.webkit.org/show_bug.cgi?id=65431
2540
2541         Reviewed by Sam Weinig.
2542
2543         Add a way to do platform-specific bundle initialization, and use it to disable smooth
2544         scrolling. Also make it possible for a test to load the injected bundle without actually running
2545         a test from it.
2546
2547         * TestWebKitAPI/InjectedBundleController.cpp:
2548         (TestWebKitAPI::InjectedBundleController::initialize):
2549         * TestWebKitAPI/InjectedBundleController.h:
2550         * TestWebKitAPI/PlatformUtilities.cpp:
2551         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2552         * TestWebKitAPI/PlatformUtilities.h:
2553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2554         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2555         (TestWebKitAPI::TEST):
2556         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.
2557         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2558         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
2559         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2560         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2561
2562 2011-07-31  Dimitri Glazkov  <dglazkov@chromium.org>
2563
2564         Use set comparison to find duplicate or overlapping specifiers in test expectations.
2565         https://bugs.webkit.org/show_bug.cgi?id=65430
2566
2567         Reviewed by Adam Barth.
2568
2569         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length
2570             of a set is wrong.
2571         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch
2572             regressions.
2573
2574 2011-07-31  Xan Lopez  <xlopez@igalia.com>
2575
2576         Group dependencies CFLAGS together.
2577
2578         * GNUmakefile.am: ditto.
2579
2580 2011-07-31  Daniel Bates  <dbates@webkit.org>
2581
2582         Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
2583         (https://bugs.webkit.org/show_bug.cgi?id=65419).
2584
2585         * GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
2586
2587 2011-07-30  Patrick Gansterer  <paroga@webkit.org>
2588
2589         Fix ports_unittest.py on native windows
2590         https://bugs.webkit.org/show_bug.cgi?id=64959
2591
2592         Reviewed by Adam Barth.
2593
2594         Replace WebKitPort.script_path with WebKitPort.script_shell_command.
2595         The latter includes the interpreter executable required on native windows.
2596
2597         * Scripts/webkitpy/common/config/ports_unittest.py:
2598
2599 2011-07-30  Adam Barth  <abarth@webkit.org>
2600
2601         Properly escape regular expressions.  (Maybe these shouldn't be regular
2602         expressions?)
2603
2604         * Scripts/webkitpy/tool/commands/rebaseline.py:
2605
2606 2011-07-30  Adam Barth  <abarth@webkit.org>
2607
2608         Add support for Win7 to garden-o-matic.
2609
2610         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2611         * Scripts/webkitpy/tool/commands/rebaseline.py:
2612
2613 2011-07-30  Adam Barth  <abarth@webkit.org>
2614
2615         garden-o-matic regression ranges expand after fast bots start passing
2616         https://bugs.webkit.org/show_bug.cgi?id=65406
2617
2618         Reviewed by Dimitri Glazkov.
2619
2620         Once the gardener has fixed a problem, the fast bots pick up the fix,
2621         which means we end up using the slow bots to compute the regression
2622         range.  Unfortunately, the slow bots give us large regression ranges,
2623         leading to this strange effect where the regression range quality
2624         degrades as fixes roll in.
2625
2626         This patch causes us to remember the previous regression ranges we've
2627         seen and to use that information in the future, as long as it's
2628         consistent with the new information we receive.
2629
2630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2631
2632 2011-07-30  Adam Barth  <abarth@webkit.org>
2633
2634         garden-o-matic should have a Refresh button to update its display
2635         https://bugs.webkit.org/show_bug.cgi?id=65403
2636
2637         Reviewed by Dimitri Glazkov.
2638
2639         The refresh button should be faster and less disruptive than the browser's reload button.
2640
2641         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2642         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2643
2644 2011-07-30  Adam Barth  <abarth@webkit.org>
2645
2646         garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
2647         https://bugs.webkit.org/show_bug.cgi?id=65231
2648
2649         Reviewed by Dimitri Glazkov.
2650
2651         The human readable name is easier to understand, especially when the patch is landed by the commit-queue.
2652
2653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2654
2655 2011-07-30  Adam Barth  <abarth@webkit.org>
2656
2657         garden-o-matic should strikeout revisions that have been rolled out
2658         https://bugs.webkit.org/show_bug.cgi?id=65227
2659
2660         Reviewed by Dimitri Glazkov.
2661
2662         This helps gardeners keep track of which problems have been solved.
2663
2664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2666         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2667         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2668
2669 2011-07-30  Adam Barth  <abarth@webkit.org>
2670
2671         Add missing files to the server.
2672
2673         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2674
2675 2011-07-29  Adam Barth  <abarth@webkit.org>
2676
2677         Actually import the logging module!
2678
2679         * Scripts/webkitpy/common/checkout/scm/git.py:
2680
2681 2011-07-29  Adam Barth  <abarth@webkit.org>
2682
2683         More debug logging.  Maybe we're running the git version of this
2684         function somehow?  (That would explain why it doesn't work!)
2685
2686         * Scripts/webkitpy/common/checkout/scm/git.py:
2687
2688 2011-07-29  Adam Barth  <abarth@webkit.org>
2689
2690         Add some temporary debug logging messages to try to understand why the
2691         windows bots can't figure out their current SVN revision.
2692
2693         * Scripts/webkitpy/common/checkout/scm/svn.py:
2694
2695 2011-07-29  Adam Barth  <abarth@webkit.org>
2696
2697         Chromium try servers should use downstream test_expectations
2698         https://bugs.webkit.org/show_bug.cgi?id=65390
2699
2700         Reviewed by Dirk Pranke.
2701
2702         Otherwise the try servers will report bogus failures.
2703
2704         * Scripts/webkitpy/layout_tests/port/chromium.py:
2705
2706 2011-07-29  Dimitri Glazkov  <dglazkov@chromium.org>
2707
2708         Fix an error in macro collapsing, refactor code to be pretty.
2709         https://bugs.webkit.org/show_bug.cgi?id=65387
2710
2711         My set math was wrong.
2712
2713         Reviewed by Adam Barth.
2714
2715         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Moved collapsing into a classmethod, fixed the math to be correct.
2716         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
2717
2718 2011-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
2719
2720         Style bot complains about EFL-specific forward declaration naming.
2721         https://bugs.webkit.org/show_bug.cgi?id=64680
2722
2723         Exclude EFL-specific forward declarations from indentifiers with underscores checks.
2724
2725         Reviewed by Adam Barth.
2726
2727         * Scripts/webkitpy/style/checkers/cpp.py:
2728         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2729
2730 2011-07-27  Adam Roben  <aroben@apple.com>
2731
2732         Use wacky !svn/bc URLs consistently in Leaks Viewer
2733
2734         This ensures that any resources loaded via relative URLs will still get pulled from the same
2735         revision of Subversion.
2736
2737         Fixes <http://webkit.org/b/65267> Focus/exclude button glyphs don't load on Leaks Viewer
2738
2739         Reviewed by David Kilzer.
2740
2741         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Use the
2742         !svn/bc-style URL for inspector.css, too, just like we do for all other resources we pull
2743         from Subversion.
2744
2745 2011-07-27  Raphael Kubo da Costa  <kubo@profusion.mobi>
2746
2747         [EFL] Drop WorkQueueItemEfl.h in favour of the general WorkQueueItem.h
2748         https://bugs.webkit.org/show_bug.cgi?id=65269
2749
2750         Reviewed by Kent Tamura.
2751
2752         WorkQueueItemEfl.h was being included by efl's
2753         LayoutTestControllerEfl.cpp, however the top-level
2754         LayoutTestController still included WorkQueueItem.h, causing a lot of
2755         type mismatches when running the WorkQueueItem code.
2756
2757         We can stick to the original WorkQueueItem header by making a few
2758         changes to EFL's LayoutTestController.
2759
2760         This should make tests such as
2761         fast/loader/non-deferred-substitute-load.html stop crashing.
2762
2763         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2764         (LayoutTestController::queueLoad):
2765         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2766         (LoadItem::invoke):
2767         (LoadHTMLStringItem::invoke):
2768         (ScriptItem::invoke):
2769         * DumpRenderTree/efl/WorkQueueItemEfl.h: Removed.
2770
2771 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
2772
2773         Re-add unit tests I accidentally zapped in r91878.
2774
2775         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Re-added unit tests.
2776
2777 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
2778
2779         Replace SpecificityCalculator with TestConfiguration-driven logic.
2780         https://bugs.webkit.org/show_bug.cgi?id=65206
2781
2782         Use our newly-acquired ability to expand modifiers into a set of
2783         matching TestConfiguration instances to calculate specificity and
2784         determine whether expectation applies to a given test configuration.
2785
2786         Also, store bug modifier on TestExpectationsLine.
2787
2788         Reviewed by Adam Barth.
2789
2790         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
2791             test configuration matching, removed a bunch of code.
2792         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
2793
2794
2795 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
2796
2797         Allow ports to specify their own test expectation specifier macros.
2798         https://bugs.webkit.org/show_bug.cgi?id=65291
2799
2800         Reviewed by Adam Barth.
2801
2802         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to use port macros.
2803         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
2804         * Scripts/webkitpy/layout_tests/port/base.py: Added configuration_specifier_macros to retrieve the macros.
2805         * Scripts/webkitpy/layout_tests/port/chromium.py: Overrode it to return Chromium's macros.
2806         * Scripts/webkitpy/layout_tests/port/test.py: Added test macros.
2807
2808 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
2809
2810         Allow TestConfigurationConverter report conversion errors.
2811         https://bugs.webkit.org/show_bug.cgi?id=65287
2812
2813         Also, fix a few miscellaneous testing issues.
2814
2815         Reviewed by Adam Barth.
2816
2817         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
2818         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
2819         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
2820             was created. 'default' is not a valid build type.
2821         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
2822
2823 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
2824
2825         Teach all ports about their test configurations.
2826         https://bugs.webkit.org/show_bug.cgi?id=65278
2827
2828         Each Port object should return a valid set of all TestConfiguration instances,
2829         available for this port.
2830
2831         Reviewed by Philippe Normand.
2832
2833         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Removed TestConfiguration.all_test_configurations,
2834             since it is different for each port.
2835         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Removed related test.
2836         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to take a list of
2837             all test configurations as a param.
2838         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted arguments accordingly.
2839         * Scripts/webkitpy/layout_tests/port/base.py: Forced all ports to override generation of all test configurations.
2840         * Scripts/webkitpy/layout_tests/port/chromium.py: Implemented _generate_all_test_configurations for the port.
2841         * Scripts/webkitpy/layout_tests/port/gtk.py: Ditto.
2842         * Scripts/webkitpy/layout_tests/port/mac.py: Ditto.
2843         * Scripts/webkitpy/layout_tests/port/qt.py: Ditto.
2844         * Scripts/webkitpy/layout_tests/port/win.py:
2845         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added an extra test to ensure we're generating a good set.
2846         * Scripts/webkitpy/layout_tests/port/test.py: Implemented a fixed-in-time all_test_configurations for testing.
2847         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added a mock all_test_configurations implementation.
2848         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added a unit test for the port.
2849
2850 2011-07-27  Benjamin Poulain  <benjamin@webkit.org>
2851
2852         [WK2][Qt] Move from QGraphicsView to Qt Scene Graph
2853         https://bugs.webkit.org/show_bug.cgi?id=62969
2854
2855         Reviewed by Andreas Kling.
2856
2857         Co-authored with Simon Hausmann  <simon.hausmann@nokia.com>
2858
2859         With the scene graph, the interface to have a window on screen is
2860         QSGCanvas. QGraphicsView is not used, and openGL is an enforced
2861         dependency.
2862
2863         Both the BrowserView and the WebKitTest runner are changed from
2864         QGraphicsView to QSGCanvas.
2865
2866         * MiniBrowser/qt/BrowserView.cpp:
2867         (BrowserView::BrowserView):
2868         (BrowserView::resizeEvent):
2869         (BrowserView::view):
2870         * MiniBrowser/qt/BrowserView.h:
2871         * MiniBrowser/qt/BrowserWindow.cpp:
2872         (BrowserWindow::BrowserWindow):
2873         (BrowserWindow::urlChanged):
2874         (BrowserWindow::~BrowserWindow):
2875         * MiniBrowser/qt/BrowserWindow.h:
2876         * MiniBrowser/qt/MiniBrowser.pro:
2877         * MiniBrowser/qt/main.cpp:
2878         (main):
2879         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2880         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2881         (WTR::WebView::WebView):
2882         (WTR::PlatformWebView::PlatformWebView):
2883         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2884
2885 2011-07-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2886
2887         Unreviewed, rolling out r91792.
2888         http://trac.webkit.org/changeset/91792
2889         https://bugs.webkit.org/show_bug.cgi?id=65242
2890
2891         It broke NRWT on Qt and GTK (Requested by Ossy_night on
2892         #webkit).
2893
2894         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2895         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2896         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2897         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2898         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2899         * Scripts/webkitpy/layout_tests/port/test.py:
2900
2901 2011-07-26  Adam Barth  <abarth@webkit.org>
2902
2903         Switch to an older idiom that works on Python 2.5.
2904
2905         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2906
2907 2011-07-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2908
2909         Add an exception to coding style check for EFL port.
2910         https://bugs.webkit.org/show_bug.cgi?id=65162
2911
2912         Add an exception of whitespace/declaration for EFL port. Because,
2913         '*' operator is next to variable in EFL coding style.
2914
2915         Reviewed by Kent Tamura.
2916
2917         * Scripts/webkitpy/style/checker.py:
2918
2919 2011-07-26  Keith Kyzivat  <keith.kyzivat@nokia.com>
2920
2921         [Qt] Add option to turn on disk caching in QtTestBrowser
2922         https://bugs.webkit.org/show_bug.cgi?id=65007
2923
2924         Reviewed by Noam Rosenthal.
2925
2926         Add menu item and command line option to turn on disk caching in
2927         QtTestBrowser. Simple QNetworkDiskCache added to the page's
2928         QNetworkAccssManager.
2929
2930         * QtTestBrowser/launcherwindow.cpp:
2931         (LauncherWindow::initializeView):
2932         (LauncherWindow::createChrome):
2933         (LauncherWindow::setDiskCache):
2934         * QtTestBrowser/launcherwindow.h:
2935         (WindowOptions::WindowOptions):
2936         * QtTestBrowser/main.cpp:
2937         (LauncherApplication::handleUserOptions):
2938
2939 2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2940
2941         Add support for download='filename' attribute in anchors.
2942         https://bugs.webkit.org/show_bug.cgi?id=64580
2943
2944         Reviewed by Adam Barth.
2945
2946         * DumpRenderTree/chromium/WebViewHost.cpp:
2947         (WebViewHost::loadURLExternally):
2948         * DumpRenderTree/chromium/WebViewHost.h:
2949
2950 2011-07-26  Dan Bernstein  <mitz@apple.com>
2951
2952         Rubber-stamped by Anders Carlsson.
2953
2954         Update DumpRenderTree and API tests for the pictograph font family preference.
2955
2956         * DumpRenderTree/mac/DumpRenderTree.mm:
2957         (resetDefaultsToConsistentValues):
2958         * DumpRenderTree/win/DumpRenderTree.cpp:
2959         (resetDefaultsToConsistentValues):
2960         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2961         (TestWebKitAPI::TEST):
2962         * WebKitTestRunner/TestController.cpp:
2963         (WTR::TestController::resetStateToConsistentValues):
2964
2965 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
2966
2967         Replace SpecificityCalculator with TestConfiguration-driven logic.
2968         https://bugs.webkit.org/show_bug.cgi?id=65206
2969
2970         Use our newly-acquired ability to expand modifiers into a set of
2971         matching TestConfiguration instances to calculate specificity and
2972         determine whether expectation applies to a given test configuration.
2973
2974         Also, store bug modifier on TestExpectationsLine.
2975
2976         Reviewed by Adam Barth.
2977
2978         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
2979         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
2980         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
2981             test configuration matching, removed a bunch of code.
2982         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
2983         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
2984             was created. 'default' is not a valid build type.
2985         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
2986
2987 2011-07-26  Adam Barth  <abarth@webkit.org>
2988
2989         Increase the information density in garden-o-matic
2990         https://bugs.webkit.org/show_bug.cgi?id=65141
2991
2992         Reviewed by Dimitri Glazkov.
2993
2994         This patch changes lets us show each revision on a single line,
2995         allowing use to show an entire day's worth of commits at once.
2996
2997         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2998         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3000
3001 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
3002
3003         TestConfigurationConverter should not barf on invalid specifiers.
3004         https://bugs.webkit.org/show_bug.cgi?id=65194
3005
3006         Reviewed by Adam Barth.
3007
3008         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Refactored TestConfigurationConverter.to_config_set a bit,
3009             made it return empty set whenever an invalid specifier is encountered.
3010         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added corresponding tests.
3011
3012 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
3013
3014         Introduce a way to convert between specifier lists and TestConfiguration sets.
3015         https://bugs.webkit.org/show_bug.cgi?id=65094
3016
3017         Add TestConfigurationConverter, a facility to convert:
3018         1) a set of specifiers into a set of TestConfiguration instances;
3019         2) a set of TestConfiguration instances into a list of sets of specifiers.
3020
3021         Reviewed by Adam Barth.
3022
3023         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfigurationConverter.
3024         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for it.
3025
3026 2011-07-26  Alexandru Chiculita  <achicu@adobe.com>
3027
3028         CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
3029         https://bugs.webkit.org/show_bug.cgi?id=65171
3030
3031         Added "features" parameter in config.json for "builder" objects. The parameter is optional and must be an array. All the items
3032         of the array will be passed to the build-webkit script. The items will automatically be prefixed with "--".
3033
3034         Reviewed by Adam Roben.
3035
3036         * BuildSlaveSupport/build.webkit.org-config/config.json:
3037         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3038
3039 2011-07-26  Chris Rogers  <crogers@google.com>
3040
3041         Avoid outputting #EOF twice for web audio tests in chromium DRT
3042         https://bugs.webkit.org/show_bug.cgi?id=65201
3043
3044         Reviewed by Dirk Pranke.
3045
3046         * DumpRenderTree/chromium/TestShell.cpp:
3047         (TestShell::dump):
3048
3049 2011-07-26  Adam Barth  <abarth@webkit.org>
3050
3051         Windows bots on build.chromium.org can't figure out the head_svn_revision
3052         https://bugs.webkit.org/show_bug.cgi?id=65156
3053
3054         Reviewed by Tony Chang.
3055
3056         This patch is a bit of a guess as to the issue based on the
3057         investigation in https://bugs.webkit.org/show_bug.cgi?id=65148.  I'm
3058         not sure whether it will fix the issue, but it seems worth a try.
3059
3060         * Scripts/webkitpy/common/checkout/scm/svn.py:
3061
3062 2011-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3063
3064         Unreviewed. Fix WebKitGtk build with GTK+ 3.x after r91707.
3065
3066         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3067         (getPreferredSizeMethod):
3068
3069 2011-07-26  MORITA Hajime  <morrita@google.com>
3070
3071         [Chromium][DRT] MockSpellCheck.cpp should be clang clean
3072         https://bugs.webkit.org/show_bug.cgi?id=65166
3073
3074         Reviewed by Kent Tamura.
3075
3076         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3077         (MockSpellCheck::spellCheckWord): -Wsign-compare warning.
3078
3079 2011-07-25  Patrick Gansterer  <paroga@webkit.org>
3080
3081         Ignore line endings in ChangeLogTests
3082         https://bugs.webkit.org/show_bug.cgi?id=64956
3083
3084         Reviewed by Adam Barth.
3085
3086         Split the lines of the ChangeLog text before comparing them.
3087         This fixes 3 tests on windows, since only the content importent.
3088
3089         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3090         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3091
3092 2011-07-25  Adam Barth  <abarth@webkit.org>
3093
3094         Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision
3095         https://bugs.webkit.org/show_bug.cgi?id=65148
3096
3097         Reviewed by Tony Chang.
3098
3099         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3100
3101 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3102
3103         Tweak whitespace wrapping to improve readability.
3104         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3105
3106 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3107
3108         Minor tweak to wrap label elements as atomic units.
3109
3110         * TestResultServer/static-dashboards/dashboard_base.js:
3111         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3112
3113 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3114
3115         always show flakiness details on the builder page
3116         https://bugs.webkit.org/show_bug.cgi?id=65139
3117
3118         Reviewed by Tony Chang.
3119
3120         In order to simplify the UI, we hide the flakiness details by default,
3121         but there's no actual use-case for this page without the flakiness details.
3122         So get rid of that option and always show the flakiness details.
3123
3124         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3125
3126 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3127
3128         simplify the UI of the header above the test list table
3129         https://bugs.webkit.org/show_bug.cgi?id=65136
3130
3131         Reviewed by Adam Barth.
3132
3133         Use checkboxes instead of links since this is really about which tests to include.
3134         Ends up using less text and put the checkboxes to the right of the header instead of below it.
3135
3136         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3137         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3138
3139 2011-07-25  Chris Rogers  <crogers@google.com>
3140
3141         Update new-run-webkit-tests to accomodate binary audio data
3142         https://bugs.webkit.org/show_bug.cgi?id=65135
3143
3144         Reviewed by Dirk Pranke.
3145
3146         * Scripts/webkitpy/layout_tests/port/chromium.py:
3147
3148 2011-07-25  Chris Rogers  <crogers@google.com>
3149
3150         Update Chromium DRT to output binary (instead of base64-encoded) data for web audio testing
3151         https://bugs.webkit.org/show_bug.cgi?id=65039
3152
3153         Reviewed by Tony Chang.
3154
3155         * DumpRenderTree/chromium/LayoutTestController.cpp:
3156         (LayoutTestController::LayoutTestController):
3157         (LayoutTestController::setAudioData):
3158         * DumpRenderTree/chromium/LayoutTestController.h:
3159         (LayoutTestController::audioData):
3160         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3161         (DRTPrinter::handleAudioHeader):
3162         (TestShellPrinter::handleAudioHeader):
3163         * DumpRenderTree/chromium/TestShell.cpp:
3164         (TestShell::dump):
3165
3166 2011-06-07  Martin Robinson  <mrobinson@igalia.com>
3167
3168         Reviewed by Gustavo Noronha Silva.
3169
3170         [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
3171         https://bugs.webkit.org/show_bug.cgi?id=62252
3172
3173         Add a new subclass of WebKitWebView that overrides the size request to
3174         return 1 pixel by 1 pixel. This ensure that it operates properly when
3175         not packed into a GtkScrolledWindow. Also construct the WebKitWebView
3176         with self-scrolling set to true.
3177
3178         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3179         (webInspectorInspectWebView): Use the new SelfScrollingWebKitWebview class here.
3180         (createWebView): Ditto.
3181         (main): Pack the widget into a GtkBox instead of a GtkScrolledWindow.
3182         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Added.
3183         (self_scrolling_webkit_web_view_class_init):
3184         (self_scrolling_webkit_web_view_init):
3185         (self_scrolling_webkit_web_view_new):
3186         (sizeRequestMethod):
3187         (getPreferredSizeMethod):
3188         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Added.
3189         * GNUmakefile.am: Added SelfScrollingWebKitWebView files to the source list.
3190
3191 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3192
3193         by default hide tests that have passes for all recorded runs
3194         https://bugs.webkit.org/show_bug.cgi?id=65127
3195
3196         Reviewed by Adam Barth.
3197
3198         This is part of simplifying the default views of the dashboard to
3199         make it show less information for the common use cases.
3200
3201         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3202         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3203
3204 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3205
3206         stop generating expectations.json now that it's unused
3207         https://bugs.webkit.org/show_bug.cgi?id=65130
3208
3209         Reviewed by Adam Barth.
3210
3211         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3212         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3213         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3214         * TestResultServer/handlers/menu.py:
3215         * TestResultServer/static-dashboards/dashboard_base.js:
3216         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3217
3218 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3219
3220         don't show builders in the flakiness dashboard that have stopped running a given test suite
3221         https://bugs.webkit.org/show_bug.cgi?id=65126
3222
3223         Reviewed by Mihai Parparita.
3224
3225         * TestResultServer/static-dashboards/dashboard_base.js:
3226
3227 2011-07-25  Adam Barth  <abarth@webkit.org>
3228
3229         Overhaul garden-o-matic frontend to integrate revision history and failures
3230         https://bugs.webkit.org/show_bug.cgi?id=65089
3231
3232         Reviewed by Dimitri Glazkov.
3233
3234         This is a major overhaul of the garden-o-matic frontend.  The new UI
3235         integrates the revision history information with failures.  Failures
3236         appear in context adjacent to the revisions that caused them (which are
3237         highlighted).  Each buildbot receives a collumn to the left, which
3238         indicates which revisions that bot has tested and whether that bot
3239         showed the indicated failures.
3240
3241         Failures are selectable with checkboxes, and can then either be
3242         examined or rebaselined.
3243
3244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
3245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
3246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3249         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
3250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
3251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3253
3254 2011-07-25  Holger Hans Peter Freyther  <zecke@selfish.org>
3255
3256         [buildbot] Add Qt Linux MIPSEL Configuration
3257         https://bugs.webkit.org/show_bug.cgi?id=65116
3258
3259         Reviewed by Adam Roben.
3260
3261         Introduce a Qt Linux MIPS EL build slave. The configuration
3262         is a build only configuration.
3263
3264         * BuildSlaveSupport/build.webkit.org-config/config.json: Add MIPS buildbot.
3265
3266 2011-07-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3267
3268         [Qt][WK2] Add multi-point touch mocking to MiniBrowser
3269         https://bugs.webkit.org/show_bug.cgi?id=64374
3270
3271         Reviewed by Benjamin Poulain.
3272
3273         Each mouse button generate a touch point. The touch point stay
3274         virtually on screen if the mouse release happened while the Ctrl
3275         modifier was pressed.
3276
3277         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3278         (MiniBrowserApplication::notify):
3279         * MiniBrowser/qt/MiniBrowserApplication.h:
3280
3281 2011-07-25  Balazs Kelemen  <kbalazs@webkit.org>
3282
3283         [Qt][WK2] Use NRWT for Qt-WK2
3284         https://bugs.webkit.org/show_bug.cgi?id=65097
3285
3286         Reviewed by Andreas Kling.
3287
3288         * Scripts/run-webkit-tests:
3289         (useNewRunWebKitTests):
3290
3291 2011-07-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3292
3293         Unreviewed, rolling out r91635.
3294         http://trac.webkit.org/changeset/91635
3295         https://bugs.webkit.org/show_bug.cgi?id=65083
3296
3297         It broke the minimal build (Requested by Ossy___OFFLINE on
3298         #webkit).
3299
3300         * QtTestBrowser/launcherwindow.cpp:
3301         (LauncherWindow::initializeView):
3302         (LauncherWindow::createChrome):
3303         * QtTestBrowser/launcherwindow.h:
3304         (WindowOptions::WindowOptions):
3305         * QtTestBrowser/main.cpp:
3306         (LauncherApplication::handleUserOptions):
3307
3308 2011-07-24  Adam Barth  <abarth@webkit.org>
3309
3310         Rename garden-o-matic "alert" to "infobar" and increase the width to 100%.
3311
3312         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3313         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3314         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3315         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3316         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3318
3319 2011-07-23  Dimitri Glazkov  <dglazkov@chromium.org>
3320
3321         TestConfiguration should be hashable and comparable for equality.
3322         https://bugs.webkit.org/show_bug.cgi?id=65070
3323
3324         Reviewed by Adam Barth.
3325
3326         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added __hash__ and __eq__ methods.
3327         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
3328
3329 2011-07-23  Dimitri Glazkov  <dglazkov@chromium.org>
3330
3331         Extract TestConfiguration from base and write a few unit tests to capture current behavior.
3332         https://bugs.webkit.org/show_bug.cgi?id=65066
3333
3334         Reviewed by Adam Barth.
3335
3336         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added.
3337         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added.
3338         * Scripts/webkitpy/layout_tests/port/base.py: Moved code to test_configuration.py
3339
3340 2011-07-23  Alok Priyadarshi  <alokp@chromium.org>
3341
3342         Switching off acceleration for small canvas broke gpu tests
3343         https://bugs.webkit.org/show_bug.cgi?id=65053
3344
3345         Reviewed by Stephen White.
3346
3347         * DumpRenderTree/chromium/WebPreferences.cpp:
3348         (WebPreferences::reset):
3349         (WebPreferences::applyTo):
3350         * DumpRenderTree/chromium/WebPreferences.h:
3351
3352 2011-07-23  Keith Kyzivat  <keith.kyzivat@nokia.com>
3353
3354         [Qt] Add option to turn on disk caching in QtTestBrowser
3355         https://bugs.webkit.org/show_bug.cgi?id=65007
3356
3357         Reviewed by Noam Rosenthal.
3358
3359         Add menu item and command line option to turn on disk caching in
3360         QtTestBrowser. Simple QNetworkDiskCache added to the page's
3361         QNetworkAccssManager.
3362
3363         * QtTestBrowser/launcherwindow.cpp:
3364         (LauncherWindow::initializeView):
3365         (LauncherWindow::createChrome):
3366         (LauncherWindow::setDiskCache):
3367         * QtTestBrowser/launcherwindow.h:
3368         (WindowOptions::WindowOptions):
3369         * QtTestBrowser/main.cpp:
3370         (LauncherApplication::handleUserOptions):
3371
3372 2011-07-22  Ojan Vafai  <ojan@chromium.org>
3373
3374         Don't match 'DEBUG' when trying to filter BUG modifiers.
3375         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3376         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3377
3378 2011-07-22  Ojan Vafai  <ojan@chromium.org>
3379
3380         Fix issue loading gtests since there's no g_expectations.
3381         Also, make filing a bug file a webkit.org bug, not a crbug since
3382         the link is only shown for layout tests.
3383         * TestResultServer/static-dashboards/dashboard_base.js:
3384         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3385
3386 2011-07-22  Ojan Vafai  <ojan@chromium.org>
3387
3388         pull test expectations into the dashboard from wvn.webkit.org
3389         https://bugs.webkit.org/show_bug.cgi?id=65054
3390
3391         Reviewed by Adam Barth.
3392
3393         Now that svn.webkit.org supports cors headers, we can just grab the txt
3394         file from there instead of generating a JSON file that we upload
3395         to appengine. We'll stop generating the JSON file in a followup patch.
3396
3397         * TestResultServer/static-dashboards/dashboard_base.js:
3398         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3399         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3400
3401 2011-07-22  Adam Barth  <abarth@webkit.org>
3402
3403         Fix typo so the tool works on a case-sensitive file system.
3404
3405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3406
3407 2011-07-22  Adam Barth  <abarth@webkit.org>
3408
3409         garden-o-matic should know what patches are landing
3410         https://bugs.webkit.org/show_bug.cgi?id=64978
3411
3412         Reviewed by Dimitri Glazkov.
3413
3414         This patch adds a display of the recently committed patches to
3415         garden-o-matic.  The UI needs iteration, but this patch establishes the
3416         plumbing.
3417
3418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
3419             - Teach trac how to extract more information from the commit log.
3420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3421             - Add a data attribute for storing the revision.
3422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3423             - Add a container for the recent commit history.
3424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3425             - CSS for displaying non-ugly commit history.
3426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3427             - Wire up trac to the UI container.
3428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3429             - A basic, compact display for a list of commits.
3430
3431 2011-07-22  Ojan Vafai  <ojan@chromium.org>
3432
3433         Fix bug when switching from layout-tests to another test-type if
3434         ToT webkit.org is the selected group.
3435         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3436
3437 2011-07-22  Ojan Vafai  <ojan@chromium.org>
3438
3439         Add back in line accidentally deleted in http://trac.webkit.org/changeset/91612.
3440         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3441
3442 2011-07-22  Ojan Vafai  <ojan@chromium.org>
3443
3444         simplify the flakiness dashboard to only show modifiers/expectations for the current builder
3445         https://bugs.webkit.org/show_bug.cgi?id=65049
3446
3447         Reviewed by Tony Chang.
3448
3449         This communicates less information, but probably makes the dashboard more usable.
3450         Also make it show that bug lines that don't point to bug numbers still
3451         show up in the bugs column (e.g. BUG_TONY) and stop showing the extra/missing
3452         columns in any view. The data is still used, but only in the view that updates
3453         the test_expectations.txt file.
3454
3455         * TestResultServer/static-dashboards/dashboard_base.js:
3456         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3457         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3458
3459 2011-07-21  Ojan Vafai  <ojan@chromium.org>
3460
3461         hook in the rest of the bots to the dashboard now they run NRWT
3462         https://bugs.webkit.org/show_bug.cgi?id=64985
3463
3464         Reviewed by Adam Barth.
3465
3466         * TestResultServer/static-dashboards/builders.js:
3467
3468 2011-07-22  Alexey Proskuryakov  <ap@apple.com>
3469
3470         Adding Tim Horton to contributor list for Bugzilla auto-completion. He is CC'ed quite frequently.
3471
3472         Unreviewed.
3473
3474         * Scripts/webkitpy/common/config/committers.py:
3475
3476 2011-07-22  Michal Pakula vel Rutka  <m.pakula@samsung.com>
3477
3478         [EFL] ewk_frame_hit_test_new enchancement
3479         https://bugs.webkit.org/show_bug.cgi?id=64260
3480
3481         Apply changes done in ewk_frame_hit_test_new in EWebLauncher:
3482         Replacing Ewk_Hit_Test_Result_Context structure 'flags'
3483         in hit test output to by enum 'context'.
3484
3485         Reviewed by Antonio Gomes.
3486
3487         * EWebLauncher/main.c:
3488         (on_key_down):
3489
3490 2011-07-21  Adam Roben  <aroben@apple.com>
3491
3492         Fix typo in TestFailures
3493
3494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3495
3496 2011-07-21  Ojan Vafai  <ojan@chromium.org>
3497
3498         simplify gtest display now that we strip modifiers from the JSON
3499         https://bugs.webkit.org/show_bug.cgi?id=64990
3500
3501         Reviewed by Adam Barth.
3502
3503         Now that names are normalized, we can remove all the code that
3504         handles gtest name changes (e.g. for adding modifiers like DISABLED_).
3505         Instead, if you try to list a test with a modifier in it, we need
3506         to strip the modifier so we get the normalized value.
3507
3508         We also get rid of the concept of extra/missing expectations for gtests.
3509         In a patch soon, we'll stop showing extra/missing expectations from the UI
3510         entirely and only leave it for the special updating test_expectations.txt
3511         view of the dashboard, which doesn't apply to gtests.
3512
3513         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3514         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3515
3516 2011-07-21  Adam Barth  <abarth@webkit.org>
3517
3518         Refactor Trac.js for use in garden-o-matic
3519         https://bugs.webkit.org/show_bug.cgi?id=64998
3520
3521         Reviewed by Adam Roben.
3522
3523         This patch refactors Trac.js to match the architecture and style of
3524         garden-o-matic.  I've also factored AsynchronousCache out of Trac (and
3525         moved it to base) because it was redundant with some other code we
3526         already had.
3527
3528         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
3529         (FailingTestsBugForm):
3530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
3531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
3532         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3533         (ViewController.prototype._displayBuilder.start):
3534         (ViewController.prototype._displayBuilder):
3535         (ViewController.prototype._domForRegressionRange.trac.getCommitDataForRevisionRange):
3536         (ViewController.prototype._domForRegressionRange):
3537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
3538         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
3540         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
3541         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3542
3543 2011-07-21  Ojan Vafai  <ojan@chromium.org>
3544
3545         Fix issue throwing a 500 to the bots. We were modifying
3546         the dictionary during an iteration over it's keys and would get
3547         RuntimeError: dictionary changed size during iteration
3548
3549         * TestResultServer/model/jsonresults.py:
3550
3551 2011-07-21  Adam Barth  <abarth@webkit.org>
3552
3553         ORWT fails to consume some NRWT arguments
3554         https://bugs.webkit.org/show_bug.cgi?id=64988
3555
3556         Reviewed by Adam Roben.
3557
3558         * Scripts/old-run-webkit-tests:
3559
3560 2011-07-21  Adam Barth  <abarth@webkit.org>
3561
3562         Merge TestFailures and garden-o-matic unit tests harness
3563    &nbs