webkitpy: Increase estimate for processes run by iOS Simulators
[WebKit-https.git] / Tools / ChangeLog
1 2017-04-10  Jonathan Bedard  <jbedard@apple.com>
2
3         webkitpy: Increase estimate for processes run by iOS Simulators
4         https://bugs.webkit.org/show_bug.cgi?id=170678
5         <rdar://problem/31534061>
6
7         Reviewed by Aakash Jain.
8
9         Previously, it was estimated that each simulated iOS device would run about 100
10         processes.  With newer versions of iOS, this is closer to 125.
11
12         * Scripts/webkitpy/port/ios_simulator.py:
13         (IOSSimulatorPort): Increase process estimate from 100 to 125.
14
15 2017-04-10  Adrian Perez de Castro  <aperez@igalia.com>
16
17         [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
18         https://bugs.webkit.org/show_bug.cgi?id=170553
19
20         Reviewed by Michael Catanzaro.
21
22         Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when
23         building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend
24         to properly position popup menus, and also avoids using functions
25         which were deprecated starting at that GTK+ release.
26
27         * MiniBrowser/gtk/BrowserSearchBar.c:
28         (searchEntryMenuIconPressedCallback):
29         Update MiniBrowser to use gtk_menu_popup_at_pointer().
30
31 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
32
33         REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing
34         https://bugs.webkit.org/show_bug.cgi?id=170677
35         <rdar://problem/31512633>
36
37         Reviewed by Tim Horton.
38
39         Fixes two drag and drop LayoutTests by introducing and enabling a TestOptions switch (enableDragDestinationActionLoad)
40         to allow dropping URLs to trigger page navigation.
41
42         * DumpRenderTree/TestOptions.h:
43         * DumpRenderTree/TestOptions.mm:
44         (TestOptions::TestOptions):
45         * DumpRenderTree/mac/DumpRenderTree.mm:
46         (resetWebViewToConsistentStateBeforeTesting):
47         * DumpRenderTree/mac/UIDelegate.h:
48         * DumpRenderTree/mac/UIDelegate.mm:
49         (-[UIDelegate resetToConsistentStateBeforeTesting:]):
50         (-[UIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
51
52 2017-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
53
54         update-webkit-dependency should report $response->message for diagnose
55         https://bugs.webkit.org/show_bug.cgi?id=170666
56
57         Reviewed by Alex Christensen.
58
59         * Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.
60
61 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
62
63         Data interaction on an image enclosed by an anchor should vend the anchor's URL
64         https://bugs.webkit.org/show_bug.cgi?id=170660
65         <rdar://problem/31043220>
66
67         Reviewed by Tim Horton.
68
69         Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
70         anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
71         should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
72         rects, but should not be.
73
74         See WebCore ChangeLog for more details.
75
76         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
77         * TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
78         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
79         (TestWebKitAPI::TEST):
80
81 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
82
83         [GTK] Remove the GDK dependency from ImageDiff
84         https://bugs.webkit.org/show_bug.cgi?id=85299
85
86         Reviewed by Žan Doberšek.
87
88         Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
89         Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
90         actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
91         ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
92         implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
93         and also add CG implementation.
94
95         * ImageDiff/CMakeLists.txt:
96         * ImageDiff/Cairo.cmake: Added.
97         * ImageDiff/ImageDiff.cpp: Added.
98         (main):
99         * ImageDiff/PlatformGTK.cmake:
100         * ImageDiff/PlatformImage.cpp: Added.
101         (ImageDiff::PlatformImage::isCompatible):
102         (ImageDiff::PlatformImage::difference):
103         * ImageDiff/PlatformImage.h: Added.
104         * ImageDiff/cairo/PlatformImageCairo.cpp: Added.
105         (ImageDiff::PlatformImage::createFromStdin):
106         (ImageDiff::PlatformImage::createFromDiffData):
107         (ImageDiff::PlatformImage::PlatformImage):
108         (ImageDiff::PlatformImage::~PlatformImage):
109         (ImageDiff::PlatformImage::width):
110         (ImageDiff::PlatformImage::height):
111         (ImageDiff::PlatformImage::rowBytes):
112         (ImageDiff::PlatformImage::hasAlpha):
113         (ImageDiff::PlatformImage::pixels):
114         (ImageDiff::PlatformImage::writeAsPNGToStdout):
115         * ImageDiff/gtk/ImageDiff.cpp: Removed.
116
117 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
118
119         REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
120         https://bugs.webkit.org/show_bug.cgi?id=170667
121
122         Reviewed by Žan Doberšek.
123
124         In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
125         that value.
126
127         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
128         (WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
129
130 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
131
132         WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
133         https://bugs.webkit.org/show_bug.cgi?id=170653
134
135         Reviewed by Tim Horton.
136
137         When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage,
138         which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the
139         platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web
140         snapshot from TestInvocation::dumpPixelsAndCompareWithExpected().
141
142         * WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage().
143         * WebKitTestRunner/TestInvocation.cpp:
144         (WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel
145         results were created in the web process.
146         * WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected().
147         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
148         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the cairo surface from the given WKimage in case
149         of web contents snapshot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
150         * WebKitTestRunner/cg/TestInvocationCG.cpp:
151         (WTR::createCGContextFromCGImage): Changed to receive a CGImageRef and renamed.
152         (WTR::createCGContextFromImage): Get the CGImageRef from the WKImage and call createCGContextFromCGImage().
153         (WTR::paintRepaintRectOverlay): It receives now the image size instead of the WKImage.
154         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the CGContextRef from the WKImage in case of web
155         contents snpashot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
156         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
157         (WTR::PlatformWebView::windowSnapshotImage): Return the cairo surface instead of creating a WKImage. Also use
158         RGB24 format to match what mac does (kCGWindowImageShouldBeOpaque).
159         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
160         (WTR::PlatformWebView::windowSnapshotImage): Return the CGImageRef instead of creating a WKImage.
161         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
162         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
163
164 2017-04-10  Chris Dumez  <cdumez@apple.com>
165
166         Drop Timer::startOneShot() overload taking a double
167         https://bugs.webkit.org/show_bug.cgi?id=170659
168
169         Reviewed by Yusuke Suzuki.
170
171         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
172
173         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
174         (TestWebKitAPI::TEST):
175         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
176         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
177
178 2017-04-09  Wenson Hsieh  <wenson_hsieh@apple.com>
179
180         [WK2] Add infrastructure to perform actions after an asynchronous position information request finishes
181         https://bugs.webkit.org/show_bug.cgi?id=170658
182         <rdar://problem/31431450>
183
184         Reviewed by Tim Horton.
185
186         Adds a new test verifying that when a web page is unresponsive, the process of preparing for data interaction
187         does not also cause the UI process to spin. We assume here that the call to prepare must be asynchronous, so it
188         should complete before the unresponsiveness timeout is triggered.
189
190         See WebKit2 ChangeLog for more details.
191
192         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
193         (TestWebKitAPI::TEST):
194
195 2017-04-09  Chris Dumez  <cdumez@apple.com>
196
197         Drop Timer::startRepeating() overload taking a double
198         https://bugs.webkit.org/show_bug.cgi?id=170656
199
200         Reviewed by Yusuke Suzuki.
201
202         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
203
204         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
205         (TestWebKitAPI::TEST):
206
207 2017-04-09  Youenn Fablet  <youenn@apple.com>
208
209         Resync WPT tests up to 23cd07d4685d81024b7440e042f8bbdb33e7ddec
210         https://bugs.webkit.org/show_bug.cgi?id=170647
211
212         Reviewed by Sam Weinig.
213
214         * Scripts/webkitpy/common/checkout/scm/git.py:
215         (Git.fetch): Fetching origin remote in case there is more than one.
216
217 2017-04-08  Simon Fraser  <simon.fraser@apple.com>
218
219         Update CSSProperties.json with correct fill-and-stroke status, and other cleanup
220         https://bugs.webkit.org/show_bug.cgi?id=170643
221
222         Reviewed by Chris Dumez.
223         
224         Update the CSSProperties.json style checker to allow:
225             - comments in codegen_properties
226             - obsolete-category and obsolete-url in specification blocks
227             - renamed "done" to "supported"
228             
229         Fix some references to codegen_properties to be codegen-properties.
230
231         * Scripts/webkitpy/style/checkers/jsonchecker.py:
232         (JSONCSSPropertiesChecker.validate_status_type):
233         (JSONCSSPropertiesChecker.validate_property_specification):
234         (JSONCSSPropertiesChecker.check_codegen_properties):
235
236 2017-04-08  Youenn Fablet  <youenn@apple.com>
237
238         WebRTC tests gardening
239         https://bugs.webkit.org/show_bug.cgi?id=170508
240
241         Reviewed by Eric Carlson.
242
243         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
244
245 2017-04-07  Keith Miller  <keith_miller@apple.com>
246
247         Add a PriorityQueue class
248         https://bugs.webkit.org/show_bug.cgi?id=170579
249
250         Reviewed by Saam Barati.
251
252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
253         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp: Added.
254         (operator  _z ):
255         (enqueue):
256         (dequeue):
257         (TEST):
258         (compareMove):
259
260 2017-04-07  Ryosuke Niwa  <rniwa@webkit.org>
261
262         Replace ES6SampleBench by ARES-6 in run-benchmark
263         https://bugs.webkit.org/show_bug.cgi?id=170585
264
265         Reviewed by Saam Barati.
266
267         Updated the plan file for ES6SampleBench to run ARES-6 instead. Also increased the number of iterations
268         from 4 to 8 to match teh default, and reduced the number of browser instances to use from 5 to 3.
269
270         * Scripts/webkitpy/benchmark_runner/data/patches/ARES-6.patch: Renamed from ES6SampleBench.patch.
271         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan: Renamed from es6bench.plan.
272
273 2017-04-07  Myles C. Maxfield  <mmaxfield@apple.com>
274
275         REGRESSION(r211382): Complex text with justification erroneously overflows containers
276         https://bugs.webkit.org/show_bug.cgi?id=170399
277         <rdar://problem/31442008>
278
279         Reviewed by Simon Fraser.
280
281         Check for the invariant that the sum of the advances is equal to m_totalWidth.
282
283         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
284         (TestWebKitAPI::TEST_F):
285
286 2017-04-07  Ryan Haddad  <ryanhaddad@apple.com>
287
288         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
289         https://bugs.webkit.org/show_bug.cgi?id=167594
290
291         Unreviewed test gardening.
292
293         Disable this test because it is still timing out on the bots.
294
295         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
296         (TEST):
297
298 2017-04-07  Jonathan Bedard  <jbedard@apple.com>
299
300         REGRESSION (r214553): Allow layout-tests to be run from Xcode without re-directing stdout, stdin and stderr
301         https://bugs.webkit.org/show_bug.cgi?id=170601
302         <rdar://problem/31492696>
303
304         Reviewed by Simon Fraser.
305
306         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
307         (setUpIOSLayoutTestCommunication): Skip TCP setup if no port is in the environment.
308         (tearDownIOSLayoutTestCommunication): Only teardown if TCP was used.
309
310 2017-04-07  Aakash Jain  <aakash_jain@apple.com>
311
312         Add support for test262 JavaScriptCore tests
313         https://bugs.webkit.org/show_bug.cgi?id=170523
314
315         Reviewed by Daniel Bates.
316
317         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bot433 and bot434.
318         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
319         (RunTest262Tests): Added class to run Test262 tests.
320         (RunTest262Tests.start): Added.
321         (RunTest262Tests.countFailures): Method to count the failures.
322         (Test262Factory): Added Test262 factory class.
323         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
324         (RunTest262TestsTest): Added unit tests.
325         (RunTest262TestsTest.assertResults): Helper method.
326         (RunTest262TestsTest.test_no_regressions_output): Added test case.
327         (test_failure_output): Same. 
328         (test_failures_output): Same.
329
330 2017-04-07  Caio Lima  <ticaiolima@gmail.com>
331
332         [JSC] Change --debug option to --debugger
333         https://bugs.webkit.org/show_bug.cgi?id=170587
334
335         Reviewed by Keith Miller.
336
337         * Scripts/run-jsc:
338
339         This patch is changing the new debugger flag for Tools/Scripts/run-jsc
340         to --debugger to avoid shadowing --debug flag used to run JSC with
341         Debug build.
342
343 2017-04-07  Brent Fulgham  <bfulgham@apple.com>
344
345         WebKit should percent encode single quotes in query strings
346         https://bugs.webkit.org/show_bug.cgi?id=170561
347         <rdar://problem/7415154>
348
349         Reviewed by Alex Christensen.
350
351         Add a test case for single-quote in the URL query string.
352
353         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
354
355 2017-04-06  Myles C. Maxfield  <mmaxfield@apple.com>
356
357         Make FontWithFeatures test font pass OTS
358         https://bugs.webkit.org/show_bug.cgi?id=169788
359
360         Reviewed by Tim Horton.
361
362         OTS, or the OpenType Sanitizer, is a check which tells if fonts are properly formed.
363         Previously, our FontWithFeatures test font did not pass this check. This patch updates
364         the font to pass the checks. Now, we can use this font on other platforms, and
365         contribute the font to the W3C for testing the CSS Fonts level 3 spec.
366
367         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
368         (Generator::appendCFFTable):
369         (Generator::Feature::operator<):
370         (Generator::appendGSUBTable):
371         (Generator::appendOS2Table):
372         (Generator::appendFormat4CMAPTable):
373         (Generator::appendHEADTable):
374         (Generator::appendHHEATable):
375         (Generator::NameRecord::operator<):
376         (Generator::appendNameSubtable):
377         (Generator::appendNAMETable):
378
379 2017-04-06  Alexey Proskuryakov  <ap@apple.com>
380
381         Disable flaky WebKit2.ResizeWithHiddenContentDoesNotHang
382         for https://bugs.webkit.org/show_bug.cgi?id=170195
383
384         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
385
386 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
387
388         Unreviewed, rolling out r215046.
389
390         This change broke internal builds.
391
392         Reverted changeset:
393
394         "WebRTC tests gardening"
395         https://bugs.webkit.org/show_bug.cgi?id=170508
396         http://trac.webkit.org/changeset/215046
397
398 2017-04-06  Youenn Fablet  <youenn@apple.com>
399
400         WebRTC tests gardening
401         https://bugs.webkit.org/show_bug.cgi?id=170508
402
403         Reviewed by Eric Carlson.
404
405         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
406
407 2017-04-06  Jonathan Bedard  <jbedard@apple.com>
408
409         REGRESSION: Simulators failing to install after launch_app times out
410         <rdar://problem/31478107>
411
412         Unreviewed infrastructure fix.
413
414         * Scripts/webkitpy/xcode/simulated_device.py:
415         (SimulatedDevice.launch_app._install_timeout): Raise RuntimeError, not Exception.
416
417 2017-04-05  Joseph Pecoraro  <pecoraro@apple.com>
418
419         test262: module test progressions need updated expectations (@@iterator changes)
420         https://bugs.webkit.org/show_bug.cgi?id=170535
421
422         Reviewed by Saam Barati.
423
424         * Scripts/run-jsc-stress-tests:
425         Add :failDueToOutdatedOrBadTest to distinguish between a test failure
426         in JavaScriptCore or an outdated or incorrect test262 test.
427
428 2017-04-05  Joseph Pecoraro  <pecoraro@apple.com>
429
430         Remove run-jsc-stress-tests benign warning about otool '-S' switch
431         https://bugs.webkit.org/show_bug.cgi?id=170527
432
433         Reviewed by Aakash Jain.
434
435         * Scripts/run-jsc-stress-tests:
436         The switch is not necessary and produces an error.
437
438 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
439
440         webkitpy: Add pid logging for simulator processes
441         https://bugs.webkit.org/show_bug.cgi?id=170505
442
443         Reviewed by Alexey Proskuryakov.
444
445         * Scripts/webkitpy/port/simulator_process.py:
446         (SimulatorProcess._start.handler): Add pid to exception.
447         (SimulatorProcess._start): Ditto.
448         * Scripts/webkitpy/xcode/simulated_device.py:
449         (SimulatedDevice.launch_app): Log pid when the process fails to launch and when
450         a pid is successfully returned.
451
452 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
453
454         Unreviewed, rolling out r214932.
455
456         This change broke an internal build.
457
458         Reverted changeset:
459
460         "[ios-simulator] API test WebKit2.DataDetectionReferenceDate
461         timing out"
462         https://bugs.webkit.org/show_bug.cgi?id=161967
463         http://trac.webkit.org/changeset/214932
464
465 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
466
467         Unreviewed, rolling out r214962.
468
469         Roll r214937 back in because it wasn't at fault for the build
470         breakage.
471
472         Reverted changeset:
473
474         "Unreviewed, rolling out r214937."
475         https://bugs.webkit.org/show_bug.cgi?id=170365
476         http://trac.webkit.org/changeset/214962
477
478 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
479
480         Unreviewed, rolling out r214937.
481
482         This change broke an internal build.
483
484         Reverted changeset:
485
486         "REGRESSION (r202472): Data Detection overwrites existing
487         links in detected ranges"
488         https://bugs.webkit.org/show_bug.cgi?id=170365
489         http://trac.webkit.org/changeset/214937
490
491 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
492
493         Increase timeouts for simulator testing
494         Unreviewed infrastructure fix.
495
496         r214895 was not sufficient, increasing timeouts again.
497
498         * Scripts/webkitpy/xcode/simulated_device.py:
499         (SimulatedDevice.install_app): Increase timeout from 3 to 10 seconds.
500
501 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
502
503         Formatting fix to remove extra space.
504
505         Unreviewed formatting fix.
506
507         * Scripts/webkitdirs.pm:
508         (isEmbeddedWebKit): Remove extra space.
509
510 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
511
512         Rename isIOSLikeWebKit to isEmbeddedWebKit.
513
514         Rubber-stamped by Alexey Proskuryakov. 
515
516         * Scripts/webkitdirs.pm:
517         (isEmbeddedWebKit): Added
518         (isIOSLikeWebKit): Deleted.
519
520 2017-04-05  Alex Christensen  <achristensen@webkit.org>
521
522         Fix CMake build.
523
524         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
525         * TestRunnerShared/spi/CoreGraphicsSPI.h: Removed.
526         * TestRunnerShared/spi/CoreGraphicsTestSPI.h: Copied from Tools/TestRunnerShared/spi/CoreGraphicsSPI.h.
527         There is a CoreGraphicsSPI.h in WebCore and the CMake build was finding the wrong one.
528         Since we just inherit the include paths from WebCore in the CMake build and since this SPI is only used for testing,
529         I just renamed CoreGraphicsSPI.h to CoreGraphicsTestSPI.h to avoid any name collisions.
530         * WebKitTestRunner/PlatformMac.cmake:
531         Add some missing files.
532         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
533
534 2017-04-05  Keith Miller  <keith_miller@apple.com>
535
536         Add debug option to run-jsc script
537         https://bugs.webkit.org/show_bug.cgi?id=170503
538
539         Reviewed by Yusuke Suzuki.
540
541         Adds a new option to the run-jsc script so that when passed
542         "--debug" it will wrap the jsc call with an lldb invocation. If
543         someone wishes to use a different debugger they can set the
544         DEBUGGER environment variable. Additionally, run-jsc now exits
545         with the exit status of the jsc call.
546
547         * Scripts/run-jsc:
548
549 2017-04-05  Andy Estes  <aestes@apple.com>
550
551         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
552         https://bugs.webkit.org/show_bug.cgi?id=170365
553         <rdar://problem/29205721>
554
555         Reviewed by Tim Horton.
556
557         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
558         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
559         (TEST): Re-enabled the test, which now passes.
560
561 2017-04-05  Andy Estes  <aestes@apple.com>
562
563         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
564         https://bugs.webkit.org/show_bug.cgi?id=167594
565
566         Re-enabled this API test now that webkit.org/b/161967 is fixed.
567
568         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
569         (TEST):
570
571 2017-04-05  Andy Estes  <aestes@apple.com>
572
573         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
574         https://bugs.webkit.org/show_bug.cgi?id=161967
575
576         Reviewed by Alexey Proskuryakov.
577
578         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
579         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
580
581 2017-04-04  Simon Fraser  <simon.fraser@apple.com>
582
583         Various settings in Minibrowser are off by default, and should be on
584         https://bugs.webkit.org/show_bug.cgi?id=170465
585         rdar://problem/31421543
586
587         Reviewed by Tim Horton.
588
589         Explicitly set preferences that should be on by default to enabled, if they have not been
590         set previously.
591
592         * MiniBrowser/mac/SettingsController.m:
593         (-[SettingsController init]):
594
595 2017-04-04  JF Bastien  <jfbastien@apple.com>
596
597         Add JF Bastien as reviewer
598         https://bugs.webkit.org/show_bug.cgi?id=170481
599
600         Reviewed by Mark Lam.
601
602         * Scripts/webkitpy/common/config/contributors.json:
603
604 2017-04-04  Jonathan Bedard  <jbedard@apple.com>
605
606         Increase timeouts for simulator testing
607
608         Unreviewed infrastructure fix.
609
610         * Scripts/webkitpy/port/simulator_process.py:
611         (SimulatorProcess._start): Increase timeout from 3 to 6 seconds.
612         * Scripts/webkitpy/xcode/simulated_device.py:
613         (SimulatedDevice.install_app): Increase timeout from 1 to 3 seconds.
614
615 2017-04-04  Tim Horton  <timothy_horton@apple.com>
616
617         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
618         https://bugs.webkit.org/show_bug.cgi?id=165801
619         <rdar://problem/29649535>
620
621         Reviewed by Wenson Hsieh.
622
623         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
624         (TEST):
625         Add some tests for wrapping finds.
626
627 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
628
629         Add some new patterns to filter-build-webkit
630         https://bugs.webkit.org/show_bug.cgi?id=170429
631
632         Reviewed by Alexey Proskuryakov.
633
634         * Scripts/filter-build-webkit:
635         (setOutputFormatOption):
636
637 2017-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
638
639         Data interaction should register type identifiers in order of priority
640         https://bugs.webkit.org/show_bug.cgi?id=170428
641         <rdar://problem/30633296>
642
643         Reviewed by Tim Horton.
644
645         Augments existing unit tests to check for the existence and priority of type identifiers in the UIItemProviders
646         created upon starting data interaction. Also fixes a race condition in one of the unit tests and adds a new unit
647         test for data interaction from a textarea to an input.
648
649         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
650         (checkTypeIdentifierPrecedesOtherTypeIdentifier):
651         (TestWebKitAPI::TEST):
652         * TestWebKitAPI/ios/DataInteractionSimulator.h:
653         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
654         (-[DataInteractionSimulator _advanceProgress]):
655         (-[DataInteractionSimulator sourceItemProviders]):
656         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
657
658 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
659
660         [GTK][JHBuild] Update mesa repository url for tarballs
661         https://bugs.webkit.org/show_bug.cgi?id=170431
662
663         Reviewed by Michael Catanzaro.
664
665         * gtk/jhbuild.modules:
666
667 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
668
669         TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
670         https://bugs.webkit.org/show_bug.cgi?id=170430
671
672         Reviewed by Alexey Proskuryakov.
673
674         * TestWebKitAPI/Tests/mac/Ahem.ttf: Removed.
675         Eliminate one of the copies of Ahem.ttf.
676
677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
678         Once eliminated, there is now only one Ahem.ttf that is copied
679         to the Resources bundle. Drive-by sort the project file.
680
681 2017-04-03  Simon Fraser  <simon.fraser@apple.com>
682
683         Allow MiniBrowser windows to receive local file drags again
684         https://bugs.webkit.org/show_bug.cgi?id=170422
685
686         Reviewed by Wenson Hsieh.
687
688         Adopt the new UIDelegate SPI to allow drops.
689
690         * MiniBrowser/mac/WK2BrowserWindowController.m:
691         (-[WK2BrowserWindowController _webView:dragDestinationActionMaskForDraggingInfo:]):
692
693 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
694
695         [GTK][JHBuild] Fetch libvpx from a release tarball instead of git
696         https://bugs.webkit.org/show_bug.cgi?id=170426
697
698         Reviewed by Michael Catanzaro.
699
700         * gtk/jhbuild.modules:
701
702 2017-04-03  Nan Wang  <n_wang@apple.com>
703
704         AX: Expose link children when doing search predication on iOS
705         https://bugs.webkit.org/show_bug.cgi?id=170424
706         <rdar://problem/31413335>
707
708         Reviewed by Chris Fleizach.
709
710         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
711         (AccessibilityUIElement::uiElementForSearchPredicate):
712         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
713         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
714
715 2017-04-03  Brian Burg  <bburg@apple.com>
716
717         run-safari should support launching with custom language and locale
718         https://bugs.webkit.org/show_bug.cgi?id=170397
719
720         Reviewed by Alexey Proskuryakov.
721
722         Hook up -AppleLanguages and -AppleLocale to command line options.
723
724         * Scripts/webkitdirs.pm:
725         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
726         (argumentsForRunAndDebugMacWebKitApp):
727
728 2017-04-03  Jonathan Bedard  <jbedard@apple.com>
729
730         webkitpy: Provide option to skip install
731         https://bugs.webkit.org/show_bug.cgi?id=170344
732
733         Reviewed by Alexey Proskuryakov.
734
735         Installing can take time for on device testing.  Provide an option to skip install
736         and use whatever driver is currently installed on the device or simulator.
737
738         * Scripts/webkitpy/port/base.py:
739         (Port.check_build): Do not check driver if skipping install.
740         * Scripts/webkitpy/port/factory.py:
741         (platform_options): Add '--no-install' option.
742         * Scripts/webkitpy/port/ios.py:
743         (IOSPort.setup_test_run): Check install option before installing.
744
745 2017-04-03  Keith Miller  <keith_miller@apple.com>
746
747         WebAssembly: Update spec tests
748         https://bugs.webkit.org/show_bug.cgi?id=170361
749
750         Rubber-stamped by Saam Barati.
751
752         Update the runner to know the new wasm spec test harness code.
753
754         * Scripts/run-jsc-stress-tests:
755
756 2017-04-01  Alexey Proskuryakov  <ap@apple.com>
757
758         Rolling back <https://trac.webkit.org/r214697>, as it made WebKit2.DataDetectionReferenceDate time out.
759
760         Was REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
761         https://bugs.webkit.org/show_bug.cgi?id=170365
762
763         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
764
765 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
766
767         Mac cmake buildfix after 214586.
768         https://bugs.webkit.org/show_bug.cgi?id=170381
769
770         Unreviewed speculative buildfix.
771
772         * WebKitTestRunner/PlatformMac.cmake:
773
774 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
775
776         Unreviewed speculative Mac cmake buildfix after r214586, just for fun.
777         https://bugs.webkit.org/show_bug.cgi?id=161675
778
779         * WebKitTestRunner/PlatformMac.cmake:
780
781 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
782
783         webkitpy: Add target host concept
784         https://bugs.webkit.org/show_bug.cgi?id=170186
785         <rdar://problem/31301797>
786
787         Reviewed by Alexey Proskuryakov.
788
789         Adding the idea of a target host. Target hosts are objects conforming to the
790         structure of the SystemHost object in Scripts/webkitpy/common/system/systemhost.py
791         Target hosts are the hosts associated with a worker process.
792
793         * Scripts/webkitpy/common/system/filesystem.py:
794         (FileSystem.map_base_host_path): Convert a path from an absolute path on the base
795         host to an absolute path on this host.
796         (FileSystem.move_to_base_host): Move file from this host to the base host.
797         (FileSystem.move_from_base_host): Move file from the base host to this host.
798         (FileSystem.copy_to_base_host): Copy file from this host to the base host.
799         (FileSystem.copy_from_base_host): Copy file from the base host to this host.
800         * Scripts/webkitpy/common/system/filesystem_mock.py:
801         (MockFileSystem.map_base_host_path): Convert a path from an absolute path on the base
802         host to an absolute path on this host.
803         (MockFileSystem.move_to_base_host): Move file from this host to the base host.
804         (MockFileSystem.move_from_base_host): Move file from the base host to this host.
805         (MockFileSystem.copy_to_base_host): Copy file from this host to the base host.
806         (MockFileSystem.copy_from_base_host): Copy file from the base host to this host.
807         * Scripts/webkitpy/port/base.py:
808         (Port.target_host): Return host determined by worker number.
809         (Port.abspath_for_test): Accept optional target_host argument to return location
810         of test on a target host.
811         (Port._driver_tempdir): Accept optional target_host argument to return a temporary
812         directory on a target host.
813         (Port.sample_process): Accept optional target_host argument to sample process on
814         a target host.
815         * Scripts/webkitpy/port/darwin.py:
816         (DarwinPort.sample_process): Run sample process on target host.
817         (DarwinPort.sample_file_path): Accept directory for file.
818         (DarwinPort.spindump_file_path): Ditto.
819         * Scripts/webkitpy/port/darwin_testcase.py:
820         (DarwinTest.test_spindump): Check file movement.
821         (DarwinTest.test_sample_process): Ditto.
822         (DarwinTest.test_sample_process_exception):
823         * Scripts/webkitpy/port/driver.py:
824         (Driver.__init__): Add and set self._target_host variable.
825         (Driver._start): Pass target host to _driver_tempdir().
826         (Driver.stop): Call the target host's rmtree.
827         (Driver._check_for_driver_timeout): Pass target host to sample_process.
828         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
829         (Driver._command_from_driver_input): Pass target host to abspath_for_test and map
830         layout test directory to target host.
831         * Scripts/webkitpy/port/ios.py:
832         (IOSPort):
833         (IOSPort.target_host): Replaced device_for_worker_number.
834         (IOSPort.setup_test_run): Replace device_for_worker_number with target_host.
835         (IOSPort.device_for_worker_number): Replaced with target_host.
836         * Scripts/webkitpy/port/server_process.py:
837         (ServerProcess.__init__): Accept target_host instead of worker_number.
838         (ServerProcess._start): Replace _host with _target_host.
839         (ServerProcess._handle_timeout): Ditto.
840         (ServerProcess._kill): Ditto.
841         * Scripts/webkitpy/port/simulator_process.py:
842         (SimulatorProcess.__init__): Accept target_host instead of worker_number.
843         (SimulatorProcess._start): Replace _device with _target_host.
844         (SimulatorProcess.stop): Ditto.
845         (SimulatorProcess._kill): Deleted.
846
847 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
848
849         Unreviewed fix after r214569
850         https://bugs.webkit.org/show_bug.cgi?id=170255
851
852         Unreviewed infrastructure fix.
853
854         * Scripts/webkitpy/port/ios.py:
855         (IOSPort.clean_up_test_run): Check if the device is defined before teardown.
856
857 2017-03-31  Andy Estes  <aestes@apple.com>
858
859         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
860         https://bugs.webkit.org/show_bug.cgi?id=170365
861         <rdar://problem/29205721>
862
863         Reviewed by Tim Horton.
864
865         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
866         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
867         (TEST): Re-enabled the test, which now passes.
868
869 2017-03-31  Tim Horton  <timothy_horton@apple.com>
870
871         Mail can get stuck underneath FindController::findStringMatches after searching in a long message
872         https://bugs.webkit.org/show_bug.cgi?id=170326
873         <rdar://problem/30330395>
874
875         Reviewed by Simon Fraser.
876
877         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
878         (TEST):
879
880 2017-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
881
882         Unreviewed. Fix WTR crashes in GTK+ port after r214413.
883
884         Fixes: http/tests/ssl/upgrade-origin-usage.html
885                http/tests/websocket/tests/hybi/network-process-crash-error.html
886                http/tests/websocket/tests/hybi/simple-wss.html
887
888         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
889         (WTR::TestController::platformContext): Return the context.
890
891 2017-03-30  Sam Weinig  <sam@webkit.org>
892
893         Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI
894         https://bugs.webkit.org/show_bug.cgi?id=170315
895
896         Reviewed by Simon Fraser.
897
898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
899         * TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Added.
900         Add test showing the completion handler is called.
901
902 2017-03-30  Filip Pizlo  <fpizlo@apple.com>
903
904         Air should support linear scan for optLevel<2
905         https://bugs.webkit.org/show_bug.cgi?id=170161
906
907         Reviewed by Saam Barati.
908         
909         This makes us run a bunch of JS tests at optLevel=1 to force testing of this new compiler
910         pipeline.
911
912         * Scripts/run-jsc-stress-tests:
913
914 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
915
916         Support tvOS and watchOS in webkitdirs.pm
917         https://bugs.webkit.org/show_bug.cgi?id=170267
918
919         Reviewed by Alexey Proskuryakov.
920
921         * Scripts/webkitdirs.pm:
922         (determineXcodeSDK): Evaluate sdk for tvos and watchos.
923         (xcodeSDKPlatformName): Added support for tvos and watchos.
924         (determinePortName): Same.
925         (isAppleCocoaWebKit): Same.
926         (willUseAppleTVDeviceSDK): Added.
927         (willUseAppleTVSimulatorSDK): Added.
928         (willUseWatchDeviceSDK): Added.
929         (willUseWatchSimulatorSDK): Added.
930         (isTVOSWebKit): Added.
931         (isWATCHOSWebKit): Added.
932         (isIOSLikeWebKit): Added.
933
934 2017-03-30  Wenson Hsieh  <wenson_hsieh@apple.com>
935
936         [WK2] Touches should not cancel when showing a custom action sheet while data interaction is active
937         https://bugs.webkit.org/show_bug.cgi?id=170291
938         <rdar://problem/31301388>
939
940         Reviewed by Tim Horton.
941
942         Adds support for testing how the custom action sheet presentation codepath interacts with data interaction, as
943         well as a new unit test. In this case, we force data interaction to fail if touches are canceled on the
944         shared UIApplication, and verify that data interaction completes successfully.
945
946         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
947         (TestWebKitAPI::TEST):
948         * TestWebKitAPI/ios/DataInteractionSimulator.h:
949         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
950         (-[DataInteractionSimulatorApplication _cancelAllTouches]):
951         (-[DataInteractionSimulator initWithWebView:]):
952         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
953         (-[DataInteractionSimulator runFrom:to:]):
954         (-[DataInteractionSimulator _advanceProgress]):
955         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
956
957 2017-03-30  Per Arne Vollan  <pvollan@apple.com>
958
959         [Win] Pass close_fds = True in Python popen call.
960         https://bugs.webkit.org/show_bug.cgi?id=170172
961
962         Reviewed by Brent Fulgham.
963
964         This was previously not supported on Windows, but in Python 2.7.10 it is.
965
966         * Scripts/webkitpy/common/system/executive.py:
967         (Executive._should_close_fds):
968         * Scripts/webkitpy/port/server_process.py:
969         (ServerProcess._start):
970
971 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
972
973         Change my status to be a WebKit reviewer.
974
975         Unreviewed status update edit.
976
977         * Scripts/webkitpy/common/config/contributors.json:
978
979 2017-03-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
980
981         Change my status to be a WebKit reviewer.
982
983         Unreviewed status update edit.
984
985         * Scripts/webkitpy/common/config/contributors.json:
986
987 2017-03-29  Tim Horton  <timothy_horton@apple.com>
988
989         Swipe gesture tests don't work on macOS Sierra
990         https://bugs.webkit.org/show_bug.cgi?id=161675
991         <rdar://problem/23379930>
992
993         Reviewed by Darin Adler.
994
995         * DumpRenderTree/mac/UIScriptControllerMac.mm:
996         (WTR::UIScriptController::platformPlayBackEventStream):
997         (WTR::UIScriptController::beginBackSwipe):
998         (WTR::UIScriptController::completeBackSwipe):
999         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h: Copied from Tools/DumpRenderTree/mac/UIScriptControllerMac.mm.
1000         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm: Added.
1001         (eventIsOfType):
1002         (eventIsOfTypes):
1003         (eventIsOfGestureType):
1004         (eventIsOfGestureTypes):
1005         (+[EventSerializer dictionaryForEvent:relativeToTime:]):
1006         (+[EventSerializer createEventForDictionary:inWindow:relativeToTime:]):
1007         (+[EventSerializer playEventStream:inWindow:completionHandler:]):
1008         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.h: Copied from Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm.
1009         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm: Added.
1010         (beginSwipeBackEventStream):
1011         (completeSwipeBackEventStream):
1012         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1013         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1014         (WTR::UIScriptController::playBackEventStream):
1015         (WTR::UIScriptController::beginBackSwipe):
1016         (WTR::UIScriptController::completeBackSwipe):
1017         (WTR::UIScriptController::platformPlayBackEventStream):
1018         (WTR::UIScriptController::platformClearAllCallbacks): Deleted.
1019         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1020         * TestRunnerShared/spi/CoreGraphicsSPI.h: Added.
1021         * TestRunnerShared/spi/IOKitSPI.h: Renamed from Tools/WebKitTestRunner/ios/IOKitSPI.h.
1022         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1023         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1024         (WTR::playBackEvents):
1025         (WTR::UIScriptController::beginBackSwipe):
1026         (WTR::UIScriptController::completeBackSwipe):
1027         (WTR::UIScriptController::platformPlayBackEventStream):
1028
1029 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
1030
1031         webkitpy: Robust test clean-up
1032         https://bugs.webkit.org/show_bug.cgi?id=170255
1033
1034         Reviewed by Alexey Proskuryakov.
1035
1036         On-device testing is the motivation for this change.  Failure to run clean-up functions can
1037         result in zombie processes, residual NFS mounts and other undesirable remnants from a failed
1038         test run.  Make an effort to clean-up even if exceptions are thrown during set-up or clean-up.
1039
1040         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1041         (Manager._set_up_run): Clean up test run if set-up fails.
1042         * Scripts/webkitpy/port/ios.py:
1043         (IOSPort.clean_up_test_run): Continue cleaning up devices even after an exception is thrown.
1044
1045 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
1046
1047         Simulator testing stops after the first crash
1048         <rdar://problem/31325362>
1049
1050         Unreviewed infrastructure fix.
1051
1052         * Scripts/webkitpy/xcode/simulated_device.py:
1053         (SimulatedDevice):
1054         (SimulatedDevice.launch_app): Increase timeout when attempting to launch app.
1055
1056 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
1057
1058         webkitpy: Standardize web-server port definitions
1059         https://bugs.webkit.org/show_bug.cgi?id=170144
1060         <rdar://problem/31284026>
1061
1062         Reviewed by Daniel Bates.
1063
1064         Default web-server ports should be declared in global variables.
1065         Add functions to web-servers which return the ports these servers
1066         are using so that other tools can forward them.
1067
1068         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1069         (LayoutTestApacheHttpd.__init__): Use shared constants in http_server_base.py.
1070         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1071         (TestLayoutTestApacheHttpd.test_start_cmd): Check port_to_forward for expected values.
1072         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1073         (Lighttpd.__init__): Use shared constants in http_server_base.py.
1074         (Lighttpd._prepare_config): Ditto.
1075         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1076         (HttpServerBase): Add default port constants.
1077         (HttpServerBase.ports_to_forward): Add function to return ports used for http server.
1078         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1079         (TestHttpServer.test_start_cmd): Check port_to_forward for expected values.
1080         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1081          (WebPlatformTestServer.ports_to_forward): Add function to return ports used for web-platform tests.
1082         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1083         (PyWebSocket): Make default port values public.
1084         (PyWebSocket.__init__): Use public default port.
1085         (PyWebSocket.ports_to_forward): Return port used in an array.
1086         * Scripts/webkitpy/port/base.py:
1087         (Port.to.ports_to_forward): Return all ports used the various web-servers managed by the port object.
1088         (Port.to.start_websocket_server): Use PyWebSocket port constants.
1089
1090 2017-03-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1091
1092         Links with empty hrefs should not be drag sources
1093         https://bugs.webkit.org/show_bug.cgi?id=170241
1094         <rdar://problem/31305505>
1095
1096         Reviewed by Tim Horton.
1097
1098         Adds a new API test: DataInteractionTests.LinkWithEmptyHREF.
1099
1100         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1101         (TestWebKitAPI::TEST):
1102         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1103
1104         Expose the current phase of the data interaction simulator for verifying behaviors in unit tests.
1105
1106         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1107         (-[DataInteractionSimulator phase]):
1108
1109 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
1110
1111         Use TCP instead of FIFOs for Simulator/Device communication
1112         https://bugs.webkit.org/show_bug.cgi?id=169419
1113         <rdar://problem/30949615>
1114
1115         Reviewed by Alexey Proskuryakov.
1116
1117         Using TCP instead of FIFOs when communicating with devices allows the device being tested
1118         to be on a different machine then the one handling the management of the test run.
1119
1120         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1121         * DumpRenderTree/mac/DumpRenderTree.mm:
1122         (dumpRenderTree): Call setUp/tearDownIOSLayoutTestCommunication() instead of using FIFOs.
1123         * Scripts/webkitpy/port/device.py:
1124         (Device.__init__): Initialize the listening_socket.
1125         (Device.listening_port): Return port of listening socket.
1126         (Device.prepare_for_testing): Open listening socket on an open port, prepare platform device
1127         fro testing.
1128         (Device.finished_testing): Close listening socket associated with this device, call the
1129         platform device's finished_testing function if it exists.
1130         * Scripts/webkitpy/port/ios.py:
1131         (IOSPort.setup_test_run): Prepare each device for testing.
1132         (IOSPort.clean_up_test_run): Notify each device that testing has completed.
1133         * Scripts/webkitpy/port/ios_simulator.py:
1134         (IOSSimulatorPort): Work around device persistence bug.
1135         (IOSSimulatorPort.__init__): Ditto.
1136         * Scripts/webkitpy/port/simulator_process.py:
1137         (SimulatorProcess):
1138         (SimulatorProcess.NonBlockingFileFromSocket): Add to work around shortcomings in
1139         Python 2’s makefile.
1140         (SimulatorProcess.NonBlockingFileFromSocket.__init__): Initialize file with socket.
1141         (SimulatorProcess.ReadFileSocket.close): Close file and then socket;
1142         (SimulatorProcess.__init__): Pass TCP port over environment, remove FIFO names.
1143         (SimulatorProcess.__getattr__): Expose all file attributes.
1144         (SimulatorProcess._accept_connection_create_file): Wait for connection from server and
1145         create and return a file-like object from the incoming connection.
1146         (SimulatorProcess._start): Use TCP connections instead of FIFOs.
1147         (SimulatorProcess._start.handler): Output server port in timeout exception.
1148         (SimulatorProcess._reset): Deleted.
1149         * TestRunnerShared/IOSLayoutTestCommunication.cpp: Added.
1150         (connectToServer): Return socket connected to the provided server address.
1151         (setupiOSLayoutTestCommunication): Connect stdin, stdout and stderr as socket to a
1152         TCP server running on localhost.
1153         (tearDownIOSLayoutTestCommunication): Close stdin, stdout and stderr TCP sockets.
1154         * TestRunnerShared/IOSLayoutTestCommunication.h: Added.
1155         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1156         * WebKitTestRunner/ios/TestControllerIOS.mm:
1157         (WTR::TestController::platformInitialize): Call setUpIOSLayoutTestCommunication()
1158         instead of using FIFOs.
1159         (WTR::TestController::platformDestroy): Call tearDownIOSLayoutTestCommunication().
1160
1161 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
1162
1163         webkitpy: Add IOSDevicePort and IOSPort tests
1164         https://bugs.webkit.org/show_bug.cgi?id=170206
1165         <rdar://problem/31308364>
1166
1167         Reviewed by Alexey Proskuryakov.
1168
1169         * Scripts/webkitpy/port/darwin_testcase.py: Removed unused import.
1170         * Scripts/webkitpy/port/ios_device_unittest.py: Added.
1171         (iosDeviceTest): Contains tests for the IOSDevicePort.
1172         (iosDeviceTest.make_port): Creates an IOSDevicePort with arguments.
1173         (iosDeviceTest.test_operating_system): Check for the correct operating system.
1174         * Scripts/webkitpy/port/ios_simulator_unittest.py: Moved from Tools/Scripts/webkitpy/port/ios_unittest.py.
1175         (iosSimulatorTest): Inherit from ios_testcase.
1176         (iosSimulatorTest.make_port): Ditto.
1177         (iosSimulatorTest.test_get_crash_log): Ditto.
1178         * Scripts/webkitpy/port/ios_testcase.py: Added.
1179         (iOSTest): Contains shared tests for the IOSDevicePort and IOSSimulatorPort.
1180         (iOSTest.test_driver_name): Tests for iOS app driver.
1181         (iOSTest.test_baseline_searchpath): Check that ios and ios-wk1 are in the baseline search path.
1182         * Scripts/webkitpy/port/ios_unittest.py: Moved to ios_simulator_unittest.py.
1183         * Scripts/webkitpy/port/port_testcase.py:
1184         (PortTestCase): Rename is_simulator to disable_setup to more accurately describe it's meaning.
1185         (PortTestCase.test_diff_image): Use disable_setup instead of is_simulator.
1186         (PortTestCase.test_diff_image_crashed): Ditto.
1187
1188 2017-03-28  Jason Marcell  <jmarcell@apple.com>
1189
1190         Fix `index-expected.txt` for dashboard test results.
1191         https://bugs.webkit.org/show_bug.cgi?id=170214
1192
1193         Reviewed by Alexey Proskuryakov.
1194
1195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt:
1196
1197 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
1198
1199         Bot watcher's dashboard has separate settings for "mac" and "macos"
1200         https://bugs.webkit.org/show_bug.cgi?id=170164
1201
1202         Reviewed by Tim Horton.
1203
1204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1205         (Settings.prototype.parsePlatformFamily): Aded a special case for "macos".
1206
1207 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
1208
1209         Fix dashboard test results on the dashboard
1210         https://bugs.webkit.org/show_bug.cgi?id=170158
1211
1212         Reviewed by Tim Horton.
1213
1214         Link to result diff instead of stdio. Looking at the diff, I wonder if it can be
1215         further improved, as it's not super readable, but stdio is entirely useless in this context.
1216
1217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1218         (Buildbot.prototype.dashboardTestResultsURLForIteration): Generate formatted diff link.
1219
1220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1221         Fixed a typo in step name, so that it's actually treated as productive.
1222
1223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1224         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
1225         (BuildbotTesterQueueView.prototype.update):
1226         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1227         Added special handling for dashboard test results.
1228
1229 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
1230
1231         Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
1232         https://bugs.webkit.org/show_bug.cgi?id=170193
1233
1234         Reviewed by Alexey Proskuryakov.
1235
1236         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1237         Fixed the order of arguments.
1238
1239 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
1240
1241         Dashboard tests fails to fetch the revision from commits
1242         https://bugs.webkit.org/show_bug.cgi?id=170191
1243
1244         Reviewed by Alexey Proskuryakov.
1245
1246         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1247         Added recordedCommitIndicesByRevisionNumber.
1248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1249         (setup): Populated trac.recordedCommitIndicesByRevisionNumber since the dashboard code uses this variable.
1250
1251 2017-03-28  Timothy Horton  <timothy_horton@apple.com>
1252
1253         Safari crashes when attempting to close tab that is displaying PDF
1254         https://bugs.webkit.org/show_bug.cgi?id=170201
1255         <rdar://problem/31242019>
1256
1257         Reviewed by Wenson Hsieh.
1258
1259         * TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
1260         (TEST):
1261         Add a test for doAfterNextStablePresentationUpdate just like the existing
1262         non-stable one.
1263
1264 2017-03-28  Jonathan Bedard  <jbedard@apple.com>
1265
1266         webkitpy: Use host pattern for devices
1267         https://bugs.webkit.org/show_bug.cgi?id=170121
1268
1269         Reviewed by Daniel Bates.
1270
1271         Devices should be treated like hosts throughout webkitpy
1272         so that more code can be re-used.  Add the needed properties
1273         and use executive over custom implemented polling/killing
1274         functions.
1275
1276         * Scripts/webkitpy/port/device.py:
1277         (Device):
1278         (Device.executive): Add optional executive property.
1279         (Device.filesystem): Add optional filesystem property.
1280         (Device.user): Add optional user property.
1281         (Device.platform): Add optional platform property.
1282         (Device.workspace): Add optional workspace property.
1283         (Device.poll): Deleted.
1284         * Scripts/webkitpy/port/simulator_process.py:
1285         (SimulatorProcess.Popen.poll): Use the devices executive.
1286         (SimulatorProcess.stop): Ditto.
1287         (SimulatorProcess._kill): Ditto.
1288         * Scripts/webkitpy/xcode/simulated_device.py:
1289         (SimulatedDevice.__init__): Add executive, filesystem, user, platform
1290         and workspace to the platform device.
1291         (SimulatedDevice.poll): Deleted.
1292
1293 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
1294
1295         Dashboard test fails with error: latestIterationGetter is not a function
1296         https://bugs.webkit.org/show_bug.cgi?id=170167
1297
1298         Reviewed by Alexey Proskuryakov.
1299
1300         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1301         (this.view._latestProductiveIteration): Configure _latestProductiveIteration in setup.
1302
1303 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1304
1305         Another test v8.
1306
1307 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1308
1309         Another test v7.
1310
1311 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1312
1313         Another test v6.
1314
1315 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1316
1317         Another test v5.
1318
1319 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1320
1321         Another test v4.
1322
1323 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1324
1325         Another test v3.
1326
1327 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1328
1329         Another test v2.
1330
1331 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1332
1333         Another test.
1334
1335 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1336
1337         <rdar://problem/30949128>
1338         Update build.webkit.org to use port 16000 for PBChangeSource.
1339         
1340         Reviewed by Alexey Proskuryakov.
1341
1342         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1343
1344 2017-03-27  Jason Marcell  <jmarcell@apple.com>
1345
1346         Bots should run the dashboard tests
1347         https://bugs.webkit.org/show_bug.cgi?id=168994
1348
1349         Reviewed by Daniel Bates and David Kilzer.
1350
1351         We pull the `--results-directory` argument value out so that `RunDashboardTests` can override it so that we can separately run the dashboard layout tests.
1352
1353         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1354         (RunWebKitTests): Define a class variable called resultDirectory for the `--results-directory` argument so that subclasses can override this if needed.
1355         (RunWebKitTests.start): Set the `--results-directory` argument value to the value of self.resultDirectory.
1356         (RunDashboardTests): Subclass of RunWebKitTests in which we run the layout tests for the Bot Watcher's Dashboard.
1357         (RunDashboardTests.start): Override the `--layout-tests-directory` to point to the dashboard layout tests.
1358         (ExtractTestResults.addCustomURLs): Update the current results URL label to indicate that it links to layout tests results and add a new link to link to dashboard layout test results.
1359         (TestFactory.__init__): Update unit tests to account for new RunDashboardTests step.
1360         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1362
1363 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
1364
1365         webkitpy: Look for 'ios' test expectations for IOSPorts
1366         https://bugs.webkit.org/show_bug.cgi?id=169413
1367
1368         Reviewed by Alexey Proskuryakov.
1369
1370         Test expectations for iOS tests should include the 'ios' folder.  Modify
1371         default_baseline_search_path to include 'ios' folder and derivatives for
1372         IOSPort.
1373
1374         * Scripts/webkitpy/port/ios.py:
1375         (IOSPort._generate_all_test_configurations): Moved from IOSSimulatorPort.
1376         (IOSPort.default_baseline_search_path): Add ios expectations along with port specific expectations.
1377         (IOSPort.test_expectations_file_position): Added for testing.
1378         * Scripts/webkitpy/port/ios_simulator.py:
1379         (IOSSimulatorPort._generate_all_test_configurations): Moved to IOSPort.
1380         (IOSSimulatorPort.default_baseline_search_path): Moved to IOSPort.
1381
1382 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
1383
1384         REGRESSION: Reseting _device_map on each child process
1385         <rdar://problem/31274476>
1386
1387         Unreviewed infrastructure fix.
1388
1389         * Scripts/webkitpy/port/ios_simulator.py:
1390         (IOSSimulatorPort): Add _DEVICE_MAP class variable.
1391         (IOSSimulatorPort.__init__): Use shared class variable
1392         (IOSSimulatorPort._device_for_worker_number_map): Use _DEVICE_MAP class variable
1393         (IOSSimulatorPort._create_devices): Ditto.
1394         (IOSSimulatorPort._quit_ios_simulator): Ditto.
1395         (IOSSimulatorPort.clean_up_test_run): Ditto.
1396
1397 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
1398
1399         REGRESSION: Failing to iterate over Simulator.managed_devices map
1400         <rdar://problem/31274476>
1401
1402         Unreviewed infrastructure fix.
1403
1404         * Scripts/webkitpy/port/ios_simulator.py:
1405         (IOSSimulatorPort._create_devices): Iterate through managed_devices by worker number.
1406
1407 2017-03-27  Alex Christensen  <achristensen@webkit.org>
1408
1409         Make WebSockets work in network process
1410         https://bugs.webkit.org/show_bug.cgi?id=169930
1411
1412         Reviewed by Youenn Fablet.
1413
1414         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1415         Add terminateNetworkProcess for the new test
1416         http/tests/websocket/tests/hybi/network-process-crash-error.html
1417         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1418         (WTR::TestRunner::setAllowsAnySSLCertificate):
1419         (WTR::TestRunner::terminateNetworkProcess):
1420         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1421         * WebKitTestRunner/TestController.cpp:
1422         (WTR::TestController::setAllowsAnySSLCertificate):
1423         (WTR::TestController::terminateNetworkProcess):
1424         * WebKitTestRunner/TestController.h:
1425         * WebKitTestRunner/TestInvocation.cpp:
1426         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1427         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1428         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1429         (WTR::TestController::platformContext):
1430         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1431         (WTR::TestController::platformContext):
1432         (WTR::TestController::platformLibraryPathForTesting):
1433         Add some infrastructure for http/tests/websocket/tests/hybi/simple-wss.html
1434         which calls testRunner.setAllowsAnySSLCertificate.  It used to only be effective
1435         for the WebProcess, but SocketStreamHandleImpl::createStreams is now in the NetworkProcess,
1436         and we need its call to Settings::allowsAnySSLCertificate to be loosened for this test,
1437         which tests that wss works, but our test certificate has an invalid certificate chain.
1438         We want production software to not have the ability to have its security weakened, so this
1439         is a test code path that is only implemented in WebKitTestRunner.
1440
1441 2017-03-25  Jonathan Bedard  <jbedard@apple.com>
1442
1443         webkitpy: Use generalized device instead of platform specific one
1444         https://bugs.webkit.org/show_bug.cgi?id=170078
1445
1446         Reviewed by Daniel Bates.
1447
1448         SimulatedDevice is re-created each time 'xcrun simctl list' is called.  Device
1449         should remain persistent.  Changing Device to a more explicit interface.
1450         SimulatedDevice no longer inherits from Device and IOSSimulator returns Devices
1451         wrapping SimulatedDevices.
1452
1453         * Scripts/webkitpy/port/device.py: Added.
1454         (Device):
1455         (Device.__init__): Construct with platform device.
1456         (Device.install_app): Install app at app path on platform device.
1457         (Device.launch_app): Launch app with bundle ID on platform device.
1458         (Device.poll): Poll platform device.
1459         (Device.udid): Access platform device UDID.
1460         (Device.__nonzero__): Check if instantiated with a valid platform device.
1461         (Device.__eq__): Compare by udid.
1462         (Device.__ne__): Ditto.
1463         (Device.__repr__): Print out platform_device representation.
1464         * Scripts/webkitpy/port/ios_simulator.py:
1465         (IOSSimulatorPort.__init__): Initialize the _device_map to an empty dictionary.
1466         (IOSSimulatorPort._device_for_worker_number_map):  Return self._device_map.
1467         (IOSSimulatorPort._create_simulators): Call Simulator.managed_devices directly.
1468         (IOSSimulatorPort._create_devices): Place Simulator.managed_devices into the
1469         device map.
1470         (IOSSimulatorPort._quit_ios_simulator): Reset self._device_map.
1471         * Scripts/webkitpy/xcode/device.py: Removed.
1472         * Scripts/webkitpy/xcode/simulated_device.py:
1473         (SimulatedDevice):
1474         (SimulatedDevice.__init__): Move host, name and did to SimulatedDevice.
1475         (SimulatedDevice.__eq__): Compare two simulated devices.
1476         (SimulatedDevice.__ne__): Ditto.
1477         (SimulatedDevice.__repr__): Print name and udid.
1478
1479 2017-03-25  Adrian Perez de Castro  <aperez@igalia.com>
1480
1481         [GTK] No value returned from PrintCustomWidgetTest::createWebKitPrintOperation() in TestPrinting.cpp
1482         https://bugs.webkit.org/show_bug.cgi?id=170059
1483
1484         Reviewed by Carlos Garcia Campos.
1485
1486         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Use "void" as return type in the declaration,
1487         the only use of the method in this same file ignores the returned value anyway.
1488
1489 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1490
1491         webkitpy should be able to run API tests
1492         https://bugs.webkit.org/show_bug.cgi?id=170028
1493
1494         Reviewed by Alexey Proskuryakov.
1495
1496         * Scripts/webkitpy/common/config/ports.py:
1497         (DeprecatedPort.run_api_tests_command): Added.
1498         * Scripts/webkitpy/port/base.py:
1499         (Port.api_results_directory): Added.
1500         * Scripts/webkitpy/tool/steps/runtests.py:
1501         (RunTests.run): Check if we should be running API tests.
1502         (RunTests._run_api_tests): Generate script to run API tests with json output.
1503         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
1504
1505 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1506
1507         Add JSON results for API tests
1508         https://bugs.webkit.org/show_bug.cgi?id=170021
1509
1510         Reviewed by Alexey Proskuryakov.
1511
1512         * Scripts/run-api-tests:
1513         (runTestsBySuite): Appends failures and timeouts to JSON data.
1514         (writeJsonDataIfApplicable): Writes JSON data to a file.
1515
1516 2017-03-24  Lucas Forschler  <lforschler@apple.com>
1517
1518         update committer_auth.py to be python 2.7 compliant
1519         https://bugs.webkit.org/show_bug.cgi?id=170063
1520         
1521         Reviewed by Alexey Proskuryakov.
1522
1523         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
1524         (CommitterAuth.authenticate):
1525             convert e.message to e.args[0]
1526
1527 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1528
1529         webkitpy: Parse JSON results from run-api-tests
1530         https://bugs.webkit.org/show_bug.cgi?id=170062
1531
1532         Reviewed by Alexey Proskuryakov.
1533
1534         * Scripts/webkitpy/common/net/apitestresults.py: Added.
1535         (APITestResults): Structure to represent API test results.
1536         (APITestResults.__init__):
1537         (APITestResults.intersection): Return the failures common to both sets of results.
1538         (APITestResults.results_from_string): Create an APITestResults object from a JSON results string.
1539         (APITestResults.equals): Return True if both results were the same.
1540         (APITestResults.is_subset): Return True if failing tests are a subset of the other failing tests.
1541         (APITestResults.all_passed): Return True if everything passed.
1542         (APITestResults.failing_tests): List of tests that didn't pass.
1543         (APITestResults.did_exceed_test_failure_limit): Always False.
1544         * Scripts/webkitpy/common/net/apitestresults_unittest.py: Added.
1545         (APITestResultsTest): Unit tests.
1546         * Scripts/webkitpy/tool/bot/apitestresultsreader.py: Added.
1547         (APITestResultsReader): Read contents of JSON results file.
1548
1549 2017-03-24  Alex Christensen  <achristensen@webkit.org>
1550
1551         REGRESSION: Content Blocker: Blocking "a[href*=randomString]" doesn't work
1552         https://bugs.webkit.org/show_bug.cgi?id=169167
1553
1554         Reviewed by Simon Fraser.
1555
1556         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1557         (TestWebKitAPI::TEST_F):
1558         Test an example of a selector that was incorrectly determined to be invalid.
1559
1560 2017-03-24  Jonathan Bedard  <jbedard@apple.com>
1561
1562         Increase timeout for booting simulators.
1563         <rdar://problem/31080009>
1564
1565         Unreviewed infrastructure fix.
1566
1567         * Scripts/webkitpy/xcode/simulator.py:
1568         (Simulator.wait_until_device_is_booted): Increase timeout.
1569         (Simulator.wait_until_device_is_in_state): Increase timeout.
1570
1571 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1572
1573         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r214277.
1574
1575         Since r214277 beforeunload events are not fired unless there's some user interaction, so we need to simulate it
1576         in our unit tests to work.
1577
1578         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1579         (testWebViewJavaScriptDialogs):
1580
1581 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1582
1583         [GTK] Add MIMETypeRegistry implementation using xdgmime and remove the GTK+ one
1584         https://bugs.webkit.org/show_bug.cgi?id=170001
1585
1586         Reviewed by Michael Catanzaro.
1587
1588         Ignore style of xdgmime sources.
1589
1590         * Scripts/webkitpy/tool/steps/checkstyle.py:
1591
1592 2017-03-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1593
1594         Dragging on a large image should not revert to a file icon if data interaction is enabled
1595         https://bugs.webkit.org/show_bug.cgi?id=170018
1596         <rdar://problem/31184508>
1597
1598         Reviewed by Tim Horton.
1599
1600         Add new tests for data interaction. LargeImageToTargetDiv verifies the change made in this patch, while
1601         AttachmentElementItemProviders was a test that was previously removed due to <rdar://problem/31038797>.
1602
1603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1604         * TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Added.
1605         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1606         (TestWebKitAPI::TEST):
1607
1608 2017-03-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1609
1610         Update WinCairoRequirements.zip
1611         https://bugs.webkit.org/show_bug.cgi?id=169950
1612
1613         Reviewed by Alex Christensen.
1614
1615         * Scripts/update-webkit-wincairo-libs: Replace $winCairoLibsURL.
1616
1617 == Rolled over to ChangeLog-2017-03-23 ==