67c2bd71b7adbcda3c6f55d1d1cad7a6cf30fc33
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         Improve label text in submit-to-ews
6         https://bugs.webkit.org/show_bug.cgi?id=53130
7
8         * QueueStatusServer/templates/submittoews.html:
9
10 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
11
12         Reviewed by Antonio Gomes.
13
14         QtTestBrowser should have a UI Settings to prevent loading images
15         https://bugs.webkit.org/show_bug.cgi?id=52409
16         
17         Added a new action item named "DisableAutoLoadImages"
18         under the "Settings" menu 
19
20         * QtTestBrowser/launcherwindow.cpp:
21         (LauncherWindow::createChrome):
22         (LauncherWindow::toggleAutoLoadImages):
23         * QtTestBrowser/launcherwindow.h:
24
25 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
26
27         Reviewed by Tony Chang.
28
29         Minor bug fixes and cleanup for filesystem wrappers, port/* test
30         classes, test_expectations.py. This change adds "test-win" and
31         "test-mac" variants to the test port so that we can better test
32         rebaselining, and adds a MockUser() object for reuse in testing.
33
34         https://bugs.webkit.org/show_bug.cgi?id=53036
35
36         * Scripts/webkitpy/common/system/filesystem.py:
37         * Scripts/webkitpy/common/system/filesystem_mock.py:
38         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
39         * Scripts/webkitpy/layout_tests/port/factory.py:
40         * Scripts/webkitpy/layout_tests/port/base.py:
41         * Scripts/webkitpy/layout_tests/port/test.py:
42         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
43         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
44         * Scripts/webkitpy/tool/mocktool.py:
45
46 2011-01-25  Tony Chang  <tony@chromium.org>
47
48         Reviewed by Dimitri Glazkov.
49
50         [chromium] remove unused layoutTestController callback
51         https://bugs.webkit.org/show_bug.cgi?id=53103
52
53         This method is used by a test_shell_test, but not needed by DRT.
54
55         * DumpRenderTree/chromium/LayoutTestController.cpp:
56         (LayoutTestController::LayoutTestController):
57         * DumpRenderTree/chromium/LayoutTestController.h:
58
59 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
60
61         Reviewed by Andreas Kling.
62
63         [GTK] Remove 64 bits release bot from the buildbot master
64         https://bugs.webkit.org/show_bug.cgi?id=52899
65
66         Removes the 64 bits release slave from the buildbot configuration,
67         so that we can use it as an EWS.
68
69         * BuildSlaveSupport/build.webkit.org-config/config.json:
70
71 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
72
73         Reviewed by Dan Bernstein.
74
75         Implement database quota callback to fix storage tests on WebKit2 bot
76         https://bugs.webkit.org/show_bug.cgi?id=53064
77
78         * WebKitTestRunner/TestController.cpp:
79         (WTR::exceededDatabaseQuota):
80         (WTR::TestController::createOtherPage):
81         (WTR::TestController::initialize):
82
83 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
84
85         Reviewed by Anders Carlsson.
86
87         Use designated temp directory for the database for WebKit2
88         https://bugs.webkit.org/show_bug.cgi?id=53052
89         
90         Adopt the new WK2 API for this.
91
92         * WebKitTestRunner/TestController.cpp:
93         (WTR::TestController::libraryPathForTesting):
94         (WTR::TestController::initialize):
95         * WebKitTestRunner/TestController.h:
96         * WebKitTestRunner/mac/TestControllerMac.mm:
97         (WTR::TestController::platformLibraryPathForTesting):
98         * WebKitTestRunner/qt/TestControllerQt.cpp:
99         (WTR::TestController::platformLibraryPathForTesting):
100         * WebKitTestRunner/win/TestControllerWin.cpp:
101         (WTR::TestController::platformLibraryPathForTesting):
102
103 2011-01-24  Lucas Forschler  <lforschler@apple.com>
104
105         Reviewed by Stephanie Lewis.
106
107         Add a new Leopard test bot.
108
109         * BuildSlaveSupport/build.webkit.org-config/config.json:
110
111 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
112
113         Reviewed by Adam Barth.
114
115         Add EFL Builder to core waterfall
116         https://bugs.webkit.org/show_bug.cgi?id=52704
117
118         Add EFL Builder to the core waterfall again.
119
120         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
121         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
122
123 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
124
125         Reviewed by Tony Chang.
126
127         new-run-webkit-tests fails to start HTTP server if there are proxy settings
128         https://bugs.webkit.org/show_bug.cgi?id=52872
129
130         Force disabling proxy to resolve the problem.
131
132         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
133         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
134
135 2011-01-24  Andreas Kling  <kling@webkit.org>
136
137         Reviewed by Darin Adler.
138
139         check-webkit-style: Update exemptions following Source/ move.
140         https://bugs.webkit.org/show_bug.cgi?id=53017
141
142         * Scripts/webkitpy/style/checker.py:
143         * Scripts/webkitpy/style/checker_unittest.py:
144
145 2011-01-24  Andras Becsi  <abecsi@webkit.org>
146
147         Rubber-stamped by Csaba Osztrogonác.
148
149         [Qt] Move project files into Source
150         https://bugs.webkit.org/show_bug.cgi?id=52891
151
152         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
153
154 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
155
156         Reviewed by Yury Semikhatsky.
157
158         Web Inspector: Find duplicate strings in localizedStrings.js
159
160         https://bugs.webkit.org/show_bug.cgi?id=53005
161
162         * Scripts/check-inspector-strings:
163
164 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
165
166         Reviewed by Andreas Kling.
167
168         [Qt] Regroup MiniBrowser's menubar and add open file action
169         https://bugs.webkit.org/show_bug.cgi?id=53000
170
171         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
172
173         * MiniBrowser/qt/BrowserWindow.cpp:
174         (BrowserWindow::BrowserWindow):
175         (BrowserWindow::openFile):
176         (BrowserWindow::~BrowserWindow):
177         * MiniBrowser/qt/BrowserWindow.h:
178
179 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
180
181         Unreviewed fix after r76496
182
183         [Qt] Move project files into Source
184         https://bugs.webkit.org/show_bug.cgi?id=52891
185
186         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
187         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
188         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
189
190 2011-01-24  Andras Becsi  <abecsi@webkit.org>
191
192         Reviewed by Csaba Osztrogonác.
193
194         [Qt] Move project files into Source
195         https://bugs.webkit.org/show_bug.cgi?id=52891
196
197         * DerivedSources.pro: Renamed from DerivedSources.pro.
198         * DumpRenderTree/qt/DumpRenderTree.pro:
199         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
200         * MiniBrowser/DerivedSources.pro:
201         * MiniBrowser/qt/MiniBrowser.pro:
202         * QtTestBrowser/QtTestBrowser.pro:
203         * Scripts/webkitdirs.pm:
204         * Tools.pro: Added.
205         * WebKitTestRunner/DerivedSources.pro:
206         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
207         * WebKitTestRunner/qt/WebKitTestRunner.pro:
208
209 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
210
211         Reviewed by Dan Bernstein.
212
213         Beefed up --threaded mode to catch even more kinds of errors.
214         https://bugs.webkit.org/show_bug.cgi?id=52971
215
216         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
217         context group to force JSC to mark multiple threads. (This used to be
218         the default, but it changed in SnowLeopard.)
219         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
220         to give threading mistakes more chances to show themselves.
221         (startJavaScriptThreads):
222         (stopJavaScriptThreads):
223
224 2011-01-22  Robert Hogan  <robert@webkit.org>
225
226         Reviewed by Andreas Kling.
227
228         [Qt] Support layoutTestController.addURLToRedirect()
229         https://bugs.webkit.org/show_bug.cgi?id=52956
230
231         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
232         (LayoutTestController::addURLToRedirect):
233         * DumpRenderTree/qt/LayoutTestControllerQt.h:
234
235 2011-01-22  Robert Hogan  <robert@webkit.org>
236
237         Reviewed by Kenneth Rohde Christiansen.
238
239         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
240         https://bugs.webkit.org/show_bug.cgi?id=49802
241
242         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
243         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
244         (WebCore::DumpRenderTree::open):
245
246 2011-01-21  Adam Barth  <abarth@webkit.org>
247
248         Reviewed by Maciej Stachowiak.
249
250         Disable mac_unittest.py that fails on some of the Mac bots
251         https://bugs.webkit.org/show_bug.cgi?id=52947
252
253         As noted in the comment, this test does not appear to be correct
254         because the function this test is testing returns different results
255         depending on which flavor of Mac the test is run on.  This patch
256         disable the test.  Hopefully we can re-enable the test once we've
257         probably insulated the test from its environment.
258
259         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
260
261 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
262
263         Reviewed by Mihai Parparita.
264
265         Fix bug introduced in r76322 that caused NRWT to not actually
266         read the Skipped files properly.
267
268         https://bugs.webkit.org/show_bug.cgi?id=52771
269
270         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
271         * Scripts/webkitpy/layout_tests/port/webkit.py:
272         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
273
274 2011-01-21  Sam Weinig  <sam@webkit.org>
275
276         Reviewed by Geoffrey Sean Garen and Mark Rowe.
277
278         WebKitTestRunner needs the HOME environment variable to be set.
279         <rdar://problem/8896573>
280
281         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
282         it exists.
283
284 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
285
286         Reviewed by Eric Seidel.
287
288         Suppress a few remaining integration tests so that none of the
289         layout_test unit tests ever read from the filesystem or launch
290         subprocesses that aren't part of the unit tests.
291
292         Also fix a minor bug in the printing unit tests that was
293         incorrectly relying on sys.argv.
294
295         https://bugs.webkit.org/show_bug.cgi?id=52863
296
297         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
298         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
299         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
300
301 2011-01-21  Darin Adler  <darin@apple.com>
302
303        Fix Mac build.
304
305         * MiniBrowser/mac/BrowserWindowController.m:
306         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
307
308 2011-01-20  Darin Adler  <darin@apple.com>
309
310         Reviewed by Dan Bernstein.
311
312         WebKit2: Implement showModalDialog
313         https://bugs.webkit.org/show_bug.cgi?id=52855
314
315         This fixes WebKitTestRunner to compile, but more work is probably
316         needed to get it to pass the tests.
317
318         * WebKitTestRunner/TestController.cpp:
319         (WTR::TestController::runModal): Added. Calls through to the
320         platform-specific version of runModal.
321         (WTR::TestController::createOtherPage): Changed to be a private
322         static member function so it can refer to runModal, which is
323         a private static member function.
324         (WTR::TestController::initialize): Pass 0 for the runModal
325         function since we don't need to run the main window modal.
326         I suspect this is wrong and will need to change.
327         * WebKitTestRunner/TestController.h: Added declarations for
328         the functions added above.
329         * WebKitTestRunner/mac/TestControllerMac.mm:
330         (WTR::TestController::runModal): Added. Untested implementation.
331         * WebKitTestRunner/qt/TestControllerQt.cpp:
332         (WTR::TestController::runModal): Added.
333         * WebKitTestRunner/win/TestControllerWin.cpp:
334         (WTR::TestController::runModal): Added.
335
336 2011-01-21  Eric Seidel  <eric@webkit.org>
337
338         Reviewed by Adam Barth.
339
340         Split Host object off from WebKitPatch for easier re-use
341         https://bugs.webkit.org/show_bug.cgi?id=52284
342
343         new-run-webkit-tests and other tools are eventually going to want one of these.
344         Basically you need to inherit from this class if you want to pretend to be a
345         self.tool object for Steps/Commands.
346
347         * Scripts/webkitpy/common/host.py: Added.
348         * Scripts/webkitpy/tool/main.py:
349
350 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
351
352         Reviewed by Adam Barth.
353
354         Disable the tests that start and stop the http server and web
355         server, so that we don't have to worry about port collisions on
356         the bots.
357
358         https://bugs.webkit.org/show_bug.cgi?id=52861
359
360         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
361
362 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
363
364         Reviewed by Eric Seidel.
365
366         nrwt: rewrite google_chrome_unittest to use mock filesystem.
367         
368         https://bugs.webkit.org/show_bug.cgi?id=52772
369         
370         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
371
372 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
373
374         Reviewed by Eric Siedel.
375
376         nrwt: clean up almost all remaining port references, remove
377         unnecessary import clauses. The only remaining references are
378         in places where a mock filesystem makes no sense or can't be
379         used, and in one routine in port/google_chrome_unittest that
380         I'll rewrite in a separate patch.
381
382         https://bugs.webkit.org/show_bug.cgi?id=52771
383
384         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
385         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
386         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
387         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
388         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
389         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
390         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
391         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
392         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
393         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
394         * Scripts/webkitpy/layout_tests/port/gtk.py:
395         * Scripts/webkitpy/layout_tests/port/mac.py:
396         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
397         * Scripts/webkitpy/layout_tests/port/qt.py:
398         * Scripts/webkitpy/layout_tests/port/webkit.py:
399         * Scripts/webkitpy/layout_tests/port/win.py:
400         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
401
402 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
403
404         Reviewed by Mihai Parparita.
405
406         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
407
408         https://bugs.webkit.org/show_bug.cgi?id=52762
409
410         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
411         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
412
413 2011-01-20  Tony Chang  <tony@chromium.org>
414
415         Reviewed by Ojan Vafai.
416
417         [chromium] fix the paths used for the rebaseline tool
418         https://bugs.webkit.org/show_bug.cgi?id=52857
419
420         Some of the bots were renamed so the path to grab the results zip
421         file has changed.
422
423         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
424
425 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
426
427         Reviewed by Tony Chang.
428
429         Fix bug introduced in r72688 / bug 52768 that broke the
430         generation of the output filename links in the results.html
431         output. Apparently none of the unit tests actually checked to
432         make sure the generated links were correct :(
433
434         https://bugs.webkit.org/show_bug.cgi?id=52854
435
436         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
437         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
438
439 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
440
441         Reviewed by Darin Adler.
442
443         https://bugs.webkit.org/show_bug.cgi?id=52849
444         Make window.print work with WebKit2
445
446         * MiniBrowser/mac/BrowserWindowController.m:
447         (-[BrowserWindowController awakeFromNib]):
448         * WebKitTestRunner/TestController.cpp:
449         (WTR::createOtherPage):
450         (WTR::TestController::initialize):
451         Added zeroes to WKPageUIClient structures to avoid build failures.
452
453 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
454
455         Reviewed by Eric Seidel.
456
457         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
458
459         https://bugs.webkit.org/show_bug.cgi?id=52756
460
461         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
462         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
463         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
464         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
465         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
466         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
467
468 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
469
470         Reviewed by Antonio Gomes.
471
472         QtTestBrowser should have a seperate menu for Settings
473         https://bugs.webkit.org/show_bug.cgi?id=52817
474         
475         Added a new menu item named "Settings"
476         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
477
478         * QtTestBrowser/launcherwindow.cpp:
479         (LauncherWindow::createChrome):
480
481 2011-01-20  Sam Weinig  <sam@webkit.org>
482
483         Reviewed by John Sullivan.
484
485         Update update-webkit-localizable-strings with new path to WebKit.
486
487         * Scripts/update-webkit-localizable-strings:
488
489 2011-01-20  James Robinson  <jamesr@chromium.org>
490
491         Reviewed by Darin Fisher.
492
493         Implement mozilla's requestAnimationFrame API
494         https://bugs.webkit.org/show_bug.cgi?id=51218
495
496         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
497
498         * DumpRenderTree/chromium/WebViewHost.cpp:
499         (invokeScheduleComposite):
500         (WebViewHost::scheduleAnimation):
501         (WebViewHost::paintInvalidatedRegion):
502         * DumpRenderTree/chromium/WebViewHost.h:
503
504 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
505
506         Reviewed by Adam Roben.
507
508         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
509         https://bugs.webkit.org/show_bug.cgi?id=42327
510
511         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
512         for methods that take their normal arguments but also a JSContextRef.
513         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
514         for evaluateScriptInIsolatedWorld.
515         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
516         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
517         this call is for an isolated world.
518         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
519         (WTR::worldMap): Helper to create a world map.
520         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
521         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
522         added LayoutTestController API.
523         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
524
525 2011-01-19  Adam Roben  <aroben@apple.com>
526
527         Convert paths in environment variables back to msys-style inside commit-log-editor
528
529         When this script gets run from inside git commit, msys-style paths in the environment will
530         have been turned into Windows-style paths with forward slashes. This screws up functions
531         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
532         the paths back to msys-style before doing anything else.
533
534         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
535         using msysgit's Perl and multiple ChangeLogs have been edited
536
537         Reviewed by David Kilzer.
538
539         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
540         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
541         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
542
543 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
544
545         [Win] Unreviewed build fix after r76248.
546
547         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
548
549 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
550
551         Reviewed by Csaba Osztrogonác.
552
553         Refactoring of the custom allocation framework
554         https://bugs.webkit.org/show_bug.cgi?id=49897
555
556         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
557         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
558         equivalent macro implementation at the necessary places.
559 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
560
561         Unreviewed. 
562
563         Adding myself to committers.py.
564
565         * Scripts/webkitpy/common/config/committers.py:
566
567 2011-01-20  Adam Barth  <abarth@webkit.org>
568
569         Reviewed by Tony Chang.
570
571         Chromium builders don't delete unversioned directories when DEPS change
572         https://bugs.webkit.org/show_bug.cgi?id=52745
573
574         If we pass this option to gclient sync, gclient will delete directories
575         that are no longer part of DEPS instead of leaving them around to
576         confuse us later.  Apparently, the downstream buildbots use this option
577         already.
578
579         * Scripts/update-webkit-chromium:
580
581 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
582
583         Unreviewed, build fix - I pulled this patch in to fix an issue
584         revealed by r76195 running on some new bots). Also fix a couple
585         of other issues revealed in testing.
586
587         nrwt: remove fs refs from layout_package/json*
588
589         https://bugs.webkit.org/show_bug.cgi?id=52754
590
591         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
592         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
593         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
594         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
595         * Scripts/webkitpy/layout_tests/port/base.py:
596
597 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
598
599         Unreviewed, build fix.
600
601         Fix a couple of minor bugs discovered while bringing up new bots
602         for testing.
603
604         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
605         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
606
607 2011-01-19  James Robinson  <jamesr@chromium.org>
608
609         Unreviewed, rolling out r76194.
610         http://trac.webkit.org/changeset/76194
611         https://bugs.webkit.org/show_bug.cgi?id=51218
612
613         Caused mysterious compile failure on the chromium win
614         build.webkit.org bots
615
616         * DumpRenderTree/chromium/WebViewHost.cpp:
617         (WebViewHost::paintInvalidatedRegion):
618         * DumpRenderTree/chromium/WebViewHost.h:
619
620 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
621
622         Reviewed by Mihai Parparita.
623
624         remove fs refs from test_runner, dump_render_tree_thread
625
626         https://bugs.webkit.org/show_bug.cgi?id=52753
627
628         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
629         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
630         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
631         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
632
633 2011-01-19  James Robinson  <jamesr@chromium.org>
634
635         Reviewed by Darin Fisher.
636
637         Implement mozilla's requestAnimationFrame API
638         https://bugs.webkit.org/show_bug.cgi?id=51218
639
640         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
641
642         * DumpRenderTree/chromium/WebViewHost.cpp:
643         (invokeScheduleComposite):
644         (WebViewHost::scheduleAnimation):
645         (WebViewHost::paintInvalidatedRegion):
646         * DumpRenderTree/chromium/WebViewHost.h:
647
648 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
649
650         Unreviewed, build fix.
651
652         Fix a few incorrect "self._filesystem" references introduced in
653         r76184.
654
655         * Scripts/webkitpy/layout_tests/port/chromium.py:
656         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
657
658 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
659
660         Reviewed by Mihai Parparita.
661
662         add a .sep property, abspath(), isabs(), mtime(), and
663         open_text_file_for_writing() to filesystem modules. Some of
664         these properties are not needed in this patch but will be needed
665         in subsequent patches (I'm doing this to avoid having to track
666         multiple versions of a single file).
667
668         Also, change most of the port/* modules to use the filesystem
669         objects instead of referencing the filesystem directly.
670
671         https://bugs.webkit.org/show_bug.cgi?id=52748
672
673         * Scripts/webkitpy/common/system/filesystem.py:
674         * Scripts/webkitpy/common/system/filesystem_mock.py:
675         * Scripts/webkitpy/layout_tests/port/__init__.py:
676         * Scripts/webkitpy/layout_tests/port/base.py:
677         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
678         * Scripts/webkitpy/layout_tests/port/chromium.py:
679         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
680         * Scripts/webkitpy/layout_tests/port/config.py:
681         * Scripts/webkitpy/layout_tests/port/test.py:
682         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
683
684 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
685
686         Reviewed by Anders Carlsson.
687
688         If resetting between tests times out, treat it as a WebProcess crash
689         https://bugs.webkit.org/show_bug.cgi?id=52757
690
691         * WebKitTestRunner/TestController.cpp:
692         (WTR::TestController::runTest):
693
694 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
695
696         Reviewed by Darin Adler.
697
698         https://bugs.webkit.org/show_bug.cgi?id=52739
699         Make it possible for a WebKit2 client to print headers and footers
700
701         Added dummy implementations for new printing UIClient calls.
702
703         * MiniBrowser/mac/BrowserWindowController.m:
704         (-[BrowserWindowController awakeFromNib]):
705         * WebKitTestRunner/TestController.cpp:
706         (WTR::createOtherPage):
707         (WTR::TestController::initialize):
708
709 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
710
711         Reviewed by Ojan Vafai.
712
713         Change webkitpy/layout_tests/port/test.py to use the
714         in-memory filesystem for cleaner unit testing. This
715         change allows us to kill a lot of code that was
716         specific to the test port, at the cost of being a
717         little less clear about how things would work if
718         you didn't have a filesystem.
719
720         https://bugs.webkit.org/show_bug.cgi?id=52605
721
722         * Scripts/webkitpy/layout_tests/port/test.py:
723
724 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
725
726         Unreviewed, build fix.
727
728         Fix test failure caused by committing attachment 79368 instead
729         of attachment 79461 on bug 52604.
730
731         * Scripts/webkitpy/common/system/filesystem_mock.py:
732
733 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
734
735         Reviewed by Mihai Parparita.
736
737         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
738         unit testing. os.walk() is too much of a hassle to implement on
739         top of the in-memory mock filesystem and adding the necessary
740         interface to files_under() gives clients a cleaner API anyway
741         (for this particular usage model).
742
743         https://bugs.webkit.org/show_bug.cgi?id=52691
744
745         * Scripts/webkitpy/common/system/filesystem.py:
746         * Scripts/webkitpy/common/system/filesystem_mock.py:
747         * Scripts/webkitpy/layout_tests/port/test_files.py:
748         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
749
750 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
751
752         Reviewed by Tony Chang.
753
754         Change more modules in the layout-tests code to use the
755         filesystem wrapper for cleaner unit testing.
756
757         This patch also adds the glob() wrapper to the filesystem
758         abstraction.
759         
760         https://bugs.webkit.org/show_bug.cgi?id=52604
761
762         * Scripts/webkitpy/layout_tests/port/test_files.py:
763         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
764         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
765         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
766         * Scripts/webkitpy/common/system/filesystem.py:
767         * Scripts/webkitpy/common/system/filesystem_mock.py:
768
769 2011-01-19  Levi Weintraub  <leviw@chromium.org>
770
771         Unreviewed.
772
773         Updating my email addresses and irc nick.
774
775         * Scripts/webkitpy/common/config/committers.py:
776
777 2011-01-19  Tony Chang  <tony@chromium.org>
778
779         Reviewed by Mihai Parparita.
780
781         [chromium] [linux] if check-sys-deps fails, output the failure reason
782         https://bugs.webkit.org/show_bug.cgi?id=52671
783
784         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
785             error handler functions.
786         * Scripts/webkitpy/layout_tests/port/chromium.py:
787             output the error text from --check-sys-deps
788         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
789
790 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
791
792         Reviewed by Andreas Kling.
793
794         [Qt] QtTestBrowser crashes when closing if Facebook is opened
795         https://bugs.webkit.org/show_bug.cgi?id=52554
796         
797         QtNetworkAccessManager is created in a thread and set as
798         member variable in QWebPage. When the thread is destroyed
799         the object is still used. So fix will set the object to
800         NULL once the thread is destroyed.
801
802         * QtTestBrowser/launcherwindow.cpp:
803         (LauncherWindow::~LauncherWindow):
804
805 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
806
807         Rubber stamped by Csaba Osztrogonac
808
809         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
810
811 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
812
813         Reviewed by Tony Chang.
814
815         new-run-webkit-tests: add a --build-directory command line argument
816
817         Official Google Chrome builds use a non-standard build directory
818         location. This patch adds a --build-directory argument that
819         allows that location to be specified on the command line. Only
820         Chromium-based builds will use this flag for now, but anyone can
821         in the future.
822
823         There are no unit tests for this since it's difficult to test
824         until mock filesystems are fully supported in the code. This was
825         tested by hand for now.
826
827         https://bugs.webkit.org/show_bug.cgi?id=52694
828
829         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
830         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
831         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
832         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
833
834 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
835
836         Not reviewed. Bot fix.
837
838         Remove an inadvertently committed debugging print.
839
840         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
841         (LayoutTestController::notifyDone):
842
843 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
844
845         Reviewed by Sam Weinig.
846
847         WebKitTestRunner should track loading more like DumpRenderTree
848         https://bugs.webkit.org/show_bug.cgi?id=52692
849
850         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
851         This makes some tests that call notifyDone multiple times pass.
852         
853         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
854         (WTR::InjectedBundle::InjectedBundle):
855         (WTR::InjectedBundle::done):
856         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
857         (WTR::InjectedBundle::topLoadingFrame):
858         (WTR::InjectedBundle::setTopLoadingFrame):
859         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
860         (WTR::InjectedBundlePage::InjectedBundlePage):
861         (WTR::InjectedBundlePage::stopLoading):
862         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
863         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
864         (WTR::InjectedBundlePage::didFinishLoadForFrame):
865         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
866         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
867         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
868         (WTR::LayoutTestController::notifyDone):
869         * WebKitTestRunner/TestController.cpp:
870         (WTR::TestController::didReceiveMessageFromInjectedBundle):
871
872 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
873
874         Reviewed by Kent Tamura.
875
876         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
877         https://bugs.webkit.org/show_bug.cgi?id=52678
878         
879         Update path now that WebKit is inside Source.
880
881         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
882
883 2011-01-18  Robert Hogan  <robert@webkit.org>
884
885         Reviewed by Simon Hausmann.
886
887         [Qt] http/tests/incremental/slow-utf8-text.pl fails
888         https://bugs.webkit.org/show_bug.cgi?id=44282
889
890         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
891         (WebCore::DumpRenderTree::dump):
892
893 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
894
895         Reviewed by Mihai Parparita.
896
897         Fix a small race condition that could cause the unit tests for
898         new-run-webkit-tests to fail in a multithreaded environment.
899         There was a small window in the code where one thread would
900         check to see if a thread had raised an exception, do something,
901         and then check to see if the thread was alive. If the other
902         thread raised an exception and exited in between these two
903         steps, the exception would be lost. Flipping the order of the
904         two checks fixes the race, since we will now always check for an
905         exception on the thread before exiting.
906
907         https://bugs.webkit.org/show_bug.cgi?id=51579
908
909         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
910
911 2011-01-18  Eric Seidel  <eric@webkit.org>
912
913         Reviewed by Adam Barth.
914
915         commit-queue dies when test archiving fails
916         https://bugs.webkit.org/show_bug.cgi?id=52617
917
918         I looked at the machine and it had 10 archives already
919         thus find_unused_name was returning None.  I've upped
920         the limit to 100 (per bug) and tested the case where
921         find_unused_name returns None (making archive return None).
922
923         * Scripts/webkitpy/common/system/workspace.py:
924         * Scripts/webkitpy/common/system/workspace_unittest.py:
925         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
926         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
927         * Scripts/webkitpy/tool/commands/queues.py:
928
929 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
930
931         Reviewed by Ojan Vafai.
932
933         Update rebaseline-chromium-webkit-tests unit tests to use a mock
934         filesystem. Also fix a couple of "with" statements missed by
935         r76050.
936
937         https://bugs.webkit.org/show_bug.cgi?id=52487
938
939         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
940
941 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
942
943         Reviewed by Martin Robinson.
944
945         [Gtk] Build fixes for gtk3 build
946         https://bugs.webkit.org/show_bug.cgi?id=52648
947
948         * DumpRenderTree/gtk/EventSender.cpp:
949         (beginDragWithFilesCallback):
950
951 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
952
953         Reviewed by Mihai Parparita.
954
955         Update rebaseline-chromium-webkit-tests to use filesystem objects
956         instead of direct references to os.path, shutil, tempfile, etc.
957
958         This patch doesn't change anything, but will allow subsequent
959         patches to change the unit tests to no longer use the real
960         filesystem.
961
962         This patch adds a bunch more methods to the filesystem object as
963         well.
964
965         https://bugs.webkit.org/show_bug.cgi?id=52482
966
967         * Scripts/webkitpy/common/system/filesystem.py:
968         * Scripts/webkitpy/common/system/filesystem_mock.py:
969         * Scripts/webkitpy/tool/commands/queues.py:
970         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
971         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
972
973 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
974
975         Reviewed by Mihai Parparita.
976
977         new-run-webkit-tests shouldn't crash when you try to run a
978         directory containing only skipped files.
979
980         https://bugs.webkit.org/show_bug.cgi?id=52478
981         
982         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
983         * Scripts/webkitpy/layout_tests/port/test.py:
984         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
985
986 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
987
988         Reviewed by Gustavo Noronha Silva.
989
990         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
991         https://bugs.webkit.org/show_bug.cgi?id=40833
992
993         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
994         GTK+ event sender.
995         (dragWithFilesDragDataGetCallback): Added.
996         (dragWithFilesDragEndCallback): Added.
997         (beginDragWithFilesCallback): Added.
998
999 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1000
1001         Reviewed by Adam Barth.
1002
1003         ews: Add additional watcher to efl ews
1004         https://bugs.webkit.org/show_bug.cgi?id=52613
1005
1006         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1007
1008         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1009
1010 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1011
1012         Reviewed by Alexey Proskuryakov.
1013
1014         Fix some headers with missing or misspelled #ifndef guards
1015         https://bugs.webkit.org/show_bug.cgi?id=52545
1016
1017         * DumpRenderTree/chromium/TestEventPrinter.h:
1018         * DumpRenderTree/chromium/WebPreferences.h:
1019
1020 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1021
1022         Reviewed by Anders Carlsson.
1023
1024         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1025         navigating back to an unreachable URL
1026         https://bugs.webkit.org/show_bug.cgi?id=52388
1027
1028         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1029
1030         * DumpRenderTree/LayoutTestController.cpp:
1031         (queueLoadHTMLStringCallback):
1032         (LayoutTestController::queueLoadHTMLString):
1033         (LayoutTestController::queueLoadAlternateHTMLString):
1034         * DumpRenderTree/LayoutTestController.h:
1035
1036         * DumpRenderTree/WorkQueueItem.h:
1037         (LoadHTMLStringItem::LoadHTMLStringItem):
1038
1039         * DumpRenderTree/chromium/LayoutTestController.cpp:
1040         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1041         (WorkItemLoadHTMLString::run):
1042         (LayoutTestController::queueLoadHTMLString):
1043
1044         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1045         (LoadHTMLStringItem::invoke):
1046         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1047         (LoadHTMLStringItem::invoke):
1048         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1049         (LoadHTMLStringItem::invoke):
1050
1051 2011-01-17  Dan Bernstein  <mitz@apple.com>
1052
1053         Rubber-stamped by Mark Rowe.
1054
1055         Update xcodeproj svn:ignore to include xcuserdata.
1056
1057         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1058         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1059         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1060         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1061         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1062
1063 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1064
1065         Unreviewed fix after r75908.
1066
1067         Move WebKit into Source
1068         https://bugs.webkit.org/show_bug.cgi?id=52530
1069
1070         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1071
1072 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1073
1074         Unreviewed.
1075
1076         Remove accidentally committed debug printing after r75908.
1077
1078         * Scripts/webkitdirs.pm:
1079
1080 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1081
1082         Unreviewed.
1083
1084         Add myself to committers list
1085         https://bugs.webkit.org/show_bug.cgi?id=52566
1086
1087         * Scripts/webkitpy/common/config/committers.py:
1088
1089 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1090
1091         Reviewed by Jeremy Orlow.
1092
1093         GeolocationController should call stopUpdating on destruction
1094         https://bugs.webkit.org/show_bug.cgi?id=52216
1095
1096         fast/dom/Geolocation/window-close-crash.html requires that a
1097         Geolocation watch be started in a secondary window. Consequently,
1098         we need to allow geolocation permission and provide a mock
1099         geolocation position for the secondary window's
1100         GeolocationClientMock.
1101
1102         * DumpRenderTree/chromium/LayoutTestController.cpp:
1103         (LayoutTestController::setGeolocationPermission):
1104         (LayoutTestController::setMockGeolocationPosition):
1105         (LayoutTestController::setMockGeolocationError):
1106         * DumpRenderTree/chromium/TestShell.h:
1107         (TestShell::windowList):
1108
1109 2011-01-16  Adam Barth  <abarth@webkit.org>
1110
1111         Update more include paths to reflect WebKit move.
1112
1113         * DumpRenderTree/chromium/EventSender.cpp:
1114         (EventSender::keyDown):
1115         (EventSender::needsShiftModifier):
1116         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1117         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1118
1119 2011-01-16  Kent Tamura  <tkent@chromium.org>
1120
1121         Unreviewed, Chromium build fix.
1122
1123         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1124
1125 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1126
1127         Build fix for GTK+ after source directory movement.
1128
1129         * GNUmakefile.am: Correct include paths.
1130
1131 2011-01-16  Adam Barth  <abarth@webkit.org>
1132
1133         Teach svn-apply about WebKit move.
1134
1135         * Scripts/VCSUtils.pm:
1136
1137 2011-01-16  Adam Barth  <abarth@webkit.org>
1138
1139         Rubber-stamped by Eric Seidel.
1140
1141         Move WebKit into Source
1142         https://bugs.webkit.org/show_bug.cgi?id=52530
1143
1144         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1145         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1146         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1147         * DumpRenderTree/qt/GCControllerQt.cpp:
1148         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1149         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1150         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1151         * DumpRenderTree/wscript:
1152         * QtTestBrowser/launcherwindow.h:
1153         * Scripts/build-webkit:
1154         * Scripts/webkitdirs.pm:
1155
1156 2011-01-15  Adam Barth  <abarth@webkit.org>
1157
1158         Teach svn-apply about WebKit2 move.
1159
1160         * Scripts/VCSUtils.pm:
1161
1162 2011-01-15  Adam Barth  <abarth@webkit.org>
1163
1164         Rubber-stamped by Eric Seidel.
1165
1166         Move WebKit2 into Source
1167         https://bugs.webkit.org/show_bug.cgi?id=52438
1168
1169         * MiniBrowser/qt/MiniBrowser.pro:
1170         * Scripts/build-webkit:
1171         * Scripts/do-file-rename:
1172         * Scripts/do-webcore-rename:
1173         * Scripts/test-webkitpy:
1174         * Scripts/webkitdirs.pm:
1175         * Scripts/webkitpy/style/checker.py:
1176         * WebKitTestRunner/DerivedSources.pro:
1177         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1178         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1179
1180 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1181
1182         Reviewed by David Levin.
1183
1184         [chromium] remove obsolete createView method
1185         https://bugs.webkit.org/show_bug.cgi?id=52437
1186
1187         * DumpRenderTree/chromium/WebViewHost.cpp:
1188         (WebViewHost::createView):
1189         * DumpRenderTree/chromium/WebViewHost.h:
1190
1191 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1192
1193         Reviewed by Geoff Garen.
1194
1195         ShouldLoadResourceForFrame should use strings, not URLs.
1196         https://bugs.webkit.org/show_bug.cgi?id=52476
1197
1198         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1199         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1200         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1201
1202 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1203
1204         Reviewed by David Levin.
1205
1206         Add Tony Gentilcore as a reviewer
1207         https://bugs.webkit.org/show_bug.cgi?id=52480
1208
1209         * Scripts/webkitpy/common/config/committers.py:
1210
1211 2011-01-14  David Levin  <levin@chromium.org>
1212
1213         Reviewed by Eric Seidel.
1214
1215         check-webkit-style: _FunctionState should keep track of where the function name starts.
1216         https://bugs.webkit.org/show_bug.cgi?id=52454
1217
1218         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1219         _FunctionState and logic for setting it correctly.
1220         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1221
1222 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1223
1224         Reviewed by David Levin.
1225
1226         Add support to DumpRenderTree to use the GPU rather than software renderer
1227         https://bugs.webkit.org/show_bug.cgi?id=52333
1228
1229         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1230         (main):
1231         * Scripts/webkitpy/layout_tests/port/chromium.py:
1232         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1233
1234 2011-01-14  Tony Chang  <tony@chromium.org>
1235
1236         Reviewed by Kent Tamura.
1237
1238         [chromium] update fonts.conf to fix 6 linux tests in drt
1239         https://bugs.webkit.org/show_bug.cgi?id=52411
1240
1241         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1242             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1243
1244 2011-01-14  Eric Seidel  <eric@webkit.org>
1245
1246         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1247
1248         Reviewed by Adam Barth.
1249
1250         Fix when running Tools/Scripts/check-webkit-style without arguments.
1251         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1252
1253         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1254         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1255
1256 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1257
1258         Reviewed by David Levin.
1259
1260         Store the tempdir object in a variable so it doesn't get deleted too early.
1261         https://bugs.webkit.org/show_bug.cgi?id=51875
1262
1263         * Scripts/update-webkit-auxiliary-libs:
1264         * Scripts/update-webkit-support-libs:
1265
1266 2011-01-14  Eric Seidel  <eric@webkit.org>
1267
1268         Unreviewed.  Make it work in python 2.5.
1269
1270         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1271         https://bugs.webkit.org/show_bug.cgi?id=49158
1272
1273         * Scripts/webkitpy/common/checkout/api_unittest.py:
1274
1275 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1276
1277         Unreviewed, rolling out r75774.
1278         http://trac.webkit.org/changeset/75774
1279         https://bugs.webkit.org/show_bug.cgi?id=52431
1280
1281         gtk builds were broken (Requested by loislo2 on #webkit).
1282
1283         * Scripts/webkitpy/common/checkout/scm.py:
1284
1285 2011-01-14  David Levin  <levin@chromium.org>
1286
1287         Reviewed by Shinichiro Hamaji.
1288
1289         check-webkit-style: _FunctionState should detect pure functions.
1290         https://bugs.webkit.org/show_bug.cgi?id=52428
1291
1292         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1293         is a pure virtual function.
1294         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1295         virtual functions are correctly detected.
1296
1297 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1298
1299         Reviewed by Yury Semikhatsky.
1300
1301         Just small fix for problem with check-webkit-style.
1302         It just didn't work for this patch.
1303         Old code can't concatenate a list of strings with None.
1304
1305         * Scripts/webkitpy/common/checkout/scm.py:
1306
1307 2011-01-13  David Levin  <levin@chromium.org>
1308
1309         Reviewed by Shinichiro Hamaji.
1310
1311         check-webkit-style: _FunctionState should use Position to know where items are.
1312         https://bugs.webkit.org/show_bug.cgi?id=52424
1313
1314         * Scripts/webkitpy/style/checkers/cpp.py:
1315         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1316         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1317         did some minor clean-up.
1318         (*): Other changes are simply about converting to use the Position's in_FunctionState
1319         instead of line numbers.
1320         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1321         to verify the positions stored in _FunctionState.
1322
1323 2011-01-13  Eric Seidel  <eric@webkit.org>
1324
1325         Reviewed by David Levin.
1326
1327         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1328         https://bugs.webkit.org/show_bug.cgi?id=49158
1329
1330         This is not the most elegant, but it is a very safe fix to this bug.
1331         One advantage of catching ScriptError like this instead of adding a
1332         new added_or_modified_files or fixing all changed_files callers
1333         to use a more specific change_files variant, is that we catch
1334         all kinds of ScriptErrors which might cause our (non-essential)
1335         suggest-reviewers code to fail out.  This should make passing
1336         --suggest-reviewers to webkit-patch upload much more robust
1337         and may even make it possible for us to make it default.
1338
1339         The root of the problem here is that SCM.changed_files includes
1340         deleted ChangeLog paths (from moves, etc) which then when we ask
1341         SVN/Git for the contents of the file at that revision, the command
1342         errors out and Executive.run_command raises a ScriptError.
1343
1344         In the future we might fix this differently by making all current
1345         callers of chagned_files use a more specific method for requesting
1346         what types of changes they're interested in (adds, modifies, deletes, etc.)
1347
1348         * Scripts/webkitpy/common/checkout/api.py:
1349         * Scripts/webkitpy/common/checkout/api_unittest.py:
1350
1351 2011-01-13  Dan Bernstein  <mitz@apple.com>
1352
1353         Reviewed by Alexey Proskuryakov.
1354
1355         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1356         https://bugs.webkit.org/show_bug.cgi?id=52419
1357
1358         Allow to further control the behavior of the willSendRequest delegate callback by making it
1359         set a different URL in the new request.
1360
1361         * DumpRenderTree/LayoutTestController.cpp:
1362         (addURLToRedirectCallback): Added.
1363         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1364         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1365         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1366         * DumpRenderTree/LayoutTestController.h:
1367         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1368         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1369         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1370         change the URL in the new request to the redirect destination.
1371
1372 2011-01-13  Eric Seidel  <eric@webkit.org>
1373
1374         Reviewed by Mihai Parparita.
1375
1376         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1377         https://bugs.webkit.org/show_bug.cgi?id=52416
1378
1379         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1380         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1381
1382         I also added FIXMEs about the changed_files returning deleted files problem
1383         which is causing the other most common exception for suggest-reviewers
1384         (and is probably breaking sheriff-bots blame detection).
1385
1386         * Scripts/webkitpy/common/checkout/api.py:
1387         * Scripts/webkitpy/common/checkout/api_unittest.py:
1388         * Scripts/webkitpy/common/checkout/scm.py:
1389
1390 2011-01-13  Eric Seidel  <eric@webkit.org>
1391
1392         Reviewed by Adam Barth.
1393
1394         results archives from commit-queue are too large to upload
1395         https://bugs.webkit.org/show_bug.cgi?id=52405
1396
1397         * Scripts/webkitpy/common/system/filesystem.py:
1398         * Scripts/webkitpy/common/system/filesystem_mock.py:
1399         * Scripts/webkitpy/tool/commands/queues.py:
1400
1401 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1402
1403         Reviewed by Martin Robinson.
1404
1405         [gtk] Zero-sized font does not yet work
1406         https://bugs.webkit.org/show_bug.cgi?id=49793
1407
1408         Set minimum-font-size to 0 for the DRT.
1409
1410         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1411         (resetDefaultsToConsistentValues):
1412
1413 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1414
1415         Reviewed by Darin Adler.
1416
1417         Make old-run-webkit-tests more robust on buildbots
1418         https://bugs.webkit.org/show_bug.cgi?id=52364
1419
1420         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1421
1422 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1423
1424         Reviewed by Darin Adler.
1425
1426         Make old-run-webkit-tests more robust on buildbots
1427         https://bugs.webkit.org/show_bug.cgi?id=52364
1428
1429         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1430
1431 2011-01-13  Tony Chang  <tony@chromium.org>
1432
1433         Reviewed by Kent Tamura.
1434
1435         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1436         https://bugs.webkit.org/show_bug.cgi?id=52332
1437
1438         Forked Info.plist is not longer needed.
1439
1440         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1441
1442 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1443
1444         Reviewed by Timothy Hatcher.
1445
1446         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1447         to be passed directly to WebInspector.UIString
1448
1449         https://bugs.webkit.org/show_bug.cgi?id=52365
1450
1451         * Scripts/check-inspector-strings:
1452
1453 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1454
1455         Unreviewed, rolling out r74881.
1456         http://trac.webkit.org/changeset/74881
1457         https://bugs.webkit.org/show_bug.cgi?id=52357
1458
1459         The EFL builder has been red for days (Requested by abarth on
1460         #webkit).
1461
1462         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1463         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1464
1465 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1466
1467         Reviewed by David Levin.
1468
1469         Add beforeunload support to WebKitTestRunner
1470         https://bugs.webkit.org/show_bug.cgi?id=52353
1471         
1472         This makes a number of currently failing tests pass.
1473
1474         * WebKitTestRunner/TestController.cpp:
1475         (WTR::runBeforeUnloadConfirmPanel):
1476         (WTR::createOtherPage):
1477         (WTR::TestController::initialize):
1478
1479 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1480
1481         Reviewed by Sam Weinig.
1482
1483         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1484         https://bugs.webkit.org/show_bug.cgi?id=52330
1485
1486         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1487         a web process crash.
1488         * WebKitTestRunner/TestController.cpp:
1489         (WTR::TestController::initialize): Set up a processDidCrash
1490         callback.
1491         (WTR::TestController::processDidCrash): Report that the Web process
1492         crashed.
1493         * WebKitTestRunner/TestController.h:
1494
1495 2011-01-12  David Levin  <levin@chromium.org>
1496
1497         Reviewed by Shinichiro Hamaji.
1498
1499         check-webkit-style -- close_expression function doesn't work correctly.
1500         https://bugs.webkit.org/show_bug.cgi?id=52272
1501
1502         * Scripts/webkitpy/style/checkers/cpp.py:
1503         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1504         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1505         generally useful (for upcoming code changes).
1506         (close_expression): Changed to use Position for input and output.
1507         Also, fixed many bugs such as only working correctly for parenthesis,
1508         not working correctly if given an offset in a line and not finding
1509         the real closing element if there were multiple closing elements in
1510         the same line.
1511         (detect_functions): Adjusted due to the change in arguments for
1512         close_expression.
1513         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1514         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1515         two positions are the same.
1516         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1517         (CppStyleTest.test_close_expression): Added tests to catch the issues
1518         that were fixed.
1519
1520 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1521
1522         Unreviewed, rolling out r75576.
1523         http://trac.webkit.org/changeset/75576
1524         https://bugs.webkit.org/show_bug.cgi?id=52304
1525
1526         broke rebaseline-chromium-webkit-test (Requested by thakis on
1527         #webkit).
1528
1529         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1530         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1531         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1532         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1533         * Scripts/webkitpy/layout_tests/port/base.py:
1534         * Scripts/webkitpy/layout_tests/port/chromium.py:
1535         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1536         * Scripts/webkitpy/layout_tests/port/test.py:
1537         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1538         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1539         * Scripts/webkitpy/style/checkers/test_expectations.py:
1540         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1541
1542 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1543
1544         Reviewed by Darin Adler.
1545
1546         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1547         https://bugs.webkit.org/show_bug.cgi?id=52307
1548
1549         * Scripts/old-run-webkit-tests:
1550
1551 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1552
1553         Reviewed by Martin Robinson.
1554
1555         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1556         https://bugs.webkit.org/show_bug.cgi?id=50867
1557
1558         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1559         TestNetscapePlugin.cpp 
1560
1561         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1562         * Scripts/webkitdirs.pm:
1563
1564 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1565
1566         Reviewed by Pavel Feldman.
1567
1568         Add check-inspector-strings script.
1569
1570         https://bugs.webkit.org/show_bug.cgi?id=52295
1571
1572         * Scripts/check-inspector-strings: Added.
1573
1574 2011-01-12  Adam Roben  <aroben@apple.com>
1575
1576         Advertise the .testnetscape file extension on Windows
1577
1578         Fixes <http://webkit.org/b/52298>
1579         plugins/no-mime-with-valid-extension.html fails on Windows
1580
1581         Reviewed by Dan Bernstein.
1582
1583         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1584         FileExtents field to map the .testnetscape file extension to the
1585         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1586
1587 2011-01-12  Adam Barth  <abarth@webkit.org>
1588
1589         Reviewed by Eric Seidel.
1590
1591         Make webkit-patch support subdirectories for SVN checkouts
1592         https://bugs.webkit.org/show_bug.cgi?id=52261
1593
1594         os.relpath does not exist on Python 2.5, so we need to call our version
1595         of the API.
1596
1597         * Scripts/webkitpy/common/checkout/scm.py:
1598
1599 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1600
1601         Reviewed by Eric Seidel.
1602
1603         Close additional pages opened during a test once the test completes.
1604         https://bugs.webkit.org/show_bug.cgi?id=52276
1605
1606         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1607         (WTR::InjectedBundle::done):
1608
1609 2011-01-11  David Levin  <levin@chromium.org>
1610
1611         Reviewed by Eric Seidel.
1612
1613         Errors should be separated from the command line in bot messages.
1614         https://bugs.webkit.org/show_bug.cgi?id=52275
1615
1616         * Scripts/webkitpy/common/system/executive.py:
1617         (ScriptError.message_with_output): Added a newline to separate the command
1618         line from the errors.
1619         * Scripts/webkitpy/common/system/executive_unittest.py:
1620         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1621         paths in message_with_output.
1622
1623 2011-01-11  Eric Seidel  <eric@webkit.org>
1624
1625         Unreviewed.
1626
1627         commit-queue should know how to upload archived results (for test flakes or general failures)
1628         https://bugs.webkit.org/show_bug.cgi?id=52048
1629
1630         The zips are mostly empty due to forgetting -r.
1631         Expected diffs were not being pulled from the archive due
1632         to the archive having longer paths than I realized.
1633
1634         * Scripts/webkitpy/common/system/workspace.py:
1635         * Scripts/webkitpy/common/system/workspace_unittest.py:
1636         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1637         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1638
1639 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1640
1641         Reviewed by Ojan Vafai.
1642
1643         The current modifier parsing code in test_expectations is
1644         fragile and hard-coded, so it's not easy to understand the logic
1645         or easily add new types of modifiers (like GPU vs. CPU testing
1646         for graphics tests, or 32-bit vs. 64-bit differences).
1647
1648         This is the first of two patches that will add in more generic
1649         support and then eliminate the GPU-specific test expectations
1650         files for Chromium.
1651
1652         This patch adds two standalone objects for handling modifiers. The
1653         rules for interpreting modifiers, precedence, and conflicts are
1654         given in the docstring to the ModifierMatcher class, which
1655         returns ModifierMatchResult objects.
1656         
1657         This patch also adds routines to the Port interface and a
1658         default set of values in the base object, in order to obtain the
1659         values needed on a given test run. These values are then passed
1660         to the expectation parser. This also allows us to clean up the
1661         logic used to lint all of the different configurations in a
1662         single test_expectations.txt file.
1663
1664         The next patch will merge in the separate GPU expectations file.
1665
1666         https://bugs.webkit.org/show_bug.cgi?id=51222
1667
1668         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1669         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1670         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1671         * Scripts/webkitpy/layout_tests/port/base.py:
1672         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1673         * Scripts/webkitpy/layout_tests/port/chromium.py:
1674         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1675         * Scripts/webkitpy/layout_tests/port/test.py:
1676         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1677         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1678
1679 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1680
1681         Reviewed by Adam Barth.
1682
1683         Make webkit-patch support subdirectories for SVN checkouts
1684         https://bugs.webkit.org/show_bug.cgi?id=52261
1685
1686         * Scripts/webkitpy/common/checkout/scm.py:
1687         * Scripts/webkitpy/style_references.py:
1688         * Scripts/webkitpy/tool/main.py:
1689         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1690
1691 2011-01-11  Eric Seidel  <eric@webkit.org>
1692
1693         Unreviewed.
1694
1695         commit-queue should know how to upload archived results (for test flakes or general failures)
1696         https://bugs.webkit.org/show_bug.cgi?id=52048
1697
1698         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1699         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1700
1701         * Scripts/webkitpy/common/system/workspace.py:
1702         * Scripts/webkitpy/common/system/workspace_unittest.py:
1703         * Scripts/webkitpy/tool/commands/queues.py:
1704
1705 2011-01-11  Sam Weinig  <sam@webkit.org>
1706
1707         Roll r75474 back in.
1708
1709 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1710
1711         Reviewed by Kenneth Rohde Christiansen.
1712
1713         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1714         https://bugs.webkit.org/show_bug.cgi?id=51204
1715
1716         * QtTestBrowser/webpage.h:
1717         (QtNAMThread::QtNAMThread):
1718         (QtNAMThread::networkAccessManager):
1719         (QtNAMThread::run):
1720
1721 2011-01-11  Peter Varga  <pvarga@webkit.org>
1722
1723         Unreviewed.
1724
1725         Add myself to committers' list.
1726
1727         * Scripts/webkitpy/common/config/committers.py:
1728
1729 2011-01-11  Eric Seidel  <eric@webkit.org>
1730
1731         Reviewed by Adam Barth.
1732
1733         commit-queue should know how to upload archived results (for test flakes or general failures)
1734         https://bugs.webkit.org/show_bug.cgi?id=52048
1735
1736         Now the queue will always upload results.  Either the entire zip, or just
1737         the diffs.txt in the case of text failures.
1738
1739         This should make understanding flakes much easier, and paves the way
1740         for having the EWS run layout tests (and upload failures).
1741
1742         In order to upload .zip files I had to teach bugzilla.py to autodetect
1743         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1744         for .patch files, I have it add one before calling guess_type.
1745
1746         We may find that always uploading the whole zip instead of just the -diffs.txt
1747         file is preferable, but for now I'm keeping the old behavior because it makes
1748         quickly understanding text failures easy.
1749
1750         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1751         * Scripts/webkitpy/common/system/workspace.py: Added.
1752         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1753         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1754         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1755         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1756         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1757         * Scripts/webkitpy/tool/commands/queues.py:
1758         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1759
1760 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1761
1762         Unreviewed, rolling out r75464.
1763         http://trac.webkit.org/changeset/75464
1764         https://bugs.webkit.org/show_bug.cgi?id=52193
1765
1766         Followup rollout for 75474 (Requested by Ossy on #webkit).
1767
1768         * MiniBrowser/mac/BrowserWindowController.m:
1769         (-[BrowserWindowController awakeFromNib]):
1770         * MiniBrowser/win/BrowserView.cpp:
1771         (BrowserView::create):
1772         * WebKitTestRunner/TestController.cpp:
1773         (WTR::createOtherPage):
1774         (WTR::TestController::initialize):
1775
1776 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1777
1778         Reviewed by Csaba Osztrogonác.
1779
1780         [Qt] Baseline qt_minimal configuration
1781         https://bugs.webkit.org/show_bug.cgi?id=51313
1782
1783         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1784         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1785         QT_NO_UNDOSTACK guard.
1786
1787         * QtTestBrowser/launcherwindow.cpp:
1788         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1789         guards.
1790         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1791         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1792         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1793         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1794
1795         * QtTestBrowser/launcherwindow.h:
1796         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1797         * QtTestBrowser/locationedit.h: Ditto.
1798
1799         * QtTestBrowser/mainwindow.cpp:
1800         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1801         QT_NO_UNDOSTACK guards.
1802         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1803         (MainWindow::changeLocation): Ditto.
1804         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1805         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1806
1807         * QtTestBrowser/webpage.cpp:
1808         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1809         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1810
1811         * QtTestBrowser/webview.cpp:
1812         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1813         (WebViewGraphicsBased::animatedYFlip): Ditto.
1814
1815 2011-01-10  Sam Weinig  <sam@webkit.org>
1816
1817         Fix build.
1818
1819         * MiniBrowser/mac/BrowserWindowController.m:
1820         (-[BrowserWindowController awakeFromNib]):
1821         * MiniBrowser/win/BrowserView.cpp:
1822         (BrowserView::create):
1823         * WebKitTestRunner/TestController.cpp:
1824         (WTR::createOtherPage):
1825         (WTR::TestController::initialize):
1826
1827 2011-01-10  Eric Seidel  <eric@webkit.org>
1828
1829         Reviewed by Ojan Vafai.
1830
1831         style-queue messages are way too long for big patches
1832         https://bugs.webkit.org/show_bug.cgi?id=52161
1833
1834         We definitely could build much fancier list-to-string-with-limit functions
1835         but this should be sufficient for our needs at the moment.
1836
1837         * Scripts/webkitpy/common/system/executive.py:
1838         * Scripts/webkitpy/common/system/executive_unittest.py:
1839
1840 2011-01-10  Tony Chang  <tony@chromium.org>
1841
1842         Unreviewed, rolling out r75398.
1843         http://trac.webkit.org/changeset/75398
1844         https://bugs.webkit.org/show_bug.cgi?id=52008
1845
1846         Some layout tests are crashing on Chromium Win.
1847
1848         * DumpRenderTree/chromium/WebViewHost.cpp:
1849         (WebViewHost::updatePaintRect):
1850         * DumpRenderTree/chromium/WebViewHost.h:
1851
1852 2011-01-10  Adam Roben  <aroben@apple.com>
1853
1854         Roll out r75392
1855
1856         It isn't needed now that r75289 has been rolled out.
1857
1858         * Scripts/run-javascriptcore-tests:
1859
1860 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1861
1862         Reviewed by Anders Carlsson.
1863
1864         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1865         https://bugs.webkit.org/show_bug.cgi?id=52160
1866
1867         * WebKitTestRunner/mac/TestControllerMac.mm:
1868         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1869         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1870         anyway.
1871
1872 2011-01-10  Tony Chang  <tony@chromium.org>
1873
1874         Reviewed by Mihai Parparita.
1875
1876         [chromium] fix for animated gif layout tests
1877         https://bugs.webkit.org/show_bug.cgi?id=52008
1878
1879         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1880             to trigger gif animations.
1881         (WebViewHostPaintTask::WebViewHostPaintTask):
1882         (WebViewHostPaintTask::runIfValid):
1883         (WebViewHost::updatePaintRect):
1884         * DumpRenderTree/chromium/WebViewHost.h:
1885         (WebViewHost::taskList):
1886
1887 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1888
1889         Reviewed by Xan Lopez.
1890
1891         [GTK] Fix gtk2 compilation for master
1892         https://bugs.webkit.org/show_bug.cgi?id=51885
1893
1894         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1895         (createBitmapContextFromWebView): Replaced the old
1896         gdk_drawable_get_size with gdk_pixmap_get_size.
1897
1898 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1899
1900         Reviewed by Laszlo Gombos.
1901
1902         [WINCE] Reenable NPAPI after r75203
1903         https://bugs.webkit.org/show_bug.cgi?id=52109
1904
1905         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1906         it with !isEfl(), because EFL port does not support NPAPI (yet).
1907
1908         * Scripts/build-webkit:
1909
1910 2011-01-10  Adam Roben  <aroben@apple.com>
1911
1912         Skip some asserting JS tests
1913
1914         See <http://webkit.org/b/52156>.
1915
1916         * Scripts/run-javascriptcore-tests:
1917
1918 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1919
1920         Reviewed by Xan Lopez.
1921
1922         [GTK] build-webkit disable Blob support via arguments passed to automake
1923         https://bugs.webkit.org/show_bug.cgi?id=52097
1924
1925         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1926         build-webkit.
1927
1928 2011-01-10  Adam Roben  <aroben@apple.com>
1929
1930         Use the same name and description for TestNetscapePlugin on Windows and
1931         Mac
1932
1933         Fixes <http://webkit.org/b/52151>
1934         fast/frames/iframe-reparenting-plugins.html fails on Windows
1935
1936         Reviewed by Steve Falkenburg.
1937
1938         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1939         the name and description from Mac's Info.plist.
1940
1941 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1942
1943         Reviewed by Laszlo Gombos.
1944
1945         [Qt][WK2] Guard gcc-specific syntax
1946
1947         Non-gcc based compliers choke on the "-include"
1948         syntax for preinclude, place guard around it.
1949
1950         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1951         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1952
1953 2011-01-10  Andreas Kling  <kling@webkit.org>
1954
1955         Reviewed by Simon Hausmann.
1956
1957         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1958         https://bugs.webkit.org/show_bug.cgi?id=52111
1959
1960         When getting a createNewPage() callback from QWKPage, create the
1961         new page with the same QWKContext as the page that is passed to
1962         the callback.
1963
1964         * MiniBrowser/qt/BrowserView.h:
1965         * MiniBrowser/qt/BrowserWindow.cpp:
1966         (newPageFunction):
1967         (BrowserWindow::BrowserWindow):
1968         * MiniBrowser/qt/BrowserWindow.h:
1969
1970 2011-01-10  Andreas Kling  <kling@webkit.org>
1971
1972         Reviewed by Kenneth Rohde Christiansen.
1973
1974         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1975
1976         BrowserView set its own useless createNewPage() callback on QWKPage.
1977         This was immediately overridden by BrowserWindow anyway, so remove
1978         the BrowserView one.
1979
1980         * MiniBrowser/qt/BrowserView.cpp:
1981         (BrowserView::BrowserView):
1982
1983 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1984
1985         Reviewed by Jeremy Orlow.
1986
1987         [Chromium] Remove non-client-based Geolocation code
1988         https://bugs.webkit.org/show_bug.cgi?id=50921
1989
1990         * DumpRenderTree/chromium/LayoutTestController.cpp:
1991         (LayoutTestController::setGeolocationPermission):
1992         (LayoutTestController::setMockGeolocationPosition):
1993         (LayoutTestController::setMockGeolocationError):
1994         * DumpRenderTree/chromium/WebViewHost.cpp:
1995         (WebViewHost::geolocationClientMock):
1996         (WebViewHost::reset):
1997         * DumpRenderTree/chromium/WebViewHost.h:
1998
1999 2011-01-10  Eric Seidel  <eric@webkit.org>
2000
2001         Reviewed by Adam Barth.
2002
2003         Commit bot tried to land r? cq+ patch
2004         https://bugs.webkit.org/show_bug.cgi?id=36638
2005
2006         It should now be possible to post a patch with r? and cq+ and the
2007         commit-queue will correctly wait for the r+ before attempting to land the patch.
2008         (This was a feature requested by several users.)
2009
2010         One caveat: We don't actually reject r-, cq+ patches from the queue
2011         (we just ignore them), but I think that's OK for now.
2012
2013         I also noticed that setting r- once a commit-queue node had grabbed
2014         a patch would not properly cancel the landing.  That's fixed and
2015         tested in this patch.
2016
2017         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2018         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2019         * Scripts/webkitpy/tool/bot/feeders.py:
2020         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2021
2022 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2023
2024         Reviewed by Kenneth Rohde Christiansen.
2025
2026         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2027         https://bugs.webkit.org/show_bug.cgi?id=51934
2028
2029         When accessing the network from the destructor of QWebPage, the network access manager
2030         was already deleted because the object WebPage was already destructed.
2031
2032         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2033         The object is now destructed in the destructor of QObject.
2034
2035         * QtTestBrowser/webpage.cpp:
2036         (WebPage::WebPage):
2037         (WebPage::setQnamThreaded):
2038         * QtTestBrowser/webpage.h:
2039         (QtNAMThread::QtNAMThread):
2040
2041 2011-01-08  Eric Seidel  <eric@webkit.org>
2042
2043         Reviewed by Ojan Vafai.
2044
2045         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2046         https://bugs.webkit.org/show_bug.cgi?id=52067
2047
2048         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2049         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2050
2051         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2052
2053 2011-01-08  Eric Seidel  <eric@webkit.org>
2054
2055         Reviewed by Mihai Parparita.
2056
2057         commit-queue hangs when the ChangeLog diff is bad
2058         https://bugs.webkit.org/show_bug.cgi?id=52072
2059
2060         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2061         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2062
2063 2011-01-08  Adam Barth  <abarth@webkit.org>
2064
2065         Teach svn-apply how to re-write WebCore to Source/WebCore.
2066
2067         * Scripts/VCSUtils.pm:
2068
2069 2011-01-07  Adam Barth  <abarth@webkit.org>
2070
2071         Rubber-stamped by Eric Seidel.
2072
2073         Move WebCore to Source
2074         https://bugs.webkit.org/show_bug.cgi?id=52050
2075
2076         Update the tools to understand WebCore's new location.
2077
2078         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2079         * DumpRenderTree/wscript:
2080         * GNUmakefile.am:
2081         * Scripts/build-webkit:
2082         * Scripts/do-file-rename:
2083         * Scripts/do-webcore-rename:
2084         * Scripts/generate-qt-inspector-resource:
2085         * Scripts/prepare-ChangeLog:
2086         * Scripts/run-bindings-tests:
2087         * Scripts/update-iexploder-cssproperties:
2088         * Scripts/update-sources-list.py:
2089         * Scripts/update-webkit-localizable-strings:
2090         * Scripts/webkitdirs.pm:
2091         * Scripts/webkitpy/common/config/build.py:
2092         * Scripts/webkitpy/common/config/build_unittest.py:
2093         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2094         * Scripts/webkitpy/style/checker.py:
2095         * Scripts/webkitpy/style/checker_unittest.py:
2096         * WebKitTestRunner/DerivedSources.pro:
2097         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2098         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2099         * wx/browser/wscript:
2100         * wx/build/settings.py:
2101
2102 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2103
2104         Reviewed by Sam Weinig.
2105
2106         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2107         https://bugs.webkit.org/show_bug.cgi?id=52086
2108
2109         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2110         (WTR::InjectedBundle::didReceiveMessage):
2111         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2112         (WTR::LayoutTestController::notifyDone):
2113         * WebKitTestRunner/TestController.cpp:
2114         (WTR::TestController::resetStateToConsistentValues):
2115         (WTR::TestController::run):
2116
2117 2011-01-07  James Robinson  <jamesr@chromium.org>
2118
2119         Revert "Implement mozilla's animationTime property"
2120         https://bugs.webkit.org/show_bug.cgi?id=51952
2121
2122         This approach isn't quite right.
2123
2124         * DumpRenderTree/chromium/WebViewHost.cpp:
2125         (WebViewHost::paintInvalidatedRegion):
2126
2127 2011-01-07  Adam Roben  <aroben@apple.com>
2128
2129         Build master fix
2130
2131         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2132         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2133
2134 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2135
2136         Reviewed by Csaba Osztrogonác.
2137
2138         run-qtwebkit-tests should be able to kill a testsuite.
2139
2140         Add new option in the script that can setup a timeout for a test.
2141         If the test execution takes more then specified time then the test
2142         would be terminated.
2143
2144         [Qt] run-qtwebkit-tests needs timeout
2145         https://bugs.webkit.org/show_bug.cgi?id=51894
2146
2147         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2148         * Scripts/run-qtwebkit-tests:
2149
2150 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2151
2152         Unreviewed fix after r75233.
2153
2154         Based on idea from Eric Seidel.
2155
2156         Add remote zip file handling to webkitpy.
2157         https://bugs.webkit.org/show_bug.cgi?id=50901
2158
2159         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2160
2161 2011-01-07  Shane Stephens  <shanestephens@google.com>
2162
2163         Reviewed by Eric Seidel.
2164
2165         svn-apply: should support git binary delta diffs
2166         https://bugs.webkit.org/show_bug.cgi?id=38864
2167
2168         * Scripts/VCSUtils.pm:
2169         * Scripts/svn-apply:
2170
2171 2011-01-06  Julie Parent  <jparent@chromium.org>
2172
2173         Reviewed by Eric Seidel.
2174
2175         Test Result Server not removing old results.
2176         https://bugs.webkit.org/show_bug.cgi?id=52012
2177
2178         * TestResultServer/model/jsonresults.py:
2179         Fix off-by-one: Truncate if >= num_runs, not just >.
2180         * TestResultServer/model/jsonresults_unittest.py:
2181         Add unit test to test that merging in a new result with the same value
2182         as the last result causes previous result to fall off.
2183
2184 2011-01-06  James Kozianski  <koz@chromium.org>
2185
2186         Reviewed by Mihai Parparita.
2187
2188         Add classes to provide a consistent interface to a set of files.
2189         https://bugs.webkit.org/show_bug.cgi?id=50901
2190
2191         These classes allow us to write code that is agnostic to whether a
2192         particular set of files resides in a local directory or in a zip file
2193         on a remote machine.
2194
2195         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2196         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2197         * Scripts/webkitpy/common/system/fileset.py: Added.
2198         * Scripts/webkitpy/common/system/filesystem.py:
2199         * Scripts/webkitpy/common/system/filesystem_mock.py:
2200         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2201         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2202
2203 2011-01-06  Eric Seidel  <eric@webkit.org>
2204
2205         Reviewed by Adam Barth.
2206
2207         NetworkTransaction should log the url it is retrying
2208         https://bugs.webkit.org/show_bug.cgi?id=52043
2209
2210         * Scripts/webkitpy/common/net/networktransaction.py:
2211         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2212
2213 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2214
2215         Windows build fix.
2216         Import os before using it.
2217
2218         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2219
2220 2011-01-06  Eric Seidel  <eric@webkit.org>
2221
2222         Reviewed by Adam Barth.
2223
2224         StyleQueue fails to report errors when patches have many files
2225         https://bugs.webkit.org/show_bug.cgi?id=52042
2226
2227         This is one of at least two errors preventing style error reporting at the moment.
2228         When we moved to passing the list of files to check explicitly,
2229         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2230         We could change the type of the QueueStatus.message type, or we could
2231         just teach statusserver.py how to clamp values (and warn when it does).
2232         I chose the latter path.
2233
2234         * Scripts/webkitpy/common/net/statusserver.py:
2235
2236 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2237
2238         Reviewed by Stephanie Lewis.
2239         
2240         Fix syntax error in script.
2241
2242         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2243         https://bugs.webkit.org/show_bug.cgi?id=51996
2244
2245         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2246
2247 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2248
2249         Unreviewed, fixing WinCE build after r75196.
2250
2251         WinCE port does not (yet) support NPAPI.
2252
2253         * Scripts/build-webkit:
2254
2255 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2256
2257         Reviewed by Darin Adler.
2258
2259         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2260         https://bugs.webkit.org/show_bug.cgi?id=52015
2261
2262         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2263         after the platform has been detected, otherwise the script will
2264         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2265         detection.
2266
2267 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2268
2269         Reviewed by Eric Seidel.
2270
2271         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2272         https://bugs.webkit.org/show_bug.cgi?id=51346
2273
2274         * Scripts/build-webkit:
2275
2276 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2277
2278         Reviewed by Adam Roben.
2279
2280         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2281         https://bugs.webkit.org/show_bug.cgi?id=51996
2282         
2283         After the configuration directory change, we were archiving the incorrect directory for
2284         build product, so we were running tests on the wrong binaries.
2285         
2286         This change archives the correct directory, and also unarchives it into a configuration-
2287         specific directory.
2288
2289         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2290         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2291
2292 2011-01-06  Eric Seidel  <eric@webkit.org>
2293
2294         Reviewed by Mihai Parparita.
2295
2296         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2297         https://bugs.webkit.org/show_bug.cgi?id=52002
2298
2299         See an example of this here:
2300         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2301
2302         It's due to the fact that we pass around TestFailure() instance
2303         objects and yet expect them to all compare to be the same.
2304
2305         This is bad.  We should either have shared instances of these values
2306         or we should just pass around the class names.  There are already hacks
2307         in place to make TestFailure objects pass equality tests, I just added
2308         a __hash__ implementation so they can be used in sets as expected.
2309
2310         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2311         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2312
2313 2011-01-06  Evan Martin  <evan@chromium.org>
2314
2315         Reviewed by Tony Chang.
2316
2317         [gdb] handle inaccessible memory and UChar*
2318         https://bugs.webkit.org/show_bug.cgi?id=52003
2319
2320         To pretty-print a UChar*, we just grope around in the memory
2321         looking for a terminating NUL.  We need to handle the exception
2322         that can occur when we poke into an invalid location.
2323
2324         Additionally, the logic for choosing which pretty-printer would
2325         early return before hitting the point where we'd use the UChar*
2326         printer.  (Did this ever work?  How did it regress?)
2327
2328         * gdb/webkit.py:
2329
2330 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2331
2332         Reviewed by Ada Chan.
2333
2334         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2335         https://bugs.webkit.org/show_bug.cgi?id=51969
2336         
2337         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2338
2339         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2340         (WTR::InjectedBundlePage::InjectedBundlePage):
2341         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2342         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2343
2344 2011-01-06  James Robinson  <jamesr@chromium.org>
2345
2346         Reviewed by Simon Fraser.
2347
2348         Implement mozilla's animationTime property
2349         https://bugs.webkit.org/show_bug.cgi?id=51952
2350
2351         Chromium DRT support for webkitAnimationTime.
2352
2353         * DumpRenderTree/chromium/WebViewHost.cpp:
2354         (WebViewHost::paintInvalidatedRegion):
2355
2356 2011-01-06  Julie Parent  <jparent@chromium.org>
2357
2358         Reviewed by Tony Chang.
2359
2360         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2361         https://bugs.webkit.org/show_bug.cgi?id=51217
2362
2363         * TestResultServer/model/jsonresults.py:
2364         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2365         Adds missing documentation.
2366         * TestResultServer/model/jsonresults_unittest.py:
2367         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2368         Update test_merge to take a number of builds to truncate at.
2369
2370 2011-01-06  Adam Barth  <abarth@webkit.org>
2371
2372         Reviewed by Eric Seidel.
2373
2374         The EWS should log outside of the working directory
2375         https://bugs.webkit.org/show_bug.cgi?id=51986
2376
2377         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2378         script, which will actually clean the working copy back to a pristine
2379         state instead of leaving untracked directories and ignored files.
2380
2381         * Scripts/webkitpy/tool/commands/queues.py:
2382         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2383
2384 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2385
2386         Windows build fix.
2387         Back out attempted change to built-product-archive.
2388
2389         * BuildSlaveSupport/built-product-archive:
2390
2391 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2392
2393         Windows build fix.
2394         Include configuration name when unpacking a build archive.
2395
2396         Needed, since we split Windows build results into configuration-specific directories
2397         under WebKitOutputDir.
2398
2399         * BuildSlaveSupport/built-product-archive:
2400
2401 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2402
2403         Reviewed by Darin Adler.
2404
2405         Debug and Release builds on Windows clobber each other
2406         https://bugs.webkit.org/show_bug.cgi?id=49185
2407
2408         Changes the structure of WebKitBuild build products directory so we
2409         completely separate each build configuration into independent directories.
2410         
2411         Although we previously had per-configuration directories for obj, this change adds
2412         per-configuration directories for bin, lib, obj, and include. Each configuration's
2413         build products are stored within a directory inside of WebKitBuild.
2414         
2415         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2416         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2417
2418         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2419         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2420         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2421         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2422         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2423         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2424         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2425         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2426         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2427         * FindSafari/FindSafari.vcproj:
2428         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2429         * MiniBrowser/MiniBrowserPostBuild.cmd:
2430         * MiniBrowser/MiniBrowserPreBuild.cmd:
2431         * Scripts/webkitdirs.pm:
2432         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2433         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2434         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2435         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2436         * TestWebKitAPI/win/copy-resources.cmd:
2437         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2438         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2439         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2440         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2441         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2442         * WebKitTestRunner/win/InjectedBundle.vcproj:
2443         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2444         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2445         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2446         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2447         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2448         * WinLauncher/WinLauncherCommon.vsprops:
2449         * WinLauncher/WinLauncherPostBuild.cmd:
2450         * WinLauncher/WinLauncherPreBuild.cmd:
2451
2452 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2453
2454         Reviewed by Ariya Hidayat.
2455
2456         [Qt] TestNetscapePlugin doesn't link on OS X
2457         https://bugs.webkit.org/show_bug.cgi?id=51948
2458
2459         Only add a dependency on libX11 on X11 systems
2460
2461         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2462
2463 2011-01-05  Jeff Miller  <jeffm@apple.com>
2464
2465         Reviewed by Adam Roben.
2466
2467         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2468         https://bugs.webkit.org/show_bug.cgi?id=51970
2469
2470         * Scripts/webkitpy/style/checker.py:
2471         Add -readability/naming for WebKit2 C API directories.
2472
2473 2011-01-05  Eric Seidel  <eric@webkit.org>
2474
2475         Unreviewed, just fixing one more log error from my previous python patch.
2476
2477         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2478         https://bugs.webkit.org/show_bug.cgi?id=51802
2479
2480         webkit-patch failure-reason was logging about parsing errors
2481         due to my misunderstanding of how BeautifulSoup.findAll worked.
2482
2483         Fixed, and added a unit test.
2484
2485         * Scripts/webkitpy/common/net/layouttestresults.py:
2486         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2487
2488 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2489
2490         Reviewed by Kenneth Rohde Christiansen.
2491
2492         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2493         https://bugs.webkit.org/show_bug.cgi?id=51951
2494
2495         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2496         to create new window from WebKit.
2497
2498         * MiniBrowser/qt/BrowserWindow.cpp:
2499         (newPageFunction):
2500         (BrowserWindow::BrowserWindow):
2501         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2502         (BrowserWindow::newWindow):
2503         (BrowserWindow::updateUserAgentList):
2504         (BrowserWindow::showUserAgentDialog):
2505         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2506         define the type of the backing store used for new windows.
2507         * MiniBrowser/qt/main.cpp:
2508         (main):
2509
2510 2011-01-05  Eric Seidel  <eric@webkit.org>
2511
2512         Reviewed by Ojan Vafai.
2513
2514         commit-queue should report failure type when reporting flaky tests
2515         https://bugs.webkit.org/show_bug.cgi?id=51900
2516
2517         This patch was a ridiculous amount of plumbing.  In the end I like
2518         the NRWT-style TestResult class even less.  But now we're passing
2519         a list of TestResult objects from the queue to the FlakyTestReporter.
2520         Thus the FlakyTestReporter can more easily report what type of failure
2521         occurred.
2522
2523         In the process, I found that I was not alone in finding TestResult
2524         cumbersome to use.  A bunch of code was trying to create a TestResult
2525         object with default values.  However since the constructor didn't make
2526         this easy, some places were getting it wrong (including the TestResult unit test)!
2527         I've fixed the TestResult constructor to have default values for non-essential
2528         arguments.
2529
2530         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2531         * Scripts/webkitpy/common/net/layouttestresults.py:
2532         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2533         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2534         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2535         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2536         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2537         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2538         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2539         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2540         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2541         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2542         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2543         * Scripts/webkitpy/tool/commands/queues.py:
2544         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2545
2546 2011-01-05  Eric Seidel  <eric@webkit.org>
2547
2548         Unreviewed.
2549
2550         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2551         https://bugs.webkit.org/show_bug.cgi?id=51802
2552
2553         Add another unit test to cover a previously missing import.
2554
2555         * Scripts/webkitpy/common/net/layouttestresults.py:
2556         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2557
2558 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2559
2560         Reviewed by David Levin.
2561
2562         Add mihaip@chromium.org as a reviewer
2563         https://bugs.webkit.org/show_bug.cgi?id=51966
2564         
2565         Add myself as a reviewer.
2566
2567         * Scripts/webkitpy/common/config/committers.py:
2568
2569 2011-01-05  James Simonsen  <simonjam@chromium.org>
2570
2571         Unreviewed. Adding myself to the list of committers.
2572
2573         * Scripts/webkitpy/common/config/committers.py:
2574
2575 2011-01-05  Eric Seidel  <eric@webkit.org>
2576
2577         Unreviewed.
2578
2579         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2580         https://bugs.webkit.org/show_bug.cgi?id=51802
2581
2582         Fix two exceptions seen on the bots after my original commit.
2583
2584         * Scripts/webkitpy/common/net/layouttestresults.py:
2585         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2586
2587 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2588
2589         Reviewed by Andreas Kling.
2590
2591         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2592         https://bugs.webkit.org/show_bug.cgi?id=51750
2593
2594         * QtTestBrowser/main.cpp:
2595         (LauncherApplication::handleUserOptions):
2596          Local storage settings can be enable form command line arguments for
2597          QtTestBrowser.
2598
2599 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2600
2601         Reviewed by Martin Robinson.
2602
2603         GTK: AX: DRT needs to use correct root object method.
2604         https://bugs.webkit.org/show_bug.cgi?id=51911
2605
2606         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2607         (AccessibilityController::rootElement):
2608
2609 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2610
2611         Rubber-stamped by Csaba Osztrogonác.
2612
2613         Based on idea from Péter Gál.
2614
2615         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2616
2617 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2618
2619         Reviewed by Adam Barth.
2620
2621         sheriff-bot should be able to do multi-revision rollouts
2622         https://bugs.webkit.org/show_bug.cgi?id=51176
2623
2624         * Scripts/webkitpy/tool/bot/irc_command.py:
2625         * Scripts/webkitpy/tool/bot/sheriff.py:
2626         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2627
2628 2011-01-05  Eric Seidel  <eric@webkit.org>
2629
2630         Reviewed by Adam Barth.
2631
2632         queues.webkit.org should have per-bot status pages
2633         https://bugs.webkit.org/show_bug.cgi?id=51906
2634
2635         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2636         statuses from a single queue.  Now that we have many bots servicing
2637         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2638         you care about scroll off the end of the 15-message limit on the main page.
2639
2640         Eventually we should probably rename /queue-status to /queue or /queues,
2641         but that's fodder for another patch.
2642
2643         * QueueStatusServer/handlers/queuestatus.py:
2644         * QueueStatusServer/index.yaml:
2645         * QueueStatusServer/main.py:
2646         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2647          - This probably should use a custom filter instead of hard-coding
2648            the URL scheme here, but I couldn't figure out how to easily
2649            create such a filter.  Most filters work with "strings" so we can't
2650            pass the status object.  We could add a method to the status
2651            object and call that, but that seemed a bit strange too.
2652         * QueueStatusServer/templates/queuestatus.html:
2653
2654 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2655
2656         Unreviewed. Adding myself to the list of committers.
2657
2658         * Scripts/webkitpy/common/config/committers.py:
2659
2660 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2661
2662         Reviewed by David Levin.
2663
2664         check-webkit-style treated some macros with parentheses after #elif as function calls
2665         https://bugs.webkit.org/show_bug.cgi?id=51695
2666
2667         Ingore function call space checking in any preprocessor directives
2668         (things starting with #). Change search() to match() because 
2669         preprocessor directives are supposed to be in the beginning of lines.
2670
2671         * Scripts/webkitpy/style/checkers/cpp.py:
2672         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2673
2674 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2675
2676         Reviewed by Tony Chang.
2677
2678         Change the --multi-load test option to --stress-opt
2679         https://bugs.webkit.org/show_bug.cgi?id=50751
2680
2681         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2682         (runTest):
2683         (main):
2684         * DumpRenderTree/chromium/TestShell.cpp:
2685         (TestShell::TestShell):
2686         * DumpRenderTree/chromium/TestShell.h:
2687         (TestShell::stressOpt):
2688         (TestShell::setStressOpt):
2689         (TestShell::stressDeopt):
2690         (TestShell::setStressDeopt):
2691         (TestShell::javaScriptFlags):
2692         (TestShell::setJavaScriptFlags):
2693         * Scripts/webkitpy/layout_tests/port/chromium.py:
2694         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2695
2696 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2697
2698         Reviewed by Sam Weinig.
2699
2700         WK2: Support Accessibility
2701         https://bugs.webkit.org/show_bug.cgi?id=51859
2702
2703         Use rootObject() method to get top of accessibility tree.
2704
2705         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2706         (AccessibilityController::focusedElement):
2707         (AccessibilityController::rootElement):
2708
2709 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2710
2711         Reviewed by Darin Adler.
2712
2713         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2714         https://bugs.webkit.org/show_bug.cgi?id=51846
2715
2716         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2717         back to GRefPtr.
2718
2719 2011-01-04  Zhe Su  <suzhe@chromium.org>
2720
2721         Reviewed by Kenneth Russell.
2722
2723         Fix insertText, setMarkedText and unmarkText methods of
2724         TextInputController to call corresponding methods of WebKit::WebView
2725         rather than WebKit::WebFrame. This change matches the behavior of
2726         chromium browser.
2727         insertText corresponds to WebView::confirmComposition(text)
2728         setMarkedText corresponds to WebView::setComposition(...)
2729         unmarkText corresponds to WebView::confirmComposition()
2730         https://bugs.webkit.org/show_bug.cgi?id=51693
2731
2732         * DumpRenderTree/chromium/TextInputController.cpp:
2733         (TextInputController::insertText):
2734         (TextInputController::setMarkedText):
2735         (TextInputController::unmarkText):
2736
2737 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2738
2739         Reviewed by Laszlo Gombos.
2740
2741         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2742
2743         On Symbian productDir points to the source directory. Removing all the
2744         empty files from the productDir directory corrupts the svn repository.
2745
2746         * Scripts/build-webkit:
2747
2748 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2749
2750         Reviewed by Adam Barth.
2751
2752         [Qt] Add SelectAll option to the context menu for the editor
2753         https://bugs.webkit.org/show_bug.cgi?id=50049
2754
2755         Set shortcut for the SelectAll action.
2756
2757         * QtTestBrowser/mainwindow.cpp:
2758         (MainWindow::buildUI):
2759
2760 2011-01-03  David Levin  <levin@chromium.org>
2761
2762         Reviewed by Eric Seidel.
2763
2764         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2765         https://bugs.webkit.org/show_bug.cgi?id=51842
2766
2767         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2768         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2769
2770 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2771
2772         Reviewed by David Kilzer.
2773
2774         [WINCE] Adds a build slave.
2775         https://bugs.webkit.org/show_bug.cgi?id=50523
2776
2777         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2778         entry for a release build of the WinCE port.
2779         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2780         flag to build the WinCE port.
2781
2782 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2783
2784         Reviewed by David Kilzer.
2785
2786         Add WinCE support to build-webkit
2787         https://bugs.webkit.org/show_bug.cgi?id=51642
2788
2789         * Scripts/build-webkit:
2790         * Scripts/webkitdirs.pm:
2791
2792 2011-01-03  Eric Seidel  <eric@webkit.org>
2793
2794         Reviewed by Adam Barth.
2795
2796         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2797         https://bugs.webkit.org/show_bug.cgi?id=51802
2798
2799         I'm not the biggest fan of the test_failures or test_results classes,
2800         but it's better to have one shared set of classes, than separate ones
2801         for new vs. old run-webkit-test result handling.
2802
2803         This moves the ORWT results class "LayoutTestResults" over to using
2804         TestResult and TestFailure classes, making it easy for us to
2805         make all our sheriff-bot and other webkitpy code NRWT ready.
2806
2807         This also makes it a trivial patch to generate results.json information
2808         from ORWT results.html files (for flaky test analysis, etc.) as well
2809         as making it a one-liner to report test failure types when the
2810         commit-queue sees flaky tests.
2811
2812         This patch tried not to add new functionality, but only to replace
2813         the guts of LayoutTestResults, while adding unit tests and hoping
2814         not to break anything.
2815
2816         I also moved callers which assumed User.prompt* were static/class methods
2817         to using them as instance methods (since we'll eventually want to make them such).
2818
2819         In the process of re-writing things, I broke the rebaseline command, so I wrote
2820         a unit test to catch my breakage were I do do so again in the future.
2821
2822         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2823         * Scripts/webkitpy/common/net/layouttestresults.py:
2824         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2825         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2826         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2827         * Scripts/webkitpy/tool/commands/queries.py:
2828         * Scripts/webkitpy/tool/commands/rebaseline.py:
2829         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2830         * Scripts/webkitpy/tool/mocktool.py:
2831
2832 2011-01-03  Adam Barth  <abarth@webkit.org>
2833
2834         Reviewed by Simon Fraser.
2835
2836         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2837         https://bugs.webkit.org/show_bug.cgi?id=51840
2838
2839         * Scripts/webkitpy/common/checkout/scm.py:
2840
2841 2011-01-03  Adam Barth  <abarth@webkit.org>
2842
2843         Reviewed by Simon Fraser.
2844
2845         webkit-patch should only hide update output if --quiet
2846         https://bugs.webkit.org/show_bug.cgi?id=51838
2847
2848         As requested by smfr.
2849
2850         * Scripts/webkitpy/tool/steps/update.py:
2851
2852 2011-01-03  Adam Barth  <abarth@webkit.org>
2853
2854         Reviewed by David Levin.
2855
2856         commit-queue shouldn't reject patches twice if two bots process the same patch
2857         https://bugs.webkit.org/show_bug.cgi?id=51805
2858
2859         Before raising an error, we first check whether the patch is still in
2860         the commit-queue.  This check is still racy, of course, but the time
2861         window is much smaller.
2862
2863         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2864
2865 2011-01-03  Sam Weinig  <sam@webkit.org>
2866
2867         Reviewed by Anders Carlsson.
2868
2869         Make run-api-tests less chatty.
2870         https://bugs.webkit.org/show_bug.cgi?id=51831
2871
2872         - Make script quiet by default and add --verbose option (replacing --quiet).
2873         - When not verbose, pipe stdout and stderr to devnull.
2874
2875         * Scripts/run-api-tests:
2876
2877 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2878
2879         Unreviewed. Adding myself to committers.py.
2880
2881         * Scripts/webkitpy/common/config/committers.py:
2882
2883 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2884
2885         Reviewed by Xan Lopez.
2886
2887         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2888         https://bugs.webkit.org/show_bug.cgi?id=51806
2889
2890         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2891         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2892         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2893         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2894         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2895         so make it 'WebKitBuild/Release/.libs'
2896
2897         * Scripts/webkitdirs.pm: 
2898
2899 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2900
2901         Reviewed by Adam Barth.
2902
2903         Make EFL a core builder
2904         https://bugs.webkit.org/show_bug.cgi?id=51804
2905
2906         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2907         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2908
2909 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2910
2911         [Qt] Unreviewed fix after r74855 and r74875.
2912
2913         * BuildSlaveSupport/built-product-archive:
2914          - Create directories explicitly.
2915          - Pass shell=True to subprocess.call().
2916
2917 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2918
2919         [Qt] Unreviewed fix after r74855.
2920
2921         Move JavaScriptCore to Source
2922         https://bugs.webkit.org/show_bug.cgi?id=51604
2923
2924         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2925
2926 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2927
2928         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2929
2930         Move JavaScriptCore to Source
2931         https://bugs.webkit.org/show_bug.cgi?id=51604
2932
2933         * Scripts/webkitdirs.pm:
2934
2935 2011-01-02  Robert Hogan  <robert@webkit.org>
2936
2937         Unreviewed, build fix.
2938
2939         [Qt] Fix DRT build after 74855
2940
2941         * DumpRenderTree/qt/DumpRenderTree.pro:
2942
2943 2011-01-01  Adam Barth  <abarth@webkit.org>
2944
2945         Remove the assumption from the Qt and Gtk builds that every project is
2946         in the root directory.
2947
2948         * Scripts/build-webkit:
2949
2950 2011-01-01  Adam Barth  <abarth@webkit.org>
2951
2952         Reviewed by Eric Seidel.
2953
2954         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2955         https://bugs.webkit.org/show_bug.cgi?id=51796
2956
2957         After this change, svn-apply will magically apply patches to
2958         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2959
2960         * Scripts/VCSUtils.pm:
2961
2962 2011-01-01  Adam Barth  <abarth@webkit.org>
2963
2964         Reviewed by Eric Seidel.
2965
2966         Move JavaScriptCore to Source
2967         https://bugs.webkit.org/show_bug.cgi?id=51604
2968
2969         Update references to JavaScriptCore to point to the new location.
2970
2971         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2972         * DumpRenderTree/qt/DumpRenderTree.pro:
2973         * DumpRenderTree/qt/ImageDiff.pro:
2974         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2975         * DumpRenderTree/wscript:
2976         * Scripts/build-jsc:
2977         * Scripts/build-webkit:
2978         * Scripts/do-file-rename:
2979         * Scripts/do-webcore-rename:
2980         * Scripts/run-javascriptcore-tests:
2981         * Scripts/update-javascriptcore-test-results:
2982         * Scripts/webkitdirs.pm:
2983         * Scripts/webkitpy/common/config/build_unittest.py:
2984         * Scripts/webkitpy/style/checker.py:
2985         * Scripts/webkitpy/style/checker_unittest.py:
2986         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2987         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2988         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2989         * wx/build/settings.py:
2990
2991 2011-01-01  Adam Barth  <abarth@webkit.org>
2992
2993         Reviewed by Eric Seidel.
2994
2995         Move Sources to Source
2996         https://bugs.webkit.org/show_bug.cgi?id=51794
2997
2998         Update scripts to point to the new location.
2999
3000         * Scripts/build-webkit:
3001         * Scripts/do-file-rename:
3002         * Scripts/do-webcore-rename:
3003         * Scripts/webkitpy/common/config/build.py:
3004         * Scripts/webkitpy/common/config/build_unittest.py:
3005
3006 2010-12-31  Kent Tamura  <tkent@chromium.org>
3007
3008         Reviewed by Eric Seidel.
3009
3010         [DRT/Chromium] Enable mock spell checker on non-OSX
3011         https://bugs.webkit.org/show_bug.cgi?id=51401
3012
3013         * DumpRenderTree/chromium/WebViewHost.cpp:
3014         (WebViewHost::spellCheck):
3015
3016 2010-12-31  Adam Barth  <abarth@webkit.org>
3017
3018         Reviewed by Ariya Hidayat.
3019
3020         Remove Tools/Scripts/wkstyle
3021         https://bugs.webkit.org/show_bug.cgi?id=51774
3022
3023         This script appears to not have been touched in a while and seems to
3024         have been replaced by check-webkit-style.
3025
3026         * Scripts/wkstyle: Removed.
3027
3028 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3029
3030         Unreviewed. Coding style fix.
3031
3032         * DumpRenderTree/chromium/TestShell.h:
3033
3034 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3035
3036         Reviewed by Pavel Feldman.
3037
3038         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3039
3040         It was a problem with Chromium DRT. DevToolsAgent object instance was
3041         attached not only to the inspected page but to the DevTools window too.
3042         As result all the inspector files were interpreted as a content of inspected page
3043         and were transfered to the DevTools scripts panel for debugging etc.
3044
3045         https://bugs.webkit.org/show_bug.cgi?id=51735
3046
3047         * DumpRenderTree/chromium/TestShell.cpp:
3048         (TestShell::TestShell):
3049         (TestShell::bindJSObjectsToWindow):
3050         (TestShell::createNewWindow):
3051         * DumpRenderTree/chromium/TestShell.h:
3052
3053 2010-12-31  Adam Barth  <abarth@webkit.org>
3054
3055         Rubber-stamped by Eric Seidel.
3056
3057         Move PageLoadTests to PerformanceTests/PageLoad
3058         https://bugs.webkit.org/show_bug.cgi?id=51771
3059
3060         Update references to PageLoadTests to point to the new location.
3061
3062         * Scripts/run-pageloadtest:
3063         * Scripts/webkitpy/common/config/build.py:
3064
3065 2010-12-31  Adam Barth  <abarth@webkit.org>
3066
3067         Rubber-stamped by Eric Seidel.
3068
3069         Move SunSpider into PerformanceTests
3070         https://bugs.webkit.org/show_bug.cgi?id=51769
3071
3072         Update these scripts to point to the new location.
3073
3074         * Scripts/run-sunspider:
3075         * Scripts/sunspider-compare-results:
3076
3077 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3078
3079         Reviewed by Kent Tamura.
3080
3081         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3082         https://bugs.webkit.org/show_bug.cgi?id=51728
3083         
3084         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3085         to render top-level scrollbars. This makes them match the Mac port's
3086         use of an NSScrollView, which means that we'll be able to share more
3087         pixel baselines.
3088         
3089         The new rendering code will not be activated until the 
3090         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3091         ScrollbarThemeChromiumMac.
3092
3093         * DumpRenderTree/DumpRenderTree.gypi:
3094         * DumpRenderTree/chromium/TestShellMac.mm:
3095         (platformInit):
3096         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3097         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3098         (+[FakeActiveWindow alwaysActiveWindow]):
3099         (+[FakeActiveWindow alwaysInactiveWindow]):
3100         (-[FakeActiveWindow initWithActiveControls:]):
3101         (-[FakeActiveWindow _hasActiveControls]):
3102         (WebThemeEngineDRTMac::paintScrollbarThumb):
3103         (stateToHIEnableState):
3104         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3105         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3106
3107 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3108
3109         Reviewed by David Kilzer.
3110
3111         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3112         used
3113         https://bugs.webkit.org/show_bug.cgi?id=51672
3114
3115         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3116         with USE_SYSTEM_MALLOC=1
3117         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3118         with USE_SYSTEM_MALLOC=1
3119
3120 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3121
3122         Reviewed by David Kilzer.
3123
3124         [Qt] [Symbian] Fix build-webkit script for Symbian
3125         https://bugs.webkit.org/show_bug.cgi?id=51509
3126
3127         Set the OUTPUT_DIR for Symbian to be the same as the source
3128         directory.
3129
3130         * Scripts/webkitdirs.pm:
3131
3132 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3133
3134         Reviewed by Darin Adler.
3135
3136         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3137         https://bugs.webkit.org/show_bug.cgi?id=51758
3138
3139         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3140
3141         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3142         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3143
3144 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3145
3146         Unreviewed WinCE buildfix.
3147
3148         * WinCELauncher/main.cpp: Add missing include.
3149
3150 2010-12-29  Daniel Bates  <dbates@rim.com>
3151
3152         Reviewed by Darin Adler.
3153
3154         svn-apply updates date of wrong change log entry for a change log diff that
3155         contains two consecutive entries with the same author and date
3156         https://bugs.webkit.org/show_bug.cgi?id=46061
3157
3158         Fixes an issue where the date of the wrong change log entry may be modified.
3159         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3160         in a ChangeLog file to the top of the file.
3161
3162         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3163         diff when it detects that the diff inserts a change log entry earlier in a
3164         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3165         change. With the advent of the commit-queue this functionality of bailing out
3166         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3167         Instead, we should always move the change log entry to the top of the ChangeLog file.
3168
3169         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3170         the date line of the correct change log entry in a ChangeLog diff.
3171
3172         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3173
3174         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3175           Updated the following unit tests now that we move entries inserted earlier to the top:
3176           - "fixChangeLogPatch: New entry inserted in middle."
3177             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3178
3179           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3180             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3181
3182         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3183
3184 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3185
3186         Reviewed by Eric Seidel.
3187
3188         [Qt] Fixed compatibility with gold linker on X11 platforms
3189         https://bugs.webkit.org/show_bug.cgi?id=51700
3190
3191         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3192         Linked TestNetscapePlugin with libX11 on Unix platforms
3193
3194 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3195
3196         Reviewed by Darin Adler.
3197
3198         Circular dependency in webkitpy.common.checkout.changelog module
3199         https://bugs.webkit.org/show_bug.cgi?id=50475
3200
3201         Remove automatic import of api.Checkout module when any checkout/
3202         submodule is imported (e.g.: when checkout.scm.Git is imported).
3203
3204         * Scripts/webkitpy/common/checkout/__init__.py:
3205
3206 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3207
3208         Reviewed by Ojan Vafai.
3209
3210         prepare-ChangeLog should support the -g option for specifying the git-commit
3211         https://bugs.webkit.org/show_bug.cgi?id=51708
3212
3213         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3214         webkit-patch, though the exact meaning of the two options remain different.
3215
3216         * Scripts/prepare-ChangeLog: Add -g.
3217
3218 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3219
3220         Reviewed by Simon Hausmann.
3221
3222         [Qt] Fix compilation with Qt in namespace
3223         https://bugs.webkit.org/show_bug.cgi?id=51701
3224
3225         * QtTestBrowser/webview.h:
3226
3227 2010-12-28  Daniel Bates  <dbates@rim.com>
3228
3229         Reviewed by Sam Weinig.
3230
3231         Substitute // MARK: for compiler-specific #pragma mark
3232         https://bugs.webkit.org/show_bug.cgi?id=51657
3233
3234         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3235         substituting  "// MARK:" for "#pragma mark", which provides
3236         analogous code-bookmarking functionality under Xcode.
3237
3238         Also, for consistency, we should substitute "// MARK:" for compiler-
3239         specific "#pragma mark" in the source files for the Mac port.
3240
3241         * DumpRenderTree/AccessibilityTextMarker.cpp:
3242         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3243         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3244         * DumpRenderTree/mac/ObjCController.m:
3245         * MiniBrowser/mac/AppDelegate.m:
3246         * MiniBrowser/mac/BrowserWindowController.m:
3247
3248 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3249
3250         Reviewed by Eric Seidel.
3251
3252         Add --no-build option to run-sunspider
3253         https://bugs.webkit.org/show_bug.cgi?id=51658
3254
3255         * Scripts/run-sunspider: add --no-build flag to skip building
3256         phase.
3257
3258 2010-12-27  Daniel Bates  <dbates@rim.com>
3259
3260         Rubber-stamped by Martin Robinson.
3261
3262         Append the directory Tools/DumpRenderTree to the list of directories that
3263         do-webcore-rename should search so that it can rename DRT files and
3264         source code.
3265
3266         * Scripts/do-webcore-rename:
3267
3268 2010-12-27  Eric Seidel  <eric@webkit.org>
3269
3270         Reviewed by Adam Barth.
3271
3272         build-webkit should detect missing Java SDK and explain how to install it
3273         https://bugs.webkit.org/show_bug.cgi?id=51651
3274
3275         * Scripts/build-webkit:
3276
3277 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3278
3279         Reviewed by Daniel Bates.
3280
3281         [GTK] Add support for build-jsc
3282         https://bugs.webkit.org/show_bug.cgi?id=51625
3283
3284         Add GTK+ support to build-jsc now that building the jsc executable as
3285         a standalone target is easy.
3286
3287         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3288         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3289         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3290         and pass it along to buildAutotoolsProject.
3291
3292 2010-12-27  David Levin  <levin@chromium.org>
3293
3294         Reviewed by Eric Seidel.
3295
3296         check-webkit-style check for meaningless variable names in function declarations.
3297         https://bugs.webkit.org/show_bug.cgi?id=51523
3298
3299         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3300         from the new check and whitespace/parens because the syntax is unusual and
3301         produced a fair number of positives for these checks.
3302         * Scripts/webkitpy/style/checkers/cpp.py:
3303         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3304         and parameter names when determining if the parameter name is useless.
3305         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3306         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3307         format.
3308         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3309         text or an acronym of it.
3310         (check_function_definition): Checks function definitions for meaningless variable names.
3311         (process_line): Added call to check_function_definition.
3312         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3313         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3314         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3315         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3316         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3317         because when only checking a snippet, there are a lot of bogus functions.
3318         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3319         that I put there previously and just noticed.
3320         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3321         check_function_definition and process_line.
3322
3323 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3324
3325         Reviewed by Martin Robinson.
3326
3327         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3328         https://bugs.webkit.org/show_bug.cgi?id=51591
3329
3330         Flash plugin uses gtk2 that is incompatible with gtk3 making
3331         webkit crash when it's built with gtk3.
3332
3333         * GtkLauncher/main.c:
3334         (main):
3335
3336 2010-12-25  Adam Barth  <abarth@webkit.org>
3337
3338         Reviewed by Eric Seidel.
3339
3340         Move ANGLE to Sources/ThirdParty
3341         https://bugs.webkit.org/show_bug.cgi?id=51605
3342
3343         * Scripts/build-webkit:
3344           - Point to the new ANGLE location.
3345
3346 2010-12-26  David Levin  <levin@chromium.org>
3347
3348         Reviewed by Eric Seidel.
3349
3350         check-webkit-style should be able to parse function declaration parameters.
3351         https://bugs.webkit.org/show_bug.cgi?id=51451
3352
3353         * Scripts/webkitpy/style/checkers/cpp.py:
3354         (Position.__init__): Holds simple position information (row, column).
3355         (Parameter.__init__): Holds information about a parameter.
3356         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3357         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3358         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3359         (find_parameter_name_index): Finds where the parameter name is.
3360         (parameter_list): Generates the list of parameters for a function.
3361         (_FunctionState.begin): Added information to allow determining the parameters
3362         on demand.
3363         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3364         (detect_functions): Improve function detection for operator functions and
3365         determine where the parameters end and pass that to _FunctionState.begin.
3366         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3367         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3368         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3369         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3370         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3371         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3372         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3373         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3374         the parameters found.
3375         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3376         detection test to verify that we catch the operator functions.
3377         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3378         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3379         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3380         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3381         test_function_length_check_definition_severity1_for_test.
3382
3383 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3384
3385         Unreviewed WinCE buildfix after r74334.
3386
3387         * CMakeListsWinCE.txt:
3388
3389 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3390
3391         Unreviewed, rolling out r74632.
3392         http://trac.webkit.org/changeset/74632
3393         https://bugs.webkit.org/show_bug.cgi?id=51600
3394
3395         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3396         on #webkit).
3397
3398         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3399         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3400
3401 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3402
3403         Reviewed by Kenneth Rohde Christiansen.
3404
3405         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3406         https://bugs.webkit.org/show_bug.cgi?id=43528
3407
3408         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3409         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3410         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3411         called.
3412
3413         * EWebLauncher/main.c:
3414         (browserCreate):
3415
3416 2010-12-24  Eric Seidel  <eric@webkit.org>
3417
3418         Reviewed by Adam Barth.
3419
3420         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3421         https://bugs.webkit.org/show_bug.cgi?id=28291
3422
3423         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3424         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3425         to strings with find in the diff.
3426         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3427
3428         * Scripts/webkitpy/common/checkout/api.py:
3429         * Scripts/webkitpy/common/checkout/diff_parser.py:
3430         * Scripts/webkitpy/tool/steps/abstractstep.py:
3431         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3432         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3433         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3434         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3435
3436 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3437
3438         Reviewed by Kenneth Russell.
3439
3440         Modify new-run-webkit-tests to shut up and exit when all the threads
3441         are wedged so that test runs complete faster and we don't end up
3442         w/ enormous log files.
3443
3444         https://bugs.webkit.org/show_bug.cgi?id=51572
3445
3446         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3447         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3448
3449 2010-12-24  Eric Seidel  <eric@webkit.org>
3450
3451         Reviewed by David Levin.
3452
3453         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3454         https://bugs.webkit.org/show_bug.cgi?id=51549
3455
3456         I've had multiple people ask me about the commit-queue's behavior
3457         regarding reporting flaky tests.  I figured it would be best to just
3458         have the queue explain itself in the bugs it files.
3459
3460         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3461         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3462
3463 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3464
3465         Reviewed by Eric Seidel.
3466
3467         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3468         https://bugs.webkit.org/show_bug.cgi?id=51467
3469
3470         * Scripts/webkitpy/style/checker.py:
3471         * Scripts/webkitpy/style/checker_unittest.py:
3472
3473 2010-12-23  Adam Barth  <abarth@webkit.org>
3474
3475         Rubber-stamped by Eric Seidel.
3476
3477         Move JavaScriptGlue into Sources
3478         https://bugs.webkit.org/show_bug.cgi?id=51583
3479
3480         These tools refer to JavaScriptGlue and need to be updated to its new
3481         location.
3482
3483         * Scripts/build-webkit:
3484         * Scripts/do-file-rename:
3485         * Scripts/do-webcore-rename:
3486         * Scripts/webkitpy/common/config/build.py:
3487         * Scripts/webkitpy/common/config/build_unittest.py:
3488
3489 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3490
3491         Reviewed by Eric Seidel.
3492
3493         Bug 51539 - update iexploder scripts to point to new location
3494
3495         * Scripts/run-iexploder-tests:
3496         * Scripts/update-iexploder-cssproperties:
3497
3498 2010-12-23  Evan Martin  <evan@chromium.org>
3499
3500         Reviewed by Ryosuke Niwa.
3501
3502         [chromium] LayoutTestController warning in float->int conversion
3503         https://bugs.webkit.org/show_bug.cgi?id=51553
3504
3505         Rather than reading an int, converting to a float, then getting a compiler
3506         warning on passing the float to something that expects an int, instead
3507         just pass around ints.
3508
3509         No tests, fixes a compiler warning.
3510
3511         * DumpRenderTree/chromium/LayoutTestController.cpp:
3512         (parsePageSizeParameters):
3513         (LayoutTestController::pageNumberForElementById):
3514         (LayoutTestController::numberOfPages):
3515
3516 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3517
3518         Reviewed by Darin Adler.
3519
3520         Bug 51537 - iexploder needs cleanup
3521         
3522         * iExploder/htdocs: Removed.
3523         * iExploder/htdocs/config.rb: Removed.
3524         * iExploder/htdocs/cssproperties.in: Removed.
3525         * iExploder/htdocs/cssvalues.in: Removed.
3526         * iExploder/htdocs/htmlattrs.in: Removed.
3527         * iExploder/htdocs/htmltags.in: Removed.
3528         * iExploder/htdocs/htmlvalues.in: Removed.
3529         * iExploder/htdocs/iexploder.cgi: Removed.
3530         * iExploder/htdocs/iexploder.rb: Removed.
3531         * iExploder/htdocs/index.html: Removed.
3532         * iExploder/htdocs/webserver.rb: Removed.
3533         * iExploder/iexploder-1.7.2/output: Removed.
3534         * iExploder/tools: Removed.
3535         * iExploder/tools/lasthit.rb: Removed.
3536         * iExploder/tools/osx_last_crash.rb: Removed.
3537         * iExploder/tools/showtest.rb: Removed.
3538
3539 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3540
3541         Reviewed by Kenneth Rohde Christiansen.
3542
3543         [EFL] Make 'single' the default backing store in EWebLauncher
3544         https://bugs.webkit.org/show_bug.cgi?id=51534
3545
3546         'single' is the simplest backing store and the one intended to be the
3547         default in the test browser. By mistake the tiled backing store was
3548         left as default in r72617.
3549
3550         * EWebLauncher/main.c:
3551         (browserCreate): ditto.
3552
3553 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3554
3555         Reviewed by Kenneth Rohde Christiansen.
3556
3557         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3558         https://bugs.webkit.org/show_bug.cgi?id=51533
3559
3560         There's no point in concatenating env("HOME") with "blah", so remove
3561         option from EWebLauncher.
3562
3563         * EWebLauncher/main.c:
3564         (main): ditto.
3565
3566 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3567
3568         Reviewed by Eric Seidel.
3569
3570         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3571
3572         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3573         I just discovered that we have two additional GC runs per each WebViewHost.
3574         Test_shell had no such calls.
3575         These gc runs eat 15% of cpu time.
3576
3577         https://bugs.webkit.org/show_bug.cgi?id=51479
3578
3579         * DumpRenderTree/chromium/WebViewHost.cpp:
3580         (WebViewHost::~WebViewHost):
3581
3582 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3583
3584         Reviewed by Ojan Vafai.
3585
3586         This change splits out the TestRunner class into its own file.
3587         When we fork the code for message passing, we will create a new
3588         TestRunner, and this change will allow that to be more modular.
3589
3590         While we're at it, split out TestInput and ResultSummary into
3591         their own files, to reduce the size of run_webkit_tests to
3592         something more managable.
3593
3594         https://bugs.webkit.org/show_bug.cgi?id=51092
3595
3596         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3597         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3598         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3599         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3600         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3601         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3602         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3603
3604  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3605
3606         Reviewed by Ojan Vafai.
3607
3608         nrwt multiprocessing - start over, prepare to fork the code
3609  
3610         This code cleans up the signatures and implementation of the
3611         TestRunner class so we can easily fork it to run either the
3612         stable implementation or the new, unstable message-passing
3613         implementation. The two variants will have different
3614         implementations of the run_tests() method. We will switch
3615         between the two based on the setting for the '--worker-model'
3616         switch. We rename the two currently valid values to 'old-inline'
3617         and 'old-threads'.
3618
3619         https://bugs.webkit.org/show_bug.cgi?id=51081
3620
3621         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3622         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3623
3624 2010-12-22  Victor Wang  <victorw@chromium.org>
3625
3626         Reviewed by Darin Fisher.
3627
3628         [Chromium] Update chromium archive test result url in rebaseline script.
3629
3630         https://bugs.webkit.org/show_bug.cgi?id=51503
3631
3632         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3633
3634 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3635
3636         Reviewed by Alice Liu.
3637
3638         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3639         Verified on Chrome, Safari, and IE.
3640         With this change, we will record memory from a parent browser window and all child processes.
3641
3642         * record-memory-win/main.cpp:
3643         (ProcessArgs):
3644         (PrintUsage):
3645         (getMemoryInfo):
3646         (printProcessInfo):
3647         (evalProcesses):
3648         (UseImage):
3649         (QueryContinuously):
3650         (ElapsedTime):
3651
3652 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3653
3654         Unreviewed rollout r74489, because it was missing changelog.
3655
3656         * record-memory-win/main.cpp:
3657         
3658 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3659
3660         Adding myself as a reviewer.
3661
3662         * Scripts/webkitpy/common/config/committers.py:
3663
3664 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3665
3666         Unreviewed.  Adding myself to committers.py.
3667
3668         * Scripts/webkitpy/common/config/committers.py:
3669
3670 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3671
3672         Reviewed by Kenneth Rohde Christiansen.
3673
3674         TestNetscapePlugIn should use #if defined
3675         https://bugs.webkit.org/show_bug.cgi?id=51471
3676
3677         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3678         (NP_Initialize):
3679         (NPP_New):
3680
3681 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3682
3683         Reviewed by Yury Semikhatsky.
3684
3685         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3686
3687         DevTools window should be closed explicitly because it has custom deinitialization code.
3688
3689         https://bugs.webkit.org/show_bug.cgi?id=50722
3690
3691         * DumpRenderTree/chromium/TestShell.cpp:
3692         (TestShell::closeRemainingWindows):
3693
3694 2010-12-22  David Levin  <levin@chromium.org>
3695
3696         Reviewed by Shinichiro Hamaji.
3697
3698         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3699         https://bugs.webkit.org/show_bug.cgi?id=51452
3700
3701         * Scripts/webkitpy/style/checkers/cpp.py:
3702         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3703         Using the file extension if possible but falling back to the file contents if we have a header file.
3704         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3705         (_FileState.is_c_or_objective_c):
3706      &nbs