2011-06-01 Daniel Cheng <dcheng@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         [chromium] Use correct file name for dragging out images.
6         https://bugs.webkit.org/show_bug.cgi?id=24887
7
8         * DumpRenderTree/chromium/EventSender.cpp:
9         (EventSender::EventSender):
10         (EventSender::dumpFilenameBeingDragged):
11         * DumpRenderTree/chromium/EventSender.h:
12
13 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
14
15         Reviewed by Tony Chang.
16
17         nrwt: make webaudio work w/o content-length header
18         https://bugs.webkit.org/show_bug.cgi?id=61819
19
20         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
21         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
22         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
23         * Scripts/webkitpy/layout_tests/port/webkit.py:
24
25 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
26
27         Reviewed by Andreas Kling.
28
29         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
30         https://bugs.webkit.org/show_bug.cgi?id=61802
31
32         Add command line parameter and menu item to MiniBrowser application 
33         enabling use of QGLWidget for browser viewport.
34
35         * MiniBrowser/qt/BrowserWindow.cpp:
36         (BrowserWindow::BrowserWindow):
37         (BrowserWindow::toggleGLViewport):
38         * MiniBrowser/qt/BrowserWindow.h:
39         * MiniBrowser/qt/MiniBrowserApplication.cpp:
40         (MiniBrowserApplication::handleUserOptions):
41         * MiniBrowser/qt/MiniBrowserApplication.h:
42         (WindowOptions::WindowOptions):
43
44 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
45
46         Reviewed by Xan Lopez.
47
48         Print out autogen arguments when they differ from the last set, to help
49         with debugging build issues.
50
51         * Scripts/webkitdirs.pm: Print out previous and current build arguments
52         when they differ.
53
54 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
55
56         Reviewed by Martin Robinson.
57
58         [GTK] run-launcher should run MiniBrowser in WebKit2
59         https://bugs.webkit.org/show_bug.cgi?id=61858
60
61         * Scripts/run-launcher: Check whether -2 command line option has
62         been passed and run MiniBrowser instead of GtkLauncher.
63
64 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
65
66         Reviewed by Dirk Pranke.
67
68         Fix exception in verbose printing mode.
69         https://bugs.webkit.org/show_bug.cgi?id=61723
70
71         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
72
73 2011-05-31  Yong Li  <yoli@rim.com>
74
75         Reviewed by Eric Seidel.
76
77         https://bugs.webkit.org/show_bug.cgi?id=54807
78         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
79         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
80         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
81         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
82         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
83         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
84         rule we should have in order to make our code independent from compilers and compiler flags.
85
86         * Scripts/webkitpy/style/checkers/cpp.py:
87
88 2011-05-31  Hironori Bono  <hbono@chromium.org>
89
90         Reviewed by Eric Seidel.
91
92         Add a JavaScript function layoutTestController.setTextDirection().
93         https://bugs.webkit.org/show_bug.cgi?id=50952
94
95         This change adds a new JavaScript function setTextDirection() to the
96         LayoutTestController class of Safari and Chrome to write layout tests
97         that changes the text direction of an editable element.
98
99         * DumpRenderTree/LayoutTestController.cpp:
100         (setTextDirectionCallback):
101         (LayoutTestController::staticFunctions):
102         * DumpRenderTree/LayoutTestController.h:
103         * DumpRenderTree/chromium/LayoutTestController.cpp:
104         (LayoutTestController::LayoutTestController):
105         (LayoutTestController::setTextDirection):
106         * DumpRenderTree/chromium/LayoutTestController.h:
107         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
108         (LayoutTestController::setTextDirection):
109         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
110         (LayoutTestController::setTextDirection):
111         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
112         (LayoutTestController::setTextDirection):
113
114 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
115
116         Reviewed by Simon Hausmann.
117
118         [Qt] User-agent list of Qt test browsers is very outdated
119         https://bugs.webkit.org/show_bug.cgi?id=61531
120
121         The user can edit the user-agent manually, so there's no need to have
122         a super complete and up to date list, but it's nice to have it
123         minimally updated.
124
125         * MiniBrowser/qt/useragentlist.txt:
126         * QtTestBrowser/useragentlist.txt:
127
128 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
129
130         Reviewed by Adam Roben.
131
132         [GTK] [WebKit2] Implement a basic WebKitTestRunner
133         https://bugs.webkit.org/show_bug.cgi?id=57068
134
135         Add an implementation of WebKitTestRunner for GTK+.
136
137         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
138         * Scripts/old-run-webkit-tests: Ditto.
139         * Scripts/run-launcher: Ditto.
140         * Scripts/webkitdirs.pm: Ditto.
141         * WebKitTestRunner/GNUmakefile.am: Added.
142         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
143         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
144         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
145         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
146         * WebKitTestRunner/PlatformWebView.h:
147         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
148         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
149         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
150         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
151         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
152         (main): Added.
153
154 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
155
156         Reviewed by Tony Chang.
157
158         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
159         https://bugs.webkit.org/show_bug.cgi?id=60241
160
161         * Scripts/new-run-webkit-tests:
162
163 2011-05-31  Eric Seidel  <eric@webkit.org>
164
165         Reviewed by David Kilzer.
166
167         webkitpy should create zips with zip -9
168         https://bugs.webkit.org/show_bug.cgi?id=61789
169
170         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
171
172         * Scripts/webkitpy/common/system/workspace.py:
173         * Scripts/webkitpy/common/system/workspace_unittest.py:
174
175 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
176
177         Reviewed by Csaba Osztrogonác.
178
179         [Qt] Implement find feature for QtTestBrowser
180         https://bugs.webkit.org/show_bug.cgi?id=61425
181
182         Buildfix for --minimal and CONFIG+=qt_minimal build.
183
184         * QtTestBrowser/launcherwindow.cpp:
185         (LauncherWindow::LauncherWindow):
186         (LauncherWindow::createChrome):
187         * QtTestBrowser/launcherwindow.h:
188
189 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
190
191         Reviewed by Csaba Osztrogonác.
192
193         [Qt] Implement find feature for QtTestBrowser
194         https://bugs.webkit.org/show_bug.cgi?id=61425
195
196         * QtTestBrowser/launcherwindow.cpp:
197         (LauncherWindow::LauncherWindow):
198         (LauncherWindow::createChrome):
199         (LauncherWindow::showFindBar):
200         (LauncherWindow::find):
201         * QtTestBrowser/launcherwindow.h:
202
203 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
204
205         Reviewed by Martin Robinson.
206
207         [GTK] Implement JavaScript dialogs in MiniBrowser
208         https://bugs.webkit.org/show_bug.cgi?id=61725
209
210         * MiniBrowser/gtk/BrowserWindow.c:
211         (WKStringGetCString): Helper function to get a UTF-8 c string from
212         a WKStringRef.
213         (WKURLGetCString): Helper function to get a UTF-8 c string from a
214         WKURLRef.
215         (browserWindowUpdateURL): Update to use WKURLGetCString.
216         (didReceiveTitleForFrame): Update to use WKStringGetCString.
217         (createMessageDialog): Create a GtkMessageDialog.
218         (runJavaScriptAlert):
219         (runJavaScriptConfirm):
220         (runJavaScriptPrompt):
221         (browserWindowUIClientInit):
222
223 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
224
225         Reviewed by Kent Tamura.
226
227         WebSocket closing handshake
228         https://bugs.webkit.org/show_bug.cgi?id=35721
229
230         * Scripts/webkitpy/thirdparty/__init__.py:
231         Pull in pywebsocket 0.6b1. We need to update pywebsocket
232         to get the right behavior of closing handshake.
233
234 2011-05-29  Daniel Bates  <dbates@rim.com>
235
236         Reviewed by David Kilzer.
237
238         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
239         https://bugs.webkit.org/show_bug.cgi?id=61162
240
241         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
242         that omits a line count. In particular, the chunk range regular expression does
243         not match a chunk range line that omits a line count. GNU diff(1) will omit the
244         line count in the chunk range if the line count is exactly 1. For example, appending
245         a new line to the end of an existing file F that contains exactly one line of text will
246         be represented in a diff with a chunk range line that omits the line count for F.
247
248         * Scripts/VCSUtils.pm:
249           (parseChunkRange): Added.
250         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
251         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
252           - Added unit test "Git: Append new line to the end of an existing file".
253
254 2011-05-28  Adam Barth  <abarth@webkit.org>
255
256         Reviewed by Eric Seidel.
257
258         EWS builds patches that fail to build twice, which seems useless and slows down the bots
259         https://bugs.webkit.org/show_bug.cgi?id=55585
260
261         This patch switches all the early warning system bots over to the new
262         PatchAnalysisTask-based infrastructure.  This patch makes these bots
263         more efficient (in the case where patches fail to build) and paves the
264         way for running tests on these bots!
265
266         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
267         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
268         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
269         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
270         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
271         * Scripts/webkitpy/tool/commands/queues.py:
272
273 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
274
275         Reviewed by Kent Tamura.
276
277         Add bashi as a committer.
278
279         https://bugs.webkit.org/show_bug.cgi?id=61685
280
281         * Scripts/webkitpy/common/config/committers.py:
282
283 2011-05-27  Adam Barth  <abarth@webkit.org>
284
285         Reviewed by Eric Seidel.
286
287         When checking whether the tree is red, the EWS posts a link to the wrong log
288         https://bugs.webkit.org/show_bug.cgi?id=61072
289
290         We need to cache the original script error because that contains the
291         failure log we want to upload.  If we don't cache that script error,
292         self._script_error will get overwritten when we sanity check the clean
293         tree (and it also has test failures).
294
295         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
296             - This testing approach is slightly goofy.  We'd like to use
297               assertRaisesRegexp, but that's not available until Python 2.7.
298         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
299
300 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
301
302         Reviewed by Adam Barth.
303
304         Add layoutTestController.setStorageAllowed() to control whether access
305         to the localStorage API is enabled via the WebPermissionClient
306         https://bugs.webkit.org/show_bug.cgi?id=61581
307
308         * DumpRenderTree/chromium/LayoutTestController.cpp:
309         (LayoutTestController::LayoutTestController):
310         (LayoutTestController::setStorageAllowed):
311         * DumpRenderTree/chromium/LayoutTestController.h:
312         * DumpRenderTree/chromium/TestShell.cpp:
313         (TestShell::TestShell):
314         (TestShell::createNewWindow):
315         * DumpRenderTree/chromium/TestShell.h:
316         * DumpRenderTree/chromium/WebPermissions.h: Added.
317         (WebPermissions::WebPermissions):
318         (WebPermissions::allowStorage):
319         (WebPermissions::setStorageAllowed):
320         (WebPermissions::reset):
321
322 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
323
324         Reviewed by Eric Seidel.
325
326         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
327         https://bugs.webkit.org/show_bug.cgi?id=60326
328
329         This patch removes a lot of the complexity from the
330         metered_stream implementation that was unnecessary since there
331         was only one caller and the logic could be coordinated better.
332
333         There should be no functional changes in this patch, just code
334         getting deleted and cleaned up.
335
336         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
337         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
338         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
339         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
340
341 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
342
343         Reviewed by Eric Seidel.
344
345         NRWT: minor cleanup in printing module
346         https://bugs.webkit.org/show_bug.cgi?id=60329
347
348         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
349
350 2011-05-27  Steve Lacey  <sjl@chromium.org>
351
352         Reviewed by David Levin.
353
354         Add sjl@chromium.org as a committer.
355
356         https://bugs.webkit.org/show_bug.cgi?id=61672
357
358         * Scripts/webkitpy/common/config/committers.py:
359
360 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
361
362         Reviewed by Adam Barth.
363
364         NRWT: remove --print detailed-progress
365         https://bugs.webkit.org/show_bug.cgi?id=60324
366
367         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
368         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
369         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
370         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
371
372 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
373
374         Reviewed by Ojan Vafai.
375
376         NRWT: debug messages from the workers are being logged twice
377         https://bugs.webkit.org/show_bug.cgi?id=60428
378
379         It looks like when the workers are run in separate processes
380         we end up getting two copies of every log message they print.
381         This has to do with the multiprocessing module on UNIX cloning
382         the log configuration in a way I wasn't expecting, and so two
383         log handlers end up getting registered.
384
385         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
386         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
387         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
388         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
389
390 2011-05-27  Adam Roben  <aroben@apple.com>
391
392         Always decode tester names from location.hash
393
394         When navigating directly to a tester-specific URL (e.g.,
395         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
396         with a URL-encoded tester name in the page, and then the encoded name could make its way
397         into Bugzilla bugs. Bad!
398
399         Reviewed by David Kilzer.
400
401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
402         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
403         decodeURIComponent before trying to use it.
404
405 2011-05-27  Adam Roben  <aroben@apple.com>
406
407         Remove testing code that snuck into r87528
408
409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
410         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
411
412 2011-05-27  Adam Roben  <aroben@apple.com>
413
414         Add links to TestFailures to easily file bugs about failing tests
415
416         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
417         links to file bugs for failing tests
418
419         Reviewed by David Kilzer.
420
421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
422         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
423         for a particular build.
424         (Builder.prototype._getFailingTests): Use resultsPageURL.
425
426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
427         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
428         failures.
429         (ViewController.prototype._domForBuildName): Use resultsPageURL.
430         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
431         new bug link. The bug has a title, description, and URL already filled in for you!
432
433 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
434
435         Unreviewed, rolling out r87464.
436         http://trac.webkit.org/changeset/87464
437         https://bugs.webkit.org/show_bug.cgi?id=61643
438
439         client-close/server-close tests are flaky on Chromium Mac and
440         Windows (Requested by aklein on #webkit).
441
442         * Scripts/webkitpy/thirdparty/__init__.py:
443
444 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
445
446         Added Douglas Davidson to contributors list for easier CC'ing.
447
448         * Scripts/webkitpy/common/config/committers.py:
449
450 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
451
452         Reviewed by Adam Barth.
453
454         Fix worldID and destinationDomain argument names
455         https://bugs.webkit.org/show_bug.cgi?id=61571
456
457         As part of working on r87423, I noticed a couple of inconsistencies in
458         argument names:
459         - We would use worldId in .h files but worldID in .cpp files.
460           Standardize on the latter
461         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
462           destinationDomains argument, even though the actual parameter was for
463           a single domain (renamed to be singular).
464
465         * DumpRenderTree/LayoutTestController.h:
466         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
467         (LayoutTestController::evaluateScriptInIsolatedWorld):
468
469 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
470
471         Reviewed by Kent Tamura.
472
473         WebSocket closing handshake
474         https://bugs.webkit.org/show_bug.cgi?id=35721
475
476         * Scripts/webkitpy/thirdparty/__init__.py:
477         Pull in pywebsocket 0.6b1. We need to update pywebsocket
478         to get the right behavior of closing handshake.
479
480 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
481
482         Reviewed by Andreas Kling.
483
484         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
485         https://bugs.webkit.org/show_bug.cgi?id=42676
486
487         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
488
489         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
490         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
491         (WTR::InjectedBundle::beginTesting):
492         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
493         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
494         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
495
496 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
497
498         Reviewed by Andreas Kling.
499
500         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
501         https://bugs.webkit.org/show_bug.cgi?id=61527
502
503         The setMaximumHeight() call is unecessary and breaks the dialog at
504         least on my setup.
505
506         * QtTestBrowser/launcherwindow.cpp:
507         (LauncherWindow::showUserAgentDialog):
508
509 2011-05-02  Robert Hogan  <robert@webkit.org>
510
511         Reviewed by Adam Roben.
512
513         [Qt] Allow popup windows from plugins when initiated by a user gesture
514
515         https://bugs.webkit.org/show_bug.cgi?id=41292
516
517         Support parameters introduced in plugin-initiate-popup-window.html
518
519         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
520         (webkit_test_plugin_new_instance):
521         (webkit_test_plugin_handle_event):
522
523 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
524
525         Reviewed by Adam Barth.
526
527         Support cross-origin XMLHttpRequest in isolated worlds
528         https://bugs.webkit.org/show_bug.cgi?id=59843
529
530         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
531
532         * DumpRenderTree/chromium/LayoutTestController.cpp:
533         (LayoutTestController::LayoutTestController):
534         (LayoutTestController::setIsolatedWorldSecurityOrigin):
535         * DumpRenderTree/chromium/LayoutTestController.h:
536
537 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
538
539         Reviewed by Adam Roben.
540
541         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
542         https://bugs.webkit.org/show_bug.cgi?id=61474
543         <rdar://problem/9468337>
544
545         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
546         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
547
548 2011-05-26  Andreas Kling  <kling@webkit.org>
549
550         Unreviewed, correct address to webkit-committers mailing list.
551
552         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
553
554 2011-05-25  Adam Roben  <aroben@apple.com>
555
556         Don't assume that builds finish in the order they were started
557
558         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
559         build when one slave is taking a long time to finish a build
560
561         Reviewed by Antti Koivisto.
562
563         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
564         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
565         newer than the oldest in-progress build are also themselves in progress. Just check whether
566         each build is actually in progress (as signified by its presence in the currentBuilds set).
567
568 2011-05-25  Adam Roben  <aroben@apple.com>
569
570         Correctly detect cases where only a single test failed/crashed/timed out
571
572         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
573         failing test
574
575         Reviewed by Darin Adler.
576
577         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
578         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
579         will be singular when only a single test fails/crashes/times out.
580
581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
582         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
583         failed/crashed/timed out.
584
585 2011-05-26  Tom Hudson  <tomhudson@google.com>
586
587         Reviewed by Tony Chang.
588
589         Add flags to Chromium ImageDiff to write image comparison metrics on
590         stdout.
591         https://bugs.webkit.org/show_bug.cgi?id=60569
592
593         * DumpRenderTree/chromium/ImageDiff.cpp:
594         (Image::createFromStdin): Fix spelling.
595         (maxOf3): New function to do 3-way maximum.
596         (getRedComponent): Extract red component from ABGR packed encoding.
597         (getGreenComponent): Extract green component from ABGR packed encoding.
598         (getBlueComponent): Extract blue component from ABGR packed encoding.
599         (weightedPercentageDifferent): Determine % of pixels different in two
600         images multiplied by intensity difference of each pixel.
601         (printHelp): Document new arguments.
602         (compareImages): Parameterize.
603         (untestedCompareImages): Parameterize.
604         (diffImages): Parameterize; write results on stdout if requested.
605         (main): Parse new arguments.
606
607 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
608
609         Reviewed by Simon Hausmann.
610
611         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
612         https://bugs.webkit.org/show_bug.cgi?id=42697
613
614         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
615
616         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
617         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
618         (WTR::InjectedBundle::beginTesting):
619         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
620         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
621         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
622
623 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
624
625         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
626         https://bugs.webkit.org/show_bug.cgi?id=61428
627         <rdar://problem/9457006>
628
629         Reviewed by Adam Roben.
630
631         The crash occurs when Flash posts a message to a window that it
632         creates, and in processing the message, it calls NPN_Evaluate to
633         evaluate JavaScript that removes the plug-in from the page. Flash then
634         crashes when we return to Flash code.
635
636         This test emulates that behavior.
637
638         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
639         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
640         Initialize member vars.
641         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
642         Remove our custom property from the message window, and destroy it.
643         (CallJSThatDestroysPlugin::NPP_Destroy):
644         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
645         layout test controller that we're done.
646         (wndProc):
647         Get the PluginTest object, and call its runTest() function.
648         (CallJSThatDestroysPlugin::NPP_New):
649         Setup the test: register a class for the message-only window, create
650         it, and post a message to it to run the test.
651         (CallJSThatDestroysPlugin::runTest):
652         Execute JS that removes the plug-in from the page, and if we're not
653         destroyed, log a success message.
654
655         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
656         Add new test to project.
657
658 2011-05-25  Tony Chang  <tony@chromium.org>
659
660         Reviewed by Adam Barth.
661
662         webkitpy's NetworkTransaction shouldn't use mechanize
663         https://bugs.webkit.org/show_bug.cgi?id=61450
664
665         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
666         use urllib2 directly.  Re-add NetworkTransaction to
667         test_results_uploader.py (reverting r87124).
668
669         * Scripts/webkitpy/common/net/networktransaction.py:
670         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
671
672 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
673
674         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
675         until the port begins using those export macros.
676
677         * DumpRenderTree/chromium/config.h:
678
679 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
680
681         Unreviewed, rolling out r87257.
682         http://trac.webkit.org/changeset/87257
683         https://bugs.webkit.org/show_bug.cgi?id=61457
684
685         This broke layout tests, see bug 61431. (Requested by
686         hwennborg on #webkit).
687
688         * DumpRenderTree/chromium/LayoutTestController.cpp:
689         (LayoutTestController::LayoutTestController):
690         (LayoutTestController::clearAllDatabases):
691         * DumpRenderTree/chromium/LayoutTestController.h:
692
693 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
694
695         Reviewed by Andreas Kling.
696
697         [Qt] fast/css/disabled-author-styles.html failed
698         https://bugs.webkit.org/show_bug.cgi?id=61438
699
700         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
701
702         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
703         (WebCore::WebPage::resetSettings):
704         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
705         (LayoutTestController::setAuthorAndUserStylesEnabled):
706         * DumpRenderTree/qt/LayoutTestControllerQt.h:
707
708 2011-05-25  Adam Roben  <aroben@apple.com>
709
710         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
711
712         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
713         started exiting early due to too many crashes, timeouts, or failures
714
715         Reviewed by David Kilzer.
716
717         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
718         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
719         run-webkit-tests exits early due to too many failures, pass that information in another
720         argument to the callback.
721         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
722         the new structure of the object passed to the callback.
723         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
724         getNumberOfFailingTests and to pass that along to our own callbacks.
725         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
726         from _getFailingTests and to store that value in the history object.
727
728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
729         (.info): Added.
730
731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
732         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
733         object and to add a note when run-webkit-tests exited early due to too many failures.
734         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
735         latestBuildInfos since each entry now contains more than just the tester and failure count.
736         Now displays a message for testers where the latest build exited early due to too many
737         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
738         store that value in latestBuildInfos.
739
740 2011-05-24  Keishi Hattori  <keishi@webkit.org>
741
742         Reviewed by Kent Tamura.
743
744         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
745         https://bugs.webkit.org/show_bug.cgi?id=61273
746
747         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
748
749 2011-05-24  Greg Simon  <gregsimon@chromium.org>
750
751         Reviewed by Dimitri Glazkov.
752
753         Control Indexeddb backends from LayoutTestController
754         https://bugs.webkit.org/show_bug.cgi?id=61000
755
756         * DumpRenderTree/chromium/LayoutTestController.cpp:
757         (LayoutTestController::LayoutTestController):
758         (LayoutTestController::setOverrideIndexedDBBackingStore):
759         (LayoutTestController::clearAllDatabases):
760         * DumpRenderTree/chromium/LayoutTestController.h:
761
762 2011-05-24  Robert Hogan  <robert@webkit.org>
763
764         Reviewed by Ryosuke Niwa.
765
766         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
767         https://bugs.webkit.org/show_bug.cgi?id=61393
768
769         * DumpRenderTree/qt/EventSenderQt.h:
770         * DumpRenderTree/qt/EventSenderQt.cpp:
771         (getModifiers): static function for interpreting modifiers
772         (EventSender::mouseDown): Respect keyboard modifiers
773         (EventSender::keyDown): use new static function
774         (EventSender::sendOrQueueEvent): whitespace fix
775
776 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
777
778         Reviewed by Adam Barth.
779
780         Adding MHTML reading support.
781         https://bugs.webkit.org/show_bug.cgi?id=7168
782
783         * Scripts/build-webkit:
784         * Scripts/old-run-webkit-tests:
785         * Scripts/webkitperl/features.pm:
786         * Scripts/webkitpy/layout_tests/port/test_files.py:
787         * Scripts/webkitpy/layout_tests/port/webkit.py:
788
789 2011-05-24  Stephen White  <senorblanco@chromium.org>
790
791         Reviewed by Kenneth Russell.
792
793         Remove most style checks on Source/ThirdParty/glu, since it doesn't
794         follow WebKit style.
795         https://bugs.webkit.org/show_bug.cgi?id=61365
796
797         * Scripts/webkitpy/style/checker.py:
798
799 2011-05-24  Adam Roben  <aroben@apple.com>
800
801         Don't allow forcing builds through the build.webkit.org web interface
802
803         Someone has been forcing bogus builds.
804
805         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
806
807 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
808
809         Reviewed by Adam Roben.
810
811         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
812         https://bugs.webkit.org/show_bug.cgi?id=42669
813
814         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
815         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
816         Because that case changed the setting.
817
818         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
819         (WTR::InjectedBundle::beginTesting):
820
821 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
822
823         Reviewed by Kenneth Rohde Christiansen.
824
825         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
826         https://bugs.webkit.org/show_bug.cgi?id=61052
827
828         * Scripts/old-run-webkit-tests:
829
830 2011-05-24  Adam Roben  <aroben@apple.com>
831
832         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
833
834         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
835         that don't have any failing tests, which isn't useful
836
837         Reviewed by David Kilzer.
838
839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
840         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
841         instead of name strings.
842         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
843         builder names into an array of builders.
844
845         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
846         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
847         the most recently completed build, or -1 if there is no such build.
848         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
849         in the given build, or -1 if the number could not be determined. Some of this code came from
850         _getFailingTests.
851         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
852         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
853         getNumberOfFailingTests functions.
854
855         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
856         (ViewController.prototype._displayTesters): Get the current number of test failures for each
857         tester and show it in the list. Omit testers that have no failures at all. We keep the
858         testers and failure counts in an array and sort it before displaying the current data, as
859         the order in which data will be fetched is unpredictable.
860
861 2011-05-23  Tony Chang  <tony@chromium.org>
862
863         Reviewed by Ojan Vafai.
864
865         [nrwt] don't use NetworkTranslation when uploading results
866         https://bugs.webkit.org/show_bug.cgi?id=61315
867
868         This avoids autoinstalling mechanize.  It didn't matter anyway
869         because test_results_uploader.py wasn't using mechanize to make the
870         request so NetworkTransaction::run wasn't doing anything extra
871         (it only matters if it catches mechanize.HTTPError).
872
873         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
874
875 2011-05-23  Tony Chang  <tony@chromium.org>
876
877         Reviewed by Dirk Pranke.
878
879         [chromium] fix the rebaseline tool to work with Linux GPU failures
880         https://bugs.webkit.org/show_bug.cgi?id=61312
881
882         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
883
884 2011-05-23  Darin Adler  <darin@apple.com>
885
886         Ignore generated .pyc files in a directory full of python code.
887
888         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
889
890 2011-05-23  Adam Barth  <abarth@webkit.org>
891
892         Reviewed by Eric Seidel.
893
894         sheriffbot should give more details about the failures in IRC
895         https://bugs.webkit.org/show_bug.cgi?id=61233
896
897         With this patch, sheriffbot will annonce the set of failing tests,
898         which might help folks triage the problem.
899
900         * Scripts/webkitpy/tool/commands/sheriffbot.py:
901         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
902
903 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
904
905         Unreviewed, rolling out r87078.
906         http://trac.webkit.org/changeset/87078
907         https://bugs.webkit.org/show_bug.cgi?id=61294
908
909         Patch contains errors and seems likely to break a bunch of
910         bots (Requested by abarth on #webkit).
911
912         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
913         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
914         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
915
916 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
917
918         Reviewed by Ojan Vafai.
919
920         Convert json_results_generator.py to output version 4 JSON.
921         https://bugs.webkit.org/show_bug.cgi?id=60869
922
923         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
924         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
925         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
926
927 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
928
929         Reviewed by Adam Barth.
930
931         Move generation of shell_command from port to executive
932         https://bugs.webkit.org/show_bug.cgi?id=61251
933
934         After move it's possible to use the code in other places too.
935
936         * Scripts/webkitpy/common/config/ports.py:
937         * Scripts/webkitpy/common/system/executive.py:
938
939 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
940
941         Reviewed by Darin Adler.
942
943         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
944         https://bugs.webkit.org/show_bug.cgi?id=42669
945
946         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
947
948         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
949         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
950         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
951         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
952
953 2011-05-22  Robert Hogan  <robert@webkit.org>
954
955         Reviewed by Kenneth Rohde Christiansen.
956
957         Fix policyDelegate in Qt DRT
958         https://bugs.webkit.org/show_bug.cgi?id=61247
959
960         Use the 'policy delegate' implemented in FrameLoaderClient
961         for layout tests. The partial implementation in DumpRenderTreeQt
962         is redundant, so remove it.
963
964         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
965         (WebCore::WebPage::acceptNavigationRequest):
966         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
967         (LayoutTestController::waitForPolicyDelegate):
968
969 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
970
971         Reviewed by Darin Adler.
972
973         Use double quotes for filename arguments
974         https://bugs.webkit.org/show_bug.cgi?id=61250
975
976         Windows does not support single quotes on the command line,
977         so replace them with double quotes.
978
979         * Scripts/prepare-ChangeLog:
980
981 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
982
983         Reviewed by Sam Weinig.
984
985         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
986         https://bugs.webkit.org/show_bug.cgi?id=42550
987         
988         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
989
990         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
991         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
992         Copy the code for pausing animations, FIXME comments and all.
993         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
994         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
995
996 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
997
998         Reviewed by Stephen White.
999
1000         Adding myself to the committers list.
1001
1002         * Scripts/webkitpy/common/config/committers.py:
1003
1004 2011-05-19  Adam Roben  <aroben@apple.com>
1005
1006         Test that the WebKit2 UI process doesn't crash when starting a download
1007
1008         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
1009         (preceded by assertion) in fastMalloc when downloading a file
1010
1011         Reviewed by Darin Adler.
1012
1013         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
1014
1015         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
1016         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
1017         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
1018         started, cancel the download, and return a bogus string.
1019
1020         (TestWebKitAPI::setContextDownloadClient):
1021         (TestWebKitAPI::setPagePolicyClient):
1022         Simple helper functions.
1023
1024         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
1025         our policy client, and run until we know that the download was started. If we haven't
1026         crashed, we win!
1027
1028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1029         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1030         * TestWebKitAPI/win/copy-resources.cmd:
1031         Added new files.
1032
1033 2011-05-20  Kent Tamura  <tkent@chromium.org>
1034
1035         Reviewed by Ryosuke Niwa.
1036
1037         Fix style errors in DumpRenderTree/chromium/.
1038         https://bugs.webkit.org/show_bug.cgi?id=61172
1039
1040         * DumpRenderTree/chromium/CppBoundClass.cpp:
1041         (CppBoundClass::getAsCppVariant):
1042         (CppBoundClass::bindToJavascript):
1043         * DumpRenderTree/chromium/CppBoundClass.h:
1044         (CppBoundClass::GetterCallback::~GetterCallback):
1045         (CppBoundClass::CppBoundClass):
1046         (CppBoundClass::Callback::~Callback):
1047         (CppBoundClass::MemberCallback::MemberCallback):
1048         (CppBoundClass::MemberCallback::~MemberCallback):
1049         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
1050         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
1051         * DumpRenderTree/chromium/CppVariant.h:
1052         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1053         (DRTDevToolsAgent::~DRTDevToolsAgent):
1054         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1055         (DRTDevToolsClient::sendFrontendLoaded):
1056         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1057         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1058         (main):
1059         * DumpRenderTree/chromium/EventSender.cpp:
1060         (SavedEvent::SavedEvent):
1061         (EventSender::EventSender):
1062         (EventSender::keyDown):
1063         * DumpRenderTree/chromium/EventSender.h:
1064         * DumpRenderTree/chromium/ImageDiff.cpp:
1065         (Image::Image):
1066         * DumpRenderTree/chromium/LayoutTestController.cpp:
1067         (LayoutTestController::LayoutTestController):
1068         (LayoutTestController::WorkQueue::reset):
1069         (WorkItemBackForward::WorkItemBackForward):
1070         (WorkItemLoadingScript::WorkItemLoadingScript):
1071         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
1072         (WorkItemLoad::WorkItemLoad):
1073         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1074         (LayoutTestController::pathToLocalResource):
1075         * DumpRenderTree/chromium/LayoutTestController.h:
1076         (LayoutTestController::WorkItem::~WorkItem):
1077         (LayoutTestController::WorkQueue::WorkQueue):
1078         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1079         (MockSpellCheck::MockSpellCheck):
1080         (MockSpellCheck::~MockSpellCheck):
1081         * DumpRenderTree/chromium/MockSpellCheck.h:
1082         * DumpRenderTree/chromium/NotificationPresenter.h:
1083         (NotificationPresenter::NotificationPresenter):
1084         * DumpRenderTree/chromium/Task.cpp:
1085         (WebTask::WebTask):
1086         * DumpRenderTree/chromium/Task.h:
1087         (TaskList::TaskList):
1088         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1089         (DRTPrinter::DRTPrinter):
1090         (TestShellPrinter::TestShellPrinter):
1091         * DumpRenderTree/chromium/TestNavigationController.cpp:
1092         (TestNavigationEntry::TestNavigationEntry):
1093         (TestNavigationEntry::~TestNavigationEntry):
1094         (TestNavigationController::TestNavigationController):
1095         (TestNavigationController::reload):
1096         (TestNavigationController::loadEntry):
1097         (TestNavigationController::didNavigateToEntry):
1098         * DumpRenderTree/chromium/TestNavigationController.h:
1099         (TestShellExtraData::TestShellExtraData):
1100         * DumpRenderTree/chromium/TestShell.cpp:
1101         (dumpHistoryItem):
1102         * DumpRenderTree/chromium/TestShell.h:
1103         (TestParams::TestParams):
1104         * DumpRenderTree/chromium/TestShellWin.cpp:
1105         (TestShell::waitTestFinished):
1106         * DumpRenderTree/chromium/TestWebWorker.h:
1107         (TestWebWorker::startWorkerContext):
1108         (TestWebWorker::terminateWorkerContext):
1109         (TestWebWorker::postMessageToWorkerContext):
1110         (TestWebWorker::clientDestroyed):
1111         (TestWebWorker::postMessageToWorkerObject):
1112         (TestWebWorker::postExceptionToWorkerObject):
1113         (TestWebWorker::postConsoleMessageToWorkerObject):
1114         (TestWebWorker::confirmMessageFromWorkerObject):
1115         (TestWebWorker::reportPendingActivity):
1116         (TestWebWorker::workerContextClosed):
1117         (TestWebWorker::~TestWebWorker):
1118         * DumpRenderTree/chromium/TextInputController.cpp:
1119         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1120         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1121         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1122         (WebThemeEngineDRTWin::paintButton):
1123         (WebThemeEngineDRTWin::paintMenuList):
1124         (WebThemeEngineDRTWin::paintTrackbar):
1125         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
1126         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1127         * DumpRenderTree/chromium/WebViewHost.cpp:
1128         (WebViewHost::navigate):
1129         (WebViewHost::updateSessionHistory):
1130         (WebViewHost::paintInvalidatedRegion):
1131         * DumpRenderTree/chromium/WebViewHost.h:
1132
1133 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1134
1135         Reviewed by Adam Roben.
1136
1137         Detect hangs in run-api-tests
1138         https://bugs.webkit.org/show_bug.cgi?id=48043
1139
1140         * Scripts/run-api-tests: Added test timeouts
1141
1142 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1143
1144         Reviewed by Adam Roben.
1145
1146         run-api-tests should run one test per process
1147         https://bugs.webkit.org/show_bug.cgi?id=61088
1148
1149         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
1150         return code, and parsing GTest output format.
1151
1152 2011-05-15  Robert Hogan  <robert@webkit.org>
1153
1154         Reviewed by Antonio Gomes.
1155
1156         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
1157         https://bugs.webkit.org/show_bug.cgi?id=60834
1158         Fix unix test plugin for plugins/get-url-with-javascript-url.html
1159
1160         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1161         (webkit_test_plugin_new_stream):
1162         (webkit_test_plugin_write_ready):
1163         (webkit_test_plugin_write):
1164
1165 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1166
1167         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
1168         http://trac.webkit.org/changeset/86869
1169         http://trac.webkit.org/changeset/86873
1170         http://trac.webkit.org/changeset/86875
1171         http://trac.webkit.org/changeset/86877
1172         https://bugs.webkit.org/show_bug.cgi?id=61139
1173
1174         broke builds and debug DRT (Requested by rniwa on #webkit).
1175
1176         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1177         * DumpRenderTree/chromium/TestShell.cpp:
1178         (TestShell::bindJSObjectsToWindow):
1179         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1180         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1181
1182 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
1183
1184         Reviewed by Darin Adler.
1185
1186         Add build logistics and plumbing for window.internals object.
1187         https://bugs.webkit.org/show_bug.cgi?id=60313
1188
1189         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1190         * DumpRenderTree/chromium/TestShell.cpp:
1191         (TestShell::bindJSObjectsToWindow): Added injection code.
1192         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1193         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1194
1195 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
1196
1197         Reviewed by Csaba Osztrogonác.
1198
1199         [Qt] Implement eventSender.scalePageBy
1200         https://bugs.webkit.org/show_bug.cgi?id=60015
1201
1202         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1203         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1204         * DumpRenderTree/qt/EventSenderQt.cpp:
1205         (EventSender::scalePageBy):
1206         * DumpRenderTree/qt/EventSenderQt.h:
1207
1208 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
1209
1210         Reviewed by Kent Tamura.
1211
1212         [Chromium] IME candidate window appears wrong position in an iframe
1213         https://bugs.webkit.org/show_bug.cgi?id=61023
1214
1215         Call the focused frame's firstRectForCharacterRange() instead of the
1216         main frame so that DRT behaves as the same as Chromium.
1217
1218         * DumpRenderTree/chromium/TextInputController.cpp:
1219         (TextInputController::firstRectForCharacterRange):
1220
1221 2011-05-18  Adam Roben  <aroben@apple.com>
1222
1223         Add a new page to build.webkit.org to help find when tests started failing
1224
1225         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
1226         right now, but already shows some useful information. It's somewhat similar to webkit-patch
1227         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
1228         little more convenient than either of them, though, because it's all done in the browser
1229         (and thus it's easy to go directly to the relevant test results).
1230
1231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
1232         (Buildbot): This class represents a Buildbot server.
1233         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
1234         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
1235         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
1236         callback.
1237         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
1238         be implemented by a derived class that understands this server's build naming scheme.
1239         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
1240         particular build.
1241
1242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
1243         (Builder): This class represents one builder on the buildbot.
1244         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
1245         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
1246         information about a particular test failure.
1247         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
1248         information about when tests started failing.
1249         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
1250         particular build.
1251         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
1252         callback.
1253         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
1254         extracts all the failing tests listed in it, passing them to the callback.
1255         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
1256         build, merges them into the build history, and calls the callback telling it whether the
1257         next build should be fetched to provide more information.
1258
1259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1260         Added. Just some simple styles.
1261
1262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
1263         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
1264         (getResource): Wrapper around XMLHttpRequest.
1265         (Array.prototype.findFirst): Finds the first element matching the given predicate and
1266         returns it.
1267         (Array.prototype.last): Returns the last element of the array.
1268
1269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
1270         (ViewController): This class contains the main logic for displaying the page.
1271         (ViewController.loaded): Just calls through to parseHash.
1272         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
1273         shows the list of all testers so one can be chosen. This function is called when the page
1274         loads and whenever we get a hashchange event.
1275         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
1276         as it is fetched. The display ends up grouping tests by when they started failing.
1277         (ViewController._displayTesters): Gets the list of testers and displays it.
1278
1279         (ViewController._domForBuildName):
1280         (ViewController._domForFailedTest):
1281         Helper functions to create descriptions and links for a particular build or failed test.
1282
1283         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
1284         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
1285         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
1286
1287         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
1288         loads all the files and sets up a ViewController, which does the rest.
1289
1290         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
1291         page.
1292
1293 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1294
1295         Reviewed by Csaba Osztrogonác.
1296
1297         [Qt] Implement layoutTestController.setValueForUser()
1298         https://bugs.webkit.org/show_bug.cgi?id=60956
1299
1300         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1301         (LayoutTestController::setValueForUser):
1302         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1303
1304 2011-05-16  Robert Hogan  <robert@webkit.org>
1305
1306         Reviewed by Kenneth Rohde Christiansen.
1307
1308         plugins/invalidate_rect.html fails on linux ports
1309
1310         - Make the unix test netscape plugin recognize the onPaintEvent
1311           and windowedPlugin parameters.
1312
1313         https://bugs.webkit.org/show_bug.cgi?id=54051
1314
1315         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1316         (handleEventX11):
1317         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1318         (LayoutTestController::displayInvalidatedRegion):
1319         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1320         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1321         (webkit_test_plugin_new_instance):
1322         (webkit_test_plugin_handle_event):
1323
1324 2011-05-17  Tony Chang  <tony@chromium.org>
1325
1326         Reviewed by Ojan Vafai.
1327
1328         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
1329         https://bugs.webkit.org/show_bug.cgi?id=60895
1330
1331         Update the tools to handle the move.  Lucid 32 results now go in
1332         chromium-linux-x86 and the default platform on Linux is now x86_64.
1333
1334         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
1335         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1336         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
1337         * Scripts/webkitpy/layout_tests/port/base.py: ditto
1338         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
1339         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1340         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
1341         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
1342         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
1343
1344 2011-05-17  Adam Roben  <aroben@apple.com>
1345
1346         Make run-api-tests work on Windows when there are spaces in the path
1347
1348         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
1349         spaces in the path to TestWebKitAPI.exe
1350
1351         Reviewed by David Levin.
1352
1353         * Scripts/run-api-tests:
1354         (runTestTool): Use the "direct object" form of system() to avoid having the path to
1355         TestWebKitAPI.exe be split by the shell.
1356
1357 2011-05-16  Ian Henderson  <ianh@apple.com>
1358
1359         Reviewed by Joseph Pecoraro.
1360
1361         Page::goToItem doesn't work while loading is deferred
1362         https://bugs.webkit.org/show_bug.cgi?id=60412
1363
1364         Add setDefersLoading and goBack methods to LayoutTestController.  We
1365         need to use goBack() instead of history.back() because the latter goes
1366         through NavigationScheduler, hence doesn't exhibit the bug.
1367
1368         * DumpRenderTree/LayoutTestController.cpp:
1369         (goBackCallback):
1370         (setDefersLoadingCallback):
1371         (LayoutTestController::staticFunctions):
1372         * DumpRenderTree/LayoutTestController.h:
1373         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1374         (LayoutTestController::goBack):
1375         (LayoutTestController::setDefersLoading):
1376         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1377         (LayoutTestController::goBack):
1378         (LayoutTestController::setDefersLoading):
1379         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1380         (LayoutTestController::goBack):
1381         (LayoutTestController::setDefersLoading):
1382         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1383         (LayoutTestController::goBack):
1384         (LayoutTestController::setDefersLoading):
1385
1386 2011-05-16  Sam Weinig  <sam@webkit.org>
1387
1388         Reviewed by Anders Carlsson.
1389
1390         TestWebKitAPI should build with clang if it can
1391         https://bugs.webkit.org/show_bug.cgi?id=60918
1392
1393         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
1394         Update CompilerVersion.xcconfig to match others.
1395
1396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1397         Add CompilerVersion.xcconfig to the project.
1398
1399         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1400         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
1401         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1402         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1403         Add some casts to quiet warnings from clang.
1404
1405 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
1406
1407         Reviewed by David Levin.
1408
1409         add dpranke as a reviewer
1410         https://bugs.webkit.org/show_bug.cgi?id=60919
1411
1412         * Scripts/webkitpy/common/config/committers.py:
1413
1414 2011-05-16  Robert Hogan  <robert@webkit.org>
1415
1416         Reviewed by Anders Carlsson.
1417
1418         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
1419
1420         https://bugs.webkit.org/show_bug.cgi?id=60838
1421
1422         The unix test plugin needs to call the test's NPP_URLNotify
1423         rather than the browsers.
1424
1425         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1426         (webkit_test_plugin_url_notify):
1427
1428 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
1429
1430         Rubber-stamped by Adam Roben.
1431
1432         Adding myself as a reviewer.
1433         * Scripts/webkitpy/common/config/committers.py:
1434
1435 2011-05-16  Sam Weinig  <sam@webkit.org>
1436
1437         Fix typo pointed out by Dave Levin.
1438
1439         * TestWebKitAPI/PlatformUtilities.h:
1440         (TestWebKitAPI::Util::assertWKStringEqual):
1441         Strig -> String.
1442
1443 2011-05-16  Sam Weinig  <sam@webkit.org>
1444
1445         Reviewed by David Levin.
1446
1447         Convert api tester over to using gtest expectations directly
1448         https://bugs.webkit.org/show_bug.cgi?id=60862
1449
1450         * TestWebKitAPI/PlatformUtilities.cpp:
1451         (TestWebKitAPI::Util::toSTD):
1452         * TestWebKitAPI/PlatformUtilities.h:
1453         (TestWebKitAPI::Util::assertWKStrigEqual):
1454         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
1455         the implementation of the macro simpler.
1456
1457         * TestWebKitAPI/Test.h:
1458         Remove TEST_ASSERT forwarder.
1459
1460         [Test changes elided]
1461
1462 2011-05-16  David Kilzer  <ddkilzer@apple.com>
1463
1464         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
1465         <rdar://problem/9446430>
1466
1467         Reviewed by Mark Rowe.
1468
1469         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
1470         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1471         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1472
1473 2011-05-16  Jon Lee  <jonlee@apple.com>
1474
1475         Reviewed by Simon Fraser.
1476
1477         Can't horizontally scroll iframes and overflow because wheel events are always accepted
1478         https://bugs.webkit.org/show_bug.cgi?id=60779
1479
1480         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1481         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
1482
1483 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1484
1485         Reviewed by Csaba Osztrogonác.
1486
1487         [Qt] Tools.pro misses include(common.pri)
1488         https://bugs.webkit.org/show_bug.cgi?id=60883
1489
1490         It includes features.pri, which depends on common.pri (the build is
1491         not broken today with the default options, but this is the right
1492         thing to do).
1493
1494         * Tools.pro:
1495
1496 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
1497
1498         Unreviewed: adding myself to committers.py.
1499
1500         * Scripts/webkitpy/common/config/committers.py:
1501
1502 2011-05-15  Daniel Bates  <dbates@webkit.org>
1503
1504         Reviewed by Chris Jerdonek.
1505
1506         svn-apply can't handle Git diff that only changes executable bit
1507         https://bugs.webkit.org/show_bug.cgi?id=60848
1508
1509         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
1510         that only has an executable bit change.
1511
1512         * Scripts/VCSUtils.pm:
1513           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
1514         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
1515         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
1516         * Scripts/svn-apply:
1517         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
1518         * Scripts/svn-unapply:
1519         (patch): Ditto.
1520         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1521           - Updated expected results for test cases to account for numTextChunks.
1522           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
1523           - Added test case "Git: file that only has an executable bit change".
1524         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1525           - Updated expected results for test cases to account for numTextChunks.
1526
1527 2011-05-15  Sam Weinig  <sam@webkit.org>
1528
1529         Fix windows build.
1530
1531         * TestWebKitAPI/win/main.cpp:
1532         (main):
1533
1534 2011-05-15  Sam Weinig  <sam@webkit.org>
1535
1536         Reviewed by David Levin.
1537
1538         Make API tester more gtest friendly
1539         https://bugs.webkit.org/show_bug.cgi?id=60859
1540
1541         * Scripts/run-api-tests:
1542         Numerous changes:
1543         - Remove logic to run tests one at a time.
1544         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
1545           the test runner and allow gtest to print it for us.
1546         - Forward stdout from the test tool to stdout, even in non-verbose runs.
1547         - Run test tool from the current working directory instead of the root webkit
1548           directory.
1549
1550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1551         Move plist to be with other bundle sources.
1552
1553         * TestWebKitAPI/TestsController.cpp:
1554         (TestWebKitAPI::TestsController::TestsController):
1555         (TestWebKitAPI::TestsController::run):
1556         * TestWebKitAPI/TestsController.h:
1557         * TestWebKitAPI/mac/main.mm:
1558         Simplify TestController down to a single run function. We should consider removing the class
1559         entirely at some point.
1560
1561 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1562
1563         Unreviewed, rolling out r86504.
1564         http://trac.webkit.org/changeset/86504
1565         https://bugs.webkit.org/show_bug.cgi?id=60853
1566
1567         "Broke Qt EventSender in editing/selection tests" (Requested
1568         by mwenge on #webkit).
1569
1570         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1571         (WebCore::WebPage::WebPage):
1572         (WebCore::DumpRenderTree::DumpRenderTree):
1573         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1574         (WebCore::DumpRenderTree::initJSObjects):
1575         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1576         (WebCore::DumpRenderTree::eventSender):
1577         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1578         (webkit_test_plugin_new_instance):
1579         (webkit_test_plugin_set_window):
1580         (webkit_test_plugin_handle_event):
1581
1582 2011-05-12  Robert Hogan  <robert@webkit.org>
1583
1584         Reviewed by Benjamin Poulain.
1585
1586         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1587
1588         The support for this test added to the unix test plugin here
1589         may allow other platforms to pass it (nearly everyone
1590         skips it). On Qt it required a bit of trickiness with
1591         the page's EventSender object to get it working fully though,
1592         so only unskipping Qt here.
1593
1594         https://bugs.webkit.org/show_bug.cgi?id=60722
1595
1596         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1597         (WebCore::WebPage::WebPage):
1598         (WebCore::WebPage::eventSender):
1599         (WebCore::DumpRenderTree::DumpRenderTree):
1600         (WebCore::DumpRenderTree::initJSObjects):
1601         (WebCore::DumpRenderTree::createWindow):
1602         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1603         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1604         (webkit_test_plugin_new_instance):
1605         (webkit_test_plugin_set_window):
1606         (webkit_test_plugin_handle_event):
1607
1608 2011-05-14  Arno Renevier  <arno@renevier.net>
1609
1610         Reviewed by Martin Robinson.
1611
1612         make run-gtk-tests executable
1613         https://bugs.webkit.org/show_bug.cgi?id=59278
1614
1615         * Scripts/run-gtk-tests:
1616
1617 2011-05-14  Anders Carlsson  <andersca@apple.com>
1618
1619         Reviewed by Kevin Decker.
1620
1621         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
1622         https://bugs.webkit.org/show_bug.cgi?id=60823
1623         <rdar://problem/9430386>
1624
1625         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
1626
1627         * DumpRenderTree/DumpRenderTree.gypi:
1628         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1629         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
1630         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
1631         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
1632         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
1633         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1634         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1635         * GNUmakefile.am:
1636
1637 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1638
1639         Unreviewed, rolling out r86476.
1640         http://trac.webkit.org/changeset/86476
1641         https://bugs.webkit.org/show_bug.cgi?id=60832
1642
1643         It made plugins/get-url-notify-with-url-that-fails-to-
1644         load.html crash on GTK (Requested by Ossy on #webkit).
1645
1646         * DumpRenderTree/DumpRenderTree.gypi:
1647         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1648         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
1649         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1650         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1651         * GNUmakefile.am:
1652
1653 2011-05-13  Anders Carlsson  <andersca@apple.com>
1654
1655         Reviewed by Sam Weinig.
1656
1657         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
1658         https://bugs.webkit.org/show_bug.cgi?id=60823
1659         <rdar://problem/9430386>
1660
1661         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
1662
1663         * DumpRenderTree/DumpRenderTree.gypi:
1664         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1665         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
1666         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
1667         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
1668         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
1669         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1670         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1671         * GNUmakefile.am:
1672
1673 2011-05-13  Anders Carlsson  <andersca@apple.com>
1674
1675         Build fix.
1676
1677         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
1678
1679 2011-05-13  Anders Carlsson  <andersca@apple.com>
1680
1681         Reviewed by Sam Weinig.
1682
1683         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
1684         https://bugs.webkit.org/show_bug.cgi?id=60810
1685
1686         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
1687
1688         * DumpRenderTree/DumpRenderTree.gypi:
1689         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1690         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1691         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1692         * GNUmakefile.am:
1693         Add files.
1694
1695         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1696         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1697         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
1698
1699         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
1700         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
1701         (GetURLWithJavaScriptURL::NPP_New):
1702         (GetURLWithJavaScriptURL::NPP_NewStream):
1703         (GetURLWithJavaScriptURL::NPP_DestroyStream):
1704         (GetURLWithJavaScriptURL::NPP_WriteReady):
1705         (GetURLWithJavaScriptURL::NPP_Write):
1706         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1707         (NPP_NewStream):
1708         (NPP_WriteReady):
1709         (NPP_Write):
1710         (NPP_URLNotify):
1711         call the PluginTest NPP wrappers.
1712
1713 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1714
1715         Unreviewed, rolling out r86447.
1716         http://trac.webkit.org/changeset/86447
1717         https://bugs.webkit.org/show_bug.cgi?id=60809
1718
1719         "Broke some uses of EventSender object on Qt" (Requested by
1720         mwenge on #webkit).
1721
1722         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1723         (WebCore::WebPage::WebPage):
1724         (WebCore::DumpRenderTree::DumpRenderTree):
1725         (WebCore::DumpRenderTree::initJSObjects):
1726         (WebCore::DumpRenderTree::createWindow):
1727         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1728         (WebCore::DumpRenderTree::eventSender):
1729         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1730         (webkit_test_plugin_new_instance):
1731         (webkit_test_plugin_set_window):
1732         (webkit_test_plugin_handle_event):
1733
1734 2011-05-13  Robert Hogan  <robert@webkit.org>
1735
1736         Reviewed by Benjamin Poulain.
1737
1738         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1739
1740         The support for this test added to the unix test plugin here
1741         may allow other platforms to pass it (nearly everyone
1742         skips it). On Qt it required a bit of trickiness with
1743         the page's EventSender object to get it working fully though,
1744         so only unskipping Qt here.
1745
1746         https://bugs.webkit.org/show_bug.cgi?id=60722
1747
1748         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1749         (WebCore::WebPage::WebPage):
1750         (WebCore::WebPage::eventSender):
1751         (WebCore::DumpRenderTree::DumpRenderTree):
1752         (WebCore::DumpRenderTree::initJSObjects):
1753         (WebCore::DumpRenderTree::createWindow):
1754         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1755         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1756         (webkit_test_plugin_new_instance):
1757         (webkit_test_plugin_set_window):
1758         (webkit_test_plugin_handle_event):
1759
1760 2011-05-13  Adam Roben  <aroben@apple.com>
1761
1762         Exclude the Leopard NRWT bot from the core builder set
1763
1764         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
1765
1766         Reviewed by Darin Adler.
1767
1768         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1769         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
1770         in the core builder set.
1771
1772         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1773         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
1774         regexps.
1775
1776 2011-05-13  Adam Roben  <aroben@apple.com>
1777
1778         Group all the NRWT bots together
1779
1780         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
1781         bots are experimental, it seems best not to clutter up the non-experimental bots with
1782         experimental ones.
1783
1784         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
1785         on build.webkit.org
1786
1787         Reviewed by Dan Bernstein.
1788
1789         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
1790         Chromium testers, which also use new-run-webkit-tests.
1791
1792 2011-05-13  Adam Roben  <aroben@apple.com>
1793
1794         Add a plugin test that dumps the plugin window's rect
1795
1796         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
1797         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
1798
1799         Reviewed by Dan Bernstein.
1800
1801         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
1802         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
1803         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
1804         harness window and log it.
1805
1806         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
1807
1808 2011-05-13  Adam Roben  <aroben@apple.com>
1809
1810         Move code required for most tests of plugin window geometry into a base class
1811
1812         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
1813         having all the trickiness in a shared base class, writing new window geometry tests will be
1814         much easier.
1815
1816         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
1817
1818         Reviewed by Anders Carlsson.
1819
1820         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
1821         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
1822         WindowGeometryTest base class. Most of the code from this class was moved to the new base
1823         class.
1824         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
1825         This is called by the base class when it is safe to check the window's geometry. Note that
1826         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
1827         just vestigial code from an earlier version of this test.
1828
1829         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
1830         WindowGeometryTest class.
1831
1832         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
1833         WindowRegionIsSetToClipRect.
1834         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
1835         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
1836         Subclasses can implement that function to perform their own tests.
1837
1838         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
1839
1840 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
1841
1842         Reviewed by Csaba Osztrogonác.
1843
1844         Missing 2nd #EOF if WebProcess is killed.
1845         https://bugs.webkit.org/show_bug.cgi?id=60761
1846
1847         If the WebProcess is killed, only one #EOF is yielded
1848         by WebKitTestRunner. However, run-webkit-test wait for
1849         a second #EOF, which signals the finishing of pixel dump.
1850         Since this never happens, run-webkit-test waits forever.
1851
1852         * WebKitTestRunner/TestInvocation.cpp:
1853         (WTR::TestInvocation::dump):
1854         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1855         * WebKitTestRunner/TestInvocation.h:
1856
1857 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1858
1859         Reviewed by Csaba Osztrogonác.
1860
1861         [NRWT] chromium-linux tests shouldn't run on other platforms
1862         https://bugs.webkit.org/show_bug.cgi?id=60162
1863
1864         Remove _tests_for_other_platforms defs because r82753
1865         implemented it properly in the baseclass in webkit.py.
1866
1867         * Scripts/webkitpy/layout_tests/port/gtk.py:
1868         * Scripts/webkitpy/layout_tests/port/qt.py:
1869         * Scripts/webkitpy/layout_tests/port/win.py:
1870
1871 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
1872
1873         Reviewed by Antonio Gomes.
1874
1875         [EFL] Remove unused option of EWeblauncher
1876         https://bugs.webkit.org/show_bug.cgi?id=60747
1877
1878         Remove sudo-workaround option.
1879         This option is not used and make other option wrong.
1880
1881         * EWebLauncher/main.c:
1882
1883 2011-05-12  Lucas Forschler  <lforschler@apple.com>
1884
1885         Reviewed by Stephanie Lewis.
1886
1887         Fix config.json to address missing WK2 builder/tester config.
1888         Fix naming of machines (xserve not macpro)
1889
1890         * BuildSlaveSupport/build.webkit.org-config/config.json:
1891
1892 2011-05-12  Lucas Forschler  <lforschler@apple.com>
1893
1894         Reviewed by Stephanie Lewis.
1895
1896         Add SnowLeopard Debug builder and Test bot.
1897         apple-xserve-8 = SL Debug Tester.
1898         apple-xserve-9 = SL Debug Builder.
1899         
1900         * BuildSlaveSupport/build.webkit.org-config/config.json:
1901
1902 2011-05-12  Adam Barth  <abarth@webkit.org>
1903
1904         This patch disables sheriffbot's bug postings.  He's just been way too
1905         spammy recently due to test flakiness.
1906
1907         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1908         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1909
1910 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
1911
1912         Reviewed by Anders Carlsson.
1913
1914         After relaunching an unresponsive web process, web page stops responding to mouse movement
1915         https://bugs.webkit.org/show_bug.cgi?id=60669
1916         <rdar://problem/9409934>
1917         
1918         This test follows the steps needed to reproduce this bug:
1919         1) Hang the web process
1920         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
1921         3) Kill and restart the WebProcess
1922         4) Move the mouse
1923         
1924         We are testing that we receive mouse move events after the WebProcess has restarted.
1925
1926         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
1927         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
1928         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
1929         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
1930         (TestWebKitAPI::setPageLoaderClient):
1931         (TestWebKitAPI::TEST):
1932         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
1933         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
1934         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
1935         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
1936
1937         * TestWebKitAPI/PlatformWebView.h:
1938         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1939         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
1940         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1941         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
1942
1943         Add new files.
1944         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1945         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1946         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1947         * TestWebKitAPI/win/copy-resources.cmd:
1948
1949 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
1950
1951         Reviewed by Antonio Gomes.
1952
1953         [EFL] Added initialization/shutdown for ecore_file library
1954         https://bugs.webkit.org/show_bug.cgi?id=60457
1955
1956         Added initialization and shuthown for ecore_file library and replaced
1957         realpath function to ecore_file_realpath.
1958
1959         * EWebLauncher/main.c:
1960         (quit):
1961         (findThemePath):
1962         (main):
1963
1964 2011-05-12  Young Han Lee  <joybro@company100.net>
1965
1966         Reviewed by Kenneth Rohde Christiansen.
1967
1968         [Qt] Implement layoutTestController.layerTreeAsText()
1969         https://bugs.webkit.org/show_bug.cgi?id=60367
1970
1971         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1972         (LayoutTestController::layerTreeAsText):
1973         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1974
1975 2011-05-11  Eric Seidel  <eric@webkit.org>
1976
1977         Reviewed by David Levin.
1978
1979         Teach validate-committer-lists how to validate committers bugzilla_email()
1980         https://bugs.webkit.org/show_bug.cgi?id=60651
1981
1982         It turns out we currently have 9 committers with invalid values for their
1983         bugzilla_email field (meaning we don't know what email is their bugzilla account).
1984         "Alexander Kellett" <lypanov@mac.com>
1985         "Andre Boule" <aboule@apple.com>
1986         "Cameron McCormack" <cam@webkit.org>
1987         "Chris Petersen" <cpetersen@apple.com>
1988         "Eli Fidler" <eli@staikos.net>
1989         "Matt Lilek" <webkit@mattlilek.com>
1990         "Pierre d'Herbemont" <pdherbemont@free.fr>
1991         "Scott Violet" <sky@chromium.org>
1992         "Adam Treat" <treat@kde.org>
1993
1994         Most of those haven't committed in a very long time, so it's not suprising
1995         that we haven't noticed that their bugzilla emails are bogus.
1996
1997         * Scripts/validate-committer-lists:
1998         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1999         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2000
2001 2011-05-11  Dmitry Lomov  <dslomov@google.com>
2002
2003         Reviewed by David Levin.
2004
2005         https://bugs.webkit.org/show_bug.cgi?id=59561
2006         Switch TestWebKitAPI to GTest
2007
2008         Fixes Makefiles and WinCairo build as well
2009
2010         * Makefile:
2011         * Scripts/build-api-tests:
2012         * Scripts/run-api-tests:
2013         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2014         * TestWebKitAPI/Test.h:
2015         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2016         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2017         (TestWebKitAPI::TEST):
2018         * TestWebKitAPI/TestsController.cpp:
2019         (TestWebKitAPI::TestsController::TestsController):
2020         (TestWebKitAPI::TestsController::dumpTestNames):
2021         (TestWebKitAPI::TestsController::runTestNamed):
2022         (TestWebKitAPI::TestsController::runAllTests):
2023         * TestWebKitAPI/TestsController.h:
2024         * TestWebKitAPI/mac/main.mm:
2025         (main):
2026
2027 2011-05-11  Eric Seidel  <eric@webkit.org>
2028
2029         Reviewed by Alexey Proskuryakov.
2030
2031         Add Luke Macpherson to committers.py as a Contributor
2032         https://bugs.webkit.org/show_bug.cgi?id=60639
2033
2034         * Scripts/webkitpy/common/config/committers.py:
2035
2036 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
2037
2038         Reviewed by Kenneth Rohde Christiansen.
2039
2040         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
2041         https://bugs.webkit.org/show_bug.cgi?id=60439
2042
2043         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
2044
2045         * Scripts/build-webkit:
2046
2047 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2048
2049         Reviewed by Adam Roben.
2050
2051         REGRESSION (r86161): WKPreferences API test failing on Windows
2052         https://bugs.webkit.org/show_bug.cgi?id=60658
2053
2054         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2055         (TestWebKitAPI::TEST):
2056
2057 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
2058
2059         Reviewed by Ojan Vafai.
2060
2061         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
2062         https://bugs.webkit.org/show_bug.cgi?id=60521
2063
2064         First steps towards making the results JSON all hierarchical.
2065
2066         * TestResultServer/model/jsonresults.py:
2067         * TestResultServer/model/jsonresults_unittest.py:
2068
2069 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
2070
2071         [wx] Build fix, adding new LayoutTestController method stubs.
2072
2073         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2074         (LayoutTestController::localStorageDiskUsageForOrigin):
2075         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2076
2077 2011-05-11  Jessie Berlin  <jberlin@apple.com>
2078
2079         Reviewed by Darin Adler.
2080
2081         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
2082         about the usage for both the origin overall and the database in question.
2083         https://bugs.webkit.org/show_bug.cgi?id=60573
2084
2085         * WebKitTestRunner/TestController.cpp:
2086         (WTR::exceededDatabaseQuota):
2087
2088 2011-05-10  Stephen White  <senorblanco@chromium.org>
2089
2090         Reviewed by David Levin.
2091
2092         Adding myself as a reviewer.
2093         https://bugs.webkit.org/show_bug.cgi?id=60587
2094
2095         * Scripts/webkitpy/common/config/committers.py:
2096
2097 2011-05-11  Eric Seidel  <eric@webkit.org>
2098
2099         Reviewed by Csaba Osztrogonác.
2100
2101         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
2102         https://bugs.webkit.org/show_bug.cgi?id=60614
2103
2104         AppEngine has a result limit of 1000.  We hit that when trying
2105         to find out how many patches the style-queue (and other queues)
2106         have passed in the last 30 days.  So lets display 1000+ instead
2107         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
2108
2109         I also made the status pages show "never" instead of just "ago" when we
2110         haven't seen a pass or boot message in the last 1000 messages.
2111
2112         * QueueStatusServer/handlers/queuestatus.py:
2113         * QueueStatusServer/templates/queuestatus.html:
2114
2115 2011-05-11  Adam Barth  <abarth@webkit.org>
2116
2117         Reviewed by Eric Seidel.
2118
2119         sheriffbot shouldn't spam bugs when it can't figure out who to blame
2120         https://bugs.webkit.org/show_bug.cgi?id=60613
2121
2122         This patch limits the number of bugs sheriffbot will spam to three.
2123         Ideally, we'd come up with some smarter huerstics, but hopefully this
2124         will cut down on the bugmail spam for slow bots.
2125
2126         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2127
2128 2011-05-10  Eric Seidel  <eric@webkit.org>
2129
2130         Reviewed by Adam Barth.
2131
2132         EWS bots should be robust against test-webkitpy hangs
2133         https://bugs.webkit.org/show_bug.cgi?id=60579
2134
2135         Added a killAfterTimeout subroutine, which takes a child_pid
2136         and timeout, and will setup a watchdog process to kill that child
2137         after the timeout.  killAfterTimeout will waitpid on the child.
2138
2139         * EWSTools/start-queue.sh:
2140
2141 2011-05-10  MORITA Hajime  <morrita@google.com>
2142
2143         Unreviewed, moved myself to the reviewers list.
2144
2145         * Scripts/webkitpy/common/config/committers.py:
2146
2147 2011-05-10  Anton D'Auria  <adauria@apple.com>
2148
2149         Reviewed by David Levin.
2150
2151         StorageTracker should report actual local storage usage on disk
2152         https://bugs.webkit.org/show_bug.cgi?id=60558
2153
2154         * DumpRenderTree/LayoutTestController.cpp:
2155         (localStorageDiskUsageForOriginCallback):
2156         (LayoutTestController::staticFunctions):
2157         * DumpRenderTree/LayoutTestController.h:
2158         * DumpRenderTree/chromium/LayoutTestController.cpp:
2159         (LayoutTestController::LayoutTestController):
2160         (LayoutTestController::localStorageDiskUsageForOrigin):
2161         * DumpRenderTree/chromium/LayoutTestController.h:
2162         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2163         (LayoutTestController::localStorageDiskUsageForOrigin):
2164         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2165         (LayoutTestController::localStorageDiskUsageForOrigin):
2166         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2167         (LayoutTestController::localStorageDiskUsageForOrigin):
2168         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2169         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2170         (LayoutTestController::localStorageDiskUsageForOrigin):
2171
2172 2011-05-10  Anton D'Auria  <adauria@apple.com>
2173
2174         Reviewed by Alexey Proskuryakov.
2175
2176         Add ApplicationCache API to get disk usage per origin
2177         https://bugs.webkit.org/show_bug.cgi?id=57127
2178
2179         Added test that loads two frames with ~15Kb image, checks usage,
2180         deletes app cache, verifies usage is 0.
2181
2182         * DumpRenderTree/LayoutTestController.cpp:
2183         (applicationCacheDiskUsageForOriginCallback):
2184         (LayoutTestController::staticFunctions):
2185         * DumpRenderTree/LayoutTestController.h:
2186         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2187         (LayoutTestController::LayoutTestController):
2188         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2189         * DumpRenderTree/chromium/LayoutTestController.h:
2190         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2191         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2192         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2193         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2194         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2195         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2196         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2197         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2198         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2199
2200 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2201
2202         Unreviewed, adding Rafael Antognolli as a committer.
2203
2204         * Scripts/webkitpy/common/config/committers.py:
2205
2206 2011-05-10  Chris Evans  <cevans@chromium.org>
2207
2208         Reviewed by Adam Barth.
2209
2210         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
2211         https://bugs.webkit.org/show_bug.cgi?id=58378
2212
2213         * DumpRenderTree/chromium/LayoutTestController.cpp:
2214         (LayoutTestController::LayoutTestController):
2215         (LayoutTestController::setAllowDisplayOfInsecureContent):
2216         (LayoutTestController::setAllowRunningOfInsecureContent):
2217         * DumpRenderTree/chromium/LayoutTestController.h:
2218         * DumpRenderTree/chromium/WebPreferences.cpp:
2219         (WebPreferences::reset):
2220         (WebPreferences::applyTo):
2221         * DumpRenderTree/chromium/WebPreferences.h:
2222         Add plumbing for new settings to Chromium DRT.
2223
2224 2011-05-10  Enrica Casucci  <enrica@apple.com>
2225
2226         Reviewed by Beth Dakin.
2227
2228         Added my name to the reviewers list and removed my name from
2229         to committer-only list.
2230
2231         * Scripts/webkitpy/common/config/committers.py:
2232
2233 2011-05-10  David Levin  <levin@chromium.org>
2234
2235         Reviewed by Shinichiro Hamaji.
2236
2237         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
2238         https://bugs.webkit.org/show_bug.cgi?id=60466
2239
2240         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
2241         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
2242           that property was removed.
2243         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
2244           filtering for errors.
2245         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
2246           verify that the line filtering is turned off.
2247         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
2248           and remove the unused file_path parameter.
2249         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
2250           line filtering is turned off (and fix test_no_error).
2251         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
2252           of errors based on the lines changed in the patch.
2253         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
2254           the filtering.
2255
2256 2011-05-10  Adam Roben  <aroben@apple.com>
2257
2258         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
2259
2260         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
2261         platform/win/plugins/window-geometry-initialized-before-set-window.html and
2262         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
2263         (WebKit2 Tests)
2264
2265         Reviewed by Anders Carlsson.
2266
2267         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
2268         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
2269         WindowedPluginTest::testHarnessWindow function.
2270
2271         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
2272         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
2273         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
2274         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
2275         created for.
2276
2277         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2278         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
2279         WindowedPluginTest, and initialized new members.
2280         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
2281         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
2282         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
2283         then clean up and tell the test harness we're done.
2284         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
2285         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
2286         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
2287         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
2288         window becomes visible.
2289         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
2290         if it was hidden at the start of the test.
2291         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
2292         This should cause our window to become visible and our window region to get set. When we get
2293         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
2294         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
2295         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
2296         "startTest".
2297         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
2298
2299         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
2300         (WindowedPluginTest::testHarnessWindow):
2301         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
2302         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
2303
2304 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
2305
2306         Reviewed by Kenneth Rohde Christiansen.
2307
2308         [Qt] Add new qt-4.8 platform for layout testing
2309         https://bugs.webkit.org/show_bug.cgi?id=60544
2310
2311         * Scripts/old-run-webkit-tests:
2312         * Scripts/webkitdirs.pm:
2313
2314 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2315
2316         Unreviewed, rolling out r86108.
2317         http://trac.webkit.org/changeset/86108
2318         https://bugs.webkit.org/show_bug.cgi?id=60533
2319
2320         Broke makefile based builds and Cairo (Requested by weinig on
2321         #webkit).
2322
2323         * Scripts/build-api-tests:
2324         * Scripts/run-api-tests:
2325         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2326         * TestWebKitAPI/Test.h:
2327         (TestWebKitAPI::Test::~Test):
2328         (TestWebKitAPI::Test::name):
2329         (TestWebKitAPI::Test::Register::Register):
2330         (TestWebKitAPI::Test::Register::create):
2331         (TestWebKitAPI::Test::Test):
2332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2333         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2334         (TestWebKitAPI::TEST):
2335         * TestWebKitAPI/TestsController.cpp:
2336         (TestWebKitAPI::TestsController::TestsController):
2337         (TestWebKitAPI::TestsController::dumpTestNames):
2338         (TestWebKitAPI::TestsController::runTestNamed):
2339         (TestWebKitAPI::TestsController::testFailed):
2340         (TestWebKitAPI::TestsController::registerCreateTestFunction):
2341         * TestWebKitAPI/TestsController.h:
2342         * TestWebKitAPI/mac/main.mm:
2343         (main):
2344
2345 2011-05-09  Hayato Ito  <hayato@chromium.org>
2346
2347         Reviewed by Ojan Vafai.
2348
2349         Skip reftests if pixel tests are disabled.
2350
2351         https://bugs.webkit.org/show_bug.cgi?id=59078
2352
2353         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2354         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2355         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2356         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2357
2358 2011-05-09  Chang Shu  <cshu@webkit.org>
2359
2360         Reviewed by Kenneth Rohde Christiansen.
2361
2362         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
2363         https://bugs.webkit.org/show_bug.cgi?id=60499
2364
2365         The implementation is similar to gtk.
2366
2367         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2368         (TextInputController::unmarkText):
2369         * DumpRenderTree/qt/TextInputControllerQt.h:
2370
2371 2011-05-09  James Robinson  <jamesr@chromium.org>
2372
2373         Reviewed by Eric Seidel.
2374
2375         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
2376         https://bugs.webkit.org/show_bug.cgi?id=60520
2377
2378         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2379
2380 2011-05-09  Dmitry Lomov  <dslomov@google.com>
2381
2382         Reviewed by Sam Weinig.
2383
2384         Switch TestWebKitAPI to GTest
2385         https://bugs.webkit.org/show_bug.cgi?id=59561
2386
2387         * Scripts/build-api-tests:
2388         * Scripts/run-api-tests:
2389         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2390         * TestWebKitAPI/Test.h:
2391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2392         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2393         (TestWebKitAPI::TEST):
2394         * TestWebKitAPI/TestsController.cpp:
2395         (TestWebKitAPI::TestsController::TestsController):
2396         (TestWebKitAPI::TestsController::dumpTestNames):
2397         (TestWebKitAPI::TestsController::runTestNamed):
2398         (TestWebKitAPI::TestsController::runAllTests):
2399         * TestWebKitAPI/TestsController.h:
2400         * TestWebKitAPI/mac/main.mm:
2401         (main):
2402
2403 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
2404
2405         Reviewed by Andreas Kling.
2406
2407         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
2408         https://bugs.webkit.org/show_bug.cgi?id=60487
2409
2410         When adding a new touch point, the start position of this point needs to be set.
2411
2412         * DumpRenderTree/qt/EventSenderQt.cpp:
2413         (EventSender::addTouchPoint):
2414
2415 2011-05-09  Robert Hogan  <robert@webkit.org>
2416
2417         Reviewed by Adam Roben.
2418
2419         https://bugs.webkit.org/show_bug.cgi?id=57137
2420
2421         Unskip plugins/embed-prefers-plugins-for-images.html
2422
2423         Add image/png mime-type to test netscape plugin on Unix.
2424
2425         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2426         (NP_GetMIMEDescription):
2427
2428 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
2429
2430         Reviewed by Ojan Vafai.
2431
2432         Pull jsonresults_unittest test cases out into separate test methods.
2433         https://bugs.webkit.org/show_bug.cgi?id=60418
2434
2435         * TestResultServer/model/jsonresults_unittest.py:
2436
2437 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2438
2439         Reviewed by Andreas Kling.
2440
2441         [Qt] fix fast/dom/Geolocation/window-close-crash.html
2442         https://bugs.webkit.org/show_bug.cgi?id=60458
2443
2444         Update all pages with Mock position/error/permission.
2445
2446         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2447         (LayoutTestController::setGeolocationPermission):
2448         (LayoutTestController::setMockGeolocationError):
2449         (LayoutTestController::setMockGeolocationPosition):
2450
2451 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
2452
2453         Reviewed by Tony Gentilcore.
2454
2455         Implement Page Visibility API.
2456         https://bugs.webkit.org/show_bug.cgi?id=54181
2457
2458         * DumpRenderTree/LayoutTestController.cpp:
2459         (setPageVisibilityCallback):
2460         (resetPageVisibilityCallback):
2461         (LayoutTestController::staticFunctions):
2462         * DumpRenderTree/LayoutTestController.h:
2463         (LayoutTestController::setPageVisibility):
2464         (LayoutTestController::resetPageVisibility):
2465         * DumpRenderTree/chromium/LayoutTestController.cpp:
2466         (LayoutTestController::LayoutTestController):
2467         (LayoutTestController::resetPageVisibility):
2468         (LayoutTestController::setPageVisibility):
2469         * DumpRenderTree/chromium/LayoutTestController.h:
2470
2471 2011-05-07  Adam Barth  <abarth@webkit.org>
2472
2473         Reviewed by Eric Seidel.
2474
2475         Testing EWS spins on patches with a large number of failures
2476         https://bugs.webkit.org/show_bug.cgi?id=60441
2477
2478         In cases where the tree has a small number of persistent failures but a
2479         patch has a large number of failures, we weren't believing any results.
2480         That lead to us retrying the patch forever while we waited for
2481         trustworthy results that would never come.
2482
2483         This patch loosens the semantics of unexpected_failures to return a
2484         subset (rather than the exact set) of unexpected failures.  In the case
2485         where the tree has a bounded number of failures and the patch has an
2486         unbounded number of failures, we can accurately compute such a subset
2487         and reject the patch.
2488
2489         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2490         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2491         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2492         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2493         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2494
2495 2011-05-07  Joe Mason  <jmason@rim.com>
2496
2497         Reviewed by Daniel Bates.
2498
2499         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
2500         https://bugs.webkit.org/show_bug.cgi?id=52211
2501
2502         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
2503         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
2504
2505         * DumpRenderTree/chromium/WebViewHost.cpp:
2506         (WebViewHost::willPerformClientRedirect):
2507         (WebViewHost::didStartProvisionalLoad):
2508         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2509         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2510
2511 2011-05-07  Daniel Bates  <dbates@webkit.org>
2512
2513         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
2514         <http://trac.webkit.org/changeset/86007> (bug #60438).
2515
2516         * Scripts/old-run-webkit-tests:
2517           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
2518             file local variable. 
2519
2520 2011-05-07  Pratik Solanki  <psolanki@apple.com>
2521
2522         Reviewed by Darin Adler.
2523
2524         Remove references to Tiger in scripts
2525         https://bugs.webkit.org/show_bug.cgi?id=60438
2526
2527         Remove isTiger() and all of the code that depends on it.
2528
2529         * Scripts/build-webkit:
2530         * Scripts/ensure-valid-python:
2531         * Scripts/gdb-safari:
2532         * Scripts/webkitdirs.pm:
2533
2534 2011-05-06  David Grogan  <dgrogan@chromium.org>
2535
2536         Reviewed by Eric Seidel.
2537
2538         update link to message about mac 64bit git binaries
2539         https://bugs.webkit.org/show_bug.cgi?id=60411
2540
2541         The original message implied (correctly, at-the-time) that
2542         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
2543         binaries. The new message notes that they do. This might prevent someone
2544         else from spending a few minutes confused.
2545
2546         * Scripts/webkitpy/common/checkout/scm/git.py:
2547
2548 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
2549
2550         Reviewed by Ojan Vafai.
2551
2552         new-run-webkit-tests: crashes in race with crashing DRT
2553         https://bugs.webkit.org/show_bug.cgi?id=60238
2554
2555         This fixes a race where if we wrote the URL to DRT and
2556         DRT crashed immediately, we could get a broken pipe
2557         error back during the write() and not handle it correctly,
2558         causing NRWT to also crash.
2559
2560         * Scripts/webkitpy/layout_tests/port/server_process.py:
2561         * Scripts/webkitpy/layout_tests/port/webkit.py:
2562
2563 2011-05-06  Adam Barth  <abarth@webkit.org>
2564
2565         Reviewed by Eric Seidel.
2566
2567         Add a --skip-integrationtests mode to test-webkitpy
2568         https://bugs.webkit.org/show_bug.cgi?id=60354
2569
2570         These two test suites account for 2/3 of test-webkitpy's running time
2571         because they're not actually unit tests.  They're integration tests.
2572         This patch adds the ability to skip integration tests by passing a
2573         command line argument to test-webkitpy.  The buildbots will continue to
2574         run these integration tests to make sure they don't regress.  This
2575         option is for use by developers when working on parts of the code that
2576         are well-covered by unit tests.
2577
2578         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
2579         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2580         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
2581         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
2582         * Scripts/webkitpy/test/main.py:
2583
2584 2011-05-06  Adam Barth  <abarth@webkit.org>
2585
2586         Reviewed by Eric Seidel.
2587
2588         The results.zip generated by the Chromium EWS are too big
2589         https://bugs.webkit.org/show_bug.cgi?id=60352
2590
2591         Currently results.zip created by the Chromium EWS bot contain roughly
2592         1000 tests that we expect to fail.  These test results are not helpful
2593         to contributors.
2594
2595         There are several approaches to solving this problem:
2596
2597         1) We could be more selective about which files to include in the zip.
2598         2) We could ask new-run-webkit-tests not to generate results for
2599            expected failures.
2600         3) We could ask new-run-webkit-tests not to run tests that we expect to
2601            fail.
2602
2603         This patch takes approach (3).  Currently, we're ignoring the outcome
2604         of failing tests anyway, so there's not much point in actually running
2605         them.  As a side benefit, this will speed up the test run by about 6%.
2606         In the future, we might revisit this decision and choose another
2607         approach.
2608
2609         * Scripts/webkitpy/common/config/ports.py:
2610         * Scripts/webkitpy/common/config/ports_unittest.py:
2611
2612 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
2613
2614         Reviewed by Csaba Osztrogonác.
2615
2616         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
2617
2618         * Scripts/old-run-webkit-tests:
2619
2620 2011-05-06  Adam Barth  <abarth@webkit.org>
2621
2622         Reviewed by Ojan Vafai.
2623
2624         Add an option to NRWT to skip failing tests
2625         https://bugs.webkit.org/show_bug.cgi?id=60295
2626
2627         This option is similar to the way old-run-webkit-tests works.  We're
2628         planning to use this option on the testing EWS bots because they don't
2629         use information from failing tests yet.
2630
2631         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2632         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2633         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2634
2635 2011-05-04  Philippe Normand  <pnormand@igalia.com>
2636
2637         Reviewed by Dimitri Glazkov.
2638
2639         Implement LayoutTestController::pseudoShadowId()
2640         https://bugs.webkit.org/show_bug.cgi?id=60034
2641
2642         shadowPseudoId support in the various LayoutTestController
2643         implementations.
2644
2645         * DumpRenderTree/LayoutTestController.cpp:
2646         (shadowPseudoIdCallback):
2647         (LayoutTestController::staticFunctions):
2648         * DumpRenderTree/LayoutTestController.h:
2649         * DumpRenderTree/chromium/LayoutTestController.cpp:
2650         (LayoutTestController::LayoutTestController):
2651         (LayoutTestController::shadowPseudoId):
2652         * DumpRenderTree/chromium/LayoutTestController.h:
2653         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2654         (LayoutTestController::shadowPseudoId):
2655         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2656         (LayoutTestController::shadowPseudoId):
2657         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2658         (LayoutTestController::shadowPseudoId):
2659         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2660         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2661         (LayoutTestController::shadowPseudoId):
2662         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2663         (LayoutTestController::shadowPseudoId):
2664         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2665         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2666         (WTR::LayoutTestController::shadowPseudoId):
2667         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2668
2669 2011-05-06  Adam Barth  <abarth@webkit.org>
2670
2671         EWS can't reject patches
2672         https://bugs.webkit.org/show_bug.cgi?id=60345
2673
2674         We're supposed to use patch.id() for the attachment ID, silly.
2675
2676         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2677         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2678
2679 2011-05-05  Steve Lacey  <sjl@chromium.org>
2680
2681         Reviewed by Ojan Vafai.
2682
2683         Fix generation of results html file by passing relative path to scm
2684         methods.
2685         Generate diff images for results html file.
2686
2687         https://bugs.webkit.org/show_bug.cgi?id=60086
2688
2689         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2690         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2691
2692 2011-05-05  Andy Estes  <aestes@apple.com>
2693
2694         Reviewed by Daniel Bates.
2695
2696         update-webkit should handle Internal using a different VCS than OpenSource.
2697         https://bugs.webkit.org/show_bug.cgi?id=60310
2698
2699         isGit() and isSVN() cache their results, so Internal will always be
2700         updated using the VCS commands used for OpenSource. If Internal uses a
2701         different VCS, this will fail. Fix this by calling isGitDirectory() and
2702         isSVNDirectory() instead, which do not cache their results.
2703
2704         * Scripts/update-webkit:
2705
2706 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2707
2708         Reviewed by Ojan Vafai.
2709
2710         nrwt: revamp integration tests incl. tests for servers
2711         https://bugs.webkit.org/show_bug.cgi?id=59985
2712
2713         This change adds the ability to run "integration tests" that
2714         depend on (and affect) the local environment on your machine.
2715         These tests can be run manually by invoking python on the
2716         test file in question and passing the '-i' flag, but are
2717         not run automatically as part of test-webkitpy.
2718
2719         Integration tests are identified by being methods named as
2720         "integration_test_*" instead of "test_*", and we use a
2721         custom TestLoader instead of the default one provided by
2722         unittest.
2723
2724         This change also adds a protected "_default_to_apache" method
2725         to the port object so we can do the right thing when starting
2726         and stopping web servers with less mechanism.
2727
2728         * Scripts/webkitpy/layout_tests/port/base.py:
2729         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2730         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2731         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2732         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2733         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2734
2735 2011-05-05  Adam Roben  <aroben@apple.com>
2736
2737         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
2738
2739         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
2740         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
2741         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
2742         safeguard against this, we fill the alpha channel with constant full opacity after the
2743         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
2744         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
2745         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
2746         results need an alpha channel, too.)
2747
2748         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
2749         generated due to alpha channel weirdness
2750
2751         Reviewed by Sam Weinig.
2752
2753         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2754         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
2755         constant full opacity.
2756         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
2757         in a CGContext or cairo_surface.
2758
2759 2011-05-05  Adam Roben  <aroben@apple.com>
2760
2761         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
2762
2763         Passing true tells the test harness to dump pixels even though we're not dumping a render
2764         tree.
2765
2766         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
2767         WebKitTestRunner doesn't result in pixel results being generated
2768
2769         Reviewed by Sam Weinig.
2770
2771         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
2772         argument to dumpAsText.
2773
2774         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2775         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
2776
2777         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2778         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
2779
2780         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
2781
2782         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
2783         developers.
2784
2785 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2786
2787         Reviewed by Ojan Vafai.
2788
2789         new-run-webkit-tests: merge os, version fields in test config
2790         https://bugs.webkit.org/show_bug.cgi?id=60004
2791
2792         This change removes the 'o/s' field from the TestConfiguration
2793         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
2794         the expectations file to macros that expand to the version names
2795         for each platform.
2796
2797         This means that you can once again put any subset of the
2798         operating system versions on a single line, e.g.:
2799           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
2800
2801         This change will break any existing test_expectations.txt
2802         file that uses the "OS-VERSION" macros, which are no longer
2803         needed. It turns out they were never needed, as just VERSION
2804         by itself was sufficient. The test_expectations.txt file should
2805         be updated accordingly prior to landing this change.
2806
2807         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2808         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2809         * Scripts/webkitpy/layout_tests/port/base.py:
2810
2811 2011-05-05  Tony Chang  <tony@chromium.org>
2812
2813         Reviewed by Adam Barth.
2814
2815         [chromium] switch from Lucida to free fonts for Hindi and Thai
2816         https://bugs.webkit.org/show_bug.cgi?id=60287
2817
2818         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
2819         packages on Lucid. There are actually multiple Thai fonts in the
2820         package, so I just picked one.
2821
2822         * DumpRenderTree/chromium/TestShellGtk.cpp:
2823         (setupFontconfig):
2824
2825 2011-05-05  Tony Chang  <tony@chromium.org>
2826
2827         Reviewed by Ojan Vafai.
2828
2829         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
2830         https://bugs.webkit.org/show_bug.cgi?id=60290
2831
2832         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
2833         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
2834         lucid64.  Because of that, google-chrome-64 used to skip the
2835         chromium-linux-x86_64 results since they were more incorrect.
2836
2837         Now that we're switching to lucid for google-chrome, we want
2838         google-chrome-64 to fall back to chromium-linux-x86_64.
2839
2840         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2841
2842 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2843
2844         Reviewed by Ojan Vafai.
2845
2846         new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
2847         https://bugs.webkit.org/show_bug.cgi?id=60002
2848
2849         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2850         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2851         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2852         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2853         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2854         * Scripts/webkitpy/style/checkers/test_expectations.py:
2855
2856 2011-05-05  Eric Seidel  <eric@webkit.org>
2857
2858         Reviewed by Adam Barth.
2859
2860         commit-queue should reject patches which fail ewses
2861         https://bugs.webkit.org/show_bug.cgi?id=47534
2862
2863         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2864         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2865         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2866
2867 2011-05-05  Chang Shu  <cshu@webkit.org>
2868
2869         Reviewed by Andreas Kling.
2870
2871         [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
2872         https://bugs.webkit.org/show_bug.cgi?id=59638
2873
2874         1. Call QGraphicsWKView constructor with pageGroupRef.
2875         2. Disable setFontFamily calls as it breaks Qt test fonts.
2876
2877         * WebKitTestRunner/TestController.cpp:
2878         (WTR::TestController::resetStateToConsistentValues):
2879         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2880         (WTR::WebView::WebView):
2881         (WTR::PlatformWebView::PlatformWebView):
2882
2883 2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>
2884
2885         Reviewed by David Kilzer.
2886
2887         Add --only-webkit option to build-webkit
2888         https://bugs.webkit.org/show_bug.cgi?id=60245
2889
2890         * Scripts/build-webkit: If --only-webkit was specified
2891         just build the WebKit project, and not its dependencies.
2892
2893 2011-05-05  Jeff Miller  <jeffm@apple.com>
2894
2895         Reviewed by Darin Adler.
2896
2897         Add didNotHandleWheelEvent callback to WKPageUIClient
2898         https://bugs.webkit.org/show_bug.cgi?id=60203
2899
2900         * MiniBrowser/gtk/BrowserWindow.c:
2901         (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
2902         * MiniBrowser/mac/BrowserWindowController.m:
2903         (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
2904         * MiniBrowser/win/BrowserView.cpp:
2905         (BrowserView::create): Stub out didNotHandleWheelEvent callback.
2906         * WebKitTestRunner/TestController.cpp:
2907         (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
2908         (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
2909
2910 2011-05-04  Eric Seidel  <eric@webkit.org>
2911
2912         Reviewed by Adam Barth.
2913
2914         Add more missing imports from scm refactor
2915         https://bugs.webkit.org/show_bug.cgi?id=60239
2916
2917         * Scripts/webkitpy/common/checkout/scm/git.py:
2918         * Scripts/webkitpy/common/checkout/scm/svn.py:
2919
2920 2011-05-04  Eric Seidel  <eric@webkit.org>
2921
2922         Reviewed by Adam Barth.
2923
2924         sheriff-bot is having more exception trouble
2925         https://bugs.webkit.org/show_bug.cgi?id=60233
2926
2927         A webpage-forced build was causing SB to throw an exception.
2928         We've long had this bug, but we just didn't notice it until now.
2929
2930         In debugging this I found we fetch an absurd amount of data now
2931         that we use buildbot's json (instead of xmlrpc), so I added
2932         the filter=1 parameter to reduce it a little.  That required
2933         me to handle the case where filter=1 would strip
2934         result=0 in some cases (it's unclear why it does that).
2935
2936         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2937         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2938
2939 2011-05-04  Cris Neckar  <cdn@chromium.org>
2940
2941         Unreviewed, Adding Cris Neckar as a committer
2942
2943         * Scripts/webkitpy/common/config/committers.py:
2944
2945 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
2946
2947         Reviewed by Laszlo Gombos.
2948
2949         [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
2950         https://bugs.webkit.org/show_bug.cgi?id=59462
2951
2952         * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging. 
2953
2954 2011-05-04  Eric Seidel  <eric@webkit.org>
2955
2956         Reviewed by Adam Barth.
2957
2958         The testing EWS bots should upload layout-test-results.zip to bugs after failures
2959         https://bugs.webkit.org/show_bug.cgi?id=60223
2960
2961         This required sharing a bit of code between the commit-queue
2962         (which already knew how to do this) and the new EWS testing bots.
2963
2964         In the process I also cleaned up EWS testing a little and
2965         removed some dead code from the commit-queue.
2966
2967         * Scripts/webkitpy/common/config/committervalidator.py:
2968         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2969         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2970         * Scripts/webkitpy/tool/commands/queues.py:
2971         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2972
2973 2011-05-04  James Kozianski  <koz@chromium.org>
2974
2975         Reviewed by Eric Seidel.
2976
2977         Add method to make a Port able to retrieve TestOutputSets from its builders.
2978         https://bugs.webkit.org/show_bug.cgi?id=58211
2979
2980         This will be used in the new rebaseline script - TestOutputs are
2981         potential new baselines.
2982
2983         * Scripts/webkitpy/common/config/urls.py:
2984         * Scripts/webkitpy/layout_tests/port/base.py:
2985         * Scripts/webkitpy/layout_tests/port/chromium.py:
2986         * Scripts/webkitpy/layout_tests/port/factory.py:
2987         * Scripts/webkitpy/layout_tests/port/webkit.py:
2988
2989 2011-05-04  Eric Seidel  <eric@webkit.org>
2990
2991         Reviewed by Ojan Vafai.
2992
2993         sheriff-bot can't parse results.html
2994         https://bugs.webkit.org/show_bug.cgi?id=60196
2995
2996         The problem was that the NRWT bots are currently core
2997         and so sheriff-bot was trying to diagnose failures on
2998         them.  It was trying to parse their results.html file
2999         and BeautifulSoup was throwing an exception.
3000
3001         It seems our version of BeautifulSoup was quite old
3002         and unable to handle <script> tags correctly.
3003         This moves us to 3.2 which doesn't seem to have this bug.
3004
3005         * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
3006
3007 2011-05-04  Adam Barth  <abarth@webkit.org>
3008
3009         Reviewed by Eric Seidel.
3010
3011         Make the EWS test logging less verbose
3012         https://bugs.webkit.org/show_bug.cgi?id=60201
3013
3014         This should help us generate less than a hundred MB of logs per hour.
3015
3016         * Scripts/webkitpy/common/config/ports.py:
3017         * Scripts/webkitpy/common/config/ports_unittest.py:
3018
3019 2011-05-04  Tao Bai  <michaelbai@chromium.org>
3020
3021         Reviewed by David Kilzer.
3022
3023         Populate touch-icon url to FrameLoaderClient
3024         https://bugs.webkit.org/show_bug.cgi?id=59143
3025
3026         Disable touch icon by default. 
3027
3028         * Scripts/build-webkit:
3029
3030 2011-05-04  Justin Novosad  <junov@chromium.org>
3031
3032         Reviewed by Kenneth Russell.
3033
3034         [Chromium] Add gpu acceleration flags to DumpRenderTree
3035         https://bugs.webkit.org/show_bug.cgi?id=60168
3036         Adding support for command line flags 
3037         enable-accelerated-2d-canvas an
3038         enable-accelerated-drawing in DumpRenderTree.
3039
3040         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3041         (main):
3042         * DumpRenderTree/chromium/TestShell.cpp:
3043         (TestShell::TestShell):
3044         (TestShell::resetWebSettings):
3045         * DumpRenderTree/chromium/TestShell.h:
3046         (TestShell::setLegacyAccelerated2dCanvasEnabled):
3047         (TestShell::setAcceleratedDrawingEnabled):
3048         * DumpRenderTree/chromium/WebPreferences.cpp:
3049         (WebPreferences::reset):
3050         (WebPreferences::applyTo):
3051         * DumpRenderTree/chromium/WebPreferences.h:
3052
3053 2011-05-04  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3054
3055         Reviewed by Csaba Osztrogonác.
3056
3057         [Qt] run-qtwebkit-tests misses exec bit
3058         https://bugs.webkit.org/show_bug.cgi?id=60188
3059
3060         Also removing an unecessary import (mostly to let this bugfix goes
3061         through the system, as this is just a chmod).
3062
3063         * Scripts/run-qtwebkit-tests:
3064
3065 2011-05-04  Adam Barth  <abarth@webkit.org>
3066
3067         Fix import of ircproxy module to actually import the module.  I don't
3068         really understand how this code could have worked before.
3069
3070         * Scripts/webkitpy/common/host.py:
3071
3072 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
3073
3074         Reviewed by Andreas Kling.
3075
3076         [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
3077         https://bugs.webkit.org/show_bug.cgi?id=60172
3078
3079         * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
3080         (BrowserWindow::BrowserWindow):
3081
3082 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
3083
3084         Reviewed by Ojan Vafai.
3085
3086         [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
3087         https://bugs.webkit.org/show_bug.cgi?id=60088
3088         
3089         Makes --new-baseline put new baselines into the first entry in the
3090         baseline search path, including any additional directories passed in via
3091         --additional-platform-directory.
3092         
3093         Simplifies baseline_path() by making it return the first entry in the
3094         baseline search path instead of requiring each port to have an
3095         implementation (should not result in any behavior change).
3096
3097         * Scripts/webkitpy/layout_tests/port/base.py:
3098         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3099         * Scripts/webkitpy/layout_tests/port/chromium.py:
3100         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3101         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3102         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3103         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3104         * Scripts/webkitpy/layout_tests/port/mac.py:
3105         * Scripts/webkitpy/layout_tests/port/test.py:
3106         * Scripts/webkitpy/layout_tests/port/webkit.py:
3107
3108 2011-05-04  Adam Barth  <abarth@webkit.org>
3109
3110         Reviewed by Eric Seidel.
3111
3112         Fix circular dependency in webkitpy
3113         https://bugs.webkit.org/show_bug.cgi?id=60075
3114
3115         These functions don't belong in bugzilla.py.  They only exist there
3116         because they are old.  Really, these functions shouldn't be free
3117         functions at all, but that's a patch for another day.
3118
3119         * Scripts/webkitpy/common/checkout/changelog.py:
3120         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3121         * Scripts/webkitpy/common/checkout/checkout.py:
3122         * Scripts/webkitpy/common/config/urls.py:
3123         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3124         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3125         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3126         * Scripts/webkitpy/style/checkers/changelog.py:
3127         * Scripts/webkitpy/tool/bot/irc_command.py:
3128         * Scripts/webkitpy/tool/bot/sheriff.py:
3129         * Scripts/webkitpy/tool/commands/upload.py:
3130
3131 2011-05-03  Pratik Solanki  <psolanki@apple.com>
3132
3133         Reviewed by Dan Bernstein.
3134
3135         https://bugs.webkit.org/show_bug.cgi?id=60141
3136         Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
3137
3138         * Scripts/build-webkit:
3139
3140 2011-05-03  Mihai Parparita  <mihaip@chromium.org>
3141
3142         Reviewed by Ojan Vafai.
3143
3144         Update rebaseline queue server to handle hierarchical test results
3145         https://bugs.webkit.org/show_bug.cgi?id=60063
3146         
3147         Update test result parsing done by the rebaseline queue server to handle
3148         the hierarchical test result output that is generated as of r85254.
3149
3150         * RebaselineQueueServer/templates/builder-queue-edit.html:
3151
3152 2011-05-03  Eric Seidel  <eric@webkit.org>
3153
3154         Reviewed by Adam Roben.
3155
3156         webkit-patch post-commits HEAD^.. throws an exception
3157         https://bugs.webkit.org/show_bug.cgi?id=60027
3158
3159         * Scripts/webkitpy/common/checkout/scm/git.py:
3160
3161 2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
3162
3163         Reviewed by Kenneth Rohde Christiansen.
3164
3165         [Qt] Layout tests may timeout if loadFinished receives false
3166         https://bugs.webkit.org/show_bug.cgi?id=60064
3167
3168         When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
3169         then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
3170         a response is ignored, like it should be for 204 responses. It is a problem for creating
3171         tests for 204 responses for example.
3172
3173         This change has been tested and it causes no regressions in layout tests.
3174
3175         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3176         (LayoutTestController::maybeDump):
3177
3178 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3179
3180         Unreviewed, rolling out r85659.
3181         http://trac.webkit.org/changeset/85659
3182         https://bugs.webkit.org/show_bug.cgi?id=59977
3183
3184         restarting isn't working correctly
3185
3186         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3187         * Scripts/webkitpy/layout_tests/port/http_server.py:
3188         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3189         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3190
3191 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3192
3193         Reviewed by Ojan Vafai.
3194
3195         new-run-webkit-tests: fix http server startup/shutdown
3196
3197         Previous versions of the code had three problems that made startup
3198         and shutdown flaky. The first is that it would throw exceptions
3199         if it couldn't delete stale log files, which was overly
3200         paranoid. The second is that some of the exceptions weren't
3201         defined properly. The third, and most important, is that it was
3202         using urllib to check if ports were available, which was leaving
3203         sockets in a half-closed state, and keeping ports from being
3204         reused. By switching to raw sockets, we are able to now reliably
3205         restart.
3206
3207         This change also switches the code to using Executives to stop
3208         processes, which will let us delete a bunch of code in the
3209         port/* implementations and fix a weird layering problem in a
3210         subsequent patch.
3211
3212         https://bugs.webkit.org/show_bug.cgi?id=59977
3213
3214         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3215         * Scripts/webkitpy/layout_tests/port/http_server.py:
3216         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3217         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3218
3219 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3220
3221         Reviewed by Adam Barth.
3222
3223         fix failing printing_unittest on win32
3224         https://bugs.webkit.org/show_bug.cgi?id=59963
3225
3226         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3227
3228 2011-05-03  Adam Roben  <aroben@apple.com>
3229
3230         Fix most strict PassOwnPtr violations on Windows
3231
3232         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
3233         enabled
3234
3235         Reviewed by Anders Carlsson.
3236
3237         * WebKitAPITest/Test.h: Use adoptPtr.
3238
3239 2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3240
3241         Reviewed by Andreas Kling.
3242
3243         Add myself to the committers list.
3244
3245         * Scripts/webkitpy/common/config/committers.py:
3246
3247 2011-05-03  James Robinson  <jamesr@chromium.org>
3248
3249         Reviewed by Kenneth Russell.
3250
3251         [chromium] Layout test animations/3d/replace-filling-transform.html failing
3252         https://bugs.webkit.org/show_bug.cgi?id=59839
3253
3254         Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.
3255
3256         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3257
3258 2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3259
3260         Unreviewed, rolling out r85471.
3261         http://trac.webkit.org/changeset/85471
3262         https://bugs.webkit.org/show_bug.cgi?id=59922
3263
3264         The rule of thumb in EFL is that you init in all the places
3265         you use it. So, if in your application you call ecore_evas_*
3266         functions, you have to call ecore_evas_init() first.
3267
3268         * EWebLauncher/main.c: always call *_init() functions when you use
3269         that namespace.
3270         (quit):
3271         (main):
3272
3273 2011-05-02  Ojan Vafai  <ojan@chromium.org>
3274
3275         Reviewed by Tony Chang.
3276
3277         remove no longer used method
3278         https://bugs.webkit.org/show_bug.cgi?id=59981
3279
3280         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3281         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3282
3283 2011-05-02  Ojan Vafai  <ojan@chromium.org>
3284
3285         Reviewed by Tony Chang.
3286
3287         add image toggling behavior from old-run-webkit-tests
3288         https://bugs.webkit.org/show_bug.cgi?id=59978
3289
3290         Output -diffs.html files. This matches old-run-webkit-tests.
3291         In theory, we could use data urls in the results.html file, but
3292         data urls don't currently have access to local files.
3293
3294         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3295
3296 2011-05-02  Tony Chang  <tony@chromium.org>
3297
3298         Reviewed by Ojan Vafai.
3299
3300         [nrwt] remove some obsolete references to .checksum files
3301         https://bugs.webkit.org/show_bug.cgi?id=59971
3302
3303         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3304         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3305         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3306         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3307         * Scripts/webkitpy/layout_tests/port/test.py:
3308         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3309
3310 2011-05-02  Adam Roben  <aroben@apple.com>
3311
3312         Take advantage of implicit nullptr_t -> PassOwnPtr conversion
3313
3314         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
3315         doesn't work, but should
3316
3317         Reviewed by Adam Barth.
3318
3319         * DumpRenderTree/chromium/CppBoundClass.h:
3320         * DumpRenderTree/chromium/WebViewHost.cpp:
3321
3322 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3323
3324         Reviewed by Xan Lopez.
3325
3326         [GTK] Compiler warning in Tools/MiniBrowser/main.c
3327         https://bugs.webkit.org/show_bug.cgi?id=59986
3328
3329         Remove a compiler warning.
3330
3331         * MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers
3332         from complaining.
3333
3334 2011-05-02  Adam Barth  <abarth@webkit.org>
3335
3336         Reviewed by Eric Seidel.
3337
3338         Add runtests_unittest.py
3339         https://bugs.webkit.org/show_bug.cgi?id=59955
3340
3341         I forgot to add this file in a previous patch.
3342
3343         * Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
3344
3345 2011-05-02  Adam Barth  <abarth@webkit.org>
3346
3347         Change the testing EWS to log failures explicitly to avoid an infinite loop.
3348
3349         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3350
3351 2011-05-02  Adrienne Walker  <enne@google.com>
3352
3353         Unreviewed, fix misspelled contributor name.
3354
3355         * Scripts/webkitpy/common/config/committers.py:
3356
3357 2011-05-02  Adam Barth  <abarth@webkit.org>
3358
3359         Reviewed by Eric Seidel.
3360
3361         cr-linux-ews should run tests
3362         https://bugs.webkit.org/show_bug.cgi?id=59272
3363
3364         This patch turns on testing for the cr-linux-ews.  Yay!
3365
3366         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3367         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3368         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3369         * Scripts/webkitpy/tool/steps/runtests.py:
3370         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3371
3372 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3373
3374         Incorporate a review comment that I mistakenly omitted from my last commit.
3375
3376         * DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
3377
3378 2011-05-02  Adam Barth  <abarth@webkit.org>
3379
3380         Reviewed by Eric Seidel.
3381
3382         EWS should report the list of unexpected failures
3383         https://bugs.webkit.org/show_bug.cgi?id=59923
3384
3385         We cache the results of the first layout test results run on the task
3386         so the EWS can grab them later.  Another option is to include them in
3387         the exception that's thrown, but this approach seemed slightly more
3388         aesthetic.
3389
3390         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3391         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3392
3393 2011-05-02  Adam Barth  <abarth@webkit.org>
3394
3395         Reviewed by Eric Seidel.
3396
3397         Add base case for a test-running EWS
3398         https://bugs.webkit.org/show_bug.cgi?id=59920
3399
3400         Later I will subclass this to run the Chromium Linux EWS.
3401
3402         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
3403         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3404         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3405
3406 2011-05-02  Anders Carlsson  <andersca@apple.com>
3407
3408         Build fix.
3409
3410         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3411         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3412
3413 2011-05-02  Nico Weber  <thakis@chromium.org>
3414
3415         Reviewed by Mihai Parparita.
3416
3417         Add --no-webkit2 to the output of "build-webkit -h"
3418         https://bugs.webkit.org/show_bug.cgi?id=59942
3419
3420         * Scripts/build-webkit:
3421
3422 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3423
3424         Reviewed by Xan Lopez.
3425
3426         [GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
3427         https://bugs.webkit.org/show_bug.cgi?id=59943
3428
3429         Disable the Ubuntu overlay scrollbar while testing, by injecting the
3430         LIBOVERLAY_SCROLLBAR=0 environment variable.
3431
3432         * Scripts/old-run-webkit-tests:
3433
3434 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3435
3436         Reviewed by Eric Seidel.
3437
3438         [GTK] editing/selection/select-out-of-editable.html failing after r83967
3439         https://bugs.webkit.org/show_bug.cgi?id=58667
3440
3441         Do not trigger mouse down events when the EventSender knows that a mouse button is
3442         already down. These type of situations can confuse Xvfb and cause dragging failures.
3443
3444         * DumpRenderTree/gtk/EventSender.cpp:
3445         (mouseDownCallback): Do not trigger another mouse button down event if the mouse button
3446         is already down. This can interfere with drags in Xvfb.
3447
3448 2011-05-02  Zsolt Fehér  <h490267@stud.u-szeged.hu>
3449
3450         Reviewed by Csaba Osztrogonác.
3451
3452         DRT sideeffect revealed by r71268.
3453         https://bugs.webkit.org/show_bug.cgi?id=48958
3454
3455         Reset QWebSettings::ZoomTextOnly attribute before all tests. 
3456
3457         Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and 
3458         PageZoomFactor too. It should be done before resetsettings() 
3459         to guarantee resetting QWebSettings::ZoomTextOnly correctly.
3460
3461         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3462         (WebCore::WebPage::resetSettings):
3463         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3464
3465 2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3466
3467         Unreviewed, rolling out r85469.
3468         http://trac.webkit.org/changeset/85469
3469         https://bugs.webkit.org/show_bug.cgi?id=59928
3470
3471         Broke  webkitpy-tests on Windows 7, GTK and Qt. (Requested by
3472         bbandix on #webkit).
3473
3474         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
3475         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3476         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3477
3478 2011-05-02  Tomasz Morawski  <t.morawski@samsung.com>
3479
3480         Reviewed by Kenneth Rohde Christiansen.
3481
3482         Cleanup EFL initialization/shutdown in the EWebLauncher
3483         https://bugs.webkit.org/show_bug.cgi?id=59922
3484
3485         Removed ecore_evas_init and edje_init form main function due to they
3486         are also called in the ewk_init. Moved ewk_shutdown to quit function.
3487
3488         * EWebLauncher/main.c:
3489         (quit):
3490         (main):
3491
3492 2011-05-02  Adam Barth  <abarth@webkit.org>
3493
3494         Reviewed by Eric Seidel.
3495
3496         Add base case for a test-running EWS
3497         https://bugs.webkit.org/show_bug.cgi?id=59920
3498
3499         Later I will subclass this to run the Chromium Linux EWS.
3500
3501         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
3502         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3503         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3504
3505 2011-05-02  Adam Barth  <abarth@webkit.org>
3506
3507         Reviewed by Eric Seidel.
3508
3509         Add the ability to skip python and perl unit tests on EC2
3510         https://bugs.webkit.org/show_bug.cgi?id=59918
3511
3512         * Scripts/webkitpy/common/config/ports.py:
3513             - This is slightly ugly, but it's useful...
3514         * Scripts/webkitpy/common/config/ports_unittest.py:
3515         * Scripts/webkitpy/tool/mocktool.py:
3516         * Scripts/webkitpy/tool/steps/runtests.py:
3517
3518 2011-05-02  Adam Barth  <abarth@webkit.org>
3519
3520         Reviewed by Eric Seidel.
3521
3522         webkit-patch --non-interactive is incompatible with new-run-webkit-tests
3523         https://bugs.webkit.org/show_bug.cgi?id=59919
3524
3525         new-run-webkit-tests doesn't support --wait-for-httpd (because it
3526         always waits for HTTPD, as I understand things).  It turns out we're
3527         not really using this flag for anything, so we should just remove it.
3528
3529         * Scripts/webkitpy/tool/steps/runtests.py:
3530         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3531
3532 2011-05-01  Eric Seidel  <eric@webkit.org>
3533
3534         Reviewed by Adam Barth.
3535
3536         The bots should learn from expected failures without having to retry
3537         https://bugs.webkit.org/show_bug.cgi?id=59279
3538
3539         Rather than re-trying the whole patch, we can just check whether we now
3540         expect the failures we see with the patch applied, saving a lot of time.
3541
3542         This patch also teaches the CommitQueue how to reject patches even
3543         when the tree is red using the new unexpected_failures() method on
3544         ExpectedFailures.
3545
3546         Finally in testing we found a bug in ExpectedFailures where it would
3547         "trust" results which had many many failures, due to using an
3548         equal sign instead of a less-than sign.
3549
3550         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
3551         * Scripts/webkitpy/tool/bot/expectedfailures.py
3552         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
3553         * Scripts/webkitpy/tool/bot/patchanalysistask.py
3554
3555
3556 2011-05-02  Adam Barth  <abarth@webkit.org>
3557
3558         Reviewed by Eric Seidel.
3559
3560         workspace.py fails to import ScriptError
3561         https://bugs.webkit.org/show_bug.cgi?id=59915
3562
3563         If the workspace fails to create a zip, webkitpy crashes instead of
3564         handling the error as expected.
3565
3566         * Scripts/webkitpy/common/system/workspace.py:
3567         * Scripts/webkitpy/common/system/workspace_unittest.py:
3568         * Scripts/webkitpy/tool/mocktool.py:
3569
3570 2011-05-01  Adam Barth  <abarth@webkit.org>
3571
3572         Remove unadvertantly added file.
3573
3574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3575
3576 2011-05-01  Adam Barth  <abarth@webkit.org>
3577
3578         Reviewed by Eric Seidel.
3579
3580         expectedfailures.py should report the unexpected failures when asked
3581         https://bugs.webkit.org/show_bug.cgi?id=59916
3582
3583         This information is useful when the EWS runs tests.
3584
3585         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3586         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3587
3588 2011-05-01  Adam Barth  <abarth@webkit.org>
3589
3590         Reviewed by Eric Seidel.
3591
3592         JSONTestResult needs to handle multiple results
3593         https://bugs.webkit.org/show_bug.cgi?id=59269
3594
3595         This case occurs when a test is flaky because NRWT will run the test
3596         twice and report both results as "actual."
3597
3598         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3599         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3600
3601 2011-05-01  Adam Barth  <abarth@webkit.org>
3602
3603         Reviewed by Eric Seidel.
3604
3605         Move checkout/api.py to checkout/checkout.py
3606         https://bugs.webkit.org/show_bug.cgi?id=59906
3607
3608         This is more consistent with Python style.
3609
3610         * Scripts/webkitpy/common/checkout/__init__.py:
3611         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3612         * Scripts/webkitpy/common/host.py:
3613         * Scripts/webkitpy/tool/main.py:
3614
3615 2011-05-01  Eric Seidel  <eric@webkit.org>
3616
3617         Reviewed by Adam Barth.
3618
3619         scm.py should be split into many pieces
3620         https://bugs.webkit.org/show_bug.cgi?id=59908
3621
3622         Forgot an AuthenticationError import.
3623
3624         * Scripts/webkitpy/common/checkout/scm/git.py:
3625         * Scripts/webkitpy/common/checkout/scm/svn.py:
3626
3627 2011-05-01  Arno Renevier  <arno@renevier.net>
3628
3629         Reviewed by Eric Seidel.
3630
3631         wrong exception raised in Lighttpd start method
3632         https://bugs.webkit.org/show_bug.cgi?id=59283
3633
3634         raise standard Exception instead of non existent
3635         google.httpd_utils.HttpdNotStarted
3636
3637         * Scripts/webkitpy/layout_tests/port/http_server.py:
3638
3639 2011-05-01  Eric Seidel  <eric@webkit.org>
3640
3641         Reviewed by Adam Barth.
3642
3643         scm.py should be split into many pieces
3644         https://bugs.webkit.org/show_bug.cgi?id=59908
3645
3646         * Scripts/webkitpy/common/checkout/scm/__init__.py:
3647         * Scripts/webkitpy/common/checkout/scm/commitmessage.py: Added.
3648         * Scripts/webkitpy/common/checkout/scm/git.py: Added.
3649         * Scripts/webkitpy/common/checkout/scm/scm.py:
3650         * Scri