Fix BenchmarkRunner to only import selenium when needed
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2
3         Fix BenchmarkRunner to only import selenium when needed
4         https://bugs.webkit.org/show_bug.cgi?id=174808
5
6         Reviewed by Stephanie Lewis.
7
8         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
9         (LinuxChromeDriver.launch_driver):
10         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
11         (LinuxFirefoxDriver.launch_driver):
12         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
13         (OSXChromeDriver.launch_driver):
14         (OSXChromeCanaryDriver.launch_driver):
15         (create_chrome_options):
16         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
17         (OSXFirefoxDriver.launch_driver):
18         (OSXFirefoxNightlyDriver.launch_driver):
19         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
20         (OSXSafariDriver.launch_driver):
21         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
22         (WebDriverBenchmarkRunner._run_one_test):
23
24 2017-07-23  Darin Adler  <darin@apple.com>
25
26         More NeverDestroyed and related cleanup
27         https://bugs.webkit.org/show_bug.cgi?id=174745
28
29         Reviewed by Alex Christensen.
30
31         * DumpRenderTree/JavaScriptThreading.cpp:
32         (javaScriptThreadsMutex): Use NeverDestroyed instead of
33         DEPRECATED_DEFINE_STATIC_LOCAL.
34         (javaScriptThreads): Ditto.
35
36 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
37
38         Subclass Benchmark Runner script for WebDriver support
39         https://bugs.webkit.org/show_bug.cgi?id=174390
40
41         Reviewed by Dewei Zhu, Stephanie Lewis.
42
43         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
44
45         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
46         (BenchmarkBuilder.__init__):
47         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
48         (BenchmarkRunner.__init__):
49         (BenchmarkRunner._find_plan_file):
50         (BenchmarkRunner._run_one_test.and):
51         (BenchmarkRunner.execute):
52         (BenchmarkRunner._get_result): Deleted.
53         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
54         (parse_args):
55         (start):
56         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
57         (WebDriverBenchmarkRunner):
58         (WebDriverBenchmarkRunner._get_result):
59         (WebDriverBenchmarkRunner._run_one_test):
60         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
61         (WebServerBenchmarkRunner):
62         (WebServerBenchmarkRunner.__init__):
63         (WebServerBenchmarkRunner._get_result):
64         (WebServerBenchmarkRunner._run_one_test):
65
66 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
67
68         Add BenchmarkRunner patches with WebDriver support for each testing plan
69         https://bugs.webkit.org/show_bug.cgi?id=174443
70
71         Reviewed by Dewei Zhu, Stephanie Lewis.
72
73         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
74         (BenchmarkBuilder.__enter__):
75         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
76         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
77         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
78         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
79         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
80         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
81         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
82         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
83         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
84         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
85         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
86         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
87         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
88         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
89         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
90         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
91         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
92         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
93         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
94         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
95         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
96         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
97         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
98         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
99         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
100         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
101         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
102         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
103         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
104         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
105         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
106         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
107         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
108
109 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
110
111         Add functions to autoinstaller needed for Benchmark Runner script
112         https://bugs.webkit.org/show_bug.cgi?id=174331
113
114         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
115
116         Adds autoinstaller functions to install selenium and webdriver binaries
117         which will be used by the browser driver part of Benchmark Runner.
118
119         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
120         (BrowserDriver.restore_env):
121         (BrowserDriver):
122         (BrowserDriver.get_webdriver_binary_path):
123         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
124         (LinuxChromeDriver.launch_driver):
125         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
126         (LinuxFirefoxDriver.launch_driver):
127         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
128         (OSXChromeDriver.launch_driver):
129         (OSXChromeCanaryDriver.launch_driver):
130         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
131         (OSXFirefoxDriver.launch_driver):
132         (OSXFirefoxNightlyDriver.launch_driver):
133         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
134         * Scripts/webkitpy/benchmark_runner/utils.py:
135         (get_driver_binary_path):
136         * Scripts/webkitpy/common/system/autoinstall.py:
137         (AutoInstaller._unzip):
138         * Scripts/webkitpy/thirdparty/__init__.py:
139         (AutoinstallImportHook.find_module):
140         (AutoinstallImportHook._install_selenium):
141         (AutoinstallImportHook):
142         (AutoinstallImportHook._install_chromedriver):
143         (AutoinstallImportHook._install_geckodriver):
144         (AutoinstallImportHook.get_latest_pypi_url):
145         (AutoinstallImportHook.install_binary):
146         (autoinstall_everything):
147         (get_driver_filename):
148         (get_os_info):
149
150 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
151
152         Add WebDriver support in browser driver part of BenchmarkRunner
153         https://bugs.webkit.org/show_bug.cgi?id=174445
154
155         Reviewed by Stephanie Lewis.
156
157         Adds a launch_driver function to each BrowserDriver subclass. This
158         function sets up the arguments for the webdriver and launches the
159         webdriver specific to that browser.
160
161         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
162         (BrowserDriver.launch_webdriver):
163         (BrowserDriver):
164         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
165         (LinuxBrowserDriver.launch_webdriver):
166         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
167         (LinuxChromeDriver.launch_url):
168         (LinuxChromeDriver):
169         (LinuxChromeDriver.launch_driver):
170         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
171         (EpiphanyBrowserDriver.launch_url):
172         (EpiphanyBrowserDriver):
173         (EpiphanyBrowserDriver.launch_driver):
174         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
175         (LinuxFirefoxDriver):
176         (LinuxFirefoxDriver.launch_url):
177         (LinuxFirefoxDriver.launch_driver):
178         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
179         (GTKMiniBrowserDriver.launch_url):
180         (GTKMiniBrowserDriver):
181         (GTKMiniBrowserDriver.launch_driver):
182         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
183         (OSXBrowserDriver._launch_webdriver):
184         (OSXBrowserDriver):
185         (OSXBrowserDriver._screen_size):
186         (OSXBrowserDriver._insert_url):
187         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
188         (OSXChromeDriver):
189         (OSXChromeDriver.launch_url):
190         (OSXChromeDriver.launch_driver):
191         (OSXChromeCanaryDriver):
192         (OSXChromeCanaryDriver.launch_url):
193         (OSXChromeCanaryDriver.launch_driver):
194         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
195         (OSXFirefoxDriver):
196         (OSXFirefoxDriver.launch_url):
197         (OSXFirefoxDriver.launch_driver):
198         (OSXFirefoxNightlyDriver):
199         (OSXFirefoxNightlyDriver.launch_url):
200         (OSXFirefoxNightlyDriver.launch_driver):
201         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
202         (OSXSafariDriver.launch_driver):
203
204 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
205
206         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
207         https://bugs.webkit.org/show_bug.cgi?id=174793
208
209         Reviewed by Tim Horton.
210
211         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
212         down. Without r219765, this test will dereference null and crash.
213
214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
215         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
216         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
217         (TEST):
218
219 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
220
221         [Win] Implement Authentication dialog in MiniBrowser
222         https://bugs.webkit.org/show_bug.cgi?id=174662
223
224         Reviewed by Alex Christensen.
225
226         * MiniBrowser/win/Common.cpp:
227         (CustomUserAgent):
228         (DisplayAuthDialog):
229         (AuthDialogProc):
230         * MiniBrowser/win/MiniBrowserLib.rc:
231         * MiniBrowser/win/MiniBrowserLibResource.h:
232         * MiniBrowser/win/ResourceLoadDelegate.cpp:
233         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
234
235 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
236
237         Handle case where line_numbers is None instead of an array of line numbers
238         https://bugs.webkit.org/show_bug.cgi?id=174775
239
240         Reviewed by Aakash Jain.
241
242         Added files set line_numbers to None in process_file.
243
244         * Scripts/webkitpy/style/filereader.py:
245         (TextFileReader.process_file): Handle case where line_number is set to None.
246         * Scripts/webkitpy/style/main_unittest.py:
247         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
248
249 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
250
251         [WPE] Add libepoxy to the Jhbuild moduleset
252         https://bugs.webkit.org/show_bug.cgi?id=174711
253
254         Reviewed by Carlos Alberto Lopez Perez.
255
256         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
257
258 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
259
260         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
261         https://bugs.webkit.org/show_bug.cgi?id=174780
262
263         Reviewed by Carlos Garcia Campos.
264
265         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
266         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
267         in case the eglplatform.h header doesn't provide that macro. This replicates
268         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
269
270 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
271
272         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
273         https://bugs.webkit.org/show_bug.cgi?id=174758
274
275         Reviewed by Dan Bernstein.
276
277         Migrate position-information-related unit tests from the PositionInformationTests suite to
278         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
279
280         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
281         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
282         (TestWebKitAPI::checkElementTypeAndBoundingRect):
283         (TestWebKitAPI::TEST):
284         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
285         * TestWebKitAPI/cocoa/TestWKWebView.h:
286         * TestWebKitAPI/cocoa/TestWKWebView.mm:
287         (-[TestWKWebView activatedElementAtPosition:]):
288
289 2017-07-22  Chris Dumez  <cdumez@apple.com>
290
291         REGRESSION(r204565): WKObject is broken
292         https://bugs.webkit.org/show_bug.cgi?id=174736
293         <rdar://problem/33246169>
294
295         Reviewed by Dan Bernstein.
296
297         Add API test that used to crash.
298
299         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
300         (TestWebKitAPI::TEST):
301
302 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
303
304         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
305         https://bugs.webkit.org/show_bug.cgi?id=174705
306
307         Reviewed by Mark Lam.
308
309         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
310         (TestWebKitAPI::testThreadGroup):
311         (TestWebKitAPI::TEST):
312
313 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
314
315         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
316         https://bugs.webkit.org/show_bug.cgi?id=174724
317
318         Reviewed by Aakash Jain.
319
320         * Scripts/webkitpy/port/ios_simulator.py:
321         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
322         simulator. Errors here should be treated the same as no simulators found.
323
324 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
325
326         [CMake] Add an option to stop build after generating project files
327         https://bugs.webkit.org/show_bug.cgi?id=174664
328
329         Reviewed by Konstantin Tokarev.
330
331         Add "--generate-project-only" to stop build after generating project files.
332
333         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
334         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
335         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
336         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
337         (isGenerateProjectOnly): ditto
338
339 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
340
341         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
342         https://bugs.webkit.org/show_bug.cgi?id=174501
343
344         Reviewed by Darin Adler.
345
346         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
347         (TestWebKitAPI::TEST):
348
349 2017-07-20  David Quesada  <david_quesada@apple.com>
350
351         Add SPI to notify WKNavigationDelegate about client redirects
352         https://bugs.webkit.org/show_bug.cgi?id=174680
353         rdar://problem/33184886
354
355         Reviewed by Brady Eidson.
356
357         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
358         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
359         (TEST):
360         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
361
362 2017-07-20  Brady Eidson  <beidson@apple.com>
363
364         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
365         https://bugs.webkit.org/show_bug.cgi?id=174685
366
367         Reviewed by Andy Estes.
368
369         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
370         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
371
372 2017-07-20  Brady Eidson  <beidson@apple.com>
373
374         Deprecate WebIconDatabase in WebKitLegacy/mac.
375         https://bugs.webkit.org/show_bug.cgi?id=174607
376
377         Reviewed by Alex Christensen.
378
379         * DumpRenderTree/mac/TestRunnerMac.mm:
380
381 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
382
383         lint-test-expectations should be run during style checking
384         https://bugs.webkit.org/show_bug.cgi?id=173559
385         <rdar://problem/32854941>
386
387         Reviewed by Aakash Jain.
388
389         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
390         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
391         prevents identifying errors on specific lines in a file.
392         * Scripts/webkitpy/style/main_unittest.py:
393         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
394         case where a linter error is in the file modified, but the line modified is not related to
395         the linter error.
396
397 2017-07-20  Brady Eidson  <beidson@apple.com>
398
399         Remove WebIconDatabase from WebKitLegacy/win.
400         https://bugs.webkit.org/show_bug.cgi?id=174608
401
402         Reviewed by Alex Christensen.
403
404         * DumpRenderTree/win/DumpRenderTree.cpp:
405         (main):
406         * DumpRenderTree/win/TestRunnerWin.cpp:
407         (TestRunner::setIconDatabaseEnabled):
408
409 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
410
411         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
412         https://bugs.webkit.org/show_bug.cgi?id=174671
413
414         Reviewed by Carlos Garcia Campos.
415
416         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
417         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
418         priority for this source in order to have it dispatched on the same
419         priority as the other WebKit-controlled GSource objects.
420
421 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
422
423         lint-test-expectations should be run during style checking
424         https://bugs.webkit.org/show_bug.cgi?id=173559
425         <rdar://problem/32854941>
426
427         Reviewed by Daniel Bates.
428
429         Follow up fix addressing style and a few minor bugs.
430
431         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
432         (TestExpectationParser.__init__): Use lambda x: x instead of str
433         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
434         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
435         reduce the calls of _shorten_filename, fix minor bug in appending the current
436         expectation's line number instead of the previous ones, clarify treatment of None
437         in file-to-line-number mapping.
438         (TestExpectations._report_warnings): Collapse call.
439         * Scripts/webkitpy/style/checkers/test_expectations.py:
440         (TestExpectationsChecker.lint_test_expectations):
441         * Scripts/webkitpy/style/filereader.py: Re-write comment.
442         (TextFileReader.process_file): Add comment explaining treatment of None in
443         file-to-line-number mapping.
444         (TextFileReader.delete_file): Collapse call.
445
446 2017-07-19  Chris Dumez  <cdumez@apple.com>
447
448         Unreviewed attempt to fix API test failure after r219663.
449
450         The test was hard-coding an exception string and the string has changed slightly
451         in r219663.
452
453         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
454         (TEST):
455
456 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
457
458         Don't write file URLs to iOS Pasteboard
459         https://bugs.webkit.org/show_bug.cgi?id=174647
460         <rdar://problem/33199730>
461
462         Reviewed by Wenson Hsieh.
463
464         Updating tests to reflect the lack of file URLs for images.
465
466         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
467         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
468         (checkEstimatedSize):
469         (TestWebKitAPI::TEST):
470
471 2017-07-19  Brady Eidson  <beidson@apple.com>
472
473         iBooks sometimes crashes when closing a book.
474         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
475
476         Reviewed by Oliver Hunt.
477
478         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
479         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
480         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
481         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
482         (TestWebKitAPI::TEST):
483
484         Add a "spin the runloop X number of times" utility:
485         * TestWebKitAPI/Utilities.h:
486         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
487         (TestWebKitAPI::Util::spinRunLoop):
488
489 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
490
491         lint-test-expectations should be run during style checking
492         https://bugs.webkit.org/show_bug.cgi?id=173559
493         <rdar://problem/32854941>
494
495         Reviewed by David Kilzer.
496
497         Running the test expectation linter requires reading both files and lines not in the
498         patch because, for example, deletion of a test can cause a lint failure even though
499         no test expectations where modified. This means that the linter will occasionally warn
500         about lines which were not changed in a given patch but whose error is related to a
501         change made in that patch.
502
503         * Scripts/webkitpy/common/system/filesystem_mock.py:
504         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
505         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
506         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
507         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
508         content, description of the error and the name of the associated test.
509         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
510         (TestExpectationParser.__init__): Pass shorten_filename function to
511         TestExpectationsParser to add a deleted file to the related_files dictionary.
512         (TestExpectationParser._check_test_exists): If the test does not exist, add the
513         missing path to the related_files dictionary.
514         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
515         files and line numbers related to this test expectation line. This will allow
516         tracking linter errors in the style checker occurring across multiple files.
517         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
518         lines to related_files dictionary.
519         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
520         (TestExpectations._report_warnings): Construct warning object instead of string
521         when adding to warnings list.
522         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
523         clean-up log.
524         * Scripts/webkitpy/style/checker.py:
525         (ProcessorBase.do_association_check): Add required function for processor classes.
526         (StyleProcessor):
527         (StyleProcessor.do_association_check): Run the TestExpectations linter when
528         checking for errors between associated files.
529         * Scripts/webkitpy/style/checkers/test_expectations.py:
530         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
531         (TestExpectationsChecker):
532         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
533         of modified files, the current working directory and the host, determine if the linter
534         warning is associated with the changes.
535         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
536         style checker.
537         * Scripts/webkitpy/style/filereader.py:
538         (TextFileReader):
539         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
540         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
541         (TextFileReader.process_file): Track both the number of files changed and which lines
542         in those files were changed.
543         (TextFileReader.do_association_check): Run the processor's association check on all
544         modified or deleted files processed by TextFileReader.
545         (TextFileReader.delete_file): Track deleted files in _files dictionary.
546         (TextFileReader.count_delete_only_file): Deleted.
547         * Scripts/webkitpy/style/filereader_unittest.py:
548         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
549         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
550         * Scripts/webkitpy/style/main.py:
551         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
552         explicitly run the association check on the file reader.
553         * Scripts/webkitpy/style/main_unittest.py:
554         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
555         embedded in the style checker.
556         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
557         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
558         construct the TextFileReader object with a StyleProcessor used to run style checks on
559         specific files.
560         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
561         testing the test expectation linter inside the style checker. This host must contain a
562         mock file system with the basic structure of test expectations.
563         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
564         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
565         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
566         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
567         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
568         * Scripts/webkitpy/style/patchreader.py:
569         (PatchReader.check): Specify which file was deleted, run the association check.
570         * Scripts/webkitpy/style/patchreader_unittest.py:
571         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
572         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
573         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
574
575 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
576
577         [WTF] Implement WTF::ThreadGroup
578         https://bugs.webkit.org/show_bug.cgi?id=174081
579
580         Reviewed by Mark Lam.
581
582         Add WTF::ThreadGroup tests.
583
584         * TestWebKitAPI/CMakeLists.txt:
585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
586         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
587         (TestWebKitAPI::testThreadGroup):
588         (TestWebKitAPI::TEST):
589
590 2017-07-18  Andy Estes  <aestes@apple.com>
591
592         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
593         https://bugs.webkit.org/show_bug.cgi?id=174631
594
595         Reviewed by Tim Horton.
596
597         * DumpRenderTree/mac/Configurations/Base.xcconfig:
598         * MiniBrowser/Configurations/Base.xcconfig:
599         * MobileMiniBrowser/Configurations/Base.xcconfig:
600         * TestWebKitAPI/Configurations/Base.xcconfig:
601         * WebKitTestRunner/Configurations/Base.xcconfig:
602
603 2017-07-18  Andy Estes  <aestes@apple.com>
604
605         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
606         https://bugs.webkit.org/show_bug.cgi?id=174631
607
608         Reviewed by Sam Weinig.
609
610         * DumpRenderTree/mac/Configurations/Base.xcconfig:
611         * MiniBrowser/Configurations/Base.xcconfig:
612         * MobileMiniBrowser/Configurations/Base.xcconfig:
613         * TestWebKitAPI/Configurations/Base.xcconfig:
614         * WebKitTestRunner/Configurations/Base.xcconfig:
615
616 2017-07-18  Daniel Bates  <dabates@apple.com>
617
618         lldb: Add type summary for StringView
619         https://bugs.webkit.org/show_bug.cgi?id=174637
620
621         Reviewed by Sam Weinig.
622
623         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
624         StringView object will print output that has the form:
625
626             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
627               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
628               m_length = 2
629               m_is8Bit = true
630               m_underlyingString = 0x0000614000000a90
631             }
632
633         * lldb/lldb_webkit.py:
634         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
635         (WTFStringView_SummaryProvider):
636         (WTFStringViewProvider):
637         (WTFStringViewProvider.__init__):
638         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
639         (WTFStringViewProvider.get_length): Access field StringView.m_length.
640         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
641         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
642
643 2017-07-18  Andy Estes  <aestes@apple.com>
644
645         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
646         https://bugs.webkit.org/show_bug.cgi?id=174631
647
648         Reviewed by Dan Bernstein.
649
650         * DumpRenderTree/mac/Configurations/Base.xcconfig:
651         * MiniBrowser/Configurations/Base.xcconfig:
652         * MobileMiniBrowser/Configurations/Base.xcconfig:
653         * TestWebKitAPI/Configurations/Base.xcconfig:
654         * WebKitTestRunner/Configurations/Base.xcconfig:
655
656 2017-07-18  Devin Rousso  <drousso@apple.com>
657
658         Web Inspector: Add memoryCost to Inspector Protocol objects
659         https://bugs.webkit.org/show_bug.cgi?id=174478
660
661         Reviewed by Joseph Pecoraro.
662
663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
664         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
665         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
666         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
667         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
668         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
669         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
670         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
671         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
672         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
673         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
674         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
675         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
676         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
677         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
678         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
679         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
680
681 2017-07-18  Andy Estes  <aestes@apple.com>
682
683         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
684         https://bugs.webkit.org/show_bug.cgi?id=174631
685
686         Reviewed by Darin Adler.
687
688         * DumpRenderTree/mac/Configurations/Base.xcconfig:
689         * MiniBrowser/Configurations/Base.xcconfig:
690         * MobileMiniBrowser/Configurations/Base.xcconfig:
691         * TestWebKitAPI/Configurations/Base.xcconfig:
692         * WebKitTestRunner/Configurations/Base.xcconfig:
693
694 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
695
696         Unreviewed, fix the iOS build.
697
698         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
699
700         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
701         (TestWebKitAPI::TEST):
702
703 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
704
705         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
706         https://bugs.webkit.org/show_bug.cgi?id=174585
707         <rdar://problem/33302541>
708
709         Reviewed by Tim Horton.
710
711         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
712         being dragged when initiating a drag.
713
714         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
715         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
716         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
717         (TestWebKitAPI::TEST):
718         * TestWebKitAPI/cocoa/TestWKWebView.h:
719
720         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
721
722         * TestWebKitAPI/cocoa/TestWKWebView.mm:
723         (-[TestWKWebView synchronouslyLoadHTMLString:]):
724
725 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
726
727         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
728         https://bugs.webkit.org/show_bug.cgi?id=174547
729
730         Reviewed by Alex Christensen.
731
732         * DumpRenderTree/PlatformWin.cmake:
733         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
734
735 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
736
737         Update style checker to deal with "final"
738         https://bugs.webkit.org/show_bug.cgi?id=174528
739
740         Reviewed by Alex Christensen.
741         
742         check-webkit-style shouldn't complain about an open brace to start a
743         line after a function definition with "final" or "const final".
744
745         * Scripts/webkitpy/style/checkers/cpp.py:
746         (check_braces):
747         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
748         (CppStyleTest.test_brace_at_begin_of_line):
749
750 2017-07-17  Alex Christensen  <achristensen@webkit.org>
751
752         Modernize content extension code
753         https://bugs.webkit.org/show_bug.cgi?id=174588
754
755         Reviewed by Sam Weinig.
756
757         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
758         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
759         (TestWebKitAPI::testRequest):
760         (TestWebKitAPI::makeBackend):
761         (TestWebKitAPI::TEST_F):
762
763 2017-07-17  Brady Eidson  <beidson@apple.com>
764
765         WKHTTPCookieStore observing only works on the default cookie store.
766         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
767
768         Reviewed by Sam Weinig.
769
770         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
771         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
772           called for the default store, a non-persistent store, and a custom store.
773         (TEST):
774
775 2017-07-16  Sam Weinig  <sam@webkit.org>
776
777         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
778         https://bugs.webkit.org/show_bug.cgi?id=174575
779
780         Reviewed by Brady Eidson.
781
782         * Scripts/svn-create-patch:
783         (findModificationType):
784         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
785         default value of "unknown".
786
787         (generateFileList):
788         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
789         for untracked, which matches our old behavior.
790
791 2017-07-17  Charlie Turner  <cturner@igalia.com>
792
793         Add some missing build dependencies on Fedora
794         https://bugs.webkit.org/show_bug.cgi?id=174578
795
796         Unreviewed dependency update.
797
798         * gtk/install-dependencies:
799
800 2017-07-16  Brady Eidson  <beidson@apple.com>
801
802         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
803         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
804
805         Reviewed by Tim Horton.
806
807         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
808         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
809         (TEST):
810
811 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
812
813         [GTK] Sort inspector GResource manifest to ensure reproducible builds
814         https://bugs.webkit.org/show_bug.cgi?id=174540
815
816         Reviewed by Michael Catanzaro.
817
818         * gtk/generate-inspector-gresource-manifest.py:
819         (get_filenames): sort list of input files
820
821 2017-07-15  Brady Eidson  <beidson@apple.com>
822
823         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
824         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
825
826         Reviewed by Tim Horton.
827
828         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
829         (TEST): Make this test more reliable by clearing everything beforehand.
830
831 2017-07-15  David Kilzer  <ddkilzer@apple.com>
832
833         Make it possible to extend check-webkit-style with Apple-internal checkers
834         <https://webkit.org/b/174464>
835         <rdar://problem/25564402>
836
837         Reviewed by Darin Adler.
838
839         * Scripts/webkitpy/style/checker.py: Import apple_additions.
840         (_all_categories): Add categories from apple_additions() if it
841         exists.
842         (CheckerDispatcher._create_checker): Create python checker
843         from apple_additions() if it exists.
844
845 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
846
847         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
848         https://bugs.webkit.org/show_bug.cgi?id=174539
849         <rdar://problem/33307395>
850
851         Reviewed by Darin Adler.
852
853         Adds a new unit test suite to cover action sheet popover presentation.
854
855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
856         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
857         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
858         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
859
860         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
861
862         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
863         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
864
865         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
866
867         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
868         (TestWebKitAPI::TEST):
869
870 2017-07-15  Sam Weinig  <sam@webkit.org>
871
872         [Scripts] Make svn-create-patch work better when called in sub directories
873         https://bugs.webkit.org/show_bug.cgi?id=174551
874
875         Reviewed by Darin Adler.
876
877         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
878           by ensuring that the prefix is applied as is done in generateDiff.
879         - Silence output of explanatory lines from svn stat (" > move to ...")
880           that show up in STDERR when running svn-create-patch.
881         - Add verbose logging that I found useful while debugging this issue.
882
883         * Scripts/svn-create-patch:
884         (findBaseUrl):
885         (findMimeType):
886         (findSourceFileAndRevision):
887         (generateDiff):
888         (generateFileList):
889         (manufacturePatchForAdditionWithHistory):
890
891 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
892
893         Unreviewed build fix after r219537.
894
895         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
896
897 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
898
899         Add iOS 11 SPI
900         https://bugs.webkit.org/show_bug.cgi?id=174430
901         <rdar://problem/33269288>
902
903         Reviewed by Tim Horton.
904
905         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
906         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
907         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
908
909 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
910
911         Failing to install on iPad simulators
912         https://bugs.webkit.org/show_bug.cgi?id=174532
913         <rdar://problem/33328347>
914
915         Reviewed by Stephanie Lewis.
916
917         * Scripts/webkitpy/xcode/simulated_device.py:
918         (SimulatedDevice.install_app): Place install command in retry try-except block.
919
920 2017-07-14  Jeff Miller  <jeffm@apple.com>
921
922         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
923         https://bugs.webkit.org/show_bug.cgi?id=174524
924
925         Reviewed by Sam Weinig.
926
927         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
928         (TEST):
929         Renamed TestParameter to TestParameter1.
930         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
931
932         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
933         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
934         Observe changes for two bundle parameters.
935
936         (-[BundleParametersPlugIn dealloc]):
937         Remove observers for two bundle parameters.
938
939 2017-07-14  Commit Queue  <commit-queue@webkit.org>
940
941         Unreviewed, rolling out r219510.
942         https://bugs.webkit.org/show_bug.cgi?id=174525
943
944         Need to revert length() == 0 check for null string (Requested
945         by yusukesuzuki on #webkit).
946
947         Reverted changeset:
948
949         "[WTF] Newly added AtomicStringImpl should use BufferInternal
950         static string if StringImpl is static"
951         https://bugs.webkit.org/show_bug.cgi?id=174501
952         http://trac.webkit.org/changeset/219510
953
954 2017-07-14  Jer Noble  <jer.noble@apple.com>
955
956         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
957         https://bugs.webkit.org/show_bug.cgi?id=174514
958
959         Reviewed by Sam Weinig.
960
961         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
962         (TestWebKitAPI::TEST_F):
963
964 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
965
966         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
967         https://bugs.webkit.org/show_bug.cgi?id=174501
968
969         Reviewed by Darin Adler.
970
971         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
972         (TestWebKitAPI::TEST):
973
974 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
975
976         Bring mac expectations in-line with other platforms
977         https://bugs.webkit.org/show_bug.cgi?id=174472
978         <rdar://problem/33297388>
979
980         Reviewed by David Kilzer.
981
982         The override order for Mac test expectations does not conform to the pattern used by iOS,
983         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
984
985             platform/mac-wk2
986             platform/wk2
987             platform/mac-elcapitan
988             platform/mac-sierra
989             generic
990
991         After this change, El Capitan's baseline search path looks like this:
992
993             platform/mac-sierra-wk2
994             platform/mac-sierra
995             platform/mac-wk2
996             platform/wk2
997             generic
998
999         * Scripts/webkitpy/port/mac.py:
1000         (MacPort.__init__): If a specific version is specified in the port name, use that
1001         as the os version.
1002         (MacPort.default_baseline_search_path): Expectation search paths should work the
1003         same way they do on other ports. Port + version overrides port, port overrides generic
1004         and wk1/wk2 should override expectations for the two combined.
1005         * Scripts/webkitpy/port/mac_unittest.py:
1006         (MacTest.test_tests_for_other_platforms): Deleted.
1007         (MacTest._assert_search_path): Deleted.
1008         (MacTest.test_baseline_search_path): Deleted.
1009         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1010         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1011         (test_rebaseline_test_and_print_scm_changes): Ditto.
1012         (test_rebaseline_and_copy_test): Ditto.
1013         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1014         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1015         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1016
1017 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1018
1019         Fix style checker unit test
1020
1021         Unreviewed WebKit2 => WebKit fixup.
1022
1023         * Scripts/webkitpy/style/checker_unittest.py:
1024         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1025
1026 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1027
1028         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1029
1030         Unreviewed build fix.
1031
1032         r219492 missed one hunk from its partial revert of r219489.
1033         This patch reverts that hunk.
1034
1035         * TestWebKitAPI/CMakeLists.txt:
1036
1037 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1038
1039         Use the old WebKit/WebKit2 targets for CMake builds.
1040
1041         Unreviewed build fix.
1042
1043         We can update the target names to match the Framework names in a future patch.
1044         This is a partial revert of r219489.
1045
1046         * TestWebKitAPI/CMakeLists.txt:
1047         WebKitLegacy => WebKit
1048         WebKit => WebKit2
1049
1050 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1051
1052         Fix TestWebKit API.
1053         https://bugs.webkit.org/show_bug.cgi?id=174164
1054         rdar://problem/33137595
1055
1056         Reviewed by Dan Bernstein.
1057
1058         * TestWebKitAPI/CMakeLists.txt:
1059         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1060         * TestWebKitAPI/PlatformGTK.cmake:
1061
1062 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1063
1064         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1065         https://bugs.webkit.org/show_bug.cgi?id=174164
1066         rdar://problem/33137595
1067
1068         Reviewed by Dan Bernstein.
1069
1070         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1071         (ShouldBuildTest):
1072         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1073         * Scripts/build-webkit:
1074         * Scripts/do-file-rename:
1075         * Scripts/do-webcore-rename:
1076         * Scripts/update-webkit-localizable-strings:
1077         * Scripts/webkitpy/common/config/watchlist:
1078         * Scripts/webkitpy/style/checker.py:
1079         * Scripts/webkitpy/style/checkers/featuredefines.py:
1080         * gtk/make-dist.py:
1081         (ensure_version_if_possible):
1082         * gtk/manifest.txt.in:
1083
1084 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1085
1086         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1087         https://bugs.webkit.org/show_bug.cgi?id=174162
1088         rdar://problem/33137594
1089
1090         Reviewed by Dan Bernstein.
1091
1092         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
1093
1094         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1095         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1096         * EWSTools/configure-clang-linux.sh:
1097         * Scripts/build-webkit:
1098         * Scripts/do-file-rename:
1099         * Scripts/do-webcore-rename:
1100         * Scripts/update-webkit-localizable-strings:
1101         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1102         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1103         * Scripts/webkitpy/style/checkers/featuredefines.py:
1104         * gtk/manifest.txt.in:
1105
1106 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
1107
1108         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
1109         https://bugs.webkit.org/show_bug.cgi?id=174438
1110         <rdar://problem/33277112>
1111
1112         Reviewed by Aakash Jain.
1113
1114         Given a patch, this will convert the changes from the path to the new directory structure.
1115
1116         * Scripts/rebase-patch-after-webkit-move: Added.
1117         (append_source): Append 'Source' to the provided path.
1118         (is_editable_line): Return true if a line the script expects to modify.
1119         (needs_rebase): Return if a line needs to be rebased based on it's content.
1120         (rebase_line): Rebase the provided line.
1121         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
1122         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
1123         were provided.
1124
1125 2017-07-12  Nan Wang  <n_wang@apple.com>
1126
1127         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1128         https://bugs.webkit.org/show_bug.cgi?id=174393
1129         <rdar://problem/33248006>
1130
1131         Reviewed by Chris Fleizach.
1132
1133         * DumpRenderTree/AccessibilityUIElement.cpp:
1134         (textMarkerRangeMatchesTextNearMarkersCallback):
1135         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1136         (AccessibilityUIElement::getJSClass):
1137         * DumpRenderTree/AccessibilityUIElement.h:
1138         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1139         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1140         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1141         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1142         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1143         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1144         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1145         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1146
1147 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1148
1149         Unreviewed, rolling out r219409.
1150
1151         The revision caused the Windows builds to fail.
1152
1153         Reverted changeset:
1154
1155         "AX: [iOS] Implement a way to retrieve a text marker range
1156         with desired text that is closest to a position"
1157         https://bugs.webkit.org/show_bug.cgi?id=174393
1158         http://trac.webkit.org/changeset/219409
1159
1160 2017-07-12  Nan Wang  <n_wang@apple.com>
1161
1162         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1163         https://bugs.webkit.org/show_bug.cgi?id=174393
1164         <rdar://problem/33248006>
1165
1166         Reviewed by Chris Fleizach.
1167
1168         * DumpRenderTree/AccessibilityUIElement.cpp:
1169         (textMarkerRangeMatchesTextNearMarkersCallback):
1170         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1171         (AccessibilityUIElement::getJSClass):
1172         * DumpRenderTree/AccessibilityUIElement.h:
1173         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1174         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1175         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1176         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1177         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1178         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1179         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1180         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1181
1182 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
1183
1184         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
1185         https://bugs.webkit.org/show_bug.cgi?id=174197
1186
1187         Reviewed by Darin Adler.
1188
1189         This bit me the first time I tried to submit a patch to WebKit, and still I have
1190         to manually edit the ChangeLog every time I use the script.
1191
1192         This generates a more convenient and standard ChangeLog entry.
1193
1194         * Scripts/prepare-ChangeLog:
1195         (generateNewChangeLogs):
1196
1197 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1198
1199         Unreviewed, rolling out r219401.
1200
1201         This revision rolled out the previous patch, but after talking
1202         with reviewer, a rebaseline is what was needed.Rolling back in
1203         before rebaseline.
1204
1205         Reverted changeset:
1206
1207         "Unreviewed, rolling out r219379."
1208         https://bugs.webkit.org/show_bug.cgi?id=174400
1209         http://trac.webkit.org/changeset/219401
1210
1211 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1212
1213         Unreviewed, rolling out r219379.
1214
1215         This revision caused a consistent failure in the test
1216         fast/dom/Window/property-access-on-cached-window-after-frame-
1217         removed.html.
1218
1219         Reverted changeset:
1220
1221         "Remove NAVIGATOR_HWCONCURRENCY"
1222         https://bugs.webkit.org/show_bug.cgi?id=174400
1223         http://trac.webkit.org/changeset/219379
1224
1225 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1226
1227         [WPE] Use libepoxy
1228         https://bugs.webkit.org/show_bug.cgi?id=172104
1229
1230         Reviewed by Michael Catanzaro.
1231
1232         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
1233         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
1234
1235 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1236
1237         [GTK][WPE] Align Jhbuild patches for GStreamer packages
1238         https://bugs.webkit.org/show_bug.cgi?id=174363
1239
1240         Reviewed by Michael Catanzaro.
1241
1242         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
1243         between the GTK+ and WPE port. There's no reason for the two ports to apply
1244         different patches over same versions of GStreamer releases.
1245
1246         This aligns the two ports on this specific issue. Next we'll look into
1247         creating a single GStreamer-specific Jhbuild moduleset that will allow us
1248         to keep these patches in a single place, avoiding duplicate files.
1249
1250         * gtk/jhbuild.modules:
1251         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1252         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
1253         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1254         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
1255
1256 2017-07-11  Dean Jackson  <dino@apple.com>
1257
1258         Remove NAVIGATOR_HWCONCURRENCY
1259         https://bugs.webkit.org/show_bug.cgi?id=174400
1260
1261         Reviewed by Sam Weinig.
1262
1263         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1264
1265 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
1266
1267         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
1268         https://bugs.webkit.org/show_bug.cgi?id=174239
1269
1270         Reviewed by Brady Eidson.
1271
1272         Create windows with specific features set and make sure those are properly reflected in the
1273         WKWindowFeatures object.
1274
1275         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1276         (resetToConsistentState):
1277         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1278         (TEST):
1279
1280 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
1281
1282         Do not duplicate files when deleting directories with svn 1.9
1283         https://bugs.webkit.org/show_bug.cgi?id=174339
1284         <rdar://problem/33226781>
1285
1286         Reviewed by David Kilzer.
1287
1288         * Scripts/svn-create-patch:
1289         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
1290         (generateFileList): Determine which files are deleted because they are part of a
1291         directory being deleted.
1292
1293 2017-07-11  Dean Jackson  <dino@apple.com>
1294
1295         Rolling out r219372.
1296
1297         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1298
1299 2017-07-11  Dean Jackson  <dino@apple.com>
1300
1301         Remove NAVIGATOR_HWCONCURRENCY
1302         https://bugs.webkit.org/show_bug.cgi?id=174400
1303
1304         Reviewed by Sam Weinig.
1305
1306         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1307
1308 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1309
1310         Teach build workers to fetch archives from S3.
1311         https://bugs.webkit.org/show_bug.cgi?id=174384
1312
1313         Reviewed by Aakash Jain.
1314
1315         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1316         (DownloadBuiltProduct):
1317
1318 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1319
1320         Configure buildbot to transfer all archives to S3.
1321         Previously this was Mac only, but it's time to expand!
1322         https://bugs.webkit.org/show_bug.cgi?id=174378
1323         
1324         Reviewed by Aakash Jain.
1325
1326         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1327         (BuildFactory.__init__):
1328
1329 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
1330
1331         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
1332         https://bugs.webkit.org/show_bug.cgi?id=174350
1333
1334         Reviewed by Xabier Rodriguez-Calvar.
1335
1336         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
1337         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
1338         patches are removed. The patches for gst-plugins-good are updated, removing
1339         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
1340         rtpbin elements that will help with the EMEv3 development.
1341
1342         * wpe/jhbuild.modules:
1343         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1344         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1345         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1346         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1347         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1348         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1349         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1350         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1351         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1352
1353 2017-07-10  John Wilander  <wilander@apple.com>
1354
1355         Resource Load Statistics: Prune statistics in orders of importance
1356         https://bugs.webkit.org/show_bug.cgi?id=174215
1357         <rdar://problem/33164403>
1358
1359         Reviewed by Chris Dumez.
1360
1361         Nest infrastructure. Adds these functions:
1362         1. testRunner.setStatisticsLastSeen()
1363         2. setStatisticsMaxStatisticsEntries()
1364         3. setStatisticsPruneEntriesDownTo()
1365
1366         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1367         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1368         (WTR::TestRunner::setStatisticsLastSeen):
1369         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1370         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1371         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1372         * WebKitTestRunner/TestController.cpp:
1373         (WTR::TestController::setStatisticsLastSeen):
1374         (WTR::TestController::setMaxStatisticsEntries):
1375         (WTR::TestController::setPruneEntriesDownTo):
1376         * WebKitTestRunner/TestController.h:
1377         * WebKitTestRunner/TestInvocation.cpp:
1378         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1379         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1380         (WTR::TestController::setStatisticsLastSeen):
1381         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1382         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1383
1384 2017-07-03  Brian Burg  <bburg@apple.com>
1385
1386         Web Replay: remove some unused code
1387         https://bugs.webkit.org/show_bug.cgi?id=173903
1388
1389         Rubber-stamped by Joseph Pecoraro.
1390
1391         * Scripts/run-input-generator-tests: Removed.
1392         * Scripts/webkitpy/replay/__init__.py: Removed.
1393         * Scripts/webkitpy/replay/main.py: Removed.
1394
1395 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1396
1397         [WPE] Fix layout test baseline and TestExpectations hierarchy
1398         https://bugs.webkit.org/show_bug.cgi?id=174092
1399
1400         Reviewed by Michael Catanzaro.
1401
1402         Like for the GTK+ port, override the default_baseline_search_path() and
1403         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1404         Both methods operate on a short list of search paths that defaults to 'wpe' and
1405         'wk2', along with any other user-specified platform directory.
1406
1407         The test_expectations_file_position() method is overridden for testing purposes,
1408         and relevant unit tests are added.
1409
1410         * Scripts/webkitpy/port/wpe.py:
1411         (WPEPort._search_paths):
1412         (WPEPort):
1413         (WPEPort.default_baseline_search_path):
1414         (WPEPort._port_specific_expectations_files):
1415         (WPEPort.test_expectations_file_position):
1416         * Scripts/webkitpy/port/wpe_unittest.py:
1417         (WPEPortTest.test_default_baseline_search_path):
1418         (WPEPortTest):
1419         (WPEPortTest.test_port_specific_expectations_files):
1420
1421 2017-07-10  Chris Dumez  <cdumez@apple.com>
1422
1423         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
1424         https://bugs.webkit.org/show_bug.cgi?id=174301
1425
1426         Reviewed by Brent Fulgham.
1427
1428         Rename some of the testRunner API for clarity and to better match what it calls
1429         internally.
1430
1431         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1432         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1433         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1434         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1435         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1436         * WebKitTestRunner/TestController.cpp:
1437         (WTR::TestController::statisticsUpdateCookiePartitioning):
1438         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1439         * WebKitTestRunner/TestController.h:
1440         * WebKitTestRunner/TestInvocation.cpp:
1441         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1442         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1443         (WTR::TestController::statisticsUpdateCookiePartitioning):
1444         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1445
1446 2017-07-10  Charlie Turner  <cturner@igalia.com>
1447
1448         [GStreamer] Live twitch.tv videos do not play
1449         https://bugs.webkit.org/show_bug.cgi?id=174222
1450
1451         Reviewed by Michael Catanzaro.
1452
1453         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1454         fixes videos not playing on twitch.tv.
1455
1456         * gtk/jhbuild.modules:
1457
1458 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1459
1460         Add WebGL2 configuration option to build-webkit
1461         https://bugs.webkit.org/show_bug.cgi?id=174251
1462
1463         Reviewed by Michael Catanzaro.
1464
1465         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1466         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1467         is marked as enabled for the Apple Cocoa ports.
1468
1469 2017-07-08  Chris Dumez  <cdumez@apple.com>
1470
1471         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1472         https://bugs.webkit.org/show_bug.cgi?id=174290
1473
1474         Reviewed by Brent Fulgham.
1475
1476         Rename testRunner API to match the new internal API names.
1477
1478         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1479         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1480         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1481         (WTR::TestRunner::statisticsSubmitTelemetry):
1482         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1483         * WebKitTestRunner/TestController.cpp:
1484         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1485         (WTR::TestController::statisticsSubmitTelemetry):
1486         * WebKitTestRunner/TestController.h:
1487         * WebKitTestRunner/TestInvocation.cpp:
1488         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1489         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1490         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1491         (WTR::TestController::statisticsSubmitTelemetry):
1492
1493 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1494
1495         Drop NOSNIFF compile flag
1496         https://bugs.webkit.org/show_bug.cgi?id=174289
1497
1498         Reviewed by Michael Catanzaro.
1499
1500         * Scripts/webkitperl/FeatureList.pm:
1501         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1502
1503 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1504
1505         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
1506         https://bugs.webkit.org/show_bug.cgi?id=174219
1507         <rdar://problem/32083177>
1508
1509         Reviewed by Ryosuke Niwa.
1510
1511         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
1512         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
1513         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
1514         place.
1515
1516         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
1517         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
1518         no action is taken when dropping.
1519
1520         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
1521         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1522         (TestWebKitAPI::TEST):
1523         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1524         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1525         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1526         (-[MockDragDropSession allowsMoveOperation]):
1527         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
1528         (-[MockDataInteractionSession initWithWindow:allowMove:]):
1529         (-[DataInteractionSimulator initWithWebView:]):
1530         (-[DataInteractionSimulator runFrom:to:]):
1531         (-[DataInteractionSimulator _advanceProgress]):
1532         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
1533         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
1534         (-[MockDataInteractionSession initWithWindow:]): Deleted.
1535
1536 2017-07-07  Commit Queue  <commit-queue@webkit.org>
1537
1538         Unreviewed, rolling out r219238, r219239, and r219241.
1539         https://bugs.webkit.org/show_bug.cgi?id=174265
1540
1541         "fast/workers/dedicated-worker-lifecycle.html is flaky"
1542         (Requested by yusukesuzuki on #webkit).
1543
1544         Reverted changesets:
1545
1546         "[WTF] Implement WTF::ThreadGroup"
1547         https://bugs.webkit.org/show_bug.cgi?id=174081
1548         http://trac.webkit.org/changeset/219238
1549
1550         "Unreviewed, build fix after r219238"
1551         https://bugs.webkit.org/show_bug.cgi?id=174081
1552         http://trac.webkit.org/changeset/219239
1553
1554         "Unreviewed, CLoop build fix after r219238"
1555         https://bugs.webkit.org/show_bug.cgi?id=174081
1556         http://trac.webkit.org/changeset/219241
1557
1558 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1559
1560         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1561         https://bugs.webkit.org/show_bug.cgi?id=174250
1562
1563         Reviewed by Carlos Alberto Lopez Perez.
1564
1565         * Scripts/webkitperl/FeatureList.pm:
1566
1567 2017-07-07  Charlie Turner  <cturner@igalia.com>
1568         [GStreamer] vid.me videos do not play
1569         https://bugs.webkit.org/show_bug.cgi?id=172240
1570
1571         Reviewed by Xabier Rodriguez-Calvar.
1572
1573         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1574         have the existing libsoup build against GNOME to avoid header drift
1575         against GStreamer's linked Soup library.
1576
1577         * gtk/jhbuild.modules:
1578
1579 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1580
1581         Write a support script to enable buildbot to upload to S3
1582         https://bugs.webkit.org/show_bug.cgi?id=174196
1583         
1584         Reviewed by Stephanie Lewis.
1585
1586         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
1587         (uploadToS3):
1588         (archiveExists):
1589
1590 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1591
1592         Enabling uploading archives to S3.
1593         https://bugs.webkit.org/show_bug.cgi?id=174198
1594         
1595         Reviewed by Stephanie Lewis.
1596
1597         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1598         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1599         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1600         (TransferToS3): Transfer full and minified archives to S3
1601
1602 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1603
1604         [WTF] Implement WTF::ThreadGroup
1605         https://bugs.webkit.org/show_bug.cgi?id=174081
1606
1607         Reviewed by Mark Lam.
1608
1609         Add WTF::ThreadGroup tests.
1610
1611         * TestWebKitAPI/CMakeLists.txt:
1612         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1613         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1614         (TestWebKitAPI::TEST):
1615
1616 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1617
1618         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1619         https://bugs.webkit.org/show_bug.cgi?id=174150
1620
1621         Reviewed by Mark Lam.
1622
1623         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1624         (TestWebKitAPI::TEST):
1625         * TestWebKitAPI/TestsController.cpp:
1626         (TestWebKitAPI::TestsController::TestsController):
1627
1628 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1629
1630         Enabling uploading archives to S3.
1631         https://bugs.webkit.org/show_bug.cgi?id=174198
1632         
1633         Reviewed by Lucas Forschler.
1634
1635         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1636         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1637         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1638         (TransferToS3): Transfer full and minified archives to S3
1639
1640 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1641
1642         [GTK][WPE] kill-old-process should kill more webkit related process
1643         https://bugs.webkit.org/show_bug.cgi?id=174220
1644
1645         Reviewed by Michael Catanzaro.
1646
1647         Generate list of possible webkit-related process names and add
1648         them to the list of process to kill.
1649         Also update the possible system related process for GTK+/WPE.
1650
1651         * BuildSlaveSupport/kill-old-processes:
1652         (listAllWebKitPrograms):
1653         (main):
1654
1655 2017-07-06  Chris Dumez  <cdumez@apple.com>
1656
1657         FileMonitor should not be ref counted
1658         https://bugs.webkit.org/show_bug.cgi?id=174166
1659
1660         Reviewed by Brent Fulgham.
1661
1662         Update the API tests to reflect the API change.
1663
1664         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1665         (TestWebKitAPI::TEST_F):
1666
1667 2017-07-06  Commit Queue  <commit-queue@webkit.org>
1668
1669         Unreviewed, rolling out r219194.
1670         https://bugs.webkit.org/show_bug.cgi?id=174207
1671
1672         it broke some layout tests (Requested by clopez on #webkit).
1673
1674         Reverted changeset:
1675
1676         "[GStreamer] vid.me videos do not play"
1677         https://bugs.webkit.org/show_bug.cgi?id=172240
1678         http://trac.webkit.org/changeset/219194
1679
1680 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1681
1682         Unreviewed, rolling out r219178.
1683
1684         This caused a consistent failure with the API test
1685         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1686
1687         Reverted changeset:
1688
1689         "[WTF] Clean up StringStatics.cpp by using
1690         LazyNeverDestroyed<> for Atoms"
1691         https://bugs.webkit.org/show_bug.cgi?id=174150
1692         http://trac.webkit.org/changeset/219178
1693
1694 2017-07-06  Alicia Boya García  <aboya@igalia.com>
1695
1696         Add CWD to Perl library path (no longer the default since 5.26.0)
1697         https://bugs.webkit.org/show_bug.cgi?id=174200
1698
1699         Reviewed by Michael Catanzaro.
1700
1701         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1702         (SetupGitClone._get_username_and_email):
1703
1704 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1705
1706         Unreviewed, update my email address.
1707
1708         * Scripts/webkitpy/common/config/contributors.json:
1709
1710 2017-07-06  Charlie Turner  <cturner@igalia.com>
1711         [GStreamer] vid.me videos do not play
1712         https://bugs.webkit.org/show_bug.cgi?id=172240
1713
1714         Reviewed by Xabier Rodriguez-Calvar.
1715
1716         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1717         have the existing libsoup build against GNOME to avoid header drift
1718         against GStreamer's linked Soup library.
1719
1720         * gtk/jhbuild.modules:
1721
1722 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1723
1724         [WTF] Move SoftLinking.h into WTF
1725         https://bugs.webkit.org/show_bug.cgi?id=174000
1726
1727         Reviewed by Alex Christensen.
1728
1729         * DumpRenderTree/mac/TestRunnerMac.mm:
1730         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1731         (test_primary_header):
1732         (ErrorCollector.__init__): Deleted.
1733         (ErrorCollector.__call__): Deleted.
1734         (ErrorCollector.results): Deleted.
1735         (ErrorCollector.result_list): Deleted.
1736         (ErrorCollector.verify_all_categories_are_seen): Deleted.
1737         (MockIo.open): Deleted.
1738         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
1739         (CppFunctionsTest.test_create_acronym): Deleted.
1740         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
1741         (CppFunctionsTest.test_parameter): Deleted.
1742         (CppFunctionsTest.test_single_line_view): Deleted.
1743         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
1744         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
1745         (CppFunctionsTest.test_parameter_list): Deleted.
1746         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
1747         (CppStyleTestBase.process_file_data): Deleted.
1748         (CppStyleTestBase.perform_lint): Deleted.
1749         (CppStyleTestBase.perform_single_line_lint): Deleted.
1750         (CppStyleTestBase.perform_multi_line_lint): Deleted.
1751         (CppStyleTestBase.perform_language_rules_check): Deleted.
1752         (CppStyleTestBase.perform_function_lengths_check): Deleted.
1753         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
1754         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
1755         (CppStyleTestBase.perform_include_what_you_use): Deleted.
1756         (CppStyleTestBase.perform_header_guard_check): Deleted.
1757         (CppStyleTestBase.assert_lint): Deleted.
1758         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
1759         (CppStyleTestBase.assert_multi_line_lint): Deleted.
1760         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
1761         (CppStyleTestBase.assert_language_rules_check): Deleted.
1762         (CppStyleTestBase.assert_include_what_you_use): Deleted.
1763         (CppStyleTestBase.assert_header_guard): Deleted.
1764         (CppStyleTestBase.assert_blank_lines_check): Deleted.
1765         (CppStyleTestBase.assert_positions_equal): Deleted.
1766         (FunctionDetectionTest.test_basic_function_detection): Deleted.
1767         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
1768         (FunctionDetectionTest.test_pure_function_detection): Deleted.
1769         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
1770         (FunctionDetectionTest.test_ignore_macros): Deleted.
1771         (FunctionDetectionTest.test_non_functions): Deleted.
1772         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
1773         (FunctionDetectionTest.test_parameter_list): Deleted.
1774         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1775         (CppStyleTest.test_asm_lines_ignored): Deleted.
1776         (CppStyleTest.test_get_line_width): Deleted.
1777         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1778         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1779         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1780         (CppStyleTest.test_position): Deleted.
1781         (CppStyleTest.test_rfind_in_lines): Deleted.
1782         (CppStyleTest.test_close_expression): Deleted.
1783         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1784         (CppStyleTest.test_cstyle_cast): Deleted.
1785         (CppStyleTest.test_runtime_casting): Deleted.
1786         (CppStyleTest.test_runtime_selfinit): Deleted.
1787         (CppStyleTest.test_runtime_rtti): Deleted.
1788         (CppStyleTest.test_static_cast_readability): Deleted.
1789         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1790         (CppStyleTest.void): Deleted.
1791         (CppStyleTest.test_deprecated_cast): Deleted.
1792         (CppStyleTest.test_mock_method): Deleted.
1793         (CppStyleTest.test_sizeof_type): Deleted.
1794         (CppStyleTest.cases): Deleted.
1795         (CppStyleTest.for): Deleted.
1796         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1797         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1798         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1799         (CppStyleTest.test_include_what_you_use): Deleted.
1800         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1801         (CppStyleTest.test_cleanse_line): Deleted.
1802         (CppStyleTest.test_multi_line_comments): Deleted.
1803         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1804         (CppStyleTest.test_multiline_strings): Deleted.
1805         (CppStyleTest.test_platformh_comments): Deleted.
1806         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1807         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1808         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1809         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1810         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1811         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1812         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1813         (CppStyleTest.test_check_posix_threading): Deleted.
1814         (CppStyleTest.test_insecure_string_operations): Deleted.
1815         (CppStyleTest.test_format_strings): Deleted.
1816         (CppStyleTest.test_insecure_temp_file): Deleted.
1817         (CppStyleTest.test_variable_length_array_detection): Deleted.
1818         (CppStyleTest.test_braces): Deleted.
1819         (CppStyleTest.test_check_check): Deleted.
1820         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1821         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1822         (CppStyleTest.test_spacing_for_fncall): Deleted.
1823         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1824         (CppStyleTest.test_spacing_before_braces): Deleted.
1825         (CppStyleTest.test_spacing_between_braces): Deleted.
1826         (CppStyleTest.test_spacing_before_brackets): Deleted.
1827         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1828         (CppStyleTest.test_objective_c_block): Deleted.
1829         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1830         (CppStyleTest.test_spacing_around_else): Deleted.
1831         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1832         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
1833         (CppStyleTest.test_operator_methods): Deleted.
1834         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
1835         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
1836         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
1837         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
1838         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
1839         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
1840         (CppStyleTest.test_space_after_comment_marker): Deleted.
1841         (CppStyleTest.test_newline_at_eof): Deleted.
1842         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
1843         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
1844         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
1845         (CppStyleTest.test_invalid_utf8): Deleted.
1846         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
1847         (CppStyleTest.test_is_blank_line): Deleted.
1848         (CppStyleTest.test_blank_lines_check): Deleted.
1849         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
1850         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
1851         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
1852         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
1853         (CppStyleTest.test_comma): Deleted.
1854         (CppStyleTest.test_declaration): Deleted.
1855         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
1856         (CppStyleTest.test_indent): Deleted.
1857         (CppStyleTest.test_indent.Foo): Deleted.
1858         (CppStyleTest.test_not_alabel): Deleted.
1859         (CppStyleTest.test_tab): Deleted.
1860         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
1861         (CppStyleTest.test_build_class): Deleted.
1862         (CppStyleTest.test_build_class.definitions): Deleted.
1863         (CppStyleTest.test_build_class.Foo): Deleted.
1864         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
1865         (CppStyleTest.test_build_end_comment): Deleted.
1866         (CppStyleTest.test_build_forward_decl): Deleted.
1867         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
1868         (CppStyleTest.test_build_header_guard): Deleted.
1869         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
1870         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
1871         (CppStyleTest.test_build_printf_format): Deleted.
1872         (CppStyleTest.test_runtime_printf_format): Deleted.
1873         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
1874         (CppStyleTest.test_build_storage_class): Deleted.
1875         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
1876         (CppStyleTest.test_build_storage_class.declaration): Deleted.
1877         (CppStyleTest.test_build_storage_class.after): Deleted.
1878         (CppStyleTest.test_build_storage_class.is): Deleted.
1879         (CppStyleTest.test_legal_copyright): Deleted.
1880         (CppStyleTest.test_invalid_increment): Deleted.
1881         (CppStyleTest.test_enum_bitfields): Deleted.
1882         (CppStyleTest.test_plain_integral_bitfields): Deleted.
1883         (CleansedLinesTest.test_init_empty): Deleted.
1884         (CleansedLinesTest.test_collapse_strings): Deleted.
1885         (OrderOfIncludesTest.tearDown): Deleted.
1886         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
1887         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
1888         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
1889         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
1890         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
1891         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
1892         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
1893         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
1894         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
1895         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
1896         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
1897         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
1898         (OrderOfIncludesTest.test_primary_header): Deleted.
1899         (OrderOfIncludesTest.test_public_primary_header): Deleted.
1900         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
1901         (OrderOfIncludesTest.test_classify_include): Deleted.
1902         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
1903         (CheckForFunctionLengthsTest.tearDown): Deleted.
1904         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
1905         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
1906         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
1907         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
1908         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
1909         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
1910         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
1911         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
1912         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
1913         (CheckForFunctionLengthsTest.function_body): Deleted.
1914         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
1915         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
1916         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
1917         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
1918         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
1919         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
1920         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
1921         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
1922         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
1923         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
1924         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
1925         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
1926         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
1927         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
1928         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
1929         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
1930         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
1931         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
1932         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
1933         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
1934         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
1935         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
1936         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
1937         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
1938         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
1939         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
1940         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
1941         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
1942         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
1943         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
1944         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
1945         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
1946         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
1947         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
1948         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
1949         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
1950         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
1951         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
1952         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
1953         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
1954         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
1955         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
1956         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
1957         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
1958         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
1959         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
1960         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
1961         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
1962         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
1963         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
1964         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
1965         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
1966         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
1967         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
1968         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
1969         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
1970         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
1971         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
1972         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
1973         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
1974         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
1975         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
1976         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
1977         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
1978         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
1979         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
1980         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
1981         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
1982         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
1983         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
1984         (LeakyPatternTest.test_get_dc): Deleted.
1985         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
1986         (LeakyPatternTest.test_own_get_dc): Deleted.
1987         (LeakyPatternTest.test_create_dc): Deleted.
1988         (LeakyPatternTest.test_create_compatible_dc): Deleted.
1989         (WebKitStyleTest.test_indentation): Deleted.
1990         (WebKitStyleTest.test_indentation.Foo): Deleted.
1991         (WebKitStyleTest.test_indentation.Document): Deleted.
1992         (WebKitStyleTest.test_spacing): Deleted.
1993         (WebKitStyleTest.test_line_breaking): Deleted.
1994         (WebKitStyleTest.test_braces): Deleted.
1995         (WebKitStyleTest.test_braces.MyClass): Deleted.
1996         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
1997         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
1998         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
1999         (WebKitStyleTest.test_null_false_zero): Deleted.
2000         (WebKitStyleTest.test_directive_indentation): Deleted.
2001         (WebKitStyleTest.test_using_std): Deleted.
2002         (WebKitStyleTest.test_using_namespace): Deleted.
2003         (WebKitStyleTest.test_max_macro): Deleted.
2004         (WebKitStyleTest.test_min_macro): Deleted.
2005         (WebKitStyleTest.test_wtf_move): Deleted.
2006         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2007         (WebKitStyleTest.test_names): Deleted.
2008         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2009         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2010         (WebKitStyleTest.test_names.declarations): Deleted.
2011         (WebKitStyleTest.test_names.struct): Deleted.
2012         (WebKitStyleTest.test_names.VectorType): Deleted.
2013         (WebKitStyleTest.test_parameter_names): Deleted.
2014         (WebKitStyleTest.test_comments): Deleted.
2015         (WebKitStyleTest.test_webkit_export_check): Deleted.
2016         (WebKitStyleTest.test_member_initialization_list): Deleted.
2017         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2018         (WebKitStyleTest.test_other): Deleted.
2019         (CppCheckerTest.mock_handle_style_error): Deleted.
2020         (CppCheckerTest._checker): Deleted.
2021         (CppCheckerTest.test_init): Deleted.
2022         (CppCheckerTest.test_eq): Deleted.
2023         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2024         (CppCheckerTest.test_ne): Deleted.
2025         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2026         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2027         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2028         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2029         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2030         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2031
2032 2017-07-05  Saam Barati  <sbarati@apple.com>
2033
2034         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2035         https://bugs.webkit.org/show_bug.cgi?id=174188
2036         <rdar://problem/30581423>
2037
2038         Reviewed by Mark Lam.
2039
2040         * Scripts/run-jsc-stress-tests:
2041
2042 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2043
2044         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2045         https://bugs.webkit.org/show_bug.cgi?id=174150
2046
2047         Reviewed by Mark Lam.
2048
2049         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2050         (TestWebKitAPI::TEST):
2051
2052 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2053
2054         Remove copy of ICU headers from WebKit
2055         https://bugs.webkit.org/show_bug.cgi?id=116407
2056
2057         Reviewed by Alex Christensen.
2058
2059         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2060         * TestWebKitAPI/Configurations/Base.xcconfig:
2061         * WebKitTestRunner/Configurations/Base.xcconfig:
2062
2063 2017-07-05  Chris Dumez  <cdumez@apple.com>
2064
2065         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2066         https://bugs.webkit.org/show_bug.cgi?id=174163
2067         <rdar://problem/33067518>
2068
2069         Reviewed by Alex Christensen.
2070
2071         Add API test coverage.
2072
2073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2074         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
2075         (TEST):
2076
2077 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2078
2079         When dragging a selection, clearing the selection in dragstart should not crash the web process
2080         https://bugs.webkit.org/show_bug.cgi?id=174142
2081         <rdar://problem/33067501>
2082
2083         Reviewed by Tim Horton.
2084
2085         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
2086         drag is starting up.
2087
2088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2089         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
2090         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2091         (TestWebKitAPI::TEST):
2092
2093 2017-07-05  Daniel Bates  <dabates@apple.com>
2094
2095         Do not pass API::FrameInfo for source frame or clear out page of target frame on
2096         API navigation
2097         https://bugs.webkit.org/show_bug.cgi?id=174170
2098         <rdar://problem/33140328>
2099
2100         Reviewed by Brady Eidson.
2101
2102         Update tests as needed for the behavior change.
2103
2104         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2105         (TEST):
2106
2107 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2108
2109         Add WebKitPrivateFrameworkStubs for iOS 11
2110         https://bugs.webkit.org/show_bug.cgi?id=173988
2111
2112         Reviewed by David Kilzer.
2113
2114         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
2115         should use the same directory for private framework stubs.
2116         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2117
2118 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
2119
2120         [MediaStream] Protect request and web view during gUM client callback
2121         https://bugs.webkit.org/show_bug.cgi?id=174096
2122         <rdar://problem/32833102>
2123
2124         Reviewed by Youenn Fablet.
2125
2126         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2127         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2128
2129 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2130
2131         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
2132
2133         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2134
2135 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2136
2137         Unreviewed, rolling out r219128.
2138
2139         Spoke with engineer who originally submitted, Patch for APi
2140         test to follow.
2141
2142         Reverted changeset:
2143
2144         "Unreviewed, rolling out r219070."
2145         https://bugs.webkit.org/show_bug.cgi?id=174082
2146         http://trac.webkit.org/changeset/219128
2147
2148 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2149
2150         Unreviewed, rolling out r219070.
2151
2152         This revision caused consistent failures of the API test
2153         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
2154
2155         Reverted changeset:
2156
2157         "Pasting single words copied to UIPasteboard inserts URLs in
2158         editable areas"
2159         https://bugs.webkit.org/show_bug.cgi?id=174082
2160         http://trac.webkit.org/changeset/219070
2161
2162 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2163
2164         Remove unused EFL logo from bot watcher dashboard
2165         https://bugs.webkit.org/show_bug.cgi?id=174136
2166
2167         Reviewed by Alexey Proskuryakov.
2168
2169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
2170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
2171
2172 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2173
2174         [GTK] Add more GTK bots to dashboard
2175         https://bugs.webkit.org/show_bug.cgi?id=174129
2176
2177         Reviewed by Carlos Alberto Lopez Perez.
2178
2179         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
2180         them.
2181
2182         This also changes the sort order to put WPE above GTK so that it's not buried under all the
2183         less-essential GTK bots.
2184
2185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2186         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2187         (WebKitBuildbot):
2188
2189 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2190
2191         [WPE] Add WPE to bot watcher dashboard
2192         https://bugs.webkit.org/show_bug.cgi?id=174119
2193
2194         Reviewed by Alexey Proskuryakov.
2195
2196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
2197         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
2198         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
2199         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2201         (WebKitBuildbot):
2202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2203         (table.queue-grid tr.platform.linux-wpe img.logo):
2204
2205 2017-07-03  Lucas Forschler  <lforschler@apple.com>
2206
2207         https://bugs.webkit.org/show_bug.cgi?id=174105
2208         
2209         Reviewed by Stephanie Lewis.
2210
2211         * BuildSlaveSupport/built-product-archive:
2212         (main): Add a -minify parser option
2213         (createZip): Pass along the optional Minify argument if requested
2214         (minifySource): This will trim down archives, logic limited to Mac platform.
2215
2216 2017-07-03  Matt Rajca  <mrajca@apple.com>
2217
2218         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
2219         https://bugs.webkit.org/show_bug.cgi?id=174103
2220
2221         Reviewed by Alex Christensen.
2222
2223         Added an API test.
2224
2225         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
2226         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2227         (TEST): Added test.
2228         * TestWebKitAPI/cocoa/TestWKWebView.h:
2229         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2230         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
2231
2232 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2233
2234         Unreviewed, rolling out r219103.
2235
2236         Caused multiple build failures.
2237
2238         Reverted changeset:
2239
2240         "Remove copy of ICU headers from WebKit"
2241         https://bugs.webkit.org/show_bug.cgi?id=116407
2242         http://trac.webkit.org/changeset/219103
2243
2244 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2245
2246         Remove copy of ICU headers from WebKit
2247         https://bugs.webkit.org/show_bug.cgi?id=116407
2248
2249         Reviewed by Alex Christensen.
2250
2251         Use WTF's copy of ICU headers.
2252
2253         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2254         * TestWebKitAPI/Configurations/Base.xcconfig:
2255         * WebKitTestRunner/Configurations/Base.xcconfig:
2256
2257 2017-07-03  Brady Eidson  <beidson@apple.com>
2258
2259         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2260         https://bugs.webkit.org/show_bug.cgi?id=174073
2261
2262         Reviewed by Andy Estes.
2263
2264         * DumpRenderTree/mac/TestRunnerMac.mm:
2265         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
2266
2267         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
2268         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2269
2270 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2271
2272         Unreviewed, rolling out r219083.
2273
2274         The revision caused an API failure on all testing platforms.
2275
2276         Reverted changeset:
2277
2278         "[MediaStream] Protect request and web view during gUM client
2279         callback"
2280         https://bugs.webkit.org/show_bug.cgi?id=174096
2281         http://trac.webkit.org/changeset/219083
2282
2283 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
2284
2285         webkitpy: Properly number duplicated crashlogs
2286         https://bugs.webkit.org/show_bug.cgi?id=172002
2287
2288         Reviewed by Aakash Jain.
2289
2290         * Scripts/webkitpy/common/system/crashlogs.py:
2291         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
2292         an increasing integer.
2293         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2294         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
2295         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
2296         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
2297
2298 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
2299
2300         WebContent processes crash when the network process crashes with pending connection requests
2301         https://bugs.webkit.org/show_bug.cgi?id=174065
2302         <rdar://problem/30359835>
2303
2304         Reviewed by Tim Horton.
2305
2306         Add a API to ensure UI process tries to relaunch a new network process when the network process
2307         crashes with pending network connection requests.
2308
2309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2310         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
2311         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2312         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2313         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
2314
2315 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
2316
2317         [MediaStream] Protect request and web view during gUM client callback
2318         https://bugs.webkit.org/show_bug.cgi?id=174096
2319         <rdar://problem/32833102>
2320
2321         Reviewed by Youenn Fablet.
2322
2323         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2324         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2325
2326 2017-07-03  Andy Estes  <aestes@apple.com>
2327
2328         [Xcode] Add an experimental setting to build with ccache
2329         https://bugs.webkit.org/show_bug.cgi?id=173875
2330
2331         Reviewed by Tim Horton.
2332
2333         On systems that already have ccache(1) installed, this patch adds experimental support for
2334         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
2335
2336         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
2337         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
2338         find the toolchain from which to run clang, and then invokes ccache with the required
2339         arguments.
2340
2341         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
2342         precompiled headers to work properly [1].
2343
2344         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
2345         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
2346         during linking.
2347         
2348         [1] https://ccache.samba.org/manual.html#_precompiled_headers
2349
2350         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2351         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2352         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2353         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2354         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
2355         * ccache/README.md: Added.
2356         * ccache/ccache-clang: Added.
2357         * ccache/ccache-clang++: Added.
2358         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
2359
2360 2017-07-03  Alex Christensen  <achristensen@webkit.org>
2361
2362         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2363         https://bugs.webkit.org/show_bug.cgi?id=174051
2364
2365         Reviewed by Tim Horton.
2366
2367         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2368         (TestWebKitAPI::TEST_F):
2369
2370 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2371
2372         Unreviewed, rolling out r219024.
2373
2374         This patch cause 3 didferent test to fail.
2375
2376         Reverted changeset:
2377
2378         "REGRESSION(r215096) Queries of URLs with non-special schemes
2379         should not percent-encode single quotes"
2380         https://bugs.webkit.org/show_bug.cgi?id=174051
2381         http://trac.webkit.org/changeset/219024
2382
2383 2017-07-03  Chris Dumez  <cdumez@apple.com>
2384
2385         Drop ResourceLoadStatisticsStore's statisticsLock
2386         https://bugs.webkit.org/show_bug.cgi?id=174080
2387
2388         Reviewed by Brent Fulgham.
2389
2390         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2391
2392         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2393         (WTR::TestController::isStatisticsPrevalentResource):
2394         (WTR::TestController::isStatisticsHasHadUserInteraction):
2395         (WTR::TestController::isStatisticsGrandfathered):
2396
2397 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2398
2399         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2400         https://bugs.webkit.org/show_bug.cgi?id=174082
2401         <rdar://problem/33046992>
2402
2403         Reviewed by Tim Horton.
2404
2405         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2406
2407         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2408         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2409         (TestWebKitAPI::TEST):
2410
2411 2017-07-02  Brady Eidson  <beidson@apple.com>
2412
2413         Add API test for all parts of WebKit1 API related to favicons.
2414         https://bugs.webkit.org/show_bug.cgi?id=174069
2415
2416         Reviewed by Andy Estes.
2417
2418         These two API tests cover all WebKit1 API related to icons.
2419         
2420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2421         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2422         (mainResourceData):
2423         (defaultFaviconData):
2424         (customFaviconData):
2425         (imageFromData):
2426         (+[IconLoadingProtocol canInitWithRequest:]):
2427         (+[IconLoadingProtocol canonicalRequestForRequest:]):
2428         (-[IconLoadingProtocol startLoading]):
2429         (-[IconLoadingProtocol stopLoading]):
2430         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2431         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2432         (TestWebKitAPI::TEST):
2433
2434 2017-07-01  Dan Bernstein  <mitz@apple.com>
2435
2436         [iOS] Remove code only needed when building for iOS 9.x
2437         https://bugs.webkit.org/show_bug.cgi?id=174068
2438
2439         Reviewed by Tim Horton.
2440
2441         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2442         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2443         (WTR::initializeWebViewConfiguration):
2444         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2445         (-[HIDEventGenerator _createIOHIDEventType:]):
2446
2447 2017-07-01  Brady Eidson  <beidson@apple.com>
2448
2449         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2450         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2451
2452         Reviewed by Alex Christensen.
2453
2454         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2455
2456 2017-07-01  Dan Bernstein  <mitz@apple.com>
2457
2458         [macOS] Remove code only needed when building for OS X Yosemite
2459         https://bugs.webkit.org/show_bug.cgi?id=174067
2460
2461         Reviewed by Tim Horton.
2462
2463         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2464         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2465         * DumpRenderTree/mac/DumpRenderTree.mm:
2466         (setDefaultsToConsistentValuesForTesting):
2467         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2468         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2469         * MiniBrowser/Configurations/Base.xcconfig:
2470         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2471         * TestWebKitAPI/Configurations/Base.xcconfig:
2472         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2473         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2474         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2475         (TestWebKitAPI::TEST_F):
2476         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2477         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2478         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2479         (TestWebKitAPI::TEST_F):
2480         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2481         (TestWebKitAPI::TEST):
2482         * WebKitTestRunner/Configurations/Base.xcconfig:
2483         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2484         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2485         (WTR::InjectedBundle::platformInitialize):
2486         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2487         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2488
2489 2017-07-01  Chris Dumez  <cdumez@apple.com>
2490
2491         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
2492         https://bugs.webkit.org/show_bug.cgi?id=174060
2493
2494         Reviewed by Brent Fulgham.
2495
2496         Port WebKitTestRunner over to the new Cocoa SPI.
2497
2498         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2499         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2500         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2501         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
2502         no-ops since this code runs in the WebContent process, not the
2503         UIProcess.
2504
2505         * WebKitTestRunner/TestController.cpp:
2506         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2507
2508 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2509
2510         Unreviewed mac build fix.
2511
2512         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2513         (TestWebKitAPI::TEST):
2514
2515 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2516
2517         Add API to get WKActivatedElementInfo
2518         https://bugs.webkit.org/show_bug.cgi?id=174001
2519         <rdar://problem/29165518>
2520         
2521         Tests for now SPI to get activatedElementInfo.
2522
2523         Reviewed by Tim Horton.
2524
2525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2526         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
2527         (TestWebKitAPI::TEST):
2528
2529 2017-06-30  Chris Dumez  <cdumez@apple.com>
2530
2531         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
2532         https://bugs.webkit.org/show_bug.cgi?id=174038
2533
2534         Reviewed by Brent Fulgham.
2535
2536         Fix typo in API name.
2537
2538         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2539         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2540         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2541         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2542         * WebKitTestRunner/TestController.cpp:
2543         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2544         * WebKitTestRunner/TestController.h:
2545         * WebKitTestRunner/TestInvocation.cpp:
2546         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2547
2548 2017-06-30  Alex Christensen  <achristensen@webkit.org>
2549
2550         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2551         https://bugs.webkit.org/show_bug.cgi?id=174051
2552         <rdar://problem/33002846>
2553
2554         Reviewed by Tim Horton.
2555
2556         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2557         (TestWebKitAPI::TEST_F):
2558
2559 2017-06-30  Daniel Bates  <dabates@apple.com>
2560
2561         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2562         https://bugs.webkit.org/show_bug.cgi?id=165160
2563         <rdar://problem/29451999>
2564
2565         Reviewed by Brady Eidson.
2566
2567         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
2568         for navigations and window creation.
2569
2570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2571         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
2572         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2573         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
2574         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2575         (TEST):
2576
2577 2017-06-29  Jer Noble  <jer.noble@apple.com>
2578
2579         Make Legacy EME API controlled by RuntimeEnabled setting.
2580         https://bugs.webkit.org/show_bug.cgi?id=173994
2581
2582         Reviewed by Sam Weinig.
2583
2584         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2585
2586 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2587
2588         Follow-up fix for r218996
2589
2590         Unreviewed infrastructure fix.
2591
2592         Repeated calls to 'ios_version' make the log noisy, memoize the function.
2593
2594         * Scripts/webkitpy/port/ios_simulator.py:
2595         (IOSSimulatorPort): Memoize ios_version().
2596
2597 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2598
2599         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2600         https://bugs.webkit.org/show_bug.cgi?id=174017
2601         <rdar://problem/32959782>
2602
2603         Reviewed by Simon Fraser.
2604
2605         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
2606         changes, the caret would appear outside of the iframe.
2607
2608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2609         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
2610         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2611         (checkDragCaretRectIsContainedInRect):
2612         (TestWebKitAPI::TEST):
2613         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2614         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2615         (-[DataInteractionSimulator _resetSimulatedState]):
2616         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2617         (-[DataInteractionSimulator _advanceProgress]):
2618         (-[DataInteractionSimulator lastKnownDragCaretRect]):
2619
2620 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2621
2622         Add support for different versions of iOS when loading test expectations
2623         https://bugs.webkit.org/show_bug.cgi?id=173774
2624         <rdar://problem/32951132>
2625
2626         Rubber-stamped by Aakash Jain.
2627
2628         When running layout tests, we should support multiple version of iOS the same way we do Mac.
2629
2630         * Scripts/webkitpy/port/ios.py:
2631         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
2632         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
2633         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
2634         * Scripts/webkitpy/port/ios_device.py:
2635         (IOSDevicePort.ios_version): Ask connected devices for implementation.
2636         * Scripts/webkitpy/port/ios_device_unittest.py:
2637         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
2638         (IOSDeviceTest.test_baseline_searchpath): Ditto.
2639         (IOSDeviceTest.test_expectations_ordering): Ditto.
2640         * Scripts/webkitpy/port/ios_simulator.py:
2641         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
2642         ask the platform.
2643
2644 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
2645
2646         Fontconfig build breaks with glibc 2.15+
2647         https://bugs.webkit.org/show_bug.cgi?id=174019
2648
2649         Reviewed by Carlos Alberto Lopez Perez.
2650
2651         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
2652
2653         * wpe/jhbuild.modules:
2654         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
2655
2656 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2657
2658         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
2659         https://bugs.webkit.org/show_bug.cgi?id=174010
2660         <rdar://problem/32597802>
2661
2662         Reviewed by Tim Horton.
2663
2664         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
2665         snapshot fails for any reason.
2666
2667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2668         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
2669         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2670         (TestWebKitAPI::TEST):
2671
2672 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
2673
2674         AX: Cannot call setValue() on contenteditable or ARIA text controls
2675         https://bugs.webkit.org/show_bug.cgi?id=173520
2676
2677         Reviewed by Ryosuke Niwa.
2678
2679         Add setValue() method to WKTR (already existed in DRT).
2680
2681         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2682         (WTR::AccessibilityUIElement::setValue):
2683         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2684         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2685         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2686         (WTR::AccessibilityUIElement::setValue):
2687
2688 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2689
2690         getBoundingClientRect returns wrong value for combination of page zoom and scroll
2691         https://bugs.webkit.org/show_bug.cgi?id=173841
2692         rdar://problem/32983841
2693
2694         Reviewed by Dean Jackson.
2695
2696         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
2697         always did text zooming.
2698
2699         * MiniBrowser/mac/WK1BrowserWindowController.m:
2700         (-[WK1BrowserWindowController zoomIn:]):
2701         (-[WK1BrowserWindowController zoomOut:]):
2702         (-[WK1BrowserWindowController canResetZoom]):
2703         (-[WK1BrowserWindowController resetZoom:]):
2704
2705 2017-06-29  John Wilander  <wilander@apple.com>
2706
2707         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
2708         https://bugs.webkit.org/show_bug.cgi?id=173940
2709         <rdar://problem/33018125>
2710
2711         Reviewed by Brent Fulgham.
2712
2713         This change allows the TestController to turn off
2714         regular resource load statistics telemetry submission
2715         and to manually control when telemetry is calculated
2716         and submitted.
2717
2718         * WebKitTestRunner/TestController.cpp:
2719         (WTR::TestController::initialize):
2720             Turns off automatic resource load statistics telemetry submission.
2721
2722 2017-06-29  Commit Queue  <commit-queue@webkit.org>
2723
2724         Unreviewed, rolling out r218512.
2725         https://bugs.webkit.org/show_bug.cgi?id=173981
2726
2727         "It changes the behavior of the JS API's JSEvaluateScript
2728         which breaks TurboTax" (Requested by saamyjoon on #webkit).
2729
2730         Reverted changeset:
2731
2732         "test262: Completion values for control flow do not match the
2733         spec"
2734         https://bugs.webkit.org/show_bug.cgi?id=171265
2735         http://trac.webkit.org/changeset/218512
2736
2737 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2738
2739         Add WebKitSystemInterface for iOS 11
2740         https://bugs.webkit.org/show_bug.cgi?id=173936
2741
2742         Reviewed by Lucas Forschler.
2743
2744         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
2745
2746 2017-06-28  Keith Miller  <keith_miller@apple.com>
2747
2748         VMTraps has some races
2749         https://bugs.webkit.org/show_bug.cgi?id=173941
2750
2751         Reviewed by Michael Saboff.
2752
2753         Add new testing mode for testing the Watchdog with our stress
2754         tests.
2755
2756         * Scripts/run-jsc-stress-tests:
2757
2758 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2759
2760         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
2761         https://bugs.webkit.org/show_bug.cgi?id=173877
2762
2763         Reviewed by Brady Eidson.
2764
2765         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
2766         the next tests.
2767
2768         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2769         (testGetFavicon):
2770
2771 2017-06-28  Tim Horton  <timothy_horton@apple.com>
2772
2773         MobileSafari was constantly using 10-15% CPU viewing a PDF
2774         https://bugs.webkit.org/show_bug.cgi?id=173944
2775         <rdar://problem/33039910>
2776
2777         Reviewed by Simon Fraser.
2778
2779         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2780         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2781         Add a test that we ever call the stable presentation update callback
2782         when we have a WKPDFView up, instead of infinitely looping.
2783
2784 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2785
2786         Prevent displaying URLs with small capital letters
2787         https://bugs.webkit.org/show_bug.cgi?id=173949
2788         <rdar://problem/32952058>
2789
2790         Reviewed by Brent Fulgham.
2791
2792         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2793         (TestWebKitAPI::TEST):
2794
2795 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2796
2797         Unreviewed test fix.
2798
2799         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2800
2801         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2802
2803 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2804
2805         Teach ResourceLoadStatistics to recognize changes in the file system
2806         https://bugs.webkit.org/show_bug.cgi?id=173800
2807         <rdar://problem/32937842>
2808
2809         Reviewed by Chris Dumez.
2810
2811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2812         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2813         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2814         (TestWebKitAPI::handleFileModification):
2815         (TestWebKitAPI::handleFileDeletion):
2816         (TestWebKitAPI::resetTestState):
2817         (TestWebKitAPI::TEST_F):
2818
2819 2017-06-28  Brady Eidson  <beidson@apple.com>
2820
2821         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2822         https://bugs.webkit.org/show_bug.cgi?id=173874
2823
2824         Reviewed by Alex Christensen.
2825
2826         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2827
2828 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2829
2830         Unreviewed, adding Don Olmstead to contributors.json
2831
2832         * Scripts/webkitpy/common/config/contributors.json:
2833
2834 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2835
2836         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
2837         https://bugs.webkit.org/show_bug.cgi?id=173886
2838         <rdar://problem/32543191>
2839
2840         Reviewed by Andy Estes.
2841
2842         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2843         (ParsedRange::ParsedRange):
2844         (-[TestSchemeHandler initWithVideoData:]):
2845         (-[TestSchemeHandler webView:startURLSchemeTask:]):
2846         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
2847         (TEST):
2848
2849 2017-06-27  JF Bastien  <jfbastien@apple.com>
2850
2851         WebAssembly: running out of executable memory should throw OoM
2852         https://bugs.webkit.org/show_bug.cgi?id=171537
2853         <rdar://problem/32963338>
2854
2855         Reviewed by Saam Barati.
2856
2857         * Scripts/run-jsc-stress-tests: add a configuration which runs the
2858         tests under limited executable memory and avoids non-WebAssembly
2859         code generation so that we more reliably run out of executable
2860         memory in WebAssembly.
2861
2862 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2863
2864         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2865         https://bugs.webkit.org/show_bug.cgi?id=173854
2866         <rdar://problem/32236827>
2867
2868         Reviewed by Ryosuke Niwa and Tim Horton.
2869
2870         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
2871
2872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2873         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
2874         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2875         (TestWebKitAPI::TEST):
2876
2877 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
2878
2879         [PAL] Add symbol export macros for PAL
2880         https://bugs.webkit.org/show_bug.cgi?id=171519
2881
2882         Reviewed by Konstantin Tokarev.
2883
2884         * DumpRenderTree/config.h:
2885         * TestWebKitAPI/CMakeLists.txt:
2886         * TestWebKitAPI/config.h:
2887         * WebKitTestRunner/config.h:
2888
2889 2017-06-27  John Wilander  <wilander@apple.com>
2890
2891         Resource Load Statistics: Add telemetry
2892         https://bugs.webkit.org/show_bug.cgi?id=173499
2893         <rdar://problem/32826094>
2894
2895         Reviewed by Brent Fulgham.
2896
2897         Adds three new testRunner functions:
2898         - installStatisticsDidRunTelemetryCallback()
2899         - statisticsFireTelemetryHandler()
2900         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
2901
2902         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2903         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2904         (WTR::InjectedBundle::didReceiveMessageToPage):
2905         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2906         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
2907         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
2908         (WTR::TestRunner::statisticsFireTelemetryHandler):
2909         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2910         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2911         * WebKitTestRunner/TestController.cpp:
2912         (WTR::TestController::resetStateToConsistentValues):
2913         (WTR::TestController::statisticsFireTelemetryHandler):
2914         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2915         * WebKitTestRunner/TestController.h:
2916         * WebKitTestRunner/TestInvocation.cpp:
2917         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2918
2919 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
2920
2921         Add missing includes to fix compilation error on FreeBSD
2922         https://bugs.webkit.org/show_bug.cgi?id=172919
2923
2924         Reviewed by Mark Lam.
2925
2926         * ImageDiff/cairo/PlatformImageCairo.cpp:
2927
2928 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
2929
2930         Unreviewed, rolling out r218783.
2931
2932         Causing accessibility/mac/setting-attributes-is-
2933         asynchronous.html to crash consistently on mac-wk2 Debug
2934
2935         Reverted changeset:
2936
2937         "AX: Cannot call setValue() on contenteditable or ARIA text
2938         controls"
2939         https://bugs.webkit.org/show_bug.cgi?id=173520
2940         http://trac.webkit.org/changeset/218783
2941
2942 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2943
2944         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
2945         https://bugs.webkit.org/show_bug.cgi?id=173825
2946
2947         Reviewed by Saam Barati.
2948
2949         * DumpRenderTree/JavaScriptThreading.cpp:
2950         (runJavaScriptThread):
2951         (startJavaScriptThreads):
2952         * DumpRenderTree/mac/DumpRenderTree.mm:
2953         (runThread):
2954         (runPthread):
2955         (testThreadIdentifierMap):
2956
2957 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2958
2959         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
2960         <https://webkit.org/b/173837>
2961
2962         Reviewed by Geoffrey Garen.
2963
2964         The clang static analyzer can't reason about objects that are
2965         assigned to a delegate as +1 retained, and then released
2966         later in a different method when the delegate is cleared.
2967
2968         Instead, use a common idiom where the object setting the
2969         delegate retains it as an instance variable on initialization.
2970         Then the same object clears the delegate and releases its
2971         instance variable during teardown.
2972
2973         Also add EXPECT_TRUE() tests to make sure the delegate objects
2974         match before teardown.
2975
2976         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2977         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2978         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2979         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2980         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2981         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
2982
2983 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2984
2985         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
2986         <https://webkit.org/b/173836>
2987
2988         Reviewed by Brady Eidson.
2989
2990         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2991         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
2992         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
2993         objects in this test.
2994
2995 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
2996
2997         [ATK] Add support for aria-details and aria-errormessage
2998         https://bugs.webkit.org/show_bug.cgi?id=172588
2999
3000         Reviewed by Chris Fleizach.
3001
3002         Add additional methods to test ARIA properties which are exposed via
3003         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
3004         to versions which support the details and error-message relation types.
3005
3006         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3007         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3008         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3009         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3010         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3011         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3012         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3013         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3014         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3015         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3016         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3017         * gtk/jhbuild.modules:
3018
3019 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3020
3021         Unreviewed. Add libfii to GTK+ install dependencies script.
3022
3023         * gtk/install-dependencies:
3024
3025 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3026
3027         Unreviewed, rolling out r215190.
3028
3029         Broke product select element on GNOME Bugzilla
3030
3031         Reverted changeset:
3032
3033         "[GTK] Misplaced right click menu on web page due to
3034         deprecated gtk_menu_popup()"
3035         https://bugs.webkit.org/show_bug.cgi?id=170553
3036         http://trac.webkit.org/changeset/215190
3037
3038 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
3039
3040         Remove Reflect.enumerate
3041         https://bugs.webkit.org/show_bug.cgi?id=173806
3042
3043         Reviewed by Yusuke Suzuki.
3044
3045         * Scripts/run-jsc-stress-tests:
3046
3047 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
3048
3049         AX: Cannot call setValue() on contenteditable or ARIA text controls
3050         https://bugs.webkit.org/show_bug.cgi?id=173520
3051
3052         Reviewed by Ryosuke Niwa.
3053
3054         Add setValue() method to WKTR (already existed in DRT).
3055
3056         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3057         (WTR::AccessibilityUIElement::setValue):
3058         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3059         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3060         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3061         (WTR::AccessibilityUIElement::setValue):
3062
3063 2017-06-23  Keith Miller  <keith_miller@apple.com>
3064
3065         Switch VMTraps to use halt instructions rather than breakpoint instructions
3066         https://bugs.webkit.org/show_bug.cgi?id=173677
3067
3068         Reviewed by JF Bastien.
3069
3070         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3071         (TEST):
3072
3073 2017-06-23  Youenn Fablet  <youenn@apple.com>
3074
3075         Set getUserMedia permission to true by default on WTR
3076         https://bugs.webkit.org/show_bug.cgi?id=173610
3077
3078         Reviewed by Alex Christensen.
3079
3080         Adding a way to reset the getUserMedia permission to pending.
3081
3082         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3083         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3084         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
3085         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3086         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3087         (WTR::TestRunner::setUserMediaPermissionAsUnset):
3088         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3089         * WebKitTestRunner/TestController.cpp:
3090         (WTR::TestController::resetStateToConsistentValues):
3091         (WTR::TestController::setUserMediaPermissionAsUnset):
3092         * WebKitTestRunner/TestController.h:
3093         * WebKitTestRunner/TestInvocation.cpp:
3094         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3095
3096 2017-06-23  Alex Christensen  <achristensen@webkit.org>
3097
3098         Add SPI to WKURLSchemeTask for redirection
3099         https://bugs.webkit.org/show_bug.cgi?id=173730
3100
3101         Reviewed by Brady Eidson.
3102
3103         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3104         (-[SchemeHandler webView:startURLSchemeTask:]):
3105         (-[SchemeHandler webView:stopURLSchemeTask:]):
3106         (TEST):
3107         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
3108         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
3109         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
3110         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
3111         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
3112
3113 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3114
3115         [WPE] Use JSC API to send script messages from web extension in tests
3116         https://bugs.webkit.org/show_bug.cgi?id=173757
3117
3118         Reviewed by Žan Doberšek.
3119
3120         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
3121         to run postMessage().
3122
3123         Fixes: /wpe/WebKitSecurityManager/file-xhr
3124                /wpe/WebKitConsoleMessage/console-api
3125                /wpe/WebKitConsoleMessage/js-exception
3126                /wpe/WebKitConsoleMessage/network-error
3127                /wpe/WebKitConsoleMessage/security-error
3128
3129         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3130         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
3131         (beforeAll): Ditto.
3132         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3133         (testWebContextSecurityFileXHR): Ditto.
3134         (beforeAll): Ditto.
3135         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3136         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
3137         (pageCreatedCallback): Remove ifdefs.
3138
3139 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3140
3141         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
3142
3143         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
3144         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
3145         doesn't exist yet in WPE.
3146
3147         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3148         (testWebViewJavaScriptDialogs):
3149         (testWebViewWindowProperties):
3150
3151 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3152
3153         [GTK] Upgrade pixman and cairo in jhbuild
3154         https://bugs.webkit.org/show_bug.cgi?id=173710
3155
3156         Reviewed by Carlos Alberto Lopez Perez.
3157
3158         * gtk/jhbuild.modules:
3159
3160 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3161
3162         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
3163         https://bugs.webkit.org/show_bug.cgi?id=173711
3164
3165         Reviewed by Carlos Alberto Lopez Perez.
3166
3167         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
3168         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
3169
3170         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3171         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
3172
3173 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3174
3175         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
3176         <https://webkit.org/b/173721>
3177
3178         Reviewed by Joseph Pecoraro.
3179
3180         Use RetainPtr<> to create NSMutableDictionary and NSNumber
3181         objects to fix leaks and to avoid the autoreleasepool.
3182
3183         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
3184         (TEST):
3185
3186 2017-06-22  Matt Lewis  <jlewis3@apple.com>
3187
3188         Unreviewed, rolling out r218633.
3189
3190         The test is failing frequently on Sierra Debug and Windows
3191
3192         Reverted changeset:
3193
3194         "AX: Cannot call setValue() on contenteditable or ARIA text
3195         controls"
3196         https://bugs.webkit.org/show_bug.cgi?id=173520
3197         http://trac.webkit.org/changeset/218633
3198
3199 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3200
3201         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
3202         <https://webkit.org/b/173690>
3203
3204         Reviewed by Chris Dumez.
3205
3206         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
3207         ownership of malloc()-ed memory, then frees it when it's
3208         released.  These tests were passing global variables into the
3209         method, which is not malloc()-ed memory, which violates the API
3210         contract.
3211
3212         The fix is to switch to use
3213         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
3214         NO for the last argument.
3215
3216         Caught by the clang static analyzer.
3217
3218         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3219         (TEST):
3220         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3221         (TEST):
3222
3223 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3224
3225         [GTK] Upgrade Harfbuzz to version 1.4.2
3226         https://bugs.webkit.org/show_bug.cgi?id=173592
3227
3228         Reviewed by Carlos Alberto Lopez Perez.
3229
3230         * gtk/jhbuild.modules:
3231
3232 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3233
3234         [WPE] Update WPEBackend-mesa
3235         https://bugs.webkit.org/show_bug.cgi?id=173705
3236
3237         Reviewed by Carlos Alberto Lopez Perez.
3238
3239         A crash has been fixed, needed for unit tests to work.
3240
3241         * wpe/jhbuild.modules:
3242
3243 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3244
3245         Remove unused coordinated graphics C API
3246         https://bugs.webkit.org/show_bug.cgi?id=173706
3247
3248         Reviewed by Žan Doberšek.
3249
3250         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
3251         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
3252         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
3253         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
3254         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
3255         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
3256
3257 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3258
3259         [WPE] Build glib API tests
3260         https://bugs.webkit.org/show_bug.cgi?id=173702
3261
3262         Reviewed by Žan Doberšek.
3263
3264         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
3265         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
3266         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
3267         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
3268         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
3269         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
3270         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
3271         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
3272         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
3273         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
3274         and implement the missing features.
3275
3276         * CMakeLists.txt:
3277         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
3278         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3279         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3280         (testAutomationSessionRequestSession):
3281         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3282         (testWebKitWebViewSessionState):
3283         (testWebKitWebViewSessionStateWithFormData):
3284         (testWebKitWebViewNavigationAfterSessionRestore):
3285         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3286         (beforeAll):
3287         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3288         (testCookieManagerEphemeral):
3289         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3290         (testBlobDownload):
3291         (beforeAll):
3292         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3293         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3294         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3295         (testProcessPerWebView):
3296         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3297         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3298         (testWebViewCreateNavigationData):
3299         (testWebViewJavaScriptDialogs):
3300         (testWebViewWindowProperties):
3301         (testWebViewMouseTarget):
3302         (testWebViewGeolocationPermissionRequests):
3303         (testWebViewUserMediaPermissionRequests):
3304         (testWebViewAudioOnlyUserMediaPermissionRequests):
3305         (testWebViewFileChooserRequest):
3306         (beforeAll):
3307         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3308         (beforeAll):
3309         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3310         (testPrivateBrowsing):
3311         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3312         (testFindControllerHide):
3313         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3314         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3315         (testWebKitSettings):
3316         (beforeAll):
3317         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3318         (testWebViewNewWithUserContentManager):
3319         (beforeAll):
3320         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3321         (testWebContextEphemeral):
3322         (testWebContextProxySettings):
3323         (beforeAll):
3324         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3325         (testWebViewWebContext):
3326         (testWebViewWebContextLifetime):
3327         (testWebViewEphemeral):
3328         (testWebViewSettings):
3329         (testWebViewCanShowMIMEType):
3330         (testWebViewPageVisibility):
3331         (testWebViewIsPlayingAudio):
3332         (beforeAll):
3333         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3334         (testWebsiteDataEphemeral):
3335         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3336         (documentLoadedCallback):
3337         (pageCreatedCallback):
3338         (methodCallCallback):
3339         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
3340         * TestWebKitAPI/glib/CMakeLists.txt:
3341         * TestWebKitAPI/glib/PlatformGTK.cmake:
3342         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3343         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3344         (main):
3345         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3346         (Test::adoptView):
3347         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3348         (WebKitTestBus::run):
3349         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3350         (WebViewTest::~WebViewTest):
3351         (WebViewTest::initializeWebView):
3352         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3353         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
3354         (WebViewTest::platformDestroy):
3355         (WebViewTest::platformInitializeWebView):
3356         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3357         (WebViewTest::resizeView):
3358         (WebViewTest::hideView):
3359         (parentWindowMapped):
3360         (WebViewTest::showInWindow):
3361         (WebViewTest::showInWindowAndWaitUntilMapped):
3362         (WebViewTest::mouseMoveTo):
3363         (WebViewTest::clickMouseButton):
3364         (WebViewTest::emitPopupMenuSignal):
3365         (WebViewTest::keyStroke):
3366         (WebViewTest::doMouseButtonEvent):
3367         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
3368         (WebViewTest::platformDestroy):
3369         (WebViewTest::platformInitializeWebView):
3370         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3371         (WebViewTest::resizeView):
3372         (WebViewTest::hideView):
3373         (WebViewTest::mouseMoveTo):
3374         (WebViewTest::clickMouseButton):
3375         (WebViewTest::keyStroke):
3376
3377 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3378
3379         [GTK] Move WebKit2 GLib API tests to glib directories
3380         https://bugs.webkit.org/show_bug.cgi?id=173642
3381
3382         Reviewed by Žan Doberšek.
3383
3384         * CMakeLists.txt:
3385         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
3386         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
3387         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
3388         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
3389         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
3390         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
3391         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
3392         (testWebKitConsoleMessageNetworkError):
3393         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
3394         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
3395         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
3396         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
3397         (testLoadFromGResource):
3398         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
3399         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
3400         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
3401         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
3402         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
3403         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
3404         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
3405         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
3406         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
3407         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
3408         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
3409         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
3410         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
3411         (testWebViewRunJavaScript):
3412         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
3413         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
3414         (registerGResource):
3415         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
3416         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
3417         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
3418         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
3419         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
3420         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
3421         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
3422         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
3423         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
3424         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
3425         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
3426         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
3427         * TestWebKitAPI/glib/CMakeLists.txt: Added.
3428         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
3429         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
3430         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
3431         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
3432         (registerGResource):
3433         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
3434         (Test::getResourcesDir):
3435         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
3436         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
3437         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
3438         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
3439         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
3440         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
3441
3442 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3443
3444         [WPE] Add initial web extensions API
3445         https://bugs.webkit.org/show_bug.cgi?id=173640
3446
3447         Reviewed by Žan Doberšek.
3448
3449         Add style checker exceptions for WPE web extensions API files.
3450
3451         * Scripts/webkitpy/style/checker.py:
3452
3453 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3454
3455         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
3456         https://bugs.webkit.org/show_bug.cgi?id=173659
3457         <rdar://problem/32879788>
3458
3459         Reviewed by Tim Horton.
3460
3461         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
3462
3463         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
3464
3465         Augment this test page to log dragend and dragstart events on the drag source as well.
3466
3467         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3468         (checkStringArraysAreEqual):
3469         (TestWebKitAPI::TEST):
3470
3471 2017-06-21  Antoine Quint  <graouts@apple.com>
3472
3473         Ensure DRT always logs rAF suspension debugging code
3474         https://bugs.webkit.org/show_bug.cgi?id=173681
3475
3476         Reviewed by Tim "Mr. T" Horton.
3477
3478         * DumpRenderTree/mac/DumpRenderTree.mm:
3479         (resetWebPreferencesToConsistentValues):
3480
3481 2017-06-21  Chris Dumez  <cdumez@apple.com>
3482
3483         Allow constructing a WTF:Function from a function pointer
3484         https://bugs.webkit.org/show_bug.cgi?id=173660
3485
3486         Reviewed by Alex Christensen.
3487
3488         Add API test coverage.
3489
3490         * TestWebKitAPI/Tests/WTF/Function.cpp:
3491         (TestWebKitAPI::returnThree):
3492         (TestWebKitAPI::returnFour):
3493         (TestWebKitAPI::returnPassedValue):
3494         (TestWebKitAPI::TEST):
3495
3496 2017-06-21  Antoine Quint  <graouts@apple.com>
3497
3498         Add logging to identify when the Page suspends scripted animations
3499         https://bugs.webkit.org/show_bug.cgi?id=173626
3500
3501         Reviewed by Tim Horton.
3502
3503         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
3504
3505         * DumpRenderTree/mac/DumpRenderTree.mm:
3506         (resetWebPreferencesToConsistentValues):
3507
3508 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
3509
3510         AX: Cannot call setValue() on contenteditable or ARIA text controls
3511         https://bugs.webkit.org/show_bug.cgi?id=173520
3512
3513         Reviewed by Ryosuke Niwa.
3514
3515         Add setValue() method to WKTR (already existed in DRT).
3516
3517         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3518         (WTR::AccessibilityUIElement::setValue):
3519         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3520         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3521         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3522         (WTR::AccessibilityUIElement::setValue):
3523
3524 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
3525
3526         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
3527         as one of the dependencies required to build the product.
3528
3529         Rubber-stamped by Carlos Garcia Campos.
3530
3531         * gtk/install-dependencies:
3532         * wpe/install-dependencies:
3533
3534 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3535
3536         Disable font variations on macOS Sierra and iOS 10
3537         https://bugs.webkit.org/show_bug.cgi?id=173618
3538         <rdar://problem/32879164>
3539
3540         Reviewed by Jon Lee.
3541
3542         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3543
3544 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3545
3546         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
3547         https://bugs.webkit.org/show_bug.cgi?id=173578
3548         <rdar://problem/32825028>
3549
3550         Reviewed by Tim Horton.
3551
3552         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
3553         a custom popover does not cause dragging to fail when the popover is presented.
3554
3555         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3556         (-[DataInteractionSimulator _advanceProgress]):
3557
3558 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3559
3560         [WPE] Add initial implementation of glib API
3561         https://bugs.webkit.org/show_bug.cgi?id=173546
3562
3563         Reviewed by Žan Doberšek.
3564
3565         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
3566         include WPE glib API files.
3567
3568         * Scripts/webkitperl/FeatureList.pm:
3569         * Scripts/webkitpy/style/checker.py:
3570         * Scripts/webkitpy/style/checkers/cpp.py:
3571         (check_identifier_name_in_declaration):
3572
3573 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3574
3575         [GTK] Upgrade to ICU to version 57.1
3576         https://bugs.webkit.org/show_bug.cgi?id=173538
3577
3578         Reviewed by Žan Doberšek.
3579
3580         * gtk/jhbuild.modules:
3581
3582 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3583
3584         [GTK] Remove unneeded modules from the jhbuild
3585         https://bugs.webkit.org/show_bug.cgi?id=170540
3586
3587         Reviewed by Michael Catanzaro.
3588
3589         We are building libxslt and libffi that we don't really need to build from sources.
3590
3591         * gtk/jhbuild.modules:
3592
3593 2017-06-19  Frederic Wang  <fwang@igalia.com>
3594
3595         [Mac] Add an experimental feature setting for async frame scrolling
3596         https://bugs.webkit.org/show_bug.cgi?id=173359
3597
3598         Reviewed by Simon Fraser.
3599
3600         * DumpRenderTree/mac/DumpRenderTree.mm:
3601         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
3602         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
3603         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3604         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
3605
3606 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
3607
3608         Unreviewed, adding myself&nb