2011-02-09 Hayato Ito <hayato@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-02-09  Hayato Ito  <hayato@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         [NRWT] Remove encoding parameters where we can assume data can be
6         written in binary mode.
7
8         https://bugs.webkit.org/show_bug.cgi?id=54066
9
10         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
11         * Scripts/webkitpy/layout_tests/port/base.py:
12
13 2011-02-09  Dirk Pranke  <dpranke@chromium.org>
14
15         Reviewed by Tony Chang.
16
17         nrwt multiprocessing: minor cleanup prior to implementing the new worker
18
19         This patch renames AbstractManager to ManagerConnection and
20         changes some argument names to be more consistent between
21         manager_worker_broker and message_broker. It also fixes a couple
22         of typos in message_broker. These changes will be tested by code
23         introduced in the next patch.
24        
25         https://bugs.webkit.org/show_bug.cgi?id=54067
26
27         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
28         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py:
29
30 2011-02-09  Anders Carlsson  <andersca@apple.com>
31
32         Reviewed by Sam Weinig.
33
34         Repro crash with Sony Google TV ad at Gizmodo
35         https://bugs.webkit.org/show_bug.cgi?id=54150
36         <rdar://problem/8782346>
37
38         Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback.
39
40         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
41         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added.
42         (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream):
43         (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy):
44         (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream):
45         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
46         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
47
48 2011-02-09  David Levin  <levin@chromium.org>
49
50         Reviewed by Eric Seidel.
51
52         check-webkit-style: The error message about NULL should be more clear for comments.
53         https://bugs.webkit.org/show_bug.cgi?id=53786
54
55         * Scripts/webkitpy/style/checkers/cpp.py: Clarified the error message.
56         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Fixed the corresponding test.
57
58 2011-02-09  Nebojsa Ciric  <cira@chromium.org>
59
60         Reviewed by Darin Fisher.
61
62         Implements Locale object of JavaScript internationalization API proposal, as an
63         v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
64         and in this patch we just provide flags, tests and build rules for chromium port.
65         https://bugs.webkit.org/show_bug.cgi?id=49414
66
67         * DumpRenderTree/chromium/TestShell.cpp:
68         (TestShell::TestShell):
69
70 2011-02-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
71
72         Reviewed by Kenneth Rohde Christiansen.
73
74         [Qt] Remove UiTools dependency from MiniBrowser
75         https://bugs.webkit.org/show_bug.cgi?id=54096
76
77         * MiniBrowser/qt/MiniBrowser.pro:
78
79 2011-02-08  Hayato Ito  <hayato@chromium.org>
80
81         Reviewed by Tony Chang.
82
83         [NRWT] Pull up rebaseline code from compare_output() function defined
84         in text_diff.py and image_diff.py into a SingleTestRunner.
85
86         This patch is a first step for eliminating test_type/* classes.
87
88         https://bugs.webkit.org/show_bug.cgi?id=53071
89
90         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
91         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
92         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
93         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
94
95 2011-02-07  Ojan Vafai  <ojan@chromium.org>
96
97         Reviewed by Mihai Parparita.
98
99         stop generating results.json files
100         https://bugs.webkit.org/show_bug.cgi?id=53977
101
102         We've only used incremental_results.json for a while now
103         and there are plans to start generating a results.json file that matches
104         the format of unexpected_results.json.
105
106         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
107         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
108         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
109         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
110         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
111
112 2011-02-08  Sailesh Agrawal  <sail@chromium.org>
113
114         Reviewed by Kenneth Russell.
115
116         Invalidate rect doesn't work for windowless plugins on Chromium
117         https://bugs.webkit.org/show_bug.cgi?id=53117
118
119         Added two new utility methods.
120         - layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints.
121         - plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect
122         This is used to test that invalidating a rect correctly causes a repaint of the plugin.
123
124         * DumpRenderTree/LayoutTestController.cpp:
125         (displayInvalidatedRegionCallback):
126         (LayoutTestController::staticFunctions):
127         * DumpRenderTree/LayoutTestController.h:
128         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
129         (invalidateRect):
130         (pluginInvoke):
131         * DumpRenderTree/chromium/LayoutTestController.cpp:
132         (LayoutTestController::LayoutTestController):
133         (LayoutTestController::displayInvalidatedRegion):
134         * DumpRenderTree/chromium/LayoutTestController.h:
135         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
136
137 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
138
139         Reviewed by Tony Chang.
140
141         new-run-webkit-tests: move the logic that starts and stops the
142         servers from dump_render_tree_thread into single_test_runner
143         so that we can reuse it in the new multiprocessing worker class
144         as well.
145
146         https://bugs.webkit.org/show_bug.cgi?id=53840
147
148         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
149         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
150  
151 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
152
153         Reviewed by Mihai Parparita.
154
155         new-run-webkit-tests: split out thread stack logging code into a sharable module
156
157         This patch splits out the code used to find and log thread
158         stacks from NRWT-specific packages to something generic and
159         shareable by other python modules. It will be shared in the near
160         future by the manager_worker_broker module, for example.
161
162         https://bugs.webkit.org/show_bug.cgi?id=53656
163
164         * Scripts/webkitpy/common/system/stack_utils.py: Added.
165         * Scripts/webkitpy/common/system/stack_utils_unittest.py: Added.
166         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
167         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
168
169 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
170
171         Reviewed by Tony Chang.
172
173         new-run-webkit-tests: move a bunch of testing logic out of
174         dump_render_tree_thread and into single_test_runner so that we
175         will be able to reuse it in the new multiprocessing worker class as well.
176
177         https://bugs.webkit.org/show_bug.cgi?id=53838
178
179         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
180         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
181
182         
183 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
184
185         Reviewed by Ojan Vafai.
186
187         new-run-webkit-tests: remove no longer needed WatchableThread
188         class.
189
190         https://bugs.webkit.org/show_bug.cgi?id=53839
191
192         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
193
194 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
195
196         Reviewed by Tony Chang.
197
198         new-run-webkit-tests: add stubs for the Manager objects that
199         will abstract the concurrency implementation (inline / threads /
200         processes). These classes do nothing yet and are not wired up to
201         anything.
202
203         https://bugs.webkit.org/show_bug.cgi?id=53477
204
205         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added.
206         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added.
207
208 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
209
210         Reviewed by Tony Chang.
211
212         new-run-webkit-tests: add simplified message broker for new-style
213         messaging. This change adds a very simple message broker that
214         will be used to shuttle messages between the TestRunner2 manager
215         thread and the Worker threads. For now the class is not used by
216         anything, but the eventual usage can be seen in the patches
217         attached to bug 49566.
218
219         https://bugs.webkit.org/show_bug.cgi?id=53158
220
221         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added.
222         * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added.
223
224 2011-02-08  Adam Barth  <abarth@webkit.org>
225
226         Reviewed by Dimitri Glazkov.
227
228         chromium-win builder shouldn't run python or perl tests
229         https://bugs.webkit.org/show_bug.cgi?id=54032
230
231         These tests don't pass on this builder because the builder isn't
232         running in cygwin.  There isn't really any point in running them and
233         making the bot red forever.
234
235         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
236
237 2011-02-08  Brady Eidson  <beidson@apple.com>
238
239         Reviewed by Darin Adler.
240
241         <rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036
242         didChangeBackForwardList should include some context about what changed
243
244         * MiniBrowser/mac/BrowserWindowController.m:
245         (didChangeBackForwardList):
246
247 2011-02-08  Sam Weinig  <sam@webkit.org>
248
249         Reviewed by Anders Carlsson.
250
251         WK2: Add ability to pass context to policy delegate methods
252         https://bugs.webkit.org/show_bug.cgi?id=54031
253
254         * MiniBrowser/mac/BrowserWindowController.m:
255         (decidePolicyForNavigationAction):
256         (decidePolicyForNewWindowAction):
257         (decidePolicyForMIMEType):
258         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
259         (TestWebKitAPI::decidePolicyForNavigationAction):
260         (TestWebKitAPI::decidePolicyForNewWindowAction):
261         (TestWebKitAPI::decidePolicyForMIMEType):
262         Update policy client for new API.
263
264 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
265
266         Reviewed by Xan Lopez.
267
268         [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
269         https://bugs.webkit.org/show_bug.cgi?id=54033
270
271         Add an implementation of LayoutTestController.setIconDatabaseEnabled that just
272         call DumpRenderTreeSupportGtk. Turn off the icon database between tests.
273
274         * DumpRenderTree/gtk/DumpRenderTree.cpp:
275         (resetDefaultsToConsistentValues): Turn off the icon database.
276         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
277         (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk
278         method.
279
280 2011-02-08  Kundu Suchismita  <suchi.kundu@nokia.com>
281
282         Reviewed by Laszlo Gombos.
283
284         Local Storage settings can be enable/disable from "Develop" menu
285         https://bugs.webkit.org/show_bug.cgi?id=52296
286
287         * QtTestBrowser/launcherwindow.cpp:
288         (LauncherWindow::createChrome):
289         (LauncherWindow::toggleLocalStorage):
290         (LauncherWindow::toggleOfflineStorageDatabase):
291         (LauncherWindow::toggleOfflineWebApplicationCache):
292         (LauncherWindow::setOfflineStorageDefaultQuota):
293         * QtTestBrowser/launcherwindow.h:
294         (WindowOptions::WindowOptions):
295         * QtTestBrowser/main.cpp:
296         (LauncherApplication::handleUserOptions):
297
298 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
299
300         Reviewed by Eric Seidel.
301
302         [GTK] EventSender.keyDown does not support non-array modifier arguments
303         https://bugs.webkit.org/show_bug.cgi?id=53962
304
305         Support handling either an array or a string for the modifier argument
306         to EventSender.keyDown.
307
308         * DumpRenderTree/gtk/EventSender.cpp:
309         (gdkModifierFromJSValue): Added this helper which factors out the
310         string comparison bits.
311         (gdkModifersFromJSValue): Test up front whether the value is a string,
312         to handle it specially.
313
314 2011-02-08  Benjamin Poulain  <ikipou@gmail.com>
315
316         Reviewed by Csaba Osztrogonác.
317
318         openDatabaseSync() stop responding after too many call
319         https://bugs.webkit.org/show_bug.cgi?id=53945
320
321         Reset the database quota to a known state between each test.
322
323         Define a quota for the known origins at each test run and delete
324         all the databases.
325         This way, the database related test do not depend on previous
326         allocations.
327
328         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
329         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
330         (WebCore::DumpRenderTree::dumpDatabaseQuota):
331         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
332         (LayoutTestController::reset):
333
334 2011-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
335
336         Reviewed by Martin Robinson.
337
338         [GTK] DRT's TextInputController is unimplemented on GTK
339         https://bugs.webkit.org/show_bug.cgi?id=52997
340
341         Initial implementation of TextInputController for GTK port.
342
343         * DumpRenderTree/gtk/DumpRenderTree.cpp:
344         (webViewWindowObjectCleared):
345         * DumpRenderTree/gtk/TextInputController.cpp: Added.
346         (setMarkedTextCallback):
347         (insertTextCallback):
348         (unmarkTextCallback):
349         (firstRectForCharacterRangeCallback):
350         (selectedRangeCallback):
351         (getClass):
352         (makeTextInputController):
353         * DumpRenderTree/gtk/TextInputController.h: Added.
354         * GNUmakefile.am:
355
356 2011-02-07  Tony Chang  <tony@chromium.org>
357
358         Reviewed by Adam Barth.
359
360         clean up python imports
361         https://bugs.webkit.org/show_bug.cgi?id=53966
362
363         Convert "import A.B.C.D as D" to "from A.B.C import D" and
364         make some imports absolute as required by PEP-8
365
366         * Scripts/webkitpy/common/checkout/scm.py:
367         * Scripts/webkitpy/common/net/irc/ircbot.py:
368         * Scripts/webkitpy/common/system/logutils.py:
369         * Scripts/webkitpy/common/system/logutils_unittest.py:
370         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
371         * Scripts/webkitpy/layout_tests/port/chromium.py:
372         * Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
373         * Scripts/webkitpy/layout_tests/port/webkit.py:
374         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
375         * Scripts/webkitpy/tool/bot/irc_command.py:
376         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
377         * Scripts/webkitpy/tool/commands/download.py:
378         * Scripts/webkitpy/tool/commands/prettydiff.py:
379         * Scripts/webkitpy/tool/commands/queries.py:
380         * Scripts/webkitpy/tool/commands/roll.py:
381         * Scripts/webkitpy/tool/commands/stepsequence.py:
382         * Scripts/webkitpy/tool/commands/upload.py:
383         * Scripts/webkitpy/tool/main.py:
384
385 2011-02-07  James Robinson  <jamesr@chromium.org>
386
387         Reviewed by Adam Barth.
388
389         Teach do-webcore-rename about the WebKit move to Source/
390         https://bugs.webkit.org/show_bug.cgi?id=53967
391
392         * Scripts/do-webcore-rename:
393
394 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
395
396         Reviewed by Dan Bernstein.
397
398         Add resource load client for injected bundle and move willSendRequest there
399         https://bugs.webkit.org/show_bug.cgi?id=53972
400
401         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
402         (didCreatePage):
403         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
404         (WTR::InjectedBundlePage::InjectedBundlePage):
405         (WTR::InjectedBundlePage::didInitiateLoadForResource):
406         (WTR::InjectedBundlePage::didReceiveResponseForResource):
407         (WTR::InjectedBundlePage::didReceiveContentLengthForResource):
408         (WTR::InjectedBundlePage::didFinishLoadForResource):
409         (WTR::InjectedBundlePage::didFailLoadForResource):
410         (WTR::InjectedBundlePage::willSendRequestForFrame):
411         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
412
413 2011-02-07  Adam Barth  <abarth@webkit.org>
414
415         Add Leopard Debug back to the core builders.
416
417         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
418         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
419
420 2011-02-07  Adam Klein  <adamk@chromium.org>
421
422         Reviewed by Jian Li.
423
424         [chromium] Remove deprecated method WebNotification::dir
425         https://bugs.webkit.org/show_bug.cgi?id=53735
426
427         * DumpRenderTree/chromium/NotificationPresenter.cpp:
428         (NotificationPresenter::show):
429
430 2011-02-07  Adam Barth  <abarth@webkit.org>
431
432         Reviewed by Eric Seidel.
433
434         Remove Leopard Debug as a core builder
435         https://bugs.webkit.org/show_bug.cgi?id=53971
436
437         The Leopard Debug builder has been failing to compile for several days.
438         My understanding is that folks are working on fixing the build, but for
439         the time being we should probably remove it from the list of core
440         builders so that the core waterfall can be green.  We can certainly add
441         it back once the build is fixed.
442
443         Also, I've removed the Tiger builders because those no longer appear to
444         be attached to the buildbot master.
445
446         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
447         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
448
449 2011-02-01  Ojan Vafai  <ojan@chromium.org>
450
451         Reviewed by Adam Roben.
452
453         include svn revisions in git diffs for the code review tool to use
454         https://bugs.webkit.org/show_bug.cgi?id=53569
455
456         * Scripts/webkitpy/common/checkout/scm.py:
457         * Scripts/webkitpy/common/checkout/scm_unittest.py:
458
459 2011-02-03  MORITA Hajime  <morrita@google.com>
460
461         Reviewed by Darin Fisher.
462
463         [Chromium] Should implement EditorClientImpl::requestCheckingOfString()
464         https://bugs.webkit.org/show_bug.cgi?id=51013
465
466         Gave DRT implementation for requestTextCheck().
467
468         * DumpRenderTree/chromium/LayoutTestController.cpp:
469         (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
470         * DumpRenderTree/chromium/WebViewHost.cpp:
471         (invokeFinishLastTextCheck): Added.
472         (WebViewHost::requestTextCheck): Added.
473         (WebViewHost::finishLastTextCheck): Added.
474         * DumpRenderTree/chromium/WebViewHost.h:
475
476 2011-02-07  Joone Hur  <joone.hur@collabora.co.uk>
477
478         Reviewed by Martin Robinson.
479
480         [Gtk] Implement layoutTestController.findString
481         https://bugs.webkit.org/show_bug.cgi?id=50237
482
483         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
484         (LayoutTestController::findString):
485
486 2011-02-07  Chang Shu  <chang.shu@nokia.com>
487
488         Reviewed by Darin Adler.
489
490         We should disable spatial navigation explicitly during the initialization
491         of DumpRenderTree.
492         https://bugs.webkit.org/show_bug.cgi?id=53928
493
494         * DumpRenderTree/mac/DumpRenderTree.mm:
495         (resetDefaultsToConsistentValues):
496
497 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
498
499         Not reviewed.
500
501         Fix WebKitTestRunner build on the SL bot.
502
503         * WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy
504         of ICU headers.
505
506 2011-02-07  Csaba Osztrogonác  <ossy@webkit.org>
507
508         Unreviewed.
509
510         [Qt][WK2] Buildfix after r77794.
511
512        WebKitTestRunner does not block remote resources or complain about them
513        https://bugs.webkit.org/show_bug.cgi?id=42139
514        <rdar://problem/8183942>
515
516         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths.
517
518 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
519
520         Not reviewed.
521
522         More bot appeasement.
523
524         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
525
526 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
527
528         Not reviewed.
529
530         Remove accidental references to directories on my laptop.
531
532         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
533
534 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
535
536         Reviewed by Antti Koivisto.
537
538         WebKitTestRunner does not block remote resources or complain about them
539         https://bugs.webkit.org/show_bug.cgi?id=42139
540         <rdar://problem/8183942>
541
542         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
543         (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required
544         checks (using KURL, to avoid need to invent a whole URL API).
545         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore
546         directly to get at KURL symbols.
547
548 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
549
550         Reviewed by Daniel Bates.
551
552         Add WebKit2 bot to list of expected builders in Python regression test results.
553         https://bugs.webkit.org/show_bug.cgi?id=53905
554
555         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
556
557 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
558
559         Reviewed by Ryosuke Niwa.
560
561         Update test expectations for new core builder
562         https://bugs.webkit.org/show_bug.cgi?id=53904
563
564         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
565
566 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
567
568         Reviewed by David Levin.
569
570         Add WebKit2 test bot to core builders
571         https://bugs.webkit.org/show_bug.cgi?id=53901
572
573         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
574
575 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
576
577         Another unreviewed Chromium build fix.
578
579         * DumpRenderTree/chromium/LayoutTestController.cpp:
580         (LayoutTestController::pathToLocalResource):
581
582 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
583
584         Unreviewed Chromium build fix.
585
586         * DumpRenderTree/chromium/LayoutTestController.cpp:
587         (LayoutTestController::pathToLocalResource):
588
589 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
590
591         Reviewed by Darin Adler.
592
593         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
594         https://bugs.webkit.org/show_bug.cgi?id=52867
595
596         * DumpRenderTree/chromium/ImageDiff.cpp:
597         (Image::craeteFromStdin): Call adoptArrayPtr.
598
599 2011-02-06  James Kozianski  <koz@chromium.org>
600
601         Reviewed by Ojan Vafai.
602
603         Add classes for representing test outputs.
604         https://bugs.webkit.org/show_bug.cgi?id=52136
605
606         These classes will make it easier to write scripts that deal with test
607         outputs such as rebaselining and deduping scripts. The intent is that
608         eventually we will be have buildbot return TestOutputs for a
609         particular build which can be compared with TestOutputs derived from a
610         local LayoutTests directory.
611
612         * Scripts/webkitpy/common/net/testoutput.py: Added.
613         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
614         * Scripts/webkitpy/common/net/testoutputset.py: Added.
615         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
616         * Scripts/webkitpy/common/system/zip_mock.py: Added.
617
618 2011-02-06  Robert Hogan  <robert@webkit.org>
619
620         Reviewed by Andreas Kling.
621
622         [Qt] Clear page's groupName even when not in DRT
623         https://bugs.webkit.org/show_bug.cgi?id=53874
624
625         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
626         (WebCore::DumpRenderTree::windowCloseRequested):
627
628 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
629
630         Reviewed by Andreas Kling.
631
632         [CMake] Add dependencies for Visual Studio projects
633         https://bugs.webkit.org/show_bug.cgi?id=53773
634
635         Add a WebKit dependecy to WinCELauncher, so CMake can 
636         generate the correct build order for the solution.
637
638         * CMakeListsWinCE.txt:
639
640 2011-02-06  Andreas Kling  <kling@webkit.org>
641
642         Reviewed by Antonio Gomes.
643
644         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
645         https://bugs.webkit.org/show_bug.cgi?id=53869
646
647         * MiniBrowser/qt/BrowserView.cpp:
648         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
649         * MiniBrowser/qt/BrowserWindow.cpp:
650         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
651         * MiniBrowser/qt/BrowserWindow.h:
652
653 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
654
655         Reviewed by Dan Bernstein.
656
657         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
658         https://bugs.webkit.org/show_bug.cgi?id=42690
659         <rdar://problem/8213851>
660
661         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
662         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
663         (WTR::InjectedBundlePage::willSendRequestForFrame):
664         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
665         (WTR::LayoutTestController::LayoutTestController):
666         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
667         (WTR::LayoutTestController::willSendRequestReturnsNull):
668         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
669
670 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
671
672         Unreviewed, rolling out r77720.
673         http://trac.webkit.org/changeset/77720
674         https://bugs.webkit.org/show_bug.cgi?id=53854
675
676         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
677         #webkit).
678
679         * Scripts/webkitpy/common/system/executive.py:
680
681 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
682
683         Unreviewed, rolling out r77725.
684         http://trac.webkit.org/changeset/77725
685         https://bugs.webkit.org/show_bug.cgi?id=53844
686
687         It broke Qt minimal build (Requested by Ossy_ on #webkit).
688
689         * QtTestBrowser/launcherwindow.cpp:
690         (LauncherWindow::createChrome):
691         * QtTestBrowser/launcherwindow.h:
692         (WindowOptions::WindowOptions):
693         * QtTestBrowser/main.cpp:
694         (LauncherApplication::handleUserOptions):
695
696 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
697
698         Reviewed by Adam Barth.
699
700         [GTK] plugins/plugin-document-back-forward.html fails
701         https://bugs.webkit.org/show_bug.cgi?id=53833
702
703         Add the new "alert on load" functionality for the Unix version of the
704         test plugin. This functionality was originally introduced in r77706.
705
706         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
707         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
708
709 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
710
711         Reviewed by Andreas Kling.
712
713         Local Storage settings can be enable/disable from "Develop" menu
714         https://bugs.webkit.org/show_bug.cgi?id=52296
715
716         * QtTestBrowser/launcherwindow.cpp:
717         (LauncherWindow::createChrome):
718         (LauncherWindow::toggleLocalStorage):
719         (LauncherWindow::toggleOfflineStorageDatabase):
720         (LauncherWindow::toggleOfflineWebApplicationCache):
721         (LauncherWindow::setOfflineStorageDefaultQuota):
722         * QtTestBrowser/launcherwindow.h:
723         (WindowOptions::WindowOptions):
724         * QtTestBrowser/main.cpp:
725         (LauncherApplication::handleUserOptions):
726
727 2011-02-04  Tony Chang  <tony@chromium.org>
728
729         Reviewed by Eric Seidel.
730
731         get test-webkitpy running on win32 python
732         https://bugs.webkit.org/show_bug.cgi?id=53822
733
734         The test harness crashes with a WindowsError because it can't find
735         'svn' when using subprocess.Popen.  This gets us past the error
736         so we can see the failing tests on the Chromium Win Release Tests
737         bot.
738
739         * Scripts/webkitpy/common/system/executive.py:
740
741 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
742
743         Reviewed by Gustavo Noronha Silva.
744
745         [GTK] fast/events/pagehide-timeout.html fails
746         https://bugs.webkit.org/show_bug.cgi?id=53771
747
748         Add knowledge of the document browser cache model the DRT. When resetting
749         WebKit settings to consistent values between tests, default to the document
750         browser cache model.
751
752         * DumpRenderTree/gtk/DumpRenderTree.cpp:
753         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
754         cache model between tests.
755         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
756         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
757         document browser cache model.
758
759 2011-02-04  Adam Barth  <abarth@webkit.org>
760
761         Reviewed by Eric Seidel.
762
763         PluginDocuments don't create widgets for plugins on back/forward
764         https://bugs.webkit.org/show_bug.cgi?id=53474
765
766         Teach the test plugin how to call alert on load.
767
768         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
769         (NPP_New):
770
771 2011-02-04  Adam Roben  <aroben@apple.com>
772
773         Add a test case for encode/decode of FormData/FormDataElement
774
775         If the fix made in r77401 is broken, this new test will crash.
776
777         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
778
779         Reviewed by Sam Weinig.
780
781         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
782         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
783
784         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
785         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
786         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
787         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
788         form, an return the session state data.
789         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
790         and restore it into another WKPage.
791
792         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
793
794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
795         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
796         * TestWebKitAPI/win/copy-resources.cmd:
797         Added new files.
798
799 2011-02-04  Adam Roben  <aroben@apple.com>
800
801         Move code to run JavaScript tests into its own files
802
803         This will allow other tests to use this mechanism.
804
805         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
806         world
807
808         Reviewed by Sam Weinig.
809
810         * TestWebKitAPI/JavaScriptTest.cpp: Added.
811         * TestWebKitAPI/JavaScriptTest.h: Added.
812         Moved code here...
813
814         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
815
816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
817         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
818         Added the new files.
819
820 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
821
822         Reviewed by Mihai Parparita.
823
824         merge test expectations for chromium, chromium-gpu. The
825         chromium-gpu port will no longer maintain its own
826         test expectations file.
827
828         Also add in a graphics_type() call on the port object to
829         determine what graphics type to use in the test configuration,
830         and log the configuration as a config setting.
831
832         https://bugs.webkit.org/show_bug.cgi?id=53562
833
834         * Scripts/webkitpy/layout_tests/port/base.py:
835         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
836         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
837         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
838
839 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
840
841         Reviewed by Pavel Feldman.
842
843         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
844         https://bugs.webkit.org/show_bug.cgi?id=53781
845
846         * Scripts/check-inspector-strings:
847
848 2011-02-04  Adam Roben  <aroben@apple.com>
849
850         Include the crashing function in the link to a crash log on Mac
851
852         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
853         function that crashed on Mac
854
855         Reviewed by David Kilzer.
856
857         * Scripts/old-run-webkit-tests:
858         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
859         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
860         the crash log.
861
862 2011-02-04  Adam Roben  <aroben@apple.com>
863
864         Link to Mac crash logs from results.html
865
866         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
867         results.html
868
869         Reviewed by David Kilzer.
870
871         * Scripts/old-run-webkit-tests:
872         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
873         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
874
875 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
876
877         Reviewed by Dan Bernstein.
878
879         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
880         https://bugs.webkit.org/show_bug.cgi?id=52897
881         <rdar://problem/8898294>
882
883         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
884         (WTR::InjectedBundlePage::InjectedBundlePage):
885         (WTR::InjectedBundlePage::willSendRequestForFrame):
886         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
887
888 2011-02-03  Ivan Krstić  <ike@apple.com>
889
890         Unreviewed.
891
892         Adding myself to committers.py.
893
894         * Scripts/webkitpy/common/config/committers.py:
895
896 2011-02-03  James Kozianski  <koz@chromium.org>
897
898         Reviewed by Dimitri Glazkov.
899
900         Add navigator.registerProtocolHandler behind a flag.
901         https://bugs.webkit.org/show_bug.cgi?id=52609
902
903         * Scripts/build-webkit:
904
905 2011-02-03  Hayato Ito  <hayato@chromium.org>
906
907         Reviewed by Eric Seidel.
908
909         [NRWT] Remove TestArgs class, which is wrongly used.
910
911         https://bugs.webkit.org/show_bug.cgi?id=53063
912
913         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
914         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
915         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
916         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
917         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
918         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
919
920 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
921
922         Reviewed by Kenneth Russell.
923
924         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
925         https://bugs.webkit.org/show_bug.cgi?id=53714
926
927         * Scripts/build-webkit: change --3d-canvas build option
928           to set ENABLE_WEBGL
929
930 2011-02-03  Hayato Ito  <hayato@chromium.org>
931
932         Reviewed by Tony Chang.
933
934         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
935         move _run_single_test() and _process_output() functions from
936         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
937
938         This is clean up and acts as a preparation for elimination of test_types/*
939         classes. These classes will move to the single_test_runner module introduced
940         in this patch.
941
942         https://bugs.webkit.org/show_bug.cgi?id=53004
943
944         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
945         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
946         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
947         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
948         * Scripts/webkitpy/layout_tests/port/base.py:
949         * Scripts/webkitpy/layout_tests/port/chromium.py:
950         * Scripts/webkitpy/layout_tests/port/dryrun.py:
951         * Scripts/webkitpy/layout_tests/port/test.py:
952         * Scripts/webkitpy/layout_tests/port/webkit.py:
953         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
954         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
955         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
956
957 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
958
959         Unreviewed, build fix.
960
961         Delete a line that was accidentally missed in r77586; without it
962         there is still a race between the two threads.
963
964         https://bugs.webkit.org/show_bug.cgi?id=51572
965
966         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
967
968 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
969
970         Reviewed by Tony Chang.
971
972         nrwt: handle "broken pipe" notifications from DRT more cleanly.
973
974         https://bugs.webkit.org/show_bug.cgi?id=52927
975
976         * Scripts/webkitpy/layout_tests/port/server_process.py:
977         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
978
979 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
980
981         Reviewed by Kenneth Russell.
982
983         Update, resubmit change to bug 51572. I think the race that was
984         fixed in r76703 caused the hang that caused us to roll this
985         patch out before, so I'd like to try again.
986
987         https://bugs.webkit.org/show_bug.cgi?id=51572
988
989         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
990         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
991
992 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
993
994         Unreviewed.
995
996         Adding myself to committers.py.
997
998         * Scripts/webkitpy/common/config/committers.py:
999
1000 2011-02-03  Adam Roben  <aroben@apple.com>
1001
1002         Include the crashing function in the link to a crash log
1003
1004         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
1005         function that crashed
1006
1007         Reviewed by David Kilzer.
1008
1009         * Scripts/old-run-webkit-tests:
1010         (crashLocation): Added. Returns the location of the crash.
1011         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
1012         could be determined.
1013
1014 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1015
1016         Unreviewed, build fix.
1017
1018         Actually make the changes suggested by Mihai in his review
1019         of bug 53720 :(
1020
1021         https://bugs.webkit.org/show_bug.cgi?id=53720
1022
1023         * Scripts/webkitpy/layout_tests/port/test_files.py:
1024         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1025
1026 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1027
1028         Reviewed by Mihai Parparita.
1029
1030         new-run-webkit-tests: Fix bug introduced in r77434 that was
1031         causing us to run the canvas GPU tests on the Mac GPU port. This
1032         bug revealed that we were not setting the port.name() field
1033         properly in many cases, so I've cleaned up all of that code, and
1034         removed a few comments about "version-specific" GPU ports that
1035         don't exist and just confused things.
1036
1037         Testing also revealed that port.abspath_for_test() wasn't
1038         normalizing paths on Windows properly, so I fixed that as well.
1039
1040         https://bugs.webkit.org/show_bug.cgi?id=53719
1041
1042         * Scripts/webkitpy/layout_tests/port/base.py:
1043         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1044         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1045
1046 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1047
1048         Reviewed by Mihai Parparita.
1049
1050         new-run-webkit-tests: fix normalization of paths on windows when gathering files
1051
1052         r77434 introduced a bug that was causing the test expectations
1053         for the GPU ports to not be treated properly. It turns out that
1054         when we gathered the list of test files on Windows, we would
1055         return paths of the form "c:\LayoutTests/fast/canvas", and the
1056         mixture of backslashes and forward slashes was confusing things.
1057
1058         This patch normalizes all of the filenames returned from
1059         test_files.find(), and adds better tests for this (fixing a
1060         couple of other bugs found in the meantime).
1061
1062         https://bugs.webkit.org/show_bug.cgi?id=53720
1063
1064         * Scripts/webkitpy/layout_tests/port/test.py:
1065         * Scripts/webkitpy/layout_tests/port/test_files.py:
1066         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1067
1068 2011-02-03  Adam Roben  <aroben@apple.com>
1069
1070         Add links to Windows crash logs in results.html
1071
1072         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
1073         results.html
1074
1075         Reviewed by David Kilzer.
1076
1077         * Scripts/old-run-webkit-tests:
1078         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
1079         createDebuggerCommandFile).
1080         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
1081         tool has exited.
1082         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
1083         it into the test results directory tree. Only implemented for Cygwin currently.
1084         (findNewestFileMatchingGlob): Added. Does what it says.
1085         (htmlForResultsSection): Only link to files that exist.
1086         (linksForErrorTest): Add a link to the crash log.
1087         (deleteExpectedAndActualResults): Delete any old crash log for this test.
1088         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
1089         hardcoding it here.
1090
1091 2011-02-03  Adam Roben  <aroben@apple.com>
1092
1093         Tell the debugger the path to the WebKit source tree when saving a crash log
1094
1095         This allows the debugger to include the crashing line of code in the log.
1096
1097         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
1098         of code
1099
1100         Reviewed by Sam Weinig.
1101
1102         * Scripts/old-run-webkit-tests:
1103         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
1104         file and returns the path to that file. The commands we pass came from
1105         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
1106         WebKit source code lives.
1107         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
1108         line using -c, save them to a file and specify the path to that file using -cf. This works
1109         around what is presumably a bug in Windows's command line parsing, where having multiple
1110         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
1111         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
1112         together to make them easier to modify in the future.
1113
1114 2011-02-02  Sam Weinig  <sam@webkit.org>
1115
1116         Reviewed by Anders Carlsson.
1117
1118         Add notification of the end of a rubber band.
1119         <rdar://problem/8940648>
1120
1121         * MiniBrowser/mac/BrowserWindowController.m:
1122         (-[BrowserWindowController awakeFromNib]):
1123         * WebKitTestRunner/TestController.cpp:
1124         (WTR::TestController::createOtherPage):
1125         (WTR::TestController::initialize):
1126         Stub out the new WKUIClient function.
1127
1128 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
1129
1130         Unreviewed.
1131
1132         Adding myself to committers.py.
1133
1134         * Scripts/webkitpy/common/config/committers.py:
1135
1136 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
1137
1138         Reviewed by Csaba Osztrogonác.
1139
1140         [Qt][WK2] MiniBrowser's window size should be 800x600
1141         https://bugs.webkit.org/show_bug.cgi?id=53670
1142
1143         Make layout test failure debugging easier.
1144         * MiniBrowser/qt/BrowserWindow.cpp:
1145         (BrowserWindow::BrowserWindow):
1146
1147 2011-02-02  Andy Estes  <aestes@apple.com>
1148
1149         Reviewed by Mark Rowe.
1150
1151         'update-webkit' should handle OpenSource and Internal using different
1152         VCSs.
1153
1154         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
1155         Internal directory.
1156
1157 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
1158
1159         Reviewed by Mihai Parparita.
1160
1161         new-run-webkit-tests: hardcode the directories to scan for tests
1162         for GPU bots instead of SKIPping them. See bug 53562 for some
1163         context, but we will now hard-code the list of directories to
1164         use by default instead of skipping over directories in the
1165         expectations file. We do this so that we will be able to merge
1166         the expectations files without getting conflicting SKIP
1167         directives. Note that this change will reduce the # of tests
1168         being run on the Mac GPU bots, because we're accidentally
1169         including some today.
1170
1171         https://bugs.webkit.org/show_bug.cgi?id=53631
1172
1173         * Scripts/webkitpy/layout_tests/port/base.py:
1174         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1175         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1176
1177 2011-02-02  Sam Weinig  <sam@webkit.org>
1178
1179         Reviewed by Beth Dakin.
1180
1181         Add ChromeClient function to paint custom overhang areas.
1182         https://bugs.webkit.org/show_bug.cgi?id=53639
1183
1184         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1185         (WTR::InjectedBundlePage::InjectedBundlePage):
1186         Stub out new callback.
1187
1188 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
1189
1190         Reviewed by Tony Chang.
1191
1192         new-run-webkit-tests: support chromium code paths in mock_drt
1193
1194         https://bugs.webkit.org/show_bug.cgi?id=53471
1195
1196         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1197         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1198
1199 2011-02-02  Adam Klein  <adamk@chromium.org>
1200
1201         Reviewed by Tony Chang.
1202
1203         Update new-run-webkit-tests --chromium to put output under Source/...
1204         https://bugs.webkit.org/show_bug.cgi?id=53612
1205
1206         * BuildSlaveSupport/test-result-archive:
1207         * Scripts/webkitpy/layout_tests/port/chromium.py:
1208
1209 2011-01-28  Tony Chang  <tony@chromium.org>
1210
1211         Reviewed by Eric Seidel.
1212
1213         [chromium] remove --use-test-shell from NRWT
1214         https://bugs.webkit.org/show_bug.cgi?id=53346
1215
1216         I've already started removing some of the bindings like eventSender so
1217         this already doesn't work isn't useful.  Also updated some comments to
1218         refer to DRT instead of test_shell.
1219
1220         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1221         * Scripts/webkitpy/layout_tests/port/chromium.py:
1222         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1223         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1224         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1225         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1226         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1227         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1228
1229 2011-02-02  Steve Lacey  <sjl@chromium.org>
1230
1231         Reviewed by Eric Carlson.
1232
1233         Implement basic media statistics on media elements.
1234         https://bugs.webkit.org/show_bug.cgi?id=53322
1235
1236         * Scripts/build-webkit:
1237
1238 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
1239
1240         [wx] Build fixes for wxWebKit.
1241
1242         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1243         (LayoutTestController::setSerializeHTTPLoads):
1244         * wx/browser/wscript:
1245         * wx/build/build_utils.py:
1246         * wx/build/settings.py:
1247
1248 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
1249
1250         Reviewed by Mihai Parparita.
1251
1252         new-run-webkit-tests: stop skipping so many tests
1253
1254         r77163 introduced a regression where we weren't resetting test
1255         expectations properly and were skipping too many tests as a
1256         result. This patch fixes that and adds a test for it.
1257
1258         https://bugs.webkit.org/show_bug.cgi?id=53551
1259
1260         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1261         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1262
1263 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
1264
1265         Reviewed by Tony Chang.
1266
1267         new-run-webkit-tests: add first stub of test_runner2. This
1268         will add support for the 'inline', 'threads', and 'processes'
1269         flags to --worker-model, but for now the implementatios just
1270         fall back on the old ones.
1271
1272         https://bugs.webkit.org/show_bug.cgi?id=53157
1273
1274         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1275         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1276
1277 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
1278
1279         Reviewed by James Robinson.
1280
1281         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
1282         https://bugs.webkit.org/show_bug.cgi?id=53522
1283
1284         * Scripts/run-chromium-webkit-unit-tests:
1285
1286 2011-02-01  Adam Barth  <abarth@webkit.org>
1287
1288         Reviewed by Mihai Parparita.
1289
1290         Using Control-C to cancel webkit-patch or other python tools causes
1291         unpleasant traceback console spew
1292         https://bugs.webkit.org/show_bug.cgi?id=53462
1293
1294         Catch the exception and don't print the stack trace.
1295
1296         * Scripts/webkit-patch:
1297
1298 2011-02-01  Scott Cameron  <sccameron@rim.com>
1299
1300         Reviewed by Daniel Bates.
1301
1302         Use Windows format for MinGW HTTPD path.
1303         https://bugs.webkit.org/show_bug.cgi?id=53503
1304
1305         * Scripts/webkitperl/httpd.pm:
1306           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
1307             so that we don't have to escape the space characters in the path. Also,
1308             changed path to Windows-style path and removed FIXME comment.
1309
1310 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
1311
1312         Reviewed by Andreas Kling.
1313
1314         [Qt][WK2] Add a way to use shared process model in MiniBrowser
1315         https://bugs.webkit.org/show_bug.cgi?id=53090
1316
1317         * MiniBrowser/qt/BrowserView.cpp:
1318         (BrowserView::BrowserView): Removed the m_context member.
1319         From now the context is guaranteed to be non-null and we
1320         don't need to store that in the object.
1321         * MiniBrowser/qt/BrowserView.h:
1322         * MiniBrowser/qt/BrowserWindow.cpp:
1323         Added static bool to determine that new windows need to be
1324         created with their own context or not. Use the same context
1325         and web process by default to be inilne with the other ports.
1326         (BrowserWindow::BrowserWindow):
1327         (BrowserWindow::newWindow):
1328         * MiniBrowser/qt/BrowserWindow.h:
1329         * MiniBrowser/qt/main.cpp:
1330         (main): Added command line switch to be able to use the
1331         non-shared process model. Simplify the handling of the command line
1332         switches a little bit.
1333
1334 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
1335
1336         Reviewed by Andreas Kling.
1337
1338         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
1339         https://bugs.webkit.org/show_bug.cgi?id=53491
1340
1341         * MiniBrowser/qt/BrowserWindow.cpp:
1342         (BrowserWindow::BrowserWindow):
1343         (BrowserWindow::toggleFullScreenMode):
1344         * MiniBrowser/qt/BrowserWindow.h:
1345
1346 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
1347
1348         Reviewed by Andreas Kling.
1349
1350         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
1351         https://bugs.webkit.org/show_bug.cgi?id=53489
1352
1353         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
1354         to Settings menu.
1355
1356         * MiniBrowser/qt/BrowserWindow.cpp:
1357         (BrowserWindow::BrowserWindow):
1358         (BrowserWindow::toggleFrameFlattening):
1359         (BrowserWindow::toggleDisableJavaScript):
1360         (BrowserWindow::toggleAutoLoadImages):
1361         * MiniBrowser/qt/BrowserWindow.h:
1362
1363 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
1364
1365         Reviewed by Tony Chang.
1366
1367         [Chromium] Switch chromium-mac to use ChromiumDriver
1368         https://bugs.webkit.org/show_bug.cgi?id=53461
1369         
1370         For the sake of consistency with the other Chromium platforms (and so
1371         that chromium-mac picks up special flags like --enable-hardware-gpu),
1372         switch chromium-mac from the WebKitDriver to ChromiumDriver.
1373
1374         * Scripts/webkitpy/layout_tests/port/chromium.py:
1375
1376 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
1377
1378         Reviewed by Mihai Parparita.
1379
1380         The current modifier parsing code in test_expectations is
1381         fragile and hard-coded, so it's not easy to understand the logic
1382         or easily add new types of modifiers (like GPU vs. CPU testing
1383         for graphics tests, or 32-bit vs. 64-bit differences).
1384
1385         This is the first of two patches that will add in more generic
1386         support and then eliminate the GPU-specific test expectations
1387         files for Chromium.
1388
1389         This patch adds two standalone objects for handling modifiers. The
1390         rules for interpreting modifiers, precedence, and conflicts are
1391         given in the docstring to the ModifierMatcher class, which
1392         returns ModifierMatchResult objects.
1393         
1394         This patch also adds routines to the Port interface and a
1395         default set of values in the base object, in order to obtain the
1396         values needed on a given test run. These values are then passed
1397         to the expectation parser. This also allows us to clean up the
1398         logic used to lint all of the different configurations in a
1399         single test_expectations.txt file.
1400
1401         The next patch will merge in the separate GPU expectations file.
1402
1403         https://bugs.webkit.org/show_bug.cgi?id=51222
1404
1405         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1406         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1407         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1408         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1409         * Scripts/webkitpy/layout_tests/port/base.py:
1410         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1411         * Scripts/webkitpy/layout_tests/port/chromium.py:
1412         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1413         * Scripts/webkitpy/layout_tests/port/test.py:
1414         * Scripts/webkitpy/layout_tests/port/webkit.py:
1415         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1416         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1417         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1418         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
1419         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1420
1421 2011-01-31  Scott Cameron  <sccameron@rim.com>
1422
1423         Reviewed by Daniel Bates.
1424
1425         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
1426         https://bugs.webkit.org/show_bug.cgi?id=50036
1427
1428         This will add an Apache2.2 configuration file and modifies scripts to allow
1429         running an httpd server in an MSYS environment.
1430
1431         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
1432         in order to allow for simple installation/execution.  Simply install the latest
1433         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
1434         be able to execute run-webkit-httpd.
1435         
1436
1437         * Scripts/run-webkit-httpd:
1438         * Scripts/webkitperl/httpd.pm:
1439
1440 2011-01-31  Tony Chang  <tony@chromium.org>
1441
1442         Reviewed by Eric Seidel.
1443
1444         mac DRT should report RTL scroll offset relative to top right corner
1445         https://bugs.webkit.org/show_bug.cgi?id=53324
1446
1447         * DumpRenderTree/mac/DumpRenderTree.mm:
1448         (dumpFrameScrollPosition):
1449
1450 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
1451
1452         Reviewed by Andreas Kling.
1453
1454         [Qt] Add Take Screen Shot action to MiniBrowser
1455         https://bugs.webkit.org/show_bug.cgi?id=53422
1456
1457         Add Take Screen Shot action to MiniBrowser's view menu.
1458
1459         * MiniBrowser/qt/BrowserWindow.cpp:
1460         (BrowserWindow::BrowserWindow):
1461         (BrowserWindow::screenshot):
1462         * MiniBrowser/qt/BrowserWindow.h:
1463
1464 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1465
1466         Reviewed by Xan Lopez.
1467
1468         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
1469         https://bugs.webkit.org/show_bug.cgi?id=53379
1470
1471         Remove left over #ifdef's. I thought all of the conditional code
1472         had been freed from the condition, but I forgot to check DRT.
1473
1474         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1475         (resetDefaultsToConsistentValues):
1476         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1477         (LayoutTestController::setAlwaysAcceptCookies):
1478
1479 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1480
1481         Unreviewed, build fix.
1482
1483         Fix regression introduced in r77093 - path.rsplit() doesn't
1484         take keyword arguments.
1485
1486         https://bugs.webkit.org/show_bug.cgi?id=53326
1487
1488         * Scripts/webkitpy/common/system/filesystem_mock.py:
1489
1490 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1491
1492         Reviewed by Mihai Parparita.
1493
1494         Add more unit tests for rebaseline-chromium-webkit-tests. This
1495         change involves restructuring a bunch of r-c-w-t code to make it
1496         more testable as well. We also add wrapper classes for handling
1497         testing zip files and fetching URLs.
1498
1499         https://bugs.webkit.org/show_bug.cgi?id=53040
1500
1501         * Scripts/webkitpy/common/system/urlfetcher.py:
1502         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
1503         * Scripts/webkitpy/common/system/zipfileset_mock.py:
1504         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1505         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1506         * Scripts/webkitpy/tool/mocktool.py:
1507
1508 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1509
1510         Reviewed by Eric Seidel.
1511
1512         Clean up of the filesystem-related modules used in webkitpy.
1513         I've added relpath() to the filesystem interface, modified
1514         ospath.relpath() so that it could work with the filesystem
1515         interface, and modified the fileset* routines to use the
1516         filesystem interface consistently.
1517
1518         This patch also adds a close() routine to the fileset routines
1519         to indicate that the caller is done with the fileset. This
1520         allows zipfileset to clean up after itself when it creates
1521         tempfiles to store downloads.
1522
1523         https://bugs.webkit.org/show_bug.cgi?id=53326
1524
1525         * Scripts/webkitpy/common/system/directoryfileset.py:
1526         * Scripts/webkitpy/common/system/fileset.py:
1527         * Scripts/webkitpy/common/system/filesystem.py:
1528         * Scripts/webkitpy/common/system/filesystem_mock.py:
1529         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1530         * Scripts/webkitpy/common/system/ospath.py:
1531         * Scripts/webkitpy/common/system/zipfileset.py:
1532         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1533
1534 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
1535
1536         Reviewed by Csaba Osztrogonác.
1537
1538         [Qt][WK2]REGRESSION (r76991): Fix build errors
1539         https://bugs.webkit.org/show_bug.cgi?id=53400
1540
1541         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
1542         and remove WebKit2Prefix.h from the build.
1543         * MiniBrowser/qt/MiniBrowser.pro:
1544
1545 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
1546
1547         Unreviewed.
1548
1549         [Qt][WK2] Buildfix.
1550
1551         * MiniBrowser/qt/MiniBrowser.pro:
1552
1553 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
1554
1555         Reviewed by Adam Roben.
1556         
1557         define NOMINMAX when building ImageDiff, as we do elsewhere.
1558
1559         Add various clampToInt() methods to MathExtras.h
1560         https://bugs.webkit.org/show_bug.cgi?id=52910
1561
1562         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1563
1564 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
1565
1566         Reviewed by Darin Adler.
1567
1568         WebKitTestRunner needs layoutTestController.setPOSIXLocale
1569         https://bugs.webkit.org/show_bug.cgi?id=42682
1570
1571         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1572         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1573         (WTR::InjectedBundle::resetLocalSettings):
1574         (WTR::InjectedBundle::didReceiveMessage):
1575         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1576         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1577         (WTR::LayoutTestController::setPOSIXLocale):
1578         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1579
1580 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1581  
1582          Reviewed by Mihai Parparita.
1583  
1584          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
1585  
1586          This patch re-enables this test and changes it to
1587          handle all of the mac platform versions, not just the one
1588          it is running on.
1589  
1590          https://bugs.webkit.org/show_bug.cgi?id=53356
1591  
1592          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1593  
1594 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1595
1596         Unreviewed, build fix.
1597
1598         Take two. The fix in 77023 didn't work, because we were
1599         still calling path.abspath_to_uri, which calls _cygpath under
1600         the covers, and it appears the cygpath on the bots does
1601         something different than it does on my machine. This patch
1602         removes the calls to path.abspath_to_uri, so it should be safe.
1603         If it doesn't work, I'll roll it out along with r76982 and 77023.
1604
1605         https://bugs.webkit.org/show_bug.cgi?id=53126
1606
1607         * Scripts/webkitpy/layout_tests/port/test.py:
1608
1609 2011-01-28  David Kilzer  <ddkilzer@apple.com>
1610
1611         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
1612         <http://webkit.org/b/53353>
1613
1614         Reviewed by Mark Rowe.
1615
1616         * Scripts/webkitdirs.pm:
1617         (checkRequiredSystemConfig): Check the Xcode marketing version
1618         in addition to the DevCoreTools build version before complaining
1619         about an old version of Xcode.  Also make the Mac OS X version
1620         check use Perl's built-in version string comparitor.
1621
1622 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1623
1624         Unreviewed, build fix.
1625
1626         Work around breakage on Win 7 Release bot caused by r76982
1627         and the fact that windows ports use "file:////" instead of
1628         "file:///". Ideally the test code should be isolated from
1629         this, but it isn't yet. Will fix properly in a bit.
1630
1631         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1632
1633 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1634
1635         Reviewed by Tony Chang.
1636
1637         new-run-webkit-tests: change worker model values to
1638         "old-inline", "old-threads" in preparation for test_runner2 /
1639         multiprocessing changes.
1640
1641         https://bugs.webkit.org/show_bug.cgi?id=53156
1642
1643         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1644         * Scripts/webkitpy/layout_tests/port/base.py:
1645         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1646         * Scripts/webkitpy/layout_tests/port/mac.py:
1647         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1648
1649 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1650
1651         Reviewed by Tony Chang.
1652
1653         committers.py - add an IRC nickname for dpranke
1654         https://bugs.webkit.org/show_bug.cgi?id=53335
1655
1656         * Scripts/webkitpy/common/config/committers.py:
1657
1658 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1659
1660         Reviewed by Tony Chang.
1661
1662         new-run-webkit-tests: add a "mock DRT" port implementation
1663         and a separate class that emulates what we expect the
1664         DumpRenderTree behavior to be.
1665
1666         This will eventually replace port/dryrun.py and allow us to get
1667         better test coverage of the new-run-webkit-tests code as well as
1668         a reference for what new-run-webkit-tests expects from DRT.
1669
1670         This is the first attempt at this, and it is pretty bare-boned. It
1671         really only has been tested on the 'mac' port (and a little on
1672         the 'chromium-mac' port.
1673
1674         https://bugs.webkit.org/show_bug.cgi?id=53126
1675
1676         * Scripts/webkitpy/common/system/filesystem_mock.py:
1677         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1678         * Scripts/webkitpy/layout_tests/port/factory.py:
1679         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1680         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1681         * Scripts/webkitpy/layout_tests/port/test.py:
1682
1683 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1684
1685         Unreviewed. Removing .swp file checked in by mistake.
1686
1687         * Scripts/.webkitdirs.pm.swp: Removed.
1688
1689 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1690
1691         Reviewed by David Kilzer.
1692
1693         Space not necessary for undefined feature
1694         https://bugs.webkit.org/show_bug.cgi?id=53317
1695
1696         * Scripts/build-webkit:
1697
1698 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1699
1700         Reviewed by Andreas Kling.
1701
1702         Reset NetworkAccessManager to clean up credentials from previous tests.
1703         This change causes no performance overhead either.
1704         https://bugs.webkit.org/show_bug.cgi?id=36688
1705
1706         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1707         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1708         (WebCore::DumpRenderTree::open):
1709         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1710
1711 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1712
1713         Reviewed by Andreas Kling.
1714
1715         [Qt] Add Zoom Text Only action to MiniBrowser
1716         https://bugs.webkit.org/show_bug.cgi?id=53297
1717
1718         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1719
1720         * MiniBrowser/qt/BrowserWindow.cpp:
1721         (BrowserWindow::BrowserWindow):
1722         (BrowserWindow::zoomIn):
1723         (BrowserWindow::zoomOut):
1724         (BrowserWindow::resetZoom):
1725         (BrowserWindow::toggleZoomTextOnly):
1726         (BrowserWindow::applyZoom):
1727         * MiniBrowser/qt/BrowserWindow.h:
1728
1729 2011-01-28  Adam Barth  <abarth@webkit.org>
1730
1731         Reviewed by Eric Seidel.
1732
1733         Add webkit-patch roll-chromium-deps
1734         https://bugs.webkit.org/show_bug.cgi?id=53288
1735
1736         This command updates the Source/WebKit/chromium/DEPS file with the
1737         last-known good revision of Chromium (or a revision specified on the
1738         command line).  I'd eventually like to turn this into a SheriffBot
1739         command, but this is the first step.
1740
1741         This patch somewhat sprawled because I needed to move a bunch of code
1742         out of ChangeLog that should never have been there in the first place.
1743         Also, I had to fix a bug in MockUser in order to test the new command.
1744
1745         * Scripts/webkitpy/common/checkout/api.py:
1746         * Scripts/webkitpy/common/checkout/changelog.py:
1747         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1748         * Scripts/webkitpy/common/checkout/deps.py: Added.
1749         * Scripts/webkitpy/common/config/urls.py:
1750         * Scripts/webkitpy/tool/commands/__init__.py:
1751         * Scripts/webkitpy/tool/commands/download_unittest.py:
1752         * Scripts/webkitpy/tool/commands/roll.py: Added.
1753         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1754         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1755         * Scripts/webkitpy/tool/mocktool.py:
1756         * Scripts/webkitpy/tool/steps/__init__.py:
1757         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1758         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1759         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1760         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1761         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1762         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1763
1764 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1765
1766         Reviewed by Laszlo Gombos.
1767
1768         Get rid of prefix header dependency for WebKit2 build system
1769         https://bugs.webkit.org/show_bug.cgi?id=50174
1770
1771         Change the style checker so that it enforces config.h include for
1772         WebKit2.
1773
1774         * Scripts/webkitpy/style/checker.py:
1775
1776 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1777
1778         Reviewed by Darin Adler.
1779
1780         execCommand("Paste") doesn't work in WebKitTestRunner
1781         https://bugs.webkit.org/show_bug.cgi?id=52785
1782
1783         Enable both of the settings needed to allow paste.
1784         
1785         * WebKitTestRunner/TestController.cpp:
1786         (WTR::TestController::resetStateToConsistentValues):
1787
1788 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1789
1790         Reviewed by Andreas Kling.
1791
1792         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1793         https://bugs.webkit.org/show_bug.cgi?id=48440
1794
1795         Preserve user input when toggling use of QGraphicsView
1796
1797         * QtTestBrowser/launcherwindow.cpp:
1798         (LauncherWindow::initializeView):
1799         (LauncherWindow::loadFinished):
1800         * QtTestBrowser/launcherwindow.h:
1801         * QtTestBrowser/mainwindow.cpp:
1802         (MainWindow::addressUrl):
1803         * QtTestBrowser/mainwindow.h:
1804
1805 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1806
1807         Reviewed by Mihai Parparita.
1808
1809         new-run-webkit-tests: turn off pixel tests correctly by default
1810         for webkit-based ports. r70013 (bug 47510) used
1811         port.set_option_default() to attempt to set default values, but
1812         that didn't work correctly. I have removed set_option_default
1813         for now since it was only being used in two places and in three
1814         useless unit tests. There is a separate bug open to fix the
1815         option parsing (48095), so this workaround is fine for now.
1816
1817         https://bugs.webkit.org/show_bug.cgi?id=53217
1818
1819         * Scripts/webkitpy/layout_tests/port/webkit.py:
1820         * Scripts/webkitpy/layout_tests/port/base.py:
1821         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1822
1823 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1824
1825         Rubber-stamped by Ariya Hidayat.
1826
1827         Trivial crash fix in WTR.
1828
1829         * WebKitTestRunner/TestController.cpp:
1830         (WTR::TestController::initialize): Increase the size
1831         of the vector by one to be able to store the null character.
1832
1833 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1834
1835         Reviewed by Csaba Osztrogonác.
1836
1837         [Qt][WK2] WTR should be initialized in the same way as DRT
1838         https://bugs.webkit.org/show_bug.cgi?id=53240
1839
1840         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1841         (WTR::activateFonts): Added missing initialization steps.
1842
1843 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1844
1845         Unreviewed. 
1846
1847         Adding myself to committers.py.
1848
1849         * Scripts/webkitpy/common/config/committers.py:
1850
1851 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1852
1853         Reviewed by Csaba Osztrogonác.
1854
1855         [Qt] [Symbian] Move project files into Source
1856         https://bugs.webkit.org/show_bug.cgi?id=52891
1857
1858         Fix the Symbian build after the project files
1859         are moved to Source directory. On Symbian qmake
1860         needs to run in the same directory where the main
1861         pro files (WebKit.pro, Tools.pro) are located.
1862
1863         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1864         is located before running qmake for Symbian. Qmake on Symbian
1865         does not properly honor the "-o" option, work it around by setting
1866         the name of the Makefile to bld.inf.
1867
1868 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1869
1870         Reviewed by Andreas Kling.
1871
1872         [Qt] Add simple zooming features to MiniBrowser
1873         https://bugs.webkit.org/show_bug.cgi?id=53231
1874
1875         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1876
1877         * MiniBrowser/qt/BrowserWindow.cpp:
1878         (BrowserWindow::BrowserWindow):
1879         (BrowserWindow::zoomIn):
1880         (BrowserWindow::zoomOut):
1881         (BrowserWindow::resetZoom):
1882         (BrowserWindow::updateUserAgentList):
1883         (BrowserWindow::applyZoom):
1884         * MiniBrowser/qt/BrowserWindow.h:
1885
1886 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1887
1888         Reviewed by Dan Bernstein.
1889
1890         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1891         https://bugs.webkit.org/show_bug.cgi?id=42319
1892         
1893         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1894
1895         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1896         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1897         (WTR::LayoutTestController::showWebInspector):
1898         (WTR::LayoutTestController::closeWebInspector):
1899         (WTR::LayoutTestController::evaluateInWebInspector):
1900         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1901         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1902         * WebKitTestRunner/TestInvocation.cpp:
1903         (WTR::shouldOpenWebInspector):
1904         (WTR::TestInvocation::invoke):
1905         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1906
1907 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1908
1909         Reviewed by Xan Lopez.
1910
1911         [GTK] Pixel dumps do not include scrollbars in output images
1912         https://bugs.webkit.org/show_bug.cgi?id=53216
1913
1914         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1915         that have scrollbars.
1916
1917         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1918         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1919         instead of the web view itself.
1920
1921 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1922
1923         Reviewed by Mihai Parparita.
1924
1925         Fix regression introduced in r76322 ... new-run-webkit-tests
1926         was attempting to save the image diff output as a UTF-8-encoded
1927         file.
1928
1929         https://bugs.webkit.org/show_bug.cgi?id=53210
1930
1931         * Scripts/webkitpy/layout_tests/port/webkit.py:
1932
1933 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1934
1935         Unreviewed, rolling out r76709.
1936         http://trac.webkit.org/changeset/76709
1937         https://bugs.webkit.org/show_bug.cgi?id=53194
1938
1939         "broke python tests on non-snowleopard platforms" (Requested
1940         by dpranke on #webkit).
1941
1942         * Scripts/webkitpy/layout_tests/port/factory.py:
1943         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1944         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1945
1946 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1947
1948         Reviewed by Tony Chang.
1949
1950         new-run-webkit-tests: add a "mock DRT" port implementation
1951         and a separate class that emulates what we expect the
1952         DumpRenderTree behavior to be.
1953
1954         This will eventually replace port/dryrun.py and allow us to get
1955         better test coverage of the new-run-webkit-tests code as well as
1956         a reference for what new-run-webkit-tests expects from DRT.
1957
1958         This is the first attempt at this, and it is pretty bare-boned. It
1959         really only has been tested on the 'mac' port (and a little on
1960         the 'chromium-mac' port.
1961
1962         https://bugs.webkit.org/show_bug.cgi?id=53126
1963
1964         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1965         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1966         * Scripts/webkitpy/layout_tests/port/factory.py:
1967
1968 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1969
1970         Reviewed by Tony Chang.
1971
1972         Add '--no-timeout' option to Chromium DRT to ease debugging.
1973         https://bugs.webkit.org/show_bug.cgi?id=52873
1974
1975         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1976         (main):
1977
1978 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1979
1980         Reviewed by Andreas Kling.
1981
1982         [Qt] Fix qt_minimal build
1983         https://bugs.webkit.org/show_bug.cgi?id=53172
1984
1985         * QtTestBrowser/locationedit.h:
1986
1987 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1988
1989         Reviewed by Antonio Gomes.
1990
1991         QtTestBrowser should have a UI Setting to disable plugins
1992         https://bugs.webkit.org/show_bug.cgi?id=52408
1993         
1994         Added a new action item named "Disable Plugins"
1995         under the "Settings" menu. 
1996
1997         * QtTestBrowser/launcherwindow.cpp:
1998         (LauncherWindow::createChrome):
1999         (LauncherWindow::togglePlugins):
2000         * QtTestBrowser/launcherwindow.h:
2001
2002 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
2003
2004         Reviewed by Adam Barth.
2005
2006         Move main CMakeLists.txt into Source directory
2007         https://bugs.webkit.org/show_bug.cgi?id=52888
2008
2009         * Scripts/webkitdirs.pm:
2010
2011 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
2012
2013         Reviewed by Eric Seidel.
2014
2015         Improve label text in submit-to-ews
2016         https://bugs.webkit.org/show_bug.cgi?id=53130
2017
2018         * QueueStatusServer/templates/submittoews.html:
2019
2020 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
2021
2022         Reviewed by Antonio Gomes.
2023
2024         QtTestBrowser should have a UI Settings to prevent loading images
2025         https://bugs.webkit.org/show_bug.cgi?id=52409
2026         
2027         Added a new action item named "DisableAutoLoadImages"
2028         under the "Settings" menu 
2029
2030         * QtTestBrowser/launcherwindow.cpp:
2031         (LauncherWindow::createChrome):
2032         (LauncherWindow::toggleAutoLoadImages):
2033         * QtTestBrowser/launcherwindow.h:
2034
2035 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
2036
2037         Reviewed by Tony Chang.
2038
2039         Minor bug fixes and cleanup for filesystem wrappers, port/* test
2040         classes, test_expectations.py. This change adds "test-win" and
2041         "test-mac" variants to the test port so that we can better test
2042         rebaselining, and adds a MockUser() object for reuse in testing.
2043
2044         https://bugs.webkit.org/show_bug.cgi?id=53036
2045
2046         * Scripts/webkitpy/common/system/filesystem.py:
2047         * Scripts/webkitpy/common/system/filesystem_mock.py:
2048         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2049         * Scripts/webkitpy/layout_tests/port/factory.py:
2050         * Scripts/webkitpy/layout_tests/port/base.py:
2051         * Scripts/webkitpy/layout_tests/port/test.py:
2052         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2053         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2054         * Scripts/webkitpy/tool/mocktool.py:
2055
2056 2011-01-25  Tony Chang  <tony@chromium.org>
2057
2058         Reviewed by Dimitri Glazkov.
2059
2060         [chromium] remove unused layoutTestController callback
2061         https://bugs.webkit.org/show_bug.cgi?id=53103
2062
2063         This method is used by a test_shell_test, but not needed by DRT.
2064
2065         * DumpRenderTree/chromium/LayoutTestController.cpp:
2066         (LayoutTestController::LayoutTestController):
2067         * DumpRenderTree/chromium/LayoutTestController.h:
2068
2069 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2070
2071         Reviewed by Andreas Kling.
2072
2073         [GTK] Remove 64 bits release bot from the buildbot master
2074         https://bugs.webkit.org/show_bug.cgi?id=52899
2075
2076         Removes the 64 bits release slave from the buildbot configuration,
2077         so that we can use it as an EWS.
2078
2079         * BuildSlaveSupport/build.webkit.org-config/config.json:
2080
2081 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2082
2083         Reviewed by Dan Bernstein.
2084
2085         Implement database quota callback to fix storage tests on WebKit2 bot
2086         https://bugs.webkit.org/show_bug.cgi?id=53064
2087
2088         * WebKitTestRunner/TestController.cpp:
2089         (WTR::exceededDatabaseQuota):
2090         (WTR::TestController::createOtherPage):
2091         (WTR::TestController::initialize):
2092
2093 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2094
2095         Reviewed by Anders Carlsson.
2096
2097         Use designated temp directory for the database for WebKit2
2098         https://bugs.webkit.org/show_bug.cgi?id=53052
2099         
2100         Adopt the new WK2 API for this.
2101
2102         * WebKitTestRunner/TestController.cpp:
2103         (WTR::TestController::libraryPathForTesting):
2104         (WTR::TestController::initialize):
2105         * WebKitTestRunner/TestController.h:
2106         * WebKitTestRunner/mac/TestControllerMac.mm:
2107         (WTR::TestController::platformLibraryPathForTesting):
2108         * WebKitTestRunner/qt/TestControllerQt.cpp:
2109         (WTR::TestController::platformLibraryPathForTesting):
2110         * WebKitTestRunner/win/TestControllerWin.cpp:
2111         (WTR::TestController::platformLibraryPathForTesting):
2112
2113 2011-01-24  Lucas Forschler  <lforschler@apple.com>
2114
2115         Reviewed by Stephanie Lewis.
2116
2117         Add a new Leopard test bot.
2118
2119         * BuildSlaveSupport/build.webkit.org-config/config.json:
2120
2121 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2122
2123         Reviewed by Adam Barth.
2124
2125         Add EFL Builder to core waterfall
2126         https://bugs.webkit.org/show_bug.cgi?id=52704
2127
2128         Add EFL Builder to the core waterfall again.
2129
2130         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2131         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2132
2133 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
2134
2135         Reviewed by Tony Chang.
2136
2137         new-run-webkit-tests fails to start HTTP server if there are proxy settings
2138         https://bugs.webkit.org/show_bug.cgi?id=52872
2139
2140         Force disabling proxy to resolve the problem.
2141
2142         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2143         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2144
2145 2011-01-24  Andreas Kling  <kling@webkit.org>
2146
2147         Reviewed by Darin Adler.
2148
2149         check-webkit-style: Update exemptions following Source/ move.
2150         https://bugs.webkit.org/show_bug.cgi?id=53017
2151
2152         * Scripts/webkitpy/style/checker.py:
2153         * Scripts/webkitpy/style/checker_unittest.py:
2154
2155 2011-01-24  Andras Becsi  <abecsi@webkit.org>
2156
2157         Rubber-stamped by Csaba Osztrogonác.
2158
2159         [Qt] Move project files into Source
2160         https://bugs.webkit.org/show_bug.cgi?id=52891
2161
2162         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
2163
2164 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
2165
2166         Reviewed by Yury Semikhatsky.
2167
2168         Web Inspector: Find duplicate strings in localizedStrings.js
2169
2170         https://bugs.webkit.org/show_bug.cgi?id=53005
2171
2172         * Scripts/check-inspector-strings:
2173
2174 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
2175
2176         Reviewed by Andreas Kling.
2177
2178         [Qt] Regroup MiniBrowser's menubar and add open file action
2179         https://bugs.webkit.org/show_bug.cgi?id=53000
2180
2181         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
2182
2183         * MiniBrowser/qt/BrowserWindow.cpp:
2184         (BrowserWindow::BrowserWindow):
2185         (BrowserWindow::openFile):
2186         (BrowserWindow::~BrowserWindow):
2187         * MiniBrowser/qt/BrowserWindow.h:
2188
2189 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
2190
2191         Unreviewed fix after r76496
2192
2193         [Qt] Move project files into Source
2194         https://bugs.webkit.org/show_bug.cgi?id=52891
2195
2196         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
2197         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
2198         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
2199
2200 2011-01-24  Andras Becsi  <abecsi@webkit.org>
2201
2202         Reviewed by Csaba Osztrogonác.
2203
2204         [Qt] Move project files into Source
2205         https://bugs.webkit.org/show_bug.cgi?id=52891
2206
2207         * DerivedSources.pro: Renamed from DerivedSources.pro.
2208         * DumpRenderTree/qt/DumpRenderTree.pro:
2209         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2210         * MiniBrowser/DerivedSources.pro:
2211         * MiniBrowser/qt/MiniBrowser.pro:
2212         * QtTestBrowser/QtTestBrowser.pro:
2213         * Scripts/webkitdirs.pm:
2214         * Tools.pro: Added.
2215         * WebKitTestRunner/DerivedSources.pro:
2216         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2217         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2218
2219 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
2220
2221         Reviewed by Dan Bernstein.
2222
2223         Beefed up --threaded mode to catch even more kinds of errors.
2224         https://bugs.webkit.org/show_bug.cgi?id=52971
2225
2226         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
2227         context group to force JSC to mark multiple threads. (This used to be
2228         the default, but it changed in SnowLeopard.)
2229         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
2230         to give threading mistakes more chances to show themselves.
2231         (startJavaScriptThreads):
2232         (stopJavaScriptThreads):
2233
2234 2011-01-22  Robert Hogan  <robert@webkit.org>
2235
2236         Reviewed by Andreas Kling.
2237
2238         [Qt] Support layoutTestController.addURLToRedirect()
2239         https://bugs.webkit.org/show_bug.cgi?id=52956
2240
2241         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2242         (LayoutTestController::addURLToRedirect):
2243         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2244
2245 2011-01-22  Robert Hogan  <robert@webkit.org>
2246
2247         Reviewed by Kenneth Rohde Christiansen.
2248
2249         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
2250         https://bugs.webkit.org/show_bug.cgi?id=49802
2251
2252         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2253         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2254         (WebCore::DumpRenderTree::open):
2255
2256 2011-01-21  Adam Barth  <abarth@webkit.org>
2257
2258         Reviewed by Maciej Stachowiak.
2259
2260         Disable mac_unittest.py that fails on some of the Mac bots
2261         https://bugs.webkit.org/show_bug.cgi?id=52947
2262
2263         As noted in the comment, this test does not appear to be correct
2264         because the function this test is testing returns different results
2265         depending on which flavor of Mac the test is run on.  This patch
2266         disable the test.  Hopefully we can re-enable the test once we've
2267         probably insulated the test from its environment.
2268
2269         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2270
2271 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
2272
2273         Reviewed by Mihai Parparita.
2274
2275         Fix bug introduced in r76322 that caused NRWT to not actually
2276         read the Skipped files properly.
2277
2278         https://bugs.webkit.org/show_bug.cgi?id=52771
2279
2280         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2281         * Scripts/webkitpy/layout_tests/port/webkit.py:
2282         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2283
2284 2011-01-21  Sam Weinig  <sam@webkit.org>
2285
2286         Reviewed by Geoffrey Sean Garen and Mark Rowe.
2287
2288         WebKitTestRunner needs the HOME environment variable to be set.
2289         <rdar://problem/8896573>
2290
2291         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
2292         it exists.
2293
2294 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
2295
2296         Reviewed by Eric Seidel.
2297
2298         Suppress a few remaining integration tests so that none of the
2299         layout_test unit tests ever read from the filesystem or launch
2300         subprocesses that aren't part of the unit tests.
2301
2302         Also fix a minor bug in the printing unit tests that was
2303         incorrectly relying on sys.argv.
2304
2305         https://bugs.webkit.org/show_bug.cgi?id=52863
2306
2307         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2308         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2309         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2310
2311 2011-01-21  Darin Adler  <darin@apple.com>
2312
2313        Fix Mac build.
2314
2315         * MiniBrowser/mac/BrowserWindowController.m:
2316         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
2317
2318 2011-01-20  Darin Adler  <darin@apple.com>
2319
2320         Reviewed by Dan Bernstein.
2321
2322         WebKit2: Implement showModalDialog
2323         https://bugs.webkit.org/show_bug.cgi?id=52855
2324
2325         This fixes WebKitTestRunner to compile, but more work is probably
2326         needed to get it to pass the tests.
2327
2328         * WebKitTestRunner/TestController.cpp:
2329         (WTR::TestController::runModal): Added. Calls through to the
2330         platform-specific version of runModal.
2331         (WTR::TestController::createOtherPage): Changed to be a private
2332         static member function so it can refer to runModal, which is
2333         a private static member function.
2334         (WTR::TestController::initialize): Pass 0 for the runModal
2335         function since we don't need to run the main window modal.
2336         I suspect this is wrong and will need to change.
2337         * WebKitTestRunner/TestController.h: Added declarations for
2338         the functions added above.
2339         * WebKitTestRunner/mac/TestControllerMac.mm:
2340         (WTR::TestController::runModal): Added. Untested implementation.
2341         * WebKitTestRunner/qt/TestControllerQt.cpp:
2342         (WTR::TestController::runModal): Added.
2343         * WebKitTestRunner/win/TestControllerWin.cpp:
2344         (WTR::TestController::runModal): Added.
2345
2346 2011-01-21  Eric Seidel  <eric@webkit.org>
2347
2348         Reviewed by Adam Barth.
2349
2350         Split Host object off from WebKitPatch for easier re-use
2351         https://bugs.webkit.org/show_bug.cgi?id=52284
2352
2353         new-run-webkit-tests and other tools are eventually going to want one of these.
2354         Basically you need to inherit from this class if you want to pretend to be a
2355         self.tool object for Steps/Commands.
2356
2357         * Scripts/webkitpy/common/host.py: Added.
2358         * Scripts/webkitpy/tool/main.py:
2359
2360 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2361
2362         Reviewed by Adam Barth.
2363
2364         Disable the tests that start and stop the http server and web
2365         server, so that we don't have to worry about port collisions on
2366         the bots.
2367
2368         https://bugs.webkit.org/show_bug.cgi?id=52861
2369
2370         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2371
2372 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2373
2374         Reviewed by Eric Seidel.
2375
2376         nrwt: rewrite google_chrome_unittest to use mock filesystem.
2377         
2378         https://bugs.webkit.org/show_bug.cgi?id=52772
2379         
2380         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2381
2382 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2383
2384         Reviewed by Eric Siedel.
2385
2386         nrwt: clean up almost all remaining port references, remove
2387         unnecessary import clauses. The only remaining references are
2388         in places where a mock filesystem makes no sense or can't be
2389         used, and in one routine in port/google_chrome_unittest that
2390         I'll rewrite in a separate patch.
2391
2392         https://bugs.webkit.org/show_bug.cgi?id=52771
2393
2394         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2395         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2396         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2397         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2398         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2399         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2400         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2401         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2402         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2403         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2404         * Scripts/webkitpy/layout_tests/port/gtk.py:
2405         * Scripts/webkitpy/layout_tests/port/mac.py:
2406         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2407         * Scripts/webkitpy/layout_tests/port/qt.py:
2408         * Scripts/webkitpy/layout_tests/port/webkit.py:
2409         * Scripts/webkitpy/layout_tests/port/win.py:
2410         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2411
2412 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2413
2414         Reviewed by Mihai Parparita.
2415
2416         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
2417
2418         https://bugs.webkit.org/show_bug.cgi?id=52762
2419
2420         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2421         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2422
2423 2011-01-20  Tony Chang  <tony@chromium.org>
2424
2425         Reviewed by Ojan Vafai.
2426
2427         [chromium] fix the paths used for the rebaseline tool
2428         https://bugs.webkit.org/show_bug.cgi?id=52857
2429
2430         Some of the bots were renamed so the path to grab the results zip
2431         file has changed.
2432
2433         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2434
2435 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2436
2437         Reviewed by Tony Chang.
2438
2439         Fix bug introduced in r72688 / bug 52768 that broke the
2440         generation of the output filename links in the results.html
2441         output. Apparently none of the unit tests actually checked to
2442         make sure the generated links were correct :(
2443
2444         https://bugs.webkit.org/show_bug.cgi?id=52854
2445
2446         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2447         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2448
2449 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
2450
2451         Reviewed by Darin Adler.
2452
2453         https://bugs.webkit.org/show_bug.cgi?id=52849
2454         Make window.print work with WebKit2
2455
2456         * MiniBrowser/mac/BrowserWindowController.m:
2457         (-[BrowserWindowController awakeFromNib]):
2458         * WebKitTestRunner/TestController.cpp:
2459         (WTR::createOtherPage):
2460         (WTR::TestController::initialize):
2461         Added zeroes to WKPageUIClient structures to avoid build failures.
2462
2463 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2464
2465         Reviewed by Eric Seidel.
2466
2467         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
2468
2469         https://bugs.webkit.org/show_bug.cgi?id=52756
2470
2471         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2472         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2473         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2474         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2475         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2476         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2477
2478 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
2479
2480         Reviewed by Antonio Gomes.
2481
2482         QtTestBrowser should have a seperate menu for Settings
2483         https://bugs.webkit.org/show_bug.cgi?id=52817
2484         
2485         Added a new menu item named "Settings"
2486         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
2487
2488         * QtTestBrowser/launcherwindow.cpp:
2489         (LauncherWindow::createChrome):
2490
2491 2011-01-20  Sam Weinig  <sam@webkit.org>
2492
2493         Reviewed by John Sullivan.
2494
2495         Update update-webkit-localizable-strings with new path to WebKit.
2496
2497         * Scripts/update-webkit-localizable-strings:
2498
2499 2011-01-20  James Robinson  <jamesr@chromium.org>
2500
2501         Reviewed by Darin Fisher.
2502
2503         Implement mozilla's requestAnimationFrame API
2504         https://bugs.webkit.org/show_bug.cgi?id=51218
2505
2506         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2507
2508         * DumpRenderTree/chromium/WebViewHost.cpp:
2509         (invokeScheduleComposite):
2510         (WebViewHost::scheduleAnimation):
2511         (WebViewHost::paintInvalidatedRegion):
2512         * DumpRenderTree/chromium/WebViewHost.h:
2513
2514 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
2515
2516         Reviewed by Adam Roben.
2517
2518         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
2519         https://bugs.webkit.org/show_bug.cgi?id=42327
2520
2521         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
2522         for methods that take their normal arguments but also a JSContextRef.
2523         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
2524         for evaluateScriptInIsolatedWorld.
2525         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2526         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
2527         this call is for an isolated world.
2528         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2529         (WTR::worldMap): Helper to create a world map.
2530         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
2531         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
2532         added LayoutTestController API.
2533         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2534
2535 2011-01-19  Adam Roben  <aroben@apple.com>
2536
2537         Convert paths in environment variables back to msys-style inside commit-log-editor
2538
2539         When this script gets run from inside git commit, msys-style paths in the environment will
2540         have been turned into Windows-style paths with forward slashes. This screws up functions
2541         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
2542         the paths back to msys-style before doing anything else.
2543
2544         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
2545         using msysgit's Perl and multiple ChangeLogs have been edited
2546
2547         Reviewed by David Kilzer.
2548
2549         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
2550         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
2551         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
2552
2553 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2554
2555         [Win] Unreviewed build fix after r76248.
2556
2557         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
2558
2559 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2560
2561         Reviewed by Csaba Osztrogonác.
2562
2563         Refactoring of the custom allocation framework
2564         https://bugs.webkit.org/show_bug.cgi?id=49897
2565
2566         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
2567         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
2568         equivalent macro implementation at the necessary places.
2569 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
2570
2571         Unreviewed. 
2572
2573         Adding myself to committers.py.
2574
2575         * Scripts/webkitpy/common/config/committers.py:
2576
2577 2011-01-20  Adam Barth  <abarth@webkit.org>
2578
2579         Reviewed by Tony Chang.
2580
2581         Chromium builders don't delete unversioned directories when DEPS change
2582         https://bugs.webkit.org/show_bug.cgi?id=52745
2583
2584         If we pass this option to gclient sync, gclient will delete directories
2585         that are no longer part of DEPS instead of leaving them around to
2586         confuse us later.  Apparently, the downstream buildbots use this option
2587         already.
2588
2589         * Scripts/update-webkit-chromium:
2590
2591 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2592
2593         Unreviewed, build fix - I pulled this patch in to fix an issue
2594         revealed by r76195 running on some new bots). Also fix a couple
2595         of other issues revealed in testing.
2596
2597         nrwt: remove fs refs from layout_package/json*
2598
2599         https://bugs.webkit.org/show_bug.cgi?id=52754
2600
2601         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2602         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2603         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2604         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2605         * Scripts/webkitpy/layout_tests/port/base.py:
2606
2607 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2608
2609         Unreviewed, build fix.
2610
2611         Fix a couple of minor bugs discovered while bringing up new bots
2612         for testing.
2613
2614         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2615         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2616
2617 2011-01-19  James Robinson  <jamesr@chromium.org>
2618
2619         Unreviewed, rolling out r76194.
2620         http://trac.webkit.org/changeset/76194
2621         https://bugs.webkit.org/show_bug.cgi?id=51218
2622
2623         Caused mysterious compile failure on the chromium win
2624         build.webkit.org bots
2625
2626         * DumpRenderTree/chromium/WebViewHost.cpp:
2627         (WebViewHost::paintInvalidatedRegion):
2628         * DumpRenderTree/chromium/WebViewHost.h:
2629
2630 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2631
2632         Reviewed by Mihai Parparita.
2633
2634         remove fs refs from test_runner, dump_render_tree_thread
2635
2636         https://bugs.webkit.org/show_bug.cgi?id=52753
2637
2638         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2639         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2640         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2641         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2642
2643 2011-01-19  James Robinson  <jamesr@chromium.org>
2644
2645         Reviewed by Darin Fisher.
2646
2647         Implement mozilla's requestAnimationFrame API
2648         https://bugs.webkit.org/show_bug.cgi?id=51218
2649
2650         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2651
2652         * DumpRenderTree/chromium/WebViewHost.cpp:
2653         (invokeScheduleComposite):
2654         (WebViewHost::scheduleAnimation):
2655         (WebViewHost::paintInvalidatedRegion):
2656         * DumpRenderTree/chromium/WebViewHost.h:
2657
2658 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2659
2660         Unreviewed, build fix.
2661
2662         Fix a few incorrect "self._filesystem" references introduced in
2663         r76184.
2664
2665         * Scripts/webkitpy/layout_tests/port/chromium.py:
2666         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2667
2668 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2669
2670         Reviewed by Mihai Parparita.
2671
2672         add a .sep property, abspath(), isabs(), mtime(), and
2673         open_text_file_for_writing() to filesystem modules. Some of
2674         these properties are not needed in this patch but will be needed
2675         in subsequent patches (I'm doing this to avoid having to track
2676         multiple versions of a single file).
2677
2678         Also, change most of the port/* modules to use the filesystem
2679         objects instead of referencing the filesystem directly.
2680
2681         https://bugs.webkit.org/show_bug.cgi?id=52748
2682
2683         * Scripts/webkitpy/common/system/filesystem.py:
2684         * Scripts/webkitpy/common/system/filesystem_mock.py:
2685         * Scripts/webkitpy/layout_tests/port/__init__.py:
2686         * Scripts/webkitpy/layout_tests/port/base.py:
2687         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2688         * Scripts/webkitpy/layout_tests/port/chromium.py:
2689         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2690         * Scripts/webkitpy/layout_tests/port/config.py:
2691         * Scripts/webkitpy/layout_tests/port/test.py:
2692         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2693
2694 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2695
2696         Reviewed by Anders Carlsson.
2697
2698         If resetting between tests times out, treat it as a WebProcess crash
2699         https://bugs.webkit.org/show_bug.cgi?id=52757
2700
2701         * WebKitTestRunner/TestController.cpp:
2702         (WTR::TestController::runTest):
2703
2704 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2705
2706         Reviewed by Darin Adler.
2707
2708         https://bugs.webkit.org/show_bug.cgi?id=52739
2709         Make it possible for a WebKit2 client to print headers and footers
2710
2711         Added dummy implementations for new printing UIClient calls.
2712
2713         * MiniBrowser/mac/BrowserWindowController.m:
2714         (-[BrowserWindowController awakeFromNib]):
2715         * WebKitTestRunner/TestController.cpp:
2716         (WTR::createOtherPage):
2717         (WTR::TestController::initialize):
2718
2719 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2720
2721         Reviewed by Ojan Vafai.
2722
2723         Change webkitpy/layout_tests/port/test.py to use the
2724         in-memory filesystem for cleaner unit testing. This
2725         change allows us to kill a lot of code that was
2726         specific to the test port, at the cost of being a
2727         little less clear about how things would work if
2728         you didn't have a filesystem.
2729
2730         https://bugs.webkit.org/show_bug.cgi?id=52605
2731
2732         * Scripts/webkitpy/layout_tests/port/test.py:
2733
2734 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2735
2736         Unreviewed, build fix.
2737
2738         Fix test failure caused by committing attachment 79368 instead
2739         of attachment 79461 on bug 52604.
2740
2741         * Scripts/webkitpy/common/system/filesystem_mock.py:
2742
2743 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2744
2745         Reviewed by Mihai Parparita.
2746
2747         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2748         unit testing. os.walk() is too much of a hassle to implement on
2749         top of the in-memory mock filesystem and adding the necessary
2750         interface to files_under() gives clients a cleaner API anyway
2751         (for this particular usage model).
2752
2753         https://bugs.webkit.org/show_bug.cgi?id=52691
2754
2755         * Scripts/webkitpy/common/system/filesystem.py:
2756         * Scripts/webkitpy/common/system/filesystem_mock.py:
2757         * Scripts/webkitpy/layout_tests/port/test_files.py:
2758         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2759
2760 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2761
2762         Reviewed by Tony Chang.
2763
2764         Change more modules in the layout-tests code to use the
2765         filesystem wrapper for cleaner unit testing.
2766
2767         This patch also adds the glob() wrapper to the filesystem
2768         abstraction.
2769         
2770         https://bugs.webkit.org/show_bug.cgi?id=52604
2771
2772         * Scripts/webkitpy/layout_tests/port/test_files.py:
2773         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2774         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2775         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2776         * Scripts/webkitpy/common/system/filesystem.py:
2777         * Scripts/webkitpy/common/system/filesystem_mock.py:
2778
2779 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2780
2781         Unreviewed.
2782
2783         Updating my email addresses and irc nick.
2784
2785         * Scripts/webkitpy/common/config/committers.py:
2786
2787 2011-01-19  Tony Chang  <tony@chromium.org>
2788
2789         Reviewed by Mihai Parparita.
2790
2791         [chromium] [linux] if check-sys-deps fails, output the failure reason
2792         https://bugs.webkit.org/show_bug.cgi?id=52671
2793
2794         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2795             error handler functions.
2796         * Scripts/webkitpy/layout_tests/port/chromium.py:
2797             output the error text from --check-sys-deps
2798         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2799
2800 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2801
2802         Reviewed by Andreas Kling.
2803
2804         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2805         https://bugs.webkit.org/show_bug.cgi?id=52554
2806         
2807         QtNetworkAccessManager is created in a thread and set as
2808         member variable in QWebPage. When the thread is destroyed
2809         the object is still used. So fix will set the object to
2810         NULL once the thread is destroyed.
2811
2812         * QtTestBrowser/launcherwindow.cpp:
2813         (LauncherWindow::~LauncherWindow):
2814
2815 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2816
2817         Rubber stamped by Csaba Osztrogonac
2818
2819         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2820
2821 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2822
2823         Reviewed by Tony Chang.
2824
2825         new-run-webkit-tests: add a --build-directory command line argument
2826
2827         Official Google Chrome builds use a non-standard build directory
2828         location. This patch adds a --build-directory argument that
2829         allows that location to be specified on the command line. Only
2830         Chromium-based builds will use this flag for now, but anyone can
2831         in the future.
2832
2833         There are no unit tests for this since it's difficult to test
2834         until mock filesystems are fully supported in the code. This was
2835         tested by hand for now.
2836
2837         https://bugs.webkit.org/show_bug.cgi?id=52694
2838
2839         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2840         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2841         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2842         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2843
2844 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2845
2846         Not reviewed. Bot fix.
2847
2848         Remove an inadvertently committed debugging print.
2849
2850         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2851         (LayoutTestController::notifyDone):
2852
2853 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2854
2855         Reviewed by Sam Weinig.
2856
2857         WebKitTestRunner should track loading more like DumpRenderTree
2858         https://bugs.webkit.org/show_bug.cgi?id=52692
2859
2860         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2861         This makes some tests that call notifyDone multiple times pass.
2862         
2863         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2864         (WTR::InjectedBundle::InjectedBundle):
2865         (WTR::InjectedBundle::done):
2866         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2867         (WTR::InjectedBundle::topLoadingFrame):
2868         (WTR::InjectedBundle::setTopLoadingFrame):
2869         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2870         (WTR::InjectedBundlePage::InjectedBundlePage):
2871         (WTR::InjectedBundlePage::stopLoading):
2872         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2873         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2874         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2875         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2876         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2877         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2878         (WTR::LayoutTestController::notifyDone):
2879         * WebKitTestRunner/TestController.cpp:
2880         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2881
2882 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2883
2884         Reviewed by Kent Tamura.
2885
2886         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2887         https://bugs.webkit.org/show_bug.cgi?id=52678
2888         
2889         Update path now that WebKit is inside Source.
2890
2891         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2892
2893 2011-01-18  Robert Hogan  <robert@webkit.org>
2894
2895         Reviewed by Simon Hausmann.
2896
2897         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2898         https://bugs.webkit.org/show_bug.cgi?id=44282
2899
2900         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2901         (WebCore::DumpRenderTree::dump):
2902
2903 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2904
2905         Reviewed by Mihai Parparita.
2906
2907         Fix a small race condition that could cause the unit tests for
2908         new-run-webkit-tests to fail in a multithreaded environment.
2909         There was a small window in the code where one thread would
2910         check to see if a thread had raised an exception, do something,
2911         and then check to see if the thread was alive. If the other
2912         thread raised an exception and exited in between these two
2913         steps, the exception would be lost. Flipping the order of the
2914         two checks fixes the race, since we will now always check for an
2915         exception on the thread before exiting.
2916
2917         https://bugs.webkit.org/show_bug.cgi?id=51579
2918
2919         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2920
2921 2011-01-18  Eric Seidel  <eric@webkit.org>
2922
2923         Reviewed by Adam Barth.
2924
2925         commit-queue dies when test archiving fails
2926         https://bugs.webkit.org/show_bug.cgi?id=52617
2927
2928         I looked at the machine and it had 10 archives already
2929         thus find_unused_name was returning None.  I've upped
2930         the limit to 100 (per bug) and tested the case where
2931         find_unused_name returns None (making archive return None).
2932
2933         * Scripts/webkitpy/common/system/workspace.py:
2934         * Scripts/webkitpy/common/system/workspace_unittest.py:
2935         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2936         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2937         * Scripts/webkitpy/tool/commands/queues.py:
2938
2939 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2940
2941         Reviewed by Ojan Vafai.
2942
2943         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2944         filesystem. Also fix a couple of "with" statements missed by
2945         r76050.
2946
2947         https://bugs.webkit.org/show_bug.cgi?id=52487
2948
2949         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2950
2951 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2952
2953         Reviewed by Martin Robinson.
2954
2955         [Gtk] Build fixes for gtk3 build
2956         https://bugs.webkit.org/show_bug.cgi?id=52648
2957
2958         * DumpRenderTree/gtk/EventSender.cpp:
2959         (beginDragWithFilesCallback):
2960
2961 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2962
2963         Reviewed by Mihai Parparita.
2964
2965         Update rebaseline-chromium-webkit-tests to use filesystem objects
2966         instead of direct references to os.path, shutil, tempfile, etc.
2967
2968         This patch doesn't change anything, but will allow subsequent
2969         patches to change the unit tests to no longer use the real
2970         filesystem.
2971
2972         This patch adds a bunch more methods to the filesystem object as
2973         well.
2974
2975         https://bugs.webkit.org/show_bug.cgi?id=52482
2976
2977         * Scripts/webkitpy/common/system/filesystem.py:
2978         * Scripts/webkitpy/common/system/filesystem_mock.py:
2979         * Scripts/webkitpy/tool/commands/queues.py:
2980         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2981         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2982
2983 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2984
2985         Reviewed by Mihai Parparita.
2986
2987         new-run-webkit-tests shouldn't crash when you try to run a
2988         directory containing only skipped files.
2989
2990         https://bugs.webkit.org/show_bug.cgi?id=52478
2991         
2992         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2993         * Scripts/webkitpy/layout_tests/port/test.py:
2994         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2995
2996 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2997
2998         Reviewed by Gustavo Noronha Silva.
2999
3000         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
3001         https://bugs.webkit.org/show_bug.cgi?id=40833
3002
3003         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
3004         GTK+ event sender.
3005         (dragWithFilesDragDataGetCallback): Added.
3006         (dragWithFilesDragEndCallback): Added.
3007         (beginDragWithFilesCallback): Added.
3008
3009 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3010
3011         Reviewed by Adam Barth.
3012
3013         ews: Add additional watcher to efl ews
3014         https://bugs.webkit.org/show_bug.cgi?id=52613
3015
3016         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
3017
3018         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3019
3020 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
3021
3022         Reviewed by Alexey Proskuryakov.
3023
3024         Fix some headers with missing or misspelled #ifndef guards
3025         https://bugs.webkit.org/show_bug.cgi?id=52545
3026
3027         * DumpRenderTree/chromium/TestEventPrinter.h:
3028         * DumpRenderTree/chromium/WebPreferences.h:
3029
3030 2011-01-17  Jessie Berlin  <jberlin@apple.com>
3031
3032         Reviewed by Anders Carlsson.
3033
3034         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
3035         navigating back to an unreachable URL
3036         https://bugs.webkit.org/show_bug.cgi?id=52388
3037
3038         Add a third parameter (unreachableURL) to queueLoadHTMLString.
3039
3040         * DumpRenderTree/LayoutTestController.cpp:
3041         (queueLoadHTMLStringCallback):
3042         (LayoutTestController::queueLoadHTMLString):
3043         (LayoutTestController::queueLoadAlternateHTMLString):
3044         * DumpRenderTree/LayoutTestController.h:
3045
3046         * DumpRenderTree/WorkQueueItem.h:
3047         (LoadHTMLStringItem::LoadHTMLStringItem):
3048
3049         * DumpRenderTree/chromium/LayoutTestController.cpp:
3050         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3051         (WorkItemLoadHTMLString::run):
3052         (LayoutTestController::queueLoadHTMLString):
3053
3054         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3055         (LoadHTMLStringItem::invoke):
3056         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3057         (LoadHTMLStringItem::invoke):
3058         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3059         (LoadHTMLStringItem::invoke):
3060
3061 2011-01-17  Dan Bernstein  <mitz@apple.com>
3062
3063         Rubber-stamped by Mark Rowe.
3064
3065         Update xcodeproj svn:ignore to include xcuserdata.
3066
3067         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
3068         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
3069         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
3070         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3071         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
3072
3073 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
3074
3075         Unreviewed fix after r75908.
3076
3077         Move WebKit into Source
3078         https://bugs.webkit.org/show_bug.cgi?id=52530
3079
3080         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
3081
3082 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
3083
3084         Unreviewed.
3085
3086         Remove accidentally committed debug printing after r75908.
3087
3088         * Scripts/webkitdirs.pm:
3089
3090 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
3091
3092         Unreviewed.
3093
3094         Add myself to committers list
3095         https://bugs.webkit.org/show_bug.cgi?id=52566
3096
3097         * Scripts/webkitpy/common/config/committers.py:
3098
3099 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
3100
3101         Reviewed by Jeremy Orlow.
3102
3103         GeolocationController should call stopUpdating on destruction
3104         https://bugs.webkit.org/show_bug.cgi?id=52216
3105
3106         fast/dom/Geolocation/window-close-crash.html requires that a
3107         Geolocation watch be started in a secondary window. Consequently,
3108         we need to allow geolocation permission and provide a mock
3109         geolocation position for the secondary window's
3110         GeolocationClientMock.
3111
3112         * DumpRenderTree/chromium/LayoutTestController.cpp:
3113         (LayoutTestController::setGeolocationPermission):
3114         (LayoutTestController::setMockGeolocationPosition):
3115         (LayoutTestController::setMockGeolocationError):
3116         * DumpRenderTree/chromium/TestShell.h:
3117         (TestShell::windowList):
3118
3119 2011-01-16  Adam Barth  <abarth@webkit.org>
3120
3121         Update more include paths to reflect WebKit move.
3122
3123         * DumpRenderTree/chromium/EventSender.cpp:
3124         (EventSender::keyDown):
3125         (EventSender::needsShiftModifier):
3126         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3127         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3128
3129 2011-01-16  Kent Tamura  <tkent@chromium.org>
3130
3131         Unreviewed, Chromium build fix.
3132
3133         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
3134
3135 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
3136
3137         Build fix for GTK+ after source directory movement.
3138
3139         * GNUmakefile.am: Correct include paths.
3140
3141 2011-01-16  Adam Barth  <abarth@webkit.org>
3142
3143         Teach svn-apply about WebKit move.
3144
3145         * Scripts/VCSUtils.pm:
3146
3147 2011-01-16  Adam Barth  <abarth@webkit.org>
3148
3149         Rubber-stamped by Eric Seidel.
3150
3151         Move WebKit into Source
3152         https://bugs.webkit.org/show_bug.cgi?id=52530
3153
3154         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3155         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3156         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3157         * DumpRenderTree/qt/GCControllerQt.cpp:
3158         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3159         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
3160         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3161         * DumpRenderTree/wscript:
3162         * QtTestBrowser/launcherwindow.h:
3163         * Scripts/build-webkit:
3164         * Scripts/webkitdirs.pm:
3165
3166 2011-01-15  Adam Barth  <abarth@webkit.org>
3167
3168         Teach svn-apply about WebKit2 move.
3169
3170         * Scripts/VCSUtils.pm:
3171
3172 2011-01-15  Adam Barth  <abarth@webkit.org>
3173
3174         Rubber-stamped by Eric Seidel.
3175
3176         Move WebKit2 into Source
3177         https://bugs.webkit.org/show_bug.cgi?id=52438
3178
3179         * MiniBrowser/qt/MiniBrowser.pro:
3180         * Scripts/build-webkit:
3181         * Scripts/do-file-rename:
3182         * Scripts/do-webcore-rename:
3183         * Scripts/test-webkitpy:
3184         * Scripts/webkitdirs.pm:
3185         * Scripts/webkitpy/style/checker.py:
3186         * WebKitTestRunner/DerivedSources.pro:
3187         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3188         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3189
3190 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
3191
3192         Reviewed by David Levin.
3193
3194         [chromium] remove obsolete createView method
3195         https://bugs.webkit.org/show_bug.cgi?id=52437
3196
3197         * DumpRenderTree/chromium/WebViewHost.cpp:
3198         (WebViewHost::createView):
3199         * DumpRenderTree/chromium/WebViewHost.h:
3200
3201 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
3202
3203         Reviewed by Geoff Garen.
3204
3205         ShouldLoadResourceForFrame should use strings, not URLs.
3206         https://bugs.webkit.org/show_bug.cgi?id=52476
3207
3208         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3209         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
3210         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3211
3212 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
3213
3214         Reviewed by David Levin.
3215
3216         Add Tony Gentilcore as a reviewer
3217         https://bugs.webkit.org/show_bug.cgi?id=52480
3218
3219         * Scripts/webkitpy/common/config/committers.py:
3220
3221 2011-01-14  David Levin  <levin@chromium.org>
3222
3223         Reviewed by Eric Seidel.
3224
3225         check-webkit-style: _FunctionState should keep track of where the function name starts.
3226         https://bugs.webkit.org/show_bug.cgi?id=52454
3227
3228         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
3229         _FunctionState and logic for setting it correctly.
3230         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
3231
3232 2011-01-14  Vincent Scheib  <scheib@chromium.org>
3233
3234         Reviewed by David Levin.
3235
3236         Add support to DumpRenderTree to use the GPU rather than software renderer
3237         https://bugs.webkit.org/show_bug.cgi?id=52333
3238
3239         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3240         (main):
3241         * Scripts/webkitpy/layout_tests/port/chromium.py:
3242         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3243
3244 2011-01-14  Tony Chang  <tony@chromium.org>
3245
3246         Reviewed by Kent Tamura.
3247
3248         [chromium] update fonts.conf to fix 6 linux tests in drt
3249         https://bugs.webkit.org/show_bug.cgi?id=52411
3250
3251         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
3252             chromium's src/webkit/tools/test_shell/resources/fonts.conf
3253
3254 2011-01-14  Eric Seidel  <eric@webkit.org>
3255
3256         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
3257
3258         Reviewed by Adam Barth.
3259
3260         Fix when running Tools/Scripts/check-webkit-style without arguments.
3261         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
3262
3263         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
3264         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3265
3266 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
3267
3268         Reviewed by David Levin.
3269
3270         Store the tempdir object in a variable so it doesn't get deleted too early.
3271         https://bugs.webkit.org/show_bug.cgi?id=51875
3272
3273         * Scripts/update-webkit-auxiliary-libs:
3274         * Scripts/update-webkit-support-libs:
3275
3276 2011-01-14  Eric Seidel  <eric@webkit.org>
3277
3278         Unreviewed.  Make it work in python 2.5.
3279
3280         webkit-patch suggest-reviewers dies when ChangeLogs are missing
3281         https://bugs.webkit.org/show_bug.cgi?id=49158
3282
3283         * Scripts/webkitpy/common/checkout/api_unittest.py:
3284
3285 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3286
3287         Unreviewed, rolling out r75774.
3288         http://trac.webkit.org/changeset/75774
3289         https://bugs.webkit.org/show_bug.cgi?id=52431
3290
3291         gtk builds were broken (Requested by loislo2 on #webkit).
3292
3293         * Scripts/webkitpy/common/checkout/scm.py:
3294
3295 2011-01-14  David Levin  <levin@chromium.org>
3296
3297         Reviewed by Shinichiro Hamaji.
3298
3299         check-webkit-style: _FunctionState should detect pure functions.
3300         https://bugs.webkit.org/show_bug.cgi?id=52428
3301
3302         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
3303         is a pure virtual function.
3304         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
3305         virtual functions are correctly detected.
3306
3307 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
3308
3309         Reviewed by Yury Semikhatsky.
3310
3311         Just small fix for problem with check-webkit-style.
3312         It just didn't work for this patch.
3313         Old code can't concatenate a list of strings with None.
3314
3315         * Scripts/webkitpy/common/checkout/scm.py:
3316
3317 2011-01-13  David Levin  <levin@chromium.org>
3318
3319         Reviewed by Shinichiro Hamaji.
3320
3321         check-webkit-style: _FunctionState should use Position to know where items are.
3322         https://bugs.webkit.org/show_bug.cgi?id=52424
3323
3324         * Scripts/webkitpy/style/checkers/cpp.py:
3325         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
3326         (detect_functions): Changed to pass Position's to _FunctionState.begin and
3327         did some minor clean-up.
3328         (*): Other changes are simply about converting to use the Position's in_FunctionState
3329         instead of line numbers.
3330         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
3331         to verify the positions stored in _FunctionState.
3332
3333 2011-01-13  Eric Seidel  <eric@webkit.org>
3334
3335         Reviewed by David Levin.
3336
3337         webkit-patch suggest-reviewers dies when ChangeLogs are missing
3338         https://bugs.webkit.org/show_bug.cgi?id=49158
3339
3340         This is not the most elegant, but it is a very safe fix to this bug.
3341         One advantage of catching ScriptError like this instead of adding a
3342         new added_or_modified_files or fixing all changed_files callers
3343         to use a more specific change_files variant, is that we catch
3344         all kinds of ScriptErrors which might cause our (non-essential)
3345         suggest-reviewers code to fail out.  This should make passing
3346         --suggest-reviewers to webkit-patch upload much more robust
3347         and may even make it possible for us to make it default.
3348
3349         The root of the problem here is that SCM.changed_files includes
3350         deleted ChangeLog paths (from moves, etc) which then when we ask
3351         SVN/Git for the contents of the file at that revision, the command
3352         errors out and Executive.run_command raises a ScriptError.
3353
3354         In the future we might fix this differently by making all current
3355         callers of chagned_files use a more specific method for requesting
3356         what types of changes they're interested in (adds, modifies, deletes, etc.)
3357
3358         * Scripts/webkitpy/common/checkout/api.py:
3359         * Scripts/webkitpy/common/checkout/api_unittest.py:
3360
3361 2011-01-13  Dan Bernstein  <mitz@apple.com>
3362
3363         Reviewed by Alexey Proskuryakov.
3364
3365         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
3366         https://bugs.webkit.org/show_bug.cgi?id=52419
3367
3368         Allow to further control the behavior of the willSendRequest delegate callback by making it
3369         set a different URL in the new request.
3370
3371         * DumpRenderTree/LayoutTestController.cpp:
3372         (addURLToRedirectCallback): Added.
3373         (LayoutTestController::staticFunctions): Added addURLToRedirect.
3374         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
3375         (LayoutTestController::redirectionDestinationForURL): Added this getter.
3376         * DumpRenderTree/LayoutTestController.h:
3377         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3378         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
3379         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
3380         change the URL in the new request to the redirect destination.
3381
3382 2011-01-13  Eric Seidel  <eric@webkit.org>
3383
3384         Reviewed by Mihai Parparita.
3385
3386         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
3387         https://bugs.webkit.org/show_bug.cgi?id=52416
3388
3389         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
3390         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
3391
3392         I also added FIXMEs about the changed_files returning deleted files problem
3393         which is causing the other most common exception for suggest-reviewers
3394         (and is probably breaking sheriff-bots blame detection).
3395
3396         * Scripts/webkitpy/common/checkout/api.py:
3397         * Scripts/webkitpy/common/checkout/api_unittest.py:
3398         * Scripts/webkitpy/common/checkout/scm.py:
3399
3400 2011-01-13  Eric Seidel  <eric@webkit.org>
3401
3402         Reviewed by Adam Barth.
3403
3404         results archives from commit-queue are too large to upload
3405         https://bugs.webkit.org/show_bug.cgi?id=52405
3406
3407         * Scripts/webkitpy/common/system/filesystem.py:
3408         * Scripts/webkitpy/common/system/filesystem_mock.py:
3409         * Scripts/webkitpy/tool/commands/queues.py:
3410
3411 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
3412
3413         Reviewed by Martin Robinson.
3414
3415         [gtk] Zero-sized font does not yet work
3416         https://bugs.webkit.org/show_bug.cgi?id=49793
3417
3418         Set minimum-font-size to 0 for the DRT.
3419
3420         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3421         (resetDefaultsToConsistentValues):
3422
3423 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
3424
3425         Reviewed by Darin Adler.
3426
3427         Make old-run-webkit-tests more robust on buildbots
3428         https://bugs.webkit.org/show_bug.cgi?id=52364
3429
3430         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
3431
3432 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
3433
3434         Reviewed by Darin Adler.
3435
3436         Make old-run-webkit-tests more robust on buildbots
3437         https://bugs.webkit.org/show_bug.cgi?id=52364
3438
3439         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
3440
3441 2011-01-13  Tony Chang  <tony@chromium.org>
3442
3443         Reviewed by Kent Tamura.
3444
3445         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
3446         https://bugs.webkit.org/show_bug.cgi?id=52332
3447
3448         Forked Info.plist is not longer needed.
3449
3450         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
3451
3452 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
3453
3454         Reviewed by Timothy Hatcher.
3455
3456         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
3457         to be passed directly to WebInspector.UIString
3458
3459         https://bugs.webkit.org/show_bug.cgi?id=52365
3460
3461         * Scripts/check-inspector-strings:
3462
3463 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3464
3465         Unreviewed, rolling out r74881.
3466         http://trac.webkit.org/changeset/74881
3467         https://bugs.webkit.org/show_bug.cgi?id=52357
3468
3469         The EFL builder has been red for days (Requested by abarth on
3470         #webkit).
3471
3472         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3473         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3474
3475 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3476
3477         Reviewed by David Levin.
3478
3479         Add beforeunload support to WebKitTestRunner
3480         https://bugs.webkit.org/show_bug.cgi?id=52353
3481         
3482         This makes a number of currently failing tests pass.
3483
3484         * WebKitTestRunner/TestController.cpp:
3485         (WTR::runBeforeUnloadConfirmPanel):
3486         (WTR::createOtherPage):
3487         (WTR::TestController::initialize):
3488
3489 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3490
3491         Reviewed by Sam Weinig.
3492
3493         Detect, identify and recover from WebProcess crashes in run-webkit-tests
3494         https://bugs.webkit.org/show_bug.cgi?id=52330
3495
3496         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
3497         a web process crash.
3498         * WebKitTestRunner/TestController.cpp:
3499         (WTR::TestController::initialize): Set up a processDidCrash
3500         callback.
3501         (WTR::TestController::processDidCrash): Report that the Web process
3502         crashed.
3503         * WebKitTestRunner/TestController.h:
3504
3505 2011-01-12  David Levin  <levin@chromium.org>
3506
3507         Reviewed by Shinichiro Hamaji.
3508
3509         check-webkit-style -- close_expression function doesn't work correctly.
3510         https://bugs.webkit.org/show_bug.cgi?id=52272
3511
3512         * Scripts/webkitpy/style/checkers/cpp.py:
3513         (Position.__str__): Added a way to convert it to a string which is useful in tests.
3514         (Position.__cmp__): Added a way to compare Position which is useful in tests and
3515         generally useful (for upcoming code changes).
3516         (close_expression): Changed to use Position for input and output.
3517         Also, fixed many bugs such as only working correctly for parenthesis,
3518         not working correctly if given an offset in a line and not finding
3519         the real closing element if there were multiple closing elements in
3520         the same line.
3521         (detect_functions): Adjusted due to the change in arguments for
3522         close_expression.
3523         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3524         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
3525         two positions are the same.
3526         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
3527         (CppStyleTest.test_close_expression): Added tests to catch the issues
3528         that were fixed.
3529
3530 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3531
3532         Unreviewed, rolling out r75576.
3533         http://trac.webkit.org/changeset/75576
3534         https://bugs.webkit.org/show_bug.cgi?id=52304
3535
3536         broke rebaseline-chromium-webkit-test (Requested by thakis on
3537         #webkit).
3538
3539         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3540         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3541         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3542         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3543         * Scripts/webkitpy/layout_tests/port/base.py:
3544         * Scripts/webkitpy/layout_tests/port/chromium.py:
3545         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3546         * Scripts/webkitpy/layout_tests/port/test.py:
3547         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3548         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3549         * Scripts/webkitpy/style/checkers/test_expectations.py:
3550         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3551
3552 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3553
3554         Reviewed by Darin Adler.
3555
3556         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
3557         https://bugs.webkit.org/show_bug.cgi?id=52307
3558
3559         * Scripts/old-run-webkit-tests:
3560
3561 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
3562
3563         Reviewed by Martin Robinson.
3564
3565         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
3566         https://bugs.webkit.org/show_bug.cgi?id=50867
3567
3568         Fixed library extention for Mac in webkitdirs.pm and type conflict in
3569         TestNetscapePlugin.cpp 
3570
3571         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
3572         * Scripts/webkitdirs.pm:
3573
3574 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
3575
3576         Reviewed by Pavel Feldman.
3577
3578         Add check-inspector-strings script.
3579
3580         https://bugs.webkit.org/show_bug.cgi?id=52295
3581
3582         * Scripts/check-inspector-strings: Added.
3583
3584 2011-01-12  Adam Roben  <aroben@apple.com>
3585
3586         Advertise the .testnetscape file extension on Windows
3587
3588         Fixes <http://webkit.org/b/52298>
3589         plugins/no-mime-with-valid-extension.html fails on Windows
3590
3591         Reviewed by Dan Bernstein.
3592
3593         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
3594         FileExtents field to map the .testnetscape file extension to the
3595         application/x-webkit-test-netscape MIME type, just as we do on Mac.
3596
3597 2011-01-12  Adam Barth  <abarth@webkit.org>
3598
3599         Reviewed by Eric Seidel.
3600
3601         Make webkit-patch support subdirectories for SVN checkouts
3602         https://bugs.webkit.org/show_bug.cgi?id=52261
3603
3604         os.relpath does not exist on Python 2.5, so we need to call our version
3605         of the API.
3606
3607         * Scripts/webkitpy/common/checkout/scm.py:
3608
3609 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3610
3611         Reviewed by Eric Seidel.
3612
3613         Close additional pages opened during a test once the test completes.
3614         https://bugs.webkit.org/show_bug.cgi?id=52276
3615
3616         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3617         (WTR::InjectedBundle::done):
3618
3619 2011-01-11  David Levin  <levin@chromium.org>
3620
3621         Reviewed by Eric Seidel.
3622
3623         Errors should be separated from the command line in bot messages.
3624         https://bugs.webkit.org/show_bug.cgi?id=52275
3625
3626         * Scripts/webkitpy/common/system/executive.py:
3627         (ScriptError.message_with_output): Added a newline to separate the command
3628         line from the errors.
3629         * Scripts/webkitpy/common/system/executive_unittest.py:
3630         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3631         paths in message_with_output.
3632
3633 2011-01-11  Eric Seidel  <eric@webkit.org>
3634
3635         Unreviewed.
3636
3637         commit-queue should know how to upload archived results (for test flakes or general failures)
3638         https://bugs.webkit.org/show_bug.cgi?id=52048
3639
3640         The zips are mostly empty due to forgetting -r.
3641         Expected diffs were not being pulled from the archive due
3642         to the archive having longer paths than I realized.
3643
3644         * Scripts/webkitpy/common/system/workspace.py:
3645         * Scripts/webkitpy/common/system/workspace_unittest.py:
3646         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3647         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3648
3649 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3650
3651         Reviewed by Ojan Vafai.
3652
3653         The current modifier parsing code in test_expectations is
3654         fragile and hard-coded, so it's not easy to understand the logic
3655         or easily add new types of modifiers (like GPU vs. CPU testing
3656         for graphics tests, or 32-bit vs. 64-bit differences).
3657
3658         This is the first of two patches that will add in more generic
3659         support and then eliminate the GPU-specific test expectations
3660         files for Chromium.
3661
3662         This patch adds two standalone objects for handling modifiers. The
3663         rules for interpreting modifiers, precedence, and conflicts are
3664         given in the docstring to the ModifierMatcher class, which
3665         returns ModifierMatchResult objects.
3666         
3667         This patch also adds routines to the Port interface and a
3668         default set of values in the base object, in order to obtain the
3669         values needed on a given test run. These values are then passed
3670         to the expectation parser. This also allows us to clean up the
3671         logic used to lint all of the different configurations in a
3672         single test_expectations.txt file.
3673
3674         The next patch will merge in the separate GPU expectations file.
3675
3676         https://bugs.webkit.org/show_bug.cgi?id=51222
3677
3678         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3679         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3680         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3681         * Scripts/webkitpy/layout_tests/port/base.py:
3682         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3683         * Scripts/webkitpy/layout_tests/port/chromium.py:
3684         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3685         * Scripts/webkitpy/layout_tests/port/test.py:
3686         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3687         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3688
3689 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3690
3691         Reviewed by Adam Barth.
3692
3693         Make webkit-patch support subdirectories for SVN checkouts
3694         https://bugs.webkit.org/show_bug.cgi?id=52261
3695
3696         * Scripts/webkitpy/common/checkout/scm.py:
3697         * Scripts/webkitpy/style_references.py:
3698         * Scripts/webkitpy/tool/main.py:
3699         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3700
3701 2011-01-11  Eric Seidel  <eric@webkit.org>
3702
3703         Unreviewed.
3704
3705         commit-queue should know how to upload archived results (for test flakes or general failures)
3706         https://bugs.webkit.org/show_bug.cgi?id=52048
3707
3708         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3709         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3710
3711         * Scripts/webkitpy/common/system/workspace.py:
3712         * Scripts/webkitpy/common/system/workspace_unittest.py: