6691274586eca483818eb3b2dcf70c6ac0cba0ae
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-23  Andy Estes  <aestes@apple.com>
2
3         Fix the build after r105635.
4
5         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
6         (TestWebKitAPI::TEST):
7
8 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
9
10         Basic enhancements to StringBuilder
11         https://bugs.webkit.org/show_bug.cgi?id=67081
12
13         Reviewed by Darin Adler.
14
15         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
16         (TestWebKitAPI::TEST):
17
18 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
19
20         [GTK] run-gtk-tests randomly fails while running the xprop comand
21         https://bugs.webkit.org/show_bug.cgi?id=76817
22
23         Reviewed by Gustavo Noronha Silva.
24
25         No need to use xprop to remove the AT_SPI_BUS property since
26         run-gtk-tests will always run new instances of Xvfb.
27
28         * Scripts/run-gtk-tests:
29         (TestRunner): Unskip TestWebKitAccessibility.
30         (TestRunner.run): Uncomment lines for launching the accessibility
31         bus and registry daemon, and remove lines for running xprop.
32
33 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
34
35         [Qt] Don't warn about override and final being C++11 extensions
36
37         Clang will emit a warning when these extensions are used without passing
38         --std=c++11, but we use feature checking to decide if we have the right
39         extensions, so we can safely ignore these warnings. The XCode and Windows
40         project files have the same workaround.
41
42         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
43         we only have one extra compiler for Objective-C, which is also used for
44         Objective-C++ sources, so we have to pass the flag, even if it doesn't
45         make sense for Objective-C.
46
47         Reviewed by Simon Hausmann.
48
49         * qmake/mkspecs/features/unix/default_post.prf:
50
51 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
52
53         [Qt] Change how build-webkit decides when to do full incremental builds
54
55         Instead of relying on update-webkit (which isn't run on the bots) to
56         decide when to do a full incremental build (make qmake), we let the
57         build-webkit script itself check the current SVN revision against the
58         previous build (by storing it in .webkit.config).
59
60         If the two differ we assume a full incremental build is needed, since
61         the new revisions might have introduced problematic things like new
62         Q_OBJECT macros. If not, we assume the developer is doing changes
63         locally, and revert to doing a plain 'make'.
64
65         In addition, when the build fails in the latter case, we inform the
66         developer of possible pitfalls and how to manually run 'make qmake'.
67
68         Reviewed by Ossy.
69
70         * Scripts/update-webkit:
71         * Scripts/webkitdirs.pm:
72         (buildQMakeProjects):
73
74 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
75
76         [GTK] run-gtk-tests randomly fails while running the xprop comand
77         https://bugs.webkit.org/show_bug.cgi?id=76817
78
79         Reviewed by Philippe Normand.
80
81         Temporarily comment the lines related to launching the ATSPI bus
82         and registry daemon, which are making the bots to fail randomly.
83
84         * Scripts/run-gtk-tests:
85         (TestRunner): Skip TestWebKitAccessibility, as it won't run
86         properly if the ATSPI infrastructure is not properly initialized.
87         (TestRunner.run): Comment lines related to initialization of ATSPI.
88
89 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
90
91         Windows python test build fix.
92
93         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
94         (PerfTestsRunner.__init__):
95
96 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
97
98         [GTK] DumpRenderTree converts "file:///" to a path differently
99         https://bugs.webkit.org/show_bug.cgi?id=76631
100
101         Reviewed by Martin Robinson.
102
103         DumpRenderTree should print "/" as the last path component if the
104         path is a lone slash instead of empty output.
105
106         * DumpRenderTree/gtk/DumpRenderTree.cpp:
107         (webViewConsoleMessage):
108
109 2012-01-20  David Levin  <levin@chromium.org>
110
111         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
112         https://bugs.webkit.org/show_bug.cgi?id=76752
113
114         Reviewed by Eric Seidel.
115
116         * Scripts/webkitpy/style/checkers/cpp.py:
117         (check_for_leaky_patterns):
118         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
119         (LeakyPatternTest.test_create_dc):
120         (LeakyPatternTest.test_create_compatible_dc):
121
122 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
123
124         Changed my status in commiters.py
125
126         Unreviewed.
127
128         * Scripts/webkitpy/common/config/committers.py:
129
130 2012-01-20  Ojan Vafai  <ojan@chromium.org>
131
132         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
133         https://bugs.webkit.org/show_bug.cgi?id=76748
134
135         Reviewed by Ryosuke Niwa.
136
137         It crawls the whole subtree and then doesn't use the data. Cutting this out
138         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
139
140         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
141         (run):
142
143 2012-01-20  Adam Barth  <abarth@webkit.org>
144
145         Another tiny tweak to the garden-o-matic CSS.  This makes things line
146         up slightly nicer when there aren't any failures.
147
148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
149         (#summary):
150
151 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
152
153         run-perf-tests should support --test-results-server option
154         https://bugs.webkit.org/show_bug.cgi?id=76680
155
156         Reviewed by Adam Barth.
157
158         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
159         to be used by perf bots. Also refactor file_uploader as needed.
160
161         * Scripts/webkitpy/common/net/file_uploader.py:
162         (FileUploader.__init__):
163         (FileUploader.upload_single_file):
164         (FileUploader.upload_as_multipart_form_data):
165         (FileUploader):
166         (FileUploader._upload_data):
167         (FileUploader._upload_data.callback):
168         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
169         (JSONResultsGeneratorBase.upload_json_files):
170         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
171         (PerfTestsRunner):
172         (PerfTestsRunner._parse_args):
173         (PerfTestsRunner.run):
174         (PerfTestsRunner._generate_json):
175         (PerfTestsRunner._upload_json):
176         (PerfTestsRunner._run_tests_set):
177         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
178         (create_runner):
179         (test_run_with_upload_json):
180         (test_run_with_upload_json.mock_upload_json):
181         (test_upload_json):
182         (test_upload_json.MockFileUploader):
183         (test_upload_json.MockFileUploader.__init__):
184         (test_upload_json.MockFileUploader.upload_single_file):
185         (test_parse_args):
186
187 2012-01-20  Adam Barth  <abarth@webkit.org>
188
189         The party time image overlaps real content!  This patch makes the
190         image centered vertically.
191
192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
193         (#onebar.partytime #summary):
194
195 2012-01-19  Ojan Vafai  <ojan@chromium.org>
196
197         Refactor TestExpectationsParser in preparation for caching the results
198         https://bugs.webkit.org/show_bug.cgi?id=76669
199
200         Reviewed by Dimitri Glazkov.
201
202         Make everything private expect for the parse method. 
203         Eventually, we'll need the expectations lines to not be modified
204         outside of TestExpectationsParser so we can cache the results.
205         This makes check-webkit-style of the chromium test_expectations.txt file
206         go from ~17 seconds to ~12 seconds on my Mac Pro.
207
208         This patch is just a refactor in preparation, so no new tests.
209
210         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
211         (TestExpectationEditorTests.make_parsed_expectation_lines):
212         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
213         (TestExpectationParser.parse):
214         (TestExpectationParser):
215         (TestExpectationParser._parse_line):
216         (TestExpectationParser._tokenize):
217         (TestExpectationParser._tokenize_list):
218         (TestExpectationsModel._clear_expectations_for_test):
219         (TestExpectations.__init__):
220         (TestExpectations._add_expectations):
221         (TestExpectations._add_skipped_tests):
222         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
223         (TestExpectationParserTests.test_tokenize_blank):
224         (TestExpectationParserTests.test_tokenize_missing_colon):
225         (TestExpectationParserTests.test_tokenize_extra_colon):
226         (TestExpectationParserTests.test_tokenize_empty_comment):
227         (TestExpectationParserTests.test_tokenize_comment):
228         (TestExpectationParserTests.test_tokenize_missing_equal):
229         (TestExpectationParserTests.test_tokenize_extra_equal):
230         (TestExpectationParserTests.test_tokenize_valid):
231         (TestExpectationParserTests.test_tokenize_valid_with_comment):
232         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
233         (TestExpectationParserTests.test_parse_empty_string):
234         (TestExpectationSerializerTests.assert_round_trip):
235         (TestExpectationSerializerTests.assert_list_round_trip):
236         * Scripts/webkitpy/tool/commands/expectations.py:
237         (OptimizeExpectations.execute):
238         * Scripts/webkitpy/tool/servers/gardeningserver.py:
239         (GardeningExpectationsUpdater.update_expectations):
240
241 2012-01-20  Adam Barth  <abarth@webkit.org>
242
243         Follow-up to previous patch: don't produce NaN when the revision number
244         is missing.
245
246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
248
249 2012-01-20  Adam Barth  <abarth@webkit.org>
250
251         Garden-o-matic should tell me which revisions have been checked by all the bots
252         https://bugs.webkit.org/show_bug.cgi?id=76722
253
254         Reviewed by Dimitri Glazkov.
255
256         This information helps me know when it's safe for me to roll a
257         candidate revision.
258
259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
260         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
261         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
262
263 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
264
265         build-webkit: Don't spit out congratulations message on Ctrl+C
266
267         Reviewed by Andreas Kling.
268
269         * Scripts/build-webkit:
270
271 2012-01-20  Philippe Normand  <pnormand@igalia.com>
272
273         [GTK] Allow extra jhbuild modulesets
274         https://bugs.webkit.org/show_bug.cgi?id=76691
275
276         Reviewed by Gustavo Noronha Silva.
277
278         * gtk/jhbuildrc: Extra modulesets and modules can be added in
279         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
280         env variables respectively. Use comma-separated values. Example:
281         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
282
283 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
284
285         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
286         https://bugs.webkit.org/show_bug.cgi?id=72589
287
288         Reviewed by Martin Robinson.
289
290         Ensure the accessibility infrastructure is available when running
291         the unit tests, otherwise WK2's accessibility tests won't work.
292
293         * Scripts/run-gtk-tests:
294         (TestRunner):
295         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
296         where at-spi2's stuff is located (like at-spi-bus-launcher and
297         at-spi2-registryd).
298         (TestRunner.run): Initialize the accessibility infrastructure.
299
300         * gtk/generate-gtkdoc:
301         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
302
303         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
304
305 2012-01-20  Hayato Ito  <hayato@chromium.org>
306
307         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
308         https://bugs.webkit.org/show_bug.cgi?id=76353
309
310         Reviewed by Hajime Morita.
311
312         Add ShadowRoot.idl, which is enabled only on chromium port since this is
313         under development feature.
314         ShadowRoot.idl contains minimum API so that we can test it.
315         Other APIs should be added on other changes so that we can isolate issues.
316
317         * DumpRenderTree/chromium/TestShell.cpp:
318         (TestShell::TestShell):
319
320 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
321
322         [GTK] GTK's DRT not to log events for already defunct objects
323         https://bugs.webkit.org/show_bug.cgi?id=76620
324
325         Reviewed by Martin Robinson.
326
327         Do not log 'state-change:defunct' events.
328
329         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
330         (printAccessibilityEvent): Early return if a
331         'state-change:defunct' signal is passed.
332         (axObjectEventListener): Pass the signal name and value in
333         separate parameters to printAccessibilityEvent.
334
335 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
336
337         Unreviewed build fix. Wrong variable being used as the cwd for git
338         remote update command.
339
340         * gtk/run-with-jhbuild:
341         (update_jhbuild):
342
343 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
344
345         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
346         https://bugs.webkit.org/show_bug.cgi?id=76585
347
348         Reviewed by Martin Robinson.
349
350         This allows us to specify a minimum version of jhbuild required,
351         while also providing stability against changes done to the master
352         branch, by letting us choose what is the exact version that will
353         be used.
354
355         * gtk/run-with-jhbuild: refactored for more hackability and easier
356         reading
357         (jhbuild_installed): checks whether jhbuild is installed
358         (jhbuild_cloned): checks whether jhbuild has been cloned
359         (jhbuild_at_expected_revision): checks whether jhbuild is at the
360         expected revision
361         (update_jhbuild): brings jhbuild to the expected revision
362         (clone_jhbuild): clones jhbuild
363         (install_jhbuild): build and installs jhbuild
364         (update_webkitgtk_libs): runs update-webkitgtk-libs
365         (ensure_jhbuild): high-level logic to decide whether and which of
366         the steps above are executed
367
368 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
369
370         [WK2] DumpRenderTree converts "file:///" to a path differently
371         https://bugs.webkit.org/show_bug.cgi?id=76653
372
373         Reviewed by John Sullivan.
374
375         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
376         Do print a slash if there are no path components.
377
378 2012-01-19  Eric Seidel  <eric@webkit.org>
379
380         webkit-patch cannot rollout patches without changelog/bug number
381         https://bugs.webkit.org/show_bug.cgi?id=75962
382
383         Reviewed by Adam Barth.
384
385         * Scripts/webkitpy/tool/commands/download.py:
386         (AbstractRolloutPrepCommand._prepare_state):
387         * Scripts/webkitpy/tool/commands/download_unittest.py:
388         (AbstractRolloutPrepCommandTest.test_prepare_state):
389
390 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
391
392         [WK2] fast/url/degenerate-file-base.html fails
393         https://bugs.webkit.org/show_bug.cgi?id=76619
394
395         Reviewed by Adam Roben.
396
397         A URL generated form local path for loading had an extra slash, making document.URL
398         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
399
400         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
401
402 2012-01-18  Ojan Vafai  <ojan@chromium.org>
403
404         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
405         https://bugs.webkit.org/show_bug.cgi?id=76510
406
407         Reviewed by Adam Barth.
408
409         Unlike other style rules, if you get the syntax of the test_expectations.txt
410         file wrong, the layout tests won't run. Also, this check is simple and only
411         slows down committing if you actually modify one of the test_expectations.txt files.
412
413         * Scripts/webkitpy/style/checkers/test_expectations.py:
414         (TestExpectationsChecker.check_test_expectations):
415         (TestExpectationsChecker.check):
416         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
417         (TestExpectationsTestCase.test_check_covers_all_configurations):
418         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
419         (TestExpectationsTestCase):
420         (assert_lines_lint):
421
422 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
423
424         Build fix. Revert an unintentional change to WebKitDriver in r105443.
425
426         * Scripts/webkitpy/layout_tests/port/driver.py:
427         (DriverProxy.__init__):
428
429 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
430
431         remove the duplicated build rules from WebKit.gyp, Tools.gyp
432         https://bugs.webkit.org/show_bug.cgi?id=73384
433
434         Reviewed by Tony Chang.
435
436         This patch removes the no-longer-necessary conditional logic for
437         build_webkit_exes_from_webkit_gyp; we now always build the exes
438         from their own dedicated gyp files.
439
440         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
441
442 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
443
444         make-new-script-test should work with HTTP tests
445         https://bugs.webkit.org/show_bug.cgi?id=76603
446
447         Reviewed by Adam Roben.
448
449         * Scripts/make-new-script-test:
450         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
451         now also creates absolute paths for HTTP.
452
453 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
454
455         Some perf tests time out when ran by run-perf-tests
456         https://bugs.webkit.org/show_bug.cgi?id=76612
457
458         Reviewed by Dirk Pranke and Eric Seidel.
459
460         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
461         Otherwise some tests such as Parser/xml-parser.html will timeout.
462
463         --no-timeout option is currently supported by Chromium and Mac ports.
464
465         * Scripts/webkitpy/layout_tests/port/base.py:
466         (Port.to.create_driver):
467         * Scripts/webkitpy/layout_tests/port/chromium.py:
468         (ChromiumDriver.__init__):
469         (ChromiumDriver._wrapper_options):
470         * Scripts/webkitpy/layout_tests/port/driver.py:
471         (Driver.__init__):
472         (DriverProxy.__init__):
473         * Scripts/webkitpy/layout_tests/port/webkit.py:
474         (WebKitDriver.__init__):
475         (WebKitDriver.cmd_line):
476         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
477         (WebKitDriverTest.test_read_binary_block):
478         (WebKitDriverTest):
479         (WebKitDriverTest.test_no_timeout):
480         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
481         (get_tests_run.RecordingTestDriver.__init__):
482         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
483         (PerfTestsRunner._parse_args):
484         (PerfTestsRunner._run_tests_set):
485         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
486         (create_runner):
487
488 2012-01-19  Ben Wells  <benwells@chromium.org>
489
490         Add support for window.print to chromium DRT
491         https://bugs.webkit.org/show_bug.cgi?id=76479
492
493         When used in a test window.print goes into print mode and then
494         straight out again. This will allow the afterprint event to be
495         tested by having the afterprint event happen before the dump
496         happens.
497
498         Reviewed by Mihai Parparita.
499
500         * DumpRenderTree/chromium/WebViewHost.cpp:
501         (WebViewHost::printPage):
502         * DumpRenderTree/chromium/WebViewHost.h:
503
504 2012-01-18  Enrica Casucci  <enrica@apple.com>
505
506         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
507         https://bugs.webkit.org/show_bug.cgi?id=76588
508         <rdar://problem/9325183>
509
510         Added test.
511         
512         Reviewed by Dan Bernstein.
513
514         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
515         (TestWebKitAPI::TEST):
516
517 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
518
519         [Qt] Do full incremental builds until bots use update-webkit
520
521         Rubber-stamped by Simon Hausmann.
522
523         * Scripts/webkitdirs.pm:
524         (buildQMakeProjects):
525
526 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
527
528         Fix the Qt build
529
530         Unreviewed build fix.
531
532         * Scripts/webkitdirs.pm:
533         (buildQMakeProjects):
534
535 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
536
537         [Qt] Make build-webkit always do safe incremental builds after update-webkit
538
539         When building against Qt5 with GCC we would just run 'make' in the build dir,
540         and rely on the dependency files output by GCC (-MD) to handle dependency
541         tracking, but that fails for special-cases like adding a Q_OBJECT macro
542         to a header.
543
544         To guarantee that an incrmental build will work, we have to run 'make qmake',
545         which we now do on every build-webkit that's followed by a successful run
546         of update-webkit. The reasoning is that update-webkit can result in such
547         potential corner-cases being applied, and since we can't know for sure
548         unless we inspect the diff and account for all the corner cases we assume
549         the worst and always run 'make qmake'.
550
551         After a succesful run of build-webkit we proceed to do just 'make' for any
552         subsequent runs, since we assume that the developer knows what kind of
553         changes he/she is doing, and when a 'make qmake' is needed.
554
555         Reviewed by Simon Hausmann.
556
557         * Scripts/update-webkit:
558         * Scripts/webkitdirs.pm:
559         (determineCurrentSVNRevision):
560         (currentSVNRevision):
561         (buildQMakeProjects):
562         * qmake/mkspecs/features/default_post.prf:
563
564 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
565
566         run-perf-tests should support Skipped list
567         https://bugs.webkit.org/show_bug.cgi?id=76594
568
569         Reviewed by Adam Barth.
570
571         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
572
573         * Scripts/webkitpy/layout_tests/port/base.py:
574         (Port.perf_tests_dir):
575         (Port.skipped_perf_tests):
576         (Port.skips_perf_test):
577         (Port.relative_perf_test_filename):
578         * Scripts/webkitpy/layout_tests/port/test.py:
579         (TestPort.perf_tests_dir):
580         * Scripts/webkitpy/layout_tests/port/webkit.py:
581         (WebKitPort._expectations_from_skipped_files):
582         (WebKitPort):
583         (WebKitPort.skipped_layout_tests):
584         (WebKitPort.skipped_perf_tests):
585         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
586         (PerfTestsRunner._collect_tests):
587         (PerfTestsRunner.run):
588         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
589         (test_run_test_set_with_json_output):
590         (test_run_test_set_with_json_source):
591         (test_collect_tests_with_skipped_list):
592         (test_collect_tests_with_skipped_list.add_file):
593
594 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
595
596         Fix path to chromium_src_dir introduced in previous change.
597
598         Unreviewed, build fix.
599
600         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
601
602 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
603
604         Need infrastructure to test Content-Disposition filename encoding support
605         https://bugs.webkit.org/show_bug.cgi?id=76572
606         <rdar://problem/6421825>
607
608         Reviewed by Sam Weinig.
609
610         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
611
612         WebKitTestRunner does not have a policy delegate yet, bug 42546.
613
614         * DumpRenderTree/mac/PolicyDelegate.mm:
615         (dispositionTypeFromContentDispositionHeader):
616         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
617
618 2012-01-18  Ojan Vafai  <ojan@chromium.org>
619
620         Fix tests from http://trac.webkit.org/changeset/105332.
621
622         The code assumed that if you passed an options object with a configuration
623         attribute that it would have a valid value. A bunch of the testing mocks
624         do things like having a configuration value of None.
625
626         * Scripts/webkitpy/layout_tests/port/base.py:
627         (Port.__init__):
628
629 2012-01-18  Ojan Vafai  <ojan@chromium.org>
630
631         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
632         https://bugs.webkit.org/show_bug.cgi?id=76576
633
634         Reviewed by Adam Barth.
635
636         Avoid calling default_configuration in base.py. We don't need it for
637         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
638         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
639         from common.executive.
640
641         At some point someone should probably look into why that call is so slow
642         since it's on the critical path for run-webkit-tests and build-webkit startup.
643
644         * Scripts/webkitpy/layout_tests/port/base.py:
645         (Port.__init__):
646         * Scripts/webkitpy/style/checkers/test_expectations.py:
647         (TestExpectationsChecker._determine_port_from_exepectations_path):
648
649 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
650
651         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
652         https://bugs.webkit.org/show_bug.cgi?id=76505
653
654         Reviewed by Tony Chang.
655
656         Update chromium build script to use All.gyp instead of WebKit.gyp
657
658         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
659         * Scripts/webkitdirs.pm:
660
661 2012-01-18  Sam Weinig  <sam@webkit.org>
662
663         Don’t hardcode the path to ‘make‘.
664
665         Reviewed by Dan Bernstein.
666
667         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
668
669 2012-01-18  Joshua Bell  <jsbell@chromium.org>
670
671         Adding myself to committers.py
672         https://bugs.webkit.org/show_bug.cgi?id=76569
673
674         Unreviewed.
675
676         * Scripts/webkitpy/common/config/committers.py:
677
678 2012-01-18  Adam Barth  <abarth@webkit.org>
679
680         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
681         https://bugs.webkit.org/show_bug.cgi?id=76567
682
683         Reviewed by Eric Seidel.
684
685         Current the AppleMac port has slightly more failures than we allow on
686         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
687         which should hopefully let the mac-ews run to completion.  Once
688         AppleMac has fewer failures, we can lower the cap again.
689
690         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
691         (LayoutTestResultsReaderTest.test_layout_test_results):
692         * Scripts/webkitpy/tool/steps/runtests.py:
693         (RunTests):
694         * Scripts/webkitpy/tool/steps/steps_unittest.py:
695
696 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
697
698         Provide access to user's list of preferred languages
699         https://bugs.webkit.org/show_bug.cgi?id=76138
700
701         Reviewed by Alexey Proskuryakov.
702
703         * GNUmakefile.am: Add JSInternalsCustom.cpp.
704
705 2012-01-18  Adam Barth  <abarth@webkit.org>
706
707         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
708         configurations.
709
710         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
711         (ChromiumLinuxPort.__init__):
712
713 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
714
715         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
716         https://bugs.webkit.org/show_bug.cgi?id=73460
717
718         Reviewed by Chris Fleizach.
719
720         * DumpRenderTree/AccessibilityUIElement.h:
721         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
722         (AccessibilityUIElement::AccessibilityUIElement):
723         (AccessibilityUIElement::scrollToMakeVisibleCallback):
724         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
725         (AccessibilityUIElement::scrollToGlobalPointCallback):
726         * DumpRenderTree/chromium/AccessibilityUIElement.h:
727         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
728         (AccessibilityUIElement::scrollToMakeVisible):
729         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
730         (AccessibilityUIElement::scrollToGlobalPoint):
731         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
732         (AccessibilityUIElement::scrollToMakeVisible):
733         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
734         (AccessibilityUIElement::scrollToGlobalPoint):
735         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
736         (AccessibilityUIElement::scrollToMakeVisible):
737         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
738         (AccessibilityUIElement::scrollToGlobalPoint):
739
740 2012-01-17  Enrica Casucci  <enrica@apple.com>
741
742         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
743         https://bugs.webkit.org/show_bug.cgi?id=76490
744         <rdar://problem/9460733>
745
746         Added TestWebKitAPI test.
747         
748         Reviewed by Dan Bernstein.
749
750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
751         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
752         changeAttributes to the WebView.
753         
754 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
755
756         [Qt] Consolidate layout test crash logging
757         https://bugs.webkit.org/show_bug.cgi?id=75088
758
759         Reviewed by Simon Hausmann.
760
761         Move backtrace generating logic into WTFReportBacktrace
762         and add a way to deinstall signal handlers if we know
763         that we have already printed the backtrace.
764
765         * DumpRenderTree/qt/main.cpp:
766         (crashHandler):
767         (setupSignalHandlers):
768         (WTFCrashHook):
769         (main):
770         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
771         (WTR::crashHandler):
772         (WTR::setupSignalHandlers):
773         (WTR::crashHook):
774         (WTR::InjectedBundle::platformInitialize):
775
776 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
777
778         Unreviewed build fix after r105256.
779
780         There was a cyclic dependency between self._port and self._host assigments.
781
782         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
783         (PerfTestsRunner.__init__):
784
785 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
786
787         Add new watchlist rule for the Qt build system
788
789         Reviewed by Simon Hausmann.
790
791         * Scripts/webkitpy/common/config/watchlist:
792
793 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
794
795         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
796
797         Reviewed by Simon Hausmann.
798
799         * Tools.pro:
800
801 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
802
803         [Qt] Allow building only a subset of the WebKit sub-projects
804
805         Fixes build-jsc, broken in r104825.
806
807         We no longer need the intermediate buildQMakeQtProject(), as we're the
808         only port using qmake, and buildQMakeProject is now highly Qt specific.
809
810         <http://webkit.org/b/76179>
811
812         Reviewed by Simon Hausmann.
813
814         * Scripts/build-jsc:
815         * Scripts/build-webkit:
816         * Scripts/webkitdirs.pm:
817         (buildQMakeProjects):
818
819 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
820
821         run-perf-tests should generate a json file that summaries the result
822         https://bugs.webkit.org/show_bug.cgi?id=76504
823
824         Reviewed by Adam Barth.
825
826         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
827         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
828         another json file to be merged into the generated json file.
829
830         Also fixed a bug that --build wasn't set by default.
831
832         * Scripts/webkitpy/layout_tests/port/test.py:
833         (TestPort.webkit_base):
834         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
835         (PerfTestsRunner.__init__):
836         (PerfTestsRunner):
837         (PerfTestsRunner._parse_args):
838         (PerfTestsRunner.run):
839         (PerfTestsRunner._generate_json_if_specified):
840         (PerfTestsRunner._process_chromium_style_test_result):
841         (PerfTestsRunner._process_parser_test_result):
842         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
843         (MainTest):
844         (create_runner):
845         (test_run_test_set):
846         (test_run_test_set_for_parser_tests):
847         (test_run_test_set_with_summary_json):
848         (test_collect_tests):
849         (test_parse_args):
850
851 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
852
853         Unreviewed, rolling out r105244.
854         http://trac.webkit.org/changeset/105244
855         https://bugs.webkit.org/show_bug.cgi?id=76518
856
857         broke Chromium Mac (Requested by rolandsteiner on #webkit).
858
859         * DumpRenderTree/AccessibilityUIElement.h:
860         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
861         (AccessibilityUIElement::AccessibilityUIElement):
862         * DumpRenderTree/chromium/AccessibilityUIElement.h:
863         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
864         (AccessibilityUIElement::removeSelection):
865         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
866         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
867         (AccessibilityUIElement::removeSelection):
868
869 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
870
871         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
872         https://bugs.webkit.org/show_bug.cgi?id=73460
873
874         Reviewed by Chris Fleizach.
875
876         * DumpRenderTree/AccessibilityUIElement.h:
877         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
878         (AccessibilityUIElement::AccessibilityUIElement):
879         (AccessibilityUIElement::scrollToMakeVisibleCallback):
880         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
881         (AccessibilityUIElement::scrollToGlobalPointCallback):
882         * DumpRenderTree/chromium/AccessibilityUIElement.h:
883         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
884         (AccessibilityUIElement::scrollToMakeVisible):
885         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
886         (AccessibilityUIElement::scrollToGlobalPoint):
887         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
888         (AccessibilityUIElement::scrollToMakeVisible):
889         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
890         (AccessibilityUIElement::scrollToGlobalPoint):
891         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
892         (AccessibilityUIElement::scrollToMakeVisible):
893         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
894         (AccessibilityUIElement::scrollToGlobalPoint):
895
896 2012-01-17  Adam Barth  <abarth@webkit.org>
897
898         Enable tests on the mac-ews
899         https://bugs.webkit.org/show_bug.cgi?id=76502
900
901         Reviewed by Simon Fraser.
902
903         Apple now has five machines running the mac-ews.  Lucas Forschler has
904         asked that we try enabling tests to see if we have enough bandwidth.
905
906         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
907         (MacEWS):
908
909 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
910
911         Add a check-webkit-style exception for GDBInterface.cpp
912         https://bugs.webkit.org/show_bug.cgi?id=76187
913
914         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
915         that it does not fail the style check.
916
917         Reviewed by Martin Robinson.
918
919         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
920         readability/naming tests on
921         Source/JavaScriptCore/jit/GDBInterface.cpp.
922         * Scripts/webkitpy/style/checker_unittest.py:
923         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
924         the above exception.
925
926 2012-01-17  Hajime Morrita  <morrita@chromium.org>
927
928         https://bugs.webkit.org/show_bug.cgi?id=76245
929         [Mac][DRT] should allow query string for the file URL.
930
931         Reviewed by Tony Chang.
932
933         Taught DRT about file:// as a url instead of a file path.
934         We are now able to use a path file:///foo/bar.html?baz as a url
935         with which DRT opens "/foo/bar.html" with "baz" as a query string.
936
937         * DumpRenderTree/mac/DumpRenderTree.mm:
938         (runTest):
939
940 2012-01-17  Ojan Vafai  <ojan@chromium.org>
941
942         Check style on test_expectations.txt files before commit
943         https://bugs.webkit.org/show_bug.cgi?id=76484
944
945         Reviewed by Adam Barth.
946
947         Unlike other style rules, if you get the syntax of the test_expectations.txt
948         file wrong, the layout tests won't run. Also, this check is simple and only
949         slows down committing if you actually modify one of the test_expectations.txt files.
950
951         * Scripts/webkitpy/tool/steps/commit.py:
952         (Commit._check_test_expectations):
953         (Commit.run):
954         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
955         (CommitTest):
956         (CommitTest.test_check_test_expectations):
957
958 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
959
960         [Qt] Debug build fails with debug qt5
961         https://bugs.webkit.org/show_bug.cgi?id=76463
962
963         Reviewed by Simon Hausmann.
964
965         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
966
967         * QtTestBrowser/cookiejar.h:
968
969 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
970
971         webkitpy: fix json import on linux
972         https://bugs.webkit.org/show_bug.cgi?id=76481
973
974         Reviewed by Adam Barth.
975
976         For some reason, the version of simplejson autoinstalled on my linux
977         box seems to be broken. We should really only be using
978         simplejson if json isn't available anyway, so this change looks
979         for json first.
980
981         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
982         (JSONGeneratorTest.test_test_timings_trie):
983
984 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
985
986         Fix failures in test-webkitpy caused by r105177.
987
988         Unreviewed, build fix.
989
990         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
991         (ChromiumLinuxPort._determine_driver_path_statically):
992         (ChromiumLinuxPort._static_build_path):
993
994 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
995
996         webkitpy: make PortFactory.get() be fully data-driven
997         https://bugs.webkit.org/show_bug.cgi?id=76360
998
999         Reviewed by Eric Seidel.
1000
1001         Refactor PortFactory.get() to be fully data-driven.
1002
1003         * Scripts/webkitpy/layout_tests/port/factory.py:
1004         (PortFactory):
1005         (PortFactory._default_port):
1006         (PortFactory.get):
1007         (PortFactory.get.in):
1008         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1009         (FactoryTest.assert_port):
1010
1011 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1012
1013         webkitpy: add determine_full_port_name(), clean up port.__init__()
1014         https://bugs.webkit.org/show_bug.cgi?id=76357
1015
1016         Reviewed by Adam Barth.
1017
1018         Each Port class is now required to implement a 'port_name' field
1019         that will match the start of all ports constructed by this class and
1020         a 'determine_full_port_name' field that will make the port
1021         fully-qualified.
1022
1023         * Scripts/webkitpy/layout_tests/port/apple.py:
1024         (ApplePort.__init__):
1025         * Scripts/webkitpy/layout_tests/port/base.py:
1026         (Port):
1027         (Port.determine_port_name):
1028         (Port.__init__):
1029         * Scripts/webkitpy/layout_tests/port/chromium.py:
1030         (ChromiumPort.for):
1031         (ChromiumPort.__init__):
1032         (ChromiumPort):
1033         (ChromiumPort._chromium_base_dir):
1034         (ChromiumPort.path_from_chromium_base):
1035         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1036         (ChromiumGpuLinuxPort):
1037         (ChromiumGpuLinuxPort.__init__):
1038         (ChromiumGpuMacPort):
1039         (ChromiumGpuMacPort.__init__):
1040         (ChromiumGpuWinPort):
1041         (ChromiumGpuWinPort.__init__):
1042         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1043         (ChromiumLinuxPort):
1044         (ChromiumLinuxPort.determine_port_name):
1045         (ChromiumLinuxPort.__init__):
1046         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1047         (ChromiumMacPort):
1048         (ChromiumMacPort.determine_port_name):
1049         (ChromiumMacPort.__init__):
1050         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1051         (ChromiumWinPort):
1052         (ChromiumWinPort.determine_port_name):
1053         (ChromiumWinPort.__init__):
1054         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1055         (DryRunPort):
1056         (DryRunPort.determine_port_name):
1057         (DryRunPort.__init__):
1058         * Scripts/webkitpy/layout_tests/port/efl.py:
1059         (EflPort):
1060         * Scripts/webkitpy/layout_tests/port/factory.py:
1061         (PortFactory):
1062         (PortFactory._default_port):
1063         (PortFactory.get):
1064         (PortFactory.get.in):
1065         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1066         (FactoryTest.assert_port):
1067         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1068         (GoogleChromeLinux32Port):
1069         (GoogleChromeLinux32Port.determine_port_name):
1070         (GoogleChromeLinux64Port):
1071         (GoogleChromeLinux64Port.determine_port_name):
1072         (GoogleChromeMacPort):
1073         (GoogleChromeMacPort.determine_port_name):
1074         (GoogleChromeWinPort):
1075         (GoogleChromeWinPort.determine_port_name):
1076         * Scripts/webkitpy/layout_tests/port/gtk.py:
1077         (GtkPort):
1078         * Scripts/webkitpy/layout_tests/port/mac.py:
1079         (MacPort):
1080         (MacPort.determine_port_name):
1081         (MacPort.__init__):
1082         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1083         (test_versions):
1084         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1085         (MockDRTPort):
1086         (MockDRTPort.determine_port_name):
1087         (MockDRTPort.__init__):
1088         (MockDRT):
1089         (MockDRT.determine_port_name):
1090         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1091         (PortTestCase.make_port):
1092         * Scripts/webkitpy/layout_tests/port/qt.py:
1093         (QtPort):
1094         (QtPort.determine_port_name):
1095         (QtPort.__init__):
1096         * Scripts/webkitpy/layout_tests/port/test.py:
1097         (TestPort):
1098         (TestPort.determine_port_name):
1099         (TestPort.__init__):
1100         * Scripts/webkitpy/layout_tests/port/webkit.py:
1101         (WebKitPort.__init__):
1102         * Scripts/webkitpy/layout_tests/port/win.py:
1103         (WinPort):
1104         (WinPort.determine_port_name):
1105         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1106         (get_test_baselines.AllPlatformsPort.__init__):
1107         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1108         (get_test_config.TestMacPort):
1109         (get_test_config):
1110
1111 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1112
1113         webkitpy: clean up port code in preparation for static port names
1114         https://bugs.webkit.org/show_bug.cgi?id=76356
1115
1116         Reviewed by Adam Barth.
1117
1118         To fix bug 76215 and be able to determine appropriate port names
1119         in webkitpy without actually constructing Port objects, we need
1120         to shuffle some logic in the chromium ports to be able to figure
1121         out whether we built DRT in 32 or 64-bit mode.
1122
1123         * Scripts/webkitpy/layout_tests/port/chromium.py:
1124         (ChromiumPort):
1125         (ChromiumPort._chromium_base_dir):
1126         (ChromiumPort.__init__):
1127         (ChromiumPort.path_from_chromium_base):
1128         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1129         (ChromiumLinuxPort):
1130         (ChromiumLinuxPort._determine_driver_path_statically):
1131         (ChromiumLinuxPort._static_build_path):
1132         (ChromiumLinuxPort._determine_architecture):
1133         (ChromiumLinuxPort.__init__):
1134         (ChromiumLinuxPort._build_path):
1135
1136 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
1137
1138         Do not remove pixel failures for ref tests.
1139         https://bugs.webkit.org/show_bug.cgi?id=76243
1140
1141         Reviewed by Tony Chang.
1142
1143         'NRWT --no-pixel-tests' complains when reftests are expected to
1144         be image mismatch.
1145
1146         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1147         (Manager._update_summary_with_result):
1148         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1149         (is_reftest_failure):
1150         (determine_result_type):
1151
1152 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
1153
1154         REGRESSION(r81225): ORWT should ignore reftests
1155         https://bugs.webkit.org/show_bug.cgi?id=67936
1156
1157         Reviewed by Csaba Osztrogonác.
1158
1159         * Scripts/old-run-webkit-tests:
1160         (isUsedInReftest): $filename should be the first parameter
1161         (findTestsToRun): run test if it isn't reftest
1162
1163 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
1164
1165         Unreviewed. Fix python unit test I broke with r105142
1166
1167         * Scripts/webkitpy/common/config/ports_unittest.py:
1168         (WebKitPortTest.test_gtk_port):
1169
1170 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1171
1172         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
1173
1174         Qt 5 no longer has that flag.
1175
1176         Reviewed by Simon Hausmann.
1177
1178         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1179         (MiniBrowserApplication::notify):
1180
1181 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1182
1183         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
1184         https://bugs.webkit.org/show_bug.cgi?id=75857
1185
1186         Reviewed by Adam Barth.
1187
1188         * Scripts/webkitdirs.pm:
1189         (buildAutotoolsProject): move cleaning the build to happen early,
1190         and handle --update-gtk right after that
1191         * Scripts/webkitpy/common/config/ports.py:
1192         (GtkPort.build_webkit_command): pass --update-gtk as an option to
1193         build-webkit, so that it is used in the EWS
1194
1195 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1196
1197         [Qt] Don't add _debug postfix to targets when building debug only
1198
1199         Reviewed by Simon Hausmann.
1200
1201         * qmake/mkspecs/features/default_post.prf:
1202         * qmake/mkspecs/features/functions.prf:
1203
1204 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1205
1206         [Qt] Add more files to project-files for easier navigation in Qt Creator
1207
1208         Reviewed by Simon Hausmann.
1209
1210         * Tools.pro:
1211         * qmake/config.tests/README: Added.
1212
1213 2012-01-17  Philippe Normand  <pnormand@igalia.com>
1214
1215         [GTK] fast/dom/constructed-objects-prototypes.html fails
1216         https://bugs.webkit.org/show_bug.cgi?id=75432
1217
1218         Reviewed by Martin Robinson.
1219
1220         * Scripts/build-webkit: Enable video-track in GTK.
1221
1222 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
1223
1224         Add toyoshim as a committer.
1225         https://bugs.webkit.org/show_bug.cgi?id=76390
1226
1227         Reviewed by Hajime Morita.
1228
1229         * Scripts/webkitpy/common/config/committers.py:
1230
1231 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
1232
1233         [WinCairo] Build fix after r104155. Several debug targets were not
1234         properly including the '*Common' property sheets.
1235
1236         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
1237         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
1238         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
1239         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
1240         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
1241
1242 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
1243
1244         REGRESSION(r105072): It broke committers_unittest.py
1245         https://bugs.webkit.org/show_bug.cgi?id=76396
1246
1247         Reviewed by Adam Barth.
1248
1249         * Scripts/webkitpy/common/config/committers_unittest.py:
1250         (CommittersTest._assert_fuzz_match): It should handle more names.
1251         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
1252
1253 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
1254
1255         [GTK] Include gtk+3 in the jhbuild modules
1256         https://bugs.webkit.org/show_bug.cgi?id=76284
1257
1258         Reviewed by Philippe Normand.
1259
1260         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
1261
1262 2012-01-16  Dan Winship  <danw@gnome.org>
1263
1264         Add myself as a committer
1265
1266         Unreviewed
1267
1268         * Scripts/webkitpy/common/config/committers.py:
1269
1270 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1271
1272         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
1273
1274         Some recent versions of a few Linux distributions have started passing
1275         --as-needed and --no-copy-dt-needed-entries by default to the linker,
1276         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
1277         needed a few symbols from libjavascriptcore_efl.so.
1278
1279         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
1280         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
1281         libraries are searched in the right order by the linker.
1282
1283 2012-01-16  Philippe Normand  <pnormand@igalia.com>
1284
1285         [GTK] set audio resources path in NRTW
1286         https://bugs.webkit.org/show_bug.cgi?id=76380
1287
1288         Reviewed by Martin Robinson.
1289
1290         * Scripts/webkitpy/layout_tests/port/gtk.py:
1291         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
1292         the uninstalled audio resources are used during webaudio tests.
1293
1294 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1295
1296         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
1297         https://bugs.webkit.org/show_bug.cgi?id=76369
1298
1299         Reviewed by Xan Lopez.
1300
1301         If there's an installed version of webkit and there are new
1302         symbols in the build tree, gtkdoc-scanobj fails due to undefined
1303         references, because the env ldflags are given before the local
1304         ones.
1305
1306         * gtk/gtkdoc.py:
1307         (GTKDoc._run_gtkdoc_scangobj):
1308
1309 2012-01-15  Pablo Flouret  <pablof@motorola.com>
1310
1311         Fix compilation errors on build-webkit --debug --no-video on mac.
1312         https://bugs.webkit.org/show_bug.cgi?id=75867
1313
1314         Reviewed by Philippe Normand.
1315
1316         Add --[no-]video-track to build-webkit, since video track feature
1317         depends on video.
1318
1319         * Scripts/build-webkit:
1320
1321 2012-01-14  James Robinson  <jamesr@chromium.org>
1322
1323         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
1324         https://bugs.webkit.org/show_bug.cgi?id=76313
1325
1326         Reviewed by Adam Barth.
1327
1328         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
1329
1330         * Scripts/run-chromium-webkit-unit-tests:
1331
1332 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1333
1334         Unreviewed, rolling out r105017.
1335         http://trac.webkit.org/changeset/105017
1336         https://bugs.webkit.org/show_bug.cgi?id=76333
1337
1338         broke the build (Requested by philn-tp on #webkit).
1339
1340         * gtk/jhbuild.modules:
1341
1342 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
1343
1344         [GTK] Include gtk+3 in the jhbuild modules
1345         https://bugs.webkit.org/show_bug.cgi?id=76284
1346
1347         Reviewed by Philippe Normand.
1348
1349         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
1350
1351 2012-01-13  Adam Barth  <abarth@webkit.org>
1352
1353         Remove --dry-run support from webkit-patch
1354         https://bugs.webkit.org/show_bug.cgi?id=76300
1355
1356         Reviewed by Dirk Pranke.
1357
1358         This is the rest of the patch from Bug 76300.  I landed it separtely
1359         because main.py had some stray conflict markers that I needed to clean
1360         up first.
1361
1362         * Scripts/webkitpy/test/main.py:
1363         (Tester.parse_args):
1364         (Tester._run_tests):
1365
1366 2012-01-13  Adam Barth  <abarth@webkit.org>
1367
1368         test-webkitpy does not run
1369         https://bugs.webkit.org/show_bug.cgi?id=76318
1370
1371         Unreviewed.
1372
1373         Looks like some conflict markers got left in the file.
1374
1375         * Scripts/webkitpy/test/main.py:
1376         (Tester.run):
1377
1378 2012-01-13  Adam Barth  <abarth@webkit.org>
1379
1380         Remove --dry-run support from webkit-patch
1381         https://bugs.webkit.org/show_bug.cgi?id=76300
1382
1383         Reviewed by Dirk Pranke.
1384
1385         We don't use this functionality for anything, and it doesn't really
1386         work.  Someone in #webkit tried using it and and got sad/confused.  We
1387         should just remove it.
1388
1389         * Scripts/webkitpy/common/checkout/scm/git.py:
1390         (Git.push_local_commits_to_server):
1391         * Scripts/webkitpy/common/checkout/scm/scm.py:
1392         (SCM.__init__):
1393         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1394         (_shared_test_commit_with_message):
1395         (GitSVNTest.test_commit_text_parsing):
1396         * Scripts/webkitpy/common/checkout/scm/svn.py:
1397         (SVN.commit_with_message):
1398         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1399         (Bugzilla.__init__):
1400         (Bugzilla.quips):
1401         (Bugzilla.authenticate):
1402         (Bugzilla.add_attachment_to_bug):
1403         (Bugzilla.add_patch_to_bug):
1404         (Bugzilla.create_bug):
1405         (Bugzilla.clear_attachment_flags):
1406         (Bugzilla.set_flag_on_attachment):
1407         (Bugzilla.obsolete_attachment):
1408         (Bugzilla.add_cc_to_bug):
1409         (Bugzilla.post_comment_to_bug):
1410         (Bugzilla.close_bug_as_fixed):
1411         (Bugzilla.reassign_bug):
1412         (reopen_bug):
1413         * Scripts/webkitpy/test/main.py:
1414         (Tester.parse_args):
1415         (Tester.run_tests):
1416
1417 2012-01-13  David Levin  <levin@chromium.org>
1418
1419         check-webkit-style: should encourage the use of Own* classes for Windows DC.
1420         https://bugs.webkit.org/show_bug.cgi?id=76227
1421
1422         Reviewed by Dirk Pranke.
1423
1424         * Scripts/webkitpy/style/checkers/cpp.py:
1425         (check_for_leaky_patterns): The new check.
1426         (process_line): Added a call to the new check.
1427         (CppChecker): Added the new error type.
1428         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1429         (CppStyleTestBase):
1430         (CppStyleTestBase.perform_leaky_pattern_check):
1431         The check for only leaky pattern errors.
1432         (LeakyPatternTest): Test cases.
1433
1434 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1435
1436         test-webkitpy: clean up handling of test directories, QueueStatusServer
1437         https://bugs.webkit.org/show_bug.cgi?id=76238
1438
1439         Reviewed by Adam Barth.
1440
1441         This patch cleans up a bunch of hacks related to how we find all
1442         of the python unit tests and set up the sys.path variable in
1443         test-webkitpy.
1444
1445         This patch changes how test-webkitpy works slightly in that we
1446         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
1447         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
1448         This greatly simplifies the mapping of paths to module names and
1449         appears to have no significant performance impact or other drawbacks.
1450
1451         There are other ways that we could remove all of the hacks and
1452         still have a more flexible mapping of paths to module names, but
1453         the ones I've thought of so far add a decent amount of complexity to
1454         the implementation and don't seem to buy us much.
1455         
1456         * QueueStatusServer/__init__.py:
1457         * Scripts/test-webkitpy:
1458         * Scripts/webkitpy/test/main.py:
1459         (Tester._modules_from_paths):
1460         (Tester._is_module):
1461
1462 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1463
1464         test-webkitpy: should support classes and individual test names as well as modules
1465         https://bugs.webkit.org/show_bug.cgi?id=76233
1466
1467         Reviewed by Adam Barth.
1468
1469         The default unittest.main() supports a list of individual
1470         TestCase classes or individual tests as well as modules. This
1471         change adds support for the same to test-webkitpy, so now you
1472         can say
1473
1474           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
1475
1476         and
1477
1478           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
1479
1480         in addition to
1481
1482           % test-wekbitpy webkitpy.test.cat_unittest
1483
1484         * Scripts/test-webkitpy:
1485         * Scripts/webkitpy/test/cat_unittest.py:
1486         * Scripts/webkitpy/test/main.py:
1487         (Tester.parse_args):
1488         (Tester.run):
1489         (Tester):
1490         (Tester._find_modules):
1491         (Tester._exclude):
1492         (Tester._run_tests):
1493         (Tester._is_module):
1494         (Tester._log_exception):
1495
1496 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1497
1498         test-webkitpy: add basic code coverage support
1499         https://bugs.webkit.org/show_bug.cgi?id=76201
1500
1501         Reviewed by Adam Barth.
1502
1503         This test adds basic code coverage support to test-webkitpy; if
1504         you pass the -c flag, we will generate a new coverage file. We
1505         can start simply with this and add more features as necessary.
1506
1507         This patch requires coverage to be already installed on the
1508         machine. I am not auto-installing this for now.
1509
1510         * Scripts/webkitpy/test/main.py:
1511         (Tester.parse_args):
1512         (Tester.run_tests):
1513
1514 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1515
1516         StatusBubbleTest.test_build_bubble is failing
1517         https://bugs.webkit.org/show_bug.cgi?id=76222
1518
1519         Reviewed by Adam Barth.
1520
1521         * QueueStatusServer/handlers/statusbubble_unittest.py:
1522         (StatusBubbleTest.test_build_bubble):
1523
1524 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1525
1526         nrwt should use multiple http shards
1527         https://bugs.webkit.org/show_bug.cgi?id=75958
1528
1529         Add --max-locked-shards option to the nrwt for manual set
1530         the maximum number of the locked shards
1531
1532         Reviewed by Dirk Pranke.
1533
1534         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1535         (Manager._max_locked_shards):
1536         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1537         (ShardingTests.get_shards):
1538         (ShardingTests.test_multiple_locked_shards):
1539         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1540         (parse_args):
1541
1542 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1543
1544         prepare-ChangeLog: Look for a text editor in a few more variables.
1545         https://bugs.webkit.org/show_bug.cgi?id=76289
1546
1547         Reviewed by Ryosuke Niwa.
1548
1549         A text editor was looked for only in the CHANGE_LOG_EDITOR and
1550         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
1551         to the OS X-specific open(1) command.
1552
1553         As there does not seem to be a common way of looking for a text editor
1554         among the scripts in Tools/Scripts right now, just look at $VISUAL and
1555         $EDITOR (set much more often than the other variables in Unix systems)
1556         before falling back to open(1).
1557
1558         * Scripts/prepare-ChangeLog:
1559         (openChangeLogs):
1560
1561 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
1562
1563         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
1564         https://bugs.webkit.org/show_bug.cgi?id=76269
1565
1566         Reviewed by Martin Robinson.
1567
1568         * gtk/gtkdoc.py:
1569         (GTKDoc._run_gtkdoc_scangobj):
1570
1571 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1572
1573         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
1574         https://bugs.webkit.org/show_bug.cgi?id=76247
1575
1576         Reviewed by Kenneth Rohde Christiansen.
1577
1578         * WebKitTestRunner/TestController.cpp:
1579         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
1580
1581 2012-01-13  Hajime Morrita  <morrita@chromium.org>
1582
1583         [Mac][DRT] Should support --no-timeout
1584         https://bugs.webkit.org/show_bug.cgi?id=76242
1585
1586         Reviewed by Darin Adler.
1587
1588         * DumpRenderTree/mac/DumpRenderTree.mm:
1589         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
1590         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
1591         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
1592         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1593         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1594         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
1595
1596 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
1597
1598         Mitigate scrollbar differences when running pixel tests
1599         https://bugs.webkit.org/show_bug.cgi?id=67217
1600
1601         Reviewed by Dan Bernstein.
1602         
1603         Enable mock scrollbars by default for tests.
1604
1605         * DumpRenderTree/mac/DumpRenderTree.mm:
1606         (resetDefaultsToConsistentValues):
1607         * WebKitTestRunner/TestController.cpp:
1608         (WTR::TestController::resetStateToConsistentValues):
1609
1610 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1611
1612         Need a script to run tests in PerformanceTests
1613         https://bugs.webkit.org/show_bug.cgi?id=76132
1614
1615         Reviewed by Adam Barth.
1616
1617         Add run-perf-tests to run performance tests using parser/resources/runner.js.
1618         Unfortunately, there isn't an easy way of telling which test uses which format
1619         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
1620
1621         All test outputs are re-formatted to match Chromium perf-bot style.
1622
1623         * Scripts/run-inspector-perf-tests.py:
1624         * Scripts/run-perf-tests: Added.
1625         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1626         (PerfTestsRunner):
1627         (PerfTestsRunner.__init__):
1628         (PerfTestsRunner._collect_tests):
1629         (PerfTestsRunner.run):
1630         (PerfTestsRunner._print_status):
1631         (PerfTestsRunner._run_tests_set):
1632         (PerfTestsRunner._process_chromium_style_test_result):
1633         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1634         (PerfTestsRunner._process_parser_test_result):
1635         (PerfTestsRunner._run_single_test):
1636         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1637         (MainTest.TestDriver.run_test):
1638         (create_runner):
1639         (run_test):
1640         (test_run_test_set):
1641         (test_run_test_set_for_parser_tests):
1642         (test_collect_tests):
1643
1644 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1645
1646         webkitpy: clean up port unit tests in preparation for making port_name mandatory
1647         https://bugs.webkit.org/show_bug.cgi?id=76123
1648
1649         Reviewed by Adam Barth.
1650
1651         This change updates the unit tests to be more consistent in how
1652         ports are created, in preparation for making port_name a
1653         mandatory parameter to the constructor and removing any version
1654         interpretation from it.
1655
1656         There should be no functional changes in this patch, but some
1657         tests that are no longer relevant have been removed or reworked.
1658
1659         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1660         (PortTest.test_get_option__default):
1661         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1662         (ChromiumLinuxPortTest):
1663         (ChromiumLinuxPortTest.assert_architecture):
1664         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1665         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1666         (ChromiumMacPortTest):
1667         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1668         (ChromiumPortTest):
1669         (ChromiumPortTest.test_all_test_configurations):
1670         (ChromiumPortTest.TestMacPort.__init__):
1671         (ChromiumPortTest.TestLinuxPort.__init__):
1672         (ChromiumPortTest.TestWinPort.__init__):
1673         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1674         (ChromiumWinTest):
1675         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1676         (EflPortTest):
1677         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1678         (GtkPortTest):
1679         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1680         (MacTest):
1681         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1682         (MockDRTPortTest):
1683         (MockDRTPortTest.make_port):
1684         * Scripts/webkitpy/layout_tests/port/qt.py:
1685         (QtPort._port_flag_for_scripts):
1686         (QtPort.__init__):
1687         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1688         (QtPortTest):
1689         (QtPortTest._assert_search_path):
1690         (QtPortTest.test_baseline_search_path):
1691         (QtPortTest.test_operating_system):
1692         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1693         (WebKitPortTest):
1694         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1695         (WinPortTest):
1696         (WinPortTest._assert_search_path):
1697         (WinPortTest.test_baseline_search_path):
1698         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1699         (get_test_config.TestMacPort.__init__):
1700
1701 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1702
1703         test-webkitpy: clean up logging and provide a real --help message
1704         https://bugs.webkit.org/show_bug.cgi?id=76142
1705
1706         Reviewed by Adam Barth.
1707
1708         This test is mostly more refactoring - it calls objects in
1709         unittest directly instead of routing through unittest.main() --
1710         in order to gain more control over the logging and to provide a
1711         correct --help message. This will also give us a better
1712         foundation for adding more feautures down the road.
1713
1714         This patch adds different levels of logging controlled by the
1715         '-s', '-q', and '-v' options (see --help for details), and
1716         removes the --verbose-logging option.
1717
1718         * Scripts/test-webkitpy:
1719         * Scripts/webkitpy/test/main.py:
1720         (Tester):
1721         (Tester.clean_packages):
1722         (Tester.__init__):
1723         (Tester.parse_args):
1724         (Tester.configure):
1725         (Tester._configure_logging):
1726         (Tester.find_modules):
1727         (Tester._exclude):
1728         (Tester._modules_from_paths):
1729         (Tester.run_tests):
1730
1731 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
1732
1733         Make the new WTF module build on Qt
1734         https://bugs.webkit.org/show_bug.cgi?id=76163
1735
1736         Reviewed by Tor Arne Vestbø.
1737
1738         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
1739
1740 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1741
1742         Unreviewed, mac DumpRenderTree fix.
1743
1744         * DumpRenderTree/mac/UIDelegate.mm:
1745         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1746
1747 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1748
1749         WebKitTestRunner should not print console message line number when it is equal to zero.
1750         https://bugs.webkit.org/show_bug.cgi?id=76167
1751
1752         Reviewed by Csaba Osztrogonác.
1753
1754         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1755         (WTR::InjectedBundlePage::willAddMessageToConsole):
1756
1757 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
1758
1759         Make default console messages line numbers consistent.
1760         https://bugs.webkit.org/show_bug.cgi?id=74075
1761
1762         Reviewed by Pavel Feldman.
1763
1764         Unset line numbers are not printed to console now.
1765         Added Source/WebCore/inspector to efl DumpRenderTree include path.
1766
1767         * DumpRenderTree/chromium/WebViewHost.cpp:
1768         (WebViewHost::didAddMessageToConsole):
1769         * DumpRenderTree/efl/CMakeLists.txt:
1770         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1771         (onConsoleMessage):
1772         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1773         (webViewConsoleMessage):
1774         * DumpRenderTree/mac/UIDelegate.mm:
1775         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1776         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1777         (WebCore::WebPage::javaScriptConsoleMessage):
1778         * DumpRenderTree/win/UIDelegate.cpp:
1779         (UIDelegate::webViewAddMessageToConsole):
1780         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1781         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1782
1783 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
1784
1785         test-webkitpy: push more logic into webkitpy.test.main, clean up code
1786         https://bugs.webkit.org/show_bug.cgi?id=76021
1787
1788         Reviewed by Eric Seidel.
1789
1790         I plan to add more functionality to test-webkitpy, but it is
1791         difficult to hack on now; this patch is the first of two that
1792         brings test-webkitpy more inline with current coding style by
1793         pushing more logic into the webkitpy.test.main.Tester class (so
1794         that it will be testable itself).
1795         
1796         There should be no functional changes in this patch.
1797
1798         * Scripts/test-webkitpy:
1799         (_path_from_webkit_root):
1800         * Scripts/webkitpy/test/main.py:
1801         (Tester):
1802         (Tester.init):
1803         (Tester.configure_logging):
1804         (Tester.configure_logging.filter):
1805         (Tester.clean_packages):
1806         (Tester.run_tests):
1807
1808 2012-01-11  Wei Jia  <wjia@chromium.org>
1809
1810         implement layout tests for <video> with media stream
1811         https://bugs.webkit.org/show_bug.cgi?id=74882
1812
1813         Reviewed by Kent Tamura.
1814
1815         * DumpRenderTree/DumpRenderTree.gypi:
1816         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
1817         (WebKit::WebUserMediaClientMock::create):
1818         (WebKit::WebUserMediaClientMock::IsMockStream):
1819         (WebKit::WebUserMediaClientMock::requestUserMedia):
1820         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
1821         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
1822         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
1823         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
1824         * DumpRenderTree/chromium/WebViewHost.cpp:
1825         (WebViewHost::userMediaClient):
1826         (WebViewHost::userMediaClientMock):
1827         (WebViewHost::createMediaPlayer):
1828         (WebViewHost::mediaStreamUtil):
1829         (WebViewHost::testMediaStreamClient):
1830         * DumpRenderTree/chromium/WebViewHost.h:
1831
1832 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1833
1834         Unreviewed, build fix.
1835
1836         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
1837
1838         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1839         (ChromiumWinPort.__init__):
1840
1841 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1842
1843         Sheriffbot build fix. Don't emit empty lines on IRC.
1844
1845         * Scripts/webkitpy/tool/bot/irc_command.py:
1846         (LastGreenRevision.execute):
1847
1848 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1849
1850         last-green-revision should report the revision that succeeded on all bots
1851         https://bugs.webkit.org/show_bug.cgi?id=76109
1852
1853         Reviewed by Adam Barth.
1854
1855         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
1856         considered green by this algorithm, all matching builders must have a successful run at the revision
1857         or two consecutive successful runs before and after the revision.
1858
1859         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
1860         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
1861
1862         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1863         (BuildBot._revisions_for_builder):
1864         (BuildBot):
1865         (BuildBot._find_green_revision):
1866         (BuildBot.last_green_revision):
1867         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1868         (MockBuildBot.last_green_revision):
1869         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1870         (test_revisions_for_builder):
1871         (test_find_green_revision):
1872         (test_last_green_revision):
1873         * Scripts/webkitpy/tool/bot/irc_command.py:
1874         (LastGreenRevision.execute):
1875         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1876         (SheriffIRCBotTest.test_lgr):
1877         * Scripts/webkitpy/tool/commands/queries.py:
1878         (LastGreenRevision):
1879
1880 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1881
1882         Unreviewed, fix build bustage on win32 introduced by r104725.
1883
1884         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1885         (MockDRTPortTest.make_port):
1886         (MockChromiumDRTTest.test_pixeltest__fails):
1887
1888 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
1889
1890         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
1891         https://bugs.webkit.org/show_bug.cgi?id=75618
1892
1893         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
1894
1895         Reviewed by Tony Chang.
1896
1897         * DumpRenderTree/chromium/LayoutTestHelper.mm:
1898         (installLayoutTestColorProfile):
1899         (restoreUserColorProfile):
1900         (main):
1901
1902 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1903
1904         test-webkitpy: fix -v and eliminate some spurious warnings
1905         https://bugs.webkit.org/show_bug.cgi?id=76099
1906
1907         Reviewed by Adam Barth.
1908
1909         when we added support for --xml output, we broke the -v flag.
1910
1911         Also, fix the code to swallow a harmless warning from
1912         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
1913
1914         test-webkitpy is now silent again except for the one known
1915         logging issue.
1916
1917         * Scripts/webkitpy/common/checkout/checkout.py:
1918         (Checkout.commit_message_for_this_commit):
1919         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1920         (test_commit_message_for_this_commit):
1921         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1922         (JSONChecker.check):
1923         (JSONChecker.line_number_from_json_exception):
1924         * Scripts/webkitpy/test/main.py:
1925         (Tester.run_tests):
1926
1927 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1928
1929         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
1930         https://bugs.webkit.org/show_bug.cgi?id=76084
1931
1932         Reviewed by Adam Barth.
1933
1934         This will help make it easier to catch layering violations. This
1935         change just refactors test code; there are no changes to
1936         production code.
1937
1938         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1939         (PortTest.make_port):
1940         (PortTest.test_find_no_paths_specified):
1941         (PortTest.test_find_one_test):
1942         (PortTest.test_find_glob):
1943         (PortTest.test_find_with_skipped_directories):
1944         (PortTest.test_find_with_skipped_directories_2):
1945         (PortTest.test_parse_reftest_list):
1946         (PortTest.test_httpd_returns_error_code):
1947         (PortTest.test_virtual_methods):
1948         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1949         (ChromiumGpuTest.assert_port_works):
1950         (ChromiumGpuTest._assert_baseline_path):
1951         (ChromiumGpuTest.test_graphics_type):
1952         (ChromiumGpuTest.test_default_tests_paths.test_paths):
1953         (ChromiumGpuTest.test_test_files):
1954         (ChromiumGpuTest.test_test_files.test_paths):
1955         (ChromiumGpuTest):
1956         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1957         (ChromiumLinuxPortTest.assert_architecture):
1958         (ChromiumLinuxPortTest.test_check_illegal_port_names):
1959         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1960         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1961         (DriverTest.make_port):
1962         (DriverTest):
1963         (DriverTest.assertVirtual):
1964         (DriverTest._assert_wrapper):
1965         (DriverTest.test_virtual_driver_methods):
1966         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1967         (MockDRTPortTest.make_port):
1968         (MockDRTPortTest.test_port_name_in_constructor):
1969         (MockDRTTest.assertTest):
1970         (MockDRTTest.test_main):
1971         (MockChromiumDRTTest.test_pixeltest__fails):
1972         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1973         (QtPortTest._assert_search_path):
1974         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1975         (TestWebKitPort.__init__):
1976         (WebKitPortUnitTests.test_default_options):
1977         (test_runtime_feature_list):
1978         (test_test_expectations):
1979
1980 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1981
1982         Style skipped tests in the flakiness dashboard
1983         https://bugs.webkit.org/show_bug.cgi?id=76091
1984
1985         Reviewed by Tony Chang.
1986
1987         * TestResultServer/static-dashboards/dashboard_base.js:
1988         Removed "FLAKY" from this list since we don't ever mark individual runs
1989         as flaky. Also deleted an outdated line.
1990         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1991
1992 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1993
1994         Remove gtest normalization code from the test results server
1995         https://bugs.webkit.org/show_bug.cgi?id=76089
1996
1997         Reviewed by Tony Chang.
1998
1999         The normalization now happens on the gtest side.
2000
2001         * TestResultServer/model/jsonresults.py:
2002         (JsonResults.merge):
2003         * TestResultServer/model/jsonresults_unittest.py:
2004         (JsonResultsTest.test_gtest):
2005
2006 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2007
2008         Be more aggressive about deleting unnecessary results from the test-results-server json files
2009         https://bugs.webkit.org/show_bug.cgi?id=76086
2010
2011         Reviewed by Tony Chang.
2012
2013         Remove any tests that only contain skip/pass/nodata values whose runtime
2014         is less than 5 seconds.
2015
2016         * TestResultServer/model/jsonresults.py:
2017         (JsonResults._normalize_results_json):
2018         * TestResultServer/model/jsonresults_unittest.py:
2019         (JsonResultsTest.test_merge_remove_test):
2020         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
2021
2022 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2023
2024         last-green-revision should give us per-bot information
2025         https://bugs.webkit.org/show_bug.cgi?id=76011
2026
2027         Reviewed by Adam Barth.
2028
2029         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
2030         we report the latest green run on each bot from the last 100 runs.
2031
2032         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2033         (BuildBot._fetch_builder_page):
2034         (BuildBot):
2035         (BuildBot._green_revision_for_builder):
2036         (BuildBot.last_green_revision):
2037         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2038         (test_green_revision_for_builder):
2039         (test_last_green_revision):
2040         * Scripts/webkitpy/tool/bot/irc_command.py:
2041         (LastGreenRevision.execute):
2042         * Scripts/webkitpy/tool/commands/queries.py:
2043         (LastGreenRevision.execute):
2044
2045 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2046
2047         webkitpy: clean up version detection in webkitpy.layout_tests.port
2048         https://bugs.webkit.org/show_bug.cgi?id=76016
2049
2050         Reviewed by Adam Barth.
2051
2052         This change updates the code in webkitpy.layout_tests.port to
2053         use the new os_name and os_version fields on host.platform. This
2054         gets layout_tests.port out of the version parsing business. Most
2055         of the diffs are just cleaning up test code to accomodate the
2056         changes.
2057
2058         * Scripts/webkitpy/common/system/executive_mock.py:
2059         (MockExecutive):
2060         (MockExecutive.ignore_error):
2061         (MockExecutive2):
2062         (MockExecutive2.ignore_error):
2063         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2064         (MockPlatformInfo.is_mac):
2065         (MockPlatformInfo.is_linux):
2066         (MockPlatformInfo.is_win):
2067         * Scripts/webkitpy/common/system/systemhost_mock.py:
2068         (MockSystemHost.__init__):
2069         * Scripts/webkitpy/layout_tests/port/apple.py:
2070         (ApplePort.__init__):
2071         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2072         (ChromiumMacPort.__init__):
2073         (ChromiumMacPort.check_wdiff):
2074         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2075         (ChromiumMacPortTest):
2076         (ChromiumMacPortTest.assert_name):
2077         (ChromiumMacPortTest.test_versions):
2078         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2079         (ChromiumPortTest.test_all_test_configurations):
2080         (ChromiumPortTest.TestMacPort.__init__):
2081         (ChromiumPortTest.TestLinuxPort.__init__):
2082         (ChromiumPortTest.TestWinPort.__init__):
2083         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2084         (ChromiumWinPort.__init__):
2085         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2086         (ChromiumWinTest):
2087         (ChromiumWinTest.assert_name):
2088         (ChromiumWinTest.test_versions):
2089         (ChromiumWinTest.test_baseline_path):
2090         (ChromiumWinTest.test_build_path):
2091         * Scripts/webkitpy/layout_tests/port/factory.py:
2092         (PortFactory._port_name_from_arguments_and_options):
2093         (PortFactory.get):
2094         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2095         (FactoryTest):
2096         (FactoryTest.setUp):
2097         (FactoryTest.assert_port):
2098         (FactoryTest.test_mac):
2099         (FactoryTest.test_win):
2100         (FactoryTest.test_google_chrome):
2101         (FactoryTest.test_gtk):
2102         (FactoryTest.test_qt):
2103         (FactoryTest.test_chromium_gpu):
2104         (FactoryTest.test_chromium_gpu_linux):
2105         (FactoryTest.test_chromium_gpu_mac):
2106         (FactoryTest.test_chromium_gpu_win):
2107         (FactoryTest.test_chromium_mac):
2108         (FactoryTest.test_chromium_linux):
2109         (FactoryTest.test_chromium_win):
2110         (FactoryTest.test_unknown_specified):
2111         (FactoryTest.test_unknown_default):
2112         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2113         (TestGoogleChromePort):
2114         (TestGoogleChromePort._verify_baseline_path):
2115         (TestGoogleChromePort._verify_expectations_overrides):
2116         (TestGoogleChromePort.test_get_google_chrome_port):
2117         * Scripts/webkitpy/layout_tests/port/mac.py:
2118         (MacPort):
2119         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2120         (MacTest):
2121         (assert_name):
2122         (test_tests_for_other_platforms):
2123         (test_version):
2124         (test_versions):
2125         (test_is_version_methods):
2126         (test_setup_environ_for_server):
2127         (_assert_search_path):
2128         (test_show_results_html_file):
2129         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2130         (PortTestCase):
2131         (PortTestCase.make_port):
2132         * Scripts/webkitpy/layout_tests/port/win.py:
2133         (WinPort):
2134         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2135         (WinPortTest):
2136         (WinPortTest.test_show_results_html_file):
2137         (WinPortTest._assert_search_path):
2138         (WinPortTest._assert_version):
2139
2140 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
2141
2142         [Qt][WK2] Remove workaround introduced into bug 75470
2143         https://bugs.webkit.org/show_bug.cgi?id=75889
2144
2145         Reviewed by Tor Arne Vestbø.
2146
2147         * MiniBrowser/qt/qml/BrowserWindow.qml:
2148
2149 2012-01-10  Dmitry Lomov  <dslomov@google.com>
2150
2151         [Chromium] Remove obsolete references to WebWorker class.
2152         https://bugs.webkit.org/show_bug.cgi?id=76020
2153
2154         Reviewed by David Levin.
2155
2156         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
2157         * DumpRenderTree/chromium/WebViewHost.cpp:
2158         * DumpRenderTree/chromium/WebViewHost.h:
2159
2160 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
2161
2162         [Qt] Some css3 filter tests are failing after r104698
2163         https://bugs.webkit.org/show_bug.cgi?id=76055
2164
2165         Reviewed by Simon Hausmann.
2166
2167         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2168         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
2169
2170 2012-01-11  Tony Chang  <tony@chromium.org>
2171
2172         Don't remove 0 byte files when running build-webkit --chromium
2173         https://bugs.webkit.org/show_bug.cgi?id=75997
2174
2175         Reviewed by Csaba Osztrogonác.
2176
2177         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
2178
2179         * Scripts/webkitdirs.pm:
2180         (determineIsQt):
2181
2182 2012-01-10  David Kilzer  <ddkilzer@apple.com>
2183
2184         Add TestWebKitAPI tests for KURL
2185         <http://webkit.org/b/75774>
2186
2187         Reviewed by Adam Barth.
2188
2189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
2190         WebCore folder and KURL.cpp source file to the project.
2191         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
2192         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
2193         during setup since this test doesn't go through WebKit or
2194         WebKit2.
2195         (TestWebKitAPI::TEST_F): Add two basic tests.
2196
2197 2012-01-10  David Kilzer  <ddkilzer@apple.com>
2198
2199         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
2200
2201         Reviewed by Adam Barth.
2202
2203         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
2204
2205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
2206         WTFStringUtilities.h to the project.
2207         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
2208         WTFStringUtilities.h.
2209         * TestWebKitAPI/WTFStringUtilities.h: Added.
2210         (WTF::operator<<):
2211
2212 2012-01-10  Vincent Scheib  <scheib@chromium.org>
2213
2214         Clarify run-webkit-tests options reset-results and new-baseline
2215         https://bugs.webkit.org/show_bug.cgi?id=75993
2216
2217         Reviewed by Dirk Pranke.
2218
2219         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2220         (parse_args):
2221
2222 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
2223
2224         Disabled mock scrollbars should draw differently
2225         https://bugs.webkit.org/show_bug.cgi?id=75995
2226
2227         Reviewed by James Robinson.
2228
2229         When the scrollbar is disabled, paint the entire track of
2230         mock scrollbars with a lighter gray, and hide the thumb.
2231
2232         * DumpRenderTree/mac/DumpRenderTree.mm:
2233         (-[DRTMockScroller drawKnob]):
2234         (-[DRTMockScroller drawRect:]):
2235
2236 2012-01-10  James Robinson  <jamesr@chromium.org>
2237
2238         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
2239         https://bugs.webkit.org/show_bug.cgi?id=75988
2240
2241         Reviewed by Adam Barth.
2242
2243         * Scripts/webkitpy/common/config/ports.py:
2244         (WebKitPort.run_webkit_unit_tests_command):
2245         (WebKitPort):
2246         (ChromiumPort.run_webkit_unit_tests_command):
2247         (ChromiumPort):
2248         * Scripts/webkitpy/common/config/ports_mock.py:
2249         (MockPort.run_webkit_unit_tests_command):
2250         * Scripts/webkitpy/tool/commands/download_unittest.py:
2251         (DownloadCommandsTest.test_build_and_test):
2252         (test_land):
2253         (test_land_red_builders):
2254         * Scripts/webkitpy/tool/steps/runtests.py:
2255         (RunTests.run):
2256         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2257
2258 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2259
2260         webkitpy: add os_name, os_version to platforminfo
2261         https://bugs.webkit.org/show_bug.cgi?id=75931
2262
2263         Reviewed by Eric Siedel.
2264
2265         As a first step in cleaning up the version parsing logic in
2266         webkitpy.layout_tests.port, this adds common routines for
2267         getting the os_name and os_version fields to the PlatformInfo
2268         class. Nothing uses them yet but I've added FIXME's to some of
2269         the code that needs to be deleted in the port files.
2270
2271         * Scripts/webkitpy/common/system/platforminfo.py:
2272         (PlatformInfo.__init__):
2273         (PlatformInfo):
2274         (PlatformInfo._determine_os_name):
2275         (PlatformInfo._determine_mac_version):
2276         (PlatformInfo._determine_linux_version):
2277         (PlatformInfo._determine_win_version):
2278         (PlatformInfo.display_name):
2279         (PlatformInfo.total_bytes_memory):
2280         (PlatformInfo._compute_bytes_from_vm_stat_output):
2281         (PlatformInfo.free_bytes_memory):
2282         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
2283         (TestPlatformInfo):
2284         (TestPlatformInfo.make_info):
2285         (TestPlatformInfo.make_info.mock_run_command):
2286         (TestPlatformInfo.setUp):
2287         (TestPlatformInfo.tearDown):
2288         (TestPlatformInfo.test_basic):
2289         (TestPlatformInfo.integration_test_basic):
2290         (TestPlatformInfo.test_display_name_mac):
2291         (TestPlatformInfo.test_display_name_win32):
2292         (TestPlatformInfo.test_memory_mac):
2293         (TestPlatformInfo.test_memory_win32):
2294         (TestPlatformInfo.test_determine_os_name):
2295         (TestPlatformInfo.test_determine_mac_version):
2296         (TestPlatformInfo.test_determine_linux_version):
2297         (TestPlatformInfo.test_determine_win_version_from_tuple):
2298         (TestPlatformInfo.test_determine_win_version_from_cmd):
2299         * Scripts/webkitpy/layout_tests/port/apple.py:
2300         (ApplePort.__init__):
2301         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2302         (ChromiumMacPort.__init__):
2303         * Scripts/webkitpy/layout_tests/port/mac.py:
2304         (MacPort):
2305         * Scripts/webkitpy/layout_tests/port/win.py:
2306         (WinPort):
2307
2308 2012-01-10  Adam Roben  <aroben@apple.com>
2309
2310         Make it possible to type data: URLs into MiniBrowser on Windows
2311
2312         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
2313         MiniBrowser on Windows
2314
2315         Reviewed by Darin Adler.
2316
2317         * MiniBrowser/win/BrowserWindow.cpp:
2318         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
2319         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
2320         does, we assume it already has a scheme and don't modify it.
2321
2322 2012-01-10  Adam Roben  <aroben@apple.com>
2323
2324         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
2325
2326         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
2327         MiniBrowser on Windows
2328
2329         Reviewed by Darin Adler.
2330
2331         * MiniBrowser/win/BrowserView.cpp:
2332         (BrowserView::goToURL): Pass the typed string through
2333         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
2334
2335 2012-01-10  Ben Wells  <benwells@chromium.org>
2336
2337         Adding myself (benwells) to committers.py
2338         https://bugs.webkit.org/show_bug.cgi?id=75971
2339
2340         Reviewed by Ojan Vafai.
2341
2342         * Scripts/webkitpy/common/config/committers.py:
2343
2344 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
2345
2346         AX: support helpText() in DumpRenderTree
2347         https://bugs.webkit.org/show_bug.cgi?id=40193
2348
2349         Reviewed by Chris Fleizach.
2350
2351         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2352         (AccessibilityUIElement::helpText): Implemented.
2353
2354 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2355
2356         Unreviewed, rolling out r104572.
2357         http://trac.webkit.org/changeset/104572
2358         https://bugs.webkit.org/show_bug.cgi?id=75967
2359
2360         It broke zillion tests (Requested by Ossy on #webkit).
2361
2362         * DumpRenderTree/qt/EventSenderQt.cpp:
2363         (EventSender::EventSender):
2364         (EventSender::sendOrQueueEvent):
2365         (EventSender::replaySavedEvents):
2366         (EventSender::eventFilter):
2367         * DumpRenderTree/qt/EventSenderQt.h:
2368
2369 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
2370
2371         [Qt] fast/events/dont-loose-last-event test fails on WK1
2372         https://bugs.webkit.org/show_bug.cgi?id=73894
2373
2374         Reviewed by Simon Hausmann.
2375
2376         Empty the entire event queue when requested besides using
2377         sendEvent instead of postEvent to make sure all events were
2378         delivered.
2379         This commit also removes not working DRT code to handle drag and drop,
2380         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
2381
2382         * DumpRenderTree/qt/EventSenderQt.cpp:
2383         (EventSender::EventSender):
2384         (EventSender::sendOrQueueEvent):
2385         (EventSender::replaySavedEvents):
2386         * DumpRenderTree/qt/EventSenderQt.h:
2387
2388 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
2389
2390         [Qt] Enable CSS_FILTERS in Qt build
2391         https://bugs.webkit.org/show_bug.cgi?id=75777
2392
2393         Add the CSS_FILTERS feature flag to Qt.
2394
2395         Reviewed by Kenneth Rohde Christiansen.
2396
2397         * qmake/mkspecs/features/features.prf:
2398
2399 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2400
2401         [Qt] Unreviewed -Werror build fix.
2402
2403         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2404         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
2405         declaration.
2406
2407 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2408
2409         [Qt] Remove dependency to uitools
2410         https://bugs.webkit.org/show_bug.cgi?id=75952
2411
2412         Reviewed by Tor Arne Vestbø.
2413
2414         QUiLoader is used for creating QLabel/QProgressBar widgets for
2415         a layout test, to verify some widget embedding feature. Unfortunately
2416         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
2417         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
2418         let's break the circular dependency.
2419
2420         * DumpRenderTree/qt/DumpRenderTree.pro:
2421         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2422         (WebCore::WebPage::createPlugin):
2423         * QtTestBrowser/QtTestBrowser.pro:
2424         * QtTestBrowser/launcherwindow.h:
2425         * QtTestBrowser/webpage.cpp:
2426         (WebPage::createPlugin):
2427         * qmake/mkspecs/features/minimal_qt.prf:
2428         * qmake/mkspecs/features/uitools.prf: Removed.
2429
2430 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
2431
2432         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
2433         https://bugs.webkit.org/show_bug.cgi?id=75894
2434
2435         Reviewed by Tor Arne Vestbø.
2436
2437         * MiniBrowser/qt/MiniBrowserApplication.h:
2438         (MiniBrowserApplication::windowOptions):
2439         * MiniBrowser/qt/main.cpp:
2440         (main):
2441
2442 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2443
2444         [Qt] DRT crashes with Qt 5
2445         https://bugs.webkit.org/show_bug.cgi?id=75951
2446
2447         Reviewed by Ossy.
2448
2449         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
2450         Qt relies on font-config to define the default font family.
2451
2452 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
2453
2454         [Qt] REGRESSION(r100130): Clean build feature is broken.
2455         https://bugs.webkit.org/show_bug.cgi?id=75863
2456
2457         Reviewed by Tor Arne Vestbø.
2458
2459         * Scripts/webkitdirs.pm:
2460         (buildQMakeProject):
2461
2462 2012-01-10  Zeno Albisser  <zeno@webkit.org>
2463
2464         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
2465         https://bugs.webkit.org/show_bug.cgi?id=75885
2466
2467         In QML events are propagated through parents. But since the
2468         WebView may consume key events, a shortcut might never reach
2469         the top QtQuickItem.
2470         Therefore an application wide event handling function in C++
2471         needs to take care of shortcuts for MiniBrowser.
2472
2473         Reviewed by Kenneth Rohde Christiansen.
2474
2475         * MiniBrowser/qt/BrowserWindow.cpp:
2476         (BrowserWindow::reload):
2477         (BrowserWindow::focusAddressBar):
2478         * MiniBrowser/qt/BrowserWindow.h:
2479         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2480         (MiniBrowserApplication::notify):
2481         * MiniBrowser/qt/qml/BrowserWindow.qml:
2482
2483 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2484
2485         Add --efl alias for --platform=efl to run-webkit-test
2486         https://bugs.webkit.org/show_bug.cgi?id=75937
2487
2488         Reviewed by Andreas Kling.
2489         
2490         * Scripts/run-webkit-tests: Add --efl alias.
2491         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
2492         (parse_args):
2493
2494 2012-01-09  Dan Bernstein  <mitz@apple.com>
2495
2496         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
2497         https://bugs.webkit.org/show_bug.cgi?id=75920
2498
2499         Reviewed by Darin Adler.
2500
2501         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2502         (TestWebKitAPI::TEST): Added a test for a range in a
2503         -webkit-user-select: none; block.
2504
2505 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2506
2507         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
2508         https://bugs.webkit.org/show_bug.cgi?id=75884
2509
2510         Reviewed by Ryosuke Niwa.
2511
2512         Fix regression introduced (revealed?) in r104340. Chromium file         
2513         url syntax is different on win32 and the test results weren't           
2514         expecting that.                                                         
2515
2516         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2517         (TestExpectations._report_errors):
2518         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2519         (test_parse_error_nonfatal):
2520         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2521         (MockDRTTest.input_line):
2522         (MockChromiumDRTTest.test_pixeltest__fails):
2523         * Scripts/webkitpy/layout_tests/port/test.py:
2524         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2525         (TestRebaseliner.make_rebaseliner):
2526         (TestRebaseliner.test_one_platform):
2527         (TestRebaseliner.test_all_platforms):
2528         (TestRebaseliner.test_png_file_with_comment):
2529         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
2530         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
2531         (TestRealMain.test_all_platforms):
2532
2533 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2534
2535         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
2536
2537         Unreviewed, build fix.
2538
2539         test-webkitpy had a built-in self-test routine to verify that
2540         deleting the .pyc files worked correctly. When I removed the
2541         python24 directory in r104482, I broke the self-test.
2542
2543         I have deleted the self-test for now. Since I am reworking
2544         test-webkitpy I will make sure the new version is adequately
2545         tested.
2546
2547         * Scripts/test-webkitpy:
2548         (configure_logging):
2549         (_clean_pyc_files):
2550         (_clean_packages):
2551         (init):
2552
2553 2012-01-09  Justin Novosad  <junov@chromium.org>
2554
2555         [Chromium] remove all references to the legacy accelerated 2d Canvas
2556         implementation
2557         https://bugs.webkit.org/show_bug.cgi?id=75108
2558
2559         Purging an old settings flag that is no longer referenced
2560
2561         Reviewed by Darin Fisher.
2562
2563         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2564         (main):
2565         * DumpRenderTree/chromium/TestShell.cpp:
2566         (TestShell::TestShell):
2567         (TestShell::resetWebSettings):
2568         * DumpRenderTree/chromium/TestShell.h:
2569         (TestShell::setAccelerated2dCanvasEnabled):
2570         * DumpRenderTree/chromium/WebPreferences.cpp:
2571         (WebPreferences::reset):
2572         (WebPreferences::applyTo):
2573         * DumpRenderTree/chromium/WebPreferences.h:
2574
2575 2012-01-09  Adam Roben  <aroben@apple.com>
2576
2577         Convert Cygwin paths to Windows paths before passing them to DRT
2578
2579         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
2580         NRWT
2581
2582         I couldn't find a way to test this because I couldn't figure out how to override the
2583         cygpath function as it is used by WebKitDriver.
2584
2585         Reviewed by Dirk Pranke.
2586
2587         * Scripts/webkitpy/layout_tests/port/webkit.py:
2588         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
2589         Windows-style path before passing it to DRT.
2590
2591 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
2592
2593         webkitpy: revamp version checking
2594         https://bugs.webkit.org/show_bug.cgi?id=75765
2595
2596         Reviewed by Adam Barth.
2597
2598         The version-checking code in webkitpy/python24/versioning seems really
2599         awkward and overdesigned, especially since we don't support python 2.4
2600         any more.
2601
2602         In addition, I am tired of getting warnings about Python 2.6 being "a
2603         newer release than what is supported" :).
2604
2605         I'm taking a page from the depot_tools python code and just creating a
2606         new webkitpy.common.version_check module that will print a message on
2607         stderr and call sys.exit() if we're running an unsupported version.
2608
2609         * Scripts/check-webkit-style:
2610         * Scripts/new-run-webkit-httpd:
2611         * Scripts/new-run-webkit-tests:
2612         * Scripts/rebaseline-chromium-webkit-tests:
2613         * Scripts/test-webkitpy:
2614         (configure_logging):
2615         (init):
2616         * Scripts/webkit-patch:
2617         (main):
2618         * Scripts/webkitpy/common/system/executive.py:
2619         (Executive._child_process_encoding):
2620         (Executive._should_encode_child_process_arguments):
2621         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
2622         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2623         * Scripts/webkitpy/python24/__init__.py: Removed.
2624         * Scripts/webkitpy/python24/versioning.py: Removed.
2625         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
2626
2627 2012-01-09  Adam Barth  <abarth@webkit.org>
2628
2629         Remove Chromium Mac CG from the flakiness dashboard
2630         https://bugs.webkit.org/show_bug.cgi?id=75873
2631
2632         Reviewed by Ojan Vafai.
2633
2634         This configuration no longer exists.
2635
2636         * TestResultServer/static-dashboards/builders.js:
2637         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2638         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2639         (testOverrideJustBuildType):
2640         (testPlatformAndBuildType):
2641
2642 2012-01-06  Adam Roben  <aroben@apple.com>
2643
2644         Print an error message when NRWT can't run Apache
2645
2646         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
2647
2648         Reviewed by Dirk Pranke.
2649
2650         * Scripts/webkitpy/layout_tests/port/base.py:
2651         (Port.check_httpd): Print an error message when Apache returns an error code instead of
2652         failing silently.
2653
2654         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2655         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
2656         run Apache.
2657         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
2658         fails.
2659
2660 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
2661
2662         [Gtk][ARM] Cross compiler buildbot is failing after r103040
2663         https://bugs.webkit.org/show_bug.cgi?id=75846
2664
2665         Reviewed by Philippe Normand.
2666
2667         * Scripts/webkitdirs.pm:
2668         (runAutogenForAutotoolsProjectIfNecessary):
2669
2670 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
2671
2672         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
2673         https://bugs.webkit.org/show_bug.cgi?id=75807
2674
2675         This patch adds a new icon to navigationbar of the Qt MiniBrowser
2676         which allows you to dynamically toggle whether touch mocking is
2677         enabled or disabled.
2678
2679         Reviewed by Tor Arne Vestbø.
2680
2681         * MiniBrowser/qt/MiniBrowser.qrc:
2682         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2683         (MiniBrowserApplication::notify):
2684         * MiniBrowser/qt/MiniBrowserApplication.h:
2685         (WindowOptions::WindowOptions):
2686         (WindowOptions::touchMockingEnabled):
2687         (WindowOptions::setTouchMockingEnabled):
2688         * MiniBrowser/qt/icons/touch.png: Added.
2689         * MiniBrowser/qt/qml/BrowserWindow.qml:
2690
2691 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2692
2693         Unreviewed. Fix make distcheck issues.
2694
2695         * MiniBrowser/gtk/GNUmakefile.am:
2696
2697 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2698
2699         Unreviewed, rolling out r104421.
2700         http://trac.webkit.org/changeset/104421
2701         https://bugs.webkit.org/show_bug.cgi?id=75816
2702
2703         Need to rebaseline some tests on Linux (Requested by noamr on
2704         #webkit).
2705
2706         * qmake/mkspecs/features/features.prf:
2707
2708 2012-01-08  Adam Barth  <abarth@webkit.org>
2709
2710         Remove support for Chromium Mac CG from garden-o-matic
2711         https://bugs.webkit.org/show_bug.cgi?id=75814
2712
2713         Reviewed by Eric Seidel.
2714
2715         This configuration no longer exists.  This patch is mostly a matter of
2716         updating config.js and removing the examples from the unit tests.
2717
2718         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2723
2724 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2725
2726         [Qt] Enable CSS_FILTERS in Qt build
2727         https://bugs.webkit.org/show_bug.cgi?id=75777
2728
2729         Add the CSS_FILTERS feature flag to Qt.
2730
2731         Reviewed by Kenneth Rohde Christiansen.
2732
2733         * qmake/mkspecs/features/features.prf:
2734
2735 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2736
2737         Categorize bots by ports instead of core/non-core separation
2738         https://bugs.webkit.org/show_bug.cgi?id=75766
2739
2740         Reviewed by Eric Seidel.
2741
2742         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
2743         (Chromium still comes before GTK and Qt).
2744
2745         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2746         (loadBuilderConfig):
2747         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2748
2749 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2750
2751         Remove the concept of core builders from webkitpy
2752         https://bugs.webkit.org/show_bug.cgi?id=75809
2753
2754         Reviewed by Ryosuke Niwa.
2755
2756         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
2757         and remove the relevant code.
2758
2759         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2760         (BuildBot.__init__):
2761         (BuildBot._matches_regexps):
2762         (BuildBot._builder_statuses_with_names_matching_regexps):
2763         (BuildBot.builder_statuses):
2764         (BuildBot.failure_map):
2765         (BuildBot._latest_builds_from_builders):
2766         (BuildBot.last_green_revision):
2767         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2768         (MockBuildBot.builder_statuses):
2769         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2770         (test_status_parsing):
2771         (test_last_green_revision):
2772         (test_last_green_revision.mock_builds_from_builders):
2773
2774 2012-01-08  Adam Barth  <abarth@webkit.org>
2775
2776         Remove Chromium Mac CG concept from webkitpy
2777         https://bugs.webkit.org/show_bug.cgi?id=75810
2778
2779         Reviewed by Ryosuke Niwa.
2780
2781         This configuration no longer exists.  We can remove all the supporting
2782         code from webkitpy.
2783
2784         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2785         (BaselineOptimizerTest.test_move_baselines):
2786         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
2787         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
2788         (BaselineOptimizerTest.test_common_directory_includes_root):
2789         (BaselineOptimizerTest.test_complex_shadowing):
2790         * Scripts/webkitpy/common/config/build.py:
2791         (_should_file_trigger_build):
2792         * Scripts/webkitpy/common/config/build_unittest.py:
2793         (ShouldBuildTest):
2794         * Scripts/webkitpy/layout_tests/port/builders.py:
2795         * Scripts/webkitpy/layout_tests/port/chromium.py:
2796         (ChromiumPort):
2797         (ChromiumPort._generate_all_test_configurations):
2798         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2799         (_default_tests_paths):
2800         (ChromiumGpuLinuxPort.tests):
2801         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2802         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
2803         (ChromiumGpuTest.assert_port_works):
2804         (ChromiumGpuTest.test_baseline_paths):
2805         (ChromiumGpuTest.test_graphics_type):
2806         (ChromiumGpuTest.test_default_tests_paths):
2807         (ChromiumGpuTest.test_test_files):
2808         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2809         (ChromiumMacPort):
2810         (ChromiumMacPort.__init__):
2811         (ChromiumMacPort.baseline_search_path):
2812         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2813         (ChromiumMacPortTest.test_graphics_type):
2814         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2815         (ChromiumPortTest.test_all_test_configurations):
2816         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2817         * Scripts/webkitpy/layout_tests/port/factory.py:
2818         (PortFactory._port_name_from_arguments_and_options):
2819         (PortFactory.get):
2820         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2821         (FactoryTest.test_chromium_gpu_mac):
2822         (FactoryTest.test_chromium_mac):
2823         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2824         (GetGoogleChromePortTest._verify_expectations_overrides):
2825         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2826         (MockChromiumDRTTest.test_chromium_parse_options):
2827         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2828         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2829         (test_url_fetcher):
2830         (test_zip_factory):
2831         (test_archive):
2832         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2833         (TestRebaseline.test_rebaseline_expectations):
2834
2835 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2836
2837         Categorize bots by ports instead of core/non-core separation
2838         https://bugs.webkit.org/show_bug.cgi?id=75766
2839
2840         Reviewed by Adam Barth.
2841
2842         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
2843
2844         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2845         (loadBuilderConfig):
2846         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2847
2848 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2849
2850         Unreviewed, rolling out r104403.
2851         http://trac.webkit.org/changeset/104403
2852         https://bugs.webkit.org/show_bug.cgi?id=75803
2853
2854         It broke all tests on Qt5 (Requested by Ossy_weekend on
2855         #webkit).
2856
2857         * qmake/mkspecs/features/features.prf:
2858
2859 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2860
2861         [Qt] Enable CSS_FILTERS in Qt build
2862         https://bugs.webkit.org/show_bug.cgi?id=75777
2863
2864         Add the CSS_FILTERS feature flag to Qt.
2865
2866         Reviewed by Kenneth Rohde Christiansen.
2867
2868         * qmake/mkspecs/features/features.prf:
2869
2870 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2871
2872         Rewrite the CSS parser of prepare-ChangeLog with unittests.
2873         https://bugs.webkit.org/show_bug.cgi?id=75202
2874
2875         Reviewed by David Kilzer.
2876
2877         The current CSS parser can just parse simple CSSes like
2878
2879             foo bar baz {
2880                 property1: value;
2881                 property2: value;
2882             }
2883
2884         , and cannot parse comments nor a CSS in which a selector and {
2885         appears in different lines. This patch rewrites the CSS parser
2886         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
2887         shown in css_unittests.css.
2888
2889         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
2890
2891         * Scripts/prepare-ChangeLog:
2892         (get_selector_line_ranges_for_css):
2893         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2894         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
2895         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
2896         (element1):
2897         (element2):
2898         (element3):
2899         (element4.p):
2900         (element5.p.q.r.s):
2901         (element6#p):
2902         (element7 element8):
2903         (element9.p element10.q):
2904         (element11#p element12#q):
2905         (element13, element14):
2906         (.p):
2907         (#p):
2908         (.p element15 #q element16.r element17#s):
2909         (element18:target):
2910         (element19):
2911         (element20):
2912         (element21):
2913         (element22):
2914
2915 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2916
2917         The Perl parser of prepare-ChangeLog can parse here-documents
2918         https://bugs.webkit.org/show_bug.cgi?id=73208
2919
2920         Reviewed by David Kilzer.
2921
2922         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
2923         which results in wrong subroutine names in ChangeLogs.
2924         With this patch, prepare-ChangeLog can judge whether the line of "}"
2925         is the end of a subroutine or a line inside a here-document.
2926
2927         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
2928
2929         * Scripts/prepare-ChangeLog:
2930         (get_function_line_ranges_for_perl):
2931         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2932         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2933         Added test cases for here-documents.
2934         (func7):
2935         (func8):
2936         (func9):
2937         (func10):
2938         (func11):
2939         (func12):
2940         (func13):
2941         (func14):
2942         (func15):
2943         (func16):
2944
2945 2012-01-08  Kentaro Hara  <haraken@chromium.org>
2946
2947         Add unittests for the JavaScript parser of prepare-ChangeLog
2948         https://bugs.webkit.org/show_bug.cgi?id=75201
2949
2950         Reviewed by David Kilzer.
2951
2952         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
2953         of prepare-ChangeLog.
2954
2955         * Scripts/prepare-ChangeLog:
2956         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
2957         omitted from parsing. Thus,
2958
2959             str = "foo"
2960             function func() {
2961             }
2962
2963         was recognized as equivalent to
2964
2965             str = function func() {
2966             }
2967
2968         This patch replaces a string with a dummy identifier 'string_appeared_here'
2969         to tell the parser that a string appeared there.
2970
2971         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2972         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
2973         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
2974         (func1):
2975         (func2):
2976         (func3):
2977         (func4):
2978         (func5):
2979         (func6):
2980         (func7):
2981         (func8):
2982         (func9):
2983         (func10):
2984         (func11):
2985         (func12):
2986         (funcOverloaded):
2987         (Func1.prototype.get x1):
2988         (Func1.prototype.get x2):
2989         (Func1.prototype.set x1):
2990         (Func1.prototype.set x3):
2991         (Func2.prototype.func13):
2992         (Func2.prototype.func14):
2993         (Func2.prototype.func15):
2994         (func16.func17):
2995         (func16.func18):
2996         (func16.func19):
2997         (func16):
2998
2999 2012-01-08  David Levin  <levin@chromium.org>
3000
3001         [chromium] Add layout test support for autosize code in FrameView.
3002         https://bugs.webkit.org/show_bug.cgi?id=73631
3003
3004         Reviewed by Dmitry Titov.
3005
3006         * DumpRenderTree/chromium/LayoutTestController.cpp:
3007         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
3008         (LayoutTestController::reset): Set the autoresize mode back to false.
3009         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
3010         * DumpRenderTree/chromium/LayoutTestController.h:
3011         * DumpRenderTree/chromium/WebViewHost.cpp:
3012         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
3013         * DumpRenderTree/chromium/WebViewHost.h:
3014
3015 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
3016
3017         [WK2][GTK] Each test takes roughly half a second to load
3018         https://bugs.webkit.org/show_bug.cgi?id=70699
3019
3020         Reviewed by Martin Robinson.
3021
3022         Set the XDG_CACHE_HOME environment variable when testing with
3023         WebKitTestRunner. This way the testing is started with a non-existing
3024         application cache. If the cache exists and is not empty, the emptying
3025         and vacuuming that is performed before every test can consume a lot of
3026         time.
3027
3028         This is just a temporary workaround until it becomes possible to set
3029         a desired directory to be used as the application cache location through
3030         WebKitWebContext.
3031
3032         * Scripts/webkitpy/layout_tests/port/gtk.py:
3033         (GtkPort.setup_environ_for_server):
3034
3035 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
3036
3037         [GTK] Enable requestAnimationFrame in build-webkit
3038         https://bugs.webkit.org/show_bug.cgi?id=75773
3039
3040         Reviewed by Martin Robinson.
3041
3042         Enable requestAnimationFrame for the Gtk port.
3043
3044         * Scripts/build-webkit:
3045
3046 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
3047
3048         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
3049
3050         * Scripts/webkitdirs.pm:
3051         (buildChromium):
3052         Missing parentheses.
3053
3054 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3055
3056         Fix DRT build on case-sensitive file systems.
3057
3058         Fix case of include of WebDynamicScrollBarsView.h
3059         
3060         * DumpRenderTree/mac/DumpRenderTree.mm:
3061
3062 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3063
3064         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
3065         https://bugs.webkit.org/show_bug.cgi?id=75662
3066
3067         Reviewed by Dan Bernstein.
3068         
3069         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
3070         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
3071         test window uses the main display's color space, so that the pixel values in the bitmap
3072         that gets checksummed are identical to the CSS colors.
3073         
3074         Removed the code that switches the display profile in DRT, since that is no longer required.
3075
3076         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
3077         * DumpRenderTree/mac/DumpRenderTree.mm:
3078         (crashHandler): Remove code that switches display profiles.
3079         (prepareConsistentTestingEnvironment): Ditto.
3080         (dumpRenderTree): Ditto.
3081         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
3082         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
3083         (createBitmapContextFromWebView): Add comment about the colorspace handling.
3084         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3085         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
3086         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
3087         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3088         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
3089         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
3090
3091 2012-01-06  David Kilzer  <ddkilzer@apple.com>
3092
3093         run-api-tests: specify individual suites and tests on the command-line
3094
3095         Reviewed by Adam Roben.
3096
3097         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3098
3099         The run-api-tests script will now accept a list of arguments on
3100         the command-line that are used as prefix filters.  To run all
3101         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
3102         use:
3103
3104             $ run-api-tests WTF
3105
3106         To run only the tests in the "WTF" suite, not the "WTF_Vector"
3107         suite, use:
3108
3109             $ run-api-tests WTF.
3110
3111         * Scripts/run-api-tests: Filter tests if any prefix arguments
3112         are passed on the command-line.
3113
3114 2012-01-06  David Kilzer  <ddkilzer@apple.com>
3115
3116         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
3117
3118         Reviewed by Adam Roben.
3119
3120         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3121
3122         * Scripts/run-api-tests:
3123         (dumpTestsBySuite): Update to accept array of tests instead of
3124         hash data structure.
3125         (runTestsBySuite): Ditto.
3126         (listAllTests): Rename from populateTests().  Update to return
3127         an array of tests instad of the hash data structure.
3128
3129 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3130
3131         webkitpy: clean up test/uri conversion routines
3132         https://bugs.webkit.org/show_bug.cgi?id=75648
3133
3134         Reviewed by Eric Seidel.
3135
3136         This change moves test_to_uri and uri_to_test from the Port
3137         class to the Driver class (the routines were only being
3138         called by the drivers), and removes a bunch of stale and/or
3139         busted logic.
3140
3141         * Scripts/webkitpy/layout_tests/port/base.py:
3142         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3143         * Scripts/webkitpy/layout_tests/port/chromium.py:
3144         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3145         * Scripts/webkitpy/layout_tests/port/driver.py:
3146         (is_http_test):
3147         (test_to_uri):
3148         (uri_to_test):
3149         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3150         (run_one_test):
3151         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3152         (MockDRTTest.input_line):
3153         (input_line):
3154         (expected_output):
3155         * Scripts/webkitpy/layout_tests/port/test.py:
3156         * Scripts/webkitpy/layout_tests/port/webkit.py:
3157         (_command_from_driver_input):
3158
3159 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3160
3161         Mitigate scrollbar differences when running pixel tests
3162         https://bugs.webkit.org/show_bug.cgi?id=67217
3163
3164         Reviewed by Dan Bernstein.
3165         
3166         Add an NSScroller subclass that draws mock scrollbars identically
3167         to the WebCore mock scrollbar theme, and register it with the
3168         WebDynamicScrollbarsView.
3169
3170         * DumpRenderTree/mac/DumpRenderTree.mm:
3171         (-[DRTMockScroller rectForPart:]):
3172         (-[DRTMockScroller drawKnob]):
3173         (-[DRTMockScroller drawRect:]):
3174         (registerMockScrollbars):
3175         (prepareConsistentTestingEnvironment):
3176
3177 2012-01-05  Jon Lee  <jonlee@apple.com>
3178
3179         Update DRT on Mac to draw resize handles on text areas.
3180
3181         Reviewed by John Sullivan.
3182
3183         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
3184         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
3185
3186         * DumpRenderTree/mac/DumpRenderTree.mm:
3187         (resetDefaultsToConsistentValues):
3188
3189 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3190
3191         [Qt] Move listing of include paths and libs to pri files in sources
3192
3193         Includepaths are sometimes modified by non-Qt contributors so keeping
3194         them in files inside Sources makes it more likely that they are updated
3195         along with project files for the other ports.
3196
3197         Using pri files instead of prf files for this also has the benefit that
3198         the include() from the main target file can be parsed and followed by
3199         Qt Creator -- something that does not work with load().
3200
3201         Dependency from a target to a library through the WEBKIT variable are
3202         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
3203         set the source root of the module and include the right pri file.
3204
3205         Ideally we'd use the variant of include() that takes an optional
3206         namespace to read the variables into, or the fromfile() function,
3207         but both of these add an overhead of about 40% on the total qmake
3208         runtime, due to making a deep copy of all the variables in the
3209         project or re-reading all the prf files from scratch.
3210
3211         Reviewed by Simon Hausmann.
3212         Reviewed by Ossy.
3213
3214         * qmake/mkspecs/features/default_post.prf:
3215         * qmake/mkspecs/modules/javascriptcore.prf: Added.
3216         * qmake/mkspecs/modules/webcore.prf: Added.
3217         * qmake/mkspecs/modules/webkit2.prf: Added.
3218         * qmake/mkspecs/modules/wtf.prf: Added.
3219
3220 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
3221
3222         [EFL] Add pre-render handling code in EWebLauncher.
3223         https://bugs.webkit.org/show_bug.cgi?id=73430
3224
3225         Reviewed by Zoltan Herczeg.
3226
3227         Add pre-render handling code by pressing Insert key.
3228
3229         * EWebLauncher/main.c:
3230         (on_key_down):
3231
3232 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
3233
3234         NRWT should use test_expectation.txt on wk2 platforms
3235         https://bugs.webkit.org/show_bug.cgi?id=75417
3236
3237         Reviewed by Dirk Pranke.
3238
3239         * Scripts/webkitpy/layout_tests/port/webkit.py:
3240         (path_to_test_expectations_file):
3241         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3242         (test_path_to_test_expectations_file):
3243
3244 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
3245
3246         Don't hardcode expected file URIs in as they depend on the platform
3247         https://bugs.webkit.org/show_bug.cgi?id=75666
3248
3249         Reviewed by Dirk Pranke.
3250
3251         * Scripts/webkitpy/layout_tests/port/win.py:
3252         (WinPort.show_results_html_file):
3253         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3254         (MainTest.test_unexpected_failures):
3255         (MainTest.test_results_directory_default):
3256         (MainTest.test_results_directory_relative):
3257
3258 2012-01-05  Anders Carlsson  <andersca@apple.com>
3259
3260         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
3261         https://bugs.webkit.org/show_bug.cgi?id=75667
3262         <rdar://problem/10389454>
3263
3264         Reviewed by Kevin Decker.
3265
3266         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
3267
3268         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3269         (PluginTest::executeScript):
3270         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3271         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
3272         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
3273         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
3274         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
3275
3276 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3277
3278         webkitpy: clean up port factory methods
3279         https://bugs.webkit.org/show_bug.cgi?id=75590
3280
3281         Reviewed by Eric Seidel.
3282
3283         This change consolidates much of the "factory method" logic
3284         of determining which port objects to create for a given set
3285         of configurations by merging the separate factory methods in
3286         chromium_gpu and google_chrome into PortFactory so that at least
3287         all of the logic is in one place.
3288
3289         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3290         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3291         * Scripts/webkitpy/layout_tests/port/factory.py:
3292         (_port_name_from_arguments_and_options):
3293         (get):
3294         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3295         (test_google_chrome):
3296         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3297         (GoogleChromeLinux32Port):
3298         (GoogleChromeLinux32Port.baseline_search_path):
3299         (test_expectations_overrides):
3300         (architecture):
3301         (GoogleChromeLinux64Port):
3302         (GoogleChromeLinux64Port.baseline_search_path):
3303         (GoogleChromeMacPort):
3304         (GoogleChromeMacPort.baseline_search_path):
3305         (GoogleChromeWinPort):
3306         (GoogleChromeWinPort.baseline_search_path):
3307         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3308         (_verify_baseline_path):
3309
3310 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
3311
3312         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
3313         https://bugs.webkit.org/show_bug.cgi?id=75617
3314
3315         Reviewed by Dirk Pranke.
3316
3317         * Scripts/webkitpy/common/system/filesystem.py:
3318         (FileSystem.exists):
3319         * Scripts/webkitpy/common/system/filesystem_mock.py:
3320         (MockFileSystem.exists):
3321         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3322         (GenericFileSystemTests.teardown_generic_test_dir):
3323         * Scripts/webkitpy/layout_tests/port/base.py:
3324         (Port.to.show_results_html_file):
3325         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3326         (MainTest.test_results_directory_absolute):
3327
3328 2012-01-05  Adam Roben  <aroben@apple.com>
3329
3330         Remove some unnecessary code from old-run-webkit-tests
3331
3332         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
3333         WebKitTestRunner.
3334
3335         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
3336         Windows
3337
3338         Reviewed by Eric Seidel.
3339
3340         * Scripts/old-run-webkit-tests:
3341         (top level):
3342         (openDumpTool):
3343         Removed calls to setPathForRunningWebKitApp.
3344
3345 2012-01-05  Adam Roben  <aroben@apple.com>
3346
3347         Teach NRWT to use run-safari to open results.html on Apple's Windows port
3348
3349         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
3350         better, since we always want to open results.html using the user's build of WebKit, not
3351         whatever their default browser is.
3352
3353         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
3354         for Apple's Windows port
3355
3356         Reviewed by Eric Seidel.
3357
3358         * Scripts/webkitpy/layout_tests/port/win.py:
3359         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
3360         an obsolete comment.
3361
3362         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3363         (WinPortTest.test_show_results_html_file): Updated expected results.
3364
3365 2012-01-05  Adam Roben  <aroben@apple.com>
3366
3367         Prepend Safari.exe's path to the command-line passed to CreateProcess
3368
3369         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
3370         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
3371         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
3372         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
3373         first argument that WebKitLauncherWin was trying to pass to it.
3374
3375         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
3376
3377         Reviewed by Steve Falkenburg.
3378
3379         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3380         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
3381         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
3382
3383 2012-01-05  Adam Roben  <aroben@apple.com>
3384
3385         Stop using explicit memory management in WebKitLauncherWin
3386
3387         We now use stack-allocated STL objects instead.
3388
3389         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
3390         Safari
3391
3392         Reviewed by Steve Falkenburg.
3393
3394         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3395         (getStringValue):
3396         (applePathFromRegistry):
3397         (safariInstallDir):
3398         (safariBrowserExe):
3399         (_tWinMain):
3400         Changed to use stack-allocated STL objects instead of malloc/free.
3401
3402 2012-01-05  Adam Roben  <aroben@apple.com>
3403
3404         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
3405
3406         This allows us to add the Safari and Apple Application Support directories to PATH before
3407         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3408
3409         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3410         Windows port of DumpRenderTree/WebKitTestRunner
3411
3412         Reviewed by Steve Falkenburg.
3413
3414         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
3415         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
3416
3417         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3418         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3419         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
3420
3421         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
3422         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
3423         the stub launcher.
3424
3425         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
3426         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
3427         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
3428         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
3429         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
3430         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
3431         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
3432
3433         * WebKitTestRunner/win/main.cpp:
3434         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3435
3436 2012-01-05  Adam Roben  <aroben@apple.com>
3437
3438         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
3439
3440         This allows us to add the Safari and Apple Application Support directories to PATH before
3441         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3442
3443         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3444         Windows port of DumpRenderTree/WebKitTestRunner
3445
3446         Reviewed by Steve Falkenburg.
3447
3448         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
3449         which I forgot to add to this .sln when that project was created.
3450
3451         * DumpRenderTree/win/DumpRenderTree.cpp:
3452         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3453
3454         * DumpRenderTree/win/DumpRenderTree.vcproj:
3455         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3456         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
3457
3458         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
3459         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
3460         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
3461         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
3462         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
3463         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
3464         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
3465         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
3466
3467         * win/DLLLauncher/DLLLauncherMain.cpp:
3468         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
3469         Safari's directory to PATH so that SafariTheme.dll can be found.
3470
3471         (main):
3472         (wWinMain):
3473         Changed to use the new modifyPath function.
3474
3475 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3476
3477         [Qt] Never enable FontConfig on Mac OS X
3478         https://bugs.webkit.org/show_bug.cgi?id=75616
3479
3480         Reviewed by Tor Arne Vestbø.
3481
3482         * qmake/mkspecs/features/features.prf:
3483
3484 2012-01-05  Alpha Lam  <hclam@chromium.org>
3485
3486         Unreviewed, rolling out r104159.
3487         http://trac.webkit.org/changeset/104159
3488         https://bugs.webkit.org/show_bug.cgi?id=75590
3489
3490         Chromium port GPU tests cannot be executed.
3491
3492         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3493         (get):
3494         (_default_tests_paths):
3495         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3496         (ChromiumGpuTest.assert_port_works):
3497         * Scripts/webkitpy/layout_tests/port/factory.py:
3498         (PortFactory._port_name_from_arguments_and_options):
3499         (PortFactory):
3500         (PortFactory._get_kwargs):
3501         (PortFactory.get):
3502         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3503         (FactoryTest.test_google_chrome.names):
3504         (FactoryTest.test_google_chrome):
3505         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3506         (GetGoogleChromePort):
3507         (GetGoogleChromePort.GoogleChromeLinux32Port):
3508         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
3509         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
3510         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
3511         (GetGoogleChromePort.GoogleChromeLinux64Port):
3512         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
3513         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
3514         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
3515         (GetGoogleChromePort.GoogleChromeMacPort):
3516         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
3517         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
3518         (GetGoogleChromePort.GoogleChromeWinPort):
3519         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
3520         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
3521         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3522         (GetGoogleChromePortTest._verify_baseline_path):
3523         (GetGoogleChromePortTest._verify_expectations_overrides):
3524
3525 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3526
3527         webkitpy: clean up port factory methods
3528         https://bugs.webkit.org/show_bug.cgi?id=75590
3529
3530         Reviewed by Eric Seidel.
3531
3532         This change consolidates much of the "factory method" logic
3533         of determining which port objects to create for a given set
3534         of configurations by merging the separate factory methods in
3535         chromium_gpu and google_chrome into PortFactory so that at least
3536         all of the logic is in one place.
3537
3538         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3539         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3540         * Scripts/webkitpy/layout_tests/port/factory.py:
3541         (_port_name_from_arguments_and_options):
3542         (get):
3543         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3544         (test_google_chrome):
3545         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3546         (GoogleChromeLinux32Port):
3547         (GoogleChromeLinux32Port.baseline_search_path):
3548         (test_expectations_overrides):
3549         (architecture):
3550         (GoogleChromeLinux64Port):
3551         (GoogleChromeLinux64Port.baseline_search_path):
3552         (GoogleChromeMacPort):
3553         (GoogleChromeMacPort.baseline_search_path):
3554         (GoogleChromeWinPort):
3555         (GoogleChromeWinPort.baseline_search_path):
3556         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3557         (_verify_baseline_path):
3558
3559 2012-01-04  Adam Roben  <aroben@apple.com>
3560
3561         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
3562
3563         This allows us to add the Apple Application Support directory to PATH before trying to load
3564         WebKit so that CoreGraphics.dll and friends can be found.
3565
3566         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
3567
3568         Reviewed by Anders Carlsson.
3569
3570         * DumpRenderTree/win/ImageDiff.vcproj:
3571         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3572         Changed to build ImageDiff.dll instead of ImageDiff.exe.
3573
3574         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
3575         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
3576
3577         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
3578         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
3579         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
3580         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
3581         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
3582         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
3583         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
3584
3585         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
3586         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
3587         to main.
3588
3589         * win/DLLLauncher/DLLLauncherMain.cpp:
3590         (main):
3591         (wWinMain):
3592         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
3593         stub launcher acts as a console program and calls a console version of
3594         dllLauncherEntryPoint.
3595
3596 2012-01-04  Adam Roben  <aroben@apple.com>
3597
3598         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
3599
3600         This allows us to add the Apple Application Support directory to PATH before trying to load
3601         WebKit so that CoreGraphics.dll and friends can be found.
3602
3603         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
3604         double-clicked
3605
3606         Reviewed by Anders Carlsson.
3607
3608         * MiniBrowser/MiniBrowser.vcproj:
3609         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3610         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
3611
3612         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
3613         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
3614         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
3615         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
3616         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
3617         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
3618         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
3619
3620         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
3621         but changed to build the stub launcher.
3622
3623         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
3624         it needs to be compiled into the .exe instead of the .dll.
3625         (DllMain): Added. We use this to store the DLL's HINSTANCE.
3626         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
3627         DLLLauncherMain code.
3628
3629         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
3630         to here.
3631
3632 2012-01-04  Adam Roben  <aroben@apple.com>
3633
3634         Make WinLauncher's window frame respond to clicks/drags again
3635
3636         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
3637         bar when Aero is disabled
3638
3639         Reviewed by Brent Fulgham.
3640
3641         * WinLauncher/WinLauncher.cpp:
3642         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
3643         Also removed an unnecessary "break" keyword.
3644
3645 2012-01-04  Adam Roben  <aroben@apple.com>
3646
3647         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
3648
3649         This allows us to add the Apple Application Support directory to PATH before trying to load
3650         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
3651         should use this mechanism.
3652
3653         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
3654         double-clicked
3655
3656         Reviewed by Anders Carlsson.
3657
3658         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
3659         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
3660         done by the now-removed InitInstance function.
3661         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
3662         calls. Merged code from InitInstance into this function, and change to use the global hInst
3663         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
3664         function, which corresponds to WinLauncher.exe.
3665
3666         * WinLauncher/WinLauncher.vcproj:
3667         * WinLauncher/WinLauncherCommon.vsprops:
3668         Changed to build WinLauncher.dll instead of WinLauncher.exe.
3669
3670         * WinLauncher/WinLauncherLauncher.rc: Added.
3671         * WinLauncher/WinLauncherLauncherResource.h: Added.
3672         This just references the WinLauncher.ico file to set the application icon (though it looks
3673         like that's a default icon).
3674
3675         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
3676         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
3677
3678         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
3679         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
3680         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
3681         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
3682         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
3683         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
3684         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
3685
3686         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
3687         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
3688         program if it detects heap corruption.
3689         (getStringValue): Helper function to read a string value from the registry.
3690         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
3691         application from the registry.
3692         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
3693         Application Support directory.
3694         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
3695         (prependPath): Helper function to prepend a directory to the PATH.
3696         (fatalError): Helper function to display an error to the user.
3697         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
3698         dllLauncherEntryPoint function.
3699
3700 2012-01-05  Kentaro Hara  <haraken@chromium.org>
3701
3702         prepare-ChangeLog cannot parse python code that nests classes and defs
3703         https://bugs.webkit.org/show_bug.cgi?id=75524
3704
3705         Reviewed by Ryosuke Niwa.
3706
3707         This patch fixes the python parser of prepare-ChangeLog so that it can parse
3708         python code that nests classes and defs, like this:
3709
3710         class C:
3711             pass
3712             def f():
3713                 pass
3714             pass
3715
3716         Also, this patch fixes the python parser so that it inserts a dummy line
3717         at the end of the file to pop out all popped scopes.
3718
3719         * Scripts/prepare-ChangeLog:
3720         (get_function_line_ranges_for_python):
3721
3722         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
3723         Added test cases that nest classes and defs.
3724         (func7):
3725         (func7.func8):
3726         (func7.func8.func9):
3727         (Class2):
3728         (Class2.Class3):
3729         (Class2.Class3.Class4):
3730         (Class5):
3731         (Class5.func10):
3732         (Class5.func11):
3733         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
3734
3735 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3736
3737         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
3738         https://bugs.webkit.org/show_bug.cgi?id=75433
3739
3740         Reviewed by Martin Robinson.
3741
3742         * MiniBrowser/gtk/BrowserWindow.c:
3743         (webViewLoadFailed): Reset the progress bar when load fails.
3744         (browserWindowConstructed): Connect to load-failed signal.
3745
3746 2012-01-04  Dan Bernstein  <mitz@apple.com>
3747
3748         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
3749         start WebProcess under gdb and WebProcess will then run the client executable.
3750
3751         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
3752
3753         Reviewed by Anders Carlsson.
3754
3755         * Scripts/webkitdirs.pm:
3756         (shouldTargetWebProcess): Added.
3757         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
3758         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
3759         app using the -client-executable option if targeting the web process.
3760
3761 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3762
3763         Adding myself to committers list.
3764
3765         Unreviewed.
3766
3767         * Scripts/webkitpy/common/config/committers.py:
3768
3769 2012-01-04  David Kilzer  <ddkilzer@apple.com>
3770
3771         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
3772
3773         This reverts commit r103546.
3774
3775         * TestWebKitAPI/TestsController.cpp:
3776         (TestWebKitAPI::TestsController::TestsController):
3777
3778 2012-01-04  James Robinson  <jamesr@chromium.org>
3779
3780         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
3781         https://bugs.webkit.org/show_bug.cgi?id=74583
3782
3783         Reviewed by Darin Fisher.
3784
3785         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
3786
3787         * Scripts/webkitpy/style/checkers/cpp.py:
3788         (check_function_definition):
3789
3790 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3791
3792         [Qt] Fix link order of static libraries and unbreak QtWin32
3793
3794         We were keeping the correct static link order between the intermediate
3795         WebKit libraries, but not the internal dependencies for each of those
3796         libraries. The load() will in some instances mess with LIBS, so we need
3797         to ensure that the dependent libraries are added after the library we
3798         are linking against.
3799
3800         Reviewed by Simon Hausmann.
3801
3802         * qmake/mkspecs/features/default_post.prf:
3803
3804 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3805
3806         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
3807
3808         The custom qmake variable 'WEBKIT' is used for signaling that a
3809         target depends in some way on other subproject of the WebKit
3810         project. For now this is limited to the set of intermediate
3811         libraries: wtf, javascriptcore, webcore, and webkit2.
3812
3813         This replaces the previous convension of using load(foo) for
3814         just include paths, and CONFIG += foo to also link against foo.
3815
3816         Adding a dependency results in additional include paths being
3817         available, and potentially linking to the library. This is
3818         decided by the build system based on conditions such as what
3819         kind of target is being built and the general build config.
3820
3821         An advantage to his approach is that it simplifies the individual
3822         foo.prf files, for example by allowing us to use INCLUDEPATH +=
3823         and LIBS += as normal instead of prepending.
3824
3825         Reviewed by Simon Hausmann.
3826
3827         * DumpRenderTree/qt/DumpRenderTree.pro:
3828         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3829         * QtTestBrowser/QtTestBrowser.pro:
3830         * WebKitTestRunner/InjectedBundle/Target.pri:
3831         * WebKitTestRunner/Target.pri:
3832         * qmake/README:
3833         * qmake/mkspecs/features/default_post.prf:
3834         * qmake/mkspecs/features/functions.prf:
3835         * qmake/mkspecs/features/javascriptcore.prf:
3836         * qmake/mkspecs/features/qtwebkit.prf:
3837         * qmake/mkspecs/features/webcore.prf:
3838         * qmake/mkspecs/features/webkit2.prf:
3839         * qmake/mkspecs/features/wtf.prf:
3840
3841 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
3842
3843         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
3844         https://bugs.webkit.org/show_bug.cgi?id=75488
3845
3846         Reviewed by Tor Arne Vestbø.
3847
3848         * MiniBrowser/qt/MiniBrowser.qrc:
3849         * MiniBrowser/qt/qml/BrowserWindow.qml:
3850         * MiniBrowser/qt/qml/Dialog.qml:
3851         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3852         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3853
3854 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3855
3856         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
3857
3858         It wasn't really a problem at runtime since the right QtWebKit was
3859         already loaded as a dependency of the web process, but the ldd output
3860         would still be busted.
3861
3862         Reviewed by Simon Hausmann.
3863
3864         * WebKitTestRunner/InjectedBundle/Target.pri:
3865
3866 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3867
3868         [Qt] Move use of $$qtLibraryTarget() to a single place
3869
3870         Reviewed by Kenneth Rohde Christiansen.
3871
3872         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3873         * WebKitTestRunner/InjectedBundle/Target.pri:
3874         * qmake/mkspecs/features/default_post.prf:
3875         * qmake/mkspecs/features/webcore.prf:
3876
3877 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
3878
3879         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
3880         https://bugs.webkit.org/show_bug.cgi?id=75238
3881
3882         Reviewed by Antonio Gomes.
3883
3884         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
3885         it could initiate download directly if it has the download attribute in the link 
3886         and doesn't need to open new blank page for the target="_blank". Enabling this 
3887         feature in the BlackBerry porting also prepares for later blob feature implementation.
3888
3889         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
3890         for the BlackBerry porting.
3891
3892 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3893
3894         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
3895         https://bugs.webkit.org/show_bug.cgi?id=75475
3896
3897         Reviewed by Martin Robinson.
3898
3899         The problem is that the property blurb contains <a ping> and tree
3900         view uses gtk_tooltip_set_markup() internally, so we need to
3901         escape the text.
3902
3903         * MiniBrowser/gtk/BrowserSettingsDialog.c:
3904         (browserSettingsDialogConstructed): Escape property blurb before
3905         storing it in the GtkTreeModel.
3906
3907 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
3908
3909         When showing results.html pass a correct URL to webbrowser.open
3910         https://bugs.webkit.org/show_bug.cgi?id=75438
3911
3912         Reviewed by Adam Barth.
3913
3914         * Scripts/webkitpy/common/system/filesystem.py:
3915         (file_path_as_url):
3916         * Scripts/webkitpy/common/system/filesystem_mock.py:
3917         (file_path_as_url):
3918         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3919         (test_file_path_as_url):
3920         * Scripts/webkitpy/layout_tests/port/base.py:
3921         (show_results_html_file):
3922         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3923         (test_show_results_html_file):
3924         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3925         (test_results_directory_relative):
3926
3927 2012-01-03  Ojan Vafai  <ojan@chromium.org>
3928
3929         shrink the header on the flakiness dashboard
3930         https://bugs.webkit.org/show_bug.cgi?id=65153
3931
3932         Reviewed by Adam Roben.
3933
3934         Move some of the "show" links to be to the right of the header
3935         instead of below the header when they content they're showing
3936         is hidden. That way we don't waste vertical space on them.
3937
3938         No new tests. This code is covered by existing tests.
3939
3940         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3941
3942 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3943
3944         Add a tool to analyze change logs
3945         https://bugs.webkit.org/show_bug.cgi?id=72243
3946
3947         Reviewed by Eric Seidel.
3948
3949         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3950         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3951         for visualizing json files.
3952
3953         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3954         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3955         generates json files, and N is the number of changelogs to parse.
3956
3957         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3958         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3959         * Scripts/webkitpy/tool/commands/__init__.py:
3960         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3961         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3962         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3963         * Scripts/webkitpy/tool/steps/options.py:
3964
3965 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3966
3967         Add a tool to analyze change logs
3968         https://bugs.webkit.org/show_bug.cgi?id=72243
3969
3970         Reviewed by Eric Seidel.
3971
3972         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3973         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3974         for visualizing json files.
3975
3976         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3977         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3978         generates json files, and N is the number of changelogs to parse.
3979
3980         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3981         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3982         * Scripts/webkitpy/tool/commands/__init__.py:
3983         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3984         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3985         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3986         * Scripts/webkitpy/tool/steps/options.py:
3987
3988 2012-01-03  Adam Roben  <aroben@apple.com>
3989
3990         Make Port subclasses override the operating_system method rather than setting an attribute
3991
3992         Without this patch, any use of Port.operating_system() within a port's __init__ method would
3993         return the default value ("mac"). This was confusing the version-checking logic inside
3994         ApplePort.__init__ on Windows.
3995
3996         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
3997         crashes on launch on Windows 7 SP1
3998
3999         Reviewed by Eric Seidel.
4000
4001         * Scripts/webkitpy/layout_tests/port/apple.py:
4002         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
4003
4004         * Scripts/webkitpy/layout_tests/port/base.py:
4005         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
4006         should now override the operating_system method instead.
4007         (Port.operating_system): Changed to always return "mac". Subclasses should override to
4008         return something else.
4009
4010         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4011         (ChromiumLinuxPort.__init__):
4012         (ChromiumLinuxPort.operating_system):
4013         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4014         (ChromiumMacPort.__init__):
4015         (ChromiumMacPort.operating_system):
4016         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4017         (ChromiumWinPort.__init__):
4018         (ChromiumWinPort.operating_system):
4019         * Scripts/webkitpy/layout_tests/port/mac.py:
4020         (MacPort.__init__):
4021         (MacPort.operating_system):
4022         * Scripts/webkitpy/layout_tests/port/win.py:
4023         (WinPort.__init__):
4024         (WinPort.operating_system):
4025         Changed to override the operating_system method rather than setting the _operating_system
4026         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
4027
4028         * Scripts/webkitpy/layout_tests/port/qt.py:
4029         (QtPort.__init__):
4030         (QtPort._path_to_webcore_library):
4031         Changed to use self.operating_system() instead of self._operating_system, for consistency
4032         with other Port-related code.
4033
4034         (QtPort.operating_system): Added this override of Port.operating_system that returns the
4035         value we determined in our __init__ method.
4036
4037         * Scripts/webkitpy/layout_tests/port/test.py:
4038         (TestPort.operating_system): Added this override of Port.operating_system that returns the
4039         value we determined in our __init__ method.
4040
4041         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4042         (PortTest.test_operating_system):
4043         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4044         (ChromiumLinuxPortTest.test_operating_system):
4045         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4046         (ChromiumMacPortTest.test_operating_system):
4047         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4048         (ChromiumWinPortTest.test_operating_system):
4049         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4050         (MacPortTest.test_operating_system):
4051         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4052         (QtPortTest.test_operating_system):
4053         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4054         (WinPortTest.test_operating_system):
4055         Test that all ports return the expected operating system string.
4056
4057 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
4058
4059         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
4060         https://bugs.webkit.org/show_bug.cgi?id=75474
4061
4062         Reviewed by Philippe Normand.
4063
4064         * Scripts/run-gtk-tests: Ignore files whose name does not start
4065         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
4066
4067 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
4068
4069         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
4070         https://bugs.webkit.org/show_bug.cgi?id=75472
4071
4072         Reviewed by Tor Arne Vestbø.
4073
4074         * MiniBrowser/qt/MiniBrowser.pro:
4075         * MiniBrowser/qt/MiniBrowser.qrc:
4076         * MiniBrowser/qt/qml/BrowserWindow.qml:
4077         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
4078
4079 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
4080
4081         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
4082         https://bugs.webkit.org/show_bug.cgi?id=75471
4083
4084         Reviewed by Tor Arne Vestbø.
4085
4086         Add simple UI for JavaScript Alert dialogs. This patch also adds a
4087         simple DialogButton QML type and a Dialog QML type which will be
4088         reusable for other JavaScript dialogs.
4089
4090         * MiniBrowser/qt/MiniBrowser.qrc:
4091         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
4092         * MiniBrowser/qt/qml/BrowserWindow.qml:
4093         * MiniBrowser/qt/qml/Dialog.qml: Added.
4094         * MiniBrowser/qt/qml/DialogButton.qml: Added.
4095
4096 2012-01-03  Rafael Brandao  <rafael.lobo@openbossa.org>
4097
4098         [Qt][WK2] MiniBrowser doesn't show url bar
4099         https://bugs.webkit.org/show_bug.cgi?id=75470
4100
4101         Reviewed by Tor Arne Vestbø.
4102
4103         * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
4104         on QtDeclarative (QTBUG-23422).
4105
4106 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4107
4108         [GTK] Simplify loader client WebKit2 GTK+ API
4109         https://bugs.webkit.org/show_bug.cgi?id=74605
4110
4111         Reviewed by Gustavo Noronha Silva.
4112
4113         * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
4114         private API.
4115
4116 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4117
4118         [Qt] Clean up detection of fontconfig
4119
4120         We decide in features.prf whether or not fontconfig is available, and
4121         set the HAVE_FONTCONFIG define accordingly. All leaf project files
4122         should use this define to decide whether or not to link against
4123         fontconfig, not do their own detection.
4124
4125         We don't need to add link_pkgconfig to CONFIG in each project file,
4126         as we selectivly enable that configuration in defaults_post when
4127         needed.
4128
4129         Reviewed by Ossy.
4130
4131         * DumpRenderTree/qt/DumpRenderTree.pro:
4132         * QtTestBrowser/QtTestBrowser.pro:
4133         * WebKitTestRunner/InjectedBundle/Target.pri:
4134         * qmake/mkspecs/features/unix/default_post.prf:
4135         * qmake/mkspecs/features/unix/default_pre.prf:
4136
4137 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4138
4139         [Qt] Introduce qmake replace function for the active build config
4140
4141         Reviewed by Ossy.
4142
4143         * qmake/mkspecs/features/default_post.prf:
4144         * qmake/mkspecs/features/functions.prf:
4145
4146 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4147
4148         [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
4149         https://bugs.webkit.org/show_bug.cgi?id=75435
4150
4151         Reviewed by Martin Robinson.
4152
4153         * GNUmakefile.am: Make sure DRT links to X11.
4154         * WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
4155
4156 2011-12-04  Philippe Normand  <pnormand@igalia.com>
4157
4158         [WK2][GTK] WebSettings support in MiniBrowser
4159         https://bugs.webkit.org/show_bug.cgi?id=73773
4160
4161         Reviewed by Martin Robinson.
4162
4163         Patch heavily inspired from the WebKit GtkLauncher to support
4164         command-line WebSettings. Example: --enable-fullscreen=TRUE.
4165         The full list of options can be consulted with --help-websettings.
4166
4167         * MiniBrowser/gtk/main.c:
4168         (loadURI):
4169         (parseOptionEntryCallback):
4170         (isValidParameterType):
4171         (getOptionEntriesFromWebKitSettings):
4172         (addSettingsGroupToContext):
4173         (main):
4174
4175 2012-01-02  Philippe Normand  <pnormand@igalia.com>
4176
4177         [GTK] GtkLauncher settings improvements
4178         https://bugs.webkit.org/show_bug.cgi?id=75439
4179
4180         Reviewed by Martin Robinson.
4181
4182         * GtkLauncher/main.c:
4183         (filenameToURL): We can use NULL in C.
4184         (isValidParameterType): Utility function to filter GParamTypes
4185         that can be edited.
4186         (getOptionEntriesFromWebKitWebSettings): Avoid handling
4187         construct-only properties and use the isValidParameterType
4188         function. Makes the code a bit cleaner.
4189
4190 2012-01-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4191
4192         [EFL] Remove whitespace/declaration style exception
4193         https://bugs.webkit.org/show_bug.cgi?id=75424
4194
4195         Reviewed by David Levin.
4196
4197         Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
4198         application. So, they still need to use EFL coding style.
4199
4200         * Scripts/webkitpy/style/checker.py:
4201
4202 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4203
4204         [GTK] Add a way to change web view settings in MiniBrowser
4205         https://bugs.webkit.org/show_bug.cgi?id=71568
4206
4207         Reviewed by Philippe Normand.
4208
4209         Add a preferences button to the toolbar that shows a dialog to
4210         change settings of the current web view. It uses a GtkTreeView
4211         with a custom cell renderer to support multiple types of values.
4212
4213         * MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.
4214         (browserCellRendererVariantFinalize):
4215         (browserCellRendererVariantGetProperty):
4216         (browserCellRendererVariantSetModeForValue):
4217         (browserCellRendererVariantSetProperty):
4218         (browserCellRendererVariantGetRendererForValue):
4219         (browserCellRendererVariantCellRendererTextEdited):
4220         (browserCellRendererVariantCellRendererSpinEdited):
4221         (browserCellRendererVariantCellRendererActivate):
4222         (browserCellRendererVariantCellRendererRender):
4223         (browserCellRendererVariantCellRendererStartEditing):
4224         (browserCellRendererVariantCellRendererGetPreferredWidth):
4225         (browserCellRendererVariantCellRendererGetPreferredHeight):
4226         (browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
4227         (browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
4228         (browserCellRendererVariantCellRendererGetAlignedArea):
4229         (browser_cell_renderer_variant_init):
4230         (browser_cell_renderer_variant_class_init):
4231         (browser_cell_renderer_variant_new):
4232         * MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
4233         * MiniBrowser/gtk/BrowserSettingsDialog.c: Added.
4234         (cellRendererChanged):
4235         (browserSettingsDialogSetProperty):
4236         (browser_settings_dialog_init):
4237         (browserSettingsDialogConstructed):
4238         (browser_settings_dialog_class_init):
4239         (browser_settings_dialog_new):
4240         * MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
4241         * MiniBrowser/gtk/BrowserWindow.c:
4242         (settingsCallback):
4243         (browser_window_init):
4244         * MiniBrowser/gtk/GNUmakefile.am:
4245         * MiniBrowser/gtk/browser-marshal.list: Added.
4246
4247 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4248
4249         [GTK] Implement create/ready-to-show/close signals in MiniBrowser
4250         https://bugs.webkit.org/show_bug.cgi?id=74711
4251
4252         Reviewed by Philippe Normand.
4253
4254         * MiniBrowser/gtk/BrowserWindow.c:
4255         (webViewClose): Destroy the window.
4256         (webViewReadyToShow): Use WindowProperties of the new view to
4257         setup and show the window.
4258         (webViewCreate): Create a new view and add it to a browser window.
4259         (browser_window_init):
4260         (browserWindowConstructed): Connect to WebKitWebView::create signal.
4261
4262 2011-12-31  Dan Bernstein  <mitz@apple.com>
4263
4264         MiniBrowser sets the WKView’s frame incorrectly
4265         https://bugs.webkit.org/show_bug.cgi?id=75393
4266
4267         Reviewed by Anders Carlsson.
4268
4269         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,
4270         which is not needed since the binray is linked with the frameworks search path set to the
4271         built products directory.
4272         * MiniBrowser/mac/BrowserWindowController.m:
4273         (-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
4274         container’s bounds rather than its frame.
4275         * MiniBrowser/mac/make-launchable.sh: Removed.
4276
4277 2011-12-29  Dan Bernstein  <mitz@apple.com>
4278
4279         debug-safari --no-saved-state fails to start the debugger
4280         https://bugs.webkit.org/show_bug.cgi?id=75374
4281
4282         Reviewed by Sam Weinig.
4283
4284         * Scripts/webkitdirs.pm:
4285         (execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
4286         the executable being debugged.
4287
4288 2011-12-29  Sam Weinig  <sam@webkit.org>
4289
4290         It should be easier to iterate a Vector backwards
4291         https://bugs.webkit.org/show_bug.cgi?id=75359
4292
4293         Reviewed by Anders Carlsson.
4294
4295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4296         * TestWebKitAPI/TestWebKitAPI.gypi:
4297         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4298         Add new Vector test.
4299
4300         * TestWebKitAPI/Tests/Vector.cpp: Added.
4301         (TestWebKitAPI::TEST):
4302         Test Vector iterators, reverse_iterators and new reversed proxy.
4303
4304 2011-12-28  Dmitry Lomov  <dslomov@google.com>
4305
4306         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
4307         https://bugs.webkit.org/show_bug.cgi?id=66509
4308         Just renames, merges and removal of dead code. Here are the list of renames:
4309           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
4310           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
4311           - WebWorkerBase merged into WebSharedWorkerImpl
4312           - NewWebWorkerBase renamed into WebWorkerBase
4313  
4314         Reviewed by David Levin.
4315
4316         * DumpRenderTree/chromium/TestWebWorker.h:
4317         (TestWebWorker::createWorker):
4318         * DumpRenderTree/chromium/WebViewHost.cpp:
4319         (WebViewHost::createWorker):
4320         * DumpRenderTree/chromium/WebViewHost.h:
4321
4322 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
4323
4324         Unreviewed, rolling out r103785.
4325         http://trac.webkit.org/changeset/103785
4326         https://bugs.webkit.org/show_bug.cgi?id=75332
4327
4328         Broke builders; looks like clobbering didnt help (Requested by