2011-04-01 Dominic Cooney <dominicc@google.com>
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-01  Dominic Cooney  <dominicc@google.com>
2
3         Reviewed by Martin Robinson.
4
5         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
6         https://bugs.webkit.org/show_bug.cgi?id=57551
7
8         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
9         (LayoutTestController::shadowRoot):
10
11 2011-04-01  Sam Weinig  <sam@webkit.org>
12
13         Reviewed by Anders Carlsson.
14
15         WebKitTestRunner needs layoutTestController.shadowRoot
16         https://bugs.webkit.org/show_bug.cgi?id=57661
17
18         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
19         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
20         (WTR::LayoutTestController::shadowRoot):
21         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
22         Implement layoutTestController.shadowRoot for WebKit2.
23
24 2011-04-01  Chang Shu  <cshu@webkit.org>
25
26         Reviewed by Darin Adler.
27
28         WebKitTestRunner needs layoutTestController.setDatabaseQuota
29         https://bugs.webkit.org/show_bug.cgi?id=57568
30
31         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
32         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
33         (WTR::LayoutTestController::setDatabaseQuota):
34         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
35
36 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
37
38         Reviewed by Tony Chang.
39
40         This patch completes the cleanup of
41         rebaseline-chromium-webkit-tests to work with all of the
42         variants of a platform (we can now rebaseline gpu- and non-gpu
43         files at the same time).
44
45         When the rebaselining is complete, any lines declared as
46         REBASELINE in the expectations file that matches a test that was
47         actually rebaselined will be deleted, even if only one of the
48         variants was actually rebaselined. This may cause odd problems,
49         but is better than where we're at today.
50
51         This change removes the -g flag and deprecates -w. The -g flag is gone
52         because GPU baselines are handled just like any other variant.
53         The -w flag is deprecated because this tool now only works
54         against the canaries, since that's the only place we have a full
55         set of bots. It will be trivial to change this to
56         build.webkit.org if we decide that's where we want them to be.
57
58         Also, this patch deletes a lot of cruft that is no longer needed
59         in the test_expectations code and the port-specific code.
60
61         https://bugs.webkit.org/show_bug.cgi?id=55191
62
63         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
64         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
65         * Scripts/webkitpy/layout_tests/port/base.py:
66         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
67         * Scripts/webkitpy/layout_tests/port/chromium.py:
68         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
69         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
70         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
71         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
72         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
73         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
74         * Scripts/webkitpy/layout_tests/port/mac.py:
75         * Scripts/webkitpy/layout_tests/port/test.py:
76         * Scripts/webkitpy/layout_tests/port/webkit.py:
77         * Scripts/webkitpy/layout_tests/port/win.py:
78         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
79         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
80
81 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
82
83         Reviewed by Adam Barth.
84
85         rebaseline-chromium-webkit-tests does not work correctly with
86         version-specific baselines. This patch updates the tool to use
87         all of the version-specific bots on the canaries, and will now
88         attempt to rebaseline all of the versions by default, although
89         it will not update both GPU and CPU versions.
90         
91         Also, it will no longer modify the test_expectations.txt file
92         *at all*. You will have to manually delete the REBASELINE lines
93         after running the tool and determining that it did what you
94         wanted it to do. This should be fixed in a separate bug - see
95         webkit bug #55191.
96
97         https://bugs.webkit.org/show_bug.cgi?id=55608
98
99         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
100         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
101         * Scripts/webkitpy/layout_tests/port/chromium.py:
102         * Scripts/webkitpy/layout_tests/port/test.py:
103         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
104         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
105
106 2011-03-31  Tony Chang  <tony@chromium.org>
107
108         Reviewed by Ojan Vafai.
109
110         [chromium] update the rebaseline tool to know about pngs with checksums
111         https://bugs.webkit.org/show_bug.cgi?id=57481
112
113         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
114         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
115
116 2011-04-01  Adam Roben  <aroben@apple.com>
117
118         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
119
120         Previously, we were getting the revision of the first revision that triggered a build.
121         Choosing the last revision would have been more accurate. But got_revision is what is used
122         everywhere else on build.webkit.org, and should work even when there were no changes that
123         triggered a build (e.g., if someone clicked the Force Build button).
124
125         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
126         recent builds list
127
128         Reviewed by Anders Carlsson.
129
130         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
131         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
132         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
133
134         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
135         (Array.prototype.first): Added this helper function to return the first element in an array
136         that matches the given predicate, or null if no such element exists.
137
138 2011-03-31  Adam Roben  <aroben@apple.com>
139
140         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
141
142         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
143
144         Reviewed by Darin Adler.
145
146         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
147         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
148         URL on its own line.
149
150         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
151         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
152         progression, and added a new test that uses a short bug URL while I was at it.
153
154 2011-04-01  Adam Roben  <aroben@apple.com>
155
156         Mark .vcproj/.vsprops/.sln files as being Windows-only
157
158         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
159
160         Reviewed by Anders Carlsson.
161
162         * Scripts/webkitpy/common/config/build.py:
163         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
164         directories as Windows-only.
165
166         * Scripts/webkitpy/common/config/build_unittest.py:
167         (ShoulBuildTest): Added test cases for the above.
168
169 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
170
171         Reviewed by Laszlo Gombos.
172
173         [Qt] Build MiniBrowser for Symbian
174         https://bugs.webkit.org/show_bug.cgi?id=56319
175
176         Have MiniBrowser reference it's own copy of useragentlist.txt instead
177         of copying QtTestBrowser's.
178         Remove Tools/MiniBrowser/DerivedSources.pro
179         This reduces complexity in the Tools scripts due to Symbian limitations.
180
181         * DerivedSources.pro:
182         * MiniBrowser/DerivedSources.pro: Removed.
183         * MiniBrowser/MiniBrowser.qrc:
184         * MiniBrowser/qt/MiniBrowser.pro:
185         * Scripts/webkitdirs.pm:
186
187 2011-03-31  Chang Shu  <cshu@webkit.org>
188
189         Reviewed by Darin Adler.
190
191         WebKitTestRunner needs layoutTestController.clearAllDatabases
192         https://bugs.webkit.org/show_bug.cgi?id=42540
193
194         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
195         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
196         (WTR::InjectedBundle::beginTesting):
197         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
198         (WTR::LayoutTestController::clearAllDatabases):
199         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
200
201 2011-03-31  Chang Shu  <cshu@webkit.org>
202
203         Reviewed by Darin Adler.
204
205         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
206         https://bugs.webkit.org/show_bug.cgi?id=42692
207
208         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
209
210 2011-03-31  Darin Adler  <darin@apple.com>
211
212         Reviewed by Sam Weinig.
213
214         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
215         https://bugs.webkit.org/show_bug.cgi?id=57573
216
217         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
218         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
219         Removed fake definitions of keyDown and contextClick.
220
221         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
222         (WTR::operator==): Added. So we can compare two WKPoint structs.
223         (WTR::parseModifier): Added.
224         (WTR::parseModifierArray): Added.
225         (WTR::EventSendingController::EventSendingController): Initialize the
226         new data members.
227         (WTR::EventSendingController::mouseDown): Added. Calls
228         WKBundlePageSimulateMouseDown.
229         (WTR::EventSendingController::mouseUp): Added. Calls
230         WKBundlePageSimulateMouseUp.
231         (WTR::EventSendingController::mouseMoveTo): Added. Calls
232         WKBundlePageSimulateMouseMotion.
233         (WTR::EventSendingController::leapForward): Added.
234         (WTR::EventSendingController::updateClickCount): Added. Used by the
235         mouseDown/Up functions to create a click count.
236
237         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
238         for the changes above.
239
240 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
241
242         Reviewed by Martin Robinson.
243
244         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
245         https://bugs.webkit.org/show_bug.cgi?id=57362
246
247         Do not generate DRT output if willSendRequestReturnsNull is set.
248
249         * DumpRenderTree/gtk/DumpRenderTree.cpp:
250         (willSendRequestCallback):
251
252 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
253
254         Reviewed by Martin Robinson.
255
256         Implement MiniBrowser for Gtk port.
257         https://bugs.webkit.org/show_bug.cgi?id=48512
258
259         Initial implementation of the Gtk MiniBrowser.
260
261         * MiniBrowser/gtk/GNUmakefile.am: Added.
262         * MiniBrowser/gtk/main.c: Added.
263         (activateUriEntryCallback):
264         (destroyCallback):
265         (goBackCallback):
266         (goForwardCallback):
267         (createToolbar):
268         (createWebView):
269         (createWindow):
270         (argumentToURL):
271         (main):
272
273 2011-03-30  Dominic Cooney  <dominicc@google.com>
274
275         Reviewed by Dimitri Glazkov.
276
277         Adds layoutTestController.shadowRoot accessor to Mac DRT.
278         https://bugs.webkit.org/show_bug.cgi?id=57415
279
280         * DumpRenderTree/LayoutTestController.cpp:
281         (shadowRootCallback):
282         (LayoutTestController::staticFunctions):
283         * DumpRenderTree/LayoutTestController.h:
284         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
285         (LayoutTestController::shadowRoot):
286         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
287         (LayoutTestController::shadowRoot):
288
289 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
290
291         Reviewed by Chris Marrin.
292
293         Update fast/canvas tests to avoid dumping the render tree when possible
294         https://bugs.webkit.org/show_bug.cgi?id=57493
295
296         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
297           accelerated drawing and accelerated drawing for canvas
298
299 2011-03-30  Adam Roben  <aroben@apple.com>
300
301         Stop ignoring leaks in CGGradientCreateWithColorStops
302
303         Fixes <rdar://problem/7888547>.
304
305         Rubber-stamped by John Sullivan.
306
307         * Scripts/old-run-webkit-tests:
308         (countAndPrintLeaks): Removed some code to ignore those leaks.
309
310 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
311
312         Reviewed by Alexey Proskuryakov.
313
314         Add some dynamic annotations to JavaScriptCore/wtf
315         https://bugs.webkit.org/show_bug.cgi?id=53747
316
317         By using these annotations we can improve the precision of finding
318         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
319         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
320
321         These files don't add new functionality, so don't need extra tests.
322
323         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
324
325 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
326
327         Reviewed by Adam Roben.
328
329         Share most vsprops between Release and Production builds in releaseproduction.vsprops
330         https://bugs.webkit.org/show_bug.cgi?id=57508
331
332         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
333         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
334         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
335         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
336         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
337         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
338         * DumpRenderTree/win/ImageDiffProduction.vsprops:
339         * DumpRenderTree/win/ImageDiffRelease.vsprops:
340         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
341         * FindSafari/FindSafariProduction.vsprops:
342         * FindSafari/FindSafariRelease.vsprops:
343         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
344         * FindSafari/FindSafariReleasePGO.vsprops:
345         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
346         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
347         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
348         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
349         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
350         * WebKitAPITest/WebKitAPITestProduction.vsprops:
351         * WebKitAPITest/WebKitAPITestRelease.vsprops:
352         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
353         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
354         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
355         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
356         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
357         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
358         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
359         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
360         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
361         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
362         * WinLauncher/WinLauncherProduction.vsprops:
363         * WinLauncher/WinLauncherRelease.vsprops:
364         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
365         * record-memory-win/record-memory-winProduction.vsprops:
366         * record-memory-win/record-memory-winRelease.vsprops:
367         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
368
369 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
370
371         Reviewed by Adam Roben.
372
373         Update Windows production build logic for new production configurations
374         https://bugs.webkit.org/show_bug.cgi?id=57494
375
376         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
377         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
378         * DumpRenderTree/win/ImageDiffProduction.vsprops:
379         * FindSafari/FindSafariProduction.vsprops:
380         * FindSafari/FindSafariReleasePGO.vsprops:
381         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
382         * WebKitAPITest/WebKitAPITestProduction.vsprops:
383         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
384         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
385         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
386         * WinLauncher/WinLauncherProduction.vsprops:
387         * record-memory-win/record-memory-winProduction.vsprops:
388
389 2011-03-30  Robert Hogan  <robert@webkit.org>
390
391         Reviewed by Antonio Gomes.
392
393         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
394         Unskip http/tests/navigation/go-back-to-error-page.html
395
396         Also add the location of DumpRenderTreeSupportQt.h
397         to DRT's include paths.
398
399         https://bugs.webkit.org/show_bug.cgi?id=52614
400
401         * DumpRenderTree/qt/DumpRenderTree.pro:
402         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
403         * DumpRenderTree/qt/DumpRenderTreeQt.h:
404         * DumpRenderTree/qt/GCControllerQt.cpp:
405         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
406         (LayoutTestController::queueLoadHTMLString):
407         * DumpRenderTree/qt/LayoutTestControllerQt.h:
408         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
409         * DumpRenderTree/qt/TextInputControllerQt.cpp:
410         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
411         (LoadAlternateHTMLStringItem::invoke):
412         * DumpRenderTree/qt/WorkQueueItemQt.h:
413         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
414         * QtTestBrowser/QtTestBrowser.pro:
415         * QtTestBrowser/launcherwindow.h:
416
417 2011-03-30  Adam Barth  <abarth@webkit.org>
418
419         Reviewed by Adam Roben.
420
421         SheriffBot rollouts take too long
422         https://bugs.webkit.org/show_bug.cgi?id=57498
423
424         We used to build before landing rollouts via the commit-queue to
425         prevent further breakage, but now that our individual commit-queue
426         machines are slower, building takes too long.  I can't remember the
427         last time a rollout broke compile.  It seems like just landing the
428         patch is the better trade-off.
429
430         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
431         * Scripts/webkitpy/tool/commands/queues_unittest.py:
432
433 2011-03-30  Adam Barth  <abarth@webkit.org>
434
435         Remove platform/chromium-mac-snowleopard
436         https://bugs.webkit.org/show_bug.cgi?id=57486
437
438         This directory no longer exists, so we can remove it from the fallback
439         chain.
440
441         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
442
443 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
444
445         Reviewed by Adam Roben.
446
447         Rename Windows configuration Release_LTCG to Production for clarity
448         https://bugs.webkit.org/show_bug.cgi?id=57465
449
450         * DumpRenderTree/DumpRenderTree.sln:
451         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
452         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
453         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
454         * DumpRenderTree/win/DumpRenderTree.vcproj:
455         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
456         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
457         * DumpRenderTree/win/ImageDiff.vcproj:
458         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
459         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
460         * FindSafari/FindSafari.vcproj:
461         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
462         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
463         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
464         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
465         * MiniBrowser/MiniBrowser.vcproj:
466         * Scripts/webkitdirs.pm:
467         * TestWebKitAPI/win/TestWebKitAPI.sln:
468         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
469         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
470         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
471         * WebKitAPITest/WebKitAPITest.vcproj:
472         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
473         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
474         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
475         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
476         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
477         * WebKitTestRunner/WebKitTestRunner.sln:
478         * WebKitTestRunner/win/InjectedBundle.vcproj:
479         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
480         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
481         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
482         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
483         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
484         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
485         * WinLauncher/WinLauncher.vcproj:
486         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
487         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
488         * record-memory-win/record-memory-win.vcproj:
489         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
490         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
491
492 2011-03-30  MORITA Hajime  <morrita@google.com>
493
494         Reviewed by Dimitri Glazkov.
495
496         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
497         https://bugs.webkit.org/show_bug.cgi?id=56573
498
499         Added LayoutTestController.shadowRoot() to Chromium DRT.
500
501         * DumpRenderTree/chromium/LayoutTestController.cpp:
502         (LayoutTestController::LayoutTestController):
503         (LayoutTestController::shadowRoot):
504         * DumpRenderTree/chromium/LayoutTestController.h:
505
506 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
507
508         Reviewed by Kent Tamura.
509
510         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
511         https://bugs.webkit.org/show_bug.cgi?id=57430
512
513         * DumpRenderTree/chromium/LayoutTestController.cpp:
514         (LayoutTestController::LayoutTestController):
515         (LayoutTestController::setPluginsEnabled):
516         * DumpRenderTree/chromium/LayoutTestController.h:
517
518 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
519
520         Reviewed by Adam Barth.
521
522         make webkit-patch upload respect -d
523         https://bugs.webkit.org/show_bug.cgi?id=57425
524
525         * Scripts/webkitpy/common/checkout/scm.py:
526         * Scripts/webkitpy/tool/steps/commit.py:
527
528 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
529
530         Reviewed by Adam Barth.
531
532         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
533         https://bugs.webkit.org/show_bug.cgi?id=57429
534
535         * Scripts/webkitpy/common/checkout/scm.py:
536
537 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
538
539         Unreviewed, rolling out r82383.
540         http://trac.webkit.org/changeset/82383
541         https://bugs.webkit.org/show_bug.cgi?id=57417
542
543         "nrwt isn't shutting down cleanly" (Requested by dpranke on
544         #webkit).
545
546         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
547         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
548         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
549
550 2011-03-29  Kent Tamura  <tkent@chromium.org>
551
552         Reviewed by Dimitri Glazkov.
553
554         Make validation message bubble testable
555         https://bugs.webkit.org/show_bug.cgi?id=57290
556
557         * DumpRenderTree/mac/DumpRenderTree.mm:
558         (createWebViewAndOffscreenWindow): Change a setting so that validation
559           bubbles isn't hidden automatically.
560
561 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
562
563         Reviewed by Ojan Vafai.
564
565         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
566
567         It's a bit unclear whether multiple threads or multiple
568         processes will be a better model on windows. This change will
569         test threads for now while we're still working out the bugs in
570         multiple-processes.
571
572         https://bugs.webkit.org/show_bug.cgi?id=57410
573
574         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
575         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
576         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
577
578 2011-03-29  David Levin  <levin@chromium.org>
579
580         Reviewed by Shinichiro Hamaji.
581
582         check-webkit-style confused by two ChangeLog entries in a row from same user
583         https://bugs.webkit.org/show_bug.cgi?id=57250
584
585         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
586         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
587         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
588           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
589           checking more than that would be very messey.
590         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
591         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
592
593 2011-03-29  Kent Tamura  <tkent@chromium.org>
594
595         Reviewed by Dimitri Glazkov.
596
597         [Mac] Enable interactive-validation tests on Mac DRT
598         https://bugs.webkit.org/show_bug.cgi?id=57308
599
600         * DumpRenderTree/mac/DumpRenderTree.mm:
601         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
602
603 2011-03-29  Chang Shu  <cshu@webkit.org>
604
605         Reviewed by Kenneth Rohde Christiansen.
606
607         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
608         https://bugs.webkit.org/show_bug.cgi?id=42692
609
610         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
611         (WTR::InjectedBundle::beginTesting):
612         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
613         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
614         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
615
616 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
617
618         Reviewed by Xan Lopez.
619
620         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
621         https://bugs.webkit.org/show_bug.cgi?id=57067
622
623         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
624         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
625         update DRT and pixel results as hundreds of results will need to be updated.
626
627         * DumpRenderTree/gtk/DumpRenderTree.cpp:
628         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
629         by overriding the theme RC/CSS files.
630
631 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
632
633         Reviewed by Adam Roben.
634
635         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
636         https://bugs.webkit.org/show_bug.cgi?id=57394
637
638         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
639         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
640         the IDE. To avoid this, add a separate vsprops file for each project configuration that
641         contains the required inherited property sheets.
642
643         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
644         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
645         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
646         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
647         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
648         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
649         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
650         * DumpRenderTree/win/DumpRenderTree.vcproj:
651         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
652         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
653         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
654         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
655         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
656         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
657         * DumpRenderTree/win/ImageDiff.vcproj:
658         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
659         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
660         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
661         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
662         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
663         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
664         * FindSafari/FindSafari.vcproj:
665         * FindSafari/FindSafariDebug.vsprops: Added.
666         * FindSafari/FindSafariDebugAll.vsprops: Added.
667         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
668         * FindSafari/FindSafariRelease.vsprops: Added.
669         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
670         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
671         * FindSafari/FindSafariReleasePGO.vsprops: Added.
672         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
673         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
674         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
675         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
676         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
677         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
678         * MiniBrowser/MiniBrowser.vcproj:
679         * WebKitAPITest/WebKitAPITest.vcproj:
680         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
681         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
682         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
683         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
684         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
685         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
686         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
687         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
688         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
689         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
690         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
691         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
692         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
693         * WebKitTestRunner/win/InjectedBundle.vcproj:
694         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
695         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
696         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
697         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
698         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
699         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
700         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
701         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
702         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
703         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
704         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
705         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
706         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
707         * WinLauncher/WinLauncher.vcproj:
708         * WinLauncher/WinLauncherDebug.vsprops: Added.
709         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
710         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
711         * WinLauncher/WinLauncherRelease.vsprops: Added.
712         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
713         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
714         * record-memory-win/record-memory-win.vcproj:
715         * record-memory-win/record-memory-winDebug.vsprops: Added.
716         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
717         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
718         * record-memory-win/record-memory-winRelease.vsprops: Added.
719         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
720         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
721
722 2011-03-29  Adam Barth  <abarth@webkit.org>
723
724         Reviewed by Darin Adler.
725
726         test_runner2.py can crash due to undefined variable
727         https://bugs.webkit.org/show_bug.cgi?id=57356
728
729         Replace reference to undefined variable with a variable that's actually
730         defined.  AFAICT, there's no way to test this code.
731
732         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
733
734 2011-03-29  Tony Chang  <tony@chromium.org>
735
736         Reviewed by Eric Seidel.
737
738         cleanup rebaseline-chromium-webkit-tests
739         https://bugs.webkit.org/show_bug.cgi?id=57375
740
741         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
742             - Split _extract_and_add_new_baselines into 3 functions
743             - Reduce the amount of line wrapping (the file already has lines
744               over 80 col, so may as well try to make the file consistent)
745             - Remove unnecessary ()s
746
747 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
748
749         Reviewed by Adam Roben.
750
751         Make WinCairo a core builder.
752         https://bugs.webkit.org/show_bug.cgi?id=57373
753
754         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
755         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
756
757 2011-03-29  Timothy Hatcher  <timothy@apple.com>
758
759         Update update-webkit-localizable-strings to understand that WebKit and
760         WebKit2 strings go in WebCore.
761
762         Also make extract-localizable-strings optionally use an exclude file. No individual
763         warnings are produced about unlocalized strings when there is no exclude file. This
764         is needed for WebCore, since there are too many bare strings.
765
766         https://webkit.org/b/57354
767
768         Reviewed by Sam Weinig.
769
770         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
771         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
772
773 2011-03-29  Darin Adler  <darin@apple.com>
774
775         Reviewed by Adam Roben.
776
777         WebKit2 bundle page needs to offer generated file hooks
778         https://bugs.webkit.org/show_bug.cgi?id=57279
779
780         (Land missing part of the original patch after r82289.)
781
782         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
783         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
784
785 2011-03-29  Tony Chang  <tony@chromium.org>
786
787         Reviewed by Ojan Vafai.
788
789         [chromium] NRWT should be able to read checksums from png comments
790         https://bugs.webkit.org/show_bug.cgi?id=57280
791
792         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
793             from a file.
794         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
795         * Scripts/webkitpy/common/system/filesystem_mock.py:
796         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
797             if the -checksum.txt file doesn't exist, try looking in the png.
798         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
799         * Scripts/webkitpy/layout_tests/port/test.py:
800         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
801             2k for a png comment with the checksum
802         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
803
804 2011-03-29  Philippe Normand  <pnormand@igalia.com>
805
806         Rubber-stamped by Gustavo Noronha Silva.
807
808         [GTK] http/tests/uri/username-with-no-hostname.html fails
809         https://bugs.webkit.org/show_bug.cgi?id=57325
810
811         * DumpRenderTree/gtk/DumpRenderTree.cpp:
812         (willSendRequestCallback): URI host value check done case-insensitively.
813
814 2011-03-29  Philippe Normand  <pnormand@igalia.com>
815
816         Reviewed by Martin Robinson.
817
818         [GTK] http/tests/uri/username-with-no-hostname.html fails
819         https://bugs.webkit.org/show_bug.cgi?id=57325
820
821         * DumpRenderTree/gtk/DumpRenderTree.cpp:
822         (willSendRequestCallback): Check URI before submitting the request
823         to WebCore.
824
825 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
826
827         Reviewed by Ojan Vafai.
828
829         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
830         https://bugs.webkit.org/show_bug.cgi?id=57303
831
832         * DumpRenderTree/chromium/EventSender.cpp:
833         (EventSender::doDragDrop):
834         (EventSender::beginDragWithFiles):
835
836 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
837
838         Reviewed by Andreas Kling.
839
840         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
841         https://bugs.webkit.org/show_bug.cgi?id=57314
842
843         Provide possibility to print loaded urls to the standard output.
844
845         * MiniBrowser/qt/BrowserWindow.cpp:
846         (BrowserWindow::BrowserWindow):
847         (BrowserWindow::printURL):
848         * MiniBrowser/qt/BrowserWindow.h:
849         * MiniBrowser/qt/MiniBrowserApplication.cpp:
850         (MiniBrowserApplication::handleUserOptions):
851         * MiniBrowser/qt/MiniBrowserApplication.h:
852         (WindowOptions::WindowOptions):
853         * QtTestBrowser/launcherwindow.cpp:
854         (LauncherWindow::initializeView):
855         (LauncherWindow::printURL):
856         (LauncherWindow::cloneWindow):
857         * QtTestBrowser/launcherwindow.h:
858         (WindowOptions::WindowOptions):
859         * QtTestBrowser/main.cpp:
860         (LauncherApplication::handleUserOptions):
861
862 2011-03-29  Gabor Loki  <loki@webkit.org>
863
864         Rubber-stamped by Csaba Osztrogonác.
865
866         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
867         https://bugs.webkit.org/show_bug.cgi?id=56918
868
869         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
870
871 2011-03-28  Gabor Loki  <loki@webkit.org>
872
873         Reviewed by Csaba Osztrogonác.
874
875         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
876         https://bugs.webkit.org/show_bug.cgi?id=56918
877
878         * Scripts/build-jsc:
879         * Scripts/webkitdirs.pm:
880
881 2011-03-28  Andrew Foster  <andrewf@chromium.org>
882
883         Reviewed by Ojan Vafai.
884
885         webkit-patch should be more intelligent about whether a bug applies to a patch
886         Create a new function, parse_bug_id_from_changelog() which determines
887         that a bug is related to a patch by parsing the output generated from
888         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
889         the description of a patch.
890         https://bugs.webkit.org/show_bug.cgi?id=56989
891
892         * Scripts/webkitpy/common/checkout/api.py:
893         * Scripts/webkitpy/common/checkout/changelog.py:
894         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
895         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
896         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
897         * Scripts/webkitpy/style/checkers/changelog.py:
898         * Scripts/webkitpy/tool/commands/upload.py:
899
900 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
901
902         Revert accidentally commited change.
903
904         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
905         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
906
907 2011-03-28  Tony Chang  <tony@chromium.org>
908
909         Reviewed by Adam Barth.
910
911         [chromium] have DRT write the png checksum into a png comment
912         https://bugs.webkit.org/show_bug.cgi?id=57255
913
914         * DumpRenderTree/chromium/TestShell.cpp:
915         (TestShell::dumpImage):
916
917 2011-03-28  Adele Peterson  <adele@apple.com>
918
919         Removing Qt stub, since it doesn't use the same header as the others.
920
921         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
922
923 2011-03-28  Adele Peterson  <adele@apple.com>
924
925         Added a few more stubs.
926
927         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
928         (LayoutTestController::hasGrammarMarker):
929         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
930         (LayoutTestController::hasGrammarMarker):
931         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
932         (LayoutTestController::hasGrammarMarker):
933
934 2011-03-28  Adele Peterson  <adele@apple.com>
935
936         Build fix.
937
938         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
939         (LayoutTestController::hasGrammarMarker):
940
941 2011-03-28  Adele Peterson  <adele@apple.com>
942
943         Reviewed by Eric Seidel.
944
945         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
946         https://bugs.webkit.org/show_bug.cgi?id=57173
947
948         * DumpRenderTree/LayoutTestController.cpp:
949         (hasGrammarMarkerCallback): Added.
950         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
951         * DumpRenderTree/LayoutTestController.h:
952         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
953         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
954
955 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
956
957         Reviewed by Benjamin Poulain.
958
959         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
960         https://bugs.webkit.org/show_bug.cgi?id=57087
961
962         Trivial typo fix after r82082.
963
964         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
965         (WTR::activateFonts):
966
967 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
968
969         Reviewed by Andreas Kling.
970
971         Add myself to the committers list.
972
973         * Scripts/webkitpy/common/config/committers.py:
974
975 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
976
977         Reviewed by Sam Weinig.
978
979         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
980         to link against WebKit.framework for now.
981
982         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
983
984 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
985
986         Reviewed by Andreas Kling.
987
988         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
989         https://bugs.webkit.org/show_bug.cgi?id=57087
990
991         Disable QT_ASCII_CAST_WARNINGS for applications.
992
993         * DumpRenderTree/qt/DumpRenderTree.pro:
994         * DumpRenderTree/qt/ImageDiff.pro:
995         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
996         * MiniBrowser/qt/MiniBrowser.pro:
997         * QtTestBrowser/QtTestBrowser.pro:
998         * WebKitTestRunner/qt/WebKitTestRunner.pro:
999
1000 2011-03-28  Andreas Kling  <kling@webkit.org>
1001
1002         Reviewed by Kenneth Rohde Christiansen.
1003
1004         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
1005         https://bugs.webkit.org/show_bug.cgi?id=57224
1006
1007         * QtTestBrowser/mainwindow.cpp:
1008         (MainWindow::buildUI):
1009         (MainWindow::onTitleChanged):
1010         * QtTestBrowser/mainwindow.h:
1011
1012 2011-03-27  Jer Noble  <jer.noble@apple.com>
1013
1014         Reviewed by Maciej Stachowiak.
1015
1016         Full Screen: disable keyboard access by default
1017         https://bugs.webkit.org/show_bug.cgi?id=56684
1018
1019         Accept the withKeyboard parameter to supportsFullScreenForElement.
1020
1021         * DumpRenderTree/mac/UIDelegate.mm:
1022         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
1023
1024 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
1025
1026         Reviewed by David Levin.
1027
1028         check-webkit-style should check ChangeLog for a valid bug number
1029         https://bugs.webkit.org/show_bug.cgi?id=57184
1030
1031         * Scripts/webkitpy/style/checker.py:
1032         * Scripts/webkitpy/style/checker_unittest.py:
1033         * Scripts/webkitpy/style/checkers/changelog.py: Added.
1034         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
1035
1036 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1037
1038         Reviewed by Andreas Kling.
1039
1040         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1041         https://bugs.webkit.org/show_bug.cgi?id=57087
1042
1043         Use explicit conversion for string to avoid depending on the default codec
1044         installed by the user code.
1045
1046         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1047         (WTR::activateFonts):
1048
1049 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
1050
1051         Revert inadvertantly committed changes.
1052
1053         * Scripts/old-run-webkit-tests:
1054         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1055
1056 2011-03-26  Andreas Kling  <kling@webkit.org>
1057
1058         Reviewed by Kenneth Rohde Christiansen.
1059
1060         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
1061         https://bugs.webkit.org/show_bug.cgi?id=57162
1062
1063         * QtTestBrowser/QtTestBrowser.qrc:
1064         * QtTestBrowser/favicon.png: Added.
1065         * QtTestBrowser/locationedit.cpp:
1066         (defaultPageIcon):
1067         (LocationEdit::LocationEdit):
1068         (LocationEdit::setPageIcon):
1069         (LocationEdit::resizeEvent):
1070         (LocationEdit::updateInternalGeometry):
1071         * QtTestBrowser/locationedit.h:
1072         * QtTestBrowser/mainwindow.cpp:
1073         (MainWindow::buildUI):
1074         (MainWindow::onIconChanged):
1075         (MainWindow::onLoadStarted):
1076         * QtTestBrowser/mainwindow.h:
1077
1078 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
1079
1080         Reviewed by Xan Lopez.
1081
1082         [GTK] Force DumpRenderTree to use 96 DPI
1083         https://bugs.webkit.org/show_bug.cgi?id=56866
1084
1085         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
1086         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
1087
1088         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1089         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
1090         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
1091         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
1092
1093 2011-03-25  Andy Estes  <aestes@apple.com>
1094
1095         Reviewed by Adele Peterson.
1096
1097         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1098         https://bugs.webkit.org/show_bug.cgi?id=49016
1099
1100         TestNetscapePlugIn needs to register support for an image MIME type so
1101         we can test that the embed tag prefers plug-ins to render image MIME
1102         types.
1103
1104         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
1105         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1106         (NP_GetMIMEDescription): Ditto.
1107         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
1108
1109 2011-03-25  Jessie Berlin  <jberlin@apple.com>
1110
1111         Reviewed by Sam Weinig.
1112
1113         WebKit2: Need to be able to set and get the Cookie Storage Policy.
1114         https://bugs.webkit.org/show_bug.cgi?id=50780
1115
1116         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
1117
1118         The test is named "CookieManager" so that we can eventually exercise more of the
1119         CookieManager functionality in the test.
1120
1121         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
1122         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
1123         Assert that the policy returned is equal to the policy set in
1124         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
1125         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
1126         Set the policy to something different than the user's policy and get the policy again.
1127         (TestWebKitAPI::didFinishLoadForFrame):
1128         Get the user's policy so that it can be restored at the end of the test.
1129         (TestWebKitAPI::TEST):
1130         Load about:blank so that the Web Process gets instatiated (needed to get the
1131         CookieManager).
1132
1133         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1134         Add CookieManager.cpp.
1135
1136 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
1137
1138         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
1139
1140         * wx/build/settings.py:
1141
1142 2011-03-24  Ilya Sherman  <isherman@chromium.org>
1143
1144         Reviewed by Adam Roben.
1145
1146         Implement layoutTestController.setAutoFilled in DRT on Windows
1147         https://bugs.webkit.org/show_bug.cgi?id=56828
1148
1149         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1150         (LayoutTestController::setAutofilled): Implemented.
1151
1152 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1153
1154         Unreviewed build correction.
1155
1156         Correct vsprops file for Debug variant of the CFLite build.
1157         Disable a CFNETWORK-specific test when building for CFLite.
1158
1159         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
1160         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1161
1162 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1163
1164         Reviewed by Adam Barth.
1165
1166         fix regressions introduced in 81908 - there were a couple of
1167         code paths that only fired under python 2.5 that I missed.
1168
1169         Also change a couple of 'python' references to sys.executable
1170         in order to handle runing test-webkitpy with a binary other than
1171         something called 'python'.
1172
1173         https://bugs.webkit.org/show_bug.cgi?id=57063
1174
1175         * Scripts/webkitpy/layout_tests/port/mac.py:
1176         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1177         * Scripts/webkitpy/test/cat.py:
1178         * Scripts/webkitpy/test/echo.py:
1179
1180 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1181
1182         Unreviewed build correction.
1183
1184         Add a stub implementation of the TestInvocation dumping logic.
1185         Update project files to reflect new file.
1186
1187         * WebKitTestRunner/cairo: Added.
1188         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
1189         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1190         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1191
1192 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1193
1194         Reviewed by Tony Chang.
1195
1196         new-run-webkit-tests: clean up worker model defaults. This
1197         changes the default behavior to 'threads' instead of
1198         'old-threads', and clarifies that chromium-win-* and
1199         chromium-mac-leopard are exceptions.
1200
1201         https://bugs.webkit.org/show_bug.cgi?id=56971
1202
1203         * Scripts/webkitpy/layout_tests/port/base.py:
1204         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1205         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1206         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1207         * Scripts/webkitpy/layout_tests/port/test.py:
1208         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1209
1210 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
1211
1212         Reviewed by Darin Adler.
1213
1214         Media Stream API: fix the order of the options in build-webkit.
1215         https://bugs.webkit.org/show_bug.cgi?id=56949
1216
1217         Fix the order of the options in build-webkit.
1218
1219         * Scripts/build-webkit:
1220
1221 2011-03-23  Adam Klein  <adamk@chromium.org>
1222
1223         Reviewed by Mihai Parparita.
1224
1225         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
1226         https://bugs.webkit.org/show_bug.cgi?id=56884
1227
1228         This option will be utilized by Chromium's ui_tests to allow
1229         referencing js-test-resources from a layout test over HTTP.
1230
1231         * Scripts/new-run-webkit-httpd:
1232         Added --layout_tests_dir option.
1233         * Scripts/webkitpy/layout_tests/port/http_server.py:
1234         Plumbed through as layout_tests_dir param.
1235
1236 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
1237
1238         Reviewed by Mihai Parparita.
1239
1240         new-run-webkit-tests: run tests in ascending alphabetical order per
1241         dir. This is a second attempt at the fix; the first attempt, in 
1242         r81597, broke the behavior on the old-inline and old-threads
1243         worker models.
1244
1245         https://bugs.webkit.org/show_bug.cgi?id=56760
1246
1247         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1248         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1249         * Scripts/webkitpy/layout_tests/port/test.py:
1250         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1251
1252 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
1253
1254         Reviewed by Martin Robinson.
1255
1256         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
1257         https://bugs.webkit.org/show_bug.cgi?id=56953
1258
1259         Print the string for the detail of 'property-change' signal.
1260
1261         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1262         (axObjectEventListener): Print the detail string.
1263
1264 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
1265
1266         Reviewed by Pavel Feldman.
1267
1268         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
1269         https://bugs.webkit.org/show_bug.cgi?id=56843
1270
1271         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1272         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1273
1274 2011-03-22  Eric Seidel  <eric@webkit.org>
1275
1276         Reviewed by Adam Barth.
1277
1278         Teach update-webkit about gyp
1279         https://bugs.webkit.org/show_bug.cgi?id=56881
1280
1281         This makes it possible for someone who builds from Xcode
1282         to just run update-webkit --gyp and have the project files
1283         generated after update automatically.
1284
1285         I also added a stand-alone "generate-project-files" script
1286         wrapping Source/gyp/configure.  This makes running gyp simpler
1287         since most people will not have gyp or Source/gyp in their path.
1288
1289         * Scripts/build-webkit:
1290         * Scripts/generate-project-files: Added.
1291         * Scripts/update-webkit:
1292
1293 2011-03-22  Anton D'Auria  <adauria@apple.com>
1294
1295         Reviewed by Alexey Proskuryakov.
1296
1297         Add +[WebApplicationCache getOriginsWithCache]
1298         https://bugs.webkit.org/show_bug.cgi?id=56722
1299
1300         * DumpRenderTree/LayoutTestController.cpp:
1301         (originsWithApplicationCacheCallback):
1302         (LayoutTestController::staticFunctions):
1303         * DumpRenderTree/LayoutTestController.h:
1304         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
1305         (LayoutTestController::originsWithApplicationCache):
1306         * DumpRenderTree/chromium/LayoutTestController.h:
1307         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
1308         (LayoutTestController::originsWithApplicationCache):
1309         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
1310         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
1311         (LayoutTestController::originsWithApplicationCache):
1312         (LayoutTestController::originsWithLocalStorage):
1313         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
1314         (LayoutTestController::originsWithApplicationCache):
1315         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1316         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
1317         (LayoutTestController::originsWithApplicationCache):
1318         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
1319         (LayoutTestController::originsWithApplicationCache):
1320
1321 2011-03-22  Eric Seidel  <eric@webkit.org>
1322
1323         Reviewed by Adam Barth.
1324
1325         Add support to build-webkit for building with gyp-generated project files
1326         https://bugs.webkit.org/show_bug.cgi?id=56877
1327
1328         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
1329         Eventually we'll want to support gyp-generated projects in a more general manner.
1330
1331         * Scripts/build-webkit:
1332
1333 2011-03-22  David Kilzer  <ddkilzer@apple.com>
1334
1335         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
1336
1337         Reviewed by Joseph Pecoraro.
1338
1339         * Scripts/build-webkit: Updated usage statement to include
1340         --dsym.
1341         * Scripts/webkitdirs.pm: Added $generateDsym variable.
1342         (generateDsym): Added. Call determineGenerateDsym() and
1343         return $generateDsym.
1344         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
1345         $generateDsym.
1346         (argumentsForXcode): Added.  Returns additional arguments for
1347         xcodebuild based on command-line switches.
1348         (XcodeOptions): Updated to include argumentsForXcode() in the
1349         array returned.
1350
1351 2011-03-22  Adam Roben  <aroben@apple.com>
1352
1353         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
1354
1355         These bots are consistently green again.
1356
1357         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
1358         core builders
1359
1360         Rubber-stamped by Antti Koivisto.
1361
1362         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1363         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
1364
1365         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1366         (BuildBotTest.test_builder_name_regexps): Updated expectations.
1367
1368 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
1369
1370         Unreviewed, rolling out r81597.
1371         http://trac.webkit.org/changeset/81597
1372         https://bugs.webkit.org/show_bug.cgi?id=56801
1373
1374         Change results in lots of unexpected flaky on the dashboard.
1375         (Requested by pfeldman on #webkit).
1376
1377         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1378         * Scripts/webkitpy/layout_tests/port/test.py:
1379         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1380
1381 2011-03-21  Sam Weinig  <sam@webkit.org>
1382
1383         Fix failing tests on the WebKit2 bots.
1384
1385         * WebKitTestRunner/TestController.cpp:
1386         (WTR::TestController::resetStateToConsistentValues):
1387
1388 2011-03-21  Daniel Sievers  <sievers@google.com>
1389
1390         Reviewed by Simon Fraser.
1391
1392         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1393         https://bugs.webkit.org/show_bug.cgi?id=56139
1394
1395         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1396         (main):
1397         * DumpRenderTree/chromium/LayoutTestController.cpp:
1398         (LayoutTestController::LayoutTestController):
1399         (LayoutTestController::layerTreeAsText):
1400         * DumpRenderTree/chromium/LayoutTestController.h:
1401         (LayoutTestController::setShowDebugLayerTree):
1402         * DumpRenderTree/chromium/TestShell.cpp:
1403         (TestShell::runFileTest):
1404         (TestShell::dump):
1405         * DumpRenderTree/chromium/TestShell.h:
1406         (TestParams::TestParams):
1407
1408 2011-03-21  Adam Roben  <aroben@apple.com>
1409
1410         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
1411
1412         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1413         output as plain text
1414
1415         Reviewed by David Kilzer.
1416
1417         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1418         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
1419         to the master.
1420         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
1421         since we're running on the build master, not the slave. Instead, turn the raw source of
1422         actual.html which the build slave uploaded into an HTML log.
1423
1424 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
1425
1426         Reviewed by Mihai Parparita.
1427
1428         new-run-webkit-tests: run tests in ascending alphabetical order per dir
1429         https://bugs.webkit.org/show_bug.cgi?id=56760
1430
1431         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1432         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1433         * Scripts/webkitpy/layout_tests/port/test.py:
1434
1435 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
1436
1437         Reviewed by Steve Block.
1438
1439         Media Stream API patch 0: adding compilation guards.
1440         https://bugs.webkit.org/show_bug.cgi?id=56458
1441
1442         Adding options to enable the media stream API feature in Chromium.
1443
1444         * Scripts/build-webkit:
1445
1446 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
1447
1448         Reviewed by Laszlo Gombos.
1449
1450         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
1451         https://bugs.webkit.org/show_bug.cgi?id=56323
1452
1453         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
1454         "--stdout" or "--stderr" option.
1455
1456         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1457         (WebCore::DumpRenderTree::~DumpRenderTree):
1458         (WebCore::DumpRenderTree::processArgsLine):
1459         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1460         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1461         (WebCore::DumpRenderTree::setRedirectOutputFileName):
1462         (WebCore::DumpRenderTree::setRedirectErrorFileName):
1463         * DumpRenderTree/qt/main.cpp:
1464         (isOption):
1465         (takeOptionValue):
1466         (printUsage):
1467         (main):
1468
1469 2011-03-21  Adam Roben  <aroben@apple.com>
1470
1471         Fix exceptions on the buildbot due to my last change
1472
1473         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1474         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
1475
1476 2011-03-21  Adam Roben  <aroben@apple.com>
1477
1478         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
1479
1480         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1481         output as plain text
1482
1483         Reviewed by Darin Adler.
1484
1485         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1486         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
1487         logs.
1488         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
1489         the build master. This will correctly treat it as HTML.
1490
1491 2011-03-20  Bill Budge  <bbudge@chromium.org>
1492
1493         Reviewed by Adam Barth.
1494
1495         Rename ThreadSafeShared to ThreadSafeRefCounted
1496         https://bugs.webkit.org/show_bug.cgi?id=56714
1497
1498         No new tests. Exposes no new functionality.
1499
1500         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
1501         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
1502         * Scripts/do-webcore-rename:
1503
1504 2011-03-19  Anton D'Auria  <adauria@apple.com>
1505
1506         Reviewed by Dan Bernstein.
1507
1508         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
1509         https://bugs.webkit.org/show_bug.cgi?id=56719
1510
1511         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
1512         (LayoutTestController::clearApplicationCacheForOrigin):
1513
1514 2011-03-19  Anton D'Auria  <adauria@apple.com>
1515
1516         Reviewed by Alexey Proskuryakov.
1517
1518         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1519         https://bugs.webkit.org/show_bug.cgi?id=56415
1520
1521         * DumpRenderTree/LayoutTestController.cpp:
1522         (clearApplicationCacheForOriginCallback):
1523         (LayoutTestController::staticFunctions):
1524         * DumpRenderTree/LayoutTestController.h:
1525         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
1526         (LayoutTestController::LayoutTestController):
1527         (LayoutTestController::clearAllApplicationCaches):
1528         (LayoutTestController::clearApplicationCacheForOrigin): 
1529         * DumpRenderTree/chromium/LayoutTestController.h:
1530         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
1531         (LayoutTestController::clearApplicationCacheForOrigin):
1532         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
1533         (LayoutTestController::clearApplicationCacheForOrigin):
1534         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1535         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
1536         (LayoutTestController::clearApplicationCacheForOrigin):
1537         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
1538         (LayoutTestController::clearApplicationCacheForOrigin):
1539
1540 2011-03-18  Dan Bernstein  <mitz@apple.com>
1541
1542         Revised build fix for r81135.
1543
1544         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1545         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1546
1547 2011-03-18  Adam Roben  <aroben@apple.com>
1548
1549         Windows build fix
1550
1551         * WebKitTestRunner/config.h: Add a missing #endif.
1552
1553 2011-03-18  Andreas Kling  <kling@webkit.org>
1554
1555         Unbreak Qt build after r81494.
1556
1557         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1558         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1559
1560 2011-03-18  Sam Weinig  <sam@webkit.org>
1561
1562         Fix windows build. This was really Adam Roben's fault. I swear!
1563
1564         * WebKitTestRunner/config.h:
1565
1566 2011-03-18  Sam Weinig  <sam@webkit.org>
1567
1568         Reviewed by Adam Roben.
1569
1570         Pixel tests don't work in WebKitTestRunner on Windows
1571         https://bugs.webkit.org/show_bug.cgi?id=56630
1572
1573         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
1574         built-in snapshotting instead of using the window server on the Mac.
1575
1576         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1577         (WTR::InjectedBundle::InjectedBundle):
1578         (WTR::InjectedBundle::didReceiveMessage):
1579         (WTR::InjectedBundle::beginTesting):
1580         (WTR::InjectedBundle::done):
1581         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1582         (WTR::InjectedBundle::setPixelResult):
1583         (WTR::InjectedBundle::shouldDumpPixels):
1584         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1585         (WTR::InjectedBundlePage::dump):
1586         Take the snapshot in the bundle and send it to the UIProcess for dumping.
1587
1588         * WebKitTestRunner/TestInvocation.cpp:
1589         (WTR::TestInvocation::invoke):
1590         (WTR::TestInvocation::dump):
1591         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1592         * WebKitTestRunner/TestInvocation.h:
1593         * WebKitTestRunner/cg: Added.
1594         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1595         (WTR::createCGContextFromImage):
1596         (WTR::computeMD5HashStringForContext):
1597         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1598         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1599         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1600
1601         * WebKitTestRunner/win/TestInvocationWin.cpp:
1602         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1603         Keep stub for Cairo build.
1604
1605         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1606         Add CG configuration.
1607
1608         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1609         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1610         Add new files.
1611
1612 2011-03-18  Adam Roben  <aroben@apple.com>
1613
1614         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1615
1616         Rubber-stamped by Simon Fraser.
1617
1618         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1619         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1620         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1621
1622 2011-03-18  Adam Roben  <aroben@apple.com>
1623
1624         Don't ellipsize long or indented function names in Leaks Viewer
1625
1626         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1627         scrollbar
1628
1629         Reviewed by Simon Fraser.
1630
1631         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1632         (.data-grid .data-container):
1633         (.data-grid td > div, .data-grid th > div):
1634         Allow the contents to extend to the right.
1635
1636 2011-03-18  Adam Roben  <aroben@apple.com>
1637
1638         Fix some leaks in DRT seen on the leaks bot
1639
1640         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1641         setWillSendRequestClearHeaderCallback in DRT are leaky
1642
1643         Reviewed by Alexey Proskuryakov.
1644
1645         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1646
1647         * DumpRenderTree/LayoutTestController.cpp:
1648         (addURLToRedirectCallback):
1649         (setWillSendRequestClearHeaderCallback):
1650         Use OwnArrayPtr to cause the strings to be deleted.
1651
1652 2011-03-18  Adam Roben  <aroben@apple.com>
1653
1654         Fix a NSURLCredential leak seen on the leaks bot
1655
1656         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1657         connection:didReceiveAuthenticationChallenge:] is leaky
1658
1659         Reviewed by John Sullivan.
1660
1661         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1662         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
1663         cause the NSURLCredential to be released.
1664
1665 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
1666
1667         Unreviewed.
1668
1669         Remove unnecessary brackets around my email address.
1670
1671         * Scripts/webkitpy/common/config/committers.py:
1672
1673 2011-03-18  Adam Roben  <aroben@apple.com>
1674         
1675         Remove some files I accidentally added in r81454
1676
1677         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
1678         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
1679
1680 2011-03-18  Adam Roben  <aroben@apple.com>
1681
1682         Ignore an NSNumberFormatter leak on SnowLeopard
1683
1684         * Scripts/old-run-webkit-tests:
1685         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
1686         getObjectValue:forString:errorDescription:].
1687
1688 2011-03-18  Adam Roben  <aroben@apple.com>
1689
1690         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
1691
1692         Rubber-stamped by Mark Rowe.
1693
1694         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1695         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
1696         released.
1697
1698 2011-03-17  Adam Roben  <aroben@apple.com>
1699
1700         Address a review comment I missed in r81445
1701
1702         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1703         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
1704         leaked bytes to speed up searching on long lines.
1705
1706 2011-03-17  Adam Roben  <aroben@apple.com>
1707
1708         Mark leaky builds orange, even if all regression tests passed
1709
1710         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
1711         build.webkit.org when all tests pass even though there are still leaks
1712
1713         Reviewed by Dan Bernstein.
1714
1715         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1716         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
1717         be marked orange if this build step generates warnings.
1718
1719 2011-03-17  Adam Roben  <aroben@apple.com>
1720
1721         Allow values in Leaks Viewer to be shown as percentages
1722
1723         Double-clicking on a column will toggle between showing percentages and showing real values.
1724
1725         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
1726         number of leaked bytes in Leaks Viewer
1727
1728         Reviewed by Joe Pecoraro.
1729
1730         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1731         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
1732         node's totalTime, which is used in calculating percentages.
1733
1734         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1735         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
1736         showing them as percentages.
1737
1738 2011-03-17  Adam Roben  <aroben@apple.com>
1739
1740         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
1741
1742         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
1743         the number of leaked allocations. And the new Average column shows the average number of
1744         leaked bytes per call.
1745
1746         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
1747         just how many allocations
1748
1749         Reviewed by Joe Pecoraro.
1750
1751         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1752         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
1753         line and store it with the leak stack.
1754         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
1755         properties.
1756         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
1757         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
1758         .numberOfCalls now holds the number of leaked allocations.
1759
1760         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1761         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
1762         appear.
1763         (monkeyPatchInspectorObjects): Format the values as bytes.
1764
1765 2011-03-17  Adam Roben  <aroben@apple.com>
1766
1767         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
1768
1769         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
1770         regression tests
1771
1772         Reviewed by James Robinson.
1773
1774         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1775         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
1776         is always populated, even when all regression tests pass.
1777
1778 2011-03-10  Hayato Ito  <hayato@chromium.org>
1779
1780         Reviewed by Tony Chang.
1781
1782         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
1783
1784         https://bugs.webkit.org/show_bug.cgi?id=56076
1785
1786         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1787
1788 2011-03-17  Adam Roben  <aroben@apple.com>
1789
1790         Skip a compositing-sensitive test when accelerated compositing is disabled
1791
1792         Reviewed by Sam Weinig.
1793
1794         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
1795         accelerated compositing is disabled.
1796
1797 2011-03-17  Adam Roben  <aroben@apple.com>
1798
1799         Start using PlatformSpecificScheduler for the Mac builders
1800
1801         The current set of file/directory patterns should work for Mac builders. We may discover
1802         that there are more files and directories we can exclude from the Mac builds, but they can
1803         be added later.
1804
1805         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
1806
1807         Reviewed by Mark Rowe.
1808
1809         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
1810         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
1811
1812         * Scripts/webkitpy/common/config/build.py:
1813         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
1814         cleaned up patterns a little bit.
1815
1816         * Scripts/webkitpy/common/config/build_unittest.py:
1817         (ShouldBuildTest): Fixed some expected results.
1818         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
1819         platforms.
1820
1821 2011-03-17  Jeff Miller  <jeffm@apple.com>
1822
1823         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
1824         
1825         *.mode*
1826         *.pbxuser
1827         *.perspective*
1828         project.xcworkspace
1829         xcuserdata
1830
1831         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1832         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1833         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1834         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1835         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1836
1837 2011-03-17  Adam Roben  <aroben@apple.com>
1838
1839         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
1840
1841         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
1842         mac-wk2
1843
1844         Reviewed by Anders Carlsson.
1845
1846         * Scripts/old-run-webkit-tests:
1847         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
1848         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
1849         we're running in WebKit2 mode.
1850
1851 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
1852
1853         Reviewed by Yury Semikhatsky.
1854
1855         Web Inspector: Clean up Inspector strings.
1856         https://bugs.webkit.org/show_bug.cgi?id=56557
1857
1858         Modify the script to deal correctly with "\xNN" escapes, and to
1859         check strings in Chromium's DevTools.js.
1860
1861         * Scripts/check-inspector-strings:
1862
1863 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
1864
1865         Reviewed by Benjamin Poulain.
1866
1867         Update autoinstall to install mechanize 0.2.4
1868         https://bugs.webkit.org/show_bug.cgi?id=56499
1869
1870         Newer versions of mechanize support HTTPS proxies, which is necessary
1871         for people using webkit-patch behind firewalls.
1872
1873         * Scripts/webkitpy/common/system/autoinstall.py:
1874         * Scripts/webkitpy/thirdparty/__init__.py:
1875
1876 2011-03-16  Sam Weinig  <sam@webkit.org>
1877
1878         Reviewed by Adam Roben.
1879
1880         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
1881         https://bugs.webkit.org/show_bug.cgi?id=56541
1882
1883         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1884         (WTR::InjectedBundlePage::willSendRequestForFrame):
1885         Check for an empty host in addition to a null host.  This bug was introduced
1886         when porting off of the KURL code and onto the WKURLRef version.
1887
1888 2011-03-16  Sam Weinig  <sam@webkit.org>
1889
1890         Reviewed by Adam Roben.
1891
1892         Add Lucas Forschler to the list of WebKit committers.
1893
1894         * Scripts/webkitpy/common/config/committers.py:
1895
1896 2011-03-16  Sam Weinig  <sam@webkit.org>
1897
1898         Reviewed upon and dictated through Adam Roben.
1899
1900         Escape crashing function names in results.html. This fixes an issue
1901         when a crash involves a type with templates.
1902
1903         * Scripts/old-run-webkit-tests:
1904
1905 2011-03-16  Daniel Sievers  <sievers@google.com>
1906
1907         Reviewed by James Robinson.
1908
1909         Add setting to always force compositing mode
1910         https://bugs.webkit.org/show_bug.cgi?id=56156
1911
1912         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1913         (main):
1914         * DumpRenderTree/chromium/TestShell.cpp:
1915         (TestShell::TestShell):
1916         (TestShell::resetWebSettings):
1917         * DumpRenderTree/chromium/TestShell.h:
1918         (TestShell::setForceCompositingMode):
1919         * DumpRenderTree/chromium/WebPreferences.cpp:
1920         (WebPreferences::reset):
1921         (WebPreferences::applyTo):
1922         * DumpRenderTree/chromium/WebPreferences.h:
1923
1924 2011-03-15  Hayato Ito  <hayato@chromium.org>
1925
1926         Reviewed by Ojan Vafai.
1927
1928         Ignore files that will be used by reftests in old-run-webkit-tests.
1929
1930         https://bugs.webkit.org/show_bug.cgi?id=55936
1931
1932         * Scripts/old-run-webkit-tests:
1933
1934 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
1935
1936         Reviewed by Adam Roben.
1937
1938         Function relativeScriptsDir doesn't return the correct relative
1939         Scripts directory.
1940
1941         * Scripts/webkitdirs.pm:
1942         (relativeScriptsDir): Ensure we use the directory that contains
1943         webkitdirs.pm, not the one that contains the original script that
1944         was invoked.
1945
1946 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1947
1948         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
1949         fix to link against the Security framework after recent WebKitSystemInterface changes.
1950
1951         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1952         (LayoutTestController::originsWithLocalStorage):
1953         * wx/build/settings.py:
1954         * wx/build/waf_extensions.py:
1955
1956 2011-03-15  Sam Weinig  <sam@webkit.org>
1957
1958         Reviewed by Darin Adler.
1959
1960         Add script to convert a patch to a prettypatch and show in the default browser
1961         https://bugs.webkit.org/show_bug.cgi?id=56416
1962
1963         This can be used either like
1964             $ svn-create-patch | show-pretty-diff
1965         or
1966             $ show-pretty-diff patch.diff
1967
1968         * Scripts/show-pretty-diff: Added.
1969
1970 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
1971
1972         Rubber-stamped by Adam Roben.
1973
1974         Adding myself as a reviewer.
1975
1976         * Scripts/webkitpy/common/config/committers.py:
1977
1978 2011-03-15  Anders Carlsson  <andersca@apple.com>
1979
1980         Try to fix the Windows build.
1981
1982         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1983         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1984
1985 2011-03-15  Anders Carlsson  <andersca@apple.com>
1986
1987         Reviewed by Sam Weinig.
1988
1989         Make sure that NP_Shutdown is always the last NPP function called
1990         https://bugs.webkit.org/show_bug.cgi?id=56391
1991
1992         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
1993
1994         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1995         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1996         (PluginTest::PluginTest):
1997         (PluginTest::NP_Shutdown):
1998         (PluginTest::registerNPShutdownFunction):
1999         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2000         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
2001         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
2002         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2003         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
2004         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
2005         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
2006         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
2007         (NPDeallocateCalledBeforeNPShutdown::shutdown):
2008         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2009         (NP_Shutdown):
2010         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2011         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2012         * GNUmakefile.am:
2013
2014 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2015
2016         Reviewed by Tony Chang.
2017
2018         Autofilled form elements are assigned fixed background color but not text color
2019         https://bugs.webkit.org/show_bug.cgi?id=48382
2020
2021         * DumpRenderTree/LayoutTestController.cpp:
2022         (setAutofilledCallback): Added.
2023         (LayoutTestController::staticFunctions):
2024         * DumpRenderTree/LayoutTestController.h:
2025         * DumpRenderTree/chromium/LayoutTestController.cpp:
2026         (LayoutTestController::LayoutTestController):
2027         (LayoutTestController::setAutofilled): Added.
2028         * DumpRenderTree/chromium/LayoutTestController.h:
2029         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2030         (LayoutTestController::setAutofilled): Added.
2031         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2032         (LayoutTestController::setAutofilled): Added.
2033         (LayoutTestController::setValueForUser): Style tweak.
2034         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2035         (LayoutTestController::setAutofilled): Added (stub).
2036         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2037         (LayoutTestController::setAutofilled): Added (stub).
2038
2039 2011-03-15  Dan Bernstein  <mitz@apple.com>
2040
2041         Build fix after r81135.
2042
2043         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2044
2045 2011-03-15  Dan Bernstein  <mitz@apple.com>
2046
2047         Build fix after r81135.
2048
2049         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2050         * WebKitTestRunner/mac/TestControllerMac.mm:
2051         * WebKitTestRunner/mac/TestInvocationMac.mm:
2052         * WebKitTestRunner/mac/main.mm:
2053
2054 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
2055
2056         Reviewed by Adam Barth.
2057
2058         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
2059         https://bugs.webkit.org/show_bug.cgi?id=56349
2060
2061         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
2062         on platforms where we use it. Copied from DumpRenderTree.pro.
2063
2064 2011-03-15  Dan Bernstein  <mitz@apple.com>
2065
2066         Build fix after r81135.
2067
2068         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2069         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2070
2071 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2072
2073         Reviewed by Darin Adler.
2074
2075         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2076         info into the headers rather than in export symbol definition files, but disable it on 
2077         all platforms initially so we can deal with port build issues one port at a time.
2078         
2079         https://bugs.webkit.org/show_bug.cgi?id=27551
2080
2081         * DumpRenderTree/cg/ImageDiffCG.cpp:
2082         * DumpRenderTree/chromium/config.h:
2083         * DumpRenderTree/config.h:
2084         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2085         * TestWebKitAPI/TestWebKitAPIPrefix.h:
2086         * WebKitAPITest/HostWindow.cpp:
2087         * WebKitAPITest/TestsController.cpp:
2088         * WebKitAPITest/config.h: Added.
2089         * WebKitAPITest/main.cpp:
2090         * WebKitAPITest/tests/WebViewDestruction.cpp:
2091         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
2092         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2093         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2094         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2095         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2096         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2097         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2098         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2099         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2100         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2101         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2102         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2103         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2104         * WebKitTestRunner/TestController.cpp:
2105         * WebKitTestRunner/TestInvocation.cpp:
2106         * WebKitTestRunner/config.h: Added.
2107         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2108         * WebKitTestRunner/qt/TestControllerQt.cpp:
2109         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2110         * WebKitTestRunner/qt/main.cpp:
2111         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2112         * WebKitTestRunner/win/TestControllerWin.cpp:
2113         * WebKitTestRunner/win/TestInvocationWin.cpp:
2114         * WebKitTestRunner/win/main.cpp:
2115         * wx/build/settings.py:
2116
2117 2011-03-15  Hayato Ito  <hayato@chromium.org>
2118
2119         Reviewed by Shinichiro Hamaji.
2120
2121         [NRWT] Add support for reftests to new-run-webkit-tests.
2122
2123         https://bugs.webkit.org/show_bug.cgi?id=55457
2124
2125         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2126         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2127         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2128         * Scripts/webkitpy/layout_tests/port/base.py:
2129         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2130         * Scripts/webkitpy/layout_tests/port/test.py:
2131         * Scripts/webkitpy/layout_tests/port/test_files.py:
2132         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2133
2134 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
2135
2136         Reviewed by Martin Robinson.
2137
2138         [GTK] Fix compilation warning after r80892
2139         https://bugs.webkit.org/show_bug.cgi?id=56302
2140
2141         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2142         (LayoutTestController::originsWithLocalStorage):
2143
2144 2011-03-15  Robert Hogan  <robert@webkit.org>
2145
2146         Reviewed by Adam Barth.
2147
2148         Document the qmakearg argument, and hint how to build webkit2 on Qt
2149         https://bugs.webkit.org/show_bug.cgi?id=56326
2150
2151         * Scripts/build-webkit: add --qmakearg to build-webkit --help
2152
2153 2011-03-15  Adam Roben  <aroben@apple.com>
2154
2155         Make Windows 7 Release (Tests) a core builder
2156
2157         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2158         give it a few more days of greenness first.
2159
2160         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2161
2162         Reviewed by Sam Weinig.
2163
2164         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2165         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2166
2167         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2168         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2169         Updated the core regexps to match the buildbot module. Updated the expected results to match
2170         the current set of core builders.
2171
2172 2011-03-14  Adam Roben  <aroben@apple.com>
2173
2174         Add forgotten file from r81116
2175
2176         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
2177
2178 2011-03-14  Sam Weinig  <sam@webkit.org>
2179
2180         Reviewed by Adam Roben.
2181
2182         about:blank fake responses don't get serialized when sent the UIProcess
2183         <rdar://problem/9108119>
2184         https://bugs.webkit.org/show_bug.cgi?id=56357
2185
2186         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
2187         (TestWebKitAPI::decidePolicyForResponse):
2188         (TestWebKitAPI::TEST):
2189         Add test that loads of about:blank have a response with a MIMEType of text/html.
2190
2191         * TestWebKitAPI/PlatformUtilities.h:
2192         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2193         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2194         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2195         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2196         Add helper to get the MIMEType from a WKURLResponse.
2197
2198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2199         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2200         Add new files.
2201
2202 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2203
2204         Reviewed by Kenneth Rohde Christiansen.
2205
2206         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
2207         https://bugs.webkit.org/show_bug.cgi?id=56006
2208
2209         * QtTestBrowser/launcherwindow.cpp:
2210         (LauncherWindow::initializeView):
2211         * QtTestBrowser/main.cpp:
2212         (LauncherApplication::handleUserOptions):
2213
2214 2011-03-14  James Kozianski  <koz@chromium.org>
2215
2216         Reviewed by Ojan Vafai.
2217
2218         Add method to make BuildBot return test outputs
2219         https://bugs.webkit.org/show_bug.cgi?id=54374
2220
2221         The Builder.latest_cached_build will be used by the new rebaseline
2222         script to determine the build to use baselines from.
2223
2224         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2225         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2226
2227 2011-03-14  Adam Roben  <aroben@apple.com>
2228
2229         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
2230
2231         Reviewed by Sam Weinig.
2232
2233         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
2234         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
2235         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
2236         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
2237         ensure the web process is initialized, then ask the bundle to run the test and assert that
2238         it succeeded.
2239
2240         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
2241         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
2242         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
2243         handle a given URL.
2244         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
2245         URL type cannot be handled).
2246         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
2247         result.
2248
2249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2250         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2251         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2252         Added new files to the project.
2253
2254 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2255
2256         Unreviewed, rolling out r81094.
2257         http://trac.webkit.org/changeset/81094
2258         https://bugs.webkit.org/show_bug.cgi?id=56355
2259
2260         Broke the chromium DRT related build. (Requested by dave_levin
2261         on #webkit).
2262
2263         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2264         (main):
2265         * DumpRenderTree/chromium/LayoutTestController.cpp:
2266         (LayoutTestController::LayoutTestController):
2267         (LayoutTestController::layerTreeAsText):
2268         * DumpRenderTree/chromium/LayoutTestController.h:
2269         * DumpRenderTree/chromium/TestShell.cpp:
2270         (TestShell::runFileTest):
2271         (TestShell::dump):
2272         * DumpRenderTree/chromium/TestShell.h:
2273         (TestParams::TestParams):
2274
2275 2011-03-14  Daniel Sievers  <sievers@google.com>
2276
2277         Reviewed by Simon Fraser.
2278
2279         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2280         https://bugs.webkit.org/show_bug.cgi?id=56139
2281
2282         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2283         (main):
2284         * DumpRenderTree/chromium/LayoutTestController.cpp:
2285         (LayoutTestController::LayoutTestController):
2286         (LayoutTestController::layerTreeAsText):
2287         * DumpRenderTree/chromium/LayoutTestController.h:
2288         (LayoutTestController::setShowDebugLayerTree):
2289         * DumpRenderTree/chromium/TestShell.cpp:
2290         (TestShell::runFileTest):
2291         (TestShell::dump):
2292         * DumpRenderTree/chromium/TestShell.h:
2293         (TestParams::TestParams):
2294
2295 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2296
2297         Reviewed by Adam Roben.
2298
2299         [Qt][WK2]Unbreak InjectedBundle on Qt
2300         https://bugs.webkit.org/show_bug.cgi?id=54109
2301
2302         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2303         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
2304         API's instead of KURL to analyze the URL.
2305         * WebKitTestRunner/StringFunctions.h:
2306         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
2307         in the WebKitTestRunner project.
2308         (WTR::toWK): Use adoptWK.
2309         (WTR::operator<<): Added helper for printing a WKURL.
2310         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
2311         against WebCore.
2312
2313 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2314
2315         Reviewed by Kenneth Rohde Christiansen.
2316
2317         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
2318         https://bugs.webkit.org/show_bug.cgi?id=56321
2319
2320         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
2321         to the list of exceptions for WebKit2 C API headers.
2322
2323 2011-03-14  Adam Roben  <aroben@apple.com>
2324
2325         Show the list of recent leaky builds in reverse chronological order
2326
2327         Previously they were being shown in a deterministic but surprising order based on
2328         lexicographically sorting the build offsets (-1, -10, -2, -3...).
2329
2330         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
2331
2332         Reviewed by Darin Adler.
2333
2334         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2335         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
2336         callback.
2337
2338 2011-03-14  Adam Roben  <aroben@apple.com>
2339
2340         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
2341
2342         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
2343         analyze
2344
2345         Reviewed by David Kilzer and Joe Pecoraro.
2346
2347         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2348         (#url-prompt): Made this a bit taller to make room for the list of builds.
2349
2350         (#recent-builds-loading-indicator):
2351         (#recent-builds-list):
2352         Added styles for the build list and loading indicator.
2353
2354         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2355         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
2356         it. This will unescape it.
2357         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
2358         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
2359         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
2360         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
2361         prompt UI.
2362         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
2363         now also used when a recent build is clicked.
2364
2365         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
2366         (RecentBuildsLoader): Store the callback.
2367         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
2368         builder. Find the revision number, leak count, and results URL for each one. Pass the
2369         resulting info to our callback.
2370
2371         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2372         (range): Added this helper function to return an array containing the integers [0, n).
2373
2374         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
2375         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
2376
2377 2011-03-14  Mark Rowe  <mrowe@apple.com>
2378
2379         Reviewed by Adam Roben.
2380
2381         Fix two memory leaks within LayoutTestController's storage support.
2382
2383         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2384         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
2385         by JSStringCreateWithCFString.
2386         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
2387         allocate.
2388
2389 2011-03-14  Mark Rowe  <mrowe@apple.com>
2390
2391         Reviewed by Oliver Hunt.
2392
2393         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
2394
2395         * DumpRenderTree/LayoutTestController.cpp:
2396         (LayoutTestController::staticFunctions): Remove duplicate entries.
2397
2398 2011-03-14  Alice Liu  <alice.liu@apple.com>
2399
2400         Reviewed by Dan Bernstein.
2401
2402         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
2403
2404         * DumpRenderTree/mac/PerlSupport/Makefile:
2405         Add whitespace when joining "-arch" with the architectures passed in as arguments.
2406
2407 2011-03-14  Daniel Bates  <dbates@rim.com>
2408
2409         https://bugs.webkit.org/show_bug.cgi?id=55438
2410         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
2411         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
2412
2413         * Scripts/build-webkit:
2414
2415 2011-03-14  Daniel Bates  <dbates@rim.com>
2416
2417         Reviewed by David Kilzer.
2418
2419         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
2420         https://bugs.webkit.org/show_bug.cgi?id=55438
2421
2422         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
2423         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
2424         CMake arguments for feature defines.
2425
2426         * Scripts/build-webkit:
2427           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
2428           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
2429           - Sorted forward declarations.
2430           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
2431             Modified call sites as needed.
2432         * Scripts/webkitdirs.pm:
2433           - Added cleanCMakeGeneratedProject() to clean a CMake build.
2434           - Added buildCMakeGeneratedProject() to build using generated build system.
2435           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
2436           - Added generateBuildSystemFromCMakeProject() to generate the build system from
2437             a CMake project.
2438           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
2439
2440 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
2441
2442         Reviewed by Steve Block.
2443
2444         Detach Geolocation from Frame when Page destroyed.
2445         https://bugs.webkit.org/show_bug.cgi?id=52877
2446
2447         Extend the layout test controller to expose the number of pending
2448         geolocation requests, so that we can test that the requests have
2449         been cancelled on page close.
2450
2451         * DumpRenderTree/LayoutTestController.cpp:
2452         (numberOfPendingGeolocationPermissionRequestsCallback):
2453         (LayoutTestController::staticFunctions):
2454         * DumpRenderTree/LayoutTestController.h:
2455         * DumpRenderTree/chromium/LayoutTestController.cpp:
2456         (LayoutTestController::LayoutTestController):
2457         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2458         * DumpRenderTree/chromium/LayoutTestController.h:
2459         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2460         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2461         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2462         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2463         * DumpRenderTree/mac/UIDelegate.h:
2464         * DumpRenderTree/mac/UIDelegate.mm:
2465         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2466         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2467         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2468         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2469         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2470         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2471         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2472         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2473
2474
2475 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2476
2477         Unreviewed. Modify my email address in committers.py.
2478
2479         * Scripts/webkitpy/common/config/committers.py:
2480
2481 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
2482
2483         Reviewed by Kenneth Rohde Christiansen.
2484
2485         [Qt] QtLauncher does not load the same set of fonts as the DRT
2486         https://bugs.webkit.org/show_bug.cgi?id=34959
2487
2488         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
2489         When this option is used the webkit fonts are loaded the same
2490         as they are in DumpRenderTree.  This option can be used on
2491         QtTestBrowser and run-launcher.  It can only be used
2492         on Linux systems with FcInit and is configured as such.
2493
2494         * QtTestBrowser/launcherwindow.h:
2495         (WindowOptions::WindowOptions):
2496         * QtTestBrowser/main.cpp:
2497         (initWebKitTestFonts):
2498         (launcherMain):
2499         (LauncherApplication::handleUserOptions):
2500
2501 2011-03-12  Dan Bernstein  <mitz@apple.com>
2502
2503         Reviewed by Mark Rowe.
2504
2505         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
2506         DumpRenderTree is being built for.
2507
2508         * DumpRenderTree/mac/PerlSupport/Makefile:
2509
2510 2011-03-12  Dan Bernstein  <mitz@apple.com>
2511
2512         Suggested by Mark Rowe.
2513
2514         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
2515         as they were before r80915.
2516
2517 2011-03-12  Anders Carlsson  <andersca@apple.com>
2518
2519         Reviewed by Sam Weinig.
2520
2521         Should be able to download a PDF to the Downloads folder
2522         https://bugs.webkit.org/show_bug.cgi?id=56256
2523
2524         * MiniBrowser/mac/BrowserWindowController.m:
2525         (-[BrowserWindowController awakeFromNib]):
2526         * WebKitTestRunner/TestController.cpp:
2527         (WTR::TestController::createOtherPage):
2528         (WTR::TestController::initialize):
2529         Update for API changes.
2530
2531 2011-03-11  Anton D'Auria  <adauria@apple.com>
2532
2533         Reviewed and landed by Brady Eidson.
2534
2535         https://bugs.webkit.org/show_bug.cgi?id=51878
2536         Add WebKit1 API to view and delete local storage
2537
2538         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
2539
2540         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2541         * DumpRenderTree/LayoutTestController.cpp:
2542         (syncLocalStorageCallback):
2543         (observeStorageTrackerNotificationsCallback):
2544         (deleteAllLocalStorageCallback):
2545         (deleteLocalStorageForOriginCallback):
2546         (originsWithLocalStorageCallback):
2547         (LayoutTestController::staticFunctions):
2548         * DumpRenderTree/LayoutTestController.h:
2549         * DumpRenderTree/StorageTrackerDelegate.h: Added.
2550         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
2551         (-[StorageTrackerDelegate init]):
2552         (-[StorageTrackerDelegate logNotifications:controller:]):
2553         (-[StorageTrackerDelegate originModified:]):
2554         (-[StorageTrackerDelegate dealloc]):
2555         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
2556         * DumpRenderTree/chromium/LayoutTestController.cpp:
2557         (LayoutTestController::LayoutTestController):
2558         (LayoutTestController::deleteAllLocalStorage):
2559         (LayoutTestController::originsWithLocalStorage):
2560         (LayoutTestController::deleteLocalStorageForOrigin):
2561         (observeStorageTrackerNotifications):
2562         (syncLocalStorage):
2563         * DumpRenderTree/chromium/LayoutTestController.h:
2564         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2565         (LayoutTestController::originsWithLocalStorage):
2566         (LayoutTestController::deleteAllLocalStorage):
2567         (LayoutTestController::deleteLocalStorageForOrigin):
2568         (LayoutTestController::observeStorageTrackerNotifications):
2569         (LayoutTestController::syncLocalStorage):
2570         * DumpRenderTree/mac/DumpRenderTree.mm:
2571         (resetDefaultsToConsistentValues):
2572         (allocateGlobalControllers):
2573         (releaseGlobalControllers):
2574         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2575         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2576         (LayoutTestController::syncLocalStorage):
2577         (LayoutTestController::observeStorageTrackerNotifications):
2578         (LayoutTestController::deleteAllLocalStorage):
2579         (LayoutTestController::originsWithLocalStorage):
2580         (LayoutTestController::deleteLocalStorageForOrigin):
2581         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2582         (LayoutTestController::originsWithLocalStorage):
2583         (LayoutTestController::deleteAllLocalStorage):
2584         (LayoutTestController::deleteLocalStorageForOrigin):
2585         (LayoutTestController::observeStorageTrackerNotifications):
2586         (LayoutTestController::syncLocalStorage):
2587         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2588         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2589         (LayoutTestController::clearAllApplicationCaches):
2590         (LayoutTestController::syncLocalStorage):
2591         (LayoutTestController::observeStorageTrackerNotifications):
2592         (LayoutTestController::clearAllDatabases):
2593         (LayoutTestController::deleteAllLocalStorage):
2594         (LayoutTestController::originsWithLocalStorage):
2595         (LayoutTestController::deleteLocalStorageForOrigin):
2596         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2597         (LayoutTestController::syncLocalStorage):
2598         (LayoutTestController::observeStorageTrackerNotifications):
2599         (LayoutTestController::clearAllDatabases):
2600         (LayoutTestController::deleteAllLocalStorage):
2601         (LayoutTestController::originsWithLocalStorage):
2602         (LayoutTestController::deleteLocalStorageForOrigin):
2603
2604 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2605
2606         Reviewed by Adam Roben.
2607
2608         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2609         Process has finished launching.
2610         https://bugs.webkit.org/show_bug.cgi?id=56208
2611
2612         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2613         (TestWebKitAPI::TEST):
2614         Test that calling WKContextClearResourceCaches works with both options when called before
2615         the Web Process is valid.
2616
2617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2618         Add the new test.
2619         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2620         Ditto.
2621
2622 2011-03-11  Adam Roben  <aroben@apple.com>
2623
2624         Make it possible to view all leaks from a build at once in Leaks Viewer
2625
2626         You can now give Leaks Viewer the URL of a build results page (e.g.,
2627         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2628         will load all the leaks files from that build.
2629
2630         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2631         files from a particular build at once, rather than one at a time
2632
2633         Reviewed by David Kilzer.
2634
2635         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2636         (LeaksLoader): Initialize our properties.
2637         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2638         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2639         from that page.
2640         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2641         so it can provide feedback. Then load each one and pass it to the client.
2642         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2643         it into a DOM, pull out all the links to leaks files, and load each one.
2644
2645         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2646         (LeaksParser): Initialize our worker.
2647         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2648
2649         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2650         This code mostly came from Worker.js.
2651         (LeaksParserWorker): Initialize our profile.
2652         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2653         profile.
2654         (LeaksParserWorker.prototype._parseLeaks):
2655         (LeaksParserWorker.prototype._createNode):
2656         (LeaksParserWorker.prototype._incorporateLeaks):
2657         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2658         version of createProfile which adds to this.profile instead of making a new profile each
2659         time.
2660         (onmessage): Parse the file and send back the new profile.
2661
2662         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2663         (#loading-indicator):
2664         (#spinner):
2665         (#loading-indicator-label):
2666         Tweaked styles to accomodate a longer label.
2667
2668         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2669         (LeaksViewer.loaded): Set up a loader and parser.
2670
2671         (LeaksViewer.get filesLeftToParse):
2672         (LeaksViewer.set filesLeftToParse):
2673         Added these simple accessors.
2674
2675         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
2676         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
2677         the parser.
2678         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
2679         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
2680         _loadLeaksFromURL function).
2681         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
2682         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
2683         loading indicator, including the number of files being loaded.
2684         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
2685         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
2686         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
2687         _loadingIndicatorText.
2688
2689         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
2690         (getResource): Moved here from LeaksViewer.js.
2691
2692         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
2693         LeaksParserWorker.js.
2694
2695         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
2696         files, added a #loading-indicator-label element, and tweaked the prompt wording.
2697
2698 2011-03-11  Adam Roben  <aroben@apple.com>
2699
2700         Don't trigger a build when build.webkit.org's HTML files are modified
2701
2702         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
2703
2704         Reviewed by Dan Bernstein.
2705
2706         * Scripts/webkitpy/common/config/build.py:
2707         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
2708         directories that shouldn't trigger builds. Re-sorted the list.
2709
2710         * Scripts/webkitpy/common/config/build_unittest.py:
2711         (ShouldBuildTest): Added a test to cover the above change.
2712
2713 2011-03-11  Adam Roben  <aroben@apple.com>
2714
2715         Roll out r80848
2716
2717         It was accidentally committed.
2718
2719         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2720         (LeaksViewer._loadLeaksFromURL):
2721
2722 2011-03-11  Tony Chang  <tony@chromium.org>
2723
2724         Reviewed by Ojan Vafai.
2725
2726         kill hung lighttpd processes on the chromium win bot
2727         https://bugs.webkit.org/show_bug.cgi?id=56152
2728
2729         Sometimes this process doesn't exit and it holds on to
2730         a log file that we can't delete or copy, causing the tests
2731         to go red.
2732
2733         * BuildSlaveSupport/win/kill-old-processes:
2734
2735 2011-03-11  Ilya Sherman  <isherman@chromium.org>
2736
2737         Reviewed by Kent Tamura.
2738
2739         [Chromium] missing HTMLInputElement::setValueForUser() to tests
2740         https://bugs.webkit.org/show_bug.cgi?id=55854
2741
2742         * DumpRenderTree/chromium/LayoutTestController.cpp:
2743         (LayoutTestController::LayoutTestController):
2744         (LayoutTestController::setValueForUser): Added.
2745         * DumpRenderTree/chromium/LayoutTestController.h:
2746
2747 2011-03-10  Peter Kasting  <pkasting@google.com>
2748
2749         Reviewed by Dimitri Glazkov.
2750
2751         Clean up some gross code in TestShellWin.cpp.  No functional change.
2752         https://bugs.webkit.org/show_bug.cgi?id=56048
2753
2754         * DumpRenderTree/chromium/TestShellWin.cpp:
2755         (checkLayoutTestSystemDependencies):
2756
2757 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
2758
2759         Reviewed by Laszlo Gombos.
2760
2761         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
2762
2763         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2764         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
2765
2766 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2767
2768         Reviewed by Kenneth Rohde Christiansen.
2769
2770         [EFL] Make single backing store the default for EWebLauncher
2771         https://bugs.webkit.org/show_bug.cgi?id=55753
2772
2773         Set single backing store the default for EWebLauncher.
2774
2775         * EWebLauncher/main.c:
2776         (main):
2777
2778 2011-03-10  Adam Roben  <aroben@apple.com>
2779
2780         Ignore errors from files being held open when creating a test result archive
2781
2782         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
2783         fails to delete the results directory
2784
2785         Reviewed by Mark Rowe.
2786
2787         * BuildSlaveSupport/test-result-archive:
2788         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
2789         thrown when a process is holding a file open.
2790
2791 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2792
2793         Unreviewed, rolling out r80701.
2794         http://trac.webkit.org/changeset/80701
2795         https://bugs.webkit.org/show_bug.cgi?id=56126
2796
2797         fast/dom/Geolocation/window-close-crash.html fails on Snow
2798         Leopard release builds (Requested by mihaip on #webkit).
2799
2800         * DumpRenderTree/LayoutTestController.cpp:
2801         (LayoutTestController::staticFunctions):
2802         * DumpRenderTree/LayoutTestController.h:
2803         * DumpRenderTree/chromium/LayoutTestController.cpp:
2804         (LayoutTestController::LayoutTestController):
2805         * DumpRenderTree/chromium/LayoutTestController.h:
2806         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2807         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2808         * DumpRenderTree/mac/UIDelegate.h:
2809         * DumpRenderTree/mac/UIDelegate.mm:
2810         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2811         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2812         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2813         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2814
2815 2011-03-10  Philippe Normand  <pnormand@igalia.com>
2816
2817         Reviewed by Gustavo Noronha Silva.
2818
2819         [GTK] run-gtk-tests doesn't fail if a test crashes
2820         https://bugs.webkit.org/show_bug.cgi?id=56089
2821
2822         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
2823         even if a test crashes. So run the tests individually and if a
2824         test fails remember its exit code so run-gtk-test fails too, if
2825         required.
2826
2827 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2828
2829         Reviewed by Dmitry Titov.
2830
2831         Detach Geolocation from Frame when Page destroyed.
2832         https://bugs.webkit.org/show_bug.cgi?id=52877
2833
2834         Extend the layout test controller to expose the number of pending
2835         geolocation requests, so that we can test that the requests have
2836         been cancelled on page close.
2837
2838         * DumpRenderTree/LayoutTestController.cpp:
2839         (numberOfPendingGeolocationPermissionRequestsCallback):
2840         (LayoutTestController::staticFunctions):
2841         * DumpRenderTree/LayoutTestController.h:
2842         * DumpRenderTree/chromium/LayoutTestController.cpp:
2843         (LayoutTestController::LayoutTestController):
2844         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2845         * DumpRenderTree/chromium/LayoutTestController.h:
2846         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2847         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2848         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2849         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2850         * DumpRenderTree/mac/UIDelegate.h:
2851         * DumpRenderTree/mac/UIDelegate.mm:
2852         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2853         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2854         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2855         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2856         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2857         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2858         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2859         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2860
2861
2862 2011-03-09  Adam Roben  <aroben@apple.com>
2863
2864         Hide Leaks Viewer's URL prompt by default
2865
2866         We will show it as needed. I think I left it visible by default by accident after doing some
2867         testing.
2868
2869         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
2870         URL is passed as a query parameter, but does
2871
2872         Reviewed by Simon Fraser.
2873
2874         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2875
2876 2011-03-09  Adam Roben  <aroben@apple.com>
2877
2878         Don't use Element.classList or box-shadow in Leaks Viewer
2879
2880         They aren't supported by Safari 5. Luckily we have substitutes for them!
2881
2882         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
2883
2884         Reviewed by Simon Fraser.
2885
2886         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2887         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
2888
2889         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2890         (LeaksViewer.urlPromptButtonClicked):
2891         (LeaksViewer._displayURLPrompt):
2892         (LeaksViewer._setLoadingIndicatorHidden):
2893         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
2894
2895 2011-03-09  Adam Roben  <aroben@apple.com>
2896
2897         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
2898
2899         Rubber-stamped by David Kilzer.
2900
2901         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2902
2903 2011-03-09  Adam Roben  <aroben@apple.com>
2904
2905         Add a Leaks Viewer tool to build.webkit.org
2906
2907         This tool parses leaks from the files generated by the leaks bot and displays them in a
2908         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
2909         code).
2910
2911         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
2912         be passed to the tool via the "url" query parameter.
2913
2914         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
2915         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
2916         Inspector's Heavy profile view. But it's still pretty useful as-is.
2917
2918         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
2919
2920         Reviewed by Darin Adler.
2921
2922         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
2923         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
2924         (#url-prompt): This is the prompt itself.
2925
2926         (#loading-indicator):
2927         (#loading-indicator > img):
2928         These show a spinner in the bottom-right when we're loading a leaks file.
2929
2930         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
2931         as percentages.
2932
2933         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
2934         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
2935         URL if one wasn't given to us as a query parameter).
2936
2937         (LeaksViewer.get loading):
2938         (LeaksViewer.set loading):
2939         (LeaksViewer.get url):
2940         (LeaksViewer.set url):
2941         Pretty simple accessors.
2942
2943         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
2944         prompt.
2945         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
2946         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
2947         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
2948         the profile to the Web Inspector code once it's been created.
2949         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
2950         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
2951         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
2952         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
2953
2954         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
2955         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
2956         (ProfilerAgent.getProfile): Store the callback.
2957         (ProfilerAgent.profileReady): Call the callback.
2958         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
2959         count and total leak counts as real values, not percentages or milliseconds.
2960
2961         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
2962         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
2963         (parseLeaks): Extract call stacks out of a leaks file.
2964         (createNode): Helper function to create a new empty profile node.
2965         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
2966         WebInspector.ProfileView.
2967
2968         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
2969
2970 2011-03-09  Dan Bernstein  <mitz@apple.com>
2971
2972         Reviewed by Adam Roben.
2973
2974         Combine multiple --ignore-tests values
2975         https://bugs.webkit.org/show_bug.cgi?id=56016
2976
2977         * Scripts/old-run-webkit-tests:
2978
2979 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
2980
2981         Reviewed by David Levin.
2982
2983         Adding myself to the committer file.
2984
2985         * Scripts/webkitpy/common/config/committers.py:
2986
2987 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2988
2989         Rubber-stamped by Adam Roben.
2990
2991         Fix two leaks I introduced into the API tests.
2992
2993         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2994         (TestWebKitAPI::TEST):
2995
2996 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2997
2998         Reviewed by Anders Carlsson.
2999
3000         Crash in CFNetwork visiting google.com
3001         https://bugs.webkit.org/show_bug.cgi?id=55958
3002
3003         Add a test for not trying to copy a null CFURLResponse.
3004
3005         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
3006         (TestWebKitAPI::TEST):
3007         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3008
3009 2011-03-08  Hayato Ito  <hayato@chromium.org>
3010
3011         Reviewed by Ojan Vafai.
3012
3013         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
3014
3015         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
3016
3017         https://bugs.webkit.org/show_bug.cgi?id=55450
3018
3019         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3020
3021 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3022
3023         Reviewed by Martin Robinson.
3024
3025         [GTK] Add layoutTestController.setValueForUser() after r80412
3026         https://bugs.webkit.org/show_bug.cgi?id=55862
3027
3028         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3029         (LayoutTestController::setValueForUser): Implement setValueForUser()
3030
3031 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
3032
3033         Reviewed by Adam Barth.
3034
3035         Add script_shell_command to WebKitPort
3036         https://bugs.webkit.org/show_bug.cgi?id=55925
3037
3038         Add a central place where we generate the shell command from the script name.
3039         This function will be used later to detect the correct script interpreter on Win32.
3040
3041         * Scripts/webkitpy/common/config/ports.py:
3042         * Scripts/webkitpy/layout_tests/port/base.py:
3043         * Scripts/webkitpy/tool/steps/abstractstep.py:
3044         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3045
3046 2011-03-07  Ojan Vafai  <ojan@chromium.org>
3047
3048         Reviewed by Adam Barth.
3049
3050         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
3051         https://bugs.webkit.org/show_bug.cgi?id=55749
3052
3053         * Scripts/webkitpy/tool/commands/upload.py:
3054         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3055         * Scripts/webkitpy/tool/steps/__init__.py:
3056         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
3057         * Scripts/webkitpy/tool/steps/options.py:
3058
3059 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
3060
3061         Reviewed by David Levin.
3062
3063         Add support for DataTransferItems
3064         https://bugs.webkit.org/show_bug.cgi?id=55115
3065
3066         Enable data transfer items in DRT.
3067
3068         * DumpRenderTree/chromium/TestShell.cpp:
3069         (TestShell::TestShell):
3070
3071 2011-03-06  Ojan Vafai  <ojan@chromium.org>
3072
3073         Reviewed by Tony Chang.
3074
3075         [test dashboard] pull treemap files
3076         https://bugs.webkit.org/show_bug.cgi?id=55852
3077
3078         * TestResultServer/handlers/dashboardhandler.py:
3079
3080 2011-03-03  Hayato Ito  <hayato@chromium.org>
3081
3082         Reviewed by Mihai Parparita.
3083
3084         [NRWT] Clear output image file used by DumpRenderTree to make sure the
3085         previous image should not be used in the ChromiumDriver.
3086
3087         Also make sure that output image from the ChromiumDriver should be ''
3088         (empty string) if a test crashes for consistency with the WebKitDriver
3089         implementation.
3090
3091         https://bugs.webkit.org/show_bug.cgi?id=55746
3092
3093         * Scripts/webkitpy/layout_tests/port/chromium.py:
3094
3095 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
3096
3097         Reviewed by Martin Robinson.
3098
3099         [Gtk] fast/js/navigator-language.html fails locally
3100         https://bugs.webkit.org/show_bug.cgi?id=55880
3101
3102         Add LANG variable to the clean environment when running
3103         old-run-webkit-tests script.
3104
3105         * Scripts/old-run-webkit-tests:
3106
3107 2011-03-07  Tony Chang  <tony@chromium.org>
3108
3109         Reviewed by Mihai Parparita.
3110
3111         [Chromium] Find .checksum files without .pngs and vice-versa
3112         https://bugs.webkit.org/show_bug.cgi?id=55236
3113
3114         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
3115             mismatched results.
3116
3117 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
3118
3119         Reviewed by Beth Dakin.
3120
3121         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
3122         https://bugs.webkit.org/show_bug.cgi?id=55706
3123
3124         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
3125
3126         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3127         (AccessibilityController::focusedElement):
3128            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
3129            because it could change at any time.
3130         (AccessibilityController::rootElement):
3131
3132 2011-03-07  Sam Weinig  <sam@webkit.org>
3133
3134         Reviewed by Anders Carlsson.
3135
3136         Add unableToImplementPolicy callback for WebKit2 policy client
3137         <rdar://problem/9071902>
3138         https://bugs.webkit.org/show_bug.cgi?id=55884
3139
3140         * MiniBrowser/mac/BrowserWindowController.m:
3141         (-[BrowserWindowController awakeFromNib]):
3142         Update policy client initialization struct for new member.
3143
3144 2011-03-07  Sam Weinig  <sam@webkit.org>
3145
3146         Reviewed by Anders Carlsson.
3147
3148         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
3149         https://bugs.webkit.org/show_bug.cgi?id=55827
3150
3151         * MiniBrowser/mac/BrowserWindowController.m:
3152         (decidePolicyForResponse):
3153         (-[BrowserWindowController awakeFromNib]):
3154         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3155         (TestWebKitAPI::decidePolicyForResponse):
3156         (TestWebKitAPI::TEST):
3157         Update tools for new name.
3158
3159 2011-03-06  Daniel Bates  <dbates@rim.com>
3160
3161         Reviewed by Eric Seidel and David Kilzer.
3162
3163         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
3164         https://bugs.webkit.org/show_bug.cgi?id=55503
3165
3166         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
3167         in checkForJavaSDK().
3168
3169         Also, remove extraneous space in function prototype for unlinkZeroFiles.
3170
3171         * Scripts/build-webkit:
3172
3173 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
3174
3175         Reviewed by Sam Weinig.
3176
3177         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
3178
3179         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3180         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
3181             by willSendRequestForFrame. The API expects a retained reference to the URL request.
3182
3183 2011-03-05  Ilya Sherman  <isherman@chromium.org>
3184
3185         Reviewed by Darin Adler.
3186
3187         HTMLInputElement::setValue() should schedule change event when the element is focused
3188         In service of https://code.google.com/p/chromium/issues/detail?id=42716
3189         https://bugs.webkit.org/show_bug.cgi?id=53160
3190
3191         * DumpRenderTree/LayoutTestController.cpp:
3192         (setValueForUserCallback):
3193         (LayoutTestController::staticFunctions):
3194         * DumpRenderTree/LayoutTestController.h:
3195         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3196         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3197         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3198         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
3199         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3200         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3201         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3202         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3203         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3204         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3205
3206 2011-03-04  Mark Rowe  <mrowe@apple.com>
3207
3208         Reviewed by Alexey Proskuryakov.
3209
3210         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
3211
3212         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
3213         
3214         * DumpRenderTree/mac/CheckedMalloc.cpp:
3215         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
3216         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
3217         and then restore the initial protection flags when we're done.
3218
3219 2011-03-04  Evan Martin  <evan@chromium.org>
3220
3221         Reviewed by Tony Chang.
3222
3223         [gdb] pretty-print KURL in gdb
3224         https://bugs.webkit.org/show_bug.cgi?id=55788
3225
3226         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
3227         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
3228         pretty-printing.
3229
3230 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3231
3232         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
3233
3234         Reviewed by Darin Adler.
3235
3236         * TestWebKitAPI/JavaScriptTest.cpp:
3237         (TestWebKitAPI::javaScriptCallback):
3238         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3239         (TestWebKitAPI::didRunJavaScript):
3240         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3241         (TestWebKitAPI::nullJavaScriptCallback):
3242         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3243         (TestWebKitAPI::didRunJavaScript):
3244
3245 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3246
3247         Make run-api-tests show failed if a test fails.
3248
3249         https://webkit.org/b/55725
3250
3251         Reviewed by Sam Weinig.
3252
3253         * Scripts/run-api-tests:
3254         (runTest): Remove "my" from the nested $result assignment so the
3255         check outside the condition sees the real result.
3256
3257 2011-03-02  MORITA Hajime  <morrita@google.com>
3258
3259         Reviewed by Kent Tamura.
3260
3261         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
3262         https://bugs.webkit.org/show_bug.cgi?id=55434
3263
3264         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
3265         and passed the object webkit_support::PostDelayedTask directly.
3266
3267         Note that the change keeps postTask() as is because it has a
3268         semantics taht webkit_support::PostDelayedTask() has; It jumps to
3269         the main thread.
3270
3271         * DumpRenderTree/chromium/Task.cpp:
3272         (postDelayedTask):
3273         * DumpRenderTree/chromium/Task.h:
3274         (WebTask::Run):
3275
3276 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3277
3278         Reviewed by Kenneth Rohde Christiansen.
3279
3280         [QT] Implement mock client-based geolocation for layout testing
3281         https://bugs.webkit.org/show_bug.cgi?id=54334
3282
3283         Implement testing for Client-Based geolocation for QtWebkit.
3284
3285         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3286         (WebCore::DumpRenderTree::DumpRenderTree):
3287         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3288         (LayoutTestController::reset):
3289         (LayoutTestController::setGeolocationPermission):
3290         (LayoutTestController::setMockGeolocationError):
3291         (LayoutTestController::setMockGeolocationPosition):
3292
3293 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3294
3295         Unreviewed, rolling out r80237.
3296         http://trac.webkit.org/changeset/80237
3297         https://bugs.webkit.org/show_bug.cgi?id=55714
3298
3299         Windows bots aren't ready to be core (Requested by aroben on
3300         #webkit).
3301
3302         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3303         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3304
3305 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
3306
3307         Reviewed by Tony Chang.
3308
3309         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
3310         https://bugs.webkit.org/show_bug.cgi?id=55694
3311         
3312         Fixes for interruptions in NRWT:
3313         - Make TestRunInterruptedException be pickleable correctly (the base
3314           Exception class defines a __reduce__ that does not include the reason)
3315         - Fix ordering of returned arguments from TestRunner2._run_tests
3316           (interrupted and keyboard_interrupted were reversed)
3317         - Fix cancel_workers callsites (was using old name).
3318         - In handle_exception re-raise actual exception instance that was thrown
3319
3320         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3321         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3322         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3323         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3324
3325 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
3326
3327         Unreviewed.
3328
3329         Adding myself as a committer.
3330
3331         * Scripts/webkitpy/common/config/committers.py:
3332
3333 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
3334
3335         Reviewed by Mihai Parparita.
3336
3337         Teach sheriffbot to answer whois commands
3338         https://bugs.webkit.org/show_bug.cgi?id=55687
3339
3340         * Scripts/webkitpy/tool/bot/irc_command.py:
3341         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3342         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3343
3344 2011-03-03  Victoria Kirst  <vrk@google.com>
3345
3346         Reviewed by Eric Carlson.
3347
3348         Enable media tests in chromium-gpu/test_expectations
3349         https://bugs.webkit.org/show_bug.cgi?id=53608
3350
3351         Add media folder to the list of GPU test paths.
3352
3353         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3354
3355 2011-03-03  Adam Roben  <aroben@apple.com>
3356
3357         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
3358
3359         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
3360         incorrect parsing of absolute Windows-style file: URLs
3361
3362         Reviewed by Tim Hatcher.
3363
3364         * WebKitTestRunner/TestInvocation.cpp:
3365         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
3366         <http://webkit.org/b/55683>.
3367
3368 2011-03-03  Tony Chang  <tony@chromium.org>
3369
3370         Reviewed by Dimitri Glazkov.
3371
3372         [chromium] Run kill-old-processes on the chromium-win bot too
3373         https://bugs.webkit.org/show_bug.cgi?id=55630
3374
3375         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3376         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
3377
3378 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3379
3380         Reviewed by Martin Robinson.
3381
3382         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
3383         https://bugs.webkit.org/show_bug.cgi?id=53960
3384
3385         * DumpRenderTree/gtk/EventSender.cpp:
3386         (sendClick):
3387         (scheduleAsynchronousClickCallback):
3388
3389 2011-03-03  Adam Roben  <aroben@apple.com>
3390
3391         Look for Windows-style paths when checking whether a test is an Inspector test
3392
3393         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
3394         out or crash on Windows 7 Release (WebKit2 Tests)
3395
3396         Reviewed by Darin Adler.
3397
3398         * WebKitTestRunner/TestInvocation.cpp:
3399         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
3400         Windows.
3401
3402 2011-03-03  Adam Roben  <aroben@apple.com>
3403
3404         Make Windows 7 Release (Tests) a core builder
3405
3406         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
3407         give it a few more days of greenness first.
3408
3409         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
3410
3411         Reviewed by Andreas Kling.
3412
3413         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3414         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
3415
3416         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3417         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
3418         Updated the core regexps to match the buildbot module. Updated the expected results to match
3419         the current set of core builders.
3420
3421 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
3422
3423         Reviewed by Andreas Kling.
3424
3425         Adding myself as a reviewer.
3426
3427         * Scripts/webkitpy/common/config/committers.py:
3428
3429 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
3430
3431         Reviewed by Xan Lopez.
3432
3433         [GTK] Extended application cache database API and added unit tests file.
3434         https://bugs.webkit.org/show_bug.cgi?id=55335
3435
3436         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
3437         of webkit_application_cache_set_maximum_size due to API exposal.
3438
3439 2011-03-02  Ojan Vafai  <ojan@chromium.org>
3440
3441         Reviewed by Adam Barth.
3442
3443         make webkit-patch upload work for security bugs
3444         https://bugs.webkit.org/show_bug.cgi?id=55655
3445
3446         The problem is that we shell out to prepare-ChangeLog,
3447         which does not authenticate with bugzilla. All it needs from
3448         bugzilla is the bug title though. We just pass it through from
3449         webkit-patch instead.
3450
3451         * Scripts/prepare-ChangeLog:
3452         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3453         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3454
3455 2011-03-01  Ojan Vafai  <ojan@chromium.org>
3456
3457         Reviewed by Tony Chang.
3458
3459         [test-dashboard] make gtest JSON match layout-tests JSON
3460         https://bugs.webkit.org/show_bug.cgi?id=55556
3461
3462         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
3463         Make this code match.
3464
3465         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3466
3467 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
3468
3469         Reviewed by Tony Chang.
3470
3471         NRWT - implement Linux Hardy 64-bit port support. This involves
3472         adding support for non-'x86' architectures and updating the
3473         "deduplicate_tests" script to correctly understand that
3474         port.name() is not always equal to basename(port.baseline_path()).
3475
3476         This change introduces two new port names: 'chromium-linux-x86'
3477         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
3478         flag will cause the code to determine which one to use at
3479         runtime, just like we currently do with 'chromium-win'.
3480
3481         https://bugs.webkit.org/show_bug.cgi?id=55535
3482
3483         * Scripts/webkitpy/common/system/executive_mock.py:
3484           Handle 'return_stderr' keyword arg to run_command()
3485         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3486         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3487         * Scripts/webkitpy/layout_tests/port/base.py:
3488         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3489         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3490         * Scripts/webkitpy/layout_tests/port/factory.py:
3491         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3492
3493 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
3494
3495         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
3496         update symlinks accordingly.
3497
3498         * wx/packaging/build-mac-installer.py:
3499
3500 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3501
3502         Unreviewed, rolling out r80139.
3503         http://trac.webkit.org/changeset/80139
3504         https://bugs.webkit.org/show_bug.cgi?id=55620
3505
3506         failing and crashing tests on Snow Leopard bot (Requested by
3507         mihaip1 on #webkit).
3508
3509         * DumpRenderTree/LayoutTestController.cpp:
3510         (LayoutTestController::staticFunctions):
3511         * DumpRenderTree/LayoutTestController.h:
3512         * DumpRenderTree/chromium/LayoutTestController.cpp:
3513         (LayoutTestController::LayoutTestController):
3514         * DumpRenderTree/chromium/LayoutTestController.h:
3515         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3516         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3517         * DumpRenderTree/mac/UIDelegate.h:
3518         * DumpRenderTree/mac/UIDelegate.mm:
3519         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3520         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3521         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3522         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3523
3524 2011-03-02  Adam Roben  <aroben@apple.com>
3525
3526         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
3527
3528         This matches DumpRenderTree on Windows.
3529
3530         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
3531         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
3532         in WebKit2
3533
3534         Reviewed by Beth Dakin.
3535
3536         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3537         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
3538         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
3539
3540 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3541
3542         Reviewed by David Levin.
3543
3544         Add feature define for data transfer items
3545         https://bugs.webkit.org/show_bug.cgi?id=55510
3546
3547         * Scripts/build-webkit:
3548
3549 2011-03-02  Adam Roben  <aroben@apple.com>
3550
3551         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
3552
3553         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
3554         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
3555         the former location, but was getting lucky on some SnowLeopard machines because symlinks
3556         were being created there pointing into DiagnosticReports. For machines without these
3557         symlinks, crash logs were not getting captured.
3558
3559         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
3560         SnowLeopard machines
3561
3562         Reviewed by Eric Seidel.
3563
3564         * Scripts/old-run-webkit-tests:
3565         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
3566
3567 2011-03-02  Adam Roben  <aroben@apple.com>
3568
3569         Don't try to capture crash logs on platforms that haven't implemented that feature
3570
3571         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
3572         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
3573
3574         Reviewed by Joseph Pecoraro.
3575
3576         * Scripts/old-run-webkit-tests:
3577         (captureSavedCrashLog): Bail if we don't have a crash log glob.
3578         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
3579         strictly required to fix bug 55504, but seems worthwhile.
3580
3581 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3582
3583         Reviewed by Dmitry Titov.
3584
3585         Detach Geolocation from Frame when Page destroyed.
3586         https://bugs.webkit.org/show_bug.cgi?id=52877
3587
3588         Extend the layout test controller to expose the number of pending
3589         geolocation requests, so that we can test that the requests have
3590         been cancelled on page close.
3591
3592         * DumpRenderTree/LayoutTestController.cpp:
3593         (numberOfPendingGeolocationPermissionRequestsCallback):
3594         (LayoutTestController::staticFunctions):
3595         * DumpRenderTree/LayoutTestController.h:
3596         * DumpRenderTree/chromium/LayoutTestController.cpp:
3597         (LayoutTestController::LayoutTestController):
3598         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3599         * DumpRenderTree/chromium/LayoutTestController.h:
3600         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3601         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3602         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3603         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3604         * DumpRenderTree/mac/UIDelegate.h:
3605         * DumpRenderTree/mac/UIDelegate.mm:
3606         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3607         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3608         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3609         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3610         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3611         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3612         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3613         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3614
3615
3616 2011-03-01  Kent Tamura  <tkent@chromium.org>
3617
3618         Reviewed by Dimitri Glazkov.
3619
3620         Assertion fails when a form validation bubble appears
3621         https://bugs.webkit.org/show_bug.cgi?id=55550
3622
3623         Test: fast/forms/interactive-validation-attach-assertion.html
3624
3625         * DumpRenderTree/chromium/WebPreferences.cpp:
3626         (WebPreferences::applyTo): Enable the interactive validation feature by
3627           default. This matches to Chromium browser.
3628
3629 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3630
3631         Reviewed by Kent Tamura.
3632
3633         Remove efl port style exception of Webcore/JavaScriptCore
3634         https://bugs.webkit.org/show_bug.cgi?id=55549
3635
3636         WebCore and JavaScriptCore need to adhere WebKit coding style.
3637
3638         * Scripts/webkitpy/style/checker.py:
3639
3640 2011-03-01  Tony Chang  <tony@chromium.org>
3641</