Unreviewed follow-up to r216776.
[WebKit-https.git] / Tools / ChangeLog
1 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
2
3         Unreviewed follow-up to r216776.
4
5         * Scripts/webkitpy/port/base.py:
6         (Port.path_to_crash_logs): Raise not implemented.
7         * Scripts/webkitpy/port/test.py:
8         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
9         * Scripts/webkitpy/port/win.py:
10         (WinPort.path_to_crash_logs): Ditto.
11
12 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
13
14         Bot watcher's dashboard shows results links twice sometimes
15         https://bugs.webkit.org/show_bug.cgi?id=172043
16
17         Reviewed by Tim Horton.
18
19         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
20         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
21
22 2017-05-12  Brady Eidson  <beidson@apple.com>
23
24         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
25         https://bugs.webkit.org/show_bug.cgi?id=172030
26
27         Unreviewed - Test gardening, in effect...
28
29         This failure is only being seen by the bots.
30         
31         I believe this test is utterly broken in the first place; when it checks the .wal file's
32         size that is not actually an indicator that the records were deleted.
33         
34         But that isn't what's coming up as failure on the bots.
35         
36         This patch is an attempt to:
37         1 - More forcefully clear the Website data directory of leftovers before the test starts.
38         2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
39
40         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
41         (defaultWebsiteDataDirectory):
42         (defaultApplicationCacheDirectory):
43         (TEST):
44
45 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
46
47         webkitpy: Pass directory with crash logs into CrashLogs
48         https://bugs.webkit.org/show_bug.cgi?id=172033
49         <rdar://problem/32157616>
50
51         Reviewed by Daniel Bates.
52
53         Refactor CrashLogs and the callers of CrashLogs so that the port object owns
54         the location of crash logs.
55
56         * Scripts/webkitpy/common/system/crashlogs.py:
57         (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
58         (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
59         generating one.
60         (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
61         self._results_directory.
62         (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
63         generating one.
64         (CrashLogs._log_directory_darwin): Moved to port.
65         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
66         to the crash log is no longer owned by CrashLogs.
67         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
68         directory for uploading crash logs. Note that crash logs are only supported on Mac
69         and Windows.
70         * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
71         * Scripts/webkitpy/port/base.py:
72         (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
73         to be in the results directory.
74         * Scripts/webkitpy/port/darwin.py:
75         (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
76         (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
77         (DarwinPort._get_crash_log): Ditto.
78         * Scripts/webkitpy/port/darwin_testcase.py:
79         (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
80         the path to crash logs.
81         * Scripts/webkitpy/port/ios_device.py:
82         (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
83         * Scripts/webkitpy/port/ios_device_unittest.py:
84         (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
85         * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
86         * Scripts/webkitpy/port/mac.py: Ditto.
87         * Scripts/webkitpy/port/test.py:
88         (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
89         * Scripts/webkitpy/port/win.py:
90         (WinPort._get_crash_log): Ditto.
91         * Scripts/webkitpy/tool/commands/queries.py:
92         (execute): Construct a port object since this is the object which owns the path to crash logs.
93
94 2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
95
96         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
97
98         In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
99         URL parameter using the default value "about:blank" when not provided.
100
101         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
102         (testWebViewCreateNavigationData):
103
104 2017-05-11  Youenn Fablet  <youenn@apple.com>
105
106         Allow WPT server to serve specific WebKit test
107         https://bugs.webkit.org/show_bug.cgi?id=171479
108
109         Reviewed by Ryosuke Niwa.
110
111         Adding a new mount point to WPT server.
112         It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
113
114         Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
115
116         * Scripts/webkitpy/layout_tests/controllers/manager.py:
117         (Manager.__init__):
118         (Manager._is_http_test):
119         (Manager._needs_web_platform_test):
120         (Manager._run_tests):
121         (Manager._is_web_platform_test): Deleted.
122         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
123         (build_routes):
124         (main):
125         * Scripts/webkitpy/port/driver.py:
126         (Driver):
127         (Driver.is_webkit_specific_web_platform_test):
128         (Driver.test_to_uri):
129         (Driver._command_from_driver_input):
130
131 2017-05-11  Brady Eidson  <beidson@apple.com>
132
133         [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
134         <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
135
136         Reviewed by Andy Estes.
137         Informal review by Maureen Daum.
138
139         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
140         (TEST):
141
142 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
143
144         REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
145         https://bugs.webkit.org/show_bug.cgi?id=171989
146
147         Reviewed by Brian Burg.
148
149         * lldb/lldb_webkit.py:
150         (WTFStringImplProvider.get_data8):
151         (WTFStringImplProvider.get_data16):
152         m_data8 and m_data16 are now part of the superclass StringImplShape
153         instead of directly in StringImpl. So first get the shape by getting
154         index 0, and the data properties are the same offset within that.
155
156 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
157
158         Remove Vibration API
159         https://bugs.webkit.org/show_bug.cgi?id=171766
160
161         Rubber-stamped by Alexey Proskuryakov.
162
163         * Scripts/webkitperl/FeatureList.pm:
164
165 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
166
167         Add WPE release bots
168         https://bugs.webkit.org/show_bug.cgi?id=171973
169
170         Reviewed by Žan Doberšek.
171
172         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
173         It also adds a new WPE buildbot category.
174
175         * BuildSlaveSupport/build.webkit.org-config/config.json:
176         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
177         (InstallWpeDependencies):
178         (appendCustomBuildFlags):
179         (Factory.__init__):
180         (loadBuilderConfig):
181         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
182         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
183
184 2017-05-09  Sam Weinig  <sam@webkit.org>
185
186         Remove support for legacy Notifications
187         https://bugs.webkit.org/show_bug.cgi?id=171487
188
189         Reviewed by Jon Lee.
190
191         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
192         (DRTDesktopNotificationPresenter::checkNotificationPermission):
193         * Scripts/webkitperl/FeatureList.pm:
194         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
195         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
196
197 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
198
199         Remove user agent quirk for Slack
200         https://bugs.webkit.org/show_bug.cgi?id=171869
201
202         Reviewed by Carlos Garcia Campos.
203
204         Remove the corresponding test.
205
206         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
207         (TestWebKitAPI::TEST):
208
209 2017-05-10  Commit Queue  <commit-queue@webkit.org>
210
211         Unreviewed, rolling out r216578.
212         https://bugs.webkit.org/show_bug.cgi?id=171920
213
214         Broke the GTK+ build with Wayland enabled (Requested by KaL on
215         #webkit).
216
217         Reverted changeset:
218
219         "[GTK] Bump GTK+ and its dependencies in jhbuild"
220         https://bugs.webkit.org/show_bug.cgi?id=171918
221         http://trac.webkit.org/changeset/216578
222
223 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
224
225         [GTK] Bump GTK+ and its dependencies in jhbuild
226         https://bugs.webkit.org/show_bug.cgi?id=171918
227
228         Reviewed by Carlos Alberto Lopez Perez.
229
230         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
231         (WTR::initializeGtkSettings):
232         * gtk/jhbuild.modules:
233         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
234         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
235
236 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
237
238         [Win] Set CMake args in build-webkit
239         https://bugs.webkit.org/show_bug.cgi?id=171436
240
241         Reviewed by Per Arne Vollan.
242
243         * Scripts/build-webkit:
244
245 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
246
247         ImageDiff: Add CG implementation for new ImageDiff
248         https://bugs.webkit.org/show_bug.cgi?id=170608
249
250         Reviewed Alex Christensen.
251
252         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
253         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
254         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
255         * ImageDiff/CMakeLists.txt:
256         * ImageDiff/Cairo.cmake:
257         * ImageDiff/ImageDiff.cpp:
258         (main):
259         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
260         * ImageDiff/PlatformImage.cpp:
261         * ImageDiff/PlatformImage.h:
262         * ImageDiff/cairo/PlatformImageCairo.cpp:
263         * ImageDiff/cg/ImageDiff.cpp: Removed.
264         * ImageDiff/cg/PlatformImageCG.cpp: Added.
265         (ImageDiff::PlatformImage::createFromStdin):
266         (ImageDiff::PlatformImage::createFromDiffData):
267         (ImageDiff::PlatformImage::PlatformImage):
268         (ImageDiff::PlatformImage::~PlatformImage):
269         (ImageDiff::PlatformImage::width):
270         (ImageDiff::PlatformImage::height):
271         (ImageDiff::PlatformImage::rowBytes):
272         (ImageDiff::PlatformImage::hasAlpha):
273         (ImageDiff::PlatformImage::pixels):
274         (ImageDiff::PlatformImage::writeAsPNGToStdout):
275
276 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
277
278         Enable FTL JIT by default on AArch64
279         https://bugs.webkit.org/show_bug.cgi?id=144039
280
281         Reviewed by Yusuke Suzuki.
282
283         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
284         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
285         as an unsupported FTL platform.
286         * Scripts/webkitdirs.pm:
287         (isARM64): Returns 1 if the determined architecture is 'arm64'.
288         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
289
290 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
291
292         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
293         https://bugs.webkit.org/show_bug.cgi?id=170857
294         <rdar://problem/31635373>
295
296         Reviewed by Aakash Jain.
297
298         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
299         code to search for crash logs.
300
301         * Scripts/webkitpy/port/darwin.py:
302         (DarwinPort._get_crash_log): Moved from MacPort.
303         * Scripts/webkitpy/port/darwin_testcase.py:
304         (DarwinTest.test_get_crash_log): Moved from MacTest.
305         * Scripts/webkitpy/port/ios_device.py:
306         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
307         devices must search for crash-logs remotely.
308         * Scripts/webkitpy/port/ios_simulator.py:
309         (IOSSimulatorPort._get_crash_log): Deleted.
310         * Scripts/webkitpy/port/ios_simulator_unittest.py:
311         (IOSSimulatorTest.test_get_crash_log): Deleted.
312         * Scripts/webkitpy/port/mac.py:
313         (MacPort._get_crash_log): Moved to DarwinPort
314         * Scripts/webkitpy/port/mac_unittest.py:
315         (MacTest.test_get_crash_log): Moved to DarwinTest.
316
317 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
318
319         build ImageDiff with host SDK from Make
320         https://bugs.webkit.org/show_bug.cgi?id=171835
321
322         Reviewed by Alexey Proskuryakov.
323
324         ImageDiff should be built for the default SDK and default architecture when
325         the SDKROOT is set to either iOS device or iOS simulator. Check the
326         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
327
328         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
329         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
330
331 2017-05-09  Matt Lewis  <jlewis3@apple.com>
332
333         Unreviewed, adding myself to contributors.json
334
335         * Scripts/webkitpy/common/config/contributors.json:
336
337 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
338
339         REGRESSION: ImageDiff not building with make
340         https://bugs.webkit.org/show_bug.cgi?id=171788
341
342         Reviewed by Alex Christensen.
343
344         * Makefile: Build ImageDiff for all platforms.
345
346 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
347
348         [Win] ImageDiff isn't built since Bug 168945
349         https://bugs.webkit.org/show_bug.cgi?id=171847
350
351         Reviewed by Alex Christensen.
352
353         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
354         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
355         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
356
357 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
358
359         Upstream the WPE port
360         https://bugs.webkit.org/show_bug.cgi?id=171110
361
362         Reviewed by Alex Christensen.
363
364         webkit-dev thread:
365         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
366
367         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
368         In-file changes removed from this ChangeLog entry for brevity.
369
370         * BuildSlaveSupport/built-product-archive:
371         * BuildSlaveSupport/test-result-archive:
372         * CMakeLists.txt:
373         * ImageDiff/PlatformWPE.cmake: Added.
374         * Scripts/build-dumprendertree:
375         * Scripts/build-webkit:
376         * Scripts/build-webkittestrunner:
377         * Scripts/update-webkit-libs-jhbuild:
378         * Scripts/update-webkitwpe-libs: Added.
379         * Scripts/webkitdirs.pm:
380         * Scripts/webkitperl/FeatureList.pm:
381         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
382         * Scripts/webkitpy/port/factory.py:
383         * Scripts/webkitpy/port/wpe.py: Added.
384         * TestWebKitAPI/PlatformWPE.cmake: Added.
385         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
386         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
387         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
388         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
389         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
390         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
391         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
392         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
393         * WebKitTestRunner/InjectedBundle/TestRunner.h:
394         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
395         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
396         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
397         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
398         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
399         * WebKitTestRunner/PlatformWPE.cmake: Added.
400         * WebKitTestRunner/PlatformWebView.h:
401         * WebKitTestRunner/TestController.cpp:
402         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
403         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
404         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
405         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
406         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
407         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
408         * jhbuild/jhbuild-wrapper:
409         * wpe/generate-inspector-gresource-manifest.py: Added.
410         * wpe/jhbuild.modules: Added.
411         * wpe/jhbuildrc: Added.
412         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
413         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
414         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
415         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
416         * wpe/patches/glib-warning-fix.patch: Added.
417         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
418         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
419         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
420         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
421         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
422
423 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
424
425         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
426         https://bugs.webkit.org/show_bug.cgi?id=169421
427         <rdar://problem/30950171>
428
429         Reviewed by Tim Horton.
430
431         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
432         (createBitmapContextFromWebView): Implement for IOSurface.
433         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
434         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
435
436 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
437
438         buildbot: Cleanup simulators after running tests
439         https://bugs.webkit.org/show_bug.cgi?id=171679
440
441         Reviewed by Aakash Jain.
442
443         simctl is partitioned for each user. Since kill-old-processes
444         is run as root, we need to specify the buildbot user when tearing
445         down simulators between steps.
446
447         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
448         (KillOldProcesses): Pass buildbot user to kill-old-processes.
449         * BuildSlaveSupport/kill-old-processes:
450         (main): Specify the user for simctl if one has been provided.
451
452 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
453
454         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
455         https://bugs.webkit.org/show_bug.cgi?id=171681
456
457         Reviewed by Carlos Garcia Campos.
458
459         * gtk/install-dependencies:
460
461 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
462
463         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
464
465         Glib uses now Unicode quotes in error messages.
466
467         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
468         (testWebKitConsoleMessageNetworkError):
469
470 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
471
472         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
473
474         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
475         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
476         characters to the input. Also fix typo in the function name.
477
478         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
479         (testWebViewJavaScriptDialogs):
480
481 2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
482
483         [GTK] Cannot sign in with new Google sign-in page
484         https://bugs.webkit.org/show_bug.cgi?id=171770
485
486         Unreviewed. This just adds a test.
487
488         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
489         (TestWebKitAPI::TEST):
490
491 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
492
493         [iOS WK2] Make rotation tests more reliable
494         https://bugs.webkit.org/show_bug.cgi?id=171778
495
496         Reviewed by Tim Horton.
497
498         Switching between "safari-style" rotation and normal rotation left state on the WKWebView
499         that would cause later viewport-sensitive tests to fail. The WKWebView would be left
500         with override layout parameters, and an override orientation, and these caused viewport
501         size to leak into later tests, and WebCore orientation to not get reset correctly.
502
503         Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
504         an override orientation was set, and would never re-register, causing lost orientationchanged
505         events.
506
507         Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
508         from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.
509
510         Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
511         the WebProcess is caught up before proceeding with the test.
512
513         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
514         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
515         * WebKitTestRunner/ios/TestControllerIOS.mm:
516         (WTR::TestController::platformResetStateToConsistentValues):
517         (WTR::TestController::platformConfigureViewForTest):
518
519 2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>
520
521         [Mac][cmake] Buildfix after r216047
522         https://bugs.webkit.org/show_bug.cgi?id=171769
523
524         Unreviewed buildfix.
525
526         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
527
528 2017-05-05  Brady Eidson  <beidson@apple.com>
529
530         API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
531         <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513
532
533         Reviewed by Andy Estes.
534
535         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
536         (TEST):
537
538 2017-05-05  Brian Burg  <bburg@apple.com>
539
540         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
541         https://bugs.webkit.org/show_bug.cgi?id=171748
542         <rdar://problem/32027327>
543
544         Reviewed by Michael Catanzaro.
545
546         Remove temporary workaround now that the assertion failure is fixed.
547
548         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
549         (TEST):
550
551 2017-05-05  Simon Fraser  <simon.fraser@apple.com>
552
553         Make it possible to test rotation in iOS WebKitTestRunner
554         https://bugs.webkit.org/show_bug.cgi?id=171755
555
556         Reviewed by Tim Horton.
557
558         Add to UIScriptController:
559             void simulateRotation(DeviceOrientation orientation, object callback);
560             void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);
561
562         The former just does a view resize, as a simple WKWebView app would do. The second does
563         animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
564         layout size and interface orientation. The two behaviors produce different resize and
565         orientationchange events and sizes, and both need to be tested.
566
567         Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
568         which is now a custom subclass (PlatformWebViewController).
569
570         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
571         (WTR::UIScriptController::simulateRotation):
572         (WTR::UIScriptController::simulateRotationLikeSafari):
573         * DumpRenderTree/mac/UIScriptControllerMac.mm:
574         (WTR::UIScriptController::simulateRotation):
575         (WTR::UIScriptController::simulateRotationLikeSafari):
576         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
577         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
578         (WTR::toDeviceOrientation):
579         (WTR::UIScriptController::simulateRotation):
580         (WTR::UIScriptController::simulateRotationLikeSafari):
581         * TestRunnerShared/UIScriptContext/UIScriptController.h:
582         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
583         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
584         (-[TestRunnerWKWebView dealloc]):
585         (-[TestRunnerWKWebView _didEndRotation]):
586         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
587         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
588         (WTR::PlatformWebView::PlatformWebView):
589         * WebKitTestRunner/ios/TestControllerIOS.mm:
590         (WTR::TestController::platformResetStateToConsistentValues):
591         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
592         (WTR::toUIDeviceOrientation):
593         (WTR::UIScriptController::simulateRotation):
594         (WTR::UIScriptController::simulateRotationLikeSafari):
595         (WTR::UIScriptController::platformClearAllCallbacks):
596         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
597         (WTR::UIScriptController::simulateRotation):
598         (WTR::UIScriptController::simulateRotationLikeSafari):
599
600 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
601
602         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
603         https://bugs.webkit.org/show_bug.cgi?id=168945
604         <rdar://problem/30745695>
605
606         Reviewed by David Kilzer.
607
608         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
609         target SDK. These two changes must happen simultaneously because some archives will
610         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
611
612         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
613         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
614         tools directory still includes ImageDiff.
615         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
616         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
617         * Scripts/webkitpy/port/darwin.py: 
618         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
619         locally or when running archives.
620         * Scripts/webkitpy/port/image_diff.py:
621         (IOSSimulatorImageDiffer): Deleted.
622         * Scripts/webkitpy/port/ios_simulator.py:
623         (IOSSimulatorPort.diff_image): Deleted.
624
625 2017-05-05  Brian Burg  <bburg@apple.com>
626
627         API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
628         https://bugs.webkit.org/show_bug.cgi?id=171748
629
630         Unreviewed test gardening.
631
632         The assertion failure will be investigated separately in order to avoid rolling out
633         the fix for "secure" cookies. This assertion fails even without r216258 applied.
634
635         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
636         (TEST):
637
638 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
639
640         Unreviewed, rolling out r216260.
641
642         Breaks internal iOS testers
643
644         Reverted changeset:
645
646         "Use ImageDiff built by host SDK and remove ImageDiff from
647         DumpRenderTree"
648         https://bugs.webkit.org/show_bug.cgi?id=168945
649         http://trac.webkit.org/changeset/216260
650
651 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
652
653         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
654         https://bugs.webkit.org/show_bug.cgi?id=168945
655         <rdar://problem/30745695>
656
657         Reviewed by David Kilzer.
658
659         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
660         target SDK. These two changes must happen simultaneously because some archives will
661         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
662
663         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
664         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
665         tools directory still includes ImageDiff.
666         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
667         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
668         * Scripts/webkitpy/port/darwin.py: 
669         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
670         locally or when running archives.
671         * Scripts/webkitpy/port/image_diff.py:
672         (IOSSimulatorImageDiffer): Deleted.
673         * Scripts/webkitpy/port/ios_simulator.py:
674         (IOSSimulatorPort.diff_image): Deleted.
675
676 2017-05-05  Brian Burg  <bburg@apple.com>
677
678         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
679         https://bugs.webkit.org/show_bug.cgi?id=171700
680         <rdar://problem/32017975>
681
682         Reviewed by Brady Eidson.
683
684         Fix a mistake in the test that should have caught this bug.
685
686         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
687         (TEST):
688         The assertions that were meant to check round-tripping were actually checking
689         the properties of the original cookie objects, not the round-tripped ones.
690         This test now fails without the bugfix and passes when it is applied.
691
692 2017-05-05  Daniel Bates  <dabates@apple.com>
693
694         Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
695         https://bugs.webkit.org/show_bug.cgi?id=171698
696
697         Reviewed by Darin Adler.
698
699         We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
700         so that we get pretty diff output when the actual string differs from the expected
701         string as opposed to seeing a boolean result. The former makes makes it straightforward
702         to diagnose a regression without reading the code for the test or instrumenting it to
703         determine the actual string that was compared.
704
705         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
706         (TestWebKitAPI::TEST):
707         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
708         (TestWebKitAPI::TEST_F):
709         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
710         (TestWebKitAPI::TEST_F):
711
712 2017-05-05  Chris Dumez  <cdumez@apple.com>
713
714         Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
715         https://bugs.webkit.org/show_bug.cgi?id=171624
716
717         Reviewed by Dan Bernstein.
718
719         Extend API test coverage to cover crashes in addition to terminations requested by the client.
720
721         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
722         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
723         (TestWebKitAPI::webProcessWasTerminatedByClient):
724         (TestWebKitAPI::webProcessCrashed):
725         (TestWebKitAPI::TEST):
726
727 2017-05-04  Mark Lam  <mark.lam@apple.com>
728
729         DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
730         https://bugs.webkit.org/show_bug.cgi?id=171716
731         <rdar://problem/30878027>
732
733         Reviewed by Saam Barati.
734
735         setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
736         does JS conversion and therefore, potentially JS allocations) and accessing
737         methods of internal JS data structures (which may do JS invocation, etc).
738
739         * DumpRenderTree/TestRunner.cpp:
740         (setAudioResultCallback):
741
742 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
743
744         buildbot: Cleanup simulators after running tests
745         https://bugs.webkit.org/show_bug.cgi?id=171679
746         <rdar://problem/31994361>
747
748         Reviewed by Aakash Jain.
749
750         We shutdown the simulator process between tests, but in some cases, this is not
751         sufficient. Explicitly shutdown every booted simulator.
752
753         * BuildSlaveSupport/kill-old-processes:
754         (main): Shutdown all booted simulators.
755
756 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
757
758         [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
759         https://bugs.webkit.org/show_bug.cgi?id=171644
760
761         Reviewed by Michael Catanzaro.
762
763         Check that only one WebKitWebContext can have automation enabled.
764
765         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
766         (testAutomationSessionRequestSession):
767
768 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
769
770         [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
771         https://bugs.webkit.org/show_bug.cgi?id=171724
772
773         Reviewed by Michael Catanzaro.
774
775         It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
776
777         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
778         (WTR::timeoutSource):
779
780 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
781
782         Unreviewed. Fix wrong assert after r215176.
783
784         Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
785         could also be RGB24 when created from a web view snapshot.
786
787         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
788         (WTR::computeMD5HashStringForCairoSurface):
789
790 2017-05-04  Brian Burg  <bburg@apple.com>
791
792         lldb_webkit.py should provide a type summary for WebCore::URL
793         https://bugs.webkit.org/show_bug.cgi?id=171670
794
795         Reviewed by Jer Noble.
796
797         Just print out the underlying string using the WTFString provider.
798
799         * lldb/lldb_webkit.py:
800         (__lldb_init_module):
801         (WebCoreURL_SummaryProvider):
802         (WebCoreURLProvider):
803         (WebCoreURLProvider.__init__):
804         (WebCoreURLProvider.to_string):
805
806 2017-05-04  Commit Queue  <commit-queue@webkit.org>
807
808         Unreviewed, rolling out r216206.
809         https://bugs.webkit.org/show_bug.cgi?id=171714
810
811         Multiple LayoutTests crashing in Document::page() (Requested
812         by ap on #webkit).
813
814         Reverted changeset:
815
816         "Remove support for legacy Notifications"
817         https://bugs.webkit.org/show_bug.cgi?id=171487
818         http://trac.webkit.org/changeset/216206
819
820 2017-05-04  Mark Lam  <mark.lam@apple.com>
821
822         API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
823         https://bugs.webkit.org/show_bug.cgi?id=171702
824
825         Reviewed by Filip Pizlo.
826
827         The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
828         changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
829         confirm that the test will detect a regression.  Unfortunately, I forgot to
830         change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
831         This patch fixes that.
832
833         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
834         (TestWebKitAPI::neverDestroyedString):
835
836 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
837
838         Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
839         https://bugs.webkit.org/show_bug.cgi?id=170195
840
841         Unreviewed test gardening.
842
843         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
844         (TEST):
845
846 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
847
848         [Win] Remove redundant macros that are set in the CMake config
849         https://bugs.webkit.org/show_bug.cgi?id=171571
850
851         Reviewed by Brent Fulgham.
852
853         * DumpRenderTree/config.h:
854         * MiniBrowser/win/stdafx.h:
855         * TestWebKitAPI/config.h:
856
857 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
858
859         Add testRunner.display() to force displaying the web page for testing
860         https://bugs.webkit.org/show_bug.cgi?id=171694
861
862         Reviewed by Simon Fraser.
863
864         Unlike testRunner.displayAndTrackRepaints(), this new function forces 
865         drawing the web page but without track repaints.
866
867         * DumpRenderTree/TestRunner.cpp:
868         (displayCallback):
869         (TestRunner::staticFunctions):
870         * DumpRenderTree/TestRunner.h:
871         * DumpRenderTree/mac/TestRunnerMac.mm:
872         (TestRunner::display):
873         * DumpRenderTree/win/TestRunnerWin.cpp:
874         (TestRunner::display):
875         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
876         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
877         (WTR::TestRunner::display):
878         * WebKitTestRunner/InjectedBundle/TestRunner.h:
879
880 2017-05-04  Mark Lam  <mark.lam@apple.com>
881
882         NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
883         https://bugs.webkit.org/show_bug.cgi?id=171586
884         <rdar://problem/31873190>
885
886         Reviewed by Yusuke Suzuki.
887
888         API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.
889
890         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
891         (TestWebKitAPI::neverDestroyedString):
892         (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
893         (TestWebKitAPI::TEST):
894
895 2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
896
897         [WK2] Add support for keeping the selection in a focused editable element when dragging begins
898         https://bugs.webkit.org/show_bug.cgi?id=171585
899         <rdar://problem/31544320>
900
901         Reviewed by Beth Dakin and Zalan Bujtas.
902
903         Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
904         a drag while editing, content is still moved (and not copied) when performing data interaction on a different
905         element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
906         operation rather than a copy.
907
908         See WebCore ChangeLog for more details.
909
910         Tests:  DataInteractionSimulator.ContentEditableToContentEditable
911                 DataInteractionSimulator.ContentEditableToTextarea
912                 DataInteractionSimulator.ContentEditableMoveParagraphs
913                 DataInteractionSimulator.TextAreaToInput
914
915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
916         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
917         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
918         (TestWebKitAPI::TEST):
919         * TestWebKitAPI/ios/DataInteractionSimulator.h:
920         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
921         (-[DataInteractionSimulator initWithWebView:]):
922         (-[DataInteractionSimulator dealloc]):
923         (-[DataInteractionSimulator _advanceProgress]):
924         (-[DataInteractionSimulator waitForInputSession]):
925         (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
926         (-[DataInteractionSimulator _webView:didStartInputSession:]):
927
928 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
929
930         Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
931         https://bugs.webkit.org/show_bug.cgi?id=171641
932
933         Reviewed by Simon Fraser.
934
935         The plan is to add back the TestRunner.display() which does the display
936         only without track repaints.
937
938         * DumpRenderTree/DumpRenderTree.h:
939         * DumpRenderTree/TestRunner.cpp:
940         (displayAndTrackRepaintsCallback):
941         (TestRunner::staticFunctions):
942         (displayCallback): Deleted.
943         (displayInvalidatedRegionCallback): Deleted.
944         * DumpRenderTree/TestRunner.h:
945         * DumpRenderTree/mac/DumpRenderTree.mm:
946         (displayWebView):
947         (displayAndTrackRepaintsWebView):
948         * DumpRenderTree/mac/TestRunnerMac.mm:
949         (TestRunner::displayAndTrackRepaints):
950         (TestRunner::display): Deleted.
951         * DumpRenderTree/win/TestRunnerWin.cpp:
952         (TestRunner::displayAndTrackRepaints):
953         (TestRunner::display): Deleted.
954         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
955         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
956         (WTR::TestRunner::displayAndTrackRepaints):
957         (WTR::TestRunner::display): Deleted.
958         * WebKitTestRunner/InjectedBundle/TestRunner.h:
959
960 2017-05-04  Brady Eidson  <beidson@apple.com>
961
962         [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
963         https://bugs.webkit.org/show_bug.cgi?id=171513
964
965         Unreviewed gardening.
966
967         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
968         (TEST): Skip the failing parts of the test on iOS for now.
969
970 2017-05-03  Jonathan Bedard  <jbedard@apple.com>
971
972         Make ImageDiff stand-alone
973         https://bugs.webkit.org/show_bug.cgi?id=168939
974
975         Reviewed by David Kilzer.
976
977         Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
978         stand-alone project. Note that this change does not eliminate the ImageDiff inside
979         the DumpRenderTree project.
980
981         * ImageDiff/ImageDiff.xcodeproj: Added.
982         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
983         * ImageDiff/Makefile: Use ImageDiff project.
984         * ImageDiff/PlatformMac.cmake: Added.
985         * ImageDiff/PlatformWin.cmake: Added.
986         * ImageDiff/cg: Added.
987         * ImageDiff/cg/Configurations: Added.
988         * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
989         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
990         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
991         * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
992         (createImageFromStdin): Stop using RetainPtr.
993         (createDifferenceImage): Ditto.
994         (main): Ditto.
995         * Scripts/build-imagediff: Stop building WTF and bmalloc.
996
997 2017-05-04  Sam Weinig  <sam@webkit.org>
998
999         Remove support for legacy Notifications
1000         https://bugs.webkit.org/show_bug.cgi?id=171487
1001
1002         Reviewed by Jon Lee.
1003
1004         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1005         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1006         * Scripts/webkitperl/FeatureList.pm:
1007         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1008         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
1009
1010 2017-05-04  Andy Estes  <aestes@apple.com>
1011
1012         Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
1013         https://bugs.webkit.org/show_bug.cgi?id=171673
1014
1015         Reviewed by Dan Bernstein.
1016
1017         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
1018         (TEST):
1019         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
1020         (TEST):
1021         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1022         (TEST):
1023         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1024         (TEST):
1025         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
1026         (TEST):
1027         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1028         (configurationWithContentFilterSettings):
1029         (-[LazilyLoadPlatformFrameworksController init]):
1030         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1031         (TEST):
1032         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
1033         (runTestWithWidth):
1034         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
1035         (TEST):
1036         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1037         (TestWebKitAPI::TEST):
1038         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1039         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1040         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
1041         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
1042         +_test_configurationWithTestPlugInClassName:
1043
1044 2017-05-04  Eric Carlson  <eric.carlson@apple.com>
1045
1046         [MediaStream] Allow host application to enable/disable media capture
1047         https://bugs.webkit.org/show_bug.cgi?id=171292
1048         <rdar://problem/31821492>
1049
1050         Reviewed by Jer Noble.
1051
1052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1053         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1054         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1055         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1056         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1057         (MediaCaptureDisabledTest::SetUp):
1058         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1059         (TEST_F):
1060         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1061
1062 2017-05-04  Caio Lima  <ticaiolima@gmail.com>
1063
1064         Unreviewed, Adding self to contributors.json
1065
1066         * Scripts/webkitpy/common/config/contributors.json: Added name.
1067
1068 2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>
1069
1070         Fix compilation with ICU 59.1
1071         https://bugs.webkit.org/show_bug.cgi?id=171612
1072
1073         Reviewed by Mark Lam.
1074
1075         ICU 59.1 has broken source compatibility. Now it defines UChar as
1076         char16_t, which does not allow automatic type conversion from unsigned
1077         short in C++ code.
1078
1079         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1080         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
1081
1082 2017-05-04  Andy Estes  <aestes@apple.com>
1083
1084         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
1085         https://bugs.webkit.org/show_bug.cgi?id=171646
1086         <rdar://problem/30306321>
1087
1088         Reviewed by Tim Horton.
1089
1090         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
1091         (runTestWithWidth):
1092         (TEST):
1093         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
1094         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
1095         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1096         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
1097         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
1098         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
1099
1100 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
1101
1102         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
1103         https://bugs.webkit.org/show_bug.cgi?id=171649
1104
1105         Reviewed by Carlos Garcia Campos.
1106
1107         Add two patches picked from the upstream repository to fix building of
1108         the Fontconfig module in JHBuild. Additionally, this needed a patch to
1109         add "autogen.sh" as it is not included in release tarballs. Also:
1110         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
1111         being regenerated (which is needed) so this is disabled for the
1112         Fontconfig module.
1113
1114         * gtk/jhbuild.modules:
1115         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
1116         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
1117         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
1118
1119 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1120
1121         Unreviewed, rolling out r216172.
1122         https://bugs.webkit.org/show_bug.cgi?id=171654
1123
1124         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
1125         implementation. (Requested by ddkilzer on #webkit).
1126
1127         Reverted changeset:
1128
1129         "[MediaStream] Allow host application to enable/disable media
1130         capture"
1131         https://bugs.webkit.org/show_bug.cgi?id=171292
1132         http://trac.webkit.org/changeset/216172
1133
1134 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1135
1136         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
1137         https://bugs.webkit.org/show_bug.cgi?id=171595
1138
1139         Reviewed by Xabier Rodriguez-Calvar.
1140
1141         * gtk/jhbuild.modules:
1142         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1143         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1144         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
1145         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
1146         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1147         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1148         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1149
1150 2017-05-03  Saam Barati  <sbarati@apple.com>
1151
1152         How we build polymorphic cases is wrong when making a call from Wasm
1153         https://bugs.webkit.org/show_bug.cgi?id=171527
1154
1155         Reviewed by JF Bastien.
1156
1157         * Scripts/run-jsc-stress-tests:
1158
1159 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
1160
1161         [MediaStream] Allow host application to enable/disable media capture
1162         https://bugs.webkit.org/show_bug.cgi?id=171292
1163         <rdar://problem/31821492>
1164
1165         Reviewed by Jer Noble.
1166
1167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1168         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1169         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1170         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1171         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1172         (MediaCaptureDisabledTest::SetUp):
1173         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1174         (TEST_F):
1175         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1176
1177 2017-05-03  John Wilander  <wilander@apple.com>
1178
1179         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
1180         https://bugs.webkit.org/show_bug.cgi?id=171584
1181         <rdar://problem/24702576>
1182
1183         Reviewed by Brent Fulgham.
1184
1185         New function to call the clear function that takes a modifiedSince parameter.
1186
1187         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1188         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1189         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1190         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1191         * WebKitTestRunner/TestController.cpp:
1192         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1193         * WebKitTestRunner/TestController.h:
1194         * WebKitTestRunner/TestInvocation.cpp:
1195         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1196
1197 2017-05-03  Commit Queue  <commit-queue@webkit.org>
1198
1199         Unreviewed, rolling out r216160 and r216161.
1200         https://bugs.webkit.org/show_bug.cgi?id=171640
1201
1202         These changes broke the iOS build. (Requested by mlewis13 on
1203         #webkit).
1204
1205         Reverted changesets:
1206
1207         "[MediaStream] Allow host application to enable/disable media
1208         capture"
1209         https://bugs.webkit.org/show_bug.cgi?id=171292
1210         http://trac.webkit.org/changeset/216160
1211
1212         "[MediaStream] Allow host application to enable/disable media
1213         capture"
1214         https://bugs.webkit.org/show_bug.cgi?id=171292
1215         http://trac.webkit.org/changeset/216161
1216
1217 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
1218
1219         [MediaStream] Allow host application to enable/disable media capture
1220         https://bugs.webkit.org/show_bug.cgi?id=171292
1221         <rdar://problem/31821492>
1222
1223         Reviewed by Jer Noble.
1224
1225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1226         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1227         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1228         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1229         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1230         (MediaCaptureDisabledTest::SetUp):
1231         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1232         (TEST_F):
1233         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1234
1235 2017-04-26  Jiewen Tan  <jiewen_tan@apple.com>
1236
1237         [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys
1238         https://bugs.webkit.org/show_bug.cgi?id=171350
1239         <rdar://problem/28600836>
1240
1241         Patched by Brady Eidson.
1242
1243         Reviewed by Brent Fulgham.
1244
1245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1246         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Added.
1247         (TestWebKitAPI::runJavaScriptAlert):
1248         (TestWebKitAPI::decidePolicyForNavigationAction):
1249         (TestWebKitAPI::decidePolicyForNavigationResponse):
1250         (TestWebKitAPI::TEST):
1251         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Added.
1252
1253 2017-05-03  Simon Fraser  <simon.fraser@apple.com>
1254
1255         Have WKWebView call _updateVisibleContentRects for the current transaction if possible, rather than always delaying
1256         https://bugs.webkit.org/show_bug.cgi?id=171619
1257         https://bugs.webkit.org/show_bug.cgi?id=170195
1258
1259         Reviewed by Tim Horton.
1260
1261         Re-enable WebKit2.ResizeWithHiddenContentDoesNotHang.
1262
1263         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1264         (TEST):
1265
1266 2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1267
1268         YouTube user agent quirk breaks new YouTube
1269         https://bugs.webkit.org/show_bug.cgi?id=171603
1270
1271         Reviewed by Carlos Garcia Campos.
1272
1273         Remove the YouTube quirk test.
1274
1275         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1276         (TestWebKitAPI::TEST):
1277
1278 2017-05-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
1279
1280         Async image decoding should be disabled for snapshots, printing and preview
1281         https://bugs.webkit.org/show_bug.cgi?id=171467
1282
1283         Reviewed by Simon Fraser.
1284
1285         Add a API test for snapshotting with large images. Ensure the images are
1286         drawn correctly which implies they should have been synchronously decoded.
1287
1288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1289         * TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Added.
1290         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm:
1291         (TEST):
1292
1293 2017-05-03  Chris Dumez  <cdumez@apple.com>
1294
1295         [WK2] Extend processDidCrash delegate to let the client know the reason for the crash
1296         https://bugs.webkit.org/show_bug.cgi?id=171565
1297         <rdar://problem/31204417>
1298
1299         Reviewed by Sam Weinig.
1300
1301         Add API test coverage.
1302
1303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1304         * TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp: Added.
1305         (TestWebKitAPI::didFinishNavigation):
1306         (TestWebKitAPI::didCrashWithReason):
1307         (TestWebKitAPI::TEST):
1308
1309 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1310
1311         check-webkit-style should also keep js-test-post[-async].js in sync
1312         <https://webkit.org/b/171568>
1313
1314         Reviewed by Joseph Pecoraro.
1315
1316         * Scripts/webkitpy/style/checker.py:
1317         (_NEVER_SKIPPED_JS_FILES): Add new list that just contains
1318         JavaScript files not to be skipped.
1319         (_NEVER_SKIPPED_FILES): Update to use _NEVER_SKIPPED_JS_FILES.
1320         (CheckerDispatcher._create_checker): Update to use
1321         _NEVER_SKIPPED_JS_FILES.
1322
1323         * Scripts/webkitpy/style/checkers/jstest.py:
1324         (ALL_JS_TEST_FUNCTION_FILES): Rename from ALL_JS_TEST_FILES.
1325         This is the list of files containing functions that need to be
1326         kept in sync.
1327         (KEEP_JS_TEST_FILES_IN_SYNC): Change to list-of-lists format so
1328         we can keep more sets of files in sync between
1329         LayoutTests/resources and LayoutTests/http/tests/resources.
1330         (JSTestChecker.check): Update to use KEEP_JS_TEST_FILES_IN_SYNC
1331         as list of lists.  Update for ALL_JS_TEST_FUNCTION_FILES rename.
1332         (JSTestChecker.check_js_test_files): Add 'file_group' argument
1333         for list of files to check instead of using
1334         KEEP_JS_TEST_FILES_IN_SYNC.
1335         (JSTestChecker.check_js_test_functions): Update for
1336         ALL_JS_TEST_FUNCTION_FILES rename.
1337
1338         * Scripts/webkitpy/style/checkers/jstest_unittest.py:
1339         (JSTestCheckerTestCase):
1340         (JSTestCheckerTestCase.test_map_functions_to_dict):
1341         - Add test case for map_functions_to_dict() in jstest.py.
1342
1343 2017-05-02  Aakash Jain  <aakash_jain@apple.com>
1344
1345         ews should indicate in logs when it fails to fetch the attachment
1346         https://bugs.webkit.org/show_bug.cgi?id=171583
1347
1348         Reviewed by Alexey Proskuryakov.
1349
1350         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1351         (Bugzilla.fetch_attachment): Added log statement.
1352
1353 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1354
1355         Rolling out jstest_unittest.py so it can be reviewed
1356
1357         Follow-up fix for:
1358         check-webkit-style should keep JavaScript test functions in sync
1359         <https://webkit.org/b/171424>
1360
1361         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
1362
1363 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1364
1365         check-webkit-style should keep JavaScript test functions in sync
1366         <https://webkit.org/b/171424>
1367
1368         Reviewed by Joseph Pecoraro.
1369
1370         Add a new JSTestChecker for check-webkit-style that keeps these
1371         two files in sync:
1372
1373             LayoutTests/http/tests/resources/js-test-pre.js
1374             LayoutTests/resources/js-test-pre.js
1375
1376         And keeps implementations of shouldBe(), shouldNotBe(),
1377         shouldNotThrow(), and shouldThrow() in sync across multiple
1378         files (with the ability to add more functions later):
1379
1380             JSTests/stress/resources/standalone-pre.js
1381             LayoutTests/http/tests/resources/js-test-pre.js
1382             LayoutTests/resources/js-test-pre.js
1383             LayoutTests/resources/js-test.js
1384             LayoutTests/resources/standalone-pre.js
1385
1386         * Scripts/webkitpy/style/checker.py: Remove unused import.  Add
1387         import for JSTestChecker.
1388         (_NEVER_SKIPPED_FILES): Add array of file names that are never
1389         skipped regardless of other rules.
1390         (_all_categories): Add JSTestChecker categories.
1391         (CheckerDispatcher.should_skip_without_warning): Use
1392         _NEVER_SKIPPED_FILES.
1393         (CheckerDispatcher._create_checker): Return JSTestChecker for
1394         the files to check.
1395
1396         * Scripts/webkitpy/style/checkers/jstest.py: Add.
1397         (map_functions_to_dict): Parse JavaScript source by splitting on
1398         /^function\s+/ regex.  This is good enough for the sanity checks
1399         to keep function implementations in sync.
1400         (strip_blank_lines_and_comments): Strips blank lines and lines
1401         with comments from the end of a chunk of text representing a
1402         function.
1403         (JSTestChecker): New checker.
1404         (JSTestChecker.__init__):
1405         (JSTestChecker.check):
1406         (JSTestChecker.check_js_test_files): Keeps whole files in sync.
1407         (JSTestChecker.check_js_test_functions): Keeps individual
1408         functions in sync.
1409
1410         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Add test
1411         case.
1412         (JSTestTestCase):
1413         (JSTestTestCase.test_map_functions_to_dict):
1414
1415 2017-05-02  Joanmarie Diggs  <jdiggs@igalia.com>
1416
1417         AX: Update implementation of aria-orientation
1418         https://bugs.webkit.org/show_bug.cgi?id=171166
1419
1420         Reviewed by Chris Fleizach.
1421
1422         Return "AXUnknownOrientation" when ATK_STATE_VERTICAL and ATK_STATE_HORIZONTAL
1423         are both absent from the state set. Before we were returning an empty string
1424         which was not consistent with what the Mac port does, thus making shared tests
1425         harder.
1426
1427         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1428         (WTR::AccessibilityUIElement::orientation):
1429
1430 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1431
1432         Stop using sprintf() in JavaScriptCore debugger
1433         <https://webkit.org/b/171512>
1434
1435         Reviewed by Keith Miller.
1436
1437         * Scripts/webkitpy/style/checker.py:
1438         (_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
1439         Source/JavaScriptCore/disassembler/udis86/ is generated code.
1440
1441 2017-05-01  Timothy Horton  <timothy_horton@apple.com>
1442
1443         Expose viewport-fit instead of clip-to-safe-area
1444         https://bugs.webkit.org/show_bug.cgi?id=171503
1445         <rdar://problem/31918249>
1446
1447         Reviewed by Simon Fraser.
1448
1449         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1450         (WTR::UIScriptController::setSafeAreaInsets):
1451         (WTR::UIScriptController::setObscuredInsets): Deleted.
1452         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1453         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1454         (WTR::UIScriptController::setSafeAreaInsets):
1455         (WTR::UIScriptController::setObscuredInsets): Deleted.
1456         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1457         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1458         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1459         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]):
1460         (-[TestRunnerWKWebView _safeAreaInsetsForFrame:inSuperview:]):
1461         * WebKitTestRunner/ios/TestControllerIOS.mm:
1462         (WTR::TestController::platformResetStateToConsistentValues):
1463         * WebKitTestRunner/ios/UIKitSPI.h:
1464         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1465         (WTR::UIScriptController::setSafeAreaInsets):
1466         (WTR::UIScriptController::setObscuredInsets): Deleted.
1467         Expose a safe area inset setter instead of obscured insets.
1468
1469 2017-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1470
1471         Unreviewed, fix the build on a new internal SDK
1472
1473         Replace usages of NSItemProviderRepresentationVisibilityAll with
1474         UIItemProviderRepresentationOptionsVisibilityAll.
1475
1476         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1477         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
1478         (TestWebKitAPI::TEST):
1479
1480 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1481
1482         [Cocoa] Replace uses of [get…Class() alloc] in TestWebKitAPI
1483         <https://webkit.org/b/171493>
1484
1485         Reviewed by Dan Bernstein.
1486
1487         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1488         Remove UIKit soft-link since TestWebKitAPI links to
1489         UIKit.framework.
1490         (TestWebKitAPI::WebKit1_AudioSessionCategoryIOS_Test): Use
1491         UIWindow and UIWebView classes directly.
1492         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1493         Remove UIKit soft-link since TestWebKitAPI links to
1494         UIKit.framework.
1495         (RequiresUserActionForPlaybackTest::createWebView): Use UIWindow
1496         class directly.
1497
1498 2017-05-01  Brady Eidson  <beidson@apple.com>
1499
1500         Update names in WKURLSchemeHandler/WKURLSchemeHandlerTask APIs.
1501         <rdar://problem/31824838> and https://bugs.webkit.org/show_bug.cgi?id=171508
1502
1503         Reviewed by Andy Estes.
1504
1505         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1506         (-[SchemeHandler webView:startURLSchemeTask:]):
1507         (-[SchemeHandler webView:stopURLSchemeTask:]):
1508         (-[SchemeHandler webView:startTask:]): Deleted.
1509         (-[SchemeHandler webView:stopTask:]): Deleted.
1510
1511 2017-05-01  Jason Marcell  <jmarcell@apple.com>
1512
1513         Add a new function for getting the Git hash for a pure git directory.
1514         https://bugs.webkit.org/show_bug.cgi?id=171450
1515
1516         Reviewed by David Kilzer.
1517
1518         * Scripts/VCSUtils.pm:
1519         (gitHashForDirectory):
1520
1521 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
1522
1523         [ATK] Expose values of aria-rowcount, aria-colcount, aria-rowindex, aria-colindex, aria-rowspan, and aria-colspan as object attributes
1524         https://bugs.webkit.org/show_bug.cgi?id=171496
1525
1526         Reviewed by Chris Fleizach.
1527
1528         Add new attribute names so that the values of the object attributes can be tested.
1529
1530         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1531         (WTR::AccessibilityUIElement::numberAttributeValue):
1532
1533 2017-05-01  Beth Dakin  <bdakin@apple.com>
1534
1535         On-screen panel for candidate bar is in the wrong place when the caret is at the 
1536         start of a paragraph
1537         https://bugs.webkit.org/show_bug.cgi?id=171453
1538         -and corresponding-
1539         rdar://problem/29779764
1540
1541         Reviewed by Tim Horton.
1542
1543         This test hard-codes the y-coordinate for the expected candidateRect. 
1544         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1545         (TEST):
1546
1547 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1548
1549         check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
1550         <https://webkit.org/b/171494>
1551
1552         Reviewed by Brent Fulgham.
1553
1554         * Scripts/webkitpy/style/checkers/cpp.py:
1555         (check_language): Change categories for certain checkers from
1556         'runtime/printf' to 'security/printf' so they are no longer
1557         filtered.
1558         (CppChecker.categories): Add 'security/printf'.
1559         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1560         (CppStyleTest.test_insecure_string_operations): Add new test for
1561         sprintf(), strcat() and strcpy().
1562         (CppStyleTest.test_format_strings): Update test results for new
1563         'security/printf' category use.
1564
1565 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
1566
1567         AX: [GTK] Add support to query for aria-current
1568         https://bugs.webkit.org/show_bug.cgi?id=149016
1569
1570         Reviewed by Chris Fleizach.
1571
1572         Implement support for "AXARIACurrent" string attribute value.
1573
1574         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1575
1576 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1577
1578         REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker
1579
1580         Unreviewed.
1581
1582         Follow-up fix for:
1583         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
1584         https://bugs.webkit.org/show_bug.cgi?id=171486
1585
1586         * Scripts/webkitpy/style/checkers/cpp.py:
1587         (check_soft_link_class_alloc): Use (\w+) instead of ([^\s]+) to
1588         match and capture the function name.  The latter also mistakenly
1589         matches C-preprocessor directives.
1590         (CppChecker.categories): Add 'runtime/soft-linked-alloc', which
1591         is a requirement for the CppChecker class.
1592
1593 2017-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1594
1595         [GTK] Add automation session API
1596         https://bugs.webkit.org/show_bug.cgi?id=171428
1597
1598         Reviewed by Carlos Alberto Lopez Perez.
1599
1600         Add an automation mode to MiniBrowser using the new API and add a unit test too.
1601
1602         * MiniBrowser/gtk/BrowserWindow.c:
1603         (webViewTitleChanged):
1604         (webViewDecidePolicy):
1605         (newTabCallback):
1606         (openPrivateWindow):
1607         (browserWindowFinalize):
1608         (browser_window_init):
1609         (browser_window_get_or_create_web_view_for_automation):
1610         * MiniBrowser/gtk/BrowserWindow.h:
1611         * MiniBrowser/gtk/main.c:
1612         (createBrowserTab):
1613         (createWebViewForAutomationCallback):
1614         (automationStartedCallback):
1615         (main):
1616         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1617         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp: Added.
1618         (testAutomationSessionRequestSession):
1619         (beforeAll):
1620         (afterAll):
1621
1622 2017-04-30  Dan Bernstein  <mitz@apple.com>
1623
1624         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
1625         https://bugs.webkit.org/show_bug.cgi?id=171486
1626
1627         Reviewed by Sam Weinig.
1628
1629         * Scripts/webkitpy/style/checkers/cpp.py:
1630         (check_soft_link_class_alloc): Added. Looks for [get…Class() alloc] and suggests
1631           alloc…Instance() instead.
1632         (check_style): Invoke new check.
1633
1634 2017-04-30  Brady Eidson  <beidson@apple.com>
1635
1636         More fixing after r215991
1637         https://bugs.webkit.org/show_bug.cgi?id=171483
1638
1639         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1640         (TEST):
1641
1642 2017-04-30  Brady Eidson  <beidson@apple.com>
1643
1644         Updates to _WKWebsiteDataStoreConfiguration cookie storage location SPI.
1645         <rdar://problem/31906397> and https://bugs.webkit.org/show_bug.cgi?id=171483
1646
1647         Reviewed by Geoff Garen (and kind of Andy Estes).
1648
1649         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1650         (TEST):
1651
1652 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
1653
1654         [ATK] Implement support for aria-autocomplete
1655         https://bugs.webkit.org/show_bug.cgi?id=171167
1656
1657         Reviewed by Chris Fleizach.
1658
1659         Add "AXSupportsAutoCompletion" attribute so the presence of
1660         ATK_STATE_SUPPORTS_AUTOCOMPLETION can be tested.
1661
1662         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1663         (WTR::AccessibilityUIElement::boolAttributeValue):
1664
1665 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
1666
1667         [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE
1668         https://bugs.webkit.org/show_bug.cgi?id=171170
1669
1670         Reviewed by Chris Fleizach.
1671
1672         Add "AXInterfaceTable" attribute to test which elements implement AtkTable.
1673
1674         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1675         (WTR::AccessibilityUIElement::boolAttributeValue):
1676
1677 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
1678
1679         [ATK] Emit object:state-changed:busy event when aria-busy value changes
1680         https://bugs.webkit.org/show_bug.cgi?id=171181
1681
1682         Reviewed by Chris Fleizach.
1683
1684         Add handler for AXElementBusyChanged notifications.
1685
1686         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1687
1688 2017-04-29  Aakash Jain  <aakash_jain@apple.com>
1689
1690         Use PEP8 style guide for raising exceptions in webkitpy.
1691         https://bugs.webkit.org/show_bug.cgi?id=171439
1692
1693         Reviewed by Daniel Bates.
1694
1695         As per https://www.python.org/dev/peps/pep-0008/
1696         "When raising an exception in Python 2, use raise ValueError('message') 
1697         instead of the older form raise ValueError, 'message'"
1698
1699         * Scripts/webkitpy/common/net/irc/ircbot.py: Using new style for raising exceptions.
1700         * Scripts/webkitpy/common/thread/messagepump.py: Same.
1701         * Scripts/webkitpy/tool/bot/queueengine.py: Same.
1702         * Scripts/webkitpy/tool/commands/queues.py: Same.
1703         * Scripts/webkitpy/tool/commands/stepsequence.py: Same.
1704         * Scripts/webkitpy/tool/multicommandtool.py: Same.
1705         * Scripts/webkitpy/tool/steps/abstractstep.py: Same.
1706
1707 2017-04-28  Simon Fraser  <simon.fraser@apple.com>
1708
1709         Add system trace points for Document::updateTouchEventRegions()
1710         https://bugs.webkit.org/show_bug.cgi?id=171470
1711         rdar://problem/31901239
1712
1713         Reviewed by Tim Horton.
1714
1715         Add trace markers for updateTouchEventRegions.
1716
1717         * Tracing/SystemTracePoints.plist:
1718
1719 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
1720
1721         webkitpy: Add apple_additions to webkitpy to insert Internal tools
1722         https://bugs.webkit.org/show_bug.cgi?id=170461
1723         <rdar://problem/31433077>
1724
1725         Reviewed by Daniel Bates.
1726
1727         Allow a package to be pulled in by run-webkit-tests which provides an interface to
1728         run layout tests on an iOS device.  If this package is not available, throw an
1729         exception when attempting to run layout tests on an iOS device.
1730
1731         * Scripts/webkitpy/port/config.py:
1732         (apple_additions): Import apple_additions package.
1733         * Scripts/webkitpy/port/device.py:
1734         (Device.install_dylibs): Pass a directory with all the frameworks and dylibs to be
1735         installed on a device.
1736         (Device.prepare_for_testing): Pass a list of ports to forward from the device to the
1737         host, the bundle id of the app to be used for testing and a path to the layout test
1738         directory to be mounted on the device.
1739         (Device.finished_testing):
1740         * Scripts/webkitpy/port/factory.py:
1741         (platform_options): Add apple_additions platform options if apple_additions exists.
1742         * Scripts/webkitpy/port/ios.py:
1743         (IOSPort.setup_test_run): Install dylibs and frameworks on the device, pass ports
1744         to forward, the bundle ID of the testing app and the layout tests directory to
1745         each device.
1746         * Scripts/webkitpy/port/ios_device.py:
1747         (IOSDevicePort):
1748         (IOSDevicePort.default_child_processes): Query apple_additions for the number of child
1749         processes to be run.
1750         (IOSDevicePort.using_multiple_devices): Always assume multiple devices are used. When
1751         a single device is used, it is still accessed through an array.
1752         (IOSDevicePort._device_for_worker_number_map): Query apple_additions for the device
1753         for worker number map.
1754         (IOSDevicePort._driver_class): Query apple_additions for the test driver.
1755         (IOSDevicePort.determine_full_port_name): Use class variable over hard-coded string.
1756         (IOSDevicePort.check_for_leaks): No implementation for iOSDevicePort.
1757         (IOSDevicePort.look_for_new_crash_logs): Ditto.
1758         (IOSDevicePort.look_for_new_samples): Ditto.
1759         (IOSDevicePort.sample_process): Ditto.
1760         (IOSDevicePort._build_driver_flags): Use class variable over hard-coded string.
1761         (IOSDevicePort._create_devices): Check that devices are available for testing and check
1762         that we have enough devices for each child process.
1763         (IOSDevicePort.clean_up_test_run): Have apple_additions preform any needed clean up.
1764         * Scripts/webkitpy/port/ios_device_unittest.py:
1765         (IOSDeviceTest.test_operating_system):
1766         (IOSDeviceTest.test_spindump): Override method from DarwinTest.
1767         (IOSDeviceTest.test_sample_process): Ditto.
1768         (IOSDeviceTest.test_sample_process_exception): Ditto.
1769
1770 2017-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1771
1772         Fix and re-enable data interaction unit tests
1773         https://bugs.webkit.org/show_bug.cgi?id=171446
1774         <rdar://problem/31820646>
1775
1776         Reviewed by Tim Horton.
1777
1778         Enables all DataInteractionTests, and adjusts file upload tests to no longer write to a temporary file before
1779         registering with the UIItemProvider, and instead just register data directly via
1780         -registerDataRepresentationForTypeIdentifier:visibility:loadHandler:.
1781
1782         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1783         (TestWebKitAPI::TEST):
1784         (temporaryURLForDataInteractionFileLoad): Deleted.
1785         (cleanUpDataInteractionTemporaryPath): Deleted.
1786         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]): Deleted.
1787         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1788         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1789
1790 2017-04-28  Brady Eidson  <beidson@apple.com>
1791
1792         Teach the DatabaseProcess to be fully SessionID aware
1793         https://bugs.webkit.org/show_bug.cgi?id=171451
1794
1795         Reviewed by Geoffrey Garen.
1796
1797         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1798
1799 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
1800
1801         Unreviewed follow-up to r214705.
1802
1803         shut.copytree will fail if given a file as an argument instead of a directory.
1804
1805         * Scripts/webkitpy/common/system/filesystem.py:
1806         (FileSystem.copy_to_base_host): Use copytree when source is a directory and copyfile
1807         when source is a file.
1808         (FileSystem.copy_from_base_host): Ditto.
1809
1810 2017-04-28  Chris Dumez  <cdumez@apple.com>
1811
1812         Update DOMTokenList.replace() to match the latest DOM specification
1813         https://bugs.webkit.org/show_bug.cgi?id=171388
1814
1815         Reviewed by Alex Christensen.
1816
1817         Add API test coverage for new Vector API.
1818
1819         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1820         (TestWebKitAPI::TEST):
1821
1822 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
1823
1824         WebKitTestRunner/DumpRenderTree prevent device from sleeping
1825         https://bugs.webkit.org/show_bug.cgi?id=170731
1826
1827         Reviewed by Alex Christensen.
1828
1829         While running layout tests on a device, the device should not be put asleep.
1830
1831         * DumpRenderTree/mac/DumpRenderTree.mm:
1832         (dumpRenderTree): Disable idle timer.
1833         * WebKitTestRunner/ios/TestControllerIOS.mm:
1834         (WTR::TestController::platformInitialize): Ditto.
1835
1836 2017-04-28  Brady Eidson  <beidson@apple.com>
1837
1838         Start of support for multiple WebsiteDataStore/SessionIDs per process
1839         https://bugs.webkit.org/show_bug.cgi?id=171422
1840
1841         Reviewed by Geoffrey Garen.
1842
1843         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1844         (TEST):
1845
1846 2017-04-28  Youenn Fablet  <youenn@apple.com>
1847
1848         Adding a runtime flag specific to MediaDevices
1849         https://bugs.webkit.org/show_bug.cgi?id=171433
1850
1851         Reviewed by Geoffrey Garen.
1852
1853         Updating WTR and DRT as peer connection and media stream runtime flags are enabled by default.
1854         Setting media devices runtime flag to true for WTR and DRT.
1855
1856         * DumpRenderTree/mac/DumpRenderTree.mm:
1857         (enableExperimentalFeatures):
1858         (resetWebPreferencesToConsistentValues):
1859         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
1860         (TestWebKitAPI::TEST):
1861         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1862         (TestWebKitAPI::TEST):
1863         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1864         (WTR::InjectedBundle::beginTesting):
1865         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1866         (WTR::TestRunner::setMediaDevicesEnabled):
1867         (WTR::TestRunner::setMediaStreamEnabled): Deleted.
1868         (WTR::TestRunner::setPeerConnectionEnabled): Deleted.
1869         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1870         * WebKitTestRunner/TestController.cpp:
1871         (WTR::TestController::resetPreferencesToConsistentValues):
1872
1873 2017-04-28  Dean Jackson  <dino@apple.com>
1874
1875         [WebGPU] Label MTLCommandQueues with a prefix for internal telemetry
1876         https://bugs.webkit.org/show_bug.cgi?id=171441
1877         <rdar://problem/31826915>
1878
1879         Reviewed by Tim Horton.
1880
1881         Add an API test for GPUCommandQueue, exercising creation
1882         and setting the label.
1883
1884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1885         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Added.
1886         (TestWebKitAPI::TEST_F):
1887
1888 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1889
1890         [ATK] aria-modal="true" should be exposed via ATK_STATE_MODAL
1891         https://bugs.webkit.org/show_bug.cgi?id=171188
1892
1893         Reviewed by Chris Fleizach.
1894
1895         Add "AXModal" attribute string so that we can test the state's exposure.
1896
1897         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1898         (WTR::AccessibilityUIElement::boolAttributeValue):
1899
1900 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1901
1902         [ATK] GridCellRole should implement AtkTableCell (regression?)
1903         https://bugs.webkit.org/show_bug.cgi?id=171179
1904
1905         Reviewed by Chris Fleizach.
1906
1907         Add new "AXInterfaceTableCell" attribute so that we can test whether or
1908         not there is an implementation of AtkTableCell (i.e. without risking false
1909         negatives from bugs in the interface's implementation).
1910
1911         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1912         (WTR::AccessibilityUIElement::boolAttributeValue):
1913
1914 2017-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1915
1916         Move UUID from WebCore/platform to WTF
1917         https://bugs.webkit.org/show_bug.cgi?id=171372
1918
1919         Reviewed by Michael Catanzaro.
1920
1921         * WebKitTestRunner/TestController.cpp:
1922
1923 2017-04-27  Alex Christensen  <achristensen@webkit.org>
1924
1925         Add stub SPI for setting cookie storage path on _WKWebsiteDataStoreConfiguration
1926         https://bugs.webkit.org/show_bug.cgi?id=171399
1927
1928         Reviewed by Brady Eidson.
1929
1930         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html:
1931         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1932         (TEST):
1933
1934 2017-04-27  Ryan Haddad  <ryanhaddad@apple.com>
1935
1936         Disable flaky API test WKWebView.SetOverrideContentSecurityPolicyWithEmptyStringForPageWithCSP.
1937         https://bugs.webkit.org/show_bug.cgi?id=167914
1938
1939         Unreviewed test gardening.
1940
1941         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm:
1942         (TEST):
1943
1944 2017-04-26  Saam Barati  <sbarati@apple.com>
1945
1946         Add some more testing modes for Wasm tests now that we have tier up
1947         https://bugs.webkit.org/show_bug.cgi?id=171360
1948
1949         Reviewed by Keith Miller.
1950
1951         Lets enable the FTL on all Wasm tests. Let's also run each
1952         test with and without CJIT.
1953
1954         * Scripts/run-jsc-stress-tests:
1955
1956 2017-04-26  Aakash Jain  <aakash_jain@apple.com>
1957
1958         JSC EWS Patch Relevance skips few JSC scripts
1959         https://bugs.webkit.org/show_bug.cgi?id=171351
1960
1961         Reviewed by Alexey Proskuryakov.
1962
1963         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1964         (CheckPatchRelevance): Added few jsc related scripts.
1965
1966 2017-04-26  Youenn Fablet  <youenn@apple.com>
1967
1968         Test importer should delete obsolete files based on w3c-import.log
1969         https://bugs.webkit.org/show_bug.cgi?id=171348
1970
1971         Reviewed by Chris Dumez.
1972
1973         * Scripts/webkitpy/w3c/test_importer.py:
1974         (TestImporter.do_import): Removing dangling -expected.txt files in regular import mode.
1975         (TestImporter.remove_deleted_files): Fixing according w3c-import.log current format.
1976         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1977         (test_remove_obsolete_content):
1978
1979 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
1980
1981         REGRESSION (r213926): We're sometimes trying to start WebKitTestRunner without proper DYLD variables
1982         <rdar://problem/31816459>
1983
1984         Unreviewed infrastructure fix.
1985
1986         Some of our iOS Simulator bots are slow and will register crashes due to an incorrect
1987         DYLD_FRAMEWORK_PATH when installing an app.
1988
1989         * Scripts/webkitpy/port/ios.py:
1990         (IOSPort.setup_test_run): Pass DYLD_FRAMEWORK_PATH to app on install.
1991
1992 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
1993
1994         [ATK] Elements with a defined, non-false value for aria-current should expose ATK_STATE_ACTIVE
1995         https://bugs.webkit.org/show_bug.cgi?id=171163
1996
1997         Reviewed by Chris Fleizach.
1998
1999         Add support for state-change notifications for ATK_STATE_ACTIVE.
2000
2001         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2002
2003 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
2004
2005         webkitpy: Teardown iOS Simulators on exit if managed Simulators are still running
2006         https://bugs.webkit.org/show_bug.cgi?id=171293
2007
2008         Reviewed by Aakash Jain.
2009
2010         We should make an effort to teardown simulators which we booted even when an exception is
2011         thrown while booting. Make some IOSSimulatorPort functions into static methods and register
2012         one of these functions to be run at exit to ensure any devices webkitpy is managing gets
2013         torn down.
2014
2015         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2016         (Manager._set_up_run): Rely on exit handlers to teardown, not exceptions.
2017         * Scripts/webkitpy/port/ios_simulator.py:
2018         (IOSSimulatorPort._teardown_managed_simulators): Function run on exit which will kill all
2019         iOS simulators and teardown and managed devices.
2020         (IOSSimulatorPort._create_simulators): Register teardown function.
2021         (IOSSimulatorPort.clean_up_test_run): Move device teardown to _teardown_managed_simulators.
2022         (IOSSimulatorPort._remove_device): Deleted.
2023
2024 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
2025
2026         [ATK] Implement support for new ARIA 1.1 values of aria-haspopup
2027         https://bugs.webkit.org/show_bug.cgi?id=171164
2028
2029         Reviewed by Chris Fleizach.
2030
2031         hasPopup() should return whether or not ATK_STATE_HAS_POPUP is in the
2032         AtkStateSet; not what is found in the AtkObject's attributes.
2033
2034         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2035         (WTR::AccessibilityUIElement::hasPopup):
2036
2037 2017-04-25  Alex Christensen  <achristensen@webkit.org>
2038
2039         Encoded filename should be decoded for WKContentExtension.identifier
2040         https://bugs.webkit.org/show_bug.cgi?id=171316
2041
2042         Reviewed by Andy Estes.
2043
2044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2045         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm.
2046         (TEST_F):
2047         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm: Removed.
2048
2049 2017-04-25  Alex Christensen  <achristensen@webkit.org>
2050
2051         REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
2052         https://bugs.webkit.org/show_bug.cgi?id=171297
2053         <rdar://problem/31530719>
2054
2055         Reviewed by Geoffrey Garen.
2056
2057         * TestWebKitAPI/PlatformWebView.h:
2058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2059         * TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added.
2060         (TestWebKitAPI::didFinishLoadForFrame):
2061         (TestWebKitAPI::mouseDidMoveOverElement):
2062         (TestWebKitAPI::setClients):
2063         (TestWebKitAPI::TEST):
2064         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2065         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2066         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2067
2068 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2069
2070         Unreviewed, temporarily disable the data interaction unit tests.
2071
2072         The API around data interaction will change significantly in the near future, and
2073         these tests will begin to fail. These will be reenabled once the bots are on an SDK
2074         that supports the updated data interaction API.
2075
2076         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2077         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2078         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2079
2080 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
2081
2082         Limit allowed size of document.title to avoid locking WebKit clients
2083         https://bugs.webkit.org/show_bug.cgi?id=165113
2084         <rdar://problem/28324389>
2085
2086         Reviewed by Darin Adler.
2087
2088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2089         * TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Added.
2090         * TestWebKitAPI/Tests/WebKit2/set-long-title.html: Added.
2091         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm: Added.
2092
2093 2017-04-25  John Wilander  <wilander@apple.com>
2094
2095         Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting
2096         https://bugs.webkit.org/show_bug.cgi?id=171295
2097         <rdar://problem/31823818>
2098
2099         Reviewed by Brent Fulgham.
2100
2101         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2102         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2103         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree):
2104         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler):
2105         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
2106         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2107         * WebKitTestRunner/TestController.cpp:
2108         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree):
2109         (WTR::TestController::statisticsFireShouldPartitionCookiesHandler):
2110         (WTR::TestController::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
2111         * WebKitTestRunner/TestController.h:
2112         * WebKitTestRunner/TestInvocation.cpp:
2113         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2114
2115 2017-04-25  Tim Horton  <timothy_horton@apple.com>
2116
2117         Try to fix the WKTR build after r215758
2118
2119         * Scripts/build-webkittestrunner:
2120
2121 2017-04-25  Daniel Bates  <dabates@apple.com>
2122
2123         Remove more EFL code
2124         https://bugs.webkit.org/show_bug.cgi?id=171288
2125
2126         Rubber-stamped by Simon Fraser.
2127
2128         The EFL port is no longer in the WebKit OpenSource Project repository. Remove more code
2129         that was part of the EFL port.
2130
2131         * CMakeLists.txt:
2132         * DumpRenderTree/AccessibilityController.h:
2133         * DumpRenderTree/AccessibilityUIElement.cpp:
2134         (AccessibilityUIElement::getJSClass):
2135         * DumpRenderTree/AccessibilityUIElement.h:
2136         * DumpRenderTree/DumpRenderTree.h:
2137         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2138         * ImageDiff/efl/ImageDiff.cpp: Removed.
2139         * MiniBrowser/efl/CMakeLists.txt: Removed.
2140         * MiniBrowser/efl/main.c: Removed.
2141         * Scripts/build-dumprendertree:
2142         * Scripts/build-jsc:
2143         * Scripts/build-webkit:
2144         * Scripts/build-webkittestrunner:
2145         * Scripts/run-minibrowser:
2146         * Scripts/update-webkit-libs-jhbuild:
2147         * Scripts/update-webkitefl-libs: Removed.
2148         * Scripts/webkitdirs.pm:
2149         (argumentsForConfiguration):
2150         (extractNonMacOSHostConfiguration):
2151         (executableProductDir):
2152         (builtDylibPathForName):
2153         (determinePortName):
2154         (launcherPath):
2155         (launcherName):
2156         (getJhbuildPath):
2157         (wrapperPrefixIfNeeded):
2158         (generateBuildSystemFromCMakeProject):
2159         (buildCMakeProjectOrExit):
2160         (isEfl): Deleted.
2161         * Scripts/webkitperl/FeatureList.pm:
2162         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
2163         * Scripts/webkitpy/common/config/ports.py:
2164         (DeprecatedPort.port):
2165         (GtkWK2Port.run_webkit_tests_command):
2166         (EflWK2Port): Deleted.
2167         (EflWK2Port.build_webkit_command): Deleted.
2168         * Scripts/webkitpy/port/builders.py:
2169         * Scripts/webkitpy/port/efl.py: Removed.
2170         * Scripts/webkitpy/port/efl_unittest.py: Removed.
2171         * Scripts/webkitpy/port/factory.py:
2172         (platform_options):
2173         (PortFactory):
2174         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2175         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2176         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2177         (TestRebaselineTest.test_baseline_directory):
2178         (TestRebaselineExpectations.test_rebaseline_expectations):
2179         * TestWebKitAPI/PlatformEfl.cmake: Removed.
2180         * TestWebKitAPI/PlatformWebView.h:
2181         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2182         (TestWebKitAPI::TEST):
2183         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
2184         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
2185         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
2186         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
2187         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
2188         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
2189         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
2190         * TestWebKitAPI/efl/main.cpp: Removed.
2191         * WebKitTestRunner/EventSenderProxy.h:
2192         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2193         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2194         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2195         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2196         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2197         (WTR::EventSendingController::contextClick):
2198         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2199         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2200         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2201         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2202         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
2203         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
2204         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
2205         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
2206         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
2207         * WebKitTestRunner/PlatformEfl.cmake: Removed.
2208         * WebKitTestRunner/PlatformWebView.h:
2209         * WebKitTestRunner/TestController.cpp:
2210         (WTR::TestController::resetStateToConsistentValues):
2211         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
2212         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
2213         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
2214         * WebKitTestRunner/efl/main.cpp: Removed.
2215         * efl/install-dependencies: Removed.
2216         * efl/jhbuild-optional.modules: Removed.
2217         * efl/jhbuild.modules: Removed.
2218         * efl/jhbuildrc: Removed.
2219         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
2220         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
2221         * efl/patches/gst-libav.patch: Removed.
2222         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
2223         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2224         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2225         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
2226         * gtk/manifest.txt.in:
2227
2228 2017-04-25  Daniel Bates  <dabates@apple.com>
2229
2230         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
2231         https://bugs.webkit.org/show_bug.cgi?id=136452
2232         <rdar://problem/23412620>
2233
2234         Reviewed by Brent Fulgham.
2235
2236         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
2237
2238         * Scripts/webkitperl/FeatureList.pm: Also do not enable nosniff on EFL
2239         as the EFL port is no longer in the WebKit OpenSource repository.
2240         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2241
2242 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2243
2244         Unreviewed follow-up to r215739 and r215740.
2245
2246         * gtk/jhbuild.modules: List the libgcrypt patch that has to be applied.
2247         This (and r215740) was supposed to land in r215739, but I managed to
2248         specify the previous version of the patch.
2249
2250 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2251
2252         Unreviewed follow-up to r215739.
2253
2254         * gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Add the missing
2255         libgcrypt patch that enforces the use of /dev/urandom.
2256
2257 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2258
2259         [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
2260         https://bugs.webkit.org/show_bug.cgi?id=171270
2261
2262         Reviewed by Michael Catanzaro.
2263
2264         * gtk/jhbuild.modules: Add the latest stable versions of libgpg-error and libgcrypt
2265         libraries to the webkitgtk-testing-dependencies metamodule. This will help people
2266         that use systems that don't yet provide libgcrypt >= 1.7.0.
2267
2268 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2269
2270         [GTK] Improve an unit test for the JHBuild wrapper.
2271         https://bugs.webkit.org/show_bug.cgi?id=168036
2272
2273         Unreviewed follow-up patch after r215727
2274
2275         * Scripts/webkitpy/port/base_unittest.py:
2276         (test_jhbuild_wrapper): Improve the unit test by ensuring the directory
2277         wasn't there before calling MockFileSystem.maybe_make_directory(), and
2278         also that it exists after calling it.
2279
2280 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2281
2282         [GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild
2283         https://bugs.webkit.org/show_bug.cgi?id=168036
2284
2285         Reviewed by Michael Catanzaro.
2286
2287         Call ImageDiff with the JHBuild wrapper if we should use it.
2288         Also add some unit tests for the JHBuild wrapper feature.
2289
2290         * Scripts/webkitpy/port/base.py:
2291         (Port._should_use_jhbuild): Use self._filesystem instead of os.path to allow mock testing.
2292         * Scripts/webkitpy/port/base_unittest.py:
2293         (test_jhbuild_wrapper): Add a test for port._should_use_jhbuild()
2294         * Scripts/webkitpy/port/image_diff.py:
2295         (ImageDiffer._start): The actual fix, use the wrapper if we should.
2296         * Scripts/webkitpy/port/image_diff_unittest.py: Removed. This two tests are now integrated in port_testcase
2297         * Scripts/webkitpy/port/port_testcase.py:
2298         (PortTestCase):
2299         (PortTestCase.test_diff_image): Test the command with wrapper and without it.
2300         (PortTestCase.test_diff_image_passed): Moved from image_diff_unittest.py
2301         (PortTestCase.test_diff_image_failed): Moved from image_diff_unittest.py
2302
2303 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2304
2305         Support reading NSURL titles from the pasteboard when performing data interaction
2306         https://bugs.webkit.org/show_bug.cgi?id=171156
2307         <rdar://problem/31356937>
2308
2309         Reviewed by Tim Horton.
2310
2311         Adds a new unit test, DataInteractionTests.ExternalSourceTitledNSURL.
2312
2313         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2314         (TestWebKitAPI::TEST):
2315
2316 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2317
2318         Respect fidelity order when reading web content from item providers
2319         https://bugs.webkit.org/show_bug.cgi?id=171155
2320         <rdar://problem/31356937>
2321
2322         Reviewed by Tim Horton.
2323
2324         Adds a new unit test (DataInteractionTests.RespectsExternalSourceFidelityRankings). See WebCore ChangeLog for
2325         more details.
2326
2327         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2328         (TestWebKitAPI::TEST):
2329
2330 2017-04-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2331
2332         SyntaxError fix after r215702.
2333         https://bugs.webkit.org/show_bug.cgi?id=168944
2334
2335         Unreviewed "build" fix.
2336
2337         * BuildSlaveSupport/built-product-archive:
2338         (archiveBuiltProduct):
2339
2340 2017-04-24  Jonathan Bedard  <jbedard@apple.com>
2341
2342         Package ImageDiff built with host SDK
2343         https://bugs.webkit.org/show_bug.cgi?id=168944
2344         <rdar://problem/30745642>
2345
2346         Reviewed by David Kilzer.
2347
2348         iOS Simulator and iOS device should archive the ImageDiff built for the host
2349         machine.
2350
2351         * BuildSlaveSupport/built-product-archive:
2352         (determineWebKitBuildDirectories): Add _hostBuildDirectory for iOS.
2353         (archiveBuiltProduct): Archive Mac products for iOS so that ImageDiff is included.
2354
2355 2017-04-24  Keith Miller  <keith_miller@apple.com>
2356
2357         ThreadMessage API tests failing on release bots
2358         https://bugs.webkit.org/show_bug.cgi?id=171246
2359
2360         Reviewed by Saam Barati.
2361
2362         Need to make sure that C++ doesn't optimize away our spin loop.
2363
2364         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2365         (runThreadMessageTest):
2366         (TEST):
2367
2368 2017-04-24  Alex Christensen  <achristensen@webkit.org>
2369
2370         Reduce copies and allocations in SharedBuffer::append
2371         https://bugs.webkit.org/show_bug.cgi?id=170956
2372
2373         Reviewed by Andreas Kling.
2374
2375         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2376         (TestWebKitAPI::TEST_F):
2377
2378 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2379
2380         [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
2381         https://bugs.webkit.org/show_bug.cgi?id=166680
2382
2383         Reviewed by Michael Catanzaro.
2384
2385         Update remote inspector unit tests.
2386
2387         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp:
2388         (main):
2389         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2390         (connectToInspectorServer):
2391         (waitUntilInspectorServerIsReady):
2392         (startTestServer):
2393         (testInspectorServerPageList):
2394         (beforeAll):
2395
2396 2017-04-23  Youenn Fablet  <youenn@apple.com>
2397
2398         Add a tool to update expected.txt files from EWS bot results
2399         https://bugs.webkit.org/show_bug.cgi?id=169538
2400
2401         Reviewed by Ryosuke Niwa.
2402
2403         This script updates expected-txt files from bugzilla posted EWS results.
2404         It uses mac-wk2 as the generic baseline and adds platform-specific results if other ports
2405         have results different from the generic baseline.
2406
2407         * Scripts/update-test-expectations-from-bugzilla: Added.
2408         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: Added.
2409         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: Added.
2410         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Adding helper routines.
2411
2412 2017-04-22  Youenn Fablet  <youenn@apple.com>
2413
2414         Add an option to import tip-of-tree WPT tests
2415         https://bugs.webkit.org/show_bug.cgi?id=171152
2416
2417         Reviewed by Joseph Pecoraro.
2418
2419         Adding a '-t' option to import tip of tree WPT tests.
2420         Updating importer based on the fact that csswg-test is no longer a thing. 
2421
2422         * Scripts/webkitpy/w3c/test_downloader.py:
2423         (TestDownloader.download_tests):
2424         * Scripts/webkitpy/w3c/test_importer.py:
2425         (configure_logging):
2426         (TestImporter.do_import):
2427         (TestImporter.write_import_log):
2428
2429 2017-04-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2430
2431         File inputs only accept UTI types that can be inserted into contenteditable areas when dropping
2432         https://bugs.webkit.org/show_bug.cgi?id=171177
2433         <rdar://problem/31765379>
2434
2435         Reviewed by Andy Estes.
2436
2437         Tests uploading a JSON file to a file input.
2438
2439         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2440         (TestWebKitAPI::TEST):
2441
2442 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2443
2444         Support writing link titles to the pasteboard when beginning data interaction on a link
2445         https://bugs.webkit.org/show_bug.cgi?id=171154
2446         <rdar://problem/31356937>
2447
2448         Reviewed by Andy Estes.
2449
2450         Augments an existing unit test, DataInteractionTests.LinkToInput, to also check that the fetching the NSURL from
2451         the source UIItemProvider generated by performing data interaction results in an NSURL with the _title attribute
2452         matching the title of the link.
2453
2454         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2455         (TestWebKitAPI::TEST):
2456
2457 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2458
2459         Unreviewed, rolling out r215608.
2460
2461         Hundreds of test failures on GTK bot
2462
2463         Reverted changeset:
2464
2465         "Reduce copies and allocations in SharedBuffer::append"
2466         https://bugs.webkit.org/show_bug.cgi?id=170956
2467         http://trac.webkit.org/changeset/215608
2468
2469 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2470
2471         [WK2] Add delegate hooks for overriding unhanded data interaction operations
2472         https://bugs.webkit.org/show_bug.cgi?id=171005
2473         <rdar://problem/31669646>
2474
2475         Reviewed by Tim Horton.
2476
2477         Adds a new API test checking that normal WebKit behavior when vending updated data interaction operations may
2478         be overridden, resulting in a data interaction operation being performed when it otherwise would not have. Also
2479         adjusts for some changes in WebKit2 (See WebKit2 ChangeLog for more details).
2480
2481         New API test:
2482         DataInteractionTests.OverrideDataInteractionOperation
2483
2484         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2485         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
2486         (TestWebKitAPI::TEST):
2487         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2488         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2489         (-[DataInteractionSimulator initWithWebView:]):
2490         (-[DataInteractionSimulator dealloc]):
2491         (-[DataInteractionSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
2492         (-[DataInteractionSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
2493         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): Deleted.
2494
2495 2017-04-21  Ryan Haddad  <ryanhaddad@apple.com>
2496
2497         Temporarily disable two flaky API tests.
2498
2499         Unreviewed test gardening.
2500
2501         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2502         (TEST):
2503         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2504         (TEST):
2505
2506 2017-04-21  Keith Miller  <keith_miller@apple.com>
2507
2508         Unreviewed, rolling out r215634.
2509
2510         underlying build issues should have been fixed
2511
2512         Reverted changeset:
2513
2514         "Unreviewed, rolling out r215620 and r215623."
2515         https://bugs.webkit.org/show_bug.cgi?id=171139
2516         http://trac.webkit.org/changeset/215634
2517
2518 2017-04-21  Aakash Jain  <aakash_jain@apple.com>
2519
2520         Bubbles on dashboard doesn't turn red for test262 failures
2521         https://bugs.webkit.org/show_bug.cgi?id=171129
2522
2523         Reviewed by Alexey Proskuryakov.
2524
2525         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.
2526
2527 2017-04-21  Commit Queue  <commit-queue@webkit.org>
2528
2529         Unreviewed, rolling out r215620 and r215623.
2530         https://bugs.webkit.org/show_bug.cgi?id=171139
2531
2532         broke arm64 build (Requested by keith_miller on #webkit).
2533
2534         Reverted changesets:
2535
2536         "Add signaling API"
2537         https://bugs.webkit.org/show_bug.cgi?id=170976
2538         http://trac.webkit.org/changeset/215620
2539
2540         "Unreviewed, fix Cloop build."
2541         http://trac.webkit.org/changeset/215623
2542
2543 2017-04-20  Keith Miller  <keith_miller@apple.com>
2544
2545         Add signaling API
2546         https://bugs.webkit.org/show_bug.cgi?id=170976
2547
2548         Reviewed by Filip Pizlo.
2549
2550         Add tests for ThreadMessages.
2551
2552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2553         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: Added.
2554         (runThreadMessageTest):
2555         (TEST):
2556
2557 2017-04-20  Conrad Shultz  <conrad_shultz@apple.com>
2558
2559         commit-log-editor should respect the git editor if one is set
2560         https://bugs.webkit.org/show_bug.cgi?id=171085
2561         <rdar://problem/31745506>
2562
2563         Reviewed by Daniel Bates.
2564
2565         * Scripts/commit-log-editor:
2566         If Git is available, consider GIT_LOG_EDITOR and any global Git editor preference when
2567         deciding which editor to present. We examine the global editor preference since that may be
2568         set automatically by installers or third-party tools.
2569
2570 2017-04-21  Alex Christensen  <achristensen@webkit.org>
2571
2572         Reduce copies and allocations in SharedBuffer::append
2573         https://bugs.webkit.org/show_bug.cgi?id=170956
2574
2575         Reviewed by Andreas Kling.
2576
2577         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2578         (TestWebKitAPI::TEST_F):
2579
2580 2017-04-20  Konstantin Tokarev  <annulen@yandex.ru>
2581
2582         [cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
2583         https://bugs.webkit.org/show_bug.cgi?id=171071
2584
2585         Reviewed by Michael Catanzaro.
2586
2587         "${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
2588         build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
2589         be available for all ports.
2590
2591         * DumpRenderTree/PlatformMac.cmake:
2592         * MiniBrowser/mac/CMakeLists.txt:
2593         * MiniBrowser/win/CMakeLists.txt:
2594         * TestWebKitAPI/PlatformJSCOnly.cmake:
2595         * TestWebKitAPI/PlatformMac.cmake:
2596         * TestWebKitAPI/PlatformWin.cmake:
2597         * WebKitTestRunner/PlatformMac.cmake:
2598
2599 2017-04-20  Joseph Pecoraro  <pecoraro@apple.com>
2600
2601         Test262 bot does not go red with failures
2602         https://bugs.webkit.org/show_bug.cgi?id=171044
2603
2604         Reviewed by Aakash Jain.
2605
2606         The piped output of run-jsc-stress-tests is different from
2607         its non-piped output. Switch to parsing the correct output.
2608
2609         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2610         (RunTest262Tests.countFailures):
2611         Just count the number of lines that start with "FAIL:".
2612
2613         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2614         (RunTest262TestsTest.test_no_regressions_output):
2615         (test_failure_output):
2616         (test_failures_output):
2617         Updated tests with new sample output produced partially from bots and
2618         locally. In cases of failure the return code of run-jsc-stress-tests
2619         is still 0 so update the expected return code in the tests.
2620
2621 2017-04-20  Brady Eidson  <beidson@apple.com>
2622
2623         WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:...
2624         <rdar://problem/31739023> and https://bugs.webkit.org/show_bug.cgi?id=171090
2625
2626         Reviewed by Andy Estes.
2627
2628         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html:
2629         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2630         (resetToConsistentState):
2631         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]):
2632         (-[OpenAndCloseWindowUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2633         (TEST):
2634         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
2635
2636 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2637
2638         [ios-simulator] PositionInformationTests API tests are timing out
2639         https://bugs.webkit.org/show_bug.cgi?id=171089
2640
2641         Rubber-stamped by Tim Horton.
2642
2643         Addresses failures observed in the new position information tests added in r215573 by only running them if the
2644         DATA_INTERACTION feature flag is enabled.
2645
2646         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
2647
2648 2017-04-20  Brady Eidson  <beidson@apple.com>
2649
2650         Skip WebKit2.OpenAndCloseWindowAsyncCallbackException for now.
2651         https://bugs.webkit.org/show_bug.cgi?id=171083
2652
2653         Unreviewed.
2654
2655         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2656
2657 2017-04-20  Brady Eidson  <beidson@apple.com>
2658
2659         Add CompletionHandlerCallChecker to SPI added in r215545.
2660         https://bugs.webkit.org/show_bug.cgi?id=171067
2661
2662         Reviewed by Dan Bernstein.
2663
2664         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2665         (TEST):
2666         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
2667
2668 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2669
2670         [WK2] -[WKContentView doAfterPositionInformationUpdate:atPosition:] should be robust against synchronous reentrancy
2671         https://bugs.webkit.org/show_bug.cgi?id=170922
2672         <rdar://problem/31634990>
2673
2674         Reviewed by Tim Horton.
2675
2676         Adds six new unit tests for retrieving interaction information at a given position in the UI process. See
2677         WebKit2 ChangeLog for more details.
2678
2679         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
2680         (-[_WKDraggableElementInfo expectToBeLink:image:atPoint:]):
2681         (TestWebKitAPI::TEST):
2682         (TestWebKitAPI::expectCGPointsToBeEqual): Deleted.
2683
2684 2017-04-20  Xan Lopez  <xlopez@igalia.com>
2685
2686         [GTK][jhbuild] Update glib and glib-networking to the latest stable versions
2687         https://bugs.webkit.org/show_bug.cgi?id=170942
2688
2689         Reviewed by Carlos Garcia Campos.
2690
2691         Update glib and glib-networking to the last stable releases. This
2692         is needed to get working TLS certificate verification at all at
2693         least in Fedora.
2694
2695         * gtk/install-dependencies: add libmount, needed for newer glib.
2696         * gtk/jhbuild.modules: update glib and glib-networking to last
2697         stable releases.
2698
2699 2017-04-20  Joanmarie Diggs  <jdiggs@igalia.com>
2700
2701         [ATK] Implement support for DPub ARIA roles
2702         https://bugs.webkit.org/show_bug.cgi?id=170679
2703
2704         Reviewed by Chris Fleizach.
2705
2706         Add DPub ARIA landmark roles to roleToString().
2707
2708         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2709
2710 2017-04-19  Joseph Pecoraro  <pecoraro@apple.com>
2711
2712         Remove WebKitTestRunner code for enabling features that are already enabled by default
2713         https://bugs.webkit.org/show_bug.cgi?id=171033
2714
2715         Reviewed by Ryosuke Niwa.
2716
2717         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2718         (WTR::InjectedBundle::beginTesting):
2719         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2720         (WTR::TestRunner::setShadowDOMEnabled): Deleted.
2721         (WTR::TestRunner::setCustomElementsEnabled): Deleted.
2722         (WTR::TestRunner::setFetchAPIEnabled): Deleted.
2723         (WTR::TestRunner::setDownloadAttributeEnabled): Deleted.
2724         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2725
2726 2017-04-19  Youenn Fablet  <youenn@apple.com>
2727
2728         [Mac] Allow customizing H264 encoder
2729         https://bugs.webkit.org/show_bug.cgi?id=170829
2730
2731         Reviewed by Alex Christensen.
2732
2733         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2734
2735 2017-04-19  Brady Eidson  <beidson@apple.com>
2736
2737         Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...].
2738         <rdar://problem/30699851> and https://bugs.webkit.org/show_bug.cgi?id=171018
2739
2740         Reviewed by Tim Horton.
2741
2742         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2743         (TEST):
2744         (-[OpenAndCloseWindowUIDelegateAsync webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2745         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
2746
2747 2017-04-19  Brady Eidson  <beidson@apple.com>
2748
2749         REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed.
2750         <rdar://problem/30774839> and https://bugs.webkit.org/show_bug.cgi?id=171002
2751
2752         Reviewed by Alex Christensen.
2753
2754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2755         * TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Added.
2756
2757 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
2758
2759         [WK2] Run tests with ResourceLoadStatistics enabled
2760         https://bugs.webkit.org/show_bug.cgi?id=170952
2761
2762         Reviewed by Andy Estes.
2763
2764         Excercise the load statistics code during tests.
2765
2766         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2767         (WTR::initializeWebViewConfiguration):
2768
2769 2017-04-19  Bill Ming  <mbbill@gmail.com>
2770
2771         close_fds should be set to False on Windows.
2772         https://bugs.webkit.org/show_bug.cgi?id=170838
2773
2774         Reviewed by Brent Fulgham.
2775
2776         * Scripts/webkitpy/common/system/executive.py:
2777         (Executive._should_close_fds):
2778
2779 2017-04-19  David Kilzer  <ddkilzer@apple.com>
2780
2781         Stop using strcpy() in WebKit::EnvironmentUtilities::stripValuesEndingWithString()
2782         <https://webkit.org/b/170994>
2783         <rdar://problem/29889932>
2784
2785         Reviewed by Brent Fulgham.
2786
2787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2788         (EnvironmentUtilitiesTest.cpp): Add to TestWebKitAPILibrary
2789         target.
2790         * TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Add.
2791         (TestWebKitAPI::strip): Helper method to set/get environment
2792         variable for testing.
2793         (TestWebKitAPI::WebKit2_StripValuesEndingWithString_Test): Add
2794         tests.
2795
2796 2017-04-19  JF Bastien  <jfbastien@apple.com>
2797
2798         WebAssembly: add script which can import GCC torture tests
2799         https://bugs.webkit.org/show_bug.cgi?id=170740
2800
2801         Reviewed by Saam Barati.
2802
2803         Add a script which can import the GCC torture tests and create a
2804         yaml file to run them as part of jsc's WebAssembly regression
2805         tests.
2806
2807         This patch doesn't commit the tests themselves because they're
2808         licensed differently.
2809
2810         * Scripts/run-jsc-stress-tests: learn how to run
2811         Emscripten-generated .js+.wasm files, and do a bit of cleanup on
2812         the options because WebAssembly is enabled by default.
2813         * Scripts/update-wasm-gcc-torture.py: Added.
2814         (parse_args):
2815         (update_lkgr):
2816         (untar_torture):
2817         (list_js_files):
2818         (waterfall_known_failures):
2819         (create_yaml):
2820         (main):
2821
2822 2017-04-19  Youenn Fablet  <youenn@apple.com>
2823
2824         Import web-platform-tests/tools
2825         https://bugs.webkit.org/show_bug.cgi?id=170718
2826
2827         Reviewed by Alex Christensen.
2828
2829         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2830         (main):
2831         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2832         (WebPlatformTestServer.ports_to_forward):
2833         (WebPlatformTestServer._prepare_config):
2834         (WebPlatformTestServer._install_modules): Deleted.
2835         * Scripts/webkitpy/w3c/test_importer.py:
2836         (TestImporter.write_html_files_for_templated_js_tests):
2837
2838 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2839
2840         [WK2] Add infrastructure and unit tests for file uploads using data interaction
2841         https://bugs.webkit.org/show_bug.cgi?id=170903
2842         <rdar://problem/31314689>
2843
2844         Reviewed by Tim Horton.
2845
2846         Adds 5 new unit tests covering different cases of uploading files through data interaction, as well as
2847         infrastructure for simulating UIItemProviders that load file data. Makes a few adjustments to the
2848         DataInteractionSimulator along the way, detailed in the per-method annotations below. See
2849         <https://bugs.webkit.org/show_bug.cgi?id=170880> for more details about the change this patch is testing.
2850
2851         New tests:
2852         DataInteractionTests.ExternalSourceImageToFileInput
2853         DataInteractionTests.ExternalSourceHTMLToUploadArea
2854         DataInteractionTests.ExternalSourceImageAndHTMLToSingleFileInput
2855         DataInteractionTests.ExternalSourceImageAndHTMLToMultipleFileInput
2856         DataInteractionTests.ExternalSourceImageAndHTMLToUploadArea
2857
2858         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2859         (testIconImage):
2860         (temporaryURLForDataInteractionFileLoad):
2861         (cleanUpDataInteractionTemporaryPath):
2862
2863         Creates and tears down temporary file directories for testing data interaction.
2864
2865         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]):
2866         (TestWebKitAPI::TEST):
2867         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2868         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2869
2870         Make necessary changes to be able to test what happens when data interaction ends over an element with no
2871         operation. Previously, we would always simulate performing a data interaction operation when ending the
2872         simulation, but this causes us to wait indefinitely for a data operation response to arrive in the UI process.
2873         Instead, we need to note whether or not the content view is allowing data interaction, and only perform an
2874         operation and wait for the -didPerform call if the operation was allowed. Otherwise, we immediately transition
2875         the phase to Cancelled and end the run.
2876
2877         (-[DataInteractionSimulator _resetSimulatedState]):
2878         (-[DataInteractionSimulator runFrom:to:]):
2879         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2880         (-[DataInteractionSimulator _advanceProgress]):
2881         (-[DataInteractionSimulator externalItemProviders]):
2882         (-[DataInteractionSimulator setExternalItemProviders:]):
2883
2884         Previously, we hard-coded DataInteractionSimulator to only support a single external item provider. In order to
2885         test the scenario where multiple files are being "data interacted" into a file-type input, we generalize this to
2886         take multiple item providers.
2887
2888         (-[DataInteractionSimulator externalItemProvider]): Deleted.
2889         (-[DataInteractionSimulator setExternalItemProvider:]): Deleted.
2890
2891 2017-04-18  John Wilander  <wilander@apple.com>
2892
2893         Make WebCore::topPrivatelyControlledDomain() return "localhost" for localhost
2894         https://bugs.webkit.org/show_bug.cgi?id=170798
2895         <rdar://problem/31595108>
2896
2897         Reviewed by Alex Christensen.
2898
2899         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
2900         (TestWebKitAPI::TEST_F):
2901             Added two negative test cases for WebCore::isPublicSuffix().
2902             Added test cases with mixed case domains, localhost, and
2903             non-ASCII for WebCore::topPrivatelyControlledDomain().
2904
2905 2017-04-18  Jonathan Bedard  <jbedard@apple.com>
2906
2907         Unreviewed, rolling out r215346 and 215361.
2908
2909         The problem these changes were fixing was addressed in
2910         <https://trac.webkit.org/changeset/215416/webkit>.
2911
2912         Reverted changesets:
2913
2914         "webkitpy: Ignore previously launched pid when system is under
2915         stress"
2916         https://bugs.webkit.org/show_bug.cgi?id=170741
2917         http://trac.webkit.org/changeset/215346
2918         http://trac.webkit.org/changeset/215361
2919
2920 2017-04-17  Alex Christensen  <achristensen@webkit.org>
2921
2922         Allow Variants of RetainPtrs
2923         https://bugs.webkit.org/show_bug.cgi?id=170923
2924
2925         Reviewed by Tim Horton and Sam Weinig.
2926
2927         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2928         (TestWebKitAPI::TEST):
2929         Add tests for RetainPtr and for another class with overloaded operator& to verify such classes can
2930         work in Variants.
2931
2932 2017-04-17  Brady Eidson  <beidson@apple.com>
2933
2934         Make WKHTTPCookieStore public.
2935         <rdar://problem/31024691> and https://bugs.webkit.org/show_bug.cgi?id=170920
2936
2937         Reviewed by Geoffrey Garen.
2938
2939         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2940         (TEST):
2941
2942 2017-04-17  Youenn Fablet  <youenn@apple.com>
2943
2944         Disable outdated WritableStream API
2945         https://bugs.webkit.org/show_bug.cgi?id=170749
2946         <rdar://problem/31446233>
2947
2948         Reviewed by Alex Christensen.
2949
2950         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
2951         - A STREAMS_API compilation flag.
2952         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
2953
2954         * DumpRenderTree/mac/DumpRenderTree.mm:
2955         (enableExperimentalFeatures):
2956         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2957         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2958         (WTR::InjectedBundle::beginTesting):
2959         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2960         (WTR::TestRunner::setFetchAPIEnabled):
2961         (WTR::TestRunner::setWritableStreamAPIEnabled):
2962         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2963         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2964
2965 2017-04-17  Tim Horton  <timothy_horton@apple.com>
2966
2967         Provide a viewport parameter to disable clipping to the safe area
2968         https://bugs.webkit.org/show_bug.cgi?id=170766
2969         <rdar://problem/31564634>
2970
2971         Reviewed by Beth Dakin.
2972
2973         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2974         (WTR::UIScriptController::setObscuredInsets):
2975         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2976         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2977         (WTR::UIScriptController::setObscuredInsets):
2978         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2979         * WebKitTestRunner/ios/TestControllerIOS.mm:
2980         (WTR::TestController::platformResetStateToConsistentValues):
2981         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2982         (WTR::UIScriptController::setObscuredInsets):
2983         Add a UIScriptController mechanism to install obscured insets
2984         on the web view.
2985
2986 2017-04-17  Dan Bernstein  <mitz@apple.com>
2987
2988         [Cocoa] Move isNullFunctionPointer down into WTF
2989         https://bugs.webkit.org/show_bug.cgi?id=170892
2990
2991         Reviewed by Sam Weinig.
2992
2993         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
2994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2995         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp: Added.
2996         (TestWebKitAPI::TEST):
2997         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd: Added.
2998         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd: Added.
2999         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd: Added.
3000         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd: Added.
3001
3002 2017-04-17  Jonathan Bedard  <jbedard@apple.com>
3003
3004         webkitpy: Correct poll when killing ServerProcess
3005
3006         Unreviewed infrastructure fix.
3007
3008         * Scripts/webkitpy/port/server_process.py:
3009         (ServerProcess._kill): A polled process equaling 'None' means the process is running.
3010
3011 2017-04-17  Eric Carlson  <eric.carlson@apple.com>
3012
3013         [MediaStream] Enable getUserMedia API test
3014         https://bugs.webkit.org/show_bug.cgi?id=170901
3015         <rdar://problem/31656594>
3016
3017         Reviewed by Youenn Fablet.
3018
3019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
3020
3021         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3022         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
3023         (TestWebKitAPI::TEST): Enable capture with mock devices.
3024         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Update to mediaDevices.getUserMedia
3025
3026 2017-04-17  Xan Lopez  <xan@igalia.com>
3027
3028         [GTK] Update the Fedora dependencies for WebKitGTK+
3029         https://bugs.webkit.org/show_bug.cgi?id=170590
3030
3031         Reviewed by Carlos Alberto Lopez Perez.
3032
3033         * gtk/install-dependencies: add a bunch of modules necessary to
3034         get a proper set of GStreamer codecs for WebRTC.
3035
3036 2017-04-16  Sam Weinig  <sam@webkit.org>
3037
3038         [WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
3039         https://bugs.webkit.org/show_bug.cgi?id=170843
3040
3041         Reviewed by Chris Dumez.
3042
3043         * DumpRenderTree/DerivedSources.make:
3044         * WebKitTestRunner/DerivedSources.make:
3045         * Scripts/webkitpy/bindings/main.py:
3046         (BindingsTests.generate_from_idl):
3047         Pass IDLAttributes.json, as it is now mandatory to have one.
3048
3049 2017-04-14  Mark Lam  <mark.lam@apple.com>
3050
3051         Update architectures in xcconfig files.
3052         https://bugs.webkit.org/show_bug.cgi?id=170867
3053         <rdar://problem/31628104>
3054
3055         Reviewed by Joseph Pecoraro.
3056
3057         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3058         * MobileMiniBrowser/Configurations/Base.xcconfig:
3059         * TestWebKitAPI/Configurations/Base.xcconfig:
3060         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3061         * WebKitTestRunner/Configurations/Base.xcconfig:
3062
3063 2017-04-14  Brady Eidson  <beidson@apple.com>
3064
3065         Fix basic WKURLSchemeHandler bugs.
3066         <rdar://problem/30647559> and https://bugs.webkit.org/show_bug.cgi?id=170862
3067
3068         Reviewed by Andy Estes.
3069
3070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3071         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Added.
3072         (-[SchemeHandler initWithData:mimeType:]):
3073         (-[SchemeHandler dealloc]):
3074         (-[SchemeHandler webView:startTask:]):
3075         (-[SchemeHandler webView:stopTask:]):
3076         (TEST):
3077
3078 2017-04-14  Bill Ming  <mbbill@gmail.com>
3079
3080         webkit-patch failed to detect git repository
3081         https://bugs.webkit.org/show_bug.cgi?id=170859
3082
3083         Reviewed by Daniel Bates.
3084
3085         Windows cmd does not accept single quoted path. So, using
3086         double quotes here will provide better platform compatibility.
3087
3088         * Scripts/VCSUtils.pm:
3089         (isGitDirectory):
3090         (isGitSVNDirectory):
3091         (svnRevisionForDirectory):
3092         (svnInfoForPath):
3093
3094 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
3095
3096         Unreviewed, rolling out r215374.
3097
3098         This change causes LayoutTests to exit early with crashes on
3099         Sierra.
3100
3101         Reverted changeset:
3102
3103         "webkitpy: Ignore previously launched pid when system is under
3104         stress"
3105         https://bugs.webkit.org/show_bug.cgi?id=170741
3106         http://trac.webkit.org/changeset/215374
3107
3108 2017-04-14  Dan Bernstein  <mitz@apple.com>
3109
3110         [ios-simulator] API test WebKit2.AdditionalReadAccessAllowedURLs is failing
3111         https://bugs.webkit.org/show_bug.cgi?id=170856
3112
3113         Disabled the newly-added test in the Simulator, which doesn’t enforce sandboxing.
3114
3115         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
3116
3117 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
3118
3119         webkitpy: Ignore previously launched pid when system is under stress
3120         https://bugs.webkit.org/show_bug.cgi?id=170741
3121
3122         Unreviewed infrastructure fix.
3123
3124         Drivers are destroyed between failing layout tests, which is not necessary and
3125         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
3126
3127         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3128         (Worker._kill_driver): Do not destroy drivers when they are stopped.
3129         * Scripts/webkitpy/port/driver.py:
3130         (Driver.stop): Reset driver values set in initializer.
3131
3132 2017-04-14  Andy Estes  <aestes@apple.com>
3133
3134         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
3135         https://bugs.webkit.org/show_bug.cgi?id=167594
3136
3137         Re-enabled this API test now that webkit.org/b/161967 is fixed.
3138
3139         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
3140         (TEST):
3141
3142 2017-04-14  Andy Estes  <aestes@apple.com>
3143
3144         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
3145         https://bugs.webkit.org/show_bug.cgi?id=161967
3146
3147         Reviewed by Alexey Proskuryakov.
3148
3149         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3150         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
3151
3152 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
3153
3154         Unreviewed, rolling out r215363.
3155
3156         This change causes LayoutTests to exit early with crashes.
3157
3158         Reverted changeset:
3159
3160         "webkitpy: Ignore previously launched pid when system is under
3161         stress"
3162         https://bugs.webkit.org/show_bug.cgi?id=170741
3163         http://trac.webkit.org/changeset/215363
3164
3165 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
3166
3167         webkitpy: Ignore previously launched pid when system is under stress
3168         https://bugs.webkit.org/show_bug.cgi?id=170741
3169
3170         Unreviewed infrastructure fix.
3171
3172         Drivers are destroyed between failing layout tests, which is not necessary and
3173         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
3174
3175         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3176         (Worker._kill_driver): Do not destroy drivers when they are stopped.
3177
3178 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
3179
3180         webkitpy: Ignore previously launched pid when system is under stress
3181         https://bugs.webkit.org/show_bug.cgi?id=170741
3182
3183         Unreviewed infrastructure fix.
3184
3185         Server processes are destroyed in the driver, which is not necessary and prevents
3186         the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
3187
3188         * Scripts/webkitpy/port/driver.py:
3189         (Driver.run_test): Do not destroy server process.
3190         (Driver._start): Only create the server process if it is None.
3191         (Driver.stop): Do not destroy server process.
3192
3193 2017-04-13  Dan Bernstein  <mitz@apple.com>
3194
3195         [Cocoa] Allow clients to specify in _WKProcessPoolConfiguration additional directory sandbox extensions
3196         https://bugs.webkit.org/show_bug.cgi?id=170387
3197
3198         Reviewed by Sam Weinig.
3199
3200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3201         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Added.
3202         (TEST):
3203         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Added.
3204         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3205         (-[AdditionalReadAccessAllowedURLsPlugIn dealloc]):
3206         (-[AdditionalReadAccessAllowedURLsPlugIn readStringFromURL:completionHandler:]):
3207         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Added.
3208
3209 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
3210
3211         webkitpy: Ignore previously launched pid when system is under stress
3212         https://bugs.webkit.org/show_bug.cgi?id=170741
3213
3214         Reviewed by David Kilzer.
3215
3216         We have seen cases where xcrun simctl launch will return a pid of a previous
3217         process and the process will appear to be running even though it is crashing.
3218         Ensure that the PID that simulator_process is receiving is not the pid of the
3219         previously run process.
3220
3221         * Scripts/webkitpy/port/simulator_process.py:
3222         (SimulatorProcess._start): Check to make sure we aren't receiving an old PID.
3223
3224 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
3225
3226         Build ImageDiff with host SDK
3227         https://bugs.webkit.org/show_bug.cgi?id=168531
3228
3229         Reviewed by David Kilzer.
3230
3231         ImageDiff should be built and run with the host SDK, not the target SDK.
3232         Build ImageDiff twice, once for the target SDK and once for the host
3233         as an intermediate step towards building for only the host SDK.
3234
3235         * ImageDiff/Makefile: Added.
3236         * Makefile: Add ImageDiff to list of targets.
3237         * Scripts/build-imagediff: Build bmalloc and WTF for the host.
3238         * Scripts/build-webkit: Build ImageDiff for host.
3239         * Scripts/webkitdirs.pm: Export extractNonMacOSHostConfiguration.
3240         (extractNonMacOSHostConfiguration): Remove non-host configuration data from the array.
3241         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Added.
3242         * Scripts/webkitpy/port/base.py:
3243         (Port.check_build): Attempt to build image diff if not found.
3244         (Port.check_image_diff): Enable logging flag.
3245         (Port._build_image_diff): Allow webkitpy to build image-diff during testing.
3246
3247 2017-04-12  Alex Christensen  <achristensen@webkit.org>
3248
3249         Clean up SharedBuffer public functions
3250         https://bugs.webkit.org/show_bug.cgi?id=170795
3251
3252         Reviewed by Andreas Kling.
3253
3254         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3255         (TestWebKitAPI::TEST_F):
3256
3257 2017-04-12  Dan Bernstein  <mitz@apple.com>
3258
3259         [Mac] Future-proof .xcconfig files
3260         https://bugs.webkit.org/show_bug.cgi?id=170802
3261
3262         Reviewed by Tim Horton.
3263
3264         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3265         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3266         * MiniBrowser/Configurations/Base.xcconfig:
3267         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3268         * TestWebKitAPI/Configurations/Base.xcconfig:
3269         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3270         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3271         * WebKitTestRunner/Configurations/Base.xcconfig:
3272         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3273
3274 2017-04-12  Alex Christensen  <achristensen@webkit.org>
3275
3276         Remove unused SharedBuffer::wrapCFDataArray
3277         https://bugs.webkit.org/show_bug.cgi?id=170794
3278
3279         Reviewed by Brady Eidson.
3280
3281         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
3282         (TestWebKitAPI::TEST_F):
3283
3284 2017-04-12  Yusuke Suzuki  <utatane.tea@gmail.com>
3285
3286         [WTF] Introduce Thread class and use RefPtr<Thread> and align Windows Threading implementation semantics to Pthread one
3287         https://bugs.webkit.org/show_bug.cgi?id=170502
3288
3289         Reviewed by Mark Lam.
3290
3291         Mechanical change. Use Thread:: APIs.
3292
3293         * DumpRenderTree/JavaScriptThreading.cpp:
3294         (runJavaScriptThread):
3295         (startJavaScriptThreads):
3296         (stopJavaScriptThreads):
3297         * DumpRenderTree/mac/DumpRenderTree.mm:
3298         (testThreadIdentifierMap):
3299         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3300         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3301         (TestWebKitAPI::runLockTest):
3302         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3303
3304 2017-04-12  Alex Christensen  <achristensen@webkit.org>
3305
3306         Modernize vector adoption
3307         https://bugs.webkit.org/show_bug.cgi?id=170758
3308
3309         Reviewed by Geoffrey Garen.
3310
3311         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3312         (TestWebKitAPI::TEST_F):
3313
3314 2017-04-11  Dean Jackson  <dino@apple.com>
3315
3316         Disable outdated WritableStream API
3317         https://bugs.webkit.org/show_bug.cgi?id=170749
3318         <rdar://problem/31446233>
3319
3320         Reviewed by Tim Horton.
3321
3322         The API we implement is no longer accurate. Disable it until we
3323         are compatible with the new specification
3324
3325         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3326
3327 2017-04-11  David Quesada  <david_quesada@apple.com>
3328
3329         Add SPI for handling geolocation authorization requests
3330         https://bugs.webkit.org/show_bug.cgi?id=170362
3331         rdar://problem/17508627
3332
3333         Reviewed by Alex Christensen.
3334
3335         Add API tests for the new WKUIDelegate SPI for allowing or denying websites permission
3336         to use geolocation. Adopt the new WKProcessPool._coreLocationProvider property to
3337         provide a stub object to simulate the various configurations of geolocation permissions:
3338         1. The app doesn't have permission to use geolocation.
3339         2. The app is allowed to use geolocation, but the UI delegate denies the web view permission.
3340         3. The app is allowed to use geolocation, and the UI delegate allows the web view permission.
3341
3342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3343         * TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Added.
3344         (-[TestCoreLocationProvider setListener:]):
3345         (-[TestCoreLocationProvider requestGeolocationAuthorization]):
3346         (-[TestCoreLocationProvider start]):
3347         (-[TestCoreLocationProvider stop]):
3348         (-[TestCoreLocationProvider setEnableHighAccuracy:]):
3349         (expectException):
3350         (-[GeolocationTestUIDelegate _webView:requestGeolocationAuthorizationForURL:frame:decisionHandler:]):
3351         (-[GeolocationTestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3352         (TestWebKitAPI::TEST):
3353         * TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Added.
3354
3355 2017-04-10  Matt Rajca  <mrajca@apple.com>
3356
3357         Change autoplay state to "prevented" when media is paused due to restrictions.
3358         https://bugs.webkit.org/show_bug.cgi?id=170686
3359
3360         Reviewed by Alex Christensen.
3361
3362         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3363         * TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Added test.
3364         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3365         (TEST):
3366
3367 2017-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
3368
3369         [WebCore][JSC] ResourceUsageData.{timeOfNextEdenCollection,timeOfNextFullCollection} should be MonotonicTime
3370         https://bugs.webkit.org/show_bug.cgi?id=170725
3371
3372         Reviewed by Sam Weinig.
3373
3374         * TestWebKitAPI/Tests/WTF/Time.cpp:
3375         (TestWebKitAPI::TEST):
3376
3377 2017-04-10  Alex Christensen  <achristensen@webkit.org>
3378
3379         Revert r215217
3380         https://bugs.webkit.org/show_bug.cgi?id=170703
3381
3382         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3383
3384 2017-04-10  Alex Christensen  <achristensen@webkit.org>
3385
3386         Continue enabling WebRTC
3387         https://bugs.webkit.org/show_bug.cgi?id=170703
3388
3389         Reviewed by Youenn Fablet.
3390
3391         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3392
3393 2017-04-10  Kocsen Chung  <kocsen_chung@apple.com>
3394
3395         Have parseRevisionProperty use default repo name as the Buildbot key.
3396         https://bugs.webkit.org/show_bug.cgi?id=170696
3397
3398         Reviewed by Daniel Bates.
3399
3400         Previously, we needed to set a key and a fallbackKey when addressing
3401         Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
3402         that the repo name maps exactly to that key for every repository other
3403         than WebKit.
3404
3405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3406         Set `key = repositoryName` and only use fallback keys when dealing with WebKit.
3407
3408 2017-04-10  Aakash Jain  <aakash_jain@apple.com>
3409
3410         Add test262 JavaScriptCore tests to dashboard
3411         https://bugs.webkit.org/show_bug.cgi?id=170711
3412
3413         Rubber-stamped by Joseph Pecoraro.
3414
3415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3416         (WebKitBuildbot): Added test262 JSC tests to dashboard.
3417
3418 2017-04-10  Alex Christensen  <achristensen@webkit.org>
3419
3420         REGRESSION(r195479) First main resource load in new WebProcess bypasses content extensions
3421         https://bugs.webkit.org/show_bug.cgi?id=170707
3422         <rdar://problem/27788755>
3423
3424         Reviewed by Tim Horton.
3425
3426         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
3427         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3428         (TEST_F):
3429         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3430         (-[ContentBlockingWebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3431         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3432         (TEST):
3433
3434 2017-04-10  Alex Christensen  <achristensen@webkit.org>
3435
3436         Add API to get available content extension identifiers in a WKContentExtensionStore
3437         https://bugs.webkit.org/show_bug.cgi?id=170093
3438
3439         Reviewed by Geoffrey Garen.
3440
3441         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
3442         (TEST_F):
3443
3444 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3445
3446         Refactor DataInteractionTests.UnresponsivePageDoesNotHangUI to not check against a fixed time interval
3447         https://bugs.webkit.org/show_bug.cgi?id=170658
3448
3449         Reviewed by Tim Horton.
3450
3451         Uses ignoreSynchronousMessagingTimeoutsForTesting to ensure that this test times out if data interaction
3452         preparation is synchronous, or passes if it is asynchronous.
3453
3454         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3455         (TestWebKitAPI::TEST):
3456         * TestWebKitAPI/cocoa/TestWKWebView.h:
3457         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3458         (-[TestWKWebView initWithFrame:]):
3459         (-[TestWKWebView initWithFrame:configuration:processPoolConfiguration:]):
3460         (-[TestWKWebView _setUpTestWindow:]):
3461
3462 2017-04-10  Brent Fulgham  <bfulgham@apple.com>
3463
3464         [WK2][macOS] Block access to Apple Events before launch.
3465         https://bugs.webkit.org/show_bug.cgi?id=170626
3466         <rdar://problem/16079334>
3467
3468         Reviewed by Alexey Proskuryakov.
3469
3470         Add a new TestWebKitAPI test that fails if Apple Events are sent.
3471
3472         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3473         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Added.
3474         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3475         (TestWebKitAPI::didFinishLoadForFrame):
3476         (TestWebKitAPI::TEST):
3477         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Added.
3478         (TestWebKitAPI::InjectedBundleAppleEventTest::InjectedBundleAppleEventTest):
3479         (TestWebKitAPI::InjectedBundleAppleEventTest::didCreatePage):
3480
3481 2017-04-10  Guillaume Emont  <guijemont@igalia.com>
3482
3483         [JSC] Do not run FTL stress tests on MIPS
3484         https://bugs.webkit.org/show_bug.cgi?id=170684
3485
3486         Reviewed by Carlos Alberto Lopez Perez.
3487
3488         run-jsc-stress-tests does not correctly detect MIPS platforms, and its
3489         logic to detect if the platform supports FTL ignores that MIPS does
3490         not support FTL. This adds detection of MIPS (with the magic number
3491         determined empirically) and fixes the determination of whether we
3492         support FTL.
3493
3494         * Scripts/run-jsc-stress-tests:
3495
3496 2017-04-10  Jonathan Bedard  <jbedard@apple.com>
3497
3498         webkitpy: Increase estimate for processes run by iOS Simulators
3499         https://bugs.webkit.org/show_bug.cgi?id=170678
3500         <rdar://problem/31534061>
3501
3502         Reviewed by Aakash Jain.
3503
3504         Previously, it was estimated that each simulated iOS device would run about 100
3505         processes.  With newer versions of iOS, this is closer to 125.
3506
3507         * Scripts/webkitpy/port/ios_simulator.py:
3508         (IOSSimulatorPort): Increase process estimate from 100 to 125.
3509
3510 2017-04-10  Adrian Perez de Castro  <aperez@igalia.com>
3511
3512         [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
3513         https://bugs.webkit.org/show_bug.cgi?id=170553
3514
3515         Reviewed by Michael Catanzaro.
3516
3517         Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when
3518         building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend
3519         to properly position popup menus, and also avoids using functions
3520         which were deprecated starting at that GTK+ release.
3521
3522         * MiniBrowser/gtk/BrowserSearchBar.c:
3523         (searchEntryMenuIconPressedCallback):
3524         Update MiniBrowser to use gtk_menu_popup_at_pointer().
3525
3526 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3527
3528         REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing
3529         https://bugs.webkit.org/show_bug.cgi?id=170677
3530         <rdar://problem/31512633>
3531
3532         Reviewed by Tim Horton.
3533
3534         Fixes two drag and drop LayoutTests by introducing and enabling a TestOptions switch (enableDragDestinationActionLoad)
3535         to allow dropping URLs to trigger page navigation.
3536
3537         * DumpRenderTree/TestOptions.h:
3538         * DumpRenderTree/TestOptions.mm:
3539         (TestOptions::TestOptions):
3540         * DumpRenderTree/mac/DumpRenderTree.mm:
3541         (resetWebViewToConsistentStateBeforeTesting):
3542         * DumpRenderTree/mac/UIDelegate.h:
3543         * DumpRenderTree/mac/UIDelegate.mm:
3544         (-[UIDelegate resetToConsistentStateBeforeTesting:]):
3545         (-[UIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
3546
3547 2017-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3548
3549         update-webkit-dependency should report $response->message for diagnose
3550         https://bugs.webkit.org/show_bug.cgi?id=170666
3551
3552         Reviewed by Alex Christensen.
3553
3554         * Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.
3555
3556 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3557
3558         Data interaction on an image enclosed by an anchor should vend the anchor's URL
3559         https://bugs.webkit.org/show_bug.cgi?id=170660
3560         <rdar://problem/31043220>
3561
3562         Reviewed by Tim Horton.
3563
3564         Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
3565         anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
3566         should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
3567         rects, but should not be.
3568
3569         See WebCore ChangeLog for more details.
3570
3571         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3572         * TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
3573         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3574         (TestWebKitAPI::TEST):
3575
3576 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3577
3578         [GTK] Remove the GDK dependency from ImageDiff
3579         https://bugs.webkit.org/show_bug.cgi?id=85299
3580
3581         Reviewed by Žan Doberšek.
3582
3583         Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
3584         Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
3585         actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
3586         ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
3587         implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
3588         and also add CG implementation.
3589
3590         * ImageDiff/CMakeLists.txt:
3591         * ImageDiff/Cairo.cmake: Added.
3592         * ImageDiff/ImageDiff.cpp: Added.
3593         (main):
3594         * ImageDiff/PlatformGTK.cmake:
3595         * ImageDiff/PlatformImage.cpp: Added.
3596         (ImageDiff::PlatformImage::isCompatible):
3597         (ImageDiff::PlatformImage::difference):
3598         * ImageDiff/PlatformImage.h: Added.
3599         * ImageDiff/cairo/PlatformImageCairo.cpp: Added.
3600         (ImageDiff::PlatformImage::createFromStdin):
3601         (ImageDiff::PlatformImage::createFromDiffData):
3602         (ImageDiff::PlatformImage::PlatformImage):
3603         (ImageDiff::PlatformImage::~PlatformImage):
3604         (ImageDiff::PlatformImage::width):
3605         (ImageDiff::PlatformImage::height):
3606         (ImageDiff::PlatformImage::rowBytes):
3607         (ImageDiff::PlatformImage::hasAlpha):
3608         (ImageDiff::PlatformImage::pixels):
3609         (ImageDiff::PlatformImage::writeAsPNGToStdout):
3610         * ImageDiff/gtk/ImageDiff.cpp: Removed.
3611
3612 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3613
3614         REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
3615         https://bugs.webkit.org/show_bug.cgi?id=170667
3616
3617         Reviewed by Žan Doberšek.
3618
3619         In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
3620         that value.
3621
3622         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3623         (WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
3624
3625 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3626
3627         WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
3628         https://bugs.webkit.org/show_bug.cgi?id=170653
3629
3630         Reviewed by Tim Horton.
3631
3632         When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage,
3633         which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the
3634         platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web
3635         snapshot from TestInvocation::dumpPixelsAndCompareWithExpected().
3636
3637         * WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage().
3638         * WebKitTestRunner/TestInvocation.cpp:
3639         (WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel
3640         results were created in the web process.
3641         * WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected().
3642         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: