platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityCont...
[WebKit-https.git] / Tools / ChangeLog
1 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
2
3         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
4         https://bugs.webkit.org/show_bug.cgi?id=127141
5
6         Reviewed by Alexey Proskuryakov.
7
8         Make sure to reset the notification handler each time.
9
10         * DumpRenderTree/AccessibilityController.cpp:
11         (AccessibilityController::resetToConsistentState):
12         * DumpRenderTree/AccessibilityController.h:
13         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
14         (AccessibilityController::platformResetToConsistentState):
15         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
16         (AccessibilityController::platformResetToConsistentState):
17         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
18         (AccessibilityController::~AccessibilityController):
19         (AccessibilityController::platformResetToConsistentState):
20         (AccessibilityController::removeNotificationListener):
21         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
22         (AccessibilityController::platformResetToConsistentState):
23
24 2014-01-17  Alberto Garcia  <berto@igalia.com>
25
26         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
27         https://bugs.webkit.org/show_bug.cgi?id=82329
28
29         Reviewed by Carlos Garcia Campos.
30
31         Unskip, this is working fine now.
32
33         * Scripts/run-gtk-tests:
34         (TestRunner):
35
36 2014-01-17  Alberto Garcia  <berto@igalia.com>
37
38         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
39         https://bugs.webkit.org/show_bug.cgi?id=82328
40
41         Reviewed by Carlos Garcia Campos.
42
43         This was caused by the icon database being corrupted in the
44         Release bot. After removing it the test works fine so it can be
45         run again.
46
47         * Scripts/run-gtk-tests:
48         (TestRunner):
49
50 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
51
52         Test results popovers at http://build.webkit.org/dashboard should link to stderr
53         https://bugs.webkit.org/show_bug.cgi?id=126929
54
55         Reviewed by Timothy Hatcher.
56
57         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
58         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
59         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
60
61         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
62         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
63
64         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
65         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
66         Add a link to stderr output if present.
67
68         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
69         (.test-results-popover .additional-link): Style with light grey (will use the same style
70         for diff links).
71
72 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
73
74         Automate DoYouEvenBench
75         https://bugs.webkit.org/show_bug.cgi?id=124497
76
77         Reviewed by Geoffrey Garen.
78
79         * Scripts/webkitpy/performance_tests/perftest.py:
80         (PerfTestMetric.__init__): Added the aggregator name as an argument.
81         (PerfTestMetric.aggregator): Added.
82         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
83         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
84         should be parsed as the metric and the aggregator respectively.
85         (PerfTest._run_with_driver): Pass in the aggregator name.
86         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
87         which generates subtests of subtests within a single test file.
88
89         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
90         (test_parse_output_with_subtests_and_total): Added.
91
92         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
93         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
94
95         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
96         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
97
98 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
99
100         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
101         https://bugs.webkit.org/show_bug.cgi?id=127141
102
103         Reviewed by Alexey Proskuryakov.
104
105         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
106
107         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
108         (AccessibilityController::~AccessibilityController):
109
110 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
111
112         EWS shouldn't comment on Bugzilla for failing builds or style errors
113         https://bugs.webkit.org/show_bug.cgi?id=127079
114
115         Reviewed by Anders Carlsson.
116
117         Since patch authors and reviewers could retrieve this information from bubbles,
118         we shouldn't spam the Bugzilla with useless comments.
119
120         We still post style errors but not python paths we used since it's a pure noise.
121
122         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
123         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
124         * Scripts/webkitpy/tool/commands/queues.py:
125         (StyleQueue.review_patch):
126
127 2014-01-15  Roger Fong  <roger_fong@apple.com>
128
129         Add support for handling WebGL load policies.
130         https://bugs.webkit.org/show_bug.cgi?id=126935
131         <rdar://problem/15790448>.
132
133         Reviewed by Timothy Horton.
134
135         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
136         (WTR::TestController::createWebViewWithOptions):
137
138 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
139
140         Remove workaround for compilers not supporting explicit override control
141         https://bugs.webkit.org/show_bug.cgi?id=127111
142
143         Reviewed by Anders Carlsson.
144
145         Now all compilers support explicit override control, this workaround can be removed.
146
147         * DumpRenderTree/gtk/fonts/fonts.conf:
148         * Scripts/do-webcore-rename:
149         Removed this rename operation from the list of contemplated future renames.
150         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
151         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
152         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
153         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
154         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
155
156 2014-01-16  Oliver Hunt  <oliver@apple.com>
157
158         Stop run-jsc from consuming stderr output
159         https://bugs.webkit.org/show_bug.cgi?id=127115
160
161         Reviewed by Mark Lam.
162
163         Simple patch to make run-jsc easier to deal with
164
165         * Scripts/run-jsc:
166
167 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
168
169         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
170         https://bugs.webkit.org/show_bug.cgi?id=126323
171
172         Reviewed by Csaba Osztrogonác.
173
174         * gtk/generate-feature-defines-files:
175
176 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
177
178         [EFL][WK2] Implement TestController::setHidden
179         https://bugs.webkit.org/show_bug.cgi?id=127036
180
181         Reviewed by Gyuyoung Kim.
182
183         WebKitTestRunner needs TestController::setHidden implementation to
184         properly handle page visibility API layout tests after r161105.
185
186         * WebKitTestRunner/efl/TestControllerEfl.cpp:
187         (WTR::TestController::setHidden):
188
189 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
190
191         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
192         https://bugs.webkit.org/show_bug.cgi?id=127083
193
194         Reviewed by Carlos Garcia Campos.
195
196         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
197         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
198
199         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
200         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
201         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
202         BrowserWindow object is being finalized, preventing the callback from firing.
203
204         * MiniBrowser/gtk/BrowserWindow.c:
205         (resetEntryProgress):
206         (webViewLoadProgressChanged):
207         (browserWindowFinalize):
208
209 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
210
211         DumpRenderTree doesn't disable web preferences autosave
212         https://bugs.webkit.org/show_bug.cgi?id=127062
213
214         Reviewed by Dan Bernstein.
215
216         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
217         Do it.
218
219 2014-01-15  Dean Jackson  <dino@apple.com>
220
221         Improve filter-build-webkit, especially for iOS builds
222         https://bugs.webkit.org/show_bug.cgi?id=81046
223
224         Reviewed by Joseph Pecoraro.
225
226         Lots of updates to the filtering rules, mostly from the
227         iOS build output. Other highlights include:
228         - ignoring escape sequences for color ouput
229         - detecting escaped spaces in file name regexps
230
231         * Scripts/filter-build-webkit:
232         (shouldIgnoreLine):
233
234 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
235
236         [GTK] Web process sometimes crashes when printing in synchronous mode
237         https://bugs.webkit.org/show_bug.cgi?id=126979
238
239         Reviewed by Gustavo Noronha Silva.
240
241         * Scripts/run-gtk-tests:
242         (TestRunner): Unskip
243         /webkit2/WebKitPrintOperation/close-after-print.
244
245 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
246
247         [EFL] Change test font installed path to webkitgtk-font-tests
248         https://bugs.webkit.org/show_bug.cgi?id=126723
249
250         Reviewed by Gyuyoung Kim.
251
252         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
253         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
254         hard-coded in FontManagement.cpp#105
255
256         * DumpRenderTree/PlatformEfl.cmake:
257         * WebKitTestRunner/PlatformEfl.cmake:
258         * efl/jhbuild.modules:
259
260 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
261
262         Make DoYouEvenBench runnable by run-perf-tests
263         https://bugs.webkit.org/show_bug.cgi?id=127030
264
265         Reviewed by Andreas Kling.
266
267         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
268         ":Total" to appear at the end of a test name. We don't do anything with it for now.
269
270         * Scripts/webkitpy/performance_tests/perftest.py:
271         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
272         to the JSON in a follow up patch for the perf dashboard.
273         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
274
275 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
276
277         [GTK] UI process crashes when the web process crashes while printing
278         https://bugs.webkit.org/show_bug.cgi?id=126977
279
280         Reviewed by Gustavo Noronha Silva.
281
282         Add new test case to check that closing the window right after
283         printing works. It's skipped for now, because this patch only
284         fixes the UI process crash, but not the web process one.
285
286         * Scripts/run-gtk-tests:
287         (TestRunner): Skip
288         /webkit2/WebKitPrintOperation/close-after-print.
289         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
290         (testPrintOperationPrintPrinter):
291         (findPrintToFilePrinter):
292         (testPrintOperationPrint):
293         (testPrintOperationErrors):
294         (testPrintOperationCloseAfterPrint):
295         (beforeAll):
296
297 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
298
299         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
300         https://bugs.webkit.org/show_bug.cgi?id=127002
301
302         Reviewed by David Kilzer.
303
304         * Scripts/webkitdirs.pm:
305         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
306
307 2014-01-14  Commit Queue  <commit-queue@webkit.org>
308
309         Unreviewed, rolling out r162000.
310         http://trac.webkit.org/changeset/162000
311         https://bugs.webkit.org/show_bug.cgi?id=127009
312
313         API versioning is wrong (Requested by rfong on #webkit).
314
315         * MiniBrowser/mac/WK2BrowserWindowController.m:
316         (-[WK2BrowserWindowController awakeFromNib]):
317         * WebKitTestRunner/TestController.cpp:
318         (WTR::TestController::createOtherPage):
319         (WTR::TestController::createWebViewWithOptions):
320
321 2014-01-13  Roger Fong  <roger_fong@apple.com>
322
323         Add support for handling WebGL load policies.
324         https://bugs.webkit.org/show_bug.cgi?id=126935
325         <rdar://problem/15790448>.
326
327         Reviewed by Brent Fulgham.
328
329         * MiniBrowser/mac/WK2BrowserWindowController.m:
330         (-[WK2BrowserWindowController awakeFromNib]):
331         * WebKitTestRunner/TestController.cpp:
332         (WTR::TestController::createWebViewWithOptions):
333
334 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
335
336         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
337         https://bugs.webkit.org/show_bug.cgi?id=120110
338
339         Reviewed by Martin Robinson.
340
341         Skip the FontConfig settings initialization in WebKitTestRunner if the
342         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
343         This is useful when profiling the WebKitTestRunner execution, where at the startup
344         this step takes considerable amount of time and disturbs the profiling output.
345
346         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
347         (WTR::initializeFontConfigSetting):
348
349 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
350
351         Add ENABLE(WEB_REPLAY) feature flag to the build system
352         https://bugs.webkit.org/show_bug.cgi?id=126949
353
354         Reviewed by Joseph Pecoraro.
355
356         * Scripts/webkitperl/FeatureList.pm:
357
358 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
359
360         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
361         https://bugs.webkit.org/show_bug.cgi?id=126702
362
363         Reviewed by Alexey Proskuryakov.
364
365         Resolve regression and remove a FIXME comment that is already fixed.
366
367         * Scripts/webkitpy/common/system/filesystem.py:
368         (FileSystem.open_text_file_for_reading):
369         * Scripts/webkitpy/common/system/filesystem_unittest.py:
370         (RealFileSystemTest.test_read_and_write_file):
371         * Scripts/webkitpy/style/filereader.py:
372         (TextFileReader._read_lines):
373         * Scripts/webkitpy/style/filereader_unittest.py:
374         (TextFileReaderTest.test_count_delete_only_file):
375         (TextFileReaderTest):
376         (TextFileReaderTest.test_process_malformed_file):
377
378 2014-01-02  Brian Holt  <brian.holt@samsung.com>
379
380         [GTK] Parse Valgrind xml leak files
381         https://bugs.webkit.org/show_bug.cgi?id=119446
382
383         Reviewed by Alejandro G. Castro.
384
385         Parse the xml files generated by Valgrind to yield useful
386         information about the memory leaks.
387
388         * Scripts/webkitpy/port/gtk.py:
389         (GtkPort.__init__):
390         (GtkPort.setup_test_run): Clear the previous output files before new
391         run.
392         (GtkPort.print_leaks_summary):
393
394         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
395         Parse the xml files generated by Valgrind and summarise leaks
396         into an easily understandable list.
397         (get_text_of):
398         (get_CDATA_of):
399         (gather_frames):
400         (ValgrindError):
401         (ValgrindError.__init__):
402         (ValgrindError.__str__):
403         (ValgrindError.unique_string):
404         (ValgrindError.error_hash):
405         (ValgrindError.__hash__):
406         (ValgrindError.__eq__):
407         (LeakDetectorValgrind):
408         (LeakDetectorValgrind.__init__):
409         (LeakDetectorValgrind._parse_leaks_output):
410         (LeakDetectorValgrind.leaks_files_in_results_directory):
411         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
412         (LeakDetectorValgrind.parse_and_print_leaks_detail):
413
414         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
415         (make_mock_valgrind_output):
416         (make_mock_incomplete_valgrind_output):
417         (make_mock_valgrind_results):
418         (make_mock_valgrind_results_incomplete):
419         (make_mock_valgrind_results_empty):
420         (make_mock_valgrind_results_misformatted):
421         (mock_run_cppfilt_command):
422         (LeakDetectorValgrindTest):
423         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
424         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
425         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
426         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
427         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
428         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
429         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
430         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
431
432 2014-01-13  Lucas Forschler  <lforschler@apple.com>
433
434         Update the LLINT CLoop Bot build infrastructure
435         https://bugs.webkit.org/show_bug.cgi?id=126604
436         
437         Unreviewed.
438         
439         * BuildSlaveSupport/build.webkit.org-config/config.json:
440         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
441         (CompileLLINTCLoop):
442         (RunLLINTCLoopTests):
443         (BuildAndTestLLINTCLoopFactory):
444         (BuildAndTestLLINTCLoopFactory.__init__):
445
446 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
447
448         [EFL][WK2] Disable failing API tests
449         https://bugs.webkit.org/show_bug.cgi?id=126960
450
451         Reviewed by Gyuyoung Kim.
452
453         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
454
455         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
456         (TestWebKitAPI::TEST):
457
458 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
459
460         Remove wdiff
461         https://bugs.webkit.org/show_bug.cgi?id=124766
462
463         Reviewed by Ryosuke Niwa.
464
465         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
466         (ResultsJSONParserTest):
467         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
468         (TestResultWriter):
469         (TestResultWriter.create_text_diff_and_write_result):
470         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
471         (summarize_results):
472         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
473         (RunTest.test_output_diffs):
474         * Scripts/webkitpy/port/base.py:
475         (Port.__init__):
476         (Port.driver_stop_timeout):
477         (Port.check_image_diff):
478         (Port.repository_paths):
479         (Port._path_to_lighttpd_php):
480         * Scripts/webkitpy/port/base_unittest.py:
481         (PortTest.test_default_child_processes):
482         (PortTest.test_pretty_patch_script_error):
483         * Scripts/webkitpy/port/port_testcase.py:
484         (PortTestCase.test_diff_image_crashed):
485         * Scripts/webkitpy/port/test.py:
486         (TestPort.operating_system):
487
488 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
489
490         Build fix for the GTK+ CMake port
491
492         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
493
494 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
495
496         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
497         https://bugs.webkit.org/show_bug.cgi?id=126881
498
499         Reviewed by Carlos Garcia Campos.
500
501         * MiniBrowser/gtk/BrowserWindow.c:
502         (browser_window_new):
503         Explicitly cast GtkWindow** to gpointer* in call to
504         g_object_add_weak_pointer to avoid compiler warnings.
505
506 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
507
508         Remove parsing of old-run-webkit-tests output from master.cfg
509         https://bugs.webkit.org/show_bug.cgi?id=126690
510
511         Reviewed by Csaba Osztrogonác.
512
513         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
514         Removed parsing of ORWT output, as it is not used anymore.
515         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
516         Updated unit tests accordingly.
517
518 2014-01-13  Commit Queue  <commit-queue@webkit.org>
519
520         Unreviewed, rolling out r161808.
521         http://trac.webkit.org/changeset/161808
522         https://bugs.webkit.org/show_bug.cgi?id=126874
523
524         This patch make several files to be always regenerated on
525         every make (Requested by KaL on #webkit).
526
527         * WebKitTestRunner/GNUmakefile.am:
528
529 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
530
531         [GTK] Make MiniBrowser windows non-transient by default
532         https://bugs.webkit.org/show_bug.cgi?id=126840
533
534         Reviewed by Carlos Garcia Campos.
535
536         Instead of making new browser windows transient as soon as they are
537         created, save the pointer to the parent window and set the transient
538         state later on when handling the "run-as-modal" signal. This makes
539         it easier to use the MiniBrowser to do tests involving multiple
540         windows, and will be useful as well when multi-web-process mode is
541         enabled for the GTK port.
542
543         * MiniBrowser/gtk/BrowserWindow.c:
544         (webViewRunAsModal): Set the parent window using
545         gtk_window_set_transient_for() using the saved parent
546         window.
547         (browser_window_new): Save the parent window using
548         g_object_set_data() instead of making the new window
549         transient immediately.
550
551 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
552
553         [EFL][WK2] Make API tests work again
554         https://bugs.webkit.org/show_bug.cgi?id=126769
555
556         Reviewed by Gyuyoung Kim.
557
558         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
559         [E]WebKit2, respectively, and this causes problems because the logic to find
560         where WebProcess is to look in the same directory of the running process and
561         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
562
563         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
564         Gtk port, which allows us to look for WebProcess initially in this directory,
565         if it's defined.
566
567         * TestWebKitAPI/efl/main.cpp:
568         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
569
570 2014-01-12  Daniel Bates  <dabates@apple.com>
571
572         [iOS] Fix the build
573
574         For now, ensure we build WebKit System Interface before we build WebKit.
575         We'll remove this constraint and the constraint to build WebKit Additions
576         in a subsequent commit.
577
578         * Scripts/build-webkit:
579
580 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
581
582         Unreviewed. Fix make distcheck.
583
584         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
585         to EXTRA_DIST.
586
587 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
588
589         --disable-dependency-tracking causes build failure due to missing directories
590         https://bugs.webkit.org/show_bug.cgi?id=94488
591
592         Reviewed by Gustavo Noronha Silva.
593
594         Autotools build fix: Ensure output directory existing
595         before generating DerivedSources. This allows for
596         --disable-dependency-tracking to be run.
597
598
599         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
600
601 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
602
603         [GTK] Fix return value of WebKitDownload::created-destination
604         https://bugs.webkit.org/show_bug.cgi?id=126741
605
606         Reviewed by Martin Robinson.
607
608         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
609         value of several callbacks.
610
611 2014-01-11  Sam Weinig  <sam@webkit.org>
612
613         Add support for null StringViews
614         https://bugs.webkit.org/show_bug.cgi?id=126827
615
616         Reviewed by Anders Carlsson.
617
618         Add new test for StringView.
619
620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
621         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
622         (TestWebKitAPI::TEST):
623
624 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
625
626         Remove the BlackBerry port from trunk
627         https://bugs.webkit.org/show_bug.cgi?id=126715
628
629         Reviewed by Anders Carlsson.
630
631         * DumpRenderTree/DumpRenderTree.h:
632         * DumpRenderTree/PixelDumpSupport.cpp:
633
634 2014-01-10  Daniel Bates  <dabates@apple.com>
635
636         [iOS] Fix project build order
637
638         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
639         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
640         time of writing.
641
642         * Scripts/build-webkit:
643
644 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
645
646         Move platformName property from testRunner to accessibilityController
647         https://bugs.webkit.org/show_bug.cgi?id=126689
648
649         Reviewed by Chris Fleizach.
650
651         Move the platformName property from the testRunner into
652         accessibilityController, since this is a concept that has only be
653         used by accessibility tests since it got added, and also because
654         the real intention was not to distinguish among "ports" (mac, win,
655         gtk, efl) but between platforms (atk, mac, win).
656
657         This change will be very useful to merge GTK's roles-exposed.html
658         and Mac's role-subrole-roledescription.html into one single test,
659         since we will be specifying in the test itself which elements are
660         supported in which accessibility "platform". In this context,
661         being able to check accessibilityController.platformName directly
662         against a list of supported accessibility platforms (e.g. "atk,mac")
663         will certainly maintain the code cleaner and simpler.
664
665         * DumpRenderTree/TestRunner.h:
666         (TestRunner::platformName): Removed.
667         * DumpRenderTree/TestRunner.cpp:
668         (getPlatformNameCallback): Removed.
669         (TestRunner::staticValues): Removed platformName
670         * DumpRenderTree/efl/TestRunnerEfl.cpp:
671         (TestRunner::platformName): Removed.
672         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
673         (TestRunner::platformName): Removed.
674         * DumpRenderTree/mac/TestRunnerMac.mm:
675         (TestRunner::platformName): Removed.
676         * DumpRenderTree/win/TestRunnerWin.cpp:
677         (TestRunner::platformName): Removed.
678
679         * DumpRenderTree/AccessibilityController.h:
680         (AccessibilityController::platformName): Added.
681         * DumpRenderTree/AccessibilityController.cpp:
682         (getPlatformNameCallback): Added.
683         (AccessibilityController::getJSClass): Added platformName.
684         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
685         (AccessibilityController::platformName): Added, returning "atk".
686         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
687         (AccessibilityController::platformName): Ditto, returning "mac".
688         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
689         (AccessibilityController::platformName): Ditto, returning "ios".
690         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
691         (AccessibilityController::platformName): Ditto, returning "win".
692
693         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
694         (platformName): Removed.
695         * WebKitTestRunner/InjectedBundle/TestRunner.h:
696         (TestRunner::platformName): Removed.
697         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
698         (TestRunner::platformName): Removed.
699         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
700         (TestRunner::platformName): Removed.
701         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
702         (TestRunner::platformName): Removed.
703         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
704         (TestRunner::platformName): Removed.
705
706         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
707         (WTR:AccessibilityController::platformName): Added.
708         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
709         (platformName): Added.
710         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
711         (WTR::AccessibilityController::platformName): Added, returning "atk".
712         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
713         (WTR::AccessibilityController::platformName): Added, returning "mac".
714
715 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
716
717         Remove the BlackBerry port from trunk
718         https://bugs.webkit.org/show_bug.cgi?id=126715
719
720         Reviewed by Anders Carlsson.
721
722         * Scripts/webkitpy/common/config/watchlist:
723
724 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
725
726         Remove the BlackBerry files outside WebCore
727         https://bugs.webkit.org/show_bug.cgi?id=126715
728
729         Reviewed by Anders Carlsson.
730
731         * DumpRenderTree/blackberry: Removed.
732
733 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
734
735         Remove knowledge of Blackberry from build scripts
736         https://bugs.webkit.org/show_bug.cgi?id=126766
737
738         Reviewed by Anders Carlsson.
739         
740         Remove isBlackBerry() and references to it, and rmeove
741         blackberry-related stuff from the watchlist.
742
743         * Scripts/build-webkit:
744         * Scripts/webkit-build-directory:
745         * Scripts/webkitdirs.pm:
746         (determineBaseProductDir):
747         (argumentsForConfiguration):
748         (builtDylibPathForName):
749         (isAppleWebKit):
750         (buildCMakeProjectOrExit):
751         (cmakeBasedPortArguments):
752         (cmakeBasedPortName):
753         * Scripts/webkitperl/FeatureList.pm:
754         * Scripts/webkitpy/common/config/watchlist:
755
756 2014-01-10  Daniel Bates  <dabates@apple.com>
757
758         [iOS] Fix up simulator build and enable default features
759
760         Rubber-stamped by Joseph Pecoraro.
761
762         * Scripts/webkitdirs.pm:
763         (determineArchitecture):
764         (determinePassedArchitecture):
765         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
766         by default only in iOS).
767
768 2014-01-10  Daniel Bates  <dabates@apple.com>
769
770         [iOS] Upstream WebCore and Tools miscellaneous changes
771         https://bugs.webkit.org/show_bug.cgi?id=126698
772
773         Reviewed by David Kilzer.
774
775         * Scripts/check-for-inappropriate-objc-class-names:
776         * Scripts/check-for-webkit-framework-include-consistency:
777
778 2014-01-09  Dan Bernstein  <mitz@apple.com>
779
780         [Cocoa] Promote WKBackForwardList{,Item}.h to public
781         https://bugs.webkit.org/show_bug.cgi?id=126707
782
783         Reviewed by Sam Weinig.
784
785         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
786         left behind in the build products directory after a private header is made public.
787
788 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
789
790         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
791         https://bugs.webkit.org/show_bug.cgi?id=126686
792
793         Reviewed by Martin Robinson.
794
795         Test that partial files are not left on disk after a download has
796         been cancelled after the destination has been decided. To make
797         sure the download is cancelled after the destination has been
798         decided and before the operation finishes, we cancel the download
799         in the destination decided callback, and we use an infinite
800         resource that writes chunks to the response body and never
801         completes the body.
802
803         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
804         (addContentDispositionHTTPHeaderToResponse): Helper function to
805         add the Content-Disposition to the response headers.
806         (writeNextChunkIdle): Write next chunk to response body.
807         (writeNextChunk): Write next chunk in an idle to avoid flooding
808         the network with the inifnite resource.
809         (serverCallback): Add an inifinite resource.
810         (testDownloadRemoteFileError): Check that partial file is not
811         present after the download has been cancelled.
812
813 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
814
815         Move myself to the committers list.
816
817         Unreviewed.
818
819         * Scripts/webkitpy/common/config/contributors.json:
820
821 2014-01-08  Seokju Kwon  <seokju@webkit.org>
822
823         [GTK] Unreviewed build fix after r161522.
824
825         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
826
827 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
828
829         Missleading style error when mixing system and non-system header include lines.
830         https://bugs.webkit.org/show_bug.cgi?id=126564
831
832         Reviewed by Ryosuke Niwa.
833
834         * Scripts/webkitpy/style/checkers/cpp.py:
835         (check_include_line):
836         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
837         (OrderOfIncludesTest.test_check_alphabetical_include_order):
838         (OrderOfIncludesTest.test_public_primary_header):
839
840 2014-01-08  Seokju Kwon  <seokju@webkit.org>
841
842         [EFL] Unreviewed build fix after r161522.
843
844         * TestWebKitAPI/CMakeLists.txt:
845         * TestWebKitAPI/PlatformEfl.cmake:
846
847 2014-01-08  Anders Carlsson  <andersca@apple.com>
848
849         Remove WKConnectionRef tests
850         https://bugs.webkit.org/show_bug.cgi?id=126666
851
852         Reviewed by Dan Bernstein.
853
854         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
855         Remove the API tests as a first step towards killing the entire thing.
856
857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
858         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
859         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
860
861 2014-01-08  Commit Queue  <commit-queue@webkit.org>
862
863         Unreviewed, rolling out r161512.
864         http://trac.webkit.org/changeset/161512
865         https://bugs.webkit.org/show_bug.cgi?id=126655
866
867         Broke webkitpy tests (Requested by ap on #webkit).
868
869         * Scripts/webkitpy/port/gtk.py:
870         (GtkPort.__init__):
871         (GtkPort.setup_test_run):
872         (GtkPort._port_specific_expectations_files):
873         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
874         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
875
876 2014-01-08  Commit Queue  <commit-queue@webkit.org>
877
878         Unreviewed, rolling out r161517.
879         http://trac.webkit.org/changeset/161517
880         https://bugs.webkit.org/show_bug.cgi?id=126659
881
882         The fix didn't completely remove the problem and is now
883         standing in the way of the rollout of the offending patch
884         (Requested by zdobersek on #webkit).
885
886         * Scripts/webkitpy/port/gtk.py:
887         (GtkPort.__init__):
888
889 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
890
891         Unreviewed. Attempting to fix webkitpy tests after r161512.
892
893         * Scripts/webkitpy/port/gtk.py:
894         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
895
896 2014-01-08  Brian Holt  <brian.holt@samsung.com>
897
898         [GTK] Parse Valgrind xml leak files
899         https://bugs.webkit.org/show_bug.cgi?id=119446
900
901         Reviewed by Alejandro G. Castro.
902
903         Parse the xml files generated by Valgrind to yield useful
904         information about the memory leaks.
905
906         * Scripts/webkitpy/port/gtk.py:
907         (GtkPort.__init__):
908         (GtkPort.setup_test_run): Clear the previous output files before new
909         run.
910         (GtkPort.print_leaks_summary):
911
912         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
913         Parse the xml files generated by Valgrind and summarise leaks
914         into an easily understandable list.
915         (get_text_of):
916         (get_CDATA_of):
917         (gather_frames):
918         (ValgrindError):
919         (ValgrindError.__init__):
920         (ValgrindError.__str__):
921         (ValgrindError.unique_string):
922         (ValgrindError.error_hash):
923         (ValgrindError.__hash__):
924         (ValgrindError.__eq__):
925         (LeakDetectorValgrind):
926         (LeakDetectorValgrind.__init__):
927         (LeakDetectorValgrind._parse_leaks_output):
928         (LeakDetectorValgrind.leaks_files_in_results_directory):
929         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
930         (LeakDetectorValgrind.parse_and_print_leaks_detail):
931
932         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
933         (make_mock_valgrind_output):
934         (make_mock_incomplete_valgrind_output):
935         (make_mock_valgrind_results):
936         (make_mock_valgrind_results_incomplete):
937         (make_mock_valgrind_results_empty):
938         (make_mock_valgrind_results_misformatted):
939         (LeakDetectorValgrindTest):
940         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
941         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
942         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
943         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
944         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
945         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
946         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
947         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
948
949 2014-01-08  Commit Queue  <commit-queue@webkit.org>
950
951         Unreviewed, rolling out r161427.
952         http://trac.webkit.org/changeset/161427
953         https://bugs.webkit.org/show_bug.cgi?id=126645
954
955         Emits a stye error on any newly added files (Requested by ap
956         on #webkit).
957
958         * Scripts/webkitpy/style/checkers/cpp.py:
959         (check_style):
960         (CppChecker):
961         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
962         (WebKitStyleTest.test_other):
963
964 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
965
966         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
967         https://bugs.webkit.org/show_bug.cgi?id=126580
968
969         Reviewed by Csaba Osztrogonác.
970
971         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
972         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
973         run-webkit-tests script.
974         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
975         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
976
977 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
978
979         Update the list of non-committer u-szeged contributors
980         https://bugs.webkit.org/show_bug.cgi?id=126640
981
982         Reviewed by Csaba Osztrogonác.
983
984         * Scripts/webkitpy/common/config/contributors.json:
985
986 2014-01-08  Alberto Garcia  <berto@igalia.com>
987
988         Fix some compilation warnings
989         https://bugs.webkit.org/show_bug.cgi?id=126635
990
991         Reviewed by Csaba Osztrogonác.
992
993         * GtkLauncher/main.c:
994         (createWindow): This function is not supposed to receive any
995         parameter, yet we are passing one.
996
997 2014-01-08  Brian Holt  <brian.holt@samsung.com>
998
999         [GTK][WK2] unskip passing unit tests
1000         https://bugs.webkit.org/show_bug.cgi?id=126637
1001
1002         Reviewed by Carlos Garcia Campos.
1003
1004         Unskip TestResources and TestAuthentication unit tests since they
1005         are passing both under Xvfb and X.
1006
1007         * Scripts/run-gtk-tests:
1008         (TestRunner):
1009
1010 2014-01-08  Alberto Garcia  <berto@igalia.com>
1011
1012         REGRESSION(r160304): [GTK] Disable libtool fast install
1013         https://bugs.webkit.org/show_bug.cgi?id=126381
1014
1015         Reviewed by Gustavo Noronha Silva.
1016
1017         Disable the libtool fast-install mode in developer/test builds.
1018
1019         In this mode binaries are generated ready to be used directly from
1020         the build tree. Otherwise they would need to be relinked when they
1021         are executed, which can take a lot of resources, particularly in
1022         debug builds.
1023
1024         * Scripts/webkitdirs.pm:
1025         (runAutogenForAutotoolsProjectIfNecessary):
1026
1027 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
1028
1029         Unreviewed GTK gardening.
1030
1031         * Scripts/run-gtk-tests:
1032         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
1033         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
1034
1035 2014-01-07  Lucas Forschler  <lforschler@apple.com>
1036
1037         Add buildbot infrasctructure for building and testing JSC cloop
1038         https://bugs.webkit.org/show_bug.cgi?id=126604
1039
1040         Reviewed by Geoffrey Garen.
1041
1042         * BuildSlaveSupport/build.webkit.org-config/config.json:
1043         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1044         (CompileCLOOP):
1045         (RunCLOOPTests):
1046         (RunCLOOPTests.countFailures):
1047         (BuildAndTestCLOOP):
1048
1049 2014-01-07  Brian Burg  <bburg@apple.com>
1050
1051         Unreviewed. Add myself as a committer.
1052
1053         * Scripts/webkitpy/common/config/contributors.json:
1054
1055 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
1056
1057         Popovers at build.webkit.org/dashboard could have titles
1058         https://bugs.webkit.org/show_bug.cgi?id=126495
1059
1060         Reviewed by Timothy Hatcher.
1061
1062         Added titles to all popovers except for pending revisions one, which I would like
1063         to improve more (probably add an ETA).
1064
1065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1066         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
1067         adding a title to base class.
1068
1069         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1070         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
1071         a divider to a separate function.
1072         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
1073         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
1074         title from above function.
1075         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
1076         variable to "content" to match all other code.
1077         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
1078         (BuildbotQueueView.prototype._addDividerToPopover): Added.
1079
1080         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1081         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
1082         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
1083         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
1084
1085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1086
1087 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
1088
1089         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
1090         https://bugs.webkit.org/show_bug.cgi?id=126472
1091
1092         Reviewed by Timothy Hatcher.
1093
1094         Added a delay when quickly switching to a different popover, making it easier to
1095         move mouse pointer from active element to its popover without accidentally opening
1096         a different popover.
1097
1098         Used this code to add a delay before creating a popover. This doesn't change UI
1099         behavior, as there was alerady a delay before it became visible, but it avoids
1100         flooding buildbot server with http requests when quickly moving the mouse over
1101         dashboard page.
1102
1103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
1104         Fixed a case where popover could get stuck. If content was updated while fade-out
1105         transition was already in place, the transition was removed for no good reason.
1106
1107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
1108         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
1109
1110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
1111         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
1112         popover delay from 1s to 800ms.
1113
1114 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
1115
1116         Improve display of failed builds at build.webkit.org/dashboard
1117         https://bugs.webkit.org/show_bug.cgi?id=126542
1118         <rdar://problem/15753550>
1119
1120         Reviewed by Timothy Hatcher.
1121
1122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1123         Instead of hardcoding step name, look for the first step that failed.
1124         While at it, added a popover with more links. There are multiple, and it's good
1125         to have a choice of which one to look at in each situation.
1126
1127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1128         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
1129         of having failed. Many iterations are interrupted for whatever reason internal to
1130         Buildbot, and these are suppoed to be orange, not red.
1131         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
1132         not only WillRetry ones.
1133         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
1134         actually failed, more likely indicating a problem with code base.
1135         (BuildbotIteration.prototype.get firstFailedStepName):
1136         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
1137         (BuildbotIteration.prototype.get failureLogs): Ditto.
1138         (BuildbotIteration.prototype.update): Store complete results for the failed step.
1139         Not every failure stops the iteration, so we could have multiple failed steps,
1140         but let's see if seeing just the first one will be enough.
1141
1142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1143         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
1144         terms of successful iterations.
1145         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
1146
1147         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1148         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
1149         terms of successful iterations.
1150
1151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1152         Removed code to create a path to build output, we now take it from results JSON.
1153
1154         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1155         Added styles for the new popover.
1156
1157 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1158
1159         defined constants should use all uppercase names with words separated by underscores.
1160         https://bugs.webkit.org/show_bug.cgi?id=126055
1161
1162         Reviewed by Alexey Proskuryakov.
1163
1164         * Scripts/webkitpy/style/checkers/cpp.py:
1165         (check_style):
1166         (CppChecker):
1167         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1168         (WebKitStyleTest.test_define_constants):
1169
1170 2014-01-07  Brian Holt  <brian.holt@samsung.com>
1171
1172         Unreviewed. Add myself as a committer.
1173
1174         * Scripts/webkitpy/common/config/contributors.json:
1175
1176 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1177
1178         Remove the WinCE buildbot from build.webkit.org
1179         https://bugs.webkit.org/show_bug.cgi?id=126517
1180
1181         Reviewed by Alexey Proskuryakov.
1182
1183         * BuildSlaveSupport/build.webkit.org-config/config.json:
1184         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1185         (appendCustomBuildFlags):
1186
1187 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
1188
1189         [EFL] Change ATK version to 2.11.4
1190         https://bugs.webkit.org/show_bug.cgi?id=126573
1191
1192         Reviewed by Gyuyoung Kim.
1193
1194         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
1195
1196         * efl/jhbuild.modules:
1197
1198 2014-01-07  Alberto Garcia  <berto@igalia.com>
1199
1200         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
1201         https://bugs.webkit.org/show_bug.cgi?id=117275
1202
1203         Reviewed by Carlos Garcia Campos.
1204
1205         If we are not using the internal jhbuild we must not use the
1206         jhbuild-wrapper script, else it will try to download and install
1207         it.
1208
1209         * Scripts/run-launcher:
1210
1211 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
1212
1213         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
1214         https://bugs.webkit.org/show_bug.cgi?id=125855
1215
1216         Reviewed by Mario Sanchez Prada.
1217
1218         Added new function isIndeterminate for testing aria-checked mixed state.
1219         I provided respective, but empty function in mac port. Mac testing it differently.
1220
1221         * DumpRenderTree/AccessibilityUIElement.cpp:
1222         (getIsIndeterminate):
1223         (AccessibilityUIElement::getJSClass):
1224         * DumpRenderTree/AccessibilityUIElement.h:
1225         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1226         (AccessibilityUIElement::isIndeterminate):
1227         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
1228         (AccessibilityUIElement::isIndeterminate):
1229         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
1230         (AccessibilityUIElement::isIndeterminate):
1231         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
1232         (AccessibilityUIElement::isIndeterminate):
1233         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1234         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1235         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1236         (WTR::AccessibilityUIElement::isIndeterminate):
1237         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1238         (WTR::AccessibilityUIElement::isIndeterminate):
1239
1240 2014-01-06  Mark Rowe  <mrowe@apple.com>
1241
1242         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
1243
1244         Reviewed by Ryosuke Niwa.
1245
1246         * DumpRenderTree/mac/DumpRenderTree.mm:
1247         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
1248         with a single case. This avoids the potential for warnings about unhandled cases.
1249         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1250         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
1251
1252 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1253
1254         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
1255         https://bugs.webkit.org/show_bug.cgi?id=126342
1256
1257         Reviewed by Gustavo Noronha Silva.
1258
1259         * CMakeLists.txt: Include the new unit tests subdirectories.
1260         * Scripts/run-gtk-tests: Update to refer to the new build locations.
1261         * Scripts/webkitpy/style/checker.py: Update the style checker.
1262         * Scripts/webkitpy/style/checker_unittest.py:
1263         * TestWebKitAPI/GNUmakefile.am:
1264         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
1265         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
1266         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
1267         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
1268         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
1269         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
1270         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
1271         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
1272         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
1273         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
1274         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
1275         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
1276         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
1277         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
1278         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
1279         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
1280         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
1281         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
1282         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
1283         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
1284         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
1285         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
1286         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
1287         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
1288         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
1289         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
1290         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
1291         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
1292         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
1293         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
1294         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
1295         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
1296         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
1297         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
1298         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
1299         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
1300         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
1301         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
1302         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
1303         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
1304         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
1305         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
1306         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
1307         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
1308         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
1309         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
1310         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
1311         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
1312         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
1313         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
1314         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
1315         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
1316         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
1317         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
1318         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
1319         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
1320         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
1321         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
1322         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
1323         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
1324         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
1325         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
1326         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
1327         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
1328         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
1329         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
1330         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
1331         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
1332         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
1333         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
1334         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
1335         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
1336         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
1337         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
1338         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
1339         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
1340         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
1341         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
1342         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
1343         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
1344         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
1345         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
1346         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
1347         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
1348         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
1349         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
1350         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
1351
1352 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
1353
1354         Gtk and Efl API test results confuse the dashboard
1355         https://bugs.webkit.org/show_bug.cgi?id=126535
1356
1357         Reviewed by Tim Horton.
1358
1359         Added "API tests" step as "platform api tests".
1360
1361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1362         (Buildbot.prototype.platformAPITestResultsURLForIteration):
1363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1364         (BuildbotIteration):
1365         (BuildbotIteration.prototype.update):
1366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1367         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1368         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1369
1370 2014-01-06  Tim Horton  <timothy_horton@apple.com>
1371
1372         build.webkit.org/dashboard should still function if localStorage is disabled
1373         https://bugs.webkit.org/show_bug.cgi?id=126511
1374
1375         Reviewed by Alexey Proskuryakov.
1376
1377         If localStorage is disabled, we should carry on with a warning.
1378
1379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1380         Don't show the gear if localStorage isn't working.
1381
1382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1383         (QueueView.prototype._updateHiddenState):
1384         Bail if localStorage isn't working.
1385
1386         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1387         (Settings.prototype.available):
1388
1389 2014-01-02  Roger Fong  <roger_fong@apple.com>
1390
1391         Set VSINSTALLDIR in win ews start script.
1392         https://bugs.webkit.org/show_bug.cgi?id=126407
1393
1394         Reviewed by Brent Fulgham.
1395
1396         * EWSTools/start-queue-win.sh:
1397
1398 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
1399
1400         Adding myself as a reviewer.
1401
1402         Unreviewed.
1403
1404         * Scripts/webkitpy/common/config/contributors.json:
1405
1406 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
1407
1408         Unreviewed. Unbreaking JSC tests after r161328.
1409
1410         * Scripts/webkitdirs.pm:
1411         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
1412         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
1413
1414 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
1415
1416         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
1417         https://bugs.webkit.org/show_bug.cgi?id=126212
1418
1419         Reviewed by Daniel Bates.
1420
1421         Allow building the GTK+ cmake port with --gtkcmake.
1422
1423         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
1424         when appropriate. Skip the autotoos path when isGtkAutotools is false.
1425         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
1426         Add isGtk which checks isGtkCMake || isGtkAutotools
1427         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
1428         (argumentsForConfiguration): use --gtkcmake when appropriate.
1429         (jscProductDir): Look in the CMake directory when appropriate.
1430         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
1431         (determineIsGtkCMake): Added.
1432         (isGtkCMake): Added.
1433         (isGtkAutotools): Renamed from isGtk.
1434         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
1435         (determineIsGtkAutotools): Renamed from determineIsGtk.
1436         (cmakeBasedPortName): Added a GTK+ path.
1437
1438 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
1439
1440         [GTK] [CMake] Fix the video and audio build
1441         https://bugs.webkit.org/show_bug.cgi?id=126464
1442
1443         Reviewed by Philippe Normand.
1444
1445         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
1446
1447 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
1448
1449         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
1450         https://bugs.webkit.org/show_bug.cgi?id=126467
1451
1452         Reviewed by Geoffrey Garen.
1453
1454         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1455         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
1456         pointer, or to tap.
1457
1458 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
1459
1460         build.webkit.org/dashboard says "failed build" even if it's another step that failed
1461         https://bugs.webkit.org/show_bug.cgi?id=126461
1462
1463         Reviewed by Geoffrey Garen.
1464
1465         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1466         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
1467         build page if it's not the compilation that failed. Use text from buildbot for description.
1468         Show a yellow icon if it's a different kind of failure.
1469
1470         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1471         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
1472
1473 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
1474
1475         setup-git-clone fails to get email address from git
1476         https://bugs.webkit.org/show_bug.cgi?id=126446
1477
1478         Reviewed by Ryosuke Niwa.
1479
1480         The setup-git-clone command fails to get an email address from git
1481         because of a bug in VCSUtils. This patch fixes that bug, and also
1482         makes it so that when VCSUtils fails for real because of a local
1483         misconfiguration, the error message is actually presented to the user
1484         of setup-git-clone.
1485
1486         * Scripts/VCSUtils.pm:
1487         (gitConfig): Call isGit() instead of accessing $isGit directly to make
1488             sure that $isGit is properly initialized.
1489         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1490         (SetupGitClone.execute): Pull out username and email acquistion to
1491             it's own method.
1492         (SetupGitClone._get_username_and_email): Catch the exception thrown
1493             when VCSUtils fails and print out the error message so that the
1494             user actually knows why the command failed.
1495
1496 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
1497
1498         It feels too hard to get rid of a popover at build.webkit.org/dashboard
1499         https://bugs.webkit.org/show_bug.cgi?id=126451
1500
1501         Reviewed by Simon Fraser.
1502
1503         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
1504         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
1505         when moving the mouse from an element to its popover.
1506
1507 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
1508
1509         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
1510         https://bugs.webkit.org/show_bug.cgi?id=122181
1511
1512         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1513         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
1514         popover.present signature change.
1515
1516 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
1517
1518         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
1519         https://bugs.webkit.org/show_bug.cgi?id=122181
1520
1521         Reviewed by Timothy Hatcher and Timothy Horton.
1522
1523         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
1524         JSONP). Dashboard will load them on demand.
1525
1526         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1527         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
1528         and made it use a function from WebKitBuildbot that builds results directory path.
1529         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
1530         a URL for full_results.json.
1531         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
1532         a URL for a crash log.
1533
1534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1535         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
1536         the iteration.
1537
1538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
1539         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
1540         popover API (see below).
1541         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
1542
1543         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1544         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
1545         for iterations that were interrupted (previously, they were displayed incorrectly,
1546         often as passes). Install popover trackers for failure bubbles for which we can currently
1547         display something useful.
1548         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
1549         a popover for layout test regressions when we have the data loaded on demand.
1550         We have test paths, special indicators for crashes/timeouts, and links to test history
1551         at flakiness dashboard.
1552         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
1553         the popover for layout test regressions. Just shows "Loading..." until the data is
1554         loaded.
1555         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
1556         types of failures if there are multiple. There is a lot of similarity with
1557         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
1558
1559         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1560         Create a global test history object, which is used for links in layout test popover.
1561
1562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
1563         Changed the API to be more like WebInspector again, allowing for changing content
1564         of an existing popover. As the size of a popover can change, making the mouse pointer
1565         enter it without a mousenter event, install a handler for mousewheel instead, and block
1566         document scrolling from this event handler when needed.
1567
1568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1569         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
1570         bubble element, making it possible to install a popover on it.
1571
1572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1573         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
1574
1575         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1576         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
1577         building a complete results URL to only building one for root results path. This is
1578         the part that depends on specific buildbot installation, everything relative to it
1579         is the same.
1580
1581         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
1582         Build a path to test history page. In the future, we may consider adding code to
1583         load the data and display it inline.
1584
1585         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1586         Added styles for this new popover.
1587
1588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
1589         a new file, WebKitTestHistory.js.
1590
1591 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1592
1593         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
1594         https://bugs.webkit.org/show_bug.cgi?id=126430
1595
1596         Reviewed by Martin Robinson.
1597
1598         * Scripts/run-gtk-tests:
1599         (TestRunner._setup_testing_environment):
1600         * gtk/common.py: Use common.tests_library_build_path() instead.
1601         (tests_library_build_path): Helper funtion that returns the path
1602         where the tests libraries are built.
1603
1604 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
1605
1606         [CMake] Build TestWebKitAPI tests into a directory structure
1607         https://bugs.webkit.org/show_bug.cgi?id=126358
1608
1609         Reviewed by Gyuyoung Kim.
1610
1611         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
1612         is useful for keeping the "bin" directory tidy during building and will make it easier
1613         to integrate the CMake build into the existing WebKitGTK+ scripts.
1614
1615         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
1616         and make the names simpler now that the directory identifies what category the test is in.
1617
1618 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
1619
1620         Provide a visual clue when element has a popover at build.webkit.org/dashboard
1621         https://bugs.webkit.org/show_bug.cgi?id=126281
1622
1623         Reviewed by Timothy Hatcher.
1624
1625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
1626         (PopoverTracker): Add a class name to elements with popovers.
1627
1628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1629         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
1630         I might have broke that recently.
1631         (*:link): Show hand cursor over links.
1632         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
1633
1634         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1635         (.status-line .message .revision-number): Show text selection cursor on our only
1636         selectable text element.
1637         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
1638         a white shadow than with a dark one on hover.
1639
1640 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1641
1642         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
1643         https://bugs.webkit.org/show_bug.cgi?id=124652
1644
1645         Reviewed by Martin Robinson.
1646
1647         * MiniBrowser/gtk/BrowserWindow.c:
1648         (webViewDecidePolicy): Use the new API instead of
1649         webkit_web_view_can_show_mime_type().
1650
1651 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1652
1653         REGRESSION(r160304): [GTK] Disable libtool fast install
1654         https://bugs.webkit.org/show_bug.cgi?id=126381
1655
1656         Reviewed by Martin Robinson.
1657
1658         Remove -no-fast-install ld flag since fast install is now disabled
1659         globally.
1660
1661         * GNUmakefile.am:
1662         * GtkLauncher/GNUmakefile.am:
1663         * MiniBrowser/gtk/GNUmakefile.am:
1664         * TestWebKitAPI/GNUmakefile.am:
1665         * WebKitTestRunner/GNUmakefile.am:
1666
1667 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
1668
1669         Unreviewed. Add myself to EFL and related watch lists.
1670
1671         * Scripts/webkitpy/common/config/watchlist:
1672
1673 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
1674
1675         [GTK] fixing ycm_extra_conf.py file
1676         https://bugs.webkit.org/show_bug.cgi?id=126371
1677
1678         It's an attempt to fix three problems with the current ycm_extra_conf file.
1679         The current implementation assumes that it's a symlink, which is not true.
1680         Usually python creates a pyc file, and this is what you get in __file__.
1681         the .pyc is not a symlink, and the current implementation doesn't work
1682         if that's the case.
1683
1684         It also assumes that the user is in the root folder.
1685         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
1686
1687         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
1688         exception since "flag" doesn't exists.
1689
1690         All those things were fixed.
1691
1692         Reviewed by Martin Robinson.
1693
1694         * gtk/ycm_extra_conf.py:
1695         (transform_relative_paths_to_absolute_paths):
1696
1697 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
1698
1699         Bindings tests results links are broken at build.webkit.org/dashboard
1700         https://bugs.webkit.org/show_bug.cgi?id=126402
1701
1702         Reviewed by Tim Horton.
1703
1704         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1705         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
1706         since the beginning.
1707
1708 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
1709
1710         "+" is very confusing at http://build.webkit.org/dashboard
1711         https://bugs.webkit.org/show_bug.cgi?id=126400
1712
1713         Reviewed by Tim Horton.
1714
1715         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1716         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
1717         source and internal counts separately, simply add them. One can always open a popover
1718         for more detail.
1719
1720 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
1721
1722         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
1723         https://bugs.webkit.org/show_bug.cgi?id=126391
1724
1725         Reviewed by Dan Bernstein.
1726
1727         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
1728         One can request credentials use via Initialization.js.
1729
1730         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1731         (Trac):
1732         (Trac.prototype.update):
1733         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1734         (loadXML):
1735
1736 2014-01-02  Commit Queue  <commit-queue@webkit.org>
1737
1738         Unreviewed, rolling out r160846.
1739         http://trac.webkit.org/changeset/160846
1740         https://bugs.webkit.org/show_bug.cgi?id=126395
1741
1742         Breaks build scripts for Windows when Visual Studio is not
1743         installed in Program Files (Requested by rfong on #webkit).
1744
1745         * Scripts/webkitdirs.pm:
1746         (visualStudioInstallDir):
1747
1748 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
1749
1750         [GTK] [CMake] run-gtk-tests should run with the cmake build
1751         https://bugs.webkit.org/show_bug.cgi?id=126341
1752
1753         Reviewed by Carlos Garcia Campos.
1754
1755         * Scripts/run-gtk-tests:
1756         (TestRunner.__init__): Use the new calling conventions for the common script.
1757         (TestRunner._setup_testing_environment): Ditto.
1758         * gtk/common.py:
1759         (set_build_types): Added set_build_types, to avoid having build_type arguments
1760         for all functions in common.
1761         (binary_build_path): Added this function which gets the path to the built binaries.
1762         (get_build_path): Removed the build_types argument.
1763         (build_path): Removed the build_types argument and call get_build_path directly now.
1764
1765 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
1766
1767         https://bugs.webkit.org/show_bug.cgi?id=126391
1768         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
1769
1770         Rubber-stamped by Dan Bernstein.
1771
1772         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1773         (loadXML): Quick and dirty fix, with a FIXME.
1774
1775 2014-01-01  Martin Robinson  <mrobinson@igalia.com>
1776
1777         [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
1778         https://bugs.webkit.org/show_bug.cgi?id=126349
1779
1780         Reviewed by Carlos Garcia Campos.
1781
1782         All CMake ports use "libTestNetscapePlugin," so choosing the same
1783         name in the autotools port will make the transition easier.
1784
1785         * GNUmakefile.am: Rename the plugin library.
1786
1787 2014-01-01  ChangSeok Oh  <changseok.oh@collabora.com>
1788
1789         [GTK][WK2] Back items are shown in reverse order in MiniBrowser
1790         https://bugs.webkit.org/show_bug.cgi?id=126354
1791
1792         Reviewed by Carlos Garcia Campos.
1793
1794         The latest visited site for backward history should be placed on the top of a history stack
1795         as a common behavior. However currently its order is reverse.
1796
1797         * MiniBrowser/gtk/BrowserWindow.c:
1798         (browserWindowUpdateNavigationActions):
1799
1800 2013-12-30  Martin Robinson  <mrobinson@igalia.com>
1801
1802         [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
1803         https://bugs.webkit.org/show_bug.cgi?id=126297
1804
1805         Reviewed by Philippe Normand.
1806
1807         * Scripts/run-gtk-tests: Looks for the tests in the new directories.
1808         (TestRunner): Ditto.
1809         (TestRunner._run_test): Ditto.
1810
1811 2013-12-30  Alexey Proskuryakov  <ap@apple.com>
1812
1813         full_results.json should distinguish unexpected failures from expected ones
1814         https://bugs.webkit.org/show_bug.cgi?id=126300
1815
1816         Reviewed by Timothy Hatcher.
1817
1818         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1819         (summarize_results): Add "report" element to JSON, which tells the consumer how
1820         this result was counted for summary.
1821
1822         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1823         Updated results to include the new element.
1824
1825         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1826         (print_unexpected_results): Added a comment pointing to another place that
1827         summarizes results, and should stay in sync.
1828
1829 2013-12-30  Ryuan Choi  <ryuan.choi@samsung.com>
1830
1831         Replace remaning CoreIPC namespace to IPC
1832         https://bugs.webkit.org/show_bug.cgi?id=126305
1833
1834         Reviewed by Anders Carlsson.
1835
1836         * TestWebKitAPI/CMakeLists.txt: Replaced CoreIPC includes to IPC.
1837         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed temporal define for IPC.
1838         * WebKitTestRunner/CMakeLists.txt: Replaced CoreIPC includes to IPC.
1839         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed temporal define for IPC.
1840
1841 2013-12-30  Brendan Long  <self@brendanlong.com>
1842
1843         Add myself to the committers list.
1844
1845         Unreviewed.
1846
1847         * Scripts/webkitpy/common/config/contributors.json:
1848
1849 2013-12-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1850
1851         [GTK] Split WebKit2APITests/TestWebKitWebView
1852         https://bugs.webkit.org/show_bug.cgi?id=126284
1853
1854         Reviewed by Philippe Normand.
1855
1856         Skip only WebKitWebView/mouse-target and all TestAuthentication
1857         tests that are timing out when running under xvfb.
1858
1859         * Scripts/run-gtk-tests:
1860         (TestRunner):
1861
1862 2013-12-29  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1863
1864         [EFL][WK2] Disable geolocation API test
1865         https://bugs.webkit.org/show_bug.cgi?id=125851
1866
1867         Reviewed by Gyuyoung Kim.
1868
1869         Geolocation is turned off by default in EFL port, so it shouldn't be tested.
1870
1871         * TestWebKitAPI/PlatformEfl.cmake: Move Geolocation to test_webkit2_api_fail_BINARIES.
1872
1873 2013-12-29  Ryuan Choi  <ryuan.choi@samsung.com>
1874
1875         [EFL] Remove ewk_view_tiled
1876         https://bugs.webkit.org/show_bug.cgi?id=125961
1877
1878         Reviewed by Gyuyoung Kim.
1879
1880         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1881         (shouldUseTiledBackingStore):
1882         Moved from DumpRenderTreeChrome to enable WebCore's TiledBackingStore
1883         instead of switching ewk_view_tiled.
1884         (DumpRenderTreeChrome::createView):
1885         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1886         (drtViewAdd):
1887         * EWebLauncher/main.c: Removed ewk_view_tiled option.
1888         (windowCreate):
1889         (parseUserArguments):
1890
1891 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
1892
1893         Pending revision popover is slightly misplaced at build.webkit.org/dashboard
1894         https://bugs.webkit.org/show_bug.cgi?id=126278
1895
1896         Reviewed by Timothy Hatcher.
1897
1898         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1899         (BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
1900         as StatusLineView message element has extra padding, and doesn't fit the text snugly.
1901         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Added bug number to a FIXME.
1902
1903         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1904         (StatusLineView.prototype.set messageElement): Removed the getter, as we no longer need it.
1905
1906         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1907         Removed display:inline-block hack for messageElement div, as we no longer use it for measuring text bounds.
1908
1909 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
1910
1911         Interrupted test runs should not count at build.webkit.org/dashboard
1912         https://bugs.webkit.org/show_bug.cgi?id=126279
1913
1914         Reviewed by Timothy Hatcher.
1915
1916         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1917         (BuildbotIteration.prototype.get productive):
1918         (BuildbotIteration.prototype.get previousProductiveIteration): Replaced previous with
1919         this accessor to skips iterations that don't have relevant data. We still want to
1920         display them, but revision ranges should not be affected.
1921         (BuildbotIteration.prototype.update): Record whether the iteration was up for retry.
1922
1923         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1924         Use latest productive iteration instead of latest iteration for pending revision
1925         count and popovers.
1926
1927 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
1928
1929         Please display (and link to) revision ranges at build.webkit.org/dashboard
1930         https://bugs.webkit.org/show_bug.cgi?id=122187
1931
1932         Reviewed by Timothy Hatcher.
1933
1934         Added popovers for revision numbers. Removed direct links, because they were misleading -
1935         a test run covers a revision range, not just the latest revision. This also makes
1936         selecting a revision for copy easier.
1937
1938         All revision numbers have the popovers for consistency, although they are most useful
1939         for iterations that are not the last ones in a view, because the content is a delta
1940         from previous iteration.
1941
1942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1943         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1944         revisionLinksForIteration() is now named revisionContentForIteration().
1945
1946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1947         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1948         Ditto.
1949
1950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1951         (BuildbotIteration.prototype.get previous): Added a function to go back in iteration history.
1952
1953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1954         Refactored to support the new popover variation. Replaced revisionLinksForIteration()
1955         with a function that builds an element with popover.
1956
1957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
1958         Changed to take a function for popover presentation instead of delegate object.
1959         We only need one delegate function, and it's easier to have multiple popovers per view class
1960         this way.
1961
1962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1963         Removed a rule for selectable class. It's replaced with a semantic rule in StatusLineView.css.
1964
1965         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1966         Renamed pending-commits-popover class to commit-history-popover.
1967
1968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1969         (.status-line .message .revision-number): Added a rule for revision numbers.
1970
1971 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
1972
1973         Please display information about pending runs in build.webkit.org/dashboard
1974         https://bugs.webkit.org/show_bug.cgi?id=122180
1975
1976         Reviewed by Timothy Hatcher.
1977
1978         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1979         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Added a semicolon at the end of a line.
1980
1981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1982         (BuildbotQueueView.prototype._latestFinishedIteration): Factored out of _appendPendingRevisionCount.
1983         (BuildbotQueueView.prototype._appendPendingRevisionCount): Install a popover tracker over the element.
1984         (BuildbotQueueView.prototype.lineForCommit): Build an element for a particular commit ot be shown in popover.
1985         (BuildbotQueueView.prototype.presentPopoverForElement): Build and show popover content when PopoverTracker
1986         asks us to.
1987
1988         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Geometry.js: Added.
1989         Taken from WebInspector with minimal changes:
1990         - Changed root name from WebInspector to Dashboard.
1991         - Removed some unused functionality.
1992         - Added Rect.containsPoint.
1993
1994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js: Added.
1995         Popover has extensive changes compared to WebInspector version, only drawing code is the same:
1996         - Fixed to work in scrollable pages - WebInspector version assumes that window
1997         and document coordinates are the same, and also erroneously dismisses a scrollable
1998         popover if scrolling cascades out of it after reaching a bound.
1999         - Simplified API and implementation to Dashboard needs, it is no longer possible to
2000         change content of an existing popover.
2001         - Rewrote visibility tracking to be more complete, and not rely on external tracker
2002         object so much.
2003         - Added code to flash scroll bars when showing a scrollable popover.
2004
2005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js: Added.
2006         Objects of this class show and hide popovers as appropriate for registered active elements.
2007
2008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2009         (StatusLineView.prototype.get messageElement): Added an accessor, so that we could
2010         install a popover on message element. It's the only visible element in pending commit
2011         line, but the line has different bounds, so we can't install a popover on it (it
2012         would be incorrectly positioned if we did).
2013
2014         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2015         (Trac.prototype._convertCommitInfoElementToObject):
2016         - Some trac installations report author in a different element, updated to support that.
2017         - Changed to parse title out of description, because trac titles are ugly. Also,
2018         we get a nice HTML with links from the description.
2019
2020         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2021         (Node.prototype.isAncestor): Copied from Web Inspector, only changing the form for
2022         consistency with the rest of this file (add a property on prototype with assignment
2023         instead of using Object.defineProperty).
2024         (Node.prototype.isDescendant): Ditto.
2025         (Node.prototype.isSelfOrAncestor): Ditto.
2026         (Node.prototype.isSelfOrDescendant): Ditto.
2027         (DOMTokenList.prototype.contains): Ditto.
2028
2029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css: Added.
2030         Like JS counterpart, mostly lifted from Web Inspector.
2031
2032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2033         Added style rules for pending commits popover.
2034
2035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2036         (.status-line.no-bubble .message): Changed to display:inline-block, so that it fits
2037         to content, and we can show the popover in a correct place.
2038
2039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added new files.
2040
2041 2013-12-27  Gavin Barraclough  <barraclough@apple.com>
2042
2043         Merge PageVisibilityState & ViewState::IsVisible in WebKit2
2044         https://bugs.webkit.org/show_bug.cgi?id=126214
2045
2046         Reviewed by Alexey Proskuryakov.
2047
2048         WebKit2 redundantly tracks the visibility of the view through two mechanisms - the visibility
2049         state, and the view state. Remove visibility state from the WebKit2 layer. The visibility
2050         state also tracks the prerender state - so split this out and handle it separately (a change
2051         we should make in WebCore, too).
2052
2053         Tools - WebKit2 no longer (poorly) supports a fake visibility state, so to test the page
2054         visibility mechanisms we should actually be changing characteristics of the view that will
2055         be detected by WebKit2 as a visibility change. This affects three things:
2056             1) On setVisibilityState WebKitTestRunner must actually change visibility of the view.
2057             2) The 'PageVisibilityState' test in the API tests is useless (as evidenced by the fact
2058                that page visibility has been broken in WebKit2 for a couple of months, and didn't
2059                catch this fact). Removed in favour of:
2060             3) 'PageVisibilityStateWithWindowChanges' - this is the good stuff. This actually tests
2061                the visibility mechanism. Beef this test up by adding coverage for: a) the prerender
2062             state, b) document.hidden, and c) too many state change notifications (it already looks
2063             for too few).
2064
2065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2066         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Removed.
2067             - Removed PageVisibilityState - this test was ineffective, API no longer supports this
2068               test, and behaviour is covered by PageVisibilityStateWithWindowChanges.
2069         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2070         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2071         (runJavaScriptAlert):
2072             - Add checking for too many calls to the alert.
2073         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::setPrerender):
2074             - Added methods to set visibility to prerender.
2075         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2076             - Added checking of 'document.hidden'.
2077         * WebKitTestRunner/TestController.cpp:
2078         (WTR::TestController::setVisibilityState):
2079         * WebKitTestRunner/TestController.h:
2080         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2081         (WTR::TestController::setHidden):
2082         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2083         (WTR::TestController::setHidden):
2084         * WebKitTestRunner/mac/TestControllerMac.mm:
2085         (WTR::TestController::setHidden):
2086             - Add setHidden method; call this from setVisibilityState.
2087
2088 2013-12-27  Alexey Proskuryakov  <ap@apple.com>
2089
2090         Display EWS status on bot watcher's dashboard
2091         https://bugs.webkit.org/show_bug.cgi?id=126224
2092
2093         Silence spurious exceptions, no visible behavior change.
2094
2095         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2096         (EWSQueue.prototype.update): Removed code that was only needed for an experimental
2097         feature that wasn't landed.
2098
2099 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
2100
2101         Display EWS status on bot watcher's dashboard
2102         https://bugs.webkit.org/show_bug.cgi?id=126224
2103
2104         Reviewed by Timothy Hatcher.
2105
2106         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added.
2108         Moved platform definitions out of Buildbot.js, as they are also needed for EWS.
2109
2110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js: Added.
2112         (QueueView):
2113         (QueueView.prototype.updateSoon):
2114         (QueueView.prototype.update):
2115         (QueueView.prototype._updateHiddenState):
2116         Moved auto-update and hide logic to a base class, as it equally applies to EWS.
2117
2118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Added.
2119         This is a peer to Buildbot.js and WebKitBuildbot.js.
2120
2121         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Added.
2122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Added.
2123         Quite simple for now, only keeping track of queue size.
2124         
2125         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2126         Initialize EWS.
2127
2128         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2129         Create EWS views.
2130
2131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2132         Updated for Buildbot.Platform rename, it's now Dashboard.Platform.
2133
2134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Removed.
2135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Removed.
2136         These were empty, no reason to waste the time loading them.
2137
2138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Removed.
2139         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css.
2140         Renamed, as these styles apply to all queues, not just buildbot ones (and they have to, as columns should look alike).
2141
2142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2143             - Changed page title, as it no longer displays just buildbot status.
2144             - Updated subresource lists for the new, renamed and removed files.
2145
2146 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
2147
2148         EWS status JSON should include Access-Control-Allow-Origin
2149         https://bugs.webkit.org/show_bug.cgi?id=126246
2150
2151         Reviewed by Ryosuke Niwa.
2152
2153         * QueueStatusServer/app.yaml: Update version.
2154         * QueueStatusServer/handlers/queuestatusjson.py:
2155         (QueueStatusJSON.get): Add the header field.
2156
2157 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
2158
2159         Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible
2160         https://bugs.webkit.org/show_bug.cgi?id=126234
2161
2162         Reviewed by Timothy Hatcher.
2163
2164         Changed elements that are semantically links from <div> to <a>.
2165
2166         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2167         (StatusLineView): Create <a> or <div> elements conditionally on whether we have a URL.
2168         Don't try simulate a link with CSS/JS, it's not needed any more.
2169         (StatusLineView.prototype._clicked): Removed.
2170
2171         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
2172         Removed text-decoration rules, default ones in Main.css now work for queue elements.
2173
2174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2175         Simplified cursor rules.
2176         Added a universal rule for links to only show underline on hover, as this is what
2177         we want almost everywhere.
2178
2179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2180         (.status-line .bubble): Added text-decoration: none, as this is the one place where
2181         we don't want it even on hover.
2182         (.status-line .label): Force display: block for consistent layout between <a>
2183         and <div>.
2184
2185 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
2186
2187         Please clarify "pending" reporting at build.webkit.org/dashboard
2188         https://bugs.webkit.org/show_bug.cgi?id=122191
2189
2190         Reviewed by Timothy Hatcher.
2191
2192         Reporting the count of pending runs didn't make a lot of sense - first, runs are
2193         coalesced and sometimes even out of order, and second, buildbot's notion of pending
2194         run was confusingly different from dashboard's.
2195
2196         Let's display how many SVN revisions are pending. This can be somewhat misleading
2197         too, because some revisions (like those for other platforms) don't trigger builds,
2198         but it's better than what we had.
2199
2200         This patch also lays the groundwork for displaying detailed information about
2201         pending revisions.
2202
2203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2204         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
2205         building pending status line directly, call newly added base class method.
2206
2207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2208         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Ditto.
2209
2210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2211         (BuildbotQueueView): Listen for events when new SVN revisions are landed, and update the view.
2212         (BuildbotQueueView.prototype._appendPendingRevisionCount): Add a line for pending
2213         SVN revisions. It uses a new style, StatusLineView.Status.NoBubble, because this
2214         information is secondary, and doesn't need as much attention.
2215         (BuildbotQueueView.prototype.revisionLinksForIteration): Build revisionURL through
2216         Trac, not through Buildbot.
2217         (BuildbotQueueView.prototype._newCommitsRecorded): Schedule an update, just like when
2218         iterations are updated.
2219
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2221         Initialize a global webkitTrac object.
2222
2223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2225         Added a new style for messages without a bubble.
2226
2227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2228         Added a model class for Trac, which keeps track of SVN timeline, and notifies
2229         listeners of changes. It uses an RSS interface to Trac, because there is no JSON one.
2230
2231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2232         (loadXML): Added a function to load XML asynchronously, just like existing JSON.load.
2233
2234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2235         Removed tracRevisionURL() function. Now that we have a Trac object, it just makes
2236         more sense to build trac URLs through it.
2237
2238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2239         Load Trac.js.
2240
2241 2013-12-25  Jongwoo Choi  <jw0330.choi@samsung.com>
2242
2243         [EFL] Activate keyboard homepage shortcut on efl minibrowser.
2244         https://bugs.webkit.org/show_bug.cgi?id=124636
2245
2246         Reviewed by Gyuyoung Kim.
2247
2248         * MiniBrowser/efl/main.c: Added.
2249         (on_key_down): Add a homepage shortcut using Alt + Home key. 
2250
2251 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
2252
2253         Revision selection behavior at build.webkit.org/dashboard is annoying
2254         https://bugs.webkit.org/show_bug.cgi?id=126235
2255
2256         Reviewed by Tim Horton.
2257
2258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2259         (BuildbotQueueView.prototype.revisionLinksForIteration): Make the whole message
2260         selectable, not just the numbers in it.
2261         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2262         (.selectable): Make selectable enable default behavior, not user-select:all.
2263
2264 2013-12-25  Martin Robinson  <mrobinson@igalia.com>
2265
2266         [GTK] [CMake] Clean up generated sources directories
2267         https://bugs.webkit.org/show_bug.cgi?id=126216
2268
2269         Reviewed by Gustavo Noronha Silva.
2270
2271         * DumpRenderTree/PlatformGTK.cmake: Use the new derived sources variables.
2272         * GtkLauncher/CMakeLists.txt: Ditto.
2273         * MiniBrowser/gtk/CMakeLists.txt: Ditto.
2274         * TestWebKitAPI/CMakeLists.txt: Now that the EFL and GTK+ forwarding header locations differ,
2275         move the platform-specific includes to the EFL and GTK platform files. Also clean up forwarding
2276         header generation into on target.
2277         * TestWebKitAPI/PlatformEfl.cmake: Added EFL-specific locations to the include list.
2278         * TestWebKitAPI/PlatformGTK.cmake: Added GTK-specific locations to the include list.
2279         * WebKitTestRunner/CMakeLists.txt: Same as for TestWebKitAPI.
2280         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
2281         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
2282         * gtk/generate-gtkdoc: Update to select the appropriate derived sources locations for
2283         the cmake build.
2284
2285 2013-12-23  Alexey Proskuryakov  <ap@apple.com>
2286
2287         Add a JSON interface for getting EWS queue status
2288         https://bugs.webkit.org/show_bug.cgi?id=126182
2289
2290         Reviewed by Ryosuke Niwa.
2291
2292         The current goal is to add an indicator of how many patches are in the queue, and
2293         the JSON also includes some other information that was easy to add.
2294
2295         * QueueStatusServer/app.yaml: Updated version for deployment.
2296
2297         * QueueStatusServer/handlers/queuestatusjson.py: Added. Returns a JSON with some
2298         bot and patch queue information.
2299
2300         * QueueStatusServer/index.yaml: Added an index for a new query that only returns
2301         bot ids.
2302
2303         * QueueStatusServer/main.py: Map /queue-status-json/ directory to QueueStatusJSON
2304         handler.
2305
2306         * QueueStatusServer/config: Added property svn:ignore.
2307         * QueueStatusServer/filters: Added property svn:ignore.
2308         * QueueStatusServer/loggers: Added property svn:ignore.
2309         * QueueStatusServer/handlers: Added property svn:ignore.
2310         * QueueStatusServer/model: Added property svn:ignore.
2311         Ignore compiled *.pyc files in all directories they appear in when running locally.
2312
2313 2013-12-23  Martin Robinson  <mrobinson@igalia.com>
2314
2315         Try to fix the build after r161017
2316
2317         * gtk/common.py:
2318         (is_cmake_build): Instead of checking whether the return value of build_path
2319         of the CMakeCache.txt file is None, check if a file actually exists at that path.
2320
2321 2013-12-23  Gustavo Noronha Silva  <gns@gnome.org>
2322
2323         [GTK] [CMake] Add support for generating gtkdoc
2324         https://bugs.webkit.org/show_bug.cgi?id=116376
2325
2326         Reviewed by Martin Robinson.
2327
2328         * gtk/common.py: look for files in the directories used by the cmake build as well.
2329
2330 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2331
2332         [GTK] Build with network process unconditionally
2333         https://bugs.webkit.org/show_bug.cgi?id=126128
2334
2335         Reviewed by Martin Robinson.
2336
2337         * Scripts/webkitperl/FeatureList.pm: Remove network-process
2338         feature command line option.
2339
2340 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2341
2342         [GTK] run-gtk-tests should always run glib tests with -k option
2343         https://bugs.webkit.org/show_bug.cgi?id=126132
2344
2345         Reviewed by Philippe Normand.
2346
2347         With -k command line option, gtester continues running all other
2348         test cases after a failure.
2349
2350         * Scripts/run-gtk-tests:
2351         (TestRunner._run_test_glib): Use -k option when runing glib tests
2352         to not stop on failure.
2353
2354 2013-12-22  Martin Robinson  <mrobinson@igalia.com>
2355
2356         [GTK][CMake] Integrate GResource for inspector files (and others?)
2357         https://bugs.webkit.org/show_bug.cgi?id=125569
2358
2359         Reviewed by Gustavo Noronha Silva.
2360
2361         * gtk/generate-inspector-gresource-manifest.py: Added.
2362
2363 2013-12-22  Csaba Osztrogonác  <ossy@webkit.org>
2364
2365         Last URTBF after r160971 to make EFL build happy.
2366
2367         * TestWebKitAPI/efl/PlatformWebView.cpp:
2368         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2369
2370 2013-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2371
2372         Unreviewed. Add myself to some more watch lists.
2373
2374         * Scripts/webkitpy/common/config/watchlist: Watch also soup, gst
2375         and binding scripts patches.
2376
2377 2013-12-20  Commit Queue  <commit-queue@webkit.org>
2378
2379         Unreviewed, rolling out r160941.
2380         http://trac.webkit.org/changeset/160941
2381         https://bugs.webkit.org/show_bug.cgi?id=126095
2382
2383         Doesn't handle subpixel layout being disabled (Requested by
2384         smfr on #webkit).
2385
2386         * gdb/webkit.py:
2387         (JSCJSStringPrinter.to_string):
2388         (add_pretty_printers):
2389         * lldb/lldb_webkit.py:
2390         (WTFMediaTime_SummaryProvider):
2391         (WTFStringProvider.to_string):
2392
2393 2013-12-20  Bem Jones-Bey  <bjonesbe@adobe.com>
2394
2395         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in gdb and lldb
2396         https://bugs.webkit.org/show_bug.cgi?id=126080
2397
2398         Reviewed by Anders Carlsson.
2399
2400         This changes the output of printing LayoutUnits to be in px, removing
2401         the need to divide by 64 manually.
2402
2403         This will lead to gdb output like:
2404
2405         m_frameRect = {
2406             m_location = LayoutPoint(0px, 0px),
2407             m_size = LayoutSize(800px, 585px)
2408         }
2409
2410         And lldb output like:
2411
2412         (const WebCore::LayoutRect) $0 = {
2413           m_location = { x = 744px, y = 1px }
2414           m_size = { width = 236px, height = 40px }
2415         }
2416
2417         This patch is based on patch for Blink by cbiesinger@chromium.org.
2418
2419         * gdb/webkit.py:
2420         (WebCoreLayoutUnitPrinter):
2421         (WebCoreLayoutUnitPrinter.__init__):
2422         (WebCoreLayoutUnitPrinter.to_string):
2423         (WebCoreLayoutSizePrinter):
2424         (WebCoreLayoutSizePrinter.__init__):
2425         (WebCoreLayoutSizePrinter.to_string):
2426         (WebCoreLayoutPointPrinter):
2427         (WebCoreLayoutPointPrinter.__init__):
2428         (WebCoreLayoutPointPrinter.to_string):
2429         (add_pretty_printers):
2430         * lldb/lldb_webkit.py:
2431         (__lldb_init_module):
2432         (WebCoreLayoutUnit_SummaryProvider):
2433         (WebCoreLayoutSize_SummaryProvider):
2434         (WebCoreLayoutPoint_SummaryProvider):
2435         (WebCoreLayoutUnitProvider):
2436         (WebCoreLayoutUnitProvider.__init__):
2437         (WebCoreLayoutUnitProvider.to_string):
2438         (WebCoreLayoutSizeProvider):
2439         (WebCoreLayoutSizeProvider.__init__):
2440         (WebCoreLayoutSizeProvider.get_width):
2441         (WebCoreLayoutSizeProvider.get_height):
2442         (WebCoreLayoutPointProvider):
2443         (WebCoreLayoutPointProvider.__init__):
2444         (WebCoreLayoutPointProvider.get_x):
2445         (WebCoreLayoutPointProvider.get_y):
2446
2447 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
2448
2449         [GTK] [CMake] Add support for building ImageDiff
2450         https://bugs.webkit.org/show_bug.cgi?id=125960
2451
2452         Reviewed by Gustavo Noronha Silva.
2453
2454         * CMakeLists.txt: Build ImageDiff for GTK+.
2455         * ImageDiff/PlatformGTK.cmake: Added.
2456
2457 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
2458
2459         [GTK] [CMake] Add support for building DumpRenderTree
2460         https://bugs.webkit.org/show_bug.cgi?id=125767
2461
2462         Reviewed by Gustavo Noronha Silva.
2463
2464         * CMakeLists.txt: Load the DumpRenderTree cmake file for GTK+ when WebKit1 is enabled.
2465         * DumpRenderTree/PlatformGTK.cmake: Added.
2466
2467 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
2468
2469         [GTK] [CMake] Add support for building WebKitTestRunner
2470         https://bugs.webkit.org/show_bug.cgi?id=125768
2471
2472         Reviewed by Gustavo Noronha Silva.
2473
2474         * CMakeLists.txt: Compile WebKitTestRunner for GTK+ when WebKit2 is enabled.
2475         * WebKitTestRunner/CMakeLists.txt: Remove some EFL specific flags from the common
2476         build file.
2477         * WebKitTestRunner/PlatformEfl.cmake: Move the flags here.
2478         * WebKitTestRunner/PlatformGTK.cmake: Added.
2479
2480 2013-12-20  Myles C. Maxfield  <mmaxfield@apple.com>
2481
2482         Myles C. Maxfield is a committer now
2483
2484         Unreviewed.
2485
2486         * Scripts/webkitpy/common/config/contributors.json:
2487
2488 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2489
2490         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
2491         https://bugs.webkit.org/show_bug.cgi?id=125854
2492
2493         Reviewed by Chris Fleizach.
2494
2495         Ensure we don't ever create instances of AccessibilityUIElement
2496         wrapping invalid platform-specific accessibility objects in DRT,
2497         both for consistency with what WKTR does (so we avoid situations
2498         where some tests fail in WK2 and not in WK1) and also to avoid
2499         overlooking tests that might not be checking the right thing.
2500
2501         * DumpRenderTree/AccessibilityUIElement.cpp:
2502         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
2503         nullPtr if the platformUIElement() is not a valid one.
2504         * DumpRenderTree/AccessibilityUIElement.h:
2505         (AccessibilityUIElement::platformUIElement): Added const modifier.
2506
2507 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2508
2509         Programmatically-inserted children lack accessibility events
2510         https://bugs.webkit.org/show_bug.cgi?id=100275
2511
2512         Reviewed by Chris Fleizach.
2513
2514         Update DRT and WebKitTestRunner to handle the children-changed
2515         signal properly, considering the detail and optional parameters.
2516
2517         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
2518         (axObjectEventListener):
2519         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
2520
2521 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2522
2523         Removed unused BUILDER_BASE_URL.
2524         https://bugs.webkit.org/show_bug.cgi?id=125442
2525
2526         Reviewed by Csaba Osztrogonác.
2527
2528         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2529         (JSONGeneratorTest._test_json_generation): Trivial test fix after r160900.
2530
2531 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2532
2533         Removed unused BUILDER_BASE_URL.
2534         https://bugs.webkit.org/show_bug.cgi?id=125442
2535
2536         Reviewed by Csaba Osztrogonác.
2537
2538         The string constant BUILDER_BASE_URL is passed around several times,
2539         but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
2540
2541         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2542         (Manager._upload_json_files):
2543         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2544         (JSONLayoutResultsGenerator.__init__):
2545         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2546         (JSONResultsGenerator.__init__):
2547
2548 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
2549
2550         check-webkit-style mistakenly flags assigning to a dereferenced pointer
2551         https://bugs.webkit.org/show_bug.cgi?id=126041
2552
2553         Reviewed by Ryosuke Niwa.
2554
2555         When checking for lines like "Foo *bar;", check-webkit-style doesn't make
2556         sure that there is a declaration. This patch makes sure that there is a
2557         declaration in order to flag spacing around asterisks.
2558
2559         * Scripts/webkitpy/style/checkers/cpp.py:
2560         (check_spacing):
2561         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2562         (CppStyleTest.test_pointer_reference_marker_location):
2563
2564 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
2565
2566         check-webkit-style marks rvalue references as violations
2567         https://bugs.webkit.org/show_bug.cgi?id=126000
2568
2569         Reviewed by Ryosuke Niwa.
2570
2571         Previously, check-webkit-style was making sure that any line with "&&" had
2572         spaces around it. However, we can now legitimately use "&&" without a previous
2573         space when declaring an rvalue reference. This patch relaxes this check.
2574
2575         * Scripts/webkitpy/style/checkers/cpp.py:
2576         (check_spacing):
2577         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2578         (CppStyleTest.test_spacing_for_binary_ops):
2579
2580 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
2581
2582         check-webkit-style marks auto return types for functions as violations
2583         https://bugs.webkit.org/show_bug.cgi?id=125999
2584
2585         Reviewed by Ryosuke Niwa.
2586
2587         If a function declaration ends with a "->" followed by a non whitespace
2588         string, don't mark as an invalid "{" on its own line
2589
2590         * Scripts/webkitpy/style/checkers/cpp.py:
2591         (check_braces):
2592         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2593         (CppStyleTest.test_brace_at_begin_of_line):
2594
2595 2013-12-19  Alex Christensen  <achristensen@webkit.org>
2596
2597         [WinCairo] More GStreamer preparations.
2598
2599         Unreviewed.
2600
2601         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props:
2602         Include FeatureDefinesCairo and WinCairo to compile the GLib part of WinLauncher.
2603
2604 2013-12-19  Lucas Forschler  <lforschler@apple.com>
2605
2606         Add Apple Mavericks perf bot.
2607         
2608         Unreviewed.
2609
2610         * BuildSlaveSupport/build.webkit.org-config/config.json:
2611
2612 2013-12-19  Commit Queue  <commit-queue@webkit.org>
2613
2614         Unreviewed, rolling out r160842.
2615         http://trac.webkit.org/changeset/160842
2616         https://bugs.webkit.org/show_bug.cgi?id=126003
2617
2618         broke accessibility/loading-iframe-updates-axtree.html
2619         (Requested by ap on #webkit).
2620
2621         * DumpRenderTree/AccessibilityUIElement.cpp:
2622         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2623         * DumpRenderTree/AccessibilityUIElement.h:
2624         (AccessibilityUIElement::platformUIElement):
2625
2626 2013-12-19  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2627
2628         get_test_baseline should get Host from test_config
2629         https://bugs.webkit.org/show_bug.cgi?id=125989
2630
2631         Reviewed by Ryosuke Niwa.
2632
2633         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2634         (TestConfig.__init__):
2635         (RebaselineServer._prepare_config):
2636         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2637         (get_test_baselines):
2638         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2639         (get_test_config):
2640
2641 2013-12-19  Roger Fong  <roger_fong@apple.com>
2642
2643         Don't check VSINSTALLDIR when looking for Visual Studio install directory.
2644         https://bugs.webkit.org/show_bug.cgi?id=125998.
2645
2646         Reviewed by Alexey Proskuryakov.
2647
2648         * Scripts/webkitdirs.pm:
2649         (visualStudioInstallDir):
2650         Get rid of the VSINSTALLDIR check. We can't build on anything besides VS2013 now anyways.
2651
2652 2013-12-19  Mario Sanchez Prada  <mario.prada@samsung.com>
2653
2654         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
2655         https://bugs.webkit.org/show_bug.cgi?id=125854
2656
2657         Reviewed by Chris Fleizach.
2658
2659         Ensure we don't ever create instances of AccessibilityUIElement
2660         wrapping invalid platform-specific accessibility objects in DRT,
2661         both for consistency with what WKTR does (so we avoid situations
2662         where some tests fail in WK2 and not in WK1) and also to avoid
2663         overlooking tests that might not be checking the right thing.
2664
2665         * DumpRenderTree/AccessibilityUIElement.cpp:
2666         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
2667         nullPtr if the platformUIElement() is not a valid one.
2668         * DumpRenderTree/AccessibilityUIElement.h:
2669         (AccessibilityUIElement::platformUIElement): Added const modifier.
2670
2671 2013-12-18  Anders Carlsson  <andersca@apple.com>
2672
2673         Deprecate some WKMutableDictionary functions
2674         https://bugs.webkit.org/show_bug.cgi?id=125962
2675
2676         Reviewed by Tim Horton.
2677
2678         * TestWebKitAPI/PlatformUtilities.cpp:
2679         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2680         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2681         (TestWebKitAPI::didAssociateFormControls):
2682         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2683         (TestWebKitAPI::WillLoadTest::willLoadURLRequest):
2684         (TestWebKitAPI::WillLoadTest::willLoadDataRequest):
2685         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2686         (WTR::createMouseMessageBody):
2687         (WTR::EventSendingController::mouseMoveTo):
2688         (WTR::EventSendingController::leapForward):
2689         (WTR::createKeyDownMessageBody):
2690         (WTR::EventSendingController::mouseScrollBy):
2691         (WTR::EventSendingController::continuousMouseScrollBy):
2692         (WTR::EventSendingController::addTouchPoint):
2693         (WTR::EventSendingController::updateTouchPoint):
2694         (WTR::EventSendingController::setTouchModifier):
2695         (WTR::EventSendingController::setTouchPointRadius):
2696         (WTR::EventSendingController::touchStart):
2697         (WTR::EventSendingController::touchMove):
2698         (WTR::EventSendingController::touchEnd):
2699         (WTR::EventSendingController::touchCancel):
2700         (WTR::EventSendingController::clearTouchPoints):
2701         (WTR::EventSendingController::releaseTouchPoint):
2702         (WTR::EventSendingController::cancelTouchPoint):
2703         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2704         (WTR::InjectedBundle::done):
2705         (WTR::InjectedBundle::setMockGeolocationPosition):
2706         (WTR::InjectedBundle::setCustomPolicyDelegate):
2707         (WTR::InjectedBundle::setVisibilityState):
2708         (WTR::InjectedBundle::queueLoad):
2709         (WTR::InjectedBundle::queueLoadHTMLString):
2710         * WebKitTestRunner/TestController.cpp:
2711         (WTR::TestController::initialize):
2712         (WTR::TestController::resetStateToConsistentValues):
2713         * WebKitTestRunner/TestInvocation.cpp:
2714         (WTR::updateThreadedScrollingForCurrentTest):
2715         (WTR::updateLayoutType):
2716         (WTR::TestInvocation::invoke):
2717
2718 2013-12-18  Martin Robinson  <mrobinson@igalia.com>
2719
2720         [GTK] [CMake] Add support for building GtkLauncher
2721         https://bugs.webkit.org/show_bug.cgi?id=125766
2722
2723         Reviewed by Gustavo Noronha Silva.
2724
2725         * CMakeLists.txt: Add the GtkLauncher subdirectory for the GTK port.
2726         * GtkLauncher/CMakeLists.txt: Added.
2727         * GtkLauncher/main.c: Support including the CMake config file.
2728
2729 2013-12-18  Alex Christensen  <achristensen@webkit.org>
2730
2731         [WinCairo] Preparation for GStreamer on Windows.
2732         https://bugs.webkit.org/show_bug.cgi?id=125946
2733
2734         Reviewed by Brent Fulgham.
2735
2736         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2737         Use new GStreamer property sheets for WinCairo.
2738         * win/DLLLauncher/DLLLauncherMain.cpp:
2739         (modifyPath):
2740         (wWinMain):
2741         Prepend GStreamer bin directory to path if it exists.
2742
2743 2013-12-18  Anders Carlsson  <andersca@apple.com>
2744
2745         Remove now useless test.
2746
2747         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2748         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
2749         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
2750         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
2751
2752 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
2753
2754         Fix page visibility api test, initialization in WebKit2
2755         https://bugs.webkit.org/show_bug.cgi?id=125933
2756
2757         Reviewed by Anders Carlsson.
2758
2759         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
2760         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
2761
2762         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2763         (TestWebKitAPI::TEST_F):
2764             - Running a test on WebKit1 twice is not the same as running it on WebKit2!
2765
2766 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2767
2768         Should not have identifiers with underscores in them, especially not leading underscores.
2769         https://bugs.webkit.org/show_bug.cgi?id=125847
2770
2771         Reviewed by Darin Adler.
2772
2773         * Scripts/webkitpy/style/checkers/cpp.py:
2774         (check_identifier_name_in_declaration):
2775         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2776         (CppStyleTest.test_runtime_selfinit):
2777         (WebKitStyleTest.test_names):
2778
2779 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2780
2781         False webkit-check-style warnings on *.
2782         https://bugs.webkit.org/show_bug.cgi?id=125915
2783
2784         Reviewed by Darin Adler.
2785
2786         * Scripts/webkitpy/style/checkers/cpp.py:
2787         (check_spacing):
2788         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2789         (CppStyleTest.test_pointer_reference_marker_location):
2790
2791 2013-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2792
2793         prepare-ChangeLog doesn't handle templates properly
2794         https://bugs.webkit.org/show_bug.cgi?id=125853
2795
2796         Reviewed by Daniel Bates.
2797
2798         * Scripts/prepare-ChangeLog:
2799         (get_function_line_ranges_for_cpp):
2800         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2801         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2802         (Class110<TemplateClass>::func36):
2803
2804 2013-12-18  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2805
2806         Move expectation parsing out of the constructor of TestExpectations
2807         https://bugs.webkit.org/show_bug.cgi?id=125439
2808
2809         Reviewed by Csaba Osztrogonác.
2810
2811         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2812         (LayoutTestRunnerTests._run_tests):
2813         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
2814         (LayoutTestRunnerTests.test_update_summary_with_result):
2815         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2816         (Manager.run):
2817         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2818         (ManagerTest.test_look_for_new_crash_logs):
2819         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
2820         (lint):
2821         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2822         (TestExpectations.suffixes_for_expectations):
2823         (TestExpectations.__init__):
2824         (TestExpectations):
2825         (TestExpectations.parse_generic_expectations):
2826         (TestExpectations.parse_default_port_expectations):
2827         (TestExpectations.parse_override_expectations):
2828         (TestExpectations.parse_all_expectations):
2829         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2830         (parse_exp):
2831         (SkippedTests.check):
2832         (SkippedTests.test_skipped_entry_dont_exist):
2833         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2834         (run_results):
2835         * Scripts/webkitpy/tool/commands/queries.py:
2836         (PrintExpectations._model):
2837         * Scripts/webkitpy/tool/commands/rebaseline.py:
2838         (RebaselineTest._update_expectations_file):
2839         (RebaselineExpectations._update_expectations_files):
2840         (RebaselineExpectations._tests_to_rebaseline):
2841
2842 2013-12-17  Jer Noble  <jer.noble@apple.com>
2843
2844         Fix TimeRanges::intersectWith
2845         https://bugs.webkit.org/show_bug.cgi?id=118802
2846
2847         Reviewed by Eric Carlson.
2848
2849         Add unit tests for WebCore/TimeRanges.
2850
2851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2852         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: Added.
2853         (TestWebKitAPI::ToString):
2854         (TestWebKitAPI::TEST):
2855
2856 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
2857
2858         Botwatcher's dashboard ceases to update itself after a while
2859         https://bugs.webkit.org/show_bug.cgi?id=125885
2860
2861         Reviewed by Timothy Hatcher.
2862
2863         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2864         Removed code that checked for the view being hidden. It's none of model's business.
2865
2866         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2867         (BuildbotQueueView): Find out what platform the view is for. Initlialize update timer.
2868         (BuildbotQueueView.prototype._updateHiddenState): Start or stop update timer as appropriate.
2869         We now stop the timer for hidden views.
2870         (BuildbotQueueView.prototype._updateQueues): Removed the logic for ignoring some updates.
2871
2872 2013-12-17  Anders Carlsson  <andersca@apple.com>
2873
2874         Fix the 32-bit build.
2875
2876         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
2877         * MiniBrowser/MiniBrowserWebProcessPlugIn.m:
2878
2879 2013-12-17  Anders Carlsson  <andersca@apple.com>
2880
2881         Give the MiniBrowser a bundle
2882         https://bugs.webkit.org/show_bug.cgi?id=125882
2883
2884         Reviewed by Sam Weinig.
2885
2886         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Added.
2887         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2888         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Added.
2889         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Added.
2890         (-[MiniBrowserWebProcessPlugIn webProcessPlugIn:initializeWithObject:]):
2891         * MiniBrowser/mac/AppDelegate.m:
2892         (-[BrowserAppDelegate init]):
2893         * MiniBrowser/mac/Bundle/Info.plist: Added.
2894         * MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch: Added.
2895
2896 2013-12-17  Gavin Barraclough  <barraclough@apple.com>
2897
2898         Remove PageVisibilityStateUnloaded
2899         https://bugs.webkit.org/show_bug.cgi?id=125869
2900
2901         Reviewed by Anders Carlsson.
2902
2903         This is not currently supported by WebKit, remove this enum value.
2904         We can always add this back later if/when we add support for this state.
2905
2906         * DumpRenderTree/mac/TestRunnerMac.mm:
2907         (TestRunner::setPageVisibility):
2908         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
2909         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
2910         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2911         (WTR::TestRunner::setPageVisibility):
2912             - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
2913
2914 2013-12-12  Martin Robinson  <mrobinson@igalia.com>
2915
2916         [GTK] [CMake] Build the plugin process against GTK+ 2
2917         https://bugs.webkit.org/show_bug.cgi?id=116374
2918
2919         Reviewed by Gustavo Noronha Silva.
2920
2921         * TestWebKitAPI/PlatformGTK.cmake: Add WebCorePlatformGTK to the list of
2922         libraries required for WebCore unit tests.
2923
2924 2013-12-17  Brent Fulgham  <bfulgham@apple.com>
2925
2926         [Win] Revise filter-build-webkit to deal with Windows build logs
2927         https://bugs.webkit.org/show_bug.cgi?id=125866
2928
2929         Reviewed by David Kilzer.
2930
2931         Enhance the script to accept a 'platform' argument. When platform
2932         'win' is provided, use processing for the Windows build file format.
2933         Otherwise, process the files as normal.
2934
2935         * Scripts/filter-build-webkit:
2936         (usageAndExit): Add a 'platform' argument
2937         (shouldIgnoreLine): When platform == 'win' use the new Windows
2938         rules for processing the build file.
2939
2940 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
2941
2942         Update style checker now that ENUM_CLASS is gone
2943         https://bugs.webkit.org/show_bug.cgi?id=125864
2944
2945         Reviewed by Anders Carlsson.
2946
2947         * Scripts/webkitpy/style/checkers/cpp.py:
2948         (_EnumState.process_clean_line):
2949         (check_braces):
2950         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2951         (NoNonVirtualDestructorsTest.test_enum_casing.Foo):
2952         (NoNonVirtualDestructorsTest.test_enum_casing):
2953         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123):
2954         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass):
2955         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum):
2956         (WebKitStyleTest.test_braces.CPP11EnumClass):
2957
2958 2013-12-17  Mario Sanchez Prada  <mario.prada@samsung.com>
2959
2960         [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
2961         https://bugs.webkit.org/show_bug.cgi?id=125857
2962
2963         Reviewed by Chris Fleizach.
2964
2965         Add mappings to DRT & WKTR for the newly exposed roles, and
2966         increase the version of ATK used by the internal jhbuild.
2967
2968         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2969         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2970         * gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
2971
2972 2013-12-17  Alex Christensen  <achristensen@webkit.org>
2973
2974         [WinCairo] Adding support for GStreamer and GLib.
2975         https://bugs.webkit.org/show_bug.cgi?id=124867
2976
2977         Reviewed by Philippe Normand.
2978
2979         * WinLauncher/WinLauncher.cpp:
2980         (wWinMain):
2981         Added g_main_context_iteration in main event loop.
2982
2983 2013-12-17  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2984
2985         Fix for C++ should have the & or * beside the type not the variable name check.
2986         https://bugs.webkit.org/show_bug.cgi?id=125846
2987
2988         Reviewed by Darin Adler.
2989
2990         * Scripts/webkitpy/style/checkers/cpp.py:
2991         (check_spacing):
2992         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2993         (CppStyleTest.test_pointer_reference_marker_location):
2994
2995 2013-12-16  Rob Buis  <rob.buis@samsung.com>
2996
2997         Add my Samsung email address.
2998
2999         Unreviewed.
3000
3001         * Scripts/webkitpy/common/config/contributors.json:
3002
3003 2013-12-16  Oliver Hunt  <oliver@apple.com>
3004
3005         Cache getters and custom accessors on the prototype chain
3006         https://bugs.webkit.org/show_bug.cgi?id=125602
3007
3008         Reviewed by Michael Saboff.
3009
3010         Make sure bencher scripts also make noInline exist
3011
3012         * Scripts/bencher:
3013
3014 2013-12-16  Anders Carlsson  <andersca@apple.com>
3015
3016         Fix crash when trying to load a null HTML string
3017         https://bugs.webkit.org/show_bug.cgi?id=125801
3018
3019         Reviewed by Dan Bernstein.
3020
3021         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
3022         (TestWebKitAPI::TEST_F):
3023         Update test results.
3024
3025 2013-12-16  Alex Christensen  <achristensen@webkit.org>
3026
3027         Fixed Win64 build on VS2013.
3028         https://bugs.webkit.org/show_bug.cgi?id=125753
3029
3030         Reviewed by Brent Fulgham.
3031
3032         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3033         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3034         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3035         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3036         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3037         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3038         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3039         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3040         * win/record-memory/record-memory.vcxproj:
3041         Added correct PlatformToolset for 64-bit builds.
3042
3043 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
3044
3045         Add a menu option to MiniBrowser to enable UI-side compositing
3046         https://bugs.webkit.org/show_bug.cgi?id=125793
3047
3048         Reviewed by Anders Carlsson.
3049         
3050         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
3051
3052         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
3053         to toggle UI-side compositing.
3054         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
3055         * MiniBrowser/mac/WK2BrowserWindowController.m:
3056         (-[WK2BrowserWindowController validateMenuItem:]):
3057         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
3058         (-[WK2BrowserWindowController toggleUISideCompositing:]):
3059         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3060         Adjust the window title to indicate whether the window is using UI-side compositing.
3061
3062 2013-12-16  Commit Queue  <commit-queue@webkit.org>
3063
3064         Unreviewed, rolling out r160645.
3065         http://trac.webkit.org/changeset/160645
3066         https://bugs.webkit.org/show_bug.cgi?id=125787
3067
3068         Change breaks test-webkitpy (Requested by bfulgham on
3069         #webkit).
3070
3071         * Scripts/prepare-ChangeLog:
3072         (get_selector_line_ranges_for_css):
3073
3074 2013-12-16  David Farler  <dfarler@apple.com>
3075
3076         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
3077         https://bugs.webkit.org/show_bug.cgi?id=124610
3078
3079         Reviewed by Mark Rowe.
3080
3081         * WebKitLauncher/WebKitNightlyEnabler.m:
3082         (enableWebKitNightlyBehaviour):
3083         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
3084         * WebKitLauncher/main.m:
3085         (main):
3086         Include both libasancrashreporter and the nightly enabler to
3087         the list of libraries to insert.
3088
3089 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3090
3091         Resolve inconsistant style warning caused by r160319.
3092         https://bugs.webkit.org/show_bug.cgi?id=125772
3093
3094         Reviewed by Darin Adler.
3095
3096         * Scripts/webkitpy/style/checkers/cpp.py:
3097         (check_for_extra_new_line_at_eof):
3098         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3099         (CppStyleTest.test_newline_at_eof):
3100         (CppStyleTest.test_extra_newlines_at_eof):
3101
3102 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
3103
3104         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
3105         https://bugs.webkit.org/show_bug.cgi?id=125780
3106
3107         Reviewed by Darin Adler.
3108
3109         * Scripts/webkitpy/port/mock_drt.py:
3110         (main):
3111         (parse_options):
3112         (MockDRT.write_test_output):
3113         * Scripts/webkitpy/port/mock_drt_unittest.py:
3114         (MockDRTTest.assertTest):
3115         (MockDRTTest.test_reftest_mismatch):
3116
3117 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3118
3119         prepare-Changelog treats CSS keyframes as mismatched parentheses.
3120         https://bugs.webkit.org/show_bug.cgi?id=125435
3121
3122         Reviewed by Darin Adler.
3123
3124         * Scripts/prepare-ChangeLog:
3125         (get_selector_line_ranges_for_css):
3126
3127 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
3128
3129         [ATK] Expose accessibility objects for more WAI-ARIA roles
3130         https://bugs.webkit.org/show_bug.cgi?id=125596
3131
3132         Reviewed by Chris Fleizach.
3133
3134         Add mappings to DRT & WKTR for the newly exposed roles.
3135
3136         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3137         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3138
3139 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
3140
3141         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
3142         https://bugs.webkit.org/show_bug.cgi?id=125594
3143
3144         Reviewed by Chris Fleizach.
3145
3146         Add mappings to DRT & WKTR for checkmenuitem role.
3147
3148         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3149         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3150
3151 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
3152
3153         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
3154         https://bugs.webkit.org/show_bug.cgi?id=125587
3155
3156         Reviewed by Chris Fleizach.
3157
3158         Add mappings to DRT & WKTR for article roles.
3159
3160         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3161         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3162
3163 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
3164
3165         [FTL] Allow EFL to build FTL with the build-jsc script.
3166         https://bugs.webkit.org/show_bug.cgi?id=125774
3167
3168         Reviewed by Zoltan Herczeg.
3169
3170         * Scripts/build-jsc:
3171
3172 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
3173
3174         Add myself as a committer
3175
3176         Unreviewed.
3177
3178         * Scripts/webkitpy/common/config/contributors.json:
3179
3180 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3181
3182         Refactor option handling in WebKitTestRunner.
3183         https://bugs.webkit.org/show_bug.cgi?id=123185
3184
3185         Reviewed by Darin Adler.
3186
3187         Option handling is refactored (according to the FIXME) that allows
3188         to automatically generate the help message.
3189
3190         * WebKitTestRunner/CMakeLists.txt:
3191         * WebKitTestRunner/GNUmakefile.am:
3192         * WebKitTestRunner/Options.cpp: Added.
3193         (WTR::Options::Options):
3194         (WTR::handleOptionTimeout):
3195         (WTR::handleOptionNoTimeout):
3196         (WTR::handleOptionNoTimeoutAtAll):
3197         (WTR::handleOptionVerbose):
3198         (WTR::handleOptionGcBetweenTests):
3199         (WTR::handleOptionPixelTests):
3200         (WTR::handleOptionPrintSupportedFeatures):
3201         (WTR::handleOptionComplexText):
3202         (WTR::handleOptionAcceleratedDrawing):
3203         (WTR::handleOptionRemoteLayerTree):
3204         (WTR::handleOptionUnmatched):
3205         (WTR::OptionsHandler::OptionsHandler):
3206         (WTR::Option::Option):
3207         (WTR::Option::matches):
3208         (WTR::OptionsHandler::parse):
3209         (WTR::OptionsHandler::printHelp):
3210         * WebKitTestRunner/Options.h: Added.
3211         * WebKitTestRunner/TestController.cpp:
3212         (WTR::TestController::initialize):
3213         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3214
3215 2013-12-15  Dan Bernstein  <mitz@apple.com>
3216
3217         32-bit build fix.
3218
3219         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3220         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
3221
3222 2013-12-14  Tim Horton  <timothy_horton@apple.com>
3223
3224         stylebot should warn when FeatureDefines differ
3225         https://bugs.webkit.org/show_bug.cgi?id=125748
3226
3227         Reviewed by Dan Bernstein.
3228
3229         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
3230         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
3231         an unlikely occurrance, to add them to the list).
3232
3233         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
3234         but that is the most straightforward way to implement it (and we're at zero diffs right now).
3235
3236         * Scripts/webkitpy/style/checker.py:
3237         (_all_categories):
3238         (FileType):
3239         (CheckerDispatcher._file_type):
3240         (CheckerDispatcher._create_checker):
3241         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
3242         (FeatureDefinesChecker):
3243         (FeatureDefinesChecker.__init__):
3244         (FeatureDefinesChecker.check):
3245
3246 2013-12-13  Sam Weinig  <sam@webkit.org>
3247
3248         Fix API tests.
3249
3250         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
3251         (TestWebKitAPI::TEST_F):
3252
3253 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
3254
3255         [Win] Remove Pre-VS2013 support code.
3256         https://bugs.webkit.org/show_bug.cgi?id=125693
3257
3258         Reviewed by Darin Adler.
3259
3260         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
3261         the math library.
3262         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
3263
3264 2013-12-13  Lucas Forschler  <lforschler@apple.com>
3265
3266         Update Webkit bots.
3267         
3268         Unreviewed.
3269         
3270         * BuildSlaveSupport/build.webkit.org-config/config.json:
3271
3272 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
3273
3274         [Win] Unreviewed build fix after r160548
3275
3276         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
3277         we are using vs12_xp target for Makefile-based projects.
3278
3279 2013-12-13  Lucas Forschler  <lforschler@apple.com>
3280
3281         Update Apple Webkit Bots
3282         
3283         Unreviewed.
3284
3285         * BuildSlaveSupport/build.webkit.org-config/config.json:
3286
3287 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
3288
3289         Unreviewed build fix after r160548.
3290
3291         * Scripts/webkitdirs.pm:
3292         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
3293
3294 2013-12-13  Lucas Forschler  <lforschler@apple.com>
3295
3296         Update Apple bots.
3297         
3298         Unreviewed.
3299
3300         * BuildSlaveSupport/build.webkit.org-config/config.json:
3301
3302 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
3303
3304         [Win] Switch WebKit solution to Visual Studio 2013
3305         https://bugs.webkit.org/show_bug.cgi?id=125192
3306
3307         Reviewed by Anders Carlsson.
3308
3309         Project files must reference vs12_xp for 32-bit builds. 
3310
3311         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3312         Update for VS2013
3313         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3314         Ditto
3315         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3316         Ditto
3317         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3318         Ditto
3319         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3320         Ditto
3321         * Scripts/webkitdirs.pm:
3322         (visualStudioInstallDir): Specify VS2013
3323         (visualStudioVersion): Ditto.
3324         (setupAppleWinEnv): Use VS2013 in messages
3325         (setupCygwinEnv): Ditto
3326         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3327         Update for VS2013
3328         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3329         Ditto
3330         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3331         Ditto
3332         * win/record-memory/record-memory.vcxproj:
3333         Ditto
3334
3335 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
3336
3337         Adding a .ycm_extra_conf file for webkitGtk
3338         https://bugs.webkit.org/show_bug.cgi?id=119618
3339
3340         Reviewed by Gustavo Noronha Silva.
3341
3342         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
3343         read the GTK+ build files to determine dynamically what flags to compile a source
3344         file with. This allows Vim to provide auto-complete for C++/C language. See
3345         https://github.com/Valloric/YouCompleteMe for how to use this file.
3346
3347         * gtk/common.py:
3348         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
3349         * gtk/ycm_extra_conf.py: Added.
3350
3351 2013-12-12  Tim Horton  <timothy_horton@apple.com>
3352
3353         [wk2] Handle pinch-to-zoom gesture
3354         https://bugs.webkit.org/show_bug.cgi?id=125604
3355
3356         Reviewed by Simon Fraser.
3357
3358         * MiniBrowser/mac/WK2BrowserWindowController.m:
3359         (-[WK2BrowserWindowController awakeFromNib]):
3360         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
3361
3362 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
3363
3364         Unreviewed. Add myself as a committer.
3365
3366         * Scripts/webkitpy/common/config/contributors.json:
3367
3368 2013-12-12  Lucas Forschler  <lforschler@apple.com>
3369
3370         Update hardware for Apple bots.
3371         
3372         Unreviewed.
3373
3374         * BuildSlaveSupport/build.webkit.org-config/config.json:
3375
3376 2013-12-12  Lucas Forschler  <lforschler@apple.com>
3377
3378         Remove unused Apple Bots.
3379         
3380         Unreviewed.
3381
3382         * BuildSlaveSupport/build.webkit.org-config/config.json:
3383
3384 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
3385
3386         Unreviewed. Add myself as a committer.
3387
3388         * Scripts/webkitpy/common/config/contributors.json:
3389
3390 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
3391
3392         Test new JSContext name APIs
3393         https://bugs.webkit.org/show_bug.cgi?id=125607
3394
3395         Reviewed by Darin Adler.
3396
3397         * Scripts/run-javascriptcore-tests:
3398         Remove trailing whitespace.
3399
3400 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
3401
3402         [Autotools] Prepend the WebCore layer archives' names with 'lib'
3403         https://bugs.webkit.org/show_bug.cgi?id=125627
3404
3405         Reviewed by Martin Robinson.
3406
3407         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
3408         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
3409
3410 2013-12-12  Commit Queue  <commit-queue@webkit.org>
3411
3412         Unreviewed, rolling out r160446.
3413         http://trac.webkit.org/changeset/160446
3414         https://bugs.webkit.org/show_bug.cgi?id=125630
3415
3416         The upower-glib-based implementation is using API that was
3417         recently removed (Requested by zdobersek1 on #webkit).
3418
3419         * Scripts/webkitperl/FeatureList.pm:
3420
3421 2013-12-12  Commit Queue  <commit-queue@webkit.org>
3422
3423         Unreviewed, rolling out r160417.
3424         http://trac.webkit.org/changeset/160417
3425         https://bugs.webkit.org/show_bug.cgi?id=125629
3426
3427         The patch is causing crashes (Requested by zdobersek1 on
3428         #webkit).
3429
3430         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3431         (axObjectEventListener):
3432         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3433
3434 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
3435
3436         Use of ar T option not supported by older binutils
3437         https://bugs.webkit.org/show_bug.cgi?id=118732
3438
3439         Reviewed by Gustavo Noronha Silva.
3440
3441         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
3442         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
3443         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
3444         of the member's object file, and not the full path to it. To work around that, all the object files
3445         under the build directory are listed by their relative paths. The members of various archives then have
3446         the basenames of their paths grepped against that list, with the found path correlating to the member
3447         finally added as the new member of the WebCoreLayer archive.
3448
3449 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
3450
3451         check-webkit-style shouldn't check spacing in #if preprocessor lines
3452         https://bugs.webkit.org/show_bug.cgi?id=125534
3453
3454         Reviewed by Ryosuke Niwa.
3455
3456         Preprocessor lines that start with #if shouldn't have to adhere to
3457         the same spacing requirements that regular code does
3458
3459         * Scripts/webkitpy/style/checkers/cpp.py:
3460         (check_spacing):
3461         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3462         (CppStyleTest.test_spacing_for_binary_ops):
3463         (WebKitStyleTest.test_line_breaking):
3464
3465 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
3466
3467         check-webkit-style can't determine if a comma is part of an initialization list
3468         https://bugs.webkit.org/show_bug.cgi?id=125537
3469
3470         Reviewed by Darin Adler.
3471
3472         The original check to make sure that initialization list lines start with
3473         a comma didn't distinguish between commas that belong to the initialization
3474         list and commas that are part of function calls. Because we don't want to
3475         match parentheses with regular expressions, we should weaken this check to
3476         only check for commas at the end of initialization list lines.
3477
3478         * Scripts/webkitpy/style/checkers/cpp.py:
3479         (check_member_initialization_list):
3480         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3481         (WebKitStyleTest.test_member_initialization_list):
3482
3483 2013-12-11  Tim Horton  <timothy_horton@apple.com>
3484
3485         Make it possible to compare layout test results between various configurations of WebKit
3486         https://bugs.webkit.org/show_bug.cgi?id=125212
3487         <rdar://problem/15199108>
3488
3489         Reviewed by Darin Adler.
3490
3491         * Scripts/compare-webkit-configurations: Added.
3492         Add a script that allows comparison between the "normal" WebKit configuration
3493         used for testing and a different configuration (e.g. with accelerated drawing
3494         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
3495
3496         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
3497
3498         This script runs the tests once in the default configuration, ignoring
3499         all test expectations, writing the results out to a temporary directory.
3500
3501         It then runs the tests again in the modified configuration, against the
3502         just-written temporary results.
3503
3504         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
3505
3506         * DumpRenderTree/mac/DumpRenderTree.mm:
3507         (resetWebPreferencesToConsistentValues):
3508         (initializeGlobalsFromCommandLineOptions):
3509         Enable accelerated drawing if requested.
3510
3511         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3512         (parse_args):
3513         Add --accelerated-drawing and --remote-layer-tree feature switches, which
3514         are forwarded on to the test drivers.
3515         Move those two and --complex-text into their own "feature switches" section.
3516         Drive-by change "Mac OS X" to "OS X".
3517         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
3518         as traditional pixel tests (with PNGs dumped on disk), and
3519         ignores e.g. -expected.html files.
3520
3521         * Scripts/webkitpy/port/base.py:
3522         (Port.reference_files):
3523         Pretend that there are no ref tests.
3524         Since is_reference_html_file is intact, our mechanism to ignore
3525         the expected files will continue working in this case.
3526
3527         * Scripts/webkitpy/port/driver.py:
3528         (Driver.cmd_line):
3529         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
3530
3531         * WebKitTestRunner/TestController.cpp:
3532         (WTR::TestController::TestController):
3533         (WTR::TestController::initialize):
3534         (WTR::TestController::resetPreferencesToConsistentValues):
3535         * WebKitTestRunner/TestController.h:
3536         (WTR::TestController::shouldUseRemoteLayerTree):
3537         * WebKitTestRunner/TestInvocation.cpp:
3538         (WTR::updateThreadedScrollingForCurrentTest):
3539         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3540         (WTR::PlatformWebView::PlatformWebView):
3541         Parse and implement the three feature switches.
3542
3543 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
3544
3545         [ATK] Expose accessibility objects WAI-ARIA landmark roles
3546         https://bugs.webkit.org/show_bug.cgi?id=125584
3547
3548         Reviewed by Chris Fleizach.
3549
3550         Add mappings to DRT & WKTR for landmark roles.
3551
3552         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3553         (AccessibilityUIElement::role):
3554         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3555         (WTR::AccessibilityUIElement::role):
3556         * gtk/jhbuild.modules:
3557
3558 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
3559
3560         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
3561         https://bugs.webkit.org/show_bug.cgi?id=125441
3562
3563         Reviewed by Martin Robinson.
3564
3565         Just avoid the double quotations when building the parameter
3566         because some versions of valgrind are not handling it correctly.
3567
3568         * Scripts/webkitpy/port/gtk.py:
3569         (GtkPort.setup_environ_for_server):
3570
3571 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
3572
3573         [GTK] Enable Battery Status API
3574         https://bugs.webkit.org/show_bug.cgi?id=125453
3575
3576         Reviewed by Martin Robinson.
3577
3578         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
3579
3580 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
3581
3582         [GTK][WK2] Add the WebKitBatteryProvider class
3583         https://bugs.webkit.org/show_bug.cgi?id=115720
3584
3585         Reviewed by Martin Robinson.
3586
3587         * gtk/generate-gtkdoc:
3588         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
3589
3590 2013-12-11  Mark Rowe  <mrowe@apple.com>
3591
3592         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
3593
3594         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
3595         to build and maintain this custom Perl module.