Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-24  Dan Bernstein  <mitz@apple.com>
2
3         Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.
4
5         Reviewed by Anders Carlsson.
6
7         * Scripts/webkitdirs.pm:
8         (determineBaseProductDir):
9
10 2011-12-24  Dan Bernstein  <mitz@apple.com>
11
12         Make build-webkit aware of additional Xcode build location defaults.
13
14         Reviewed by Anders Carlsson.
15
16         * Scripts/webkitdirs.pm:
17         (determineXcodeVersion): Added. This was previously in determineBaseProductDir().
18         (readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
19         (determineBaseProductDir): Changed to check for a custom build location
20         style specified as an absolute location.
21
22 2011-12-24  Ryosuke Niwa  <rniwa@webkit.org>
23
24         Unreviewed, rolling out r103619.
25         http://trac.webkit.org/changeset/103619
26         https://bugs.webkit.org/show_bug.cgi?id=66509
27
28         Broke chromium clang build
29
30         * DumpRenderTree/chromium/TestWebWorker.h:
31         (TestWebWorker::createWorker):
32         * DumpRenderTree/chromium/WebViewHost.cpp:
33         (WebViewHost::createWorker):
34         * DumpRenderTree/chromium/WebViewHost.h:
35
36 2011-12-23  Daniel Bates  <dbates@webkit.org>
37
38         Provide option to disable Mac OS 10.7 application resume when using
39         {debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
40         https://bugs.webkit.org/show_bug.cgi?id=66902
41
42         Reviewed by David Kilzer.
43
44         Add an optional command line argument --no-saved-state to disable
45         application resume (state restoration) for the session on Mac OS 10.7.
46
47         For instance, when debugging an issue in Safari it is useful to be able
48         to temporarily disable application resume. Currently you can disable
49         application resume when launching Safari from within Xcode. We should
50         expose a similar option in our command line tools.
51
52         * Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()
53         to print a help message and exit() if the command line argument --help was given.
54         * Scripts/debug-safari: Ditto.
55         * Scripts/debug-test-runner: Ditto.
56         * Scripts/run-minibrowser: Ditto.
57         * Scripts/run-safari: Ditto.
58         * Scripts/run-test-runner: Ditto.
59         * Scripts/run-test-webkit-api: Ditto.
60         * Scripts/run-webkit-app: Ditto.
61         * Scripts/webkitdirs.pm:
62         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
63         (argumentsForRunAndDebugMacWebKitApp): Added.
64         (runMacWebKitApp): If the --no-saved-state command line argument was given then
65         disable application resume for the session.
66         (execMacWebKitAppForDebugging): Ditto.
67
68 2011-12-23  Dmitry Lomov  <dslomov@google.com>
69
70         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
71         https://bugs.webkit.org/show_bug.cgi?id=66509
72         Just renames, merges and removal of dead code. Here are the list of renames:
73           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
74           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
75           - WebWorkerBase merged into WebSharedWorkerImpl
76           - NewWebWorkerBase renamed into WebWorkerBase
77  
78         Reviewed by David Levin.
79
80         * DumpRenderTree/chromium/TestWebWorker.h:
81         (TestWebWorker::createWorker):
82         * DumpRenderTree/chromium/WebViewHost.cpp:
83         (WebViewHost::createWorker):
84         * DumpRenderTree/chromium/WebViewHost.h:
85
86 2011-12-23  Kentaro Hara  <haraken@chromium.org>
87
88         Let parser_unittests.pl call different language parsers
89         https://bugs.webkit.org/show_bug.cgi?id=75081
90
91         Reviewed by David Kilzer.
92
93         We introduced parser_unittests.pl in bug 74994 , but it is implemented
94         to always call get_function_line_ranges_for_perl(). In order to enable unittests
95         for other languages, this patch lets parser_unittests.pl call different language
96         parsers depending on the languages.
97
98         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
99
100         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
101
102 2011-12-22  Adam Roben  <aroben@apple.com>
103
104         Snow Leopard test fix
105
106         * Scripts/webkitpy/test/main.py:
107         (Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to
108         unittest.main, even though that's the default. So now we explicitly specify a
109         TextTestRunner.
110
111 2011-12-22  Chris Fleizach  <cfleizach@apple.com>
112
113         AX: attributed strings do not include AXHeading information when a link is contained within the heading
114         https://bugs.webkit.org/show_bug.cgi?id=75059
115
116         Reviewed by Darin Adler.
117
118         Support the ability to check if an arbitrary attribute is present within an
119         attributed string that can be retrieved through an AccessibilityTextMarkerRange.
120
121         * DumpRenderTree/AccessibilityUIElement.cpp:
122         (attributedStringForTextMarkerRangeContainsAttributeCallback):
123         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
124         (AccessibilityUIElement::getJSClass):
125         * DumpRenderTree/AccessibilityUIElement.h:
126         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
127         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
128         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
129         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
130         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
131         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
132         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
133         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
134
135 2011-12-22  David Kilzer  <ddkilzer@apple.com>
136
137         run-api-tests: runAllTests() and runTest() should not use global variables
138
139         Reviewed by Adam Roben.
140
141         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
142
143         * Scripts/run-api-tests:
144         (runTestsBySuite): Rename from runAllTests().  Add arguments for
145         list of tests and $verbose.
146         (runTest): Add $verbose argument.
147
148 2011-12-22  David Kilzer  <ddkilzer@apple.com>
149
150         run-api-tests: inline runAllTestsInSuite() into runAllTests()
151
152         Reviewed by Adam Roben.
153
154         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
155
156         In order to make it easy to run one or more individual suites,
157         or one more individual tests, it's easier to call a single
158         method with different data structures than individual methods.
159
160         * Scripts/run-api-tests:
161         (runAllTests): Inline runAllTestsInSuite().
162
163 2011-12-22  Adam Roben  <aroben@apple.com>
164
165         Add a --xml flag to test-webkitpy
166
167         test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
168         JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
169         This is useful for working with tools that consume JUnit-style XML files.
170
171         Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
172         running test-webkitpy
173
174         Reviewed by Darin Adler.
175
176         * Scripts/webkitpy/test/main.py:
177         (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
178         unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
179
180         * Scripts/webkitpy/thirdparty/__init__.py:
181         (AutoinstallImportHook.find_module):
182         (AutoinstallImportHook._install_xmlrunner):
183         Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
184         This change is untested because it's basically impossible to get a test to pass when --xml
185         is passed to test-webkitpy (because xmlrunner will already have been imported by the time
186         the test runs).
187
188 2011-12-22  David Kilzer  <ddkilzer@apple.com>
189
190         TestWebKitAPI: initialize the main thread before running tests
191         <http://webkit.org/b/75064>
192
193         Reviewed by Adam Roben.
194
195         * TestWebKitAPI/TestsController.cpp:
196         (TestWebKitAPI::TestsController::TestsController): Call
197         WTF::initializeMainThread() to prevent assertions in Debug
198         builds.
199
200 2011-12-22  David Kilzer  <ddkilzer@apple.com>
201
202         run-api-tests: dumpAllTests() should not use global variables
203
204         Reviewed by Adam Roben.
205
206         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
207
208         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
209         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
210         global data as an argument.  Sort suite names and test names
211         alphabetically to match output when running tests.
212
213 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
214
215         [BlackBerry] Enable blob for the BlackBerry porting
216         https://bugs.webkit.org/show_bug.cgi?id=75074
217
218         Reviewed by George Staikos.
219
220         * Scripts/build-webkit:
221
222 2011-12-22  Kentaro Hara  <haraken@chromium.org>
223
224         Add unittests for the Perl parser of prepare-ChangeLog
225         https://bugs.webkit.org/show_bug.cgi?id=74994
226
227         Reviewed by David Kilzer.
228
229         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
230
231         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
232
233         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
234         Runs unittests specified in @testFiles.
235         You can reset expected results by specifying a --reset-results option.
236         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
237         Contains simple methods.
238         (func1):
239         (func2):
240         (func3):
241         (func4):
242         (func5):
243         (func6):
244         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
245         This test result is generated by the --reset-results option.
246
247 2011-12-21  Eric Seidel  <eric@webkit.org>
248
249         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
250         so that they appear in the bugzilla autocomplete CC list.
251         I also removed the "radar" irc nick (which I believe does not exist)
252         and removed the uneeded [] around the radar bugzilla email.
253
254         Unreviewed.
255
256         * Scripts/webkitpy/common/config/committers.py:
257
258 2011-12-21  Daniel Bates  <dbates@rim.com>
259
260         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
261         https://bugs.webkit.org/show_bug.cgi?id=74985
262
263         Reviewed by Eric Seidel.
264
265         * Scripts/build-jsc:
266         * Scripts/webkitdirs.pm:
267         (cmakeBasedPortName): Added.
268
269 2011-12-21  Daniel Bates  <dbates@rim.com>
270
271         Extract BlackBerry CMake arguments from build-webkit into separate function
272         https://bugs.webkit.org/show_bug.cgi?id=74981
273
274         Reviewed by Rob Buis.
275
276         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
277         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
278         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
279         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
280         that we can pass them to the CMake build system when building JavaScriptCore.
281
282         * Scripts/build-webkit: Move construction of CMake argument list from here to
283         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
284         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
285         call it from build-webkit.
286         * Scripts/webkitdirs.pm:
287         (blackberryCMakeArguments): Added.
288         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
289         BlackBerry port.
290
291 2011-12-21  Daniel Bates  <dbates@webkit.org>
292
293         Extract WinCE CMake arguments from build-webkit into separate function
294         https://bugs.webkit.org/show_bug.cgi?id=74983
295
296         Reviewed by Rob Buis.
297
298         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
299         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
300         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
301         that we can pass it to the CMake build system when building JavaScriptCore.
302
303         * Scripts/build-webkit:
304         * Scripts/webkitdirs.pm:
305         (cmakeBasedPortArguments): Added.
306
307 2011-12-21  Kentaro Hara  <haraken@chromium.org>
308
309         In prepare-ChangeLog, replace constant global variables with "use constant"
310         https://bugs.webkit.org/show_bug.cgi?id=74992
311
312         Reviewed by Ryosuke Niwa.
313
314         This patch replaces the following constant global variables with "use constant"s.
315             - $changeLogTimeZone
316             - $SVN
317             - $GIT
318             - %supportedTestExtensions
319
320         * Scripts/prepare-ChangeLog:
321         (changeLogNameFromArgs):
322         (changeLogEmailAddressFromArgs):
323         (resolveConflictedChangeLogs):
324         (generateNewChangeLogs):
325         (diffCommand):
326         (statusCommand):
327         (createPatchCommand):
328         (findOriginalFileFromSvn):
329         (determinePropertyChanges):
330         (generateFileList):
331         (reviewerAndDescriptionForGitCommit):
332
333 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
334
335         nrwt: rename field references from _fs to _filesystem
336         https://bugs.webkit.org/show_bug.cgi?id=74898
337
338         Reviewed by Adam Barth.
339
340         This is a simple cleanup; most of the code uses
341         self._filesystem, but some used self._fs; this change renames
342         the latter to the former to be more consistent.
343
344         * Scripts/webkitpy/layout_tests/controllers/manager.py:
345         (Manager.__init__):
346         (Manager.collect_tests):
347         (Manager._strip_test_dir_prefix):
348         (Manager._split_into_chunks_if_necessary):
349         (Manager.results_directory):
350         (Manager._clobber_old_results):
351         (Manager._upload_json_files):
352         (Manager.print_config):
353         (Manager._copy_results_html_file):
354         (Manager._show_results_html_file):
355         (Manager._log_worker_stack):
356         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
357         (JSONLayoutResultsGenerator._normalize_results_json):
358         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
359         (JSONResultsGeneratorBase.__init__):
360         (JSONResultsGeneratorBase.generate_json_output):
361         (JSONResultsGeneratorBase.generate_times_ms_file):
362         (JSONResultsGeneratorBase.upload_json_files):
363         (JSONResultsGeneratorBase._get_svn_revision):
364         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
365         (Base.__init__):
366
367 2011-12-20  Kentaro Hara  <haraken@chromium.org>
368
369         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
370         https://bugs.webkit.org/show_bug.cgi?id=74836
371
372         Reviewed by David Kilzer.
373
374         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
375         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
376         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
377         of prepare-ChangeLog.
378
379         Using LoadAsModule.pm, you can load a Perl script as follows.
380         The first argument is the arbitrary package name you want to use, and the second argument
381         is the name of the Perl script you want to load.
382
383             use LoadAsModule qw(RunLeaks run-leaks);
384             RunLeaks::someFunctionDefinedInRunLeaks(...);
385
386         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
387                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
388                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
389
390         * Scripts/webkitperl/LoadAsModule.pm: Added.
391         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
392         (import):
393         (readFile):
394         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
395         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
396         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
397
398 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
399
400         [Qt] WK2 Debugging quirks need some improvement
401         https://bugs.webkit.org/show_bug.cgi?id=74859
402
403         Reviewed by Simon Hausmann.
404
405         Improvements added to make debugging WebKit2 more
406         confortable and efficient:
407         1. Unify debugging quirks. From now all of them are controlled
408         by the QT_WEBKIT2_DEBUG environment variable.
409         2. Disable crash handlers for WebKitTestRunner if debugging quirks
410         are used to make it possible to use postmortem debugging via core dumps
411         which is extremely useful for debugging bugs triggered by layout tests.
412         3. Disable test timeout for WebKitTestRunner if debugging quirks
413         are used because that makes debugging impossible.
414
415         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
416         (WTR::InjectedBundle::platformInitialize):
417         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
418         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
419         * WebKitTestRunner/qt/TestControllerQt.cpp:
420         (WTR::TestController::platformRunUntil):
421
422 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
423
424         [Qt][WK2] Implement favicon support
425         https://bugs.webkit.org/show_bug.cgi?id=71082
426
427         Reviewed by Simon Hausmann.
428
429         A favorite icon was added on MiniBrowser's url bar as example.
430         We display a default icon when the page doesn't have an icon ready.
431
432         * MiniBrowser/qt/MiniBrowser.qrc:
433         * MiniBrowser/qt/icons/favicon.png: Added.
434         * MiniBrowser/qt/qml/BrowserWindow.qml:
435
436 2011-12-19  Sam Weinig  <sam@webkit.org>
437
438         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
439         https://bugs.webkit.org/show_bug.cgi?id=74907
440
441         Reviewed by Dan Bernstein.
442
443         Add ScrollByLineCommands API test.
444
445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
446         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
447         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
448
449 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
450
451         webkitpy: remove port.executive, port.filesystem, port.user properties
452         https://bugs.webkit.org/show_bug.cgi?id=74896
453
454         Reviewed by Eric Seidel.
455
456         Following on the refactoring of the port and host objects, this
457         removes the public executive, filesystem, and user properties
458         from the Port interface (protected versions of executive and
459         filesystem still exist). There is still some more clean up to
460         make the code more consistent and rearrange some other files to
461         talk to Hosts directly instead of getting them off of the Port
462         class.
463
464         * Scripts/webkitpy/layout_tests/controllers/manager.py:
465         (Manager.__init__):
466         (Manager.results_directory):
467         (Manager._log_worker_stack):
468         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
469         (ManagerTest.test_fallback_path_in_config):
470         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
471         (_InlineManager.start_worker):
472         (_InlineWorkerConnection.__init__):
473         * Scripts/webkitpy/layout_tests/controllers/worker.py:
474         (Worker.safe_init):
475         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
476         (TestConfiguration.from_port):
477         * Scripts/webkitpy/layout_tests/port/base.py:
478         (Port.__init__):
479         (Port.tests):
480         (Port.show_results_html_file):
481         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
482         (PortTest.test_layout_tests_skipping):
483         (PortTest.test_test_dirs):
484         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
485         (_set_up_derived_options):
486         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
487         (PerfTestsRunner.__init__):
488         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
489         (HtmlGenerator.__init__):
490         (HtmlGenerator.show_html):
491         (real_main):
492         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
493         (TestHtmlGenerator.make_generator):
494
495 2011-12-19  Daniel Bates  <dbates@webkit.org>
496
497         Pass command line arguments to GDB when debugging a Mac WebKit application
498         https://bugs.webkit.org/show_bug.cgi?id=72829
499
500         Reviewed by David Kilzer.
501
502         Pass through any command line arguments given to debug-{safari, minibrowser}
503         to GDB so that they may influence the application instance launched by GDB.
504
505         * Scripts/webkitdirs.pm:
506         (execMacWebKitAppForDebugging):
507
508 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
509
510         webkitpy: remove executive,filesystem,user parameters from Port constructor
511         https://bugs.webkit.org/show_bug.cgi?id=74878
512
513         Reviewed by Eric Seidel.
514
515         This change concludes the refactoring that makes Host a required
516         parameter for Port and ensures that all access to filesystem,
517         executives, etc. is going through the Host.
518
519         * Scripts/webkitpy/layout_tests/port/base.py:
520         (Port.__init__):
521
522 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
523
524         webkitpy: finish refactoring port classes to make a host mandatory
525         https://bugs.webkit.org/show_bug.cgi?id=74566
526
527         Reviewed by Eric Seidel.
528
529         This change makes all Port objects take a required (System)Host
530         parameter, and updates the TestPort object to no longer create a
531         mock filesystem or add files to the existing filesystem by
532         default.
533
534         * Scripts/webkitpy/layout_tests/port/base.py:
535         (Port.__init__):
536         * Scripts/webkitpy/layout_tests/port/factory.py:
537         (PortFactory.__init__):
538         (PortFactory._get_kwargs):
539         * Scripts/webkitpy/layout_tests/port/test.py:
540         (TestInstance.__init__):
541         (TestPort.__init__):
542         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
543         (passing_run):
544         (logging_run):
545         (get_tests_run):
546         (MainTest.test_single_file):
547         (MainTest.test_stderr_is_saved):
548         (MainTest.test_test_list):
549         (MainTest.test_test_list_with_prefix):
550         (MainTest.test_missing_and_unexpected_results):
551         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
552         (MainTest.test_crash_with_stderr):
553         (MainTest.test_no_image_failure_with_image_diff):
554         (MainTest.test_crash_log):
555         (MainTest.test_web_process_crash_log):
556         (MainTest.test_exit_after_n_failures_upload):
557         (MainTest.test_results_directory_absolute):
558         (MainTest.test_results_directory_relative):
559         (MainTest.test_retries_directory):
560         (MainTest.test_tolerance.get_port_for_run):
561         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
562         (EndToEndTest.test_end_to_end):
563         (EndToEndTest.test_reftest_with_two_notrefs):
564         (RebaselineTest.test_reset_results):
565         (RebaselineTest.test_missing_results):
566         (RebaselineTest.test_new_baseline):
567         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
568         (Rebaseliner.__init__):
569         (main):
570         (real_main):
571         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
572         (test_host_port_and_filesystem):
573         (TestRebaseliner.make_rebaseliner):
574         (TestRealMain.test_all_platforms):
575         (TestHtmlGenerator.make_generator):
576
577 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
578
579         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
580         https://bugs.webkit.org/show_bug.cgi?id=74562
581
582         Reviewed by Eric Seidel.
583
584         Apart from a minor change to style/checkers/test_expectations.py
585         to take a host as a parameter to a TestExpectationsChecker(),
586         there are only refactoring changes to unit tests here.
587
588         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
589         (TestResultWriterTest.test_reftest_diff_image):
590         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
591         (JSONGeneratorTest._test_json_generation):
592         (JSONGeneratorTest.test_test_timings_trie):
593         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
594         (Base.__init__):
595         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
596         (PortTest.make_port):
597         (PortTest.test_layout_tests_skipping):
598         (PortTest.test_test_dirs):
599         (PortTest.test_additional_platform_directory):
600         (PortTest.test_uses_test_expectations_file):
601         (PortTest.test_find_no_paths_specified):
602         (PortTest.test_find_one_test):
603         (PortTest.test_find_glob):
604         (PortTest.test_find_with_skipped_directories):
605         (PortTest.test_find_with_skipped_directories_2):
606         (PortTest.test_parse_reftest_list):
607         * Scripts/webkitpy/layout_tests/port/dryrun.py:
608         (DryRunPort.__init__):
609         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
610         (FactoryTest.setUp):
611         (FactoryTest.tearDown):
612         (FactoryTest.assert_port):
613         (FactoryTest.assert_platform_port):
614         (FactoryTest.test_unknown_specified):
615         (FactoryTest.test_unknown_default):
616         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
617         (GetGoogleChromePortTest._verify_expectations_overrides):
618         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
619         (MockDRTPortTest.make_port):
620         (MockDRTTest.assertTest):
621         (MockDRTTest.test_main):
622         (MockChromiumDRTTest.test_pixeltest__fails):
623         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
624         (QtPortTest._assert_search_path):
625         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
626         (TestWebKitPort.__init__):
627         (WebKitPortTest.test_skipped_directories_for_symbols):
628         (test_skipped_directories_for_features):
629         (test_skipped_layout_tests):
630         (test_skipped_file_search_paths):
631         (test_root_option):
632         (test_test_expectations):
633         (test_build_driver):
634         (test_linux_distro_detection):
635         (test_apache_config_file_name_for_platform):
636         (test_path_to_apache_config_file):
637         (WebKitDriverTest.test_read_block):
638         * Scripts/webkitpy/style/checkers/test_expectations.py:
639         (TestExpectationsChecker.__init__):
640         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
641         (TestExpectationsTestCase._expect_port_for_expectations_path):
642         (TestExpectationsTestCase.assert_lines_lint):
643         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
644         (get_test_config.TestMacPort):
645
646 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
647
648         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
649         https://bugs.webkit.org/show_bug.cgi?id=74854
650
651         Reviewed by Csaba Osztrogonác.
652
653         Since r101052, libewebkit.so is built in a different location, so we
654         need to adjust the path returned by builtDylibPathForName.
655
656         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
657         port also respects Release/Debug configurations.
658
659         These changes should make run-launcher finally work correctly with
660         webkit-efl.
661
662         * Scripts/webkitdirs.pm:
663         (usesPerConfigurationBuildDirectory):
664         (builtDylibPathForName):
665
666 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
667
668         [Qt][WK2] Add support for modal event loop processing for WTR
669         https://bugs.webkit.org/show_bug.cgi?id=74852
670
671         Reviewed by Kenneth Rohde Christiansen.
672
673         Rewrote event loop processing: Instead of terminating the event loop
674         in notifyDone() - something no other platform does - we now respect the
675         "bool& condition" parameter passed to platformRunUntil. This ensures
676         proper termination even when the condition is changed from within a
677         nested event loop, because only when we _exit_ from the nested event
678         loop we will check the condition and terminate the test properly.
679
680         In addition this patch implements TestController::runModal by means of
681         a nested event loop, which is passed to the platform webview that is
682         supposed to be modal. It is that view's responsibility to exit the
683         loop, upon destruction. I believe that's similar to how it works on the Mac,
684         where it doesn't seem that NSApp's runModalForWindow is terminate via
685         abort/stopModal but simply because the window is closed.
686
687         * WebKitTestRunner/PlatformWebView.h:
688         (WTR::PlatformWebView::setModalEventLoop):
689         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
690         (WTR::PlatformWebView::PlatformWebView):
691         (WTR::PlatformWebView::~PlatformWebView):
692         * WebKitTestRunner/qt/TestControllerQt.cpp:
693         (WTR::TestController::notifyDone):
694         (WTR::TestController::platformRunUntil):
695         (WTR::TestController::runModal):
696
697 2011-12-18  Kentaro Hara  <haraken@chromium.org>
698
699         REGRESSION(r103149): prepare-ChangeLog outputs a warning
700         https://bugs.webkit.org/show_bug.cgi?id=74808
701
702         Reviewed by David Kilzer.
703
704         Added the prototype declaration of main() to avoid warning messages.
705         Sorted subroutine declarations in the alphabetical order.
706
707         * Scripts/prepare-ChangeLog:
708
709 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
710
711         [Qt] Fix QtTestBrowser compilation with QtWidgets module
712         https://bugs.webkit.org/show_bug.cgi?id=74791
713
714         Reviewed by Andreas Kling.
715
716         * QtTestBrowser/QtTestBrowser.pro:
717
718 2011-12-17  Kentaro Hara  <haraken@chromium.org>
719
720         Remove top-level code completely from prepare-ChangeLog
721         https://bugs.webkit.org/show_bug.cgi?id=74698
722
723         Reviewed by Darin Adler.
724
725         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
726         This patch just moves all top-level code into main().
727
728         * Scripts/prepare-ChangeLog:
729         (main):
730
731 2011-12-16  Dean Jackson  <dino@apple.com>
732
733         Move webkit-bug-importer to Contributor. It won't
734         autocomplete as an Account.
735         See https://bugs.webkit.org/show_bug.cgi?id=74739
736         for some discussion.
737
738         Unreviewed.
739
740         * Scripts/webkitpy/common/config/committers.py:
741
742 2011-12-16  Dean Jackson  <dino@apple.com>
743
744         Add webkit-bug-importer@group.apple.com to accounts
745         so that it autocompletes in bugzilla.
746
747         Unreviewed.
748
749         * Scripts/webkitpy/common/config/committers.py:
750
751 2011-12-16  Philippe Normand  <pnormand@igalia.com>
752
753         Unreviewed, skipping 3 failing GTK API tests.
754
755         * Scripts/run-gtk-tests:
756
757 2011-12-16  Philippe Normand  <pnormand@igalia.com>
758
759         Unreviewed, GTK API tests build fix attempt.
760
761         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
762
763 2011-12-16  Philippe Normand  <pnormand@igalia.com>
764
765         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
766
767         * Scripts/run-gtk-tests:
768
769 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
770
771         [Qt] Fix the build for newer Qt5
772         https://bugs.webkit.org/show_bug.cgi?id=74703
773
774         Reviewed by Csaba Osztrogonác.
775
776         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
777         * DumpRenderTree/qt/EventSenderQt.cpp:
778         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
779         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
780         (WTR::EventSenderProxy::sendTouchEvent):
781         * MiniBrowser/qt/MiniBrowserApplication.cpp:
782         (MiniBrowserApplication::sendTouchEvent): Ditto.
783         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
784
785 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
786
787         [Qt] Detect and force clean build when feature defines are added
788
789         Reviewed by Ossy.
790
791         https://bugs.webkit.org/show_bug.cgi?id=74689
792
793         * Scripts/webkitdirs.pm:
794
795 2011-12-16  Kentaro Hara  <haraken@chromium.org>
796
797         [Refactoring] Remove all global variables from prepare-ChangeLog
798         https://bugs.webkit.org/show_bug.cgi?id=74681
799
800         Reviewed by Ryosuke Niwa.
801
802         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
803         manner. This bug is one of the incremental refactorings to remove all top-level
804         code and global variables from prepare-ChangeLog. In this patch,
805         we make the following global variables be used only through parameter passing.
806         This patch removes all global variables from prepare-ChangeLog.
807             - $mergeBase
808             - $gitCommit
809             - $gitIndex
810
811         * Scripts/prepare-ChangeLog:
812         (generateFunctionLists):
813         (changeLogNameFromArgs):
814         (changeLogEmailAddressFromArgs):
815         (generateNewChangeLogs):
816         (printDiff):
817         (diffFromToString):
818         (diffCommand):
819         (statusCommand):
820         (createPatchCommand):
821         (generateFileList):
822         (isConflictStatus):
823
824 2011-12-15  Philippe Normand  <pnormand@igalia.com>
825
826         [GTK] Rounding errors on 32-bit machines causes tests to fail
827         https://bugs.webkit.org/show_bug.cgi?id=72254
828
829         Initial patch by vanuan@gmail.com.
830         Reviewed by Martin Robinson.
831
832         * Scripts/webkitdirs.pm:
833         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
834         CXXFLAGS to autogen in an attempt to harmonize floating point
835         values between 32-bit and 64-bit architectures.
836
837 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
838
839         [GTK] Make distcheck fails during the install
840         https://bugs.webkit.org/show_bug.cgi?id=74274
841
842         No review, since this is a build fix.
843
844         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
845         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
846         always runs. This means that the gtkdoc step was always running when make was
847         invoked. Generating gtkdoc during 'make install' was triggering a race condition
848         with the library file. Later we can fix generate-forwarding-headers and unbreak
849         'make docs,' but this bandaid is sufficient to let us release.
850
851 2011-12-15  Eric Seidel  <eric@webkit.org>
852
853         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
854         https://bugs.webkit.org/show_bug.cgi?id=74650
855
856         Reviewed by Adam Barth.
857
858         * Scripts/webkitpy/common/system/platforminfo.py:
859         (PlatformInfo._compute_bytes_from_vm_stat_output):
860         * Scripts/webkitpy/layout_tests/port/base.py:
861         (Port.default_child_processes):
862         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
863         (PortTest.test_default_child_processes):
864
865 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
866
867         bencher script should support remote benchmarking on platforms that don't have ruby
868         https://bugs.webkit.org/show_bug.cgi?id=74659
869
870         Rubber-stamped by Sam Weinig.
871         
872         Added the ability to have bencher generate a benchmarking playload that consists of
873         copies of all of the benchmarks, optionally copies of all of the frameworks and
874         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
875         order, which then spits out a raw results file that bencher can parse.
876         
877         In normal operating mode, you never see this, as it just generates the payload and
878         script internally, runs it, parses the results, and spits them out.
879         
880         The --remote mode has been changed to use this style, so any remote host that has
881         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
882         a sh-compatible shell can be used for remote benchmarking.
883         
884         The feature to include VMs in the benchmarking payload is by default only activated
885         when using --remote, but it can also be activated when doing local benchmarking; the
886         benefit is that you remove any pathname-related performance pathologies. All VMs
887         become equal because they are all located in
888         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
889         (usually 0 or 1).
890         
891         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
892         through DumpRenderTree. This is only a bit slower than running in jsc.
893
894         * Scripts/bencher:
895
896 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
897
898         webkitpy: clean up TestPort to (mostly) not create a new filesystem
899         https://bugs.webkit.org/show_bug.cgi?id=74556
900
901         This change modifies the TestPort to be ready to add tests to an
902         existing filesystem instead of creating a new filesystem; we
903         leave unit_test_filesystem() in for now for compatibility.
904
905         * Scripts/webkitpy/common/host_mock.py:
906         (MockHost.__init__):
907           - call add_unit_tests_to_mock_filesystem by default to make
908             the MockHost more generally useful for layout_test unit tests.
909         * Scripts/webkitpy/layout_tests/port/test.py:
910         (TestInstance.__init__):
911         (add_unit_tests_to_mock_filesystem):
912         (add_file):
913         (unit_test_filesystem):
914         (TestPort.__init__):
915         (TestPort._set_default_overriding_none):
916
917 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
918
919         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
920         https://bugs.webkit.org/show_bug.cgi?id=74551
921
922         This is some minor cleanup prior to making all of the host/port
923         changes described in bug 74138.
924
925         * Scripts/webkitpy/common/host_mock.py:
926         (MockHost.__init__):
927           - make sure the scm object is initialized with the same mock
928             executive and filesystem objects.
929
930         * Scripts/webkitpy/common/system/filesystem_mock.py:
931         (MockFileSystem.clear_written_files):
932           - add a routine that will be useful in testing.
933         (MockFileSystem.maybe_make_directory):
934         (MockFileSystem.write_binary_file):
935           - fix bugs to make sure directories are created properly.
936         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
937         (_Process.run):
938           - add clarifying comments.
939         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
940         (MockDRTPort.__init__):
941         (MockDRT.__init__):
942           - add clarifying comments.
943
944 2011-12-15  Anders Carlsson  <andersca@apple.com>
945
946         Regression (r102866): Navigating away from or closing a page with a plugin crashes
947         https://bugs.webkit.org/show_bug.cgi?id=74655
948
949         Reviewed by Sam Weinig.
950
951         Add a bunch of tests.
952
953         * TestWebKitAPI/Tests/WTF/Functional.cpp:
954
955 2011-12-15  Stephanie Lewis  <slewis@apple.com>
956
957         https://bugs.webkit.org/show_bug.cgi?id=74469
958         Escape paths to svn commands so our tools can handle filenames with @ symbols.
959
960         Reviewed by Adam Roben.
961
962         * Scripts/VCSUtils.pm:
963         (scmMoveOrRenameFile):
964         (scmAddExecutableBit):
965         (scmRemoveExecutableBit):
966         (determineSVNRoot):
967         (svnRevisionForDirectory):
968         (pathRelativeToSVNRepositoryRootForPath):
969         (svnStatus):
970         (escapeSubversionPath):
971         * Scripts/parse-malloc-history:
972         (main):
973         * Scripts/prepare-ChangeLog:
974         (diffCommand):
975         (statusCommand):
976         (findOriginalFileFromSvn):
977         (determinePropertyChanges):
978         * Scripts/resolve-ChangeLogs:
979         (conflictFiles):
980         (resolveConflict):
981         (showStatus):
982         * Scripts/svn-apply:
983         (patch):
984         (scmCopy):
985         (scmAdd):
986         (scmRemove):
987         * Scripts/svn-create-patch:
988         (findBaseUrl):
989         (findMimeType):
990         (findSourceFileAndRevision):
991         (generateDiff):
992         (generateFileList):
993         (manufacturePatchForAdditionWithHistory):
994         * Scripts/svn-unapply:
995         (patch):
996         (revertDirectories):
997
998 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
999
1000         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
1001         https://bugs.webkit.org/show_bug.cgi?id=74617
1002
1003         Reviewed by Kenneth Rohde Christiansen.
1004
1005         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
1006         for viewport info button, adjusted height and added rounded corners.
1007
1008 2011-12-15  Andy Estes  <aestes@apple.com>
1009
1010         TestFailures: store the name of the buildbot results directory in a property
1011         https://bugs.webkit.org/show_bug.cgi?id=74663
1012
1013         Reviewed by Adam Barth.
1014         
1015         Store the name of the results directory as a property on Buildbot's
1016         prototype. This allows subclasses of Buildbot to customize the results
1017         directory.
1018
1019         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
1020         (Buildbot.prototype.resultsDirectoryURL):
1021
1022 2011-12-15  Tony Chang  <tony@chromium.org>
1023
1024         [chromium] pass --delete_unversioned_trees to gclient on the bots
1025         https://bugs.webkit.org/show_bug.cgi?id=74565
1026
1027         Reviewed by Kenneth Russell.
1028
1029         It was temporarily removed in r102891 to keep the bots green.  Now
1030         that the bots have cycled, we can add it back.
1031
1032         * Scripts/update-webkit-chromium:
1033
1034 2011-12-15  Kentaro Hara  <haraken@chromium.org>
1035
1036         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
1037         https://bugs.webkit.org/show_bug.cgi?id=74497
1038
1039         Reviewed by Ryosuke Niwa.
1040
1041         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1042         manner. This bug is one of the incremental refactorings to remove all top-level
1043         code and global variables from prepare-ChangeLog. In this patch,
1044         we make the following global variables be used only through parameter passing.
1045             - $bugDescription
1046             - $bugNumber
1047             - $name
1048             - $emailAddress
1049             - $gitReviewer
1050             - $writeChangeLogs
1051
1052         * Scripts/prepare-ChangeLog:
1053         (fetchBugDescriptionFromURL):
1054         (generateNewChangeLogs):
1055         (reviewerAndDescriptionForGitCommit):
1056
1057 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
1058
1059         [EFL] Add a few more web database functions to ewk_settings.
1060         https://bugs.webkit.org/show_bug.cgi?id=72148
1061
1062         Reviewed by Antonio Gomes.
1063
1064         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1065         (LayoutTestController::clearAllDatabases):
1066         (LayoutTestController::setDatabaseQuota):
1067
1068 2011-12-15  Martin Kosiba  <mkosiba@google.com>
1069
1070         Fix find on web pages with -webkit-user-select: none for Chromium
1071         https://bugs.webkit.org/show_bug.cgi?id=72281
1072
1073         Reviewed by Ryosuke Niwa.
1074
1075         Provided a partial findString implementation. This doesn't support
1076         all of the FindOptions since they're not exposed via WebFindOptions.
1077
1078         * DumpRenderTree/chromium/LayoutTestController.cpp:
1079         (LayoutTestController::LayoutTestController):
1080         (LayoutTestController::findString):
1081         * DumpRenderTree/chromium/LayoutTestController.h:
1082
1083 2011-12-15  Kenneth Russell  <kbr@google.com>
1084
1085         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
1086         https://bugs.webkit.org/show_bug.cgi?id=74581
1087
1088         Reviewed by Darin Fisher.
1089
1090         * DumpRenderTree/chromium/LayoutTestController.cpp:
1091         (LayoutTestController::overridePreference):
1092         * DumpRenderTree/chromium/WebPreferences.cpp:
1093         (WebPreferences::reset):
1094         (WebPreferences::applyTo):
1095         * DumpRenderTree/chromium/WebPreferences.h:
1096
1097 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1098
1099         [Qt] Improve the look of the viewport info overlay
1100
1101         Reviewed by Tor Arne Vestbø.
1102
1103         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
1104
1105 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
1106
1107         [Qt] Support requestAnimationFrame API
1108         https://bugs.webkit.org/show_bug.cgi?id=74528
1109
1110         Add build-option for requestAnimationFrame feature.
1111
1112         Reviewed by Kenneth Rohde Christiansen.
1113
1114         * qmake/mkspecs/features/features.prf:
1115
1116 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1117
1118         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
1119
1120         Reviewed by Simon Hausmann.
1121
1122         * qmake/mkspecs/features/webcore.prf:
1123
1124 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
1125
1126         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
1127         https://bugs.webkit.org/show_bug.cgi?id=72893
1128
1129         Reviewed by Kenneth Rohde Christiansen.
1130
1131         This patch extends QQuickWebViewExperimental by a property named
1132         viewportInfo, which contains the viewport scalability and
1133         layout and contents size information. This property is exposed to
1134         QML through the experimental extension for QQuickWebView.
1135
1136         * MiniBrowser/qt/MiniBrowser.pro:
1137         * MiniBrowser/qt/MiniBrowser.qrc:
1138         * MiniBrowser/qt/icons/info.png: Added.
1139         * MiniBrowser/qt/qml/BrowserWindow.qml:
1140         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
1141
1142 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
1143
1144         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
1145         https://bugs.webkit.org/show_bug.cgi?id=74586
1146
1147         Reviewed by Hajime Morita.
1148
1149         No new tests. Covered by existing tests.
1150
1151         * DumpRenderTree/chromium/WebViewHost.cpp:
1152         (WebViewHost::requestCheckingOfText):
1153           Returns immediately if text is empty.
1154
1155 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
1156
1157         [Qt] QtWebKit fails to build on Mac OS X after r102776
1158         https://bugs.webkit.org/show_bug.cgi?id=74593
1159
1160         Reviewed by Simon Hausmann.
1161
1162         CONFIG =+ link_pkgconfig is needed such that the correct parameters
1163         are passed to the compiler.
1164
1165         * DumpRenderTree/qt/DumpRenderTree.pro:
1166
1167 2011-12-14  Tony Chang  <tony@chromium.org>
1168
1169         [chromium] Remove redundant third_party entries from chromium DEPS
1170         https://bugs.webkit.org/show_bug.cgi?id=74472
1171
1172         Reviewed by Kenneth Russell.
1173
1174         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
1175
1176 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1177
1178         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
1179         VCSUtils::isGit() and VCSUtils::isSVN().
1180         https://bugs.webkit.org/show_bug.cgi?id=74485
1181
1182         Reviewed by David Kilzer.
1183
1184         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1185         manner. This bug is one of the incremental refactorings to remove all top-level
1186         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
1187         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
1188         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
1189         just by looking at the current working directory.
1190
1191         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
1192         (diffFromToString):
1193         (diffCommand):
1194         (statusCommand):
1195         (createPatchCommand):
1196         (diffHeaderFormat):
1197         (generateFileList):
1198         (isAddedStatus):
1199         (isConflictStatus):
1200         (statusDescription):
1201         (extractLineRange):
1202
1203 2011-12-14  Sam Weinig  <weinig@apple.com>
1204
1205         Remove whitespace from InheritedPropertySheets attributes in
1206         vsprops files to appease the Visual Studio project migrator.
1207
1208         Reviewed by Adam Roben.
1209
1210         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
1211         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
1212         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
1213         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1214         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1215         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1216         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
1217         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
1218         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
1219         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1220         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1221         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1222         * DumpRenderTree/win/ImageDiffDebug.vsprops:
1223         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
1224         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
1225         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1226         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1227         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1228         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
1229         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
1230         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
1231         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1232         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1233         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1234         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1235         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1236         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
1237         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
1238         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
1239         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1240         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1241         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1242         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
1243         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
1244         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
1245         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1246         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1247         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1248         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
1249         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
1250         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
1251         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1252         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1253         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1254         * WinLauncher/WinLauncherDebug.vsprops:
1255         * WinLauncher/WinLauncherDebugAll.vsprops:
1256         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
1257         * WinLauncher/WinLauncherProduction.vsprops:
1258         * WinLauncher/WinLauncherRelease.vsprops:
1259         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1260         * record-memory-win/record-memory-winDebug.vsprops:
1261         * record-memory-win/record-memory-winDebugAll.vsprops:
1262         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
1263         * record-memory-win/record-memory-winProduction.vsprops:
1264         * record-memory-win/record-memory-winRelease.vsprops:
1265         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1266
1267 2011-12-14  Anders Carlsson  <andersca@apple.com>
1268
1269         Windows build fix.
1270
1271         Move CHECKs out of the destructor.
1272
1273         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1274         (TestWebKitAPI::B::~B):
1275         (TestWebKitAPI::TEST):
1276
1277 2011-12-14  Anders Carlsson  <andersca@apple.com>
1278
1279         binding a member function should ref/deref the object pointer if needed
1280         https://bugs.webkit.org/show_bug.cgi?id=74552
1281
1282         Reviewed by Sam Weinig.
1283
1284         Add new tests.
1285
1286         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1287         (TestWebKitAPI::B::B):
1288         (TestWebKitAPI::B::~B):
1289         (TestWebKitAPI::B::ref):
1290         (TestWebKitAPI::B::deref):
1291         (TestWebKitAPI::B::f):
1292         (TestWebKitAPI::B::g):
1293         (TestWebKitAPI::TEST):
1294
1295 2011-12-14  Hajime Morrita  <morrita@chromium.org>
1296
1297         JS_INLINE and WTF_INLINE should be visible from WebCore
1298         https://bugs.webkit.org/show_bug.cgi?id=73191
1299
1300         Reviewed by Kevin Ollivier.
1301
1302         Removed macro definitions which is now provided by Platform.h
1303
1304         * DumpRenderTree/chromium/config.h:
1305         * DumpRenderTree/config.h:
1306         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
1307         * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
1308         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
1309         * TestWebKitAPI/config.h:
1310         * WebKitTestRunner/config.h:
1311
1312 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1313
1314         Unreviewed, rolling out r102761.
1315         http://trac.webkit.org/changeset/102761
1316         https://bugs.webkit.org/show_bug.cgi?id=74485
1317
1318         we came up with a better fix than this (see comments in bug
1319         74485)
1320
1321         * Scripts/prepare-ChangeLog:
1322         (generateFunctionLists):
1323         (printDiff):
1324         (diffCommand):
1325         (statusCommand):
1326         (createPatchCommand):
1327         (generateFileList):
1328         (isAddedStatus):
1329         (isConflictStatus):
1330         (statusDescription):
1331         (extractLineRange):
1332
1333 2011-12-14  Anders Carlsson  <andersca@apple.com>
1334
1335         Work around a bug in the MSVC2005 compiler
1336         https://bugs.webkit.org/show_bug.cgi?id=74550
1337
1338         Reviewed by Sam Weinig.
1339
1340         Re-enable tests.
1341
1342         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1343
1344 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1345
1346         [Qt] Test fonts are not used with Qt5
1347         https://bugs.webkit.org/show_bug.cgi?id=72513
1348
1349         My last unreviewed buildfix for this crazy bug.
1350
1351         * qmake/mkspecs/features/features.prf:
1352
1353 2011-12-14  Anders Carlsson  <andersca@apple.com>
1354
1355         Another attempt at fixing the Windows build.
1356
1357         Disable all the tests until I can figure out what's going on here.
1358
1359         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1360
1361 2011-12-14  Anders Carlsson  <andersca@apple.com>
1362
1363         Fix the Windows build.
1364
1365         Disable some of the tests for now.
1366
1367         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1368
1369 2011-12-14  Anders Carlsson  <andersca@apple.com>
1370
1371         bind should handle member functions
1372         https://bugs.webkit.org/show_bug.cgi?id=74529
1373
1374         Reviewed by Sam Weinig.
1375
1376         Add tests.
1377
1378         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1379         (TestWebKitAPI::A::A):
1380         (TestWebKitAPI::A::f):
1381         (TestWebKitAPI::A::addF):
1382         (TestWebKitAPI::TEST):
1383
1384 2011-12-14  Anders Carlsson  <andersca@apple.com>
1385
1386         Add unary and binary bind overloads
1387         https://bugs.webkit.org/show_bug.cgi?id=74524
1388
1389         Reviewed by Sam Weinig.
1390
1391         Add tests.
1392
1393         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1394         (TestWebKitAPI::TEST):
1395         (TestWebKitAPI::multiplyByTwo):
1396         (TestWebKitAPI::multiplyByOneAndAHalf):
1397         (TestWebKitAPI::multiply):
1398         (TestWebKitAPI::subtract):
1399
1400 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1401
1402         [Qt] Test fonts are not used with Qt5
1403         https://bugs.webkit.org/show_bug.cgi?id=72513
1404
1405         MIPS and SH4 buildfix after r102776 and r102795.
1406
1407         Reviewed by Csaba Osztrogonác.
1408
1409         * qmake/mkspecs/features/features.prf:
1410
1411 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1412
1413         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
1414
1415         * qmake/mkspecs/features/features.prf:
1416
1417 2011-12-14  Andreas Kling  <kling@webkit.org>
1418
1419         Make my e-mail address a little more awesome.
1420
1421         * Scripts/webkitpy/common/config/committers.py:
1422
1423 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1424
1425         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
1426
1427         * qmake/mkspecs/features/webcore.prf:
1428
1429 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
1430
1431         [Qt] Test fonts are not used with Qt5
1432         https://bugs.webkit.org/show_bug.cgi?id=72513
1433
1434         Reviewed by Simon Hausmann.
1435
1436         Don't depend on Q_WS_X11 anymore since it's not the Qt5
1437         way to detect the platform. Make the guards depend
1438         on our own configtest for fontconfig. For Qt4 we can still
1439         use the preassumption that we have it on Linux.
1440
1441         * DumpRenderTree/qt/DumpRenderTree.pro:
1442         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1443         (WebCore::DumpRenderTree::open):
1444         (WebCore::DumpRenderTree::initializeFonts):
1445         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1446         * DumpRenderTree/qt/main.cpp:
1447         (main): Additionally remove a nonsense piece of code that was
1448         trying to reset the font settings - which is not necessary -
1449         after we have already returned from main.
1450         * WebKitTestRunner/InjectedBundle/Target.pri:
1451         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1452         (WTR::activateFonts):
1453         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
1454         from WTR. It is not needed. We set up the fonts via the injected bundle.
1455         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
1456         (main):
1457         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
1458         * qmake/mkspecs/features/features.prf:
1459         * qmake/sync.profile:
1460
1461 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1462
1463         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
1464
1465         Followup to r102679
1466
1467         https://bugs.webkit.org/show_bug.cgi?id=74413
1468
1469         Reviewed by Simon Hausmann.
1470
1471         * qmake/mkspecs/features/webcore.prf:
1472
1473 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
1474
1475         [Qt] Mobile theme could use a little refresh
1476         https://bugs.webkit.org/show_bug.cgi?id=74293
1477
1478         Have MiniBrowser use the mobile theme when not
1479         passed --desktop.
1480
1481         Reviewed by Kenneth Rohde Christiansen.
1482
1483         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1484         (MiniBrowserApplication::handleUserOptions):
1485
1486 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
1487
1488         [Qt] [Gardening] Remove qt-4.7 layout tests dir
1489         https://bugs.webkit.org/show_bug.cgi?id=74426
1490
1491         Building trunk now depends on Qt >= 4.8, so no need to keep this directory
1492         on the tree.
1493
1494         Reviewed by Csaba Osztrogonác.
1495
1496         * Scripts/webkitpy/layout_tests/port/qt.py:
1497         (QtPort.qt_version):
1498         (QtPort.baseline_search_path):
1499         (QtPort._skipped_file_search_paths):
1500         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1501         (QtPortTest._assert_search_path):
1502
1503 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1504
1505         [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
1506         through parameter passing
1507         https://bugs.webkit.org/show_bug.cgi?id=74485
1508
1509         Reviewed by Ryosuke Niwa.
1510
1511         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1512         manner. This bug is one of the incremental refactorings to remove all top-level
1513         code and global variables from prepare-ChangeLog. In this patch,
1514         we make the following global variables be used only through parameter passing.
1515             - $isGit
1516             - $isSVN
1517
1518         * Scripts/prepare-ChangeLog:
1519         (generateFunctionLists):
1520         (printDiff):
1521         (diffFromToString):
1522         (diffCommand):
1523         (statusCommand):
1524         (createPatchCommand):
1525         (diffHeaderFormat):
1526         (generateFileList):
1527         (isAddedStatus):
1528         (isConflictStatus):
1529         (statusDescription):
1530         (extractLineRange):
1531
1532 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
1533
1534         [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
1535         https://bugs.webkit.org/show_bug.cgi?id=74417
1536
1537         Reviewed by Simon Hausmann.
1538
1539         Based on original patch by Kenneth Christiansen.
1540
1541         Already covered by current tests.
1542
1543         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1544         (WebCore::DumpRenderTree::DumpRenderTree):
1545         (WebCore::DumpRenderTree::~DumpRenderTree):
1546         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1547         (LayoutTestController::setMockDeviceOrientation):
1548
1549 2011-12-03  Philippe Normand  <pnormand@igalia.com>
1550
1551         [GTK] Bad text rendering since r101343
1552         https://bugs.webkit.org/show_bug.cgi?id=73744
1553
1554         Reviewed by Martin Robinson.
1555
1556         Turn cairo hint metrics off for better font metrics reporting in
1557         the tests. This is especially important for SVG.
1558
1559         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1560         (initializeGtkFontSettings):
1561         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1562         (WTR::initializeGtkSettings):
1563
1564 2011-12-13  Kentaro Hara  <haraken@chromium.org>
1565
1566         [Refactoring] Remove several global variables from prepare-ChangeLog
1567         https://bugs.webkit.org/show_bug.cgi?id=74389
1568
1569         Reviewed by David Kilzer.
1570
1571         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1572         manner. This bug is one of the incremental refactorings to remove all top-level
1573         code and global variables from prepare-ChangeLog. In this patch,
1574         we make the following global variables being used only through parameter passing.
1575             - %paths
1576             - $changedFiles
1577             - $conflictFiles
1578             - $functionLists
1579             - $bugURL
1580
1581         * Scripts/prepare-ChangeLog:
1582         (findChangeLogs):
1583         (generateNewChangeLogs):
1584         (processPaths):
1585         (generateFileList):
1586         (firstDirectoryOrCwd):
1587
1588 2011-12-13  Anders Carlsson  <andersca@apple.com>
1589
1590         Add a very bare-bones implementation of bind and Function to WTF
1591         https://bugs.webkit.org/show_bug.cgi?id=74462
1592
1593         Reviewed by Sam Weinig.
1594
1595         Add basic tests for WTF::Function and WTF::bind.
1596
1597         * TestWebKitAPI/TestWebKitAPI.gypi:
1598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1599         * TestWebKitAPI/Tests/Functional.cpp: Added.
1600         (TestWebKitAPI::returnFortyTwo):
1601         (TestWebKitAPI::TEST):
1602         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1603
1604 2011-12-13  Robin Dunn  <robin@alldunn.com>
1605
1606         [wx] Add a URL argument to wxWebView constructor.
1607         https://bugs.webkit.org/show_bug.cgi?id=74316
1608         
1609         Reviewed by Kevin Ollivier.
1610
1611         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1612         (MyApp::OnInit):
1613         * wx/browser/browser.cpp:
1614         (MyApp::OnInit):
1615
1616 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1617
1618         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
1619         https://bugs.webkit.org/show_bug.cgi?id=74430
1620
1621         Reviewed by David Levin.
1622
1623         * Scripts/webkitpy/common/config/watchlist:
1624
1625 2011-12-13  Peter Beverloo  <peter@chromium.org>
1626
1627         [Chromium] Pull in FreeType and decrease check-out complexity for Android
1628         https://bugs.webkit.org/show_bug.cgi?id=74401
1629
1630         Decrease the check-out complexity by removing the need to first run
1631         "update-webkit-chromium --chromium" prior to running it with
1632         "--chromium-android", which was caused by an unversioned third_party/
1633         directory being created. This moves the Android NDK to Source/WebKit/
1634         chromium/, coming from third_party/ in that directory.
1635
1636         Reviewed by Adam Barth.
1637
1638         * Scripts/update-webkit-chromium:
1639         * Scripts/webkitdirs.pm:
1640         (buildChromiumMakefile):
1641
1642 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
1643
1644         build-jsc passing incorrect args to buildGtkProject
1645         https://bugs.webkit.org/show_bug.cgi?id=74308
1646
1647         Reviewed by Gustavo Noronha Silva.
1648
1649         * Scripts/build-webkit: Instead of invoking buildGtkProject with
1650         another argument about webkit2, unshift a --disable-webkit2
1651         argument onto the buildArgs.
1652         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
1653         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
1654         and build-jsc are run one after the other.
1655
1656 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1657
1658         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
1659         https://bugs.webkit.org/show_bug.cgi?id=74413
1660
1661         Unreviewed buildfix.
1662
1663         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
1664
1665 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1666
1667         [Qt] Unreviewed speculativ debug buildfix after r102679.
1668
1669         * QtTestBrowser/QtTestBrowser.pro:
1670         * QtTestBrowser/main.cpp:
1671
1672 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1673
1674         [Qt] Get rid of layering violations in includes
1675
1676         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
1677         in the webcore.prf, but rather in each target that specificly needs
1678         headers in these location. We used to include them directly in webcore
1679         since we had layering violations between WebCore and WebKit, but now
1680         that they are gone there's no reason to do that.
1681
1682         Reviewed by Simon Hausmann.
1683
1684         * DumpRenderTree/qt/DumpRenderTree.pro:
1685         * QtTestBrowser/launcherwindow.h:
1686         * WebKitTestRunner/InjectedBundle/Target.pri:
1687         * qmake/mkspecs/features/webcore.prf:
1688         * qmake/mkspecs/features/webkit2.prf:
1689
1690 2011-12-13  János Badics  <dicska@gmail.com>
1691
1692         [NRWT] It crashes intermittently when there are WebProcess crashes
1693         https://bugs.webkit.org/show_bug.cgi?id=73451
1694
1695         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
1696
1697         Reviewed by Kenneth Rohde Christiansen.
1698
1699         * Scripts/webkitpy/layout_tests/port/server_process.py:
1700         (ServerProcess._check_for_crash):
1701
1702 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1703
1704         Unreviewed. Fix GTK+ API docs build.
1705
1706         * gtk/generate-gtkdoc:
1707         (get_webkit2_options): Ignore WebKitUIClient since it's private
1708         API.
1709
1710 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
1711
1712         Reviewed, removed one of my email addresses to use the apprpriate one.
1713
1714         * Scripts/webkitpy/common/config/committers.py:
1715
1716 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
1717
1718         [Qt] Fix skip list search path and expected file search path in ORWT
1719         https://bugs.webkit.org/show_bug.cgi?id=74281
1720
1721         Expected file search path fixed.
1722
1723         Print all used skipped list and expected search path in verbose mode similar to NRWT.
1724
1725         Reviewed by Csaba Osztrogonác.
1726
1727         * Scripts/old-run-webkit-tests:
1728         (buildPlatformResultHierarchy):
1729         (buildPlatformTestHierarchy):
1730         (readSkippedFiles):
1731
1732 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1733
1734         [Qt] Missing layoutTestController.dumpWillCacheResponse
1735         https://bugs.webkit.org/show_bug.cgi?id=74287
1736
1737         Reviewed by Csaba Osztrogonác.
1738
1739         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1740         (LayoutTestController::reset):
1741         (LayoutTestController::dumpWillCacheResponse):
1742         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1743
1744 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
1745
1746         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
1747         https://bugs.webkit.org/show_bug.cgi?id=73771
1748
1749         Reviewed by Gustavo Noronha Silva.
1750
1751         When using a fallback font during testing, always use DejaVu Sans. This prevents
1752         falling back to DejaVu Serif on some systems.
1753
1754         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
1755
1756 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1757
1758         Add myself as a committer
1759
1760         * Scripts/webkitpy/common/config/committers.py:
1761
1762 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1763
1764         [Qt] [WK2] Support customizing popup menus with QML
1765         https://bugs.webkit.org/show_bug.cgi?id=73560
1766
1767         Reviewed by Tor Arne Vestbø.
1768
1769         Add an Item Selector to our WebView using the experimental API.
1770
1771         * MiniBrowser/qt/MiniBrowser.pro:
1772         * MiniBrowser/qt/MiniBrowser.qrc:
1773         * MiniBrowser/qt/qml/BrowserWindow.qml:
1774         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
1775
1776 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
1777
1778         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
1779         https://bugs.webkit.org/show_bug.cgi?id=74283
1780
1781         Reviewed by Simon Hausmann.
1782
1783         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1784         (MiniBrowserApplication::sendTouchEvent):
1785
1786 2011-12-12  Kentaro Hara  <haraken@chromium.org>
1787
1788         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
1789         to show ChangeLogs diff and open ChangeLogs in an editor
1790         https://bugs.webkit.org/show_bug.cgi?id=74266
1791
1792         Reviewed by Ryosuke Niwa.
1793
1794         We are planning to write unit-tests for prepare-ChangeLog
1795         in a run-leaks_unittest manner. This patch is one of the incremental
1796         refactorings to remove all top-level code and global variables from
1797         prepare-ChangeLog.
1798
1799         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
1800         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
1801         Renamed @changed_files to @changedFiles.
1802         Renamed %conflict_files to %conflictFiles.
1803         (generateFunctionLists):
1804         (printDiff):
1805         (openChangeLogs):
1806
1807 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1808
1809         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
1810         https://bugs.webkit.org/show_bug.cgi?id=74257
1811
1812         Reviewed by Ryosuke Niwa.
1813
1814         We are planning to write unit-tests for prepare-ChangeLog
1815         in a run-leaks_unittest/ manner. This patch is one of the incremental
1816         refactorings to remove all top-level code and global variables from
1817         prepare-ChangeLog.
1818
1819         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
1820         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
1821         into resolveConflictedChangeLogs().
1822         (getLatestChangeLogs):
1823         (resolveConflictedChangeLogs):
1824
1825 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1826
1827         [Refactoring] Move top-level code to generate a new ChangeLog into a method
1828         https://bugs.webkit.org/show_bug.cgi?id=74253
1829
1830         Reviewed by David Kilzer.
1831
1832         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
1833         which requires to remove top-level code and global variables. This patch is one of
1834         the incremental refactorings for that.
1835
1836         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
1837         (generateFunctionLists):
1838         (findChangeLogs):
1839         (generateNewChangeLogs):
1840         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
1841
1842 2011-12-10  Kentaro Hara  <haraken@chromium.org>
1843
1844         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
1845         https://bugs.webkit.org/show_bug.cgi?id=74175
1846
1847         Reviewed by Ryosuke Niwa.
1848
1849         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1850         This requires to remove top-level code. This patch is one of the incremental refactorings
1851         for that.
1852
1853         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
1854         (findChangeLogs):
1855
1856 2011-12-10  Andreas Kling  <kling@webkit.org>
1857
1858         Add my Apple e-mail to committers.py.
1859
1860         * Scripts/webkitpy/common/config/committers.py:
1861
1862 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1863
1864         chromium win build: revert build_webkit_exes_from_webkit_gyp change
1865         https://bugs.webkit.org/show_bug.cgi?id=74225
1866
1867         This change sets build_webkit_exes_from_webkit_gyp back to 1;
1868         the "All.gyp" solution doesn't work on windows.
1869
1870         * Scripts/webkitdirs.pm:
1871         (buildChromium):
1872
1873 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
1874
1875         [Qt] Click's count is limited to three continuous clicks.
1876         https://bugs.webkit.org/show_bug.cgi?id=45666
1877
1878         Reviewed by Kenneth Rohde Christiansen.
1879
1880         Update m_time at every call to leapForward, so double clicks
1881         event are correctly sent by EventSender.
1882
1883         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1884         (WTR::EventSenderProxy::updateClickCountForButton):
1885         (WTR::EventSenderProxy::leapForward):
1886
1887 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1888
1889         [Refactoring] Reduce top-level code in prepare-ChangeLog
1890         https://bugs.webkit.org/show_bug.cgi?id=74172
1891
1892         Reviewed by Ryosuke Niwa.
1893
1894         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1895         This requires to remove top-level code. This patch is one of the incremental refactorings
1896         for that.
1897
1898         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
1899         (generateFunctionLists):
1900
1901 2011-12-09  Sam Weinig  <sam@webkit.org>
1902
1903         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
1904         https://bugs.webkit.org/show_bug.cgi?id=74218
1905
1906         Reviewed by Anders Carlsson.
1907
1908         Add a test of the WKConnectionRef API.
1909
1910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1911         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
1912         (TestWebKitAPI::didCreateConnection):
1913         (TestWebKitAPI::connectionDidReceiveMessage):
1914         (TestWebKitAPI::connectionDidClose):
1915         (TestWebKitAPI::TEST):
1916         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
1917         (TestWebKitAPI::connectionDidReceiveMessage):
1918         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
1919         (TestWebKitAPI::WKConnectionTest::initialize):
1920
1921 2011-12-09  David Levin  <levin@chromium.org>
1922
1923         Hash* iterators should allow comparison between const and const versions.
1924         https://bugs.webkit.org/show_bug.cgi?id=73370
1925
1926         Reviewed by Darin Adler.
1927
1928         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
1929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1930         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1931         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
1932         (TestWebKitAPI::TEST): Add a test for the new functionality.
1933
1934 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1935
1936         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
1937         https://bugs.webkit.org/show_bug.cgi?id=74212
1938
1939         Reviewed by Tony Chang.
1940
1941         The change introduced in r102201 to split the executables out of
1942         WebKit.gyp apparently doesn't work right on Windows, since
1943         WebKit.gyp and Tools.gyp refer to dependent projects by
1944         different relative paths (it appears gyp doesn't normalize the
1945         paths). This change moves Tools.gyp to be in the same directory
1946         as WebKit.gyp (and All.gyp), which should fix this and
1947         conveniently will also solve the problem of how to add Tools.gyp
1948         to the chromium DEPS file.
1949
1950         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
1951
1952 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1953
1954         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
1955         https://bugs.webkit.org/show_bug.cgi?id=74173
1956
1957         Reviewed by Ryosuke Niwa.
1958
1959         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1960         This requires to remove top-level code. This patch is one of the incremental refactorings
1961         for that.
1962
1963         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
1964         (fetchBugDescriptionFromURL):
1965
1966 2011-12-09  Tony Chang  <tony@chromium.org>
1967
1968         Switch the chromium mac bots to using skia test results
1969         https://bugs.webkit.org/show_bug.cgi?id=74201
1970
1971         Reviewed by Ryosuke Niwa.
1972
1973         This is reverting http://trac.webkit.org/changeset/97781 and changing
1974         the name in master.cfg to no longer have cg in the name.
1975
1976         * BuildSlaveSupport/build.webkit.org-config/config.json:
1977         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1978         (appendCustomBuildFlags):
1979         (RunWebKitTests.start):
1980
1981 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1982
1983         [Qt] Remove a wrongly placed ASSERT.
1984
1985         Reviewed by Tor Arne Vestbø.
1986
1987         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1988         (MiniBrowserApplication::notify):
1989
1990 2011-12-09  Cary Clark  <caryclark@google.com>
1991
1992         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
1993         https://bugs.webkit.org/show_bug.cgi?id=74118
1994
1995         Reviewed by Adam Barth.
1996
1997         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1998         (get):
1999         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2000         (ChromiumMacPort.__init__):
2001         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2002         (ChromiumMacPortTest.test_versions):
2003         (ChromiumMacPortTest.test_graphics_type):
2004
2005 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2006
2007         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
2008
2009         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
2010         this failed when moving files in the source tree, as the .d file would contain
2011         stale dependencies on the old source file location. By keeping the object files
2012         (and hence the depdendency files) in a proper tree structure inside the objects
2013         directory we can prevent this failure.
2014
2015         A side benefit is that we can also have objects with the same name inside the
2016         same project.
2017
2018         Reviewed by Simon Hausmann.
2019
2020         * qmake/mkspecs/features/unix/default_pre.prf:
2021
2022 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2023
2024         Unreviewed. Update unit test after r102412.
2025
2026         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2027         (IRCCommandTest.test_whois):
2028
2029 2011-12-09  Kentaro Hara  <haraken@chromium.org>
2030
2031         REGRESSION(r102105): run-bindings-tests should output full diff results
2032         https://bugs.webkit.org/show_bug.cgi?id=74166
2033
2034         Reviewed by Adam Barth.
2035
2036         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
2037         run-bindings-tests should output full diff results.
2038
2039         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
2040         (BindingsTests.generate_from_idl):
2041         (BindingsTests.generate_supplemental_dependency):
2042         (BindingsTests.detect_changes):
2043
2044 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
2045
2046         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
2047         https://bugs.webkit.org/show_bug.cgi?id=73990
2048
2049         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
2050
2051         Fix QtQuick includes after move from QtDeclarative to QtQuick.
2052
2053         * MiniBrowser/qt/BrowserWindow.h:
2054         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2055
2056 2011-12-08  Adam Klein  <adamk@chromium.org>
2057
2058         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
2059         https://bugs.webkit.org/show_bug.cgi?id=73492
2060
2061         Reviewed by Adam Barth.
2062
2063         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
2064         keypress event without any script on the stack.
2065
2066         * DumpRenderTree/chromium/EventSender.cpp:
2067         (EventSender::EventSender):
2068         (EventSender::keyDown):
2069         (KeyDownTask::KeyDownTask):
2070         (KeyDownTask::runIfValid):
2071         (EventSender::scheduleAsynchronousKeyDown):
2072         * DumpRenderTree/chromium/EventSender.h:
2073
2074 2011-12-08  Hayato Ito  <hayato@chromium.org>
2075
2076         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
2077         https://bugs.webkit.org/show_bug.cgi?id=73980
2078
2079         Reviewed by Tony Chang.
2080
2081         * gdb/webkit.py:
2082         (guess_string_length):
2083         (ustring_to_string):
2084         (lstring_to_string):
2085         (LCharStringPrinter):
2086         (LCharStringPrinter.to_string):
2087         (WTFStringImplPrinter.get_length):
2088         (WTFStringImplPrinter.to_string):
2089         (WTFStringImplPrinter.is_8bit):
2090         (WTFStringPrinter.stringimpl_ptr):
2091         (WTFStringPrinter.get_length):
2092         (WTFStringPrinter.to_string):
2093         (add_pretty_printers.lookup_function):
2094
2095 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
2096
2097         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
2098         https://bugs.webkit.org/show_bug.cgi?id=73916
2099
2100         Reviewed by Kent Tamura.
2101
2102         * qmake/mkspecs/features/features.prf:
2103
2104 2011-12-08  Adrienne Walker  <enne@google.com>
2105
2106         Unreviewed contributor additions to committers.py.
2107
2108         * Scripts/webkitpy/common/config/committers.py:
2109
2110 2011-12-08  David Reveman  <reveman@chromium.org>
2111
2112         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
2113         https://bugs.webkit.org/show_bug.cgi?id=74017
2114
2115         Reviewed by James Robinson.
2116         
2117         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
2118
2119         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2120         (main):
2121         * DumpRenderTree/chromium/TestShell.cpp:
2122         (TestShell::TestShell):
2123         (TestShell::resetWebSettings):
2124         * DumpRenderTree/chromium/TestShell.h:
2125         (TestShell::setAcceleratedPaintingEnabled):
2126         (TestShell::setPerTilePaintingEnabled):
2127         * DumpRenderTree/chromium/WebPreferences.cpp:
2128         (WebPreferences::reset):
2129         (WebPreferences::applyTo):
2130         * DumpRenderTree/chromium/WebPreferences.h:
2131         * Scripts/webkitpy/layout_tests/port/chromium.py:
2132         (ChromiumDriver._wrapper_options):
2133         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2134         (parse_args):
2135
2136 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
2137
2138         create a "SystemHost" object for webkitpy to slim down the Host object
2139         https://bugs.webkit.org/show_bug.cgi?id=72680
2140
2141         Reviewed by Eric Siedel.
2142
2143         This creates a SystemHost object that other objects that should
2144         only have dependencies on functionality in webkitpy.common.system
2145         can use; this will allow them to not require a full Host.
2146
2147         * Scripts/webkitpy/common/host.py:
2148         * Scripts/webkitpy/common/host_mock.py:
2149         * Scripts/webkitpy/common/system/systemhost.py: Added.
2150         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
2151
2152 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
2153
2154         AX: platform/mac/accessibility/search-with-frames.html crashes
2155         https://bugs.webkit.org/show_bug.cgi?id=74093
2156
2157         Reviewed by Darin Adler.
2158
2159         Take care of the case when an incoming element is null.
2160
2161         * DumpRenderTree/AccessibilityUIElement.cpp:
2162         (uiElementForSearchPredicateCallback):
2163         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2164         (AccessibilityUIElement::uiElementForSearchPredicate):
2165         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2166         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2167
2168 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
2169
2170         [Qt] Visualize mock point ID's in the MiniBrowser
2171         https://bugs.webkit.org/show_bug.cgi?id=74098
2172
2173         Reviewed by Tor Arne Vestbø.
2174
2175         * MiniBrowser/qt/BrowserWindow.cpp:
2176         (BrowserWindow::updateVisualMockTouchPoints):
2177         * MiniBrowser/qt/qml/MockTouchPoint.qml:
2178
2179 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
2180
2181         Accessibility: AccessibilityController should support listening to notifications on all elements.
2182         https://bugs.webkit.org/show_bug.cgi?id=72866
2183
2184         Adds addNotificationListener and removeNotificationListener methods
2185         to AccessibilityController, to listen to notifications on any element
2186         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
2187         implementations are all contained in this change.
2188
2189         On Mac, refactors AccessibilityNotificationHandler into its own
2190         source file that can be used by both AccessibilityController and
2191         AccessibilityUIElement. (Both DRT and WKTR.)
2192
2193         Reviewed by Chris Fleizach.
2194
2195         * DumpRenderTree/AccessibilityController.cpp:
2196         (addNotificationListenerCallback):
2197         (removeNotificationListenerCallback):
2198         (AccessibilityController::getJSClass):
2199         * DumpRenderTree/AccessibilityController.h:
2200         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2201         * DumpRenderTree/chromium/AccessibilityController.cpp:
2202         (AccessibilityController::AccessibilityController):
2203         (AccessibilityController::notificationReceived):
2204         (AccessibilityController::addNotificationListenerCallback):
2205         (AccessibilityController::removeNotificationListenerCallback):
2206         * DumpRenderTree/chromium/AccessibilityController.h:
2207         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2208         (AccessibilityController::addNotificationListener):
2209         (AccessibilityController::removeNotificationListener):
2210         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2211         (AccessibilityController::~AccessibilityController):
2212         (AccessibilityController::addNotificationListener):
2213         (AccessibilityController::removeNotificationListener):
2214         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
2215         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
2216         (-[NSString createJSStringRef]):
2217         (-[AccessibilityNotificationHandler init]):
2218         (-[AccessibilityNotificationHandler setPlatformElement:]):
2219         (-[AccessibilityNotificationHandler dealloc]):
2220         (-[AccessibilityNotificationHandler setCallback:]):
2221         (-[AccessibilityNotificationHandler startObserving]):
2222         (-[AccessibilityNotificationHandler _notificationReceived:]):
2223         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2224         (AccessibilityUIElement::addNotificationListener):
2225         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2226         (notificationListenerProc):
2227         (AccessibilityController::addNotificationListener):
2228         (AccessibilityController::removeNotificationListener):
2229         (AccessibilityController::winNotificationReceived):
2230         (AccessibilityController::winAddNotificationListener):
2231         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2232         (AccessibilityUIElement::addNotificationListener):
2233         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2234         (WTR::AccessibilityController::addNotificationListener):
2235         (WTR::AccessibilityController::removeNotificationListener):
2236         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2237         (WTR::AccessibilityController::logAccessibilityEvents):
2238         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2239         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
2240         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2241         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2242         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2243         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
2244         (WTR::AccessibilityController::addNotificationListener):
2245         (WTR::AccessibilityController::removeNotificationListener):
2246         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
2247         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
2248         (-[NSString createJSStringRef]):
2249         (-[AccessibilityNotificationHandler init]):
2250         (-[AccessibilityNotificationHandler setPlatformElement:]):
2251         (-[AccessibilityNotificationHandler dealloc]):
2252         (-[AccessibilityNotificationHandler setCallback:]):
2253         (-[AccessibilityNotificationHandler startObserving]):
2254         (-[AccessibilityNotificationHandler _notificationReceived:]):
2255         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2256         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2257         (WTR::AccessibilityUIElement::verticalScrollbar):
2258         (WTR::AccessibilityUIElement::addNotificationListener):
2259         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2260
2261 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
2262
2263         [Qt][WK2] Unreviewed buildfix after r102352.
2264
2265         * qmake/mkspecs/features/webkit2.prf:
2266
2267 2011-12-08  Adam Roben  <aroben@apple.com>
2268
2269         Make finding crash logs by PID work on Snow Leopard
2270
2271         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
2272         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
2273         read the first line of the crash log and pull the PID out of there.
2274
2275         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
2276         Snow Leopard
2277
2278         Reviewed by Darin Adler.
2279
2280         * Scripts/webkitpy/common/system/crashlogs.py:
2281         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
2282         name and PID for the log, rather than checking the Lion-only app_description extended
2283         attribute. We now also reject the log if the process name doesn't match what we expect.
2284
2285         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2286         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
2287         PID.
2288         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
2289         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
2290         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
2291         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
2292         read, files that actually contain a crash log for some other process, and files that are
2293         misformatted.
2294
2295         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
2296         unused.
2297
2298         * Scripts/webkitpy/common/system/filesystem_mock.py:
2299         (MockFileSystem.__init__): Removed xattr support, which is now unused.
2300         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
2301         ReadableTextFileObject. This function was completely broken before!
2302         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
2303         bugs like the above.
2304         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
2305         things like readline() and seek().
2306
2307         (ReadableTextFileObject.close):
2308         (ReadableTextFileObject.read):
2309         Added. We override the superclass implementation to account for using a StringIO object.
2310
2311         (ReadableTextFileObject.readline):
2312         (ReadableTextFileObject.seek):
2313         Added. These just call through to StringIO.
2314
2315         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2316         (MainTest.test_crash_log):
2317         (MainTest.test_web_process_crash_log):
2318         Changed to use make_mock_crash_report_darwin.
2319
2320 2011-12-06  Jon Lee  <jonlee@apple.com>
2321
2322         [WK2] Add permissions support (73960)
2323         https://bugs.webkit.org/show_bug.cgi?id=73960
2324         <rdar://problem/10357008>
2325
2326         Reviewed by Darin Adler.
2327
2328         Add null function item to comply with added callback to WKPageUIClient.
2329
2330         * MiniBrowser/mac/BrowserWindowController.m:
2331         (-[BrowserWindowController awakeFromNib]):
2332         * WebKitTestRunner/TestController.cpp:
2333         (WTR::TestController::createOtherPage):
2334         (WTR::TestController::initialize):
2335
2336 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
2337
2338         [Qt] Visualize mock points in the Qt MiniBrowser
2339         https://bugs.webkit.org/show_bug.cgi?id=74074
2340
2341         Reviewed by Tor Arne Vestbø.
2342
2343         * MiniBrowser/qt/BrowserWindow.cpp:
2344         (BrowserWindow::updateVisualMockTouchPoints):
2345         * MiniBrowser/qt/BrowserWindow.h:
2346         * MiniBrowser/qt/MiniBrowser.qrc:
2347         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2348         (MiniBrowserApplication::notify):
2349         (MiniBrowserApplication::sendTouchEvent):
2350         * MiniBrowser/qt/MiniBrowserApplication.h:
2351         * MiniBrowser/qt/icons/touchpoint.png: Added.
2352         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
2353
2354 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
2355
2356         [Qt] WebKitTestRunner crashes with debug builds
2357         https://bugs.webkit.org/show_bug.cgi?id=74090
2358
2359         Reviewed by Tor Arne Vestbø.
2360
2361         * WebKitTestRunner/qt/TestControllerQt.cpp:
2362         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
2363         to ensure WTF/JSC threading is initialized.
2364
2365 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
2366
2367         fix build-webkit --chromium after breakage in r102201
2368         https://bugs.webkit.org/show_bug.cgi?id=74031
2369
2370         Reviewed by Tony Chang.
2371
2372         * Scripts/webkitdirs.pm:
2373         (buildChromium):
2374
2375 2011-12-08  Kentaro Hara  <haraken@chromium.org>
2376
2377         Unreviewed, rolling out r102280.
2378         http://trac.webkit.org/changeset/102280
2379         https://bugs.webkit.org/show_bug.cgi?id=74031
2380
2381         Chromium/Windows build is broken
2382
2383         * Scripts/webkitdirs.pm:
2384         (buildChromium):
2385
2386 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
2387
2388         Adding myself to committers list.
2389
2390         Unreviewed.
2391
2392         * Scripts/webkitpy/common/config/committers.py:
2393
2394 2011-12-07  Michael Saboff  <msaboff@apple.com>
2395
2396         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
2397         https://bugs.webkit.org/show_bug.cgi?id=73995
2398
2399         Reenabled failing tests that the code part of the patch fixes.
2400
2401         Reviewed by Geoffrey Garen.
2402
2403         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2404         (TestWebKitAPI::TEST):
2405
2406 2011-12-07  MORITA Hajime  <morrita@google.com>
2407
2408         [filter-build-webkit] should not emit reset color when --no-color is given
2409         https://bugs.webkit.org/show_bug.cgi?id=73992
2410
2411         Reviewed by Daniel Bates.
2412
2413         Stop printing control sequences when --no-color is given.
2414         After this change, the filter runs nicely even on environments
2415         like Emacs compilation-mode which cannot understand the control sequence.
2416
2417         * Scripts/filter-build-webkit:
2418         (printLine):
2419
2420 2011-12-07  Eric Seidel  <eric@webkit.org>
2421
2422         Use free memory to determine if we have space for DRT instances instead of total memory
2423         https://bugs.webkit.org/show_bug.cgi?id=74021
2424
2425         Reviewed by Adam Barth.
2426
2427         This will hopefully make the Mac buildbots behave better.
2428
2429         I also reduced the expected memory needed per DRT now that
2430         we're properly accounting for the system memory in our calculations.
2431
2432         * Scripts/webkitpy/common/system/platforminfo.py:
2433         (PlatformInfo.total_bytes_memory):
2434         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
2435         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2436         (MockPlatformInfo.total_bytes_memory):
2437         * Scripts/webkitpy/layout_tests/port/base.py:
2438         (Port.default_child_processes):
2439         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2440         (PortTest.test_default_child_processes):
2441
2442 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
2443
2444         fix build-webkit --chromium after breakage in r102201
2445         https://bugs.webkit.org/show_bug.cgi?id=74031
2446
2447         Reviewed by Tony Chang.
2448
2449         r102201 introduced a change to the chromium build that splits
2450         the executables out of WebKit.gyp into other gyp files, and adds
2451         a new "All.gyp" that builds everything. However, I forgot to
2452         update the build script to use All.gyp.
2453
2454         * Scripts/webkitdirs.pm:
2455         (buildChromium):
2456
2457 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
2458
2459         Moved myself to the committers list.
2460
2461         * Scripts/webkitpy/common/config/committers.py:
2462
2463 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2464
2465         [Qt] Fix debug shlib build with V8.
2466
2467         Reviewed by Tor Arne Vestbø.
2468
2469         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
2470         v8 builds.
2471
2472 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2473
2474         [Qt] V8 build fixes.
2475
2476         Reviewed by Tor Arne Vestbø.
2477
2478         * qmake/mkspecs/features/javascriptcore.prf: Don't add
2479         Source/Thirdparty to the include search path here.
2480         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
2481         used when building WebCore as well as using it, because header files like
2482         GraphicsContext3D.h include stuff from ThirdParty.
2483
2484 2011-12-07  Peter Beverloo  <peter@chromium.org>
2485
2486         [Chromium] Fix project file generation for the Android bot after r102201
2487         https://bugs.webkit.org/show_bug.cgi?id=73996
2488
2489         The gyp refactoring in r102201 was didn't explicitly exclude
2490         the Android operating system in Tools/Tools.gyp, which broke
2491         as gcc_version is not defined for that configuration.
2492
2493         Reviewed by Andreas Kling.
2494
2495         * Tools.gyp:
2496
2497 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
2498
2499         Unreviewed. Disabled failing tests on chromium.
2500
2501         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2502         (TestWebKitAPI::TEST):
2503
2504 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
2505
2506         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
2507         https://bugs.webkit.org/show_bug.cgi?id=73382
2508
2509         Reviewed by Tony Chang.
2510
2511         XCode (and hence GYP) can't handle circular dependencies between
2512         files (and projects). Accordingly, although the binaries in
2513         WebKit.gyp depend on webkit_support and webkit_support depends
2514         on webkit, we don't mention the latter dependency in the file.
2515         To fix this, this change moves the binaries like DRT into a new
2516         GYP file, and modifies gyp_webkit to build from that file
2517         instead of WebKit.gyp.
2518
2519         * Tools.gyp: Added.
2520
2521 2011-12-06  Adam Roben  <aroben@apple.com>
2522
2523         Add a pid parameter to CrashLogs.find_newest_log
2524
2525         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
2526         considered.
2527
2528         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
2529         process whose crash log you want to find
2530
2531         Reviewed by Dirk Pranke.
2532
2533         * Scripts/webkitpy/common/system/crashlogs.py:
2534         (CrashLogs.find_newest_log): Added an optional pid parameter.
2535         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
2536         candidate log's app_description extended attribute to see if that log corresponds to a
2537         crashed process with the specified PID.
2538
2539         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2540         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
2541         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
2542         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
2543
2544         * Scripts/webkitpy/common/system/filesystem.py:
2545         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
2546         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
2547         present.
2548
2549         * Scripts/webkitpy/common/system/filesystem_mock.py:
2550         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
2551         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
2552         dictionary.
2553
2554         * Scripts/webkitpy/tool/commands/queries.py:
2555         (CrashLog): Added help text. Added an optional PID parameter.
2556         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
2557
2558 2011-12-06  Adam Roben  <aroben@apple.com>
2559
2560         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
2561
2562         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
2563         alive beyond the normal timeout limit. In cases where the crashed process was able to die
2564         faster, NRWT would assume that Crash Reporter had finished even though it often was still
2565         running, which would lead to an incorrect crash log being picked up.
2566
2567         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
2568
2569         Reviewed by Dirk Pranke.
2570
2571         * Scripts/webkitpy/layout_tests/port/server_process.py:
2572         (ServerProcess._reset):
2573         (ServerProcess.write):
2574         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
2575         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
2576         set_crashed.
2577
2578         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
2579         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
2580         we bail out of handling the failure as a timeout if we find out that the process in fact
2581         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
2582         so.
2583         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
2584         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
2585         disk.
2586
2587         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2588         (TrivialMockPort.is_crash_reporter): Added.
2589
2590         * Scripts/webkitpy/layout_tests/port/webkit.py:
2591         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
2592         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
2593
2594 2011-12-06  Adam Barth  <abarth@webkit.org>
2595
2596         NRWT fails on unreleased versions of Mac OS X
2597         https://bugs.webkit.org/show_bug.cgi?id=72748
2598
2599         Reviewed by Dirk Pranke.
2600
2601         Hopefully this patch will make NRWT work on future versions on Mac OS X.
2602         Most of the infrastructure was already in place, but there were some
2603         asserts that failed.  I've tested this patch by haxoring the version
2604         detection logic to simulate an unknown version.  We might need to
2605         iterate based on feedback from folks with a real future version.
2606
2607         * Scripts/webkitpy/layout_tests/port/apple.py:
2608         (ApplePort.__init__):
2609             - mac-future is an allowed port_name that's used internally by
2610               webkitpy to represent future versions of Mac OS X.
2611         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2612         (test_versions):
2613             - Test that we don't throw exceptions when dealing with future
2614               versions of Mac OS X.
2615         * Scripts/webkitpy/layout_tests/port/webkit.py:
2616         (WebKitPort._expectations_from_skipped_files):
2617             - Demote this logging message to "debug".  It's expected that
2618               mac-future doesn't have a Skipped file.
2619         * Scripts/webkitpy/layout_tests/port/mac.py:
2620         (MacPort.__init__):
2621         * Scripts/webkitpy/layout_tests/port/win.py:
2622         (WinPort.__init__):
2623             - Re-order some code in these constructors so that
2624               self._operating_system is available to the ApplePort constructor.
2625
2626 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
2627
2628         Added myself as a committer.
2629
2630         * Scripts/webkitpy/common/config/committers.py:
2631
2632 2011-12-06  Peter Beverloo  <peter@chromium.org>
2633
2634         Added myself as a committer.
2635
2636         * Scripts/webkitpy/common/config/committers.py:
2637
2638 2011-12-06  Kentaro Hara  <haraken@chromium.org>
2639
2640         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
2641         https://bugs.webkit.org/show_bug.cgi?id=73637
2642
2643         Reviewed by Adam Barth.
2644
2645         This patch replaces subprocess.Popen() with Executive, similar to other
2646         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
2647         works well for cases where no exception is raised, no exception is raised
2648         but diff is found, and ScriptError is raised.
2649
2650         * Scripts/run-bindings-tests:
2651         (main):
2652         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
2653         (BindingsTests.__init__):
2654         (BindingsTests.generate_from_idl):
2655         (BindingsTests.generate_supplemental_dependency):
2656         (BindingsTests.detect_changes):
2657
2658 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
2659
2660         [Qt] MiniBrowser should default to touch behavior
2661         https://bugs.webkit.org/show_bug.cgi?id=73863
2662
2663         Reviewed by Chang Shu.
2664
2665         MiniBrowser currently defaults to the traditional desktop behaviour
2666         instead of touch behaviour which is prefered.
2667
2668         * MiniBrowser/qt/BrowserWindow.cpp:
2669         (BrowserWindow::BrowserWindow):
2670         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2671         (printHelp):
2672         (MiniBrowserApplication::handleUserOptions):
2673         * MiniBrowser/qt/MiniBrowserApplication.h:
2674         (WindowOptions::WindowOptions):
2675         (WindowOptions::setUseTraditionalDesktopBehavior):
2676         (WindowOptions::useTraditionalDesktopBehavior):
2677
2678 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2679
2680         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
2681         https://bugs.webkit.org/show_bug.cgi?id=73878
2682
2683         Reviewed by Tony Chang.
2684
2685         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
2686         r98785 made webkit.py always use m_data16, which does not work when
2687         the string is an 8-bit string (such as KURL::string()).
2688
2689         I was not able to directly call StringImpl::is8Bit() in the Python
2690         code, so I just reproduced the implementation there.
2691
2692         * gdb/webkit.py:
2693         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2694         (WTFStringPrinter.to_string):
2695         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2696         (JSCUStringPrinter.to_string):
2697
2698 2011-12-05  Eric Seidel  <eric@webkit.org>
2699
2700         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
2701         in hopes of making the Snow Leopard bot stop timing out.
2702
2703         Unreviewed.
2704
2705         * Scripts/webkitpy/layout_tests/port/base.py:
2706         (Port.default_child_processes):
2707         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2708         (PortTest.test_default_child_processes):
2709
2710 2011-12-05  Eric Seidel  <eric@webkit.org>
2711
2712         NRWT creates too many workers on RAM-limited machines
2713         https://bugs.webkit.org/show_bug.cgi?id=73847
2714
2715         Reviewed by Dirk Pranke.
2716
2717         Make NRWT restrict its number of workers when there isn't enough
2718         RAM to support them.
2719         Also re-enable parallel testing on the Mac bots which were
2720         failing due to not enough ram.
2721
2722         * Scripts/run-webkit-tests:
2723         (platformIsReadyForParallelTesting):
2724         * Scripts/webkitpy/common/host.py:
2725         (Host.__init__):
2726         * Scripts/webkitpy/common/system/executive_mock.py:
2727         (MockExecutive.cpu_count):
2728         * Scripts/webkitpy/common/system/platforminfo.py:
2729         (PlatformInfo.__init__):
2730         (PlatformInfo.display_name):
2731         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2732         (MockPlatformInfo.display_name):
2733         * Scripts/webkitpy/layout_tests/port/base.py:
2734         (Port.default_child_processes):
2735         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2736         (PortTest.test_default_child_processes):
2737         (PortTest.test_pretty_patch_os_error):
2738
2739 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
2740
2741         Last mouse event could be lost if a JS call to eventSender.leapForward is made
2742         https://bugs.webkit.org/show_bug.cgi?id=73366
2743
2744         Reviewed by Kenneth Rohde Christiansen.
2745
2746         Empty the entire event queue when requested besides using
2747         sendEvent instead of postEvent to make sure all events were
2748         delivered.
2749
2750         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2751         (WTR::EventSenderProxy::EventSenderProxy):
2752         (WTR::EventSenderProxy::sendOrQueueEvent):
2753         (WTR::EventSenderProxy::replaySavedEvents):
2754
2755 2011-12-05  Adam Barth  <abarth@webkit.org>
2756
2757         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
2758         https://bugs.webkit.org/show_bug.cgi?id=73845
2759
2760         Reviewed by Darin Fisher.
2761
2762         Update includes to point to the new header locations.
2763
2764         * DumpRenderTree/chromium/AccessibilityController.cpp:
2765         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2766         * DumpRenderTree/chromium/CppBoundClass.cpp:
2767         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2768         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2769         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2770         * DumpRenderTree/chromium/EventSender.cpp:
2771         * DumpRenderTree/chromium/EventSender.h:
2772         * DumpRenderTree/chromium/GamepadController.h:
2773         * DumpRenderTree/chromium/LayoutTestController.cpp:
2774         * DumpRenderTree/chromium/LayoutTestController.h:
2775         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2776         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2777         * DumpRenderTree/chromium/PlainTextController.cpp:
2778         * DumpRenderTree/chromium/Task.cpp:
2779         * DumpRenderTree/chromium/TestNavigationController.h:
2780         * DumpRenderTree/chromium/TestShell.cpp:
2781         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2782         * DumpRenderTree/chromium/TestWebPlugin.h:
2783         * DumpRenderTree/chromium/TextInputController.cpp:
2784         * DumpRenderTree/chromium/WebPermissions.cpp:
2785         * DumpRenderTree/chromium/WebPreferences.h:
2786         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2787         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2788         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2789         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2790         * DumpRenderTree/chromium/WebViewHost.cpp:
2791
2792 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2793
2794         Add Aharon Lanin to the contributors list.
2795
2796         * Scripts/webkitpy/common/config/committers.py:
2797
2798 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
2799
2800         Moving myself from contributors to committers.
2801
2802         * Scripts/webkitpy/common/config/committers.py:
2803
2804 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2805
2806         Add myself as a committer.
2807
2808         * Scripts/webkitpy/common/config/committers.py:
2809
2810 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
2811
2812         [Qt] Rename QQuickWebView::canStop property to just loading 
2813         https://bugs.webkit.org/show_bug.cgi?id=73813
2814
2815         Reviewed by Kenneth Rohde Christiansen.
2816
2817         Replaced references to WebView.canStop with WebView.loading.
2818
2819         * MiniBrowser/qt/qml/BrowserWindow.qml:
2820
2821 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
2822
2823         run-webkit-tests: limit --child-processes properly on apple mac
2824         https://bugs.webkit.org/show_bug.cgi?id=73856
2825
2826         Reviewed by Adam Roben.
2827
2828         Fix typos in r102013 so that we correctly pass --child-processes=1 on
2829         the apple mac bots temporarily.
2830
2831         * Scripts/run-webkit-tests:
2832         (platformIsReadyForParallelTesting):
2833
2834 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2835
2836         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
2837         https://bugs.webkit.org/show_bug.cgi?id=73840
2838
2839         Reviewed by Simon Fraser.
2840
2841         Temporarily go back to single process mode on Mac.
2842
2843         * Scripts/run-webkit-tests:
2844         (platformIsReadyForParallelTesting):
2845
2846 2011-12-05  Adam Roben  <aroben@apple.com>
2847
2848         Redeploy apple-macpro-7 and apple-xserve-1
2849
2850         These slaves have been sitting idle since we removed our Leopard builders in r97496.
2851
2852         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
2853         sitting idle
2854
2855         Reviewed by Sam Weinig.
2856
2857         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
2858         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
2859         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
2860         (WebKit2 Tests)".
2861
2862 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2863
2864         [Qt] Make the UI of the MiniBrowser slightly nicer
2865
2866         Rubberstamped by Simon Hausmann.
2867
2868         - Add proper padding
2869         - Show feedback when pressing on the toolbar icons
2870         - Make the text entry better looking
2871
2872         * MiniBrowser/qt/qml/BrowserWindow.qml:
2873
2874 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2875
2876         NRWT should handle duplicated expectations
2877         https://bugs.webkit.org/show_bug.cgi?id=69750
2878
2879         Reviewed by Dirk Pranke.
2880
2881         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2882         (TestExpectations.__init__):
2883         (TestExpectations._report_errors):
2884         (TestExpectations._add_expectations):
2885         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2886         (test_add_skipped_tests):
2887         * Scripts/webkitpy/layout_tests/port/base.py:
2888         (Port.skipped_tests):
2889         * Scripts/webkitpy/layout_tests/port/webkit.py:
2890         (WebKitPort.test_expectations):
2891         (WebKitPort.skipped_tests):
2892         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2893         (test_test_expectations):
2894
2895 2011-12-04  Eric Seidel  <eric@webkit.org>
2896
2897         After success with Mac, Win and Gtk, turning on parallel testing
2898         by default for all platforms (except Qt).
2899
2900         We'll add more platforms to the blacklist if we see problems.
2901
2902         Unreviewed.
2903
2904         * Scripts/run-webkit-tests:
2905         (platformIsReadyForParallelTesting):
2906
2907 2011-12-04  Sam Weinig  <sam@webkit.org>
2908
2909         Add tests for RetainPtr::adoptNS/adoptCF
2910         https://bugs.webkit.org/show_bug.cgi?id=73470
2911
2912         Reviewed by Adam Roben and Darin Adler.
2913
2914         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2915         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
2916         (TestWebKitAPI::TEST):
2917         Test that adopting using adoptCF creates a RetainPtr with a
2918         value whose retain count is 1.
2919
2920         * TestWebKitAPI/Tests/WTF/ns: Added.
2921         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
2922         (TestWebKitAPI::TEST):
2923         Test that adopting using adoptNS creates a RetainPtr with a
2924         value whose retain count is 1.
2925
2926 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
2927
2928         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
2929         https://bugs.webkit.org/show_bug.cgi?id=73748
2930
2931         Reviewed by Gustavo Noronha Silva.
2932
2933         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
2934
2935 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2936
2937         Another GTK build fix after r101922.
2938
2939         Rubber-stamped by Martin Robinson.
2940
2941         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2942         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
2943
2944 2011-12-04  Xan Lopez  <xlopez@igalia.com>
2945
2946         Fix compiler warning in LayoutTestController
2947
2948         Reviewed by Philippe Normand.
2949
2950         * DumpRenderTree/LayoutTestController.cpp:
2951         (LayoutTestController::LayoutTestController): fix warning.
2952
2953 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
2954
2955         Add missing methods used by fast/notifications tests to LayoutTestController
2956         https://bugs.webkit.org/show_bug.cgi?id=63616
2957
2958         Reviewed by Martin Robinson.
2959
2960         Add missing simulateDesktopNotificationClick method used by
2961         fast/notifications. Provide a default implementation for
2962         areDesktopNotificationPermissionRequestsIgnored and
2963         ignoreDesktopNotificationPermissionRequests.
2964
2965         * DumpRenderTree/LayoutTestController.cpp:
2966         (LayoutTestController::LayoutTestController): call into the port implementation.
2967         (simulateDesktopNotificationClickCallback): ditto.
2968         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
2969         (LayoutTestController::staticFunctions): declare new methods.
2970         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
2971         * DumpRenderTree/LayoutTestController.h:
2972         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
2973         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2974         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
2975         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2976         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2977         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2978         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2979         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2980         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2981         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2982         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2983
2984 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
2985
2986         [GTK] Don't log document events in DRT
2987         https://bugs.webkit.org/show_bug.cgi?id=73746
2988
2989         Reviewed by Martin Robinson.
2990
2991         Stop connecting globally to document-related events.
2992
2993         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2994         (connectAccessibilityCallbacks): Removed connections.
2995         (disconnectAccessibilityCallbacks): Removed disconnections.
2996
2997 2011-12-03  Dan Bernstein  <mitz@apple.com>
2998
2999         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
3000
3001         Reviewed by Darin Adler.
3002
3003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3004         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
3005         (TestWebKitAPI::TEST):
3006
3007 2011-12-03  Philippe Normand  <pnormand@igalia.com>
3008
3009         Another GTK build fix after r101922.
3010
3011         Rubber-stamped by Martin James Robinson.
3012
3013         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3014         (LayoutTestController::pathToLocalResource): return value needs to
3015         be a URI.
3016
3017 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3018
3019         Small fix for my previous patch. Do not try to delete a member
3020         of a dictionary that does not exist.
3021
3022         Reviewed by Gustavo Noronha Silva.
3023
3024         * gtk/run-with-jhbuild:
3025         (install_and_run_jhbuild):
3026
3027 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3028
3029         Fix jhbuild installation for people who have unusual MAKE environment
3030         variables such as 'make -j4' as the jhbuild build does not handle it.
3031
3032         Reviewed by Gustavo Noronha Silva.
3033
3034         * gtk/run-with-jhbuild:
3035         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
3036
3037 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3038
3039         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
3040         when run for the first time.
3041
3042         Reviewed by Gustavo Noronha Silva.
3043
3044         * Scripts/update-webkitgtk-libs: Fix first run.
3045
3046 2011-12-03  Philippe Normand  <pnormand@igalia.com>
3047
3048         Unreviewed, GTK build fix after r101922.
3049
3050         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3051         (LayoutTestController::pathToLocalResource): Added sentinel in
3052         g_build_filename call.
3053
3054 2011-12-03  Philippe Normand  <pnormand@igalia.com>
3055
3056         GTK API tests build fix. Run the tests inside jhbuild.
3057
3058         Rubber-stamped by Gustavo Noronha Silva.
3059
3060         * Scripts/run-gtk-tests:
3061         (TestRunner.__init__):
3062         (TestRunner.run._error_handler):
3063         (TestRunner):
3064         (TestRunner.run):
3065
3066 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3067
3068         Small build fix. Properly specify the path to the locally installed jhbuild.
3069
3070         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
3071
3072 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3073
3074         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
3075         https://bugs.webkit.org/show_bug.cgi?id=67256
3076
3077         Reviewed by Philippe Normand.
3078
3079         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing 
3080         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
3081         which points to the more generic top-level path of the WebKit checkout. This code is
3082         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
3083         share code here.
3084
3085         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
3086         location. This will cause the fallback to fail if you build into a non-typical location
3087         or even fake it with a symlink. In this case it's important to use the environment variable.
3088
3089         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3090         (getTopLevelPath): Added.
3091         (initializeFonts): Use the new helper to get the font path.
3092         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
3093         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3094         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
3095         test paths.
3096         * Scripts/webkitpy/layout_tests/port/gtk.py:
3097         (GtkPort.setup_environ_for_server):Pass the top-level path of the
3098         checkout instead of passing the font path.
3099         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3100         (WTR::getTopLevelPath): Added this helper.
3101         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
3102
3103 2011-12-02  David Levin  <levin@chromium.org>
3104
3105         Rename WTF class from TemporarilyChange to TemporaryChange.
3106         https://bugs.webkit.org/show_bug.cgi?id=73479
3107
3108         Reviewed by Eric Seidel.
3109
3110         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
3111         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
3112         * TestWebKitAPI/TestWebKitAPI.gypi:
3113         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3114         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
3115         (TestWebKitAPI::TEST):
3116         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3117
3118 2011-12-02  Tony Chang  <tony@chromium.org>
3119
3120         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
3121         https://bugs.webkit.org/show_bug.cgi?id=73453
3122
3123         Reviewed by Ryosuke Niwa.
3124
3125         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
3126         The verbose output will include the failure reason.
3127
3128         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
3129         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3130         (write_test_result):
3131         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
3132         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
3133         (determine_result_type):
3134         (FailureReftestNoImagesGenerated.__init__):
3135         (FailureReftestNoImagesGenerated):
3136         (FailureReftestNoImagesGenerated.message):
3137         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
3138         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
3139         (MainTest.test_run_singly_actually_runs_tests):
3140         (MainTest.test_unexpected_failures):
3141         (EndToEndTest.test_end_to_end):
3142
3143 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
3144
3145         ChangeLog should be able to parse annotated changelogs
3146         https://bugs.webkit.org/show_bug.cgi?id=72703
3147
3148         Reviewed by Eric Seidel.
3149
3150         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
3151         and extract the revision number for each entry.
3152
3153         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
3154
3155         * Scripts/webkitpy/common/checkout/changelog.py:
3156         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3157         * Scripts/webkitpy/common/checkout/scm/git.py:
3158         * Scripts/webkitpy/common/checkout/scm/scm.py:
3159         * Scripts/webkitpy/common/checkout/scm/svn.py:
3160
3161 2011-12-02  Eric Seidel  <eric@webkit.org>
3162
3163         Enable parallel testing for Win and Gtk bots
3164         after confirming with Lucas and Martin the bots should be OK.
3165
3166         Unreviewed. (I ran the idea by Lucas and Martin.)
3167
3168         * Scripts/run-webkit-tests:
3169         (platformIsReadyForParallelTesting):
3170
3171 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3172
3173         Try to fix the GTK+ build.
3174
3175         * gtk/jhbuild.modules: Properly specify the glib-networking
3176         dependency for soup.
3177
3178 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3179
3180         Fix a syntax error in the committers.py file.
3181
3182         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
3183
3184 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
3185
3186         Add Alan Stearns and Peter Linss to the contributors list.
3187
3188         * Scripts/webkitpy/common/config/committers.py:
3189
3190 2011-12-02  Kent Tamura  <tkent@chromium.org>
3191
3192         [Chromium] Fix compilation warnings for ASSERT()
3193         https://bugs.webkit.org/show_bug.cgi?id=73623
3194
3195         Reviewed by Tony Chang.
3196
3197         * DumpRenderTree/chromium/ImageDiff.cpp:
3198          - Fix fprintf format: %s -> %d for __LINE__
3199          - Do nothing for ASSERT() if NDEBUG.
3200
3201 2011-12-02  Eric Seidel  <eric@webkit.org>
3202
3203         Enable parallel testing for all Mac bots.
3204
3205         Unreviewed.
3206
3207         * Scripts/run-webkit-tests:
3208         (platformIsReadyForParallelTesting):
3209
3210 2011-12-02  Eric Seidel  <eric@webkit.org>
3211
3212         Enable parallel testing for run-webkit-tests on Mac Lion.
3213         I plan to move all the machines to parallel testing shortly
3214         but we're starting with Lion.
3215
3216         Unreviewed.
3217
3218         * Scripts/run-webkit-tests:
3219         (platformIsReadyForParallelTesting):
3220
3221 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
3222
3223         Added helper method to identify whether the page has custom page size style.
3224         https://bugs.webkit.org/show_bug.cgi?id=73585
3225
3226         Reviewed by Darin Fisher.
3227
3228         * DumpRenderTree/chromium/LayoutTestController.cpp:
3229         (LayoutTestController::LayoutTestController):
3230         (LayoutTestController::hasCustomPageSizeStyle):
3231         * DumpRenderTree/chromium/LayoutTestController.h:
3232
3233 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
3234
3235         [NRWT] reftest should support having multiple references per test
3236         https://bugs.webkit.org/show_bug.cgi?id=73613
3237
3238         Reviewed by Dirk Pranke.
3239
3240         Add a support for having multiple reference files for a single test.
3241
3242         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
3243         at least one of expected mismatches, we compare expected mismatches first in order to minimize
3244         the number of reference files to open on DRT.
3245
3246         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3247         (interpret_test_failures): Remove checks no longer applicable.
3248         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3249         (ResultSummaryTest.test_interpret_test_failures): Ditto.
3250         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3251         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
3252         (SingleTestRunner._driver_input):
3253         (SingleTestRunner.run):
3254         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
3255         * Scripts/webkitpy/layout_tests/models/test_input.py:
3256         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
3257         * Scripts/webkitpy/layout_tests/port/base.py:
3258         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
3259         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
3260         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3261         (PortTest.test_parse_reftest_list):
3262         * Scripts/webkitpy/layout_tests/port/test.py:
3263         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3264         (MainTest.test_unexpected_failures):
3265         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
3266         (EndToEndTest.test_end_to_end):
3267         (EndToEndTest.test_reftest_with_two_notrefs): Added.
3268
3269 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3270
3271         Build libsoup without gnome dependencies (like keyring).
3272
3273         * gtk/jhbuild.modules:
3274
3275 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3276
3277         Also build gcrypt and p11-kit, and make them dependencies of
3278         gnutls.
3279
3280         * gtk/jhbuild.modules:
3281
3282 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
3283
3284         [wx] Unreviewed build fixes for Windows build.
3285
3286         * waf/build/wxpresets.py:
3287
3288 2011-12-01  Eric Seidel  <eric@webkit.org>
3289
3290         Reviewed by Adam Barth.
3291
3292         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
3293         https://bugs.webkit.org/show_bug.cgi?id=32006
3294
3295         I decided not to make it warn, and just have it re-open the bug.
3296         That's not that different from today's behavior which will
3297         just silently attach the patch.
3298
3299         This patch makes behavior between upload and land-safely consistent
3300         (previously one would assign patches and the other would not)
3301         as well as adds the ability for both to ensure that the bug is open.
3302
3303         To test this I had to add a few more methods to MockBugzilla which
3304         (positively) affected a few other test results.
3305
3306         I also made AbstractStep keep a cached copy of the Bug object
3307         and used the cached copy where appropriate (including for 'bug_title').
3308         This should reduce the number of bug fetches we perform.
3309
3310         * Scripts/webkitpy/tool/commands/download_unittest.py:
3311         * Scripts/webkitpy/tool/commands/upload.py:
3312         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3313         * Scripts/webkitpy/tool/mocktool.py:
3314         * Scripts/webkitpy/tool/steps/__init__.py:
3315         * Scripts/webkitpy/tool/steps/abstractstep.py:
3316         * Scripts/webkitpy/tool/steps/closebug.py:
3317         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
3318         * Scripts/webkitpy/tool/steps/postdiff.py:
3319         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3320         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3321         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3322         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3323
3324 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3325
3326         Also pass --no-interact to jhbuild when updating dependencies.
3327
3328         * Scripts/update-webkitgtk-libs:
3329
3330 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
3331
3332         Make _build_path check more thoroughly that build paths exist.
3333         https://bugs.webkit.org/show_bug.cgi?id=73601
3334
3335         Reviewed by Ojan Vafai.
3336
3337         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3338         (ChromiumMacPort._build_path):
3339
3340 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3341
3342         Add libffi to the jhbuild modules list as a glib dependency.
3343
3344         Rubber-stamped by Martin Robinson.
3345
3346         * gtk/jhbuild.modules:
3347
3348 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3349
3350         Build fix. Use internal pcre on glib, make gnutls a dependency of
3351         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
3352         in non-interactive mode.
3353
3354         * Scripts/update-webkitgtk-libs:
3355         * gtk/jhbuild.modules:
3356         * gtk/run-with-jhbuild:
3357
3358 2011-12-02  Adam Roben  <aroben@apple.com>
3359
3360         Fix for Python 2.6
3361
3362         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3363         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
3364         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
3365         searching for "Tests that timed out:" etc. This makes our check less strict, but it
3366         shouldn't matter given the kinds of content we parse.
3367
3368 2011-12-02  Adam Roben  <aroben@apple.com>
3369
3370         Fix names of failed/timed out tests in run-api-tests output
3371
3372         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
3373         out tests
3374
3375         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
3376
3377         Reviewed by Simon Fraser.
3378
3379         * Scripts/run-api-tests:
3380         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
3381         of this function.
3382
3383 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
3384
3385         [GTK] generate-gtkdoc should respect build type
3386         https://bugs.webkit.org/show_bug.cgi?id=73296
3387
3388         Reviewed by Philippe Normand.
3389
3390         * Scripts/webkitdirs.pm:
3391         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
3392         * gtk/common.py: If --build is passed give preference to the Debug build directory.
3393
3394 2011-12-02  Tony Chang  <tony@chromium.org>
3395
3396         [nrwt] fix wdiff output
3397         https://bugs.webkit.org/show_bug.cgi?id=73604
3398
3399         Reviewed by Adam Barth.
3400
3401         * Scripts/webkitpy/layout_tests/port/base.py:
3402         (Port.wdiff_text):
3403         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3404         (PortTest.test_wdiff_text):
3405
3406 2011-12-02  Adam Roben  <aroben@apple.com>
3407
3408         Teach build.webkit.org to display how many unit tests failed or timed out
3409
3410         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
3411         build.webkit.org
3412
3413         We now display something like "5 unit tests failed or timed out". Eventually we might want
3414         to split out how many failure vs. timeouts there were.
3415
3416         Reviewed by Darin Adler.
3417
3418         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3419         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
3420         classes that may want to subclass it.
3421         (RunUnitTests): Changed to inherit from TestWithFailureCount.
3422         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
3423         timed out:" and "Tests that failed:" lines, if present.
3424
3425         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3426         (StubStdio):
3427         (StubRemoteCommand):
3428         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
3429
3430         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
3431         the test run correctly.
3432
3433         (RunUnitTestsTest.test_no_failures_or_timeouts):
3434         (RunUnitTestsTest.test_one_failure):
3435         (RunUnitTestsTest.test_multiple_failures):
3436         (RunUnitTestsTest.test_one_timeout):
3437         (RunUnitTestsTest.test_multiple_timeouts):
3438         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
3439         Test various cases.
3440
3441 2011-12-02  Adam Roben  <aroben@apple.com>
3442
3443         Teach prepare-ChangeLog to treat master.cfg as a Python file
3444
3445         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
3446         in buildbot's master.cfg
3447
3448         Reviewed by Darin Adler.
3449
3450         * Scripts/prepare-ChangeLog:
3451         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
3452         master.cfg.
3453
3454 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3455
3456         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
3457         https://bugs.webkit.org/show_bug.cgi?id=73669
3458
3459         Reviewed by Gustavo Noronha Silva.
3460
3461         Add a wrapper script that knows how to install jhbuild and also to wrap commands
3462         in the jhbuild shell.
3463
3464         * Scripts/webkitdirs.pm:
3465         (runAutogenForAutotoolsProject): Use the new wrapper script.
3466         (mustReRunAutogen): Ditto.
3467         (buildAutotoolsProject): Ditto.
3468         * Scripts/webkitpy/layout_tests/port/gtk.py:
3469         (GtkDriver.cmd_line): Ditto.
3470         * gtk/run-with-jhbuild: Added.
3471
3472 2011-12-01  Adam Roben  <aroben@apple.com>
3473
3474         Teach check-webkit-style how to check the syntax of JSON files
3475
3476         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3477
3478         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
3479         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
3480         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
3481         been removed, since its output differs by platform.
3482
3483         Reviewed by Darin Adler.
3484
3485         * Scripts/webkitpy/style/checker.py:
3486         (_all_categories): Added JSONChecker's categories to the set of all categories.
3487         (FileType): Added a JSON type. Incremented other types.
3488         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3489         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3490
3491         * Scripts/webkitpy/style/checker_unittest.py:
3492         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3493         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3494
3495         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3496         which would have matched our other checkers, because I couldn't figure out how to call
3497         "json.loads" without hitting namespace conflicts.)
3498         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3499         just the modified lines from a patch.
3500         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3501         exception.
3502         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3503         try to extract a line number.
3504
3505         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3506         (MockErrorHandler.__init__):
3507         (MockErrorHandler.turn_off_line_filtering):
3508         (MockErrorHandler.__call__):
3509         Helper class. Copied from xml_unittest.py.
3510
3511         (JSONCheckerTest.test_line_number_from_json_exception): Test the
3512         line_number_from_json_exception helper method.
3513
3514         (JSONCheckerTest.assert_no_error):
3515         (JSONCheckerTest.assert_error):
3516         Helper methods to assert that we did or didn't get an error.
3517
3518         (JSONCheckerTest.mock_handle_style_error): Helper method.
3519
3520         (JSONCheckerTest.test_conflict_marker):
3521         (JSONCheckerTest.test_single_quote):
3522         (JSONCheckerTest.test_init):
3523         (JSONCheckerTest.test_no_error):
3524         Test various cases.
3525
3526 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3527
3528         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
3529         https://bugs.webkit.org/show_bug.cgi?id=73664
3530
3531         Reviewed by Martin Robinson.
3532
3533         This patch adds our HTTP library and its main dependencies; this
3534         should not affect layout or rendering.
3535
3536         * gtk/jhbuild.modules:
3537
3538 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3539
3540         [GTK] Also run DumpRenderTree under jhbuild
3541         https://bugs.webkit.org/show_bug.cgi?id=73646
3542
3543         Reviewed by Martin Robinson.
3544
3545         * Scripts/webkitpy/layout_tests/port/gtk.py:
3546         (GtkDriver.cmd_line):
3547
3548 2011-12-02  Hajime Morrita  <morrita@chromium.org>
3549
3550         Unreviewed, rolling out r101751 and r101775.
3551         http://trac.webkit.org/changeset/101751
3552         http://trac.webkit.org/changeset/101775
3553         https://bugs.webkit.org/show_bug.cgi?id=73191
3554
3555         breaks Windows build
3556
3557         * DumpRenderTree/chromium/config.h:
3558         * DumpRenderTree/config.h:
3559         * TestWebKitAPI/config.h:
3560         * WebKitTestRunner/config.h:
3561
3562 2011-12-02  Kentaro Hara  <haraken@chromium.org>
3563
3564         Move run-bindings-tests implementation to webkitpy/bindings/main.py
3565         https://bugs.webkit.org/show_bug.cgi?id=73619
3566
3567         Reviewed by Adam Barth.
3568
3569         As run-bindings-tests has been growing, this patch just moves its implementation
3570         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
3571
3572         No change in behavior.
3573
3574         * Scripts/run-bindings-tests:
3575         (main):
3576         * Scripts/webkitpy/bindings/__init__.py: Added.
3577         * Scripts/webkitpy/bindings/main.py: Added.
3578         (BindingsTests.__init__):
3579         (BindingsTests.generate_from_idl):
3580         (BindingsTests.generate_supplemental_dependency):
3581         (BindingsTests.detect_changes):
3582         (BindingsTests.run_tests):
3583
3584 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
3585
3586         Tools/Scripts: eliminate find_test_files from Port class.
3587         https://bugs.webkit.org/show_bug.cgi?id=73553
3588
3589         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
3590         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
3591         Also I'll move _is_test_file() and related functions close to Port.tests().
3592
3593         Reviewed by Dirk Pranke.
3594
3595         * Scripts/webkitpy/layout_tests/port/base.py:
3596         (Port.tests):
3597         (Port.is_reference_html_file):
3598         (Port._has_supported_extension):
3599         (Port._is_test_file):
3600         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3601         (PortTest.test_find_no_paths_specified):
3602         (PortTest.test_find_one_test):
3603         (PortTest.test_find_glob):
3604         (PortTest.test_find_with_skipped_directories):
3605         (PortTest.test_find_with_skipped_directories_2):
3606         (PortTest.test_is_test_file):
3607         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3608         (_default_tests_paths):
3609         (ChromiumGpuLinuxPort.tests):
3610         (ChromiumGpuCgMacPort.tests):
3611         (ChromiumGpuMacPort.tests):
3612         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3613         (ChromiumGpuTest.test_default_tests_paths.test_paths):
3614         (ChromiumGpuTest.test_default_tests_paths):
3615         (ChromiumGpuTest.test_test_files.test_paths):
3616         (ChromiumGpuTest):
3617         (ChromiumGpuTest.test_test_files):
3618         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3619         (get_tests_run.RecordingTestDriver.run_test):
3620         * Scripts/webkitpy/tool/commands/rebaseline.py:
3621         (OptimizeBaselines._optimize_baseline):
3622         (OptimizeBaselines.execute):
3623         (AnalyzeBaselines._analyze_baseline):
3624         (AnalyzeBaselines.execute):
3625
3626 2011-12-01  Hajime Morrita  <morrita@chromium.org>
3627
3628         JS_INLINE and WTF_INLINE should be visible from WebCore
3629         https://bugs.webkit.org/show_bug.cgi?id=73191
3630
3631         Reviewed by Kevin Ollivier.
3632
3633         Removed macro definitions which is now provided by Platform.h
3634
3635         * DumpRenderTree/chromium/config.h:
3636         * DumpRenderTree/config.h:
3637         * TestWebKitAPI/config.h:
3638         * WebKitTestRunner/config.h:
3639
3640 2011-12-01  Hayato Ito  <hayato@chromium.org>
3641
3642         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
3643         https://bugs.webkit.org/show_bug.cgi?id=73406
3644
3645         Reviewed by Ryosuke Niwa.
3646
3647         WebKitPort's image_diff uses tolerance='0.1' in default.
3648         When reftests fail, we should use tolerace=0 when diff-ing images.
3649
3650         Since ImageDiff on chromium port doesn't use tolerance value as of now,
3651         this change doesn't affect chromium port's behavior.
3652
3653         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
<