6324518ebddcdb415614a6de8fcd5df626d122e3
[WebKit-https.git] / Tools / ChangeLog
1 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2
3         [EFL] Bump cairo version to 1.14.2
4         https://bugs.webkit.org/show_bug.cgi?id=148474
5
6         Reviewed by Csaba Osztrogonác.
7
8         * efl/jhbuild.modules:
9
10 2015-08-26  Andy Estes  <aestes@apple.com>
11
12         Crash when following a Google search link to Twitter with Limit Adult Content enabled
13         https://bugs.webkit.org/show_bug.cgi?id=147651
14
15         Rubber-stamped by Brady Eidson.
16
17         Taught TestRunner how to decide the navigation policy after a delay.
18
19         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
20         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
21         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
22         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
23         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
24         * WebKitTestRunner/InjectedBundle/TestRunner.h:
25         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
26         * WebKitTestRunner/TestController.cpp:
27         (WTR::TestController::initialize):
28         (WTR::TestController::resetStateToConsistentValues):
29         (WTR::TestController::decidePolicyForNavigationAction):
30         * WebKitTestRunner/TestController.h:
31         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
32         * WebKitTestRunner/TestInvocation.cpp:
33         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
34
35 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
36
37         [Win] Rename 'WinLauncher' to 'MiniBrowser'
38         https://bugs.webkit.org/show_bug.cgi?id=148485
39
40         Reviewed by Alex Christensen
41
42         Move the WinLauncher project and source files to a subdirectory
43         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
44         source code and project files.
45         
46         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
47         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
48         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
49         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
50         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
51         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
52         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
53         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
54         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
55         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
56         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
57         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
58         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
59         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
60         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
61         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
62         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
63         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
64         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
65         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
66         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
67         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
68         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
69         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
70         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
71         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
72         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
73         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
74         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
75         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
76         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
77         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
78         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
79         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
80         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
81         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
82         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
83         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
84         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
85         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
86         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
87         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
88         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
89         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
90         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
91         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
92         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
93         * MiniBrowser/win: Copied from WinLauncher.
94         * MiniBrowser/win/Common.cpp:
95         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
96         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
97         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
98         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
99         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
100         * MiniBrowser/win/PageLoadTestClient.cpp:
101         * MiniBrowser/win/PageLoadTestClient.h:
102         * MiniBrowser/win/ResourceLoadDelegate.cpp:
103         * MiniBrowser/win/ResourceLoadDelegate.h:
104         * MiniBrowser/win/WinLauncher.cpp: Removed.
105         * MiniBrowser/win/WinLauncher.h: Removed.
106         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
107         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
108         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
109         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
110         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
111         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
112         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
113         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
114         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
115         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
116         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
117         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
118         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
119         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
120         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
121         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
122         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
123         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
124         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
125         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
126         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
127         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
128         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
129         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
130         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
131         * MiniBrowser/win/WinLauncherReplace.h: Removed.
132         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
133         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
134         * MiniBrowser/win/WinMain.cpp:
135         * WinLauncher: Removed.
136         * WinLauncher/AccessibilityDelegate.cpp: Removed.
137         * WinLauncher/AccessibilityDelegate.h: Removed.
138         * WinLauncher/CMakeLists.txt: Removed.
139         * WinLauncher/Common.cpp: Removed.
140         * WinLauncher/DOMDefaultImpl.cpp: Removed.
141         * WinLauncher/DOMDefaultImpl.h: Removed.
142         * WinLauncher/PageLoadTestClient.cpp: Removed.
143         * WinLauncher/PageLoadTestClient.h: Removed.
144         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
145         * WinLauncher/PrintWebUIDelegate.h: Removed.
146         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
147         * WinLauncher/ResourceLoadDelegate.h: Removed.
148         * WinLauncher/WebDownloadDelegate.cpp: Removed.
149         * WinLauncher/WebDownloadDelegate.h: Removed.
150         * WinLauncher/WinLauncher.cpp: Removed.
151         * WinLauncher/WinLauncher.h: Removed.
152         * WinLauncher/WinLauncher.vcxproj: Removed.
153         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
154         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
155         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
156         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
157         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
158         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
159         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
160         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
161         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
162         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
163         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
164         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
165         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
166         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
167         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
168         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
169         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
170         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
171         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
172         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
173         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
174         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
175         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
176         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
177         * WinLauncher/WinLauncherReplace.h: Removed.
178         * WinLauncher/WinLauncherWebHost.cpp: Removed.
179         * WinLauncher/WinLauncherWebHost.h: Removed.
180         * WinLauncher/WinMain.cpp: Removed.
181         * WinLauncher/resource.h: Removed.
182         * WinLauncher/stdafx.cpp: Removed.
183         * WinLauncher/stdafx.h: Removed.
184         * win/AssembleBuildLogs/AssembleLogs.cmd:
185
186 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
187
188         [Win] Simplify menu handling code in WinLauncher
189         https://bugs.webkit.org/show_bug.cgi?id=148461
190
191         Reviewed by Zalan Bujtas.
192
193         Revise 'ToggleMenuItem' to return a boolean value indicating if
194         it handled the message. Revise WndProc to use this to decide if it
195         should pass the message on to the default handler, rather than
196         duplicating the logic in both places.
197         
198         * WinLauncher/Common.cpp:
199         (ToggleMenuItem): Return true if the menu item message was handled.
200         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
201         the message tothe default handler.
202
203 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
204
205         Remove unused code after r188948
206         https://bugs.webkit.org/show_bug.cgi?id=148467
207
208         Reviewed by Gyuyoung Kim.
209
210         * WebKitTestRunner/TestController.cpp:
211         (WTR::TestController::platformPreferences): Deleted.
212
213 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
214
215         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
216         https://bugs.webkit.org/show_bug.cgi?id=148377
217
218         Reviewed by Carlos Garcia Campos.
219
220         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
221         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
222         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
223         EFL and GTK at the moment.
224
225         * WebKitTestRunner/TestController.cpp:
226         (WTR::TestController::platformWillRunTest):
227         * WebKitTestRunner/efl/TestControllerEfl.cpp:
228         (WTR::TestController::platformPreferences):
229         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
230         (WTR::TestController::platformPreferences):
231
232 2015-08-25  Nan Wang  <n_wang@apple.com>
233
234         AX: Enable accessibility/aria-controls.html test for mac
235         https://bugs.webkit.org/show_bug.cgi?id=148458
236
237         Reviewed by Chris Fleizach.
238
239         Implemented ariaControlsElementAtIndex(unsigned index).
240
241         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
242         (AccessibilityUIElement::ariaControlsElementAtIndex):
243         (AccessibilityUIElement::disclosedRowAtIndex):
244         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
245         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
246
247 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
248
249         Remove python tests for PassRefPtr 
250         https://bugs.webkit.org/show_bug.cgi?id=148463
251
252         Reviewed by Andy Estes.
253
254         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
255
256         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
257         (PassPtrTest): Deleted.
258         (PassPtrTest.assert_pass_ptr_check): Deleted.
259         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
260         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
261         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
262         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
263         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
264         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
265
266 2015-08-25  Andy Estes  <aestes@apple.com>
267
268         [iOS] run-webkit-tests fails if watchOS SDK is installed
269         https://bugs.webkit.org/show_bug.cgi?id=148453
270
271         Reviewed by David Kilzer.
272
273         * Scripts/webkitpy/xcode/simulator.py:
274         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
275         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
276
277 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
278
279         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
280         https://bugs.webkit.org/show_bug.cgi?id=148197
281         rdar://problem/22334382
282
283         Reviewed by Daniel Bates.
284
285         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
286         * Scripts/webkitpy/port/ios.py:
287         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
288         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
289         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
290         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
291         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
292
293 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
294
295         Remove PassRefPtr style check rule
296         https://bugs.webkit.org/show_bug.cgi?id=148432
297
298         Reviewed by Andreas Kling.
299
300         PassRefPtr is being removed. Thus style rule needs to be removed as well.
301
302         * Scripts/webkitpy/style/checkers/cpp.py:
303         (_check_parameter_name_against_text): Deleted.
304         (check_function_definition_and_pass_ptr): Deleted.
305         (check_function_definition): Deleted.
306         (check_pass_ptr_usage): Deleted.
307         (process_line): Deleted.
308         (CppChecker): Deleted.
309
310 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
311
312         [Win] Expose "Inverted Colors" option in WinLauncher
313         https://bugs.webkit.org/show_bug.cgi?id=148451
314
315         Reviewed by Tim Horton.
316
317         Add the ability to toggle the "Inverted Colors" preference
318         in WinLauncher.
319         
320         * WinLauncher/Common.cpp:
321         (ToggleMenuItem): Toggle the feature when the menu item
322         is selected.
323         (WndProc): Recognize the new menu option.
324         * WinLauncher/WinLauncher.cpp:
325         (WinLauncher::setToDefaultPreferences): Launch with "Invert
326         Colors" turned off.
327         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
328         entry for "Invert Colors".
329         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
330
331 2015-08-25  Nan Wang  <n_wang@apple.com>
332
333         [Mac] accessibility/document-attributes.html fails
334         https://bugs.webkit.org/show_bug.cgi?id=116636
335
336         Reviewed by Chris Fleizach.
337
338         Implemented documentURI() and documentEncoding().
339
340         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
341         (AccessibilityUIElement::documentEncoding):
342         (AccessibilityUIElement::documentURI):
343         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
344         (WTR::AccessibilityUIElement::documentEncoding):
345         (WTR::AccessibilityUIElement::documentURI):
346
347 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
348
349         [Win] Unreviewed test gardening.
350
351         Fix another case where the logging string is constructed using the variable 'frame',
352         but the method argument is not given a name. This causes the global 'frame' value to
353         be used, producing incorrect output.
354
355         * DumpRenderTree/win/FrameLoadDelegate.cpp:
356         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
357         argument.
358
359 2015-08-24  Tim Horton  <timothy_horton@apple.com>
360
361         (Finally...) get rid of WKViewIOS
362         https://bugs.webkit.org/show_bug.cgi?id=148404
363
364         Reviewed by Anders Carlsson.
365
366         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
367         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
368         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
369         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
370         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
371         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
372         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
373         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
374         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
375         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
376         Mark tests that use WKBrowsingContextController as Mac-only.
377
378         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
379         (WTR::AccessibilityController::addNotificationListener):
380         * WebKitTestRunner/ios/mainIOS.mm:
381         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
382         Import UIKit instead of depending on WKView.h to do so.
383
384 2015-08-24  Jason Marcell  <jmarcell@apple.com>
385
386         Add support to dashboard for displaying Git SHA's as revisions.
387         https://bugs.webkit.org/show_bug.cgi?id=148387
388
389         Reviewed by Daniel Bates.
390
391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
392         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
393         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
394         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
396         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
397
398 2015-08-24  Andy Estes  <aestes@apple.com>
399
400         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
401
402         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
403
404 2015-08-23  Andy Estes  <aestes@apple.com>
405
406         Addressed a missed piece of review feedback from r188851.
407
408         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
409
410 2015-08-23  Andy Estes  <aestes@apple.com>
411
412         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
413         https://bugs.webkit.org/show_bug.cgi?id=147872
414         rdar://problem/22044000
415
416         Reviewed by Dan Bernstein.
417         
418         Added an API test.
419
420         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
422         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
423         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
424         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
425         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
426         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
427         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
428         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
429         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
430         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
431
432 2015-08-23  Andy Estes  <aestes@apple.com>
433
434         Fixed the 32-bit Mac build after r188844.
435
436         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
437         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
438
439 2015-08-22  Andy Estes  <aestes@apple.com>
440
441         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
442         https://bugs.webkit.org/show_bug.cgi?id=148317
443
444         Reviewed by Dan Bernstein.
445
446         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
447         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
448         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
449         when creating WKWebViews.
450
451         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
452         added a new API test for bundle parameters.
453
454         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
455         named its executable TestWebKitAPI.bundle.
456         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
458         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
459         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
460         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
461         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
462         bundle parameter and asked for an initial notification.
463         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
464         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
465         mirror its value in the main frame's JSContext.
466         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
467         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
468         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
469         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
470         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
471         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
472         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
473         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
474         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
475         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
476
477 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
478
479         URTBF after r188828.
480
481         * WebKitTestRunner/PlatformWebView.h:
482
483 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
484
485         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
486         https://bugs.webkit.org/show_bug.cgi?id=148356
487
488         Reviewed by Darin Adler.
489
490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
491         (BuildbotCombinedQueueView.prototype.update):
492
493 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
494
495         build.webkit.org/dashboard: Respect step's hidden flag
496         https://bugs.webkit.org/show_bug.cgi?id=148357
497
498         Reviewed by Darin Adler.
499
500         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
501         (BuildbotIteration.prototype._parseData):
502
503 2015-08-23  Nan Wang  <n_wang@apple.com>
504
505         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
506         https://bugs.webkit.org/show_bug.cgi?id=148328
507
508         Reviewed by Darin Adler.
509
510         We should only expose stringValue() when value attribute is set.
511
512         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
513         (AccessibilityUIElement::stringValue):
514         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
515         (WTR::AccessibilityUIElement::stringValue):
516
517 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
518
519         Remove style checking rule regarding OwnPtr and PassOwnPtr
520         https://bugs.webkit.org/show_bug.cgi?id=148360
521
522         Reviewed by Darin Adler.
523
524         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
525         Removed it.
526
527         * Scripts/do-webcore-rename:
528         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
529         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
530         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
531         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
532         (WebKitStyleTest.test_names): Deleted.
533
534 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
535
536         WebKitTestRunner should use WKWebView on OS X and iOS
537         https://bugs.webkit.org/show_bug.cgi?id=143743
538         <rdar://problem/16947123>
539
540         Reviewed by Anders Carlsson.
541         Patch by Enrica Casucci and myself.
542
543         * WebKitTestRunner/PlatformWebView.h:
544         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
545         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
546         instead of WKContext and WKPageGroup.
547
548         Remove the unused, always-true windowSnapshotEnabled().
549         While technically some platforms don't have window snapshotting,
550         they just return null instead of implementing windowSnapshotEnabled().
551
552         * WebKitTestRunner/TestController.h:
553         * WebKitTestRunner/TestController.cpp:
554         (WTR::TestController::createOtherPage):
555         (WTR::TestController::initialize):
556         (WTR::TestController::createWebViewWithOptions):
557         Delegate to the various platforms for creating PlatformWebView instances,
558         for creating WKContexts, and for accessing WKPreferences,
559         so that they can do special things (like, use WKWebView instead!).
560
561         (WTR::TestController::resetPreferencesToConsistentValues):
562         Make explicit WebKitTestRunner's desired default for two preferences
563         which have differing defaults between the antique and modern API,
564         for consistency's sake.
565
566         (WTR::TestController::resetStateToConsistentValues):
567         Add platformResetStateToConsistentValues.
568
569         * WebKitTestRunner/TestInvocation.cpp:
570         (WTR::TestInvocation::dumpResults):
571         Adjust to the aforementioned removal of windowSnapshotEnabled().
572
573         * WebKitTestRunner/ios/TestControllerCocoa.mm:
574         (WTR::TestController::platformResetStateToConsistentValues):
575         (WTR::TestController::platformPreferences):
576         (WTR::TestController::platformCreateWebView):
577         (WTR::TestController::platformCreateOtherPage):
578         (WTR::TestController::platformInitializeConfiguration):
579         Implement the new platform functions for the Modern WebKit2 API,
580         in a new TestControllerCocoa file that is shared between iOS and Mac.
581         
582         For platformMaybeCreateContext, use the trick that we know we can cast
583         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
584         WKWebView's configuration.
585
586         Ditto for WKPreferencesRef and WKPreferences.
587
588         Remove user content filters on the WKWebView's userContentController.
589
590         * WebKitTestRunner/mac/TestControllerMac.mm:
591         * WebKitTestRunner/ios/TestControllerIOS.mm:
592         Move code into TestControllerCocoa.
593
594         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
595         (WTR::InjectedBundle::beginTesting):
596         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
597         (WTR::TestRunner::addUserScript):
598         (WTR::TestRunner::addUserStyleSheet):
599         Adopt WKBundlePage API for user scripts/sheets.
600
601         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
602         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
603         Make and keep a WKWebView instead of a WKView.
604         
605         * WebKitTestRunner/mac/EventSenderProxy.mm:
606         (WTR::EventSenderProxy::mouseUp):
607         (WTR::EventSenderProxy::mouseMoveTo):
608         Reach inside the WKWebView to the WKView when dispatching events.
609         This is fairly ugly and we should come up with a better solution.
610         Also, fix some flipping and style errors.
611
612 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
613
614         Unreviewed, attempt to fix GTK build after r188718
615
616         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
617         (WTR::PlatformWebView::PlatformWebView):
618
619 2015-08-21  Commit Queue  <commit-queue@webkit.org>
620
621         Unreviewed, rolling out r188807, r188813, and r188815.
622         https://bugs.webkit.org/show_bug.cgi?id=148349
623
624         lots of 32-bit build problems, better to resolve separately
625         and try again (Requested by thorton on #webkit).
626
627         Reverted changesets:
628
629         "WebKitTestRunner should use WKWebView on OS X and iOS"
630         https://bugs.webkit.org/show_bug.cgi?id=143743
631         http://trac.webkit.org/changeset/188807
632
633         "Stop building WebKitTestRunner for 32-bit platforms"
634         https://bugs.webkit.org/show_bug.cgi?id=143743
635         http://trac.webkit.org/changeset/188813
636
637         "Stop building WebKitTestRunner for 32-bit platforms"
638         https://bugs.webkit.org/show_bug.cgi?id=143743
639         http://trac.webkit.org/changeset/188815
640
641 2015-08-21  Tim Horton  <timothy_horton@apple.com>
642
643         Stop building WebKitTestRunner for 32-bit platforms
644         https://bugs.webkit.org/show_bug.cgi?id=143743
645         <rdar://problem/16947123>
646
647         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
648         This is a restriction on the valid set, not the desired set.
649
650 2015-08-21  Jason Marcell  <jmarcell@apple.com>
651
652         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
653         to work with these new objects.
654         https://bugs.webkit.org/show_bug.cgi?id=148188
655
656         Reviewed by Daniel Bates.
657
658         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
659         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
660         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
661         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
662         (repository, "branch name")-pair.
663         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
665         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
667         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
668         objects which represent a (repository, "branch name")-pair.
669         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
670         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
671         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
672         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
673         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
674         BuildbotQueue.branch to BuildbotQueue.branches.
675         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
676         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
677
678 2015-08-21  Tim Horton  <timothy_horton@apple.com>
679
680         Stop building WebKitTestRunner for 32-bit platforms
681         https://bugs.webkit.org/show_bug.cgi?id=143743
682         <rdar://problem/16947123>
683
684         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
685         WKWebView is not available on 32-bit OS X.
686
687 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
688
689         [Win] Unreviewed test correction after r188709.
690
691         I removed a function argument that happened to be mirrored by a global
692         value with the same name. This prevented a compile error, but testing
693         showed that the wrong value was being used in the function.
694
695         * DumpRenderTree/win/FrameLoadDelegate.cpp:
696         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
697         back
698
699 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
700
701         WebKitTestRunner should use WKWebView on OS X and iOS
702         https://bugs.webkit.org/show_bug.cgi?id=143743
703         <rdar://problem/16947123>
704
705         Reviewed by Anders Carlsson.
706         Patch by Enrica Casucci and myself.
707
708         * WebKitTestRunner/PlatformWebView.h:
709         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
710         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
711         instead of WKContext and WKPageGroup.
712
713         Remove the unused, always-true windowSnapshotEnabled().
714         While technically some platforms don't have window snapshotting,
715         they just return null instead of implementing windowSnapshotEnabled().
716
717         * WebKitTestRunner/TestController.h:
718         * WebKitTestRunner/TestController.cpp:
719         (WTR::TestController::createOtherPage):
720         (WTR::TestController::initialize):
721         (WTR::TestController::createWebViewWithOptions):
722         Delegate to the various platforms for creating PlatformWebView instances,
723         for creating WKContexts, and for accessing WKPreferences,
724         so that they can do special things (like, use WKWebView instead!).
725
726         (WTR::TestController::resetPreferencesToConsistentValues):
727         Make explicit WebKitTestRunner's desired default for two preferences
728         which have differing defaults between the antique and modern API,
729         for consistency's sake.
730
731         (WTR::TestController::resetStateToConsistentValues):
732         Add platformResetStateToConsistentValues.
733
734         * WebKitTestRunner/TestInvocation.cpp:
735         (WTR::TestInvocation::dumpResults):
736         Adjust to the aforementioned removal of windowSnapshotEnabled().
737
738         * WebKitTestRunner/ios/TestControllerCocoa.mm:
739         (WTR::TestController::platformResetStateToConsistentValues):
740         (WTR::TestController::platformPreferences):
741         (WTR::TestController::platformCreateWebView):
742         (WTR::TestController::platformCreateOtherPage):
743         (WTR::TestController::platformInitializeConfiguration):
744         Implement the new platform functions for the Modern WebKit2 API,
745         in a new TestControllerCocoa file that is shared between iOS and Mac.
746         
747         For platformMaybeCreateContext, use the trick that we know we can cast
748         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
749         WKWebView's configuration.
750
751         Ditto for WKPreferencesRef and WKPreferences.
752
753         Remove user content filters on the WKWebView's userContentController.
754
755         * WebKitTestRunner/mac/TestControllerMac.mm:
756         * WebKitTestRunner/ios/TestControllerIOS.mm:
757         Move code into TestControllerCocoa.
758
759         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
760         (WTR::InjectedBundle::beginTesting):
761         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
762         (WTR::TestRunner::addUserScript):
763         (WTR::TestRunner::addUserStyleSheet):
764         Adopt WKBundlePage API for user scripts/sheets.
765
766         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
767         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
768         Make and keep a WKWebView instead of a WKView.
769         
770         * WebKitTestRunner/mac/EventSenderProxy.mm:
771         (WTR::EventSenderProxy::mouseUp):
772         (WTR::EventSenderProxy::mouseMoveTo):
773         Reach inside the WKWebView to the WKView when dispatching events.
774         This is fairly ugly and we should come up with a better solution.
775         Also, fix some flipping and style errors.
776
777 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
778
779         Improve how UI events are dispatched by WebKitTestRunner
780         https://bugs.webkit.org/show_bug.cgi?id=148326
781
782         Reviewed by Anders Carlsson.
783
784         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
785         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
786         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
787         asynchronous (and really, it has always been for the most part).
788
789         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
790         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
791         (WTR::EventSendingController::mouseUp): Ditto.
792         (WTR::EventSendingController::mouseMoveTo): Ditto.
793         (WTR::EventSendingController::mouseForceDown): Ditto.
794         (WTR::EventSendingController::mouseForceUp): Ditto.
795         (WTR::EventSendingController::mouseForceChanged): Ditto.
796         (WTR::EventSendingController::leapForward): Ditto.
797         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
798         (WTR::EventSendingController::keyDown): Ditto.
799         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
800         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
801         to be done in custom WebKit2 code for test wheel event handling.
802         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
803         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
804         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
805         (WTR::EventSendingController::addTouchPoint): Ditto.
806         (WTR::EventSendingController::updateTouchPoint): Ditto.
807         (WTR::EventSendingController::setTouchModifier): Ditto.
808         (WTR::EventSendingController::setTouchPointRadius): Ditto.
809         (WTR::EventSendingController::touchStart): Ditto.
810         (WTR::EventSendingController::touchMove): Ditto.
811         (WTR::EventSendingController::touchEnd): Ditto.
812         (WTR::EventSendingController::touchCancel): Ditto.
813         (WTR::EventSendingController::clearTouchPoints): Ditto.
814         (WTR::EventSendingController::releaseTouchPoint): Ditto.
815         (WTR::EventSendingController::cancelTouchPoint): Ditto.
816
817         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
818         (WTR::InjectedBundle::postSetWindowIsKey):
819         (WTR::InjectedBundle::postSimulateWebNotificationClick):
820         (WTR::InjectedBundle::isGeolocationProviderActive):
821         (WTR::InjectedBundle::shouldProcessWorkQueue):
822         Updated for WKBundlePagePostSynchronousMessage renaming.
823
824         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
825         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
826
827         * WebKitTestRunner/TestController.cpp:
828         (WTR::TestController::initialize): Allow handling the new test style messages.
829         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
830         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
831         (WTR::TestController::didReceiveMessageFromInjectedBundle):
832         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
833         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
834
835         * WebKitTestRunner/mac/EventSenderProxy.mm:
836         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
837         (WTR::EventSenderProxy::keyDown): Ditto.
838         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
839         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
840
841 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
842
843         Skip no-llint tests that fail due to running out of executable memory after r188969
844         https://bugs.webkit.org/show_bug.cgi?id=148273
845
846         Reviewed by Michael Saboff.
847
848         * Scripts/run-jsc-stress-tests:
849
850 2015-08-21  Nan Wang  <n_wang@apple.com>
851
852         [Mac] accessibility/selection-states.html fails
853         https://bugs.webkit.org/show_bug.cgi?id=116637
854
855         Reviewed by Chris Fleizach.
856
857         Implemented isSelectable() and isMultiSelectable().
858
859         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
860         (AccessibilityUIElement::isSelectable):
861         (AccessibilityUIElement::isMultiSelectable):
862         (AccessibilityUIElement::isSelectedOptionActive):
863         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
864         (WTR::AccessibilityUIElement::isSelectable):
865         (WTR::AccessibilityUIElement::isMultiSelectable):
866         (WTR::AccessibilityUIElement::isVisible):
867
868 2015-08-21  Jason Marcell  <jmarcell@apple.com>
869
870         Fix iteration over repositories on bot watcher's dashboard.
871
872         Reviewed by Alexey Proskuryakov.
873
874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
875         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
876
877 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
878
879         [EFL] Revise PlatformWebView ctor according to r188718
880         https://bugs.webkit.org/show_bug.cgi?id=148282
881
882         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
883         instead of WKContextRef and WKPageGroupRef respectively.
884
885         Reviewed by Gyuyoung Kim.
886
887         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
888         (WTR::PlatformWebView::PlatformWebView):
889
890 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
891
892         Unreviewed, changed Devin Rousso's email.
893
894         * Scripts/webkitpy/common/config/contributors.json:
895
896 2015-08-20  Anders Carlsson  <andersca@apple.com>
897
898         Use WKPageConfigurationRef in WebKitTestRunner
899         https://bugs.webkit.org/show_bug.cgi?id=147996
900
901         Reviewed by Tim Horton.
902
903         * WebKitTestRunner/TestController.cpp:
904         (WTR::TestController::createOtherPage):
905         (WTR::TestController::initialize):
906         (WTR::TestController::createWebViewWithOptions):
907         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
908         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
909         (WTR::PlatformWebView::PlatformWebView):
910         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
911
912 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
913
914         [Win] Update Windows tools for revised MIDL interfaces
915         https://bugs.webkit.org/show_bug.cgi?id=148249
916
917         Reviewed by Dean Jackson.
918
919         This is a follow-up to Bug 148001.
920
921         Revise the testing software to use compatible signatures and
922         implementations to match the requirements of the IDL generated
923         with the SAL annotations.
924
925         * DumpRenderTree/win/DRTDataObject.cpp:
926         * DumpRenderTree/win/DRTDataObject.h:
927         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
928         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
929         * DumpRenderTree/win/DRTDropSource.cpp:
930         * DumpRenderTree/win/DRTDropSource.h:
931         * DumpRenderTree/win/DumpRenderTree.cpp:
932         * DumpRenderTree/win/EditingDelegate.cpp:
933         * DumpRenderTree/win/EditingDelegate.h:
934         * DumpRenderTree/win/FrameLoadDelegate.cpp:
935         * DumpRenderTree/win/FrameLoadDelegate.h:
936         * DumpRenderTree/win/HistoryDelegate.cpp:
937         * DumpRenderTree/win/HistoryDelegate.h:
938         * DumpRenderTree/win/PolicyDelegate.cpp:
939         * DumpRenderTree/win/PolicyDelegate.h:
940         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
941         * DumpRenderTree/win/ResourceLoadDelegate.h:
942         * DumpRenderTree/win/TestRunnerWin.cpp:
943         * DumpRenderTree/win/UIDelegate.cpp:
944         * DumpRenderTree/win/UIDelegate.h:
945         * WinLauncher/AccessibilityDelegate.cpp:
946         * WinLauncher/AccessibilityDelegate.h:
947         * WinLauncher/Common.cpp:
948         * WinLauncher/DOMDefaultImpl.cpp:
949         * WinLauncher/DOMDefaultImpl.h:
950         * WinLauncher/PageLoadTestClient.cpp:
951         * WinLauncher/PageLoadTestClient.h:
952         * WinLauncher/PrintWebUIDelegate.cpp:
953         * WinLauncher/PrintWebUIDelegate.h:
954         * WinLauncher/ResourceLoadDelegate.cpp:
955         * WinLauncher/ResourceLoadDelegate.h:
956         * WinLauncher/WebDownloadDelegate.cpp:
957         * WinLauncher/WebDownloadDelegate.h:
958         * WinLauncher/WinLauncherWebHost.cpp:
959         * WinLauncher/WinLauncherWebHost.h:
960         * WinLauncher/WinMain.cpp:
961         * win/DLLLauncher/DLLLauncherMain.cpp:
962
963 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
964
965         Unreviewed, shorten a test that runs too long and times out.
966
967         * TestWebKitAPI/Tests/WTF/Lock.cpp:
968         (TestWebKitAPI::TEST):
969
970 2015-08-20  Alex Christensen  <achristensen@webkit.org>
971
972         Clean up CMake build after r188673
973         https://bugs.webkit.org/show_bug.cgi?id=148234
974
975         Reviewed by Tim Horton.
976
977         * DumpRenderTree/PlatformWin.cmake:
978         * TestWebKitAPI/CMakeLists.txt:
979         * TestWebKitAPI/PlatformWin.cmake:
980         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
981         gtest needs to be a static library on Windows to not crash.
982
983 2015-08-19  Alex Christensen  <achristensen@webkit.org>
984
985         CMake Windows build should not include files directly from other Source directories
986         https://bugs.webkit.org/show_bug.cgi?id=148198
987
988         Reviewed by Brent Fulgham.
989
990         * DumpRenderTree/DumpRenderTreePrefix.h:
991         Include cmakeconfig.h to properly define all enabled features.
992         * DumpRenderTree/PlatformWin.cmake:
993         * TestWebKitAPI/PlatformWin.cmake:
994
995 2015-08-19  Alex Christensen  <achristensen@webkit.org>
996
997         Build TestWTF on Mac with CMake.
998         https://bugs.webkit.org/show_bug.cgi?id=147972
999
1000         Reviewed by Tim Horton.
1001
1002         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
1003         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
1004
1005         * TestWebKitAPI/CMakeLists.txt:
1006         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
1007         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
1008         * TestWebKitAPI/PlatformMac.cmake: Added.
1009         * TestWebKitAPI/config.h:
1010         Postpone some build fixes until WebKit builds completely on Mac with CMake.
1011
1012 2015-08-19  Brian Burg  <bburg@apple.com>
1013
1014         Unreviewed, add Aleksandr Skachkov to the list of contributors.
1015
1016         * Scripts/webkitpy/common/config/contributors.json:
1017
1018 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1019
1020         REGRESSION(r188548): [GTK] Build broken.
1021         https://bugs.webkit.org/show_bug.cgi?id=148154
1022
1023         Reviewed by Martin Robinson.
1024
1025         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1026         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1027         Even if we don't need to add/override any settings in ViewOptions,
1028         we need to define this as an empty function to make it build.
1029
1030 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1031
1032         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
1033         https://bugs.webkit.org/show_bug.cgi?id=148073
1034
1035         Reviewed by Alexey Proskuryakov.
1036
1037         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
1038         (TestWebKitAPI::TEST):
1039
1040 2015-08-18  Anders Carlsson  <andersca@apple.com>
1041
1042         Fix test failure fallout from r188602 by using a V5 page ui client struct.
1043
1044         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1045         (TestWebKitAPI::setUpClients):
1046
1047 2015-08-18  Brian Burg  <bburg@apple.com>
1048
1049         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1050         https://bugs.webkit.org/show_bug.cgi?id=147955
1051
1052         Reviewed by Timothy Hatcher.
1053
1054         To enable sharing of common test code between protocol and model tests,
1055         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1056
1057         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1058         protocol-test.js uses to load the inspector frontend stub into its iframe
1059         from an arbitrary local file URL.
1060
1061         * DumpRenderTree/TestRunner.cpp:
1062         (getInspectorTestStubURLCallback):
1063         (TestRunner::staticValues):
1064         * DumpRenderTree/TestRunner.h:
1065         * DumpRenderTree/mac/TestRunnerMac.mm:
1066         (SOFT_LINK_STAGED_FRAMEWORK):
1067         (TestRunner::inspectorTestStubURL):
1068         * DumpRenderTree/win/TestRunnerWin.cpp:
1069         (TestRunner::inspectorTestStubURL):
1070         * WebKitTestRunner/Configurations/Base.xcconfig:
1071         Since WebKitTestRunner now includes WebCore private headers, also search
1072         for the WebCore framework inside the WebKit umbrella framework.
1073
1074         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1075         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1076         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1077         (WTR::TestRunner::inspectorTestStubURL):
1078         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1079         (WTR::TestRunner::inspectorTestStubURL):
1080         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1081         (WTR::TestRunner::inspectorTestStubURL):
1082
1083 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
1084
1085         Unreviewed, fix GTK build.
1086
1087         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1088         (TestWebKitAPI::TEST):
1089
1090 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
1091
1092         Replace all remaining uses of WTF::Mutex with WTF::Lock
1093         https://bugs.webkit.org/show_bug.cgi?id=148089
1094
1095         Reviewed by Geoffrey Garen.
1096
1097         * DumpRenderTree/JavaScriptThreading.cpp:
1098         (javaScriptThreadsMutex):
1099         (runJavaScriptThread):
1100         (startJavaScriptThreads):
1101         (stopJavaScriptThreads):
1102         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
1103         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1104         (TestWebKitAPI::TEST):
1105         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1106         (TestWebKitAPI::TEST):
1107
1108 2015-08-17  Commit Queue  <commit-queue@webkit.org>
1109
1110         Unreviewed, rolling out r188539, r188544, r188552, and
1111         r188564.
1112         https://bugs.webkit.org/show_bug.cgi?id=148122
1113
1114         Broke tests and some build styles (Requested by ap on
1115         #webkit).
1116
1117         Reverted changesets:
1118
1119         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
1120         bundle"
1121         https://bugs.webkit.org/show_bug.cgi?id=147955
1122         http://trac.webkit.org/changeset/188539
1123
1124         "Web Inspector: split TestStub.js into multiple files and
1125         modernize it"
1126         https://bugs.webkit.org/show_bug.cgi?id=148077
1127         http://trac.webkit.org/changeset/188544
1128
1129         "Web Inspector: InspectorTest should be a subclass of
1130         TestHarness"
1131         https://bugs.webkit.org/show_bug.cgi?id=148079
1132         http://trac.webkit.org/changeset/188552
1133
1134         "Unreviewed internal build fix attempt after r188539."
1135         http://trac.webkit.org/changeset/188564
1136
1137 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1138
1139         [OS X] Remove support for composite fonts
1140         https://bugs.webkit.org/show_bug.cgi?id=147920
1141
1142         Reviewed by Dan Bernstein.
1143
1144         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1145         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
1146         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1147         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1148         * DumpRenderTree/mac/DumpRenderTree.mm:
1149         (allowedFontFamilySet): Deleted.
1150         (activateTestingFonts): Deleted.
1151         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1152         (WTR::allowedFontFamilySet): Deleted.
1153         (WTR::activateFonts): Deleted.
1154         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1155         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
1156         * WebKitTestRunner/mac/TestControllerMac.mm:
1157         (WTR::allowedFontFamilySet): Deleted.
1158
1159 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
1160
1161         Unreviewed internal build fix attempt after r188539.
1162
1163         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1164
1165 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1166
1167         Fix the build
1168
1169         Unreviewed.
1170
1171         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1172
1173 2015-08-17  Alex Christensen  <achristensen@webkit.org>
1174
1175         Build Debug Suffix on Windows with CMake
1176         https://bugs.webkit.org/show_bug.cgi?id=148083
1177
1178         Reviewed by Brent Fulgham.
1179
1180         * TestWebKitAPI/CMakeLists.txt:
1181         * TestWebKitAPI/PlatformWin.cmake:
1182         Add DEBUG_SUFFIX
1183
1184 2015-08-17  Anders Carlsson  <andersca@apple.com>
1185
1186         Simplify how PlatformWebViews are created when view options change
1187         https://bugs.webkit.org/show_bug.cgi?id=148093
1188
1189         Reviewed by Sam Weinig.
1190
1191         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
1192
1193         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
1194         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
1195         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
1196
1197         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
1198
1199         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
1200         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
1201
1202         * WebKitTestRunner/TestController.cpp:
1203         (WTR::TestController::ensureViewSupportsOptionsForTest):
1204         (WTR::shouldUseFixedLayout):
1205         (WTR::TestController::viewOptionsForTest):
1206         (WTR::TestController::updateWebViewSizeForTest):
1207         (WTR::TestController::updateWindowScaleForTest):
1208         (WTR::TestController::configureViewForTest):
1209         (WTR::TestController::initialize): Deleted.
1210         (WTR::TestController::ensureViewSupportsOptions): Deleted.
1211         (WTR::TestController::updateLayoutTypeForTest): Deleted.
1212         (WTR::TestController::platformConfigureViewForTest): Deleted.
1213         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
1214         (WTR::TestController::run): Deleted.
1215         * WebKitTestRunner/TestController.h:
1216         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1217         (WTR::shouldUseFixedLayout):
1218         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1219         (WTR::TestController::platformConfigureViewForTest):
1220         (WTR::TestController::platformResetPreferencesToConsistentValues):
1221         * WebKitTestRunner/ios/TestControllerIOS.mm:
1222         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1223         * WebKitTestRunner/mac/TestControllerMac.mm:
1224         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1225         (WTR::TestController::platformConfigureViewForTest):
1226
1227 2015-08-17  Sam Weinig  <sam@webkit.org>
1228
1229         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
1230         https://bugs.webkit.org/show_bug.cgi?id=148097
1231
1232         Reviewed by Anders Carlsson.
1233
1234         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
1235         Add tests for WebsiteDataStores in the WKPageConfiguration.
1236
1237 2015-08-17  Brian Burg  <bburg@apple.com>
1238
1239         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1240         https://bugs.webkit.org/show_bug.cgi?id=147955
1241
1242         Reviewed by Timothy Hatcher.
1243
1244         To enable sharing of common test code between protocol and model tests,
1245         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1246
1247         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1248         protocol-test.js uses to load the inspector frontend stub into its iframe
1249         from an arbitrary local file URL.
1250
1251         * DumpRenderTree/TestRunner.cpp:
1252         (getInspectorTestStubURLCallback):
1253         (TestRunner::staticValues):
1254         * DumpRenderTree/TestRunner.h:
1255         * DumpRenderTree/mac/TestRunnerMac.mm:
1256         (SOFT_LINK_STAGED_FRAMEWORK):
1257         (TestRunner::inspectorTestStubURL):
1258         * DumpRenderTree/win/TestRunnerWin.cpp:
1259         (TestRunner::inspectorTestStubURL):
1260         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1261         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1262         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1263         (WTR::TestRunner::inspectorTestStubURL):
1264         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1265         (WTR::TestRunner::inspectorTestStubURL):
1266         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1267         (WTR::TestRunner::inspectorTestStubURL):
1268
1269 2015-08-17  Saam barati  <sbarati@apple.com>
1270
1271         Change email address from saambarati1@gmail.com to sbarati@apple.com
1272
1273         * Scripts/webkitpy/common/config/contributors.json:
1274
1275 2015-08-17  Jason Marcell  <jmarcell@apple.com>
1276
1277         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
1278         repositories other than "openSource" and "internal".
1279         https://bugs.webkit.org/show_bug.cgi?id=147961
1280
1281         Reviewed by Daniel Bates.
1282
1283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1284         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
1285         generically with repositories other than "openSource" and "internal".
1286
1287 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
1288
1289         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
1290         https://bugs.webkit.org/show_bug.cgi?id=148081
1291
1292         Reviewed by Tim Horton.
1293
1294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1295         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1296
1297 2015-08-11  Andy Estes  <aestes@apple.com>
1298
1299         [Cocoa] Add redirect support to CustomProtocolManager
1300         https://bugs.webkit.org/show_bug.cgi?id=147871
1301
1302         Reviewed by Dan Bernstein.
1303
1304         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
1305
1306         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1307         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
1308         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
1309         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1310         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
1311         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
1312         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
1313         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
1314         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
1315         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1316         (TestWebKitAPI::TEST): Unregistered TestProtocol.
1317         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
1318         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
1319         (-[TestProtocol startLoading]): Taught to handle redirect responses.
1320
1321 2015-08-13  Andy Estes  <aestes@apple.com>
1322
1323         [Cocoa] Downloads do not start if policy decision is made asynchronously
1324         https://bugs.webkit.org/show_bug.cgi?id=147985
1325
1326         Reviewed by Brady Eidson.
1327
1328         Added a new API test.
1329
1330         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1331         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1332         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
1333         (TEST):
1334
1335 2015-08-14  Commit Queue  <commit-queue@webkit.org>
1336
1337         Unreviewed, rolling out r187357.
1338         https://bugs.webkit.org/show_bug.cgi?id=148032
1339
1340         webkit-patch generates incorrect patches that cannot be
1341         applied (Requested by dydz on #webkit).
1342
1343         Reverted changeset:
1344
1345         "Call fixChangeLogPatch when generating patches from webkit-
1346         patch"
1347         https://bugs.webkit.org/show_bug.cgi?id=147248
1348         http://trac.webkit.org/changeset/187357
1349
1350 2015-08-14  Jason Marcell  <jmarcell@apple.com>
1351
1352         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
1353         other than "openSource" and "internal".
1354         https://bugs.webkit.org/show_bug.cgi?id=147938
1355
1356         Reviewed by Daniel Bates.
1357
1358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1359         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
1360         repositories other than "openSource" and "internal".
1361
1362 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
1363
1364         Unreviewed, shorten another test that is timing out.
1365
1366         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1367         (TestWebKitAPI::TEST):
1368
1369 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
1370
1371         AppScale: Assertion hit when hovering a webkit-queue bubble
1372         https://bugs.webkit.org/show_bug.cgi?id=147997
1373
1374         Reviewed by Alexey Proskuryakov.
1375
1376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1377         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
1378
1379 2015-08-13  Lucas Forschler  <lforschler@apple.com>
1380
1381         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
1382         
1383         Unreviewed.
1384         
1385         * Scripts/copy-webkitlibraries-to-product-directory:
1386
1387 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
1388
1389         Run benchmark customized Dromaeo should not assume there is an internet connection.
1390         https://bugs.webkit.org/show_bug.cgi?id=147995
1391
1392         Reviewed by Ryosuke Niwa.
1393
1394         Add several dependency js libs to local.
1395
1396         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
1397
1398 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1399
1400         WTF should have a compact Condition object to use with Lock
1401         https://bugs.webkit.org/show_bug.cgi?id=147986
1402
1403         Reviewed by Geoffrey Garen.
1404
1405         Add a test for WTF::Condition.
1406
1407         * TestWebKitAPI/CMakeLists.txt:
1408         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1409         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1410         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
1411         (TestWebKitAPI::TEST):
1412         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1413         (TestWebKitAPI::runLockTest): Change the name of the thread.
1414
1415 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1416
1417         Unreviewed, shorten another test. It's timing out in debug on some bot.
1418
1419         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1420         (TestWebKitAPI::TEST):
1421
1422 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
1423
1424         WTF::Lock should not suffer from the thundering herd
1425         https://bugs.webkit.org/show_bug.cgi?id=147947
1426
1427         Reviewed by Geoffrey Garen.
1428
1429         Add testing that checks that locks return to a pristine state after contention is over.
1430
1431         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1432         (TestWebKitAPI::LockInspector::isFullyReset):
1433         (TestWebKitAPI::runLockTest):
1434         (TestWebKitAPI::TEST):
1435
1436 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
1437
1438         Benchmarks supported by run_benchmark script should not assume we have internet access.
1439         https://bugs.webkit.org/show_bug.cgi?id=147959
1440
1441         Reviewed by Ryosuke Niwa.
1442
1443         For JSBench we should not request jquery.min.js from google through the internet.
1444
1445         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
1446
1447 2015-08-12  Jason Marcell  <jmarcell@apple.com>
1448
1449         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
1450         other than "openSource" and "internal".
1451         https://bugs.webkit.org/show_bug.cgi?id=147796
1452
1453         Reviewed by Daniel Bates.
1454
1455         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1456         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
1457         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
1458         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
1459         and another assertion that, if the previousIteration is non-null, the given repository is in
1460         previousIteration.revision.
1461         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
1462         with repositories other than "openSource" and "internal". Also added an assertion that the returned
1463         fragment has at least one child node.
1464
1465 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
1466
1467         Add a tool that dumps class and struct member layout, showing padding
1468         https://bugs.webkit.org/show_bug.cgi?id=147898
1469
1470         Reviewed by Zalan Bujtas.
1471         
1472         This 'dump-class-layout' script uses the lldb Python bindings to collect data
1473         about data member layout, and displays it.
1474         
1475         Sample output:
1476
1477               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
1478               +0 < 56>     WebCore::URL m_value;
1479               +0 <  8>         WTF::String m_string;
1480               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
1481               +0 <  8>                 WTF::StringImpl * m_ptr;
1482               +8 <  1>         bool:1 m_isValid;
1483               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
1484               +9 <  3>         <PADDING>
1485              +12 <  4>         int m_schemeEnd;
1486              +16 <  4>         int m_userStart;
1487              +20 <  4>         int m_userEnd;
1488              +24 <  4>         int m_passwordEnd;
1489              +28 <  4>         int m_hostEnd;
1490              +32 <  4>         int m_portEnd;
1491              +36 <  4>         int m_pathAfterLastSlash;
1492              +40 <  4>         int m_pathEnd;
1493              +44 <  4>         int m_queryEnd;
1494              +48 <  4>         int m_fragmentEnd;
1495              +52 <  4>         <PADDING>
1496              +52 <  4>     <PADDING>
1497              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
1498              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
1499             Total byte size: 72
1500             Total pad bytes: 11
1501             Padding percentage: 15.28 %
1502
1503         * Scripts/dump-class-layout: Added.
1504         (webkit_build_dir):
1505         (developer_dir):
1506         (import_lldb):
1507         (find_build_directory):
1508         (verify_type):
1509         (verify_type_recursive):
1510         (dump_class):
1511         (main):
1512         (main.or):
1513
1514 2015-08-12  Alex Christensen  <achristensen@webkit.org>
1515
1516         Fix Debug CMake builds on Windows
1517         https://bugs.webkit.org/show_bug.cgi?id=147940
1518
1519         Reviewed by Chris Dumez.
1520
1521         * DumpRenderTree/PlatformWin.cmake:
1522         * TestWebKitAPI/PlatformWin.cmake:
1523         The BitmapImage test is not enabled on the AppleWin port.
1524         * WinLauncher/CMakeLists.txt:
1525         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
1526
1527 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1528
1529         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
1530
1531         In r188125 I added a way to mark tests as slow to use a longer
1532         timeout. But it seems it was not enough for
1533         WTF_Lock.ContendedShortSection, so let's try again with a longer
1534         timeout now.
1535
1536         * Scripts/run-gtk-tests:
1537         (TestRunner._run_google_test):
1538
1539 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1540
1541         Allow --debug option in run-jsc
1542         https://bugs.webkit.org/show_bug.cgi?id=147923
1543
1544         Reviewed by Csaba Osztrogonác.
1545
1546         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
1547
1548         * Scripts/run-jsc:
1549
1550 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1551
1552         Fix test after build fix in r188286.
1553         https://bugs.webkit.org/show_bug.cgi?id=147907
1554
1555         Reviewed by Anders Carlsson.
1556
1557         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1558         sleep_for can now be used, but we need to include <thread>
1559
1560 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1561
1562         Always use a byte-sized lock implementation
1563         https://bugs.webkit.org/show_bug.cgi?id=147908
1564
1565         Reviewed by Geoffrey Garen.
1566
1567         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
1568         now tests of Lock.
1569
1570         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1571         (TestWebKitAPI::runLockTest):
1572         (TestWebKitAPI::TEST):
1573
1574 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
1575
1576         Make ASan build not depend on asan.xcconfig
1577         https://bugs.webkit.org/show_bug.cgi?id=147840
1578         rdar://problem/21093702
1579
1580         Reviewed by Daniel Bates.
1581
1582         * asan/asan.xcconfig:
1583         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
1584         are now marked in source code.
1585
1586 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1587
1588         Unreviewed, shorten another test since it timed out.
1589
1590         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1591         (TestWebKitAPI::TEST):
1592
1593 2015-08-11  Mark Lam  <mark.lam@apple.com>
1594
1595         Fix names of Lock tests: should be "Contended", not "Contented".
1596         https://bugs.webkit.org/show_bug.cgi?id=147905
1597
1598         Reviewed by Saam Barati.
1599
1600         We're testing the behavior of lock contention (i.e. when threads contend), not
1601         whether the locks are happy (contented).
1602
1603         * Scripts/run-gtk-tests:
1604         (TestRunner):
1605         (TestRunner.__init__): Deleted.
1606         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1607         (TestWebKitAPI::runLockTest):
1608         (TestWebKitAPI::TEST):
1609
1610 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1611
1612         Update WinCairoRequirements to VS2015.
1613
1614         * Scripts/update-webkit-wincairo-libs:
1615         Update WinCairoRequirements location.
1616
1617 2015-08-11  Jason Marcell  <jmarcell@apple.com>
1618
1619         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
1620         for internalTrac.
1621         https://bugs.webkit.org/show_bug.cgi?id=147805
1622
1623         Reviewed by Daniel Bates.
1624
1625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1626         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
1627         Dashboard.Repository.Internal.trac for internalTrac.
1628         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
1629         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
1630         respectively.
1631         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
1632         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
1633         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
1634         internalTrac.
1635         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
1636         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
1637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1638         (Analyzer): Ditto.
1639         (Analyzer.prototype.analyze): Ditto.
1640
1641 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1642
1643         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
1644
1645         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1646         (TestWebKitAPI::TEST):
1647
1648 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
1649
1650         [Win] Switch Windows build to Visual Studio 2015
1651         https://bugs.webkit.org/show_bug.cgi?id=147887
1652         <rdar://problem/22235098>
1653
1654         Reviewed by Alex Christensen.
1655
1656         Update Visual Studio project file settings to use the current Visual
1657         Studio and compiler. Continue targeting binaries to run on our minimum
1658         supported configuration of Windows 7.
1659
1660         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1661         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1662         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1663         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1664         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1665         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
1666         prefer the newer MSBuild included in Visual Studio 2015.
1667         (visualStudioInstallDir):
1668         (msBuildInstallDir):
1669         (visualStudioVersion):
1670         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1671         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1672         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1673         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1674         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1675         * win/record-memory/record-memory.vcxproj:
1676
1677 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1678
1679         Another speculative build fix after r188280.
1680
1681         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1682         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
1683         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
1684
1685 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1686
1687         Unreviewed build fix after r188280.
1688
1689         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1690         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
1691
1692 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
1693
1694         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
1695         https://bugs.webkit.org/show_bug.cgi?id=147665
1696
1697         Reviewed by Mark Lam.
1698
1699         * TestWebKitAPI/CMakeLists.txt:
1700         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1701         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1702         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1703         (TestWebKitAPI::TEST):
1704         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
1705         (TestWebKitAPI::TEST):
1706
1707 2015-08-11  Brian Burg  <bburg@apple.com>
1708
1709         webkit-patch should not explode when $EDITOR is set incorrectly
1710         https://bugs.webkit.org/show_bug.cgi?id=147884
1711
1712         Reviewed by Darin Adler.
1713
1714         If $EDITOR doesn't exist, log a warning and continue.
1715
1716         * Scripts/webkitpy/common/system/user.py: 
1717         (User.edit):
1718         (User.edit_changelog):
1719
1720 2015-08-11  Dan Bernstein  <mitz@apple.com>
1721
1722         Reverted r188255, because it turned out that delegates do nonot need this information.
1723
1724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1725         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
1726
1727 2015-08-11  Dan Bernstein  <mitz@apple.com>
1728
1729         [Cocoa] The UI delegate can't tell if printing was user-initiated
1730         https://bugs.webkit.org/show_bug.cgi?id=147869
1731
1732         Reviewed by Sam Weinig.
1733
1734         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1735         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
1736         (-[PrintFrameController webView:didFinishNavigation:]):
1737         (-[PrintFrameController _webView:printFrame:userInitiated:]):
1738         (TEST):
1739
1740 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1741
1742         Another build fix after r188239.
1743
1744         * TestWebKitAPI/PlatformWin.cmake:
1745         Link with more libraries.
1746         * WinLauncher/CMakeLists.txt:
1747         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
1748
1749 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
1750
1751         Build fix after r188237.
1752
1753         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1754         (BenchmarkBuilder.__enter__):
1755
1756 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1757
1758         Update ReadMe and correct the way to use abstract abstract class.
1759         https://bugs.webkit.org/show_bug.cgi?id=147860
1760
1761         Reviewed by Ryosuke Niwa.
1762
1763         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
1764         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
1765
1766         * Scripts/webkitpy/benchmark_runner/README.md:
1767         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1768         (BrowserDriver):
1769         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1770         (OSXBrowserDriver.restore_env):
1771         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1772         (HTTPServerDriver):
1773         (HTTPServerDriver.set_device_id):
1774         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1775         (SimpleHTTPServerDriver.get_return_code):
1776         (SimpleHTTPServerDriver):
1777         (SimpleHTTPServerDriver.set_device_id):
1778
1779 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1780
1781         Build TestWebKitAPI with CMake on Windows
1782         https://bugs.webkit.org/show_bug.cgi?id=147851
1783
1784         Reviewed by Chris Dumez.
1785
1786         * CMakeLists.txt:
1787         * TestWebKitAPI/CMakeLists.txt:
1788         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
1789         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
1790         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
1791         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
1792         * TestWebKitAPI/PlatformEfl.cmake:
1793         * TestWebKitAPI/PlatformGTK.cmake:
1794         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
1795         I did this without changing the directory structure of the existing EFL and GTK builds.
1796         * TestWebKitAPI/PlatformWin.cmake: Added.
1797         * TestWebKitAPI/win/main.cpp:
1798         (main):
1799         (dllLauncherEntryPoint):
1800         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
1801         * WinLauncher/CMakeLists.txt:
1802         AppleWin port needs /NODEFAULTLIB:MSVCRT.
1803
1804 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1805
1806         Make cleanup more robust and minor code cleaning in run benchmark script.
1807         https://bugs.webkit.org/show_bug.cgi?id=147800
1808
1809         Reviewed by Ryosuke Niwa.
1810
1811         Use 'finnaly' block to make sure cleanup code is always executed.
1812
1813         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1814         (built_benchmark):
1815         (built_benchmark.__init__):
1816         (built_benchmark.__enter__):
1817         (built_benchmark.__exit__):
1818         (test_environment):
1819         (test_environment.__init__):
1820         (test_environment.__enter__):
1821         (test_environment.__exit__):
1822         (BenchmarkRunner.__init__):
1823         (BenchmarkRunner.execute):
1824         (BenchmarkRunner._dump):
1825         (BenchmarkRunner._wrap):
1826         (BenchmarkRunner): Deleted.
1827         (BenchmarkRunner._cleanup): Deleted.
1828         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1829         (BrowserDriver.close_browsers):
1830         (BrowserDriver):
1831         (BrowserDriver.restore_env):
1832         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1833         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
1834
1835 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1836
1837         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
1838         https://bugs.webkit.org/show_bug.cgi?id=146414
1839
1840         Reviewed by Darin Adler.
1841
1842         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1843         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
1844
1845 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1846
1847         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
1848         https://bugs.webkit.org/show_bug.cgi?id=147727
1849
1850         Reviewed by Sergio Villar Senin.
1851
1852         I think it was not this test in particular, but
1853         /webkit2/WebKitWebView/custom-charset that is affecting the
1854         others. This is because changing the encoding reloads the page,
1855         but we don't wait for the page to be reloaded, so when the test
1856         finishes and other test starts the web process is still reloading
1857         the page.
1858
1859         * Scripts/run-gtk-tests:
1860         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
1861         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1862         (testWebViewCustomCharset): Wait until page is reloaded after
1863         changing the charset.
1864
1865 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1866
1867         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
1868
1869         It's timing out in the bots. My guess is that there's no installer
1870         installed in the bots and gst_install_plugins_supported() returns
1871         false, so we don't even get a permission request because no
1872         installer will be launched.
1873
1874         * Scripts/run-gtk-tests:
1875         (TestRunner):
1876
1877 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1878
1879         [GTK] Another build fix after r188157.
1880
1881         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1882         (WTR::PlatformWebView::viewSupportsOptions):
1883         Name all the things correctly!
1884
1885 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1886
1887         [EFL, GTK] Build fix after r188176.
1888
1889         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1890         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
1891
1892 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1893
1894         [GTK] Speculative build fix after r188157.
1895
1896         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1897         (WTR::PlatformWebView::PlatformWebView):
1898         Update parameter list.
1899
1900 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1901
1902         Build more testing binaries with CMake on Windows
1903         https://bugs.webkit.org/show_bug.cgi?id=147799
1904
1905         Reviewed by Brent Fulgham.
1906
1907         * DumpRenderTree/CMakeLists.txt:
1908         Build TestNetscapePlugin.
1909         * DumpRenderTree/PlatformWin.cmake:
1910         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
1911         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
1912         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
1913         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
1914         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
1915         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
1916         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
1917         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1918         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
1919
1920 2015-08-07  Jason Marcell  <jmarcell@apple.com>
1921
1922         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
1923         https://bugs.webkit.org/show_bug.cgi?id=147667
1924
1925         Reviewed by Daniel Bates.
1926
1927         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1928         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
1929         other than "openSource" and "internal".
1930         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
1931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1932         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
1933         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
1934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1935         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
1936         (sortedPlatforms): Deleted.
1937         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1938         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
1939         (sortedPlatforms): Deleted.
1940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1941         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
1942         and sorts them by this property returning the new sorted array.
1943
1944 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
1945
1946         Lightweight locks should be adaptive
1947         https://bugs.webkit.org/show_bug.cgi?id=147545
1948
1949         Reviewed by Geoffrey Garen.
1950
1951         * TestWebKitAPI/CMakeLists.txt:
1952         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1953         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1954         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
1955         (TestWebKitAPI::runLockTest):
1956         (TestWebKitAPI::TEST):
1957
1958 2015-08-07  Anders Carlsson  <andersca@apple.com>
1959
1960         Fix a tyop.
1961
1962         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1963         (WTR::PlatformWebView::viewSupportsOptions):
1964
1965 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
1966
1967         Update AppEngine app version numbers to the latest commit.
1968
1969         * QueueStatusServer/app.yaml:
1970         * TestResultServer/app.yaml:
1971
1972 2015-08-07  Anders Carlsson  <andersca@apple.com>
1973
1974         Simplify WKTR's view options
1975         https://bugs.webkit.org/show_bug.cgi?id=147791
1976
1977         Reviewed by Sam Weinig.
1978
1979         Instead of using a WKDictionaryRef, just use a struct for the options.
1980
1981         * WebKitTestRunner/PlatformWebView.h:
1982         (WTR::PlatformWebView::options):
1983         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1984         * WebKitTestRunner/TestController.cpp:
1985         (WTR::TestController::initialize):
1986         (WTR::TestController::createWebViewWithOptions):
1987         (WTR::TestController::ensureViewSupportsOptions):
1988         (WTR::TestController::updateLayoutTypeForTest):
1989         * WebKitTestRunner/TestController.h:
1990         * WebKitTestRunner/ViewOptions.h: Added.
1991         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1992         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1993         (WTR::PlatformWebView::PlatformWebView):
1994         (WTR::PlatformWebView::viewSupportsOptions):
1995         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1996         (WTR::PlatformWebView::viewSupportsOptions):
1997         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1998         (WTR::PlatformWebView::viewSupportsOptions):
1999         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2000         (WTR::PlatformWebView::PlatformWebView):
2001         (WTR::PlatformWebView::viewSupportsOptions):
2002         * WebKitTestRunner/mac/TestControllerMac.mm:
2003         (WTR::TestController::platformConfigureViewForTest):
2004
2005 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
2006
2007         Running tests for a long time results in some tests running very slowly (throttling)
2008         https://bugs.webkit.org/show_bug.cgi?id=147718
2009
2010         Reviewed by Chris Dumez.
2011
2012         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
2013         Although COCOA ports default this setting to be disabled in WebKit1,
2014         we should make both test harnesses disable the setting for consistency.
2015
2016         * DumpRenderTree/mac/DumpRenderTree.mm:
2017         (resetWebPreferencesToConsistentValues):
2018
2019 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2020
2021         Use a specific version of Speedometer in run-benchmark
2022         https://bugs.webkit.org/show_bug.cgi?id=147769
2023
2024         Reviewed by Chris Dumez.
2025
2026         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
2027
2028         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2029
2030 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2031
2032         twisted_http_server.py should support --port
2033         https://bugs.webkit.org/show_bug.cgi?id=147771
2034
2035         Reviewed by Chris Dumez.
2036
2037         Added the option. This makes the script more useful on its own.
2038
2039         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2040
2041 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2042
2043         [GTK] WTF unit tests are timing out in the bots
2044         https://bugs.webkit.org/show_bug.cgi?id=147777
2045
2046         Reviewed by Filip Pizlo.
2047
2048         Add a way to mark google unit tests as slow and add
2049         WTF_Lock.ContentedShortSection to the list. In case of slow test
2050         we use the double of the given timeout for that particular test.
2051
2052         * Scripts/run-gtk-tests:
2053         (TestRunner):
2054         (TestRunner._run_google_test):
2055
2056 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2057
2058         [GTK] run-gtk-tests should not stop when a google test case fails
2059         https://bugs.webkit.org/show_bug.cgi?id=147778
2060
2061         Reviewed by Philippe Normand.
2062
2063         For glib based tests we run the test runner with the -k option,
2064         but for google tests we are aborting as soon as we find a failure.
2065
2066         * Scripts/run-gtk-tests:
2067         (TestRunner._run_google_test_suite): Use a global return code that
2068         is set to 1 when any test has failed.
2069
2070 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2071
2072         [GStreamer] Do not automatically show PackageKit codec installation notifications
2073         https://bugs.webkit.org/show_bug.cgi?id=135973
2074
2075         Reviewed by Philippe Normand.
2076
2077         Handle the missing media plugins installation permission request
2078         in MiniBrowser and add a test case for the new API.
2079
2080         * MiniBrowser/gtk/BrowserWindow.c:
2081         (webViewDecidePermissionRequest):
2082         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2083         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2084         (permissionRequestCallback):
2085         (testInstallMissingPluginsPermissionRequest):
2086         (beforeAll):
2087         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2088         (methodCallCallback):
2089
2090 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
2091
2092         Running tests for a long time results in some tests running very slowly (throttling)
2093         https://bugs.webkit.org/show_bug.cgi?id=147718
2094
2095         Reviewed by Alexey Proskuryakov.
2096
2097         * WebKitTestRunner/TestController.cpp:
2098         (WTR::TestController::resetPreferencesToConsistentValues):
2099         Ensure throttling settings are disabled for tests for all ports, as
2100         COCOA ports default to having these setting enabled. Note, there is
2101         still other timer throttling not covered by these setting.
2102
2103 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2104
2105         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
2106         https://bugs.webkit.org/show_bug.cgi?id=147752
2107
2108         Reviewed by Chris Dumez.
2109
2110         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
2111
2112         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
2113         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
2114
2115         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
2116         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
2117         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
2118         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
2119         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
2120         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2121         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
2122         HTTPServerDriverFactory taking the platform name as an argument.
2123         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
2124         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
2125         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
2126         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2127         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
2128         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
2129         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
2130         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2131         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
2132         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
2133         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
2134         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
2135         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2136         (HTTPServerDriver): Replaced name by platforms.
2137         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2138         (SimpleHTTPServerDriver): Ditto.
2139         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2140         (parse_args): Removed --http-server-driver option.
2141         (start): Ditto.
2142
2143 2015-08-06  Chris Dumez  <cdumez@apple.com>
2144
2145         Toggle GPS state based on page visibility to save battery
2146         https://bugs.webkit.org/show_bug.cgi?id=147685
2147
2148         Reviewed by Benjamin Poulain.
2149
2150         Add testRunner.isGeolocationProviderActive() test support function.
2151
2152         * DumpRenderTree/TestRunner.cpp:
2153         (isGeolocationProviderActiveCallback):
2154         (TestRunner::staticFunctions):
2155         * DumpRenderTree/TestRunner.h:
2156         * DumpRenderTree/mac/MockGeolocationProvider.h:
2157         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2158         (-[MockGeolocationProvider isActive]):
2159         * DumpRenderTree/mac/TestRunnerMac.mm:
2160         (TestRunner::isGeolocationProviderActive):
2161         * DumpRenderTree/win/TestRunnerWin.cpp:
2162         (TestRunner::isGeolocationProviderActive):
2163         * WebKitTestRunner/GeolocationProviderMock.h:
2164         (WTR::GeolocationProviderMock::isActive):
2165         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2166         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2167         (WTR::InjectedBundle::isGeolocationProviderActive):
2168         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2169         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2170         (WTR::TestRunner::isGeolocationProviderActive):
2171         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2172         * WebKitTestRunner/TestController.cpp:
2173         (WTR::TestController::isGeolocationProviderActive):
2174         * WebKitTestRunner/TestController.h:
2175         * WebKitTestRunner/TestInvocation.cpp:
2176         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2177
2178 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2179
2180         Automate JSBench with run-benchmark
2181         https://bugs.webkit.org/show_bug.cgi?id=147716
2182
2183         Reviewed by Chris Dumez.
2184
2185         Added JSBench plan to run-benchmark.
2186
2187         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2188         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
2189         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
2190         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
2191         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
2192         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
2193         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
2194         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
2195         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
2196         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
2197         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
2198         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2199         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
2200         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
2201         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
2202         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2203
2204 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2205
2206         Pass-through the undefined options in run-jsc
2207         https://bugs.webkit.org/show_bug.cgi?id=147717
2208
2209         Undefined options in run-jsc is just passed to the actual jsc shell.
2210         We can execute `Tools/Scripts/run-jsc -d`.
2211
2212         Reviewed by Csaba Osztrogonác.
2213
2214         * Scripts/run-jsc:
2215
2216 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2217
2218         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
2219
2220         It's flaky.
2221
2222         * Scripts/run-gtk-tests:
2223         (TestRunner):
2224
2225 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
2226
2227         [EFL] Bump EFL version to 1.15.0
2228         https://bugs.webkit.org/show_bug.cgi?id=147450
2229
2230         Reviewed by Gyuyoung Kim.
2231
2232         * efl/jhbuild.modules:
2233
2234 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2235
2236         Unreviewed. Unksip TestContextMenu GTK+ API test.
2237
2238         This has been skipped for a long time, and it's very
2239         unconvenient. It has never failed for me locally, so let's try
2240         again to see if it works in the bots. I'll skip it again if it
2241         keeps failing.
2242
2243         * Scripts/run-gtk-tests:
2244         (TestRunner):
2245
2246 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
2247
2248         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
2249
2250         * DumpRenderTree/JavaScriptThreading.cpp:
2251         (javaScriptThreadsMutex):
2252         (runJavaScriptThread):
2253         (startJavaScriptThreads):
2254         (stopJavaScriptThreads):
2255         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2256         (TestWebKitAPI::TEST):
2257         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2258         (TestWebKitAPI::TEST):
2259
2260 2015-08-05  Alex Christensen  <achristensen@webkit.org>
2261
2262         Build DumpRenderTree with CMake.
2263         https://bugs.webkit.org/show_bug.cgi?id=147519
2264
2265         Reviewed by Brent Fulgham.
2266
2267         * CMakeLists.txt:
2268         Build the DumpRenderTree directory now that it builds successfully.
2269         * DumpRenderTree/CMakeLists.txt:
2270         Added missing source file and don't link with WebCore.lib.
2271         * DumpRenderTree/PlatformWin.cmake:
2272         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
2273         * WinLauncher/CMakeLists.txt:
2274         We need libcmt now that we are not linking with WebCore.lib.
2275
2276 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
2277
2278         AppScale: Use https URLs for subresources and links
2279         https://bugs.webkit.org/show_bug.cgi?id=147686
2280
2281         Reviewed by Ryosuke Niwa.
2282
2283         * QueueStatusServer/filters/webkit_extras.py:
2284         * TestResultServer/static-dashboards/dashboard_base.js:
2285         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2286         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2287         * TestResultServer/static-dashboards/treemap.js:
2288         * TestResultServer/static-dashboards/ui.js:
2289
2290 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
2291
2292         Rename Mutex to DeprecatedMutex
2293         https://bugs.webkit.org/show_bug.cgi?id=147675
2294
2295         Reviewed by Geoffrey Garen.
2296
2297         * DumpRenderTree/JavaScriptThreading.cpp:
2298         (javaScriptThreadsMutex):
2299         (runJavaScriptThread):
2300         (startJavaScriptThreads):
2301         (stopJavaScriptThreads):
2302         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2303         (TestWebKitAPI::TEST):
2304         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2305         (TestWebKitAPI::TEST):
2306
2307 2015-08-05  Timothy Hatcher  <timothy@apple.com>
2308
2309         Update the WebKit nightly icon
2310         https://bugs.webkit.org/show_bug.cgi?id=147684
2311
2312         Reviewed by Sam Weinig.
2313
2314         * WebKitLauncher/webkit.icns: Replaced.
2315
2316 2015-08-05  Daniel Bates  <dabates@apple.com>
2317
2318         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
2319         https://bugs.webkit.org/show_bug.cgi?id=147678
2320         <rdar://problem/21827815>
2321
2322         Reviewed by Brady Eidson.
2323
2324         Add a test to ensure that we restore the "should open external URLs" policy on
2325         page reload after the web content process crashes.
2326
2327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2328         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
2329         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2330         (TEST):
2331
2332 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
2333
2334         [EFL] Editing tests have been broken since r186694
2335         https://bugs.webkit.org/show_bug.cgi?id=146888
2336
2337         Reviewed by Brent Fulgham.
2338
2339         Restored some codes for the context click on GTK+ and EFL port.
2340
2341         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2342         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
2343
2344 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
2345
2346         Install twisted package for http server when necessary.
2347         https://bugs.webkit.org/show_bug.cgi?id=147082
2348
2349         Reviewed by Ryosuke Niwa.
2350
2351         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2352         * Scripts/webkitpy/thirdparty/__init__.py:
2353         (AutoinstallImportHook.find_module):
2354         (AutoinstallImportHook._install_twisted):
2355
2356 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2357
2358         [Win] Update Apple Windows build for VS2015
2359         https://bugs.webkit.org/show_bug.cgi?id=147653
2360
2361         Reviewed by Dean Jackson.
2362
2363         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
2364         something older than VS2015, define snprintf as _snprintf.
2365         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2366         Remove unneeded macro definition for snprintf.
2367         * Scripts/webkitpy/common/system/platforminfo.py:
2368         (PlatformInfo._determine_win_version): Recognize Windows 10.
2369         * Scripts/webkitpy/port/win.py:
2370         (WinPort): Ditto.
2371         * Scripts/webkitpy/port/win_unittest.py:
2372         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
2373         (WinPortTest._assert_version): Ditto.
2374
2375 2015-08-04  Brian Burg  <bburg@apple.com>
2376
2377         Unreviewed, update email addresses in contributors.json and watchlist.
2378
2379         * Scripts/webkitpy/common/config/contributors.json:
2380         * Scripts/webkitpy/common/config/watchlist:
2381
2382 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
2383
2384         Implement NPAPI redirect handling
2385         https://bugs.webkit.org/show_bug.cgi?id=138675
2386         rdar://problem/15779101
2387
2388         Patch by Jeffrey Pfau, updated and tweaked by me.
2389
2390         Reviewed by Anders Carlsson.
2391
2392         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2393         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2394         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2395         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2396         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2397         (PluginTest::NPP_URLNotify):
2398         (PluginTest::NPP_URLRedirectNotify):
2399         (PluginTest::NPP_GetValue):
2400         (PluginTest::NPN_GetURLNotify):
2401         (PluginTest::NPN_PostURLNotify):
2402         (PluginTest::NPN_GetValue):
2403         (PluginTest::NPN_ReleaseVariantValue):
2404         (PluginTest::NPN_URLRedirectResponse):
2405         (PluginTest::NPN_ConvertPoint):
2406         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2407         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
2408         (URLRedirect::URLRedirect):
2409         (URLRedirect::ScriptableObject::hasMethod):
2410         (URLRedirect::ScriptableObject::get):
2411         (URLRedirect::ScriptableObject::serviceAsync):
2412         (URLRedirect::ScriptableObject::invoke):
2413         (URLRedirect::NPP_GetValue):
2414         (URLRedirect::NPP_URLNotify):
2415         (URLRedirect::NPP_URLRedirectNotify):
2416         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2417         (NP_GetEntryPoints):
2418         (NPP_URLNotify):
2419         (NPP_URLRedirectNotify):
2420         (NPP_GetValue):
2421
2422 2015-08-04  Tim Horton  <timothy_horton@apple.com>
2423
2424         Move Matt Daiter to committers.
2425
2426         * Scripts/webkitpy/common/config/contributors.json:
2427
2428 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2429
2430         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
2431         https://bugs.webkit.org/show_bug.cgi?id=147636
2432
2433         Reviewed by Alex Christensen.
2434         
2435         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
2436         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
2437         on EWS machines)
2438
2439         * Scripts/build-webkit:
2440
2441 2015-08-04  Jason Marcell  <jmarcell@apple.com>
2442
2443         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
2444         https://bugs.webkit.org/show_bug.cgi?id=147280
2445
2446         Reviewed by Daniel Bates.
2447
2448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2449         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
2450         Refactored _parseData to handle repositories more generically.
2451         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
2452         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2453         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
2454         "opensourceRevision" and "internalRevision".
2455         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2456         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2457         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
2458         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2459         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
2460         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
2461         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
2462         and "internalRevision".
2463         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
2464         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
2465         "opensourceRevision" and "internalRevision".
2466         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
2467         constants for internal and opensource repositories.
2468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2469         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
2470         instead of "opensourceRevision" and "internalRevision".
2471         (Analyzer.prototype._countPercentageOfGreen): Ditto.
2472         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
2473         (Analyzer.prototype._countTimes): Ditto.
2474         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2475         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
2476
2477 2015-08-04  Mark Lam  <mark.lam@apple.com>
2478
2479         Removed a local debugging line I accidentally left in from a previous commit.
2480
2481         Not Reviewed.
2482
2483         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2484
2485 2015-08-04  Mark Lam  <mark.lam@apple.com>
2486
2487         Unreviewed. Make Saam Barati a WebKit reviewer.
2488
2489         * Scripts/webkitpy/common/config/contributors.json:
2490
2491 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2492
2493         Unreviewed, updated Streams API watchlist.
2494
2495         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
2496
2497 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
2498
2499         [CMake] Add an option to build AllInOne files
2500         https://bugs.webkit.org/show_bug.cgi?id=102647
2501
2502         Reviewed by Alex Christensen.
2503
2504         * Scripts/webkitperl/FeatureList.pm:
2505
2506 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
2507
2508         AppScale: Add required indices
2509         https://bugs.webkit.org/show_bug.cgi?id=147593
2510
2511         Reviewed by Tim Horton.
2512
2513         * QueueStatusServer/index.yaml:
2514
2515 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
2516
2517         Check in LLVM 3.6.2 binary drops for El Capitan
2518         https://bugs.webkit.org/show_bug.cgi?id=147582
2519
2520         Reviewed by Alexey Proskuryakov.
2521         
2522         Recognize 10.11 and use the right drops.
2523
2524         * Scripts/copy-webkitlibraries-to-product-directory:
2525
2526 2015-08-03  Alex Christensen  <achristensen@webkit.org>
2527
2528         [Win] Build fix after r187733.
2529
2530         * WinLauncher/PageLoadTestClient.cpp:
2531         (PageLoadTestClient::dumpRunStatistics):
2532         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
2533
2534 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
2535
2536         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
2537         https://bugs.webkit.org/show_bug.cgi?id=118455
2538
2539         Reviewed by Filip Pizlo.
2540
2541         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2542         (TestWebKitAPI::TEST):
2543
2544 2015-07-31  Alex Christensen  <achristensen@webkit.org>
2545
2546         Prepare for VS2015
2547         https://bugs.webkit.org/show_bug.cgi?id=146579
2548
2549         Reviewed by Jon Honeycutt.
2550
2551         * WinLauncher/stdafx.h:
2552         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
2553
2554 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2555
2556         [EFL] Fix pixman build on ARM with GCC 4.9.3
2557         https://bugs.webkit.org/show_bug.cgi?id=147224
2558
2559         Reviewed by Gyuyoung Kim.
2560
2561         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
2562
2563 2015-07-30  Anders Carlsson  <andersca@apple.com>
2564
2565         Add support for window.open to WK1BrowserWindowController
2566         https://bugs.webkit.org/show_bug.cgi?id=147474
2567
2568         Reviewed by Dan Bernstein.
2569
2570         * MiniBrowser/mac/WK1BrowserWindowController.m:
2571         (-[WK1BrowserWindowController awakeFromNib]):
2572         Set javaScriptCanOpenWindowsAutomatically to YES. 
2573         If this becomes a nuisance, we can always add a menu item to toggle this.
2574
2575         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2576         Implement this UI delegate method.
2577
2578 2015-07-30  Anders Carlsson  <andersca@apple.com>
2579
2580         Undo stray commit.
2581
2582         * MiniBrowser/mac/WK1BrowserWindowController.m:
2583         (-[WK1BrowserWindowController awakeFromNib]):
2584         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2585
2586 2015-07-29  Dean Jackson  <dino@apple.com>
2587
2588         Don't use (Details) when exposing SPI
2589         https://bugs.webkit.org/show_bug.cgi?id=147426
2590         <rdar://problem/22062407>
2591
2592         Reviewed by Dan Bernstein.
2593
2594         If we are declaring the interface without any implementation,
2595         we should use class extensions.
2596
2597         * DumpRenderTree/mac/DumpRenderTree.mm:
2598         * DumpRenderTree/mac/EventSendingController.mm:
2599         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2600         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2601         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2602         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2603         * WebKitTestRunner/mac/TestControllerMac.mm:
2604
2605 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
2606
2607         Replace Google App Engine with AppScale
2608         https://bugs.webkit.org/show_bug.cgi?id=147178
2609
2610         Reviewed by Daniel Bates.
2611
2612         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2613         (RunWebKitTests):
2614         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2615         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2617         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2619         (.):
2620         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2621         (BubbleQueueServer):
2622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2623         (TestHistory):
2624         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2625         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
2626         * TestResultServer/app.yaml: Ditto
2627         * Scripts/webkitpy/common/config/urls.py:
2628         * TestResultServer/main.py:
2629         * TestResultServer/static-dashboards/dashboard_base.js:
2630         * TestResultServer/static-dashboards/loader.js:
2631
2632 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
2633
2634         [EFL] Enable IndexedDB based on DatabaseProcess
2635         https://bugs.webkit.org/show_bug.cgi?id=147221
2636
2637         Reviewed by Csaba Osztrogonác.
2638
2639         * Scripts/webkitperl/FeatureList.pm:
2640
2641 2015-07-30  Alex Christensen  <achristensen@webkit.org>
2642
2643         Build AppleWin port with CMake
2644         https://bugs.webkit.org/show_bug.cgi?id=147385
2645
2646         Reviewed by Martin Robinson.
2647
2648         * WinLauncher/CMakeLists.txt:
2649         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
2650
2651 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
2652
2653         Implement basic types for ECMAScript Internationalization API
2654         https://bugs.webkit.org/show_bug.cgi?id=146926
2655
2656         Reviewed by Benjamin Poulain.
2657
2658         Enable flag now that the basic objects are in place.
2659
2660         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
2661
2662 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2663
2664         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
2665         https://bugs.webkit.org/show_bug.cgi?id=147108
2666
2667         Reviewed by Gustavo Noronha Silva.
2668
2669         Add test case to check the web process limit.
2670
2671         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2672         (testWebProcessLimit):
2673         (beforeAll):
2674
2675 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2676
2677         [GTK] Missing casts in BrowserWindow.c
2678         https://bugs.webkit.org/show_bug.cgi?id=147395
2679
2680         Reviewed by Carlos Garcia Campos.
2681
2682         * MiniBrowser/gtk/BrowserWindow.c:
2683         (browserWindowSetupEditorToolbar):
2684
2685 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2686
2687         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
2688         https://bugs.webkit.org/show_bug.cgi?id=147350
2689
2690         Reviewed by Sam Weinig.
2691
2692         * Scripts/webkitperl/FeatureList.pm:
2693
2694 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2695
2696         [Freetype] Always allow font matching for strong aliases
2697         https://bugs.webkit.org/show_bug.cgi?id=147057
2698
2699         Reviewed by Martin Robinson.
2700
2701         Create family aliases needed for the new layout tests.
2702
2703         * WebKitTestRunner/gtk/fonts/fonts.conf:
2704
2705 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
2706
2707         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
2708         https://bugs.webkit.org/show_bug.cgi?id=147359
2709
2710         Reviewed by Ryosuke Niwa.
2711
2712         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2713         (NewCommitBot.begin_work_queue):
2714         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2715         (SheriffBot.begin_work_queue):
2716
2717 2015-07-27  Alex Christensen  <achristensen@webkit.org>
2718
2719         Use Ninja on Windows.
2720         https://bugs.webkit.org/show_bug.cgi?id=147228
2721
2722         Reviewed by Martin Robinson.
2723
2724         * WinLauncher/CMakeLists.txt:
2725         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
2726         * Scripts/build-webkit:
2727         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
2728
2729 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
2730
2731         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
2732         highlight after being tapped to style a selection"
2733         https://bugs.webkit.org/show_bug.cgi?id=147278
2734
2735         Reviewed by Ryosuke Niwa.
2736
2737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2738
2739         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
2740         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
2741         (TestWebKitAPI::TEST):
2742         Load a page with the string "Hello, world!", then select "world" and
2743         underline it. Test that the typing attributes for the current selection
2744         include the underline attribute.
2745
2746 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2747
2748         Unreviewed, updated my nick name in contributors.json
2749
2750         * Scripts/webkitpy/common/config/contributors.json:
2751
2752 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
2753
2754         AX: scrollable elements do not allow 3-finger swipe
2755         https://bugs.webkit.org/show_bug.cgi?id=141893
2756
2757         Reviewed by Mario Sanchez Prada.
2758
2759         Support global notification listeners for iOS code.
2760         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
2761         Implement scrollUp/Down/Left/Right.
2762
2763         * DumpRenderTree/AccessibilityController.h:
2764         * DumpRenderTree/AccessibilityUIElement.cpp:
2765         (increaseTextSelectionCallback):
2766         (scrollPageUpCallback):
2767         (scrollPageDownCallback):
2768         (scrollPageLeftCallback):
2769         (scrollPageRightCallback):
2770         (decreaseTextSelectionCallback):
2771         (getElementTextLengthCallback):
2772         (AccessibilityUIElement::getJSClass):
2773         * DumpRenderTree/AccessibilityUIElement.h:
2774         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2775         (AccessibilityController::~AccessibilityController):
2776         (AccessibilityController::elementAtPoint):
2777         (AccessibilityController::addNotificationListener):
2778         (AccessibilityController::platformResetToConsistentState):
2779         (AccessibilityController::removeNotificationListener):
2780         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2781         (AccessibilityUIElement::AccessibilityUIElement):
2782         (AccessibilityUIElement::subrole):
2783         (AccessibilityUIElement::scrollPageUp):
2784         (AccessibilityUIElement::scrollPageDown):
2785         (AccessibilityUIElement::scrollPageLeft):
2786         (AccessibilityUIElement::scrollPageRight):
2787         (AccessibilityUIElement::roleDescription):
2788         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2789         (-[AccessibilityNotificationHandler _notificationReceived:]):
2790         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2791         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2792         (WTR::AccessibilityUIElement::linkedElement):
2793         (WTR::AccessibilityUIElement::headerElementAtIndex):
2794         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2795         (WTR::AccessibilityUIElement::scrollPageUp):
2796         (WTR::AccessibilityUIElement::scrollPageDown):
2797         (WTR::AccessibilityUIElement::scrollPageLeft):
2798         (WTR::AccessibilityUIElement::scrollPageRight):
2799         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2800         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2801         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2802         (WTR::AccessibilityController::addNotificationListener):
2803         (WTR::AccessibilityController::removeNotificationListener):
2804         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2805         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2806         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2807         (WTR::AccessibilityUIElement::scrollPageUp):
2808         (WTR::AccessibilityUIElement::scrollPageDown):
2809         (WTR::AccessibilityUIElement::scrollPageLeft):
2810         (WTR::AccessibilityUIElement::scrollPageRight):
2811         (WTR::AccessibilityUIElement::increaseTextSelection):
2812
2813 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
2814
2815         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
2816         https://bugs.webkit.org/show_bug.cgi?id=147279
2817         <rdar://problem/21990767>
2818
2819         Reviewed by Dean Jackson.
2820
2821         * DumpRenderTree/win/TestRunnerWin.cpp:
2822         (TestRunner::addUserScript):
2823         (TestRunner::addUserStyleSheet):
2824         (TestRunner::setDeveloperExtrasEnabled):
2825
2826 2015-07-24  Basile Clement  <basile_clement@apple.com>
2827
2828         Call fixChangeLogPatch when generating patches from webkit-patch
2829         https://bugs.webkit.org/show_bug.cgi?id=147248
2830
2831         Reviewed by Geoffrey Garen.
2832
2833         When two consecutive patches are from the same author, diff tools
2834         create wrong-looking diffs for ChangeLog files where the apparent added
2835         author is actually the previous patch's author line, making it awkward
2836         to read - and things only get worse when committing a patch and a
2837         followup fix for the same bug shortly after.
2838
2839         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
2840         this, which we use in perl scripts (svn-create-patch et al). But it is
2841         not used by webkit-patch, which is a python script, and thus creates
2842         "bad" diffs.
2843
2844         In the long term, we should probably port fixChangeLogPatch to python -
2845         but in the short term, let's make webkit-patch call perl to run
2846         fixChangeLogPatch. We are already making various external calls there
2847         anyway.
2848
2849         * Scripts/webkitpy/common/checkout/scm/git.py:
2850         (Git.create_patch):
2851         * Scripts/webkitpy/common/checkout/scm/scm.py:
2852         (SCM.fix_changelog_patch):
2853         * Scripts/webkitpy/common/checkout/scm/svn.py:
2854         (SVN.create_patch):
2855
2856 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
2857
2858         commit-queue flags in webkit-patch are confusing
2859         https://bugs.webkit.org/show_bug.cgi?id=88694
2860
2861         Reviewed by Csaba Osztrogonác.
2862
2863         * Scripts/webkitpy/tool/steps/options.py:
2864         (Options): Updated help string to be more descriptive.
2865
2866 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
2867
2868         [Win] Implement proper High DPI support features
2869         https://bugs.webkit.org/show_bug.cgi?id=146335
2870         <rdar://problem/21558269>
2871
2872         Reviewed by Alex Christensen.
2873
2874         Update WinLauncher to take device scaling factor into account.
2875
2876         * WinLauncher/Common.cpp:
2877         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
2878         a valid font.
2879         (computeFullDesktopFrame): Handle high DPI desktops.
2880         (WndProc): Make comments more precise.
2881         * WinLauncher/WinLauncher.cpp:
2882         (WinLauncher::init): Determine device scale factor at launch.
2883         (WinLauncher::updateDeviceScaleFactor): Added.
2884         * WinLauncher/WinLauncher.h:
2885         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
2886         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
2887         (wWinMain): Ditto.
2888         * win/DLLLauncher/DLLLauncherMain.cpp:
2889         (wWinMain): Tell Windows we understand high DPI.
2890
2891 2015-07-23  Alex Christensen  <achristensen@webkit.org>
2892
2893         [Win] Unreviewed build fix after r187169.
2894
2895         * Scripts/build-webkit:
2896         Correctly find WebKit.sln.
2897
2898 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2899
2900         [GTK] Add API to allow executing editing commands that require an argument
2901         https://bugs.webkit.org/show_bug.cgi?id=146781
2902
2903         Reviewed by Gustavo Noronha Silva.
2904
2905         Add buttons to insert image/link to the MiniBrowser edit toolbar,
2906         and test cases for insert image/link commands too.
2907
2908         * MiniBrowser/gtk/BrowserWindow.c:
2909         (insertImageCommandCallback):
2910         (insertLinkCommandCallback):
2911         (browserWindowSetupEditorToolbar):
2912         (browserWindowConstructed):
2913         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2914         (testWebViewEditorInsertImage):
2915         (testWebViewEditorCreateLink):
2916         (beforeAll):
2917
2918 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2919
2920         Unregistering and re-registering a user message handler does not work
2921         https://bugs.webkit.org/show_bug.cgi?id=138142
2922
2923         Reviewed by Martin Robinson.
2924
2925         This has probably been fixed in r184846, enable the test case
2926         blocked on it.
2927
2928         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2929         (testUserContentManagerScriptMessageReceived):
2930
2931 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
2932
2933         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
2934         https://bugs.webkit.org/show_bug.cgi?id=147212
2935
2936         Reviewed by Filip Pizlo.
2937
2938         * Scripts/webkitperl/FeatureList.pm:
2939
2940 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
2941
2942         Add --ios-simulator to run-api-tests --help.
2943
2944         Rubber-stamped by Dan Bates.
2945
2946         * Scripts/run-api-tests:
2947
2948 2015-07-22  Jason Marcell  <jmarcell@apple.com>
2949
2950         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
2951         https://bugs.webkit.org/show_bug.cgi?id=147043
2952
2953         Reviewed by Daniel Bates and Alexey Proskuryakov.
2954
2955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2956         (Buildbot.prototype._normalizeQueueInfo):
2957         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
2958         in cases where the queue.branch property is not set and the queue is not a combined queue.
2959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2960         (BuildbotCombinedQueueView):
2961         Ensuring uniformity of repository branches within a combined queue.
2962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2963         (WebKitBuildbot.prototype.get defaultBranches):
2964         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
2965         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
2966         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
2967         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
2968         implement defaultBranches so that a person can either update the definition of the sub-queue or
2969         implement defaultBranches in the derived Buildbot class they are using.
2970
2971 2015-07-22  Alex Christensen  <achristensen@webkit.org>
2972
2973         Switch WinCairo build to use CMake.
2974         https://bugs.webkit.org/show_bug.cgi?id=147169
2975
2976         Reviewed by Brent Fulgham.
2977
2978         * Scripts/build-webkit:
2979         * Scripts/webkitdirs.pm:
2980         (determineConfiguration):
2981         (determineArchitecture):
2982         (determinePassedConfiguration):
2983         (passedConfiguration):
2984         (jhbuildWrapperPrefixIfNeeded):
2985         (generateBuildSystemFromCMakeProject):
2986         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
2987
2988 2015-07-22  Alex Christensen  <achristensen@webkit.org>
2989
2990         Fix quirks in CMake build on Mac and Windows
2991         https://bugs.webkit.org/show_bug.cgi?id=147174
2992
2993         Reviewed by Gyuyoung Kim.
2994
2995         * CMakeLists.txt:
2996         Don't build DumpRenderTree with CMake for now (until we get that working).
2997         * WinLauncher/CMakeLists.txt:
2998         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
2999
3000 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3001
3002         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
3003         https://bugs.webkit.org/show_bug.cgi?id=147146
3004
3005         Reviewed by Darin Adler.
3006
3007         * Scripts/webkitpy/style/checkers/cpp.py:
3008         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
3009         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3010         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
3011
3012 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
3013
3014         Fixed VM pool allocation should have a reserve for allocations that cannot fail
3015         https://bugs.webkit.org/show_bug.cgi?id=147154
3016         rdar://problem/21847618
3017
3018         Reviewed by Geoffrey Garen.
3019         
3020         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
3021         mitigations work, these should all pass. Prior to this patch there were >20 failures.
3022
3023         * Scripts/run-jsc-stress-tests:
3024
3025 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3026
3027         [GTK] Add API to be notified about editor state changes
3028         https://bugs.webkit.org/show_bug.cgi?id=145875
3029
3030         Reviewed by Gustavo Noronha Silva.
3031
3032         Update the typing attributes toggle buttons state according to the
3033         editor state in MiniBrowser, and add a test case to the
3034         WebViewEditor unit tests.
3035
3036         * MiniBrowser/gtk/BrowserWindow.c:
3037         (browserWindowEditingCommandToggleButtonSetActive):
3038         (typingAttributesChanged):
3039         (browserWindowSetupEditorToolbar):
3040         (browserWindowConstructed):
3041         (browser_window_init):
3042         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3043         (testWebViewEditorEditorStateTypingAttributes):
3044         (beforeAll):
3045
3046 2015-07-20  Tomas Popela  <tpopela@redhat.com>
3047
3048         [GTK] Add selection-changed signal to the WebKit2 API
3049         https://bugs.webkit.org/show_bug.cgi?id=137116
3050
3051         Reviewed by Carlos Garcia Campos.
3052
3053         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
3054         (namely the selection-changed signal).
3055
3056         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3057         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
3058         (WebKitWebEditorTest::create):
3059         (WebKitWebEditorTest::selectionChangedCallback):
3060         (WebKitWebEditorTest::testSelectionSelectAll):
3061         (WebKitWebEditorTest::testSelectionCollapse):
3062         (WebKitWebEditorTest::testSelectionModifyMove):
3063         (WebKitWebEditorTest::testSelectionModifyExtend):
3064         (WebKitWebEditorTest::testSelectionUnselect):
3065         (registerTests):
3066         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
3067         (testWebKitWebEditorSelectionChanged):
3068         (beforeAll):
3069         (afterAll):
3070
3071 2015-07-20  Alex Christensen  <achristensen@webkit.org>
3072
3073         Resurrect CMake build on Windows.
3074         https://bugs.webkit.org/show_bug.cgi?id=147083
3075
3076         Reviewed by Gyuyoung Kim.
3077
3078         * DumpRenderTree/CMakeLists.txt:
3079         * DumpRenderTree/PlatformWin.cmake: Added.
3080         * WinLauncher/CMakeLists.txt:
3081
3082 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3083
3084         [GTK] Enable seccomp filter API tests
3085         https://bugs.webkit.org/show_bug.cgi?id=140071
3086
3087         Reviewed by Žan Doberšek.
3088
3089         These tests will now be run by the run-gtk-tests script.
3090
3091         * TestWebKitAPI/PlatformGTK.cmake:
3092
3093 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3094
3095         [GTK] Add seccomp filters support
3096         https://bugs.webkit.org/show_bug.cgi?id=110014
3097
3098         Reviewed by Žan Doberšek.
3099
3100         Add libseccomp to jhbuild modulesets.
3101
3102         * gtk/jhbuild.modules:
3103
3104 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
3105
3106         MiniBrowser window title is just "Window" when page has no <title>
3107         https://bugs.webkit.org/show_bug.cgi?id=147076
3108
3109         Reviewed by Tim Horton.
3110         
3111         Make MiniBrowser windows show the filename from the URL if we never get a title changed
3112         notification.
3113
3114         * MiniBrowser/mac/WK1BrowserWindowController.m:
3115         (-[WK1BrowserWindowController updateTitle:]):
3116         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
3117         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
3118         * MiniBrowser/mac/WK2BrowserWindowController.m:
3119         (-[WK2BrowserWindowController updateTitle:]):
3120         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3121         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3122
3123 2015-07-17  Andy Estes  <aestes@apple.com>
3124
3125         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
3126         https://bugs.webkit.org/show_bug.cgi?id=147044
3127         rdar://problem/21567820
3128
3129         Reviewed by Brady Eidson.
3130
3131         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3132         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
3133         This matches the behavior of DumpRenderTree.
3134
3135 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
3136
3137         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
3138         https://bugs.webkit.org/show_bug.cgi?id=147032
3139
3140         Reviewed by Alex Christensen.
3141
3142         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3143         Test that the useless terms are eliminated by counting
3144         the number of NFA nodes generated.
3145
3146 2015-07-17  Dan Bernstein  <mitz@apple.com>
3147
3148         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
3149         https://bugs.webkit.org/show_bug.cgi?id=147040
3150
3151         Reviewed by Dean Jackson.
3152
3153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3154         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
3155         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
3156         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
3157         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3158         (TEST):
3159
3160 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
3161
3162         webkit-patch uses incorrect credentials from keychain to login until account lockout
3163         https://bugs.webkit.org/show_bug.cgi?id=146923
3164
3165         Reviewed by Daniel Bates.
3166
3167         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
3168         provide incorrect credentials then ask for them to be saved to the keychain
3169         webkit-patch will then use those incorrect credentials until 5 total attempts
3170         have been made to log in. This will lock the user out of Bugzilla for a
3171         half hour.
3172
3173         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3174         (Bugzilla.authenticate): Added argument to read_credentials() that
3175         passes in whether or not to use stored credentials.
3176         * Scripts/webkitpy/common/net/credentials.py:
3177         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
3178         that specifies whether or not to use credentials stored on the system. If it
3179         does, we do not auto-fill credentials since either the credentials caused
3180         the failure, or they weren't used in the first place so there is no reason
3181         to try and use them again if a failure happened.
3182         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
3183         use_stored_credentials argument.
3184         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
3185         retrieve username/password information from the local system (environment, Git, keychain,
3186         keyring) are never called. It also tests that we get back our mocked username and password.
3187         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
3188         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
3189         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
3190         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
3191         is never called.
3192         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
3193         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
3194         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
3195         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
3196         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
3197         against.
3198
3199 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3200
3201         Unreviewed, remove my redundant email information.
3202
3203         * Scripts/webkitpy/common/config/contributors.json:
3204
3205 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3206
3207         Unreviewed. Add Hyungwook Lee as a committer.
3208
3209         * Scripts/webkitpy/common/config/contributors.json:
3210
3211 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3212
3213         Added myself to the list of contributors.
3214
3215         Reviewed by Brent Fulgham.
3216
3217         * Scripts/webkitpy/common/config/contributors.json:
3218
3219 2015-07-16  Alex Christensen  <achristensen@webkit.org>
3220
3221         [Content Extensions] Cache domain actions
3222         https://bugs.webkit.org/show_bug.cgi?id=146817
3223
3224         Reviewed by Benjamin Poulain.
3225
3226         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3227         (TestWebKitAPI::TEST_F):
3228         Test if-domain and unless-domain with multiple load types.
3229
3230 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
3231
3232         [Content extensions] Combine suffixes when generating NFAs
3233         https://bugs.webkit.org/show_bug.cgi?id=146961
3234
3235         Reviewed by Alex Christensen.
3236
3237         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3238         (TestWebKitAPI::compareContents):
3239         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3240
3241 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3242
3243         [GTK] Input method filter is always enabled when the view is focused
3244         https://bugs.webkit.org/show_bug.cgi?id=146965
3245
3246         Reviewed by Martin Robinson.
3247
3248         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
3249
3250         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
3251         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
3252
3253 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3254
3255         [EFL] Bump libseccomp version to 2.2.3
3256         https://bugs.webkit.org/show_bug.cgi?id=146980
3257
3258         Reviewed by Gyuyoung Kim.
3259
3260         * efl/jhbuild.modules:
3261
3262 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
3263
3264         [Win] Maintain consistent COM Interfaces
3265         https://bugs.webkit.org/show_bug.cgi?id=146983
3266         <rdar://problem/21822278>
3267
3268         Reviewed by Dean Jackson.
3269
3270         Update DumpRenderTree and WinLauncher to use the properly
3271         versioned COM interface objects.
3272
3273         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3274         (AccessibilityController::rootElement):
3275         * DumpRenderTree/win/DumpRenderTree.cpp:
3276         (resetWebPreferencesToConsistentValues):
3277         (resetWebViewToConsistentStateBeforeTesting):
3278         (runTest):
3279         (createWebViewAndOffscreenWindow):
3280         * DumpRenderTree/win/EditingDelegate.cpp:
3281         (EditingDelegate::QueryInterface):
3282         (EditingDelegate::shouldEndEditingInDOMRange):
3283         (EditingDelegate::shouldInsertNode):
3284         * DumpRenderTree/win/EditingDelegate.h:
3285         * DumpRenderTree/win/EventSender.cpp:
3286         (scalePageByCallback):
3287         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3288         (FrameLoadDelegate::didCommitLoadForFrame):
3289         * DumpRenderTree/win/TestRunnerWin.cpp:
3290         (TestRunner::callShouldCloseOnWebView):
3291         (TestRunner::applicationCacheDiskUsageForOrigin):
3292         (TestRunner::clearApplicationCacheForOrigin):
3293         (TestRunner::setDefersLoading):
3294         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3295         (TestRunner::setTabKeyCyclesThroughElements):
3296         (TestRunner::setValueForUser):
3297         (TestRunner::dispatchPendingLoadRequests):
3298         (TestRunner::setWindowIsKey):
3299         (TestRunner::execCommand):
3300         (TestRunner::addOriginAccessWhitelistEntry):
3301         (TestRunner::removeOriginAccessWhitelistEntry):
3302         (TestRunner::addUserScript):
3303         (TestRunner::addUserStyleSheet):
3304         (TestRunner::showWebInspector):
3305         (TestRunner::closeWebInspector):
3306         (TestRunner::evaluateInWebInspector):
3307         (TestRunner::setSerializeHTTPLoads):
3308         * DumpRenderTree/win/TextInputControllerWin.cpp:
3309         (TextInputController::setMarkedText):
3310         (TextInputController::hasMarkedText):
3311         (TextInputController::unmarkText):
3312         (TextInputController::markedRange):
3313         (TextInputController::insertText):
3314         (TextInputController::firstRectForCharacterRange):
3315         (TextInputController::selectedRange):
3316         * DumpRenderTree/win/UIDelegate.h:
3317         (UIDelegate::unused2):
3318         (UIDelegate::unused3):
3319         (UIDelegate::webViewScrolled):
3320         (UIDelegate::webViewShouldInterruptJavaScript):
3321         (UIDelegate::webViewReceivedFocus):
3322         (UIDelegate::unused4): Deleted.
3323         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3324         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3325         * WinLauncher/PageLoadTestClient.cpp:
3326         (PageLoadTestClient::didStartProvisionalLoad):
3327         * WinLauncher/WinLauncher.cpp:
3328         (WinLauncher::init):
3329         * WinLauncher/WinLauncher.h:
3330         * WinLauncher/WinLauncherWebHost.cpp:
3331         (WinLauncherWebHost::didFinishLoadForFrame):
3332         (WinLauncherWebHost::didFirstLayoutInFrame):
3333         * WinLauncher/WinLauncherWebHost.h:
3334
3335 2015-07-15  Dean Johnson  <dean_johnson@apple.com>
3336
3337         Many test failures in scm_unittest.py
3338         https://bugs.webkit.org/show_bug.cgi?id=143967
3339
3340         Reviewed by Daniel Bates. 
3341
3342         * Scripts/webkitpy/common/checkout/scm/detection.py:
3343         (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to
3344         absolute canonical file paths. Two mutually exclusive issues cause this
3345         to be a problem.
3346             1) Python's os.path.relpath() function does not return correct relative
3347             paths between two filepaths that point to the same file, if symlinks are
3348             involved.
3349                 On Mac, /tmp points to /private/tmp
3350                 ex. os.path.relpath('/tmp', '/private/tmp')
3351                     returns '../../tmp'
3352             What we want is actually just '.'
3353             2) Git does not allow file paths to trace outside of
3354             the Git repository. This means that if you have a repository in
3355             /tmp and you refer to that repository when invoking a git command as
3356             ../tmp, Git will produce errors about working outside of the repository.
3357         * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed
3358         its default behavior and such, needed to be updated.
3359         (Git.changed_files): '--' was added into the command so that patch_directories
3360         were taken as positional arguments.
3361         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup 
3362         in the GitSVNTest class to more closely emulate the version of Git that the tests
3363         assumed a system had. Also fixed a small side-effect from the absolute canonical
3364         path fix in SCMDetector.detect_scm_system
3365         (SVNTestRepository.setup): A relative filepath was previously passed as the
3366         checkout root to SCMDetector.detect_scm_system, but is now cleaned to
3367         an absolute canonical path before being passed in. The failing test
3368         was a "sanity check" that the svn.checkout_root and scm.checkout_root
3369         were the same.
3370         (GitSVNTest._setup_git_checkout):
3371             1) Added "--prefix ''" option to `git clone` since Git changed its default
3372             behavior in version 2.0.
3373             2) The branch master was renamed to trunk to more closely emulate what
3374             tests expected when they were written. 
3375         (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three
3376         original tests failed because the tests expected the trunk branch
3377         to produce its parent's commit, whereas Git merely provides the HEAD commit
3378         for a given branch (trunk in this case). Based on other tests written
3379         in the same commit, it appears these tests were failing from the point they
3380         were written.
3381
3382 2015-07-14  Anders Carlsson  <andersca@apple.com>
3383
3384         Assertions.h should include ExportMacros.h
3385         https://bugs.webkit.org/show_bug.cgi?id=146948
3386
3387         Reviewed by Tim Horton.
3388
3389         Remove now unneeded WTF_EXPORT_PRIVATE define.
3390
3391         * DumpRenderTree/cg/ImageDiffCG.cpp:
3392
3393 2015-07-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3394
3395         [GTK] [Wayland] Build by default the X11 and Wayland targets.
3396         https://bugs.webkit.org/show_bug.cgi?id=146057
3397
3398         Reviewed by Carlos Garcia Campos.
3399
3400         * gtk/install-dependencies:
3401
3402 2015-07-10  Brent Fulgham  <bfulgham@apple.com>
3403
3404         [Mac] Unable to dismiss context menu during test runs
3405         https://bugs.webkit.org/show_bug.cgi?id=146836
3406
3407         Reviewed by Tim Horton.
3408
3409         Since Context Menus are modal, the test system would block on the displayed context menu,
3410         causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the
3411         mouse click and generate the menu contents, but not ask AppKit to display it.
3412
3413         Drive-by fix: We did not handle 'escape' key presses. This is also fixed.
3414
3415         * DumpRenderTree/mac/EventSendingController.mm:
3416         (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character.
3417         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3418         (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position.
3419         (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then
3420         copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same
3421         work without actually calling on AppKit to display the menu.
3422         ask WebCore to do all the work EXCEPT displaying the menu.
3423         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3424         * WebKitTestRunner/mac/EventSenderProxy.mm:
3425         (WTR::EventSenderProxy::keyDown): Handle the 'escape' character.
3426
3427 2015-07-09  Filip Pizlo  <fpizlo@apple.com>
3428
3429         It should be possible to run the OSR exit fuzzer
3430         https://bugs.webkit.org/show_bug.cgi?id=146814
3431
3432         Reviewed by Mark Lam.
3433         
3434         This runs a test command to detect how many static OSR exit sites it had, and then for
3435         each exit site, it triggers three exits (earliest opportunity, last opportunity, some
3436         middle opportunity), plus a mode where the check always exits. This is an exhaustive
3437         search, so in the future it'll be very appropriate for cases where we have a simple test
3438         and we want to see what happens when you eventually exit in this test.
3439         
3440         Right now this isn't hooked into any specific tests, but I've done some spot checks on it
3441         and it seems to do the right thing.
3442
3443         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz: Added.
3444         (fail):
3445
3446 2015-07-10  Alex Christensen  <achristensen@webkit.org>
3447
3448         Add tests for r186649
3449         https://bugs.webkit.org/show_bug.cgi?id=146821
3450
3451         Reviewed by Darin Adler.
3452
3453         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3454         (TestWebKitAPI::TEST_F):
3455         (TestWebKitAPI::compareContents):
3456         (TestWebKitAPI::expectedIndex):
3457         Add some larger tests to test large jumps.
3458
3459 2015-07-09  Dewei Zhu  <dewei_zhu@apple.com>
3460
3461         Quick fix for run_benchmark script that AppKit.NSRunningApplication does not work properly
3462         https://bugs.webkit.org/show_bug.cgi?id=146820
3463
3464         Reviewed by Ryosuke Niwa.
3465
3466         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3467         (OSXBrowserDriver):
3468         (OSXBrowserDriver.close_browsers):
3469         (OSXBrowserDriver._terminiate_processes):
3470         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3471         (OSXChromeDriver):
3472         (OSXChromeCanaryDriver):
3473         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3474         (OSXFirefoxDriver):
3475         (OSXFirefoxNightlyDriver):
3476         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3477         (OSXSafariDriver):
3478
3479 2015-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3480
3481         [GTK] pango should be included in the default jhbuild moduleset
3482         https://bugs.webkit.org/show_bug.cgi?id=146683
3483
3484         Reviewed by Martin Robinson.
3485
3486         Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when
3487         compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and
3488         fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild
3489         moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have
3490         the same problem again the next time pango wants to use a new fontconfig feature), or remove
3491         fontconfig (which would make it hard to keep tests working). On the balance, adding pango is
3492         best.
3493
3494         * gtk/jhbuild-optional.modules: Remove pango
3495         * gtk/jhbuild.modules: Add pango and update to latest 1.36.8
3496
3497 2015-07-09  Devin Rousso  <drousso@apple.com>
3498
3499         Unreviewed.  Added myself as a committer.
3500
3501         * Scripts/webkitpy/common/config/contributors.json:
3502
3503 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
3504
3505         Add a way to set the default URL from Minibrowser UI
3506         https://bugs.webkit.org/show_bug.cgi?id=146780
3507
3508         Reviewed by Simon Fraser.
3509
3510         * MiniBrowser/mac/AppDelegate.m:
3511         (-[BrowserAppDelegate didChangeSettings]):
3512         * MiniBrowser/mac/BrowserWindowController.h:
3513         * MiniBrowser/mac/BrowserWindowController.m:
3514         (-[BrowserWindowController fetch:]):
3515         (-[BrowserWindowController reload:]):
3516         (-[BrowserWindowController forceRepaint:]):
3517         (-[BrowserWindowController goBack:]):
3518         (-[BrowserWindowController goForward:]):
3519         (-[BrowserWindowController showHideWebView:]):
3520         (-[BrowserWindowController removeReinsertWebView:]):
3521         (-[BrowserWindowController zoomIn:]):
3522         (-[BrowserWindowController zoomOut:]):
3523         (-[BrowserWindowController resetZoom:]):
3524         (-[BrowserWindowController canZoomIn]):
3525         (-[BrowserWindowController canZoomOut]):
3526         (-[BrowserWindowController canResetZoom]):
3527         (-[BrowserWindowController toggleZoomMode:]):
3528         (-[BrowserWindowController setScale:]):
3529         (-[BrowserWindowController toggleShrinkToFit:]):
3530         (-[BrowserWindowController dumpSourceToConsole:]):
3531         (-[BrowserWindowController find:]):
3532         (-[BrowserWindowController didChangeSettings]):
3533         (-[BrowserWindowController currentURL]):
3534         Get rid of the BrowserController protocol. It was a bad idea and confused
3535         Interface Builder more than I thought possible.
3536
3537         * MiniBrowser/mac/SettingsController.m:
3538         (-[SettingsController _populateMenu]):
3539         (-[SettingsController setDefaultURLToCurrentURL:]):
3540         If we have a BrowserWindowController, grab its URL and set the relevant default.
3541
3542         * MiniBrowser/mac/WK1BrowserWindowController.h:
3543         * MiniBrowser/mac/WK1BrowserWindowController.m:
3544         (-[WK1BrowserWindowController currentURL]):
3545         * MiniBrowser/mac/WK2BrowserWindowController.h:
3546         * MiniBrowser/mac/WK2BrowserWindowController.m:
3547         (-[WK2BrowserWindowController currentURL]):
3548         Retrieve the current URL from the WKView/WebView.
3549
3550 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
3551
3552         Increase MiniBrowser location bar maximum width
3553         https://bugs.webkit.org/show_bug.cgi?id=146779
3554
3555         Reviewed by Simon Fraser.
3556
3557         * MiniBrowser/mac/BrowserWindow.xib:
3558         Have an enormous maximum width on the location bar, so that it doesn't
3559         stop expanding with the window at 800px.
3560
3561 2015-07-08  Brady Eidson  <beidson@apple.com>
3562
3563         Crash calling [WebView close] in didFinishLoadForFrame callback.
3564         <rdar://problem/21690765> and https://bugs.webkit.org/show_bug.cgi?id=146773
3565
3566         Reviewed by David Kilzer.
3567
3568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3569         
3570         * TestWebKitAPI/Tests/mac/WebViewCloseInsideDidFinishLoadForFrame.mm: Added.
3571         (-[WebViewCloseFrameLoadDelegate webView:didFinishLoadForFrame:]):
3572         (TestWebKitAPI::TEST):
3573
3574 2015-07-08  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3575
3576         Fix ASSERTION FAILED: !m_pendingNavigationID in WebPage::reload().
3577         https://bugs.webkit.org/show_bug.cgi?id=146546
3578
3579         Reviewed by Darin Adler.
3580
3581         We did't reset pendingNavigationID value when request url is empty.
3582         Hence we need to ignore ASSERT check in this case.
3583
3584         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3585         (TestWebKitAPI::TEST):
3586
3587 2015-07-08  Benjamin Poulain  <bpoulain@apple.com>
3588
3589         [Content Extensions] Fuse undistinguishable actions as much as possible
3590         https://bugs.webkit.org/show_bug.cgi?id=146762
3591
3592         Reviewed by Alex Christensen.
3593
3594         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3595         Test that combinations and flags still work as expected.
3596
3597 2015-07-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3598
3599         [GTK] [Wayland] Allow building and testing the Wayland target with the default JHBuild moduleset.
3600         https://bugs.webkit.org/show_bug.cgi?id=146056
3601
3602         Reviewed by Martin Robinson.
3603
3604         * gtk/install-dependencies: libepoxy is now required for building GTK+.
3605         * gtk/jhbuild-wayland.modules: Removed. Not longer needed.
3606         * gtk/jhbuild.modules: Upgrade GTK+ (3.16.4) and required dependencies for building:
3607         Cairo (1.14.2), Gdk-Pixbuf (2.30.8) and GLib (2.44.1).
3608         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Removed. Not longer needed.
3609         Cairo removed support for LTO on (1.14). Upstream commit: c7ff9bb.
3610         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Removed. Not longer needed.
3611         GTK+ merged this patch on GTK+-3.10. Upstream commit: 8d83d98.
3612
3613 2015-07-06  Matt Rajca  <mrajca@apple.com>
3614
3615         Media Session: propagate metadata changes to UI clients
3616         https://bugs.webkit.org/show_bug.cgi?id=146660
3617
3618         Reviewed by Tim Horton.
3619
3620         * WebKitTestRunner/TestController.cpp: Build fixes for updated PageUIClient.
3621         (WTR::TestController::createOtherPage):
3622         (WTR::TestController::createWebViewWithOptions):
3623
3624 2015-07-07  Brady Eidson  <beidson@apple.com>
3625
3626         HTTP Auth cached after disabling private browsing/reset.
3627         <rdar://problem/8293055> and https://bugs.webkit.org/show_bug.cgi?id=146654
3628
3629         Reviewed by Tim Horton.
3630
3631         * DumpRenderTree/mac/DumpRenderTree.mm:
3632         (resetWebViewToConsistentStateBeforeTesting): Clear in-memory credentials in between test runs.
3633
3634 2015-07-06  Alex Christensen  <achristensen@webkit.org>
3635
3636         [Content Extensions] Remove memory page reporting
3637         https://bugs.webkit.org/show_bug.cgi?id=146659
3638
3639         Reviewed by Benjamin Poulain.
3640
3641         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3642         (TestWebKitAPI::TEST_F):
3643
3644 2015-07-06  Benjamin Poulain  <benjamin@webkit.org>
3645
3646         [Content Extensions] Make the DFA transitions ranges instead of characters
3647         https://bugs.webkit.org/show_bug.cgi?id=146575
3648
3649         Reviewed by Alex Christensen.
3650
3651         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3652         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3653         Since the minimizer is perfect, we get the minimal solution now,
3654         which is really cool!
3655
3656 2015-07-06  Brady Eidson  <beidson@apple.com>
3657
3658         ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads.
3659         <rdar://problem/21640050> and https://bugs.webkit.org/show_bug.cgi?id=146563
3660
3661         Reviewed by Geoff Garen.
3662
3663         * WebKitTestRunner/TestInvocation.cpp:
3664         (WTR::TestInvocation::invoke): For testing purposes, all pages should start with the 
3665           ShouldOpenExternalURLsPolicy set to "ShouldNotAllow"
3666
3667 2015-07-06  Daniel Bates  <dabates@apple.com>
3668
3669         Unreviewed, rolling out r170639.
3670
3671         Broke using webkit-patch apply-attachment to apply an
3672         attachment from a security bug. The patch incorrectly assumed
3673         that Bugzilla returns a non-HTTP 200 status code in its HTTP
3674         response when authentication is required.
3675
3676         Reverted changeset:
3677
3678         "webkit-patch apply-from-bug / apply-attachment should not ask
3679         for credentials if none are required"
3680         https://bugs.webkit.org/show_bug.cgi?id=40095
3681         http://trac.webkit.org/changeset/170639
3682
3683 2015-07-04  Chris Dumez  <cdumez@apple.com>
3684
3685         Drop RefPtr::clear() method
3686         https://bugs.webkit.org/show_bug.cgi?id=146556
3687
3688         Reviewed by Brady Eidson.
3689
3690         Drop RefPtr::clear() method in favor of "= nullptr;" pattern.
3691
3692 2015-07-03  Dan Bernstein  <mitz@apple.com>
3693
3694         Fixed the iOS build.
3695
3696         * DumpRenderTree/mac/EventSendingController.mm:
3697         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3698         (+[EventSendingController webScriptNameForSelector:]):
3699
3700 2015-07-03  Dan Bernstein  <mitz@apple.com>
3701
3702         [Xcode] Update some build settings as recommended by Xcode 7
3703         https://bugs.webkit.org/show_bug.cgi?id=146597
3704
3705         Reviewed by Sam Weinig.
3706
3707         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
3708
3709         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
3710         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
3711         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
3712         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
3713         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
3714
3715         * DumpRenderTree/mac/EventSendingController.mm:
3716         (+[EventSendingController webScriptNameForSelector:]): Removed check for setDragMode:,
3717         which was removed in r19101.
3718
3719         * DumpRenderTree/mac/TextInputController.m:
3720         (-[TextInputController interpretKeyEvents:withSender:]): Suppressed -Wundeclared-selector
3721         around used of a selector not that is not declared anywhere.
3722
3723         * MiniBrowser/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS.
3724
3725         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
3726
3727         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
3728         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
3729         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
3730         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
3731         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
3732
3733         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
3734
3735 2015-07-02  Daniel Bates  <dabates@apple.com>
3736
3737         [iOS] Add WebKitSystemInterface for iOS 8.4
3738         https://bugs.webkit.org/show_bug.cgi?id=146548
3739
3740         Rubber-stamped by Zalan Bujtas.
3741
3742         * Scripts/copy-webkitlibraries-to-product-directory:
3743
3744 2015-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3745
3746         [GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
3747         https://bugs.webkit.org/show_bug.cgi?id=146234
3748
3749         Reviewed by Sergio Villar Senin.
3750
3751         Enable the WebSQL directory test that was disabled because of this bug.
3752
3753         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3754         (testWebContextConfiguration):
3755
3756 2015-07-01  Matthew Daiter  <mdaiter@apple.com>
3757
3758         Enabled MEDIA_STREAM flag
3759         https://bugs.webkit.org/show_bug.cgi?id=145947
3760         <rdar://problem/21365829>
3761         
3762         Reviewed by Eric Carlson.
3763
3764         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3765
3766 2015-06-30  Martin Robinson  <mrobinson@igalia.com>
3767
3768         [GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936
3769         https://bugs.webkit.org/show_bug.cgi?id=144828
3770
3771         Reviewed by Carlos Garcia Campos.
3772
3773         * WebKitTestRunner/gtk/main.cpp:
3774         (main): Use the new WKTextChecker API to set the spell checking languages
3775         when the process is starting up.
3776
3777 2015-06-30  Andy VanWagoner  <thetalecrafter@gmail.com>
3778
3779         Implement ECMAScript Internationalization API
3780         https://bugs.webkit.org/show_bug.cgi?id=90906
3781
3782         Reviewed by Benjamin Poulain.
3783
3784         * Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag
3785
3786 2015-06-30  Jonathan Davis  <jond@apple.com>
3787
3788         Unreviewed. Added myself as a committer.
3789
3790         * Scripts/webkitpy/common/config/contributors.json:
3791
3792 2015-06-30  Brent Fulgham  <bfulgham@apple.com>
3793
3794         Unreviewed build fix.
3795
3796         * Scripts/update-webkit-dependency: Try to build even if we cannot connect
3797         to developer.apple.com to get update libraries.
3798
3799 2015-06-29  Jake Nielsen  <jacob_nielsen@apple.com>
3800
3801         Add timeout in run-webkit-tests for launching the simulator
3802         https://bugs.webkit.org/show_bug.cgi?id=146371
3803
3804         Reviewed by Darin Adler.
3805
3806         Adds a default 5-minute timeout using the timeout class in webkitpy.benchmark_runner.utils
3807         for the otherwise infinitely patient wait_until_device_is_in_state method.
3808
3809         * Scripts/webkitpy/xcode/simulator.py:
3810         (Simulator.DeviceState):
3811         (Simulator):
3812         (Simulator.wait_until_device_is_in_state):
3813         (Simulator.device_state):
3814
3815 2015-06-29  Benjamin Poulain  <benjamin@webkit.org>
3816
3817         Make the NFA transitions range-based
3818         https://bugs.webkit.org/show_bug.cgi?id=146338
3819
3820         Reviewed by Alex Christensen.
3821
3822         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3823         Test some new interesting cases.
3824
3825 2015-06-28  Dan Bernstein  <mitz@apple.com>
3826
3827         [Xcode] Use the same environment for command-line and IDE builds
3828         https://bugs.webkit.org/show_bug.cgi?id=146401
3829
3830         Reviewed by Anders Carlsson.
3831
3832         * Scripts/webkitdirs.pm:
3833         (XcodeOptions): Set the UseSanitizedBuildSystemEnvironment user default to YES, which makes
3834         xcodebuild use the same environment Xcode uses.
3835
3836 2015-06-28  Dan Bernstein  <mitz@apple.com>
3837
3838         REGRESSION (r185915): Source-incompatible change in WKPageUIClient
3839         https://bugs.webkit.org/show_bug.cgi?id=146396
3840
3841         Reviewed by Anders Carlsson.
3842
3843         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3844         (TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name.
3845         (TestWebKitAPI::TEST): Updated for renames.
3846         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3847         (runJavaScriptAlert): Removed suffix.
3848         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated.
3849         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3850         (runJavaScriptAlert): Removed suffix.
3851         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated.
3852
3853 2015-06-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3854
3855         [GTK][SOUP] Implement WebCore::PublicSuffix for soup and enable PUBLIC_SUFFIX_LIST for GTK+
3856         https://bugs.webkit.org/show_bug.cgi?id=146318
3857
3858         Reviewed by Sergio Villar Senin.
3859
3860         Copy mac PublicSuffix test to the common directory and add it to
3861         the GTK+ build.
3862
3863         * TestWebKitAPI/PlatformGTK.cmake:
3864         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: Added.
3865         (TestWebKitAPI::TEST_F):
3866
3867 2015-06-26  Per Arne Vollan  <peavo@outlook.com>
3868
3869         WinLauncher fails to download files.
3870         https://bugs.webkit.org/show_bug.cgi?id=146242
3871
3872         Reviewed by Alex Christensen.
3873
3874         Added WinLauncher download delegate.
3875
3876         * WinLauncher/Common.cpp:
3877         * WinLauncher/WebDownloadDelegate.cpp: Added.
3878         (WebDownloadDelegate::WebDownloadDelegate):
3879         (WebDownloadDelegate::~WebDownloadDelegate):
3880         (WebDownloadDelegate::QueryInterface):
3881         (WebDownloadDelegate::AddRef):
3882         (WebDownloadDelegate::Release):
3883         (WebDownloadDelegate::decideDestinationWithSuggestedFilename):
3884         (WebDownloadDelegate::didCancelAuthenticationChallenge):
3885         (WebDownloadDelegate::didCreateDestination):
3886         (WebDownloadDelegate::didFailWithError):
3887         (WebDownloadDelegate::didReceiveAuthenticationChallenge):
3888         (WebDownloadDelegate::didReceiveDataOfLength):
3889         (WebDownloadDelegate::didReceiveResponse):
3890         (WebDownloadDelegate::shouldDecodeSourceDataOfMIMEType):
3891         (WebDownloadDelegate::willResumeWithResponse):
3892         (WebDownloadDelegate::willSendRequest):
3893         (WebDownloadDelegate::didBegin):
3894         (WebDownloadDelegate::didFinish):
3895         * WinLauncher/WebDownloadDelegate.h: Added.
3896         * WinLauncher/WinLauncher.cpp:
3897         (WinLauncher::setAccessibilityDelegate):
3898         (WinLauncher::setResourceLoadDelegate):
3899         (WinLauncher::setDownloadDelegate):
3900         (WinLauncher::mainFrame):
3901         * WinLauncher/WinLauncher.h:
3902         (WinLauncher::standardPreferences):
3903         (WinLauncher::privatePreferences):
3904         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3905         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3906         * WinLauncher/WinMain.cpp:
3907         (wWinMain):
3908
3909 2015-06-26  Csaba Osztrogonác  <ossy@webkit.org>
3910
3911         [EFL] Bump libseccomp version to 2.2.1
3912         https://bugs.webkit.org/show_bug.cgi?id=146341
3913
3914         Reviewed by Gyuyoung Kim.
3915
3916         * efl/jhbuild.modules:
3917         * efl/jhbuildrc: Enabled libseccomp build on AArch64.
3918         * efl/patches/libseccomp-pick-up-CC.patch: Removed, we don't need it anymore.
3919
3920 2015-06-25  Alex Christensen  <achristensen@webkit.org>
3921
3922         [Content Extensions] Add a way to match a domain but not subdomains
3923         https://bugs.webkit.org/show_bug.cgi?id=146241
3924         rdar://problem/21557754
3925
3926         Reviewed by Darin Adler.
3927
3928         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3929         (TestWebKitAPI::TEST_F):
3930         Update subdomain test because of changed behavior and add test for new '*' functionality.
3931
3932 2015-06-25  Jaehun Lim  <ljaehun.lim@samsung.com>
3933
3934         Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes.
3935         https://bugs.webkit.org/show_bug.cgi?id=146308
3936
3937         Reviewed by Csaba Osztrogonác.
3938
3939         ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
3940
3941         * Scripts/webkitperl/FeatureList.pm:
3942
3943 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3944
3945         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
3946         https://bugs.webkit.org/show_bug.cgi?id=146149
3947
3948         Reviewed by Sergio Villar Senin.
3949
3950         Update unit tests to use WebKitWebsiteDataManager.
3951
3952         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3953         (testWebContextConfiguration):
3954         (serverCallback):
3955         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3956         (Test::Test): Use WebKitWebsiteDataManager and set all possible
3957         values to ensure unit tests don't write outside the temporary directory.
3958         (Test::~Test): Explicitly reset the web context to ensure its
3959         objects are released before the leaks check.
3960         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3961         (WebViewTest::wait): Fix the GSource used, since we are receiving
3962         a double in seconds, but using g_timeout_add_seconds() that
3963         expects an unsigned in seconds. Use GMainLoopSource to correctly
3964         handle the value and simplify the code.
3965
3966 2015-06-24  Jason Marcell  <jmarcell@apple.com>
3967
3968         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
3969         https://bugs.webkit.org/show_bug.cgi?id=146126
3970         <rdar://problem/18226291>
3971
3972         Reviewed by Alexey Proskuryakov.
3973
3974         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3975         (documentReady): Using combined queues to display iOS projects
3976
3977 2015-06-24  Doug Russell  <d_russell@apple.com>
3978
3979         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject 
3980         when posting a selection notification when on the border between two accessibilityObjects
3981         https://bugs.webkit.org/show_bug.cgi?id=146177
3982
3983         Reviewed by Darin Adler.
3984
3985         Add support for mapping WebCore Accessibility types into JSValueRef types
3986         so they can be used in tests.
3987
3988         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3989         (webAccessibilityObjectWrapperClass):
3990         (-[AccessibilityNotificationHandler startObserving]):
3991         (makeValueRefForValue):
3992         (makeArrayRefForArray):
3993         (makeObjectRefForDictionary):
3994         (-[AccessibilityNotificationHandler _notificationReceived:]):
3995         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3996         (webAccessibilityObjectWrapperClass):
3997         (-[AccessibilityNotificationHandler startObserving]):
3998         (makeValueRefForValue):
3999         (makeArrayRefForArray):
4000         (makeObjectRefForDictionary):
4001         (-[AccessibilityNotificationHandler _notificationReceived:]):
4002
4003 2015-06-24  Zalan Bujtas  <zalan@apple.com>
4004
4005         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
4006         https://bugs.webkit.org/show_bug.cgi?id=146273
4007         rdar://problem/18509840
4008
4009         Reviewed by Simon Fraser.
4010
4011         Due to the floating point approximate representation, we can't always produce
4012         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
4013         and by changing the rounding in roundToDevicePixel() from float to double.
4014
4015         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
4016         (TestWebKitAPI::TEST):
4017
4018 2015-06-24  Brady Eidson  <beidson@apple.com>
4019
4020         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
4021         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
4022
4023         Reviewed by Alex Christensen.
4024
4025         - Update WKTR to the new client structure.
4026         - Update existing TestWebKitAPI tests to either use the new client structure or
4027           assign the old function signature to the updated variable name.
4028         - Include a new test.
4029
4030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4031
4032         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
4033         (TestWebKitAPI::runJavaScriptAlert):
4034
4035         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
4036         (TestWebKitAPI::TEST):
4037
4038         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
4039         (TestWebKitAPI::analyzeDialogArguments):
4040         (TestWebKitAPI::runJavaScriptAlert):
4041         (TestWebKitAPI::runJavaScriptConfirm):
4042         (TestWebKitAPI::runJavaScriptPrompt):
4043         (TestWebKitAPI::createNewPage):
4044         (TestWebKitAPI::TEST):
4045
4046         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
4047         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
4048
4049         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
4050         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
4051
4052         * WebKitTestRunner/TestController.cpp:
4053         (WTR::TestController::createOtherPage):
4054         (WTR::TestController::createWebViewWithOptions):
4055
4056 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
4057
4058         Refactoring benchmark runner script to follow pep8 code style.
4059         https://bugs.webkit.org/show_bug.cgi?id=146264
4060
4061         Reviewed by Ryosuke Niwa.
4062
4063         Refactor benchmark runner script to follow pep8 code style.
4064
4065         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
4066         (GenericBenchmarkBuilder.prepare):
4067         (GenericBenchmarkBuilder._run_create_script):
4068         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
4069         (GenericBenchmarkBuilder._fetch_remote_archive):
4070         (GenericBenchmarkBuilder):
4071         (GenericBenchmarkBuilder._checkout_with_subversion):
4072         (GenericBenchmarkBuilder._apply_patch):
4073         (GenericBenchmarkBuilder.clean):
4074         (GenericBenchmarkBuilder._runCreateScript): Deleted.
4075         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
4076         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
4077         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
4078         (GenericBenchmarkBuilder._applyPatch): Deleted.
4079         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
4080         (BenchmarkRunner.__init__):
4081         (BenchmarkRunner._find_plan_file):
4082         (BenchmarkRunner.execute):
4083         (BenchmarkRunner._cleanup):
4084         (BenchmarkRunner._dump):
4085         (BenchmarkRunner._wrap):
4086         (BenchmarkRunner._merge):
4087         (BenchmarkRunner._show_results):
4088         (BenchmarkRunner._findPlanFile): Deleted.
4089         (BenchmarkRunner.cleanup): Deleted.
4090         (BenchmarkRunner.dump): Deleted.
4091         (BenchmarkRunner.wrap): Deleted.
4092         (BenchmarkRunner.merge): Deleted.
4093         (BenchmarkRunner.show_results): Deleted.
4094         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
4095         (BrowserDriver.prepare_env):
4096         (BrowserDriver.launch_url):
4097         (BrowserDriver.close_browsers):
4098         (BrowserDriver.prepareEnv): Deleted.
4099         (BrowserDriver.launchUrl): Deleted.
4100         (BrowserDriver.closeBrowser): Deleted.
4101         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
4102         (OSXBrowserDriver):
4103         (OSXBrowserDriver.prepare_env):
4104         (OSXBrowserDriver.close_browsers):
4105         (OSXBrowserDriver._launch_process):
4106         (OSXBrowserDriver._terminiate_processes):
4107         (OSXBrowserDriver._launch_process_with_caffinate):
4108         (OSXBrowserDriver._screen_size):
4109         (OSXBrowserDriver.prepareEnv): Deleted.
4110         (OSXBrowserDriver.closeBrowsers): Deleted.
4111         (OSXBrowserDriver.launchProcess): Deleted.
4112         (OSXBrowserDriver.terminateProcesses): Deleted.
4113         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
4114         (OSXBrowserDriver.screenSize): Deleted.
4115         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
4116         (OSXChromeDriver):
4117         (OSXChromeDriver.launch_url):
4118         (OSXChromeCanaryDriver):
4119         (OSXChromeCanaryDriver.launch_url):
4120         (OSXChromeDriver.launchUrl): Deleted.
4121         (OSXChromeCanaryDriver.launchUrl): Deleted.
4122         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
4123         (OSXFirefoxDriver):
4124         (OSXFirefoxDriver.launch_url):
4125         (OSXFirefoxNightlyDriver):
4126         (OSXFirefoxNightlyDriver.launch_url):
4127         (OSXFirefoxDriver.launchUrl): Deleted.
4128         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
4129         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
4130         (OSXSafariDriver):
4131         (OSXSafariDriver.prepare_env):
4132         (OSXSafariDriver.launch_url):
4133         (OSXSafariDriver.close_browsers):
4134         (OSXSafariDriver._maximize_window):
4135         (OSXSafariDriver.prepareEnv): Deleted.
4136         (OSXSafariDriver.launchUrl): Deleted.
4137         (OSXSafariDriver.closeBrowsers): Deleted.
4138         (OSXSafariDriver.maximizeWindow): Deleted.
4139         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
4140         (HTTPServerDriver.fetch_result):
4141         (HTTPServerDriver.kill_server):
4142         (HTTPServerDriver.get_return_code):
4143         (HTTPServerDriver.set_device_id):
4144         (HTTPServerDriver.fetchResult): Deleted.
4145         (HTTPServerDriver.killServer): Deleted.
4146         (HTTPServerDriver.getReturnCode): Deleted.
4147         (HTTPServerDriver.setDeviceID): Deleted.
4148         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
4149         (SimpleHTTPServerDriver.serve):
4150         (SimpleHTTPServerDriver.base_url):
4151         (SimpleHTTPServerDriver.fetch_result):
4152         (SimpleHTTPServerDriver.kill_server):
4153         (SimpleHTTPServerDriver.get_return_code):
4154         (SimpleHTTPServerDriver): Deleted.
4155         (SimpleHTTPServerDriver.baseUrl): Deleted.
4156         (SimpleHTTPServerDriver.fetchResult): Deleted.
4157         (SimpleHTTPServerDriver.killServer): Deleted.
4158         (SimpleHTTPServerDriver.getReturnCode): Deleted.
4159         * Scripts/webkitpy/benchmark_runner/utils.py:
4160         (get_path_from_project_root):
4161         (force_remove):
4162         (getPathFromProjectRoot): Deleted.
4163         (forceRemove): Deleted.
4164
4165 2015-06-23  Anders Carlsson  <andersca@apple.com>
4166
4167         Add operator! and copy/move constructors to WeakObjCPtr
4168         https://bugs.webkit.org/show_bug.cgi?id=146255
4169
4170         Reviewed by Andreas Kling.
4171
4172         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
4173         (TEST):
4174
4175 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
4176
4177         Expose some more rendering progress events, and have MiniBrowser log for each of them
4178         https://bugs.webkit.org/show_bug.cgi?id=146227
4179
4180         Reviewed by Darin Adler.
4181
4182         Register for layout milestones/rendering progress events in the WK1 and WK2
4183         browser window controllers, and, if logging is turned on, log when they are
4184         reached.
4185
4186         * MiniBrowser/mac/WK1BrowserWindowController.m:
4187         (-[WK1BrowserWindowController awakeFromNib]):
4188         (-[WK1BrowserWindowController webView:didLayout:]):
4189         * MiniBrowser/mac/WK2BrowserWindowController.m:
4190         (-[WK2BrowserWindowController awakeFromNib]):
4191         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
4192
4193 2015-06-23  Brady Eidson  <beidson@apple.com>
4194
4195         WKFrameInfo should have an accessor for the Frame's current security origin.
4196         https://bugs.webkit.org/show_bug.cgi?id=146162
4197
4198         Reviewed by Dan Bernstein.
4199
4200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4201         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
4202         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
4203         (sawDialog):
4204         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
4205         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4206         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
4207         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
4208         (TEST):
4209
4210 2015-06-23  Tanay C  <tanay.c@samsung.com>
4211
4212         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
4213         https://bugs.webkit.org/show_bug.cgi?id=146007
4214
4215         Reviewed by Darin Adler.
4216
4217         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
4218         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
4219         (pluginLogWithWindowObject):
4220         (pluginLogWithArguments):
4221         (pluginLog):
4222         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
4223         (PluginTest::executeScript):
4224         (PluginTest::log):
4225
4226 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
4227
4228         [EFL] Add libhyphen-dev as dependency after r185862
4229         https://bugs.webkit.org/show_bug.cgi?id=146230
4230
4231         Reviewed by Gyuyoung Kim.
4232
4233         * efl/install-dependencies:
4234
4235 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
4236
4237         [EFL] Hyphenation is not supported
4238         https://bugs.webkit.org/show_bug.cgi?id=89830
4239
4240         Reviewed&n