EWS bots don't remove untracked files after processing a patch
[WebKit-https.git] / Tools / ChangeLog
1 2013-02-04  Alan Cutter  <alancutter@chromium.org>
2
3         EWS bots don't remove untracked files after processing a patch
4         https://bugs.webkit.org/show_bug.cgi?id=108891
5
6         Reviewed by Adam Barth.
7
8         Added option to remove untracked files in the bot's repo.
9
10         * EWSTools/start-queue.sh:
11
12 2013-02-04  Benjamin Poulain  <bpoulain@apple.com>
13
14         Kill suspendAnimation(), resumeAnimation() and numberOfActiveAnimations() from DRT/WTR; use Internals
15         https://bugs.webkit.org/show_bug.cgi?id=108741
16
17         Reviewed by Tony Chang.
18
19         Remove all support for suspendAnimation(), resumeAnimation() and numberOfActiveAnimations().
20
21         * DumpRenderTree/TestRunner.cpp:
22         (TestRunner::staticFunctions):
23         * DumpRenderTree/TestRunner.h:
24         (TestRunner):
25         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
26         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
27         (WebTestRunner::TestRunner::TestRunner):
28         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
29         (TestRunner):
30         * DumpRenderTree/efl/TestRunnerEfl.cpp:
31         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
32         * DumpRenderTree/mac/TestRunnerMac.mm:
33         * DumpRenderTree/qt/TestRunnerQt.cpp:
34         * DumpRenderTree/qt/TestRunnerQt.h:
35         (TestRunner):
36         * DumpRenderTree/win/TestRunnerWin.cpp:
37         * DumpRenderTree/wx/TestRunnerWx.cpp:
38         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
39         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
40         * WebKitTestRunner/InjectedBundle/TestRunner.h:
41         (TestRunner):
42
43 2013-02-04  Nico Weber  <thakis@chromium.org>
44
45         [chromium] Try to get WebKit building with enable_web_intents set to 0 on Windows too.
46         https://bugs.webkit.org/show_bug.cgi?id=108887
47
48         Reviewed by Kentaro Hara.
49
50         This is a follow-up to http://trac.webkit.org/changeset/141614. The
51         Mac and Linux linkers didn't complain about the reference to
52         WebIntent in that function for some reason (probably because it's
53         a dead function that's stripped).
54
55         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
56         (WebTestRunner):
57         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
58         (TestRunner):
59
60 2013-02-04  Julie Parent  <jparent@chromium.org>
61
62         Dashboard cleanup: Make builder a real dashboardSpecificParameter.
63         https://bugs.webkit.org/show_bug.cgi?id=108706
64
65         Reviewed by Dirk Pranke.
66         
67         Add builder to g_defaultDashboardSpecificParameter maps for the
68         dashboards where it is used (flakiness, timeline, treemap).
69         Default it to null, and then update reads of it to check the
70         builder group's default if one is not set, rather than trying to
71         set and track this everywhere.
72         This allows us to remove tons of special-casing of builder parsing,
73         including where we used to add it to the query string even when the
74         user did not specify it.
75
76         * TestResultServer/static-dashboards/dashboard_base.js:
77         (parseParameters):
78         * TestResultServer/static-dashboards/flakiness_dashboard.js:
79         (generatePage):
80         (handleQueryParameterChange):
81         * TestResultServer/static-dashboards/loader.js:
82         (.):
83         * TestResultServer/static-dashboards/timeline_explorer.html:
84         * TestResultServer/static-dashboards/treemap.html:
85
86 2013-02-04  Julie Parent  <jparent@chromium.org>
87
88         Setting tests on flakiness dashboard should invalidate builder.
89         https://bugs.webkit.org/show_bug.cgi?id=108521
90
91         Reviewed by Dirk Pranke.
92         
93         When you move into a cross builder view, builder should not still be
94         set.  Currently, it is deleted from the internal state, but still shows
95         up in the url, causing the current state and the hash to not match.
96         
97         To see this in action, load the flakiness dashboard, select a builder,
98         and then click on an individual test, to get into individual test view.
99         The url will still have the builder you selected listed, even though it
100         is cleared in the UI.
101         
102         The fix is to consider 'tests' to be a parameter that invalidates builder.
103
104         * TestResultServer/static-dashboards/flakiness_dashboard.js:
105
106 2013-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
107
108         [EFL][WK2] Introduce a WebView class as counterpart for WKViewRef
109         https://bugs.webkit.org/show_bug.cgi?id=107931
110
111         Reviewed by Anders Carlsson.
112
113         Change platformView to be a WKView and use WKViewGetEvasObject
114         for the places where an Evas_Object is needed.
115
116         Instead of extracting the Ecore_Evas* from the m_view we use
117         the m_window instead, which actually holds the it.
118
119         * TestWebKitAPI/PlatformWebView.h:
120         * TestWebKitAPI/efl/PlatformWebView.cpp:
121         (TestWebKitAPI::PlatformWebView::PlatformWebView):
122         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
123         (TestWebKitAPI::PlatformWebView::resizeTo):
124         (TestWebKitAPI::PlatformWebView::page):
125         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
126         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
127         (TestWebKitAPI::PlatformWebView::simulateRightClick):
128         * WebKitTestRunner/PlatformWebView.h:
129         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
130         (WTR::EventSenderProxy::sendTouchEvent):
131         (WTR::EventSenderProxy::setTouchModifier):
132         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
133         (WTR::PlatformWebView::PlatformWebView):
134         (WTR::PlatformWebView::~PlatformWebView):
135         (WTR::PlatformWebView::resizeTo):
136         (WTR::PlatformWebView::page):
137         (WTR::PlatformWebView::focus):
138         (WTR::PlatformWebView::windowFrame):
139         (WTR::PlatformWebView::setWindowFrame):
140         (WTR::PlatformWebView::windowSnapshotImage):
141
142 2013-02-04  Timothy Loh  <timloh@chromium.com>
143
144         Don't update author info in PrepareChangeLog and allow users to skip the PrepareChangeLog step entirely.
145         https://bugs.webkit.org/show_bug.cgi?id=108788
146
147         Reviewed by Ryosuke Niwa.
148
149         As per discussion in Bug 74358, it's probably preferable to remove the
150         behaviour of updating the author details in a ChangeLog entry. We also
151         want to be able to skip preparing change logs (e.g. rebaselining many
152         tests), so a --no-prepare-changelogs option is added to webkit-patch.
153
154         * Scripts/webkitpy/common/checkout/changelog.py:
155         (ChangeLogEntry._parse_entry):
156         (ChangeLogEntry.date): Added
157         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
158         (test_parse_log_entries_from_changelog):
159         * Scripts/webkitpy/tool/commands/commandtest.py:
160         (CommandsTest.assert_execute_outputs):
161         * Scripts/webkitpy/tool/steps/options.py:
162         (Options): Added --no-prepare-changelogs
163         * Scripts/webkitpy/tool/steps/preparechangelog.py:
164         (PrepareChangeLog.options):
165         (PrepareChangeLog._merge_entries): date_line() gets the entire line, including
166         the author's name and email, but we only want to replace the date.
167         (PrepareChangeLog.run):
168         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
169         (PrepareChangeLogTest.test_resolve_existing_entry): Added tests for changed
170         authors. Removed unneeded variable.
171
172 2013-02-04  Jochen Eisinger  <jochen@chromium.org>
173
174         [chromium] Remove WebEventSender and WebAccessibilityController from public TestRunner API
175         https://bugs.webkit.org/show_bug.cgi?id=108467
176
177         Reviewed by Adam Barth.
178
179         * DumpRenderTree/DumpRenderTree.gypi:
180         * DumpRenderTree/chromium/TestRunner/public/WebAccessibilityController.h: Removed.
181         * DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: Removed.
182         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
183         (WebTestRunner):
184         (WebTestInterfaces):
185         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
186         (WebTestRunner):
187         (WebTestProxyBase):
188         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
189         (WebTestRunner):
190         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
191         (WebTestRunner):
192         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
193         (WebTestRunner::TestInterfaces::TestInterfaces):
194         (WebTestRunner::TestInterfaces::setWebView):
195         (WebTestRunner::TestInterfaces::webView):
196         (WebTestRunner):
197         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
198         (TestInterfaces):
199         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
200         (TestRunner):
201         * DumpRenderTree/chromium/TestRunner/src/WebAccessibilityController.cpp: Removed.
202         * DumpRenderTree/chromium/TestRunner/src/WebEventSender.cpp: Removed.
203         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
204         (WebTestRunner::WebTestInterfaces::WebTestInterfaces):
205         (WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
206         (WebTestRunner::WebTestInterfaces::setWebView):
207         (WebTestRunner::WebTestInterfaces::setDelegate):
208         (WebTestRunner::WebTestInterfaces::bindTo):
209         (WebTestRunner::WebTestInterfaces::resetAll):
210         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
211         (WebTestRunner::WebTestInterfaces::webView):
212         (WebTestRunner::WebTestInterfaces::testRunner):
213         (WebTestRunner::WebTestInterfaces::testInterfaces):
214         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
215         (WebTestRunner::WebTestProxyBase::setInterfaces):
216         * DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Removed.
217         * DumpRenderTree/chromium/TestShell.h:
218         * DumpRenderTree/chromium/WebViewHost.cpp:
219         * DumpRenderTree/chromium/WebViewHost.h:
220
221 2013-02-04  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
222
223         [EFL] Add "full screen" parameter to MiniBrowser
224         https://bugs.webkit.org/show_bug.cgi?id=108850
225
226         Reviewed by Antonio Gomes.
227
228         Implements the {-F,--full-screen}={true,false} parameter to WebKit EFL's
229         MiniBrowser.
230
231         * MiniBrowser/efl/main.c:
232         (window_create):
233         (elm_main):
234         Added '-F/--full-screen' parameter functionality.
235
236 2013-02-04  Jochen Eisinger  <jochen@chromium.org>
237
238         [chromium] remove WebTestPlugin from the public TestRunner API
239         https://bugs.webkit.org/show_bug.cgi?id=108467
240
241         Reviewed by Adam Barth.
242
243         * DumpRenderTree/DumpRenderTree.gypi:
244         * DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h: Removed.
245         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
246         (WebKit):
247         (WebTestProxyBase):
248         (WebTestRunner::WebTestProxy::createPlugin):
249         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp.
250         (WebTestRunner::TestPlugin::TestPlugin):
251         (WebTestRunner):
252         (WebTestRunner::TestPlugin::~TestPlugin):
253         (WebTestRunner::TestPlugin::initialize):
254         (WebTestRunner::TestPlugin::destroy):
255         (WebTestRunner::TestPlugin::updateGeometry):
256         (WebTestRunner::TestPlugin::parsePrimitive):
257         (WebTestRunner::TestPlugin::parseColor):
258         (WebTestRunner::TestPlugin::parseOpacity):
259         (WebTestRunner::TestPlugin::parseBoolean):
260         (WebTestRunner::TestPlugin::initScene):
261         (WebTestRunner::TestPlugin::drawScene):
262         (WebTestRunner::TestPlugin::destroyScene):
263         (WebTestRunner::TestPlugin::initProgram):
264         (WebTestRunner::TestPlugin::initPrimitive):
265         (WebTestRunner::TestPlugin::drawPrimitive):
266         (WebTestRunner::TestPlugin::loadShader):
267         (WebTestRunner::TestPlugin::loadProgram):
268         (WebTestRunner::TestPlugin::handleInputEvent):
269         (WebTestRunner::TestPlugin::handleDragStatusUpdate):
270         (WebTestRunner::TestPlugin::create):
271         (WebTestRunner::TestPlugin::mimeType):
272         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Added.
273         (WebTestRunner):
274         (TestPlugin):
275         (WebTestRunner::TestPlugin::scriptableObject):
276         (WebTestRunner::TestPlugin::canProcessDrag):
277         (WebTestRunner::TestPlugin::paint):
278         (WebTestRunner::TestPlugin::updateFocus):
279         (WebTestRunner::TestPlugin::updateVisibility):
280         (WebTestRunner::TestPlugin::acceptsInputEvents):
281         (WebTestRunner::TestPlugin::didReceiveResponse):
282         (WebTestRunner::TestPlugin::didReceiveData):
283         (WebTestRunner::TestPlugin::didFinishLoading):
284         (WebTestRunner::TestPlugin::didFailLoading):
285         (WebTestRunner::TestPlugin::didFinishLoadingFrameRequest):
286         (WebTestRunner::TestPlugin::didFailLoadingFrameRequest):
287         (WebTestRunner::TestPlugin::isPlaceholder):
288         (WebTestRunner::TestPlugin::prepareTexture):
289         (WebTestRunner::TestPlugin::context):
290         (Scene):
291         (WebTestRunner::TestPlugin::Scene::Scene):
292         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
293         (WebTestRunner::WebTestProxyBase::createPlugin):
294         (WebTestRunner):
295         * DumpRenderTree/chromium/WebViewHost.cpp:
296         (WebViewHost::createPlugin):
297
298 2013-02-04  Gustavo Noronha Silva  <gns@gnome.org>
299
300         Add a new method for obtaining a build-type-dependent path,
301         instead of modifying all call sites to pass it in.
302
303         Reviewed by Martin Robinson.
304
305         * Scripts/run-gtk-tests:
306         (TestRunner.__init__): use the new method, which takes a tuple.
307         (TestRunner._setup_testing_environment): ditto.
308         * gtk/common.py:
309         (get_build_path): accept a tuple that may include Release and
310         Debug as build types, for searching.
311         (build_path_for_build_types): new method that finds the path when
312         it is dependent on the build type.
313         (build_path): restore its original behaviour.
314
315 2013-02-04  David Kilzer  <ddkilzer@apple.com>
316
317         Remove duplicate entry from DumpRenderTree Xcode project
318
319             $ uniq Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | diff -u - Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | patch -p0 -R
320             patching file Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
321
322         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
323         Remove duplicate.
324
325 2013-02-04  David Kilzer  <ddkilzer@apple.com>
326
327         Sort TestWebKitAPI Xcode project file
328
329         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
330
331 2013-02-03  Alan Cutter  <alancutter@chromium.org>
332
333         PatchLogs are not getting created on QueueStatusServer
334         https://bugs.webkit.org/show_bug.cgi?id=108593
335
336         Reviewed by Eric Seidel.
337
338         Added missing "added" patch event to submit-to-ews handler.
339
340         * QueueStatusServer/app.yaml:
341         * QueueStatusServer/handlers/submittoews.py:
342         (SubmitToEWS._add_attachment_to_ews_queues):
343
344 2013-02-03  Douglas Stockwell  <dstockwell@chromium.org>
345
346         Unreviewed. Add dstockwell as a contributor in comitters.py and to the watchlist for animation
347         https://bugs.webkit.org/show_bug.cgi?id=108777
348
349         * Scripts/webkitpy/common/config/committers.py:
350         * Scripts/webkitpy/common/config/watchlist:
351
352 2013-02-03  Sam Weinig  <sam@webkit.org>
353
354         Fix failing test.
355
356         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
357         (TestWebKitAPI::didFinishLoadForFrame):
358
359 2013-02-03  Timothy Loh  <timloh@chromium.com>
360
361         Make ChangeLogEntry detect annotations by prepare-ChangeLog (Added/Removed/Copied from/Renamed from) as clean.
362         https://bugs.webkit.org/show_bug.cgi?id=108433
363
364         Reviewed by Eric Seidel.
365
366         PrepareChangeLog is supposed to update the file/function list if we
367         haven't touched it, but the existing regex doesn't handle the
368         annotations prepare-ChangeLog adds (e.g. "Added.")
369
370         * Scripts/webkitpy/common/checkout/changelog.py:
371         (ChangeLogEntry.is_touched_files_text_clean):
372         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
373         (test_is_touched_files_text_clean):
374
375 2013-02-02  Dean Jackson  <dino@apple.com>
376
377         Add Antoine Quint to the list of committers
378         https://bugs.webkit.org/show_bug.cgi?id=108750
379
380         No review necessary.
381
382         * Scripts/webkitpy/common/config/committers.py:
383
384 2013-02-02  Patrick Gansterer  <paroga@webkit.org>
385
386         [CMake] Adopt the WinCE port to new CMake
387         https://bugs.webkit.org/show_bug.cgi?id=108754
388
389         Reviewed by Laszlo Gombos.
390
391         * WinCELauncher/CMakeLists.txt: Mark WinCELauncher
392         as WIN32 target to use the correct entry point.
393
394 2013-02-02  Alexey Proskuryakov  <ap@apple.com>
395
396         One is not allowed to use commit-queue to make oneself a committer.
397
398         * Scripts/webkitpy/common/config/committers.py: Rolled out r141693.
399         Also, changed e-mail order for Yongjun Zhang, so that Bugzilla autocomplete works.
400
401 2013-02-02  Antoine Quint  <graouts@apple.com>
402
403         Add Antoine Quint to the list of committers
404         https://bugs.webkit.org/show_bug.cgi?id=108750
405
406         Reviewed by Dean Jackson.
407
408         * Scripts/webkitpy/common/config/committers.py:
409
410 2013-02-01  Adrian Perez de Castro  <aperez@igalia.com>
411
412         [GTK] Building fails in an armv5tel board
413         https://bugs.webkit.org/show_bug.cgi?id=108083
414
415         Reviewed by Martin Robinson.
416
417         In some systems in which $architecture is filled-in from "uname -m"
418         the value may not start with "arm-", but with "armvN", where "N" is
419         an architecture version number. The regexp in isARM() is modified
420         so it covers these kind of cases.
421
422         * Scripts/webkitdirs.pm:
423         (isARM):
424
425 2013-02-01  Gregg Tavares  <gman@google.com>
426
427         Update LayoutTests scripts to skip webgl folder on ports
428         https://bugs.webkit.org/show_bug.cgi?id=108705
429
430         Reviewed by Dirk Pranke.
431
432         I'm working on checking in the WebGL Conformance Tests
433         as layout tests into LayoutTests/webgl. For ports
434         that do not have WebGL enabled this changes will
435         skip tests in the "webgl" folder.
436
437         * Scripts/webkitpy/layout_tests/port/base.py:
438         (Port._missing_symbol_to_skipped_tests):
439         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
440         (PortTestCase.test_skipped_directories_for_symbols):
441
442 2013-02-01  Roger Fong  <roger_fong@apple.com>
443
444         Unreviewed. Fix for webkitpy tests.
445
446         * Scripts/webkitpy/tool/steps/runtests.py:
447         (RunTests.run):
448         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
449
450 2013-02-01  Jer Noble  <jer.noble@apple.com>
451
452         LLDB: add synthetic provider for WTF::HashTable
453         https://bugs.webkit.org/show_bug.cgi?id=108718
454
455         Reviewed by Darin Adler.
456
457         Add a synthetic provider which will emit the contents of a given
458         WTF::HashTable. This allows clients using Xcode/lldb to enumerate
459         the hash contents.
460
461         * lldb/lldb_webkit.py:
462         (__lldb_init_module):
463         (__lldb_init_module.lldb_webkit):
464         (WTFHashTable_SummaryProvider):
465         (WTFVectorProvider.has_children):
466         (WTFHashTableProvider):
467         (WTFHashTableProvider.__init__):
468         (WTFHashTableProvider.num_children):
469         (WTFHashTableProvider.get_child_index):
470         (WTFHashTableProvider.get_child_at_index):
471         (WTFHashTableProvider.tableSize):
472         (WTFHashTableProvider.keyCount):
473         (WTFHashTableProvider.update):
474         (WTFHashTableProvider.has_children):
475
476 2013-02-01  Roger Fong  <roger_fong@apple.com>
477
478         Unreviewed. Fix webkitpy tests since a build_style is not specified in some cases.
479
480         * Scripts/webkitpy/tool/steps/runtests.py:
481         (RunTests.run):
482
483 2013-02-01  Roger Fong  <roger_fong@apple.com>
484
485         Unreviewed. Re-try enabling Win-EWS tests for the third time. 
486         https://bugs.webkit.org/show_bug.cgi?id=107968
487
488         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
489         (WinEWS):
490
491 2013-01-31  Roger Fong  <roger_fong@apple.com>
492
493         Fix test scripts for EWS bots to get them running once and for all.
494         https://bugs.webkit.org/show_bug.cgi?id=108422
495
496         Reviewed by Timothy Horton.
497
498         Disabling --quiet option on Windows for now because that fails when we try to use /dev/null.
499         runtests.py was not passing in a configuration to run-webkit-tests which causes DRT to build in release by default.
500         However, we build in Debug only on the EWS Windows bots, which caused the build to fail.
501
502         * Scripts/webkitpy/tool/steps/runtests.py:
503         (RunTests.options):
504         (RunTests.run):
505
506 2013-02-01  Nico Weber  <thakis@chromium.org>
507
508         [chromium] Build webkit with enable_web_intents set to 0.
509         https://bugs.webkit.org/show_bug.cgi?id=108408
510
511         Reviewed by Tony Chang.
512
513         I'll then make chromium build fine with that, then switch
514         enable_web_intents to 0, roll that into webkit, and then
515         actually remove the code hidden behind this flag.
516
517         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
518         (WebTestRunner::TestRunner::TestRunner):
519         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
520         (WebTestRunner::WebTestProxyBase::registerIntentService):
521         (WebTestRunner::WebTestProxyBase::dispatchIntent):
522         * DumpRenderTree/chromium/WebViewHost.cpp:
523         * DumpRenderTree/chromium/WebViewHost.h:
524         (WebViewHost):
525
526 2013-02-01  Zan Dobersek  <zdobersek@igalia.com>
527
528         Set the GTK 64-bit Debug builder to build and test only WebKit1
529         https://bugs.webkit.org/show_bug.cgi?id=108648
530
531         Reviewed by Philippe Normand.
532
533         * BuildSlaveSupport/build.webkit.org-config/config.json: Change the builder name, type and
534         build directory to note that the builder builds and tests only the WebKit1 port on the GTK platform.
535         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
536         (CompileWebKit1Only): Add the new build class that builds only the WebKit1 port of the builder's platform.
537         (BuildAndTestWebKit1OnlyFactory): Add the new factory that uses the CompileWebKit1Only build class
538         for building and testing only WebKit1 on the builder's platform.
539
540 2013-02-01  Jochen Eisinger  <jochen@chromium.org>
541
542         [chromium] move ownership of TestRunner object to TestInterfaces
543         https://bugs.webkit.org/show_bug.cgi?id=108464
544
545         Reviewed by Adam Barth.
546
547         Before, TestShell owned the class. This also removes the last include
548         from DumpRenderTree to TestRunner/src.
549
550         This also deletes TestDelegate and uses WebTestDelegate everywhere
551         instead.
552
553         * DumpRenderTree/DumpRenderTree.gypi:
554         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
555         (WebTestInterfaces):
556         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
557         (WebKit):
558         (WebTestRunner):
559         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
560         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
561         (WebTestRunner):
562         (WebTestRunner::AccessibilityController::setDelegate):
563         (AccessibilityController):
564         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
565         (WebTestRunner):
566         (WebTestRunner::makeMenuItemStringsFor):
567         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
568         (WebTestRunner):
569         (WebTestRunner::EventSender::setDelegate):
570         (EventSender):
571         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
572         (WebTestRunner::GamepadController::setDelegate):
573         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
574         (WebTestRunner):
575         (GamepadController):
576         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: Removed.
577         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
578         (WebTestRunner::TestInterfaces::TestInterfaces):
579         (WebTestRunner::TestInterfaces::~TestInterfaces):
580         (WebTestRunner::TestInterfaces::setWebView):
581         (WebTestRunner::TestInterfaces::setDelegate):
582         (WebTestRunner::TestInterfaces::bindTo):
583         (WebTestRunner::TestInterfaces::resetAll):
584         (WebTestRunner):
585         (WebTestRunner::TestInterfaces::setTestIsRunning):
586         (WebTestRunner::TestInterfaces::testRunner):
587         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
588         (WebTestRunner):
589         (TestInterfaces):
590         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
591         (WebTestRunner::TestRunner::TestRunner):
592         (WebTestRunner::TestRunner::reset):
593         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
594         (WebKit):
595         (TestRunner):
596         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
597         (WebTestRunner::WebTestInterfaces::Internal::testRunner):
598         (WebTestInterfaces::Internal):
599         (WebTestRunner::WebTestInterfaces::Internal::Internal):
600         (WebTestRunner::WebTestInterfaces::Internal::setDelegate):
601         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
602         * DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Added.
603         (WebTestRunner):
604         (WebTestRunner::WebTestRunner::WebTestRunner):
605         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
606         (WebTestRunner::WebTestRunner::shouldDumpAsText):
607         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
608         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
609         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
610         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
611         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
612         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
613         (WebTestRunner::WebTestRunner::audioData):
614         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
615         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
616         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
617         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
618         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
619         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
620         (WebTestRunner::WebTestRunner::canOpenWindows):
621         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
622         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
623         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
624         (WebTestRunner::WebTestRunner::webPermissions):
625         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
626         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
627         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
628         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
629         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
630         (WebTestRunner::WebTestRunner::testRepaint):
631         (WebTestRunner::WebTestRunner::sweepHorizontally):
632         (WebTestRunner::WebTestRunner::isPrinting):
633         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
634         (WebTestRunner::WebTestRunner::setTitleTextDirection):
635         (WebTestRunner::WebTestRunner::httpHeadersToClear):
636         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
637         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
638         (WebTestRunner::WebTestRunner::setTopLoadingFrame):
639         (WebTestRunner::WebTestRunner::topLoadingFrame):
640         (WebTestRunner::WebTestRunner::policyDelegateDone):
641         (WebTestRunner::WebTestRunner::policyDelegateEnabled):
642         (WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
643         (WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
644         (WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
645         (WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
646         (WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
647         * DumpRenderTree/chromium/TestShell.cpp:
648         (TestShell::initialize):
649         (TestShell::createMainWindow):
650         (TestShell::~TestShell):
651         (TestShell::runFileTest):
652         (TestShell::resetTestController):
653         (TestShell::dump):
654         (TestShell::bindJSObjectsToWindow):
655         * DumpRenderTree/chromium/TestShell.h:
656         (TestShell::testRunner):
657         (TestShell):
658
659 2013-02-01  Alan Cutter  <alancutter@chromium.org>
660
661         PatchLog process durations are increasing linearly with time (faulty data logging)
662         https://bugs.webkit.org/show_bug.cgi?id=108621
663
664         Reviewed by Eric Seidel.
665
666         Added a check to prevent a stop event from happening to the same patch multiple times.
667
668         * QueueStatusServer/loggers/recordpatchevent.py:
669         (RecordPatchEvent.stopped):
670
671 2013-02-01  Manuel Rego Casasnovas  <rego@igalia.com>
672
673         [GTK][WK2] MiniBrowser fullscreen signals support
674         https://bugs.webkit.org/show_bug.cgi?id=108005
675
676         Reviewed by Carlos Garcia Campos.
677
678         Shows a label for 2 seconds using overlay (if GTK >= 3.2.0) and hides
679         the toolbar when entering fullscreen. When leaving fullscreen the
680         label is hidden (if it's not hidden yet) and the toolbar is shown again.
681
682         * MiniBrowser/gtk/BrowserWindow.c:
683         (_BrowserWindow):
684         (fullScreenMessageTimeoutCallback):
685         (webViewEnterFullScreen):
686         (webViewLeaveFullScreen):
687         (browserWindowFinalize):
688         (browserWindowConstructed):
689
690 2013-02-01  Alexis Menard  <alexis@webkit.org>
691
692         Enable unprefixed CSS transitions by default.
693         https://bugs.webkit.org/show_bug.cgi?id=108216
694
695         Reviewed by Dean Jackson.
696
697         Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
698         to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to 
699         guard the unprefixing work for CSS Transforms and animations.
700
701         * Scripts/webkitperl/FeatureList.pm:
702         * qmake/mkspecs/features/features.pri:
703
704 2013-01-31  David Farler  <dfarler@apple.com>
705
706         Provide a sensible default architecture when building on iOS SDKs
707         https://bugs.webkit.org/show_bug.cgi?id=108395
708
709         Reviewed by Anders Carlsson.
710
711         * Scripts/webkitdirs.pm:
712         (determineArchitecture): Anchor SDK regex matches at the beginning.
713
714 2013-01-31  Ryosuke Niwa  <rniwa@webkit.org>
715
716         buildbot should not rely on webkitpy
717         https://bugs.webkit.org/show_bug.cgi?id=107379
718
719         Reviewed by Eric Seidel.
720
721         Move all Python files used in buildbot configuration into BuildSlaveSupport directory.
722         Once this patch is landed, we can stop restarting the master on webkitpy changes.
723
724         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
725         * BuildSlaveSupport/build.webkit.org-config/htdigestparser.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser.py.
726         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser_unittest.py.
727         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
728         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: Copied from Tools/Scripts/webkitpy/common/config/build.py.
729         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/build_unittest.py.
730         (ShouldBuildTest.test_should_build):
731         * Scripts/webkitpy/common/config/build.py: Removed.
732         * Scripts/webkitpy/common/config/build_unittest.py: Removed.
733         * Scripts/webkitpy/common/net/htdigestparser.py: Removed.
734         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Removed.
735
736 2013-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
737
738         Unreviewed, rolling out r141349.
739         http://trac.webkit.org/changeset/141349
740         https://bugs.webkit.org/show_bug.cgi?id=108422
741
742         "yet another windows ews fix needed" (Requested by lforschler
743         on #webkit).
744
745         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
746         (WinEWS):
747
748 2013-01-31  Rouslan Solomakhin  <rouslan@chromium.org>
749
750         [Chromium] Suggest 'uppercase' for multi-word misspelling 'upper case'
751         https://bugs.webkit.org/show_bug.cgi?id=108509
752
753         Reviewed by Tony Chang.
754
755         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
756         (append): Added utility function to append WebString to WebVector.
757         (MockSpellCheck::fillSuggestionList): Suggest 'uppercase' for misspelling 'upper case'.
758
759 2013-01-31  David Farler  <dfarler@apple.com>
760
761         Provide a sensible default architecture when building on iOS SDKs
762         https://bugs.webkit.org/show_bug.cgi?id=108395
763
764         Reviewed by Joseph Pecoraro.
765
766         * Scripts/webkitdirs.pm:
767         (determineArchitecture):
768         Check for iphoneos and iphonesimulator SDKs for a default arch.
769         (determineXcodeSDK): Added.
770         (xcodeSDK): Added.
771         (XcodeOptions): Add ARCHS= if defined.
772
773 2013-01-31  Christopher Cameron  <ccameron@chromium.org>
774
775         Fix rubber-band effect on non-scrollable pages
776         https://bugs.webkit.org/show_bug.cgi?id=107611
777
778         Add mouseWheelBegin function to EventSender to allow
779         event-based rubber-banding tests.
780
781         Reviewed by Antonio Gomes.
782
783         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
784         (WebTestRunner):
785         (WebTestRunner::EventSender::EventSender):
786         (WebTestRunner::EventSender::mouseDragBegin):
787         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
788         (EventSender):
789
790 2013-01-31  James Robinson  <jamesr@chromium.org>
791
792         [chromium] Notify the WebWidget when the WebViewHost is about to tear down compositing support
793         https://bugs.webkit.org/show_bug.cgi?id=108518
794
795         Reviewed by Adrienne Walker.
796
797         * DumpRenderTree/chromium/WebViewHost.cpp:
798         (WebViewHost::shutdown):
799
800 2013-01-31  Pratik Solanki  <psolanki@apple.com>
801
802         DumpRenderTree should put NSSound calls inside USE(APPKIT)
803         https://bugs.webkit.org/show_bug.cgi?id=108499
804
805         Reviewed by Andy Estes.
806
807         * DumpRenderTree/mac/DumpRenderTree.mm:
808         (dumpRenderTree):
809
810 2013-01-30  Brian Weinstein  <bweinstein@apple.com>
811
812         Add a call to the page UI client to determine if a plug-in should load
813         https://bugs.webkit.org/show_bug.cgi?id=108407
814         <rdar://problem/13066332>
815
816         Add entries for the new function in the necessary structs.
817
818         Reviewed by Anders Carlsson.
819
820         * MiniBrowser/mac/WK2BrowserWindowController.m:
821         (-[WK2BrowserWindowController awakeFromNib]):
822         * WebKitTestRunner/TestController.cpp:
823         (WTR::TestController::createOtherPage):
824         (WTR::TestController::createWebViewWithOptions):
825
826 2013-01-31  Florin Malita  <fmalita@chromium.org>
827
828         [Chromium] Unreviewed gardening.
829
830         Win build fix after http://trac.webkit.org/changeset/141471.
831
832         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
833         (MockSpellCheck::spellCheckWord):
834
835 2013-01-31  Enrica Casucci  <enrica@apple.com>
836
837         WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
838         https://bugs.webkit.org/show_bug.cgi?id=108396.
839         <rdar://problem/12920461>
840
841         Reviewed by Alexey Proskuryakov.
842         
843         Adding new WebKit2 test with relevant bundle, to test the new APIs.
844
845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
846         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: Added.
847         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
848         (TestWebKitAPI::setInjectedBundleClient):
849         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: Added.
850         (PasteboardNotificationsTest):
851         (TestWebKitAPI::willWriteToPasteboard):
852         (TestWebKitAPI::getPasteboardDataForRange):
853         (TestWebKitAPI::didWriteToPasteboard):
854         (TestWebKitAPI::PasteboardNotificationsTest::PasteboardNotificationsTest):
855         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
856         * TestWebKitAPI/Tests/WebKit2/execCopy.html: Added.
857         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Updated to reflect
858         changes in InjectedBundleEditorClient.
859         (WTR::InjectedBundlePage::InjectedBundlePage):
860
861 2013-01-31  Rouslan Solomakhin  <rouslan@chromium.org>
862
863         [Chromium] Add two-word misspelling to mock spellchecker
864         https://bugs.webkit.org/show_bug.cgi?id=108498
865
866         Reviewed by Tony Chang.
867
868         Some layout tests verify spellcheck behavior when multiple words are
869         marked as a single misspelling. This change adds a two-word misspelling
870         'upper case' to the mock spellchecker used by layout tests.
871
872         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
873         (MockSpellCheck::spellCheckWord): Modified to handle spaces in misspellings.
874         (MockSpellCheck::initializeIfNeeded):  Modified to use a vector instead of a hash table.
875         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
876         (MockSpellCheck): Changed misspellings container from hash table to vector.
877
878 2013-01-31  Simon Hausmann  <simon.hausmann@digia.com>
879
880         [Qt] Prospective build fix.
881
882         Reviewed by Jocelyn Turcotte.
883
884         Don't create .prl files for intermediate libs as their contents get
885         injected within -Wl,-whole-archive -lFoo -wl,-no-whole-archive.
886
887         * qmake/mkspecs/features/default_post.prf:
888
889 2013-01-31  Alan Cutter  <alancutter@chromium.org>
890
891         EWS graphs have unusual data for patch waiting times
892         https://bugs.webkit.org/show_bug.cgi?id=108427
893
894         Reviewed by Eric Seidel.
895
896         The max_patches_waiting QueueLog property may have missed recording patches waiting in idle times when no events are fired to update it. I added a cron job to take care of this issue.
897         The patch wait duration in PatchLogs was being incorrectly updated after a patch expired and was picked up again from the queue. That period should really count towards the processing time instead.
898         Added a WarningLog to record if any erroneous situations occur due to invalid contents in the datastore. These basically highlight if any "impossible" execution paths get executed.
899
900         * QueueStatusServer/app.yaml:
901         * QueueStatusServer/cron.yaml:
902         * QueueStatusServer/handlers/syncqueuelogs.py: Copied from Tools/QueueStatusServer/model/patchlog.py.
903         (SyncQueueLogs):
904         (SyncQueueLogs.get):
905         * QueueStatusServer/loggers/recordpatchevent.py:
906         (RecordPatchEvent.added):
907         (RecordPatchEvent.retrying):
908         (RecordPatchEvent.started):
909         (RecordPatchEvent.stopped):
910         (RecordPatchEvent.updated):
911         * QueueStatusServer/main.py:
912         * QueueStatusServer/model/patchlog.py:
913         (PatchLog.lookup):
914         (PatchLog):
915         (PatchLog.lookup_if_exists):
916         (PatchLog.calculate_process_duration):
917         (PatchLog._generate_key):
918         * QueueStatusServer/model/queuelog.py:
919         (QueueLog.update_max_patches_waiting):
920         (QueueLog._get_or_create_txn):
921         (QueueLog):
922         (QueueLog._get_patches_waiting):
923         * QueueStatusServer/model/warninglog.py: Copied from Tools/QueueStatusServer/model/patchlog.py.
924         (WarningLog):
925         (WarningLog.record):
926
927 2013-01-31  Anders Carlsson  <andersca@apple.com>
928
929         Remove Web Intents code from WebKit2
930         https://bugs.webkit.org/show_bug.cgi?id=108506
931
932         Reviewed by Simon Fraser.
933
934         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
935         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
936         (WTR::InjectedBundlePage::InjectedBundlePage):
937         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
938         (InjectedBundlePage):
939         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
940         * WebKitTestRunner/InjectedBundle/TestRunner.h:
941         (TestRunner):
942
943 2013-01-31  Tommy Widenflycht  <tommyw@google.com>
944
945         [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
946         https://bugs.webkit.org/show_bug.cgi?id=108458
947
948         Reviewed by Adam Barth.
949
950         Only renames, no other code changes.
951
952         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
953         (MockWebMediaStreamCenter::didEnableMediaStreamTrack):
954         (MockWebMediaStreamCenter::didDisableMediaStreamTrack):
955         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
956         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
957         (MockWebMediaStreamCenter::didStopLocalMediaStream):
958         (MockWebMediaStreamCenter::didCreateMediaStream):
959         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
960         (MockWebMediaStreamCenter):
961         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
962         (MockWebRTCPeerConnectionHandler::addStream):
963         (MockWebRTCPeerConnectionHandler::removeStream):
964         (MockWebRTCPeerConnectionHandler::getStats):
965         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
966         (MockWebRTCPeerConnectionHandler):
967         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
968         (UserMediaRequestTask::UserMediaRequestTask):
969         (WebUserMediaClientMock::requestUserMedia):
970
971 2013-01-31  Zan Dobersek  <zdobersek@igalia.com>
972
973         REGRESSION (r141402): incorrectly set injected bundle path when running GTK unit tests
974         https://bugs.webkit.org/show_bug.cgi?id=108496
975
976         Reviewed by Philippe Normand.
977
978         * Scripts/run-gtk-tests:
979         (TestRunner.__init__): Add the build type as a member on the TestRunner interface.
980         (TestRunner._setup_testing_environment): Use the build type member to determine correct path
981         to the injected bundle.
982
983 2013-01-31  Christophe Dumez  <dchris@gmail.com>
984
985         [EFL] Disable Web Intents
986         https://bugs.webkit.org/show_bug.cgi?id=108457
987
988         Reviewed by Alexey Proskuryakov.
989
990         Remove EFL DRT code related to Web intents.
991
992         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
993         (DumpRenderTreeChrome::createView):
994         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
995         (DumpRenderTreeChrome::onFrameCreated):
996         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
997         (DumpRenderTreeChrome):
998         * DumpRenderTree/efl/TestRunnerEfl.cpp:
999         (TestRunner::sendWebIntentResponse):
1000         (TestRunner::deliverWebIntent):
1001         * Scripts/webkitperl/FeatureList.pm: Turn off WEB_INTENTS flag
1002         for EFL port.
1003
1004 2013-01-31  Simon Hausmann  <simon.hausmann@digia.com>
1005
1006         [Qt] Disable force_static_libs_as_shared in developer builds if wk2 is enabled
1007
1008         Reviewed by Jocelyn Turcotte.
1009
1010         This is a temporary workaround during the development of #108471, where we move files around
1011         but some link time dependencies might remain.
1012
1013         * qmake/mkspecs/features/default_post.prf:
1014
1015 2013-01-31  Simon Hausmann  <simon.hausmann@digia.com>
1016
1017         [Qt] Make it possible to compile WebKit2 Qt related files without access to internal WK2 C++ API
1018         https://bugs.webkit.org/show_bug.cgi?id=108472
1019
1020         Reviewed by Andreas Kling.
1021
1022         Add a new module to the qmake build system that represents the part of the WebKit2 Qt integration
1023         that doesn't depend on WebKit2 internals.
1024
1025         * qmake/mkspecs/features/webkit_modules.prf:
1026         * qmake/mkspecs/modules/webkit2qml.prf: Copied from Source/WebKit2/WebKit2.pro.
1027
1028 2013-01-31  James Robinson  <jamesr@chromium.org>
1029
1030         [chromium] Remove dead transitional code from WebViewImpl
1031         https://bugs.webkit.org/show_bug.cgi?id=107889
1032
1033         Reviewed by Adam Barth.
1034
1035         ScrollingCoordinatorChromiumTests need to initialize compositing, so its implementation of
1036         WebWidgetClient has to support the new compositor initialization path.
1037
1038         * DumpRenderTree/chromium/WebViewHost.cpp:
1039         (WebViewHost::initializeLayerTreeView):
1040         (WebViewHost::setWebWidget):
1041
1042 2013-01-31  Gustavo Noronha Silva  <gns@gnome.org>
1043
1044         [GTK] run-gtk-tests does not respect the -d argument
1045         https://bugs.webkit.org/show_bug.cgi?id=107822
1046
1047         Reviewed by Philippe Normand.
1048
1049         * Scripts/run-gtk-tests:
1050         (TestRunner.__init__): use the value for the debug option to decide what
1051         build_type to request a path for.
1052         * gtk/common.py:
1053         (get_build_path): now accepts a build_type argument instead of trying both
1054         Release and Debug in order, defaults to release.
1055         (build_path): takes and passes a build_type argument, no default value.
1056
1057 2013-01-31  Christophe Dumez  <dchris@gmail.com>
1058
1059         Update Christophe Dumez's email address
1060         https://bugs.webkit.org/show_bug.cgi?id=108453
1061
1062         Reviewed by Kenneth Rohde Christiansen.
1063
1064         Update my email address in committers.py.
1065
1066         * Scripts/webkitpy/common/config/committers.py:
1067
1068 2013-01-31  Jochen Eisinger  <jochen@chromium.org>
1069
1070         [chromium] move runModalBeforeUnloadDialog to TestRunner library
1071         https://bugs.webkit.org/show_bug.cgi?id=108442
1072
1073         Reviewed by Adam Barth.
1074
1075         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1076         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
1077         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1078         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
1079         * DumpRenderTree/chromium/WebViewHost.cpp:
1080         * DumpRenderTree/chromium/WebViewHost.h:
1081
1082 2013-01-31  Jochen Eisinger  <jochen@chromium.org>
1083
1084         [chromium] move postMessage related methods to TestRunner library
1085         https://bugs.webkit.org/show_bug.cgi?id=108343
1086
1087         Reviewed by Adam Barth.
1088
1089         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1090         (WebKit):
1091         (WebTestProxyBase):
1092         (WebTestRunner::WebTestProxy::willCheckAndDispatchMessageEvent):
1093         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1094         (WebTestRunner::WebTestProxyBase::willCheckAndDispatchMessageEvent):
1095         (WebTestRunner):
1096         * DumpRenderTree/chromium/WebViewHost.cpp:
1097         (WebViewHost::willCheckAndDispatchMessageEvent):
1098
1099 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
1100
1101         [chromium] move remaining resource load related methods to TestRunner library
1102         https://bugs.webkit.org/show_bug.cgi?id=108334
1103
1104         Reviewed by Adam Barth.
1105
1106         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1107         (WebTestRunner::WebTestDelegate::allowExternalPages):
1108         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1109         (WebKit):
1110         (WebTestProxyBase):
1111         (WebTestRunner::WebTestProxy::canHandleRequest):
1112         (WebTestRunner::WebTestProxy::cannotHandleRequestError):
1113         (WebTestRunner::WebTestProxy::didCreateDataSource):
1114         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1115         (WebTestRunner::WebTestProxyBase::canHandleRequest):
1116         (WebTestRunner):
1117         (WebTestRunner::WebTestProxyBase::cannotHandleRequestError):
1118         (WebTestRunner::WebTestProxyBase::didCreateDataSource):
1119         (WebTestRunner::WebTestProxyBase::willSendRequest):
1120         * DumpRenderTree/chromium/WebViewHost.cpp:
1121         (WebViewHost::canHandleRequest):
1122         (WebViewHost::didCreateDataSource):
1123         (WebViewHost::willSendRequest):
1124         (WebViewHost::allowExternalPages):
1125         * DumpRenderTree/chromium/WebViewHost.h:
1126
1127 2013-01-30  Hajime Morrita  <morrita@google.com>
1128
1129         Unreviewed test failure fix for r141341.
1130
1131         * Scripts/webkitpy/tool/steps/runtests.py:
1132         (RunTests.run):
1133         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1134
1135 2013-01-30  Levi Weintraub  <leviw@chromium.org>
1136
1137         [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
1138         https://bugs.webkit.org/show_bug.cgi?id=108381
1139
1140         Reviewed by James Robinson.
1141
1142         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that
1143         tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.
1144
1145 2013-01-30  Julie Parent  <jparent@chromium.org>
1146
1147         Add a concept of dashboard parameters that invalidate others
1148         https://bugs.webkit.org/show_bug.cgi?id=108362
1149
1150         Reviewed by Dirk Pranke.
1151
1152         There are certain parameters to the dashboards, that when selected,
1153         invalidate others, such as selecting the test type invalidates the
1154         builder group. Add this concept to dashboard_base and allow specifc
1155         dashboard to add their own invalidating parameters.
1156         
1157         The result is that when the user takes a specific action, like changing
1158         the test type, the builder would get reset to the default for the new
1159         test type, rather than erroring or not matching the query param, as is
1160         the current behavior.
1161         
1162         Also deletes some unused code (selectBuilder).
1163         
1164         * TestResultServer/static-dashboards/dashboard_base.js:
1165         (invalidateQueryParameters):
1166         (setQueryParameter):
1167         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1168         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1169         * TestResultServer/static-dashboards/timeline_explorer.html:
1170         * TestResultServer/static-dashboards/treemap.html:
1171
1172 2013-01-30  Kiran Muppala  <cmuppala@apple.com>
1173
1174         Disable process suppression of DumpRenderTree on Mac
1175         https://bugs.webkit.org/show_bug.cgi?id=108400
1176
1177         Reviewed by Jessie Berlin.
1178
1179         * DumpRenderTree/mac/DumpRenderTree.mm:
1180         (prepareConsistentTestingEnvironment): Take assertion to prevent
1181         process suppression.
1182
1183 2013-01-30  Roger Fong  <roger_fong@apple.com>
1184
1185         Enable tests for Windows EWS!
1186         https://bugs.webkit.org/show_bug.cgi?id=107968.
1187         Patch by Lucas Forschler.
1188
1189         Reviewed by Adam Barth.
1190
1191         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1192         (WinEWS):
1193
1194 2013-01-30  Christophe Dumez  <christophe.dumez@intel.com>
1195
1196         Add a StringTypeAdapter for ASCIILiteral
1197         https://bugs.webkit.org/show_bug.cgi?id=108338
1198
1199         Reviewed by Benjamin Poulain.
1200
1201         Add API tests for operator+() taking an ASCIILiteral.
1202
1203         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1204         (TestWebKitAPI::TEST):
1205
1206 2013-01-30  Roger Fong  <roger_fong@apple.com>
1207
1208         Modify runtests.py script so that --skip-failing-tests option is not added when platform is cygwin.
1209
1210         Rubberstamped by Timothy Horton.
1211
1212         * Scripts/webkitpy/tool/steps/runtests.py:
1213         (RunTests.run):
1214
1215 2013-01-30  Sheriff Bot  <webkit.review.bot@gmail.com>
1216
1217         Unreviewed, rolling out r141205.
1218         http://trac.webkit.org/changeset/141205
1219         https://bugs.webkit.org/show_bug.cgi?id=108353
1220
1221         Command for running tests on windows needs to be investigated.
1222         (Requested by lforschler on #webkit).
1223
1224         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1225         (WinEWS):
1226
1227 2013-01-30  Tony Chang  <tony@chromium.org>
1228
1229         [Chromium] Enable textarea resize corner for tests
1230         https://bugs.webkit.org/show_bug.cgi?id=108385
1231
1232         Reviewed by Ojan Vafai.
1233
1234         We should test what we ship. Also, this makes us pass more tests in content_shell.
1235
1236         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1237         (WebTestRunner::WebPreferences::reset): Turn on resize corner.
1238
1239 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
1240
1241         [chromium] move custom policy delegate to TestRunner library
1242         https://bugs.webkit.org/show_bug.cgi?id=108328
1243
1244         Reviewed by Adam Barth.
1245
1246         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1247         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1248         (WebTestProxyBase):
1249         (WebTestRunner::WebTestProxy::decidePolicyForNavigation):
1250         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1251         (WebTestRunner::WebTestRunner::policyDelegateEnabled):
1252         (WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
1253         (WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
1254         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1255         (WebTestRunner::TestRunner::reset):
1256         (WebTestRunner::TestRunner::policyDelegateEnabled):
1257         (WebTestRunner):
1258         (WebTestRunner::TestRunner::policyDelegateIsPermissive):
1259         (WebTestRunner::TestRunner::policyDelegateShouldNotifyDone):
1260         (WebTestRunner::TestRunner::setCustomPolicyDelegate):
1261         (WebTestRunner::TestRunner::waitForPolicyDelegate):
1262         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1263         (TestRunner):
1264         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1265         (WebTestRunner::WebTestProxyBase::decidePolicyForNavigation):
1266         (WebTestRunner):
1267         * DumpRenderTree/chromium/WebViewHost.cpp:
1268         (WebViewHost::decidePolicyForNavigation):
1269         (WebViewHost::reset):
1270         * DumpRenderTree/chromium/WebViewHost.h:
1271         (WebViewHost):
1272
1273 2013-01-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1274
1275         [Qt][WK1] Support better testing of Web Notifications
1276         https://bugs.webkit.org/show_bug.cgi?id=107696
1277
1278         Reviewed by Jocelyn Turcotte.
1279
1280         Do not dump notification output to the console by default, instead allow the 
1281         tests that need this feature to enable it.
1282
1283         Implement denyWebNotificationPermission and removeAllWebNotificationPermissions.
1284         Remove unused m_desktopNotificationAllowedOrigins variable.
1285
1286         * DumpRenderTree/qt/TestRunnerQt.cpp:
1287         (TestRunner::TestRunner):
1288         (TestRunner::reset):
1289         (TestRunner::dumpNotifications):
1290         (TestRunner::grantWebNotificationPermission):
1291         (TestRunner::denyWebNotificationPermission):
1292         (TestRunner::removeAllWebNotificationPermissions):
1293         * DumpRenderTree/qt/TestRunnerQt.h:
1294         (TestRunner):
1295
1296 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
1297
1298         [chromium] move methods from WebTestDelegate to WebTestRunner
1299         https://bugs.webkit.org/show_bug.cgi?id=108309
1300
1301         Reviewed by Adam Barth.
1302
1303         By moving more logic to the TestRunner library, we can share more
1304         code with content shell.
1305
1306         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1307         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1308         (WebTestProxyBase):
1309         (WebTestRunner::WebTestProxy::createView):
1310         (WebTestRunner::WebTestProxy::isSmartInsertDeleteEnabled):
1311         (WebTestRunner::WebTestProxy::isSelectTrailingWhitespaceEnabled):
1312         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1313         (WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
1314         (WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
1315         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1316         (WebTestRunner::TestRunner::reset):
1317         (WebTestRunner::TestRunner::isSmartInsertDeleteEnabled):
1318         (WebTestRunner):
1319         (WebTestRunner::TestRunner::isSelectTrailingWhitespaceEnabled):
1320         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
1321         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
1322         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1323         (TestRunner):
1324         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1325         (WebTestRunner::WebTestProxyBase::createView):
1326         (WebTestRunner::WebTestProxyBase::isSmartInsertDeleteEnabled):
1327         (WebTestRunner):
1328         (WebTestRunner::WebTestProxyBase::isSelectTrailingWhitespaceEnabled):
1329         * DumpRenderTree/chromium/TestShell.h:
1330         (TestShell):
1331         * DumpRenderTree/chromium/WebViewHost.cpp:
1332         (WebViewHost::createView):
1333         (WebViewHost::didStartLoading):
1334         (WebViewHost::didStopLoading):
1335         (WebViewHost::isSmartInsertDeleteEnabled):
1336         (WebViewHost::isSelectTrailingWhitespaceEnabled):
1337         (WebViewHost::reset):
1338         * DumpRenderTree/chromium/WebViewHost.h:
1339         (WebViewHost):
1340
1341 2013-01-30  Kwang Yul Seo  <skyul@company100.net>
1342
1343         Unreviewed. Add Jae Hyun Park to contributor list.
1344
1345         * Scripts/webkitpy/common/config/committers.py:
1346
1347 2013-01-29  Alan Cutter  <alancutter@chromium.org>
1348
1349         Need a cr-linux debug EWS bot
1350         https://bugs.webkit.org/show_bug.cgi?id=98957
1351
1352         Reviewed by Eric Seidel.
1353
1354         Added cr-linux-debug-ews bot to webkit-patch, QueueStatusServer and GCE build scripts.
1355
1356         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Added.
1357         * QueueStatusServer/app.yaml:
1358         * QueueStatusServer/config/queues.py: Added.
1359         * QueueStatusServer/model/queues.py:
1360         (Queue.__init__):
1361         (Queue.queue_with_name):
1362         (Queue.all):
1363         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1364         (ChromiumLinuxDebugEWS):
1365
1366 2013-01-29  Alan Cutter  <alancutter@chromium.org>
1367
1368         Tidy up Sheriffbot's Sheriffs command's unit tests
1369         https://bugs.webkit.org/show_bug.cgi?id=108262
1370
1371         Reviewed by Eric Seidel.
1372
1373         Added the use of MockWeb instead of the filesystem to test the sheriffs command.
1374
1375         * Scripts/webkitpy/tool/bot/irc_command.py:
1376         (Sheriffs._retrieve_webkit_sheriffs):
1377         (Sheriffs.execute):
1378         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1379         (IRCCommandTest.test_sheriffs):
1380         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Removed.
1381         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Removed.
1382         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Removed.
1383         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Removed.
1384         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Removed.
1385
1386 2013-01-29  Lucas Forschler  <lforschler@apple.com>
1387
1388         Enable tests for Windows EWS!
1389         https://bugs.webkit.org/show_bug.cgi?id=107968
1390         
1391         Reviewed by Adam Barth.
1392
1393         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1394         (WinEWS):
1395
1396 2013-01-29  Alan Cutter  <alancutter@chromium.org>
1397
1398         MockWeb should be able to serve mock web content
1399         https://bugs.webkit.org/show_bug.cgi?id=108240
1400
1401         Reviewed by Dirk Pranke.
1402
1403         Added the ability to have MockWeb serve mock web data.
1404
1405         * Scripts/webkitpy/common/host_mock.py:
1406         (MockHost.__init__):
1407         * Scripts/webkitpy/common/net/web_mock.py:
1408         (MockWeb.__init__):
1409         (MockWeb.get_binary):
1410
1411 2013-01-29  Jessie Berlin  <jberlin@apple.com>
1412
1413         run-api-tests should have an option to specify root
1414         https://bugs.webkit.org/show_bug.cgi?id=108210
1415
1416         Reviewed by Ryosuke Niwa.
1417
1418         * Scripts/run-api-tests:
1419         Add the option and use it to set the configuration product directory. Since it is supposed
1420         to point to the built products, do not build the products if root is specified (this mimics
1421         the behavior of run-javascriptcore-tests).
1422
1423 2013-01-29  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
1424
1425         [EFL] Add Toggle fullscreen (F11) to MiniBrowser
1426         https://bugs.webkit.org/show_bug.cgi?id=108122
1427
1428         Reviewed by Antonio Gomes.
1429
1430         Adds fullscreen mode toggle (F11) option to MiniBrowser using native API.
1431
1432         * MiniBrowser/efl/main.c:
1433         (on_key_down): Add 'F11' key handler.
1434
1435 2013-01-29  Patrick Gansterer  <paroga@webkit.org>
1436
1437         [CMake] Use offical Windows CE support
1438         https://bugs.webkit.org/show_bug.cgi?id=108061
1439
1440         Reviewed by Laszlo Gombos.
1441
1442         Recent version of CMake has added Windows CE support, but uses a
1443         slightly different interface than the patched version used before.
1444         Change the command line parameters to use the offical CMake binaries.
1445
1446         * Scripts/webkitdirs.pm:
1447         (cmakeBasedPortArguments):
1448
1449 2013-01-29  Alan Cutter  <alancutter@chromium.org>
1450
1451         QueueStatusServer needs pages to display historical queue data
1452         https://bugs.webkit.org/show_bug.cgi?id=107659
1453
1454         Reviewed by Eric Seidel.
1455
1456         Created a /queue-charts/<queue-name> handler to present queue and patch data using Google Chart Tools.
1457
1458         * QueueStatusServer/app.yaml:
1459         * QueueStatusServer/config/charts.py: Copied from Tools/QueueStatusServer/model/queuelog.py.
1460         (get_time_unit):
1461         * QueueStatusServer/filters/webkit_extras.py:
1462         (webkit_linkify):
1463         (webkit_bug_id):
1464         (webkit_attachment_id):
1465         (results_link):
1466         (queue_status_link):
1467         (queue_charts_link):
1468         * QueueStatusServer/handlers/queuecharts.py: Added.
1469         (QueueCharts):
1470         (QueueCharts.get):
1471         (QueueCharts._get_min_med_max):
1472         (QueueCharts._get_patch_data):
1473         (QueueCharts._get_patch_logs):
1474         (QueueCharts._get_queue_data):
1475         (QueueCharts._get_queue_logs):
1476         (QueueCharts._get_time_unit):
1477         (QueueCharts._get_timestamp):
1478         (QueueCharts._get_view_range):
1479         * QueueStatusServer/handlers/queuestatus.py:
1480         (QueueStatus.get):
1481         * QueueStatusServer/index.yaml:
1482         * QueueStatusServer/main.py:
1483         * QueueStatusServer/model/queuelog.py:
1484         (QueueLog):
1485         (QueueLog.create_key):
1486         (QueueLog.get_at):
1487         (QueueLog.get_current):
1488         (QueueLog.get_or_create):
1489         (QueueLog._get_or_create_txn):
1490         * QueueStatusServer/stylesheets/charts.css: Added.
1491         (.chart):
1492         (.choices):
1493         * QueueStatusServer/templates/queuecharts.html: Added.
1494         * QueueStatusServer/templates/queuestatus.html:
1495
1496 2013-01-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1497
1498         [GTK] Missing build flags when building with Harfbuzz
1499         https://bugs.webkit.org/show_bug.cgi?id=108174
1500
1501         Reviewed by Martin Robinson.
1502
1503         Add FREETYPE_CFLAGS and FREETYPE_LIBS to makefiles so -lharfbuzz
1504         parameter will be added to linking lines when needed.
1505
1506         * GNUmakefile.am: Added FREETYPE_CFLAGS and FREETYPE_LIBS.
1507         * MiniBrowser/gtk/GNUmakefile.am: Ditto.
1508         * TestWebKitAPI/GNUmakefile.am: Ditto.
1509
1510 2013-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1511
1512         [GTK] Implement resources API using injected bundle
1513         https://bugs.webkit.org/show_bug.cgi?id=107457
1514
1515         Reviewed by Sam Weinig.
1516
1517         * Scripts/run-gtk-tests:
1518         (TestRunner): Unksip resources unit tests.
1519
1520 2013-01-29  Michael Brüning  <michael.bruning@digia.com>
1521
1522         Unreviewed, updated my email information.
1523
1524         * Scripts/webkitpy/common/config/committers.py:
1525
1526 2013-01-29  Jochen Eisinger  <jochen@chromium.org>
1527
1528         [chromium] delete DRTTestRunner
1529         https://bugs.webkit.org/show_bug.cgi?id=108082
1530
1531         Reviewed by Adam Barth.
1532
1533         * DumpRenderTree/DumpRenderTree.gypi:
1534         * DumpRenderTree/chromium/DRTTestRunner.cpp: Removed.
1535         * DumpRenderTree/chromium/DRTTestRunner.h: Removed.
1536         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1537         (WebTestRunner::WebTestDelegate::testFinished):
1538         (WebTestRunner::WebTestDelegate::testTimedOut):
1539         (WebTestRunner::WebTestDelegate::isBeingDebugged):
1540         (WebTestRunner::WebTestDelegate::layoutTestTimeout):
1541         (WebTestRunner::WebTestDelegate::closeRemainingWindows):
1542         (WebTestRunner::WebTestDelegate::navigationEntryCount):
1543         (WebTestRunner::WebTestDelegate::windowCount):
1544         (WebTestRunner::WebTestDelegate::setCustomPolicyDelegate):
1545         (WebTestRunner::WebTestDelegate::waitForPolicyDelegate):
1546         (WebTestRunner::WebTestDelegate::goToOffset):
1547         (WebTestRunner::WebTestDelegate::reload):
1548         (WebTestRunner::WebTestDelegate::loadURLForFrame):
1549         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1550         (WebTestRunner::WebTestRunner::policyDelegateDone):
1551         (WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
1552         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1553         (WebTestRunner::TestRunner::WorkQueue::~WorkQueue):
1554         (WebTestRunner):
1555         (WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
1556         (WebTestRunner::TestRunner::WorkQueue::processWork):
1557         (WebTestRunner::TestRunner::WorkQueue::reset):
1558         (WebTestRunner::TestRunner::WorkQueue::addWork):
1559         (WebTestRunner::TestRunner::TestRunner):
1560         (WebTestRunner::TestRunner::reset):
1561         (WebTestRunner::TestRunner::policyDelegateDone):
1562         (WebTestRunner::TestRunner::shouldInterceptPostMessage):
1563         (WebTestRunner::TestRunner::waitUntilDone):
1564         (WebTestRunner::TestRunner::notifyDone):
1565         (WebTestRunner::TestRunner::completeNotifyDone):
1566         (WorkItemBackForward):
1567         (WebTestRunner::WorkItemBackForward::WorkItemBackForward):
1568         (WebTestRunner::WorkItemBackForward::run):
1569         (WebTestRunner::TestRunner::queueBackNavigation):
1570         (WebTestRunner::TestRunner::queueForwardNavigation):
1571         (WorkItemReload):
1572         (WebTestRunner::WorkItemReload::run):
1573         (WebTestRunner::TestRunner::queueReload):
1574         (WorkItemLoadingScript):
1575         (WebTestRunner::WorkItemLoadingScript::WorkItemLoadingScript):
1576         (WebTestRunner::WorkItemLoadingScript::run):
1577         (WorkItemNonLoadingScript):
1578         (WebTestRunner::WorkItemNonLoadingScript::WorkItemNonLoadingScript):
1579         (WebTestRunner::WorkItemNonLoadingScript::run):
1580         (WebTestRunner::TestRunner::queueLoadingScript):
1581         (WebTestRunner::TestRunner::queueNonLoadingScript):
1582         (WorkItemLoad):
1583         (WebTestRunner::WorkItemLoad::WorkItemLoad):
1584         (WebTestRunner::WorkItemLoad::run):
1585         (WebTestRunner::TestRunner::queueLoad):
1586         (WorkItemLoadHTMLString):
1587         (WebTestRunner::WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1588         (WebTestRunner::WorkItemLoadHTMLString::run):
1589         (WebTestRunner::TestRunner::queueLoadHTMLString):
1590         (WebTestRunner::TestRunner::locationChangeDone):
1591         (WebTestRunner::TestRunner::windowCount):
1592         (WebTestRunner::TestRunner::setCloseRemainingWindowsWhenComplete):
1593         (WebTestRunner::TestRunner::setCustomPolicyDelegate):
1594         (WebTestRunner::TestRunner::waitForPolicyDelegate):
1595         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1596         (TestRunner):
1597         (WorkItem):
1598         (WebTestRunner::TestRunner::WorkItem::~WorkItem):
1599         (WorkQueue):
1600         (WebTestRunner::TestRunner::WorkQueue::WorkQueue):
1601         (WebTestRunner::TestRunner::WorkQueue::setFrozen):
1602         (WebTestRunner::TestRunner::WorkQueue::isEmpty):
1603         (WebTestRunner::TestRunner::WorkQueue::taskList):
1604         * DumpRenderTree/chromium/TestShell.cpp:
1605         (TestShell::initialize):
1606         (TestShell::runFileTest):
1607         (TestShell::loadURL):
1608         (TestShell::createNewWindow):
1609         * DumpRenderTree/chromium/TestShell.h:
1610         (TestShell::testRunner):
1611         (TestShell):
1612         * DumpRenderTree/chromium/WebViewHost.cpp:
1613         (WebViewHost::testFinished):
1614         (WebViewHost::testTimedOut):
1615         (WebViewHost::isBeingDebugged):
1616         (WebViewHost::layoutTestTimeout):
1617         (WebViewHost::closeRemainingWindows):
1618         (WebViewHost::navigationEntryCount):
1619         (WebViewHost::windowCount):
1620         (WebViewHost::setCustomPolicyDelegate):
1621         (WebViewHost::waitForPolicyDelegate):
1622         (WebViewHost::goToOffset):
1623         (WebViewHost::reload):
1624         (WebViewHost::loadURLForFrame):
1625         (WebViewHost::shutdown):
1626         (WebViewHost::testRunner):
1627         * DumpRenderTree/chromium/WebViewHost.h:
1628         (WebTestRunner):
1629         (WebViewHost):
1630
1631 2013-01-28  Timothy Loh  <timloh@chromium.com>
1632
1633         Refactor ChangeLog and PrepareChangeLog to use FileSystem objects
1634         https://bugs.webkit.org/show_bug.cgi?id=107903
1635
1636         Reviewed by Eric Seidel.
1637
1638         To make ChangeLog and PrepareChangeLog easier to test, we can use
1639         FileSystem objects instead of just passing around paths.
1640
1641         * Scripts/webkitpy/common/checkout/changelog.py:
1642         (ChangeLog.__init__):
1643         (ChangeLog.parse_latest_entry_from_file):
1644         (ChangeLog.parse_entries_from_file):
1645         (ChangeLog.latest_entry):
1646         (ChangeLog.update_with_unreviewed_message):
1647         (ChangeLog.set_reviewer):
1648         (ChangeLog.set_short_description_and_bug_url):
1649         (ChangeLog.delete_entries):
1650         (ChangeLog.prepend_text):
1651         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1652         (ChangeLogTest):
1653         (test_parse_log_entries_from_changelog):
1654         (test_latest_entry_parse_single_entry):
1655         (test_set_reviewer):
1656         (test_set_short_description_and_bug_url):
1657         (test_delete_entries):
1658         (test_prepend_text):
1659         * Scripts/webkitpy/common/system/filesystem_mock.py:
1660         (ReadableTextFileObject.__init__):
1661         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1662         (PrepareChangeLog._ensure_bug_url):
1663         (PrepareChangeLog._resolve_existing_entry):
1664         (PrepareChangeLog.run):
1665         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1666         (test_ensure_bug_url):
1667         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1668         (_assert_message_for_revert_output):
1669
1670 2013-01-28  Raymond Toy  <rtoy@google.com>
1671
1672         Add myself to committers.py
1673         https://bugs.webkit.org/show_bug.cgi?id=107992
1674
1675         Reviewed by kbr@google.com.
1676
1677         * Scripts/webkitpy/common/config/committers.py:
1678
1679 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1680
1681         [Mac] Update PageVisibilityState when WebView is hidden / visible
1682         https://bugs.webkit.org/show_bug.cgi?id=107509
1683
1684         Reviewed by Sam Weinig.
1685
1686         Add a test that PageVisibility of WK1 WebViews and WK2 WKViews
1687         automatically changes between hidden and visible as the view is added
1688         and removed from window, or when it is in a window that changes
1689         visibility, for instance by minimizing / deminimizing.
1690
1691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1692         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html: Added.
1693         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Added.
1694         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1695         (runJavaScriptAlert):
1696         (PageVisibilityStateWithWindowChanges):
1697         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
1698         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
1699         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1700         (TestWebKitAPI::TEST_F):
1701         Test visibility state of a page in a WebView/WKView with different window states.
1702
1703         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
1704         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1705         (TestWebKitAPI::WebKitAgnosticTest::teardownView):
1706         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1707         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1708         Add a WK1 and WK2 teardownView to balance initializeView.
1709
1710 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1711
1712         Improve PageVisibility API with enums
1713         https://bugs.webkit.org/show_bug.cgi?id=107364
1714
1715         Reviewed by Sam Weinig.
1716
1717         * DumpRenderTree/mac/TestRunnerMac.mm:
1718         (TestRunner::resetPageVisibility):
1719         (TestRunner::setPageVisibility):
1720         Update the WK1 test code to use the new WK1 enums.
1721
1722         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1723         (WTR::InjectedBundle::setVisibilityState):
1724         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1725         (InjectedBundle):
1726         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1727         (WTR::TestRunner::setPageVisibility):
1728         (WTR::TestRunner::resetPageVisibility):
1729         * WebKitTestRunner/TestController.cpp:
1730         (WTR::TestController::setVisibilityState):
1731         * WebKitTestRunner/TestController.h:
1732         (TestController):
1733         * WebKitTestRunner/TestInvocation.cpp:
1734         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1735         Update the WK2 test code to use the new WK2 API and enums.
1736
1737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1738         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Added.
1739         (TestWebKitAPI):
1740         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
1741         (TestWebKitAPI::assertSerializedScriptValueIsStringValue):
1742         (TestWebKitAPI::didRunStep1StateChangeVisibleToHidden):
1743         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
1744         (TestWebKitAPI::didRunStep3StateChangePrerenderToPreview):
1745         (TestWebKitAPI::didRunStep4InStatePreview):
1746         (TestWebKitAPI::TEST):
1747         Test the new WK2 API with all enum types.
1748
1749 2013-01-28  Jochen Eisinger  <jochen@chromium.org>
1750
1751         [chromium] remove temporary define used for updating TestRunner API
1752
1753         Unreviewed. Clean-up change.
1754
1755         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1756
1757 2013-01-28  James Craig  <james@cookiecrook.com>
1758
1759         HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
1760         https://bugs.webkit.org/show_bug.cgi?id=107650
1761
1762         Reviewed by Chris Fleizach.
1763
1764         Updating accessibility strings and accessors for DL/DT/DD.
1765
1766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
1767         (createDescriptionList):
1768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1769         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1770
1771 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
1772
1773         [GTK][WTR] Update layoutTestController.pathToLocalResource
1774         https://bugs.webkit.org/show_bug.cgi?id=107538
1775
1776         Reviewed by Martin Robinson.
1777
1778         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1779         (WTR::TestRunner::pathToLocalResource): Update implementation based on
1780         DRT code.
1781
1782 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
1783
1784         [GTK][WTR] Move getTopLevelPath() to utilities file
1785         https://bugs.webkit.org/show_bug.cgi?id=107541
1786
1787         Reviewed by Martin Robinson.
1788
1789         * WebKitTestRunner/GNUmakefile.am: Add new files.
1790         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1791         (WTR::getOutputDir): Uses the moved method from InjectedBundleUtilities.
1792         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp: Added.
1793         (WTR):
1794         (WTR::topLevelPath): Implementation moved from ActivateFontsGtk.
1795         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h: Added.
1796         (WTR): Add new method header and documentation.
1797
1798 2013-01-28  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1799
1800         [EFL] Include Ecore_Getopt.h in MiniBrowser.
1801         https://bugs.webkit.org/show_bug.cgi?id=108067
1802
1803         Reviewed by Kenneth Rohde Christiansen.
1804
1805         Be explicit and include Ecore_Getopt.h since we use it for parsing
1806         command line options. It is safer than relying on other headers
1807         including it for us.
1808
1809         * MiniBrowser/efl/main.c:
1810
1811 2013-01-28  Renata Hodovan  <reni@webkit.org>
1812
1813         [WK2] Putting QtWebProcess into a chrooted sandbox
1814         https://bugs.webkit.org/show_bug.cgi?id=90005
1815
1816         Reviewed by Anders Carlsson and  Zoltan Herczeg.
1817
1818         Add feature flag for suid sandbox in linux.
1819
1820         * Scripts/webkitperl/FeatureList.pm:
1821
1822 2013-01-27  David Farler  <dfarler@apple.com>
1823
1824         REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
1825         https://bugs.webkit.org/show_bug.cgi?id=108028
1826
1827         Reviewed by Dan Bernstein.
1828
1829         * DumpRenderTree/Makefile: Reverted.
1830         * Makefile: Reverted.
1831         * Scripts/webkitdirs.pm: Reverted.
1832
1833 2013-01-27  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
1834
1835         Fixing atomicIncrement implementation for Windows by dropping support before XP SP2.
1836         https://bugs.webkit.org/show_bug.cgi?id=106740
1837
1838         Reviewed by Benjamin Poulain.
1839
1840         * DumpRenderTree/config.h:
1841         * WinLauncher/stdafx.h:
1842
1843 2013-01-26  David Farler  <dfarler@apple.com>
1844
1845         Makefiles should work for arbitrary SDKs and architectures on Apple ports
1846         https://bugs.webkit.org/show_bug.cgi?id=107863
1847
1848         Reviewed by David Kilzer.
1849
1850         * Makefile:
1851         Added temporary filters for projects not yet building on iOS.
1852         * DumpRenderTree/Makefile:
1853         Building with iOS SDKs -> -target All-iOS
1854         * Scripts/webkitdirs.pm:
1855         (determineConfiguration):
1856         Added --configuration switch detection.
1857         (determineArchitecture):
1858         Added --architecture and ARCH=(.*) switch detection.
1859         (argumentsForConfiguration):
1860         (determineXcodeSDK):
1861         Look for --device, --simulator, and --sdk switches.
1862         (xcodeSDK):
1863         Added.
1864         (XcodeOptions):
1865         Determine Xcode SDK and generate -arch switches.
1866
1867 2013-01-25  Jochen Eisinger  <jochen@chromium.org>
1868
1869         [chromium] move tracking of the top loading frame to TestRunner library
1870         https://bugs.webkit.org/show_bug.cgi?id=107948
1871
1872         Reviewed by Adam Barth.
1873
1874         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1875         (DRTTestRunner::WorkQueue::processWorkSoon):
1876         (DRTTestRunner::WorkQueue::processWork):
1877         (DRTTestRunner::completeNotifyDone):
1878         * DumpRenderTree/chromium/DRTTestRunner.h:
1879         (DRTTestRunner):
1880         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1881         (WebTestProxyBase):
1882         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1883         (WebTestRunner::WebTestRunner::setTopLoadingFrame):
1884         (WebTestRunner::WebTestRunner::topLoadingFrame):
1885         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1886         (WebTestRunner::TestRunner::TestRunner):
1887         (WebTestRunner::TestRunner::reset):
1888         (WebTestRunner::TestRunner::setTopLoadingFrame):
1889         (WebTestRunner):
1890         (WebTestRunner::TestRunner::topLoadingFrame):
1891         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1892         (TestRunner):
1893         (WebTestRunner::TestRunner::locationChangeDone):
1894         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1895         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
1896         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
1897         (WebTestRunner::WebTestProxyBase::didFailLoad):
1898         (WebTestRunner::WebTestProxyBase::didFinishLoad):
1899         (WebTestRunner::WebTestProxyBase::locationChangeDone):
1900         (WebTestRunner):
1901         * DumpRenderTree/chromium/WebViewHost.cpp:
1902         (WebViewHost::reset):
1903         (WebViewHost::updateURL):
1904         * DumpRenderTree/chromium/WebViewHost.h:
1905         (WebViewHost):
1906
1907 2013-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1908
1909         Unreviewed, rolling out r140774.
1910         http://trac.webkit.org/changeset/140774
1911         https://bugs.webkit.org/show_bug.cgi?id=107932
1912
1913          Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
1914         and fastScrollingForFixedPosition are failing (Requested by
1915         keishi on #webkit).
1916
1917         * DumpRenderTree/chromium/WebViewHost.cpp:
1918         (WebViewHost::initializeLayerTreeView):
1919         (WebViewHost::setWebWidget):
1920
1921 2013-01-25  Alan Cutter  <alancutter@chromium.org>
1922
1923         Quick fix for Chromium EWS bots running out of space due to a tmp file leak
1924         https://bugs.webkit.org/show_bug.cgi?id=107905
1925
1926         Reviewed by Eric Seidel.
1927
1928         Added line to EWS loop to clear /tmp of known Chromium test leak.
1929         Directories named ".org.chromium.Chromium.XXXXXX" not getting cleaned up.
1930
1931         * EWSTools/start-queue.sh:
1932
1933 2013-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1934
1935         Update Anne's email address
1936         https://bugs.webkit.org/show_bug.cgi?id=107866
1937
1938         Reviewed by Adam Barth.
1939
1940         * Scripts/webkitpy/common/config/committers.py:
1941
1942 2013-01-24  Alan Cutter  <alancutter@chromium.org>
1943
1944         HTTP 500 error between QueueStatusServer and bot(s)
1945         https://bugs.webkit.org/show_bug.cgi?id=107184
1946
1947         Reviewed by Adam Barth.
1948
1949         Removed the use of memcache which was the source of the exception.
1950
1951         * QueueStatusServer/handlers/updatestatus.py:
1952         (UpdateStatus.post):
1953         * QueueStatusServer/model/attachment.py:
1954         (Attachment):
1955         (Attachment.summary):
1956
1957 2013-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1958
1959         Unreviewed, rolling out r140653.
1960         http://trac.webkit.org/changeset/140653
1961         https://bugs.webkit.org/show_bug.cgi?id=107916
1962
1963         Causes a temp file leak on the bots (Requested by abarth on
1964         #webkit).
1965
1966         * DumpRenderTree/chromium/TestShell.cpp:
1967         (TestShell::resetTestController):
1968
1969 2013-01-24  Eric Seidel  <eric@webkit.org>
1970
1971         Skip haslanded_unittest.py on systems which do not have interdiff installed
1972         https://bugs.webkit.org/show_bug.cgi?id=106402
1973
1974         Unreviewed.
1975
1976         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1977         (HasLandedTest):
1978
1979 2013-01-24  Ryosuke Niwa  <rniwa@webkit.org>
1980
1981         Disable the failing webkitpy test for now.
1982
1983         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1984
1985 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
1986
1987         Fixing the diff_parser to correctly identify git diffs even with leading comments.
1988         https://bugs.webkit.org/show_bug.cgi?id=107871
1989
1990         Reviewed by Eric Seidel.
1991
1992         * Scripts/webkitpy/common/checkout/diff_parser.py:
1993         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1994         * Scripts/webkitpy/tool/steps/haslanded.py:
1995
1996 2013-01-24  James Robinson  <jamesr@chromium.org>
1997
1998         [chromium] Remove dead transitional code from WebViewImpl
1999         https://bugs.webkit.org/show_bug.cgi?id=107889
2000
2001         Reviewed by Adrienne Walker.
2002
2003         * DumpRenderTree/chromium/WebViewHost.cpp:
2004         (WebViewHost::initializeLayerTreeView):
2005         (WebViewHost::setWebWidget):
2006
2007 2013-01-24  Joshua Bell  <jsbell@chromium.org>
2008
2009         Add watchlist for IndexedDB development, and add myself and others.
2010
2011         Unreviewed.
2012
2013         * Scripts/webkitpy/common/config/watchlist:
2014
2015 2013-01-24  Martin Robinson  <mrobinson@igalia.com>
2016
2017         Abstract the logic for appending a UChar32 onto StringBuilder
2018         https://bugs.webkit.org/show_bug.cgi?id=107505
2019
2020         Reviewed by Darin Adler.
2021
2022         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2023         (TestWebKitAPI::TEST): Added a simple test for appending UChar32.
2024
2025 2013-01-24  Erik Arvidsson  <arv@chromium.org>
2026
2027         Unreviewed, rolling out r140703.
2028         http://trac.webkit.org/changeset/140703
2029         https://bugs.webkit.org/show_bug.cgi?id=107556
2030
2031         r140561 was not the reason for the Android breakage
2032
2033         * DumpRenderTree/chromium/TestShell.cpp:
2034         (TestShell::~TestShell):
2035         (TestShell::closeWindow):
2036         * DumpRenderTree/chromium/WebViewHost.cpp:
2037         (WebViewHost::WebViewHost):
2038         (WebViewHost::~WebViewHost):
2039         (WebViewHost::shutdown):
2040         * DumpRenderTree/chromium/WebViewHost.h:
2041         (WebViewHost):
2042
2043 2013-01-24  Dean Jackson  <dino@apple.com>
2044
2045         Allow some plugin snapshot UI content to come from Injected Bundle
2046         https://bugs.webkit.org/show_bug.cgi?id=107852
2047
2048         Reviewed by Anders Carlsson.
2049
2050         Null implementations of plugInStartLabelTitle, plugInStartLabelSubtitle and
2051         plugInExtraStyleSheet.
2052
2053         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2054         (WTR::InjectedBundlePage::InjectedBundlePage):
2055
2056 2013-01-24  Erik Arvidsson  <arv@chromium.org>
2057
2058         Unreviewed, rolling out r140561.
2059         http://trac.webkit.org/changeset/140561
2060         https://bugs.webkit.org/show_bug.cgi?id=107556
2061
2062         Suspected to break Android which prevens WebKit roll
2063
2064         * DumpRenderTree/chromium/TestShell.cpp:
2065         (TestShell::~TestShell):
2066         (TestShell::closeWindow):
2067         * DumpRenderTree/chromium/WebViewHost.cpp:
2068         (WebViewHost::WebViewHost):
2069         (WebViewHost::~WebViewHost):
2070         * DumpRenderTree/chromium/WebViewHost.h:
2071         (WebViewHost):
2072
2073 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
2074
2075         Adding "has-landed" command to webkit-patch which compares a
2076         committed patch to the changes which exist locally (ignoring the
2077         ChangeLog file).
2078
2079         https://bugs.webkit.org/show_bug.cgi?id=106402
2080
2081         Reviewed by Eric Seidel.
2082
2083         * Scripts/webkitpy/common/checkout/diff_parser.py:
2084         (git_diff_to_svn_diff):
2085         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2086         (Bug.commit_revision):
2087         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
2088         (BugTest.test_is_in_comments):
2089         (BugTest):
2090         (BugTest.test_commit_revision):
2091         * Scripts/webkitpy/tool/commands/upload.py:
2092         (HasLanded):
2093         * Scripts/webkitpy/tool/steps/__init__.py:
2094         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
2095         (HasLanded):
2096         (HasLanded.convert_to_svn):
2097         (HasLanded.strip_change_log):
2098         (run):
2099
2100         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2101         (Bug.commit_revision):
2102         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
2103         (BugTest.test_is_in_comments):
2104         (BugTest):
2105         (BugTest.test_commit_revision):
2106         * Scripts/webkitpy/tool/commands/upload.py:
2107         (HasLanded):
2108         * Scripts/webkitpy/tool/steps/__init__.py:
2109         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
2110         (HasLanded):
2111         (HasLanded.convert_to_svn):
2112         (HasLanded.strip_change_log):
2113         (HasLanded.diff_diff):
2114         (HasLanded.run):
2115         * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
2116         (HasLandedTest):
2117         (HasLandedTest.test_run):
2118         (test_convert_to_svn_and_strip_change_log):
2119
2120 2013-01-24  Dan Carney  <dcarney@google.com>
2121
2122         [chromium] move most WebViewHost printf calls to WebTestProxy
2123         https://bugs.webkit.org/show_bug.cgi?id=107553
2124
2125         Reviewed by Jochen Eisinger.
2126
2127         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2128         (WebKit):
2129         (WebTestProxyBase):
2130         (WebTestRunner::WebTestProxy::unableToImplementPolicyWithError):
2131         (WebTestRunner::WebTestProxy::didAddMessageToConsole):
2132         (WebTestRunner::WebTestProxy::runModalAlertDialog):
2133         (WebTestRunner::WebTestProxy::runModalConfirmDialog):
2134         (WebTestRunner::WebTestProxy::runModalPromptDialog):
2135         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
2136         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2137         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
2138         (WebTestRunner::WebTestProxyBase::reset):
2139         (WebTestRunner::WebTestProxyBase::setLogConsoleOutput):
2140         (WebTestRunner):
2141         (WebTestRunner::WebTestProxyBase::unableToImplementPolicyWithError):
2142         (WebTestRunner::WebTestProxyBase::didAddMessageToConsole):
2143         (WebTestRunner::WebTestProxyBase::runModalAlertDialog):
2144         (WebTestRunner::WebTestProxyBase::runModalConfirmDialog):
2145         (WebTestRunner::WebTestProxyBase::runModalPromptDialog):
2146         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
2147         * DumpRenderTree/chromium/TestShell.cpp:
2148         (TestShell::showDevTools):
2149         * DumpRenderTree/chromium/WebViewHost.cpp:
2150         (WebViewHost::didAddMessageToConsole):
2151         (WebViewHost::runModalAlertDialog):
2152         (WebViewHost::runModalConfirmDialog):
2153         (WebViewHost::runModalPromptDialog):
2154         (WebViewHost::runModalBeforeUnloadDialog):
2155         (WebViewHost::unableToImplementPolicyWithError):
2156         (WebViewHost::reset):
2157         * DumpRenderTree/chromium/WebViewHost.h:
2158         (WebViewHost):
2159
2160 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
2161
2162         [Chromium] Give webkit_support a chance to reset state between layout test runs
2163         https://bugs.webkit.org/show_bug.cgi?id=107132
2164
2165         Reviewed by Adam Barth.
2166
2167         We currently only have need for this on OS(ANDROID), but now it
2168         would be useful to have a hook for resetting state on all
2169         platforms. Will soon be using this for IDBFactory initialization.
2170
2171         * DumpRenderTree/chromium/TestShell.cpp:
2172         (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
2173
2174 2013-01-23  Alan Cutter  <alancutter@chromium.org>
2175
2176         QueueStatusServer crashes in production on next-patch
2177         https://bugs.webkit.org/show_bug.cgi?id=107775
2178
2179         Reviewed by Adam Barth.
2180
2181         Replaced Python 2.5 incompatible call to timedelta.total_seconds().
2182
2183         * QueueStatusServer/app.yaml:
2184         * QueueStatusServer/model/patchlog.py:
2185         (PatchLog.calculate_wait_duration):
2186         (PatchLog.calculate_process_duration):
2187         (PatchLog):
2188         (PatchLog._time_delta_to_seconds):
2189
2190 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2191
2192         The previous patch wasn't complete. Finish reverting r139998 for real.
2193
2194         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2195         (ProfilerAgent.getProfile):
2196
2197 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2198
2199         Revert r139998 for now since the Leaks Viewer pulls in a specific version of Inspector code.
2200
2201         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2202         (ProfilerAgent.getProfile):
2203
2204 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
2205
2206         [Chromium] Remove unused header files in chromium/public/platform/
2207         https://bugs.webkit.org/show_bug.cgi?id=107741
2208
2209         Reviewed by James Robinson.
2210
2211         These header files have migrated to the new Platform directory.
2212         This patch updates the remaining #include references and removes
2213         the old files that did nothing but redirect to the new ones.
2214
2215         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
2216         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
2217
2218 2013-01-23  Martin Robinson  <mrobinson@igalia.com>
2219
2220         [GTK] Bump webkitgtk-test-fonts dependency to cover fallbacks for Tamil, Bengali, and others
2221         https://bugs.webkit.org/show_bug.cgi?id=107727
2222
2223         Reviewed by Gustavo Noronha Silva.
2224
2225         * gtk/jhbuild.modules: Update the JHBuild moduleset to point to the new webkitgtk-test-fonts.
2226         We are using the git repository now that github has deprecated the downloads feature.
2227
2228 2013-01-23  Tony Chang  <tony@chromium.org>
2229
2230         Unreviewed, set svn:eol-style to CRLF on Windows .sln files.
2231
2232         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2233         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2234         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2235         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
2236
2237 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
2238
2239         [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
2240         https://bugs.webkit.org/show_bug.cgi?id=107145
2241
2242         Reviewed by Adam Barth.
2243
2244         Part of a larger refactoring series; see tracking bug 82948.
2245         
2246         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2247         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2248         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2249         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2250         * DumpRenderTree/chromium/DRTTestRunner.h:
2251         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
2252         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2253         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
2254         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2255         * DumpRenderTree/chromium/TestNavigationController.h:
2256         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
2257         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2258         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
2259         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2260         (WebTestRunner):
2261         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
2262         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
2263         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2264         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2265         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2266         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2267         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
2268         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
2269         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
2270         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2271         * DumpRenderTree/chromium/TestShell.cpp:
2272         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2273         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2274         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2275         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2276         * DumpRenderTree/chromium/WebViewHost.cpp:
2277
2278 2013-01-23  Jochen Eisinger  <jochen@chromium.org>
2279
2280         [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html
2281         https://bugs.webkit.org/show_bug.cgi?id=107556
2282
2283         Reviewed by Tony Chang.
2284
2285         WebViewHost initiates a navigation to about:blank in its destructor.
2286         However, since WebTestProxy inherits from WebViewHost, at this point
2287         the WebViewClient and WebFrameClient interfaces are already partially
2288         destructed resulting in the use after free.
2289
2290         This does not affect the chromium implementation since it doesn't
2291         invoke WebKit API methods in its destructor.
2292
2293         * DumpRenderTree/chromium/TestShell.cpp:
2294         (TestShell::~TestShell):
2295         (TestShell::closeWindow):
2296         * DumpRenderTree/chromium/WebViewHost.cpp:
2297         (WebViewHost::WebViewHost):
2298         (WebViewHost::~WebViewHost):
2299         (WebViewHost::shutdown):
2300         * DumpRenderTree/chromium/WebViewHost.h:
2301         (WebViewHost):
2302
2303 2013-01-23  Andrei Bucur  <abucur@adobe.com>
2304
2305         [CSS Regions] Create Regions watchlist
2306         https://bugs.webkit.org/show_bug.cgi?id=107281
2307
2308         Reviewed by Adam Barth.
2309
2310         This patch adds 4 new definitions:
2311         - RegionsDevelopment - used to track the development progress for regions
2312         - RegionsExpectationsMore and RegionsExpectationsLess - used to track expectations changes for the regions tests
2313         - RegionsUsage - used to track changes that make use of regions in all the code base
2314
2315         For now, the Adobe internal tracker is the only email address listening for these patterns.
2316
2317         * Scripts/webkitpy/common/config/watchlist:
2318
2319 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
2320
2321         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
2322         https://bugs.webkit.org/show_bug.cgi?id=107523
2323
2324         Reviewed by Yury Semikhatsky.
2325
2326         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2327         (DRTDevToolsClient::isUnderTest):
2328         (DRTDevToolsClient::call):
2329         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2330         (DRTDevToolsClient):
2331
2332 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
2333
2334         Removing command line shortening as it makes it difficult to see the command during errors.
2335         https://bugs.webkit.org/show_bug.cgi?id=107643
2336
2337         Reviewed by Eric Seidel.
2338
2339         * Scripts/webkitpy/common/system/executive.py:
2340         (ScriptError):
2341         (ScriptError.__init__):
2342         * Scripts/webkitpy/common/system/executive_unittest.py:
2343
2344 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
2345
2346         Adding myself as contributor in committers.py (as requested by eseidel).
2347         https://bugs.webkit.org/show_bug.cgi?id=107647
2348
2349         Reviewed by Eric Seidel.
2350
2351         * Scripts/webkitpy/common/config/committers.py:
2352
2353 2013-01-22  Alan Cutter  <alancutter@chromium.org>
2354
2355         Add monitoring of patches and queues to the QueueStatusServer
2356         https://bugs.webkit.org/show_bug.cgi?id=107612
2357
2358         Reviewed by Adam Barth.
2359
2360         Created classes for recording events into the datastore and integrated them into the existing handlers.
2361         Code for presenting the recorded data will come in a separate patch.
2362
2363         * QueueStatusServer/app.yaml:
2364         * QueueStatusServer/config/__init__.py: Added.
2365         * QueueStatusServer/config/logging.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
2366         * QueueStatusServer/config/messages.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
2367         * QueueStatusServer/handlers/nextpatch.py:
2368         (NextPatch.get):
2369         (NextPatch._assign_patch):
2370         * QueueStatusServer/handlers/releasepatch.py:
2371         (ReleasePatch.post):
2372         * QueueStatusServer/handlers/updatestatus.py:
2373         (UpdateStatus.post):
2374         * QueueStatusServer/handlers/updateworkitems.py:
2375         (UpdateWorkItems._parse_work_items_string):
2376         (UpdateWorkItems):
2377         (UpdateWorkItems._update_work_items_from_request):
2378         (UpdateWorkItems._queue_from_request):
2379         (UpdateWorkItems.post):
2380         * QueueStatusServer/loggers/__init__.py: Added.
2381         * QueueStatusServer/loggers/recordbotevent.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
2382         (RecordBotEvent):
2383         (RecordBotEvent.activity):
2384         * QueueStatusServer/loggers/recordpatchevent.py: Added.
2385         (RecordPatchEvent):
2386         (RecordPatchEvent.added):
2387         (RecordPatchEvent.retrying):
2388         (RecordPatchEvent.started):
2389         (RecordPatchEvent.stopped):
2390         (RecordPatchEvent.updated):
2391         (RecordPatchEvent._get_patches_waiting):
2392         * QueueStatusServer/model/patchlog.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
2393         (PatchLog):
2394         (PatchLog.lookup):
2395         (PatchLog.calculate_wait_duration):
2396         (PatchLog.calculate_process_duration):
2397         * QueueStatusServer/model/queuelog.py: Copied from Tools/QueueStatusServer/handlers/nextpatch.py.
2398         (QueueLog):
2399         (QueueLog.get_current):
2400         (QueueLog.create_key):
2401         * QueueStatusServer/model/queuestatus.py:
2402         (QueueStatus.is_retry_request):
2403
2404 2013-01-22  Timothy Loh  <timloh@chromium.com>
2405
2406         prepare-Changelog should support updating the list of changed files
2407         https://bugs.webkit.org/show_bug.cgi?id=74358
2408
2409         Reviewed by Eric Seidel.
2410
2411         Needing to re-make ChangeLog entries when the list of files/functions
2412         changes is a bit annoying, it'd be nice to have this more automated.
2413         This patch makes `webkit-patch update' update the date line and bug
2414         description if needed, and if the list of changed files/functions has
2415         changed, either updates the list (if there are no annotations), or
2416         otherwise appends the new list below.
2417
2418         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2419         (PrepareChangeLog._resolve_existing_entry):
2420         (PrepareChangeLog):
2421         (PrepareChangeLog._merge_entries):
2422         (PrepareChangeLog.run):
2423         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2424         (PrepareChangeLogTest.test_resolve_existing_entry):
2425         (make_entry):
2426         (test_ensure_bug_url):
2427
2428 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
2429
2430         Use Python 2.7 unittest syntax in our unittests
2431         https://bugs.webkit.org/show_bug.cgi?id=105607
2432
2433         Reviewed by Eric Seidel.
2434
2435         * Scripts/webkitpy/**/*_unittest.py:
2436
2437 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
2438
2439         Convert disable-msg to disable for new pylint.
2440         https://bugs.webkit.org/show_bug.cgi?id=107627
2441
2442         Reviewed by Eric Seidel.
2443
2444         * Scripts/webkitpy/common/checkout/scm/svn.py:
2445         (SVNRepository.has_authorization_for_realm):
2446         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2447         (Builder.force_build):
2448         * Scripts/webkitpy/common/system/executive_mock.py:
2449         (MockExecutive2.run_command):
2450         * Scripts/webkitpy/layout_tests/port/base.py:
2451         (Port.reference_files):
2452         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2453         (ChromiumPortTestCase.test_default_configuration):
2454         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2455         (PortTestCase.test_expectations_ordering):
2456         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2457         (HttpServerBase._check_that_all_ports_are_available):
2458         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
2459         (AbstractLocalServerCommand.execute):
2460         * Scripts/webkitpy/tool/commands/download.py:
2461         (AbstractPatchProcessingCommand):
2462         * Scripts/webkitpy/tool/commands/rebaseline.py:
2463         (AbstractRebaseliningCommand):
2464         (AbstractParallelRebaselineCommand):
2465         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2466         (_BaseTestCase.setUp):
2467         (TestAnalyzeBaselines.setUp):
2468
2469 2013-01-22  Frank Farzan  <frankf@chromium.org>
2470
2471         Flakiness dashboard: update builders.jsonp
2472         https://bugs.webkit.org/show_bug.cgi?id=107610
2473
2474         Reviewed by Ojan Vafai.
2475
2476         * TestResultServer/static-dashboards/builders.jsonp:
2477
2478 2013-01-22  Frank Farzan  <frankf@chromium.org>
2479
2480         Add Android instrumentation tests from ChromiumLinux waterfall
2481         https://bugs.webkit.org/show_bug.cgi?id=107597
2482
2483         Reviewed by Ojan Vafai.
2484
2485         * TestResultServer/static-dashboards/builders.js:
2486         (loadBuildersList):
2487
2488 2013-01-21  Kentaro Hara  <haraken@chromium.org>
2489
2490         Implement UIEvent constructor
2491         https://bugs.webkit.org/show_bug.cgi?id=107430
2492
2493         Reviewed by Adam Barth.
2494
2495         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
2496
2497         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
2498         which is enabled on Safari and Chromium for now.
2499
2500         * Scripts/webkitperl/FeatureList.pm:
2501
2502 2013-01-22  Timothy Loh  <timloh@chromium.com>
2503
2504         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
2505         https://bugs.webkit.org/show_bug.cgi?id=107478
2506
2507         Reviewed by Eric Seidel.
2508
2509         On the road to resolving Bug 74358, we need a few more functions in
2510         changelog.py.
2511         To make things easier to mock, change @staticmethods to @classmethods.
2512
2513         * Scripts/webkitpy/common/checkout/changelog.py:
2514         (ChangeLogEntry):
2515         (ChangeLogEntry._parse_reviewer_text):
2516         (ChangeLogEntry._split_contributor_names):
2517         (ChangeLogEntry._parse_author_name_and_email):
2518         (ChangeLogEntry._parse_author_text):
2519         (ChangeLogEntry._parse_touched_functions):
2520         (ChangeLogEntry._parse_bug_description):
2521         (ChangeLogEntry._parse_entry):
2522         (ChangeLogEntry.date_line):
2523         (ChangeLogEntry.bug_description):
2524         (ChangeLogEntry.touched_functions):
2525         (ChangeLogEntry.touched_files_text):
2526         (ChangeLogEntry.is_touched_files_text_clean):
2527         (ChangeLog):
2528         (ChangeLog.parse_latest_entry_from_file):
2529         (ChangeLog._separate_revision_and_line):
2530         (ChangeLog.parse_entries_from_file):
2531         (ChangeLog.set_short_description_and_bug_url):
2532         (ChangeLog.delete_entries):
2533         (ChangeLog.prepend_text):
2534         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2535         (test_parse_log_entries_from_changelog):
2536         (test_latest_entry_parse):
2537         (test_set_short_description_and_bug_url):
2538         (test_delete_entries):
2539         (test_prepend_text):
2540
2541 2013-01-22  Lucas Forschler  <lforschler@apple.com>
2542
2543         Create a MAC EWS startup shell script.
2544
2545         Reviewed by Ryosuke Niwa.
2546
2547         * EWSTools/start-queue-mac.sh: Added.
2548
2549 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
2550
2551         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
2552         https://bugs.webkit.org/show_bug.cgi?id=107230
2553
2554         Reviewed by David Kilzer.
2555
2556         * DumpRenderTree/mac/TestRunnerMac.mm:
2557         (TestRunner::resetPageVisibility):
2558         Fix a typo in the original implementation. resetPageVisibility should
2559         pass initialState YES so an event is not dispatched, which causes
2560         issues in multiple tests. This now matches other ports.
2561
2562 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
2563
2564         [GTK] Enable CSS Image Orientation feature
2565         https://bugs.webkit.org/show_bug.cgi?id=99040
2566
2567         Reviewed by Martin Robinson.
2568
2569         Enable the CSS Image Orientation feature in the development
2570         builds of the GTK port. The feature is still disabled in the release
2571         builds.
2572
2573         * Scripts/webkitperl/FeatureList.pm:
2574
2575 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
2576
2577         [GTK] Enable the <template> element support in development builds
2578         https://bugs.webkit.org/show_bug.cgi?id=106575
2579
2580         Reviewed by Martin Robinson.
2581
2582         Enable the <template> element support in the development builds of the GTK port.
2583
2584         * Scripts/webkitperl/FeatureList.pm:
2585
2586 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
2587
2588         Prettify the output of the override-feature-defines script
2589         https://bugs.webkit.org/show_bug.cgi?id=106542
2590
2591         Reviewed by Martin Robinson.
2592
2593         The output now clearly lists the feature defines being overridden
2594         along with the default and overriding values for each feature define.
2595
2596         * gtk/override-feature-defines:
2597         (adjust_feature_defines_makefile):
2598         (adjust_feature_defines_makefile.override_feature_define):
2599
2600 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
2601
2602         Remove uses of deprecated unittest.TestCase aliases
2603         https://bugs.webkit.org/show_bug.cgi?id=102252
2604
2605         Reviewed by Adam Barth.
2606
2607         Replace the deprecated assertEquals method of the TestCase interface
2608         used in some webkitpy unittests with the assertEqual method.
2609
2610         * Scripts/webkitpy/common/system/profiler_unittest.py:
2611         (ProfilerFactoryTest._assert_default_profiler_name):
2612         (ProfilerFactoryTest.test_default_profiler_output):
2613         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2614         (GtkPortTest.test_expectations_files):
2615         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2616         (TestHttpServer.test_win32_start_and_stop):
2617
2618 2013-01-22  Jer Noble  <jer.noble@apple.com>
2619
2620         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
2621         https://bugs.webkit.org/show_bug.cgi?id=107562
2622
2623         Rubber-stamped by Alexy Proskuryakov.
2624
2625         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
2626
2627         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2628         (WTR::PlatformWebView::PlatformWebView):
2629         (WTR::PlatformWebView::viewSupportsOptions):
2630
2631 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
2632
2633         One is not allowed to use commit-queue to make oneself a committer.
2634
2635         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
2636
2637 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
2638
2639         Add myself to commiters.py
2640         https://bugs.webkit.org/show_bug.cgi?id=107546
2641
2642         Reviewed by Kentaro Hara.
2643
2644         * Scripts/webkitpy/common/config/committers.py:
2645
2646 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
2647
2648         [GTK] Implement TestRunner::setTextDirection
2649         https://bugs.webkit.org/show_bug.cgi?id=107131
2650
2651         Reviewed by Philippe Normand.
2652
2653         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2654         (resetDefaultsToConsistentValues): Reset direction to default value.
2655         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2656         (TestRunner::setTextDirection): Implement method using
2657         gtk_widget_set_direction.
2658
2659 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
2660
2661         [chromium] move spell checking mocks to TestRunner library
2662         https://bugs.webkit.org/show_bug.cgi?id=107455
2663
2664         Reviewed by Kent Tamura.
2665
2666         The content module doesn't provide its own WebSpellCheckClient.
2667
2668         * DumpRenderTree/DumpRenderTree.gypi:
2669         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2670         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
2671         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2672         (WebKit):
2673         (WebTestRunner):
2674         (WebTestProxyBase):
2675         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2676         (WebTestRunner):
2677         (WebTestRunner::makeMenuItemStringsFor):
2678         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
2679         (MockGrammarCheck::checkGrammarOfString):
2680         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
2681         (WebKit):
2682         (MockGrammarCheck):
2683         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
2684         (MockSpellCheck::MockSpellCheck):
2685         (MockSpellCheck::~MockSpellCheck):
2686         (isNotASCIIAlpha):
2687         (MockSpellCheck::spellCheckWord):
2688         (MockSpellCheck::fillSuggestionList):
2689         (MockSpellCheck::initializeIfNeeded):
2690         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
2691         (MockSpellCheck):
2692         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
2693         (WebTestRunner::SpellCheckClient::SpellCheckClient):
2694         (WebTestRunner):
2695         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
2696         (WebTestRunner::SpellCheckClient::setDelegate):
2697         (WebTestRunner::SpellCheckClient::spellCheck):
2698         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
2699         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
2700         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
2701         (WebTestRunner::SpellCheckClient::autoCorrectWord):
2702         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
2703         (WebTestRunner):
2704         (SpellCheckClient):
2705         (WebTestRunner::SpellCheckClient::taskList):
2706         (WebTestRunner::SpellCheckClient::mockSpellCheck):
2707         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2708         (TestDelegate):
2709         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2710         (WebTestInterfaces::Internal):
2711         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2712         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
2713         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
2714         (WebTestRunner::WebTestProxyBase::setDelegate):
2715         (WebTestRunner::WebTestProxyBase::spellCheckClient):
2716         (WebTestRunner):
2717         * DumpRenderTree/chromium/WebViewHost.cpp:
2718         (WebViewHost::WebViewHost):
2719         (WebViewHost::setWebWidget):
2720         * DumpRenderTree/chromium/WebViewHost.h:
2721         (WebViewHost):
2722
2723 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
2724
2725         [EFL] Adds Accessibility support to wk1
2726         https://bugs.webkit.org/show_bug.cgi?id=107440
2727
2728         Reviewed by Gyuyoung Kim.
2729
2730         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
2731
2732 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
2733
2734         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
2735         https://bugs.webkit.org/show_bug.cgi?id=107506
2736
2737         Reviewed by Dan Bernstein.
2738
2739         * MiniBrowser/mac/WK1BrowserWindowController.m:
2740         (-[WK1BrowserWindowController dealloc]):
2741
2742 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
2743
2744         Add build flag for Canvas's Path object (disabled by default)
2745         https://bugs.webkit.org/show_bug.cgi?id=107473
2746
2747         Reviewed by Dean Jackson.
2748
2749         Add CANVAS_PATH build flag to build systems.
2750
2751         * Scripts/webkitperl/FeatureList.pm:
2752
2753 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
2754
2755         [EFL][WK2] Add APIs to set/get view source mode
2756         https://bugs.webkit.org/show_bug.cgi?id=106633
2757
2758         Reviewed by Gyuyoung Kim.
2759
2760         Added a shotcut 'F8' in Minibrowser to display a source code
2761         of the web page in a new window.
2762
2763        * MiniBrowser/efl/main.c:
2764         (on_key_down):
2765         (on_window_create):
2766         (window_create):
2767         (elm_main):
2768
2769 2013-01-21  Nico Weber  <thakis@chromium.org>
2770
2771         [chromium] Don't archive generated source files.
2772         https://bugs.webkit.org/show_bug.cgi?id=106736
2773
2774         Reviewed by Eric Seidel.
2775
2776         They shouldn't be needed to run tests. They don't need a lot of space,
2777         but add many lines to the "extracting" stdout. This attempts to reduce
2778         that noise a bit.
2779
2780         * BuildSlaveSupport/built-product-archive:
2781         (archiveBuiltProduct):
2782
2783 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
2784
2785         Mac DumpRenderTree's installSignalHandlers() is unreachable code
2786         https://bugs.webkit.org/show_bug.cgi?id=107383
2787
2788         Reviewed by Sam Weinig.
2789
2790         The CrashHandler of DumpRenderTree were originally used for restoring
2791         the color profile of the main display even if DRT crashes.
2792
2793         That feature was later limited to pixel tests only in r29999.
2794
2795         In r104351, the DRT was changed to use device color space. Making the crash
2796         handlers useless, but they were left in the code since the error reporting
2797         code was still reachable.
2798
2799         Later, r124581 refactored the code and dumpPixelsForCurrentTest
2800         is being used before being assigned its value.
2801         This did cause any regression because the code had become useless with the previous change.
2802
2803         * DumpRenderTree/mac/DumpRenderTree.mm:
2804         Remove crashHandler() and installSignalHandlers() as they have become useless and
2805         have been unreachable code for 6 months.
2806         (dumpRenderTree):
2807         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
2808         at those points.
2809
2810 2013-01-21  Nico Weber  <thakis@chromium.org>
2811
2812         Make ninja the default build system for build-webkit --chromium on mac
2813         https://bugs.webkit.org/show_bug.cgi?id=106737
2814
2815         Reviewed by Eric Seidel.
2816
2817         * Scripts/update-webkit-chromium:
2818
2819 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
2820
2821         Regression(r140262): Causes a lot of flakiness
2822         https://bugs.webkit.org/show_bug.cgi?id=107454
2823
2824         Reviewed by Alexey Proskuryakov.
2825
2826         r140262 introduced a lot of flakiness due to fixed layout mode
2827         not getting disabled on the view after being enabled for
2828         specific test cases. This patch makes sure fixed layout mode
2829         properly gets reset in WebKitTestRunner to avoid flakiness.
2830
2831         * WebKitTestRunner/TestInvocation.cpp:
2832         (WTR::updateLayoutType):
2833
2834 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
2835
2836         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
2837         https://bugs.webkit.org/show_bug.cgi?id=107421
2838
2839         Unreviewed build fix.
2840
2841         * Scripts/run-gtk-tests:
2842         (TestRunner): skip Resource tests.
2843
2844 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
2845
2846         [EFL][WKTR] platformRunUntil() should keep the main loop running
2847         https://bugs.webkit.org/show_bug.cgi?id=107442
2848
2849         Reviewed by Noam Rosenthal.
2850
2851         EFL's implementation of platformRunUntil() should keep the main loop
2852         running and avoid calling sleep() between calls to
2853         ecore_main_loop_iterate(). This call to sleep seems to be a source
2854         of deadlocks (see Bug 106884).
2855
2856         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2857         (WTR::TestController::platformRunUntil):
2858
2859 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
2860
2861         QtTestBrowser should provide way to clear selected elements
2862         https://bugs.webkit.org/show_bug.cgi?id=107437
2863
2864         Reviewed by Simon Hausmann.
2865
2866         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
2867         Invoke the clearSelection prior to highlighting new elements.
2868
2869         * QtTestBrowser/launcherwindow.cpp:
2870         (ElementHighlight):
2871         (LauncherWindow::createChrome):
2872         (LauncherWindow::selectElements):
2873         (LauncherWindow::clearSelection):
2874         * QtTestBrowser/launcherwindow.h:
2875         (LauncherWindow):
2876
2877 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
2878
2879         [chromium] move methods interacting with willSendRequest to TestRunner
2880         https://bugs.webkit.org/show_bug.cgi?id=107270
2881
2882         Reviewed by Kent Tamura.
2883
2884         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2885         (DRTTestRunner::DRTTestRunner):
2886         (DRTTestRunner::waitForPolicyDelegate):
2887         * DumpRenderTree/chromium/DRTTestRunner.h:
2888         (DRTTestRunner):
2889         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2890         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2891         (WebTestRunner::WebTestRunner::httpHeadersToClear):
2892         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
2893         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
2894         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2895         (WebTestRunner::TestRunner::TestRunner):
2896         (WebTestRunner::TestRunner::reset):
2897         (WebTestRunner::TestRunner::httpHeadersToClear):
2898         (WebTestRunner):
2899         (WebTestRunner::TestRunner::shouldBlockRedirects):
2900         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
2901         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
2902         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
2903         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
2904         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2905         (TestRunner):
2906         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2907         (WebTestRunner::WebTestProxyBase::willSendRequest):
2908         * DumpRenderTree/chromium/WebViewHost.cpp:
2909         (WebViewHost::willSendRequest):
2910         (WebViewHost::reset):
2911         * DumpRenderTree/chromium/WebViewHost.h:
2912         (WebViewHost):
2913
2914 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
2915
2916         [GTK] Stop building WebKit2 on GTK EWSs
2917         https://bugs.webkit.org/show_bug.cgi?id=107435
2918
2919         Reviewed by Philippe Normand.
2920
2921         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
2922         so stop building it on GTK EWSs.
2923
2924         * Scripts/webkitpy/common/config/ports.py:
2925         (GtkPort.build_webkit_command):
2926         * Scripts/webkitpy/common/config/ports_unittest.py:
2927         (DeprecatedPortTest.test_gtk_port):
2928
2929 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
2930
2931         MediaStream API: Update the RTCPeerConnection states to match the latest specification
2932         https://bugs.webkit.org/show_bug.cgi?id=107120
2933
2934         Reviewed by Adam Barth.
2935
2936         Updating mock to use the new states.
2937
2938         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2939         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
2940         (MockWebRTCPeerConnectionHandler::initialize):
2941         (MockWebRTCPeerConnectionHandler::updateICE):
2942
2943 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
2944
2945         Extend diff_parser to support the --full-index output.
2946         https://bugs.webkit.org/show_bug.cgi?id=107408
2947
2948         Reviewed by Maciej Stachowiak.
2949
2950         * Scripts/webkitpy/common/checkout/diff_parser.py:
2951         (git_diff_to_svn_diff):
2952         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
2953         (DiffParserTest):
2954         (DiffParserTest.test_git_diff_to_svn_diff):
2955         (git_diff_to_svn_diff):
2956
2957 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
2958
2959         Dragging over an element with scrollbars should scroll the element when dragging near edges
2960         https://bugs.webkit.org/show_bug.cgi?id=39725
2961
2962         Reviewed by Hajime Morita.
2963
2964         This patch introduces canceling drag-and-drop by escape key for testing
2965         behavior after cancellation drag-and-drop.
2966
2967         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2968         (WebTestRunner):
2969         (WebTestRunner::EventSender::doMouseUp):
2970         (WebTestRunner::EventSender::finishDragAndDrop):
2971         (WebTestRunner::EventSender::keyDown):
2972         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
2973         (EventSender):
2974         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
2975
2976 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2977
2978         [chromium] move frame generation related methods to TestRunner
2979         https://bugs.webkit.org/show_bug.cgi?id=107268
2980
2981         Reviewed by Adam Barth.
2982
2983         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2984         (DRTTestRunner::DRTTestRunner):
2985         (DRTTestRunner::setWillSendRequestReturnsNull):
2986         * DumpRenderTree/chromium/DRTTestRunner.h:
2987         (DRTTestRunner):
2988         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2989         (WebTestRunner::WebTestDelegate::display):
2990         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
2991         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2992         (WebTestRunner::TestRunner::TestRunner):
2993         (WebTestRunner::TestRunner::display):
2994         (WebTestRunner):
2995         (WebTestRunner::TestRunner::displayInvalidatedRegion):
2996         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2997         (TestRunner):
2998         * DumpRenderTree/chromium/WebViewHost.cpp:
2999         (WebViewHost::display):
3000         (WebViewHost::displayInvalidatedRegion):
3001         * DumpRenderTree/chromium/WebViewHost.h:
3002
3003 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
3004
3005         [chromium] move speech related methods to TestRunner library
3006         https://bugs.webkit.org/show_bug.cgi?id=107266
3007
3008         Reviewed by Adam Barth.
3009
3010         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3011         (DRTTestRunner::DRTTestRunner):
3012         (DRTTestRunner::displayInvalidatedRegion):
3013         * DumpRenderTree/chromium/DRTTestRunner.h:
3014         (DRTTestRunner):
3015         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3016         (WebTestDelegate):
3017         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
3018         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
3019         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
3020         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
3021         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
3022         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3023         (WebTestRunner::TestRunner::TestRunner):
3024         (WebTestRunner):
3025         (WebTestRunner::TestRunner::addMockSpeechInputResult):
3026         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
3027         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
3028         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
3029         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
3030         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3031         (TestRunner):
3032         * DumpRenderTree/chromium/WebViewHost.cpp:
3033         (WebViewHost::addMockSpeechInputResult):
3034         (WebViewHost::setMockSpeechInputDumpRect):
3035         (WebViewHost::addMockSpeechRecognitionResult):
3036         (WebViewHost::setMockSpeechRecognitionError):
3037         (WebViewHost::wasMockSpeechRecognitionAborted):
3038         * DumpRenderTree/chromium/WebViewHost.h:
3039
3040 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
3041
3042         [chromium] move notification related methods to TestRunner
3043         https://bugs.webkit.org/show_bug.cgi?id=107269
3044
3045         Reviewed by Adam Barth.
3046
3047         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3048         (DRTTestRunner::DRTTestRunner):
3049         * DumpRenderTree/chromium/DRTTestRunner.h:
3050         (DRTTestRunner):
3051         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3052         (WebTestDelegate):
3053         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
3054         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
3055         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3056         (WebTestRunner::TestRunner::TestRunner):
3057         (WebTestRunner):
3058         (WebTestRunner::TestRunner::grantWebNotificationPermission):
3059         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
3060         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3061         (TestRunner):
3062         * DumpRenderTree/chromium/WebViewHost.cpp:
3063         (WebViewHost::grantWebNotificationPermission):
3064         (WebViewHost::simulateLegacyWebNotificationClick):
3065         * DumpRenderTree/chromium/WebViewHost.h:
3066
3067 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
3068
3069         [chromium] move geolocation related methods to TestRunner
3070         https://bugs.webkit.org/show_bug.cgi?id=107267
3071
3072         Reviewed by Adam Barth.
3073
3074         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3075         (DRTTestRunner::DRTTestRunner):
3076         * DumpRenderTree/chromium/DRTTestRunner.h:
3077         (DRTTestRunner):
3078         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3079         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
3080         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
3081         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
3082         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
3083         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3084         (WebTestRunner::TestRunner::TestRunner):
3085         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
3086         (WebTestRunner):
3087         (WebTestRunner::TestRunner::setGeolocationPermission):
3088         (WebTestRunner::TestRunner::setMockGeolocationPosition):
3089         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
3090         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3091         (TestRunner):
3092         * DumpRenderTree/chromium/WebViewHost.cpp:
3093         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
3094         (WebViewHost::setGeolocationPermission):
3095         (WebViewHost::setMockGeolocationPosition):
3096         (WebViewHost::setMockGeolocationPositionUnavailableError):
3097         * DumpRenderTree/chromium/WebViewHost.h:
3098
3099 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
3100
3101         Unreviewed build fix for Qt WK2 after r140258.
3102         Use the size_t type instead of unsigned for the variable
3103         which holds the position of the first null character in the
3104         console message.
3105
3106         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3107         (WTR::InjectedBundlePage::willAddMessageToConsole):
3108
3109 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3110
3111         Unreviewed, rolling out r140260.
3112         http://trac.webkit.org/changeset/140260
3113         https://bugs.webkit.org/show_bug.cgi?id=107387
3114
3115         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
3116         nothing else) (Requested by thakis__ on #webkit).
3117
3118         * Scripts/update-webkit-chromium:
3119
3120 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3121
3122         Delegated scrolling: Assertion on attempt to show a CSS sticky element
3123         https://bugs.webkit.org/show_bug.cgi?id=106890
3124
3125         Reviewed by Kenneth Rohde Christiansen.
3126
3127         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
3128
3129         * WebKitTestRunner/TestInvocation.cpp:
3130         (WTR::shouldUseFixedLayout):
3131         (WTR):
3132         (WTR::updateLayoutType):
3133
3134 2013-01-19  Nico Weber  <thakis@chromium.org>
3135
3136         Make ninja the default build system for build-webkit --chromium on mac
3137         https://bugs.webkit.org/show_bug.cgi?id=106737
3138
3139         Reviewed by Eric Seidel.
3140
3141         * Scripts/update-webkit-chromium:
3142
3143 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
3144
3145         [WK2] svg/dom/fuzz-path-parser.html is failing
3146         https://bugs.webkit.org/show_bug.cgi?id=107133
3147
3148         Reviewed by Alexey Proskuryakov.
3149
3150         Console messages can contain null characters before the end of string.
3151         Appending such message to the StringBuilder as a WTFString appends the
3152         complete string, including the null character. This later cuts off everything
3153         after the null character when the string is being printed out to the test
3154         output.
3155
3156         To avoid this, truncate the string up to the first null character. This
3157         preserves the newline character appended immediately after this and
3158         stops giving incorrect output.
3159
3160         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3161         (WTR::InjectedBundlePage::willAddMessageToConsole):
3162
3163 2013-01-19  Eric Seidel  <eric@webkit.org>
3164
3165         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
3166         https://bugs.webkit.org/show_bug.cgi?id=107367
3167
3168         Reviewed by Ryosuke Niwa.
3169
3170         Using srcdoc instead of document.write changes the error output
3171         ever so slightly.  Clearly we were already trying to ignore these
3172         messages, just not succeeding.  This change makes this new test "pass" correctly.
3173
3174         * Scripts/webkitpy/performance_tests/perftest.py:
3175         (PerfTest):
3176
3177 2013-01-18  Dan Winship  <danw@gnome.org>
3178
3179         REGRESSION (r139071): run-webkit-httpd complains at launch
3180         https://bugs.webkit.org/show_bug.cgi?id=107310
3181
3182         Reviewed by Alexey Proskuryakov.
3183
3184         * Scripts/webkitperl/httpd.pm:
3185         (getApacheVersion): use preferred perl syntax
3186
3187 2013-01-18  Julie Parent  <jparent@chromium.org>
3188
3189         Add back 'group' as a default cross dashboard parameter, but with null as its value.
3190         https://bugs.webkit.org/show_bug.cgi?id=107336
3191
3192         We need to have 'group' listed as a parameter, else we never parse it,
3193         as we only parse parameters with defaults.
3194         
3195         Reviewed by Ojan Vafai.
3196
3197         * TestResultServer/static-dashboards/dashboard_base.js:
3198
3199 2013-01-18  Emil A Eklund  <eae@chromium.org>
3200
3201         Update LayoutUnit rounding unit test
3202         https://bugs.webkit.org/show_bug.cgi?id=107322
3203
3204         Reviewed by Levi Weintraub.
3205         
3206         Update the LayoutUnitRounding test to use fromFloatRound for
3207         values that cannot accurately be represented as a LayoutUnit
3208         (the default behavior is to floor the value to the nearest
3209         LayoutUnit).
3210
3211         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3212         (TestWebKitAPI::TEST):
3213
3214 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3215
3216         VCSUtils.pm: Stop calling git repo-config.
3217         https://bugs.webkit.org/show_bug.cgi?id=107294
3218
3219         Reviewed by Dirk Pranke.
3220
3221         The `repo-config' git command has been deprecated since early
3222         2008, and recent versions have started warning it is deprecated.
3223
3224         Basically revert r27870 and use the `config' command all the time.
3225
3226         * Scripts/VCSUtils.pm:
3227         (gitConfig):
3228
3229 2013-01-18  Levi Weintraub  <leviw@chromium.org>
3230
3231         LayoutUnit should round half consistently, not away from zero
3232         https://bugs.webkit.org/show_bug.cgi?id=107208
3233
3234         Reviewed by Eric Seidel.
3235
3236         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
3237         cover this change in rounding behavior.
3238
3239 2013-01-18  Tim Horton  <timothy_horton@apple.com>
3240
3241         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
3242         https://bugs.webkit.org/show_bug.cgi?id=107234
3243
3244         Reviewed by Simon Fraser.
3245
3246         * DumpRenderTree/mac/DumpRenderTree.mm:
3247         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
3248         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3249         (WTR::PlatformWebView::PlatformWebView): Ditto.
3250
3251 2013-01-18  Tim Horton  <timothy_horton@apple.com>
3252
3253         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
3254         https://bugs.webkit.org/show_bug.cgi?id=107251
3255
3256         Reviewed by Simon Fraser.
3257
3258         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
3259
3260         * DumpRenderTree/mac/DumpRenderTree.mm:
3261         (dumpRenderTree):
3262         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3263         (WTR::InjectedBundle::platformInitialize):
3264
3265 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
3266
3267         [GTK] Enable indexed database for development builds
3268         https://bugs.webkit.org/show_bug.cgi?id=107299
3269
3270         Reviewed by Gustavo Noronha Silva.
3271
3272         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
3273         for GTK+ development builds.
3274
3275 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
3276
3277         AX: Improve table-guessing heuristics
3278         https://bugs.webkit.org/show_bug.cgi?id=107042
3279
3280         Reviewed by Chris Fleizach.
3281
3282         Implement parentElementCallback on Chromium to make testing easier.
3283
3284         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3285         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
3286
3287 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
3288
3289         [GTK] Add property for IndexedDB database path to WebKitGTK+
3290         https://bugs.webkit.org/show_bug.cgi?id=106136
3291
3292         Reviewed by Gustavo Noronha Silva.
3293
3294         During testing, set the web database directory to DUMPRENDERTREE_TEMP
3295         before falling back to the old default. This is necessary because
3296         indexed database tests require that each DRT shard is using a different
3297         IDB database location.
3298
3299         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3300         (temporaryDatabaseDirectory): Added this helper for getting the
3301         database directory.
3302         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
3303
3304 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3305
3306         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
3307         https://bugs.webkit.org/show_bug.cgi?id=107264
3308
3309         Reviewed by Laszlo Gombos.
3310
3311         Enable API test InjectedBundleFrameHitTest for hit-testing,
3312         since it is now passing on both Debug and Release builds.
3313
3314         * TestWebKitAPI/CMakeLists.txt:
3315         * TestWebKitAPI/PlatformEfl.cmake:
3316
3317 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
3318
3319         [GTK] Implement TestRunner::addUserScript
3320         https://bugs.webkit.org/show_bug.cgi?id=107275
3321
3322         Reviewed by Philippe Normand.
3323
3324         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3325         (TestRunner::addUserScript): Implement method using
3326         DumpRenderTreeSupportGtk::addUserScript.
3327
3328 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3329
3330         Unreviewed, add my secondary email address to the list.
3331
3332         * Scripts/webkitpy/common/config/committers.py:
3333
3334 2013-01-18  Dan Carney  <dcarney@google.com>
3335
3336         [chromium] move pointerlock functions to TestRunner library
3337         https://bugs.webkit.org/show_bug.cgi?id=107241
3338
3339         Reviewed by Jochen Eisinger.
3340
3341         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3342         (DRTTestRunner::DRTTestRunner):
3343         * DumpRenderTree/chromium/DRTTestRunner.h:
3344         (DRTTestRunner):
3345         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3346         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
3347         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
3348         (WebTestRunner::WebTestDelegate::didLosePointerLock):
3349         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
3350         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
3351         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3352         (WebTestRunner::TestRunner::TestRunner):
3353         (WebTestRunner):
3354         (WebTestRunner::TestRunner::didAcquirePointerLock):
3355         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
3356         (WebTestRunner::TestRunner::didLosePointerLock):
3357         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
3358         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
3359         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3360         (TestRunner):
3361         * DumpRenderTree/chromium/WebViewHost.h:
3362         (WebViewHost):
3363
3364 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
3365
3366         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
3367         https://bugs.webkit.org/show_bug.cgi?id=106774
3368
3369         Reviewed by Martin Robinson.
3370
3371         In order to fix a long standing linespacing/font ascent & descent issue
3372         we found that FreeType commit b0962ac34e660 solves that problem.
3373         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
3374         maintainer recommending several security updates after that said commit.
3375
3376         Also, in order to avoid extra rebaselining, let's activate subpixel
3377         layout at the same time.
3378
3379         * efl/jhbuild.modules: New freetype 2.4.11
3380
3381 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
3382
3383         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
3384         https://bugs.webkit.org/show_bug.cgi?id=107107
3385         PR 282192
3386
3387         Reviewed by Rob Buis.
3388
3389         The DRT application will convert relative/absolute file path to
3390         file://<real-file-path> format, so we only check for http/file prefix.
3391
3392         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3393         (BlackBerry::WebKit::isFullUrl):
3394         (WebKit):
3395         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
3396
3397 2013-01-17  Frank Farzan  <frankf@chromium.org>
3398
3399         Flakiness dashboard: Add ChromiumFYI master
3400         https://bugs.webkit.org/show_bug.cgi?id=107180
3401
3402         Reviewed by Ojan Vafai.
3403
3404         This is needed to enable Chrome Android bots
3405         to upload results for instrumentation tests.
3406
3407         * TestResultServer/generate_builders_json.py:
3408         (main):
3409         * TestResultServer/static-dashboards/builders.jsonp:
3410
3411 2013-01-17  Frank Farzan  <frankf@chromium.org>
3412
3413         Add Chrome on Android instrumentation test types to flakiness dashboard
3414         https://bugs.webkit.org/show_bug.cgi?id=106964
3415
3416         Reviewed by Ojan Vafai.
3417
3418         Specifically, add these test types:
3419         
3420          androidwebview_instrumentation_tests
3421          chromiumtestshell_instrumentation_tests
3422          contentshell_instrumentation_tests
3423         
3424         Also, add ChromiumFYI to the list of masters.
3425
3426         * TestResultServer/static-dashboards/builders.js:
3427         (loadBuildersList):
3428         * TestResultServer/static-dashboards/dashboard_base.js:
3429         (currentBuilderGroupCategory):
3430
3431 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
3432
3433         Fixing webkitpy's SCM unit tests.
3434         https://bugs.webkit.org/show_bug.cgi?id=106429
3435
3436         Reviewed by Eric Seidel.
3437
3438         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3439         (SCMDetectorTest.test_detect_scm_system):
3440         * Scripts/webkitpy/common/checkout/scm/git.py:
3441         (Git.in_working_directory):
3442         (Git.read_git_config):
3443         (Git._assert_can_squash):
3444         (Git.remote_branch_ref):
3445         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3446         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
3447         (GitTestWithMock):
3448         (GitTestWithMock.make_scm):
3449         (GitTestWithMock.test_create_patch):
3450         * Scripts/webkitpy/common/system/outputcapture.py:
3451         (OutputCapture.assert_outputs):
3452         (OutputCaptureTestCaseBase):
3453         * Scripts/webkitpy/test/printer.py:
3454         (Printer.configure):
3455
3456 2013-01-17  Julie Parent  <jparent@chromium.org>
3457
3458         Flakiness dashboard assumes there must be ToT tests
3459         https://bugs.webkit.org/show_bug.cgi?id=107155
3460
3461         Remove group as a default parameter, since we can't actually know
3462         the name of a group initially.  Instead, introduces 
3463         currentBuilderGroupName which returns the current builder group
3464         if it has been explicitly set, or picks the first one available
3465         as a default. Allows us to remove some extra code tracking this
3466         stuff as well.
3467         
3468         Reviewed by Ojan Vafai.
3469
3470         * TestResultServer/static-dashboards/dashboard_base.js:
3471         (parseCrossDashboardParameters):
3472         (currentBuilderGroupName):
3473         (currentBuilderGroup):
3474         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3475         (platformAndBuildType):
3476         * TestResultServer/static-dashboards/loader.js:
3477         (.):
3478
3479 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
3480
3481         Remove NodeListsNodeData when it's no longer needed
3482         https://bugs.webkit.org/show_bug.cgi?id=107074
3483
3484         Reviewed by Darin Adler.
3485
3486         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
3487
3488         * Scripts/webkitpy/performance_tests/perftest.py:
3489         (PerfTest):
3490
3491 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
3492
3493         Ref test images are upside-down in WebKit2
3494         https://bugs.webkit.org/show_bug.cgi?id=105457
3495
3496         Reviewed by Sam "Speedy" Weinig.
3497         
3498         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
3499         from the window snapshot contained a flipped copy of the image, causing all ref
3500         and pixel images to be upside-down.
3501
3502         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3503         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3504
3505 2013-01-17  Timothy Loh  <timloh@google.com>
3506
3507         Replaced specifiers variable with is_debug in builders.py
3508         https://bugs.webkit.org/show_bug.cgi?id=107057
3509
3510         Reviewed by Dirk Pranke.
3511
3512         Replaced specifiers variable with is_debug in builders.py to simplify
3513         Bug 106259. The other specifiers are not used elsewhere in the code.
3514         Fixed builder_name_for_port_name to return a debug builder if we don't
3515         have a release builder.
3516
3517         * Scripts/webkitpy/layout_tests/port/builders.py:
3518         (all_port_names):
3519         (builder_name_for_port_name):
3520         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3521         (TestRebaselineExpectations.test_rebaseline_expectations):
3522
3523 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
3524
3525         [GTK] Build with LevelDB when IndexedDB is enabled
3526         https://bugs.webkit.org/show_bug.cgi?id=103220
3527
3528         Reviewed by Gustavo Noronha Silva.
3529
3530         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
3531         as it does not conform to WebKit style.
3532
3533 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3534
3535         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
3536         https://bugs.webkit.org/show_bug.cgi?id=107119
3537
3538         Reviewed by Laszlo Gombos.
3539
3540         Do not use ASSERT on ecore_evas_init(), since the expression inside
3541         the macro compiles out of release builds.
3542
3543         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
3544         * TestWebKitAPI/efl/PlatformWebView.cpp:
3545         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
3546
3547 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
3548
3549         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
3550         https://bugs.webkit.org/show_bug.cgi?id=104545
3551
3552         Reviewed by Yury Semikhatsky.
3553
3554         Adopt signature changes.
3555
3556         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3557         (ProfilerAgent.getCPUProfile): Renamed.
3558         (ProfilerAgent.getHeapSnapshot): Added.
3559
3560 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
3561
3562         [GTK][EFL] NWRT should check that Xvfb is installed
3563         https://bugs.webkit.org/show_bug.cgi?id=71767
3564
3565         Reviewed by Dirk Pranke.
3566
3567         EFL and GTK ports now check that Xvfb is installed before running
3568         layout tests. The command line used to check whether Xvfb is present
3569         is a simple `which Xvfb` that should return 0 as the exit code upon
3570         success.
3571
3572         * Scripts/webkitpy/layout_tests/port/efl.py:
3573         (EflPort.show_results_html_file):
3574         (EflPort):
3575         (EflPort.check_sys_deps):
3576         * Scripts/webkitpy/layout_tests/port/gtk.py:
3577         (GtkPort.check_sys_deps):
3578         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3579         (XvfbDriver):
3580         (XvfbDriver.check_xvfb):
3581
3582 2013-01-16  Alan Cutter  <alancutter@chromium.org>
3583
3584         sheriffbot can't tell me who "kov" is
3585         https://bugs.webkit.org/show_bug.cgi?id=106184
3586
3587         Reviewed by Eric Seidel.
3588
3589         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
3590
3591         * Scripts/webkitpy/common/config/committers.py:
3592         (Account.matches_glob):
3593         (CommitterList.contributors_by_search_string):
3594         * Scripts/webkitpy/common/config/committers_unittest.py:
3595         (CommittersTest.test_committer_lookup):
3596         * Scripts/webkitpy/tool/bot/irc_command.py:
3597         (Whois):
3598
3599 2013-01-16  David Kilzer  <ddkilzer@apple.com>
3600
3601         Use xcrun to find path to make for Mac port
3602         <http://webkit.org/b/107091>
3603
3604         Reviewed by Dan Bernstein.
3605
3606         * Scripts/webkitpy/layout_tests/port/mac.py:
3607         (MacPort._build_java_test_support): Call self.make_command().
3608         (MacPort.make_command): Add.  Call xcrun_find().
3609         (MacPort.nm_command): Use self.xcrun_find().
3610         (MacPort.xcrun_find): Add.  Extract from nm_command().
3611
3612 2013-01-16  Sam Weinig  <sam@webkit.org>
3613
3614         Make debug-safari --target-web-process work again
3615         https://bugs.webkit.org/show_bug.cgi?id=107088
3616
3617         Reviewed by Anders Carlsson.
3618
3619         * Scripts/webkitdirs.pm:
3620         (execMacWebKitAppForDebugging):
3621         The shim is now called SecItemShim.
3622
3623 2013-01-16  Alan Cutter  <alancutter@chromium.org>
3624
3625         GCE build scripts don't take working directory into account when calling findzone.sh
3626         https://bugs.webkit.org/show_bug.cgi?id=106962
3627
3628         Reviewed by Adam Barth.
3629
3630         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3631         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3632         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3633
3634 2013-01-16  Alan Cutter  <alancutter@chromium.org>
3635
3636         start-queue.sh does not pass remaining parameters correctly
3637         https://bugs.webkit.org/show_bug.cgi?id=107054
3638
3639         Reviewed by Adam Barth.
3640
3641         start-queue.sh now passes all remaining params to the webkit-patch command.
3642         Previously only one additional queue parameter could be sent.
3643
3644         * EWSTools/start-queue.sh:
3645
3646 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
3647
3648         check-webkit-style script cannot running in Chinese windows.
3649         https://bugs.webkit.org/show_bug.cgi?id=87548
3650
3651         Reviewed by Darin Adler.
3652
3653         * Scripts/webkitpy/common/system/platforminfo.py:
3654         (PlatformInfo._win_version_tuple_from_cmd):
3655
3656 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
3657
3658         Delete an extraneous print statement.
3659         https://bugs.webkit.org/show_bug.cgi?id=106562
3660
3661         Delete the extraneous print statement introduced in r139841.
3662
3663         * Scripts/webkitpy/layout_tests/views/printing.py:
3664         (Printer.print_found):
3665
3666 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
3667
3668         Please reinstate --pixel
3669         https://bugs.webkit.org/show_bug.cgi?id=101995
3670
3671         Reviewed by Dirk Pranke.
3672
3673         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
3674         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
3675         Some developers are still used to these options that were available in