621a527434f8624d980e77a1a1f231c524f3ca35
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Fix the build on other platforms after r220865
4         https://bugs.webkit.org/show_bug.cgi?id=175683
5
6         Reviewed by Tim Horton.
7
8         Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
9         availability is determined by SDK version rather than deployment version.
10
11         * TestWebKitAPI/ios/UIKitSPI.h:
12
13 2017-08-17  Andreas Kling  <akling@apple.com>
14
15         Disable CSS regions at compile time
16         https://bugs.webkit.org/show_bug.cgi?id=175630
17
18         Reviewed by Antti Koivisto.
19
20         * Scripts/webkitperl/FeatureList.pm:
21         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
22
23 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
24
25         Unreviewed, try to fix the internal iOS 10 build after r220865.
26
27         * TestWebKitAPI/ios/UIKitSPI.h:
28
29         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
30         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
31         this compiler guard.
32
33 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
34
35         [iOS] Respect type fidelities when copying image elements to the pasteboard
36         https://bugs.webkit.org/show_bug.cgi?id=175638
37         <rdar://problem/26556043>
38
39         Reviewed by Ryosuke Niwa.
40
41         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
42         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
43         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
44
45         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
46         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
47         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
48         (TestWebKitAPI::TEST):
49         (TestWebKitAPI::presentActionSheetAndChooseAction):
50         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
51         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
52         (checkEstimatedSize):
53         (checkSuggestedNameAndEstimatedSize):
54
55         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
56
57         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
58         (TestWebKitAPI::TEST):
59         * TestWebKitAPI/ios/DataInteractionSimulator.h:
60         * TestWebKitAPI/ios/UIKitSPI.h: Added.
61
62 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
63
64         Recursively create resource load statistics folder for testing
65         https://bugs.webkit.org/show_bug.cgi?id=175676
66
67         Reviewed by Brady Eidson.
68
69         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
70         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
71
72 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
73
74         [GTK][WPE] Add NTLM authentication enabled API
75         https://bugs.webkit.org/show_bug.cgi?id=122952
76
77         Reviewed by Michael Catanzaro.
78
79         Add a test case to check we can enable/disable NTLM.
80
81         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
82         (testWebViewAuthenticationNTLM):
83         (beforeAll):
84
85 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
86
87         [PAL] Move spi/ios and spi/win directories into PAL
88         https://bugs.webkit.org/show_bug.cgi?id=175171
89
90         Reviewed by Antti Koivisto.
91
92         * DumpRenderTree/mac/EventSendingController.mm:
93
94 2017-08-16  Andy Estes  <aestes@apple.com>
95
96         [Payment Request] Add an ENABLE flag and an experimental feature preference
97         https://bugs.webkit.org/show_bug.cgi?id=175622
98
99         Reviewed by Tim Horton.
100
101         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
102         * WebKitTestRunner/TestController.cpp:
103         (WTR::TestController::resetPreferencesToConsistentValues):
104
105 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
106
107         undefined URL in PopoverTracker for failed step
108         https://bugs.webkit.org/show_bug.cgi?id=175593
109         <rdar://problem/33898769>
110
111         Reviewed by Daniel Bates.
112
113         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
114         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
115
116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
117         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
118         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
119         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
120         (BuildbotTestResults): Accept URL in constructor.
121
122 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
123
124         Remove Proximity Events and related code
125         https://bugs.webkit.org/show_bug.cgi?id=175545
126
127         Reviewed by Daniel Bates.
128
129         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
130         and other related code.
131
132         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
133
134 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
135
136         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
137         https://bugs.webkit.org/show_bug.cgi?id=175504
138
139         Reviewed by Sam Weinig.
140
141         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
142
143 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
144
145         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
146         https://bugs.webkit.org/show_bug.cgi?id=175557
147
148         Reviewed by Jon Lee.
149         
150         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
151
152         * DumpRenderTree/TestRunner.cpp:
153         (TestRunner::staticFunctions):
154         (setViewModeMediaFeatureCallback): Deleted.
155         * DumpRenderTree/TestRunner.h:
156         * DumpRenderTree/mac/TestRunnerMac.mm:
157         (TestRunner::setViewModeMediaFeature): Deleted.
158         * DumpRenderTree/win/TestRunnerWin.cpp:
159         (TestRunner::setViewModeMediaFeature): Deleted.
160         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
161
162 2017-08-14  Andy Estes  <aestes@apple.com>
163
164         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
165         https://bugs.webkit.org/show_bug.cgi?id=175548
166         <rdar://problem/33866206>
167
168         Reviewed by Brady Eidson.
169
170         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
171         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
172         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
173
174 2017-08-14  Youenn Fablet  <youenn@apple.com>
175
176         WPT server should be able to do logging even if its output folder is not created at launch time
177         https://bugs.webkit.org/show_bug.cgi?id=175543
178
179         Reviewed by Alexey Proskuryakov.
180
181         Removing no longer used stdout/stderr member variables.
182         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
183
184         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
185         (WebPlatformTestServer.__init__):
186         (WebPlatformTestServer._prepare_config):
187         (WebPlatformTestServer._spawn_process):
188         (WebPlatformTestServer._stop_running_server):
189
190 2017-08-14  Daniel Bates  <dabates@apple.com>
191
192         webkit-patch: Passing --no-review should submit patch to EWS by default
193         https://bugs.webkit.org/show_bug.cgi?id=148899
194
195         Reviewed by David Kilzer.
196
197         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
198         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
199         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
200
201         Frequently I want to post a draft of a patch without review to have the EWS bots process
202         it to catch build and test breakage before I clean it up and post it for formal review.
203         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
204         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
205         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
206
207         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
208         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
209         parse the attachment id from the response page after adding an attachment to the bug.
210         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
211         HTTP response after uploading the patch.
212         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
213         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
214         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
215         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
216         * Scripts/webkitpy/tool/commands/upload.py:
217         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
218         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
219         this command.
220         (PostCommits.execute): Submit the patch to EWS, if applicable.
221         * Scripts/webkitpy/tool/commands/upload_unittest.py:
222         (test_upload): Set options.ews to False as the upload command expects this option
223         to be specified.
224         (test_upload_with_no_review_and_ews): Added.
225         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
226         * Scripts/webkitpy/tool/steps/options.py:
227         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
228         * Scripts/webkitpy/tool/steps/postdiff.py:
229         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
230         this command.
231         (PostDiff.run): Submit the patch to EWS, if applicable.
232         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
233         (SubmitToEWS):
234         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
235         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
236
237 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
238
239         Disable two flaky VideoControlsManager API tests.
240
241         Unreviewed test gardening.
242
243         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
244         (TestWebKitAPI::TEST):
245
246 2017-08-14  Tim Horton  <timothy_horton@apple.com>
247
248         Only create directory and sandbox extension handle for storage directories if they are set
249         https://bugs.webkit.org/show_bug.cgi?id=175522
250
251         Reviewed by Brady Eidson.
252
253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
254         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
255         (TEST):
256         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
257         doesn't log anything to stderr.
258
259 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
260
261         sub-categorize Sandbox violation logs
262         https://bugs.webkit.org/show_bug.cgi?id=175536
263         <rdar://problem/33834416>
264
265         Reviewed by David Kilzer.
266
267         * Scripts/webkitpy/common/system/crashlogs.py:
268         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
269         a Sandbox violation.
270         (CrashLogs._find_all_logs_darwin): Update comment.
271         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
272         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
273         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
274         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
275         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
276         * Scripts/webkitpy/port/darwin.py:
277         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
278
279 2017-08-14  Daniel Bates  <dabates@apple.com>
280
281         Add Automator service to copy permalink to Clipboard
282         https://bugs.webkit.org/show_bug.cgi?id=170978
283
284         Reviewed by Joseph Pecoraro.
285
286         It is helpful to reference using a hyperlink a particular line of code when having
287         a discussion on IRC or in a bug. You can get such a link by navigating to the file
288         in the Trac Browse Source viewer and selecting the line your are interested in.
289         I found myself doing this often enough that I wrote an Automator service to do it
290         for me.
291
292         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
293
294         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
295         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
296         * CopyPermalink/README: Added.
297
298 2017-08-14  Chris Dumez  <cdumez@apple.com>
299
300         Address flakiness related to download tests
301         https://bugs.webkit.org/show_bug.cgi?id=175338
302         <rdar://problem/33865119>
303
304         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
305         between tests.
306
307         * WebKitTestRunner/TestController.cpp:
308         (WTR::TestController::resetStateToConsistentValues):
309
310 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
311
312         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
313         https://bugs.webkit.org/show_bug.cgi?id=175474
314         <rdar://problem/33844628>
315
316         Reviewed by Wenson Hsieh.
317
318         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
319
320         * DumpRenderTree/mac/DumpRenderTree.mm:
321         (resetWebPreferencesToConsistentValues):
322         * WebKitTestRunner/TestController.cpp:
323         (WTR::TestController::resetPreferencesToConsistentValues):
324
325 2017-08-12  Chris Dumez  <cdumez@apple.com>
326
327         Address flakiness related to download tests
328         https://bugs.webkit.org/show_bug.cgi?id=175338
329
330         Reviewed by Ryosuke Niwa.
331
332         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
333           is actually queried when a download completes. Previously, this would be
334           identical to a call to testRunner.waitUntilDone() because any download
335           completion would call testRunner.notifyDone().
336         - Disable logging of download callbacks by default and add a
337           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
338           enable such logging.
339
340         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
341         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
342         (WTR::InjectedBundle::didReceiveMessageToPage):
343         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
344         (WTR::TestRunner::setShouldLogDownloadCallbacks):
345         * WebKitTestRunner/InjectedBundle/TestRunner.h:
346         * WebKitTestRunner/TestController.cpp:
347         (WTR::TestController::downloadDidStart):
348         (WTR::TestController::decideDestinationWithSuggestedFilename):
349         (WTR::TestController::downloadDidFinish):
350         (WTR::TestController::downloadDidFail):
351         (WTR::TestController::downloadDidCancel):
352         * WebKitTestRunner/TestController.h:
353         (WTR::TestController::setShouldLogDownloadCallbacks):
354         * WebKitTestRunner/TestInvocation.cpp:
355         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
356
357 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
358
359         Create mock ITP data in testing to prevent grandfathering
360         https://bugs.webkit.org/show_bug.cgi?id=174720
361
362         Unreviewed follow-up fix for r220604.
363
364         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
365         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
366
367 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
368
369         Create mock ITP data in testing to prevent grandfathering
370         https://bugs.webkit.org/show_bug.cgi?id=174720
371         <rdar://problem/33457779>
372
373         Reviewed by Brent Fulgham.
374
375         We don't need to be triggering grandfathering when each test runner starts. On Mac,
376         this may launch plugins which can cause layout tests to fail later if the test
377         runner does not shut-down before the plugins unload.
378
379         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
380         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
381         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
382         prevent grandfathering from being triggered.
383         * WebKitTestRunner/ios/TestControllerIOS.mm:
384         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
385         * WebKitTestRunner/mac/TestControllerMac.mm:
386         (WTR::TestController::platformInitialize): Ditto.
387
388 2017-08-11  Sam Weinig  <sam@webkit.org>
389
390         WTF::Function does not allow for reference / non-default constructible return types
391         https://bugs.webkit.org/show_bug.cgi?id=175244
392         <rdar://problem/33801582>
393
394         Reviewed by Chris Dumez.
395
396         * TestWebKitAPI/Tests/WTF/Function.cpp:
397         (TestWebKitAPI::TEST):
398
399 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
400
401         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
402         https://bugs.webkit.org/show_bug.cgi?id=175378
403
404         Reviewed by Sergio Villar Senin.
405
406         Add two test cases to check proxy authentication.
407
408         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
409         (Tunnel::Tunnel):
410         (Tunnel::~Tunnel):
411         (Tunnel::connect):
412         (Tunnel::connected):
413         (serverCallback):
414         (ProxyAuthenticationTest::ProxyAuthenticationTest):
415         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
416         (ProxyAuthenticationTest::proxyServerPortAsString):
417         (testWebViewAuthenticationProxy):
418         (testWebViewAuthenticationProxyHTTPS):
419         (beforeAll):
420
421 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
422
423         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
424         https://bugs.webkit.org/show_bug.cgi?id=175428
425
426         Both ports share the GStreamer code as multimedia backend and till
427         not so long they were using different versions. Now they do use
428         the same versions and it does not make any sense anymore (and
429         neither had sense before) to have differences in the modulesets.
430
431         In this patch I created a GStreamer moduleset and referenced it
432         from both GTK+'s and WPE's. GStreamer patches were also moved there.
433
434         Reviewed by Žan Doberšek.
435
436         * gstreamer/jhbuild.modules: Added.
437         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
438         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
439         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
440         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
441         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
442         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
443         * gtk/jhbuild.modules:
444         * wpe/jhbuild.modules:
445         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
446         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
447         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
448         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
449         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
450
451 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
452
453         Unreviewed, adding Ross Kirsling to contributors.json
454
455         * Scripts/webkitpy/common/config/contributors.json:
456
457 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
458
459         Unreviewed, attempt to fix build failure with VC2017
460
461         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
462         (TEST):
463
464 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
465
466         Unreviewed, suppress warnings on GCC
467
468         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
469         (TestWebKitAPI::CheckedArithmeticTester::run):
470
471 2017-08-10  Dan Bernstein  <mitz@apple.com>
472
473         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
474         https://bugs.webkit.org/show_bug.cgi?id=173223
475
476         Reviewed by Tim Horton.
477
478         The rebuilds were happening due to a difference in the compiler options that the IDE and
479         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
480         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
481         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
482         Advanced when a Custom Absolute path is selected.
483
484         * Scripts/webkitdirs.pm:
485         (determineBaseProductDir):
486
487 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
488
489         Run more WTF tests
490         https://bugs.webkit.org/show_bug.cgi?id=174970
491
492         Reviewed by Michael Catanzaro.
493
494         Some of WTF tests are not executed in non Apple ports while they are generic ones.
495         This patch adds these tests to non-Apple port TestWebKitAPI.
496         Currently, we do not add Signals.cpp since it depends on signal functionality.
497
498         * TestWebKitAPI/CMakeLists.txt:
499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
500         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
501         (isHigherPriority):
502         (TEST):
503         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
504         (TEST):
505         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
506         (TEST):
507
508 2017-08-10  obinna obike  <oobike@apple.com>
509
510         Remove obsolete link from webkit-queues status page
511         https://bugs.webkit.org/show_bug.cgi?id=175337
512
513         Reviewed by Aakash Jain.
514
515         * QueueStatusServer/templates/recentstatus.html:
516         Removed the link to the ews-watcher server.
517
518 2017-08-10  Brian Burg  <bburg@apple.com>
519
520         WKPreferences should conform to NSCopying
521         https://bugs.webkit.org/show_bug.cgi?id=175303
522         <rdar://problem/33764939>
523
524         Reviewed by Dan Bernstein.
525
526         Add unit test to make sure a WKPreference and its copy are
527         not aliased to each other or affect each other's properties.
528
529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
530         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
531         (TEST):
532
533 2017-08-10  Tim Horton  <timothy_horton@apple.com>
534
535         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
536         https://bugs.webkit.org/show_bug.cgi?id=175436
537         <rdar://problem/33667497>
538
539         Reviewed by Simon Fraser.
540
541         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
542         (TestWebKitAPI::TEST_F):
543
544 2017-08-10  Lucas Forschler  <lforschler@apple.com>
545
546         Fix duplicated code in r220534.
547
548         Unreviewed cleanup.
549
550         * Scripts/bisect-builds:
551
552 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
553
554         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
555         https://bugs.webkit.org/show_bug.cgi?id=175344
556         <rdar://problem/28507240>
557
558         Reviewed by Alexey Proskuryakov.
559
560         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
561         Finally enable the existing tests for iOS.
562
563         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
564         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
566         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
567
568 2017-08-10  Lucas Forschler  <lforschler@apple.com>
569
570         Write a tool to bisect WebKit builds
571         https://bugs.webkit.org/show_bug.cgi?id=174596
572
573         Reviewed by Dean Johnson and Kocsen Chung.
574
575         * Scripts/bisect-builds: Added.
576         (bisect_builds): main bisection algorithm
577         (download_archive):download an archive from S3 using existing tools
578         (extract_archive):extract an archive using existing tools
579         (find_le):Find rightmost value less than or equal to x
580         (find_ge):Find leftmost item greater than or equal to x
581         (get_api_url):generate url for the rest api/database
582         (get_indices_from_revisions):convert revisions to list indexes for bisection
583         (get_sorted_revisions):retrieve sorted revision list
584         (get_s3_location_for_revision):calculate the S3 archive storage location
585         (parse_args):parse command line arguments
586         (pick_next_build):compute the next build to bisect
587         (prompt_did_reproduce):prompt user for direction for bisection
588         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
589         (test_archive):Platform specific logic to test downloaded archive
590         (minified_platforms):return a list of minified platforms in the database
591         (unminified_platforms):return a list of full platforms in the database
592         (is_supported_platform):check if platform is supported
593         (validate_options):validate command line options
594         (main):
595
596 2017-08-10  Lucas Forschler  <lforschler@apple.com>
597
598         Remove bisect-builds script.
599         https://bugs.webkit.org/show_bug.cgi?id=175433
600         
601         Reviewed by Aakash Jain.
602
603         * Scripts/bisect-builds: Removed.
604
605 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
606
607         Remove ENABLE_GAMEPAD_DEPRECATED
608         https://bugs.webkit.org/show_bug.cgi?id=175361
609
610         Reviewed by Carlos Garcia Campos.
611
612         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
613
614 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
615
616         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
617         https://bugs.webkit.org/show_bug.cgi?id=175426
618
619         Reviewed by Carlos Garcia Campos.
620
621         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
622
623 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
624
625         Add Ms2ger as contributor.
626         https://bugs.webkit.org/show_bug.cgi?id=175325
627
628         Reviewed by Carlos Alberto Lopez Perez.
629
630         * Scripts/webkitpy/common/config/contributors.json:
631
632 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
633
634         Fix run-benchmark after r220483.
635         https://bugs.webkit.org/show_bug.cgi?id=175415
636         <rdar://problem/33803003>
637
638         Reviewed by Ryosuke Niwa.
639
640         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
641
642         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
643         (WebServerBenchmarkRunner._run_one_test):
644
645 2017-08-09  Chris Dumez  <cdumez@apple.com>
646
647         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
648         https://bugs.webkit.org/show_bug.cgi?id=175401
649
650         Reviewed by Brady Eidson.
651
652         * DumpRenderTree/mac/DumpRenderTree.mm:
653         (enableExperimentalFeatures):
654
655 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
656
657         [PAL] Move spi/cocoa and spi/cg directories into PAL
658         https://bugs.webkit.org/show_bug.cgi?id=175175
659
660         Reviewed by Myles C. Maxfield.
661
662         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
663         * DumpRenderTree/mac/DumpRenderTree.mm:
664         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
665         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
666
667         * Scripts/webkitpy/style/checker.py:
668         * Scripts/webkitpy/style/checker_unittest.py:
669         (GlobalVariablesTest.test_path_rules_specifier):
670
671         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
672
673         * Scripts/webkitpy/style/checkers/cpp.py:
674         (check_braces):
675         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
676         (WebKitStyleTest.test_braces.CF_OPTIONS):
677         (WebKitStyleTest.test_braces):
678
679         Prevent CF_OPTIONS() from being handled as funtion definition.
680
681 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
682
683         [WTF] Move TextStream into WTF
684         https://bugs.webkit.org/show_bug.cgi?id=175211
685
686         Reviewed by Myles C. Maxfield.
687
688         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
689
690 2017-08-09  Andy Estes  <aestes@apple.com>
691
692         Part 3 of: Rename DatabaseProcess to StorageProcess
693         https://bugs.webkit.org/show_bug.cgi?id=175034
694
695         Reviewed by Brady Eidson.
696
697         * WebKitTestRunner/TestController.cpp:
698         (WTR::TestController::databaseProcessName): Updated to return
699         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
700
701 2017-08-09  Commit Queue  <commit-queue@webkit.org>
702
703         Unreviewed, rolling out r220466, r220477, and r220487.
704         https://bugs.webkit.org/show_bug.cgi?id=175411
705
706         This change broke existing API tests and follow up fixes did
707         not resolve all the issues. (Requested by ryanhaddad on
708         #webkit).
709
710         Reverted changesets:
711
712         https://bugs.webkit.org/show_bug.cgi?id=175244
713         http://trac.webkit.org/changeset/220466
714
715         "WTF::Function does not allow for reference / non-default
716         constructible return types"
717         https://bugs.webkit.org/show_bug.cgi?id=175244
718         http://trac.webkit.org/changeset/220477
719
720         https://bugs.webkit.org/show_bug.cgi?id=175244
721         http://trac.webkit.org/changeset/220487
722
723 2017-08-09  Sam Weinig  <sam@webkit.org>
724
725         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
726
727         Remove one addition of null Function test.
728
729 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
730
731         Allow nested timeouts in webkitpy
732         https://bugs.webkit.org/show_bug.cgi?id=175390
733         <rdar://problem/33803003>
734
735         Reviewed by David Kilzer.
736
737         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
738         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
739         the executive to detect and recover from any issues connecting with devices.
740
741         * Scripts/webkitpy/benchmark_runner/utils.py:
742         (TimeoutError): Deleted.
743         (timeout): Deleted.
744         * Scripts/webkitpy/common/timeout_context.py: Added.
745         (Timeout): A timeout context designed to be nested.
746         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
747         (Timeout.TimeoutData.__init__):
748         (Timeout.default_handler): Timeout handler used if none is specified.
749         (Timeout.current): Access data about the most urgent timeout.
750         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
751         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
752         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
753         urgent timeout data.
754         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
755         most urgent timeout data, if such data exists.
756         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
757         (TimeoutContextTests):
758         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
759         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
760         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
761         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
762         over a less urgent outer timeout.
763         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
764         over a less urgent inner timeout.
765         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
766         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
767         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
768         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
769         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
770         * Scripts/webkitpy/port/simulator_process.py:
771         (SimulatorProcess._start): Use Timeout class.
772         * Scripts/webkitpy/xcode/simulated_device.py:
773         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
774         (SimulatedDevice.launch_app): Ditto.
775         (SimulatedDevice.launch_app._install_timeout): Deleted.
776         * Scripts/webkitpy/xcode/simulator.py:
777         (Simulator.wait_until_device_is_booted):Use Timeout class.
778         (Simulator.wait_until_device_is_in_state): Ditto.
779
780 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
781
782         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
783         https://bugs.webkit.org/show_bug.cgi?id=175392
784         <rdar://problem/33783207>
785
786         Reviewed by Tim Horton and Megan Gardner.
787
788         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
789
790         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
791
792 2017-08-09  Sam Weinig  <sam@webkit.org>
793
794         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
795
796         * TestWebKitAPI/Tests/WTF/Function.cpp:
797         Remove tests of null Functions, as they are no longer supported.
798
799 2017-08-09  Daniel Bates  <dabates@apple.com>
800
801         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
802         https://bugs.webkit.org/show_bug.cgi?id=175247
803         <rdar://problem/33679804>
804
805         Reviewed by Brady Eidson.
806
807         Add tests for redirects.
808
809         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
810         (TEST):
811         * TestWebKitAPI/cocoa/TestProtocol.mm:
812         (createRedirectURL):
813         (-[TestProtocol startLoading]):
814
815 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
816
817         Unreviewed, rolling out r220393.
818
819         This patch regresses the performance of WebPage::editorState.
820
821         Reverted changeset:
822
823         "[iOS WK2] WKWebView schedules nonstop layout after pressing
824         cmb+b,i,u inside a contenteditable div"
825         https://bugs.webkit.org/show_bug.cgi?id=175116
826         http://trac.webkit.org/changeset/220393
827
828 2017-08-08  obinna obike  <oobike@apple.com>
829
830         Created Individual EWS Pages
831         https://bugs.webkit.org/show_bug.cgi?id=174477
832
833         Reviewed by Aakash Jain.
834
835         Created individual pages for each EWS. Changed the link within each status bubble
836         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
837
838         * QueueStatusServer/handlers/patch.py:
839         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
840         * QueueStatusServer/handlers/statusbubble.py:
841         (StatusBubble._build_bubble): Updated url for specific EWS.
842         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
843         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
844         all ews queues.
845         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
846         takes you directly to the individual ews page.
847
848 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
849
850         Separate jsc stress test script writer from run-jsc-stress-tests
851         https://bugs.webkit.org/show_bug.cgi?id=175216
852
853         Reviewed by Mark Lam.
854
855         * Scripts/run-jsc-stress-tests:
856         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
857
858 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
859
860         Unreviewed, fix Ubuntu LTS build
861         https://bugs.webkit.org/show_bug.cgi?id=174490
862
863         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
864
865 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
866
867         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
868         https://bugs.webkit.org/show_bug.cgi?id=175302
869         <rdar://problem/33762116>
870
871         Reviewed by Tim Horton.
872
873         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
874         See WebKit ChangeLog for more details.
875
876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
877         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
878         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
879         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
880         (-[SlowTextInputContext handleEvent:completionHandler:]):
881         (-[SlowInputWebView inputContext]):
882         (-[SlowInputWebView _web_superInputContext]):
883         (TEST):
884
885 2017-08-08  John Wilander  <wilander@apple.com>
886
887         Resource Load Statistics: Clear web processes' state on history removal
888         https://bugs.webkit.org/show_bug.cgi?id=175271
889         <rdar://problem/33756560>
890
891         Reviewed by Chris Dumez.
892
893         Test infrastructure for asynchronous tests of website data
894         removal for _WKWebsiteDataTypeResourceLoadStatistics.
895
896         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
897         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
898         (WTR::InjectedBundle::didReceiveMessageToPage):
899         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
900         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
901         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
902         * WebKitTestRunner/InjectedBundle/TestRunner.h:
903         * WebKitTestRunner/TestController.cpp:
904         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
905         * WebKitTestRunner/TestController.h:
906         * WebKitTestRunner/TestInvocation.cpp:
907         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
908         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
909         * WebKitTestRunner/TestInvocation.h:
910         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
911         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
912
913 2017-08-08  Alicia Boya García  <aboya@igalia.com>
914
915         Add Alicia Boya García as contributor
916         https://bugs.webkit.org/show_bug.cgi?id=175326
917
918         Reviewed by Michael Catanzaro.
919
920         * Scripts/webkitpy/common/config/contributors.json:
921
922 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
923
924         [CMake] Properly test if compiler supports compiler flags
925         https://bugs.webkit.org/show_bug.cgi?id=174490
926
927         Reviewed by Konstantin Tokarev.
928
929         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
930         * MiniBrowser/gtk/CMakeLists.txt:
931         * TestRunnerShared/Bindings/JSWrapper.cpp:
932         (WTR::JSWrapper::initialize):
933         * TestWebKitAPI/CMakeLists.txt:
934         * TestWebKitAPI/PlatformGTK.cmake:
935         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
936         (TestWebKitAPI::CheckedArithmeticTester::run):
937         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
938         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
939         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
940         (formControlsAssociatedCallback):
941         * TestWebKitAPI/glib/CMakeLists.txt:
942         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
943         (Test::getResourcesDir):
944         * WebKitTestRunner/CMakeLists.txt:
945         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
946         (WTR::menuItemClickCallback):
947         (WTR::staticConvertMenuItemToType):
948         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
949         (WTR::TestRunner::setUseDashboardCompatibilityMode):
950         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
951         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
952         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
953         (WTR::AccessibilityUIElement::helpText const):
954         (WTR::AccessibilityUIElement::attributedStringForRange):
955         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
956         (WTR::EventSenderProxy::updateTouchPoint):
957         (WTR::EventSenderProxy::releaseTouchPoint):
958
959 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
960
961         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
962         https://bugs.webkit.org/show_bug.cgi?id=175116
963         <rdar://problem/28279301>
964
965         Reviewed by Darin Adler and Ryosuke Niwa.
966
967         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
968         EditorStateTests run on both iOS and Mac.
969
970         * TestWebKitAPI/EditingTestHarness.h: Added.
971         * TestWebKitAPI/EditingTestHarness.mm: Added.
972
973         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
974         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
975         the state of the latest observed EditorState.
976
977         (-[EditingTestHarness initWithWebView:]):
978         (-[EditingTestHarness dealloc]):
979         (-[EditingTestHarness webView]):
980         (-[EditingTestHarness latestEditorState]):
981         (-[EditingTestHarness editorStateHistory]):
982         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
983         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
984         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
985         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
986         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
987         (-[EditingTestHarness toggleBold]):
988         (-[EditingTestHarness toggleItalic]):
989         (-[EditingTestHarness toggleUnderline]):
990         (-[EditingTestHarness setForegroundColor:]):
991         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
992         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
993         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
994         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
995         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
996         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
997         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
998
999         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
1000         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
1001         keys and values.
1002
1003         (-[EditingTestHarness latestEditorStateContains:]):
1004         (-[EditingTestHarness _webView:editorStateDidChange:]):
1005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1006         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
1007         (TestWebKitAPI::setUpEditorStateTestHarness):
1008         (TestWebKitAPI::TEST):
1009         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
1010
1011 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
1012
1013         Prevent domain from being set to a TLD
1014         https://bugs.webkit.org/show_bug.cgi?id=175226
1015         <rdar://problem/11079948>
1016
1017         Reviewed by Chris Dumez.
1018
1019         Extend the public suffix tests to include cases used by the
1020         Public Domain 'Public Suffix List'.
1021
1022         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
1023         (TestWebKitAPI::TEST):
1024
1025 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
1026
1027         [XCode] webkit-patch should run sort-Xcode-project-file
1028         https://bugs.webkit.org/show_bug.cgi?id=174036
1029         <rdar://problem/33732709>
1030
1031         Reviewed by Simon Fraser.
1032
1033         * Scripts/webkitpy/common/config/ports.py:
1034         * Scripts/webkitpy/tool/commands/download.py:
1035         * Scripts/webkitpy/tool/commands/download_unittest.py:
1036         * Scripts/webkitpy/tool/commands/upload.py:
1037         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1038         * Scripts/webkitpy/tool/steps/__init__.py:
1039         * Scripts/webkitpy/tool/steps/options.py:
1040         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1041
1042 2017-08-07  Devin Rousso  <drousso@apple.com>
1043
1044         Web Inspector: Preview Canvas path when viewing a recording
1045         https://bugs.webkit.org/show_bug.cgi?id=174967
1046
1047         Reviewed by Brian Burg.
1048
1049         * DumpRenderTree/TestOptions.h:
1050         * DumpRenderTree/TestOptions.mm:
1051         (TestOptions::TestOptions):
1052         * DumpRenderTree/mac/DumpRenderTree.mm:
1053         (setWebPreferencesForTestOptions):
1054         * WebKitTestRunner/TestController.cpp:
1055         (WTR::TestController::resetPreferencesToConsistentValues):
1056         (WTR::updateTestOptionsFromTestHeader):
1057         * WebKitTestRunner/TestOptions.h:
1058         (WTR::TestOptions::hasSameInitializationOptions const):
1059         Add plumbing for new InspectorAdditions runtime flag.
1060
1061 2017-08-07  obinna obike  <oobike@apple.com>
1062
1063         Sorted EWS Queues on Patch page
1064         https://bugs.webkit.org/show_bug.cgi?id=173667
1065
1066         Reviewed by Aakash Jain.
1067
1068         * QueueStatusServer/handlers/patch.py:
1069         (Patch.get): Sorted queue_status.
1070         * QueueStatusServer/templates/patch.html:
1071         Changed queue_status.items to queue_status because it's a list.
1072
1073 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1074
1075         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
1076         https://bugs.webkit.org/show_bug.cgi?id=175286
1077
1078         Reviewed by Myles C. Maxfield.
1079
1080         * Scripts/webkitpy/style/checkers/cpp.py:
1081         (check_braces):
1082         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1083         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
1084         (WebKitStyleTest.test_braces):
1085         (WebKitStyleTest.test_braces.NS_OPTIONS):
1086
1087 2017-08-07  Brian Burg  <bburg@apple.com>
1088
1089         Remove CANVAS_PATH compilation guard
1090         https://bugs.webkit.org/show_bug.cgi?id=175207
1091
1092         Reviewed by Sam Weinig.
1093
1094         * Scripts/webkitperl/FeatureList.pm:
1095         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1096
1097 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
1098
1099         [Win] Use Visual Studio 2017 if installed.
1100         https://bugs.webkit.org/show_bug.cgi?id=175188
1101
1102         Reviewed by Sam Weinig.
1103
1104         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
1105
1106         * Scripts/webkitdirs.pm:
1107         (visualStudioInstallDir):
1108         (msBuildInstallDir):
1109
1110 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1111
1112         [GTK][WPE] Add API to provide browser information required by automation
1113         https://bugs.webkit.org/show_bug.cgi?id=175130
1114
1115         Reviewed by Michael Catanzaro.
1116
1117         * MiniBrowser/gtk/main.c:
1118         (automationStartedCallback): Set browser information when a new automation session is started.
1119         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1120         (testAutomationSessionApplicationInfo):
1121         (beforeAll):
1122
1123 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
1124
1125         Unreviewed, rolling out r220295.
1126
1127         This change introduced 4 errors in webkitpy tests.
1128
1129         Reverted changeset:
1130
1131         "[XCode] webkit-patch should run sort-Xcode-project-file"
1132         https://bugs.webkit.org/show_bug.cgi?id=174036
1133         http://trac.webkit.org/changeset/220295
1134
1135 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1136
1137         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
1138
1139         Unreviewed test gardening.
1140
1141         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1142         (TestWebKitAPI::TEST):
1143
1144 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
1145
1146         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
1147         https://bugs.webkit.org/show_bug.cgi?id=175083
1148
1149         Reviewed by Oliver Hunt.
1150         
1151         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
1152         to wait for VM destructions to finish before running the next test. This makes it easier to 
1153         understand leaks results from workers tests, and leads to fewer reported leaks.
1154
1155         * DumpRenderTree/mac/DumpRenderTree.mm:
1156         (runTest):
1157
1158 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1159
1160         check-webkit-style: fix path-specific rules for WebKit2 rename
1161         https://bugs.webkit.org/show_bug.cgi?id=175182
1162
1163         Reviewed by David Kilzer.
1164
1165         * Scripts/webkitpy/style/checker.py:
1166
1167 2017-08-04  Youenn Fablet  <youenn@apple.com>
1168
1169         [Cache API] Add Cache and CacheStorage IDL definitions
1170         https://bugs.webkit.org/show_bug.cgi?id=175201
1171
1172         Reviewed by Brady Eidson.
1173
1174         * DumpRenderTree/mac/DumpRenderTree.mm:
1175         (enableExperimentalFeatures):
1176         (resetWebPreferencesToConsistentValues):
1177         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1178         (WTR::InjectedBundle::beginTesting):
1179         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1180         (WTR::TestRunner::setCacheAPIEnabled):
1181         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1182
1183 2017-08-04  John Wilander  <wilander@apple.com>
1184
1185         Resource Load Statistics: Report user interaction immediately, but only when needed
1186         https://bugs.webkit.org/show_bug.cgi?id=175090
1187         <rdar://problem/33685546>
1188
1189         Reviewed by Chris Dumez.
1190
1191         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1192         (WTR::InjectedBundle::beginTesting):
1193             Now calls WebCore::ResourceLoadObserver::clearState().
1194
1195 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1196
1197         Add an API test for r220286
1198         https://bugs.webkit.org/show_bug.cgi?id=175206
1199
1200         Reviewed by Simon Fraser.
1201
1202         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1203         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1204         (createAnimatedResizeWebView):
1205         (TEST):
1206         Add a test to ensure that we don't call
1207         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1208         animated resize.
1209
1210 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1211
1212         [XCode] webkit-patch should run sort-Xcode-project-file
1213         https://bugs.webkit.org/show_bug.cgi?id=174036
1214
1215         Reviewed by Simon Fraser.
1216
1217         * Scripts/webkitpy/common/config/ports.py:
1218         * Scripts/webkitpy/tool/commands/download.py:
1219         * Scripts/webkitpy/tool/commands/upload.py:
1220         * Scripts/webkitpy/tool/steps/__init__.py:
1221         * Scripts/webkitpy/tool/steps/options.py:
1222         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1223
1224 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1225
1226         REGRESSION(r219857): run-benchmark --allplans broken
1227         https://bugs.webkit.org/show_bug.cgi?id=175186
1228
1229         Reviewed by Saam Barati.
1230
1231         r219857 forgot to update also the calls to BenchmarkRunner() that
1232         is done when the script is run with --allplans.
1233
1234         To fix this (and avoid future issues like this), let's factorize
1235         the calls to the benchhmark runner in a run_benchmark_plan()
1236         function.
1237
1238         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1239         (run_benchmark_plan):
1240         (start):
1241
1242 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1243
1244         Dashboard bubbles sometimes show failure count instead of crash count
1245         https://bugs.webkit.org/show_bug.cgi?id=175157
1246         <rdar://problem/33709009>
1247
1248         Reviewed by Alexey Proskuryakov.
1249
1250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1251         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1252
1253 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1254
1255         Add tests for NeverDestroyed
1256         https://bugs.webkit.org/show_bug.cgi?id=175146
1257
1258         Reviewed by Darin Adler.
1259
1260         * CMakeLists.txt:
1261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1262         New files and sort.
1263
1264         * TestWebKitAPI/Tests/WTF/Logger.h:
1265         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1266         (TestWebKitAPI::log):
1267         (TestWebKitAPI::takeLogStr):
1268         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1269         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1270         (TestWebKitAPI::log): Deleted.
1271         (TestWebKitAPI::takeLogStr): Deleted.
1272         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1273
1274         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1275         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1276         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1277         (TestWebKitAPI::LifecycleLogger::operator=):
1278         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1279         (TestWebKitAPI::LifecycleLogger::setName):
1280         (TestWebKitAPI::TEST):
1281         Add a class that logs construction / assignment / modifications.
1282
1283         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1284         (TestWebKitAPI::TEST):
1285         (TestWebKitAPI::list):
1286         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1287
1288 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1289
1290         minification logic is not implemented for ios builds
1291         <rdar://problem/33726561>
1292
1293         Reviewed by Dean Johnson
1294
1295         * BuildSlaveSupport/built-product-archive:
1296         (minifyDirectory): refactor minifySource -> minifyDirectory
1297         (archiveBuiltProduct): add ios minification logic
1298         (minifySource): Deleted.
1299
1300 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1301
1302         Unreviewed, rolling out r220271.
1303
1304         Rolling out due to Layout Test failing on iOS Simulator.
1305
1306         Reverted changeset:
1307
1308         "Remove STREAMS_API compilation guard"
1309         https://bugs.webkit.org/show_bug.cgi?id=175165
1310         http://trac.webkit.org/changeset/220271
1311
1312 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1313
1314         Unreviewed, rolling out r220268.
1315
1316         This change caused assertion failures on macOS and iOS Debug
1317         WK2.
1318
1319         Reverted changeset:
1320
1321         "Resource Load Statistics: Report user interaction
1322         immediately, but only when needed"
1323         https://bugs.webkit.org/show_bug.cgi?id=175090
1324         http://trac.webkit.org/changeset/220268
1325
1326 2017-08-04  Youenn Fablet  <youenn@apple.com>
1327
1328         Remove STREAMS_API compilation guard
1329         https://bugs.webkit.org/show_bug.cgi?id=175165
1330
1331         Reviewed by Darin Adler.
1332
1333         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1334
1335 2017-08-04  John Wilander  <wilander@apple.com>
1336
1337         Resource Load Statistics: Report user interaction immediately, but only when needed
1338         https://bugs.webkit.org/show_bug.cgi?id=175090
1339         <rdar://problem/33685546>
1340
1341         Reviewed by Chris Dumez.
1342
1343         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1344         (WTR::InjectedBundle::beginTesting):
1345             Now calls WebCore::ResourceLoadObserver::clearState().
1346
1347 2017-08-03  Brian Burg  <bburg@apple.com>
1348
1349         Remove ENABLE(WEB_SOCKET) guards
1350         https://bugs.webkit.org/show_bug.cgi?id=167044
1351
1352         Reviewed by Joseph Pecoraro.
1353
1354         * Scripts/webkitperl/FeatureList.pm:
1355         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1356
1357 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1358
1359         REGRESSION(r219850): run-benchmark script broken on Linux
1360         https://bugs.webkit.org/show_bug.cgi?id=175126
1361
1362         Reviewed by Stephanie Lewis.
1363
1364         The run-benchmark script dynamically generates the list of supported
1365         browsers and platforms (currently Linux and OSX) by loading all
1366         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1367         and getting the browser_name and platform variables from the
1368         classes defined there.
1369
1370         This means that this classes should not raise an exception when
1371         loaded on other platforms or otherwise they will broke the whole
1372         script. Its fine if they raise an exception when executing any of
1373         the methods they implement, but not when just loading/importing
1374         the class.
1375
1376         Move the argument variable definitions that call on the platform
1377         specific OSXBrowserDriver._screen_size() function from beeing
1378         variables that are evaluated when loading the file, to be functions
1379         that are only evaluated when the actual functionality needs to be
1380         executed.
1381
1382         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1383         (OSXChromeDriver.launch_url):
1384         (OSXChromeCanaryDriver.launch_url):
1385         (create_args):
1386         (create_chrome_options):
1387         (create_window_size_arg):
1388         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1389         (OSXFirefoxDriver.launch_url):
1390         (OSXFirefoxNightlyDriver.launch_url):
1391         (OSXFirefoxNightlyDriver.launch_driver):
1392         (create_args):
1393
1394 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1395
1396         [PAL] Move spi/cf directory into PAL
1397         https://bugs.webkit.org/show_bug.cgi?id=175057
1398
1399         Reviewed by Antti Koivisto.
1400
1401         * Scripts/webkitpy/style/checker.py:
1402         * Scripts/webkitpy/style/checker_unittest.py:
1403         (GlobalVariablesTest.test_path_rules_specifier):
1404
1405         Ignore "readability/naming/underscores" style errors for sources
1406         under the WebCore/PAL/pal/spi directory.
1407
1408         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1409
1410 2017-08-03  Youenn Fablet  <youenn@apple.com>
1411
1412         Remove FETCH_API compilation guard
1413         https://bugs.webkit.org/show_bug.cgi?id=175154
1414
1415         Reviewed by Chris Dumez.
1416
1417         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1418
1419 2017-08-03  Lucas Forschler  <lforschler@apple.com>
1420
1421         Enable archive minification on iOS builds
1422         https://bugs.webkit.org/show_bug.cgi?id=174718
1423         
1424         Reviewed by Aakash Jain.
1425
1426         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1427         (BuildFactory.__init__):
1428
1429 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1430
1431         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
1432         https://bugs.webkit.org/show_bug.cgi?id=175140
1433
1434         Reviewed by Alexey Proskuryakov.
1435
1436         We are having lately issues with JSC tests causing problems on
1437         the GTK+ and WPE bots due to the high amount of memory some tests
1438         need to run.
1439
1440         The best thing we can do now is to workaround this by disabling
1441         all the tests marked as memoryLimited on the GTK and WPE bots.
1442         We may revise this on the future.
1443
1444         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1445         (RunJavaScriptCoreTests.start):
1446
1447 2017-08-03  Brady Eidson  <beidson@apple.com>
1448
1449         Add SW IDLs and stub out basic functionality.
1450         https://bugs.webkit.org/show_bug.cgi?id=175115
1451
1452         Reviewed by Chris Dumez.
1453
1454         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1455
1456         * Scripts/webkitpy/bindings/main.py:
1457
1458 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
1459
1460         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
1461         https://bugs.webkit.org/show_bug.cgi?id=159510
1462
1463         Reviewed by Daniel Bates.
1464
1465         Allow any https certificate when running tests.
1466
1467         * DumpRenderTree/win/DumpRenderTree.cpp:
1468         (runTest):
1469
1470 2017-08-02  Youenn Fablet  <youenn@apple.com>
1471
1472         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
1473         https://bugs.webkit.org/show_bug.cgi?id=175089
1474
1475         Reviewed by Chris Dumez.
1476
1477         * DumpRenderTree/TestOptions.mm:
1478         (TestOptions::TestOptions): Using absolutePath if available.
1479         * DumpRenderTree/mac/DumpRenderTree.mm:
1480         (computeTestURL): Removing http/tests/ specific URL computation.
1481         * Scripts/webkitpy/port/driver.py:
1482         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
1483
1484 2017-08-02  Lucas Forschler  <lforschler@apple.com>
1485
1486         download-built-product should allow for a proxy option
1487         https://bugs.webkit.org/show_bug.cgi?id=174875
1488
1489         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
1490
1491         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1492         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
1493         
1494
1495 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1496
1497         check-webkit-style: deleting lines in a file runs the linter on the whole file
1498         https://bugs.webkit.org/show_bug.cgi?id=175078
1499
1500         Reviewed by David Kilzer.
1501
1502         Deleting lines in a file should not cause linter errors to be blamed on the patch.
1503         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
1504
1505         * Scripts/webkitpy/style/checkers/test_expectations.py:
1506         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
1507         * Scripts/webkitpy/style/main_unittest.py:
1508         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
1509         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
1510         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
1511
1512 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1513
1514         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
1515         https://bugs.webkit.org/show_bug.cgi?id=175075
1516
1517         Reviewed by David Kilzer.
1518
1519         We have no way of handling text files with illegal unicode characters. Allow the callers of
1520         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
1521         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
1522
1523         * Scripts/webkitpy/common/system/filesystem.py:
1524         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
1525         (FileSystem.write_text_file): Ditto.
1526         * Scripts/webkitpy/common/system/filesystem_mock.py:
1527         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
1528         (MockFileSystem.write_text_file): Ditto.
1529         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1530         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
1531         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
1532
1533 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
1534
1535         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
1536         https://bugs.webkit.org/show_bug.cgi?id=175072
1537
1538         Reviewed by Alexey Proskuryakov.
1539
1540         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1541         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
1542
1543 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1544
1545         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
1546         https://bugs.webkit.org/show_bug.cgi?id=175019
1547
1548         Reviewed by Darin Adler.
1549
1550         * TestWebKitAPI/CMakeLists.txt:
1551
1552 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1553
1554         Enabling uploading archives to S3
1555         https://bugs.webkit.org/show_bug.cgi?id=174198
1556
1557         Unreviewed unit test fix after r219235.
1558
1559         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1560
1561 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1562
1563         Fix JSCOnly ARM buildbots after r220047
1564         https://bugs.webkit.org/show_bug.cgi?id=174993
1565
1566         Unreviewed fix after r220087.
1567
1568         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1569         (BuildAndRemoteJSCTestsFactory.__init__):
1570
1571 2017-08-01  Chris Dumez  <cdumez@apple.com>
1572
1573         Add initial support for navigator.sendBeacon
1574         https://bugs.webkit.org/show_bug.cgi?id=175007
1575         <rdar://problem/33547728>
1576
1577         Reviewed by Sam Weinig.
1578
1579         Enable the Beacon API at runtime in the context of layout tests since the
1580         feature is currently disabled by default.
1581
1582         * DumpRenderTree/mac/DumpRenderTree.mm:
1583         (enableExperimentalFeatures):
1584         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1585         (WTR::InjectedBundle::beginTesting):
1586         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1587         (WTR::TestRunner::setModernMediaControlsEnabled):
1588         (WTR::TestRunner::setBeaconAPIEnabled):
1589         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1590
1591 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
1592
1593         Update Bot Watcher's Dashboard for Buildbot 0.9
1594         https://bugs.webkit.org/show_bug.cgi?id=174777
1595
1596         Reviewed by Daniel Bates.
1597
1598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1599         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
1600         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
1601         in a dictionary.
1602         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
1603         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
1604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1605         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
1606         (parseRevisionProperty): Ditto.
1607         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
1608         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
1609         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
1610         have changed in Buildbot 0.9.
1611         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
1612         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
1613         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
1614         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
1615         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
1616         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
1617         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
1618         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
1619         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
1620         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
1621         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1622         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
1623         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
1624         (BuildbotQueue.prototype.get overviewURL): Ditto.
1625         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
1626         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
1627         Buildbot 0.8 or 0.9.
1628         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
1629         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
1630         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
1631         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
1632         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
1633         Therefore we are fetching information for fixed number of build. 
1634         Also iterating the loop incrementally since the build data is already reverse sorted.
1635         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1636         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
1637         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
1638         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1639         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
1640
1641 2017-08-01  Devin Rousso  <drousso@apple.com>
1642
1643         Web Inspector: simplify WebInspector with WI
1644         https://bugs.webkit.org/show_bug.cgi?id=175058
1645
1646         Reviewed by Joseph Pecoraro.
1647
1648         * Scripts/check-inspector-strings:
1649         (extract_ui_strings):
1650         * Scripts/extract-localizable-js-strings:
1651
1652 2017-08-01  Youenn Fablet  <youenn@apple.com>
1653
1654         Layout tests with 'https' suffix should be run over HTTPS
1655         https://bugs.webkit.org/show_bug.cgi?id=174992
1656
1657         Reviewed by Chris Dumez.
1658
1659         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
1660         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
1661         Covered by corresponding unit tests.
1662
1663         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1664         (run_server):
1665         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1666         (base_http_url):
1667         (base_https_url):
1668         (base_url): Deleted.
1669         * Scripts/webkitpy/port/base.py:
1670         (Port.to.web_platform_test_server_base_http_url):
1671         (Port.to):
1672         (Port.to.web_platform_test_server_base_https_url):
1673         (Port.to.web_platform_test_server_base_url): Deleted.
1674         * Scripts/webkitpy/port/driver.py:
1675         (Driver.__init__):
1676         (Driver.wpt_test_path_to_uri):
1677         (Driver):
1678         (Driver.http_test_path_to_uri):
1679         (Driver.test_to_uri):
1680         (Driver.uri_to_test):
1681         * Scripts/webkitpy/port/driver_unittest.py:
1682         (DriverTest.test_test_to_uri):
1683         (DriverTest.test_uri_to_test):
1684
1685 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1686
1687         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
1688         https://bugs.webkit.org/show_bug.cgi?id=173998
1689
1690         Reviewed by Darin Adler.
1691
1692         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
1693         detect mistakes in backward compatibility in the future when we change it.
1694
1695         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
1696         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
1697         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
1698         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
1699         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
1700         internal key data slot.
1701
1702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1703         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
1704         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
1705         (getNextMessage):
1706         (TEST):
1707         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
1708         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
1709         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
1710         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
1711         These are the pre-baked databases.
1712         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
1713         This is the actual test that do all the reads and comparisons.
1714         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
1715         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
1716         IndexedDB new stuffs. Then it can be used to bake the database again.
1717
1718 2017-08-01  Brady Eidson  <beidson@apple.com>
1719
1720         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
1721         https://bugs.webkit.org/show_bug.cgi?id=175030
1722
1723         Reviewed by Andy Estes.
1724
1725         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1726         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
1727
1728 2017-08-01  Brady Eidson  <beidson@apple.com>
1729
1730         Part 2 of: Rename DatabaseProcess to StorageProcess.
1731         https://bugs.webkit.org/show_bug.cgi?id=174880
1732
1733         Reviewed by Andy Estes.
1734
1735         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1736         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1737         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1738         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1739         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1740         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1741         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1742         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1743
1744 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
1745
1746         Fix JSCOnly ARM buildbots after r220047
1747         https://bugs.webkit.org/show_bug.cgi?id=174993
1748
1749         Reviewed by Saam Barati.
1750
1751         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1752         (BuildAndRemoteJSCTestsFactory.__init__):
1753
1754 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1755
1756         [WTF] Introduce Private Symbols
1757         https://bugs.webkit.org/show_bug.cgi?id=174935
1758
1759         Reviewed by Darin Adler.
1760
1761         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1762         (TestWebKitAPI::TEST):
1763
1764 2017-07-30  Darin Adler  <darin@apple.com>
1765
1766         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
1767         https://bugs.webkit.org/show_bug.cgi?id=130653
1768
1769         Reviewed by Antti Koivisto.
1770
1771         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1772         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
1773         when calling frameDidChangeLocation.
1774         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
1775         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
1776         thus causing mysterious failures of a couple of tests. There are two remaining issues:
1777         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
1778         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
1779         same logic flaw that causes "top loading frame" to get set to one of the subframes in
1780         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
1781         loading, subframe starts loading. It would be good to clean that up some day, but for now
1782         this patch makes the two work identically rather than changing both.
1783         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
1784
1785 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1786
1787         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
1788         https://bugs.webkit.org/show_bug.cgi?id=174963
1789
1790         Reviewed by Darin Adler.
1791
1792         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
1793         RetainPtr<>. This patch changes them to all use auto.
1794
1795         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1796         (TestWebKitAPI::TEST):
1797
1798 2017-07-30  Brady Eidson  <beidson@apple.com>
1799
1800         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
1801         https://bugs.webkit.org/show_bug.cgi?id=174958
1802
1803         Reviewed by Darin Adler.
1804
1805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1806         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
1807         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
1808         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
1809         (runUntilTasksInFlight):
1810         (TEST):
1811
1812 2017-07-28  Commit Queue  <commit-queue@webkit.org>
1813
1814         Unreviewed, rolling out r219990.
1815         https://bugs.webkit.org/show_bug.cgi?id=174961
1816
1817         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
1818         estes on #webkit).
1819
1820         Reverted changeset:
1821
1822         "Part 2 of: Rename DatabaseProcess to StorageProcess."
1823         https://bugs.webkit.org/show_bug.cgi?id=174880
1824         http://trac.webkit.org/changeset/219990
1825
1826 2017-07-28  Brady Eidson  <beidson@apple.com>
1827
1828         API tests that use URLSchemeHandler are failing.
1829         https://bugs.webkit.org/show_bug.cgi?id=174950
1830
1831         Reviewed by Alex Christensen.
1832
1833         Fix the NoMIMEType test to be correct.
1834
1835         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1836         (-[SchemeHandler initWithData:mimeType:]):
1837         (-[SchemeHandler webView:startURLSchemeTask:]):
1838         (TEST):
1839
1840 2017-07-28  Daniel Bates  <dabates@apple.com>
1841
1842         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
1843         https://bugs.webkit.org/show_bug.cgi?id=174876
1844
1845         Reviewed by Alex Christensen.
1846
1847         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
1848         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
1849         they provide a more direct way to test the platform abstraction.
1850
1851         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
1852
1853         * Scripts/prepare-ChangeLog:
1854         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
1855         of the current working directory.
1856
1857 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
1858
1859         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1860         https://bugs.webkit.org/show_bug.cgi?id=174930
1861
1862         Unreviewed test fix.
1863
1864         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
1865
1866         * Scripts/prepare-ChangeLog:
1867         (get_function_line_ranges_for_cpp):
1868
1869 2017-07-28  JF Bastien  <jfbastien@apple.com>
1870
1871         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1872         https://bugs.webkit.org/show_bug.cgi?id=174930
1873
1874         Reviewed by Daniel Bates.
1875
1876         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
1877         here also teach it about const and volatile overloads. I didn't do
1878         reference and rvalue reference overloads because we don't really
1879         use them, and the current parser throws away those characters and
1880         it doesn't seem worth making it more complex.
1881
1882         * Scripts/prepare-ChangeLog:
1883         (get_function_line_ranges_for_cpp):
1884         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1885         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1886         (Foo::Arrow::arrow):
1887         (Foo::Arrow::otherArrow):
1888         (Foo::Arrow::otherArrow const):
1889         (Foo::Arrow::otherArrow volatile):
1890         (Foo::Arrow::otherArrow const volatile):
1891
1892 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
1893
1894         [GTK] Building with ENABLE_VIDEO=OFF fails
1895         https://bugs.webkit.org/show_bug.cgi?id=174940
1896
1897         Reviewed by Alex Christensen.
1898
1899         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
1900         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
1901
1902         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1903         (methodCallCallback): Add missing USE(GSTREAMER) guard.
1904
1905 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
1906
1907         [WPE] Implement EventSenderProxy in WTR
1908         https://bugs.webkit.org/show_bug.cgi?id=173419
1909
1910         Reviewed by Žan Doberšek.
1911
1912         Add the implementation of EventSenderProxy to the WTR. This
1913         allows us to extend the coverage of the test suite in WKWPE.
1914
1915         * WebKitTestRunner/EventSenderProxy.h:
1916         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
1917         libxkbcommon needed to deal with key events.
1918         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1919         (WTR::EventSenderProxy::EventSenderProxy):
1920         (WTR::senderButtonToWPEButton):
1921         (WTR::EventSenderProxy::mouseDown):
1922         (WTR::EventSenderProxy::mouseUp):
1923         (WTR::EventSenderProxy::mouseMoveTo):
1924         (WTR::EventSenderProxy::mouseScrollBy):
1925         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1926         (WTR::EventSenderProxy::leapForward):
1927         (WTR::wkEventModifiersToWPE):
1928         (WTR::getXKBKeySymForKeyRef):
1929         (WTR::EventSenderProxy::keyDown):
1930         (WTR::EventSenderProxy::addTouchPoint):
1931         (WTR::EventSenderProxy::updateTouchPoint):
1932         (WTR::EventSenderProxy::setTouchModifier):
1933         (WTR::EventSenderProxy::setTouchPointRadius):
1934         (WTR::EventSenderProxy::getUpdatedTouchEvents):
1935         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
1936         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1937         (WTR::EventSenderProxy::touchStart):
1938         (WTR::EventSenderProxy::touchMove):
1939         (WTR::EventSenderProxy::touchEnd):
1940         (WTR::EventSenderProxy::touchCancel):
1941         (WTR::EventSenderProxy::clearTouchPoints):
1942         (WTR::EventSenderProxy::releaseTouchPoint):
1943         (WTR::EventSenderProxy::cancelTouchPoint):
1944
1945 2017-07-27  Brady Eidson  <beidson@apple.com>
1946
1947         Part 2 of: Rename DatabaseProcess to StorageProcess.
1948         https://bugs.webkit.org/show_bug.cgi?id=174880
1949
1950         Reviewed by Andy Estes.
1951
1952         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1953         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1954         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1955         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1956         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1957         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1958         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1959         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1960
1961 2017-07-26  Mark Lam  <mark.lam@apple.com>
1962
1963         Add ability to only run specific tests in run-javascriptcore-tests.
1964         https://bugs.webkit.org/show_bug.cgi?id=174884
1965
1966         Reviewed by Saam Barati.
1967
1968         For example, if we only want to run testapi, we can do so as follows:
1969             $ run-javascriptcore-tests --testapi
1970
1971         Previously, specifying --testapi effectively does nothing because we run all tests
1972         by default.  Only --no-testapi had the effect of disabling the test set.  This
1973         old behavior for --testapi is not very useful or meaningful.  We're now changing
1974         it to mean that we will only run that test.
1975
1976         With this change, we can also run more than one set of tests.  For example, if we
1977         only want to run testmasm and testair, we can do so as follows:
1978             $ run-javascriptcore-tests --testmasm --testair
1979
1980         By default, if no specific test option is specified, run-javascriptcore-tests will
1981         run all tests.
1982
1983         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
1984         the mozilla tests (--mozilla-tests) even though both are run via the lower level
1985         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
1986         the other set will not run.  For example, the following only runs the mozilla tests:
1987             $ run-javascriptcore-tests --mozilla-tests
1988
1989         Note also that --jit-stress-tests is not for choosing a different set of tests.
1990         Instead, it is used for determining whether we run JIT'ed test configurations
1991         on the jsc stress tests and mozilla tests.  As a result, specifying
1992         --jit-stress-tests will not omit other tests.  For example, the following still
1993         runs all tests:
1994             $ run-javascriptcore-tests --jit-stress-tests
1995
1996         * Scripts/run-javascriptcore-tests:
1997         (defaultStringForTestState):
1998         (enableTestOrNot):
1999         (runJSCStressTests):
2000
2001 2017-07-26  Mark Lam  <mark.lam@apple.com>
2002
2003         Make run-javascriptcore-test run testair, testb3, and testmasm.
2004         https://bugs.webkit.org/show_bug.cgi?id=174837
2005         <rdar://problem/33522927>
2006
2007         Reviewed by Saam Barati and Filip Pizlo.
2008
2009         1. Refactors code for running testapi so that we can use it to run other tests.
2010         2. Added running of testmasm, testair, testb3.
2011
2012         Note: the existing testapi invocation code does not support remote invocation of
2013         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
2014         and testb3 also do not support remote invocation.  If we wish to add remote
2015         invocation support, we should do that in a separate patch.
2016
2017         * Scripts/run-javascriptcore-tests:
2018         (testPath):
2019         (runTest):
2020         (testapiPath): Deleted.
2021
2022 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2023
2024         Remove duplicate code from Buildbot.js in dashboard
2025         https://bugs.webkit.org/show_bug.cgi?id=174870
2026
2027         Reviewed by Daniel Bates.
2028
2029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2030         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
2031         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
2032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
2033         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
2034
2035 2017-07-26  Brady Eidson  <beidson@apple.com>
2036
2037         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
2038         https://bugs.webkit.org/show_bug.cgi?id=174851
2039
2040         Reviewed by Chris Dumez.
2041
2042         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2043         (TEST):
2044
2045 2017-07-26  Brian Burg  <bburg@apple.com>
2046
2047         Remove WEB_TIMING feature flag
2048         https://bugs.webkit.org/show_bug.cgi?id=174795
2049
2050         Reviewed by Alex Christensen.
2051
2052         * Scripts/webkitperl/FeatureList.pm:
2053         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2054
2055 2017-07-26  Chris Dumez  <cdumez@apple.com>
2056
2057         Pressing the Escape key should not be a valid user gesture to enter fullscreen
2058         https://bugs.webkit.org/show_bug.cgi?id=174864
2059         <rdar://problem/33009088>
2060
2061         Reviewed by Geoffrey Garen.
2062
2063         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
2064         WKTR.
2065
2066         * DumpRenderTree/mac/EventSendingController.mm:
2067         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2068
2069 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2070
2071         Unreviewed, added Romain Bellessort to contributors.json.
2072
2073         * Scripts/webkitpy/common/config/contributors.json:
2074
2075 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
2076
2077         [WPE] WebGL2 support
2078         https://bugs.webkit.org/show_bug.cgi?id=174249
2079
2080         Reviewed by Alex Christensen.
2081
2082         * Scripts/webkitperl/FeatureList.pm:
2083         Enable WebGL2 for WPE when building through build-webkit.
2084
2085 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2086
2087         Unreviewed. Fix GTK distcheck.
2088
2089         * gtk/make-dist.py:
2090         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
2091
2092 2017-07-25  Brady Eidson  <beidson@apple.com>
2093
2094         ResourceLoadStatistics grandfathering happens much too often.
2095         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
2096
2097         Reviewed by Chris Dumez.
2098
2099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2100         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
2101         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
2102         (TEST):
2103
2104 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2105
2106         Fix autoinstaller failing on autoinstall_everything
2107         https://bugs.webkit.org/show_bug.cgi?id=174830
2108
2109         Reviewed by Joseph Pecoraro.
2110
2111         * Scripts/webkitpy/thirdparty/__init__.py:
2112         (AutoinstallImportHook.find_module):
2113         (AutoinstallImportHook.install_chromedriver):
2114         (AutoinstallImportHook.install_geckodriver):
2115         (AutoinstallImportHook._install_chromedriver): Deleted.
2116         (AutoinstallImportHook._install_geckodriver): Deleted.
2117
2118 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
2119
2120         Replace --runtime with something for both ios-simulator and ios-device
2121         https://bugs.webkit.org/show_bug.cgi?id=173775
2122         <rdar://problem/32952164>
2123
2124         Reviewed by Aakash Jain.
2125
2126         Add --version flag for both iOS simulator and iOS device.
2127
2128         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2129         (parse_args): Add --version flag and move --no-install.
2130         * Scripts/webkitpy/port/factory.py:
2131         (platform_options): Move --no-intall to run_webkit_tests.py.
2132         * Scripts/webkitpy/port/ios.py:
2133         (IOSPort):
2134         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
2135         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
2136         * Scripts/webkitpy/port/ios_device.py:
2137         (IOSDevicePort.ios_version): Consult --version flag before checking connected
2138         devices for iOS version.
2139         * Scripts/webkitpy/port/ios_device_unittest.py:
2140         (IOSDeviceTest.make_port): Set --version option so that we can generate test
2141         expectation paths without devices connected.
2142         (IOSDeviceTest.test_additional_platform_directory): Deleted.
2143         (IOSDeviceTest.test_baseline_searchpath): Deleted.
2144         (IOSDeviceTest.test_expectations_ordering): Deleted.
2145         * Scripts/webkitpy/port/ios_simulator.py:
2146         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
2147         flag to specify a runtime.
2148         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
2149         flag and then use the default runtime.
2150
2151 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2152
2153         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
2154         https://bugs.webkit.org/show_bug.cgi?id=174815
2155
2156         Reviewed by Carlos Alberto Lopez Perez.
2157
2158         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
2159         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
2160         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
2161         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
2162         think), probably because of a newer CMake version.
2163
2164         * CMakeLists.txt:
2165         * TestWebKitAPI/CMakeLists.txt:
2166         * TestWebKitAPI/PlatformGTK.cmake:
2167
2168 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2169
2170         Fix BenchmarkRunner to only import selenium when needed
2171         https://bugs.webkit.org/show_bug.cgi?id=174808
2172
2173         Reviewed by Stephanie Lewis.
2174
2175         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2176         (LinuxChromeDriver.launch_driver):
2177         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2178         (LinuxFirefoxDriver.launch_driver):
2179         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2180         (OSXChromeDriver.launch_driver):
2181         (OSXChromeCanaryDriver.launch_driver):
2182         (create_chrome_options):
2183         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2184         (OSXFirefoxDriver.launch_driver):
2185         (OSXFirefoxNightlyDriver.launch_driver):
2186         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2187         (OSXSafariDriver.launch_driver):
2188         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2189         (WebDriverBenchmarkRunner._run_one_test):
2190
2191 2017-07-23  Darin Adler  <darin@apple.com>
2192
2193         More NeverDestroyed and related cleanup
2194         https://bugs.webkit.org/show_bug.cgi?id=174745
2195
2196         Reviewed by Alex Christensen.
2197
2198         * DumpRenderTree/JavaScriptThreading.cpp:
2199         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2200         DEPRECATED_DEFINE_STATIC_LOCAL.
2201         (javaScriptThreads): Ditto.
2202
2203 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2204
2205         Subclass Benchmark Runner script for WebDriver support
2206         https://bugs.webkit.org/show_bug.cgi?id=174390
2207
2208         Reviewed by Dewei Zhu, Stephanie Lewis.
2209
2210         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2211
2212         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2213         (BenchmarkBuilder.__init__):
2214         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2215         (BenchmarkRunner.__init__):
2216         (BenchmarkRunner._find_plan_file):
2217         (BenchmarkRunner._run_one_test.and):
2218         (BenchmarkRunner.execute):
2219         (BenchmarkRunner._get_result): Deleted.
2220         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2221         (parse_args):
2222         (start):
2223         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2224         (WebDriverBenchmarkRunner):
2225         (WebDriverBenchmarkRunner._get_result):
2226         (WebDriverBenchmarkRunner._run_one_test):
2227         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2228         (WebServerBenchmarkRunner):
2229         (WebServerBenchmarkRunner.__init__):
2230         (WebServerBenchmarkRunner._get_result):
2231         (WebServerBenchmarkRunner._run_one_test):
2232
2233 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2234
2235         Add BenchmarkRunner patches with WebDriver support for each testing plan
2236         https://bugs.webkit.org/show_bug.cgi?id=174443
2237
2238         Reviewed by Dewei Zhu, Stephanie Lewis.
2239
2240         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2241         (BenchmarkBuilder.__enter__):
2242         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2243         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2244         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2245         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2246         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2247         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2248         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2249         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2250         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2251         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2252         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2253         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2254         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2255         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2256         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2257         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2258         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2259         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2260         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2261         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2262         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2263         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2264         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2265         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2266         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2267         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2268         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2269         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2270         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2271         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2272         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2273         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2274         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2275
2276 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2277
2278         Add functions to autoinstaller needed for Benchmark Runner script
2279         https://bugs.webkit.org/show_bug.cgi?id=174331
2280
2281         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2282
2283         Adds autoinstaller functions to install selenium and webdriver binaries
2284         which will be used by the browser driver part of Benchmark Runner.
2285
2286         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2287         (BrowserDriver.restore_env):
2288         (BrowserDriver):
2289         (BrowserDriver.get_webdriver_binary_path):
2290         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2291         (LinuxChromeDriver.launch_driver):
2292         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2293         (LinuxFirefoxDriver.launch_driver):
2294         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2295         (OSXChromeDriver.launch_driver):
2296         (OSXChromeCanaryDriver.launch_driver):
2297         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2298         (OSXFirefoxDriver.launch_driver):
2299         (OSXFirefoxNightlyDriver.launch_driver):
2300         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2301         * Scripts/webkitpy/benchmark_runner/utils.py:
2302         (get_driver_binary_path):
2303         * Scripts/webkitpy/common/system/autoinstall.py:
2304         (AutoInstaller._unzip):
2305         * Scripts/webkitpy/thirdparty/__init__.py:
2306         (AutoinstallImportHook.find_module):
2307         (AutoinstallImportHook._install_selenium):
2308         (AutoinstallImportHook):
2309         (AutoinstallImportHook._install_chromedriver):
2310         (AutoinstallImportHook._install_geckodriver):
2311         (AutoinstallImportHook.get_latest_pypi_url):
2312         (AutoinstallImportHook.install_binary):
2313         (autoinstall_everything):
2314         (get_driver_filename):
2315         (get_os_info):
2316
2317 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2318
2319         Add WebDriver support in browser driver part of BenchmarkRunner
2320         https://bugs.webkit.org/show_bug.cgi?id=174445
2321
2322         Reviewed by Stephanie Lewis.
2323
2324         Adds a launch_driver function to each BrowserDriver subclass. This
2325         function sets up the arguments for the webdriver and launches the
2326         webdriver specific to that browser.
2327
2328         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2329         (BrowserDriver.launch_webdriver):
2330         (BrowserDriver):
2331         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2332         (LinuxBrowserDriver.launch_webdriver):
2333         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2334         (LinuxChromeDriver.launch_url):
2335         (LinuxChromeDriver):
2336         (LinuxChromeDriver.launch_driver):
2337         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2338         (EpiphanyBrowserDriver.launch_url):
2339         (EpiphanyBrowserDriver):
2340         (EpiphanyBrowserDriver.launch_driver):
2341         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2342         (LinuxFirefoxDriver):
2343         (LinuxFirefoxDriver.launch_url):
2344         (LinuxFirefoxDriver.launch_driver):
2345         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2346         (GTKMiniBrowserDriver.launch_url):
2347         (GTKMiniBrowserDriver):
2348         (GTKMiniBrowserDriver.launch_driver):
2349         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2350         (OSXBrowserDriver._launch_webdriver):
2351         (OSXBrowserDriver):
2352         (OSXBrowserDriver._screen_size):
2353         (OSXBrowserDriver._insert_url):
2354         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2355         (OSXChromeDriver):
2356         (OSXChromeDriver.launch_url):
2357         (OSXChromeDriver.launch_driver):
2358         (OSXChromeCanaryDriver):
2359         (OSXChromeCanaryDriver.launch_url):
2360         (OSXChromeCanaryDriver.launch_driver):
2361         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2362         (OSXFirefoxDriver):
2363         (OSXFirefoxDriver.launch_url):
2364         (OSXFirefoxDriver.launch_driver):
2365         (OSXFirefoxNightlyDriver):
2366         (OSXFirefoxNightlyDriver.launch_url):
2367         (OSXFirefoxNightlyDriver.launch_driver):
2368         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2369         (OSXSafariDriver.launch_driver):
2370
2371 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2372
2373         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
2374         https://bugs.webkit.org/show_bug.cgi?id=174793
2375
2376         Reviewed by Tim Horton.
2377
2378         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
2379         down. Without r219765, this test will dereference null and crash.
2380
2381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2382         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
2383         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
2384         (TEST):
2385
2386 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2387
2388         [Win] Implement Authentication dialog in MiniBrowser
2389         https://bugs.webkit.org/show_bug.cgi?id=174662
2390
2391         Reviewed by Alex Christensen.
2392
2393         * MiniBrowser/win/Common.cpp:
2394         (CustomUserAgent):
2395         (DisplayAuthDialog):
2396         (AuthDialogProc):
2397         * MiniBrowser/win/MiniBrowserLib.rc:
2398         * MiniBrowser/win/MiniBrowserLibResource.h:
2399         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2400         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2401
2402 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
2403
2404         Handle case where line_numbers is None instead of an array of line numbers
2405         https://bugs.webkit.org/show_bug.cgi?id=174775
2406
2407         Reviewed by Aakash Jain.
2408
2409         Added files set line_numbers to None in process_file.
2410
2411         * Scripts/webkitpy/style/filereader.py:
2412         (TextFileReader.process_file): Handle case where line_number is set to None.
2413         * Scripts/webkitpy/style/main_unittest.py:
2414         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
2415
2416 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2417
2418         [WPE] Add libepoxy to the Jhbuild moduleset
2419         https://bugs.webkit.org/show_bug.cgi?id=174711
2420
2421         Reviewed by Carlos Alberto Lopez Perez.
2422
2423         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
2424
2425 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2426
2427         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
2428         https://bugs.webkit.org/show_bug.cgi?id=174780
2429
2430         Reviewed by Carlos Garcia Campos.
2431
2432         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2433         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
2434         in case the eglplatform.h header doesn't provide that macro. This replicates
2435         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
2436
2437 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2438
2439         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
2440         https://bugs.webkit.org/show_bug.cgi?id=174758
2441
2442         Reviewed by Dan Bernstein.
2443
2444         Migrate position-information-related unit tests from the PositionInformationTests suite to
2445         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
2446
2447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2448         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2449         (TestWebKitAPI::checkElementTypeAndBoundingRect):
2450         (TestWebKitAPI::TEST):
2451         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
2452         * TestWebKitAPI/cocoa/TestWKWebView.h:
2453         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2454         (-[TestWKWebView activatedElementAtPosition:]):
2455
2456 2017-07-22  Chris Dumez  <cdumez@apple.com>
2457
2458         REGRESSION(r204565): WKObject is broken
2459         https://bugs.webkit.org/show_bug.cgi?id=174736
2460         <rdar://problem/33246169>
2461
2462         Reviewed by Dan Bernstein.
2463
2464         Add API test that used to crash.
2465
2466         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2467         (TestWebKitAPI::TEST):
2468
2469 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2470
2471         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
2472         https://bugs.webkit.org/show_bug.cgi?id=174705
2473
2474         Reviewed by Mark Lam.
2475
2476         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2477         (TestWebKitAPI::testThreadGroup):
2478         (TestWebKitAPI::TEST):
2479
2480 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
2481
2482         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
2483         https://bugs.webkit.org/show_bug.cgi?id=174724
2484
2485         Reviewed by Aakash Jain.
2486
2487         * Scripts/webkitpy/port/ios_simulator.py:
2488         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
2489         simulator. Errors here should be treated the same as no simulators found.
2490
2491 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
2492
2493         [CMake] Add an option to stop build after generating project files
2494         https://bugs.webkit.org/show_bug.cgi?id=174664
2495
2496         Reviewed by Konstantin Tokarev.
2497
2498         Add "--generate-project-only" to stop build after generating project files.
2499
2500         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
2501         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
2502         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
2503         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
2504         (isGenerateProjectOnly): ditto
2505
2506 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2507
2508         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2509         https://bugs.webkit.org/show_bug.cgi?id=174501
2510
2511         Reviewed by Darin Adler.
2512
2513         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2514         (TestWebKitAPI::TEST):
2515
2516 2017-07-20  David Quesada  <david_quesada@apple.com>
2517
2518         Add SPI to notify WKNavigationDelegate about client redirects
2519         https://bugs.webkit.org/show_bug.cgi?id=174680
2520         rdar://problem/33184886
2521
2522         Reviewed by Brady Eidson.
2523
2524         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2525         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
2526         (TEST):
2527         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
2528
2529 2017-07-20  Brady Eidson  <beidson@apple.com>
2530
2531         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
2532         https://bugs.webkit.org/show_bug.cgi?id=174685
2533
2534         Reviewed by Andy Estes.
2535
2536         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2537         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
2538
2539 2017-07-20  Brady Eidson  <beidson@apple.com>
2540
2541         Deprecate WebIconDatabase in WebKitLegacy/mac.
2542         https://bugs.webkit.org/show_bug.cgi?id=174607
2543
2544         Reviewed by Alex Christensen.
2545
2546         * DumpRenderTree/mac/TestRunnerMac.mm:
2547
2548 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2549
2550         lint-test-expectations should be run during style checking
2551         https://bugs.webkit.org/show_bug.cgi?id=173559
2552         <rdar://problem/32854941>
2553
2554         Reviewed by Aakash Jain.
2555
2556         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2557         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
2558         prevents identifying errors on specific lines in a file.
2559         * Scripts/webkitpy/style/main_unittest.py:
2560         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
2561         case where a linter error is in the file modified, but the line modified is not related to
2562         the linter error.
2563
2564 2017-07-20  Brady Eidson  <beidson@apple.com>
2565
2566         Remove WebIconDatabase from WebKitLegacy/win.
2567         https://bugs.webkit.org/show_bug.cgi?id=174608
2568
2569         Reviewed by Alex Christensen.
2570
2571         * DumpRenderTree/win/DumpRenderTree.cpp:
2572         (main):
2573         * DumpRenderTree/win/TestRunnerWin.cpp:
2574         (TestRunner::setIconDatabaseEnabled):
2575
2576 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
2577
2578         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
2579         https://bugs.webkit.org/show_bug.cgi?id=174671
2580
2581         Reviewed by Carlos Garcia Campos.
2582
2583         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2584         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
2585         priority for this source in order to have it dispatched on the same
2586         priority as the other WebKit-controlled GSource objects.
2587
2588 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2589
2590         lint-test-expectations should be run during style checking
2591         https://bugs.webkit.org/show_bug.cgi?id=173559
2592         <rdar://problem/32854941>
2593
2594         Reviewed by Daniel Bates.
2595
2596         Follow up fix addressing style and a few minor bugs.
2597
2598         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2599         (TestExpectationParser.__init__): Use lambda x: x instead of str
2600         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
2601         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
2602         reduce the calls of _shorten_filename, fix minor bug in appending the current
2603         expectation's line number instead of the previous ones, clarify treatment of None
2604         in file-to-line-number mapping.
2605         (TestExpectations._report_warnings): Collapse call.
2606         * Scripts/webkitpy/style/checkers/test_expectations.py:
2607         (TestExpectationsChecker.lint_test_expectations):
2608         * Scripts/webkitpy/style/filereader.py: Re-write comment.
2609         (TextFileReader.process_file): Add comment explaining treatment of None in
2610         file-to-line-number mapping.
2611         (TextFileReader.delete_file): Collapse call.
2612
2613 2017-07-19  Chris Dumez  <cdumez@apple.com>
2614
2615         Unreviewed attempt to fix API test failure after r219663.
2616
2617         The test was hard-coding an exception string and the string has changed slightly
2618         in r219663.
2619
2620         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2621         (TEST):
2622
2623 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
2624
2625         Don't write file URLs to iOS Pasteboard
2626         https://bugs.webkit.org/show_bug.cgi?id=174647
2627         <rdar://problem/33199730>
2628
2629         Reviewed by Wenson Hsieh.
2630
2631         Updating tests to reflect the lack of file URLs for images.
2632
2633         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2634         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
2635         (checkEstimatedSize):
2636         (TestWebKitAPI::TEST):
2637
2638 2017-07-19  Brady Eidson  <beidson@apple.com>
2639
2640         iBooks sometimes crashes when closing a book.
2641         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
2642
2643         Reviewed by Oliver Hunt.
2644
2645         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2646         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
2647         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
2648         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
2649         (TestWebKitAPI::TEST):
2650
2651         Add a "spin the runloop X number of times" utility:
2652         * TestWebKitAPI/Utilities.h:
2653         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2654         (TestWebKitAPI::Util::spinRunLoop):
2655
2656 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2657
2658         lint-test-expectations should be run during style checking
2659         https://bugs.webkit.org/show_bug.cgi?id=173559
2660         <rdar://problem/32854941>
2661
2662         Reviewed by David Kilzer.
2663
2664         Running the test expectation linter requires reading both files and lines not in the
2665         patch because, for example, deletion of a test can cause a lint failure even though
2666         no test expectations where modified. This means that the linter will occasionally warn
2667         about lines which were not changed in a given patch but whose error is related to a
2668         change made in that patch.
2669
2670         * Scripts/webkitpy/common/system/filesystem_mock.py:
2671         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
2672         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2673         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
2674         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
2675         content, description of the error and the name of the associated test.
2676         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
2677         (TestExpectationParser.__init__): Pass shorten_filename function to
2678         TestExpectationsParser to add a deleted file to the related_files dictionary.
2679         (TestExpectationParser._check_test_exists): If the test does not exist, add the
2680         missing path to the related_files dictionary.
2681         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
2682         files and line numbers related to this test expectation line. This will allow
2683         tracking linter errors in the style checker occurring across multiple files.
2684         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
2685         lines to related_files dictionary.
2686         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
2687         (TestExpectations._report_warnings): Construct warning object instead of string
2688         when adding to warnings list.
2689         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
2690         clean-up log.
2691         * Scripts/webkitpy/style/checker.py:
2692         (ProcessorBase.do_association_check): Add required function for processor classes.
2693         (StyleProcessor):
2694         (StyleProcessor.do_association_check): Run the TestExpectations linter when
2695         checking for errors between associated files.
2696         * Scripts/webkitpy/style/checkers/test_expectations.py:
2697         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
2698         (TestExpectationsChecker):
2699         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
2700         of modified files, the current working directory and the host, determine if the linter
2701         warning is associated with the changes.
2702         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
2703         style checker.
2704         * Scripts/webkitpy/style/filereader.py:
2705         (TextFileReader):
2706         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
2707         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
2708         (TextFileReader.process_file): Track both the number of files changed and which lines
2709         in those files were changed.
2710         (TextFileReader.do_association_check): Run the processor's association check on all
2711         modified or deleted files processed by TextFileReader.
2712         (TextFileReader.delete_file): Track deleted files in _files dictionary.
2713         (TextFileReader.count_delete_only_file): Deleted.
2714         * Scripts/webkitpy/style/filereader_unittest.py:
2715         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
2716         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
2717         * Scripts/webkitpy/style/main.py:
2718         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
2719         explicitly run the association check on the file reader.
2720         * Scripts/webkitpy/style/main_unittest.py:
2721         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
2722         embedded in the style checker.
2723         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
2724         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
2725         construct the TextFileReader object with a StyleProcessor used to run style checks on
2726         specific files.
2727         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
2728         testing the test expectation linter inside the style checker. This host must contain a
2729         mock file system with the basic structure of test expectations.
2730         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
2731         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
2732         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
2733         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
2734         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
2735         * Scripts/webkitpy/style/patchreader.py:
2736         (PatchReader.check): Specify which file was deleted, run the association check.
2737         * Scripts/webkitpy/style/patchreader_unittest.py:
2738         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
2739         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
2740         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
2741
2742 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2743
2744         [WTF] Implement WTF::ThreadGroup
2745         https://bugs.webkit.org/show_bug.cgi?id=174081
2746
2747         Reviewed by Mark Lam.
2748
2749         Add WTF::ThreadGroup tests.
2750
2751         * TestWebKitAPI/CMakeLists.txt:
2752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2753         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2754         (TestWebKitAPI::testThreadGroup):
2755         (TestWebKitAPI::TEST):
2756
2757 2017-07-18  Andy Estes  <aestes@apple.com>
2758
2759         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2760         https://bugs.webkit.org/show_bug.cgi?id=174631
2761
2762         Reviewed by Tim Horton.
2763
2764         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2765         * MiniBrowser/Configurations/Base.xcconfig:
2766         * MobileMiniBrowser/Configurations/Base.xcconfig:
2767         * TestWebKitAPI/Configurations/Base.xcconfig:
2768         * WebKitTestRunner/Configurations/Base.xcconfig:
2769
2770 2017-07-18  Andy Estes  <aestes@apple.com>
2771
2772         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2773         https://bugs.webkit.org/show_bug.cgi?id=174631
2774
2775         Reviewed by Sam Weinig.
2776
2777         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2778         * MiniBrowser/Configurations/Base.xcconfig:
2779         * MobileMiniBrowser/Configurations/Base.xcconfig:
2780         * TestWebKitAPI/Configurations/Base.xcconfig:
2781         * WebKitTestRunner/Configurations/Base.xcconfig:
2782
2783 2017-07-18  Daniel Bates  <dabates@apple.com>
2784
2785         lldb: Add type summary for StringView
2786         https://bugs.webkit.org/show_bug.cgi?id=174637
2787
2788         Reviewed by Sam Weinig.
2789
2790         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
2791         StringView object will print output that has the form:
2792
2793             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
2794               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
2795               m_length = 2
2796               m_is8Bit = true
2797               m_underlyingString = 0x0000614000000a90
2798             }
2799
2800         * lldb/lldb_webkit.py:
2801         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
2802         (WTFStringView_SummaryProvider):
2803         (WTFStringViewProvider):
2804         (WTFStringViewProvider.__init__):
2805         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
2806         (WTFStringViewProvider.get_length): Access field StringView.m_length.
2807         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
2808         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
2809
2810 2017-07-18  Andy Estes  <aestes@apple.com>
2811
2812         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2813         https://bugs.webkit.org/show_bug.cgi?id=174631
2814
2815         Reviewed by Dan Bernstein.
2816
2817         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2818         * MiniBrowser/Configurations/Base.xcconfig:
2819         * MobileMiniBrowser/Configurations/Base.xcconfig:
2820         * TestWebKitAPI/Configurations/Base.xcconfig:
2821         * WebKitTestRunner/Configurations/Base.xcconfig:
2822
2823 2017-07-18  Devin Rousso  <drousso@apple.com>
2824
2825         Web Inspector: Add memoryCost to Inspector Protocol objects
2826         https://bugs.webkit.org/show_bug.cgi?id=174478
2827
2828         Reviewed by Joseph Pecoraro.
2829
2830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2831         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
2832         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
2833         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
2834         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
2835         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
2836         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
2837         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
2838         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
2839         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
2840         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
2841         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
2842         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
2843         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
2844         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
2845         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
2846         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
2847
2848 2017-07-18  Andy Estes  <aestes@apple.com>
2849
2850         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2851         https://bugs.webkit.org/show_bug.cgi?id=174631
2852
2853         Reviewed by Darin Adler.
2854
2855         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2856         * MiniBrowser/Configurations/Base.xcconfig:
2857         * MobileMiniBrowser/Configurations/Base.xcconfig:
2858         * TestWebKitAPI/Configurations/Base.xcconfig:
2859         * WebKitTestRunner/Configurations/Base.xcconfig:
2860
2861 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2862
2863         Unreviewed, fix the iOS build.
2864
2865         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
2866
2867         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2868         (TestWebKitAPI::TEST):
2869
2870 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2871
2872         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
2873         https://bugs.webkit.org/show_bug.cgi?id=174585
2874         <rdar://problem/33302541>
2875
2876         Reviewed by Tim Horton.
2877
2878         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
2879         being dragged when initiating a drag.
2880
2881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2882         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
2883         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2884         (TestWebKitAPI::TEST):
2885         * TestWebKitAPI/cocoa/TestWKWebView.h:
2886
2887         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
2888
2889         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2890         (-[TestWKWebView synchronouslyLoadHTMLString:]):
2891
2892 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2893
2894         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
2895         https://bugs.webkit.org/show_bug.cgi?id=174547
2896
2897         Reviewed by Alex Christensen.
2898
2899         * DumpRenderTree/PlatformWin.cmake:
2900         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2901
2902 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2903
2904         Update style checker to deal with "final"
2905         https://bugs.webkit.org/show_bug.cgi?id=174528
2906
2907         Reviewed by Alex Christensen.
2908         
2909         check-webkit-style shouldn't complain about an open brace to start a
2910         line after a function definition with "final" or "const final".
2911
2912         * Scripts/webkitpy/style/checkers/cpp.py:
2913         (check_braces):
2914         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2915         (CppStyleTest.test_brace_at_begin_of_line):
2916
2917 2017-07-17  Alex Christensen  <achristensen@webkit.org>
2918
2919         Modernize content extension code
2920         https://bugs.webkit.org/show_bug.cgi?id=174588
2921
2922         Reviewed by Sam Weinig.
2923
2924         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2925         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2926         (TestWebKitAPI::testRequest):
2927         (TestWebKitAPI::makeBackend):
2928         (TestWebKitAPI::TEST_F):
2929
2930 2017-07-17  Brady Eidson  <beidson@apple.com>
2931
2932         WKHTTPCookieStore observing only works on the default cookie store.
2933         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
2934
2935         Reviewed by Sam Weinig.
2936
2937         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2938         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
2939           called for the default store, a non-persistent store, and a custom store.
2940         (TEST):
2941
2942 2017-07-16  Sam Weinig  <sam@webkit.org>
2943
2944         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
2945         https://bugs.webkit.org/show_bug.cgi?id=174575
2946
2947         Reviewed by Brady Eidson.
2948
2949         * Scripts/svn-create-patch:
2950         (findModificationType):
2951         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
2952         default value of "unknown".
2953
2954         (generateFileList):
2955         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
2956         for untracked, which matches our old behavior.
2957
2958 2017-07-17  Charlie Turner  <cturner@igalia.com>
2959
2960         Add some missing build dependencies on Fedora
2961         https://bugs.webkit.org/show_bug.cgi?id=174578
2962
2963         Unreviewed dependency update.
2964
2965         * gtk/install-dependencies:
2966
2967 2017-07-16  Brady Eidson  <beidson@apple.com>
2968
2969         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
2970         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
2971
2972         Reviewed by Tim Horton.
2973
2974         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2975         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
2976         (TEST):
2977
2978 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
2979
2980         [GTK] Sort inspector GResource manifest to ensure reproducible builds
2981         https://bugs.webkit.org/show_bug.cgi?id=174540
2982
2983         Reviewed by Michael Catanzaro.
2984
2985         * gtk/generate-inspector-gresource-manifest.py:
2986         (get_filenames): sort list of input files
2987
2988 2017-07-15  Brady Eidson  <beidson@apple.com>
2989
2990         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
2991         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
2992
2993         Reviewed by Tim Horton.
2994
2995         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2996         (TEST): Make this test more reliable by clearing everything beforehand.
2997
2998 2017-07-15  David Kilzer  <ddkilzer@apple.com>
2999
3000         Make it possible to extend check-webkit-style with Apple-internal checkers
3001         <https://webkit.org/b/174464>
3002         <rdar://problem/25564402>
3003
3004         Reviewed by Darin Adler.
3005
3006         * Scripts/webkitpy/style/checker.py: Import apple_additions.
3007         (_all_categories): Add categories from apple_additions() if it
3008         exists.
3009         (CheckerDispatcher._create_checker): Create python checker
3010         from apple_additions() if it exists.
3011
3012 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3013
3014         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
3015         https://bugs.webkit.org/show_bug.cgi?id=174539
3016         <rdar://problem/33307395>
3017
3018         Reviewed by Darin Adler.
3019
3020         Adds a new unit test suite to cover action sheet popover presentation.
3021
3022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3023         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
3024         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
3025         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
3026
3027         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
3028
3029         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
3030         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3031
3032         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
3033
3034         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3035         (TestWebKitAPI::TEST):
3036
3037 2017-07-15  Sam Weinig  <sam@webkit.org>
3038
3039         [Scripts] Make svn-create-patch work better when called in sub directories
3040         https://bugs.webkit.org/show_bug.cgi?id=174551
3041
3042         Reviewed by Darin Adler.
3043
3044         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
3045           by ensuring that the prefix is applied as is done in generateDiff.
3046         - Silence output of explanatory lines from svn stat (" > move to ...")
3047           that show up in STDERR when running svn-create-patch.
3048         - Add verbose logging that I found useful while debugging this issue.
3049
3050         * Scripts/svn-create-patch:
3051         (findBaseUrl):
3052         (findMimeType):
3053         (findSourceFileAndRevision):
3054         (generateDiff):
3055         (generateFileList):
3056         (manufacturePatchForAdditionWithHistory):
3057
3058 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
3059
3060         Unreviewed build fix after r219537.
3061
3062         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3063
3064 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3065
3066         Add iOS 11 SPI
3067         https://bugs.webkit.org/show_bug.cgi?id=174430
3068         <rdar://problem/33269288>
3069
3070         Reviewed by Tim Horton.
3071
3072         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
3073         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
3074         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
3075
3076 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3077
3078         Failing to install on iPad simulators
3079         https://bugs.webkit.org/show_bug.cgi?id=174532
3080         <rdar://problem/33328347>
3081
3082         Reviewed by Stephanie Lewis.
3083
3084         * Scripts/webkitpy/xcode/simulated_device.py:
3085         (SimulatedDevice.install_app): Place install command in retry try-except block.
3086
3087 2017-07-14  Jeff Miller  <jeffm@apple.com>
3088
3089         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3090         https://bugs.webkit.org/show_bug.cgi?id=174524
3091
3092         Reviewed by Sam Weinig.
3093
3094         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
3095         (TEST):
3096         Renamed TestParameter to TestParameter1.
3097         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3098
3099         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3100         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3101         Observe changes for two bundle parameters.
3102
3103         (-[BundleParametersPlugIn dealloc]):
3104         Remove observers for two bundle parameters.
3105
3106 2017-07-14  Commit Queue  <commit-queue@webkit.org>
3107
3108         Unreviewed, rolling out r219510.
3109         https://bugs.webkit.org/show_bug.cgi?id=174525
3110
3111         Need to revert length() == 0 check for null string (Requested
3112         by yusukesuzuki on #webkit).
3113
3114         Reverted changeset:
3115
3116         "[WTF] Newly added AtomicStringImpl should use BufferInternal
3117         static string if StringImpl is static"
3118         https://bugs.webkit.org/show_bug.cgi?id=174501
3119         http://trac.webkit.org/changeset/219510
3120
3121 2017-07-14  Jer Noble  <jer.noble@apple.com>
3122
3123         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
3124         https://bugs.webkit.org/show_bug.cgi?id=174514
3125
3126         Reviewed by Sam Weinig.
3127
3128         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
3129         (TestWebKitAPI::TEST_F):
3130
3131 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3132
3133         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3134         https://bugs.webkit.org/show_bug.cgi?id=174501
3135
3136         Reviewed by Darin Adler.
3137
3138         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3139         (TestWebKitAPI::TEST):
3140
3141 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3142
3143         Bring mac expectations in-line with other platforms
3144         https://bugs.webkit.org/show_bug.cgi?id=174472
3145         <rdar://problem/33297388>
3146
3147         Reviewed by David Kilzer.
3148
3149         The override order for Mac test expectations does not conform to the pattern used by iOS,
3150         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
3151
3152             platform/mac-wk2
3153             platform/wk2
3154             platform/mac-elcapitan
3155             platform/mac-sierra
3156             generic
3157
3158         After this change, El Capitan's baseline search path looks like this:
3159
3160             platform/mac-sierra-wk2
3161             platform/mac-sierra
3162             platform/mac-wk2
3163             platform/wk2
3164             generic
3165
3166         * Scripts/webkitpy/port/mac.py:
3167         (MacPort.__init__): If a specific version is specified in the port name, use that
3168         as the os version.
3169         (MacPort.default_baseline_search_path): Expectation search paths should work the
3170         same way they do on other ports. Port + version overrides port, port overrides generic
3171         and wk1/wk2 should override expectations for the two combined.
3172         * Scripts/webkitpy/port/mac_unittest.py:
3173         (MacTest.test_tests_for_other_platforms): Deleted.
3174         (MacTest._assert_search_path): Deleted.
3175         (MacTest.test_baseline_search_path): Deleted.
3176         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3177         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
3178         (test_rebaseline_test_and_print_scm_changes): Ditto.
3179         (test_rebaseline_and_copy_test): Ditto.
3180         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
3181         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
3182         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
3183
3184 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3185
3186         Fix style checker unit test
3187
3188         Unreviewed WebKit2 => WebKit fixup.
3189
3190         * Scripts/webkitpy/style/checker_unittest.py:
3191         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3192
3193 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3194
3195         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
3196
3197         Unreviewed build fix.
3198
3199         r219492 missed one hunk from its partial revert of r219489.
3200         This patch reverts that hunk.
3201
3202         * TestWebKitAPI/CMakeLists.txt:
3203
3204 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3205
3206         Use the old WebKit/WebKit2 targets for CMake builds.
3207
3208         Unreviewed build fix.
3209
3210         We can update the target names to match the Framework names in a future patch.
3211         This is a partial revert of r219489.
3212
3213         * TestWebKitAPI/CMakeLists.txt:
3214         WebKitLegacy => WebKit
3215         WebKit => WebKit2
3216
3217 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3218
3219         Fix TestWebKit API.
3220         https://bugs.webkit.org/show_bug.cgi?id=174164
3221         rdar://problem/33137595
3222
3223         Reviewed by Dan Bernstein.
3224
3225         * TestWebKitAPI/CMakeLists.txt:
3226         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3227         * TestWebKitAPI/PlatformGTK.cmake:
3228
3229 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3230
3231         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
3232         https://bugs.webkit.org/show_bug.cgi?id=174164
3233         rdar://problem/33137595
3234
3235         Reviewed by Dan Bernstein.
3236
3237         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3238         (ShouldBuildTest):
3239         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3240         * Scripts/build-webkit:
3241         * Scripts/do-file-rename:
3242         * Scripts/do-webcore-rename:
3243         * Scripts/update-webkit-localizable-strings:
3244         * Scripts/webkitpy/common/config/watchlist:
3245         * Scripts/webkitpy/style/checker.py:
3246         * Scripts/webkitpy/style/checkers/featuredefines.py:
3247         * gtk/make-dist.py:
3248         (ensure_version_if_possible):
3249         * gtk/manifest.txt.in:
3250
3251 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
3252
3253         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
3254         https://bugs.webkit.org/show_bug.cgi?id=174162
3255         rdar://problem/33137594
3256
3257         Reviewed by Dan Bernstein.
3258
3259         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
3260
3261         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3262         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3263         * EWSTools/configure-clang-linux.sh:
3264         * Scripts/build-webkit:
3265         * Scripts/do-file-rename:
3266         * Scripts/do-webcore-rename:
3267         * Scripts/update-webkit-localizable-strings:
3268         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3269         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3270         * Scripts/webkitpy/style/checkers/featuredefines.py:
3271         * gtk/manifest.txt.in:
3272
3273 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
3274
3275         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
3276         https://bugs.webkit.org/show_bug.cgi?id=174438
3277         <rdar://problem/33277112>
3278
3279         Reviewed by Aakash Jain.
3280
3281         Given a patch, this will convert the changes from the path to the new directory structure.
3282
3283         * Scripts/rebase-patch-after-webkit-move: Added.
3284         (append_source): Append 'Source' to the provided path.
3285         (is_editable_line): Return true if a line the script expects to modify.
3286         (needs_rebase): Return if a line needs to be rebased based on it's content.
3287         (rebase_line): Rebase the provided line.
3288         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
3289         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
3290         were provided.
3291
3292 2017-07-12  Nan Wang  <n_wang@apple.com>
3293
3294         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3295         https://bugs.webkit.org/show_bug.cgi?id=174393
3296         <rdar://problem/33248006>
3297
3298         Reviewed by Chris Fleizach.
3299
3300         * DumpRenderTree/AccessibilityUIElement.cpp:
3301         (textMarkerRangeMatchesTextNearMarkersCallback):
3302         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3303         (AccessibilityUIElement::getJSClass):
3304         * DumpRenderTree/AccessibilityUIElement.h:
3305         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3306         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3307         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3308         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3309         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3310         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3311         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3312         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3313
3314 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3315
3316         Unreviewed, rolling out r219409.
3317
3318         The revision caused the Windows builds to fail.
3319
3320         Reverted changeset:
3321
3322         "AX: [iOS] Implement a way to retrieve a text marker range
3323         with desired text that is closest to a position"
3324         https://bugs.webkit.org/show_bug.cgi?id=174393
3325         http://trac.webkit.org/changeset/219409
3326
3327 2017-07-12  Nan Wang  <n_wang@apple.com>
3328
3329         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3330         https://bugs.webkit.org/show_bug.cgi?id=174393
3331         <rdar://problem/33248006>
3332
3333         Reviewed by Chris Fleizach.
3334
3335         * DumpRenderTree/AccessibilityUIElement.cpp:
3336         (textMarkerRangeMatchesTextNearMarkersCallback):
3337         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3338         (AccessibilityUIElement::getJSClass):
3339         * DumpRenderTree/AccessibilityUIElement.h:
3340         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3341         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3342         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3343         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3344         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3345         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3346         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3347         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3348
3349 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
3350
3351         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
3352         https://bugs.webkit.org/show_bug.cgi?id=174197
3353
3354         Reviewed by Darin Adler.
3355
3356         This bit me the first time I tried to submit a patch to WebKit, and still I have
3357         to manually edit the ChangeLog every time I use the script.
3358
3359         This generates a more convenient and standard ChangeLog entry.
3360
3361         * Scripts/prepare-ChangeLog:
3362         (generateNewChangeLogs):
3363
3364 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3365
3366         Unreviewed, rolling out r219401.
3367
3368         This revision rolled out the previous patch, but after talking
3369         with reviewer, a rebaseline is what was needed.Rolling back in
3370         before rebaseline.
3371
3372         Reverted changeset:
3373
3374         "Unreviewed, rolling out r219379."
3375         https://bugs.webkit.org/show_bug.cgi?id=174400
3376         http://trac.webkit.org/changeset/219401
3377
3378 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3379
3380         Unreviewed, rolling out r219379.
3381
3382         This revision caused a consistent failure in the test
3383         fast/dom/Window/property-access-on-cached-window-after-frame-
3384         removed.html.
3385
3386         Reverted changeset:
3387
3388         "Remove NAVIGATOR_HWCONCURRENCY"
3389         https://bugs.webkit.org/show_bug.cgi?id=174400
3390         http://trac.webkit.org/changeset/219379
3391
3392 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3393
3394         [WPE] Use libepoxy
3395         https://bugs.webkit.org/show_bug.cgi?id=172104
3396
3397         Reviewed by Michael Catanzaro.
3398
3399         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
3400         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
3401
3402 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3403
3404         [GTK][WPE] Align Jhbuild patches for GStreamer packages
3405         https://bugs.webkit.org/show_bug.cgi?id=174363
3406
3407         Reviewed by Michael Catanzaro.
3408
3409         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
3410         between the GTK+ and WPE port. There's no reason for the two ports to apply
3411         different patches over same versions of GStreamer releases.
3412
3413         This aligns the two ports on this specific issue. Next we'll look into
3414         creating a single GStreamer-specific Jhbuild moduleset that will allow us
3415         to keep these patches in a single place, avoiding duplicate files.
3416
3417         * gtk/jhbuild.modules:
3418         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3419         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
3420         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3421         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
3422
3423 2017-07-11  Dean Jackson  <dino@apple.com>
3424
3425         Remove NAVIGATOR_HWCONCURRENCY
3426         https://bugs.webkit.org/show_bug.cgi?id=174400
3427
3428         Reviewed by Sam Weinig.
3429
3430         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3431
3432 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
3433
3434         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
3435         https://bugs.webkit.org/show_bug.cgi?id=174239
3436
3437         Reviewed by Brady Eidson.
3438
3439         Create windows with specific features set and make sure those are properly reflected in the
3440         WKWindowFeatures object.
3441
3442         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3443         (resetToConsistentState):
3444         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3445         (TEST):
3446
3447 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
3448
3449         Do not duplicate files when deleting directories with svn 1.9
3450         https://bugs.webkit.org/show_bug.cgi?id=174339
3451         <rdar://problem/33226781>
3452
3453         Reviewed by David Kilzer.
3454
3455         * Scripts/svn-create-patch:
3456         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
3457         (generateFileList): Determine which files are deleted because they are part of a
3458         directory being deleted.
3459
3460 2017-07-11  Dean Jackson  <dino@apple.com>
3461
3462         Rolling out r219372.
3463
3464         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3465
3466 2017-07-11  Dean Jackson  <dino@apple.com>
3467
3468         Remove NAVIGATOR_HWCONCURRENCY
3469         https://bugs.webkit.org/show_bug.cgi?id=174400
3470
3471         Reviewed by Sam Weinig.
3472
3473         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3474
3475 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3476
3477         Teach build workers to fetch archives from S3.
3478         https://bugs.webkit.org/show_bug.cgi?id=174384
3479
3480         Reviewed by Aakash Jain.
3481
3482         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3483         (DownloadBuiltProduct):
3484
3485 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3486
3487         Configure buildbot to transfer all archives to S3.
3488         Previously this was Mac only, but it's time to expand!
3489         https://bugs.webkit.org/show_bug.cgi?id=174378
3490         
3491         Reviewed by Aakash Jain.
3492
3493         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3494         (BuildFactory.__init__):
3495
3496 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
3497
3498         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
3499         https://bugs.webkit.org/show_bug.cgi?id=174350
3500
3501         Reviewed by Xabier Rodriguez-Calvar.
3502
3503         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
3504         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
3505         patches are removed. The patches for gst-plugins-good are updated, removing
3506         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
3507         rtpbin elements that will help with the EMEv3 development.
3508
3509         * wpe/jhbuild.modules:
3510         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
3511         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
3512         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
3513         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3514         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
3515         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3516         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
3517         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
3518         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
3519
3520 2017-07-10  John Wilander  <wilander@apple.com>
3521
3522         Resource Load Statistics: Prune statistics in orders of importance
3523         https://bugs.webkit.org/show_bug.cgi?id=174215
3524         <rdar://problem/33164403>
3525
3526         Reviewed by Chris Dumez.
3527
3528         Nest infrastructure. Adds these functions:
3529         1. testRunner.setStatisticsLastSeen()
3530         2. setStatisticsMaxStatisticsEntries()
3531         3. setStatisticsPruneEntriesDownTo()
3532
3533         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3534         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3535         (WTR::TestRunner::setStatisticsLastSeen):
3536         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
3537         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3538         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3539         * WebKitTestRunner/TestController.cpp:
3540         (WTR::TestController::setStatisticsLastSeen):
3541         (WTR::TestController::setMaxStatisticsEntries):
3542         (WTR::TestController::setPruneEntriesDownTo):
3543         * WebKitTestRunner/TestController.h:
3544         * WebKitTestRunner/TestInvocation.cpp:
3545         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3546         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3547         (WTR::TestController::setStatisticsLastSeen):
3548         (WTR::TestController::setStatisticsMaxStatisticsEntries):
3549         (WTR::TestController::setStatisticsPruneEntriesDownTo):
3550
3551 2017-07-03  Brian Burg  <bburg@apple.com>
3552
3553         Web Replay: remove some unused code
3554         https://bugs.webkit.org/show_bug.cgi?id=173903
3555
3556         Rubber-stamped by Joseph Pecoraro.
3557
3558         * Scripts/run-input-generator-tests: Removed.
3559         * Scripts/webkitpy/replay/__init__.py: Removed.
3560         * Scripts/webkitpy/replay/main.py: Removed.
3561
3562 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
3563
3564         [WPE] Fix layout test baseline and TestExpectations hierarchy
3565         https://bugs.webkit.org/show_bug.cgi?id=174092
3566
3567         Reviewed by Michael Catanzaro.
3568
3569         Like for the GTK+ port, override the default_baseline_search_path() and
3570         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
3571         Both methods operate on a short list of search paths that defaults to 'wpe' and
3572         'wk2', along with any other user-specified platform directory.
3573
3574         The test_expectations_file_position() method is overridden for testing purposes,
3575         and relevant unit tests are added.
3576
3577         * Scripts/webkitpy/port/wpe.py:
3578         (WPEPort._search_paths):
3579         (WPEPort):
3580         (WPEPort.default_baseline_search_path):
3581         (WPEPort._port_specific_expectations_files):
3582         (WPEPort.test_expectations_file_position):
3583         * Scripts/webkitpy/port/wpe_unittest.py:
3584         (WPEPortTest.test_default_baseline_search_path):
3585         (WPEPortTest):
3586         (WPEPortTest.test_port_specific_expectations_files):
3587
3588 2017-07-10  Chris Dumez  <cdumez@apple.com>
3589
3590         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
3591         https://bugs.webkit.org/show_bug.cgi?id=174301
3592
3593         Reviewed by Brent Fulgham.
3594
3595         Rename some of the testRunner API for clarity and to better match what it calls
3596         internally.
3597
3598         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3599         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3600         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
3601         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
3602         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3603         * WebKitTestRunner/TestController.cpp:
3604         (WTR::TestController::statisticsUpdateCookiePartitioning):
3605         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
3606         * WebKitTestRunner/TestController.h:
3607         * WebKitTestRunner/TestInvocation.cpp:
3608         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3609         * WebKitTestRunner/cocoa/TestControllerCocoa.mm: