620ddfbe609a0bbc32795f343861a0dcfa657627
[WebKit-https.git] / Tools / ChangeLog
1 2015-11-02  Andy Estes  <aestes@apple.com>
2
3         [Cocoa] Add tvOS and watchOS to SUPPORTED_PLATFORMS
4         https://bugs.webkit.org/show_bug.cgi?id=150819
5
6         Reviewed by Dan Bernstein.
7
8         This tells Xcode to include these platforms in its Devices dropdown, making it possible to build in the IDE.
9
10         * DumpRenderTree/mac/Configurations/Base.xcconfig:
11         * MiniBrowser/Configurations/Base.xcconfig:
12         * TestWebKitAPI/Configurations/Base.xcconfig:
13         * WebKitTestRunner/Configurations/Base.xcconfig:
14
15 2015-11-02  Anders Carlsson  <andersca@apple.com>
16
17         Begin work on supporting reply blocks in _WKRemoteObjectRegistry
18         https://bugs.webkit.org/show_bug.cgi?id=150739
19
20         Reviewed by Tim Horton.
21
22         Add a test. We only test the encoding right now.
23
24         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
25         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
26         (TEST):
27         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
28         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
29
30 2015-11-02  Tim Horton  <timothy_horton@apple.com>
31
32         Get rid of WKWebView's inner WKView (WKView being inside WKWebView leads to weird API issues)
33         https://bugs.webkit.org/show_bug.cgi?id=150174
34
35         Reviewed by Anders Carlsson.
36
37         * WebKitTestRunner/mac/EventSenderProxy.mm:
38         (WTR::EventSenderProxy::mouseUp):
39         (WTR::EventSenderProxy::mouseMoveTo):
40         Revert some parts of r188828 which no longer apply.
41
42 2015-10-30  Dana Burkart  <dburkart@apple.com>
43
44         svn-apply should handle unified diffs
45         https://bugs.webkit.org/show_bug.cgi?id=150650
46
47         Reviewed by Darin Adler.
48
49         * Scripts/VCSUtils.pm:
50         (parseUnifiedDiffHeader):
51         This method parses a unified diff header, and returns a information in the
52         style of parseGitDiffHeader and parseSvnDiffHeader.
53
54         (parseDiffHeader):
55         Teach parseDiffHeader to recognize unified diff headers.
56
57         (parseDiff):
58         Teach parseDiff to recognize unified diffs.
59
60         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
61         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl: Added.
62
63 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
64
65         Fix the FTL JIT build with system LLVM on Linux
66         https://bugs.webkit.org/show_bug.cgi?id=150795
67
68         Reviewed by Filip Pizlo.
69
70         * efl/install-dependencies:
71         * gtk/install-dependencies:
72
73 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
74
75         [EFL] Bump harfbuzz versions to 0.9.35
76         https://bugs.webkit.org/show_bug.cgi?id=150448
77
78         Reviewed by Gyuyoung Kim.
79
80         * efl/jhbuild.modules:
81
82 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
83
84         [EFL] gnutls-3.3.0 jhbuild module build fails on Ubuntu 15.10
85         https://bugs.webkit.org/show_bug.cgi?id=150622
86
87         Reviewed by Gyuyoung Kim.
88
89         * efl/install-dependencies:
90         * efl/jhbuild.modules:
91
92 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
93
94         Fix EFL jhbuild module build on Ubuntu 15.10
95         https://bugs.webkit.org/show_bug.cgi?id=150621
96
97         Reviewed by Gyuyoung Kim.
98
99         * efl/jhbuild.modules:
100         * efl/patches/efl-remove-XPrint.patch: Added.
101
102 2015-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
103
104         [GLIB] Remove delete on destroy GMainLoopSources
105         https://bugs.webkit.org/show_bug.cgi?id=150771
106
107         Reviewed by Žan Doberšek.
108
109         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:
110         (TestWebKitAPI::TEST): Remove DeleteOnDestroy unit tests.
111         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
112         (WebViewTest::wait): Use g_timeout_add instead of GMainLoopSource.
113
114 2015-11-01  Yusuke Suzuki  <utatane.tea@gmail.com>
115
116         [ES6] Support Generator Syntax
117         https://bugs.webkit.org/show_bug.cgi?id=150769
118
119         Reviewed by Geoffrey Garen.
120
121         Added ENABLE_ES6_GENERATORS flag.
122
123         * Scripts/webkitperl/FeatureList.pm:
124
125 2015-11-01  Alexey Proskuryakov  <ap@apple.com>
126
127         Sort EWS bots in popovers
128         https://bugs.webkit.org/show_bug.cgi?id=150782
129
130         Reviewed by Darin Adler.
131
132         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
133         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
134
135 2015-10-31  Filip Pizlo  <fpizlo@apple.com>
136
137         B3::reduceStrength's DCE should be more agro and less wrong
138         https://bugs.webkit.org/show_bug.cgi?id=150748
139
140         Reviewed by Geoffrey Garen.
141
142         Add an LLVM version of testb3's "testComplex".
143
144         * ReducedFTL/ComplexTest.cpp: Added.
145
146 2015-11-01  Commit Queue  <commit-queue@webkit.org>
147
148         Unreviewed, rolling out r191831.
149         https://bugs.webkit.org/show_bug.cgi?id=150774
150
151         The new test fails (Requested by ap on #webkit).
152
153         Reverted changeset:
154
155         "Begin work on supporting reply blocks in
156         _WKRemoteObjectRegistry"
157         https://bugs.webkit.org/show_bug.cgi?id=150739
158         http://trac.webkit.org/changeset/191831
159
160 2015-10-31  Andreas Kling  <akling@apple.com>
161
162         Add a debug overlay with information about web process resource usage.
163         <https://webkit.org/b/150599>
164
165         Reviewed by Darin Adler.
166
167         Add a menu item to the MiniBrowser so we can toggle the resource usage overlay on/off.
168
169         * MiniBrowser/mac/SettingsController.h:
170         * MiniBrowser/mac/SettingsController.m:
171         (-[SettingsController _populateMenu]):
172         (-[SettingsController validateMenuItem:]):
173         (-[SettingsController toggleShowResourceUsageOverlay:]):
174         (-[SettingsController resourceUsageOverlayVisible]):
175         * MiniBrowser/mac/WK2BrowserWindowController.m:
176         (-[WK2BrowserWindowController didChangeSettings]):
177
178 2015-10-31  Lucas Forschler  <lforschler@apple.com>
179
180         Teach the CompileWebKit step to look for additional arguments.
181         
182         Unreviewed config change.
183
184         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
185         (CompileWebKit.start):
186
187 2015-10-30  Anders Carlsson  <andersca@apple.com>
188
189         Begin work on supporting reply blocks in _WKRemoteObjectRegistry
190         https://bugs.webkit.org/show_bug.cgi?id=150739
191
192         Reviewed by Tim Horton.
193
194         Add a test. We only test the encoding right now.
195
196         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
197         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
198         (TEST):
199         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
200         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
201
202 2015-10-30  Lucas Forschler  <lforschler@apple.com>
203
204         Add CMAke builder to build.webkit.org
205         https://bugs.webkit.org/show_bug.cgi?id=150738
206         
207         Reviewed by Alex Christensen.
208
209         * BuildSlaveSupport/build.webkit.org-config/config.json:
210
211 2015-10-30  Brent Fulgham  <bfulgham@apple.com>
212
213         [Win] build-jsc and run-javascriptcore-tests do not work
214         https://bugs.webkit.org/show_bug.cgi?id=150700
215
216         Reviewed by Mark Lam.
217         
218         Correct our build system so that it expects Windows to be using CMake,
219         and to build the correct sub-projects for our JSC helper scripts.
220
221         * Scripts/build-jsc: Make sure to build the testapi harness when
222           building for Windows.
223         * Scripts/build-webkit:
224           (1) Use the existing 'cmakeBasedPortName()'
225           (2) Use File::Spec rather than hard-coding path delimeters.
226           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
227         method rather than hard-coding the name based on conditional.
228         * Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
229           LLVM libraries on Apple Windows build.
230         * Scripts/run-javascriptcore-tests:
231         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
232         * Scripts/run-jsc: Ditto.
233         * Scripts/webkitdirs.pm:
234         (cmakeBasedPortName): Update to return the right value for the Apple
235         Windows port and the WinCairo port.
236         (isCMakeBuild): Expect CMake build for all Windows ports.
237
238 2015-10-30  Carlos Garcia Campos  <cgarcia@igalia.com>
239
240         [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
241         https://bugs.webkit.org/show_bug.cgi?id=150665
242
243         Reviewed by Csaba Osztrogonác.
244
245         We check it only to wipe the directory or not, but we are still
246         tryihng to update every module even when the configuration hasn't
247         changed. This is problematic because it makes the whole build fail
248         when any repository fails to checkout an already checked out
249         revision, because the server is down for example. This is even
250         more problematic for the bots that skip perfectly valid revisions.
251         It's still possible to force an update passing --force command
252         line argument.
253
254         * Scripts/update-webkit-libs-jhbuild:
255         (deleteJhbuildMd5): Delete the md5sum files if exist.
256         (runJhbuild): Return early if the md5sum files haven't
257         changed. Only write them after a successful build and delete them
258         if the build fails to ensure we don't skip next run.
259
260 2015-10-30  Philippe Normand  <pnormand@igalia.com>
261
262         [GTK] Fix MacCLang build errors in Tools
263         https://bugs.webkit.org/show_bug.cgi?id=150031
264
265         Reviewed by Carlos Garcia Campos.
266
267         * TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
268         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
269         * WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
270         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
271
272 2015-10-29  Hunseop Jeong  <hs85.jeong@samsung.com>
273
274         [EFL] MiniBrowser didn't work after r191749.
275         https://bugs.webkit.org/show_bug.cgi?id=150706
276
277         Reviewed by Alex Christensen.
278
279         Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
280
281         * Scripts/run-minibrowser:
282
283 2015-10-29  Commit Queue  <commit-queue@webkit.org>
284
285         Unreviewed, rolling out r191766.
286         https://bugs.webkit.org/show_bug.cgi?id=150707
287
288         Problem with Cygwin build (Requested by bfulgham_ on #webkit).
289
290         Reverted changeset:
291
292         "[Win] build-jsc and run-javascriptcore-tests do not work"
293         https://bugs.webkit.org/show_bug.cgi?id=150700
294         http://trac.webkit.org/changeset/191766
295
296 2015-10-29  Brent Fulgham  <bfulgham@apple.com>
297
298         [Win] build-jsc and run-javascriptcore-tests do not work
299         https://bugs.webkit.org/show_bug.cgi?id=150700
300
301         Reviewed by Mark Lam.
302         
303         Correct our build system so that it expects Windows to be using CMake,
304         and to build the correct sub-projects for our JSC helper scripts.
305
306         * Scripts/build-jsc: Make sure to build the testapi harness when
307           building for Windows.
308         * Scripts/build-webkit:
309           (1) Use the existing 'cmakeBasedPortName()'
310           (2) Use File::Spec rather than hard-coding path delimeters.
311           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
312         method rather than hard-coding the name based on conditional.
313         * Scripts/run-javascriptcore-tests:
314         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
315         * Scripts/run-jsc: Ditto.
316         * Scripts/webkitdirs.pm:
317         (cmakeBasedPortName): Update to return the right value for the Apple
318         Windows port and the WinCairo port.
319         (isCMakeBuild): Expect CMake build for all Windows ports.
320
321 2015-10-29  Alex Christensen  <achristensen@webkit.org>
322
323         Fix build-jsc on Mac after r191749.
324
325         * Scripts/build-jsc:
326         Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
327
328 2015-10-29  Alex Christensen  <achristensen@webkit.org>
329
330         Fix Mac CMake build
331         https://bugs.webkit.org/show_bug.cgi?id=150686
332
333         Reviewed by Filip Pizlo.
334
335         * Scripts/build-webkit:
336         * Scripts/webkitdirs.pm:
337         (isCachedArgumentfileOutOfDate):
338         (wrapperPrefixIfNeeded):
339         (generateBuildSystemFromCMakeProject):
340         (buildCMakeGeneratedProject):
341         (cmakeBasedPortName):
342         (determineIsCMakeBuild):
343         (isCMakeBuild):
344         (promptUser):
345         (jhbuildWrapperPrefixIfNeeded): Deleted.
346
347 2015-10-29  Lucas Forschler  <lforschler@apple.com>
348
349         Teach JSC bots to build 32bit instead of x86_64
350         
351         Reviewed by Mark Lam.
352
353         * BuildSlaveSupport/build.webkit.org-config/config.json:
354
355 2015-10-29  Per Arne Vollan  <peavo@outlook.com>
356
357         [WinCairo] Fall back to AppleWin results in layout tests.
358         https://bugs.webkit.org/show_bug.cgi?id=150672
359
360         Reviewed by Alex Christensen.
361
362         * Scripts/webkitpy/port/win.py:
363         (WinCairoPort):
364         (WinCairoPort.default_baseline_search_path):
365
366 2015-10-28  Keith Rollin  <krollin@apple.com>
367
368         Do not sanitize user input for input[type=url]
369         https://bugs.webkit.org/show_bug.cgi?id=150346
370         <rdar://problem/23243240>
371
372         Reviewed by Brent Fulgham.
373
374         The Windows version of DumpRenderTree's eventSender.keyDown handler
375         simulates user-entry by decomposing the given character into a virtual
376         key code and a set of modifier keys. The code that determines if the
377         shift key should be simulated only worked if the character was an
378         upper case character. Extend this support to also include symbols that
379         (on the U.S. keyboard) require holding down the shift key.
380
381         This change allows fast/forms/input-user-input-sanitization.html
382         to succeed, which requires us to simulate the entering of '@' and ':'.
383
384         * DumpRenderTree/win/EventSender.cpp:
385         (keyDownCallback):
386
387 2015-10-28  Alex Christensen  <achristensen@webkit.org>
388
389         Compile and link with CMake on Mac
390         https://bugs.webkit.org/show_bug.cgi?id=150632
391
392         Reviewed by Tim Horton.
393
394         * TestWebKitAPI/PlatformMac.cmake:
395
396 2015-10-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
397
398         Unreviewed.
399
400         * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
401
402 2015-10-28  Per Arne Vollan  <peavo@outlook.com>
403
404         Add WinCairo to list of ports in run-webkit-tests.
405         https://bugs.webkit.org/show_bug.cgi?id=150625
406
407         Reviewed by Brent Fulgham.
408
409         * Scripts/webkitpy/common/config/ports.py:
410         (DeprecatedPort.port):
411         (WinPort.run_webkit_tests_command):
412         (WinCairoPort):
413         (GtkWK2Port):
414         * Scripts/webkitpy/port/factory.py:
415         (PortFactory):
416         * Scripts/webkitpy/port/win.py:
417         (WinPort.find_system_pid):
418         (WinCairoPort):
419
420 2015-10-27  Alexey Proskuryakov  <ap@apple.com>
421
422         WebKitTestRunner leaks in generateWhitelist()
423         https://bugs.webkit.org/show_bug.cgi?id=150563
424
425         Reviewed by Andreas Kling.
426
427         * WebKitTestRunner/mac/TestControllerMac.mm:
428         (WTR::generateWhitelist):
429
430 2015-10-27  Anders Carlsson  <andersca@apple.com>
431
432         Add an API test for _WKRemoteObjectRegistry
433         https://bugs.webkit.org/show_bug.cgi?id=150597
434
435         Reviewed by Andreas Kling.
436
437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
438         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
439         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
440         (TEST):
441         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
442         (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
443         (-[RemoteObjectRegistryPlugIn sayHello:]):
444
445 2015-10-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
446
447         Add myself to the reviewers list
448         https://bugs.webkit.org/show_bug.cgi?id=150581
449
450         Unreviewed.
451
452         * Scripts/webkitpy/common/config/contributors.json:
453
454 2015-10-26  Ryan Haddad  <ryanhaddad@apple.com>
455
456         Adding myself to contributors.json
457
458         * Scripts/webkitpy/common/config/contributors.json:
459
460 2015-10-26  Tim Horton  <timothy_horton@apple.com>
461
462         Don't expose the whitelist/blacklist in _WKUserStyleSheet
463         https://bugs.webkit.org/show_bug.cgi?id=150566
464
465         Reviewed by Anders Carlsson.
466
467         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
468         (TEST):
469
470 2015-10-26  Philippe Normand  <pnormand@igalia.com>
471
472         Unreviewed, rolling out r191576.
473
474         broke
475
476         Reverted changeset:
477
478         "[GStreamer] Bump internal jhbuild versions to 1.6.0"
479         https://bugs.webkit.org/show_bug.cgi?id=149594
480         http://trac.webkit.org/changeset/191576
481
482 2015-10-26  ChangSeok Oh  <changseok.oh@collabora.com>
483
484         [GStreamer] Bump internal jhbuild versions to 1.6.0
485         https://bugs.webkit.org/show_bug.cgi?id=149594
486
487         Reviewed by Philippe Normand.
488
489         Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
490         useful so they are removed accordingly.
491
492         * gtk/jhbuild.modules:
493         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
494         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
495         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
496
497 2015-10-25  Alexey Proskuryakov  <ap@apple.com>
498
499         API tests fail on El Capitan after r191543
500         https://bugs.webkit.org/show_bug.cgi?id=150547
501
502         Reviewed by Dan Bernstein.
503
504         * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
505
506 2015-10-24  Tim Horton  <timothy_horton@apple.com>
507
508         Add a way to add user style sheets to WKUserContentController
509         https://bugs.webkit.org/show_bug.cgi?id=150531
510         <rdar://problem/23191691>
511
512         Reviewed by Darin Adler.
513
514         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
515         (TEST):
516
517 2015-10-24  Tim Horton  <timothy_horton@apple.com>
518
519         Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
520         https://bugs.webkit.org/show_bug.cgi?id=150525
521
522         Reviewed by Darin Adler.
523
524         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
525         (TEST):
526         Test the various new keys.
527
528 2015-10-24  Frederic Wang  <fred.wang@free.fr>
529
530         check-webkit-style complains about missing operator whitespace inside character literal
531         https://bugs.webkit.org/show_bug.cgi?id=150396
532
533         Reviewed by Darin Adler.
534
535         * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
536         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
537         (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
538
539 2015-10-23  Michael Saboff  <msaboff@apple.com>
540
541         REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
542         https://bugs.webkit.org/show_bug.cgi?id=150513
543
544         Reviewed by Saam Barati.
545
546         Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
547
548         * DumpRenderTree/TestRunner.cpp:
549         (simulateWebNotificationClickCallback):
550         (failNextCodeBlock):
551         (numberOfDFGCompiles):
552         (TestRunner::staticFunctions):
553         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
554         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
555         (WTR::TestRunner::setBlockAllPlugins):
556         (WTR::TestRunner::failNextCodeBlock):
557         (WTR::TestRunner::numberOfDFGCompiles):
558         * WebKitTestRunner/InjectedBundle/TestRunner.h:
559
560 2015-10-23  Anders Carlsson  <andersca@apple.com>
561
562         Simplify the WebKitLegacy menu conversion code
563         https://bugs.webkit.org/show_bug.cgi?id=150509
564
565         Reviewed by Andreas Kling.
566
567         Implement the context menu delegate method so we'll test that code path.
568
569         * MiniBrowser/mac/WK1BrowserWindowController.m:
570         (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
571
572 2015-10-23  Per Arne Vollan  <peavo@outlook.com>
573
574         [WinCairo] Improve test results for fast layouttests.
575         https://bugs.webkit.org/show_bug.cgi?id=150464
576
577         Reviewed by Alex Christensen.
578
579         Set custom device scale factor to 1.0.
580
581         * DumpRenderTree/win/DumpRenderTree.cpp:
582         (createWebViewAndOffscreenWindow):
583
584 2015-10-23  Mark Salisbury  <mark.salisbury@hp.com>
585
586         [GTK] update-webkitgtk-libs should use mesa tarball
587
588         https://bugs.webkit.org/show_bug.cgi?id=150470
589
590         update-webkitgtk-libs downloads all build dependencies; in fixing
591         bug 148941 mesa was switched from ftp to git access.  Now an http
592         tarball is available, which is preferred over accessing via git.
593
594         Reviewed by Philippe Normand
595
596         * gtk/jhbuild.modules:
597         Mesa access changed to http tarball.
598
599 2015-10-22  Sam Weinig  <sam@webkit.org>
600
601         Navigations on the same host (but with different schemes and ports) should not trigger universal links
602         <rdar://problem/22811325>
603         https://bugs.webkit.org/show_bug.cgi?id=150481
604
605         Reviewed by Dan Bernstein.
606
607         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
608         Update test to test that navigations on the same host but with different schemes does not
609         trigger universal links, but that changes in the host do.
610
611 2015-10-22  Ryosuke Niwa  <rniwa@webkit.org>
612
613         REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
614         https://bugs.webkit.org/show_bug.cgi?id=150428
615
616         Reviewed by Antti Koivisto.
617
618         Added a regression test using WebKit API test.
619
620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
621         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
622         (TestWebKitAPI::didFinishLoadForFrame):
623         (TestWebKitAPI::TEST):
624
625 2015-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
626
627         Unreviewed. Fix GTK+ build after r191423.
628
629         Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
630
631         * gtk/webkitdom.py:
632         (WebKitDOMDocGenerator):
633
634 2015-10-22  Aakash Jain  <aakash_jain@apple.com>
635
636         [Win][EFL][GTK] webkitpy test failed after r191374.
637         https://bugs.webkit.org/show_bug.cgi?id=150433
638
639         Reviewed by Alexey Proskuryakov.
640
641         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
642         (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
643         (CrashLogsTest.test_find_log_darwin): Same.
644
645 2015-10-21  Brian Burg  <bburg@apple.com>
646
647         Unreviewed, update watchlist for JS builtins.
648
649         Add a category for JS builtins code generator, similar to other generators.
650
651         Add a nag message to rebaseline builtins generator tests when touching
652         code generator files in Source/JavaScriptCore/Scripts/builtins/.
653
654         * Scripts/webkitpy/common/config/watchlist:
655
656 2015-10-21  Brian Burg  <bburg@apple.com>
657
658         Restructure generate-js-bindings script to be modular and testable
659         https://bugs.webkit.org/show_bug.cgi?id=149929
660
661         Reviewed by Alex Christensen.
662
663         Add a stub shell script and basic webkitpy support for running builtins
664         generator tests.
665
666         * Scripts/run-builtins-generator-tests: Added.
667         (main):
668         * Scripts/webkitpy/codegen/__init__.py: Added.
669         * Scripts/webkitpy/codegen/main.py: Added.
670
671             The only interesting difference here from the inspector protocol
672             generator equivalent is that this implementation decodes the target
673             framework and output mode (combined or separate) from the test's file name.
674
675         (BuiltinsGeneratorTests):
676         (BuiltinsGeneratorTests.__init__):
677         (BuiltinsGeneratorTests.generate_from_js_builtins):
678         (BuiltinsGeneratorTests.write_error_file):
679         (BuiltinsGeneratorTests.detect_changes):
680         (BuiltinsGeneratorTests.run_tests):
681         (BuiltinsGeneratorTests.main):
682
683 2015-10-21  Aakash Jain  <aakash_jain@apple.com>
684
685         run-webkit-tests does not copy all crash logs for layout test failures on Mac
686         https://bugs.webkit.org/show_bug.cgi?id=150407
687         <rdar://problem/22239750>
688
689         Reviewed by Alexey Proskuryakov.
690
691         * Scripts/webkitpy/port/mac.py:
692         (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
693         (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
694         the log directory.
695         (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
696         from log directory and merge them with the list of already crashed tests.
697
698 2015-10-21  Filip Pizlo  <fpizlo@apple.com>
699
700         Failures in PutStackSinkingPhase should be less severe
701         https://bugs.webkit.org/show_bug.cgi?id=150400
702
703         Reviewed by Geoffrey Garen.
704
705         Add a test mode for no PutStackSinkingPhase.
706
707         * Scripts/run-jsc-stress-tests:
708
709 2015-10-21  Nan Wang  <n_wang@apple.com>
710
711         AX: Expose table size and cell indexes on iOS
712         https://bugs.webkit.org/show_bug.cgi?id=150366
713
714         Reviewed by Chris Fleizach.
715
716         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
717         (AccessibilityUIElement::rowCount):
718         (AccessibilityUIElement::columnCount):
719         (AccessibilityUIElement::indexInTable):
720         (AccessibilityUIElement::numberAttributeValue):
721         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
722         (WTR::AccessibilityUIElement::numberAttributeValue):
723         (WTR::AccessibilityUIElement::rowCount):
724         (WTR::AccessibilityUIElement::columnCount):
725         (WTR::AccessibilityUIElement::indexInTable):
726
727 2015-10-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
728
729         W3C test importer should not import reference files as regular tests
730         https://bugs.webkit.org/show_bug.cgi?id=150331
731
732         Reviewed by Darin Adler.
733
734         Updated test_parser to return information that a file can be a referencefile or a manual test.
735         Updated test importer to skip those files.
736         Updated/Added test parser unit tests accordingly.
737
738         Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
739         Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
740         to mark these files as Skip, since they are not direct tests. 
741
742         * Scripts/webkitpy/w3c/test_importer.py:
743         (TestImporter.__init__):
744         (TestImporter.find_importable_tests):
745         (TestImporter.import_tests):
746         * Scripts/webkitpy/w3c/test_parser.py:
747         (TestParser.analyze_test):
748         * Scripts/webkitpy/w3c/test_parser_unittest.py:
749         (test_analyze_non_html_file):
750         (test_reference_test):
751
752 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
753
754         run-webkit-tests does not copy all crash logs for layout test failures on iOS
755         https://bugs.webkit.org/show_bug.cgi?id=150056
756         <rdar://problem/9280656>
757
758         Reviewed by Alexey Proskuryakov.
759
760         * Scripts/webkitpy/common/system/crashlogs.py:
761         (CrashLogs.find_all_logs): Generic method to find all crash logs.
762         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
763         It iterates through log directory and returns all the logs based on timestamp.
764         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
765         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
766         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
767         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
768         * Scripts/webkitpy/layout_tests/controllers/manager.py:
769         (Manager.run): Modified start_time to start counting before simulator launch
770         so that we can capture crashes during simualator launch.
771         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
772         any test which is not already marked as CRASH to the run_results.
773         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
774         (TestExpectationsModel.get_expectations_string): return PASS in case there
775         are no expectations defined for this test.
776         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
777         (summarize_results): Add other_crashes in a separte category in full_results.json.
778         * Scripts/webkitpy/port/ios.py:
779         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
780         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
781         from the log directory.
782         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
783         logs from log directory and merge them with the list of already crashed tests.
784
785 2015-10-20  Dana Burkart  <dburkart@apple.com>
786
787         Fix the build
788
789         Unreviewed.
790
791         My previous patch was missing a necessary space character.
792
793         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
794
795 2015-10-20  Dana Burkart  <dburkart@apple.com>
796
797         svn-apply fails to apply binary diffs in some cases
798         https://bugs.webkit.org/show_bug.cgi?id=64647
799
800         Reviewed by Daniel Bates.
801
802         * Scripts/VCSUtils.pm:
803         (decodeGitBinaryPatchDeltaSize): Modified.
804         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
805         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
806
807 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
808
809         Mac Debug EWS never finishes when there are failures
810         https://bugs.webkit.org/show_bug.cgi?id=150334
811
812         Reviewed by Daniel Bates.
813
814         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
815         * Scripts/webkitpy/tool/commands/queues.py:
816
817 2015-10-20  Philippe Normand  <pnormand@igalia.com>
818
819         [GTK] Enable OpenWebRTC test video/audio sources in tests
820
821         This is needed because we can't expect the buildbots to have
822         webcam/mic devices plugged in.
823
824         Rubber-stamped by Carlos Garcia Campos.
825
826         * Scripts/run-gtk-tests:
827         (TestRunner._setup_testing_environment):
828         * Scripts/webkitpy/port/gtk.py:
829         (GtkPort.setup_environ_for_server):
830
831 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
832
833         Rename the PICTURE_SIZES flag to CURRENTSRC
834         https://bugs.webkit.org/show_bug.cgi?id=150275
835
836         Reviewed by Dean Jackson.
837
838         * Scripts/webkitperl/FeatureList.pm:
839
840 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
841
842         Unreviewed, add myself to the committers list.
843
844         * Scripts/webkitpy/common/config/contributors.json:
845
846 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
847
848         Add new EWS queues to bot watcher's dashboard
849         https://bugs.webkit.org/show_bug.cgi?id=150297
850
851         Reviewed by Darin Adler.
852
853         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
854         (BubbleQueueServer):
855
856 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
857
858         REGRESSION(r190262): User media unit test failures after r190262
859         https://bugs.webkit.org/show_bug.cgi?id=149580
860
861         Reviewed by Carlos Garcia Campos.
862
863         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
864         So we do not need to skip them anymore.
865
866         * Scripts/run-gtk-tests:
867         (TestRunner): Deleted.
868
869 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
870
871         Add historical addresses to contributors.json
872         https://bugs.webkit.org/show_bug.cgi?id=150227
873
874         Reviewed by Darin Adler.
875
876         * Scripts/webkitpy/common/config/contributors.json:
877
878 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
879
880         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
881         https://bugs.webkit.org/show_bug.cgi?id=150307
882
883         Reviewed by Brent Fulgham.
884
885         The DLL build rules have been changed to generate "{Name}Lib.DLL",
886         but these changes have not yet been applied to the Visual Studio builds.
887
888         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
889
890 2015-10-16  Andreas Kling  <akling@apple.com>
891
892         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
893         <https://webkit.org/b/150153>
894
895         Unreviewed.
896
897         Just use simple arrays of LChar and UChar for this test instead of creating String
898         objects and then getting the characters8()/characters16() from them, since that
899         doesn't guarantee null-termination (the bug.)
900
901         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
902         (TestWebKitAPI::TEST):
903         (TestWebKitAPI::build): Deleted.
904
905 2015-10-16  Tim Horton  <timothy_horton@apple.com>
906
907         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
908         https://bugs.webkit.org/show_bug.cgi?id=150255
909
910         Reviewed by Simon Fraser.
911
912         * Scripts/run-api-tests:
913         (runTest):
914         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
915         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
916         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
917         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
918         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
919         Don't set the layout size until after the load finishes and we're waiting
920         for the reply, so that there is no race between the new size coming in
921         and us waiting for it.
922
923 2015-10-16  Anders Carlsson  <andersca@apple.com>
924
925         WebEditingDelegate should be a formal protocol
926         https://bugs.webkit.org/show_bug.cgi?id=150254
927         <rdar://problem/23149847>
928
929         Reviewed by Dan Bernstein.
930
931         * DumpRenderTree/mac/EditingDelegate.h:
932         Conform to the WebEditingDelegate protocol.
933
934 2015-10-16  Tim Horton  <timothy_horton@apple.com>
935
936         Hook up autolayout intrinsic sizing for WKWebView
937         https://bugs.webkit.org/show_bug.cgi?id=150219
938         <rdar://problem/20016905>
939
940         Reviewed by Simon Fraser.
941
942         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
943         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
944         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
945         (-[AutoLayoutWKWebView load:expectingContentSize:]):
946         (-[AutoLayoutWKWebView expectContentSizeChange:]):
947         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
948         (TEST):
949         Add a variety of tests, including one which catches the bug that
950         the WebCore part of this patch fixes.
951
952 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
953
954         Update the help message of --system-malloc
955         https://bugs.webkit.org/show_bug.cgi?id=150169
956
957         Reviewed by Geoffrey Garen.
958
959         * Scripts/webkitperl/FeatureList.pm:
960
961 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
962
963         Update ImportExpectations according currently imported wpt tests
964         https://bugs.webkit.org/show_bug.cgi?id=150158
965
966         Reviewed by Chris Dumez.
967
968         * Scripts/webkitpy/w3c/test_downloader.py:
969         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
970
971 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
972
973         Unreviewed, Update my email address.
974
975         * Scripts/webkitpy/common/config/contributors.json:
976
977 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
978
979         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
980         https://bugs.webkit.org/show_bug.cgi?id=84960
981
982         Reviewed by Žan Doberšek.
983
984         * Scripts/run-gtk-tests:
985         (TestRunner): Unskip tests using SessionState.
986         * TestWebKitAPI/PlatformGTK.cmake: Add
987         WKPageCopySessionStateWithFiltering test.
988
989 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
990
991         [GTK] Missing return value on TestWebExtensions.cpp:193
992         https://bugs.webkit.org/show_bug.cgi?id=149755
993
994         Unreviewed. Add missing return value.
995
996         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
997         (permissionRequestCallback):
998
999 2015-10-14  Andy Estes  <aestes@apple.com>
1000
1001         [iOS] build-dumprendertree does not build ImageDiff
1002         https://bugs.webkit.org/show_bug.cgi?id=150152
1003
1004         Reviewed by Tim Horton.
1005
1006         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
1007         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
1008         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
1009         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
1010
1011         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
1012         fine on that platform, and results in ImageDiff being built.
1013
1014         * Scripts/build-dumprendertree:
1015
1016 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
1017
1018         [Win] Enforce launcher/library naming scheme
1019         https://bugs.webkit.org/show_bug.cgi?id=150124
1020
1021         Reviewed by Alex Christensen.
1022
1023         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
1024         * MiniBrowser/win/CMakeLists.txt: Ditto.
1025         * TestWebKitAPI/PlatformWin.cmake: Ditto.
1026         * win/DLLLauncher/DLLLauncherMain.cpp:
1027         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
1028         original {name}.dll.
1029
1030 2015-10-14  Andreas Kling  <akling@apple.com>
1031
1032         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
1033         <https://webkit.org/b/150135>
1034
1035         Reviewed by Geoffrey Garen.
1036
1037         Add a new WTF API test that covers this issue.
1038
1039         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1040         (TestWebKitAPI::build):
1041         (TestWebKitAPI::TEST):
1042
1043 2015-10-14  Alex Christensen  <achristensen@webkit.org>
1044
1045         Add SPI for reloading without content blockers
1046         https://bugs.webkit.org/show_bug.cgi?id=150058
1047         rdar://problem/22742222
1048
1049         Reviewed by Sam Weinig.
1050
1051         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1052         (WTR::TestController::cocoaResetStateToConsistentValues):
1053         * WebKitTestRunner/mac/TestControllerMac.mm:
1054         (WTR::TestController::platformConfigureViewForTest):
1055
1056 2015-10-14  Mark Lam  <mark.lam@apple.com>
1057
1058         Rename some JSC option names to be more uniform.
1059         https://bugs.webkit.org/show_bug.cgi?id=150127
1060
1061         Reviewed by Geoffrey Garen.
1062
1063         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1064         * Scripts/run-jsc-stress-tests:
1065
1066 2015-10-14  Anders Carlsson  <andersca@apple.com>
1067
1068         Change the bundle app cache APIs to take a page
1069         https://bugs.webkit.org/show_bug.cgi?id=150123
1070
1071         Reviewed by Sam Weinig.
1072
1073         Update APIs.
1074
1075         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1076         (WTR::InjectedBundle::beginTesting):
1077         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1078         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1079         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1080         (WTR::TestRunner::clearAllApplicationCaches):
1081         (WTR::TestRunner::clearApplicationCacheForOrigin):
1082         (WTR::TestRunner::setAppCacheMaximumSize):
1083         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
1084         (WTR::TestRunner::originsWithApplicationCache):
1085
1086 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1087
1088         Update web-platform-tests tools to the latest revision
1089         https://bugs.webkit.org/show_bug.cgi?id=149645
1090
1091         Reviewed by Darin Adler.
1092
1093         Disabling git submodules information conversion to json install file for web-platform-tests.
1094         Disabling related python unit tests.
1095         The tools submodules contain submodules and the conversion tool does not support that yet.
1096
1097         Updating wpt launcher script to aling it with web-platform-test main script.
1098
1099         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1100         (main):
1101         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1102         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
1103         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1104         (TestImporterTest.test_submodules_generation):
1105
1106 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1107
1108         More debug queue build fixing.
1109
1110         Preserve the build style in one more place. Changed mock build_style from "both"
1111         to "release", as we don't support testing both debug and release.
1112
1113         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1114         (MockCommitQueue.archive_last_test_results):
1115         (MockCommitQueue):
1116         (MockCommitQueue.build_style):
1117         (MockCommitQueue.did_pass_testing_ews):
1118         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1119         (PatchAnalysisTask._test):
1120         (PatchAnalysisTask._build_and_test_without_patch):
1121         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1122         (EarlyWarningSystemTest._default_expected_logs):
1123         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1124
1125 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1126
1127         More debug queue build fixing.
1128
1129         Add build_style argument to derived classes as well.
1130
1131         * Scripts/webkitpy/common/config/ports.py:
1132         (MacPort):
1133         (MacPort.run_webkit_tests_command):
1134         (WinPort.run_bindings_tests_command):
1135         (WinPort):
1136         (WinPort.run_webkit_tests_command):
1137         (GtkWK2Port.build_webkit_command):
1138         (GtkWK2Port):
1139         (GtkWK2Port.run_webkit_tests_command):
1140
1141 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
1142
1143         [iOS] Build fix
1144
1145         Unreviewed.
1146
1147         Mach-O section names are limited to 16 characters.
1148
1149         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1150         * DumpRenderTree/mac/DumpRenderTree.mm:
1151         (activateFontsIOS):
1152
1153 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1154
1155         Build fix for mac-debug EWS queue.
1156
1157         Unreviewed.
1158
1159         Pass --debug to run-webkit-tests.
1160
1161         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
1162         will need to be substantially modified to work in EWS, so the dummy implementation
1163         was not helpful.
1164
1165         * Scripts/webkitpy/common/config/ports.py:
1166         (DeprecatedPort.run_javascriptcore_tests_command):
1167         (DeprecatedPort):
1168         (DeprecatedPort.run_webkit_tests_command):
1169         (DeprecatedPort.run_python_unittests_command):
1170         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
1171         * Scripts/webkitpy/common/config/ports_mock.py:
1172         (MockPort.run_javascriptcore_tests_command):
1173         (MockPort):
1174         (MockPort.run_webkit_tests_command):
1175         (MockPort.run_bindings_tests_command):
1176         (MockPort.run_webkit_unit_tests_command): Deleted.
1177         * Scripts/webkitpy/tool/commands/download_unittest.py:
1178         * Scripts/webkitpy/tool/steps/runtests.py:
1179         (RunTests.run):
1180         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1181         (RunTestsTest.test_webkit_run_unit_tests):
1182         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1183         (StepsTest.test_runtests_args):
1184
1185 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
1186
1187         [Win] Generate Crash Traces
1188         https://bugs.webkit.org/show_bug.cgi?id=150103
1189
1190         Reviewed by Daniel Bates.
1191
1192         We were using an exception filter to try to emit "#CRASHED" to stderr
1193         when a test program crashed. However, the modern Python implementation
1194         seems capable of recognizing crashes on its own. Furthermore, registering
1195         the exception handler was preventing the JIT debugger (NTSD) from
1196         automatically attaching to the crashing program, so we were not getting
1197         crash traces.
1198         
1199         * DumpRenderTree/win/DumpRenderTree.cpp:
1200         (main): Don't register an exception filter.
1201         (exceptionFilter): Deleted.
1202         * Scripts/webkitpy/common/system/crashlogs.py:
1203         (CrashLogs): Add another regular expression to handle a second crash trace
1204         syntax I encountered during testing.
1205         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
1206         try the new one. The PID found by the new expression is in hexadecimal, so
1207         convert it to an integer before returning it.
1208         * Scripts/webkitpy/port/driver.py:
1209         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
1210         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
1211         check for "#CRASHED" after stripping off the EOL characters.
1212         * Scripts/webkitpy/port/win.py:
1213         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
1214         invocation. This is apparently used to signal an event when the debugger is finished.
1215
1216 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1217
1218         Mac Debug and 32-bit queues should be separate
1219         https://bugs.webkit.org/show_bug.cgi?id=150092
1220
1221         Reviewed by Lucas Forschler.
1222
1223         * QueueStatusServer/config/queues.py:
1224         * QueueStatusServer/model/queues.py:
1225         (Queue._capitalize_after_dash):
1226         (Queue._caplitalize_after_dash): Deleted.
1227         * Scripts/webkitpy/common/config/ews.json:
1228
1229 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
1230
1231         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
1232         https://bugs.webkit.org/show_bug.cgi?id=150085
1233
1234         Reviewed by Carlos Garcia Campos.
1235
1236         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1237
1238 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
1239
1240         Unreviewed, add myself to the committers list.
1241
1242         * Scripts/webkitpy/common/config/contributors.json:
1243
1244 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1245
1246         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
1247         https://bugs.webkit.org/show_bug.cgi?id=149983
1248
1249         Reviewed by Dan Bates.
1250
1251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1252         (BubbleQueueServer):
1253         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1254
1255 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1256
1257         Fix webkitpy tests after r190922.
1258
1259         * Scripts/webkitpy/common/config/ews.json:
1260         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1261         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1262
1263 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1264
1265         Add a Mac debug EWS queue
1266         https://bugs.webkit.org/show_bug.cgi?id=150069
1267
1268         Reviewed by Geoffrey Garen.
1269
1270         * QueueStatusServer/config/queues.py:
1271         * Scripts/webkitpy/common/config/ews.json:
1272         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1273         (AbstractEarlyWarningSystem):
1274         (AbstractEarlyWarningSystem.archive_last_test_results):
1275         (AbstractEarlyWarningSystem.build_style):
1276         (AbstractEarlyWarningSystem.refetch_patch):
1277         (AbstractEarlyWarningSystem.load_ews_classes):
1278
1279 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1280
1281         [GTK] Update jhbuild's version of harfbuzz
1282         https://bugs.webkit.org/show_bug.cgi?id=149749
1283
1284         Reviewed by Martin Robinson.
1285
1286         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
1287
1288         * gtk/jhbuild.modules: Updated details for harfbuzz.
1289
1290 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1291
1292         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
1293         https://bugs.webkit.org/show_bug.cgi?id=150026
1294
1295         Reviewed by Philippe Normand.
1296
1297         Backport upstream patch from gst-plugins-bad so that the right version
1298         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
1299         gets compiled properly, avoiding crashes on runtime while running tests.
1300
1301         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
1302         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
1303
1304 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
1305
1306         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
1307         https://bugs.webkit.org/show_bug.cgi?id=149777
1308
1309         Reviewed by Simon Fraser.
1310
1311         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
1312         to the list of tests to preinstall at startup time.
1313
1314         Also, update the generation of the 'name' table in the FontWithFeatures font.
1315
1316         * DumpRenderTree/mac/DumpRenderTree.mm:
1317         (allowedFontFamilySet):
1318         (activateTestingFonts):
1319         (activateFontsIOS):
1320         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1321         (Generator::generate):
1322         (Generator::appendCFFTable):
1323         (Generator::appendNameSubtable):
1324         (Generator::appendNAMETable):
1325         * FontWithFeatures/FontWithFeatures/main.cpp:
1326         (main):
1327         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1328         (WTR::allowedFontFamilySet):
1329         (WTR::activateFonts):
1330         * WebKitTestRunner/mac/TestControllerMac.mm:
1331         (WTR::allowedFontFamilySet):
1332
1333 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
1334
1335         Unreviewed. Add Jinyoung Hur as a committer. 
1336
1337         * Scripts/webkitpy/common/config/contributors.json:
1338
1339 2015-10-10  Dan Bernstein  <mitz@apple.com>
1340
1341         [iOS] Remove unnecessary iOS version checks
1342         https://bugs.webkit.org/show_bug.cgi?id=150002
1343
1344         Reviewed by Alexey Proskuryakov.
1345
1346         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1347         (-[HIDEventGenerator _createIOHIDEventType:]):
1348         (-[HIDEventGenerator _sendHIDEvent:]):
1349         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1350         * WebKitTestRunner/ios/UIKitSPI.h:
1351
1352 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
1353
1354         Unreviewed, rolling out r190689
1355         https://bugs.webkit.org/show_bug.cgi?id=149992
1356
1357         Fixed in other repository.
1358
1359         Reverted changesets:
1360
1361         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
1362         https://bugs.webkit.org/show_bug.cgi?id=149897
1363
1364 2015-10-09  Brian Burg  <bburg@apple.com>
1365
1366         Teach webkitperl how to figure out IOS versions from the SDK
1367         https://bugs.webkit.org/show_bug.cgi?id=149963
1368
1369         Reviewed by Daniel Bates.
1370
1371         It should be easier to check the major and minor version of IOS SDKs.
1372
1373         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
1374         * Scripts/webkitdirs.pm:
1375         (splitVersionString): Added.
1376         (determineOSXVersion): Use splitVersionString.
1377         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
1378         (iosVersion): Added.
1379
1380 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
1381
1382         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
1383         https://bugs.webkit.org/show_bug.cgi?id=149960
1384
1385         Reviewed by Tim Horton.
1386         
1387         Use adoptWK(), and null out some members (file is not using ARC).
1388
1389         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1390         (UIScriptContext::uiScriptComplete):
1391         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1392         (-[TestRunnerWKWebView dealloc]):
1393
1394 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1395
1396         Remove ENABLE_SUID_SANDBOX_LINUX cruft
1397         https://bugs.webkit.org/show_bug.cgi?id=149954
1398
1399         Reviewed by Darin Adler.
1400
1401         * Scripts/webkitperl/FeatureList.pm:
1402
1403 2015-10-09  Daniel Bates  <dabates@apple.com>
1404
1405         Make iOS builders generate debug information in a separate dSYM file
1406         https://bugs.webkit.org/show_bug.cgi?id=149696
1407
1408         Reviewed by Darin Adler.
1409
1410         Similar to the Mac builders, the iOS builders should write debug information
1411         into a separate dSYM file instead of including such information in the binary
1412         itself (default Xcode behavior)
1413
1414         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1415         (CompileWebKit.start):
1416
1417 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1418
1419         Fix webkitpy tests after r190779
1420         https://bugs.webkit.org/show_bug.cgi?id=149949
1421
1422         Reviewed by Ryosuke Niwa.
1423
1424         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1425         (BenchmarkResults.format):
1426         (BenchmarkResults._format_values):
1427
1428 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
1429
1430         Extend run-benchmark script to support human-readable results conversion.
1431         https://bugs.webkit.org/show_bug.cgi?id=149944
1432
1433         Reviewed by Ryosuke Niwa.
1434
1435         Add '--read-results-json' and '--no-adjust-unit' options.
1436         '--read-results-json' option converts result file to human readable format.
1437         '--no-adjust-unit' option skips scientific notation convertion.
1438         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
1439
1440         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1441         (BenchmarkResults.format):
1442         (BenchmarkResults._format_tests):
1443         (BenchmarkResults._format_values):
1444         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1445         (BenchmarkRunner.__init__):
1446         (BenchmarkRunner._run_benchmark):
1447         (BenchmarkRunner._dump):
1448         (BenchmarkRunner.show_results):
1449         (BenchmarkRunner._show_results): Deleted.
1450         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1451         (parse_args):
1452         (start):
1453
1454 2015-10-08  Daniel Bates  <dabates@apple.com>
1455
1456         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
1457         https://bugs.webkit.org/show_bug.cgi?id=149945
1458
1459         Reviewed by Dan Bernstein.
1460
1461         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
1462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
1463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1464         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1465         (WebKitBuildbot):
1466         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1467         (table.queue-grid tr.platform.ios-9 img.logo):
1468
1469 2015-10-08  Daniel Bates  <dabates@apple.com>
1470
1471         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
1472         https://bugs.webkit.org/show_bug.cgi?id=149943
1473
1474         Reviewed by Dan Bernstein.
1475
1476         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
1477         teach build-webkit to install them when building for iOS device using the public iOS SDK. 
1478
1479         * Scripts/build-webkit:
1480
1481 2015-10-08  Daniel Bates  <dabates@apple.com>
1482
1483         Add LLVM binaries for iOS 9 device
1484         https://bugs.webkit.org/show_bug.cgi?id=149913
1485
1486         Reviewed by Filip Pizlo.
1487
1488         Implement support for building LLVM for ARM64-based iOS devices.
1489
1490         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
1491         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
1492         an existing build earlier in the file such that remove previously built
1493         libraries before building/copying new ones (if applicable).
1494         (fileContains): Moved function outside of if-block.
1495         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
1496         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
1497         added logic to build LLVM for ARM64-based iOS devices.
1498         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
1499         LLVM into the WebKitBuild directory.
1500
1501 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
1502
1503         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
1504         https://bugs.webkit.org/show_bug.cgi?id=149848
1505
1506         Reviewed by Darin Adler.
1507
1508         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1509
1510 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
1511
1512         [Win] Support 64-bit Build and Testing
1513         https://bugs.webkit.org/show_bug.cgi?id=149904
1514
1515         Reviewed by Daniel Bates.
1516
1517         Extend our existing scripts to support 64-bit build and test operations on
1518         Windows.
1519
1520         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
1521         Windows always builds the whole stack.
1522         * Scripts/webkit-build-directory: Add an option to return the location of
1523         the executable files produced by a specific configuration. This change is
1524         actually useful for Gtk and EFL, too.
1525         * Scripts/webkitdirs.pm:
1526         (executableProductDir): Added. This function appends the proper binary
1527         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
1528         (jscProductDir): Use the new 'executableProductDir' method.
1529         (setPathForRunningWebKitApp): Ditto.
1530         (runSafari): Ditto.
1531         (runMiniBrowser): Ditto.
1532         * Scripts/webkitpy/port/factory.py:
1533         (configuration_options): Add a 64-bit option, used on Windows to specify
1534         which binary target should be used for testing.
1535         * Scripts/webkitpy/port/win.py:
1536         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
1537         processes when needed.
1538         (WinPort._build_path): Add the correct binary target path to _build_path.
1539         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
1540         64-bit paths for 64-bit tests.
1541         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
1542         NTSD debugger does not understand this argument.
1543
1544 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
1545
1546         Test font-variant-* and font-feature-settings with TrueType fonts
1547         https://bugs.webkit.org/show_bug.cgi?id=149776
1548
1549         Reviewed by Simon Fraser.
1550
1551         This test extends our existing FontWithFeatures project to be able to generate a
1552         TrueType font. This font is conceptually similar as the existing OpenType font,
1553         except the feature -> character mapping is different.
1554
1555         The font itself only supports the following characters:
1556         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1557         However, the shape of these letters are either an X or a check mark.
1558         The letter "A" always is a check mark.
1559         The letter "B" always is an X.
1560         Each font feature has an letter associated with it. When the font feature is enabled,
1561         that letter is shown as a check mark. For example, when
1562         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
1563         mark.
1564
1565         Here are the mappings of font features to letters:
1566         kLigaturesType / kCommonLigaturesOnSelector: C
1567         kLigaturesType / kContextualLigaturesOnSelector: D
1568         kLigaturesType / kRareLigaturesOnSelector: G
1569         kLigaturesType / kHistoricalLigaturesOnSelector: I
1570         kContextualAlternatesType / kContextualAlternatesOnSelector: L
1571         kVerticalPositionType / kInferiorsSelector: O
1572         kVerticalPositionType / kSuperiorsSelector: P
1573         kLowerCaseType / kLowerCaseSmallCapsSelector: S
1574         kUpperCaseType / kUpperCaseSmallCapsSelector: V
1575         kLowerCaseType / kLowerCasePetiteCapsSelector: T
1576         kUpperCaseType / kUpperCasePetiteCapsSelector: W
1577         kLetterCaseType / 14: Y
1578         kStyleOptionsType / kTitlingCapsSelector: a
1579         kNumberCaseType / kUpperCaseNumbersSelector: c
1580         kNumberCaseType / kLowerCaseNumbersSelector: d
1581         kNumberSpacingType / kProportionalNumbersSelector: f
1582         kNumberSpacingType / kMonospacedNumbersSelector: g
1583         kFractionsType / kDiagonalFractionsSelector: i
1584         kFractionsType / kVerticalFractionsSelector: j
1585         kVerticalPositionType / kOrdinalsSelector: Q
1586         kTypographicExtrasType / kSlashedZeroOnSelector: k
1587         kLigaturesType / kHistoricalLigaturesOnSelector: K
1588         kCharacterShapeType / kJIS1978CharactersSelector: m
1589         kCharacterShapeType / kJIS1983CharactersSelector: n
1590         kCharacterShapeType / kJIS1990CharactersSelector: o
1591         kCharacterShapeType / kJIS2004CharactersSelector: p
1592         kCharacterShapeType / kSimplifiedCharactersSelector: q
1593         kCharacterShapeType / kTraditionalCharactersSelector: r
1594         kTextSpacingType / kMonospacedTextSelector: t
1595         kTextSpacingType / kProportionalTextSelector: u
1596         kRubyKanaType / kRubyKanaOnSelector: v
1597
1598         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1599         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1600         (CFFBuilder::moveTo):
1601         (CFFBuilder::lineTo):
1602         (GLYFBuilder::GLYFBuilder):
1603         (GLYFBuilder::takeResult):
1604         (GLYFBuilder::moveTo):
1605         (GLYFBuilder::lineTo):
1606         (GLYFBuilder::closePath):
1607         (GLYFBuilder::writePoint):
1608         (GLYFBuilder::append16):
1609         (generateBoxCharString):
1610         (generateCheckCharString):
1611         (generateXCharString):
1612         (itemForGlyph):
1613         (Generator::generate):
1614         (Generator::insertSelector):
1615         (Generator::insertFeature):
1616         (Generator::generateFeatureDescription):
1617         (Generator::appendCFFTable):
1618         (Generator::appendGLYFTable):
1619         (Generator::appendLOCATable):
1620         (Generator::appendFEATTable):
1621         (Generator::appendMetamorphosisChain):
1622         (Generator::appendMORXTable):
1623         (Generator::appendHEADTable):
1624         (Generator::appendHMTXTable):
1625         (Generator::appendNameSubtable):
1626         (Generator::append2ByteASCIIString):
1627         (Generator::appendNAMETable):
1628         (generateFont):
1629         (CFFBuilder::curveToCubic): Deleted.
1630         (charStringForGlyph): Deleted.
1631         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1632         * FontWithFeatures/FontWithFeatures/main.cpp:
1633         (constructFontWithTrueTypeFeature):
1634         (constructFontWithOpenTypeFeature):
1635         (drawText):
1636         (main):
1637         (drawTextWithFeature): Deleted.
1638
1639 2015-10-07  Commit Queue  <commit-queue@webkit.org>
1640
1641         Unreviewed, rolling out r190572, r190593, r190594, and
1642         r190639.
1643         https://bugs.webkit.org/show_bug.cgi?id=149897
1644
1645         Breaks Mavericks build (Requested by litherum on #webkit).
1646
1647         Reverted changesets:
1648
1649         "Allow WKRetainPtrs to be used as keys in hashing data
1650         structures"
1651         https://bugs.webkit.org/show_bug.cgi?id=149762
1652         http://trac.webkit.org/changeset/190572
1653
1654         "REGRESSION(189668?): http/tests/notifications/events.html
1655         flakily asserts or times out"
1656         https://bugs.webkit.org/show_bug.cgi?id=149218
1657         http://trac.webkit.org/changeset/190593
1658
1659         "Prospective Mavericks build fix."
1660         http://trac.webkit.org/changeset/190594
1661
1662         "Post-review cleanup after r190572."
1663         http://trac.webkit.org/changeset/190639
1664
1665 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1666
1667         [GTK] Add autocleanups
1668         https://bugs.webkit.org/show_bug.cgi?id=149588
1669
1670         Reviewed by Darin Adler.
1671
1672         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
1673         (AutocleanupsTest::create):
1674         (AutocleanupsTest::testWebProcessAutocleanups):
1675         (registerTests):
1676         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1677         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
1678         (testUIProcessAutocleanups):
1679         (testWebProcessAutocleanups):
1680         (beforeAll):
1681         (afterAll):
1682
1683 2015-10-06  Brian Burg  <bburg@apple.com>
1684
1685         Unreviewed, try to fix the iOS 8 build after r190368.
1686
1687         On older versions, IOHIDEventCreateForceEvent is not available.
1688
1689         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1690         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
1691
1692 2015-10-06  Keith Miller  <keith_miller@apple.com>
1693
1694         Add gmalloc option to run-javascriptcore-tests.
1695         https://bugs.webkit.org/show_bug.cgi?id=149858
1696
1697         Reviewed by Geoffrey Garen.
1698
1699         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
1700         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
1701
1702         * Scripts/run-javascriptcore-tests:
1703
1704 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
1705
1706         Post-review cleanup after r190572.
1707
1708         Unreviewed.
1709
1710         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
1711
1712 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
1713
1714         [Win] Unreviewed build correction.
1715
1716         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
1717         are soft-linked at runtime.
1718
1719 2015-10-06  Keith Miller  <keith_miller@apple.com>
1720
1721         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
1722         https://bugs.webkit.org/show_bug.cgi?id=149815
1723
1724         Reviewed by Filip Pizlo.
1725
1726         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1727         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1728         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1729         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1730         so should just use one test runner.
1731
1732         * Scripts/run-javascriptcore-tests:
1733         (runJSCStressTests):
1734         (runMozillaTests): Deleted.
1735         (defaultJsDriverArgsForMozillaTests): Deleted.
1736         * Scripts/run-jsc-stress-tests:
1737
1738 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
1739
1740         [GTK] Make update-webkitgtk-libs work behind firewall
1741
1742         update-webkitgtk-libs can work behind a firewall with changes to
1743         a few packages.  Where outbound git and active FTP connections
1744         fail, using http protocol succeeds.  Most packages are
1745         already accessed using http.
1746
1747         https://bugs.webkit.org/show_bug.cgi?id=148941
1748
1749         Reviewed by Martin Robinson.
1750
1751         Tools
1752         * gtk/jhbuild.modules:
1753             Replace git URLs with http.  Remove no longer used ftp repositories.
1754             Update argument for libxml2's autogen.sh script (--without-python
1755             is ignored; --with-python=no is correct).
1756         * jhbuild/jhbuild-wrapper:
1757             Instead of connecting to git://git.gnome.org/jhbuild, connect to
1758             http://git.gnome.org/browse/jhbuild.
1759
1760 2015-10-06  Daniel Bates  <dbates@webkit.org>
1761
1762         Enable XSLT when building WebKit for iOS using the public iOS SDK
1763         https://bugs.webkit.org/show_bug.cgi?id=149827
1764
1765         Reviewed by Alexey Proskuryakov.
1766
1767         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1768         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1769         run this script before building WebKit for iOS or the build will fail because one or more XSLT
1770         headers cannot be found.
1771
1772         * Scripts/configure-xcode-for-ios-development:
1773         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1774
1775 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1776
1777         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1778         https://bugs.webkit.org/show_bug.cgi?id=149218
1779
1780         Reviewed by Alexey Proskuryakov.
1781
1782         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1783         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1784         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1785         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1786         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1787         WebNotificationProvider must be updated to appropriately handle multiple
1788         WKNotificationManagerRefs in flight at the same time.
1789
1790         * WebKitTestRunner/WebNotificationProvider.cpp:
1791         (WTR::WebNotificationProvider::~WebNotificationProvider):
1792         (WTR::WebNotificationProvider::showWebNotification):
1793         (WTR::WebNotificationProvider::closeWebNotification):
1794         (WTR::WebNotificationProvider::addNotificationManager):
1795         (WTR::WebNotificationProvider::removeNotificationManager):
1796         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1797         (WTR::WebNotificationProvider::reset):
1798         * WebKitTestRunner/WebNotificationProvider.h:
1799
1800 2015-10-05  Daniel Bates  <dabates@apple.com>
1801
1802         Disable Bitcode when building for iOS device
1803         https://bugs.webkit.org/show_bug.cgi?id=149818
1804
1805         Reviewed by Alexey Proskuryakov.
1806
1807         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1808         when building for iOS device.
1809
1810         * Scripts/webkitdirs.pm:
1811         (XcodeOptions):
1812
1813 2015-10-05  Daniel Bates  <dabates@apple.com>
1814
1815         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1816         https://bugs.webkit.org/show_bug.cgi?id=140828
1817         <rdar://problem/19520599>
1818
1819         Reviewed by Alexey Proskuryakov.
1820
1821         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1822         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1823         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1824         to build-webkit.
1825
1826         * Scripts/webkitdirs.pm:
1827         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1828         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1829         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1830         (hasIOSDevelopmentCertificate): Added.
1831
1832 2015-10-05  Daniel Bates  <dabates@apple.com>
1833
1834         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1835         https://bugs.webkit.org/show_bug.cgi?id=149766
1836
1837         Reviewed by Alexey Proskuryakov.
1838
1839         Create network storage testing session on iOS.
1840
1841         Currently we do not create a network storage testing session on iOS. A network storage testing session always
1842         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1843         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1844         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1845         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1846         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1847         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1848         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1849         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1850
1851         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1852         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1853         returns a non-null pointer to a cookie store.
1854
1855         * DumpRenderTree/mac/DumpRenderTree.mm:
1856         (prepareConsistentTestingEnvironment):
1857
1858 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1859
1860         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1861         available.
1862
1863         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1864         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1865
1866 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1867
1868         Allow WKRetainPtrs to be used as keys in hashing data structures
1869         https://bugs.webkit.org/show_bug.cgi?id=149762
1870
1871         Reviewed by Anders Carlsson.
1872
1873         * TestWebKitAPI/PlatformGTK.cmake:
1874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1875         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1876         (TestWebKitAPI::TEST):
1877
1878 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1879
1880         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1881         available, and tidy up the #ifdefs in the UIKitSPI header.
1882
1883         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1884         (-[HIDEventGenerator _sendHIDEvent:]):
1885         * WebKitTestRunner/ios/UIKitSPI.h:
1886
1887 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
1888
1889         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1890         https://bugs.webkit.org/show_bug.cgi?id=149792
1891
1892         Reviewed by Martin Robinson.
1893
1894         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1895         for WebKitTestRunner multiple times.
1896
1897 2015-10-04  Daniel Bates  <dabates@apple.com>
1898
1899         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1900         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1901
1902         For now, support calling build-layouttestrelay without --ios-simulator so long
1903         as we are building on a Mac.
1904
1905         * Scripts/build-layouttestrelay:
1906
1907 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1908
1909         Support Trac 1.0.x XML timeline link format
1910         https://bugs.webkit.org/show_bug.cgi?id=149786
1911
1912         Reviewed by Lucas Forschler.
1913
1914         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1915         (Trac.prototype._convertCommitInfoElementToObject):
1916
1917 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1918
1919         Fix some errors on bot watcher's dashboard
1920         https://bugs.webkit.org/show_bug.cgi?id=149789
1921
1922         Reviewed by Lucas Forschler.
1923
1924         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1925         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1926         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1927
1928 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1929
1930         Bot watcher's dashboard builders should turn yellow when svn fails
1931         https://bugs.webkit.org/show_bug.cgi?id=149791
1932
1933         Reviewed by Lucas Forschler.
1934
1935         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1936         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1937         (BuildbotBuilderQueueView.prototype.update):
1938
1939 2015-10-02  Daniel Bates  <dabates@apple.com>
1940
1941         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
1942         https://bugs.webkit.org/show_bug.cgi?id=149769
1943
1944         Reviewed by Alexey Proskuryakov.
1945
1946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
1947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1950         (WebKitBuildbot):
1951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1952         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
1953
1954 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1955
1956         REGRESSION(r190370): Speedometer spits out an extra console message
1957         https://bugs.webkit.org/show_bug.cgi?id=149720
1958
1959         Unreviewed. Temporarily ignore the console error message.
1960
1961         * Scripts/webkitpy/performance_tests/perftest.py:
1962         (PerfTest._filter_output):
1963
1964 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1965
1966         Provide "--no-ninja" option to avoid using Ninja
1967         https://bugs.webkit.org/show_bug.cgi?id=149757
1968
1969         Reviewed by Alex Christensen.
1970
1971         Add a new command line argument understood by webkitdirs.pm so
1972         that we can conditionally avoid using Ninja. This is an
1973         'opt-out' argument, so no existing Ninja users should be affected.
1974         
1975         * Scripts/webkitdirs.pm:
1976         (canUseNinja): Check for option and block ninja if present.
1977
1978 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
1979
1980         Flakiness dashboard should support OS X El Capitan
1981         https://bugs.webkit.org/show_bug.cgi?id=149648
1982
1983         Reviewed by Alexey Proskuryakov.
1984
1985         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
1986
1987 2015-10-02  Daniel Bates  <dabates@apple.com>
1988
1989         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
1990         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1991
1992         For now, pass --ios-simulator.
1993
1994         * Scripts/webkitpy/port/ios.py:
1995         (IOSSimulatorPort._build_relay):
1996
1997 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
1998
1999         Remove a "nullable" that breaks the iOS 8 build.
2000
2001         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2002         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
2003
2004 2015-10-02  Daniel Bates  <dabates@apple.com>
2005
2006         LayoutTestRelay is not built and archived when building for iOS Simulator
2007         https://bugs.webkit.org/show_bug.cgi?id=149753
2008
2009         Reviewed by Alexey Proskuryakov and Andy Estes.
2010
2011         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
2012         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
2013         product archive when building for iOS Simulator, respectively.
2014
2015         * BuildSlaveSupport/built-product-archive:
2016         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
2017         differentiate between iOS device and iOS Simulator platforms.
2018         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
2019         from determineWebKitBuildDirectories() into this function so that it can be used by both
2020         determineWebKitBuildDirectories() and archiveBuiltProduct().
2021         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
2022         webkitBuildDirectoryForConfigurationAndPlatform().
2023         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
2024         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
2025         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
2026         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
2027         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
2028         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
2029         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
2030         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
2031         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
2032         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
2033         * Scripts/build-layouttestrelay:
2034             - Remove unnecessary include of Perl module POSIX.
2035             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
2036         * Scripts/build-webkit:
2037             - Invoke script build-layouttestrelay when building for iOS Simulator.
2038
2039 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
2040
2041         [Win] Unreviewed test fix.
2042
2043         You cannot run 'run-webkit-tests' from the command line because it does not know
2044         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
2045         because they explicitly set use the 'root' argument to provide the full path to
2046         the test binaries.
2047
2048         * Scripts/webkitpy/port/win.py:
2049         (WinPort._build_path): Added.
2050
2051 2015-10-02  Alex Christensen  <achristensen@webkit.org>
2052
2053         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
2054         https://bugs.webkit.org/show_bug.cgi?id=149430
2055         rdar://problem/22742222
2056
2057         Reviewed by Geoffrey Garen.
2058
2059         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2060         (WTR::TestController::cocoaResetStateToConsistentValues):
2061         * WebKitTestRunner/mac/TestControllerMac.mm:
2062         (WTR::TestController::platformConfigureViewForTest):
2063         Test what happens when you disable content blockers from the SPI.
2064
2065 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2066
2067         [Win] Unreviewed build fix for run-api-tests
2068
2069         * Scripts/run-api-tests:
2070         (testToolPaths): Windows run needs to specify the binary path.
2071
2072 2015-10-01  Daniel Bates  <dabates@apple.com>
2073
2074         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
2075         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2076
2077         Following r190424 we can now rely on webkit-build-directory to return the path to
2078         the correct configuration-specific build directory on Windows.
2079
2080         * BuildSlaveSupport/built-product-archive:
2081         (archiveBuiltProduct):
2082
2083 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2084
2085         [Win] Unreviewed build fix.
2086
2087         * Scripts/webkitdirs.pm:
2088         (setupAppleWinEnv): Use 64-bit build tools if available
2089
2090 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2091
2092         [Win] Fix TestWebKitAPI build under CMake.
2093
2094         Reviewed by Alex Christensen.
2095
2096         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
2097         for Psapi.lib.
2098
2099 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2100
2101         [Win] Fix behavior of webkit-build-directory script
2102         https://bugs.webkit.org/show_bug.cgi?id=149718
2103
2104         Reviewed by Alex Christensen.
2105
2106         * Scripts/webkitdirs.pm:
2107         (determineConfigurationProductDir): Do not include the binary
2108         sub-directory in the configuration product directory output.
2109         (jscProductDir): Append correct binary path for Windows build.
2110         (setPathForRunningWebKitApp): Include properly binary subdirectories.
2111         (runSafari): Update for revised productDir behavior.
2112         (runMiniBrowser): Ditto.
2113
2114 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
2115
2116         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
2117         use iOS SDK, like with all the others.
2118
2119         * Scripts/build-webkit:
2120
2121 2015-10-01  Daniel Bates  <dabates@apple.com>
2122
2123         Attempt to fix the iOS 9 Simulator testers
2124
2125         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
2126         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
2127         LayoutTestRelay when building for iOS Simulator.
2128
2129         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2130         * Scripts/build-webkit:
2131
2132 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2133
2134         [GTK] Websites with invalid auth header keep loading forever
2135         https://bugs.webkit.org/show_bug.cgi?id=149710
2136
2137         Reviewed by Martin Robinson.
2138
2139         Add test case to check that we can authenticate sites with an
2140         empty realm.
2141
2142         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2143         (testWebViewAuthenticationEmptyRealm):
2144         (serverCallback):
2145         (beforeAll):
2146
2147 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
2148
2149         [Mac] Make run-api-tests work with System Integrity Protection
2150         https://bugs.webkit.org/show_bug.cgi?id=149711
2151         rdar://problem/22928202
2152
2153         Reviewed by Dan Bernstein.
2154
2155         * Scripts/run-api-tests:
2156         (runTest):
2157         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
2158
2159 2015-10-01  Daniel Bates  <dabates@apple.com>
2160
2161         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
2162         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2163
2164         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
2165         For now, use the path to the top-level WebKit build directory instead of using the configuration-
2166         specific build directory.
2167
2168         * BuildSlaveSupport/built-product-archive:
2169         (archiveBuiltProduct):
2170
2171 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2172
2173         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
2174         https://bugs.webkit.org/show_bug.cgi?id=145837
2175
2176         Reviewed by Philippe Normand.
2177
2178         * efl/jhbuild.modules:
2179         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
2180         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
2181
2182 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2183
2184         Unreviewed. Fix the iOS build after r190407.
2185
2186         * WebKitTestRunner/ios/IOKitSPI.h:
2187
2188 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2189
2190         Implement keyboard event sending for iOS in WebKitTestRunner
2191         https://bugs.webkit.org/show_bug.cgi?id=149676
2192
2193         Reviewed by Simon Fraser.
2194
2195         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
2196         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
2197         allows us to run code when the keyboard is shown or hidden.
2198
2199         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
2200         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2201         (WTR::UIScriptController::setDidShowKeyboardCallback):
2202         (WTR::UIScriptController::didShowKeyboardCallback):
2203         (WTR::UIScriptController::setDidHideKeyboardCallback):
2204         (WTR::UIScriptController::didHideKeyboardCallback):
2205         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2206         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
2207         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
2208         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2209         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2210         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2211         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
2212                 the notifications that the keyboard has been raised or lowered.
2213         (-[TestRunnerWKWebView _keyboardDidShow:]):
2214         (-[TestRunnerWKWebView _keyboardDidHide:]):
2215         * WebKitTestRunner/ios/HIDEventGenerator.h:
2216         * WebKitTestRunner/ios/HIDEventGenerator.m:
2217         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
2218         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
2219         (hidUsageCodeForCharacter): Ditto.
2220         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
2221                 a keyDown event in WebKit.
2222         * WebKitTestRunner/ios/IOKitSPI.h:
2223         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2224
2225 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2226
2227         Unreviewed, rolling out r190399.
2228
2229         Tests are still failing even after r190362
2230
2231         Reverted changeset:
2232
2233         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
2234         http://trac.webkit.org/changeset/190399
2235
2236 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2237
2238         [jhbuild] switch to new upstream usrsctp library
2239         https://bugs.webkit.org/show_bug.cgi?id=149494
2240
2241         Reviewed by Philippe Normand.
2242
2243         * efl/jhbuild.modules:
2244         * gtk/jhbuild.modules:
2245
2246 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2247
2248         Unreviewed. Unskip GTK+ user media unit tests after r190362.
2249
2250         They should pass now.
2251
2252         * Scripts/run-gtk-tests:
2253         (TestRunner):
2254
2255 2015-09-30  Daniel Bates  <dabates@apple.com>
2256
2257         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2258         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2259
2260         * BuildSlaveSupport/built-product-archive:
2261         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
2262         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
2263
2264 2015-09-30  Daniel Bates  <dabates@apple.com>
2265
2266         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2267         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2268
2269         Actually, we need to pass --configuration to script webkit-build-directory to have
2270         it return the path to the configuration-specific build directory.
2271
2272         * BuildSlaveSupport/built-product-archive:
2273         (determineWebKitBuildDirectories):
2274
2275 2015-09-30  Daniel Bates  <dabates@apple.com>
2276
2277         built-product-archive archives incorrect build directory for iOS port
2278         https://bugs.webkit.org/show_bug.cgi?id=149695
2279
2280         Reviewed by Darin Adler.
2281
2282         Fixes an issue where the script built-product-archive archives a non-existent
2283         build directory for the iOS port. Without loss of generality, the script assumes
2284         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
2285         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
2286
2287         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
2288         to determine the top-level build directory and computes the configuration-specific
2289         build directory to be the concatenation of the the top-level build directory and
2290         the configuration (e.g. Release). This is incorrect. Instead we should call
2291         webkit-build-directory omitting the flag --top-level to compute the path to the
2292         configuration-specific build directory.
2293
2294         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
2295         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
2296         its purpose and added global variable _configurationBuildDirectory to store the path
2297         to the configuration-specific build directory. Ensure that we have a non-empty string
2298         for both the top-level and configuration-specific build directories.
2299         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
2300         Compute the configuration-specific build directory and store it in the global variable
2301         _configurationBuildDirectory.
2302         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
2303         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
2304         as needed.
2305         (determineWebKitBuildDirectory): Deleted.
2306
2307 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
2308
2309         [EFL] css3/device-adapt/* tests failed after r190335.
2310         https://bugs.webkit.org/show_bug.cgi?id=149655
2311
2312         Reviewed by Simon Fraser.
2313
2314         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2315         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
2316
2317         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2318         (WTR::shouldUseFixedLayout):
2319
2320 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
2321
2322         Extend JetStream timeout for slow devices.
2323
2324         Reviewed by Chris Dumez.
2325
2326         Extend JetStream timeout to 20 minutes.
2327
2328         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2329
2330 2015-09-30  Daniel Bates  <dabates@apple.com>
2331
2332         Rename iOS builders/testers to include version
2333         https://bugs.webkit.org/show_bug.cgi?id=149685
2334
2335         Reviewed by Simon Fraser.
2336
2337         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
2338         make it clear to a reader the version of iOS these builders/testers are using.
2339
2340         * BuildSlaveSupport/build.webkit.org-config/config.json:
2341         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2342
2343 2015-09-30  Daniel Bates  <dabates@apple.com>
2344
2345         Add iOS criterion for triggering a build
2346         https://bugs.webkit.org/show_bug.cgi?id=149679
2347
2348         Rubber-stamped by Alexey Proskuryakov.
2349
2350         First pass at defining criterion for triggering an iOS build.
2351
2352         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2353         (_should_file_trigger_build):
2354         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2355         (ShouldBuildTest):
2356         (ShouldBuildTest.test_should_build):
2357
2358 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2359
2360         [iOS] Allow tests to generate user gestures for UI testing
2361         https://bugs.webkit.org/show_bug.cgi?id=149653
2362
2363         Reviewed by Tim Horton.
2364
2365         Expose functionality in UIScriptController to allow for testing single- and double-tap,
2366         and to listen for completion of scrolling and zooming in the WKWebView.
2367         
2368         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
2369         which hides the complexity of creating these events. Event dispatch is asynchronous.
2370         We detect when the last event has been handled by dispatching a vendor-specific event,
2371         which is detected via -_handleHIDEvent: in our UIApplication subclass.
2372         
2373         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
2374         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
2375         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
2376         single and double taps.
2377         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2378         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
2379         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
2380         (UIScriptContext::unregisterCallback):
2381         (UIScriptContext::callbackWithID):
2382         (UIScriptContext::fireCallback):
2383         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2384         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2385         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
2386         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
2387         (WTR::UIScriptController::setDidEndZoomingCallback):
2388         (WTR::UIScriptController::didEndZoomingCallback):
2389         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
2390         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
2391         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2392         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2393         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2394         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2395         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
2396         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2397         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
2398         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
2399         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
2400         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
2401         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2402         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
2403         (simpleDragCurve):
2404         (calculateNextLocation):
2405         (delayBetweenMove):
2406         (+[HIDEventGenerator sharedHIDEventGenerator]):
2407         (+[HIDEventGenerator nextEventCallbackID]):
2408         (-[HIDEventGenerator init]):
2409         (-[HIDEventGenerator _createIOHIDEventType:]):
2410         (-[HIDEventGenerator _sendHIDEvent:]):
2411         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2412         (-[HIDEventGenerator _updateTouchPoints:count:]):
2413         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
2414         (-[HIDEventGenerator touchDown:touchCount:]):
2415         (-[HIDEventGenerator touchDown:]):
2416         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
2417         (-[HIDEventGenerator liftUp:touchCount:]):
2418         (-[HIDEventGenerator liftUp:]):
2419         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2420         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2421         (-[HIDEventGenerator tap:completionBlock:]):
2422         (-[HIDEventGenerator doubleTap:completionBlock:]):
2423         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
2424         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2425         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
2426         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
2427         (-[HIDEventGenerator markerEventReceived:]):
2428         * WebKitTestRunner/ios/IOKitSPI.h: Added.
2429         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2430         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2431         (WTR::globalToContentCoordinates):
2432         (WTR::UIScriptController::singleTapAtPoint):
2433         (WTR::UIScriptController::doubleTapAtPoint):
2434         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2435         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2436         * WebKitTestRunner/ios/mainIOS.mm:
2437         (-[WebKitTestRunnerApp _handleHIDEvent:]):
2438
2439 2015-09-30  Dana Burkart  <dburkart@apple.com>
2440
2441         git-add-reviewer should trim trailing spaces/newlines
2442         https://bugs.webkit.org/show_bug.cgi?id=149513
2443
2444         Reviewed by Darin Adler.
2445
2446         * Scripts/git-add-reviewer:
2447         (nonInteractive):
2448
2449 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
2450
2451         REGRESSION(r190262): User media unit test failures after r190262
2452         https://bugs.webkit.org/show_bug.cgi?id=149580
2453
2454         Reviewed by Darin Adler.
2455
2456         * WebKitTestRunner/TestController.cpp:
2457         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
2458           order to WKUserMediaPermissionRequestAllow.
2459
2460 2015-09-30  Daniel Bates  <dabates@apple.com>
2461
2462         Add iOS builders and testers
2463         https://bugs.webkit.org/show_bug.cgi?id=149549
2464
2465         Reviewed by Alexey Proskuryakov.
2466
2467         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
2468         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
2469
2470         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
2471         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
2472
2473 2015-09-30  Timothy Hatcher  <timothy@apple.com>
2474
2475         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
2476         https://bugs.webkit.org/show_bug.cgi?id=149674
2477
2478         Reviewed by Lucas Forschler.
2479
2480         * WebKitLauncher/WebKitLauncher.entitlements: Added.
2481         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2482
2483 2015-09-30  Jason Marcell  <jmarcell@apple.com>
2484
2485         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
2486         have an associated trac instance.
2487         https://bugs.webkit.org/show_bug.cgi?id=149673
2488
2489         Reviewed by Alexey Proskuryakov.
2490
2491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2492         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
2493         have an associated trac instance.
2494
2495 2015-09-30  Daniel Bates  <dabates@apple.com>
2496
2497         Prioritize testing latest build request on iOS test bots
2498         https://bugs.webkit.org/show_bug.cgi?id=149669
2499
2500         Reviewed by Darin Adler.
2501
2502         We should prioritize testing of the latest build request on the iOS test bots
2503         as we do for Mac and Windows test bots.
2504
2505         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2506         (loadBuilderConfig):
2507
2508 2015-09-30  Daniel Bates  <dabates@apple.com>
2509
2510         Add buildbot category for iOS builders and testers
2511         https://bugs.webkit.org/show_bug.cgi?id=149667
2512
2513         Reviewed by Darin Adler.
2514
2515         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
2516         for iOS to the build.webkit.org home page.
2517
2518         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2519         (loadBuilderConfig):
2520         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2521
2522 2015-09-30  Daniel Bates  <dabates@apple.com>
2523
2524         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2525         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2526
2527         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
2528         in <http://trac.webkit.org/changeset/190351>.
2529
2530         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2531         (CompileWebKit.start):
2532
2533 2015-09-30  Daniel Bates  <dabates@apple.com>
2534
2535         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2536         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2537
2538         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
2539         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
2540
2541         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2542         (CompileWebKit.start):
2543
2544 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2545
2546         bot210 was configured for a queue instead of bot126.
2547         
2548         Unreviewed config.json fix.
2549         
2550         * BuildSlaveSupport/build.webkit.org-config/config.json:
2551
2552 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2553
2554         Bring El Capitan buildbot infrastructure online.
2555         https://bugs.webkit.org/show_bug.cgi?id=149605
2556         
2557         Reviewed by Darin Adler.
2558
2559         * BuildSlaveSupport/build.webkit.org-config/config.json:
2560
2561 2015-09-30  Tomas Popela  <tpopela@redhat.com>
2562
2563         [GTK] Deprecation warnings in DOMNodeTest
2564         https://bugs.webkit.org/show_bug.cgi?id=149663
2565
2566         After the webkit_dom_document_get_elements_by_tag_name deprecation we
2567         need to update the tests to use webkit_dom_document_query_selector_all
2568         to avoid compilation warnings.
2569
2570         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
2571         (the suggested replacement for the deprecated function).
2572
2573         Reviewed by Carlos Garcia Campos.
2574
2575         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2576         (WebKitDOMNodeTest::testTagNamesNodeList):
2577         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2578         (registerTests):
2579         (WebKitDOMNodeTest::testTagNames): Deleted.
2580         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2581         (prepareDOMForTagNamesTests):
2582         (testWebKitDOMNodeTagNamesNodeList):
2583         (testWebKitDOMNodeTagNamesHTMLCollection):
2584         (beforeAll):
2585         (testWebKitDOMNodeTagNames): Deleted.
2586
2587 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2588
2589         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
2590         https://bugs.webkit.org/show_bug.cgi?id=149650
2591
2592         Reviewed by Tim Horton.
2593         
2594         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
2595         looks at the file path, and not the custom options that come from file comments.
2596         
2597         Fix by computing TestOptions before making the TestInvocation, and setting them
2598         as const TestInvocation data. This meant changing various call sites to take
2599         the std::string pathOrURL, rather than the TestInvocation itself.
2600         
2601         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
2602
2603         * WebKitTestRunner/CMakeLists.txt:
2604         * WebKitTestRunner/TestController.cpp:
2605         (WTR::TestController::ensureViewSupportsOptionsForTest):
2606         (WTR::testPath):
2607         (WTR::createTestURL):
2608         (WTR::updateTestOptionsFromTestHeader):
2609         (WTR::TestController::testOptionsForTest):
2610         (WTR::TestController::updateWebViewSizeForTest):
2611         (WTR::TestController::updateWindowScaleForTest):
2612         (WTR::TestController::runTest):
2613         * WebKitTestRunner/TestController.h:
2614         * WebKitTestRunner/TestInvocation.cpp:
2615         (WTR::TestInvocation::TestInvocation):
2616         (WTR::TestInvocation::invoke):
2617         (WTR::createWKURL): Deleted.
2618         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
2619         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
2620         * WebKitTestRunner/TestInvocation.h:
2621         (WTR::TestInvocation::options):
2622         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2623         (WTR::pathContains):
2624         (WTR::shouldMakeViewportFlexible):
2625         (WTR::shouldUseFixedLayout):
2626         (WTR::isSVGTestPath):
2627         (WTR::isHiDPITestPath):
2628         (WTR::TestOptions::TestOptions):
2629         * WebKitTestRunner/TestOptions.h:
2630         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2631         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2632         (WTR::pathContains):
2633         (WTR::shouldUseFixedLayout):
2634         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2635         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2636         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2637         * WebKitTestRunner/ios/TestControllerIOS.mm:
2638         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2639         * WebKitTestRunner/mac/TestControllerMac.mm:
2640         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2641
2642 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
2643
2644         Flakiness dashboard should support OS X El Capitan
2645         https://bugs.webkit.org/show_bug.cgi?id=149648
2646
2647         Reviewed by Alexey Proskuryakov.
2648
2649         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
2650         difference between new appscale and old Google App Engine implementation.
2651         * TestResultServer/app.yaml: Same.
2652         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2653
2654 2015-09-29  Daniel Bates  <dabates@apple.com>
2655
2656         configure-xcode-for-ios-development does not work with Xcode 7
2657         https://bugs.webkit.org/show_bug.cgi?id=149640
2658
2659         Reviewed by Alexey Proskuryakov.
2660
2661         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
2662         because it cannot find the Xcode specification files for iOS simulator and device. These
2663         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
2664         relevant definitions to the Xcode 7 specification files directly as opposed to creating
2665         new specification files with the added definitions (as we did in older versions of Xcode)
2666         in order for Xcode 7 to honor these definitions.
2667
2668         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
2669         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
2670         (updateXcode7SpecificationFile): Added.
2671         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
2672         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
2673         appropriate success message.
2674         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
2675         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
2676         (createXcodeSpecificationFromSpecificationAndId): Deleted.
2677
2678 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2679
2680         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
2681         https://bugs.webkit.org/show_bug.cgi?id=149639
2682
2683         Reviewed by Alex Christensen.
2684
2685         * Scripts/VCSUtils.pm:
2686         (exitStatus): Use 'isWindows()' method.
2687         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
2688         an error. This method could probably just go away.
2689         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
2690         always changing to Unix style. 
2691         (unixPath): Added. Needed so Windows can always show a Unix path in the
2692         ChangeLog file.
2693         (changeLogName): Work around the fact that 'getpwuid' is not available on
2694         a pure Windows build of Perl.
2695         * Scripts/prepare-ChangeLog:
2696         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
2697         path on Windows.
2698         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
2699         support using arrays for 'open' arguments.
2700         (resolveChangeLogsPath): Ditto.
2701         (resolveConflictedChangeLogs): Use new helper functions.
2702         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
2703         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
2704         quotes. Unix systems are happy either way.
2705         (statusCommand): Ditto.
2706         * Scripts/webkitdirs.pm:
2707         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2708
2709 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2710
2711         [Win] Unreviewed 64-bit build fix after switch to CMake.
2712
2713         * Scripts/webkitdirs.pm:
2714         (determineIsWin64FromArchitecture): Added.
2715
2716 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2717
2718         printing does not use minimum page zoom factor
2719         https://bugs.webkit.org/show_bug.cgi?id=108507
2720
2721         Reviewed by Darin Adler.
2722
2723         WebKitTestRunner always takes the snapshots from the UI process
2724         (expect for IOS), so in the case of printing, the layout in the
2725         web view is not the expected one. When printing, we need to take
2726         the snapshot in the web process and ensure it's rendered with a
2727         PrintContext.
2728
2729         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2730         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2731         kWKSnapshotOptionsPrinting option to
2732         WKBundlePageCreateSnapshotWithOptions() when printing.
2733
2734 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2735
2736         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2737         https://bugs.webkit.org/show_bug.cgi?id=149595
2738
2739         Reviewed by Tim Horton.
2740
2741         All ports except IOS implement
2742         PlatformWebView::windowSnapshotImage() to generate the snapshot
2743         for the pixel tests in the UI process. But we are still generating
2744         a snapshot for pixel tests in the Web process too, that is passed
2745         to the UI process but ignored.
2746         Whether a pixel result is needed or not, is only known by the web
2747         process depending on whether the test called dumpAsText with
2748         dumpPixels == true or not. Since the pixels are now dump in the UI
2749         process, we need to pass that information to the UI process when
2750         the test is done. For that we set a PixelResultIsPending bool
2751         parameter to the Done message, and we only add the PixelResult
2752         when UI process doesn't need to generate the pixels dump.
2753
2754         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2755         (WTR::InjectedBundle::didReceiveMessageToPage): Set
2756         m_pixelResultIsPending to false on reset.
2757         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2758         Done message, and set the PixelResult if m_pixelResultIsPending is false.
2759         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2760         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2761         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2762         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2763         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2764         port.
2765         * WebKitTestRunner/TestInvocation.cpp:
2766         (WTR::TestInvocation::dumpResults): Use either the pixel result
2767         from the web process or generate a pixel result from the web view
2768         if need it.
2769         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2770         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2771         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2772         is created by the caller now, but the CG implementation needs to
2773         know if it's a Web or UI process snapshot.
2774         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2775         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2776         cairo surface for the given image.
2777         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2778         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2779         CGContext for the given image.
2780
2781 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
2782
2783         Fix JS errors on dashboard metrics page
2784         https://bugs.webkit.org/show_bug.cgi?id=149608
2785
2786         Reviewed by Alexey Proskuryakov.
2787
2788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2789         (initPlatformsByFamily): 
2790         (updateHiddenPlatforms):
2791         (parsePlatformFamily): Deleted.
2792         (updateToggleButtons): Deleted.
2793         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2794         (updateHiddenPlatforms): Added to remove errors.
2795         (initPlatformsByFamily): Added to remove errors.
2796         (unhiddenQueues): Updated to use Settings.
2797         (documentReady): Added logic to add toggle buttons to the settings menu.
2798         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2799         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2800         MetricsMain.js to Settings.
2801         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2802         MetricsMain.js to Settings.
2803         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2804         (QueueView.prototype._updateHiddenState): Updated to use Settings.
2805
2806 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
2807
2808         Appscale query fails because of missing index
2809         https://bugs.webkit.org/show_bug.cgi?id=149609
2810
2811         Reviewed by Darin Adler.
2812
2813         * QueueStatusServer/index.yaml: Added the required index.
2814
2815 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2816
2817         [Win] Fix the 64-bit build after switch to cmake.
2818
2819         Reviewed by Alex Christensen.
2820
2821         * Scripts/webkitdirs.pm:
2822         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2823         run a 64-bit build.
2824
2825 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2826
2827         [Win] Allow Windows to run test-webkitpy without Cygwin
2828         https://bugs.webkit.org/show_bug.cgi?id=149602
2829
2830         Reviewed by Alex Christensen.
2831
2832         These changes mostly shift from hard-coded paths using UNIX-style
2833         separators to Python's "os.path.join" syntax that uses the correct
2834         path separator for each platform.
2835         
2836         * Scripts/webkitpy/common/system/path.py:
2837         (cygpath): Don't pass paths through Cygpath on native Windows.
2838         * Scripts/webkitpy/port/win.py:
2839         (WinPort._path_to_apache): Use os.path.join.
2840         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2841         in 64-bit environments).
2842         * Scripts/webkitpy/style/checker.py: Use os.path.join.
2843         * Scripts/webkitpy/style/checker_unittest.py:
2844         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2845         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2846         (GlobalVariablesTest): Ditto.
2847         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2848         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2849         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2850         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2851         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2852         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2853         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2854         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2855         (StyleProcessor_CodeCoverageTest): Ditto.
2856         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2857         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2858         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2859         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2860         manual string concatenation of paths.
2861
2862 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2863
2864         Add bugzilla addresses of committers to contributors.json
2865         https://bugs.webkit.org/show_bug.cgi?id=149520
2866
2867         Reviewed by Darin Adler.
2868
2869         * Scripts/webkitpy/common/config/contributors.json:
2870
2871 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2872
2873         validate-committer-lists -b shouldn't need edituser privileges
2874         https://bugs.webkit.org/show_bug.cgi?id=149519
2875
2876         Reviewed by Darin Adler.
2877
2878         * Scripts/validate-committer-lists:
2879         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2880         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2881         (BugzillaQueries.is_invalid_bugzilla_email):
2882         (BugzillaQueries): Deleted.
2883         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2884
2885 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2886
2887         Unreviewed. Gardening: skip media stream tests failing after r190262.
2888
2889         * Scripts/run-gtk-tests:
2890         (TestRunner):
2891
2892 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2893
2894         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2895         https://bugs.webkit.org/show_bug.cgi?id=149571
2896
2897         Reviewed by Dan Bernstein.
2898
2899         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
2900
2901         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2902         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2903         * LayoutTestRelay/Configurations/Base.xcconfig:
2904         * MiniBrowser/Configurations/Base.xcconfig:
2905         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2906         * TestWebKitAPI/Configurations/Base.xcconfig:
2907         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2908         * WebEditingTester/Configurations/Base.xcconfig:
2909         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2910         * WebKitTestRunner/Configurations/Base.xcconfig:
2911         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2912         * WebKitTestRunner/iOS.xcconfig: Removed.
2913
2914 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
2915
2916         Clean up user media request internal API
2917         https://bugs.webkit.org/show_bug.cgi?id=149527
2918
2919         Reviewed by Tim Horton.
2920
2921         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2922         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2923
2924         * WebKitTestRunner/TestController.cpp:
2925         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2926
2927 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
2928
2929         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2930         https://bugs.webkit.org/show_bug.cgi?id=149577
2931
2932         Reviewed by Tim Horton.
2933         
2934         When calling testRunner.runUIScript() from a page load event, the script could run
2935         in the UI process before the current remote layer tree transaction had been handled
2936         there. This meant that runUIScript() could query state which was about to change.
2937         
2938         Fix by delaying the execution of the UI script until a layer tree transaction has
2939         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
2940
2941         * WebKitTestRunner/TestInvocation.cpp:
2942         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2943         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2944         * WebKitTestRunner/TestInvocation.h:
2945
2946 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2947
2948         [Mac] Media tests start to time out after a few days of bot uptime
2949         https://bugs.webkit.org/show_bug.cgi?id=149468
2950
2951         Reviewed by Darin Adler.
2952
2953         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
2954         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
2955         all temporary and cache files go to a custom location.
2956
2957         * Scripts/webkitpy/port/base.py:
2958         * Scripts/webkitpy/port/driver.py:
2959         * Scripts/webkitpy/port/mac.py:
2960         * Scripts/webkitpy/port/win.py:
2961         (WinPort._driver_tempdir_for_environment): Deleted unused function.
2962
2963 2015-09-25  Dan Bernstein  <mitz@apple.com>
2964
2965         Removed MiniBrowser.entitlements.
2966
2967         Rubber-stamped by Anders Carlsson.
2968
2969         The entitlements weren’t used anyway.
2970
2971         * MiniBrowser/MiniBrowser.entitlements: Removed.
2972         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2973
2974 2015-09-24  Daniel Bates  <dabates@apple.com>
2975
2976         Add WebKitSystemInterface for iOS 9.0
2977         https://bugs.webkit.org/show_bug.cgi?id=149550
2978
2979         Rubber-stamped by Alexey Proskuryakov.
2980
2981         * Scripts/copy-webkitlibraries-to-product-directory:
2982
2983 2015-09-24  Daniel Bates  <dabates@apple.com>
2984
2985         Support building for arbitrary architectures
2986         https://bugs.webkit.org/show_bug.cgi?id=149539
2987
2988         Reviewed by Alexey Proskuryakov.
2989
2990         Teach buildbot to pass the architectures associated with the builder to build-webkit
2991         when building on OS X and iOS. As a side effect of this change we now support building
2992         universal binaries when multiples architectures are specified.
2993
2994         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2995         (CompileWebKit.start):
2996
2997 2015-09-24  Daniel Bates  <dabates@apple.com>
2998
2999         Fix the build after <http://trac.webkit.org/changeset/190212>
3000         (http://trac.webkit.org/changeset/190212)
3001
3002         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
3003
3004         * BuildSlaveSupport/built-product-archive:
3005         (main):
3006
3007 2015-09-24  Daniel Bates  <dabates@apple.com>
3008
3009         Support running unit tests on iOS Simulator test bot
3010         https://bugs.webkit.org/show_bug.cgi?id=149536
3011
3012         Reviewed by Alexey Proskuryakov.
3013
3014         Implements support for running unit tests on a iOS test bot. At the time of writing,
3015         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
3016
3017         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3018         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
3019         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
3020
3021 2015-09-24  Daniel Bates  <dabates@apple.com>
3022
3023         Add support infrastructure for OpenSource iOS builders and testers
3024         https://bugs.webkit.org/show_bug.cgi?id=149534
3025
3026         Reviewed by Darin Adler.
3027
3028         Towards setting up OpenSource iOS build bots, teach buildbot and its support
3029         scripts about iOS.
3030
3031         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3032         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
3033         --ios-simulator or --device for a builder/tester whose full platform name begins with
3034         "ios-simulator" or "ios", respectively.
3035         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
3036         * BuildSlaveSupport/built-product-archive:
3037         (main): Pass the full platform name to determineWebKitBuildDirectory().
3038         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
3039         command line flag when building for iOS.
3040         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
3041         parameter fullPlatform. This parameter was originally added in r125066 to support the
3042         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
3043         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
3044         * BuildSlaveSupport/clean-build:
3045         (main): Call script webkit-build-directory with the appropriate command line flag when
3046         building for iOS.
3047         * BuildSlaveSupport/delete-stale-build-files:
3048         (main): Use the same logic for iOS as we do for Mac.
3049         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
3050         flag when building for iOS.
3051         * BuildSlaveSupport/test-result-archive:
3052         (archiveTestResults): Use the same logic for iOS as we do for Mac.
3053
3054 2015-09-24  Daniel Bates  <dabates@apple.com>
3055
3056         Remove Chromium-specific changes to script built-product-archive
3057         https://bugs.webkit.org/show_bug.cgi?id=149530
3058
3059         Rubber-stamped by Csaba Osztrogonác.
3060
3061         Reverts changes made in r113074 and r113067 to support Chromium testers. The
3062         Chromium code has long since been removed from the OpenSource WebKit Project.
3063
3064         * BuildSlaveSupport/built-product-archive:
3065         (createZipManually):
3066         (createZip):
3067         (archiveBuiltProduct):
3068
3069 2015-09-24  Dan Bernstein  <mitz@apple.com>
3070
3071         Build fix.
3072
3073         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3074
3075 2015-09-24  Mark Lam  <mark.lam@apple.com>
3076
3077         Unreviewed. Make Lucas Forschler a WebKit reviewer.
3078
3079         * Scripts/webkitpy/common/config/contributors.json:
3080
3081 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3082
3083         Unreviewed. Fix GObject DOM API breaks after r190120.
3084
3085         Bring back code removed in r169931 to handle documentation of
3086         deleted classes.
3087
3088         * gtk/webkitdom.py:
3089         (WebKitDOMDocGenerator):
3090         (WebKitDOMDocGenerator.write_deleted_classes):
3091         (WebKitDOMDocGenerator.generate):
3092         (write_deleted_classes):
3093         (WebKitDOMDocGeneratorSections._deleted_class):
3094         (WebKitDOMDocGeneratorSections._deleted_class.in):
3095         (WebKitDOMDocGeneratorSections.write_deleted_classes):
3096         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
3097
3098 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
3099
3100         [Cocoa] [Font Features] Implement font-variant-*
3101         https://bugs.webkit.org/show_bug.cgi?id=148413
3102
3103         Reviewed by Darin Adler.
3104
3105         Update test font to use "lnum" feature.
3106
3107         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3108         (Generator::appendGSUBTable):
3109
3110 2015-09-22  Andy Estes  <aestes@apple.com>
3111
3112         ContentFiltering.AllowDownloadAfterAddData is very flaky
3113         https://bugs.webkit.org/show_bug.cgi?id=148885
3114         <rdar://problem/22729563>
3115
3116         Reviewed by Alexey Proskuryakov.
3117
3118         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
3119         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
3120         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
3121
3122         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3123         (downloadTest):
3124
3125 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
3126
3127         Mavericks: Media tests start to time out after a few days of bot uptime
3128         https://bugs.webkit.org/show_bug.cgi?id=149468
3129
3130         Reviewed by Chris Dumez.
3131
3132         * Scripts/webkitpy/port/base.py:
3133         * Scripts/webkitpy/port/driver.py:
3134         * Scripts/webkitpy/port/mac.py:
3135
3136 2015-09-22  Nan Wang  <n_wang@apple.com>
3137
3138         Unreviewed, add myself to the committers list.
3139
3140         * Scripts/webkitpy/common/config/contributors.json:
3141
3142 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
3143
3144         Remove 'nullable' to fix older iOS builds.
3145
3146         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3147         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3148
3149 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
3150
3151         [Win] Show tiled drawing debug overlay on Windows
3152         https://bugs.webkit.org/show_bug.cgi?id=149426
3153
3154         Reviewed by Dean Jackson.
3155
3156         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
3157         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
3158         * MiniBrowser/win/Common.cpp:
3159         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
3160         flag if needed.
3161         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
3162
3163 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
3164
3165         [Win] Use command-line argument to launch in regular or High DPI mode.
3166         https://bugs.webkit.org/show_bug.cgi?id=149417
3167
3168         Reviewed by Dean Jackson.
3169
3170         * MiniBrowser/win/Common.cpp:
3171         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
3172         very start of execution, before the MiniBrowser.dll is loaded.
3173         * win/DLLLauncher/DLLLauncherMain.cpp:
3174         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
3175         present. On WinCairo, always use High DPI.
3176
3177 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3178
3179         32-bit Mac build fix attempt after r190065.
3180
3181         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3182
3183 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
3184
3185         [OS X] Update for Xcode 7.0 on Yosemite
3186         https://bugs.webkit.org/show_bug.cgi?id=149389
3187
3188         Reviewed by Dan Bernstein.
3189
3190         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3191         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3192         Removed unneeded declarations - conforming to a protocol is sufficient.
3193
3194         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3195         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3196         Changed the definitions to be compiled whenever the SDK requires it (so we will have
3197         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
3198
3199 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
3200
3201         Add the ability for tests to run script in the UI process in WebKitTestRunner
3202         https://bugs.webkit.org/show_bug.cgi?id=149356
3203
3204         Reviewed by Tim Horton.
3205
3206         This change adds testRunner.runUIScript(script, callback), which allows a test
3207         to execute script in a JSContext which runs in the UI process. That context
3208         has bindings exposed through the UIScriptController interface; currently one test
3209         function, and some iOS-specific functions are included. UIScriptController can be
3210         async with a callback, and runUIScript() itself is asynchronous. When the UI 
3211         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
3212         is a string passed back to the web process, and given to the runUIScript()
3213         callback function.
3214         
3215         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
3216
3217         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
3218         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
3219         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3220         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
3221         complete, call back into TestRunner.
3222         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3223         (WTR::nextUIScriptCallbackID):
3224         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
3225         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
3226         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3227         * WebKitTestRunner/PlatformWebView.h:
3228         * WebKitTestRunner/TestController.cpp:
3229         (WTR::updateTestOptionsFromTestHeader):
3230         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
3231         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
3232         * WebKitTestRunner/TestInvocation.cpp:
3233         (WTR::TestInvocation::shouldUseFixedLayout):
3234         (WTR::TestInvocation::shouldUseThreadedScrolling):
3235         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3236         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3237         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
3238         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
3239         * WebKitTestRunner/TestInvocation.h:
3240         * WebKitTestRunner/TestOptions.h:
3241         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3242         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3243         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3244         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
3245         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3246         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
3247         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3248         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
3249         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3250         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
3251         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
3252         (WTR::UIScriptController::doAsyncTask):
3253         (WTR::UIScriptController::zoomToScale):
3254         (WTR::UIScriptController::zoomScale):
3255         (WTR::UIScriptController::minimumZoomScale):
3256         (WTR::UIScriptController::maximumZoomScale):
3257         (WTR::UIScriptController::contentVisibleRect):
3258         * WebKitTestRunner/mac/EventSenderProxy.mm:
3259         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3260         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
3261         * WebKitTestRunner/mac/TestControllerMac.mm:
3262         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3263         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
3264         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3265         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
3266         (UIScriptContext::UIScriptContext):
3267         (UIScriptContext::~UIScriptContext):
3268         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
3269         asynchronous, call the callback.
3270         (UIScriptContext::nextTaskCallbackID):
3271         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
3272         that has a callback). Has to store the callbackID of the script, so code called from the completion
3273         callback knows which UI script invoked it.
3274         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
3275         (UIScriptContext::uiScriptComplete):
3276         (UIScriptContext::objectFromRect): Make a JS object from a rect.
3277         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3278         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
3279         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
3280         (WTR::UIScriptController::UIScriptController):
3281         (WTR::UIScriptController::makeWindowObject):
3282         (WTR::UIScriptController::wrapperClass):
3283         (WTR::UIScriptController::doAsyncTask):
3284         (WTR::UIScriptController::zoomToScale):
3285         (WTR::UIScriptController::zoomScale):
3286         (WTR::UIScriptController::minimumZoomScale):
3287         (WTR::UIScriptController::maximumZoomScale):
3288         (WTR::UIScriptController::contentVisibleRect):
3289         (WTR::UIScriptController::uiScriptComplete):
3290         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3291         (WTR::UIScriptController::create):
3292         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
3293
3294 2015-09-21  Tim Horton  <timothy_horton@apple.com>
3295
3296         Turn on threaded scrolling by default in the tests
3297         https://bugs.webkit.org/show_bug.cgi?id=149377
3298
3299         Reviewed by Simon Fraser.
3300
3301         * WebKitTestRunner/mac/TestControllerMac.mm:
3302         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3303         (WTR::shouldUseThreadedScrolling): Deleted.
3304         Turn on threaded scrolling by default.
3305
3306 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3307
3308         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
3309         https://bugs.webkit.org/show_bug.cgi?id=149252
3310
3311         Reviewed by Darin Adler.
3312
3313         In case of glib tests the test runner notifies about tests
3314         crashing, but for google tests we don't get any feedback, which
3315         means that in case of a test crashing we get a list of **PASS**
3316         messages and at the summary we are notified that the test suite
3317         has failed, but it's impossible to know which test cases have failed.
3318
3319         * Scripts/run-gtk-tests:
3320         (TestRunner._run_google_test): Add a **CRASH** message if test
3321         case crashed.
3322
3323 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3324
3325         WebKitTestRunner can leak user content script results between tests
3326         https://bugs.webkit.org/show_bug.cgi?id=149391
3327
3328         Reviewed by Sam Weinig.
3329
3330         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
3331         about:blank, and thus about:blank doesn't have unintended side effects.
3332
3333         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3334         (WTR::InjectedBundle::beginTesting):
3335         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3336         (WTR::InjectedBundlePage::resetAfterTest):
3337
3338 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3339
3340         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
3341         https://bugs.webkit.org/show_bug.cgi?id=149384
3342
3343         Reviewed by Chris Fleizach.
3344
3345         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3346         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
3347         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
3348         regardless of whether someone else holds a reference (we also call -stopListening in
3349         -dealloc).
3350
3351         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3352         (AccessibilityController::platformResetToConsistentState):
3353         (AccessibilityController::addNotificationListener):
3354         Ditto.
3355
3356 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3357
3358         Remove XHR_TIMEOUT compilation guard
3359         https://bugs.webkit.org/show_bug.cgi?id=149260
3360
3361         Reviewed by Benjamin Poulain.
3362
3363         * Scripts/webkitperl/FeatureList.pm:
3364
3365 2015-09-19  Dan Bernstein  <mitz@apple.com>
3366
3367         Attempted build fix.
3368
3369         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3370
3371 2015-09-18  Commit Queue  <commit-queue@webkit.org>
3372
3373         Unreviewed, rolling out r189908.
3374         https://bugs.webkit.org/show_bug.cgi?id=149368
3375
3376         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
3377
3378         Reverted changeset:
3379
3380         "printing does not use minimum page zoom factor"
3381         https://bugs.webkit.org/show_bug.cgi?id=108507
3382         http://trac.webkit.org/changeset/189908
3383
3384 2015-09-18  Andy Estes  <aestes@apple.com>
3385
3386         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
3387         https://bugs.webkit.org/show_bug.cgi?id=149360
3388
3389         Reviewed by Tim Horton.
3390
3391         Added an API test.
3392
3393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3394         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
3395         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3396         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3397         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
3398         (TEST):
3399         * TestWebKitAPI/ios/pages.pages: Added.
3400
3401 2015-09-18  Nan Wang  <n_wang@apple.com>
3402
3403         AX: Implement ARIA 1.1 @aria-current on iOS
3404         https://bugs.webkit.org/show_bug.cgi?id=149297
3405
3406         Reviewed by Chris Fleizach.
3407
3408         Added support to test aria-current on iOS.
3409
3410         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3411         (AccessibilityUIElement::stringAttributeValue):
3412         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3413         (WTR::AccessibilityUIElement::stringAttributeValue):
3414
3415 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
3416
3417         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
3418         https://bugs.webkit.org/show_bug.cgi?id=149352
3419
3420         Reviewed by Simon Fraser.
3421
3422         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
3423         m_context can be null. This may indicate a bug in webkitpy too, but
3424         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
3425         wrong with opening and immediately closing it.
3426
3427 2015-09-18  Daniel Bates  <dabates@apple.com>
3428
3429         isGitSVNDirectory() returns true when Git is not installed
3430         https://bugs.webkit.org/show_bug.cgi?id=149351
3431
3432         Reviewed by Alexey Proskuryakov.
3433
3434         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
3435         Git is not installed on the machine.
3436
3437         * Scripts/VCSUtils.pm:
3438         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
3439         status code 0 (success).
3440
3441 2015-09-18  Alex Christensen  <achristensen@webkit.org>
3442
3443         Prevent build-webkit from building four times on Windows 
3444         https://bugs.webkit.org/show_bug.cgi?id=149336
3445
3446         Reviewed by Brent Fulgham.
3447
3448         * Scripts/build-webkit:
3449         Move the Windows code out of the for loop iterating over each subdirectory to be build.
3450         They're built all at once.
3451         * Scripts/webkitdirs.pm:
3452         (buildVisualStudioProject):
3453         (cmakeGeneratedBuildfile):
3454         Don't generate the Visual Studio solution if it already exists.
3455         It will run CMake again if necessary.
3456
3457 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3458
3459         [iOS WK2] WTR fails to set the key window in the UIKit sense
3460         https://bugs.webkit.org/show_bug.cgi?id=149325
3461
3462         Reviewed by Tim Horton.
3463
3464         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
3465         This causes UIKit to bypass code that actually sets the key window, resulting in
3466         [UIAppliation sharedApplication].keyWindow always being nil.
3467
3468         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
3469         -[WebKitTestRunnerWindow isKeyWindow] call super.
3470
3471         * WebKitTestRunner/PlatformWebView.h:
3472         (WTR::PlatformWebView::setWindowIsKey): Deleted.
3473         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3474         (WTR::PlatformWebView::setWindowIsKey):
3475         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3476         (WTR::PlatformWebView::setWindowIsKey):
3477         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3478         (-[WebKitTestRunnerWindow isKeyWindow]):
3479         (WTR::PlatformWebView::PlatformWebView):
3480         (WTR::PlatformWebView::~PlatformWebView):
3481         (WTR::PlatformWebView::setWindowIsKey):
3482         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3483         (WTR::PlatformWebView::setWindowIsKey):
3484
3485 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3486
3487         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
3488         https://bugs.webkit.org/show_bug.cgi?id=149321
3489
3490         Reviewed by Tim Horton.
3491         
3492         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
3493         enabled the "testing" viewport configuration, which disables page scaling.
3494         
3495         If we're running viewport tests, we want the normal web page configuration.
3496         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
3497         based on whether the test is in a "viewport" directory.
3498
3499         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3500         (WTR::InjectedBundle::beginTesting):
3501         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3502         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
3503         * WebKitTestRunner/TestInvocation.cpp:
3504         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3505         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3506         (WTR::TestInvocation::shouldMakeViewportFlexible):
3507         (WTR::TestInvocation::invoke):
3508         * WebKitTestRunner/TestInvocation.h:
3509         * WebKitTestRunner/ios/TestControllerIOS.mm:
3510         (WTR::TestController::platformConfigureViewForTest):
3511         (WTR::shouldMakeViewportFlexible): Deleted.
3512
3513 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3514
3515         Give iOS WebKitTestRunner a launch storyboard
3516         https://bugs.webkit.org/show_bug.cgi?id=149314
3517
3518         Reviewed by Dan Bates.
3519         
3520         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
3521         that it's been built for specific device configurations, and puts the window
3522         at the top of the screen. This simplifies coordinate conversions in a future patch.
3523
3524         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3525         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
3526         * WebKitTestRunner/ios/Launch.storyboard: Added.
3527
3528 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
3529
3530         Update licence in r189890
3531         https://bugs.webkit.org/show_bug.cgi?id=149306
3532
3533         Reviewed by Dean Jackson.
3534
3535         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3536         * FontWithFeatures/FontWithFeatures/FontCreator.h:
3537         * FontWithFeatures/FontWithFeatures/main.cpp:
3538
3539 2015-09-17  Mark Lam  <mark.lam@apple.com>
3540
3541         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
3542         https://bugs.webkit.org/show_bug.cgi?id=149285
3543
3544         Reviewed by Saam Barati.
3545
3546         Just need to add an option to pass --no-jit to run-jsc-stress-test.
3547
3548         * Scripts/run-javascriptcore-tests:
3549         (runJSCStressTests):
3550
3551 2015-09-17  Alex Christensen  <achristensen@webkit.org>
3552
3553         Switch AppleWin build to use CMake
3554         https://bugs.webkit.org/show_bug.cgi?id=149163
3555
3556         Reviewed by Brent Fulgham.
3557
3558         * Scripts/build-webkit:
3559         * Scripts/run-api-tests:
3560         (runTest):
3561         (listAllTests):
3562         (prepareEnvironmentForRunningTestTool):
3563         (testToolPaths):
3564         (testToolPath): Deleted.
3565         Run the API tests as separate executables on Windows.
3566         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3567         * Scripts/webkitdirs.pm:
3568         (checkRequiredSystemConfig):
3569         (jhbuildWrapperPrefixIfNeeded):
3570         (generateBuildSystemFromCMakeProject):
3571         Fix configuration quirks.
3572
3573 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
3574
3575         Added toggle options for hiding and showing certain platform families on the dashboard.
3576         https://bugs.webkit.org/show_bug.cgi?id=148403
3577
3578         Reviewed by David Kilzer.
3579
3580         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
3581         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
3582         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
3583         in lieu of an "all" button in the toggle menu.
3584
3585         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3586         (parsePlatformFamily): Helper function to parse out a platform family.
3587         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
3588         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
3589         (updateToggleButtons): Updates the status of the toggle buttons.
3590         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
3591         (documentReady): Added creation of toggle buttons.
3592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3593         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
3594         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
3595         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
3596         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
3597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3598         (QueueView): Updated to use hiddenPlatformFamilies.
3599         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
3600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3601         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
3602         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
3603         (Settings.prototype.toggleHiddenPlatform): Deleted.
3604         (Settings.prototype.clearHiddenPlatforms): Deleted.
3605         (Settings.prototype.toggleShowPlatformFamily): Deleted.
3606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3607         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
3608         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
3609         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
3610         (table.queue-grid tr.headers th):
3611         (div.settingsWrapper.hide):
3612         (div.settingsWrapper):
3613         (div.familyToggleWrapper):
3614         (div.platformFamilyToggleButton):
3615         (div.platformFamilyShowToggleButton:not(:last-child)):
3616         (div.familyShown):
3617         (div.accessibilityButton):
3618         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
3619         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
3620         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
3621         platformFamilyToggleButton and settingsWrapper class.
3622         (.accessibilityButton): Deleted.
3623
3624 2015-09-17  Tim Horton  <timothy_horton@apple.com>
3625
3626         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
3627         https://bugs.webkit.org/show_bug.cgi?id=148904
3628
3629         Reviewed by Myles Maxfield.
3630
3631         * WebKitTestRunner/TestController.cpp:
3632         (WTR::parseBooleanTestHeaderValue):
3633         (WTR::updateViewOptionsFromTestHeader):
3634         Check for the key "useThreadedScrolling".
3635         Add some code to check for "true" and "false" for boolean options.
3636
3637         (WTR::TestController::viewOptionsForTest):
3638         Apply the test's overrides last, even after the platform's.
3639
3640 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3641
3642         printing does not use minimum page zoom factor
3643         https://bugs.webkit.org/show_bug.cgi?id=108507
3644
3645         Reviewed by Darin Adler.
3646
3647         WebKitTestRunner always takes the snapshots from the UI process
3648         (expect for IOS), so in the case of printing, the layout in the
3649         web view is not the expected one. When printing, we need to take
3650         the snapshot in the web process and ensure it's rendered with a
3651         PrintContext.
3652
3653         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3654         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
3655         kWKSnapshotOptionsPrinting option to
3656         WKBundlePageCreateSnapshotWithOptions() when printing. When not
3657         printing, don't even create the snapshot, since it will be ignored
3658         by the UI process that always creates its own from the WebView (expect for IOS platform)
3659         * WebKitTestRunner/TestInvocation.cpp:
3660         (WTR::TestInvocation::dumpResults): Use always the snapshot image
3661         received from the web process if any when comparing pixel
3662         results. Now we only receive a snapshot from the web process in
3663         case of printing, or when platform is IOS. Otherwhise, generate
3664         the snapshot from the WebView as usual.
3665         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
3666         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
3667         is created by the caller now, but the CG implementation needs to
3668         know if it's a Web or UI process snapshot.
3669         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3670         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3671         cairo surface for the given image.
3672         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3673         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3674         CGContext for the given image.
3675
3676 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
3677
3678         Create a font which can be used for testing font features
3679         https://bugs.webkit.org/show_bug.cgi?id=149237
3680
3681         Reviewed by Simon Fraser.
3682
3683         This patch adds a new project in the Tools/ directory which generates a font which can
3684         be used for testing font features. This is a standalone project consisting of two files:
3685         1. A file which actually generates the byte vector representing the font. This file has
3686         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
3687         specific, and only relies on the C++ STL.
3688         2. A file with a main() which calls generateFont() and writes out the font, as well as
3689         uses the font to render some demonstration text into a .png file. This file is platform
3690         specific.
3691
3692         The font itself only supports the following characters:
3693         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
3694         However, the shape of these letters are either an X or a check mark.
3695
3696         The letter "A" always is a check mark.
3697         The letter "B" always is an X.
3698         Without any font features turned on, the rest of the letters are shown as X.
3699
3700         Each font feature has an letter associated with it. When the font feature is enabled,
3701         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
3702         as a check mark.
3703
3704         Here are the mappings of font features to letters:
3705         liga: C
3706         clig: D
3707         dlig: E
3708         hlig: F
3709         calt: G
3710         subs: H
3711         sups: I
3712         smcp: J
3713         c2sc: K
3714         pcap: L
3715         c2pc: M
3716         unic: N
3717         titl: O
3718         onum: P
3719         pnum: Q
3720         tnum: R
3721         frac: S
3722         afrc: T
3723         ordn: U
3724         zero: V
3725         hist: W
3726         jp78: X
3727         jp83: Y
3728         jp90: Z
3729         jp04: a
3730         smpl: b
3731         trad: c
3732         fwid: d
3733         pwid: e
3734         ruby: f
3735
3736         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
3737         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
3738         (integralLog2):
3739         (roundDownToPowerOfTwo):
3740         (isFourByteAligned):
3741         (clampTo):
3742         (append32):
3743         (writeCFFEncodedNumber):
3744         (CFFBuilder::CFFBuilder):
3745         (CFFBuilder::takeResult):
3746         (CFFBuilder::moveTo):
3747         (CFFBuilder::lineTo):
3748         (CFFBuilder::curveToCubic):
3749         (CFFBuilder::closePath):
3750         (CFFBuilder::writePoint):
3751         (generateBoxCharString):
3752         (generateCheckCharString):
3753         (generateXCharString):
3754         (charStringForGlyph):
3755         (Generator::generate):
3756         (Generator::Placeholder::Placeholder):
3757         (Generator::Placeholder::populate):
3758         (Generator::Placeholder::~Placeholder):
3759         (Generator::placeholder):
3760         (Generator::append16):
3761         (Generator::append32):
3762         (Generator::append32BitCode):
3763         (Generator::overwrite16):
3764         (Generator::overwrite32):
3765         (Generator::appendCFFTable):
3766         (Generator::appendSubstitutionSubtable):
3767         (Generator::appendScriptSubtable):
3768         (Generator::appendGSUBTable):
3769         (Generator::appendOS2Table):
3770         (Generator::appendFormat12CMAPTable):
3771         (Generator::appendFormat4CMAPTable):
3772         (Generator::appendCMAPTable):
3773         (Generator::appendHEADTable):
3774         (Generator::appendHHEATable):
3775         (Generator::appendHMTXTable):
3776         (Generator::appendMAXPTable):
3777         (Generator::appendNAMETable):
3778         (Generator::appendPOSTTable):
3779         (Generator::calculateChecksum):
3780         (Generator::appendTable):
3781         (generateFont):
3782         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
3783         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
3784         (drawTextWithFeature):
3785         (main):
3786
3787 2015-09-16  Commit Queue  <commit-queue@webkit.org>
3788
3789         Unreviewed, rolling out r189875 and r189878.
3790         https://bugs.webkit.org/show_bug.cgi?id=149235
3791
3792         cygwin cmake build not ready yet (Requested by alexchristensen
3793         on #webkit).
3794
3795         Reverted changesets:
3796
3797         "Switch AppleWin build to use CMake"
3798         https://bugs.webkit.org/show_bug.cgi?id=149163
3799         http://trac.webkit.org/changeset/189875
3800
3801         "Cygwin build fix after r189875"
3802         http://trac.webkit.org/changeset/189878
3803
3804 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3805
3806         Cygwin build fix after r189875
3807
3808         * Scripts/build-webkit:
3809         * Scripts/webkitdirs.pm:
3810         (jhbuildWrapperPrefixIfNeeded):
3811         (generateBuildSystemFromCMakeProject):
3812         Make things work with cygwin and cmake.
3813
3814 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3815
3816         Switch AppleWin build to use CMake
3817         https://bugs.webkit.org/show_bug.cgi?id=149163
3818
3819         Reviewed by Brent Fulgham.
3820
3821         * Scripts/build-webkit:
3822         Build with CMake.
3823         * Scripts/run-api-tests:
3824         (runTest):
3825         (listAllTests):
3826         (prepareEnvironmentForRunningTestTool):
3827         (testToolPaths):
3828         (testToolPath): Deleted.
3829         Run the API tests as separate executables on Windows.
3830         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3831
3832 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
3833
3834         Add newer build.webkit.org pages to robots.txt
3835         https://bugs.webkit.org/show_bug.cgi?id=149219
3836
3837         Reviewed by Darin Adler.
3838
3839         Indexing bot watcher's dashboard can't be good.
3840
3841         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
3842
3843 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3844
3845         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
3846
3847         * BuildSlaveSupport/built-product-archive:
3848         (unzipArchive):
3849
3850 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3851
3852         [EFL] Fix the help message of separated web process option of MiniBrowser
3853         https://bugs.webkit.org/show_bug.cgi?id=149212
3854
3855         Reviewed by Gyuyoung Kim.
3856
3857         * MiniBrowser/efl/main.c:
3858
3859 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3860
3861         Fix python syntax after r189851.
3862
3863         * BuildSlaveSupport/built-product-archive:
3864         (unzipArchive):
3865         For loops need a colon.
3866
3867 2015-09-15  Alex Christensen  <achristensen@webkit.org>
3868
3869         Fix Windows test bots after changing to non-cygwin build
3870         https://bugs.webkit.org/show_bug.cgi?id=149196
3871
3872         Reviewed by Daniel Bates.
3873
3874         * BuildSlaveSupport/built-product-archive:
3875         (unzipArchive):
3876         Using different versions of python makes what I think is https://bugs.python.org/issue15795
3877         prevent us from executing files from the archive on the test bots.
3878
3879 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
3880
3881         Add ShadowRoot interface and Element.prototype.attachShadow
3882         https://bugs.webkit.org/show_bug.cgi?id=149187
3883
3884         Reviewed by Antti Koivisto.
3885
3886         * Scripts/webkitperl/FeatureList.pm:
3887
3888 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
3889
3890         Appscale queue status json output lacks bots
3891         https://bugs.webkit.org/show_bug.cgi?id=149194
3892         <rdar://problem/22171089>
3893
3894         Reviewed by Alexey Proskuryakov.
3895
3896         * QueueStatusServer/handlers/queuestatusjson.py:
3897         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
3898         * QueueStatusServer/index.yaml: Index according to appscale requirements.
3899
3900 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
3901
3902         [Win] Provide a means for viewing the layer tree
3903         https://bugs.webkit.org/show_bug.cgi?id=149165
3904
3905         Reviewed by Simon Fraser.
3906
3907         Update MiniBrowser with a new Debug menu option that will
3908         dump the current layer tree to the debug console.
3909         
3910         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
3911         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
3912         * MiniBrowser/win/Common.cpp:
3913         (WndProc): Add handler for 'Print Layer Tree' menu option.
3914         * MiniBrowser/win/MiniBrowser.cpp:
3915         (MiniBrowser::printLayerTree): Added Handler.
3916         * MiniBrowser/win/MiniBrowser.h:
3917
3918 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
3919
3920         WebKitTestRunner declarative language setting is broken for iOS
3921         https://bugs.webkit.org/show_bug.cgi?id=149119
3922
3923         Unreviewed.
3924
3925         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
3926         lost in the final version which got committed. This simply implements the existing
3927         OS X behavior on iOS.
3928
3929         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3930         (WTR::InjectedBundle::platformInitialize):
3931
3932 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
3933
3934         Unreviewed, add myself to committers list.
3935
3936         * Scripts/webkitpy/common/config/contributors.json:
3937
3938 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
3939
3940         [Cocoa] Allow testing with the system language
3941         https://bugs.webkit.org/show_bug.cgi?id=148671
3942
3943         Reviewed by Anders Carlsson and Alexey Proskuryakov.
3944
3945         React to tests marked with language=lang1,lang2,etc in their header.
3946         Once this information is parsed, pass it to
3947         WKContextConfigurationSetOverrideLanguages().
3948
3949         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3950         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
3951         list.
3952         * WebKitTestRunner/TestController.cpp:
3953         (WTR::TestController::createWebViewWithOptions): Call
3954         WKContextConfigurationSetOverrideLanguages().
3955         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
3956         * WebKitTestRunner/TestOptions.h:
3957         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3958         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
3959         option to restart the web process.
3960         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3961         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
3962
3963 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
3964
3965         [WKTR] Allow changing the WKContextConfiguration between successive tests
3966         https://bugs.webkit.org/show_bug.cgi?id=148833
3967
3968         Reviewed by Tim Horton.
3969
3970         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3971         However, there are certain tests which require specifying options in this object. This patch makes
3972         our existing code for recreating the test runner web view also recreate the WKContext.
3973
3974         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3975         class.
3976
3977         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3978         * WebKitTestRunner/PlatformWebView.h:
3979         (WTR::PlatformWebView::options):
3980         * WebKitTestRunner/TestController.cpp:
3981         (WTR::TestController::initialize):
3982         (WTR::TestController::generateContextConfiguration):
3983         (WTR::TestController::generatePageConfiguration):
3984         (WTR::TestController::createWebViewWithOptions):
3985         (WTR::TestController::ensureViewSupportsOptionsForTest):
3986         (WTR::updateContextConfigurationOptionsFromTestHeader):
3987         (WTR::TestController::contextConfigurationOptionsForTest):
3988         (WTR::TestController::platformCreateWebView):
3989         (WTR::TestController::platformCreateOtherPage):
3990         (WTR::updateViewOptionsFromTestHeader): Deleted.
3991         (WTR::TestController::viewOptionsForTest): Deleted.
3992         * WebKitTestRunner/TestController.h:
3993         (WTR::TestController::injectedBundlePath):
3994         (WTR::TestController::testPluginDirectory):
3995         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3996         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3997         (WTR::TestController::platformCreateWebView):
3998         (WTR::TestController::platformCreateOtherPage):
3999         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4000         (WTR::PlatformWebView::PlatformWebView):
4001         (WTR::PlatformWebView::viewSupportsOptions):
4002         * WebKitTestRunner/efl/TestControllerEfl.cpp:
4003         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
4004         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
4005         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4006         (WTR::PlatformWebView::PlatformWebView):
4007         (WTR::PlatformWebView::viewSupportsOptions):
4008         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4009         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
4010         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
4011         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4012         (WTR::PlatformWebView::PlatformWebView):
4013         (WTR::PlatformWebView::viewSupportsOptions):
4014         * WebKitTestRunner/ios/TestControllerIOS.mm:
4015         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
4016         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
4017         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4018         (WTR::PlatformWebView::PlatformWebView):
4019         (WTR::PlatformWebView::viewSupportsOptions):
4020         * WebKitTestRunner/mac/TestControllerMac.mm:
4021         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
4022         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
4023
4024 2015-09-11  Michael Saboff  <msaboff@apple.com>
4025
4026         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
4027         https://bugs.webkit.org/show_bug.cgi?id=149083
4028
4029         Reviewed by Alexey Proskuryakov.
4030
4031         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
4032
4033         * DumpRenderTree/mac/LayoutTestHelper.m:
4034         (colorProfileURLForDisplay):
4035
4036 2015-09-11  Saam barati  <sbarati@apple.com>
4037
4038         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
4039         https://bugs.webkit.org/show_bug.cgi?id=149058
4040
4041         Reviewed by Geoffrey Garen.
4042
4043         * Scripts/run-jsc-stress-tests:
4044
4045 2015-09-10  Commit Queue  <commit-queue@webkit.org>
4046
4047         Unreviewed, rolling out r189595.
4048         https://bugs.webkit.org/show_bug.cgi?id=149052
4049
4050         The tests still fail (Requested by ap on #webkit).
4051
4052         Reverted changeset:
4053
4054         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
4055         error -1"
4056         https://bugs.webkit.org/show_bug.cgi?id=142929
4057         http://trac.webkit.org/changeset/189595
4058
4059 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
4060
4061         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
4062         https://bugs.webkit.org/show_bug.cgi?id=142929
4063
4064         Reviewed by Brent Fulgham.
4065
4066         Silence the logging. We'll track fixing the root cause in Radar.
4067
4068         * Scripts/webkitpy/port/mac.py:
4069         (MacPort.stderr_patterns_to_strip): Added a FIXME.
4070
4071         * Scripts/webkitpy/port/win.py:
4072         (WinPort.logging_patterns_to_strip): Added.
4073
4074 2015-09-09  Andy Estes  <aestes@apple.com>
4075
4076         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
4077         https://bugs.webkit.org/show_bug.cgi?id=149022
4078
4079         Reviewed by Daniel Bates.
4080
4081         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
4082         did not account for this.
4083
4084         * Scripts/webkitpy/xcode/simulator.py:
4085         (Simulator): Optionally matched a revision at the end of a runtime version number.
4086         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
4087
4088 2015-09-09  Andy Estes  <aestes@apple.com>
4089
4090         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
4091         https://bugs.webkit.org/show_bug.cgi?id=149029
4092         <rdar://problem/22432624>
4093
4094         Reviewed by Daniel Bates.
4095
4096         * Scripts/webkitpy/xcode/simulator.py:
4097         (Simulator): Taught to parse tvOS runtimes.
4098         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
4099
4100 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
4101
4102         Fix bit rot on bot watcher's dashboard page
4103         https://bugs.webkit.org/show_bug.cgi?id=149012
4104
4105         Reviewed by Tim Horton.
4106
4107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4108         The code path used by the metrics page was trying to add properties to an undefined.
4109
4110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
4111         Silence an expection that would occur when the step has no logs. This should never
4112         happen, but it did (perhaps buildbot was misconfigured for a while).
4113
4114 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
4115
4116         Update LayoutTestRelay xcconfig file.
4117
4118         Rubber-stamped by Dan Bernstein.
4119
4120         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
4121
4122 2015-09-09  Saam barati  <sbarati@apple.com>
4123
4124         DFG should have a debugging option that runs a phase that flushes all locals
4125         https://bugs.webkit.org/show_bug.cgi?id=148916
4126
4127         Reviewed by Filip Pizlo.
4128
4129         * Scripts/run-jsc-stress-tests:
4130
4131 2015-09-09  Commit Queue  <commit-queue@webkit.org>
4132
4133         Unreviewed, rolling out r189530 and r189534.
4134         https://bugs.webkit.org/show_bug.cgi?id=148996
4135
4136         Caused assertion failures on Yosemite (Requested by litherum
4137         on #webkit).
4138
4139         Reverted changesets:
4140
4141         "[WKTR] Allow changing the WKContextConfiguration between
4142         successive tests"
4143         https://bugs.webkit.org/show_bug.cgi?id=148833
4144         http://trac.webkit.org/changeset/189530
4145
4146         "[Cocoa] Fix the tests after r189530"
4147         http://trac.webkit.org/changeset/189534
4148
4149 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
4150
4151         [Cocoa] Fix the tests after r189530
4152
4153         Unreviewed.
4154
4155         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4156         (WTR::initializeWebViewConfiguration):
4157
4158 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
4159
4160         [WKTR] Allow changing the WKContextConfiguration between successive tests
4161         https://bugs.webkit.org/show_bug.cgi?id=148833
4162
4163         Reviewed by Tim Horton.
4164
4165         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
4166         However, there are certain tests which require specifying options in this object. This patch makes
4167         our existing code for recreating the test runner web view also recreate the WKContext.
4168
4169         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
4170         class.
4171
4172         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
4173         * WebKitTestRunner/PlatformWebView.h:
4174         (WTR::PlatformWebView::options):
4175         * WebKitTestRunner/TestController.cpp:
4176         (WTR::TestController::initialize):
4177         (WTR::TestController::generateContextConfiguration):
4178         (WTR::TestController::generatePageConfiguration):
4179         (WTR::TestController::createWebViewWithOptions):
4180         (WTR::TestController::ensureViewSupportsOptionsForTest):
4181         (WTR::updateContextConfigurationOptionsFromTestHeader):
4182         (WTR::TestController::contextConfigurationOptionsForTest):
4183         (WTR::TestController::platformCreateWebView):
4184         (WTR::TestController::platformCreateOtherPage):
4185         (WTR::updateViewOptionsFromTestHeader): Deleted.
4186         (WTR::TestController::viewOptionsForTest): Deleted.
4187         * WebKitTestRunner/TestController.h:
4188         (WTR::TestController::injectedBundlePath):
4189         (WTR::TestController::testPluginDirectory):
4190         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4191         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4192         (WTR::TestController::platformCreateWebView):
4193         (WTR::TestController::platformCreateOtherPage):
4194         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4195         (WTR::PlatformWebView::PlatformWebView):
4196         (WTR::PlatformWebView::viewSupportsOptions):
4197         * WebKitTestRunner/efl/TestControllerEfl.cpp:
4198         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
4199         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
4200         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4201         (WTR::PlatformWebView::PlatformWebView):
4202         (WTR::PlatformWebView::viewSupportsOptions):
4203         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4204         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
4205         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
4206         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4207         (WTR::PlatformWebView::PlatformWebView):
4208         (WTR::PlatformWebView::viewSupportsOptions):
4209         * WebKitTestRunner/ios/TestControllerIOS.mm:
4210         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
4211         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
4212         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4213         (WTR::PlatformWebView::PlatformWebView):
4214         (WTR::PlatformWebView::viewSupportsOptions):
4215         * WebKitTestRunner/mac/TestControllerMac.mm:
4216         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
4217         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
4218
4219 2015-09-08  Daniel Bates  <dabates@apple.com>
4220
4221         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
4222         https://bugs.webkit.org/show_bug.cgi?id=148980
4223
4224         Reviewed by Alexey Proskuryakov.
4225
4226         Add setting to enable/disable accelerated drawing so as to support testing
4227         this feature in MiniBrowser on Mac.
4228
4229         * MiniBrowser/mac/SettingsController.h:
4230         * MiniBrowser/mac/SettingsController.m:
4231         (-[SettingsController _populateMenu]): Add menu item.
4232         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
4233         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
4234         (-[SettingsController acceleratedDrawingEnabled]): Added.
4235         * MiniBrowser/mac/WK1BrowserWindowController.m:
4236         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
4237         * MiniBrowser/mac/WK2BrowserWindowController.m:
4238         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
4239
4240 2015-09-08  Jason Marcell  <jmarcell@apple.com>
4241
4242         Unreviewed. Added myself as a commiter in contributors.json.
4243
4244         * Scripts/webkitpy/common/config/contributors.json:
4245
4246 2015-09-08  Keith Miller  <keith_miller@apple.com>
4247
4248         Unreviewed, added myself to the list of contributors.
4249
4250         * Scripts/webkitpy/common/config/contributors.json:
4251
4252 2015-09-08  Daniel Bates  <dabates@apple.com>
4253
4254         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
4255         https://bugs.webkit.org/show_bug.cgi?id=148921
4256
4257         Reviewed by Alexey Proskuryakov.
4258
4259         The ring image is positioned above the platform icon in markup and we specify the CSS
4260         property z-index for the ring image so that it is painted on top of the platform icon
4261         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
4262         of the ring image, switch the order of these DOM elements and remove the use of the CSS
4263         property z-index to achieve a similar effect.
4264
4265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
4266         (documentReady): Create the platform icon image element before the ring image such that
4267         the ring image is painted on top of the platform icon.
4268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4269         (table.queue-grid td.logo img.ring): Removed property z-index.
4270