Web Inspector: Disabling Inspector causes build failure on Windows
[WebKit-https.git] / Tools / ChangeLog
1 2012-04-18  Vivek Galatage  <vivekgalatage@gmail.com>
2
3         Web Inspector: Disabling Inspector causes build failure on Windows
4         https://bugs.webkit.org/show_bug.cgi?id=83557
5
6         Reviewed by Pavel Feldman.
7
8         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
9         This change brings all such API calls under the guard.
10
11         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
12         (WTR::LayoutTestController::showWebInspector):
13         (WTR::LayoutTestController::closeWebInspector):
14         (WTR::LayoutTestController::evaluateInWebInspector):
15         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
16         * WebKitTestRunner/TestInvocation.cpp:
17         (WTR::TestInvocation::invoke):
18
19 2012-04-18  Mario Sanchez Prada  <msanchez@igalia.com>
20
21         [GTK] atk/textChangedNotifications API test fails
22         https://bugs.webkit.org/show_bug.cgi?id=84010
23
24         Unreviewed, unskipping test after bug being fixed by r114311.
25
26         * Scripts/run-gtk-tests:
27         (TestRunner): Unskip now passing test.
28
29 2012-04-17  Jacky Jiang  <zhajiang@rim.com>
30
31         [BlackBerry] Viewport metatag doesn't disable double-tap zoom
32         https://bugs.webkit.org/show_bug.cgi?id=84199
33
34         Reviewed by George Staikos.
35
36         Revert a part of the change master_32/SHA:fa0f8ee9 and use
37         WebPage::setUserScalable instead.
38
39         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
40         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
41
42 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
43
44         build-webkit: make ninja work with chromium linux
45         https://bugs.webkit.org/show_bug.cgi?id=84213
46
47         Reviewed by Eric Seidel.
48
49         Fix typos so that build-webkit will use ninja to
50         build chromium if a build.ninja file exists and is up-to-date.
51
52         * Scripts/webkitdirs.pm:
53         (determineIsChromiumNinja):
54
55 2012-04-17  Ojan Vafai  <ojan@chromium.org>
56
57         Add caching to the flakiness dashboard json files
58         https://bugs.webkit.org/show_bug.cgi?id=84198
59
60         Reviewed by Dirk Pranke.
61
62         * TestResultServer/handlers/testfilehandler.py:
63         (GetFile._get_file_list):
64         (GetFile._get_file_content):
65         (GetFile._get_file_content_from_key):
66         (GetFile._get_test_list_json):
67         (GetFile._serve_json):
68         Add a Last-Modified header and handle If-Modified-Since headers.
69         (GetFile.get):
70
71 2012-04-17  Anders Carlsson  <andersca@apple.com>
72
73         Need a client callback for when the user tries to interact with an already unresponsive page
74         https://bugs.webkit.org/show_bug.cgi?id=84201
75         <rdar://problem/11140862>
76
77         Reviewed by Andreas Kling.
78
79         Add new client functions.
80
81         * MiniBrowser/mac/BrowserWindowController.m:
82         (-[BrowserWindowController awakeFromNib]):
83         * WebKitTestRunner/TestController.cpp:
84         (WTR::TestController::initialize):
85
86 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
87
88         nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
89         https://bugs.webkit.org/show_bug.cgi?id=84190
90
91         Reviewed by Ojan Vafai.
92
93         LayoutTestHelper would exit when the user typed ctrl-c, but we
94         would attempt to write to it to shut it down, generating an
95         IOError.
96
97         * Scripts/webkitpy/layout_tests/port/chromium.py:
98         (ChromiumPort.stop_helper):
99
100 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
101
102         rename --experimental-fully-parallel
103         https://bugs.webkit.org/show_bug.cgi?id=84188
104
105         Reviewed by Ojan Vafai.
106
107         I thought this was done long ago; rename
108         --experimental-fully-parallel to just --fully-parallel and
109         remove the --no- switch that AFAIK no one uses.
110
111         * Scripts/webkitpy/layout_tests/controllers/manager.py:
112         (Manager._run_tests):
113         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
114         (parse_args):
115
116 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
117
118         EFL's LayoutTestController does not implement callShouldCloseOnWebView
119         https://bugs.webkit.org/show_bug.cgi?id=82301
120
121         Reviewed by Martin Robinson.
122
123         Implement callShouldCloseOnWebView in EFL's LayoutTestController by
124         calling shouldClose() on the FrameLoader, allowing the related test
125         to be removed from the skip list.
126
127         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
128         (LayoutTestController::callShouldCloseOnWebView):
129
130 2012-04-17  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
131
132         [EFL] Add setting API to enable/disable XSSAuditor
133         https://bugs.webkit.org/show_bug.cgi?id=83281
134
135         Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
136         in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal 
137         'xss,detected' in DRT to enable a test, which is expecting a line containing
138         'didDetectXSS' in the output when reflected XSS is encountered in the page.
139
140         Reviewed by Antonio Gomes.
141
142         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
143         (DumpRenderTreeChrome::createView):
144         (DumpRenderTreeChrome::onFrameCreated):
145         (DumpRenderTreeChrome::onDidDetectXSS):
146         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
147         (DumpRenderTreeChrome):
148         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
149         (LayoutTestController::setXSSAuditorEnabled):
150
151 2012-04-17  Nandor Huszka  <hnandor@inf.u-szeged.hu>
152
153         [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
154         https://bugs.webkit.org/show_bug.cgi?id=77533
155
156         Reviewed by Simon Hausmann.
157
158         Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
159         the corresponding parameter to the buildQMakeProjects function.
160
161         * Scripts/build-jsc:
162
163 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
164
165         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
166         https://bugs.webkit.org/show_bug.cgi?id=83030
167
168         Reviewed by Antonio Gomes.
169
170         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
171         in EFL's DumpRenderTree. Make use of the new frame argument passed to
172         the "load,started" and "load,finished" signals.
173
174         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
175         (DumpRenderTreeChrome::createView):
176         (DumpRenderTreeChrome::onLoadStarted):
177         (DumpRenderTreeChrome::processWork):
178         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
179         (DumpRenderTreeChrome::onWebViewOnloadEvent):
180         (DumpRenderTreeChrome::onInsecureContentRun):
181         (DumpRenderTreeChrome::onInsecureContentDisplayed):
182         (DumpRenderTreeChrome::onFrameCreated):
183         (DumpRenderTreeChrome::onFrameProvisionalLoad):
184         (DumpRenderTreeChrome::onFrameLoadCommitted):
185         (DumpRenderTreeChrome::onFrameLoadFinished):
186         (DumpRenderTreeChrome::onFrameLoadError):
187         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
188         (DumpRenderTreeChrome):
189
190 2012-04-17  Sheriff Bot  <webkit.review.bot@gmail.com>
191
192         Unreviewed, rolling out r114376.
193         http://trac.webkit.org/changeset/114376
194         https://bugs.webkit.org/show_bug.cgi?id=84155
195
196         Wrong patch version committed, asked by the patch author.
197         (Requested by rakuco on #webkit).
198
199         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
200         (DumpRenderTreeChrome::createView):
201         (DumpRenderTreeChrome::processWork):
202         (DumpRenderTreeChrome::onLoadFinished):
203         (DumpRenderTreeChrome::onWillSendRequest):
204         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
205         (DumpRenderTreeChrome):
206
207 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
208
209         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
210         https://bugs.webkit.org/show_bug.cgi?id=83030
211
212         Reviewed by Antonio Gomes.
213
214         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
215         in EFL's DumpRenderTree.
216
217         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
218         (DumpRenderTreeChrome::createView):
219         (DumpRenderTreeChrome::processWork):
220         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
221         (DumpRenderTreeChrome::onWebViewOnloadEvent):
222         (DumpRenderTreeChrome::onInsecureContentRun):
223         (DumpRenderTreeChrome::onInsecureContentDisplayed):
224         (DumpRenderTreeChrome::onFrameCreated):
225         (DumpRenderTreeChrome::onFrameProvisionalLoad):
226         (DumpRenderTreeChrome::onFrameLoadCommitted):
227         (DumpRenderTreeChrome::onFrameLoadFinished):
228         (DumpRenderTreeChrome::onFrameLoadError):
229         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
230         (DumpRenderTreeChrome):
231
232 2012-04-17  Michael Brüning  <michael.bruning@nokia.com>
233
234         [Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
235         https://bugs.webkit.org/show_bug.cgi?id=83035
236
237         Reviewed by Simon Hausmann.
238
239         The force_static_libs_as_shared feature for the Qt port will remove
240         hide_symbols from Qt's CONFIG in order to make them visible to other
241         libraries again.
242
243         Due to an evaluation order problem in qmake, the flags for the C++ compiler
244         that are set by adding hide_symbols to the CONFIG variables get applied
245         to qmake's C++ compiler flags directly and hence trying to remove these
246         later will not work and cause build failures when using the force_static_libs_as_shared
247         feature of the Qt port.
248
249         This is fixed by removing the flags that hide the exports from the compiler flags directly.
250
251         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
252
253 2012-04-16  Ryosuke Niwa  <rniwa@webkit.org>
254
255         Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
256         https://bugs.webkit.org/show_bug.cgi?id=84068
257
258         Reviewed by Eric Seidel.
259
260         Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
261         automatically creates the build directory if needed.
262
263         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
264         (DownloadAndPerfTestFactory.__init__):
265         (DownloadAndPerfTestWebKit2Factory.__init__):
266
267 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
268
269         [GTK] Use configure instead of autogen.sh for gtk+
270         https://bugs.webkit.org/show_bug.cgi?id=84112
271
272         Rubber-stamped by Martin Robinson.
273
274         * gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
275         we don't want to depend on that for now, so run configure instead - we
276         can, since we are using a tarball
277
278 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
279
280         Unreviewed, rolling out r114322.
281         http://trac.webkit.org/changeset/114322
282         https://bugs.webkit.org/show_bug.cgi?id=84096
283
284         Didn't make the debug bot happy, so back out
285
286         * gtk/jhbuild.modules:
287
288 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
289
290         [GTK] Try to fix debug bot by adding gobject-introspection to the build
291         https://bugs.webkit.org/show_bug.cgi?id=84096
292
293         Unreviewed speculative build fix.
294
295         * gtk/jhbuild.modules: Added gobject-introspection, since modules need
296         an up-to-date introspection m4 for running autogen.
297
298 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
299
300         [GTK] Add pango to jhbuild
301         https://bugs.webkit.org/show_bug.cgi?id=84086
302
303         Unreviewed build fix.
304
305         * gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
306         jhbuild environment. It's required for latest stable GTK+ and some
307         systems may lack it.
308
309 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
310
311         [GTK] fonts jhbuild module needs an empty clean target
312         https://bugs.webkit.org/show_bug.cgi?id=84085
313
314         Rubber-stamped by Martin Robinson.
315
316         * gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
317         includes a phony clean target that should make warnings and errors go
318         away.
319
320 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
321
322         [GTK] Bump dependency on GTK+ 3.x to match reality
323         https://bugs.webkit.org/show_bug.cgi?id=84060
324
325         Rubber-stamped by Martin Robinson.
326
327         * gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
328         to their GNOME 3.4 versions.
329         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
330         is applied upstream.
331
332 2012-04-16  Vincent Scheib  <scheib@chromium.org>
333
334         Adding Contributors Brian Salomon and Tom Hudson to committers.py.
335
336         Unreviewed.
337
338         * Scripts/webkitpy/common/config/committers.py:
339
340 2012-04-16  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
341
342         [BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
343         https://bugs.webkit.org/show_bug.cgi?id=84031
344
345         Reviewed by Rob Buis.
346
347         Implemented interface function didReceiveAuthenticationChallenge in class
348         DumpRenderTree.
349
350         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
351         (drtCredentialDescription):
352         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
353         (WebKit):
354         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
355         (WebCore):
356         (DumpRenderTree):
357
358 2012-04-16  Philippe Normand  <pnormand@igalia.com>
359
360         build-webkit --gtk --no-webkit2 builds WK2
361         https://bugs.webkit.org/show_bug.cgi?id=83977
362
363         Reviewed by Martin Robinson.
364
365         * Scripts/build-webkit: Fixup ./configure option to disable
366         WebKit2 build.
367
368 2012-04-16  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
369
370         [EFL] [DRT] Feeding key events with invalid keyName
371         https://bugs.webkit.org/show_bug.cgi?id=83797
372
373         Keep the keyName valid within scope of KeyEventInfo to avoid
374         feeding key events with invalid keyName.
375
376         Reviewed by Philippe Normand.
377
378         * DumpRenderTree/efl/EventSender.cpp:
379         (KeyEventInfo::KeyEventInfo):
380         (KeyEventInfo):
381         (keyPadNameFromJSValue):
382         (keyNameFromJSValue):
383         (createKeyEventInfo):
384         (sendKeyDown):
385
386 2012-04-16  Andras Piroska  <pandras@inf.u-szeged.hu>
387
388         [Qt] Replace QtXmlPatterns usage with libxslt dependency
389         <https://bugs.webkit.org/show_bug.cgi?id=76820>
390
391         Reviewed by Simon Hausmann.
392
393         The features.prf file was modified, in order to use libxml and libxslt by default.
394         This modification only work at Qt5.
395
396         * qmake/config.tests/libxml2/libxml2.cpp: Added.
397         (main):
398         * qmake/config.tests/libxml2/libxml2.pro: Added.
399         * qmake/config.tests/libxslt/libxslt.cpp: Added.
400         (main):
401         * qmake/config.tests/libxslt/libxslt.pro: Added.
402         * qmake/mkspecs/features/features.prf:
403         * qmake/sync.profile:
404
405 2012-04-16  Seokju Kwon  <seokju.kwon@samsung.com>
406
407         [EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
408         https://bugs.webkit.org/show_bug.cgi?id=83862
409
410         Reviewed by Kenneth Rohde Christiansen.
411
412         EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
413         It doesn't work properly because of wrong parameter order in function call.
414
415         * EWebLauncher/main.c:
416
417 2012-04-16  Philippe Normand  <pnormand@igalia.com>
418
419         Unreviewed, GTK gardening.
420
421         * Scripts/run-gtk-tests:
422         (TestRunner): Skip /webkit/atk/textChangedNotifications.
423
424 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
425
426         Chromium perf bots should not build
427         https://bugs.webkit.org/show_bug.cgi?id=83641
428
429         Reviewed by Eric Seidel.
430
431         Don't build on perf bots to improve the cycle time.
432
433         * BuildSlaveSupport/build.webkit.org-config/config.json:
434
435 2012-04-14  Zalan Bujtas  <zbujtas@gmail.com>
436
437         [WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
438         https://bugs.webkit.org/show_bug.cgi?id=81945
439
440         Reviewed by Dan Bernstein.
441
442         WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
443         the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
444         PageCache to be functional.
445
446         * WebKitTestRunner/TestController.cpp:
447         (WTR::TestController::resetStateToConsistentValues):
448
449 2012-04-11  James Robinson  <jamesr@chromium.org>
450
451         [chromium] Remove unused compositeToTexture / compositeOffscreen setting
452         https://bugs.webkit.org/show_bug.cgi?id=83733
453
454         Reviewed by Adrienne Walker.
455
456         Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
457
458         * DumpRenderTree/chromium/DumpRenderTree.cpp:
459         (main):
460         * DumpRenderTree/chromium/TestShell.cpp:
461         (TestShell::TestShell):
462         (TestShell::resetWebSettings):
463         * DumpRenderTree/chromium/TestShell.h:
464         (TestShell):
465         * DumpRenderTree/chromium/WebPreferences.cpp:
466         (WebPreferences::reset):
467         (WebPreferences::applyTo):
468         * DumpRenderTree/chromium/WebPreferences.h:
469         (WebPreferences):
470
471 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
472
473         webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
474         and also rebaseline the test results since we ignore the first run now.
475
476         * Scripts/webkitpy/performance_tests/perftest.py:
477         (PageLoadingPerfTest.run):
478         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
479         (TestPageLoadingPerfTest.test_run):
480
481 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
482
483         Enable SVG page loading performance tests
484         https://bugs.webkit.org/show_bug.cgi?id=83861
485
486         Reviewed by Adam Barth.
487
488         Add support for page loading tests. These are tests without any test running harnesses, and we use
489         DriverOutput's test_timeout to measure the loading time.
490
491         Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
492
493         * Scripts/webkitpy/performance_tests/perftest.py:
494         (PerfTest.run):
495         (PerfTest):
496         (PerfTest.run_failed):
497         (PerfTest.parse_output):
498         (PerfTest.output_statistics):
499         (ChromiumStylePerfTest.parse_output):
500         (PageLoadingPerfTest): Added.
501         (PageLoadingPerfTest.__init__):
502         (PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
503         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
504         (MockPrinter):
505         (MockPrinter.__init__):
506         (MockPrinter.write):
507         (MainTest):
508         (MainTest.test_parse_output):
509         (MainTest.test_parse_output_with_failing_line):
510         (TestPageLoadingPerfTest):
511         (TestPageLoadingPerfTest.assertWritten):
512         (TestPageLoadingPerfTest.MockDriver):
513         (TestPageLoadingPerfTest.MockDriver.__init__):
514         (TestPageLoadingPerfTest.MockDriver.run_test):
515         (TestPageLoadingPerfTest.test_run):
516         (TestPageLoadingPerfTest.test_run_with_bad_output):
517         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
518         (PerfTestsRunner):
519         (PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
520         (PerfTestsRunner._collect_tests):
521         (PerfTestsRunner._run_tests_set):
522         (PerfTestsRunner._run_single_test):
523         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
524         (test_collect_tests_with_page_load_svg):
525         (test_collect_tests_with_page_load_svg.add_file):
526
527 2012-04-10  Brady Eidson  <beidson@apple.com>
528
529         <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600
530         Need WebKit2 API to notify whether history loads are in the page cache
531
532         Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
533         callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
534
535         Reviewed by Darin Adler.
536
537         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
538         (TestWebKitAPI::didFinishLoadForFrame):
539         (TestWebKitAPI::willGoToBackForwardListItem):
540         (TestWebKitAPI::setPageLoaderClient):
541         (TestWebKitAPI::TEST):
542         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
543         (ShouldGoToBackForwardListItemTest):
544         (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
545         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
546         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
547         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
548
549         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
550         (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
551
552 2012-04-13  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
553
554         Group EFL bots into a category on the buildbot master
555         https://bugs.webkit.org/show_bug.cgi?id=82712
556
557         Reviewed by Adam Roben.
558
559         Creating a new category definition on the buildbot frontend.
560
561         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
562         (loadBuilderConfig): Determine category for EFL bots
563         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
564
565 2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>
566
567         Unreviewed, rolling out r113714.
568         http://trac.webkit.org/changeset/113714
569         https://bugs.webkit.org/show_bug.cgi?id=83887
570
571         It is behaving strange on the bots and needs more
572         investigation. (Requested by jeez_ on #webkit).
573
574         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
575         (WTR::PlatformWebView::PlatformWebView):
576
577 2012-04-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
578
579         webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
580         https://bugs.webkit.org/show_bug.cgi?id=83690
581
582         Reviewed by Tor Arne Vestbø.
583
584         Typing part of an email and pressing <TAB> will bash-complete it using the list in
585         Tools/Scripts/webkitpy/common/config/committers.py
586
587         * Scripts/webkit-tools-completion.sh:
588
589 2012-04-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
590
591         [EFL] Add API for color chooser
592         https://bugs.webkit.org/show_bug.cgi?id=83692
593
594         Enables INPUT_TYPE_COLOR by default on the EFL port.
595
596         Reviewed by Kenneth Rohde Christiansen.
597
598         * Scripts/build-webkit:
599
600 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
601
602         Extract PerfTest class from PerfTestRunner
603         https://bugs.webkit.org/show_bug.cgi?id=83847
604
605         Reviewed by Hajime Morita.
606
607         Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
608         that was previously represented by a tuple.
609
610         Also moved the logic to determine whether a given test is chromium style or not from run() to
611         _collect_tests(). And moved the output parsing algorithms for parser style and chromium style
612         tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
613         add new types of tests more easily.
614
615         * Scripts/webkitpy/performance_tests/perftest.py: Added.
616         (PerfTest):
617         (PerfTest.__init__):
618         (PerfTest.test_name):
619         (PerfTest.dirname):
620         (PerfTest.path_or_url):
621         (PerfTest._should_ignore_line_in_parser_test_result):
622         (PerfTest.parse_output):
623         (ChromiumStylePerfTest):
624         (ChromiumStylePerfTest.__init__):
625         (ChromiumStylePerfTest.parse_output):
626         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
627         (PerfTestsRunner._collect_tests):
628         (PerfTestsRunner.run):
629         (PerfTestsRunner._run_tests_set):
630         (PerfTestsRunner._run_single_test):
631         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
632         (run_test):
633         (_tests_for_runner):
634         (test_run_test_set_with_json_output):
635         (test_run_test_set_with_json_source):
636         (test_run_test_set_with_multiple_repositories):
637         (_collect_tests_and_sort_test_name):
638         (test_collect_tests):
639         (test_collect_tests_with_skipped_list):
640
641 2012-04-12  Balazs Kelemen  <kbalazs@webkit.org>
642
643         [Qt] Fix WebKit1 build with V8
644         https://bugs.webkit.org/show_bug.cgi?id=83322
645
646         Reviewed by Adam Barth.
647
648         * DumpRenderTree/qt/DumpRenderTree.pro:
649         * qmake/mkspecs/features/default_post.prf:
650         * qmake/mkspecs/features/default_pre.prf:
651         * qmake/mkspecs/features/features.prf:
652
653 2012-04-12  Dirk Pranke  <dpranke@chromium.org>
654
655         test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
656         https://bugs.webkit.org/show_bug.cgi?id=83583
657
658         Reviewed by Philippe Normand
659
660         Updated the unit test to ignore the hours and minutes of the
661         localtime for time(0), since we can't easily guarantee which
662         timezone we're in or what timezone rules were in effect on
663         1/1/1970; this should be mostly fine since we can trust that
664         time.localtime() will work, although there is the possibility
665         that we'll screw up the time formatting of which field is the
666         hours and which is the minutes.
667
668         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
669         (VerboseTest):
670         (VerboseTest.test_basic):
671         (VerboseTest.test_log_after_update):
672
673 2012-04-12  Dominik Rottsches  <dominik.rottsches@linux.intel.com>
674
675         Add an EFL Debug Buildbot to the master configuration
676         https://bugs.webkit.org/show_bug.cgi?id=82711
677
678         Forgot to add EFL Linux Debug to scheduler.
679
680         Reviewed by Philippe Normand.
681
682         * BuildSlaveSupport/build.webkit.org-config/config.json:
683
684 2012-04-12  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
685
686         Add an EFL Debug Buildbot to the master configuration
687         https://bugs.webkit.org/show_bug.cgi?id=82711
688
689         Reviewed by Philippe Normand.
690
691         Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.
692
693         * BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
694
695 2012-04-12  George Staikos  <staikos@webkit.org>
696
697         Enable the fullscreen API for BlackBerry.
698         https://bugs.webkit.org/show_bug.cgi?id=83757
699
700         Reviewed by Antonio Gomes.
701
702         * Scripts/build-webkit:
703
704 2012-04-12  Simon Pena  <spena@igalia.com>
705
706         [GTK] Test runner crashes without recent versions of pulseaudio-utils
707         https://bugs.webkit.org/show_bug.cgi?id=83774
708
709         Reviewed by Philippe Normand.
710
711         Besides checking that pactl is available, check also that its output
712         is the expected one, and handle gracefully when it isn't, when
713         trying to unload pulseaudio modules.
714
715         * Scripts/webkitpy/layout_tests/port/gtk.py:
716         (GtkPort._unload_pulseaudio_module):
717         (GtkPort._restore_pulseaudio_module):
718
719 2012-03-05  Pierre Rossi  <pierre.rossi@gmail.com>
720
721         [Qt] Use QRawFont when building with Qt 5
722         https://bugs.webkit.org/show_bug.cgi?id=78001
723
724         Flip the QRawFont switch for Qt 5.
725
726         Reviewed by Simon Hausmann.
727
728         * qmake/mkspecs/features/features.prf:
729
730 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
731
732         Web Inspector: Disabling Inspector causes build failure on Windows
733         https://bugs.webkit.org/show_bug.cgi?id=83557
734
735         Reviewed by Pavel Feldman.
736
737         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
738         This change brings all such API calls under the guard.
739
740         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
741         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
742         (WTR):
743         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
744         (LayoutTestController):
745         * WebKitTestRunner/TestInvocation.cpp:
746         (WTR::TestInvocation::invoke):
747
748 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
749
750         Fix regression introduced in r113927.
751
752         Unreviewed, build fix.
753
754         I failed to rename skipped_tests() to skipped_layout_tests()
755         everywhere it needed to be renamed. The unit tests didn't catch
756         this because the TestPort was one of the places that didn't get
757         renamed :(.
758
759         * Scripts/webkitpy/layout_tests/controllers/manager.py:
760         (Manager.parse_expectations):
761         * Scripts/webkitpy/layout_tests/port/test.py:
762         (TestPort.skipped_layout_tests):
763         * Scripts/webkitpy/tool/commands/queries.py:
764         (PrintExpectations._model):
765
766 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
767
768         new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
769         https://bugs.webkit.org/show_bug.cgi?id=47528
770
771         Reviewed by Adam Barth.
772
773         The skipped-ports command has been replaced by 'webkit-patch
774         print-expectations', which offers the equivalent functionality
775         via 'webkit-patch print-expectations --platform \* -t skip'
776         (and other features, of course).
777         
778         This also allows me to fix a nasty layering violation where the
779         chromium port had to know about the TestExpectations objects in
780         order to implement the command properly.
781
782         Lastly, this allows me to rename skipped_tests() to
783         skipped_layout_tests() to more consistent with
784         skipped_perf_tests().
785         
786         This patch removes skips_layout_test() from the Port interface,
787         because that can't be implemented without the port knowing about
788         Expectations objects (and skipped-ports was the only thing using it).
789
790         * Scripts/webkitpy/layout_tests/port/base.py:
791         (Port.skipped_layout_tests):
792         (Port.skipped_perf_tests):
793         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
794         (PortTest.test_default_configuration_notfound):
795         * Scripts/webkitpy/layout_tests/port/chromium.py:
796         (ChromiumPort.test_expectations_overrides):
797         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
798         (ChromiumPortTest.test_path_to_image_diff):
799         * Scripts/webkitpy/layout_tests/port/webkit.py:
800         (WebKitPort.skipped_layout_tests):
801         * Scripts/webkitpy/tool/commands/queries.py:
802         (execute):
803         * Scripts/webkitpy/tool/commands/queries_unittest.py:
804         (QueryCommandsTest.test_tree_status):
805
806 2012-04-11  Mark Rowe  <mrowe@apple.com>
807
808         Remove a fprintf from LayoutTestController.
809
810         This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
811         It was added for no apparent reason by Ryosuke in r113651.
812
813         * DumpRenderTree/LayoutTestController.cpp:
814         (LayoutTestController::redirectionDestinationForURL):
815
816 2012-04-11  Nico Weber  <thakis@chromium.org>
817
818         [mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
819         https://bugs.webkit.org/show_bug.cgi?id=83709
820
821         Reviewed by Anders Carlsson.
822
823         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
824         (handleEventCarbon):
825
826 2012-04-11  Rafael Brandao  <rafael.lobo@openbossa.org>
827
828         Adding myself to committers.py
829         https://bugs.webkit.org/show_bug.cgi?id=83711
830
831         Unreviewed update to committers.py.
832
833         * Scripts/webkitpy/common/config/committers.py:
834
835 2012-04-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
836
837         [EFL] LayoutTestController needs implementation of pageProperty
838         https://bugs.webkit.org/show_bug.cgi?id=82449
839
840         Add missing implementation pageProperty to EFL's LayoutTestController
841         in order to unskip printing/page-rule-selection.html
842
843         Reviewed by Antonio Gomes.
844
845         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
846         (LayoutTestController::pageProperty):
847
848 2012-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
849
850         Unreviewed, rolling out r113836.
851         http://trac.webkit.org/changeset/113836
852         https://bugs.webkit.org/show_bug.cgi?id=83705
853
854         Broke all the WebKit2 inspector tests (Requested by andersca
855         on #webkit).
856
857         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
858         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
859         (WTR::LayoutTestController::showWebInspector):
860         (WTR::LayoutTestController::closeWebInspector):
861         (WTR::LayoutTestController::evaluateInWebInspector):
862         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
863         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
864         (LayoutTestController):
865         * WebKitTestRunner/TestInvocation.cpp:
866         (WTR::TestInvocation::invoke):
867
868 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
869
870         Web Inspector: Disabling Inspector causes build failure on Windows
871         https://bugs.webkit.org/show_bug.cgi?id=83557
872
873         Reviewed by Pavel Feldman.
874
875         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
876         This change brings all such API calls under the guard.
877
878         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
879         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
880         (WTR):
881         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
882         (LayoutTestController):
883         * WebKitTestRunner/TestInvocation.cpp:
884         (WTR::TestInvocation::invoke):
885
886 2012-04-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
887
888         [Qt][WK2] Manage graphics buffers in the web process
889         https://bugs.webkit.org/show_bug.cgi?id=78675
890  
891         Make graphics surface available only for Qt 5, attempting to fix
892         the Qt-mac build.
893
894         Unreviewed build fix.
895
896         * qmake/mkspecs/features/features.prf:
897
898 2012-04-11  Philippe Normand  <pnormand@igalia.com>
899
900         Unreviewed, GTK NRWT follow-up fix after r113849.
901
902         * Scripts/webkitpy/layout_tests/port/gtk.py:
903         (GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.
904
905 2012-04-11  Simon Pena  <spena@igalia.com>
906
907         [GTK] media/event-attributes.html fails
908         https://bugs.webkit.org/show_bug.cgi?id=71662
909
910         Reviewed by Philippe Normand.
911
912         PulseAudio's module "module-stream-restore" allows saving the volume
913         of a stream, restoring it the next time it runs.
914         This affects the tests, since DumpRenderTree's volume settings are
915         saved between test runs, and tests relying on specific volume values
916         would miss some volumeChange events (or get additional ones).
917
918         This patch hooks on the existing GtkPort setup_test_run method and
919         creates a new clean_up_test_run method, so PulseAudio's module is
920         unloaded (if found) before running the tests, and restored (if it
921         was there previously) after they finished, ensuring the tests run in
922         the right environment.
923
924         * Scripts/webkitpy/layout_tests/controllers/manager.py:
925         (Manager._clean_up_run): Invoke the port implementation of
926         clean_up_test_run.
927         * Scripts/webkitpy/layout_tests/port/base.py:
928         (Port.clean_up_test_run): Add an empty implementation of
929         clean_up_test_run.
930         * Scripts/webkitpy/layout_tests/port/gtk.py:
931         (GtkPort._unload_pulseaudio_module): Unloads the offending
932         pulseaudio module, if found.
933         (GtkPort):
934         (GtkPort._restore_pulseaudio_module): Restores the offending
935         pulseaudio module, if it was there previously.
936         (GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
937         (GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.
938
939 2012-04-11  Andras Becsi  <andras.becsi@nokia.com>
940
941         Fix the build with gcc 4.7.0
942         https://bugs.webkit.org/show_bug.cgi?id=83584
943
944         Reviewed by Alexey Proskuryakov.
945
946         * qmake/mkspecs/features/unix/default_post.prf:
947         The -fuse-ld=gold option is not supported with upstream gcc.
948
949 2012-04-11  Ryosuke Niwa  <rniwa@webkit.org>
950
951         Refactor PerfTestRunner to include file extensions in test names
952         https://bugs.webkit.org/show_bug.cgi?id=83677
953
954         Reviewed by Hajime Morita.
955
956         Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.
957
958         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
959         (PerfTestsRunner._collect_tests):
960         (PerfTestsRunner._run_tests_set):
961         (PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
962         We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
963         (PerfTestsRunner._run_single_test):
964         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
965         (run_test):
966         (_tests_for_runner):
967         (test_run_test_set):
968         (test_run_test_set_kills_drt_per_run):
969         (test_run_test_pause_before_testing):
970         (test_run_test_set_for_parser_tests):
971         (test_collect_tests):
972         (test_collect_tests_with_skipped_list):
973
974 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
975
976         Web Inspector: Disabling Inspector causes build failure on Windows
977         https://bugs.webkit.org/show_bug.cgi?id=83557
978
979         Reviewed by Pavel Feldman.
980
981         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
982         This change brings all such API calls under the guard.
983
984         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
985         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
986         (WTR):
987         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
988         (LayoutTestController):
989         * WebKitTestRunner/TestInvocation.cpp:
990         (WTR::TestInvocation::invoke):
991
992 2012-04-10  Kent Tamura  <tkent@chromium.org>
993
994         Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
995
996         * Scripts/webkitpy/common/config/watchlist:
997         * Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
998
999 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1000
1001         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
1002         https://bugs.webkit.org/show_bug.cgi?id=82799
1003
1004         Reviewed by Ojan Vafai.
1005
1006         The tests we were skipping in _mark_interrupted_tests_as_skipped
1007         had incorrectly-constructed TestResults, and so they were not
1008         being treated as failures. The JSON generator doesn't record
1009         tests that are passed or skiped in incremental_results, so you
1010         couldn't tell these tests were being skipped at all.
1011
1012         This change changes _mark_interrupted_tests_as_skipped() to
1013         treat the skipped tests as failures; this is arguably still
1014         incorrect but is minimally invasive for now. We probably need to
1015         revisit how we are uploading information about tests that are
1016         skipped and passed altogether in a separate change.
1017
1018         This change also cleans up a couple of other nits that were
1019         unnecessary or broken in this same code path.
1020
1021         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1022         (Manager._mark_interrupted_tests_as_skipped):
1023         (Manager._upload_json_files): Deletes the check for
1024         chromium-mac-leopard (as it is no longer necessary).
1025         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1026         (JSONLayoutResultsGenerator.__init__): Here we were
1027         recalculating the failure type unnecessarily.
1028         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1029         (determine_result_type):
1030         (FailureEarlyExit): Adds a new failure type so we can tell what
1031         happened.
1032         (FailureEarlyExit.message):
1033         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1034         (MainTest.test_exit_after_n_failures_upload): Add more checks to
1035         ensure that we are recording the SKIP correctly; this is less
1036         than ideal, because we can't actually test the contents of
1037         incremental_results.json. We should fix that at some point.
1038
1039 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1040
1041         make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
1042         https://bugs.webkit.org/show_bug.cgi?id=83401
1043
1044         Reviewed by Adam Barth.
1045
1046         Last patch in the series - no longer look in mac-leopard,
1047         mac-snowleopard, or mac-lion.
1048
1049         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1050         (ChromiumMacPort):
1051         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1052
1053 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1054
1055         webkit-patch: add a print-expectations command
1056         https://bugs.webkit.org/show_bug.cgi?id=83347
1057
1058         Reviewed by Adam Barth.
1059
1060         This command will print the expected results for a given set of
1061         tests on a given set of ports matching a given set of keywords.
1062
1063         Example output (printing all the tests not expected to pass, and their
1064         expected results, on a Mac):
1065
1066         $ webkit-patch print-expectations -x pass fast/html
1067         // For mac-snowleopard
1068         fast/html/details-open4.html = TEXT
1069         fast/html/details-open2.html = TEXT
1070         fast/html/details-no-summary4.html = TEXT
1071         fast/html/details-open-javascript.html = TEXT
1072         $
1073
1074         You can also print full test-expectatons.txt lines using --full and a
1075         CSV-style report (which can be useful for post-processing) using --csv.
1076
1077         It will replace the 'skipped-files' command (which will be
1078         removed in a subsequent patch) and is a more general (and
1079         cleaner and properly layered) solution.
1080
1081         Also add an update() command to MockOptions() to make overriding keywords easier.
1082
1083         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1084         (TestExpectationSerializer.to_string):
1085         (TestExpectationSerializer):
1086         (TestExpectationSerializer.to_csv):
1087         (TestExpectationSerializer._format_result):
1088         (TestExpectationLine.create_passing_expectation):
1089         (TestExpectationsModel.get_test_set_for_keyword):
1090         (TestExpectationsModel.has_keyword):
1091         (TestExpectations.model):
1092         * Scripts/webkitpy/tool/commands/queries.py:
1093         (execute):
1094         (PrintExpectations):
1095         (PrintExpectations.__init__):
1096         (PrintExpectations.execute):
1097         (PrintExpectations._filter_tests):
1098         (PrintExpectations._format_lines):
1099         (PrintExpectations._model):
1100         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1101         (TestPrintExpectations): Added.
1102         * Scripts/webkitpy/tool/mocktool.py:
1103         (MockOptions):
1104         (MockOptions.__init__):
1105         (MockOptions.update): Added.
1106
1107 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1108
1109         webkitpy: refactor handling of --platform and related options
1110         https://bugs.webkit.org/show_bug.cgi?id=83525
1111
1112         Reviewed by Adam Barth.
1113
1114         This change moves to centralize handling of --platform, --debug,
1115         --gtk, and other similar flags into a central place next to the
1116         code that actually uses those flags in PortFactory to get the
1117         right Port object.
1118
1119         * Scripts/webkitpy/layout_tests/port/__init__.py:
1120         * Scripts/webkitpy/layout_tests/port/factory.py:
1121         (port_options):
1122         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1123         (parse_args):
1124         * Scripts/webkitpy/tool/commands/queries.py:
1125         (PrintBaselines.__init__):
1126
1127 2012-04-10  Ojan Vafai  <ojan@chromium.org>
1128
1129         Add a chromeless view to the individual tests view
1130         https://bugs.webkit.org/show_bug.cgi?id=83541
1131
1132         Reviewed by Daniel Bates.
1133
1134         This is the view suitable to inlining in other contexts (e.g. garden-o-matic).
1135
1136         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1137         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1138         (testHtmlForIndividualTestOnAllBuilders):
1139         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
1140         (testHtmlForIndividualTestOnAllBuildersWithChrome):
1141         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
1142         (testHtmlForIndividualTests):
1143         (htmlEscape):
1144         (runTests):
1145
1146 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1147
1148         remove 'win' from chromium-win, chromium-linux fallback paths
1149         https://bugs.webkit.org/show_bug.cgi?id=83613
1150
1151         Reviewed by Ojan Vafai.
1152
1153         The chromium ports no longer need to look at the apple 'win'
1154         directory for baseline results.
1155
1156         Also remove the old '-gpu-' entries from the flakiness dashboard
1157         map since I'm touching lines nearby.
1158
1159         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1160         (ChromiumLinuxPort):
1161         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1162         (ChromiumWinPort):
1163         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1164
1165 2012-04-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
1166
1167         [Qt][WK2] Manage graphics buffers in the web process
1168         https://bugs.webkit.org/show_bug.cgi?id=78675
1169
1170         Enable graphics surfaces on Mac for Qt.
1171
1172         Reviewed by Kenneth Rohde Christiansen.
1173
1174         * qmake/mkspecs/features/features.prf:
1175
1176 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
1177
1178         [CMake] Enable USE_FOLDERS property
1179         https://bugs.webkit.org/show_bug.cgi?id=83571
1180
1181         Reviewed by Daniel Bates.
1182
1183         Setting the FOLDER property on targets gives more structure
1184         to the generated Visual Studio solutions.
1185         This does not affect other CMake generators.
1186
1187         * DumpRenderTree/efl/CMakeLists.txt:
1188         * EWebLauncher/CMakeLists.txt:
1189         * WinCELauncher/CMakeLists.txt:
1190
1191 2012-04-10  David Dorwin  <ddorwin@chromium.org>
1192
1193         Add Encrypted Media Extensions methods to HTMLMediaElement
1194         https://bugs.webkit.org/show_bug.cgi?id=82971
1195
1196         Reviewed by Adam Barth.
1197
1198         The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
1199         Implementation is based on v0.1 of the draft proposal at
1200         http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.
1201
1202         * DumpRenderTree/chromium/TestShell.cpp:
1203         (TestShell::TestShell):
1204
1205 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
1206
1207         [EFL][DRT] Catch the "title,changed" signal
1208         https://bugs.webkit.org/show_bug.cgi?id=82174
1209
1210         Reviewed by Gustavo Noronha Silva.
1211
1212         EFL's DumpRenderTree now catches the "title,changed" signal, and
1213         prints out the needed information.
1214
1215         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1216         (DumpRenderTreeChrome::onTitleChanged):
1217
1218 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
1219
1220         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
1221         https://bugs.webkit.org/show_bug.cgi?id=82443
1222
1223         Reviewed by Philippe Normand.
1224
1225         EFL's DRT needs to support LayoutTestController's
1226         willSendRequestReturnsNull() and return NULL when expected. This
1227         allows for several tests to be removed from the skip list.
1228
1229         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1230         (DumpRenderTreeChrome::onWillSendRequest):
1231
1232 2012-04-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1233
1234         [EFL] LayoutTestController needs implementation of addUserStyleSheet
1235         https://bugs.webkit.org/show_bug.cgi?id=82446
1236
1237         Adding missing implementation addUserStyleSheet to EFL's LayoutTestController 
1238         so that we can unskip related tests from the skip list. 
1239
1240         Reviewed by Antonio Gomes.
1241
1242         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1243         (LayoutTestController::addUserStyleSheet): Implemented.
1244
1245 2012-04-10  Philip Rogers  <pdr@google.com>
1246
1247         Adding myself to committers.py!
1248
1249         Unreviewed update to committers.py.
1250
1251         * Scripts/webkitpy/common/config/committers.py:
1252
1253 2012-04-10  Dinu Jacob  <dinu.jacob@nokia.com>
1254
1255         [Qt][WK2] Title in MiniBrowser is not updated for a page with no title
1256         https://bugs.webkit.org/show_bug.cgi?id=82483
1257
1258         Reviewed by Kenneth Rohde Christiansen.
1259
1260         Set window title to default if there is no page title.
1261
1262         * MiniBrowser/qt/BrowserWindow.cpp:
1263         (BrowserWindow::BrowserWindow):
1264         (BrowserWindow::onTitleChanged):
1265         * MiniBrowser/qt/BrowserWindow.h:
1266         (BrowserWindow):
1267
1268 2012-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1269
1270         [Qt][WK2] Implement PageClient::isViewWindowActive()
1271         https://bugs.webkit.org/show_bug.cgi?id=81143
1272
1273         Reviewed by Kenneth Rohde Christiansen.
1274
1275         Fix the WrapperWindow from our PlatformWebView
1276         so it correctly creates the platform related
1277         stuff for QWindow, which is not created unless
1278         QWindow::setVisible() or QWindow::show() are called.
1279
1280         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1281         (WTR::PlatformWebView::PlatformWebView):
1282
1283 2012-04-10  Balazs Kelemen  <kbalazs@webkit.org>
1284
1285         [Qt][WK2] TestNetscapePlugin is broken
1286         https://bugs.webkit.org/show_bug.cgi?id=83024
1287
1288         Reviewed by Csaba Osztrogonác.
1289
1290         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1291         Fix X11 availability check. embedded is always true with QPA.
1292         * Tools.pro:
1293         Build the test plugin if plugins are enabled for WebKit2.
1294         * qmake/mkspecs/features/features.prf:
1295         * qmake/mkspecs/features/functions.prf:
1296         Added a convenience function to determine availability
1297         of X11 libraries.
1298
1299 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
1300
1301         [WIN] Fix build without precompiled header.
1302
1303         * DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
1304
1305 2012-04-10  Arko Saha  <arko@motorola.com>
1306
1307         Unreviewed: adding myself to committers.py.
1308
1309         * Scripts/webkitpy/common/config/committers.py:
1310
1311 2012-04-09  Kaustubh Atrawalkar  <kaustubh@motorola.com>
1312
1313         Unreviewed: adding myself to committers.py.
1314
1315         * Scripts/webkitpy/common/config/committers.py:
1316
1317 2012-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1318
1319         Unreviewed, rolling out r113656.
1320         http://trac.webkit.org/changeset/113656
1321         https://bugs.webkit.org/show_bug.cgi?id=83542
1322
1323         test is broken on chromium-win (Requested by simonjam on
1324         #webkit).
1325
1326         * DumpRenderTree/chromium/WebViewHost.cpp:
1327         (WebViewHost::dispatchIntent):
1328
1329 2012-04-09  Takashi Toyoshima  <toyoshim@chromium.org>
1330
1331         Update pywebsocket to 0.7.4.
1332         https://bugs.webkit.org/show_bug.cgi?id=83461
1333
1334         Reviewed by Kent Tamura.
1335
1336         This version supports TLS by using ssl in addition to pyOpenSSL.
1337         Other functional difrerences from 0.7.2 are:
1338          - strict Sec-WebSocket-Key validation conforming RFC 4648
1339          - compression ratio logging in debug
1340
1341         * Scripts/webkitpy/thirdparty/__init__.py:
1342         (AutoinstallImportHook._install_pywebsocket):
1343
1344 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
1345
1346         add a webkit-patch print-baselines command
1347         https://bugs.webkit.org/show_bug.cgi?id=83348
1348
1349         Reviewed by Adam Barth.
1350
1351         This adds a simple 'print-baselines' command to webkit-patch
1352         that can be used in one of two forms: to print where the
1353         baselines for a given test (or set of tests) on a single port
1354         will be found, or to generate a report for multiple ports.
1355
1356         Example of the former:
1357
1358         $ webkit-patch print-baselines fast/html/keygen.html
1359         // For mac-snowleopard
1360         platform/mac/fast/html/keygen-expected.txt
1361         platform/mac/fast/html/keygen-expected.png
1362         $
1363
1364         The latter is most useful for finding out which fallback dirs are
1365         used by which ports for which tests, for example,
1366         'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
1367         No example output is given because the reports are pretty wordy :).
1368
1369         * Scripts/webkitpy/layout_tests/port/base.py:
1370         (Port.baseline_extensions): Added.
1371         (Port.expected_baseline_dict): Added.
1372         * Scripts/webkitpy/tool/commands/queries.py:
1373         (PrintBaselines):
1374         (PrintBaselines.__init__):
1375         (PrintBaselines.execute):
1376         (PrintBaselines._print_baselines):
1377         (PrintBaselines._platform_for_path):
1378
1379 2012-04-09  Florin Malita  <fmalita@chromium.org>
1380
1381         Unreviewed: adding myself to committers.py.
1382
1383         * Scripts/webkitpy/common/config/committers.py:
1384
1385 2012-04-09  Ming Xie  <mxie@rim.com>
1386
1387         [BlackBerry] Allow simulator to use GLES2 acceleration
1388         https://bugs.webkit.org/show_bug.cgi?id=81672
1389
1390         Reviewed by Rob Buis.
1391
1392         * Scripts/webkitdirs.pm:
1393         (blackberryCMakeArguments):
1394
1395 2012-04-09  Dana Jansens  <danakj@chromium.org>
1396
1397         Mark myself as a committer
1398         https://bugs.webkit.org/show_bug.cgi?id=83510
1399
1400         Reviewed by Adrienne Walker.
1401
1402         * Scripts/webkitpy/common/config/committers.py:
1403
1404 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
1405
1406         nrwt is failing to upload test results on the chromium-mac-leopard bots
1407         https://bugs.webkit.org/show_bug.cgi?id=83230
1408
1409         Unreviewed, build fix.
1410
1411         It looks like the change in r113399 to use the per-request
1412         timeout variable didn't actually work, so I am removing the
1413         timeout code altogether and counting on the idea that upload
1414         just isn't likely to take that long and the timeouts and
1415         retransmits are largely unused and largely unnecessary. We'll
1416         see if this breaks anywhere else.
1417
1418         * Scripts/webkitpy/common/net/file_uploader.py:
1419         (FileUploader.__init__):
1420         (FileUploader._upload_data.callback):
1421         (FileUploader):
1422
1423 2012-04-09  Rob Buis  <rbuis@rim.com>
1424
1425         [BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
1426         https://bugs.webkit.org/show_bug.cgi?id=83469
1427
1428         Reviewed by Dirk Schulze.
1429
1430         Remove WTF:: prefixes and fix a warning with the length variable.
1431
1432         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1433         (jsStringRefToWebCoreString):
1434         (LayoutTestController::execCommand):
1435         (LayoutTestController::isCommandEnabled):
1436         (LayoutTestController::setUserStyleSheetLocation):
1437         (LayoutTestController::counterValueForElementById):
1438         (LayoutTestController::overridePreference):
1439         (LayoutTestController::setMockGeolocationError):
1440         (LayoutTestController::findString):
1441
1442 2012-04-09  Patrick Gansterer  <paroga@webkit.org>
1443
1444         Build fix for WinCE after r113570.
1445
1446         * Scripts/build-webkit: Do not use FastMalloc for WinCE.
1447
1448 2012-04-09  Eric Carlson  <eric.carlson@apple.com>
1449
1450         Subscribe eric.carlson@apple.com to Media-related changes
1451         https://bugs.webkit.org/show_bug.cgi?id=83421
1452
1453         Reviewed by Dan Bernstein.
1454
1455         * Scripts/webkitpy/common/config/watchlist:
1456
1457 2012-04-09  Martin Robinson  <mrobinson@igalia.com>
1458
1459         check-webkit-style should ignore NULL usage in gtk_style_context_get_style
1460         https://bugs.webkit.org/show_bug.cgi?id=83412
1461
1462         Reviewed by David Levin.
1463
1464         Accept NULL as an argument for gtk_style_context_get_style, because it's
1465         used as a sentinel in a variable argument list. 
1466
1467         * Scripts/webkitpy/style/checkers/cpp.py:
1468         (check_for_null): Add an exception.
1469         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1470         (WebKitStyleTest.test_null_false_zero): Add a test for the exception.
1471
1472 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
1473
1474         webkitpy: use the filesystem object properly in fileuploader
1475         https://bugs.webkit.org/show_bug.cgi?id=83326
1476
1477         Reviewed by Adam Barth.
1478
1479         We should be using the filesystem object rather than the codecs
1480         object.
1481
1482         * Scripts/webkitpy/common/net/file_uploader.py:
1483         (FileUploader.upload_as_multipart_form_data):
1484
1485 2012-04-09  Eric Seidel  <eric@webkit.org>
1486
1487         Enable webkit_unit_tests for commit queue and EWS while tracking failures
1488         https://bugs.webkit.org/show_bug.cgi?id=83329
1489
1490         Unreviewed.  Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
1491
1492         line 62, in _create_unit_test_results
1493          return UnitTestResults.results_from_string(results_xml)
1494          NameError: global name 'UnitTestResults' is not defined
1495
1496         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1497         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1498         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1499
1500 2012-04-08  Adam Barth  <abarth@webkit.org>
1501
1502         The port object is missing unit_tests_results_path
1503         https://bugs.webkit.org/show_bug.cgi?id=83448
1504
1505         Unreviewed.
1506
1507         This is causing the cr-linux-ews to throw an exception.
1508
1509         * Scripts/webkitpy/common/config/ports.py:
1510         (DeprecatedPort.unit_tests_results_path):
1511
1512 2012-04-07  Patrick Gansterer  <paroga@webkit.org>
1513
1514         [CMake] Cleanup WTF include directories
1515         https://bugs.webkit.org/show_bug.cgi?id=82716
1516
1517         Reviewed by Eric Seidel.
1518
1519         * DumpRenderTree/efl/CMakeLists.txt:
1520         * WinCELauncher/CMakeLists.txt:
1521
1522 2012-04-07  Rob Buis  <rbuis@rim.com>
1523
1524         [BlackBerry] Add Battery Status API support
1525         https://bugs.webkit.org/show_bug.cgi?id=82615
1526
1527         Reviewed by George Staikos.
1528
1529         Enable BATTERY_STATUS.
1530
1531         * Scripts/build-webkit:
1532
1533 2012-04-06  Ami Fischman  <fischman@chromium.org>
1534
1535         Subscribe feature-media-reviews@c.o to Media-related changes.
1536         https://bugs.webkit.org/show_bug.cgi?id=83397
1537
1538         Reviewed by David Levin.
1539
1540         * Scripts/webkitpy/common/config/committers.py:
1541         * Scripts/webkitpy/common/config/watchlist:
1542
1543 2012-04-06  Adrienne Walker  <enne@google.com>
1544
1545         [chromium] Add virtual test suite for threaded compositing
1546         https://bugs.webkit.org/show_bug.cgi?id=82263
1547
1548         Reviewed by James Robinson.
1549
1550         Add compositing/visibility as a virtual test suites to test threaded
1551         compositing with. This is a reasonable smoke test of 9 tests, none of
1552         which have any expectations in the non-threaded case.
1553
1554         To fix many of the remaining tests in this virtual test suite, there
1555         will need to be some serious refactoring to merge the conflict between
1556         the way CCScheduler wants to draw frames and the way DRT also wants to
1557         control things. So, in the short term, enable a few simple tests that
1558         are known to be passing.
1559
1560         * Scripts/webkitpy/layout_tests/port/chromium.py:
1561         (ChromiumPort.virtual_test_suites):
1562
1563 2012-04-06  Enrica Casucci  <enrica@apple.com>
1564
1565         Provide Obj-C private API to simplify markup.
1566         https://bugs.webkit.org/show_bug.cgi?id=83334
1567         <rdar://problem/11033861>
1568
1569         Reviewed by Sam Weinig.
1570
1571         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1572         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
1573         (-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
1574         * TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
1575
1576 2012-04-06  Dirk Pranke  <dpranke@chromium.org>
1577
1578         new-run-webkit-tests: fix bugs in 'mock' drt implementation
1579         https://bugs.webkit.org/show_bug.cgi?id=83341
1580
1581         Reviewed by Eric Seidel.
1582
1583         The current implementation crashed in some circumstances for
1584         reference tests and files that were missing expected results.
1585         This patch fixes those cases and adds more unit tests; it is a
1586         precursor to adding unit tests each port that actually uses this
1587         code, in order to get better coverage of the port/*
1588         implementations.
1589
1590         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1591         (parse_options):
1592         (MockDRT.input_from_line):
1593         (MockDRT.output_for_test):
1594         (MockDRT.run_one_test):
1595         (MockChromiumDRT.input_from_line):
1596         (MockChromiumDRT.output_for_test):
1597         (MockChromiumDRT.run_one_test):
1598         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1599         (MockDRTTest.make_input_output):
1600         (MockDRTTest.expected_output):
1601         (MockDRTTest):
1602         (MockDRTTest.assertTest):
1603         (MockDRTTest.test_missing_image):
1604         (MockDRTTest.test_missing_text):
1605         (MockDRTTest.test_reftest_match):
1606         (MockDRTTest.test_reftest_mismatch):
1607         (MockChromiumDRTTest.expected_output):
1608
1609 2012-04-06  James Robinson  <jamesr@chromium.org>
1610
1611         Enable webkit_unit_tests for commit queue and EWS while tracking failures
1612         https://bugs.webkit.org/show_bug.cgi?id=83329
1613
1614         Reviewed by Adam Barth.
1615
1616         This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
1617         the commit queue and EWS can reject patches that cause regressions.
1618
1619         * Scripts/webkitpy/common/config/ports.py:
1620         (ChromiumPort.run_webkit_unit_tests_command):
1621         * Scripts/webkitpy/common/config/ports_mock.py:
1622         (MockPort.unit_tests_results_path):
1623         * Scripts/webkitpy/common/net/layouttestresults.py:
1624         (LayoutTestResults.__init__):
1625         (LayoutTestResults.failing_tests):
1626         (LayoutTestResults):
1627         (LayoutTestResults.add_unit_test_failures):
1628         * Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
1629         (UnitTestResults):
1630         (UnitTestResults.results_from_string):
1631         * Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
1632         (UnitTestResultsTest):
1633         (UnitTestResultsTest.test_nostring):
1634         (UnitTestResultsTest.test_emptystring):
1635         (UnitTestResultsTest.test_nofailures):
1636         (test_onefailure):
1637         (test_multiple_failures_per_test):
1638         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1639         (MockCommitQueue.test_results):
1640         (MockCommitQueue.archive_last_test_results):
1641         (FailingTestCommitQueue.test_results):
1642         (test_flaky_test_failure):
1643         (test_failed_archive):
1644         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1645         (LayoutTestResultsReader._create_unit_test_results):
1646         (LayoutTestResultsReader.results):
1647         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1648         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1649         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1650         (PatchAnalysisTaskDelegate.test_results):
1651         (PatchAnalysisTaskDelegate.archive_last_test_results):
1652         (PatchAnalysisTask._test):
1653         (PatchAnalysisTask._build_and_test_without_patch):
1654         (PatchAnalysisTask._test_patch):
1655         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1656         (AbstractEarlyWarningSystem.test_results):
1657         (AbstractEarlyWarningSystem.archive_last_test_results):
1658         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1659         (EarlyWarningSytemTest._test_testing_ews):
1660         * Scripts/webkitpy/tool/commands/queues.py:
1661         (CommitQueue.test_results):
1662         (CommitQueue.archive_last_test_results):
1663         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1664         (CommitQueueTest.test_commit_queue):
1665         (test_rollout):
1666         (test_manual_reject_during_processing):
1667         * Scripts/webkitpy/tool/steps/runtests.py:
1668         (RunTests.run):
1669         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1670         (RunTestsTest.test_webkit_run_unit_tests):
1671
1672 2012-04-06  Aaron Colwell  <acolwell@chromium.org>
1673
1674         Enable MediaSource feature for DumpRenderTree so
1675         MediaSource LayoutTests will pass for Chromium.
1676         https://bugs.webkit.org/show_bug.cgi?id=83053
1677
1678         Reviewed by Dimitri Glazkov.
1679
1680         * DumpRenderTree/chromium/TestShell.cpp:
1681         (TestShell::TestShell):
1682
1683 2012-04-06  George Staikos  <staikos@webkit.org>
1684
1685         Turn on vibration support for BlackBerry.
1686
1687         Reviewed by Rob Buis.
1688
1689         * Scripts/build-webkit:
1690
1691 2012-04-06  Dan Bernstein  <mitz@apple.com>
1692
1693         <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access
1694
1695         Reviewed by Sam Weinig.
1696
1697         * Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.
1698
1699 2012-04-05  Dirk Pranke  <dpranke@chromium.org>
1700
1701         nrwt is failing to upload test results on the chromium-mac-leopard bots
1702         https://bugs.webkit.org/show_bug.cgi?id=83230
1703
1704         Reviewed by Ojan Vafai.
1705
1706         This should fix things properly; FileUploader() was setting the
1707         socket default timeout value, and apparently that doesn't work
1708         properly with urllib. Also, the class had a bad try/finally
1709         block that was causing the exceptions to be swallowed :(.
1710
1711         * Scripts/webkitpy/common/net/file_uploader.py:
1712         (FileUploader.__init__):
1713         (FileUploader._upload_data.callback):
1714         (FileUploader):
1715         (FileUploader._upload_data):
1716         * Scripts/webkitpy/common/net/networktransaction.py:
1717         (NetworkTimeout.__str__):
1718         (NetworkTransaction.run):
1719         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1720         (JSONResultsGeneratorBase.upload_json_files):
1721
1722 2012-04-05  Patrick Gansterer  <paroga@webkit.org>
1723
1724         [Qt] Correct <wtf/*.h> include paths.
1725         https://bugs.webkit.org/show_bug.cgi?id=83270
1726
1727         Reviewed by Eric Seidel.
1728
1729         Modify the #include declerations so that the
1730         wtf types are included using the full path.
1731
1732         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1733
1734 2012-04-05  Philippe Normand  <pnormand@igalia.com>
1735
1736         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
1737         https://bugs.webkit.org/show_bug.cgi?id=83176
1738
1739         Reviewed by Tony Chang.
1740
1741         Refactored the test to use os.path.join() to specify the
1742         core_pattern value of the empty crash log mock.
1743
1744         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1745         (GtkPortTest):
1746         (GtkPortTest.assertLinesEqual):
1747         (GtkPortTest.test_get_crash_log):
1748         (_mock_gdb_output):
1749
1750 2012-04-05  Csaba Osztrogonác  <ossy@webkit.org>
1751
1752         [Qt] Fix includes after QtDeclarative -> QtQML renaming
1753         https://bugs.webkit.org/show_bug.cgi?id=82195
1754
1755         Relanding r112651, because Qt5 is updated everywhere.
1756
1757         * MiniBrowser/qt/BrowserWindow.cpp:
1758         (BrowserWindow::updateVisualMockTouchPoints):
1759         * MiniBrowser/qt/main.cpp:
1760         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1761         (WTR::WrapperWindow::handleStatusChanged):
1762         * qmake/mkspecs/features/unix/default_post.prf:
1763
1764 2012-04-05  Pierre Rossi  <pierre.rossi@gmail.com>
1765
1766         [Qt] WK1/WK2 layout test results are diverging
1767         https://bugs.webkit.org/show_bug.cgi?id=82720
1768
1769         The resolving of default font families was altered in Qt5.
1770         This directly affects the font picked by DRT for layout
1771         tests. Since we want to keep the Qt4 and Qt5 results in line,
1772         we can trick DRT in picking the same font as before for now.
1773
1774         Reviewed by Csaba Osztrogonác.
1775
1776         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1777         (WebKit::initializeTestFonts):
1778
1779 2012-04-05  Kinuko Yasuda  <kinuko@chromium.org>
1780
1781         Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
1782         https://bugs.webkit.org/show_bug.cgi?id=82592
1783
1784         Reviewed by David Levin.
1785
1786         Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.
1787
1788         * DumpRenderTree/chromium/EventSender.cpp:
1789         (EventSender::beginDragWithFiles):
1790
1791 2012-04-04  Tim Horton  <timothy_horton@apple.com>
1792
1793         [mac] WKTR should always keep its windows offscreen
1794         https://bugs.webkit.org/show_bug.cgi?id=83244
1795         <rdar://problem/11188764>
1796
1797         Reviewed by Simon Fraser.
1798
1799         We don't want to allow windows onto the main display; intercept attempts to
1800         change WebKitTestRunnerWindow's frame origin and prevent it from happening.
1801
1802         Also keep around and respond with a new "fake" origin, in case someone is
1803         expecting it to change (I couldn't find any tests that expected this, however).
1804
1805         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1806         (-[WebKitTestRunnerWindow setFrameOrigin:]):
1807         (-[WebKitTestRunnerWindow setFrame:display:animate:]):
1808         (-[WebKitTestRunnerWindow setFrame:display:]):
1809         (-[WebKitTestRunnerWindow frame]):
1810
1811 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1812
1813         Fix typo introduced in r113271.
1814
1815         Unreviewed, build fix.
1816
1817         * Scripts/webkitpy/common/net/file_uploader.py:
1818         (FileUploader._upload_data.callback):
1819         (FileUploader):
1820
1821 2012-04-04  Scott Graham  <scottmg@google.com>
1822
1823         [Chromium, DRT] Bounds check indices on gamepadController
1824         https://bugs.webkit.org/show_bug.cgi?id=83192
1825
1826         Invalid test data would cause bad array accesses. Add simple checks to
1827         ignore such invalid data.
1828
1829         Reviewed by Kent Tamura.
1830
1831         * DumpRenderTree/chromium/GamepadController.cpp:
1832         (GamepadController::connect):
1833         (GamepadController::disconnect):
1834         (GamepadController::setId):
1835         (GamepadController::setButtonCount):
1836         (GamepadController::setButtonData):
1837         (GamepadController::setAxisCount):
1838         (GamepadController::setAxisData):
1839
1840 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1841
1842         nrwt is failing to upload test results on the chromium-mac-leopard bots
1843         https://bugs.webkit.org/show_bug.cgi?id=83230
1844
1845         Reviewed by Ojan Vafai.
1846
1847         More debugging info and a possible fix - stop messing with the
1848         default network timeout, and don't swallow URLErrors.
1849
1850         * Scripts/webkitpy/common/net/file_uploader.py:
1851         (FileUploader._upload_data):
1852         * Scripts/webkitpy/common/net/networktransaction.py:
1853         (NetworkTransaction.run):
1854         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1855         (JSONResultsGeneratorBase.upload_json_files):
1856
1857 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1858
1859         nrwt is failing to upload test results on the chromium-mac-leopard bots
1860         https://bugs.webkit.org/show_bug.cgi?id=83230
1861
1862         Reviewed by Ojan Vafai.
1863
1864         * Scripts/webkitpy/common/net/file_uploader.py:
1865         (FileUploader.__init__):
1866         (FileUploader._upload_data.callback):
1867         (FileUploader):
1868         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1869         (Manager._upload_json_files):
1870         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1871         (JSONResultsGeneratorBase.upload_json_files):
1872
1873 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1874
1875         WKTR needs to implement layoutTestController.setPageVisibility()
1876         https://bugs.webkit.org/show_bug.cgi?id=69554
1877
1878         Reviewed by Simon Fraser.
1879
1880         This patch implements the layoutTestController.setPageVisibility
1881         so WKTR supports the Page Visibility API implementation by using InjectedBundle
1882         to set the visibility state directly to Page.
1883
1884         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1885         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1886         (WTR::LayoutTestController::setPageVisibility):
1887         (WTR):
1888         (WTR::LayoutTestController::resetPageVisibility):
1889         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1890         (LayoutTestController):
1891
1892 2012-04-04  Adam Barth  <abarth@webkit.org>
1893
1894         [Chromium] TestWebKitAPI links in WebCore twice
1895         https://bugs.webkit.org/show_bug.cgi?id=83177
1896
1897         Reviewed by Dimitri Glazkov.
1898
1899         This is causing link errors in the Windows component build. This patch
1900         moves the dependencies a bit lower down in the dependency diagram in
1901         the hopes of removing the duplicate symbols.
1902
1903         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1904
1905 2012-04-04  Christophe Dumez  <christophe.dumez@intel.com>
1906
1907         [EFL][DRT] Catch the "resource,request,willsend" signal
1908         https://bugs.webkit.org/show_bug.cgi?id=82192
1909
1910         Reviewed by Gustavo Noronha Silva.
1911
1912         EFL's DumpRenderTree now catches the "resource,request,willsend"
1913         signal in order to implement the "Blocked access to external URL"
1914         behavior and avoid potential network-related timeouts in the tests.
1915
1916         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1917         (DumpRenderTreeChrome::createView):
1918         (DumpRenderTreeChrome::onWillSendRequest):
1919         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1920         (DumpRenderTreeChrome):
1921
1922 2012-04-04  Patrick Gansterer  <paroga@webkit.org>
1923
1924         [EFL][DRT] Correct <wtf/*.h> include paths.
1925         https://bugs.webkit.org/show_bug.cgi?id=83168
1926
1927         Reviewed by Eric Seidel.
1928
1929         Modify the #include declarations so that the 
1930         wtf types are included using the full path.
1931
1932         * DumpRenderTree/efl/DumpRenderTree.cpp:
1933
1934 2012-04-04  Philippe Normand  <pnormand@igalia.com>
1935
1936         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
1937         https://bugs.webkit.org/show_bug.cgi?id=83176
1938
1939         Reviewed by Tony Chang.
1940
1941         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1942         (test_get_crash_log): Skip the test on non-linux platforms.
1943
1944 2012-04-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1945
1946         [EFL] DRT support for computedStyleIncludingVisitedInfo
1947         https://bugs.webkit.org/show_bug.cgi?id=82190
1948
1949         Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
1950         LayoutTestController so that we can unskip related tests from the skip list.
1951
1952         Reviewed by Antonio Gomes.
1953
1954         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1955         (LayoutTestController::computedStyleIncludingVisitedInfo):
1956
1957 2012-04-04  Raphael Kubo da Costa  <rakuco@webkit.org>
1958
1959         Unreviewed; update my email address once again in the committers
1960         and watch list.
1961
1962         * Scripts/webkitpy/common/config/committers.py: Prefer my
1963         webkit.org email over my FreeBSD.org one.
1964         * Scripts/webkitpy/common/config/watchlist: Ditto.
1965
1966 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1967
1968         [Qt][WK2] QtWebKit2 should support Page Visibility API
1969         https://bugs.webkit.org/show_bug.cgi?id=81164
1970
1971         Reviewed by Kenneth Rohde Christiansen.
1972
1973         Enabling Page Visiblity API for Qt WebKit2.
1974
1975         * qmake/mkspecs/features/features.prf:
1976
1977 2012-04-04  Andras Becsi  <andras.becsi@nokia.com>
1978
1979         [Qt][WK2] Make the WebView a subclass of Flickable
1980         https://bugs.webkit.org/show_bug.cgi?id=83033
1981
1982         Reviewed by Kenneth Rohde Christiansen.
1983
1984         Remove workaround in MiniBrowser and the ScrollIndicator
1985         now that the WebView is a Flickable.
1986
1987         * MiniBrowser/qt/MiniBrowser.pro:
1988         * MiniBrowser/qt/qml/BrowserWindow.qml:
1989         * MiniBrowser/qt/qml/ScrollIndicator.qml:
1990         * WebKitTestRunner/Target.pri:
1991
1992 2012-04-04  Csaba Osztrogonác  <ossy@webkit.org>
1993
1994         REGRESSION(r113144): It made run-webkit-tests always fail
1995         https://bugs.webkit.org/show_bug.cgi?id=83142
1996
1997         Unreviewed trivial fix after r113144.
1998
1999         * Scripts/run-webkit-tests:
2000
2001 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2002
2003         I really hope this is the last build fix. Apparently exec doesn't quite arguments with
2004         double quotations on Windows. Use system instead.
2005
2006         Hopefully, this won't break anything.
2007
2008         * Scripts/run-webkit-tests:
2009
2010 2012-04-03  Keishi Hattori  <keishi@webkit.org>
2011
2012         Disable ENABLE_DATALIST for now
2013         https://bugs.webkit.org/show_bug.cgi?id=82871
2014
2015         Reviewed by Kent Tamura.
2016
2017         * Scripts/build-webkit: Disabled ENABLE_DATALIST.
2018
2019 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2020
2021         Sigh... this isn't going well. I can't even reproduce this issue locally.
2022         Another speculative fix.
2023
2024         * Scripts/run-webkit-tests:
2025
2026 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2027
2028         I don't know why I'm so sloppy today. Another build fix.
2029
2030         * Scripts/run-webkit-tests:
2031
2032 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2033
2034         Hopefully the last build fix for Chromium Windows.
2035
2036         Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.
2037
2038         * Scripts/run-webkit-tests:
2039
2040 2012-04-03  Dirk Pranke  <dpranke@chromium.org>
2041
2042         [Chromium] Lots of timeouts causing Mac10.6 to exit early.
2043         https://bugs.webkit.org/show_bug.cgi?id=83076
2044
2045         Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).
2046
2047         Add logic to the apple mac and chromium mac code to not use
2048         too many workers; it looks like the xserves (and possibly mac
2049         pros) count hyperthreaded cores when they really shouldn't and
2050         we end up using too many workers at a time; this leads to tests
2051         thrashing and timing out.
2052
2053         This change is a temporary fix to make the bots happy while I
2054         look into more profiling and other fixes.
2055
2056         * Scripts/webkitpy/layout_tests/port/mac.py:
2057         (ChromiumMacPort.default_child_processes):
2058
2059         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2060         (ChromiumMacPort.default_child_processes):
2061
2062 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
2063
2064         WebKitTestRunner's EventSender is leaky
2065         https://bugs.webkit.org/show_bug.cgi?id=83099
2066
2067         Reviewed by Beth Dakin.
2068         
2069         Fix leaks of WKNumbers by using the adoptWK idiom, and make
2070         all the code consistent.
2071
2072         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2073         (WTR::EventSendingController::mouseDown):
2074         (WTR::EventSendingController::mouseUp):
2075         (WTR::EventSendingController::mouseMoveTo):
2076         (WTR::EventSendingController::leapForward):
2077         (WTR::EventSendingController::keyDown):
2078         (WTR::EventSendingController::mouseScrollBy):
2079         (WTR::EventSendingController::addTouchPoint):
2080         (WTR::EventSendingController::updateTouchPoint):
2081         (WTR::EventSendingController::setTouchModifier):
2082         (WTR::EventSendingController::releaseTouchPoint):
2083         (WTR::EventSendingController::cancelTouchPoint):
2084
2085 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2086
2087         Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.
2088
2089         * Scripts/run-webkit-tests:
2090         (useNewRunWebKitTests):
2091
2092 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2093
2094         kill-old-processes should kill apache2 and httpd
2095         https://bugs.webkit.org/show_bug.cgi?id=83065
2096
2097         Reviewed by Tony Chang.
2098
2099         Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.
2100
2101         * BuildSlaveSupport/kill-old-processes:
2102
2103 2012-04-03  Tony Chang  <tony@chromium.org>
2104
2105         run the same test steps on test only bots as on build-and-test bots
2106         https://bugs.webkit.org/show_bug.cgi?id=83090
2107
2108         Reviewed by Ryosuke Niwa.
2109
2110         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2111         (TestFactory.__init__):
2112
2113 2012-04-03  Ami Fischman  <fischman@chromium.org>
2114
2115         Add a Media watchlist.
2116         https://bugs.webkit.org/show_bug.cgi?id=83071
2117
2118         Reviewed by David Levin.
2119
2120         * Scripts/webkitpy/common/config/watchlist:
2121
2122 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
2123
2124         Fix large leak in WebKitTestRunner
2125         https://bugs.webkit.org/show_bug.cgi?id=83084
2126
2127         Reviewed by Beth Dakin.
2128         
2129         Fix a leak of the bimap backing store created when doing pixel and
2130         ref tests. This leak was causing serious thrash on the test bots.
2131         
2132         We don't need to allocate memory for CGBitmapContextCreate(); if we
2133         pass NULL, it will allocate and manage its own backing store.
2134
2135         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2136         (WTR::createCGContextFromImage):
2137
2138 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2139
2140         Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.
2141
2142         * BuildSlaveSupport/built-product-archive:
2143         (unzipArchive):
2144
2145 2012-04-03  Ojan Vafai  <ojan@chromium.org>
2146
2147         Give more human friendly error message when builders fail to load or have stale data.
2148         https://bugs.webkit.org/show_bug.cgi?id=83058
2149
2150         Reviewed by Eric Seidel.
2151
2152         * TestResultServer/static-dashboards/dashboard_base.js:
2153         (addError):
2154         (addBuilderLoadErrors):
2155         (handleLocationChange):
2156         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2157
2158 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2159
2160         Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.
2161
2162         * BuildSlaveSupport/built-product-archive:
2163         (extractBuiltProduct):
2164
2165 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2166
2167         Yet another build fix after r113067. Don't trigger Chromium testers right away
2168         since they're now triggered by builders.
2169
2170         * BuildSlaveSupport/build.webkit.org-config/config.json:
2171
2172 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2173
2174         Another build fix after r113067 for Mac port.
2175         It turned out that archiving the entire build directory doesn't work.
2176
2177         * BuildSlaveSupport/built-product-archive:
2178         (createZipManually):
2179         (createZip):
2180         (archiveBuiltProduct):
2181
2182 2012-04-03  Mike Lattanzio  <mlattanzio@rim.com>
2183
2184         [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
2185         https://bugs.webkit.org/show_bug.cgi?id=82643
2186
2187         Update LayoutTestController to accomodate the new find API.
2188         It now provides caseSensitive functionality to DRT.
2189
2190         Internal Review by Andy Chen.
2191
2192         Reviewed by Rob Buis.
2193
2194         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2195         (LayoutTestController::findString):
2196
2197 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2198
2199         Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
2200         because download-built-product creates the build directory as needed.
2201
2202         This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.
2203
2204         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2205         (TestFactory.__init__):
2206
2207 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2208
2209         Build fix after r113067. Don't delete the build directory.
2210
2211         * BuildSlaveSupport/built-product-archive:
2212         (extractBuiltProduct):
2213
2214 2012-04-02  Ojan Vafai  <ojan@chromium.org>
2215
2216         Load all builder lists from the buildbot json
2217         https://bugs.webkit.org/show_bug.cgi?id=82998
2218
2219         Reviewed by Adam Barth.
2220
2221         Also, remove an unnecessary list of test types. Now we don't hard-code
2222         builder names anywhere and we only have a single hard-coded list of
2223         test types.
2224
2225         * TestResultServer/static-dashboards/builders.js:
2226         (BuilderMaster.prototype.logPath):
2227         (BuilderMaster.prototype.builderJsonPath):
2228         (requestBuilderList.xhr.onload):
2229         (requestBuilderList.xhr.onerror):
2230         (isChromiumDepsFyiGpuTestRunner):
2231         (isChromiumTipOfTreeGpuTestRunner):
2232         (isChromiumDepsGTestRunner):
2233         (isChromiumDepsCrosGTestRunner):
2234         (isChromiumTipOfTreeGTestRunner):
2235         (onBuilderListLoad):
2236         (loadBuildersList):
2237         * TestResultServer/static-dashboards/dashboard_base.js:
2238         (parseCrossDashboardParameters):
2239         (currentBuilderGroupCategory):
2240         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2241         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2242         (testHtmlForTestsWithExpectationsButNoFailures):
2243         (testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
2244         (testGenerateChromiumDepsGTestBuildersFromBuilderList):
2245         (testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
2246         (testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
2247         * TestResultServer/static-dashboards/timeline_explorer.html:
2248
2249 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
2250
2251         Chromium testers should extract builds instead of building on their own
2252         https://bugs.webkit.org/show_bug.cgi?id=82996
2253
2254         Reviewed by Tony Chang.
2255
2256         Make Chromium builders triggger Chromium testers and make testers download and extract builds
2257         from the buildbot master instead of building binaries on their own.
2258
2259         Add download-built-product to wrap curl used in the download-built-product step since Windows
2260         does not provide "curl" natively.
2261
2262         * BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
2263         Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
2264         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2265         (DownloadBuiltProduct): Call download-built-product instead of curl.
2266         * BuildSlaveSupport/built-product-archive:
2267         (createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
2268         needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
2269         (archiveBuiltProduct): Zip the configuration build directory on Mac port.
2270         (unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
2271         (extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
2272         * BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.
2273
2274 2012-04-03  Martin Robinson  <mrobinson@igalia.com>
2275
2276         [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
2277         https://bugs.webkit.org/show_bug.cgi?id=82473
2278
2279         Reviewed by Philippe Normand.
2280
2281         Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
2282         was ever run.
2283
2284         * gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
2285         check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
2286
2287 2012-04-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2288
2289         [EFL] DRT support for setInteractiveFormValidationEnabled
2290         https://bugs.webkit.org/show_bug.cgi?id=82050
2291
2292         Enable interactive form validation and unskip tests from the
2293         skip list.
2294
2295         Reviewed by Antonio Gomes.
2296
2297         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2298         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2299
2300 2012-04-03  Philippe Normand  <pnormand@igalia.com>
2301
2302         Unreviewed, another test-webkitpy fix-up after r113037.
2303
2304         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
2305         crash dump depending on current environment.
2306
2307 2012-04-03  Philippe Normand  <pnormand@igalia.com>
2308
2309         Unreviewed, test-webkitpy build fix after r113037.
2310
2311         * Scripts/webkitpy/layout_tests/port/gtk.py:
2312         (GtkPort._get_crash_log):
2313
2314 2012-04-03  Philippe Normand  <pnormand@igalia.com>
2315
2316         [GTK] crash log reports support
2317         https://bugs.webkit.org/show_bug.cgi?id=81659
2318
2319         Reviewed by Martin Robinson.
2320
2321         Removed the daemontools crashmon/xvfb scripts and implemented the crash
2322         log reporting in the NRWT Gtk port. To get proper crash logs one
2323         needs to set the core pattern like this:
2324         echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
2325         Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
2326         environment variable.
2327
2328         * BuildSlaveSupport/gtk/README:
2329         * BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
2330         * BuildSlaveSupport/gtk/crashmon/log/run: Removed.
2331         * BuildSlaveSupport/gtk/crashmon/run: Removed.
2332         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2333         * BuildSlaveSupport/gtk/xvfb/log/run: Removed.
2334         * BuildSlaveSupport/gtk/xvfb/run: Removed.
2335         * Scripts/new-run-webkit-tests:
2336         * Scripts/webkitpy/layout_tests/port/gtk.py:
2337         (GtkDriver.stop):
2338         (GtkPort.show_results_html_file):
2339         (GtkPort):
2340         (GtkPort._get_gdb_output):
2341         (GtkPort._get_crash_log):
2342         (GtkPort._get_crash_log.match_filename):
2343         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2344         (GtkPortTest):
2345         (test_show_results_html_file):
2346         (assertLinesEqual):
2347         (_mock_gdb_output):
2348         (test_get_crash_log):
2349
2350 2012-04-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2351
2352         Enable and connect the WebInspectorServer with WebKit2 pages.
2353         https://bugs.webkit.org/show_bug.cgi?id=73094
2354
2355         Reviewed by Simon Hausmann.
2356
2357         Enable developer extras on pages in MiniBrowser for Qt.
2358
2359         * MiniBrowser/qt/qml/BrowserWindow.qml:
2360
2361 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
2362
2363         [EFL] LayoutTestController needs implementation of setDefersLoading
2364         https://bugs.webkit.org/show_bug.cgi?id=82890
2365
2366         Reviewed by Philippe Normand.
2367
2368         Implement setDefersLoading() in EFL's LayoutTestController so that the
2369         corresponding test case can be removed from the skip list.
2370
2371         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2372         (LayoutTestController::setDefersLoading):
2373
2374 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
2375
2376         [EFL] LayoutTestController needs implementation of goBack
2377         https://bugs.webkit.org/show_bug.cgi?id=81914
2378
2379         Reviewed by Philippe Normand.
2380
2381         Implement goBack() in EFL's LayoutTestController by calling
2382         ewk_frame_back().
2383
2384         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2385         (LayoutTestController::goBack):
2386
2387 2012-04-03  Alexander Shalamov  <alexander.shalamov@intel.com>
2388
2389         [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
2390         https://bugs.webkit.org/show_bug.cgi?id=82589
2391
2392         Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
2393         in order to unskip printing/page-format-data.html
2394
2395         Reviewed by Philippe Normand.
2396
2397         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2398         (LayoutTestController::pageSizeAndMarginsInPixels):
2399
2400 2012-04-03  Simon Pena  <spena@igalia.com>
2401
2402         [GTK] DRT missing didRunInsecureContent notification
2403         https://bugs.webkit.org/show_bug.cgi?id=59367
2404
2405         Reviewed by Philippe Normand.
2406
2407         Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
2408         the main WebFrame or any other WebFrame created later. Added
2409         "didRunInsecureContent" notification in the callback in order to
2410         get the LayoutTests passing.
2411
2412         * DumpRenderTree/gtk/DumpRenderTree.cpp: Connect
2413         to WebFrame's "insecure-content-run" signal and add
2414         didRunInsecureContent notification in the callback to get the
2415         LayoutTests passing.
2416         (didRunInsecureContent):
2417         (createWebView):
2418
2419 2012-04-03  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2420
2421         rebaseline-server: Make it possible to not launch a browser with the server.
2422         https://bugs.webkit.org/show_bug.cgi?id=82999
2423
2424         Reviewed by Adam Barth.
2425
2426         Add the `--no-show-results' option, which lets one decide not to
2427         launch a web browser when running the rebaseline server.  This is
2428         especially useful if the default browser is not the wanted one, or
2429         if the rebaseline server page is already open.
2430
2431         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
2432         (AbstractLocalServerCommand.__init__):
2433         (AbstractLocalServerCommand.execute):
2434
2435 2012-04-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2436
2437         EFL's LayoutTestController disableImageLoading implementation.
2438         https://bugs.webkit.org/show_bug.cgi?id=82848
2439
2440         Reviewed by Hajime Morita.
2441
2442         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2443         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2444         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2445         (LayoutTestController::disableImageLoading):
2446
2447 2012-04-02  Alexander Shalamov  <alexander.shalamov@intel.com>
2448
2449         [EFL] LayoutTestController needs implementation of isPageBoxVisible
2450         https://bugs.webkit.org/show_bug.cgi?id=82591
2451
2452         Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
2453         in order to unskip printing/page-format-data.html
2454
2455         Reviewed by Hajime Morita.
2456
2457         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2458         (LayoutTestController::isPageBoxVisible):
2459
2460 2012-04-02  Simon Fraser  <simon.fraser@apple.com>
2461
2462         run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
2463         https://bugs.webkit.org/show_bug.cgi?id=82962
2464
2465         Reviewed by Dirk Pranke.
2466
2467         Ensure that _build_path() returns an absolute path.
2468
2469         Eric Seidel also had to deploy MockConfig in a bunch of places
2470         in order to correct previous testing errors where we were
2471         pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
2472         was a real path.  The real Config object calls run_command("webkit-build-directory")
2473         to read the WebKit build directory from the webkitdirs.pm perl code.
2474         MockConfig abstracts this away and always returns "/mock-build" during
2475         testing.  This change is much larger than one would think necessary
2476         because of needing to deploy this MockConfig class.
2477
2478         * Scripts/webkitpy/layout_tests/port/webkit.py:
2479         (WebKitPort._build_path):
2480
2481 2012-04-02  Ojan Vafai  <ojan@chromium.org>
2482
2483         Fix snafu in r112971. We were never calling parseParameter for builder.
2484
2485         * TestResultServer/static-dashboards/dashboard_base.js:
2486
2487 2012-04-02  Ojan Vafai  <ojan@chromium.org>
2488
2489         Generate the lists of all layout test builders from the buildbot json
2490         https://bugs.webkit.org/show_bug.cgi?id=82924
2491
2492         Reviewed by Mihai Parparita.
2493
2494         In order to make this work, cleaned up a lot of existing technical debt.
2495         -Got rid of expectations builder. This concept is outdated and just dead code.
2496         -Split hash parameter parsing into two functions. One for dashboard_base
2497         (crossDashboardParameters) and one for the specific dashboard html file
2498         (dashboardSpecificParameters). In the old world, parseParameters needed to
2499         be called twice and depended on it's own output the first time through.
2500         Now we only need to parse crossDashboardParameters first and crossDashboardParameters
2501         doesn't depend on the output of crossDashboardParameters.
2502         -Lots of variable/method renames due to the above.
2503         -g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
2504         for that dashboard.
2505
2506         * TestResultServer/static-dashboards/aggregate_results.html:
2507         * TestResultServer/static-dashboards/builders.js:
2508         (BuilderGroup):
2509         (BuilderGroup.prototype.setup):
2510         (jsonRequest.xhr.onload):
2511         (jsonRequest.xhr.onerror):
2512         (isWebkitTestRunner):
2513         (isChromiumWebkitTipOfTreeTestRunner):
2514         (isChromiumWebkitDepsTestRunner):
2515         (generateBuildersFromBuilderList):
2516         (onLayoutTestBuilderListLoad):
2517         (onErrorLoadingBuilderList):
2518         (loadBuildersList):
2519         * TestResultServer/static-dashboards/dashboard_base.js:
2520         (handleValidHashParameterWrapper):
2521         (queryHashAsMap):
2522         (parseParameter):
2523         (parseCrossDashboardParameters):
2524         (parseDashboardSpecificParameters):
2525         (parseParameters):
2526         (diffStates):
2527         (defaultValue):
2528         (isLayoutTestResults):
2529         (isGPUTestResults):
2530         (currentBuilderGroupCategory):
2531         (currentBuilderGroup):
2532         (initBuilders):
2533         Now that we've split parameter parseing, these methods no longer need
2534         to take an optional state. They can always just use the global cross-dashboard state.
2535
2536         (pathToBuilderResultsFile):
2537         (appendJSONScriptElementFor):
2538         (appendJSONScriptElements):
2539         (handleResourceLoadError):
2540         (haveJsonFilesLoaded):
2541         (combinedDashboardState):
2542         (setQueryParameter):
2543         (permaLinkURLHash):
2544         (toggleQueryParameter):
2545         (queryParameterValue):
2546         (selectHTML):
2547         (htmlForTestTypeSwitcher):
2548         (g_handleBuildersListLoaded):
2549         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2550         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2551         (testPlatformAndBuildType):
2552         (testSubstringList):
2553         (testHtmlForTestTypeSwitcherGroup):
2554         (testLookupVirtualTestSuite):
2555         (testBaseTest):
2556         (generateBuildersFromBuilderListHelper):
2557         (testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
2558         (testGenerateChromiumWebkitDepsBuildersFromBuilderList):
2559         (assertObjectsDeepEqual):
2560         (testQueryHashAsMap):
2561         (testDiffStates):
2562         * TestResultServer/static-dashboards/timeline_explorer.html:
2563         * TestResultServer/static-dashboards/treemap.html:
2564
2565 2012-04-02  Tony Chang  <tony@chromium.org>
2566
2567         check-webkit-style errors when removing .png files
2568         https://bugs.webkit.org/show_bug.cgi?id=82933
2569
2570         Reviewed by David Levin.
2571
2572         * Scripts/webkitpy/style/patchreader.py:
2573         (PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).
2574         * Scripts/webkitpy/style/patchreader_unittest.py:
2575         (test_check_patch_with_png_deletion):
2576
2577 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2578
2579         Unreviewed, rolling out r112948.
2580         http://trac.webkit.org/changeset/112948
2581         https://bugs.webkit.org/show_bug.cgi?id=82961
2582
2583         Someone else already checked in a similar change (Requested by
2584         sundiamonde on #webkit).
2585
2586         * Scripts/webkitpy/layout_tests/port/webkit.py:
2587         (WebKitDriver._start):
2588
2589 2012-04-02  Adam Barth  <abarth@webkit.org>
2590
2591         garden-o-matic isn't able to rebaseline audio failures
2592         https://bugs.webkit.org/show_bug.cgi?id=82957
2593
2594         Reviewed by Chris Rogers.
2595
2596         This patch just adds "wav" to the list of test suffixes and updates the
2597         unit tests to show that we're rebaselining audio tests results now too.
2598
2599         * Scripts/webkitpy/tool/commands/rebaseline.py:
2600         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2601         (test_rebaseline_updates_expectations_file):
2602
2603 2012-04-02  Adam Barth  <abarth@webkit.org>
2604
2605         garden-o-matic should let you listen to audio failures
2606         https://bugs.webkit.org/show_bug.cgi?id=82953
2607
2608         Reviewed by Chris Rogers.
2609
2610         Now that we've actually got an audio failure on the bots, we can clean
2611         up the last stray bugs.  This patch doesn't have any tests because I'm
2612         lame.
2613
2614         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2615         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2617         (.):
2618
2619 2012-04-02  Stephanie Lewis  <slewis@apple.com>
2620
2621         run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
2622         https://bugs.webkit.org/show_bug.cgi?id=82552
2623
2624         Reviewed by Dirk Pranke.
2625
2626         Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
2627
2628         * Scripts/webkitpy/layout_tests/port/webkit.py:
2629         (WebKitDriver._start):
2630
2631 2012-04-02  Dirk Pranke  <dpranke@chromium.org>
2632
2633         NRWT is not printing out the builder it's uploading JSON files for
2634         https://bugs.webkit.org/show_bug.cgi?id=82834
2635
2636         Reviewed by Ojan Vafai.
2637
2638         Handle log messages of the form log.info("%s", arg) properly ...
2639         I didn't even know you could do that :).
2640
2641         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2642         (_LogHandler.emit):
2643         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2644         (RegularTest.test_log_args):
2645         (VerboseTest.test_log_args):
2646
2647 2012-04-02  Tim Horton  <timothy_horton@apple.com>
2648
2649         [mac] LayoutTestHelper crashes if there is no main display
2650         https://bugs.webkit.org/show_bug.cgi?id=82944
2651         <rdar://problem/11162954>
2652
2653         Reviewed by Simon Fraser.
2654
2655         If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
2656         a null dictionary, so we shouldn't go ahead and try to read from it.
2657
2658         * DumpRenderTree/mac/LayoutTestHelper.m:
2659         (installLayoutTestColorProfile):
2660
2661 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
2662
2663         [Qt][WK2] Set up plugin process on Unix
2664         https://bugs.webkit.org/show_bug.cgi?id=72121
2665
2666         Reviewed by Simon Hausmann.
2667
2668         * qmake/mkspecs/features/features.prf: Reenable plugins
2669         and turn on plugin process.
2670
2671 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2672
2673         Unreviewed, rolling out r112868, r112879, and r112881.
2674         http://trac.webkit.org/changeset/112868
2675         http://trac.webkit.org/changeset/112879
2676         http://trac.webkit.org/changeset/112881
2677         https://bugs.webkit.org/show_bug.cgi?id=82901
2678
2679         "Build fail on bots." (Requested by kbalazs on #webkit).
2680
2681         * MiniBrowser/gtk/GNUmakefile.am:
2682         * qmake/mkspecs/features/features.prf:
2683
2684 2012-04-02  Philippe Normand  <pnormand@igalia.com>
2685
2686         [GTK] Enable shadow-dom in build-webkit.
2687
2688         Rubber-stamped by Gustavo Noronha Silva.
2689
2690         * Scripts/build-webkit: Enable shadow-dom build, this is need to
2691         have a working build currently.
2692
2693 2012-04-02  Andreas Kling  <kling@webkit.org>
2694
2695         Adding Zalan Bujtas to committers list.
2696
2697         * Scripts/webkitpy/common/config/committers.py:
2698
2699 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
2700
2701         [Qt][WK2] Set up plugin process on Unix
2702         https://bugs.webkit.org/show_bug.cgi?id=72121
2703
2704         Reviewed by Simon Hausmann.
2705
2706         * qmake/mkspecs/features/features.prf: Reenable plugins
2707         and turn on plugin process.
2708
2709 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2710
2711         Unreviewed, rolling out r112651.
2712         http://trac.webkit.org/changeset/112651
2713         https://bugs.webkit.org/show_bug.cgi?id=82887
2714
2715         It doesn't work with older Qt5 (Requested by Ossy on #webkit).
2716
2717         * MiniBrowser/qt/BrowserWindow.cpp:
2718         (BrowserWindow::updateVisualMockTouchPoints):
2719         * MiniBrowser/qt/main.cpp:
2720         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2721         (WTR::WrapperWindow::handleStatusChanged):
2722         * qmake/mkspecs/features/unix/default_post.prf:
2723
2724 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2725
2726         [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
2727         https://bugs.webkit.org/show_bug.cgi?id=82877
2728
2729         Reviewed by Philippe Normand.
2730
2731         * Scripts/run-gtk-tests:
2732         (TestRunner.run_tests): Use replace instead of lstrip to remove
2733         the programs_path from the full path of unit tests.
2734
2735 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2736
2737         Unreviewed. Skip flaky unit tests.
2738
2739         * Scripts/run-gtk-tests:
2740         (TestRunner):
2741
2742 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
2743
2744         webkitpy rebaseline.
2745
2746         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2747         (test_run_test_set_with_json_output):
2748         (test_run_test_set_with_json_source):
2749
2750 2012-04-01  Ryosuke Niwa  <rniwa@webkit.org>
2751
2752         perf-o-matic should store test results' units
2753         https://bugs.webkit.org/show_bug.cgi?id=82852
2754
2755         Reviewed by Kentaro Hara.
2756
2757         Include units in the results JSON.
2758
2759         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2760         (PerfTestsRunner._process_chromium_style_test_result):
2761         (PerfTestsRunner._process_parser_test_result):
2762
2763 2012-04-01  Tony Tseung  <tseung@apple.com>
2764
2765         Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
2766         composite fonts from existing physical fonts.
2767         <rdar://problem/10717370>
2768         https://bugs.webkit.org/show_bug.cgi?id=82810
2769             
2770         A new test font of this kind as been added to the test tools for running the webkit-tests
2771
2772         Reviewed by Dan Bernstein.
2773
2774         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2775         Added new dependency SampleFont.sfont
2776         
2777         * DumpRenderTree/fonts/SampleFont.sfont: Added.
2778         
2779         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2780         * DumpRenderTree/mac/DumpRenderTree.mm:
2781         (allowedFontFamilySet):
2782         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
2783         
2784         (activateTestingFonts):
2785         Added the registration of the Composite Font Referene sample font
2786         
2787         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2788         (WTR::allowedFontFamilySet):
2789         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
2790
2791         (WTR::activateFonts):
2792         Added the registration of the Composite Font Referene sample font
2793
2794         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2795         Added new dependency SampleFont.sfont
2796
2797         * WebKitTestRunner/fonts/SampleFont.sfont: Added.
2798
2799 2012-04-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2800
2801         Support the Network Information API
2802         https://bugs.webkit.org/show_bug.cgi?id=73528
2803
2804         Reviewed by Adam Barth.
2805
2806         Add network information API feature to build script.
2807
2808         * Scripts/build-webkit:
2809
2810 2012-03-31  Ojan Vafai  <ojan@chromium.org>
2811
2812         Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
2813         https://bugs.webkit.org/show_bug.cgi?id=82839
2814
2815         Reviewed by Adam Barth.
2816
2817         Also, update various hard-coded lists for WIN7 and Lion ports.
2818         This is necessary since the new list of builders grabbed off the
2819         buildbot includes Lion.
2820
2821         * TestResultServer/static-dashboards/builders.js:
2822         (generateWebkitBuildersFromBuilderList):
2823         (xhr.onreadystatechange):
2824         Don't use dashboard_base's request method to avoid layering violation.
2825
2826         * TestResultServer/static-dashboards/dashboard_base.js:
2827         (parseParameters):
2828         (initBuilders):
2829         (haveJsonFilesLoaded):
2830         (g_handleBuildersListLoaded):
2831         Block loading the JSON files for each builder until we actually have a list of builders.
2832
2833         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2834         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2835         (testPlatformAndBuildType):
2836         (testGenerateWebkitBuildersFromBuilderList):
2837         * TestResultServer/static-dashboards/timeline_explorer.html:
2838         * TestResultServer/static-dashboards/treemap.html:
2839         Delay generating the page until the builder list has loaded.
2840
2841 2012-03-31  Ojan Vafai  <ojan@chromium.org>
2842
2843         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
2844         https://bugs.webkit.org/show_bug.cgi?id=82799
2845
2846         Reviewed by Eric Seidel.
2847
2848         If we don't run a test, mark it as skipped.
2849
2850         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2851         (Manager._mark_interrupted_tests_as_skipped):
2852         (Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
2853         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2854         (ManagerTest.test_interrupt_if_at_failure_limits):
2855
2856 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2857
2858         One more build fix after r112781 for Chromium Windows.
2859         Don't copy zip .idb files.
2860
2861         * BuildSlaveSupport/built-product-archive:
2862         (copyBuildFiles):
2863
2864 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2865
2866         Yet another build fix after r112781 for Chromium Windows.
2867         Run webkit-build-directory by perl explicitly.
2868
2869         * BuildSlaveSupport/built-product-archive:
2870         (determineWebKitBuildDirectory):
2871
2872 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2873
2874         Fix the syntax error in master.cfg after r112734.
2875
2876         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2877         (unitTestsSupported):
2878
2879 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2880
2881         Another build fix after r112781.
2882
2883         * BuildSlaveSupport/built-product-archive:
2884         (createZip):
2885
2886 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2887
2888         Build fix after r112781.
2889
2890         * BuildSlaveSupport/built-product-archive:
2891         (createZipManually):
2892         (createZip):
2893
2894 2012-03-30  Ryosuke Niwa  <rniwa@webkit.org>
2895
2896         Chromium bots should upload archived built files
2897         https://bugs.webkit.org/show_bug.cgi?id=82666
2898
2899         Reviewed by Tony Chang.
2900
2901         * BuildSlaveSupport/build.webkit.org-config/config.json:
2902         * BuildSlaveSupport/built-product-archive:
2903         (main):
2904         (determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
2905         call out to webkit-build-directory.
2906         (removeDirectoryIfExists): Extracted.
2907         (copyBuildFiles): Added to avoid archiving useless intermedinate files.
2908         (createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
2909         (createZipManually.addToArchive):
2910         (createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
2911         (archiveBuiltProduct): Add support for Chromium port.
2912         * Scripts/webkit-build-directory: Add support for --platform options.
2913
2914 2012-03-30  Dan Bernstein  <mitz@apple.com>
2915
2916         Reverted r112767, because it caused many vertical text tests to fail.
2917
2918         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2919         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
2920         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2921         * DumpRenderTree/mac/DumpRenderTree.mm:
2922         (allowedFontFamilySet):
2923         (activateTestingFonts):
2924         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2925         (WTR::allowedFontFamilySet):
2926         (WTR::activateFonts):
2927         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2928         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
2929
2930 2012-03-30  Malcolm MacLeod  <malcolm.macleod@tshwanedje.com>
2931
2932         [wx] Move wxWebKit API into WebKit namespace.
2933         https://bugs.webkit.org/show_bug.cgi?id=82740
2934
2935         Reviewed by Kevin Ollivier.
2936
2937         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2938         (LayoutWebViewEventHandler::LayoutWebViewEventHandler):
2939         (LayoutWebViewEventHandler::bindEvents):
2940         (LayoutWebViewEventHandler::OnLoadEvent):
2941         (LayoutWebViewEventHandler::OnAlertEvent):
2942         (LayoutWebViewEventHandler::OnConfirmEvent):
2943         (LayoutWebViewEventHandler::OnPromptEvent):
2944         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2945         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
2946         (LayoutWebViewEventHandler::OnWindowObjectClearedEvent):
2947         (LayoutWebViewEventHandler):
2948         (dumpFramesAsText):
2949         (dump):
2950         (MyApp::OnInit):
2951         * wx/browser/browser.cpp:
2952         (MyApp::OnInit):
2953
2954 2012-03-30  Eli Fidler  <efidler@rim.com>
2955
2956         Enable OpenType Sanitizer for BlackBerry port.
2957         https://bugs.webkit.org/show_bug.cgi?id=82782
2958
2959         Reviewed by Eric Seidel.
2960
2961         * Scripts/webkitdirs.pm:
2962         (blackberryCMakeArguments): add OTS to include path
2963
2964 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
2965
2966         run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
2967         as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
2968         is found.
2969
2970         <rdar://problem/11158581>
2971         
2972         Reviewed by Mark Rowe.
2973
2974         * Scripts/webkitpy/layout_tests/port/webkit.py:
2975         (WebKitDriver._start):
2976
2977 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
2978
2979         Disable run-api-tests on release mac builds
2980         https://bugs.webkit.org/show_bug.cgi?id=82788
2981
2982         Reviewed by Ryosuke Niwa.
2983         
2984         TestWebKitAPI crashes every time in release builds currently
2985         (https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
2986         run-api-tests on mac release builders.
2987
2988         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2989         (unitTestsSupported):
2990
2991 2012-03-30  Chang Shu  <cshu@webkit.org>
2992
2993         Unreviewed. Update my email.
2994
2995         * Scripts/webkitpy/common/config/committers.py:
2996
2997 2012-03-30  Chris Fleizach  <cfleizach@apple.com>
2998
2999         AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
3000         https://bugs.webkit.org/show_bug.cgi?id=82745
3001
3002         Reviewed by Simon Fraser.
3003
3004         * DumpRenderTree/AccessibilityUIElement.cpp:
3005         (rangeForPositionCallback):
3006         (AccessibilityUIElement::rangeForPosition):
3007         (AccessibilityUIElement::getJSClass):
3008         * DumpRenderTree/AccessibilityUIElement.h:
3009         (AccessibilityUIElement):
3010         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3011         (AccessibilityUIElement::rangeForPosition):
3012         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3013         (WTR::AccessibilityUIElement::rangeForPosition):
3014         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3015         (AccessibilityUIElement):
3016         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3017         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3018         (WTR::AccessibilityUIElement::rangeForPosition):
3019         (WTR):
3020
3021 2012-03-30  David Barr  <davidbarr@chromium.org>
3022
3023         Split up top-level .gitignore and .gitattributes
3024         https://bugs.webkit.org/show_bug.cgi?id=82687
3025
3026         Reviewed by Tor Arne Vestbø.
3027
3028         * .gitattributes: Added.
3029         * .gitignore: Added.
3030         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
3031         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.
3032
3033 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
3034
3035         Actually remove the ChromiumOS GTK builder, like r112673 said it would.
3036
3037         * TestResultServer/static-dashboards/builders.js:
3038
3039 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
3040
3041         Update ChromiumOS bot names in builders.js to reflect changes made by
3042         http://crrev.com/129835
3043         
3044         Also removes the ChromiumOS GTK builder, which was removed by
3045         http://crrev.com/129835
3046
3047         * TestResultServer/static-dashboards/builders.js:
3048
3049 2012-03-30  Vineet Chaudhary  <rgf748@motorola.com>
3050
3051         [GTK] Disable introspection build in the at-spi2-core module.
3052         https://bugs.webkit.org/show_bug.cgi?id=82729
3053
3054         Reviewed by Philippe Normand.
3055
3056         This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
3057
3058         * gtk/jhbuild.modules: Disable introspection.
3059
3060 2012-03-30  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3061
3062         Add a "preview" state to Page Visibility API implementation
3063         https://bugs.webkit.org/show_bug.cgi?id=81355
3064
3065         Reviewed by Adam Barth.
3066
3067         Updating the Page Visibility API implementation to the current spec version.
3068
3069         * DumpRenderTree/chromium/LayoutTestController.cpp:
3070         (LayoutTestController::setPageVisibility):
3071
3072 2012-03-30  Keishi Hattori  <keishi@webkit.org>
3073
3074         Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
3075         https://bugs.webkit.org/show_bug.cgi?id=80972
3076
3077         Reviewed by Kent Tamura.
3078
3079         * Scripts/build-webkit:
3080         * qmake/mkspecs/features/features.prf:
3081
3082 2012-03-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
3083
3084         [Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
3085         https://bugs.webkit.org/show_bug.cgi?id=82195
3086
3087         Reviewed by Simon Hausmann.
3088
3089         * MiniBrowser/qt/BrowserWindow.cpp:
3090         (BrowserWindow::updateVisualMockTouchPoints):
3091         * MiniBrowser/qt/main.cpp:
3092         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3093         (WTR::WrapperWindow::handleStatusChanged):
3094         * qmake/mkspecs/features/unix/default_post.prf:
3095
3096 2012-03-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3097
3098         [EFL] Implement LayoutTestController::setMinimumTimerInterval
3099         https://bugs.webkit.org/show_bug.cgi?id=81220
3100
3101         Add missing implementation setMinimumTimerInterval to EFL's
3102         LayoutTestController so that we can unskip related tests from the skip list.
3103
3104         Reviewed by Philippe Normand.
3105
3106         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3107         (LayoutTestController::setMinimumTimerInterval):
3108
3109 2012-03-29  Dan Bernstein  <mitz@apple.com>
3110
3111         Removed “Intel” from the Lion builders’ names.
3112
3113         Rubber-stamped by Mark Rowe.
3114
3115         * BuildSlaveSupport/build.webkit.org-config/config.json:
3116         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3117         (LeaksViewer._displayURLPrompt):
3118
3119 2012-03-29  Mihai Parparita  <mihaip@chromium.org>
3120
3121         [Chromium] Add sharded ChromiumOS debug bots to builders.js
3122         https://bugs.webkit.org/show_bug.cgi?id=82639
3123
3124         Reviewed by Eric Seidel.
3125
3126         The bots were sharded by http://crrev.com/129613, update builders.js
3127         to reflect this.
3128
3129         * TestResultServer/static-dashboards/builders.js:
3130
3131 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
3132
3133         remove support for junit-style xml output from test-webkitpy
3134         https://bugs.webkit.org/show_bug.cgi?id=82279
3135
3136         Reviewed by Eric Seidel.
3137
3138         This was added when we were looking into integrating w/ Jenkins
3139         rather than buildbot, but I believe that project got shelved, so
3140         this is unused. We can always add it back in later as necessary.
3141
3142         * Scripts/webkitpy/test/main.py:
3143         (Tester._parse_args):
3144         (Tester._run_tests):
3145         * Scritps/webkitpy/thirdparty/__init__.py:
3146
3147 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
3148
3149         new-run-webkit-tests: crashes when it fails to decode a stack trace
3150         https://bugs.webkit.org/show_bug.cgi?id=82673
3151
3152         Unreviewed, build fix.
3153
3154         We are assuming the stdout/stderr output from the driver is utf-8
3155         encoded when we get stack traces; this may not be a valid
3156         assumption generally, but if we do get strings that aren't valid
3157         utf-8, we would crash. Now we will ignore any decoding errors.
3158
3159         * Scripts/webkitpy/layout_tests/port/base.py:
3160         (Port._get_crash_log):
3161         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3162         (PortTestCase.test_get_crash_log):
3163
3164 2012-03-29  Simon Fraser  <simon.fraser@apple.com>
3165
3166         Scripts fail to detect when a tool crashes
3167         https://bugs.webkit.org/show_bug.cgi?id=82659
3168
3169         Reviewed by Mark Rowe.
3170         
3171         Have exitStatus() detect when the process fail to exit cleanly
3172         (possibly because of a crash), and return a non-zero exit code
3173         in that case.
3174
3175         * Scripts/VCSUtils.pm:
3176         (exitStatus):
3177
3178 2012-03-29  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3179
3180         [GTK][EFL] run-javascriptcore-tests should be run through jhbuild
3181         https://bugs.webkit.org/show_bug.cgi?id=82581
3182
3183         Reviewed by Martin Robinson.
3184
3185         Running Javascriptcore tests through jhbuild
3186         for consistency with run-webkit-tests and in order to
3187         avoid confusing libraries when facing regressions.
3188
3189         * Scripts/run-javascriptcore-tests:
3190
3191 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
3192
3193         test-webkitpy: add --timing
3194         https://bugs.webkit.org/show_bug.cgi?id=82550
3195
3196         Reviewed by Eric Seidel.
3197
3198         This patch adds a --timing option that will display the time
3199         each test takes. It also removes the --silent option, since
3200         probably no one ever used it, and cleans up the logging
3201         option parsing code to be easier to follow.
3202
3203         * Scripts/webkitpy/test/main.py:
3204         (Tester._parse_args):
3205         (Tester._configure):
3206         * Scripts/webkitpy/test/runner.py:
3207         (TestRunner.write_result):
3208         * Scripts/webkitpy/test/runner_unittest.py:
3209         (RunnerTest.test_regular):
3210         (RunnerTest.test_verbose):
3211         (RunnerTest):
3212         (RunnerTest.test_timing):
3213
3214 2012-03-29  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3215
3216         HashMap<>::add should return a more descriptive object
3217         https://bugs.webkit.org/show_bug.cgi?id=71063
3218
3219         Reviewed by Ryosuke Niwa.
3220
3221         Update code to use AddResult instead of a pair.
3222
3223         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3224         (LayoutTestController::evaluateScriptInIsolatedWorld):
3225         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3226         (LayoutTestController::evaluateScriptInIsolatedWorld):
3227         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3228         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld):
3229
3230 2012-03-29  Ilya Tikhonovsky  <loislo@chromium.org>
3231
3232         Web Inspector: chromium: DRT --no-timeout option doesn't work.
3233         https://bugs.webkit.org/show_bug.cgi?id=82608
3234
3235         Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
3236         This was broken by r112354 and the sequence became opposite.
3237
3238         Reviewed by Yury Semikhatsky.
3239
3240         * DumpRenderTree/chromium/TestShell.cpp:
3241         (TestShell::TestShell):
3242         (TestShell::initialize):
3243
3244 2012-03-29  Vineet Chaudhary  <rgf748@motorola.com>
3245
3246         Remove custom bindings form Internals.idl of attribute type Array.
3247         https://bugs.webkit.org/show_bug.cgi?id=82319
3248
3249         Reviewed by Kentaro Hara.
3250
3251         Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp as no longer required.
3252
3253         * GNUmakefile.am:
3254
3255 2012-03-28  Mark Rowe  <mrowe@apple.com>
3256
3257         Fix --no-saved-state.
3258
3259         Ignore the flag before Lion, rather than making it specific to Lion.
3260
3261         Rubber-stamped by Dan Bernstein.
3262
3263         * Scripts/webkitdirs.pm:
3264         (argumentsForRunAndDebugMacWebKitApp):
3265
3266 2012-03-28  Dave Tharp  <dtharp@codeaurora.org>
3267
3268         Add dtharp to contributors list
3269         https://bugs.webkit.org/show_bug.cgi?id=82545
3270
3271         Reviewed by Adam Barth.
3272
3273         Adding dtharp as Contributor.
3274
3275         * Scripts/webkitpy/common/config/committers.py:
3276
3277 2012-03-28  Stuart Eichert  <stuart.eichert@palm.com>
3278
3279         build-webkit : the word "pass" is spelled incorrectly as "passs"
3280         https://bugs.webkit.org/show_bug.cgi?id=82532
3281
3282         Reviewed by Julien Chaffraix.
3283
3284         Corrected spelling of the word "pass" in build-webkit.
3285
3286         * Scripts/build-webkit:
3287
3288 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
3289
3290         new-run-webkit-tests doesn't log correctly after retrying failures
3291         https://bugs.webkit.org/show_bug.cgi?id=82541
3292
3293         Unreviewed, build fix.
3294
3295         r112189 introduced a regression where we would accidentally
3296         delete the log handler after we retried any failing tests - that
3297         meant that any log messages around uploading the results got
3298         dropped.
3299
3300         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3301         (Manager._run_tests):
3302
3303 2012-03-28  Kevin Ollivier  <kevino@theolliviers.com>
3304
3305         [wx] Unreviewed. Build fix, move WTF back into JSCore target
3306         until issues with JSCore not linking in all WTF symbols are resolved.
3307
3308         * waf/build/settings.py:
3309
3310 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
3311
3312         download-built-product build step should detect 404 errors
3313         https://bugs.webkit.org/show_bug.cgi?id=82491
3314
3315         Reviewed by Ryosuke Niwa.
3316         
3317         Pass --fail to curl so that it reports 404 errors.
3318
3319         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3320         (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
3321         * BuildSlaveSupport/built-product-archive:
3322         (extractBuiltProduct): Remove trailing whitespace.
3323
3324 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
3325
3326         flakiness dashboard should only keep the last 500 runs
3327         https://bugs.webkit.org/show_bug.cgi?id=82530
3328
3329         Reviewed by Ojan Vafai.
3330
3331         If a bot has an overly large amount of failing tests, then
3332         storing 750 runs' worth takes a lot of memory and CPU time to
3333         process and we end up getting killed by AppEngine; this cases
3334         data corruption and confusion down the road when we have to
3335         retry the upload of the data and the tests show up as multiple
3336         runs.
3337
3338         * TestResultServer/model/jsonresults.py:
3339         (JsonResults.update_file):
3340
3341 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
3342
3343         extract-built-product build step should fail if unzipping fails
3344         https://bugs.webkit.org/show_bug.cgi?id=82493
3345
3346         Reviewed by Simon Fraser.
3347
3348         Forward non-zero exit code from subprocesses so that the master can detect any failures
3349         and bail out early.
3350
3351         * BuildSlaveSupport/built-product-archive:
3352         (main):
3353
3354 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
3355
3356         test-webkitpy should support files, directories, and packages as command line args
3357         https://bugs.webkit.org/show_bug.cgi?id=76765
3358
3359         Reviewed by Adam Barth.
3360
3361         This patch adds support for specifying files, directories, and
3362         packages to test-webkitpy along with the already existing
3363         support for modules, test classes, and individual test names.
3364
3365         Also, fix a bug in filesystem_mock where we wouldn't normalize a
3366         path containing a reference to the current directory properly,
3367         for example, '/foo/./bar.py'.
3368
3369         * Scripts/webkitpy/common/system/filesystem_mock.py:
3370         (MockFileSystem.normpath):
3371         * Scripts/webkitpy/test/main.py:
3372         (Tester._configure_logging):
3373         (Tester._run_tests):
3374         * Scripts/webkitpy/test/test_finder.py:
3375         (TestDirectoryTree.find_modules):
3376         (TestDirectoryTree.subpath):
3377         (TestFinder.is_dotted_name):
3378         (TestFinder.find_names):
3379         (TestFinder):
3380         (TestFinder._find_names_for_arg):
3381         (TestFinder._find_in_trees):
3382         (TestFinder._default_names):
3383         * Scripts/webkitpy/test/test_finder_unittest.py:
3384         (TestFinderTest.setUp):
3385         (TestFinderTest.tearDown):
3386         (TestFinderTest.check_names):
3387         (TestFinderTest.test_default_names):
3388         (TestFinderTest):
3389         (TestFinderTest.test_paths):
3390
3391 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
3392
3393         Fix inspector tests when running in internal builds.
3394
3395         <rdar://problem/11050694>
3396
3397         Reviewed by Tim Hatcher.
3398
3399         * DumpRenderTree/mac/DumpRenderTree.mm:
3400         (resetDefaultsToConsistentValues):
3401         * WebKitTestRunner/TestController.cpp:
3402         (WTR::TestController::resetStateToConsistentValues):
3403
3404 2012-03-28  David Kilzer  <ddkilzer@apple.com>
3405
3406         Use xcrun to find nm and ranlib on OS X builds
3407         <http://webkit.org/b/82466>
3408
3409         Reviewed by Dan Bernstein.
3410
3411         * Scripts/build-webkit: Use xcrun to find ranlib.
3412         * Scripts/webkitdirs.pm:
3413         (determineNmPath): Added.  Use xcrun to find nm on OS X.
3414         (nmPath): Added.
3415         * Scripts/webkitperl/features.pm:
3416         (libraryContainsSymbol): Use nmPath().
3417
3418 2012-03-28  Ojan Vafai  <ojan@chromium.org>
3419
3420         Add history navigation to garden-o-matic
3421         https://bugs.webkit.org/show_bug.cgi?id=82495
3422
3423         Reviewed by Dimitri Glazkov.
3424
3425         Also, maintain scroll offsets when returning to a tab. This makes addressing
3426         expected failures considerably easier when dealing with below-the-fold tests.
3427
3428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3429         -Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
3430         switching.
3431         -Modify window.location with the tabName in the hash. Can't use pushState because this is served
3432         from a file URL and Chrome puts each different file URL in it's own origin.
3433
3434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3435         Remove the href so that clicking on the accordion item does not modify window.location.hash.
3436
3437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3439
3440 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3441
3442         [GTK] generate-gtk-doc doesn't cope with custom build directory
3443         https://bugs.webkit.org/show_bug.cgi?id=82448
3444
3445         Reviewed by Martin Robinson.
3446
3447         Pass the product directory in generate-gtkdoc arguments from
3448         build-webkit.
3449
3450         * Scripts/webkitdirs.pm:
3451         (buildAutotoolsProject):
3452         * gtk/common.py:
3453         (get_build_path):
3454
3455 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3456
3457         [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
3458         https://bugs.webkit.org/show_bug.cgi?id=82341
3459
3460         Reviewed by Martin Robinson.
3461
3462         Add --skipped=skip|ignore|only command line option.
3463
3464         * Scripts/run-gtk-tests:
3465         (TestRunner._test_cases_to_skip): Return the list of test cases
3466         to skip for the given test depending on the skipped action.
3467         (TestRunner._should_run_test): Decide whether to run the test or
3468         not depending on the skipped action.
3469         (TestRunner.run_tests): Only show the list of skipped tests when
3470         skipped action is 'skip'.
3471
3472 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3473
3474         [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
3475         https://bugs.webkit.org/show_bug.cgi?id=82333
3476
3477         Reviewed by Martin Robinson.
3478
3479         * Scripts/run-gtk-tests:
3480         (TestRunner.SkippedTest): Add SkippedTest class to store more
3481         information about skipped tests.
3482         (TestRunner._setup_testing_environment): Use SkippedTest to add
3483         TestWebKitAccessibility to the skipped list.
3484         (TestRunner._find_skipped_test): Return the SkippedTest object for
3485         a given test path.
3486         (TestRunner._test_cases_to_skip): Returns the list of test cases
3487         that should be skipped for a given test path.
3488         (TestRunner._should_run_test): Helper funtion to decide whether
3489         the given test path should be run or not. Tests in the skipped
3490         list that don't have a list of failing test cases are not run at
3491         all. Tests in the skipped list that contain a list of test cases
3492         are run with gtester -s to skip the individual test cases.
3493         (TestRunner._run_test): Helper funtion to run a given test.
3494         (TestRunner.run_tests): Build the list of tests to run based on
3495         _should_run_test() and use helper function _run_test() to run
3496         every test.
3497
3498 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3499
3500         [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
3501         https://bugs.webkit.org/show_bug.cgi?id=52810
3502
3503         Reviewed by Simon Hausmann.
3504
3505         Use SSE2 floating point math on 32 bit instead of the default
3506         387 to make layout test result same on 32 and on 64 bit builds.
3507
3508         * qmake/mkspecs/features/unix/default_post.prf:
3509
3510 2012-03-28  Sergio Villar Senin  <svillar@igalia.com>
3511
3512         [Soup] DNS prefetching spams resolver, shoots self in the foot
3513         https://bugs.webkit.org/show_bug.cgi?id=41630
3514
3515         Reviewed by Martin Robinson.
3516
3517         Bump libsoup and glib dependencies.
3518
3519         * efl/jhbuild.modules:
3520         * gtk/jhbuild.modules:
3521
3522 2012-03-28  Gustavo Noronha Silva  <gns@gnome.org>
3523
3524         [GTK] Disable introspection for jhbuild modules
3525         https://bugs.webkit.org/show_bug.cgi?id=82395
3526
3527         Reviewed by Philippe Normand.
3528
3529         * efl/jhbuild.modules: add --disable-introspection to all modules
3530         that support it
3531         * gtk/jhbuild.modules: ditto.
3532
3533 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3534
3535         [Qt] Unreviewed, fix API tests after adding full platforms. (r111658)
3536
3537         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3538         (BuildAndTestFactory.__init__):
3539
3540 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3541
3542         [Qt] Unreviewed typo fix after r112383.
3543
3544         * Scripts/run-qtwebkit-tests:
3545         (Main.check_crash_occurences):
3546
3547 2012-03-28  Ádám Kallai  <kadam@inf.u-szeged.hu>
3548
3549         [Qt] run-qtwebkit-tests should report crashes
3550         https://bugs.webkit.org/show_bug.cgi?id=76905
3551
3552         Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
3553         Made unit test for this modification by János Badics <jbadics@inf.u-szeged.hu>.
3554
3555         Reviewed by Csaba Osztrogonác.
3556
3557         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3558         (RunQtAPITests.commandComplete):
3559         (RunQtAPITests.evaluateCommand):
3560         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3561         (RunQtAPITestsTest):
3562         (test_failure):
3563         (test_crash):
3564         * Scripts/run-qtwebkit-tests:
3565         (Main.announce_results_html):
3566         (Main):
3567         (Main.check_crash_occurences):
3568         (Main.convert_to_stdout):
3569         (Main.convert_to_html):
3570
3571 2012-03-28  Kwonjin Jeong  <gram@company100.net>
3572
3573         Add support for Intel compiler on Linux QT port.
3574         https://bugs.webkit.org/show_bug.cgi?id=81077
3575
3576         Reviewed by Tor Arne Vestbø.
3577
3578         * qmake/mkspecs/features/default_post.prf:
3579         Don't hide symbols when building with Intel compiler.
3580         The symbols are needed when building QtWebKit tests.
3581
3582         * qmake/mkspecs/features/unix/icc.prf:
3583         Added to ignore icc-specific warnings.
3584         This feature is used with command-line arguments for build-webkit script.
3585
3586 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3587
3588         Unreviewed, trivial update-webkit-libs-jhbuild system call fix.
3589
3590         * Scripts/update-webkitgtk-libs: This script is written in
3591         Perl. Not Python. So use perl vocabulary to refer to command line arguments.
3592
3593 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
3594
3595         kill-old-processes doesn't do anything on linux
3596         https://bugs.webkit.org/show_bug.cgi?id=82388
3597
3598         Reviewed by Tony Chang.
3599
3600         Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
3601         This should help stabilizing Chromium linux bots.
3602
3603         * BuildSlaveSupport/kill-old-processes:
3604
3605 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3606
3607         [GTK] jhbuild wrongly tricked into clean-up
3608         https://bugs.webkit.org/show_bug.cgi?id=82216
3609
3610         Reviewed by Gustavo Noronha Silva.
3611
3612         Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
3613         build tree. Also when checking if the jhbuild configuration
3614         changed use absolute md5sum paths.
3615
3616         * Scripts/webkitdirs.pm:
3617         (runAutogenForAutotoolsProjectIfNecessary):
3618         (jhbuildConfigurationChanged):
3619         (buildAutotoolsProject):
3620
3621 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3622
3623         kill-old-processes doesn't do anything on linux
3624         https://bugs.webkit.org/show_bug.cgi?id=82388
3625
3626         One more attempt to disable kill-old-processes on the Qt bots not to kill each others.
3627
3628         The platform in Factory comes from config.json, accordingly platform is fullplatform,
3629         for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.
3630
3631         Reviewed by Ryosuke Niwa.
3632
3633         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3634         (Factory.__init__):
3635
3636 2012-03-28  Hao Zheng  <zhenghao@chromium.org>
3637
3638         Make Chromium port for Android use hardware gpu path default.
3639         https://bugs.webkit.org/show_bug.cgi?id=82033
3640
3641         Reviewed by Dirk Pranke.
3642
3643         Skip canvas tests, which are run in virtual gpu test suites.
3644
3645         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3646         (ChromiumAndroidPort.__init__):
3647         (ChromiumAndroidPort.skipped_tests):
3648
3649 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3650
3651         kill-old-processes doesn't do anything on linux
3652         https://bugs.webkit.org/show_bug.cgi?id=82388
3653
3654         Disable kill-old-processes on the Qt bots not to kill each others.
3655
3656         Reviewed by Ryosuke Niwa.
3657
3658         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3659         (Factory.__init__):
3660
3661 2012-03-27  Hao Zheng  <zhenghao@chromium.org>
3662
3663         Handle DRT crash caused by Android OOM.
3664         https://bugs.webkit.org/show_bug.cgi?id=82310
3665
3666         Reviewed by Tony Chang.
3667
3668         When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
3669         is stopped silently and regarded as crashed. Re-run the test for
3670         such crash.
3671
3672         Add some debug log to NRWT.
3673
3674         * Scripts/webkitpy/layout_tests/port/chromium.py:
3675         (ChromiumDriver.run_test):
3676         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3677         (ChromiumAndroidPort.__init__):
3678         (ChromiumAndroidPort.get_last_stacktrace):
3679         (ChromiumAndroidDriver.__init__):
3680         (ChromiumAndroidDriver._start):
3681         (ChromiumAndroidDriver.run_test):
3682         (ChromiumAndroidDriver._get_drt_return_value):
3683
3684 2012-03-27  Ojan Vafai  <ojan@chromium.org>
3685
3686         Fix expected results for some unittest failures.
3687
3688         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3689
3690 2012-03-27  Adrienne Walker  <enne@google.com>
3691
3692         [chromium] Fix --enabled-threaded-compositing flag in DRT
3693         https://bugs.webkit.org/show_bug.cgi?id=82405
3694
3695         Reviewed by James Robinson.
3696
3697         --enable-threaded-compositing wasn't working because there was no way
3698         to set the value before it was used in the TestShell constructor.
3699
3700         To avoid adding yet another boolean parameter to TestShell's
3701         constructor, add an explicit initialize function that can operate on
3702         any boolean settings that are set post-constructor.
3703
3704         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3705         (main):
3706         * DumpRenderTree/chromium/TestShell.cpp:
3707         (TestShell::TestShell):
3708         (TestShell::initialize):
3709         * DumpRenderTree/chromium/TestShell.h:
3710         (TestShell):
3711         (TestShell::setTestShellMode):
3712
3713 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
3714
3715         new-run-webkit-tests: suppress debug output from run-safari on results file
3716         htt