Tools/ChangeLog

   1 2013-06-11  Ryosuke Niwa  <rniwa@webkit.org>
   2
   3         Add an option to run-webkit-tests to skip java dependency check
   4         https://bugs.webkit.org/show_bug.cgi?id=117516
   5
   6         Reviewed by Andreas Kling.
   7
   8         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
   9         (parse_args):
  10         * Scripts/webkitpy/port/mac.py:
  11         (MacPort._check_port_build):
  12
  13 2013-06-11  Alex Christensen  <achristensen@apple.com>
  14
  15         https://bugs.webkit.org/show_bug.cgi?id=117514
  16         Removed extra Xcode code coverage flags.
  17
  18         Reviewed by Sam Weinig.
  19
  20         * Scripts/webkitdirs.pm:
  21         (XcodeCoverageSupportOptions):
  22
  23 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
  24
  25         [Windows] Implement 'attributeValue' accessor to support testing
  26         https://bugs.webkit.org/show_bug.cgi?id=117513
  27
  28         Reviewed by Anders Carlsson.
  29
  30         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
  31         (comparableObject): Move earlier in file.
  32         (findAccessibleObjectById): New implemenation.
  33         (AccessibilityController::accessibleElementById): New implementation.
  34
  35 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
  36
  37         Make WTR use its own temporary directory for application cache
  38         https://bugs.webkit.org/show_bug.cgi?id=117143
  39
  40         Reviewed by Alexey Proskuryakov.
  41
  42         * WebKitTestRunner/TestController.cpp:
  43         (WTR::TestController::initialize):
  44
  45 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
  46
  47         https://bugs.webkit.org/show_bug.cgi?id=117449
  48         Remove dead code for storing fonts in __DATA section
  49
  50         Reviewed by Dan Bernstein.
  51
  52         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  53         Don't copy font resources to __DATA, as we don't have any code that reads them
  54         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
  55
  56         * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
  57         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
  58         Removed comments suggesting that we want to restore the old solution.
  59
  60 2013-06-10  Bear Travis  <betravis@adobe.com>
  61
  62         [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
  63         https://bugs.webkit.org/show_bug.cgi?id=117162
  64
  65         Reviewed by Alexandru Chiculita.
  66
  67         Adding the WebCore/rendering/shapes directory to the include list.
  68
  69         * DumpRenderTree/efl/CMakeLists.txt:
  70
  71 2013-06-09  Brent Fulgham  <bfulgham@apple.com>
  72
  73         [Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
  74         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  75         (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
  76         happends in some of the 'accessibility' test cases.
  77
  78 2013-06-08  peavo@outlook.com  <peavo@outlook.com>
  79
  80         [WinCairo] TestWebKitAPI fails to link.
  81         https://bugs.webkit.org/show_bug.cgi?id=117345
  82
  83         Reviewed by Brent Fulgham.
  84
  85         Need to link with WTF.lib.
  86
  87         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
  88
  89 2013-06-07  Roger Fong  <roger_fong@apple.com>
  90
  91         Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
  92
  93         Rubberstamped by Ryousuke Niwa.
  94
  95         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  96         (RunTest.test_build_check):
  97
  98 2013-06-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
  99
 100         [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
 101         https://bugs.webkit.org/show_bug.cgi?id=117315
 102
 103         Reviewed by Benjamin Poulain.
 104
 105         Qt doesn't use the default values specified on FeatureList since r44681,
 106         this patch just remove a bit of noise.
 107
 108         * Scripts/webkitperl/FeatureList.pm:
 109
 110 2013-06-07  Jungsik Tae  <davidtlay88@gmail.com>
 111
 112         [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
 113         https://bugs.webkit.org/show_bug.cgi?id=115890
 114
 115         Reviewed by Christophe Dumez.
 116
 117         When user clicks HTML5 input type color,
 118         color selector window is created on browser object by using elm_colorchooser_add().
 119         It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
 120         The evas_object_color_set() sets a color value returning to browser.
 121
 122         * MiniBrowser/efl/main.c:
 123         (window_free): When we delete parent window, deleting the colorpicker object.
 124         (on_color_changed): Change color of rectangle to show color selected by user.
 125         (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
 126         (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
 127         (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
 128         (on_color_picker_dismiss): Delete colorpicker object.
 129         (on_color_picker_request): Create colorpicker window object.
 130         (window_create):
 131
 132 2013-06-06  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
 133
 134         svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
 135         https://bugs.webkit.org/show_bug.cgi?id=111066
 136
 137         Reviewed by Daniel Bates.
 138
 139         Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
 140
 141         ParseGitDiffHeader() should support the path which line has space characters.
 142         To support this, I changed parsing algorithm like the following:
 143         - When the diff have prefix, we consider next characters after "b/" as part of a file path.
 144         - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
 145
 146         We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
 147
 148         If the path has a tab, the patch(1) command thinks file path is characters before the tab.
 149         I added a dummy tab and revision when we convert git diff to svn diff.
 150
 151         * Scripts/VCSUtils.pm:
 152         (parseGitDiffHeader):
 153         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
 154         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
 155         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
 156           - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
 157
 158 2013-06-06  Simon Fraser  <simon.fraser@apple.com>
 159
 160         Add a menu item to MiniBrowser to toggle Transparent windows
 161         https://bugs.webkit.org/show_bug.cgi?id=117316
 162
 163         Reviewed by Anders Carlsson.
 164
 165         Add a menu item that toggles "Transparent window" mode, which is exposed
 166         via private WebKit API and WebKit2 API.
 167
 168         * MiniBrowser/mac/BrowserWindowController.h:
 169         * MiniBrowser/mac/MainMenu.xib:
 170         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
 171         * MiniBrowser/mac/WK1BrowserWindowController.m:
 172         (-[WK1BrowserWindowController validateMenuItem:]):
 173         (-[WK1BrowserWindowController toggleTransparentWindow:]):
 174         * MiniBrowser/mac/WK2BrowserWindowController.m:
 175         (-[WK2BrowserWindowController validateMenuItem:]):
 176         (-[WK2BrowserWindowController toggleTransparentWindow:]):
 177         (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
 178         when testing.
 179
 180 2013-06-06  Roger Fong  <roger_fong@apple.com>
 181
 182         Stop copying AAS binaries into build folder.
 183         https://bugs.webkit.org/show_bug.cgi?id=117319.
 184
 185         Rubberstamped by Darin Adler.
 186
 187         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
 188
 189 2013-06-06  Hugo Parente Lima  <hugo.lima@openbossa.org>
 190
 191         Aligning build-webkit command line switch names to the WebKit flag names
 192         https://bugs.webkit.org/show_bug.cgi?id=117254
 193
 194         Reviewed by Laszlo Gombos.
 195
 196         * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
 197
 198 2013-06-06  Chris Fleizach  <cfleizach@apple.com>
 199
 200         AX: iOS ignores ARIA progressbar elements
 201         https://bugs.webkit.org/show_bug.cgi?id=116727
 202
 203         Reviewed by David Kilzer.
 204
 205         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
 206         (AccessibilityUIElement::minValue):
 207         (AccessibilityUIElement::maxValue):
 208
 209 2013-06-06  peavo@outlook.com  <peavo@outlook.com>
 210
 211         [WinCairo] Fix build-webkit to build WinCairo under VS2010.
 212         https://bugs.webkit.org/show_bug.cgi?id=117255
 213
 214         Reviewed by Daniel Bates.
 215
 216         Need to update configuration names according to solution file.
 217
 218         * Scripts/webkitdirs.pm:
 219         (determineConfiguration):
 220         (determinePassedConfiguration):
 221
 222 2013-06-06  Ryosuke Niwa  <rniwa@webkit.org>
 223
 224         Remove run-performance-tests
 225         https://bugs.webkit.org/show_bug.cgi?id=117285
 226
 227         Reviewed by Andreas Kling.
 228
 229         Remove the script since it's not used anywhere.
 230
 231         * BuildSlaveSupport/run-performance-tests: Removed.
 232
 233 2013-06-05  Bear Travis  <betravis@adobe.com>
 234
 235         [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
 236         https://bugs.webkit.org/show_bug.cgi?id=117172
 237
 238         Reviewed by Alexandru Chiculita.
 239
 240         Adding the CSS_SHAPES compile flag.
 241
 242         * Scripts/webkitperl/FeatureList.pm:
 243         * qmake/mkspecs/features/features.pri:
 244
 245 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
 246
 247         [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
 248         to UNIX-style they will not execute properly.
 249
 250         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
 251         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
 252
 253 2013-06-05  Roger Fong  <roger_fong@apple.com>
 254
 255         Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
 256
 257         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 258         (RunWebKitTests.start):
 259
 260 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
 261
 262         [Windows] Switch to NRWT
 263         https://bugs.webkit.org/show_bug.cgi?id=117200
 264
 265         Reviewed by Anders Carlsson.
 266
 267         * Scripts/run-webkit-tests:
 268         (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
 269
 270 2013-06-05  Dominik Röttsches  <dominik.rottsches@intel.com>
 271
 272         Unreviewed name fix after r150662
 273
 274         My firstname got duplicated when fixing bug 116737.
 275
 276         * Scripts/webkitpy/common/config/contributors.json:
 277
 278 2013-06-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
 279
 280         Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
 281         https://bugs.webkit.org/show_bug.cgi?id=117244
 282
 283         Reviewed by Daniel Bates.
 284
 285         Fixed a regression introduced by r151196: not only does webkit.org
 286         still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
 287         infrastructure used by ports such as GTK+ and EFL also use on it for
 288         things such as jhbuild.
 289
 290         While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
 291         both environment variables.
 292
 293         * Scripts/webkitdirs.pm:
 294         (determineBaseProductDir):
 295
 296 2013-06-05  Wojciech Bielawski  <w.bielawski@samsung.com>
 297
 298         [GTK] Forwarding headers not generated for incremental build
 299         https://bugs.webkit.org/show_bug.cgi?id=117198
 300
 301         Reviewed by Carlos Garcia Campos.
 302
 303         * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
 304
 305 2013-06-05  Andras Becsi  <andras.becsi@digia.com>
 306
 307         [Qt][WK2] Fix layout testing with Qt 5.1
 308         https://bugs.webkit.org/show_bug.cgi?id=117203
 309
 310         Reviewed by Jocelyn Turcotte.
 311
 312         With Qt 5.1 synchronous requests via QNetworkAccessManager do not
 313         go into loading state but directly call handler functions for
 314         finished state instead of relying on a connection.
 315         Our wrapper QQuickView uses a data URI scheme to create the root
 316         item for testing which results in a synchronous request when loading
 317         the QML data, therefore the state of the QQuickWindow immediately
 318         becomes Ready.
 319         Since the final initialization of the root item depended on the
 320         emission of QQuickView::statusChanged(QQuickView::Ready) we ended
 321         up with a partially initialized wrapper window, thus most of our
 322         layout tests were failing.
 323         For compatibility with pre-5.1 Qt versions keep the old behaviour
 324         in case the WrapperWindow is not ready in the constructor yet.
 325
 326         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
 327         (WTR::WrapperWindow::WrapperWindow):
 328         * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
 329         (TestWebKitAPI::WrapperWindow::WrapperWindow):
 330
 331 2013-06-05  Dariusz Frankiewicz  <d.frankiewic@samsung.com>
 332
 333         Bad value in tests counter at new-run-webkit-tests
 334         in --debug-rwt-logging mode
 335         https://bugs.webkit.org/show_bug.cgi?id=116858
 336
 337         Reviewed by Dirk Pranke.
 338
 339         Fix by moving counter incrementation, from after printing line,
 340         to before printing. Also changed variable name.
 341
 342         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
 343         (LayoutTestRunner.run_tests):
 344         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
 345         (FakePrinter):
 346         * Scripts/webkitpy/layout_tests/views/printing.py:
 347         (Printer.__init__):
 348         (Printer._test_status_line):
 349         (Printer.print_started_test):
 350         (Printer.print_finished_test):
 351         * Scripts/webkitpy/test/printer.py:
 352         (Printer.__init__):
 353         (Printer.print_finished_test):
 354         (Printer._test_line):
 355         (Printer.print_result):
 356
 357 2013-06-05  Zan Dobersek  <zdobersek@igalia.com>
 358
 359         Move MemoryInfo under window.internals
 360         https://bugs.webkit.org/show_bug.cgi?id=117197
 361
 362         Reviewed by Ryosuke Niwa.
 363
 364         * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
 365         the Automake build
 366         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
 367         testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
 368
 369 2013-06-03  Roger Fong  <roger_fong@apple.com>
 370
 371         Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
 372         <rdar://problem/14042021>.
 373
 374         Reviewed by Brent Fulgham.
 375
 376         * Scripts/build-api-tests:
 377         * Scripts/build-dumprendertree:
 378         * Scripts/build-webkit:
 379         * Scripts/update-webkit-dependency:
 380         * Scripts/update-webkit-support-libs:
 381         * Scripts/webkitdirs.pm:
 382         (determineBaseProductDir):
 383         (setupAppleWinEnv):
 384         (setupCygwinEnv):
 385
 386 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
 387
 388         [Windows] NRWT is not putting crash logs in proper place (corrections)
 389         https://bugs.webkit.org/show_bug.cgi?id=117212
 390
 391         Reviewed by Dirk Pranke.
 392
 393         * Scripts/webkitpy/common/system/crashlogs.py:
 394         (CrashLogs.__init__): Accept a result directory argument in constructor.
 395         (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
 396         (CrashLogs._find_newest_log_win): No longer use 'port' argument.
 397         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
 398         (CrashLogsTest.test_find_log_win): Simplify test.
 399         * Scripts/webkitpy/common/system/executive.py:
 400         (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
 401         * Scripts/webkitpy/port/win.py:
 402         (WinPort._get_crash_log): No longer require 'port' argument.
 403
 404 2013-06-04  Ryosuke Niwa  <rniwa@webkit.org>
 405
 406         Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
 407
 408         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 409
 410 2013-06-04  Greg Hughes  <ghughes@apple.com>
 411
 412         Add "VisibleOnly" key to search predicate
 413         https://bugs.webkit.org/show_bug.cgi?id=115491
 414
 415         Reviewed by Chris Fleizach.
 416
 417         Added support for accessibility clients to use the search predicate to find only visible elements
 418
 419         * DumpRenderTree/AccessibilityUIElement.cpp:
 420         (uiElementForSearchPredicateCallback):
 421         * DumpRenderTree/AccessibilityUIElement.h:
 422         (AccessibilityUIElement):
 423         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
 424         (AccessibilityUIElement::uiElementForSearchPredicate):
 425         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 426         (AccessibilityUIElement::uiElementForSearchPredicate):
 427         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
 428         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
 429         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 430         (AccessibilityUIElement):
 431         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
 432         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
 433         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
 434
 435 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
 436
 437         [Windows] Unreviewed build fix.  The last check-in lost CR/LF endings on the batch file,
 438         causing build failure.
 439
 440         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
 441         DOS-style CR/LF endings.
 442
 443 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
 444
 445         [Windows] Unreviewed test correction.
 446
 447         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
 448         QuartzCore dll's, which are needed by TestWebKitAPI.
 449         * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
 450         with VS2010 will run when linked against VS2005 support libraries.
 451
 452 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 453
 454         Automatically generate WorkerContext constructor attributes
 455         https://bugs.webkit.org/show_bug.cgi?id=117183
 456
 457         Reviewed by Kentaro Hara.
 458
 459         Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
 460         tests.
 461
 462         * Scripts/webkitpy/bindings/main.py:
 463         (BindingsTests.generate_supplemental_dependency):
 464         (BindingsTests.main):
 465
 466 2013-06-04  Ryuan Choi  <ryuan.choi@samsung.com>
 467
 468         [EFL] File dialog of MiniBrowser have broken background.
 469         https://bugs.webkit.org/show_bug.cgi?id=117189
 470
 471         Reviewed by Christophe Dumez.
 472
 473         * MiniBrowser/efl/main.c:
 474         (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
 475
 476 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 477
 478         [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
 479         https://bugs.webkit.org/show_bug.cgi?id=117184
 480
 481         Reviewed by Gyuyoung Kim.
 482
 483         Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
 484         that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
 485
 486         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 487         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
 488         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
 489
 490 2013-06-03  Simon Pena  <simon.pena@samsung.com>
 491
 492         validate-committer-lists script is now outdated and does not work
 493         https://bugs.webkit.org/show_bug.cgi?id=115860
 494
 495         Reviewed by Brent Fulgham.
 496
 497         The script validate-committer-lists was outdated, still using the deprecated log
 498         system and having the old addresses for the mailing lists, as well as still referring
 499         to committers.py, after this was renamed to contributors.json. This patch fixes that
 500         so it can be used again.
 501
 502         * Scripts/validate-committer-lists: Replace calls to log and error with the
 503         new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
 504         to committers.py, which should be contributors.json.
 505         (CommitterListFromMailingList):
 506         (CommitterListFromMailingList.check_for_emails_missing_from_list):
 507         (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
 508         (CommitterListFromGit._fill_in_emails_for_old_logins):
 509         (CommitterListFromGit.print_committers_missing_from_committer_list):
 510
 511 2013-06-03  Dirk Pranke  <dpranke@chromium.org>
 512
 513         add a script to dump the tests run most recently by a given worker
 514         https://bugs.webkit.org/show_bug.cgi?id=116571
 515
 516         Reviewed by Brent Fulgham.
 517
 518         The tests_run*.txt results files in layout-test-results/ were removed
 519         in r137356, in favor of collecting more data about how the tests were
 520         run and compressing it and storing it in stats.json. However, it was
 521         nice to just be able to look at a flat text file.
 522
 523         This script will extract the tests run by a given worker from a
 524         given stats.json file, and should help to address that.
 525
 526         * Scripts/dump-webkit-tests-run: Added.
 527         (main):
 528         (convert_trie_to_flat_paths):
 529
 530 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
 531
 532         [Windows] NRWT is not putting crash logs in proper place
 533         https://bugs.webkit.org/show_bug.cgi?id=117098
 534
 535         Reviewed by Ryosuke Niwa.
 536
 537         Provide windows-specific overloads for various Port features needed to create and capture
 538         crash logs.  This change makes it possible to view crash logs (when created) as part of the
 539         summary report at the end of the NRWT run.
 540
 541         * Scripts/webkitpy/common/system/crashlogs.py:
 542         (CrashLogs.find_newest_log): Add support for win32 crash logs
 543         (CrashLogs._find_newest_log_win): Added
 544         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
 545         (make_mock_crash_report_win): Added
 546         (CrashLogsTest.test_find_log_win): Added.
 547         * Scripts/webkitpy/common/system/executive.py:
 548         (Executive.running_pids): Add support for Cygwin win32 crash logs
 549         * Scripts/webkitpy/common/system/executive_mock.py:
 550         (MockExecutive.__init__):
 551         * Scripts/webkitpy/common/system/filesystem_unittest.py:
 552         (RealFileSystemTest.test_read_and_write_file): Add tests for
 553         malformed ascii/utf8 handling (i.e., Windows log files)
 554         * Scripts/webkitpy/port/base.py:
 555         (Port.find_system_pid): Added
 556         * Scripts/webkitpy/port/server_process.py:
 557         (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
 558         * Scripts/webkitpy/port/win.py:
 559         (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
 560         for user to hit enter.
 561         (WinPort._get_crash_log): Added
 562         (WinPort.look_for_new_crash_logs): Added
 563         (WinPort.find_system_pid): Added
 564         * Scripts/webkitpy/port/win_unittest.py:
 565         (WinPortTest.test_get_crash_log): Added test
 566
 567 2013-06-03  Eduardo Lima Mitev  <elima@igalia.com>
 568
 569         [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
 570         https://bugs.webkit.org/show_bug.cgi?id=116726
 571
 572         Reviewed by Gyuyoung Kim.
 573
 574         Current version of ATK in efl-ews environment is 2.4.0 and is taken from
 575         the platform (it is not listed in jhbuild moduleset). That version is
 576         old-ish and contain deprecated symbols and missing API, that are blocking
 577         patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
 578         moduleset, which is the same version the gtk port uses.
 579
 580         See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
 581         why this is needed.
 582
 583         * efl/jhbuild.modules: Adds ATK module as dependency
 584
 585 2013-06-03  Erik van Pienbroek  <epienbro@fedoraproject.org>
 586
 587         [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
 588         https://bugs.webkit.org/show_bug.cgi?id=117168
 589
 590         Reviewed by Martin Robinson.
 591
 592         The tool generate-gtkdoc internally calls pkg-config.
 593         When cross-compiling it shouldn't use pkg-config, but
 594         it should use the pkg-config which was detected by
 595         the ./configure script (for example this can be
 596         i686-w64-mingw32-pkg-config when cross-compiling)
 597
 598         * GNUmakefile.am:
 599         * gtk/gtkdoc.py:
 600         (PkgConfigGTKDoc.__init__):
 601
 602 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
 603
 604         [Windows] Unreviewed build fix.
 605
 606         * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
 607         allow VS2010 builds to use VS2005 runtime libraries as needed.
 608
 609 2013-06-03  Roger Fong  <roger_fong@apple.com>
 610
 611         Nuke VS2005 files from the tree.
 612         <rdar://problem/14042021>.
 613
 614         Rubberstamped by Brent Fulgham.
 615
 616         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
 617         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
 618         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
 619         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
 620         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
 621         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
 622         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
 623         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
 624         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
 625         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
 626         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
 627         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
 628         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
 629         * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
 630         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
 631         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
 632         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
 633         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
 634         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
 635         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
 636         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
 637         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
 638         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
 639         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
 640         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
 641         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
 642         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
 643         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
 644         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
 645         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
 646         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
 647         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
 648         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
 649         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
 650         * DumpRenderTree/win/ImageDiff.vcproj: Removed.
 651         * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
 652         * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
 653         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
 654         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
 655         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
 656         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
 657         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
 658         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
 659         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
 660         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
 661         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
 662         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
 663         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
 664         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
 665         * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
 666         * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
 667         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
 668         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
 669         * Scripts/pdevenv: Removed.
 670         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
 671         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
 672         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
 673         * WebKitLauncherWin: Removed.
 674         * WebKitLauncherWin/Resource.h: Removed.
 675         * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
 676         * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
 677         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
 678         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
 679         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
 680         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
 681         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
 682         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
 683         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
 684         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
 685         * WebKitLauncherWin/webkit.ico: Removed.
 686         * WinLauncher/WinLauncher.ico: Removed.
 687         * WinLauncher/WinLauncher.rc: Removed.
 688         * WinLauncher/WinLauncher.vcproj: Removed.
 689         * WinLauncher/WinLauncherCommon.vsprops: Removed.
 690         * WinLauncher/WinLauncherDebug.vsprops: Removed.
 691         * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
 692         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
 693         * WinLauncher/WinLauncherLauncher.rc: Removed.
 694         * WinLauncher/WinLauncherLauncher.vcproj: Removed.
 695         * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
 696         * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
 697         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
 698         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
 699         * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
 700         * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
 701         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
 702         * WinLauncher/WinLauncherLauncherResource.h: Removed.
 703         * WinLauncher/WinLauncherPostBuild.cmd: Removed.
 704         * WinLauncher/WinLauncherPreBuild.cmd: Removed.
 705         * WinLauncher/WinLauncherProduction.vsprops: Removed.
 706         * WinLauncher/WinLauncherRelease.vsprops: Removed.
 707         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
 708         * WinLauncher/small.ico: Removed.
 709         * record-memory-win: Removed.
 710         * record-memory-win/main.cpp: Removed.
 711         * record-memory-win/record-memory-win-common.vsprops: Removed.
 712         * record-memory-win/record-memory-win.vcproj: Removed.
 713         * record-memory-win/record-memory-winDebug.vsprops: Removed.
 714         * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
 715         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
 716         * record-memory-win/record-memory-winProduction.vsprops: Removed.
 717         * record-memory-win/record-memory-winRelease.vsprops: Removed.
 718         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
 719
 720 2013-06-03  Chris Fleizach  <cfleizach@apple.com>
 721
 722         AX: MathML multiscripts not exposed in Accessibility
 723         https://bugs.webkit.org/show_bug.cgi?id=115069
 724
 725         Reviewed by Tim Horton.
 726
 727         Add methods to help output components of math multiscripts for accessibility.
 728
 729         * DumpRenderTree/AccessibilityUIElement.cpp:
 730         (mathPostscriptsDescriptionCallback):
 731         (mathPrescriptsDescriptionCallback):
 732         (AccessibilityUIElement::getJSClass):
 733         * DumpRenderTree/AccessibilityUIElement.h:
 734         (AccessibilityUIElement):
 735         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 736         (convertMathMultiscriptPairsToString):
 737         (AccessibilityUIElement::mathPostscriptsDescription):
 738         (AccessibilityUIElement::mathPrescriptsDescription):
 739         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
 740         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
 741         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
 742         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 743         (AccessibilityUIElement):
 744         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
 745         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
 746         (WTR::_convertMathMultiscriptPairsToString):
 747         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
 748         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
 749
 750 2013-06-03  Commit Queue  <commit-queue@webkit.org>
 751
 752         Unreviewed, rolling out r151109.
 753         http://trac.webkit.org/changeset/151109
 754         https://bugs.webkit.org/show_bug.cgi?id=117145
 755
 756         "Plugins in WK2 aren't implemented yet." (Requested by
 757         jturcotte on #webkit).
 758
 759         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 760         * qmake/mkspecs/features/features.prf:
 761         * qmake/mkspecs/features/unix/default_pre.prf:
 762
 763 2013-05-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
 764
 765         [Qt] Re-enable plugins on Mac.
 766         https://bugs.webkit.org/show_bug.cgi?id=116622
 767
 768         Reviewed by Tor Arne Vestbø.
 769
 770         Plugins on Mac were only enabled if !embedded but the later was set if
 771         QPA is enabled, which is the default since Qt 5.0.
 772
 773         Remove references to 'embedded' and fix various build issues,
 774         PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
 775         months.
 776
 777         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 778         * qmake/mkspecs/features/features.prf:
 779         * qmake/mkspecs/features/unix/default_pre.prf:
 780
 781 2013-06-03  Krzysztof Czech  <k.czech@samsung.com>
 782
 783         [GTK][WK2] accessibility/placeholder.html is failing
 784         https://bugs.webkit.org/show_bug.cgi?id=106344
 785
 786         Reviewed by Gyuyoung Kim.
 787
 788         Adds support for retrieving attribute value.
 789
 790         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 791         (WTR::coreAttributeToAtkAttribute):
 792         (WTR::AccessibilityUIElement::stringAttributeValue):
 793
 794 2013-06-01  Tim Horton  <timothy_horton@apple.com>
 795
 796         Add a preferred email address and "expertise" for me.
 797
 798         * Scripts/webkitpy/common/config/contributors.json:
 799
 800 2013-05-31  Roger Fong  <roger_fong@apple.com>
 801
 802         Unreviewed. Make windows test bots search in the correct directory for build output.
 803
 804         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 805         (RunWebKitTests.start):
 806         * Scripts/webkitdirs.pm:
 807         (determineConfigurationProductDir):
 808
 809 2013-05-31  Roger Fong  <roger_fong@apple.com>
 810
 811         Unreviewed. Windows build fix...
 812
 813         * BuildSlaveSupport/built-product-archive:
 814         (createZip):
 815
 816 2013-05-31  Roger Fong  <roger_fong@apple.com>
 817
 818         Unreviewed. Windows build fix. One more time!
 819
 820         * BuildSlaveSupport/built-product-archive:
 821         (archiveBuiltProduct):
 822         (extractBuiltProduct):
 823
 824 2013-05-31  Roger Fong  <roger_fong@apple.com>
 825
 826         Unreviewed. Windows build fix.
 827
 828         * Scripts/build-webkit:
 829
 830 2013-05-31  Roger Fong  <roger_fong@apple.com>
 831
 832         Unreviewed. Windows build fix.
 833
 834         * Scripts/build-webkit:
 835
 836 2013-05-31  Roger Fong  <roger_fong@apple.com>
 837
 838         Make build-webkit output VCExpress 2010 build logs properly.
 839         https://bugs.webkit.org/show_bug.cgi?id=117096
 840
 841         Reviewed by Brent Fulgham.
 842
 843         Make it so that output from VCExpress is always printed to console.
 844         Get build log results from AssembleBuildLogs project output.
 845         We don't need those old VCExpress scripts anymore either.
 846
 847         * Scripts/build-webkit:
 848         * Scripts/print-msvc-project-dependencies: Removed.
 849         * Scripts/print-vse-failure-logs: Removed.
 850
 851 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
 852
 853         [Windows] Use WinLauncher to display LayoutTest results
 854         https://bugs.webkit.org/show_bug.cgi?id=117085
 855
 856         Reviewed by Oliver Hunt.
 857
 858         * Scripts/webkitdirs.pm:
 859         (runSafari): Use WinLauncher to display content
 860         * WinLauncher/WinLauncher.cpp:
 861         (dllLauncherEntryPoint): Check for URL argument.
 862
 863 2013-05-31  Roger Fong  <roger_fong@apple.com>
 864
 865         Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
 866
 867         * win/AssembleBuildLogs/AssembleLogs.cmd:
 868
 869 2013-05-31  Commit Queue  <commit-queue@webkit.org>
 870
 871         Unreviewed, rolling out r151022.
 872         http://trac.webkit.org/changeset/151022
 873         https://bugs.webkit.org/show_bug.cgi?id=117084
 874
 875         Also breaks build by introducing duplicate symbols (Requested
 876         by bfulgham on #webkit).
 877
 878         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
 879
 880 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
 881
 882         [Windows] Unreviewed build fix to NRWT
 883
 884         * Scripts/webkitpy/port/win.py:
 885         (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
 886
 887 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
 888
 889         [Windows] Unreviewed build fix after r151012
 890
 891         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
 892         WTF library to support SHA tests
 893
 894 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
 895
 896         [Windows] Unreviewed build fix after r151012
 897
 898         * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
 899         snprintf definition for Windows.
 900
 901 2013-05-31  Zan Dobersek  <zdobersek@igalia.com>
 902
 903         Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
 904         https://bugs.webkit.org/show_bug.cgi?id=116445
 905
 906         Reviewed by Benjamin Poulain.
 907
 908         Add the MD5 and SHA1 unit tests that were previously located inside WTF.
 909
 910         * TestWebKitAPI/CMakeLists.txt:
 911         * TestWebKitAPI/GNUmakefile.am:
 912         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
 913         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
 914         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 915         * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
 916         (TestWebKitAPI):
 917         (TestWebKitAPI::expectMD5):
 918         (TestWebKitAPI::TEST):
 919         * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
 920         (TestWebKitAPI):
 921         (TestWebKitAPI::expectSHA1):
 922         (TestWebKitAPI::TEST):
 923         * TestWebKitAPI/Tests/WTF/WTF.pro:
 924         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
 925
 926 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
 927
 928         [Windows] Unreviewed build correction.
 929
 930         * Scripts/webkitpy/port/win.py:
 931         (WinPort.create_debugger_command_file): The directory needs to be
 932         a string, not a temporary directory object.
 933
 934 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
 935
 936         [Windows] NRWT doesn't save crash logs on Apple's Windows port.
 937         https://bugs.webkit.org/show_bug.cgi?id=76935
 938
 939         Reviewed by Ryosuke Niwa.
 940
 941         Extend the WinPort class with commands to set and clean up various registry
 942         values needed to invoke the correct debugger to get crash files.
 943
 944         * Scripts/webkitpy/port/win.py:
 945         (WinPort): Added global caches for registry keys and settings
 946         (WinPort._ntsd_location): Added
 947         (WinPort.create_debugger_command_file): Added
 948         (WinPort.read_registry_string): Added
 949         (WinPort.write_registry_string): Added
 950         (WinPort.setup_crash_log_saving): Added
 951         (WinPort.restore_crash_log_saving): Added
 952         (WinPort.setup_test_run): Added overload to add registry settings.
 953         (WinPort.clean_up_test_run): Added overload to clean up registry settings.
 954
 955 2013-05-30  Roger Fong  <roger_fong@apple.com>
 956
 957         Get rid of JavaScript exports file on AppleWin port.
 958         https://bugs.webkit.org/show_bug.cgi?id=117050.
 959
 960         Reviewed by Darin Adler.
 961
 962         Start linking in WTF.lib now that it's a shared library.
 963
 964         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
 965         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
 966         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
 967
 968 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
 969
 970         Web Inspector: tests in PerformanceTests/inspector/ are timing out
 971         https://bugs.webkit.org/show_bug.cgi?id=77024
 972
 973         Reviewed by Andreas Kling.
 974
 975         Remove inspector performance tests since they have been disabled for ages,
 976         and they don't use the standard parser-style performance output.
 977
 978         It's adding a lot of code complexity to our infrastructure.
 979
 980         * Scripts/webkitpy/performance_tests/perftest.py:
 981         (SingleProcessPerfTest.__init__):
 982         (PerfTestFactory):
 983         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
 984         (TestPerfTestFactory.test_regular_test):
 985         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
 986         (TestDriver.run_test):
 987         (MainTest.run_test):
 988         (MainTest._tests_for_runner):
 989         (MainTest.test_run_test_set_kills_drt_per_run):
 990         (MainTest._test_run_with_json_output):
 991         (MainTest):
 992         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
 993
 994 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
 995
 996         Remove requires_http_server as Chromium Android was the only port that needed this
 997         https://bugs.webkit.org/show_bug.cgi?id=117018
 998
 999         Reviewed by Benjamin Poulain.
1000
1001         Removed the unused code that existed for Chromium Android port.
1002
1003         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1004         (LayoutTestRunner.run_tests):
1005         (LayoutTestRunner._handle_finished_test_list):
1006         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1007         (Manager._run_tests):
1008         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1009         (PerfTestsRunner._collect_tests):
1010         (PerfTestsRunner.run):
1011         * Scripts/webkitpy/port/base.py:
1012         (Port.to.start_helper):
1013         * Scripts/webkitpy/port/base_unittest.py:
1014         (PortTest.test_build_path):
1015
1016 2013-05-29  Ruth Fong  <ruth_fong@apple.com>
1017
1018         prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
1019         https://bugs.webkit.org/show_bug.cgi?id=113221
1020
1021         Reviewed by Ryosuke Niwa.
1022
1023         Teach prepare-Changelog to not list the names of modified namespaces,
1024         classes, or structs in C++ files. Thus, if a change is made
1025         within a namespace/class/struct yet outside a function, it will
1026         not be reflected in the ChangeLog entry.
1027         See https://bugs.webkit.org/show_bug.cgi?id=113221#c8
1028         for more details on how ChangeLog entries are affected.
1029
1030         * Scripts/prepare-ChangeLog:
1031         (get_function_line_ranges_for_cpp):
1032         (delete_namespaces_from_ranges_for_cpp): Added.
1033         (is_function_in_namespace): Added.
1034         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
1035         to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
1036
1037 2013-05-29  Praveen R Jadhav  <praveen.j@samsung.com>
1038
1039         Cleanup AudioSourceNode.idl from WebKit build.
1040         https://bugs.webkit.org/show_bug.cgi?id=116905.
1041
1042         Reviewed by Darin Adler.
1043
1044         AudioSourceNode.idl is not part of WebAudio Specifications anymore.
1045         AudioNode is inherited directly in all the audio source nodes.
1046
1047         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1048
1049 2013-05-29  Andrew Lo  <anlo@rim.com>
1050
1051         Add Andrew Lo to contributors.json
1052         https://bugs.webkit.org/show_bug.cgi?id=116981
1053
1054         Reviewed by Rob Buis.
1055
1056         Adding Andrew Lo to contributors.json.
1057
1058         * Scripts/webkitpy/common/config/contributors.json:
1059
1060 2013-05-29  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1061
1062         Unreviewed. Adding myself as a committer.
1063
1064         * Scripts/webkitpy/common/config/contributors.json:
1065
1066 2013-05-29  Marcelo Lira  <marcelo.lira@openbossa.org>
1067
1068         [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
1069         https://bugs.webkit.org/show_bug.cgi?id=116683
1070
1071         Reviewed by Noam Rosenthal.
1072
1073         A coordinates conversion test for WKViewUserViewportToContents was
1074         added to WebKit2 API tests.
1075
1076         * TestWebKitAPI/PlatformEfl.cmake:
1077         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
1078         (TestWebKitAPI):
1079         (TestWebKitAPI::TEST):
1080
1081 2013-05-29  Yong Li  <yong.li.webkit@outlook.com>
1082
1083         Unreviewed. Update my info.
1084
1085         * Scripts/webkitpy/common/config/contributors.json:
1086
1087 2013-05-29  Dongseong Hwang  <dongseong.hwang@intel.com>
1088
1089         Unreviewed. Add myself as committer in contributors.json.
1090
1091         * Scripts/webkitpy/common/config/contributors.json:
1092
1093 2013-05-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1094
1095         Unreviewed. Fix make distcheck.
1096
1097         * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
1098         DISTCLEANFILES.
1099
1100 2013-05-29  Mary Wu  <mawu@blackberry.com>
1101
1102         Unreviewed: update my email address in contributors.json.
1103
1104         * Scripts/webkitpy/common/config/contributors.json:
1105
1106 2013-05-29  Kalyan Kondapally  <kalyan.kondapally@intel.com>
1107
1108         Unreviewed: Adding myself to committers list.
1109
1110         * Scripts/webkitpy/common/config/contributors.json:
1111
1112 2013-05-28  Arpita Bahuguna  <a.bah@samsung.com>
1113
1114         Unreviewed: Adding myself to committers list.
1115
1116         * Scripts/webkitpy/common/config/contributors.json:
1117
1118 2013-05-28  Brent Fulgham  <bfulgham@webkit.org>
1119
1120         [Windows] Many CSS2.1 tests fail under NRWT.
1121         https://bugs.webkit.org/show_bug.cgi?id=75707
1122
1123         Reviewed by Darin Adler.
1124
1125         * DumpRenderTree/win/DumpRenderTree.cpp:
1126         (findFontFallback): Added
1127         (addFontFallbackIfPresent): Added
1128         (removeFontFallbackIfPresent): Added
1129         (runTest): Set up/remove font fallbacks when needed.
1130
1131 2013-05-28  Brent Fulgham  <bfulgham@apple.com>
1132
1133         [Windows] NRWT reports failure for 'mac' test cases.
1134         https://bugs.webkit.org/show_bug.cgi?id=116698
1135
1136         Reviewed by Ryosuke Niwa.
1137
1138         The Windows port falls back to the Mac port for many test results,
1139         and so adds the mac and mac-wk2 to its set of fallbacks.
1140         Unfortunately, NRWT thinks that this means that tests in these
1141         folders should be executed, resulting in many failures on
1142         Windows.
1143
1144         This change overloads the '_tests_for_other_platforms' method
1145         to return a subset of the result fallback list so that we do
1146         not attempt to execute Mac tests on Windows.
1147
1148         * Scripts/webkitpy/port/base.py:
1149         (Port.test_search_path): Added. Defaults to just calling the
1150         baseline_search_path method, which is how most ports behave.
1151         (Port._test_for_other_platforms): Modified to call the new
1152         test_search_path method.
1153
1154         * Scripts/webkitpy/port/win.py:
1155         (WinPort.test_search_path): Added custom overload. Strips
1156         out mac-specific test paths.
1157
1158 2013-05-28  Martin Robinson  <mrobinson@igalia.com>
1159
1160         Fix GTK+ CMake build
1161
1162         * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
1163         library target is simply "WebKit2."
1164
1165 2013-05-28  Zan Dobersek  <zdobersek@igalia.com>
1166
1167         [webkitpy] Explicitly specify the reference file extensions
1168         https://bugs.webkit.org/show_bug.cgi?id=116333
1169
1170         Reviewed by Benjamin Poulain.
1171
1172         Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
1173         between valid reference files required by reftests and text baselines that have the same extension as
1174         potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
1175         that were until this change recognized as reference files).
1176
1177         Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
1178
1179         * Scripts/webkitpy/port/base.py:
1180         (Port.reference_files): Iterate through the _supported_reference_extensions set.
1181         (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
1182         _supported_reference_extensions set, containing the extensions allowed for reference files.
1183         (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
1184         (Port._has_supported_extension): Use _supported_test_extensions.
1185         * Scripts/webkitpy/port/base_unittest.py:
1186         (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
1187         Port.is_reference_html_file method.
1188
1189 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1190
1191         Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
1192
1193         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1194         (NewCommitBot.next_work_item):
1195
1196 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1197
1198         WKR and webkitbot build fixes.
1199
1200         * Scripts/webkitpy/tool/bot/irc_command.py:
1201         (RollChromiumDEPS.execute):
1202         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1203         (NewCommitBot.next_work_item):
1204
1205 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1206
1207         roll-chromium-deps doesn't repeat the full name.
1208
1209         Rubber-stamped by Andreas Kling.
1210
1211         * Scripts/webkitpy/tool/bot/irc_command.py:
1212         (RollChromiumDEPS.execute):
1213
1214 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1215
1216         Revert another erroneous change.
1217
1218         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1219         (NewCommitBot.next_work_item):
1220
1221 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1222
1223         Revert an erroneous change.
1224
1225         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1226         (SheriffBot):
1227
1228 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1229
1230         Some build fixes for WKR and webkitbot.
1231
1232         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1233         (IRCBotTest.test_help):
1234         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1235         (Agent):
1236         (Agent.__init__):
1237         (Agent.name):
1238         (NewCommitBot):
1239         (NewCommitBot.begin_work_queue):
1240         (NewCommitBot.next_work_item):
1241         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1242         (SheriffBot):
1243
1244 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1245
1246         Teach webkitbot and WKR how to respond to yt?
1247         https://bugs.webkit.org/show_bug.cgi?id=116775
1248
1249         Reviewed by Andreas Kling.
1250
1251         * Scripts/webkitpy/tool/bot/irc_command.py:
1252         (Hi): Fixed the usage string.
1253         (Hi.execute): Made it more generic so that it works in WKR.
1254         (YouThere): Added.
1255         (YouThere.execute): Added.
1256         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1257
1258 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
1259
1260         Try to fix the EFL build.
1261
1262         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1263         (TestRunner::setPageVisibility):
1264
1265 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
1266
1267         Unprefix Page Visibility API
1268         https://bugs.webkit.org/show_bug.cgi?id=102340
1269
1270         Reviewed by Tim Horton.
1271
1272         Rename "preview" state to "unloaded" state, and adjust the tests
1273         to test for it.
1274
1275         * DumpRenderTree/mac/TestRunnerMac.mm:
1276         (TestRunner::setPageVisibility):
1277         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
1278         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
1279         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
1280         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
1281         (TestWebKitAPI::didRunStep4InStateUnloaded):
1282         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
1283         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1284         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1285         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1286         (WTR::TestRunner::setPageVisibility):
1287
1288 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
1289
1290         Unreviewed build fix. Don't use new NRWT logic needed
1291         by Windows yet. Activate (and fix test) when we cut over.
1292
1293         * Scripts/webkitpy/port/driver.py:
1294         (Driver._setup_environ_for_driver):
1295         (Driver._start):
1296
1297 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
1298
1299         [Windows] Expose database storage and cache locations via preferences.
1300         https://bugs.webkit.org/show_bug.cgi?id=116729
1301
1302         Reviewed by Tim Horton.
1303
1304         Update DumpRenderTree to use CFPreferences to control where WebKit
1305         stores its local databases, URL caches, etc.
1306
1307         * DumpRenderTree/win/DumpRenderTree.cpp:
1308         (libraryPathForDumpRenderTree): Added.
1309         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
1310         * Scripts/webkitpy/port/base.py:
1311         (Port._driver_tempdir): Added (to allow port-specific overload).
1312         (Port._driver_tempdir_for_environment): Ditto
1313         * Scripts/webkitpy/port/driver.py:
1314         (Driver._setup_environ_for_driver): Use new overload to set
1315         environment variable.
1316         (Driver._start): Use new overload for temp directory location.
1317         * Scripts/webkitpy/port/win.py:
1318         (WinPort._driver_tempdir_for_environment): New overload to supply
1319         Windows path to DumpRenderTree environment (while still using
1320         cygwin paths for internal operations.
1321
1322 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1323
1324         Remove custom code for webkitAudioContext global constructor getter
1325         https://bugs.webkit.org/show_bug.cgi?id=116530
1326
1327         Reviewed by Geoffrey Garen.
1328
1329         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
1330         WebAudio feature instead of public ewk_view API since that API was
1331         removed.
1332
1333         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1334         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1335         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1336         (TestRunner::overridePreference):
1337
1338 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
1339
1340         Make team.html have each contributor's area of expertise
1341         https://bugs.webkit.org/show_bug.cgi?id=116737
1342
1343         Reviewed by Benjamin Poulain.
1344
1345         * Scripts/webkitpy/common/config/contributors.json:
1346         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
1347
1348         Changed formatting of the file because the lines are getting way to
1349         long, and I generated this, so it's easier if the formatting of the
1350         file is regular.
1351
1352 2013-05-24  Simon Pena  <simon.pena@samsung.com>
1353
1354         Update WTF::Vector pretty printers
1355         https://bugs.webkit.org/show_bug.cgi?id=116719
1356
1357         Reviewed by Anders Carlsson.
1358
1359         After r148891, WTF::Vector pretty printers were left outdated, as
1360         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
1361         one as a member. This patch updates the pretty printers so they work
1362         again.
1363
1364         * gdb/webkit.py:
1365         (WTFVectorPrinter.children):
1366         (WTFVectorPrinter.to_string):
1367
1368 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
1369
1370         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
1371         https://bugs.webkit.org/show_bug.cgi?id=116710
1372
1373         Reviewed by Mark Rowe.
1374
1375         * DumpRenderTree/mac/DumpRenderTree.mm:
1376         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
1377
1378 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
1379
1380         Add missing dependencies to deps script.
1381
1382         [GTK] Missing packages in install-dependencies script.
1383         https://bugs.webkit.org/show_bug.cgi?id=116632
1384
1385         Reviewed by Martin Robinson.
1386
1387         * gtk/install-dependencies:
1388
1389 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
1390
1391         [Windows] Unreviewed change for NRWT support.
1392
1393         * Scripts/webkitpy/port/win.py:
1394         (WinPort.default_child_processes): Added a default implementation
1395         that limits NRWT to a single instance.
1396
1397 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
1398
1399         Remove meaningless "test_uses_apache" from Python test cases.
1400         https://bugs.webkit.org/show_bug.cgi?id=38756
1401
1402         Reviewed by Ryosuke Niwa.
1403
1404         * Scripts/webkitpy/port/port_testcase.py:
1405         (PortTestCase.test_driver_cmd_line): Remove the meaningless
1406         "test_uses_apache" test case from the Python test infrastructure.
1407         It was hard-coded to true, even though not all ports use
1408         Apache.
1409
1410 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
1411
1412         [Windows] Update new-run-webkit-tests for Windows port.
1413         https://bugs.webkit.org/show_bug.cgi?id=38756
1414
1415         Reviewed by Ryosuke Niwa.
1416
1417         * Scripts/new-run-webkit-httpd:
1418         (run): Switch from 'chromium' to 'win'
1419         * Scripts/webkitpy/port/win.py:
1420         (WinPort): Add support methods for lighttpd server.
1421         (WinPort._uses_apache):
1422         (WinPort._path_to_lighttpd):
1423         (WinPort._path_to_lighttpd_modules):
1424         (WinPort._path_to_lighttpd_php):
1425
1426 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
1427
1428         Make default bug links in buildbot clickable
1429         https://bugs.webkit.org/show_bug.cgi?id=116673
1430
1431         Reviewed by Ryosuke Niwa.
1432
1433         Use changecommentlink of html.WebStatus to make the links clickable.
1434
1435         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1436
1437 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
1438
1439         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
1440         https://bugs.webkit.org/show_bug.cgi?id=116595
1441
1442         Temporarily skip this test.
1443
1444         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1445         (TestWebKitAPI::TEST):
1446
1447 2013-05-22  Alex Christensen  <achristensen@apple.com>
1448
1449         Unreviewed.  Added myself to contributors.json.
1450
1451         * Scripts/webkitpy/common/config/contributors.json:
1452         Added myself.
1453
1454 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1455
1456         [EFL][WK2] Add sub menus to MiniBrowser
1457         https://bugs.webkit.org/show_bug.cgi?id=114728
1458
1459         Reviewed by Christophe Dumez.
1460
1461         Elementary Ctxpopup widget API does not provide support for submenu item.
1462         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
1463         Elementary Menu widget.
1464
1465         * MiniBrowser/efl/main.c:
1466         (_Browser_Window):
1467         (on_window_resize):
1468         (window_free):
1469         (context_menu_item_selected_cb):
1470         (context_menu_populate):
1471         (on_context_menu_show):
1472         (on_context_menu_hide):
1473         (window_create):
1474
1475 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
1476
1477         [EFL] Add command line option to MiniBrowser to set cookies policy.
1478         https://bugs.webkit.org/show_bug.cgi?id=115028
1479
1480         Reviewed by Christophe Dumez.
1481
1482         Add command line option to MiniBrowser EFL to set cookies policy:
1483         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
1484         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
1485
1486         * MiniBrowser/efl/main.c:
1487         (elm_main):
1488
1489 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1490
1491         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
1492         https://bugs.webkit.org/show_bug.cgi?id=116585
1493
1494         Reviewed by Alexey Proskuryakov.
1495
1496         willLoadURLRequest and willLoadDataRequest require the API version 6.
1497
1498         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1499
1500 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1501
1502         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
1503         https://bugs.webkit.org/show_bug.cgi?id=116516
1504
1505         Reviewed by Alexey Proskuryakov.
1506
1507         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
1508
1509         * DumpRenderTree/mac/DumpRenderTree.mm:
1510         (createWebViewAndOffscreenWindow): Match the ordering.
1511         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
1512
1513 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
1514
1515         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
1516         https://bugs.webkit.org/show_bug.cgi?id=116568
1517
1518         Reviewed by Anders Carlsson.
1519
1520         * WebKitTestRunner/WebNotificationProvider.cpp:
1521         (WTR::WebNotificationProvider::~WebNotificationProvider):
1522         * WebKitTestRunner/WebNotificationProvider.h:
1523         When the provider is destroyed, it should no longer be registered with the manager.
1524
1525         * WebKitTestRunner/GeolocationProviderMock.cpp:
1526         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
1527         * WebKitTestRunner/GeolocationProviderMock.h:
1528         I wasn't seeing a crash here, but this code has the same issue as notification
1529         provider, so applying the same fix.
1530
1531         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1532         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
1533         destructor having fixed the above.
1534
1535 2013-05-21  Commit Queue  <commit-queue@webkit.org>
1536
1537         Unreviewed, rolling out r150386 and r150397.
1538         http://trac.webkit.org/changeset/150386
1539         http://trac.webkit.org/changeset/150397
1540         https://bugs.webkit.org/show_bug.cgi?id=116572
1541
1542         Broke a test; Alex is going to try again later. (Requested by
1543         thorton on #webkit).
1544
1545         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1546         (WTR::pathSuitableForTestResult):
1547         (WTR::dumpRequestDescriptionSuitableForTestResult):
1548         (WTR::dumpResponseDescriptionSuitableForTestResult):
1549         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1550         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1551         (WTR::InjectedBundlePage::willSendRequestForFrame):
1552         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1553         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1554         (InjectedBundlePage):
1555
1556 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1557
1558         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
1559
1560         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1561         (AbstractCommitLogCommand._recent_commit_messages):
1562
1563 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
1564
1565         [GTK] [CMake] Add support for building WebKit2
1566         https://bugs.webkit.org/show_bug.cgi?id=116372
1567
1568         Reviewed by Gustavo Noronha Silva.
1569
1570         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
1571         * MiniBrowser/gtk/CMakeLists.txt: Added.
1572
1573 2013-05-21  Jessie Berlin  <jberlin@apple.com>
1574
1575         Revert r149635, it was too optimistic.
1576
1577         Rubber-stamped by Andreas Kling.
1578
1579         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
1580         #ifdefs in WebCore code outside of WebCore/platform.
1581
1582         * Scripts/webkitpy/style/checkers/cpp.py:
1583         (check_invalid_increment):
1584         (process_line):
1585         (CppChecker):
1586         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1587         (CppStyleTest.test_plain_integral_bitfields):
1588
1589 2013-05-21  Jer Noble  <jer.noble@apple.com>
1590
1591         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
1592
1593         * lldb/lldb_webkit.py:
1594         (WTFVectorProvider.num_children):
1595         (WTFVectorProvider.get_child_index):
1596         (WTFVectorProvider.get_child_at_index):
1597         (WTFVectorProvider.update):
1598
1599 2013-05-21  Jessie Berlin  <jberlin@apple.com>
1600
1601         Expose a way to know when forms are added to a page or when form controls are added to a form
1602         in the injected bundle
1603         https://bugs.webkit.org/show_bug.cgi?id=116334
1604
1605         Reviewed by Alexey Proskuryakov.
1606
1607         Add tests for the new callbacks.
1608
1609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1610         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
1611
1612         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
1613         (TestWebKitAPI::nullJavaScriptCallback):
1614         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
1615         being passed in for the callback.
1616         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1617         After receiving the message that didAssociateFormControls callback was invoked from adding
1618         the form in the onload handler, tell the page to add a password field to the form, which
1619         should also invoke didAssociateFormControls callback.
1620         (TestWebKitAPI::setInjectedBundleClient):
1621         Register to receive messages.
1622         (TestWebKitAPI::TEST):
1623         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
1624         been invoked for both adding the form and for adding a password field to the form.
1625
1626         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
1627         (TestWebKitAPI::shouldNotifyOnFormChanges):
1628         Return true so the didAssociateFormControls callback is invoked.
1629         (TestWebKitAPI::didAssociateFormControls):
1630         Tell the UI process.
1631         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
1632         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1633         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
1634
1635         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
1636         Add a form in response to the onload event. Add a button that will add the password field
1637         for manual testing.
1638
1639 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
1640
1641         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
1642         https://bugs.webkit.org/show_bug.cgi?id=106341
1643
1644         Reviewed by Martin Robinson.
1645
1646         Adds support for retrieving accessibility element at exact point.
1647
1648         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1649         (WTR::AccessibilityUIElement::elementAtPoint):
1650
1651 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
1652
1653         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
1654         https://bugs.webkit.org/show_bug.cgi?id=112913
1655
1656         Reviewed by Martin Robinson.
1657
1658         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
1659         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
1660         so the leak appears.
1661
1662         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1663         (WTR):
1664         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1665         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1666         (WTR::AccessibilityController::rootElement):
1667         (WTR):
1668         (WTR::AccessibilityController::focusedElement):
1669         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1670         (WTR::checkElementState):
1671         (WTR::indexRangeInTable):
1672         (WTR::alterCurrentValue):
1673         (WTR::AccessibilityUIElement::getChildren):
1674         (WTR::AccessibilityUIElement::getChildrenWithRange):
1675         (WTR::AccessibilityUIElement::childrenCount):
1676         (WTR::AccessibilityUIElement::indexOfChild):
1677         (WTR::AccessibilityUIElement::titleUIElement):
1678         (WTR::AccessibilityUIElement::parentElement):
1679         (WTR::AccessibilityUIElement::allAttributes):
1680         (WTR::AccessibilityUIElement::role):
1681         (WTR::AccessibilityUIElement::title):
1682         (WTR::AccessibilityUIElement::description):
1683         (WTR::AccessibilityUIElement::orientation):
1684         (WTR::AccessibilityUIElement::stringValue):
1685         (WTR::AccessibilityUIElement::language):
1686         (WTR::AccessibilityUIElement::x):
1687         (WTR::AccessibilityUIElement::y):
1688         (WTR::AccessibilityUIElement::width):
1689         (WTR::AccessibilityUIElement::height):
1690         (WTR::AccessibilityUIElement::intValue):
1691         (WTR::AccessibilityUIElement::minValue):
1692         (WTR::AccessibilityUIElement::maxValue):
1693         (WTR::AccessibilityUIElement::isEnabled):
1694         (WTR::AccessibilityUIElement::isFocused):
1695         (WTR::AccessibilityUIElement::isSelected):
1696         (WTR::AccessibilityUIElement::isExpanded):
1697         (WTR::AccessibilityUIElement::isChecked):
1698         (WTR::AccessibilityUIElement::rowCount):
1699         (WTR::AccessibilityUIElement::columnCount):
1700         (WTR::AccessibilityUIElement::rowIndexRange):
1701         (WTR::AccessibilityUIElement::columnIndexRange):
1702         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1703         (WTR::AccessibilityUIElement::increment):
1704         (WTR::AccessibilityUIElement::decrement):
1705         (WTR::AccessibilityUIElement::press):
1706         (WTR::AccessibilityUIElement::documentEncoding):
1707         (WTR::AccessibilityUIElement::documentURI):
1708         (WTR::AccessibilityUIElement::isFocusable):
1709         (WTR::AccessibilityUIElement::isSelectable):
1710         (WTR::AccessibilityUIElement::isMultiSelectable):
1711         (WTR::AccessibilityUIElement::isVisible):
1712
1713 2013-05-20  Lucas Forschler  <lforschler@apple.com>
1714
1715     Rollout 150398.
1716
1717 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
1718
1719         [GTK] Fix concatenations of string literals that are not C++11-compliant
1720         https://bugs.webkit.org/show_bug.cgi?id=116449
1721
1722         Reviewed by Martin Robinson.
1723
1724         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
1725         is simply a matter of separating the string and the string literal that are being concatenated with a space.
1726
1727         * ImageDiff/gtk/ImageDiff.cpp:
1728         (printImage):
1729
1730 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
1731
1732         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
1733         https://bugs.webkit.org/show_bug.cgi?id=116450
1734
1735         Reviewed by Martin Robinson.
1736
1737         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
1738         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
1739         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
1740         TestWebKitAPI programs when compiling them.
1741
1742         * TestWebKitAPI/GNUmakefile.am:
1743
1744 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1745
1746         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
1747         https://bugs.webkit.org/show_bug.cgi?id=116492
1748
1749         Reviewed by Dirk Pranke.
1750
1751         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
1752
1753         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
1754         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
1755         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
1756         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
1757         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
1758         to memory pressure on the machine.
1759
1760         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
1761         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
1762         for a subsequent patch just to make things easier to follow.
1763
1764         * Scripts/webkitpy/port/driver.py:
1765         (DriverProxy.__init__):
1766         (DriverProxy.run_test):
1767         (DriverProxy.has_crashed):
1768         (DriverProxy.stop):
1769
1770 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1771
1772         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
1773         https://bugs.webkit.org/show_bug.cgi?id=116423
1774
1775         Reviewed by Ryosuke Niwa.
1776
1777         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
1778
1779         * BuildSlaveSupport/build.webkit.org-config/config.json:
1780
1781 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
1782
1783         Remove remaining link-prerender code
1784         https://bugs.webkit.org/show_bug.cgi?id=116429
1785
1786         Reviewed by Darin Adler.
1787
1788         Link prerendering code was removed in r150356.
1789
1790         * Scripts/webkitperl/FeatureList.pm:
1791         * qmake/mkspecs/features/features.pri:
1792
1793 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1794
1795         commit-queue should check for oops in changelog entries
1796         https://bugs.webkit.org/show_bug.cgi?id=116395
1797
1798         Reviewed by Martin Robinson.
1799
1800         Make changelog validation fail when it contains oops!.
1801
1802         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1803         (CommitQueueTask._validate_changelog):
1804         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1805         (CommitQueueTaskTest._run_through_task):
1806         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1807         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1808         (ValidateChangeLogs.options):
1809         (ValidateChangeLogs._check_changelog_diff):
1810         (ValidateChangeLogs._changelog_contains_oops):
1811         (ValidateChangeLogs.run):
1812         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1813         (ValidateChangeLogsTest._assert_start_line_produces_output):
1814         (ValidateChangeLogsTest.test_check_changelog_diff):
1815         (ValidateChangeLogsTest):
1816         (ValidateChangeLogsTest.test_changelog_contains_oops):
1817
1818 2013-05-20  Jessie Berlin  <jberlin@apple.com>
1819
1820         Expose a way to know when forms are added to a page or when form controls are added to a form
1821         in the injected bundle
1822         https://bugs.webkit.org/show_bug.cgi?id=116334
1823
1824         Reviewed by Alexey Proskuryakov.
1825
1826         Add tests for the new callbacks.
1827
1828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1829         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
1830
1831         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
1832         (TestWebKitAPI::nullJavaScriptCallback):
1833         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
1834         being passed in for the callback.
1835         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1836         After receiving the message that didAssociateFormControls callback was invoked from adding
1837         the form in the onload handler, tell the page to add a password field to the form, which
1838         should also invoke didAssociateFormControls callback.
1839         (TestWebKitAPI::setInjectedBundleClient):
1840         Register to receive messages.
1841         (TestWebKitAPI::TEST):
1842         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
1843         been invoked for both adding the form and for adding a password field to the form.
1844
1845         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
1846         (TestWebKitAPI::shouldNotifyOnFormChanges):
1847         Return true so the didAssociateFormControls callback is invoked.
1848         (TestWebKitAPI::didAssociateFormControls):
1849         Tell the UI process.
1850         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
1851         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1852         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
1853
1854         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
1855         Add a form in response to the onload event. Add a button that will add the password field
1856         for manual testing.
1857
1858 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1859
1860         [EFL][JHBUILD] Make sure eet is built before evas
1861         https://bugs.webkit.org/show_bug.cgi?id=116440
1862
1863         Reviewed by Gyuyoung Kim.
1864
1865         Mark eet as a dependency of evas since evas requires eet to enable some of its
1866         functionality.
1867
1868         * efl/jhbuild.modules:
1869
1870 2013-05-20  Alex Christensen  <achristensen@apple.com>
1871
1872         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
1873         https://bugs.webkit.org/show_bug.cgi?id=116125
1874
1875         Reviewed by Tim Horton.
1876
1877         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1878         (WTR::pathSuitableForTestResult):
1879         Changed string operations to match _drt_descriptionSuitableForTestResult.
1880         (WTR::dumpRequestDescriptionSuitableForTestResult):
1881         (WTR::dumpResponseDescriptionSuitableForTestResult):
1882         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1883         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1884         (WTR::InjectedBundlePage::willSendRequestForFrame):
1885         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1886         Pass the main frame's URL to pathSuitableForTestResult.
1887         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1888         Added WKBundlePageRef to willPerformClientRedirectForFrame.
1889
1890 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
1891
1892         fix w3c test importer unit tests after r150324
1893         https://bugs.webkit.org/show_bug.cgi?id=116459
1894
1895         Reviewed by Ryosuke Niwa.
1896
1897         This patch fixes the unit tests to not actually call out to
1898         'hg' (by using a mock executive) and also changes the real
1899         directory we crawl from Source/WebCore/css to
1900         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
1901         still change this to a mock filesystem, but that's a separate change.
1902
1903         * Scripts/webkitpy/w3c/test_importer.py:
1904         (main):
1905         (TestImporter.__init__):
1906         (TestImporter.load_changeset):
1907         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1908         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1909         (TestImporterTest.test_import_dir_with_no_tests):
1910
1911 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1912
1913         Unreviewed EFL build fix.
1914
1915         Fix linking errors due to undefined symbols on Ubuntu 13.04.
1916
1917         * DumpRenderTree/efl/CMakeLists.txt:
1918         * EWebLauncher/CMakeLists.txt:
1919         * MiniBrowser/efl/CMakeLists.txt:
1920
1921 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1922
1923         [EFL] Reenabled INDEXED_DATABASE after r150344
1924         https://bugs.webkit.org/show_bug.cgi?id=116430
1925
1926         Reviewed by Gyuyoung Kim.
1927
1928         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
1929         build was fixed in r150344.
1930
1931         * Scripts/webkitperl/FeatureList.pm:
1932
1933 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
1934
1935         [EFL] init/shutdown should be paired in EWebLauncher
1936         https://bugs.webkit.org/show_bug.cgi?id=116427
1937
1938         Reviewed by Christophe Dumez.
1939
1940         Added ecore_file_shutdown() for cleanup of ecore_file.
1941         Removed edje_init and ecore_evas_init because it was in ewk_init().
1942
1943         * EWebLauncher/main.c:
1944         (main):
1945
1946 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
1947
1948         [EFL] Add command line option to MiniBrowser to set user agent
1949         https://bugs.webkit.org/show_bug.cgi?id=116387
1950
1951         Reviewed by Christophe Dumez.
1952
1953         We need this option to compare the rendering differences according to different user agents.
1954
1955         * MiniBrowser/efl/main.c:
1956         (window_create):
1957         (elm_main):
1958
1959 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
1960
1961         Unreviewed, addressing test-webkitpy failures after r150317.
1962
1963         * Scripts/webkitpy/w3c/test_converter.py:
1964         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
1965
1966 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
1967
1968         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
1969         https://bugs.webkit.org/show_bug.cgi?id=114554
1970
1971         Reviewed by Gyuyoung Kim.
1972
1973         Using variables as target names is very uncommon in CMake.
1974         The usual way to specify the name of the resulting binary
1975         is to set the OUTPUT_NAME target property.
1976
1977         * DumpRenderTree/efl/CMakeLists.txt:
1978         * EWebLauncher/CMakeLists.txt:
1979         * ImageDiff/CMakeLists.txt:
1980         * MiniBrowser/efl/CMakeLists.txt:
1981         * TestWebKitAPI/CMakeLists.txt:
1982         * WebKitTestRunner/CMakeLists.txt:
1983         * WebKitTestRunner/PlatformEfl.cmake:
1984         * WinCELauncher/CMakeLists.txt:
1985
1986 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1987
1988         Unreviewed EFL build fix.
1989
1990         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
1991         WK2 build after r150305.
1992
1993         * Scripts/webkitperl/FeatureList.pm:
1994
1995 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
1996
1997         [GTK] Parallel build fails if gtk-doc is enabled
1998         https://bugs.webkit.org/show_bug.cgi?id=116227
1999
2000         Reviewed by Martin Robinson.
2001
2002         * GNUmakefile.am:
2003         Don't use the 'all' target to generate the documentation.
2004         The prerequisites of this target must be files that need to be
2005         built _before_ the actual compilation of WebKit starts. Since the
2006         documentation depends on WebKit being built first, this means in
2007         practice that the code will be built in parallel with the
2008         generation of its dependencies, potentially making the build fail.
2009
2010 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2011
2012         Don't run hg.
2013
2014         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2015         (TestImporterTest):
2016
2017 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
2018
2019         Create a script to import W3C tests
2020         https://bugs.webkit.org/show_bug.cgi?id=111513
2021
2022         Reviewed by Ryosuke Niwa.
2023
2024         This patch attempts to re-land the 'import-w3c-tests'
2025         script and accompanying modules.  The tests and code have
2026         been cleaned up so that we do not log anything to stdout/stderr
2027         while running the tests (thanks to outputcapture) and do not
2028         write into the source tree while running the tests, and much
2029         but not all of the code has been converted over to using the webkitpy
2030
2031         * Scripts/import-w3c-tests: Added.
2032         * Scripts/webkitpy/w3c/__init__.py: Added.
2033         * Scripts/webkitpy/w3c/test_converter.py: Added.
2034         (W3CTestConverter):
2035         (W3CTestConverter.__init__):
2036         (W3CTestConverter.path_from_webkit_root):
2037         (W3CTestConverter.read_webkit_prefixed_css_property_list):
2038         (W3CTestConverter.convert_for_webkit):
2039         (W3CTestConverter.convert_css):
2040         (W3CTestConverter.convert_html):
2041         (W3CTestConverter.convert_testharness_paths):
2042         (W3CTestConverter.convert_prefixed_properties):
2043         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
2044         (W3CTestConverter.replace_tag):
2045         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2046         (W3CTestConverterTest):
2047         (W3CTestConverterTest.fake_dir_path):
2048         (W3CTestConverterTest.test_read_prefixed_property_list):
2049         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
2050         (test_convert_for_webkit_harness_only):
2051         (test_convert_for_webkit_properties_only):
2052         (test_convert_for_webkit_harness_and_properties):
2053         (test_convert_test_harness_paths):
2054         (test_convert_prefixed_properties):
2055         (verify_conversion_happened):
2056         (verify_no_conversion_happened):
2057         (verify_test_harness_paths):
2058         (verify_prefixed_properties):
2059         (generate_test_content):
2060         * Scripts/webkitpy/w3c/test_importer.py: Added.
2061         (main):
2062         (parse_args):
2063         (validate_import_directory):
2064         (TestImporter):
2065         (TestImporter.__init__):
2066         (TestImporter.path_from_webkit_root):
2067         (TestImporter.do_import):
2068         (TestImporter.load_changeset):
2069         (TestImporter.find_importable_tests):
2070         (TestImporter.import_tests):
2071         (TestImporter.setup_destination_directory):
2072         (TestImporter.update_test_status):
2073         (TestImporter.remove_deleted_files):
2074         (TestImporter.write_import_log):
2075         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2076         (TestImporterTest):
2077         (TestImporterTest.test_import_dir_with_no_tests):
2078         * Scripts/webkitpy/w3c/test_parser.py: Added.
2079         (TestParser):
2080         (TestParser.__init__):
2081         (TestParser.load_file):
2082         (TestParser.analyze_test):
2083         (TestParser.reference_links_of_type):
2084         (TestParser.is_jstest):
2085         (TestParser.support_files):
2086         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2087         (TestParserTest):
2088         (TestParserTest.test_analyze_test_reftest_one_match):
2089         (test_analyze_test_reftest_multiple_matches):
2090         (test_analyze_test_reftest_match_and_mismatch):
2091         (test_analyze_test_reftest_with_ref_support_Files):
2092         (test_analyze_jstest):
2093         (test_analyze_pixel_test_all_true):
2094         (test_analyze_pixel_test_all_false):
2095         (test_analyze_non_html_file):
2096
2097 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2098
2099         Leaks builders exit early frequently
2100         https://bugs.webkit.org/show_bug.cgi?id=116355
2101
2102         Reviewed by Stephanie Lewis.
2103
2104         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
2105         we tolerate from 20 to 50.
2106
2107         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2108         (RunWebKitTests.start):
2109         * Scripts/webkitpy/port/mac.py:
2110         (MacPort.default_child_processes):
2111
2112 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
2113
2114         Remove chrome-channels command from the webkit-patch
2115         https://bugs.webkit.org/show_bug.cgi?id=116303
2116
2117         Reviewed by Ryosuke Niwa.
2118
2119         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
2120         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
2121         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
2122         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
2123         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
2124         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
2125
2126 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2127
2128         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
2129         Part 3 of 3: <http://webkit.org/b/116247>
2130
2131         Reviewed by Benjamin Poulain.
2132
2133         * Scripts/filter-build-webkit: Change while() loop to for() loop
2134         to track $previousLine, then pass $previousLine into
2135         shouldIgnoreLine().
2136         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
2137         line that begins with four spaces if the previous line is a
2138         linker error message.
2139         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2140         - Add "Ignored: " to test descriptions to document expected
2141           behavior.
2142         - Add comment blocks for various groups of tests.
2143         - Expand "Build settings" tests since we're changing the code in
2144           shouldIgnoreLine() that ignores those lines.
2145         - Add tests for undefined symbols error message.
2146         (description): Add.  Extract from global code.
2147
2148 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2149
2150         Add tests for shouldIgnoreLine() in filter-build-webkit
2151         Part 2 of 3: <http://webkit.org/b/116247>
2152
2153         Reviewed by Benjamin Poulain.
2154
2155         * Scripts/filter-build-webkit:
2156         (shouldIgnoreLine): Add.  Extract code from global scope into
2157         subroutine to make it testable.
2158         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
2159         Tests shouldIgnoreLine() using output from a real build
2160         transcript.
2161
2162 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2163
2164         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
2165         https://bugs.webkit.org/show_bug.cgi?id=116341
2166
2167         Reviewed by Brady Eidson.
2168
2169         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2170
2171 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
2172
2173         [Windows] Don't use pdevenv when building with VS2010.
2174         https://bugs.webkit.org/show_bug.cgi?id=116338.
2175
2176         Reviewed by Adam Roben.
2177
2178         * Scripts/webkitdirs.pm:
2179         (setupCygwinEnv): Check if we are using VS2005, and only use
2180         the 'pdevenv' hack if we are. Otherwise, just build with
2181         our standard project since it uses VS2010+'s native
2182         parallel building features.
2183
2184 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2185
2186         Unreviewed. Disable accelerated compositing until we figure out why it does not work
2187         properly in the 64 bits release bot.
2188
2189         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2190         (resetDefaultsToConsistentValues):
2191
2192 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2193
2194         Make filter-build-webkit testable using LoadAsModule
2195         Part 1 of 3: <http://webkit.org/b/116247>
2196
2197         Reviewed by Benjamin Poulain.
2198
2199         * Scripts/filter-build-webkit: Change global variables that are
2200         used in subroutines from 'my' to 'our' to make it possible to
2201         evaluate the script in a package context in LoadAsModule.pm.
2202
2203 2013-05-14  Sam Weinig  <sam@webkit.org>
2204
2205         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
2206         https://bugs.webkit.org/show_bug.cgi?id=116132
2207
2208         Reviewed by Anders Carlsson.
2209
2210         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
2211         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
2212
2213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2214         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
2215         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
2216         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2217
2218 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
2219
2220         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
2221         https://bugs.webkit.org/show_bug.cgi?id=114781
2222
2223         Reviewed by Christophe Dumez.
2224
2225         Add run_before_unload_confirm and
2226         Print the log message with "CONFIRM NAVIGATION: " in console.
2227
2228         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2229         (onBeforeUnloadConfirm):
2230         (drtViewAdd):
2231
2232 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
2233
2234         Fix Analyze ChangeLog's entry processing
2235         https://bugs.webkit.org/show_bug.cgi?id=116219
2236
2237         Reviewed by Ryosuke Niwa.
2238
2239         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2240         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
2241
2242 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
2243
2244         [Qt] UrlLoader::loadNext is broken in MiniBrowser
2245         https://bugs.webkit.org/show_bug.cgi?id=116099
2246
2247         Reviewed by Jocelyn Turcotte.
2248
2249         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
2250         are not available any more. So, UrlLoader::loadNext was broken
2251         because it failed to connect to those signals.
2252
2253         * MiniBrowser/qt/UrlLoader.cpp:
2254         (UrlLoader::UrlLoader):
2255         (UrlLoader::loadingChanged):
2256         * MiniBrowser/qt/UrlLoader.h:
2257         (UrlLoader):
2258
2259 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
2260
2261         [WebSocket] Update pywebsocket to r760
2262         https://bugs.webkit.org/show_bug.cgi?id=115863
2263
2264         Reviewed by Alexey Proskuryakov.
2265
2266         Version r760 supports a newer draft of message compression.
2267         We need this update to finish the permessage compression patch in
2268         bug 98840. This patch also fixes failing unit tests after the update.
2269
2270         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
2271         (StreamBase._read):
2272         (StreamBase._read.of):
2273         (StreamBase._write):
2274         (StreamBase.receive_bytes):
2275         (StreamBase._read_until):
2276         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
2277         (parse_frame):
2278         (StreamOptions.__init__):
2279         (Stream.__init__):
2280         (Stream._receive_frame_as_frame_object):
2281         (Stream._get_message_from_frame):
2282         (Stream._process_close_message):
2283         (Stream.close_connection):
2284         (Stream.get_last_received_opcode):
2285         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
2286         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
2287         (Dispatcher.do_extra_handshake):
2288         (Dispatcher.transfer_data):
2289         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
2290         (ExtensionProcessorInterface.__init__):
2291         (ExtensionProcessorInterface.request):
2292         (ExtensionProcessorInterface):
2293         (ExtensionProcessorInterface.name):
2294         (ExtensionProcessorInterface.check_consistency_with_other_processors):
2295         (ExtensionProcessorInterface.set_active):
2296         (ExtensionProcessorInterface.is_active):
2297         (ExtensionProcessorInterface._get_extension_response_internal):
2298         (ExtensionProcessorInterface.get_extension_response):
2299         (ExtensionProcessorInterface._setup_stream_options_internal):
2300         (ExtensionProcessorInterface.setup_stream_options):
2301         (_log_outgoing_compression_ratio):
2302         (_log_incoming_compression_ratio):
2303         (_parse_window_bits):
2304         (_AverageRatioCalculator):
2305         (_AverageRatioCalculator.__init__):
2306         (_AverageRatioCalculator.add_original_bytes):
2307         (_AverageRatioCalculator.add_result_bytes):
2308         (_AverageRatioCalculator.get_average_ratio):
2309         (DeflateFrameExtensionProcessor):
2310         (DeflateFrameExtensionProcessor.__init__):
2311         (DeflateFrameExtensionProcessor._get_extension_response_internal):
2312         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
2313         (DeflateFrameExtensionProcessor._outgoing_filter):
2314         (DeflateFrameExtensionProcessor._incoming_filter):
2315         (CompressionExtensionProcessorBase.for):
2316         (CompressionExtensionProcessorBase.__init__):
2317         (CompressionExtensionProcessorBase._get_extension_response_internal):
2318         (CompressionExtensionProcessorBase._setup_stream_options_internal):
2319         (PerFrameCompressExtensionProcessor):
2320         (PerMessageDeflateExtensionProcessor):
2321         (PerMessageDeflateExtensionProcessor.__init__):
2322         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
2323         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
2324         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
2325         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
2326         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
2327         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
2328         (PerMessageDeflateExtensionProcessor.set_bfinal):
2329         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
2330         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
2331         (_PerMessageDeflateFramer):
2332         (_PerMessageDeflateFramer.__init__):
2333         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
2334         (_PerMessageDeflateFramer._process_incoming_message):
2335         (_PerMessageDeflateFramer._process_outgoing_message):
2336         (_PerMessageDeflateFramer.setup_stream_options):
2337         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
2338         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
2339         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
2340         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
2341         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
2342         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
2343         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
2344         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
2345         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
2346         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
2347         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
2348         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
2349         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
2350         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
2351         (PerMessageCompressExtensionProcessor):
2352         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
2353         (MuxExtensionProcessor.__init__):
2354         (MuxExtensionProcessor.check_consistency_with_other_processors):
2355         (MuxExtensionProcessor):
2356         (MuxExtensionProcessor._get_extension_response_internal):
2357         (MuxExtensionProcessor._setup_stream_options_internal):
2358         (MuxExtensionProcessor.set_quota):
2359         (MuxExtensionProcessor.quota):
2360         (MuxExtensionProcessor.set_extensions):
2361         (MuxExtensionProcessor.extensions):
2362         (is_compression_extension):
2363         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
2364         (validate_subprotocol):
2365         (parse_host_header):
2366         (format_header):
2367         (check_request_line):
2368         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
2369         (Handshaker.do_handshake):
2370         (Handshaker._create_handshake_response):
2371         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
2372         (_validate_subprotocol):
2373         (_check_header_lines):
2374         (_build_location):
2375         (Handshaker.do_handshake):
2376         (Handshaker._set_subprotocol):
2377         (Handshaker._set_location):
2378         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
2379         (_create_dispatcher):
2380         (headerparserhandler):
2381         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
2382         (_create_add_channel_response):
2383         (_create_drop_channel):
2384         (_create_flow_control):
2385         (_create_new_channel_slot):
2386         (_create_fallback_new_channel_slot):
2387         (_MuxFramePayloadParser._read_number):
2388         (_MuxFramePayloadParser._read_size_and_contents):
2389         (_MuxFramePayloadParser._read_flow_control):
2390         (_MuxFramePayloadParser._read_new_channel_slot):
2391         (_LogicalConnection.__init__):
2392         (_LogicalConnection.write):
2393         (_LogicalConnection.on_write_data_done):
2394         (_LogicalConnection):
2395         (_LogicalConnection.on_writer_done):
2396         (_InnerMessage):
2397         (_InnerMessage.__init__):
2398         (_InnerMessageBuilder):
2399         (_InnerMessageBuilder.that):
2400         (_InnerMessageBuilder.__init__):
2401         (_InnerMessageBuilder._handle_first):
2402         (_InnerMessageBuilder._process_first_fragmented_control):
2403         (_InnerMessageBuilder._process_first_fragmented_message):
2404         (_InnerMessageBuilder._handle_fragmented_control):
2405         (_InnerMessageBuilder._reassemble_fragmented_control):
2406         (_InnerMessageBuilder._handle_fragmented_message):
2407         (_InnerMessageBuilder._reassemble_fragmented_message):
2408         (_InnerMessageBuilder.build):
2409         (_LogicalStream.__init__):
2410         (_LogicalStream._create_inner_frame):
2411         (_LogicalStream._write_inner_frame):
2412         (_LogicalStream.replenish_send_quota):
2413         (_LogicalStream.send_message):
2414         (_LogicalStream._receive_frame):
2415         (_LogicalStream._get_message_from_frame):
2416         (_LogicalStream.stop_sending):
2417         (_PhysicalConnectionWriter.__init__):
2418         (_PhysicalConnectionWriter._write_data):
2419         (_PhysicalConnectionWriter.run):
2420         (_PhysicalConnectionWriter.stop):
2421         (_Worker.run):
2422         (_MuxHandshaker.__init__):
2423         (_MuxHandshaker._create_stream):
2424         (_MuxHandshaker._create_handshake_response):
2425         (_HandshakeDeltaBase.create_headers):
2426         (_MuxHandler.start):
2427         (_MuxHandler.wait_until_done):
2428         (_MuxHandler.notify_write_data_done):
2429         (_MuxHandler._process_drop_channel):
2430         (_MuxHandler._process_logical_frame):
2431         (_MuxHandler.notify_reader_done):
2432         (_MuxHandler):
2433         (_MuxHandler.notify_writer_done):
2434         (_MuxHandler.fail_physical_connection):
2435         (_MuxHandler.fail_logical_channel):
2436         (use_mux):
2437         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
2438         (_StandaloneRequest.get_uri):
2439         (_StandaloneRequest.get_unparsed_uri):
2440         (_StandaloneRequest):
2441         (_StandaloneRequest.is_https):
2442         (_import_ssl):
2443         (_import_pyopenssl):
2444         (_StandaloneSSLConnection.for):
2445         (_StandaloneSSLConnection):
2446         (_StandaloneSSLConnection.__getattribute__):
2447         (_StandaloneSSLConnection.__setattr__):
2448         (_StandaloneSSLConnection.makefile):
2449         (_StandaloneSSLConnection.shutdown):
2450         (_StandaloneSSLConnection.recv):
2451         (WebSocketServer.__init__):
2452         (WebSocketServer._create_sockets):
2453         (WebSocketServer.handle_error):
2454         (WebSocketServer.get_request):
2455         (WebSocketServer.get_request.default_callback):
2456         (WebSocketRequestHandler.parse_request):
2457         (_build_option_parser):
2458         (_main):
2459         (_main.if):
2460         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
2461         (RepeatedXorMasker.__init__):
2462         (RepeatedXorMasker._mask_using_swig):
2463         (RepeatedXorMasker):
2464         (RepeatedXorMasker._mask_using_array):
2465         (_Deflater.compress_and_finish):
2466         (_RFC1979Deflater.filter):
2467         (DeflateSocket.send):
2468
2469 2013-05-16  Jonathan Liu  <net147@gmail.com>
2470
2471         Fix testing if program exists in PATH
2472         https://bugs.webkit.org/show_bug.cgi?id=116216
2473
2474         Reviewed by Jocelyn Turcotte.
2475
2476         functions.prf incorrectly uses win_cmd_shell to test whether to
2477         add .exe to the executable name when checking if it exists in
2478         the PATH environment variable. This works correctly when
2479         building using Windows Command Prompt but not under MSYS shell.
2480
2481         To resolve this, check the win32 platform scope instead of
2482         win_cmd_shell so that it correctly adds .exe to the executable
2483         name on Windows regardless of the shell used when testing if
2484         it exists in PATH.
2485
2486         * qmake/mkspecs/features/functions.prf:
2487
2488 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
2489
2490         Fix the hard-coded names of EWS bots that run tests.
2491
2492         * Scripts/webkitpy/tool/commands/queues.py:
2493         (CommitQueue.did_pass_testing_ews):
2494
2495 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2496
2497         [GTK] Build Xvfb with jhbuild
2498         https://bugs.webkit.org/show_bug.cgi?id=115907
2499
2500         Reviewed by Martin Robinson.
2501
2502         Build our own Xvfb so that we can avoid problems with the system Xvfb
2503         relying on symbols not present in our jhbuilt libraries such as pixman,
2504         and also to ensure we have the fix for a GLX module crasher.
2505
2506         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2507         (resetDefaultsToConsistentValues): enable accelerated compositing.
2508         * gtk/install-dependencies: list packages required for building Xvfb.
2509         * gtk/jhbuild.modules: add xserver as a jhbuild module.
2510         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
2511         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
2512         initializing the GLX module for Xvfb.
2513
2514 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2515
2516         [jhbuild] Should remove the sources directory as well when cleaning
2517         https://bugs.webkit.org/show_bug.cgi?id=116229
2518
2519         Reviewed by Martin Robinson.
2520
2521         * Scripts/update-webkit-libs-jhbuild:
2522         (cleanJhbuild): remove the Source directory as well when cleaning.
2523
2524 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
2525
2526         [EFL] Remove Intel Wk2 Buildbots from Master
2527         https://bugs.webkit.org/show_bug.cgi?id=116149
2528
2529         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
2530         since Gyuyoung Kim from Samsung plans to take over and maintain it.
2531
2532         Reviewed by Benjamin Poulain.
2533
2534         * BuildSlaveSupport/build.webkit.org-config/config.json:
2535
2536 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
2537
2538         [Windows] Update various build tools to understand VS2010 environment.
2539         https://bugs.webkit.org/show_bug.cgi?id=116169.
2540
2541         Reviewed by Anders Carlsson.
2542
2543         * Scripts/build-api-tests: Identify VS2010 environment.
2544         * Scripts/build-dumprendertree: Ditto.
2545         * Scripts/build-webkit: Ditto.
2546         * Scripts/webkitdirs.pm:
2547         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
2548         range of acceptable SDK's.
2549
2550 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
2551
2552         Allow http tests on Arch Linux
2553         https://bugs.webkit.org/show_bug.cgi?id=116155
2554
2555         Reviewed by Ryosuke Niwa.
2556
2557         * Scripts/webkitpy/port/base.py:
2558         (Port._is_arch_based): Added check for /etc/arch-release file.
2559         (Port._apache_config_file_name_for_platform): Call the check.
2560         * Scripts/webkitpy/port/port_testcase.py:
2561         (test_linux_distro_detection): Testcase added.
2562
2563 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
2564
2565         Remove a leftover v8 file from the watchlist
2566         https://bugs.webkit.org/show_bug.cgi?id=116158
2567
2568         Reviewed by Csaba Osztrogonác.
2569
2570         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
2571
2572 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
2573
2574         [GTK] Fails to build while generating gtkdoc
2575         https://bugs.webkit.org/show_bug.cgi?id=115612
2576
2577         Reviewed by Philippe Normand.
2578
2579         Fix typo in the prerequisites of docs-build.stamp.
2580
2581         * GNUmakefile.am:
2582
2583 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
2584
2585         Unreviewed, fixing the current test-webkitpy failure.
2586
2587         * Scripts/webkitpy/port/mac_unittest.py:
2588         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
2589         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
2590
2591 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
2592
2593         Fix build after r150090.
2594         https://bugs.webkit.org/show_bug.cgi?id=116129
2595
2596         Unreviewed build fix after r150090.
2597
2598         * WebKitTestRunner/TestInvocation.cpp:
2599         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2600
2601 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2602
2603         [Windows, others] Unreviewed build fix after r150090.
2604
2605         * DumpRenderTree/TestRunner.cpp:
2606         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
2607         doesn't exist on other platforms.
2608
2609 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
2610
2611         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
2612         https://bugs.webkit.org/show_bug.cgi?id=115889
2613
2614         Reviewed by Benjamin Poulain.
2615
2616         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2617         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2618
2619 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2620
2621         [Windows] Identify proper run environment for scripts.
2622         https://bugs.webkit.org/show_bug.cgi?id=116114
2623
2624         Reviewed by David Kilzer.
2625
2626         Determine (based on Visual Studio version) which path to use for
2627         executables (bin versus bin32).
2628
2629         * Scripts/webkitdirs.pm:
2630         (determineVisualStudioInstallDir): Added.
2631         (determineVisualStudioVersion): Added.
2632         (determineConfigurationProductDir): Modified to choose proper bin
2633         or bin32 directory.
2634         (visualStudioVersion): Added
2635         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
2636
2637 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
2638
2639         [Mac] Add tests for secure event input
2640         https://bugs.webkit.org/show_bug.cgi?id=116121
2641
2642         Reviewed by Mark Rowe.
2643
2644         * DumpRenderTree/TestRunner.cpp:
2645         (getSecureEventInputIsEnabledCallback):
2646         (TestRunner::staticValues):
2647         Expose an accessor for current secure event input state.
2648
2649         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2650         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2651         (WTR::TestRunner::secureEventInputIsEnabled):
2652         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2653         * WebKitTestRunner/TestInvocation.cpp:
2654         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2655         Expose an accessor for current secure event input state. This has to be done in
2656         UI process, as this is where it's changed by WebKit.
2657
2658 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
2659
2660         [Mac] Add a testing shim for secure event input functions
2661         https://bugs.webkit.org/show_bug.cgi?id=116122
2662
2663         Reviewed by Mark Rowe.
2664
2665         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
2666         Inject WebCore testing shim library to override system framework functions.
2667
2668 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2669
2670         [Windows] Switch to embedded manifest commands for launcher executables.
2671         https://bugs.webkit.org/show_bug.cgi?id=116109
2672
2673         Reviewed by Darin Adler.
2674
2675         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
2676         now-unused WinLauncher.exe.manifest file.
2677         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
2678         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
2679         when building with VS2010 or newer.
2680
2681 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2682
2683         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
2684         https://bugs.webkit.org/show_bug.cgi?id=116079
2685
2686         Reviewed by David Kilzer.
2687
2688         * Scripts/old-run-webkit-tests:
2689         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
2690
2691 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
2692
2693         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
2694         https://bugs.webkit.org/show_bug.cgi?id=115921
2695
2696         Reviewed by Gustavo Noronha Silva.
2697
2698         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
2699         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
2700
2701 2013-05-13  Alex Christensen  <achristensen@apple.com>
2702
2703         Added testRunner.setPrinting.
2704         https://bugs.webkit.org/show_bug.cgi?id=42693
2705         rdar://problem/8213845
2706
2707         Reviewed by Darin Adler.
2708
2709         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2710         Added setPrinting JavaScript function.
2711         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2712         (WTR::InjectedBundlePage::dump):
2713         Dump the external representation for printing if setPrinting has been called.
2714         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2715         (WTR::TestRunner::isPrinting): Added.
2716         (WTR::TestRunner::setPrinting): Added.
2717         Added and initialized m_isPrinting member boolean.
2718
2719 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
2720
2721         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
2722         https://bugs.webkit.org/show_bug.cgi?id=116016
2723
2724         Reviewed by Dirk Pranke.
2725
2726         Same fix as in the upstream style checker, but without hg support.
2727         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
2728
2729         * Scripts/webkitpy/style/checkers/cpp.py:
2730         (FileInfo.repository_name):
2731
2732 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
2733
2734         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
2735         https://bugs.webkit.org/show_bug.cgi?id=115918
2736
2737         Reviewed by Gustavo Noronha Silva.
2738
2739         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
2740         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
2741         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
2742         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
2743         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
2744         problems.
2745
2746         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
2747         These are then used as dependencies for the archive creation rule as well as the list from which the archive
2748         file paths are constructed and then used to dump the member files from these archives. The member files are
2749         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
2750         successfully link.
2751
2752         * TestWebKitAPI/GNUmakefile.am:
2753
2754 2013-05-13  Anders Carlsson  <andersca@apple.com>
2755
2756         Remove UnusedParam.h
2757         https://bugs.webkit.org/show_bug.cgi?id=116029
2758
2759         Reviewed by Andreas Kling.
2760
2761         Stop including UnusedParam.h.
2762
2763         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2764         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2765
2766 2013-05-12  Commit Queue  <commit-queue@webkit.org>
2767
2768         Unreviewed, rolling out r149955.
2769         http://trac.webkit.org/changeset/149955
2770         https://bugs.webkit.org/show_bug.cgi?id=115990
2771
2772         Broke lots of tests (Requested by smfr on #webkit).
2773
2774         * Scripts/webkitpy/port/mac.py:
2775
2776 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2777
2778         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
2779         https://bugs.webkit.org/show_bug.cgi?id=115914
2780
2781         Reviewed by Martin Robinson.
2782
2783         * GtkLauncher/main.c:
2784         (createToolbar):
2785         * MiniBrowser/gtk/BrowserWindow.c:
2786         (_BrowserWindow):
2787         (browserWindowSetStatusText):
2788         (fullScreenMessageTimeoutCallback):
2789         (webViewEnterFullScreen):
2790         (webViewLeaveFullScreen):
2791         (browserWindowFinalize):
2792         (browserWindowConstructed):
2793         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2794         (WTR::EventSenderProxy::mouseScrollBy):
2795         (WTR::EventSenderProxy::continuousMouseScrollBy):
2796
2797 2013-05-11  Anders Carlsson  <andersca@apple.com>
2798
2799         Crash when terminating a process that has not been fully launched
2800         https://bugs.webkit.org/show_bug.cgi?id=115962
2801         <rdar://problem/13660916>
2802
2803         Reviewed by Andreas Kling.
2804
2805         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
2806         before the process has had a chance to be fully launched.
2807
2808         * TestWebKitAPI/GNUmakefile.am:
2809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2810         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
2811         (TestWebKitAPI):
2812         (TestWebKitAPI::didFinishLoadForFrame):
2813         (TestWebKitAPI::TEST):
2814         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
2815
2816 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
2817
2818         Remove Mac OS X Leopard (10.5) support
2819         https://bugs.webkit.org/show_bug.cgi?id=107964
2820
2821         Reviewed by Ryosuke Niwa.
2822
2823         Removed the code for 10.5 and removed if-def for 10.6.
2824
2825         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2826         (convertMIMEType):
2827         (createXMLStringFromWebArchiveData):
2828         * DumpRenderTree/mac/TestRunnerMac.mm:
2829         (TestRunner::authenticateSession):
2830         (TestRunner::setTextDirection):
2831         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
2832         (convertMIMEType):
2833         (createXMLStringFromWebArchiveData):
2834
2835 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
2836
2837         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
2838         https://bugs.webkit.org/show_bug.cgi?id=115935
2839
2840         Reviewed by Jer Noble.
2841
2842         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
2843         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
2844         to the new manifest file.
2845         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
2846
2847 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
2848
2849         Fix some compiler warnings (miscellaneous)
2850         https://bugs.webkit.org/show_bug.cgi?id=80790
2851
2852         Reviewed by Rob Buis.
2853
2854         Fix the following warnings for BlackBerry:
2855         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
2856         used as truth value [-Wparentheses].
2857
2858         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2859         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2860
2861 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2862
2863         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
2864         https://bugs.webkit.org/show_bug.cgi?id=115928
2865
2866         Reviewed by Kenneth Rohde Christiansen.
2867
2868         WKViewSetThemePath was moved to WKViewEfl.h.
2869
2870         * TestWebKitAPI/efl/PlatformWebView.cpp:
2871
2872 2013-05-10  Andreas Kling  <akling@apple.com>
2873
2874         I accidentally the Java testing.
2875
2876         * Scripts/webkitpy/port/mac.py:
2877
2878 2013-05-10  Brian Holt  <brian.holt@samsung.com>
2879
2880         [GTK] Module Cairo fails to build under jhbuild
2881         https://bugs.webkit.org/show_bug.cgi?id=115854
2882
2883         Reviewed by Martin Robinson.
2884
2885         Make cairo depend on glib in jhbuild.modules.
2886
2887         * gtk/jhbuild.modules:
2888
2889 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2890
2891         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
2892         https://bugs.webkit.org/show_bug.cgi?id=115904
2893
2894         Reviewed by Martin Robinson.
2895
2896         * ImageDiff/gtk/ImageDiff.cpp:
2897         (main):
2898
2899 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
2900
2901         Add my new address to contributors.json. (Unreviewed)
2902
2903         * Scripts/webkitpy/common/config/contributors.json:
2904
2905 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2906
2907         Unreviewed. Move myself to the reviewers list.
2908
2909         * Scripts/webkitpy/common/config/contributors.json:
2910
2911 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2912
2913         Unreviewed. Add my email to a few watchlists.
2914
2915         * Scripts/webkitpy/common/config/watchlist:
2916
2917 2013-05-10  Simon Pena  <simon.pena@samsung.com>
2918
2919         Unicode support missing from string representation of Contributors in committers.py
2920         https://bugs.webkit.org/show_bug.cgi?id=115859
2921
2922         Reviewed by Darin Adler.
2923
2924         Contributors, in committers.py, provided a string representation in __str__ which
2925         didn't support unicode characters, so printing a contributor would fail in that case.
2926         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
2927         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
2928
2929         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
2930         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
2931         representation.
2932         (Contributor.__str__):
2933         (Contributor):
2934         (Contributor.__unicode__):
2935         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
2936         a contributor with unicode characters can be represented as a string.
2937         (CommittersTest):
2938         (CommittersTest.test_contributor_encoding):
2939
2940 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
2941
2942         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
2943         https://bugs.webkit.org/show_bug.cgi?id=92371
2944
2945         Reviewed by Brent Fulgham.
2946
2947         Use JavaScriptThreading.cpp where the same functionality is
2948         implemented too. This reduces the dependency on the pthread
2949         library. Also replace assert() with WebKit ASSERT().
2950
2951         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2952         * DumpRenderTree/win/DumpRenderTree.cpp:
2953         (dumpHistoryItem):
2954         (dumpBackForwardList):
2955         * DumpRenderTree/win/DumpRenderTree.vcproj:
2956
2957 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
2958
2959         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
2960         https://bugs.webkit.org/show_bug.cgi?id=92505
2961
2962         Reviewed by Brent Fulgham.
2963
2964         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2965         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
2966         (javaScriptThreadsMutex):
2967         (javaScriptThreads):
2968         (runJavaScriptThread):
2969         (startJavaScriptThreads):
2970         (stopJavaScriptThreads):
2971         * DumpRenderTree/pthreads: Removed.
2972         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
2973
2974 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
2975
2976         Unreviewed. Update Simon Pena email on his behalf.
2977
2978         * Scripts/webkitpy/common/config/contributors.json:
2979
2980 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2981
2982         Add support for [NoInterfaceObject] Web IDL extended attribute
2983         https://bugs.webkit.org/show_bug.cgi?id=115714
2984
2985         Reviewed by Kentaro Hara.
2986
2987         Update BindingsTests.generate_supplemental_dependency() to pass an
2988         additional windowConstructorsFile argument to preprocess-idls.pl.
2989
2990         * Scripts/webkitpy/bindings/main.py:
2991         (BindingsTests.generate_supplemental_dependency):
2992         (BindingsTests.main):
2993
2994 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
2995
2996         [GTK][AC] Buildfix after r149694
2997         https://bugs.webkit.org/show_bug.cgi?id=115797
2998
2999         Reviewed by Gustavo Noronha Silva.
3000
3001         Add CLUTTER_LIBS for linking TestWebCore.
3002
3003         * TestWebKitAPI/GNUmakefile.am:
3004
3005 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3006
3007         [EFL] Remove unnecessary pkgs in EFL jhbuild
3008         https://bugs.webkit.org/show_bug.cgi?id=114908
3009
3010         Reviewed by Laszlo Gombos.
3011
3012         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
3013         handle them using jhbuild. We can reduce build time when using --update-efl.
3014
3015         * efl/jhbuild.modules:
3016
3017 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
3018
3019         [EFL] Disable SHADOW DOM feature in FeatureList.pm
3020         https://bugs.webkit.org/show_bug.cgi?id=115834
3021
3022         Reviewed by Gyuyoung Kim.
3023
3024         * Scripts/webkitperl/FeatureList.pm:
3025
3026 2013-05-08  Lucas Forschler  <lforschler@apple.com>
3027
3028         Add Scheduler for Mac MtnLion 32bit Release builder.
3029
3030         Unreviewed.
3031
3032         * BuildSlaveSupport/build.webkit.org-config/config.json:
3033
3034 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
3035
3036         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
3037         https://bugs.webkit.org/show_bug.cgi?id=115808
3038
3039         Reviewed by Darin Adler.
3040
3041         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
3042         was left outdated after r127191, when the m_string member was changed
3043         from UString to String. This patch calls the right pretty printer for it.
3044
3045         * gdb/webkit.py:
3046         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
3047         WTFImplPrettyPrinter.
3048
3049 2013-05-08  Andy Estes  <aestes@apple.com>
3050
3051         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
3052         https://bugs.webkit.org/show_bug.cgi?id=115790
3053
3054         Reviewed by Alexey Proskuryakov.
3055
3056         Added two API tests:
3057
3058         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
3059         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
3060
3061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3062         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
3063         (TestWebKitAPI):
3064         (TestWebKitAPI::TEST):
3065         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
3066         (TestWebKitAPI):
3067         (TestWebKitAPI::decidePolicyForNavigationAction):
3068         (CustomProtocolInvalidSchemeTest):
3069         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
3070
3071 2013-05-08  Lucas Forschler  <lforschler@apple.com>
3072
3073         Teach buildbot how to compile 32-bit on Mac.
3074
3075         Reviewed by Ryosuke Niwa.
3076
3077         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3078         (CompileWebKit.start):
3079         (ExtractTestResultsAndLeaks):
3080
3081 2013-05-08  Eli Fidler  <efidler@blackberry.com>
3082
3083         [BlackBerry] Fix usage of BlackBerry::Platform::String
3084         https://bugs.webkit.org/show_bug.cgi?id=115781
3085
3086         Reviewed by Rob Buis.
3087
3088         BlackBerry PRs 304193 and 327181
3089         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
3090
3091         We currently have a problem where we're passing UTF-8 encoded data into
3092         the char* constructors of BlackBerry::Platform::String. This means the string
3093         thinks its data is not UTF-8.
3094
3095         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3096         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3097         (BlackBerry::WebKit::dumpHistoryItem):
3098         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3099         (TestRunner::setUserStyleSheetLocation):
3100         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
3101         (LoadHTMLStringItem::invoke):
3102
3103 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
3104
3105         Tools: add new BlackBerry include dirs.
3106         https://bugs.webkit.org/show_bug.cgi?id=115514
3107
3108         Reviewed by Rob Buis.
3109
3110         iType include dirs are missing, and HarfBuzz needs to be fixed.
3111
3112         * Scripts/webkitdirs.pm:
3113         (blackberryCMakeArguments):
3114
3115 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
3116
3117         [GTK] Plumb the Automake build system for the Battery Status API feature
3118         https://bugs.webkit.org/show_bug.cgi?id=115718
3119
3120         Reviewed by Martin Robinson.
3121
3122         * Scripts/webkitdirs.pm:
3123         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
3124         through the --(enable|disable)-battery-status flag passed to configure.
3125
3126 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
3127
3128         new-run-webkit-websocketserver doesn't work after Chromium removal
3129         https://bugs.webkit.org/show_bug.cgi?id=115816
3130
3131         Reviewed by Joseph Pecoraro.
3132
3133         Fix the bug by instantiating the correct port object.
3134
3135         * Scripts/new-run-webkit-websocketserver:
3136         (main):
3137
3138 2013-05-07  Lucas Forschler  <lforschler@apple.com>
3139
3140         Configure buildbot for 32bit builder.
3141         https://bugs.webkit.org/show_bug.cgi?id=115769
3142
3143         Reviewed by Ryosuke Niwa.
3144
3145         * BuildSlaveSupport/build.webkit.org-config/config.json:
3146
3147 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
3148
3149         Unreviewed. Update to show my apple.com address.
3150
3151         * Scripts/webkitpy/common/config/contributors.json: Added
3152         my apple.com e-mail address.
3153
3154 2013-05-08  David Kilzer  <ddkilzer@apple.com>
3155
3156         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
3157
3158         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3159         (concatenateAttributeAndValue): Switch to appendVector().
3160
3161 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
3162
3163         [Qt][WTR] Fix the build on Mac after r149692
3164
3165         Unreviewed build fix.
3166
3167         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3168         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3169
3170 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
3171
3172         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
3173         to the watchlist for Accessibility.
3174
3175         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
3176         * Scripts/webkitpy/common/config/watchlist: Added myself.
3177
3178 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
3179
3180         [Qt] Build fails with clang
3181         https://bugs.webkit.org/show_bug.cgi?id=115741
3182
3183         Reviewed by Benjamin Poulain.
3184
3185         Since r149112 std::move is used in AtomicString for compilers that
3186         support rvalue references and this requires a standard library
3187         implementing c++11 move semantics.
3188         We only explicitely require c++11 for WebKit2, but since clang supports
3189         rvalue references the build of subtargets using AtomicString fails because
3190         of missing std::move.
3191         It is safe to add CONFIG += c++11 for the whole project when using clang
3192         since we explicitely disable c++11 for ANGLE that had probems with libc++.
3193
3194         * qmake/mkspecs/features/unix/default_pre.prf:
3195
3196 2013-05-08  Darin Adler  <darin@apple.com>
3197
3198         Fix one more place that needed to use adoptCF/NS
3199         https://bugs.webkit.org/show_bug.cgi?id=115778
3200
3201         Reviewed by Benjamin Poulain.
3202
3203         Not sure why I missed this code last time, but found a bit more code that needs
3204         to switch to the newer style adoptCF/NS.
3205
3206         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
3207         (convertWebResourceDataToString): Use adoptCF.
3208         (convertWebResourceResponseToDictionary): Ditto.
3209         (createXMLStringFromWebArchiveData): Ditto.
3210         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
3211         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
3212
3213 2013-05-08  Commit Queue  <commit-queue@webkit.org>
3214
3215         Unreviewed, rolling out r149271.
3216         http://trac.webkit.org/changeset/149271
3217         https://bugs.webkit.org/show_bug.cgi?id=115780
3218
3219         The mangled symbols are now enforced through LDFLAGS
3220         (Requested by zdobersek on #webkit).
3221
3222         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
3223
3224 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
3225
3226         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
3227         https://bugs.webkit.org/show_bug.cgi?id=115636
3228
3229         Reviewed by Ryosuke Niwa.
3230
3231         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3232         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
3233         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
3234         while Chromium-specific, can't be removed just yet as there's more code that uses it.
3235
3236 2013-05-06  Darin Adler  <darin@apple.com>
3237
3238         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
3239         https://bugs.webkit.org/show_bug.cgi?id=115657
3240
3241         Reviewed by Sam Weinig.
3242
3243         This is similar to my last set of changes, but covers code that I missed with
3244         global replace using the Safari Xcode workspace.
3245
3246         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3247         (convertWebResourceDataToString):
3248         (convertWebResourceResponseToDictionary):
3249         (createXMLStringFromWebArchiveData):
3250         * DumpRenderTree/cg/ImageDiffCG.cpp:
3251         (createImageFromStdin):
3252         (createDifferenceImage):
3253         (main):
3254         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3255         (printPNG):
3256         (dumpBitmap):
3257         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3258         (BitmapContext::BitmapContext):
3259         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3260         (-[MockWebNotificationProvider init]):
3261         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3262         (createBitmapContext):
3263         * DumpRenderTree/mac/TestRunnerMac.mm:
3264         (TestRunner::addDisallowedURL):
3265         (TestRunner::applicationCacheDiskUsageForOrigin):
3266         (TestRunner::localStorageDiskUsageForOrigin):
3267         (TestRunner::clearApplicationCacheForOrigin):
3268         (TestRunner::deleteLocalStorageForOrigin):
3269         (TestRunner::copyDecodedHostName):
3270         (TestRunner::copyEncodedHostName):
3271         (TestRunner::queueLoad):
3272         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3273         (TestRunner::setMockGeolocationPositionUnavailableError):
3274         (TestRunner::setUserStyleSheetLocation):
3275         (TestRunner::setValueForUser):
3276         (TestRunner::overridePreference):
3277         (TestRunner::setPersistentUserStyleSheetLocation):
3278         (TestRunner::execCommand):
3279         (TestRunner::findString):
3280         (TestRunner::isCommandEnabled):
3281         (TestRunner::addOriginAccessWhitelistEntry):
3282         (TestRunner::removeOriginAccessWhitelistEntry):
3283         (TestRunner::addUserScript):
3284         (TestRunner::addUserStyleSheet):
3285         (TestRunner::evaluateInWebInspector):
3286         (TestRunner::evaluateScriptInIsolatedWorld):
3287         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3288         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
3289         (TestRunner::authenticateSession):
3290         (TestRunner::grantWebNotificationPermission):
3291         (TestRunner::denyWebNotificationPermission):
3292         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3293         (createCFURLResponseFromResponseData):
3294         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3295         (LoadItem::invoke):
3296         (LoadHTMLStringItem::invoke):
3297         (ScriptItem::invoke):
3298         * DumpRenderTree/win/DumpRenderTree.cpp:
3299         (substringFromIndex):
3300         (urlSuitableForTestResult):
3301         (lastPathComponent):
3302         (sharedCFURLCache):
3303         * DumpRenderTree/win/ImageDiffCairo.cpp:
3304         (createImageFromStdin):
3305         (main):
3306         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3307         (createBitmapContextFromWebView):
3308         * DumpRenderTree/win/TestRunnerWin.cpp:
3309         (TestRunner::setUserStyleSheetLocation):
3310         (TestRunner::setPersistentUserStyleSheetLocation):
3311         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3312         (TestWebKitAPI::TEST):
3313         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
3314         (TestWebKitAPI::TEST):
3315         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3316         (TestWebKitAPI::TEST):
3317         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3318         (TestWebKitAPI::TEST):
3319         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
3320         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3321         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
3322         (TestWebKitAPI::createWindow):
3323         (TestWebKitAPI::TEST):
3324         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3325         (TestWebKitAPI::TEST):
3326         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
3327         (TestWebKitAPI::AcceptsFirstMouse::runTest):
3328         * TestWebKitAPI/Tests/mac/AttributedString.mm:
3329         (TestWebKitAPI::TEST):
3330         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
3331         (TestWebKitAPI::TEST):
3332         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
3333         (TestWebKitAPI::TEST):
3334         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3335         (TestWebKitAPI::TEST):
3336         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
3337         (TestWebKitAPI::TEST):
3338         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
3339         (TestWebKitAPI::TEST):
3340         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
3341         (TestWebKitAPI::TEST):
3342         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3343         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
3344         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3345         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
3346         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
3347         (TestWebKitAPI::TEST):
3348         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
3349         (TestWebKitAPI::TEST):
3350         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3351         (TestWebKitAPI::TEST):
3352         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
3353         (TestWebKitAPI::TEST):
3354         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
3355         (TestWebKitAPI::TEST):
3356         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3357         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3358         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
3359         (TestWebKitAPI::TEST):
3360         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3361         (TestWebKitAPI::TEST):
3362         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
3363         (TestWebKitAPI::TEST):
3364         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
3365         (TestWebKitAPI::TEST):
3366         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
3367         (TestWebKitAPI::TEST):
3368         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
3369         (TestWebKitAPI::TEST):
3370         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
3371         (TestWebKitAPI::TEST):
3372         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3373         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3374         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3375         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
3376         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3377         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
3378         (WTR::testPathFromURL):
3379         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3380         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3381         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3382         (WTR::createCGContextFromImage):
3383         (WTR::dumpBitmap):
3384         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3385         * WebKitTestRunner/mac/EventSenderProxy.mm:
3386         (WTR::EventSenderProxy::mouseScrollBy):
3387         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3388         (WTR::PlatformWebView::windowSnapshotImage):
3389         * WebKitTestRunner/win/TestControllerWin.cpp:
3390         (WTR::TestController::initializeTestPluginDirectory):
3391         Use adoptCF and adoptNS.
3392
3393 2013-05-07  Alex Christensen  <achristensen@apple.com>
3394
3395         Fix a memory leak introduced in r149692
3396         https://bugs.webkit.org/show_bug.cgi?id=115766
3397
3398         Reviewed by Mark Rowe.
3399
3400         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
3401         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
3402
3403         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3404         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3405         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
3406
3407 2013-05-07  Darin Adler  <darin@apple.com>
3408
3409         [Win] Fix storage leak in Windows DumpRenderTree
3410         https://bugs.webkit.org/show_bug.cgi?id=115651
3411
3412         Reviewed by Sam Weinig.
3413
3414         * DumpRenderTree/win/DumpRenderTree.cpp:
3415         (lastPathComponent): Added a missing call to adoptCF.
3416
3417 2013-05-07  Alex Christensen  <achristensen@apple.com>
3418
3419         fixed a memory leak introduced by bug 42324 by using a RetainPtr
3420         https://bugs.webkit.org/show_bug.cgi?id=115760
3421
3422         Reviewed by Tim Horton.
3423
3424         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3425         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3426         fixed memory leak, added UNUSED_PARAM macros
3427
3428 2013-05-07  Alex Christensen  <achristensen@apple.com>
3429
3430         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
3431         https://bugs.webkit.org/show_bug.cgi?id=42324
3432         <rdar://problem/8193633>
3433
3434         Reviewed by Tim Horton.
3435
3436         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3437         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
3438         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3439         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3440         Added dumpDOMAsWebArchive code that is called when dumping.
3441         (WTR::InjectedBundlePage::dump):
3442         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
3443         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3444         (InjectedBundlePage):
3445         Added dumpDOMAsWebArchive declaration.
3446         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
3447         (WTR::TestRunner::dumpDOMAsWebArchive):
3448         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
3449         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3450         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
3451         * Tools/WebKitTestRunner/cf: Added.
3452         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
3453         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
3454         (convertMIMEType):
3455         (convertWebResourceDataToString):
3456         (normalizeHTTPResponseHeaderFields):
3457         (normalizeWebResourceURL):
3458         (convertWebResourceResponseToDictionary):
3459         (compareResourceURLs):
3460         (createXMLStringFromWebArchiveData):
3461         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
3462         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
3463         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
3464         Copied from Tools/DumpRenderTree/mac for used functions.
3465         (createCFURLResponseFromResponseData):
3466         (supportedNonImageMIMETypes):
3467
3468 2013-05-07  Alex Christensen  <achristensen@apple.com>
3469
3470         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
3471         https://bugs.webkit.org/show_bug.cgi?id=115745
3472
3473         Reviewed by Tim Horton.
3474
3475         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3476         (compareResourceURLs):
3477         Updated style.
3478
3479 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
3480
3481         Add an 'isReadOnly' member to IDL parse tree structure
3482         https://bugs.webkit.org/show_bug.cgi?id=115704
3483
3484         Reviewed by Kentaro Hara.
3485
3486         Use newly added isReadOnly attribute.
3487
3488         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3489         (_generateHeaderFile):
3490         (_generateImplementationFile):
3491         (_staticValuesGetterImplementation):
3492
3493 2013-05-07  Anders Carlsson  <andersca@apple.com>
3494
3495         Remove AlwaysInline.h from WTF
3496         https://bugs.webkit.org/show_bug.cgi?id=115727
3497
3498         Reviewed by Brent Fulgham.
3499
3500         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
3501         to keep AlwaysInline.h around anymore.
3502
3503         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3504         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3505
3506 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
3507
3508         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
3509         https://bugs.webkit.org/show_bug.cgi?id=114808
3510
3511         Reviewed by Jocelyn Turcotte.
3512
3513         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
3514         (https://codereview.qt-project.org/#change,54234)
3515
3516         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3517         (WTR::WrapperWindow::handleStatusChanged):
3518
3519 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3520
3521         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
3522
3523         * Scripts/webkitpy/common/config/watchlist:
3524
3525 2013-05-06  Kangil Han  <kangil.han@samsung.com>
3526
3527         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
3528         https://bugs.webkit.org/show_bug.cgi?id=115645
3529
3530         Reviewed by Gyuyoung Kim.
3531
3532         To run performance tests in wk1, we need --no-timeout option implementation.
3533         So adopt it from gtk+ port.
3534
3535         * DumpRenderTree/efl/DumpRenderTree.cpp:
3536         (shouldSetWaitToDumpWatchdog):
3537         (parseCommandLineOptions):
3538         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
3539         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3540         (TestRunner::setWaitToDump):
3541
3542 2013-05-06  Commit Queue  <commit-queue@webkit.org>
3543
3544         Unreviewed, rolling out r149547.
3545         http://trac.webkit.org/changeset/149547
3546         https://bugs.webkit.org/show_bug.cgi?id=115682
3547
3548         Added unittests that fail on bots and spits out text into
3549         stdout (Requested by rniwa on #webkit).
3550
3551         * Scripts/import-w3c-tests: Removed.
3552         * Scripts/webkitpy/w3c/__init__.py: Removed.
3553         * Scripts/webkitpy/w3c/test_converter.py: Removed.
3554         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
3555         * Scripts/webkitpy/w3c/test_importer.py: Removed.
3556         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
3557         * Scripts/webkitpy/w3c/test_parser.py: Removed.
3558         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
3559
3560 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
3561
3562         [jhbuild] bump jhbuild version to take advantage of new improvements
3563         https://bugs.webkit.org/show_bug.cgi?id=115558
3564
3565         Reviewed by Martin Robinson.
3566
3567         One of the important improvements is jhbuild no longer fetches git
3568         repositories if they are already at the expected revision, which should
3569         make the EWS bots more robust to git servers unavailability.
3570
3571         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
3572
3573 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
3574
3575         [GTK] Add webkit_uri_scheme_request_finish_error
3576         https://bugs.webkit.org/show_bug.cgi?id=94316
3577
3578         Reviewed by Anders Carlsson.
3579
3580         * MiniBrowser/gtk/main.c:
3581         (miniBrowserErrorQuark): Add function to create a global quark for
3582         MiniBrowser.
3583         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
3584         function webkit_uri_scheme_request_finish_error().
3585
3586 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
3587
3588         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
3589         https://bugs.webkit.org/show_bug.cgi?id=113808
3590
3591         Reviewed by Rob Buis.
3592
3593         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
3594         to true for BlackBerry.
3595
3596         * Scripts/webkitperl/FeatureList.pm:
3597
3598 2013-05-06  Jessie Berlin  <jberlin@apple.com>
3599
3600         check-webkit-style should complain about a layering violation if platform-specific guards are
3601         used in WebCore outside of the platform directory
3602         https://bugs.webkit.org/show_bug.cgi?id=115567
3603
3604         Reviewed by Benjamin Poulain.
3605
3606         * Scripts/webkitpy/style/checkers/cpp.py:
3607         (check_for_webcore_platform_layering_violation):
3608         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
3609         (process_line):
3610         Add the check_for_webcore_platform_layering_violation.
3611         (CppChecker):
3612         List the new check.
3613
3614         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3615         (CppStyleTest.test_webcore_platform_layering_violation):
3616         Add tests.
3617
3618 2013-05-06  David Kilzer  <ddkilzer@apple.com>
3619
3620         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
3621         <http://webkit.org/b/115667>
3622
3623         Reviewed by Dirk Pranke.
3624
3625         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3626         (Bugzilla._check_create_bug_response): Update regex to work with
3627         Bugzilla 3.2.3 and 4.2.5.
3628         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3629         (test__check_create_bug_response): Add new test that covers both
3630         old and new <title> variations.
3631
3632 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3633
3634         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
3635         https://bugs.webkit.org/show_bug.cgi?id=115661
3636
3637         Reviewed by Ryosuke Niwa.
3638
3639         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
3640         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
3641         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
3642
3643         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3644         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3645
3646 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3647
3648         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
3649         https://bugs.webkit.org/show_bug.cgi?id=114603
3650
3651         Reviewed by Ryosuke Niwa.
3652
3653         * TestResultServer/generate_builders_json.py:
3654         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
3655         to represent these