6048289d4f8f60f03c870e5343015e367d67bedb
[WebKit-https.git] / Tools / ChangeLog
1 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
2
3         build.webkit.org/dashboard: OS X EWS is now on Mavericks
4         https://bugs.webkit.org/show_bug.cgi?id=140595
5
6         Reviewed by Csaba Osztrogonác.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
9         (BubbleQueueServer):
10
11 2015-01-17  David Kilzer  <ddkilzer@apple.com>
12
13         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
14
15         * Scripts/webkitpy/port/ios.py:
16         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
17         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
18         the Mountain Lion and Mavericks bots.
19
20 2015-01-17  David Kilzer  <ddkilzer@apple.com>
21
22         Attempt to fix webkitpy tests on GTK Linux ports
23
24         * Scripts/webkitpy/port/ios.py:
25         (IOSPort.determine_full_port_name): Set a sensible default if
26         not running on a Mac platform or if no iOS SDK is installed.
27
28 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
29
30         Create iOS-EWS client queue
31         https://bugs.webkit.org/show_bug.cgi?id=140476
32
33         Reviewed by Alexey Proskuryakov.
34
35         * EWSTools/start-queue-mac.sh:
36         Adds call to configure-xcode-for-ios-development for iOS EWS.
37         * Scripts/webkitpy/common/config/ews.json:
38         Adds the iOS EWS config entry.
39         * Scripts/webkitpy/common/config/ports.py:
40         (DeprecatedPort.port):
41         Adds IOSPort to the port map.
42         (IOSPort):
43         (IOSPort.build_webkit_command):
44         Adds --sdk=iphoneos to the webkit build command.
45         * Scripts/webkitpy/port/base.py:
46         (Port.architecture):
47         Adds an accessor for the architecture member variable.
48         * Scripts/webkitpy/port/factory.py:
49         (PortFactory):
50         Adds IOSPort to the port class list.
51         * Scripts/webkitpy/port/ios.py:
52         Adds the IOSPort to encapsulate iOS-specific things.
53         (IOSPort):
54         (IOSPort.determine_full_port_name):
55         (IOSPort.__init__):
56         (IOSPort._build_driver_flags):
57         (IOSPort.operating_system):
58         * Scripts/webkitpy/tool/commands/download_unittest.py:
59         Adds the archetecture option to the mock options.
60         (DownloadCommandsTest._default_options):
61         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
62         Appends the archetecture option into calls to webkit-patch.
63         (AbstractEarlyWarningSystem.review_patch):
64         (AbstractEarlyWarningSystem.run_command):
65         (AbstractEarlyWarningSystem.load_ews_classes):
66         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
67         Adds logic to soothe the unittest now that --architecture is being
68         thrown around everywhere.
69         (EarlyWarningSystemTest._default_expected_logs):
70         * Scripts/webkitpy/tool/commands/queues.py:
71         Adds glue code to ferry the --architecture option around.
72         (AbstractQueue.__init__):
73         (PatchProcessingQueue.begin_work_queue):
74         * Scripts/webkitpy/tool/steps/abstractstep.py:
75         Adds the archetecture option to all AbstractSteps so that
76         EarlyWarningSystem doesn't start shoving --architecture into
77         unsuspecting commands.
78         (AbstractStep.options):
79         * Scripts/webkitpy/tool/steps/build.py:
80         Translates the --architecture option into an ARCHS= format to pass to
81         build-webkit.
82         (Build.build):
83         * Scripts/webkitpy/tool/steps/options.py:
84         Adds a definition for the --architecture option.
85         (Options):
86
87 2015-01-16  Sam Weinig  <sam@webkit.org>
88
89         Add a basic configuration object for WKView
90         https://bugs.webkit.org/show_bug.cgi?id=140559
91
92         Reviewed by Anders Carlsson.
93
94         Add tests for WKPageConfigurationRef.
95
96         * TestWebKitAPI/PlatformWebView.h:
97         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
98         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
99         (TestWebKitAPI::TEST):
100         (TestWebKitAPI::didFinishLoadForFrame):
101         (TestWebKitAPI::setPageLoaderClient):
102         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
103         (TestWebKitAPI::PlatformWebView::initialize):
104         (TestWebKitAPI::PlatformWebView::PlatformWebView):
105
106 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
107
108         WeakPtr functions crash when created with default constructor
109         https://bugs.webkit.org/show_bug.cgi?id=140479
110
111         Reviewed by Andreas Kling.
112
113         Add WeakPtr API tests.
114
115         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
116         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
117         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
118
119 2015-01-16  Chris Dumez  <cdumez@apple.com>
120
121         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
122         https://bugs.webkit.org/show_bug.cgi?id=140568
123
124         Reviewed by Alexey Proskuryakov.
125
126         Fix the script parsing CSSPropertyNames.in to stop splitting lines
127         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
128         e.g. "Longhands=background-position-x|background-position-y".
129         This would confuse the script and treat this as a CSS property:
130         "background-position-x|background-position-y".
131
132         We now split on white space and treat the first string on the line
133         to be the property name (this is the syntax in this file).
134
135         * Scripts/webkitpy/w3c/test_converter.py:
136         (_W3CTestConverter.__init__):
137         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
138
139 2015-01-16  Daniel Bates  <dabates@apple.com>
140
141         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
142         https://bugs.webkit.org/show_bug.cgi?id=135589
143
144         Reviewed by David Kilzer.
145
146         Derived from a patch by David Farler.
147
148         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
149         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
150         in terms of the simctl command line utility.
151
152         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
153         (eraseIOSSimulatorDevice): Added.
154         (bootedIOSSimulatorDevice): Added.
155         (iosSimulatorApplicationsPath): Added.
156         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
157         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
158         (quitIOSSimulator): Added.
159         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
160         the specified name and currently selected iOS runtime.
161         (isIOSSimulatorSystemInstalledApp): Added.
162         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
163         (deleteiOSSimulatorDevice): Deleted.
164         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
165         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
166
167 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
168
169         Resurrect the WinCairo bot.
170         https://bugs.webkit.org/show_bug.cgi?id=139908
171
172         Reviewed by Csaba Osztrogonác.
173
174         * BuildSlaveSupport/build.webkit.org-config/config.json:
175         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
176         (appendCustomBuildFlags):
177         * BuildSlaveSupport/test-result-archive:
178         (archiveTestResults):
179         Add WinCairo buildbot.
180
181 2015-01-16  Chris Dumez  <cdumez@apple.com>
182
183         webkit-patch should auto-install the keyring python module
184         https://bugs.webkit.org/show_bug.cgi?id=140547
185
186         Reviewed by David Kilzer.
187
188         Auto-install the keyring python module. This is the module that
189         webkit-patch uses for cross-platform access to the keyring
190         service.
191
192         Without this module, if the password if not in the keychain,
193         webkit-patch will keep asking for your username / password and
194         never remember them.
195
196         * Scripts/webkitpy/common/net/credentials.py:
197         * Scripts/webkitpy/thirdparty/__init__.py:
198         (AutoinstallImportHook.find_module):
199         (AutoinstallImportHook._install_keyring):
200
201 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
202
203         Remove ENABLE(SQL_DATABASE) guards
204         https://bugs.webkit.org/show_bug.cgi?id=140434
205
206         Reviewed by Darin Adler.
207
208         * Scripts/webkitperl/FeatureList.pm:
209
210 2015-01-15  Daniel Bates  <dabates@apple.com>
211
212         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
213         https://bugs.webkit.org/show_bug.cgi?id=139685
214         <rdar://problem/19281317>
215
216         Reviewed by Simon Fraser.
217
218         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
219         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
220
221         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
222         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
223         before DRT dumps the output of a test. In particular, the WebThread may start a new page
224         load (say, as a result of continued JavaScript execution), which will ultimately lead to
225         dumping the test result again. Instead we want DRT to dump the test result synchronously
226         such that we capture the state of the web page either when the page is loaded or when
227         window.testRunner.notifyDone() is called.
228
229         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
230         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
231         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
232         flush CA transactions to the window.
233         * DumpRenderTree/mac/DumpRenderTree.mm:
234         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
235         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
236         (dump): Renamed; formerly named dumpTestResults().
237         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
238         enabling repaint support on iOS.
239         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
240         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
241         (dumpTestResults): Deleted.
242
243 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
244
245         [Win] Miscellaneous DRT fixes
246         https://bugs.webkit.org/show_bug.cgi?id=116562
247
248         Reviewed by Tim Horton.
249
250         While investigating the cause of several Windows crashes, I found:
251         (1) Messy conversions to and from BSTR types
252         (2) Weird mixes of wide-string and narrow string conversions
253         (3) Passing nullptr to some CoreFoundation routines that do not
254             permit null arguments.
255         (4) Commands to link the executable to the VS2005 runtime.
256
257         This patch cleans up these issues to improve DRT reliability on
258         Windows.
259
260         * DumpRenderTree/cg/ImageDiffCG.cpp:
261         (main): Get rid of VS2005 runtime linking.
262         * DumpRenderTree/win/DumpRenderTree.cpp:
263         (urlSuitableForTestResult): Protect against being asked
264         to process an empty URL.
265         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
266         than converting to/from wchar_t buffers.
267         (runTest): Simplify string and BSTR handling.
268         (createWebViewAndOffscreenWindow): Ditto.
269         (main): Get rid of VS2005 runtime linking.
270         * DumpRenderTree/win/TestRunnerWin.cpp:
271         (jsStringRefToWString): Simplify code.
272         (TestRunner::pathToLocalResource):
273         (TestRunner::setUserStyleSheetLocation):
274         * TestWebKitAPI/win/main.cpp: Get rid of
275         VS2005 runtime linking.
276         * win/DLLLauncher/DLLLauncherMain.cpp:
277         (wWinMain): Ditto.
278
279 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
280
281         Stop hardcoding mac-mountainlion in commit queue
282         https://bugs.webkit.org/show_bug.cgi?id=140492
283
284         Reviewed by Anders Carlsson.
285
286         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
287         there should be no change in behavior, because:
288         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
289         using it to create a port object.
290         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
291         is actually correct to use "mac" for the name there. We only used to get the expected
292         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
293         for unknown deprecated port names.
294
295         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
296
297 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
298
299         Create iOS-EWS server queue
300         https://bugs.webkit.org/show_bug.cgi?id=140473
301
302         Reviewed by Benjamin Poulain.
303
304         * QueueStatusServer/app.yaml: Updates the SVN version number.
305         * QueueStatusServer/config/queues.py: Add ios-ews queue.
306         * QueueStatusServer/model/queues.py:         
307         (Queue.display_name): Makes sure the display name is pretty!
308
309 2015-01-14  Daniel Bates  <dabates@apple.com>
310
311         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
312         https://bugs.webkit.org/show_bug.cgi?id=140301
313         <rdar://problem/19389266>
314
315         Reviewed by Jon Honeycutt.
316
317         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
318         with an unavailable runtime.
319
320         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
321         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
322         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
323         specified runtime cannot be used because it is unavailable.
324         * Scripts/webkitpy/port/ios.py:
325         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
326         which was formerly named testing_device.
327         * Scripts/webkitpy/xcode/simulator.py:
328         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
329         more robust than looking up the simulator device by name and runtime. This approach also
330         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
331         unavailable runtimes under the same iOS heading it would use to show it as available).
332         (Simulator.find_device_by_udid): Added.
333         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
334         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
335         (Simulator.available_runtimes): Added.
336         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
337         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
338         first element of the sorted list is the runtime with the highest version number.
339         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
340
341 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
342
343         Remove WK2 Windows cruft
344         https://bugs.webkit.org/show_bug.cgi?id=140440
345
346         Reviewed by Anders Carlsson.
347
348         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
349         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
350         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
351
352 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
353
354         Fix TestWTF failed in TestWebKitAPI
355         https://bugs.webkit.org/show_bug.cgi?id=140333
356
357         Reviewed by Sam Weinig.
358
359         Clear the std::ostringstream before starting test.
360
361         * TestWebKitAPI/Tests/WTF/RefLogger.h:
362         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
363
364 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
365
366         TestWebKitWebContext depends on British English spellcheck dictionary
367         https://bugs.webkit.org/show_bug.cgi?id=140403
368
369         Reviewed by Martin Robinson.
370
371         Install all English hunspell dictionaries on Fedora and Arch.
372
373         * gtk/install-dependencies:
374
375 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
376
377         [GTK] install-dependencies should grok dnf
378         https://bugs.webkit.org/show_bug.cgi?id=140396
379
380         Reviewed by Martin Robinson.
381
382         Fedora: install dependencies with dnf if yum is not installed.
383
384         * gtk/install-dependencies:
385
386 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
387
388         [EFL][GTK] Fix build after r178309  
389         https://bugs.webkit.org/show_bug.cgi?id=140381
390
391         Reviewed by Gyuyoung Kim.
392
393         * TestWebKitAPI/CMakeLists.txt: Added the API directory
394
395 2015-01-11  Sam Weinig  <sam@webkit.org>
396
397         Remove support for SharedWorkers
398         https://bugs.webkit.org/show_bug.cgi?id=140344
399
400         Reviewed by Anders Carlsson.
401
402         * Scripts/webkitperl/FeatureList.pm:
403
404 2015-01-12  Anders Carlsson  <andersca@apple.com>
405
406         Make delegates conform to formal delegate protocols
407         https://bugs.webkit.org/show_bug.cgi?id=140370
408
409         Reviewed by Dan Bernstein.
410
411         * DumpRenderTree/mac/TestRunnerMac.mm:
412         (TestRunner::numberOfPendingGeolocationPermissionRequests):
413         (TestRunner::setGeolocationPermission):
414
415 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
416
417         build-webkit: silence output of 'which'
418         https://bugs.webkit.org/show_bug.cgi?id=140278
419
420         Reviewed by Daniel Bates.
421
422         Use a more elegent test for the existance of ninja and eclipse.
423
424         * Scripts/webkitdirs.pm:
425         (commandExists): Don't assume the command supports --version
426         (canUseNinja): Use commandExists()
427         (canUseEclipse): Use commandExists()
428
429 2015-01-09  Sam Weinig  <sam@webkit.org>
430
431         Update the output format for run-api-tests
432         https://bugs.webkit.org/show_bug.cgi?id=140332
433
434         Reviewed by Dan Bernstein.
435
436         Changes the output format for run-api-tests be a bit simpler (no longer 
437         indented based on suite, as we were not really using suite very well) but
438         also include details in the case of failure.
439
440         Changes verbose mode to no longer spew out the gtest default printer output,
441         as the custom printer now includes the failure information.
442
443         * Scripts/run-api-tests:
444         (runTestsBySuite):
445         (runTest):
446         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
447         with colorized variants and strip out leaks spew (the leaks can be added back using
448         the new --show-leaks argument).
449
450         * TestWebKitAPI/TestsController.cpp:
451         (TestWebKitAPI::Printer::OnTestPartResult):
452         (TestWebKitAPI::Printer::OnTestEnd):
453         (TestWebKitAPI::TestsController::run):
454         Implement a custom result printer that just prints out the information we want.
455
456 2015-01-09  Sam Weinig  <sam@webkit.org>
457
458         TestWebKitAPI should print out the lists that fail at the end
459         https://bugs.webkit.org/show_bug.cgi?id=140329
460
461         Reviewed by Tim Horton.
462
463         * Scripts/run-api-tests:
464         (runTestsBySuite):
465         Print out failures and timeouts in all modes, not just verbose.
466
467 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
468
469         Make bmalloc work with ASan
470         https://bugs.webkit.org/show_bug.cgi?id=140194
471
472         Reviewed by Mark Lam.
473
474         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
475         ASan automatically (by forwarding to system malloc at runtime).
476
477 2015-01-09  Daniel Bates  <dabates@apple.com>
478
479         [iOS] Make DumpRenderTree build with public SDK
480         https://bugs.webkit.org/show_bug.cgi?id=140311
481
482         Reviewed by Sam Weinig.
483
484         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
485         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
486         Additionally, remove unused header CoreGraphics/CGFontDB.h.
487
488         * DumpRenderTree/mac/DumpRenderTree.mm:
489         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
490
491 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
492
493         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
494         https://bugs.webkit.org/show_bug.cgi?id=140300
495
496         Reviewed by Simon Fraser.
497
498         * WebKitTestRunner/TestController.cpp:
499         (WTR::TestController::createOtherPage):
500         (WTR::TestController::updateWindowScaleForTest):
501         (WTR::TestController::configureViewForTest):
502         * WebKitTestRunner/TestController.h:
503
504 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
505
506         Unreviewed. Moving myself to the committer section.
507
508         * Scripts/webkitpy/common/config/contributors.json:
509
510 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
511
512         Add a script to check for platform layering violations
513         https://bugs.webkit.org/show_bug.cgi?id=140248
514
515         Reviewed by Darin Adler.
516
517         It prints all the cases where files inside platform include
518         headers that are not in platform directory.
519
520         * Scripts/check-for-platform-layering-violations: Added.
521         (get_platform_headers):
522         (check_source_file):
523
524 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
525
526         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
527         https://bugs.webkit.org/show_bug.cgi?id=139884
528
529         Reviewed by Tim Horton.
530
531         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
532         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
533         what the "nominal resolution" is, but this appears to work in practice.
534
535 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
536
537         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
538         https://bugs.webkit.org/show_bug.cgi?id=140256
539
540         Reviewed by Anders Carlsson.
541
542         * DumpRenderTree/win/DumpRenderTree.cpp:
543         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
544         running with heap validation checks.
545         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
546         the "svg\\W3C-SVG-1.1" test directory.
547         (removeFontFallbackIfPresent): Use nullptr instead of 0.
548         * DumpRenderTree/win/TestRunnerWin.cpp:
549         (TestRunner::clearPersistentUserStyleSheet): Ditto.
550
551 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
552
553         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
554         https://bugs.webkit.org/show_bug.cgi?id=140218
555
556         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
557         Undone an accidental change - check for self.has_crashed() again. This code path
558         is for ports that don't have a signal handler printing #CRASHED when main process
559         crashes.
560
561         * Scripts/webkitpy/port/driver_unittest.py:
562         (DriverTest.test_check_for_driver_crash.assert_crash):
563         (DriverTest.test_check_for_driver_crash):
564         Updated the tests, all changes are expected.
565
566 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
567
568         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
569         https://bugs.webkit.org/show_bug.cgi?id=140218
570
571         Reviewed by Darin Adler.
572
573         * Scripts/webkitpy/port/driver.py:
574         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
575         "process crashed" condition. These don't make sense together - it's either a crash
576         or a timeout, and we should detect those properly at a much lower level.
577         (Driver.run_test): Ditto.
578         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
579         cases.
580
581         * WebKitTestRunner/TestController.h:
582         * WebKitTestRunner/TestController.cpp:
583         (WTR::TestController::webProcessName): 
584         (WTR::TestController::processDidCrash):
585         Factored out hardcoded child process names, as we now use these in two places.
586
587         * WebKitTestRunner/TestInvocation.cpp:
588         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
589         process name, so that it can be sampled (fixes sampling on Mavericks and above).
590
591 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
592
593         Reorder my list of email addresses, keeping the Bugzilla address at the
594         top since Bugzilla and other webkitpy scripts rely on that ordering.
595
596         * Scripts/webkitpy/common/config/contributors.json:
597
598 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
599
600         Moving myself to the reviewers section and updating
601         the list of my email addresses.
602
603         * Scripts/webkitpy/common/config/contributors.json:
604
605 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
606
607         [GTK] Build gtk-doc without gtkdoc-mktmpl
608         https://bugs.webkit.org/show_bug.cgi?id=140225
609
610         Reviewed by Darin Adler.
611
612         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
613         don't modify the tmpl files that it generates, it's not doing anything
614         for us.
615
616         * gtk/gtkdoc.py:
617         (GTKDoc.generate):
618         (GTKDoc._run_gtkdoc_scangobj):
619         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
620
621 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
622
623         [GTK][ThreadedCompositor] Add support for threaded compositor.
624         https://bugs.webkit.org/show_bug.cgi?id=118265
625
626         Reviewed by Martin Robinson.
627
628         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
629         autotools build systems. The feature is disabled by default.
630         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
631         from the feature flags.
632
633         * Scripts/webkitperl/FeatureList.pm:
634
635 2015-01-07  Daniel Bates  <dabates@apple.com>
636
637         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
638         https://bugs.webkit.org/show_bug.cgi?id=137371
639
640         Reviewed by David Kilzer.
641
642         Use SPI wrapper headers instead of directly referencing private SPI headers.
643
644         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
645         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
646         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
647         to the list of iOS header search directories so that we can include header UIKitSPI.h.
648         * DumpRenderTree/mac/DumpRenderTree.mm:
649         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
650         * DumpRenderTree/mac/EventSendingController.mm:
651         * DumpRenderTree/mac/TestRunnerMac.mm:
652
653 2015-01-07  Commit Queue  <commit-queue@webkit.org>
654
655         Unreviewed, rolling out r178068.
656         https://bugs.webkit.org/show_bug.cgi?id=140235
657
658         Breaks the iOS build (Requested by enrica on #webkit).
659
660         Reverted changeset:
661
662         "[iOS] Make WebKit2 build with public iOS SDK and more build
663         fixes for DRT"
664         https://bugs.webkit.org/show_bug.cgi?id=137371
665         http://trac.webkit.org/changeset/178068
666
667 2015-01-07  Daniel Bates  <dabates@apple.com>
668
669         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
670         https://bugs.webkit.org/show_bug.cgi?id=137371
671
672         Reviewed by David Kilzer.
673
674         Use SPI wrapper headers instead of directly referencing private SPI headers.
675
676         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
677         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
678         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
679         to the list of header search directories so that we can include header UIKitSPI.h.
680         * DumpRenderTree/mac/DumpRenderTree.mm:
681         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
682         * DumpRenderTree/mac/EventSendingController.mm:
683         * DumpRenderTree/mac/TestRunnerMac.mm:
684
685 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
686
687         [Win] Unreviewed test change to improve run reproducibility
688
689         * Scripts/webkitpy/port/win.py:
690         (WinPort.default_child_processes): Run a single DRT instance to help
691         identify failures caused by earlier test runs.
692
693 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
694
695         Myles C. Maxfield is a reviewer now
696         https://bugs.webkit.org/show_bug.cgi?id=140196
697
698         Reviewed by Dean Jackson.
699
700         * Scripts/webkitpy/common/config/contributors.json:
701
702 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
703
704         Make webkit-patch try harder to find keychain credentials
705         https://bugs.webkit.org/show_bug.cgi?id=140170
706
707         Reviewed by Ryosuke Niwa.
708
709         When the user manually enters a password into webkit-patch, we hand that off to the
710         Keyring Python module. However, that module creates a generic password entry instead
711         of an internet password entry. We should look for both kinds.
712
713         * Scripts/webkitpy/common/net/credentials.py:
714         (Credentials._run_security_tool):
715         (Credentials._credentials_from_keychain):
716         * Scripts/webkitpy/common/net/credentials_unittest.py:
717         (test_security_output_parse_entry_not_found):
718         (_assert_security_call):
719
720 2015-01-06  Anders Carlsson  <andersca@apple.com>
721
722         Try to fix the Mountain Lion build.
723
724         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
725         (TestWebKitAPI::didGetImageForMatchResult):
726
727 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
728
729         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
730         https://bugs.webkit.org/show_bug.cgi?id=140095
731
732         Reviewed by Anders Carlsson.
733
734         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
735         builds, but not in debug ones.
736
737 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
738
739         [Win] Extend WinLauncher with support for Page Zoom
740         https://bugs.webkit.org/show_bug.cgi?id=140152
741
742         Reviewed by Anders Carlsson.
743
744         * WinLauncher/Common.cpp:
745         (WndProc):
746         * WinLauncher/WinLauncher.cpp:
747         (WinLauncher::resetZoom):
748         (WinLauncher::zoomIn):
749         (WinLauncher::zoomOut):
750         * WinLauncher/WinLauncher.h:
751         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
752         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
753         * win/DLLLauncher/DLLLauncherMain.cpp:
754         (wWinMain):
755
756 2015-01-06  Anders Carlsson  <andersca@apple.com>
757
758         Fix API tests that are broken under HiDPI
759         https://bugs.webkit.org/show_bug.cgi?id=140146
760
761         Reviewed by Tim Horton.
762
763         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
764         (TestWebKitAPI::didGetImageForMatchResult):
765         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
766
767         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
768         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
769         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
770         out in a window that has a backing scale factor of 1.
771  
772         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
773         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
774         Ditto.
775
776 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
777
778         ADDRESS_SANITIZER macro is overloaded
779         https://bugs.webkit.org/show_bug.cgi?id=140130
780
781         Reviewed by Anders Carlsson.
782
783         * WebKitTestRunner/TestController.cpp: Use the new macro.
784
785 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
786
787         Remove some stale class names in check-for-inappropriate-objc-class-names
788         https://bugs.webkit.org/show_bug.cgi?id=140104
789
790         Reviewed by Darin Adler.
791
792         * Scripts/check-for-inappropriate-objc-class-names:
793         These UIWK* classes no longer exist.
794
795 2015-01-05  Anders Carlsson  <andersca@apple.com>
796
797         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
798         https://bugs.webkit.org/show_bug.cgi?id=140096
799         rdar://problem/19368938
800
801         Reviewed by Alexey Proskuryakov.
802
803         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
804         since clientInfo points to a web view, not the test controller.
805
806         * WebKitTestRunner/TestController.cpp:
807         (WTR::TestController::createOtherPage):
808
809 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
810
811         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
812         https://bugs.webkit.org/show_bug.cgi?id=140077
813
814         Reviewed by Csaba Osztrogonác.
815
816         WebKit C SPI is available on EFL,GTK.
817         Changed the define order to pass the API test.
818
819         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
820         (TestWebKitAPI::TEST):
821
822 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
823
824         Simplify WebKitTestRunner timeout tracking
825         https://bugs.webkit.org/show_bug.cgi?id=140036
826
827         Reviewed by Darin Adler.
828
829         The code for configuring timeouts was mostly dead, because run-webkit-tests never
830         passes the --timeout option to WebKitTestRunner.
831
832         * WebKitTestRunner/Options.h:
833         * WebKitTestRunner/Options.cpp:
834         (WTR::Options::Options):
835         (WTR::OptionsHandler::OptionsHandler):
836         (WTR::handleOptionTimeout): Deleted.
837         Removed support for --timeout. Timeouts are passed for each test individually,
838         and defaults are good enough for the rare cases where WebKitTestRunner is run
839         manually without run-webkit-tests.
840
841         * WebKitTestRunner/TestController.cpp:
842         (WTR::TestController::TestController):
843         (WTR::TestController::initialize):
844         (WTR::TestController::resetStateToConsistentValues):
845         (WTR::TestController::reattachPageToWebProcess):
846         (WTR::TestController::runUntil):
847         * WebKitTestRunner/TestController.h:
848         Simplified runUntil by passing the actual timeout, not an enum.
849         Increased short timeout for ASan enabled builds, as WebProcess launching takes
850         quite a while.
851
852         * WebKitTestRunner/TestInvocation.cpp:
853         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
854
855         * WebKitTestRunner/efl/TestControllerEfl.cpp:
856         (WTR::TestController::platformRunUntil):
857         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
858         (WTR::TestController::platformRunUntil):
859         Build fixes.
860
861 2015-01-02  Anders Carlsson  <andersca@apple.com>
862
863         Remove now unused storage tracker glue from DumpRenderTree
864         https://bugs.webkit.org/show_bug.cgi?id=140045
865
866         Reviewed by Darin Adler.
867
868         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
869         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
870         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
871         * DumpRenderTree/TestRunner.cpp:
872         (TestRunner::staticFunctions):
873         (syncLocalStorageCallback): Deleted.
874         (observeStorageTrackerNotificationsCallback): Deleted.
875         (deleteAllLocalStorageCallback): Deleted.
876         (deleteLocalStorageForOriginCallback): Deleted.
877         (localStorageDiskUsageForOriginCallback): Deleted.
878         (originsWithLocalStorageCallback): Deleted.
879         * DumpRenderTree/TestRunner.h:
880         * DumpRenderTree/mac/DumpRenderTree.mm:
881         (allocateGlobalControllers):
882         (releaseGlobalControllers):
883         * DumpRenderTree/mac/DumpRenderTreeMac.h:
884         * DumpRenderTree/mac/TestRunnerMac.mm:
885         (TestRunner::syncLocalStorage): Deleted.
886         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
887         (TestRunner::observeStorageTrackerNotifications): Deleted.
888         (TestRunner::deleteAllLocalStorage): Deleted.
889         (TestRunner::originsWithLocalStorage): Deleted.
890         (TestRunner::deleteLocalStorageForOrigin): Deleted.
891         * DumpRenderTree/win/TestRunnerWin.cpp:
892         (TestRunner::syncLocalStorage): Deleted.
893         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
894         (TestRunner::observeStorageTrackerNotifications): Deleted.
895         (TestRunner::deleteAllLocalStorage): Deleted.
896         (TestRunner::originsWithLocalStorage): Deleted.
897         (TestRunner::deleteLocalStorageForOrigin): Deleted.
898
899 2015-01-01  Darin Adler  <darin@apple.com>
900
901         We often misspell identifier as "identifer"
902         https://bugs.webkit.org/show_bug.cgi?id=140025
903
904         Reviewed by Michael Saboff.
905
906         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
907         * Scripts/webkitdirs.pm:
908         (appIdentifierFromBundle):
909         (installAndLaunchIOSWebKitAppInSimulator):
910         Fix misspellings
911
912 2015-01-01  Zalan Bujtas  <zalan@apple.com>
913
914         Saturated arithmetics: Incorrect float/double clamping.
915         https://bugs.webkit.org/show_bug.cgi?id=139888
916         rdar://problem/19330885
917
918         Reviewed by Simon Fraser.
919
920         Clamp float and double values correctly when applying saturated arithmetics.
921
922         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
923         (TestWebKitAPI::TEST):
924
925 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
926
927         [EFL] Bump version of ATK used by jhbuild to 2.15.2
928         https://bugs.webkit.org/show_bug.cgi?id=139816
929
930         Reviewed by Gyuyoung Kim.
931
932         Bump version of ATK used by jhbuild to 2.15.2
933
934         * efl/jhbuild.modules:
935
936 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
937
938         [jhBuild] cairo build error (-flto)
939         https://bugs.webkit.org/show_bug.cgi?id=139056
940
941         Reviewed by Philippe Normand.
942
943         cairo fails to link  with gcc 4.9 due to lto
944         related issue. This problem has been partially
945         addressed by cairo:
946         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
947         use the cairo --disable-lto option and remove jhbuild
948         makeargs fixes the issue.
949
950         * gtk/jhbuild.modules:
951         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
952
953 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
954         [Mac] Enable kerning, ligatures, and printer fonts 
955         https://bugs.webkit.org/show_bug.cgi?id=139970
956
957         Rubber stamped by Simon Fraser.
958
959         Flip the switch.
960
961         * DumpRenderTree/mac/DumpRenderTree.mm:
962         * WebKitTestRunner/TestController.cpp:
963         * WebKitTestRunner/mac/main.mm:
964
965 2014-12-26  Dan Bernstein  <mitz@apple.com>
966
967         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
968         https://bugs.webkit.org/show_bug.cgi?id=139950
969
970         Reviewed by David Kilzer.
971
972         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
973         in a manner that works with Xcode 5.1.1.
974
975 2014-12-24  Dan Bernstein  <mitz@apple.com>
976
977         Engineering builds of MiniBrowser ignore deprecated declaration warnings
978         https://bugs.webkit.org/show_bug.cgi?id=139941
979
980         Reviewed by Darin Adler.
981
982         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
983         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
984         to YES.
985         * MiniBrowser/mac/AppDelegate.m:
986         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
987         deprecated NSOKButton.
988
989 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
990
991         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
992         https://bugs.webkit.org/show_bug.cgi?id=134763
993
994         Reviewed by Ryosuke Niwa.
995
996         Adding an option to disable test harness link conversion.
997
998         * Scripts/webkitpy/w3c/test_converter.py:
999         (convert_for_webkit):
1000         (_W3CTestConverter.__init__):
1001         (_W3CTestConverter.convert_attributes_if_needed):
1002         * Scripts/webkitpy/w3c/test_importer.py:
1003         (parse_args):
1004         (TestImporter.import_tests):
1005
1006 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1007
1008         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
1009         https://bugs.webkit.org/show_bug.cgi?id=139933
1010
1011         Reviewed by Daniel Bates.
1012
1013         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
1014         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
1015         until ReportCrash lets it go.
1016
1017         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
1018         even get the actual crash log eventually - even when it times out waiting for the log, it
1019         makes a second lookup at the very end, after all tests finish. There may be further
1020         improvements needed here, but this small fix addresses most cases that happen in practice.
1021
1022         * DumpRenderTree/mac/DumpRenderTree.mm:
1023         (writeCrashedMessageOnFatalError):
1024         (dumpRenderTree):
1025         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
1026
1027         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
1028         unhelpful comment.
1029
1030 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1031
1032         Don't force -O1 for debug ASan builds
1033         https://bugs.webkit.org/show_bug.cgi?id=139926
1034
1035         Reviewed by Darin Adler.
1036
1037         * asan/asan.xcconfig:
1038
1039 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1040
1041         Simplify building with ASan
1042         https://bugs.webkit.org/show_bug.cgi?id=139916
1043
1044         Reviewed by Mark Rowe.
1045
1046         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
1047         We could also update Configuration file format, but that's a little scary because
1048         of how many places in code read it.
1049
1050         * Scripts/webkitdirs.pm:
1051         (determineASanIsEnabled): Read it from ASan configuration file.
1052         (argumentsForConfiguration): Added a FIXME.
1053         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
1054         (XcodeOptions): Pass the options needed for ASan.
1055
1056         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
1057         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
1058         that automatically.
1059
1060 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1061
1062         TestWebKitAPI build is broken when ASan is enabled
1063         https://bugs.webkit.org/show_bug.cgi?id=139902
1064
1065         Reviewed by Darin Adler.
1066
1067         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1068         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
1069         Inherit linker flags from DebugRelease, which respects ASAN.
1070
1071 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
1072
1073         Sort the Xcode project file.
1074
1075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1076
1077 2014-12-22  Lucas Forschler  <lforschler@apple.com>
1078
1079         Update apple-mac-114 to bot629.
1080         
1081         Unreviewed.
1082         
1083         * BuildSlaveSupport/build.webkit.org-config/config.json:
1084
1085 2014-12-22  Lucas Forschler  <lforschler@apple.com>
1086
1087         Replace Apple bot104 with bot124.
1088         
1089         Unreviewed.
1090         
1091         * BuildSlaveSupport/build.webkit.org-config/config.json:
1092
1093 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
1094
1095         URTBF after r177639.
1096
1097         * TestWebKitAPI/CMakeLists.txt:
1098
1099 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1100
1101         [EFL] MiniBrowser steals web view's focus
1102         https://bugs.webkit.org/show_bug.cgi?id=139482
1103
1104         Reviewed by Gyuyoung Kim.
1105
1106         Although we set focus on ewk_view while MiniBrowser initialization
1107         Ecore steals it in a favor of main window. As a result
1108         focused element on web page is unable to receive events.
1109
1110         * MiniBrowser/efl/main.c:
1111         (window_create):
1112         Prevent window from stealing web view's focus on start up.
1113
1114 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
1115
1116         [Win] Revise DRT logic to match Mac.
1117
1118         Rubberstamped by Anders Carlsson.
1119
1120         Update the Windows logic to perform initialization of preferences and WebKit
1121         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
1122         the same circumstances as the Mac version.
1123
1124         * DumpRenderTree/win/DumpRenderTree.cpp:
1125         (dump):
1126         (resetWebPreferencesToConsistentValues):
1127         (setDefaultsToConsistentValuesForTesting):
1128         (resetWebViewToConsistentStateBeforeTesting):
1129         (sizeWebViewForCurrentTest):
1130         (runTest):
1131         (createWebViewAndOffscreenWindow):
1132         (allocateGlobalControllers):
1133         (prepareConsistentTestingEnvironment):
1134         (main):
1135         (resetDefaultsToConsistentValues): Deleted.
1136
1137 2014-12-19  Roger Fong  <roger_fong@apple.com>
1138
1139         Unreviewed. Rollout r177605.
1140
1141         * EWSTools/start-queue-win.sh:
1142
1143 2014-12-19  Roger Fong  <roger_fong@apple.com>
1144
1145         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
1146
1147         * EWSTools/start-queue-win.sh:
1148
1149 2014-12-19  Daniel Bates  <dabates@apple.com>
1150
1151         [iOS] Add WebKitSystemInterface for iOS 8.1
1152         https://bugs.webkit.org/show_bug.cgi?id=139831
1153
1154         Reviewed by Alexey Proskuryakov.
1155
1156         Implement support in copy-webkitlibraries-to-product-directory to copy
1157         WebKitSystemInterface for iOS to the product directory and have build-webkit
1158         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
1159
1160         * Scripts/build-webkit:
1161         * Scripts/copy-webkitlibraries-to-product-directory:
1162
1163 2014-12-19  Daniel Bates  <dabates@apple.com>
1164
1165         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
1166         https://bugs.webkit.org/show_bug.cgi?id=139829
1167
1168         Reviewed by Alexey Proskuryakov.
1169
1170         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
1171         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
1172         expects the Xcode SDK to be specified using the --sdk-name command line argument.
1173
1174         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
1175         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
1176         logic to both avoid duplicating effort and make the command line options for
1177         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
1178         with the approach used in other WebKit tools.
1179
1180         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
1181         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
1182         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
1183
1184         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
1185         improve the readability of the code.
1186         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
1187         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
1188         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
1189         be included in a library.
1190         (unpackIfNecessary): Modified to call executeRanlib().
1191
1192 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
1193
1194         REGRESSION (177368): Some tests started to immediately time out
1195         https://bugs.webkit.org/show_bug.cgi?id=139826
1196
1197         Reviewed by Daniel Bates.
1198
1199         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
1200         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
1201         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
1202         ends in a load failure, we don't dump, so we used to leak the timer.
1203         
1204         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
1205         Added a comment.
1206
1207 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
1208
1209         [Win] Add accessor for serializing HTTP loads
1210         https://bugs.webkit.org/show_bug.cgi?id=139817
1211
1212         Reviewed by Mark Lam.
1213
1214         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
1215         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
1216         remove some redundant code from the destructor.
1217
1218 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
1219
1220         Clean up a fix for performance test bot failing to build
1221         https://bugs.webkit.org/show_bug.cgi?id=139818
1222
1223         Reviewed by Csaba Osztrogonác.
1224
1225         The "_1" in step name was annoying.
1226
1227         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1228         (CleanBuildIfScheduled.start):
1229         (RunAndUploadPerfTests):
1230         (DownloadAndPerfTestFactory.__init__):
1231         (DownloadAndPerfTestWebKit2Factory.__init__):
1232         (CleanBuildUnconditionally): Deleted.
1233         (CleanBuildUnconditionally.start): Deleted.
1234
1235 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
1236
1237         REGRESSION(r177535): It broke the GTK performance bot
1238         https://bugs.webkit.org/show_bug.cgi?id=139811
1239
1240         Reviewed by Carlos Garcia Campos.
1241
1242         Trigger clean build only on mac platform.
1243
1244         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1245         (DownloadAndPerfTestFactory.__init__):
1246         (DownloadAndPerfTestWebKit2Factory.__init__):
1247
1248 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
1249
1250         Unreviewed, moved myself to the list of committers.
1251
1252         * Scripts/webkitpy/common/config/contributors.json:
1253
1254 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
1255
1256         [Win] Update DumpRenderTree to more closely match Mac version
1257         https://bugs.webkit.org/show_bug.cgi?id=139799
1258
1259         Reviewed by Tim Horton.
1260
1261         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1262         (AccessibilityController::accessibleElementById): Correct
1263         use of BSTR to avoid leak.
1264         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
1265         update to match Mac version more closely.
1266         (dumpFramesAsText):
1267         (dump):
1268         (resetDefaultsToConsistentValues):
1269         (resetWebViewToConsistentStateBeforeTesting):
1270         (sizeWebViewForCurrentTest):
1271         (runTest):
1272         (openWindows):
1273         (windowToWebViewMap):
1274         (createWebViewAndOffscreenWindow):
1275         (sharedCFURLCache):
1276         (initializeGlobalsFromCommandLineOptions):
1277         (main):
1278         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1279         (TestRunner::addDisallowedURL):
1280         (TestRunner::applicationCacheDiskUsageForOrigin):
1281         (TestRunner::syncLocalStorage):
1282         (TestRunner::localStorageDiskUsageForOrigin):
1283         (TestRunner::observeStorageTrackerNotifications):
1284         (TestRunner::clearApplicationCacheForOrigin):
1285         (TestRunner::originsWithApplicationCache):
1286         (TestRunner::deleteAllLocalStorage):
1287         (TestRunner::setStorageDatabaseIdleInterval):
1288         (TestRunner::closeIdleLocalStorageDatabases):
1289         (TestRunner::originsWithLocalStorage):
1290         (TestRunner::deleteLocalStorageForOrigin):
1291         (TestRunner::copyDecodedHostName):
1292         (TestRunner::copyEncodedHostName):
1293         (TestRunner::keepWebHistory):
1294         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1295         (TestRunner::setAppCacheMaximumSize):
1296         (TestRunner::setCustomPolicyDelegate):
1297         (TestRunner::goBack):
1298         (TestRunner::setDefersLoading):
1299         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1300         (TestRunner::setMockDeviceOrientation):
1301         (TestRunner::setMockGeolocationPosition):
1302         (TestRunner::setMockGeolocationPositionUnavailableError):
1303         (TestRunner::setIconDatabaseEnabled):
1304         (TestRunner::setMainFrameIsFirstResponder):
1305         (TestRunner::setSpatialNavigationEnabled):
1306         (TestRunner::setPluginsEnabled):
1307         (TestRunner::setAutomaticLinkDetectionEnabled):
1308         (TestRunner::setUseDashboardCompatibilityMode):
1309         (TestRunner::dispatchPendingLoadRequests):
1310         (TestRunner::findString):
1311         (TestRunner::setCacheModel):
1312         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1313         (TestRunner::setWebViewEditable):
1314         (TestRunner::authenticateSession):
1315         (TestRunner::abortModal):
1316         (TestRunner::setSerializeHTTPLoads):
1317         (TestRunner::addChromeInputField):
1318         (TestRunner::removeChromeInputField):
1319         (TestRunner::focusWebView):
1320         (TestRunner::setBackingScaleFactor):
1321         (TestRunner::grantWebNotificationPermission):
1322         (TestRunner::denyWebNotificationPermission):
1323         (TestRunner::removeAllWebNotificationPermissions):
1324         (TestRunner::simulateWebNotificationClick):
1325
1326 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
1327
1328         Add strong typing to RefCounter interface, return value as a bool.
1329         https://bugs.webkit.org/show_bug.cgi?id=139776
1330
1331         Reviewed by Geoff Garen.
1332
1333         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
1334         This means there is no compile time type checking to prevent mistakes. Update the count()
1335         method to token<>(), templated on type used to identify the token being returned.
1336         Calls to token<T>() will return a result of type RefCounter::Token<T>.
1337
1338         There are a few problems with the fact the counter will return you an exact count of the
1339         number of outstanding tokens:
1340           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
1341             to do so if the value is only readable as a boolean.
1342           - It is desirable to provide the value as an argument to the callback, however to make
1343             this useful for integer values it is also necessary to indicate the direction of change
1344             (0->1 is often interesting where 2->1 is not).
1345           - There is a mismatch between the precision of returning a count, and the inherent
1346             imprecision of a token based mechanism, where it may be difficult to guarantee
1347             absolutely no unnecessary refcount churn, and thus unintentional counter values.
1348
1349         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1350         (TestWebKitAPI::TEST):
1351             - update API test.
1352
1353 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1354
1355         Disable retries on Mac Release WK2 testers
1356         https://bugs.webkit.org/show_bug.cgi?id=139798
1357
1358         Reviewed by Simon Fraser.
1359
1360         * BuildSlaveSupport/build.webkit.org-config/config.json:
1361
1362 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1363
1364         Perf tests frequently fail saying "build not up to date"
1365         https://bugs.webkit.org/show_bug.cgi?id=139786
1366
1367         Illegitimately yet authoritatively reviewed by Lucas Forschler.
1368
1369         Undo the rest of the first fix, and implement the behavior differently.
1370
1371         is_clean isn't automatically forwarded from config.json to properties.
1372
1373         * BuildSlaveSupport/build.webkit.org-config/config.json:
1374         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1375         (CleanBuildUnconditionally):
1376         (CleanBuildUnconditionally.start):
1377         (DownloadAndPerfTestFactory.__init__):
1378         (DownloadAndPerfTestWebKit2Factory.__init__):
1379
1380 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1381
1382         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
1383         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
1384         found nothing.
1385
1386         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1387         (BuildAndPerfTestFactory):
1388         (BuildAndPerfTestWebKit2Factory):
1389
1390 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1391
1392         Perf tests frequently fail saying "build not up to date"
1393         https://bugs.webkit.org/show_bug.cgi?id=139786
1394
1395         Reviewed by Ryosuke Niwa.
1396
1397         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
1398         directory to get rid of stale precompiled headers, and let it rebuild
1399         DumpRenderTree each time, that's fast.
1400
1401         Also, removed unused "build and perf test" code.
1402
1403         * BuildSlaveSupport/build.webkit.org-config/config.json:
1404
1405 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
1406
1407         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
1408
1409         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
1410         it easier to see what steps are missing when running under Windows.
1411
1412         * DumpRenderTree/win/TestRunnerWin.cpp:
1413         (TestRunner::callShouldCloseOnWebView):
1414         (TestRunner::clearAllApplicationCaches):
1415         (TestRunner::applicationCacheDiskUsageForOrigin):
1416         (TestRunner::syncLocalStorage):
1417         (TestRunner::localStorageDiskUsageForOrigin):
1418         (TestRunner::observeStorageTrackerNotifications):
1419         (TestRunner::clearApplicationCacheForOrigin):
1420         (TestRunner::originsWithApplicationCache):
1421         (TestRunner::clearAllDatabases):
1422         (TestRunner::deleteAllLocalStorage):
1423         (TestRunner::setStorageDatabaseIdleInterval):
1424         (TestRunner::closeIdleLocalStorageDatabases):
1425         (TestRunner::originsWithLocalStorage):
1426         (TestRunner::deleteLocalStorageForOrigin):
1427         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1428         (jsStringRefToWString):
1429         (TestRunner::setAppCacheMaximumSize):
1430         (TestRunner::setDatabaseQuota):
1431         (TestRunner::goBack):
1432         (TestRunner::setDefersLoading):
1433         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1434         (TestRunner::setAutomaticLinkDetectionEnabled):
1435         (TestRunner::dispatchPendingLoadRequests):
1436         (TestRunner::overridePreference):
1437         (TestRunner::removeAllVisitedLinks):
1438         (TestRunner::waitForPolicyDelegate):
1439         (TestRunner::resetPageVisibility):
1440         (TestRunner::setPageVisibility):
1441         (TestRunner::grantWebNotificationPermission):
1442         (TestRunner::denyWebNotificationPermission):
1443         (TestRunner::removeAllWebNotificationPermissions):
1444         (TestRunner::simulateWebNotificationClick):
1445         (TestRunner::simulateLegacyWebNotificationClick):
1446
1447 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
1448
1449         [Win] Correct Windows tests after Bug 139149 (edit)
1450         https://bugs.webkit.org/show_bug.cgi?id=139781
1451
1452         Reviewed by Anders Carlsson.
1453
1454         * DumpRenderTree/win/TestRunnerWin.cpp:
1455         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
1456         interface.
1457
1458 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
1459
1460         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
1461         https://bugs.webkit.org/show_bug.cgi?id=139748
1462
1463         Reviewed by Daniel Bates.
1464         
1465         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
1466         have all been updated.
1467
1468         * Scripts/webkitpy/port/factory.py:
1469         (platform_options):
1470
1471 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
1472
1473         Build more of TestWebKitAPI for iOS
1474         https://bugs.webkit.org/show_bug.cgi?id=139747
1475
1476         Reviewed by Daniel Bates.
1477         
1478         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
1479         which excluded some tests that should be run for iOS.
1480         
1481         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
1482         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
1483         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
1484         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
1485         
1486         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
1487         to share code between Mac and iOS.
1488
1489         * TestWebKitAPI/Configurations/Base.xcconfig:
1490         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1491         * TestWebKitAPI/InjectedBundleController.cpp:
1492         * TestWebKitAPI/InjectedBundleMain.cpp:
1493         * TestWebKitAPI/JavaScriptTest.cpp:
1494         * TestWebKitAPI/PlatformUtilities.cpp:
1495         * TestWebKitAPI/PlatformUtilities.h:
1496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1497         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1498         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1499         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1500         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1501         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
1502         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
1503         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1504         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1505         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1506         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1507         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1508         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
1509         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1510         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1511         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1512         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1513         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1514         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1515         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1516         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1517         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1518         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1519         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1520         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1521         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1522         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1523         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1524         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
1525         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1526         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1527         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1528         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1529         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1530         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1531         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1532         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
1533         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1534         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1535         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1536         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1537         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1538         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1539         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
1540         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1541         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1542         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1543         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1544         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
1545         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1546         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1547         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1548         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1549         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1550         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1551         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1552         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1553         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1554         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1555         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1556         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1557         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1558         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1559         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1560         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
1561         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1562         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1563         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1564         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1565         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1566         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1567         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1568         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1569         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
1570         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1571         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
1572         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
1573         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
1574         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1575         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1576         (TestWebKitAPI::TEST):
1577         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1578         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1579         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1580         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1581         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
1582         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
1583         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1584         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
1585         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1586         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
1587         (TEST):
1588         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1589         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1590         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1591         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
1592         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1593         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1594         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1595         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1596         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1597         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1598         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
1599         (TestWebKitAPI::Util::run):
1600         (TestWebKitAPI::Util::sleep):
1601         (TestWebKitAPI::Util::toSTD):
1602         * TestWebKitAPI/config.h:
1603         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1604         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1605         (TestWebKitAPI::Util::run): Deleted.
1606         (TestWebKitAPI::Util::sleep): Deleted.
1607         (TestWebKitAPI::Util::toSTD): Deleted.
1608
1609 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1610
1611         [GTK] Add support for FTL JIT on ARM64
1612         https://bugs.webkit.org/show_bug.cgi?id=139677
1613
1614         Reviewed by Csaba Osztrogonác.
1615
1616         * gtk/jhbuild-optional.modules:
1617         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
1618         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
1619
1620 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
1621
1622         [GTK] Implement webkit_web_view_is_playing_audio()
1623         https://bugs.webkit.org/show_bug.cgi?id=138918
1624
1625         Reviewed by Carlos Garcia Campos.
1626
1627         Add test case case for webkit_web_view_is_playing_audio() and the
1628         WebKitWebView::is-playing-audio property.
1629
1630         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1631         (urlForResource): Utility function to get URLs pointing to resources
1632         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
1633         (testWebViewIsPlayingAudio): Added.
1634         (beforeAll):
1635         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1636         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
1637         API tests resources directory, or the WebKit2 C API tests resources
1638         directory. The default value of the flag is to use the WebKit2 GTK
1639         one, to avoid having to change existing tests.
1640         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1641         (isPlayingAudioChanged): Added.
1642         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
1643         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1644
1645 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1646
1647         [GTK] [EFL] Enable per_test_timeout
1648         https://bugs.webkit.org/show_bug.cgi?id=139771
1649
1650         Reviewed by Csaba Osztrogonác.
1651
1652         This is needed to make WKTR use either the default port timeout, or the
1653         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
1654         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
1655
1656         * Scripts/webkitpy/port/efl.py:
1657         (EflPort.supports_per_test_timeout): Enabled.
1658         * Scripts/webkitpy/port/gtk.py:
1659         (GtkPort.supports_per_test_timeout): Enabled.
1660
1661 2014-12-17  Lucas Forschler  <lforschler@apple.com>
1662
1663         Move Apple buildbot slaves to their new home.
1664         
1665         Reviewed by Roger Fong.
1666
1667         * BuildSlaveSupport/build.webkit.org-config/config.json:
1668
1669 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
1670
1671         REGRESSION (r177363): Gtk and Efl testing is broken
1672         https://bugs.webkit.org/show_bug.cgi?id=139734
1673
1674         Reviewed by Simon Fraser.
1675
1676         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1677         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
1678         affected both script and tool timeout. This is still the right place for this logic,
1679         but it would be a larger refactoring than I can do right now.
1680
1681         * Scripts/webkitpy/port/base.py:
1682         (Port.supports_per_test_timeout): Added a FIXME.
1683         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
1684         to avoid making tests take more time.
1685
1686         * Scripts/webkitpy/port/driver.py:
1687         (Driver.run_test): Adjust script timeout here.
1688         (Driver._check_for_driver_timeout): Fix the timeout detection.
1689         (Driver._read_block): Actually use the timeout detection code.
1690
1691         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
1692         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
1693
1694         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
1695         Update results for the new default.
1696
1697         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1698         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
1699         actually a good one.
1700
1701 2014-12-17  Commit Queue  <commit-queue@webkit.org>
1702
1703         Unreviewed, rolling out r177456.
1704         https://bugs.webkit.org/show_bug.cgi?id=139749
1705
1706         Broke webkitpy and Mac tests (Requested by ap on #webkit).
1707
1708         Reverted changeset:
1709
1710         "REGRESSION (r177363): Gtk and Efl testing is broken"
1711         https://bugs.webkit.org/show_bug.cgi?id=139734
1712         http://trac.webkit.org/changeset/177456
1713
1714 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
1715
1716         REGRESSION (r177363): Gtk and Efl testing is broken
1717         https://bugs.webkit.org/show_bug.cgi?id=139734
1718
1719         Reviewed by Simon Fraser.
1720
1721         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1722         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
1723         affected both script and tool timeout. This is still the right place for this logic,
1724         but it would be a larger refactoring than I can do right now.
1725
1726         * Scripts/webkitpy/port/base.py:
1727         (Port.supports_per_test_timeout): Added a FIXME.
1728         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
1729         to avoid making tests take more time.
1730
1731         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
1732
1733         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
1734         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
1735
1736 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1737
1738         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
1739         https://bugs.webkit.org/show_bug.cgi?id=139725
1740
1741         Reviewed by Martin Robinson.
1742
1743         The timeout is already in milliseconds, so we don't need to do any conversion.
1744
1745         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1746         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1747
1748 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
1749
1750         [EFL]Fix build warning in MiniBrowser
1751         https://bugs.webkit.org/show_bug.cgi?id=139723
1752
1753         Reviewed by Darin Adler.
1754
1755         The warning is caused by the compiler wanting the first argument to be a
1756         string literal, not a dynamically created string.
1757
1758         * MiniBrowser/efl/main.c:
1759         (quit):
1760
1761 2014-12-16  Sam Weinig  <sam@webkit.org>
1762
1763         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
1764         https://bugs.webkit.org/show_bug.cgi?id=139718
1765
1766         Reviewed by Mark Rowe.
1767
1768         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
1769         files into a static lib which the command line utility can link link against.
1770         This will allow us to create a TestWebKitAPI.app that can run on iOS.
1771
1772         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1773         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
1774         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1775
1776 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
1777
1778         Sort out timeout implementations in DRT and WKTR
1779         https://bugs.webkit.org/show_bug.cgi?id=139671
1780
1781         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
1782         with the tool.
1783
1784         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1785         (RunTest.test_hung_thread):
1786
1787 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
1788
1789         Sort out timeout implementations in DRT and WKTR
1790         https://bugs.webkit.org/show_bug.cgi?id=139671
1791
1792         Reviewed by Simon Fraser.
1793
1794         Test timeout implementation had many deficiencies, please see the bug for details.
1795         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
1796         [ Slow ] modifiers should work a lot better.
1797
1798         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
1799         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
1800         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
1801         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
1802         DumpRenderTree already read the --timeout option from command line, and webkitpy
1803         was already configured to pass it on Mac and iOS. Let's actually use it.
1804         TestCommand already had the same 30 second default, so this doesn't change behavior
1805         when DRT is ran manually without the option.
1806         Windows DumpRenderTree will need to be fixed separately (that's easy).
1807
1808         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
1809         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
1810         slightly better to use stderr in both, as this is an out of band message, but
1811         that's a larger refactoring, and the difference is minimal in practice.
1812
1813         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1814         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
1815         different. We want the tool to reliably detect timeouts that can be detected, and
1816         not race with the script for that.
1817
1818         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
1819         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
1820         is honored inmore cases, that could make tests run slower.
1821         * Scripts/webkitpy/port/driver.py:
1822         (Driver.__init__):
1823         (Driver.run_test):
1824         (Driver.cmd_line):
1825         (Driver._check_for_driver_timeout):
1826         Detect tests that have the timeout output, and make these have the proper Timeout result.
1827
1828         * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
1829         incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
1830
1831         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1832         (WTR::TestRunner::setCustomTimeout): Deleted.
1833         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1834         (WTR::TestRunner::setCustomTimeout):
1835         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1836         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1837         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1838         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1839         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1840         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1841         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1842         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1843         Updated to use a timeout passed from UI process, which used to be ignored.
1844
1845         * WebKitTestRunner/TestController.cpp:
1846         (WTR::TestController::TestController):
1847         (WTR::TestController::runUntil):
1848         (WTR::TestController::getCustomTimeout): Deleted.
1849         * WebKitTestRunner/TestController.h:
1850         Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
1851         Changed default message timeouts to match new run-webkit-tests timeout. These don't
1852         affect ports where timeout is passed per test (shouldn't they all be like that?).
1853
1854         * WebKitTestRunner/TestInvocation.cpp:
1855         (WTR::TestInvocation::invoke):
1856         (WTR::TestInvocation::setCustomTimeout): Deleted.
1857         * WebKitTestRunner/TestInvocation.h:
1858         (WTR::TestInvocation::setCustomTimeout):
1859         (WTR::TestInvocation::customTimeout):
1860         Ditto.
1861
1862 2014-12-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1863
1864         [EFL] Add logging domain for MiniBrowser
1865         https://bugs.webkit.org/show_bug.cgi?id=139642
1866
1867         Reviewed by Gyuyoung Kim.
1868
1869         Similarly to EWebKit2, provide logging facility for MiniBrowser
1870         based on Eina Log module to have a convenient way to display
1871         all/subset/none messages for EFL based libraries and MiniBrowser.
1872
1873         Usage:
1874         1. Disable all messages:
1875            EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
1876
1877         2. Enable all messages:
1878            EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
1879
1880         3. Enable MiniBrowser and EWebkit2 messages only:
1881            EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
1882
1883         More information and examples you can find here:
1884         http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
1885
1886         * MiniBrowser/efl/main.c:
1887         (on_mouse_wheel):
1888         (on_window_resize):
1889         (save_page_contents_callback):
1890         (script_execute_callback):
1891         (on_key_down):
1892         (on_download_request):
1893         (on_download_finished):
1894         (on_download_failed):
1895         (quit):
1896         (on_refresh_button_clicked):
1897         (on_stop_button_clicked):
1898         (navigation_button_longpress_process):
1899         (on_popup_menu_item_clicked):
1900         (popup_menu_populate):
1901         (on_popup_menu_show):
1902         (on_window_create):
1903         (context_menu_item_selected_cb):
1904         (context_menu_populate):
1905         (on_context_menu_show):
1906         (on_context_menu_hide):
1907         (on_navigation_policy_decision):
1908         (window_create):
1909         (parse_cookies_policy):
1910         (elm_main):
1911         (has_scheme):
1912         (list_item_label_get):
1913         (on_popup_menu_hide):
1914         (on_window_close):
1915         (on_home_button_clicked):
1916         Replace locally info() macro with newly introduced
1917         one which uses Eina Log module. There is no logic change.
1918
1919 2014-12-15  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1920
1921         [EFL] FTL JIT not working on ARM64
1922         https://bugs.webkit.org/show_bug.cgi?id=139295
1923
1924         Reviewed by Michael Saboff.
1925
1926         Added patches for llvm to add ARM64 support for FTL JIT
1927
1928         * efl/jhbuild.modules:
1929         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
1930         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
1931
1932 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1933
1934         Move Said to the committers section.
1935
1936         * Scripts/webkitpy/common/config/contributors.json:
1937
1938 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1939
1940         Implement Data Detectors immediate actions for WebKit2
1941         https://bugs.webkit.org/show_bug.cgi?id=139617
1942         <rdar://problem/19198539>
1943
1944         Reviewed by Beth Dakin.
1945
1946         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1947         (TestWebKitAPI::TEST):
1948         Temporarily disable the action menu tests while the
1949         underlying code is in flux.
1950
1951 2014-12-14  Andreas Kling  <akling@apple.com>
1952
1953         Replace PassRef with Ref/Ref&& across the board.
1954         <https://webkit.org/b/139587>
1955
1956         Reviewed by Darin Adler.
1957
1958         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1959         (TestWebKitAPI::passWithRef):
1960         (TestWebKitAPI::TEST):
1961         (TestWebKitAPI::passWithPassRef): Deleted.
1962         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1963         (TestWebKitAPI::TEST):
1964         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1965         (TestWebKitAPI::TEST):
1966         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1967         (TestWebKitAPI::createTestValue):
1968
1969 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1970
1971         [EFL] MiniBrowser's window_create may return NULL
1972         https://bugs.webkit.org/show_bug.cgi?id=139585
1973
1974         Reviewed by Gyuyoung Kim.
1975
1976         Move NULL checking before using object which window_create
1977         returns.
1978
1979         * MiniBrowser/efl/main.c:
1980         (elm_main):
1981
1982 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
1983
1984         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
1985         https://bugs.webkit.org/show_bug.cgi?id=73030
1986
1987         Reviewed by Anders Carlsson.
1988
1989         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
1990         database to empty to avoid having it fetch default favicons at random times.
1991         DumpRenderTree also disables it, and also it has a way for tests to temporarily
1992         enable it.
1993
1994 2014-12-12  Lucas Forschler  <lforschler@apple.com>
1995
1996         Update Apple owned build slaves after infrastructure update.
1997         
1998         Reviewed by Ryosuke Niwa.
1999
2000         * BuildSlaveSupport/build.webkit.org-config/config.json:
2001
2002 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2003
2004         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
2005         https://bugs.webkit.org/show_bug.cgi?id=139537
2006
2007         Reviewed by Carlos Garcia Campos.
2008
2009         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
2010         of get_dependencies_path().
2011         * jhbuild/jhbuildutils.py:
2012         (get_dependencies_path): Fix the function to return the new
2013         dependencies path: DependenciesPORT.
2014         (enter_jhbuild_environment_if_available): Pass the port name
2015         when invoking get_dependencies_path().
2016
2017 2014-12-10  Lucas Forschler  <lforschler@apple.com>
2018
2019         Update Apple owned build slaves.
2020         
2021         Rubber-stamped by Dana Burkart.
2022         
2023         * BuildSlaveSupport/build.webkit.org-config/config.json:
2024
2025 2014-12-10  Daniel Bates  <dabates@apple.com>
2026
2027         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
2028         timeout instead of test failure
2029         https://bugs.webkit.org/show_bug.cgi?id=139525
2030
2031         Reviewed by Zalan Bujtas.
2032
2033         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
2034         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
2035         output.
2036
2037         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
2038         for the WebThread to spin its run loop before dumping its output. A test that
2039         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
2040         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
2041         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
2042         because run-webkit-tests may terminate a DumpRenderTree.app process when it
2043         exceeds its process time limit (defaults to 35ms) regardless of whether such
2044         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
2045
2046         * Scripts/webkitpy/port/ios.py:
2047         (IOSSimulatorPort.default_timeout_ms):
2048
2049 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2050
2051         [GTK][WK2] Add HTML5 Notifications support
2052         https://bugs.webkit.org/show_bug.cgi?id=61140
2053
2054         Reviewed by Carlos Garcia Campos.
2055
2056         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
2057         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2058         (testWebViewNotification):
2059         (beforeAll):
2060         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
2061         (permissionRequestDialogCallback):
2062         (webViewDecidePermissionRequest):
2063         (geolocationRequestDialogCallback): Deleted.
2064
2065 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
2066
2067         Fix webkitpy test expectation
2068
2069         Not sure what I messed up, but TOTAL_SKIPS was not right.
2070
2071         * Scripts/webkitpy/port/test.py:
2072
2073 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
2074
2075         Remove virtual test support from webkitpy
2076         https://bugs.webkit.org/show_bug.cgi?id=139427
2077
2078         Reviewed by Alexey Proskuryakov.
2079
2080         It seems that the only concrete client of virtual tests is the unit tests :D
2081
2082         This patch tries to clean as much useless code as possible.
2083
2084         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2085         (RunTest.test_tolerance):
2086         (RunTest.test_virtual): Deleted.
2087         * Scripts/webkitpy/layout_tests/views/printing.py:
2088         (Printer._print_test_trace):
2089         * Scripts/webkitpy/port/base.py:
2090         (Port.expected_filename):
2091         (Port.tests):
2092         (Port.test_isfile):
2093         (Port.test_isdir):
2094         (Port.sample_process):
2095         (Port.find_system_pid):
2096         (Port.test_expectations_file_position):
2097         (Port.virtual_test_suites): Deleted.
2098         (Port): Deleted.
2099         (Port.populated_virtual_test_suites): Deleted.
2100         (Port._virtual_tests): Deleted.
2101         (Port.lookup_virtual_test_base): Deleted.
2102         (Port.lookup_virtual_test_args): Deleted.
2103         (VirtualTestSuite): Deleted.
2104         (VirtualTestSuite.__init__): Deleted.
2105         (VirtualTestSuite.__repr__): Deleted.
2106         * Scripts/webkitpy/port/base_unittest.py:
2107         (PortTest.test_test_exists):
2108         (PortTest.test_test_isfile):
2109         (PortTest.test_test_isdir):
2110         (PortTest.test_tests):
2111         * Scripts/webkitpy/port/driver.py:
2112         (DriverProxy.run_test): Deleted.
2113         * Scripts/webkitpy/port/test.py:
2114         (TestPort._skipped_tests_for_unsupported_features):
2115         (TestPort.all_baseline_variants):
2116         (TestPort.virtual_test_suites): Deleted.
2117         * Scripts/webkitpy/tool/commands/queries.py:
2118         (PrintBaselines.__init__):
2119         (PrintBaselines.execute):
2120         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2121         (PrintBaselinesTest.test_basic):
2122         (PrintBaselinesTest.test_multiple):
2123         (PrintBaselinesTest.test_csv):
2124
2125 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2126
2127         Blink Merge: Remove 'http_lock' code from webkitpy
2128         https://bugs.webkit.org/show_bug.cgi?id=136722
2129
2130         Reviewed by Alexey Proskuryakov.
2131
2132         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
2133         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
2134
2135         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2136         (LayoutTestRunner.__init__):
2137         (LayoutTestRunner.run_tests):
2138         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
2139         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
2140         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2141         (FakePrinter.flush):
2142         (LayoutTestRunnerTests._runner):
2143         (LayoutTestRunnerTests._run_tests):
2144         (LayoutTestRunnerTests.test_servers_started):
2145         (LockCheckingRunner): Deleted.
2146         (LockCheckingRunner.__init__): Deleted.
2147         (LockCheckingRunner.handle_finished_list): Deleted.
2148         (LayoutTestRunnerTests.test_http_locking): Deleted.
2149         * Scripts/webkitpy/port/base.py:
2150         (Port.__init__):
2151         (Port.to.http_server_supports_ipv6):
2152         (Port.to.stop_websocket_server):
2153         (Port.to.acquire_http_lock): Deleted.
2154         (Port.to.release_http_lock): Deleted.
2155         * Scripts/webkitpy/port/http_lock.py: Removed.
2156         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
2157         * Scripts/webkitpy/port/ios.py:
2158         (IOSSimulatorPort.show_results_html_file):
2159         (IOSSimulatorPort.acquire_http_lock): Deleted.
2160         (IOSSimulatorPort): Deleted.
2161         (IOSSimulatorPort.release_http_lock): Deleted.
2162         * Scripts/webkitpy/port/mac.py:
2163         (MacPort.show_results_html_file):
2164         (MacPort): Deleted.
2165         (MacPort.acquire_http_lock): Deleted.
2166         (MacPort.release_http_lock): Deleted.
2167         * Scripts/webkitpy/port/mock_drt.py:
2168         (MockDRTPort.start_websocket_server):
2169         (MockDRTPort.stop_websocket_server):
2170         (MockDRTPort.acquire_http_lock): Deleted.
2171         (MockDRTPort.release_http_lock): Deleted.
2172         * Scripts/webkitpy/port/mock_drt_unittest.py:
2173         (MockDRTPortTest.test_uses_apache):
2174         (MockDRTPortTest.integration_test_http_lock): Deleted.
2175         * Scripts/webkitpy/port/port_testcase.py:
2176         (PortTestCase.assert_servers_are_up):
2177         (PortTestCase.integration_test_http_lock): Deleted.
2178         * Scripts/webkitpy/port/test.py:
2179         (TestPort.start_websocket_server):
2180         (TestPort.stop_websocket_server):
2181         (TestPort.acquire_http_lock): Deleted.
2182         (TestPort.release_http_lock): Deleted.
2183
2184 2014-12-09  Alberto Garcia  <berto@igalia.com>
2185
2186         convertToUTF8String converts null string to empty string
2187         https://bugs.webkit.org/show_bug.cgi?id=133904
2188
2189         Reviewed by Carlos Garcia Campos.
2190
2191         Test that trying to get the value of a non-existent attribute
2192         returns 0 instead of an empty string.
2193
2194         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2195         (WebKitDOMNodeTest::testInsertion):
2196
2197 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
2198
2199         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
2200         https://bugs.webkit.org/show_bug.cgi?id=139070
2201
2202         Reviewed by Carlos Garcia Campos.
2203
2204         * gtk/jhbuild.modules:
2205
2206 2014-12-08  Tim Horton  <timothy_horton@apple.com>
2207
2208         Add action menu tests
2209         https://bugs.webkit.org/show_bug.cgi?id=139156
2210
2211         Reviewed by Dean Jackson.
2212
2213         * TestWebKitAPI/PlatformWebView.h:
2214         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2215         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2216         Add a mechanism allowing tests to provide their own WKView subclass.
2217
2218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2219         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
2220         Add a file with lots of menu targets.
2221
2222         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
2223         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
2224         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
2225         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2226         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
2227
2228         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
2229
2230         (TestWebKitAPI::didFinishLoadForFrameCallback):
2231         (TestWebKitAPI::didFinishDownloadCallback):
2232         (TestWebKitAPI::didCreateDownloadDestinationCallback):
2233         Watch downloads and ensure that they match the content we expect.
2234
2235         (TestWebKitAPI::watchPasteboardForString):
2236         (TestWebKitAPI::watchPasteboardForImage):
2237         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
2238         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
2239         (TestWebKitAPI::javaScriptStringCallback):
2240         (TestWebKitAPI::javaScriptBoolCallback):
2241         (TestWebKitAPI::callJavaScriptReturningString):
2242         (TestWebKitAPI::callJavaScriptReturningBool):
2243         (TestWebKitAPI::watchEditableAreaForString):
2244         (TestWebKitAPI::waitForVideoReady):
2245         (TestWebKitAPI::retrieveSelection):
2246         (TestWebKitAPI::retrieveSelectionInElement):
2247         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
2248         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
2249         Add many helpers for testing, especially to make asynchronous things synchronous.
2250
2251         (TestWebKitAPI::windowPointForTarget):
2252         (TestWebKitAPI::inset8):
2253         Hard-code points in action-menu-targets.html for hit testing.
2254
2255         (TestWebKitAPI::TEST):
2256         Add a suite of tests for WebKit2 action menus.
2257
2258         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
2259         (TestWebKitAPI::createActionContextForPhoneNumber):
2260         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
2261         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
2262         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
2263         (TestWebKitAPI::ActionMenuTest::drawRect):
2264         (TestWebKitAPI::ActionMenuTest::didCreatePage):
2265         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
2266         so that we can test that infrastructure.
2267
2268 2014-12-08  Philippe Normand  <pnormand@igalia.com>
2269
2270         [GTK] UserMedia Permission Request API
2271         https://bugs.webkit.org/show_bug.cgi?id=136449
2272
2273         Reviewed by Carlos Garcia Campos.
2274
2275         The GTK version of the MiniBrowser has gained UserMedia permission
2276         request support.
2277
2278         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
2279         requires user permission to access audio/video devices.
2280         (permissionRequestDialogCallback):
2281         (webViewDecidePermissionRequest):
2282         (geolocationRequestDialogCallback): Deleted.
2283
2284 2014-12-08  Anders Carlsson  <andersca@apple.com>
2285
2286         Add a stubbed out method for clearing out the website data store
2287         https://bugs.webkit.org/show_bug.cgi?id=139404
2288
2289         Reviewed by Antti Koivisto.
2290
2291         Add a debug menu item for testing clearing of website data.
2292
2293         * MiniBrowser/mac/MainMenu.xib:
2294         * MiniBrowser/mac/WK2BrowserWindowController.m:
2295         (-[WK2BrowserWindowController clearWebsiteData:]):
2296
2297 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
2298
2299         Update style checker to deal with "const override"
2300         https://bugs.webkit.org/show_bug.cgi?id=139371
2301
2302         Reviewed by Csaba Osztrogonác.
2303
2304         check-webkit-style shouldn't complain about an open brace to start a
2305         line after a function definition with const override.
2306
2307         * Scripts/webkitpy/style/checkers/cpp.py:
2308         (check_braces):
2309         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2310         (CppStyleTest.test_brace_at_begin_of_line):
2311
2312 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2313
2314         [GTK] Fix GObject DOM bindings API break tests after r176920
2315         https://bugs.webkit.org/show_bug.cgi?id=139368
2316
2317         Reviewed by Gustavo Noronha Silva.
2318
2319         Remove the @version from the symbol name before comparing.
2320
2321         * gtk/check-for-webkitdom-api-breaks:
2322         (read_expected_api):
2323
2324 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2325
2326         Remove the option to automatically update the GObject DOM bindings symbols file
2327         https://bugs.webkit.org/show_bug.cgi?id=139366
2328
2329         Reviewed by Martin Robinson.
2330
2331         It's currently broken, because symbols now need to be in a
2332         specific order. Now that the symbols file only contains stable
2333         API, it's not a problem to manually update it every time new API
2334         is added.
2335
2336         * gtk/check-for-webkitdom-api-breaks:
2337         (read_expected_api):
2338         (check_api):
2339         (write_expected_api): Deleted.
2340
2341 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2342
2343         [GTK] Use GMainLoopSource in WebKitTestRunner
2344         https://bugs.webkit.org/show_bug.cgi?id=138831
2345
2346         Reviewed by Sergio Villar Senin.
2347
2348         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2349         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2350         (WTR::TestRunner::platformInitialize):
2351         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2352         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2353         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
2354         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2355         (WTR::TestController::notifyDone):
2356         (WTR::TestController::platformRunUntil):
2357         (WTR::cancelTimeout): Deleted.
2358
2359 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2360
2361         [GTK] Missing API detected in GObject DOM bindings after r176630
2362         https://bugs.webkit.org/show_bug.cgi?id=139201
2363
2364         Reviewed by Gustavo Noronha Silva.
2365
2366         Handle deprecated symbols again when generating the GObject DOM
2367         bindings documentation.
2368
2369         * gtk/webkitdom.py:
2370         (WebKitDOMDocGenerator):
2371         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
2372         (WebKitDOMDocGenerator.generate):
2373         (WebKitDOMDocGeneratorSections.__init__):
2374         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
2375         (WebKitDOMDocGeneratorSections.write_section):
2376
2377 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
2378
2379         [EFL][jhbuild] Fix libsoup build with clang
2380         https://bugs.webkit.org/show_bug.cgi?id=139088
2381
2382         Reviewed by Gyuyoung Kim.
2383
2384         * efl/jhbuild.modules:
2385         * efl/patches/soup-clang-warning-fix1.patch: Added.
2386         * efl/patches/soup-clang-warning-fix2.patch: Added.
2387
2388 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
2389
2390         [Mac] DumpRenderTree sets storage directory incorrectly
2391         https://bugs.webkit.org/show_bug.cgi?id=139347
2392
2393         Reviewed by Dan Bernstein.
2394
2395         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2396         Don't use user defaults to pass per-instance paths, as user defaults are shared
2397         across all instances.
2398
2399 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
2400
2401         AX: I cannot activate links on the mobile version of news.google.com
2402         https://bugs.webkit.org/show_bug.cgi?id=139330
2403
2404         Reviewed by Simon Fraser.
2405
2406         Implement press for iOS.
2407
2408         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2409         (AccessibilityUIElement::press):
2410
2411 2014-12-05  Daniel Bates  <dabates@apple.com>
2412
2413         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
2414         https://bugs.webkit.org/show_bug.cgi?id=139326
2415
2416         Reviewed by Anders Carlsson.
2417
2418         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
2419         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
2420         using the same scale factor as used in WebKit.
2421
2422         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2423         (createBitmapContextFromWebView):
2424
2425 2014-12-05  Anders Carlsson  <andersca@apple.com>
2426
2427         REGRESSION (r176677): All tests crash on Windows
2428         https://bugs.webkit.org/show_bug.cgi?id=139321
2429
2430         Reviewed by Alexey Proskuryakov.
2431
2432         * DumpRenderTree/win/DumpRenderTree.cpp:
2433         (runTest):
2434         Don't call CFRelease on the url while we have an outstanding pointer to its string,
2435         and use the right number of bytes when allocating the testURL buffer.
2436
2437 2014-12-05  Daniel Bates  <dabates@apple.com>
2438
2439         [iOS] DumpRenderTree produces many reference test mismatches
2440         https://bugs.webkit.org/show_bug.cgi?id=139314
2441
2442         Reviewed by Simon Fraser.
2443
2444         Fixes an issue where the scale factor used to render the snapshot taken by
2445         DumpRenderTree may differ from the device scale factor. In particular, the
2446         scale factor used to render a snapshot of a test may differ from the scale
2447         factor used to render the snapshot of its expected result.
2448
2449         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
2450         snapshot the UIWebBrowserView. This SPI always render using a scale factor
2451         of one when the backing store for the LegacyTileLayer objects were out-of-
2452         date regardless of the device scale factor. Instead we should use UIImage
2453         and CALayer API to perform the snapshot with respect to the device scale
2454         factor.
2455
2456         Additionally write iOS pixel dump support logic in terms of existing
2457         DumpRenderTree abstractions so as to support generating and comparing
2458         pixel dump checksums as well as make the iOS code more consistent with
2459         the logic used by other ports.
2460
2461         * DumpRenderTree/PixelDumpSupport.cpp:
2462         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
2463         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2464         (BitmapContext::createFromUIImage): Added.
2465         (BitmapContext::pixelData): Added.
2466         (BitmapContext::BitmapContext): Added.
2467         (computeMD5HashStringForBitmapContext): Added.
2468         (dumpBitmap): Added.
2469         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
2470         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
2471
2472 2014-12-05  Anders Carlsson  <andersca@apple.com>
2473
2474         Give all web pages a website data store
2475         https://bugs.webkit.org/show_bug.cgi?id=139317
2476
2477         Reviewed by Tim Horton.
2478
2479         * MiniBrowser/mac/AppDelegate.m:
2480         (-[BrowserAppDelegate newPrivateWindow:]):
2481         Don't release the controller - it's implicitly retained by the window.
2482
2483 2014-12-05  Daniel Bates  <dabates@apple.com>
2484
2485         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
2486         https://bugs.webkit.org/show_bug.cgi?id=137581
2487         <rdar://problem/18642906>
2488
2489         Reviewed by Simon Fraser.
2490
2491         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
2492         of the test that proceeded the currently running test.
2493
2494         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2495         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
2496         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
2497         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
2498
2499 2014-12-05  Jer Noble  <jer.noble@apple.com>
2500
2501         [WTF] MediaTime should support round-tripping from and to doubles.
2502         https://bugs.webkit.org/show_bug.cgi?id=139248
2503
2504         Reviewed by Eric Carlson.
2505
2506         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
2507         the MediaTimes after this change.
2508
2509         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2510         (WTF::operator<<):
2511         (TestWebKitAPI::TEST):
2512         * lldb/lldb_webkit.py:
2513         (WTFMediaTime_SummaryProvider):
2514         (WTFMediaTimeProvider.timeValueAsDouble):
2515         (WTFMediaTimeProvider.isIndefinite):
2516         (WTFMediaTimeProvider):
2517         (WTFMediaTimeProvider.hasDoubleValue):
2518
2519 2014-12-05  Anders Carlsson  <andersca@apple.com>
2520
2521         Add a private browsing mode to MiniBrowser
2522         https://bugs.webkit.org/show_bug.cgi?id=139308
2523
2524         Reviewed by Sam Weinig.
2525
2526         * MiniBrowser/mac/AppDelegate.m:
2527         (defaultConfiguration):
2528         (-[BrowserAppDelegate newWindow:]):
2529         (-[BrowserAppDelegate newPrivateWindow:]):
2530         * MiniBrowser/mac/MainMenu.xib:
2531         * MiniBrowser/mac/WK2BrowserWindowController.h:
2532         * MiniBrowser/mac/WK2BrowserWindowController.m:
2533         (-[WK2BrowserWindowController awakeFromNib]):
2534         (-[WK2BrowserWindowController initWithConfiguration:]):
2535         (-[WK2BrowserWindowController dealloc]):
2536         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2537
2538 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
2539
2540         Run http tests parallel
2541         https://bugs.webkit.org/show_bug.cgi?id=138958
2542
2543         Reviewed by Daniel Bates.
2544
2545         Remove the concept of "locked shard". Now http tests are just like any other tests.
2546         We start HTTP and WebSocket servers at the start if we need them, and terminate them
2547         when done with all the tests (not when the last http test runs, which is unnecessarily
2548         unpredictable).
2549
2550         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
2551         patch, they used to take over 15 minutes.
2552
2553         As part of the fix, we no longer pass the number of servers to Apache. I don't
2554         think that these parameters did what we wanted them to do; Apache handles the load
2555         just fine without them.
2556
2557         The change applies to all platforms. I fixed everything I could find on Mac, and
2558         Ossy told me that he's been running http tests in parallel for a long time. If
2559         there is increased instability for some ports, it will need to be fixed - there is
2560         generally nothing special about http tests at this point, and most code is
2561         cross-platform in WebKit2.
2562
2563         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2564         (LayoutTestRunner.__init__):
2565         (LayoutTestRunner.run_tests):
2566         (LayoutTestRunner.start_servers_with_lock):
2567         (LayoutTestRunner._handle_started_test):
2568         (Worker.handle):
2569         (Sharder.__init__):
2570         (Sharder.shard_tests):
2571         (Sharder._shard_every_file):
2572         (Sharder._shard_by_directory):
2573         (LayoutTestRunner._handle_finished_test_list): Deleted.
2574         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
2575         (Sharder._shard_in_two): Deleted.
2576         (Sharder): Deleted.
2577         (Sharder._resize_shards): Deleted.
2578         (Sharder._resize_shards.divide_and_round_up): Deleted.
2579         (Sharder._resize_shards.extract_and_flatten): Deleted.
2580         (Sharder._resize_shards.split_at): Deleted.
2581         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2582         (FakePrinter.print_workers_and_shards):
2583         (LayoutTestRunnerTests.test_servers_started.start_http_server):
2584         (LayoutTestRunnerTests.test_servers_started):
2585         (SharderTests.get_shards):
2586         (SharderTests.test_shard_by_dir):
2587         (SharderTests.test_shard_every_file):
2588         (SharderTests): Deleted.
2589         (SharderTests.test_shard_in_two): Deleted.
2590         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
2591         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
2592         (SharderTests.test_multiple_locked_shards): Deleted.
2593         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2594         (ManagerTest.test_needs_servers.get_manager):
2595         (ManagerTest.integration_test_needs_servers.get_manager):
2596         (ManagerTest.test_look_for_new_crash_logs.get_manager):
2597         (ManagerTest):
2598         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2599         (_set_up_derived_options):
2600         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2601         (RunTest.test_batch_size):
2602         (RunTest.test_max_locked_shards): Deleted.
2603         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2604         (LayoutTestApacheHttpd.__init__):
2605         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2606         (TestLayoutTestApacheHttpd.test_start_cmd):
2607         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2608         (Lighttpd.__init__):
2609         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2610         (HttpServerBase.__init__):
2611         * Scripts/webkitpy/layout_tests/views/printing.py:
2612         (Printer.print_workers_and_shards):
2613         * Scripts/webkitpy/port/base.py:
2614         (Port.default_child_processes):
2615         (Port.to.start_http_server):
2616         (Port.default_max_locked_shards): Deleted.
2617         * Scripts/webkitpy/port/port_testcase.py:
2618         (PortTestCase.make_port):
2619         (PortTestCase.test_default_max_locked_shards): Deleted.
2620         * Scripts/webkitpy/port/test.py:
2621         (TestPort.start_http_server):
2622
2623 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
2624
2625         Don't lock perf tests in run-webkit-tests
2626         https://bugs.webkit.org/show_bug.cgi?id=139264
2627
2628         Reviewed by Daniel Bates.
2629
2630         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2631         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2632         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2633         * Scripts/webkitpy/layout_tests/models/test_input.py:
2634         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2635
2636 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
2637
2638         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
2639         https://bugs.webkit.org/show_bug.cgi?id=139243
2640
2641         Reviewed by Anders Carlsson.
2642
2643         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
2644         chance to allow untrusted certificates.
2645
2646         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
2647         Set up more client objects for secondary windows. We may be able to share some of the
2648         code with main view creation function, but it's not exactly the same (notably, we
2649         do not focus a secondary window when it's done loading).
2650
2651 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
2652
2653         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
2654         https://bugs.webkit.org/show_bug.cgi?id=139071
2655
2656         Reviewed by Chris Fleizach.
2657
2658         Add string value for ATK_ROLE_STATIC in roleToString.
2659
2660         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2661
2662 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
2663
2664         check-webkit-style is confused by ternary expression inside first member initializer
2665         https://bugs.webkit.org/show_bug.cgi?id=136442
2666
2667         Reviewed by Csaba Osztrogonác.
2668
2669         * Scripts/webkitpy/style/checkers/cpp.py:
2670         (check_member_initialization_list):
2671
2672 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2673
2674         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
2675         https://bugs.webkit.org/show_bug.cgi?id=139220
2676
2677         Reviewed by Philippe Normand.
2678
2679         * gtk/jhbuild.modules:
2680         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
2681
2682 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2683
2684         Remove unused JSC runtime options
2685         https://bugs.webkit.org/show_bug.cgi?id=133070
2686
2687         Reviewed by Csaba Osztrogonác.
2688
2689         * Scripts/run-jsc-stress-tests:
2690
2691 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2692
2693         [EFL] Add subtle crypto to the build system
2694         https://bugs.webkit.org/show_bug.cgi?id=138612
2695
2696         Reviewed by Csaba Osztrogonác.
2697
2698         * Scripts/webkitperl/FeatureList.pm:
2699
2700 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
2701
2702         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
2703         https://bugs.webkit.org/show_bug.cgi?id=139005
2704
2705         Reviewed by Chris Fleizach.
2706
2707         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2708         Add mapping for ATK_ROLE_CAPTION to roleToString
2709
2710 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
2711
2712         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
2713         https://bugs.webkit.org/show_bug.cgi?id=139149
2714
2715         Reviewed by Anders Carlsson.
2716
2717         WebKit2 already cleared application caches between runs (although it wasn't entirely
2718         effective without WebCore changes in this patch).
2719
2720         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
2721
2722         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
2723         function is not implemented on Windows, see below).
2724
2725         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
2726         Ameded a FIXME.
2727
2728 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
2729
2730         Generalize PageActivityAssertionToken
2731         https://bugs.webkit.org/show_bug.cgi?id=139106
2732
2733         Reviewed by Sam Weinig.
2734
2735         Add an API test for WTF::RefCounter.
2736
2737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2738         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
2739         (TestWebKitAPI::TEST):
2740             - added RefCounter test.
2741
2742 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
2743
2744         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
2745         https://bugs.webkit.org/show_bug.cgi?id=139174
2746
2747         Reviewed by Simon Fraser.
2748
2749         * DumpRenderTree/TestRunner.cpp:
2750         * DumpRenderTree/TestRunner.h:
2751         Renamed testPathOrURL to testURL, because this variable always contains a URL.
2752
2753         * DumpRenderTree/mac/DumpRenderTree.mm:
2754         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
2755         (testPathFromURL): Moved from FrameLoadDelegate.mm.
2756         (runTest): Set crash reporter information here, as we know the exact test URL.
2757
2758         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2759         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
2760         reporter information here.
2761
2762         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2763         * DumpRenderTree/mac/TestRunnerMac.mm:
2764         Updated for testPathOrURL renaming.
2765
2766         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2767         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
2768         test URL until load starts, so save it into TestRunner now. A new TestRunner object
2769         is created for each test.
2770
2771         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2772         (WTR::TestRunner::testURL):
2773         (WTR::TestRunner::setTestURL):
2774         Make TestRunner know the test name. For now, it's good enough to have it once load
2775         starts, but if we ever need it earlier, we can send it with BeginTest message.
2776
2777         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2778         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2779         Use test URL, not currently loading URL for CrashReporter.
2780
2781         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
2782         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
2783         (WebKit1 already had it right).
2784
2785         * DumpRenderTree/win/DumpRenderTree.cpp:
2786         (sizeWebViewForCurrentTest):
2787         (runTest):
2788         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2789         (ResourceLoadDelegate::willSendRequest):
2790         Changed Windows DumpRenderTree to also use URL in TestRunner.
2791
2792 2014-12-02  Daniel Bates  <dabates@apple.com>
2793
2794         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
2795         https://bugs.webkit.org/show_bug.cgi?id=139143
2796
2797         Reviewed by David Kilzer.
2798
2799         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
2800         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
2801         crashes. Run-webkit-tests will record as crashing the test associated with the
2802         DumpRenderTree instance that wrote that string.
2803
2804         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
2805         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
2806         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
2807         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
2808         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
2809         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
2810         about a crash.
2811
2812         Additionally, update the crash message format written to standard error when LayoutTestRelay
2813         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
2814         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
2815         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
2816         when they crash in their test machinery logic/UI process code.
2817
2818         * DumpRenderTree/mac/DumpRenderTree.mm:
2819         (writeCrashedMessageOnFatalError): Added.
2820         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
2821         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
2822         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2823         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
2824         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
2825         the crash logs for WebKitTestRunner/DumpRenderTree.app.
2826         * Scripts/webkitpy/port/driver.py:
2827         (Driver.__init__): Update comment.
2828         (Driver._check_for_driver_crash): Ditto.
2829         * Scripts/webkitpy/port/ios.py:
2830         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
2831         regular expression. This constant is used as an optimization to avoid compiling the same
2832         regular expression across invocations of _get_crash_log().
2833         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
2834         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
2835         closer to where they are used.
2836
2837 2014-12-01  Anders Carlsson  <andersca@apple.com>
2838
2839         Remove WKBundleRemoveAllVisitedLinks
2840         https://bugs.webkit.org/show_bug.cgi?id=139163
2841
2842         Reviewed by Sam Weinig.
2843
2844         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
2845
2846         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2847         (WTR::InjectedBundle::beginTesting):
2848         * WebKitTestRunner/TestInvocation.cpp:
2849         (WTR::TestInvocation::invoke):
2850
2851 2014-12-02  Anders Carlsson  <andersca@apple.com>
2852
2853         Fix Windows build.
2854
2855         * DumpRenderTree/win/DumpRenderTree.cpp:
2856         (setAlwaysAcceptCookies):
2857
2858 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2859
2860         [EFL] Remove edbus dependency from jhbuild
2861         https://bugs.webkit.org/show_bug.cgi?id=139130
2862
2863         Reviewed by Gyuyoung Kim.
2864
2865         After http://trac.webkit.org/changeset/176555 we
2866         don't need it anymore.
2867
2868         * efl/jhbuild.modules:
2869
2870 2014-12-02  Philippe Normand  <pnormand@igalia.com>
2871
2872         [jhbuild] wrong Dependencies path
2873         https://bugs.webkit.org/show_bug.cgi?id=139176
2874
2875         Reviewed by Martin Robinson.
2876
2877         * Scripts/webkitpy/port/base.py:
2878         (Port._should_use_jhbuild):
2879
2880 2014-12-02  Philippe Normand  <pnormand@igalia.com>
2881
2882         [GStreamer] Bump internal jhbuild versions to 1.4.4
2883         https://bugs.webkit.org/show_bug.cgi?id=138866
2884
2885         Reviewed by Carlos Garcia Campos.
2886
2887         * gtk/jhbuild.modules:
2888         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
2889         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
2890         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
2891
2892 2014-12-01  Commit Queue  <commit-queue@webkit.org>
2893
2894         Unreviewed, rolling out r176566.
2895         https://bugs.webkit.org/show_bug.cgi?id=139124
2896
2897         It broke the GTK performance tests. (Requested by clopez on
2898         #webkit).
2899
2900         Reverted changeset:
2901
2902         "[GTK] Use GMainLoopSource in WebKitTestRunner"
2903         https://bugs.webkit.org/show_bug.cgi?id=138831
2904         http://trac.webkit.org/changeset/176566
2905
2906 2014-11-29  Anders Carlsson  <andersca@apple.com>
2907
2908         Crash when calling WKPageClose on the originated page from within createNewPage callback
2909         https://bugs.webkit.org/show_bug.cgi?id=139099
2910         <rdar://problem/19052564>
2911
2912         Reviewed by Sam Weinig.
2913
2914         Add a test.
2915
2916         * TestWebKitAPI/PlatformWebView.h:
2917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2918         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
2919         (TestWebKitAPI::runJavaScriptAlert):
2920         (TestWebKitAPI::createNewPage):
2921         (TestWebKitAPI::TEST):
2922         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
2923         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2924         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2925
2926 2014-11-28  Commit Queue  <commit-queue@webkit.org>
2927
2928         Unreviewed, rolling out r176564.
2929         https://bugs.webkit.org/show_bug.cgi?id=139093
2930
2931         massive failures on release test bot (Requested by philn on
2932         #webkit).
2933
2934         Reverted changeset:
2935
2936         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
2937         https://bugs.webkit.org/show_bug.cgi?id=138866
2938         http://trac.webkit.org/changeset/176564
2939
2940 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2941
2942         [GTK] Use GMainLoopSource in WebKitTestRunner
2943         https://bugs.webkit.org/show_bug.cgi?id=138831
2944
2945         Reviewed by Sergio Villar Senin.
2946
2947         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2948         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2949         (WTR::TestRunner::platformInitialize):
2950         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2951         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2952         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
2953         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2954         (WTR::TestController::notifyDone):
2955         (WTR::TestController::platformRunUntil):
2956         (WTR::cancelTimeout): Deleted.
2957
2958 2014-11-24  Philippe Normand  <pnormand@igalia.com>
2959
2960         [GStreamer] Bump internal jhbuild versions to 1.4.4
2961         https://bugs.webkit.org/show_bug.cgi?id=138866
2962
2963         Reviewed by Carlos Garcia Campos.
2964
2965         * gtk/jhbuild.modules:
2966         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
2967         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
2968         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
2969
2970 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2971
2972         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
2973         https://bugs.webkit.org/show_bug.cgi?id=138834
2974
2975         Reviewed by Sergio Villar Senin.
2976
2977         It makes everyting simpler and the tests run faster too, since we
2978         don't need to spawn the private bus and wait until the DBus name
2979         is registered. The web extension registers a new JavaSCript class
2980         with a status method to run the tests, similar to the DBus
2981         method. In the UI process side, tests use webkit_web_view_run_java_script()
2982         instead of sending a DBus message.
2983
2984         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2985         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
2986         (WebKitDOMNodeFilterTest::create):
2987         (WebKitDOMNodeFilterTest::testTreeWalker):
2988         (WebKitDOMNodeFilterTest::testNodeIterator):
2989         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
2990         (WebKitDOMNodeFilterTest::runTest): Deleted.
2991         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2992         (WebKitDOMNodeTest::create):
2993         (WebKitDOMNodeTest::testHierarchyNavigation):
2994         (WebKitDOMNodeTest::testInsertion):
2995         (WebKitDOMNodeTest::testTagNames):
2996         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
2997         (WebKitDOMNodeTest::runTest): Deleted.
2998         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
2999         (WebKitDOMXPathNSResolverTest::create):
3000         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3001         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3002         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
3003         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
3004         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3005         (WebKitFrameTest::create):
3006         (WebKitFrameTest::testMainFrame):
3007         (WebKitFrameTest::testURI):
3008         (WebKitFrameTest::testJavaScriptContext):
3009         (WebKitFrameTest::webPageFromArgs): Deleted.
3010         (WebKitFrameTest::runTest): Deleted.
3011         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3012         (testWebKitDOMNodeHierarchyNavigation):
3013         (testWebKitDOMNodeInsertion):
3014         (testWebKitDOMNodeTagNames):
3015         (beforeAll):
3016         (afterAll):
3017         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
3018         (runTest):
3019         (beforeAll):
3020         (afterAll):
3021         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
3022         (testWebKitDOMXPathNSResolverNative):
3023         (testWebKitDOMXPathNSResolverCustom):
3024         (beforeAll):
3025         (afterAll):
3026         (runTest): Deleted.
3027         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
3028         (webkitFrameTestRun):
3029         (beforeAll):
3030         (afterAll):
3031         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3032         (testsMap):
3033         (WebProcessTest::add):
3034         (WebProcessTest::create):
3035         (runTest):
3036         (windowObjectClearedCallback):
3037         (webkit_web_extension_initialize):
3038         (methodCallCallback): Deleted.
3039         (webkit_web_extension_initialize_with_user_data): Deleted.
3040         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3041         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
3042         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
3043         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3044         (WebViewTest::runWebProcessTest):
3045         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3046
3047 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
3048
3049         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
3050         https://bugs.webkit.org/show_bug.cgi?id=139086
3051
3052         Reviewed by Gyuyoung Kim.
3053
3054         * efl/jhbuild.modules:
3055         * efl/patches/libseccomp-pick-up-CC.patch: Added.
3056
3057 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
3058
3059         [EFL] Add warning if CMake version is too old for building with ninja.
3060         https://bugs.webkit.org/show_bug.cgi?id=139055
3061
3062         Reviewed by Gyuyoung Kim.
3063
3064         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
3065         that version in their repositories.
3066
3067         * efl/install-dependencies:
3068
3069 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
3070
3071         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
3072         https://bugs.webkit.org/show_bug.cgi?id=139044
3073
3074         Reviewed by Chris Fleizach.
3075
3076         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
3077         The proposed solution will enable the use of this method for the object table.
3078         Existing test shows the result.
3079
3080         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3081         (WTR::AccessibilityUIElement::columnHeaders):
3082
3083 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
3084
3085         [EFL] Remove E_Dbus dependency
3086         https://bugs.webkit.org/show_bug.cgi?id=136355
3087
3088         Reviewed by Gyuyoung Kim.
3089
3090         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
3091
3092 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
3093
3094         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
3095         https://bugs.webkit.org/show_bug.cgi?id=139047
3096
3097         Reviewed by Carlos Garcia Campos.
3098
3099         * efl/jhbuild.modules:
3100         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
3101         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
3102         * gtk/jhbuild-optional.modules:
3103         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
3104         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
3105
3106 2014-11-25  Tanay C  <tanay.c@samsung.com>
3107
3108         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
3109         https://bugs.webkit.org/show_bug.cgi?id=138090
3110
3111         Reviewed by Carlos Garcia Campos.
3112
3113         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
3114         (browserWindowZoomIn): Added.
3115         (browserWindowZoomOut): Added.
3116         (scrollEventCallback): Added.
3117         (zoomInCallback): Modified.
3118         (zoomOutCallback): Modified.
3119         (browserWindowConstructed): Modified.
3120
3121 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
3122
3123         [EFL] REGRESSION(r176514): It made performance tests fail
3124         https://bugs.webkit.org/show_bug.cgi?id=139037
3125
3126         Reviewed by Gyuyoung Kim.
3127
3128         * Scripts/webkitpy/port/efl.py:
3129         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
3130         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
3131         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
3132
3133 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3134
3135         [GTK] update-webkitgtk-libs fails to build fontconfig
3136         https://bugs.webkit.org/show_bug.cgi?id=139032
3137
3138         Reviewed by Martin Robinson.
3139
3140         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
3141         fontconfig will try to generate documentation and fail.
3142
3143         * gtk/install-dependencies:
3144
3145 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3146
3147         Unreviewed. Fix GTK+ make distcheck.
3148
3149         * gtk/manifest.txt: Remove deleted files.
3150
3151 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
3152
3153         [EFL] Utilize Eail library to support accessibility in EFL
3154         https://bugs.webkit.org/show_bug.cgi?id=137742
3155
3156         Reviewed by Gyuyoung Kim.
3157
3158         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
3159
3160         * efl/jhbuild-optional.modules: Added.
3161         * efl/jhbuild.modules:
3162
3163 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3164
3165         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
3166         https://bugs.webkit.org/show_bug.cgi?id=139023
3167
3168         Reviewed by Sergio Villar Senin.
3169
3170         Rename WebKitWebView/default-context as WebKitWebView/web-context
3171         and check we are always using the right context for new web views.
3172
3173         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3174         (testWebViewWebContext):
3175         (beforeAll):
3176         (testWebViewDefaultContext): Deleted.
3177
3178 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3179
3180         [GTK] Add API to override the default local storage directory
3181         https://bugs.webkit.org/show_bug.cgi?id=138828
3182
3183         Reviewed by Gustavo Noronha Silva.
3184
3185         Add test to check that the local storage directory is created at
3186         the path given on construction.
3187
3188         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3189         (testWebContextConfiguration):
3190         (beforeAll):
3191         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3192         (Test::Test):
3193         (Test::~Test): Deleted.
3194
3195 2014-11-21  Zalan Bujtas  <zalan@apple.com>
3196
3197         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
3198         https://bugs.webkit.org/show_bug.cgi?id=138981
3199
3200         Reviewed by Simon Fraser.
3201
3202         * MiniBrowser/mac/SettingsController.h:
3203         * MiniBrowser/mac/SettingsController.m:
3204         (-[SettingsController _populateMenu]):
3205         (-[SettingsController validateMenuItem:]):
3206         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
3207         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
3208         * MiniBrowser/mac/WK1BrowserWindowController.m:
3209         (-[WK1BrowserWindowController didChangeSettings]):
3210         * MiniBrowser/mac/WK2BrowserWindowController.m:
3211         (-[WK2BrowserWindowController didChangeSettings]):
3212
3213 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
3214
3215         Remove http lock code from webkitperl
3216         https://bugs.webkit.org/show_bug.cgi?id=138959
3217
3218         Reviewed by Alexey Proskuryakov.
3219
3220         * Scripts/webkitperl/httpd.pm:
3221         (cleanUp):
3222         (extractLockNumber): Deleted.
3223         (getLockFiles): Deleted.
3224         (getNextAvailableLockNumber): Deleted.
3225         (getLockNumberForCurrentRunning): Deleted.
3226         (waitForHTTPDLock): Deleted.
3227         (scheduleHttpTesting): Deleted.
3228         (getWaitTime): Deleted.
3229
3230 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
3231
3232         [EFL] The option value of fixed layout is false in MiniBrowser
3233         https://bugs.webkit.org/show_bug.cgi?id=138830
3234
3235         Reviewed by Gyuyoung Kim.
3236
3237         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
3238
3239         * MiniBrowser/efl/main.c:
3240
3241 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
3242
3243         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
3244         https://bugs.webkit.org/show_bug.cgi?id=138871
3245
3246         Reviewed by Carlos Garcia Campos.
3247
3248         Add a test case for the convenience API for posting user messages
3249         added to the DOM bindings.
3250
3251         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3252         (testUserContentManagerMessageFromConvenienceDOMBindings):
3253         (beforeAll):
3254         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3255         (documentLoadedCallback):
3256
3257 2014-11-19  Dana Burkart  <dburkart@apple.com>
3258
3259         Work around the fact that different masters may have different names for their codebases.
3260         https://bugs.webkit.org/show_bug.cgi?id=138878
3261
3262         Reviewed by Mark Rowe.
3263
3264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3265         (parseRevisionProperty): Changed.
3266         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
3267         opensource / internal codebase naming convention.
3268
3269 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
3270
3271         AX: Screen braille input doesn't work on forms.
3272         https://bugs.webkit.org/show_bug.cgi?id=138804
3273
3274         Unreviewed build fix.
3275
3276         * DumpRenderTree/AccessibilityUIElement.cpp:
3277         (AccessibilityUIElement::setValue):
3278
3279 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
3280
3281         AX: Screen braille input doesn't work on forms.
3282         https://bugs.webkit.org/show_bug.cgi?id=138804
3283
3284         Reviewed by Mario Sanchez Prada.
3285
3286         Add a method to setValue through the AX API in DRT.
3287
3288         * DumpRenderTree/AccessibilityUIElement.cpp:
3289         (setValueCallback):
3290         (AccessibilityUIElement::getJSClass):
3291         * DumpRenderTree/AccessibilityUIElement.h:
3292         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3293         (AccessibilityUIElement::setValue):
3294         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3295         (AccessibilityUIElement::setValue):
3296
3297 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
3298
3299         Remove the WinCairo buildbot
3300         https://bugs.webkit.org/show_bug.cgi?id=138805
3301
3302         Reviewed by Alex Christensen.
3303
3304         * BuildSlaveSupport/build.webkit.org-config/config.json:
3305         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3306         (appendCustomBuildFlags):
3307         * BuildSlaveSupport/test-result-archive:
3308         (archiveTestResults):
3309
3310 2014-11-18  Daniel Bates  <dabates@apple.com>
3311
3312         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3313         SPI are not available in public SDK
3314         https://bugs.webkit.org/show_bug.cgi?id=138802
3315
3316         Reviewed by David Kilzer.
3317
3318         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
3319
3320         * DumpRenderTree/mac/CheckedMalloc.cpp:
3321
3322 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3323
3324         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
3325
3326         Forgot to fix this test before landing.
3327
3328         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3329         (testWebViewDefaultContext):
3330
3331 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3332
3333         [GTK] Add API to create a WebKitWebContext
3334         https://bugs.webkit.org/show_bug.cgi?id=138826
3335
3336         Reviewed by Gustavo Noronha Silva.
3337
3338         Use a different WebKitWebContext for every test to ensure test
3339         cases are independent to each other. Tests using DBus to
3340         communicate with the injected bundle extension now use a unique
3341         name for the well known DBus name.
3342
3343         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3344         (beforeAll): Remove comment about the order of the tests and
3345         move the success test before the failed one now that tests don't
3346         depend on each others.
3347         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3348         (beforeAll): Remove call to set the web extensions directory,
3349         since this is now done for all test in the Test constructor.
3350         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
3351         (beforeAll): Do not create a temporary directory, a temporary data
3352         directory is now created for all tests.
3353         (afterAll):
3354         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3355         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
3356         to the web process test runner.
3357         (testWebKitDOMNodeInsertion): Ditto.
3358         (testWebKitDOMNodeTagNames): Ditto.
3359         (beforeAll): Remove call to set the web extensions directory.
3360         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
3361         (runTest): Pass the web extension ID to the web process test runner.
3362         (beforeAll): Remove call to set the web extensions directory.
3363         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
3364         (runTest): Pass the web extension ID to the web process test runner.
3365         (beforeAll): Remove call to set the web extensions directory.
3366         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3367         (createFileAtDestination): Use Test::dataDirectory() as base dir
3368         for temporary files.
3369         (beforeAll): Do not create a temporary directory.
3370         (afterAll):
3371         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
3372         (webkitFrameTestRun): Pass the web extension ID to the web process
3373         test runner.
3374         (beforeAll): Remove call to set the web extensions directory.
3375         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3376         (beforeAll): Remove call to set the web extensions directory.
3377         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3378         (testProcessPerWebView): Use local member instead of global variable.
3379         (testMultiprocessWebViewCreateReadyClose): Ditto.
3380         (beforeAll): Do not connect to initialize-web-extensions, Test now
3381         connects to the signal for all tests and calls a virtual method
3382         that test can override.
3383         (afterAll):
3384         (initializeWebExtensions): Deleted.
3385         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
3386         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
3387         for temporary files.
3388         (beforeAll): Do not create a temporary directory.
3389         (afterAll):
3390         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3391         (beforeAll): Remove call to set the web extensions directory.
3392         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3393         (beforeAll): Remove comment about the tests order.
3394         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3395         (testWebExtensionGetTitle): Build the DBus service name using the
3396         web extension ID.
3397         (testDocumentLoadedSignal): Ditto.
3398         (testWebKitWebViewProcessCrashed): Ditto.
3399         (testWebExtensionIsolatedWorld): Ditto.
3400         (beforeAll): Remove initialization-user-data test, since now all
3401         tests are passing user data to the web extension.
3402         (testWebExtensionInitializationUserData): Deleted.
3403         (initializeWebExtensions): Deleted.
3404         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3405         (testSetDirectory): Use the web context member inherited from Test.
3406         (testClearDatabase): Ditto.
3407         (testGetFaviconURI): Ditto.
3408         (beforeAll): Do not create a temporary directory.
3409         (afterAll):
3410         (webkitFaviconDatabaseFinalizedCallback): Deleted.
3411         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3412         (UserContentManagerTest::UserContentManagerTest):
3413         (beforeAll): Remove call to set the web extensions directory.
3414         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3415         (testWebContextDefault): Check also that a newly create web
3416         context is not the default web context.
3417         (testWebContextSpellChecker): Use the web context member inherited
3418         from Test.
3419         (testWebContextLanguages): Ditto.
3420         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3421         (methodCallCallback): Remove GetInitializationUserData method.
3422         (webkit_web_extension_initialize_with_user_data): Always create
3423         the DBus name using the user data provided.
3424         (makeBusName): Deleted.
3425         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3426         (webkit_web_extension_initialize_with_user_data): Create the DBus
3427         name using the user data provided.
3428         (webkit_web_extension_initialize): Deleted.
3429         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
3430         (Test::dataDirectory): Return the temporary data directory.
3431         (removeNonEmptyDirectory): Also remove directories recursively.
3432         (main): Remove the disk cache directory initialization, since this
3433         is now done in the Test constructor.
3434         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3435         (Test::initializeWebExtensionsCallback): Call the virtual method
3436         initializeWebExtensions()
3437         (Test::Test): Create a new WebKitWebContext and initialize it.
3438         (Test::~Test): Disconnect initialize-web-extensions signal.
3439         (Test::initializeWebExtensions): Set the web extensions directory
3440         and user data.
3441         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
3442         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
3443         (WebProcessTestRunner::runTest): Build the DBus proxy using a
3444         unique name created with the Test web extension ID.
3445         (WebProcessTestRunner::proxy): Deleted.
3446         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
3447         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3448         (WebViewTest::WebViewTest): Create the web view with the Test web
3449         context.
3450         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
3451         content manager parameter to the constructor.
3452
3453 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
3454
3455         [GTK] Mesa build fails over llvm-3.5
3456         https://bugs.webkit.org/show_bug.cgi?id=138825
3457
3458         Reviewed by Gustavo Noronha Silva.
3459
3460         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
3461
3462         * gtk/jhbuild.modules:
3463         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
3464
3465 2014-11-17  Daniel Bates  <dabates@apple.com>
3466
3467         Unreviewed, rolling out r176232.
3468
3469         Broke the Mac build. Will investigate offline.
3470
3471         Reverted changeset:
3472
3473         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
3474         MobileGestalt"
3475         https://bugs.webkit.org/show_bug.cgi?id=138802
3476         http://trac.webkit.org/changeset/176232
3477
3478 2014-11-17  Daniel Bates  <dabates@apple.com>
3479
3480         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3481         SPI are not available in public SDK
3482         https://bugs.webkit.org/show_bug.cgi?id=138802
3483
3484         Reviewed by David Kilzer.
3485
3486         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
3487
3488         * DumpRenderTree/mac/CheckedMalloc.cpp:
3489
3490 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
3491
3492         Having 30+ flaky failures breaks EWS
3493         https://bugs.webkit.org/show_bug.cgi?id=138743
3494
3495         Reviewed by Alexey Proskuryakov.
3496
3497         Adds tests to ensure that the problem has been solved.
3498         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3499         (test_first_failure_limit):
3500         (test_first_failure_limit_with_some_tree_redness):
3501         (test_second_failure_limit):
3502         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
3503         (test_first_and_second_failure_limit):
3504         (test_first_and_clean_failure_limit):
3505         (test_first_second_and_clean_failure_limit):
3506         (test_very_red_tree_retry): Deleted.
3507         Really this was renamed to test_first_second_and_clean_failure_limit.
3508         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3509         Makes the appropriate changes to PatchAnalysisTask to make sure that
3510         even when the first test run hits the failure limit, it will still try
3511         a second run.
3512         (PatchAnalysisTask._results_failed_different_tests):
3513         (PatchAnalysisTask._test_patch):
3514         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
3515
3516 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
3517
3518         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
3519         https://bugs.webkit.org/show_bug.cgi?id=136018
3520
3521         Reviewed by Carlos Garcia Campos.
3522
3523         It is possible that the order of -L arguments in the output of
3524         pkg-config is wrong, which causes the linker to find the wrong
3525         version (usually older version) of libraries when running
3526         gtkdoc-scangobj.
3527
3528         * gtk/gtkdoc.py:
3529         (GTKDoc._run_gtkdoc_scangobj):
3530
3531 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3532
3533         Bump EFL version to 1.12.0
3534         https://bugs.webkit.org/show_bug.cgi?id=138733
3535
3536         Reviewed by Gyuyoung Kim.
3537
3538         * efl/jhbuild.modules:
3539
3540 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
3541
3542         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
3543         https://bugs.webkit.org/show_bug.cgi?id=138771
3544
3545         Reviewed by Chris Fleizach.
3546
3547         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
3548
3549         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3550
3551 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
3552
3553         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
3554         https://bugs.webkit.org/show_bug.cgi?id=138767
3555
3556         Reviewed by Chris Fleizach.
3557
3558         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
3559
3560         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3561
3562 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
3563
3564         Add shortcut macros to Mac TestExpectations
3565         https://bugs.webkit.org/show_bug.cgi?id=138729
3566
3567         Reviewed by Simon Fraser.
3568
3569         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
3570         Add version macros for current OS versions.
3571
3572 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
3573
3574         https://bugs.webkit.org/show_bug.cgi?id=138628
3575         A patch that doesn't apply is stuck in commit queue
3576
3577         Rubber-stamped by David Kilzer.
3578
3579         This also hopefully fixes other issues:
3580         - a patch that has cq+ flag set by a non-committer kills commit queue;
3581         - EWS never reports failing tests, and keeps spinning instead.
3582
3583         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3584         (Bugzilla.set_flag_on_attachment):
3585         (Bugzilla.obsolete_attachment):
3586         Apply the fix from r174797 to more places.
3587
3588 2014-11-13  Dan Bernstein  <mitz@apple.com>
3589
3590         Policy client not called for navigations through the page cache
3591         https://bugs.webkit.org/show_bug.cgi?id=138703
3592
3593         Reviewed by Alexey Proskuryakov.
3594
3595         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3596         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
3597         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3598
3599 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
3600
3601         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
3602         https://bugs.webkit.org/show_bug.cgi?id=137867
3603
3604         Reviewed by Chris Fleizach.
3605
3606         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
3607         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
3608         able to test for the presence of ATK_ROLE_INVALID.
3609
3610         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3611         (WTR::AccessibilityUIElement::role):
3612
3613 2014-11-13  Juergen Ributzka  <juergen@apple.com>
3614
3615         Update the "combineModules" script to handel more LLVM metadata.
3616         https://bugs.webkit.org/show_bug.cgi?id=138514
3617
3618         Reviewed by Filip Pizlo.
3619
3620         * ReducedFTL/combineModules.rb:
3621
3622 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
3623
3624         Allow constructing a base PassRef with a derived Ref
3625         https://bugs.webkit.org/show_bug.cgi?id=138701
3626
3627         Reviewed by Andreas Kling
3628
3629         * TestWebKitAPI/Tests/WTF/Ref.cpp:
3630         (TestWebKitAPI::passWithPassRef):
3631         (TestWebKitAPI::passWithPassRefPtr):
3632         (TestWebKitAPI::TEST):
3633
3634 2014-11-05  Ada Chan  <adachan@apple.com>
3635
3636         Implement new plug-in API for muting plug-ins
3637         https://bugs.webkit.org/show_bug.cgi?id=138105
3638
3639         Reviewed by Anders Carlsson.
3640
3641         Add a new plug-in test for the mute API.
3642
3643         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3644         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
3645         (SetMuted::SetMuted):
3646         (SetMuted::isMuted):
3647         (SetMuted::cachedIsMuted):
3648         (SetMuted::ScriptableObject::hasProperty):
3649         (SetMuted::ScriptableObject::getProperty):
3650         (SetMuted::ScriptableObject::pluginTest):
3651         (SetMuted::NPP_New):
3652         (SetMuted::NPP_GetValue):
3653         (SetMuted::NPP_SetValue):
3654
3655 2014-11-12  Philippe Normand  <pnormand@igalia.com>
3656
3657         Unreviewed, GTK gardening.
3658
3659         * Scripts/run-gtk-tests:
3660         (TestRunner): Skip the UserMediaBasic test because it depends on
3661         constraints validation which is going to be fixed in bug #136449.
3662
3663 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3664
3665         [GTK] Expose user script messages to GObject DOM bindings
3666         https://bugs.webkit.org/show_bug.cgi?id=138411
3667
3668         Reviewed by Philippe Normand.
3669
3670         Add a test case to check that user script messages sent using the
3671         DOM bindings API are also received in the UI process.
3672
3673         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3674         (UserScriptMessageTest::waitUntilMessageReceived):
3675         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
3676         (testUserContentManagerScriptMessageFromDOMBindings):
3677         (beforeAll):
3678         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3679         (documentLoadedCallback):
3680
3681 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3682
3683         Unreviewed. Fix GTK+ clean build after r175930.
3684
3685         Partial rollout of r175930 to not build the new unit test that
3686         broke clean builds in GTK+ port.
3687
3688         * TestWebKitAPI/PlatformGTK.cmake:
3689
3690 2014-09-01  Philippe Normand  <pnormand@igalia.com>
3691
3692         [WK2] UserMediaClient support
3693         https://bugs.webkit.org/show_bug.cgi?id=123158
3694
3695         Reviewed by Benjamin Poulain.
3696
3697         Simple API test for the UserMedia permission request API. The
3698         required test infrastructure is also added, inspired by the
3699         Geolocation infrastructure.
3700
3701         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
3702         Permission request.
3703         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
3704         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
3705         (TestWebKitAPI::TEST):
3706         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
3707         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
3708         helper method to set the permission request result without user interaction.
3709         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
3710         (WTR::InjectedBundle::setUserMediaPermission):
3711         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
3712         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
3713         (WTR::TestRunner::setUserMediaPermission):
3714         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
3715         * WebKitTestRunner/TestController.cpp:
3716         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
3717         request handler.
3718         (WTR::TestController::createOtherPage): Enable the new UserMedia
3719         permission request handler.
3720         (WTR::TestController::createWebViewWithOptions): Ditto.
3721         (WTR::TestController::resetPreferencesToConsistentValues): Enable
3722         MediaStream support, this is needed for getUserMedia.
3723         (WTR::TestController::resetStateToConsistentValues): clear
3724         UserMedia permissions list and flags.
3725         (WTR::TestController::setUserMediaPermission): Set permission
3726         request result and distpatch it.
3727         (WTR::TestController::handleUserMediaPermissionRequest): Save
3728         request and dispatch it.
3729         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
3730         Dispatch cached permission requests.
3731         * WebKitTestRunner/TestController.h:
3732         * WebKitTestRunner/TestInvocation.cpp:
3733         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3734
3735 2014-11-11  David Kilzer  <ddkilzer@apple.com>
3736
3737         webkit-patch --suggest-reviewers is broken with newer versions of git
3738         <http://webkit.org/b/138627>
3739
3740         Reviewed by Michael Saboff with feedback from Daniel Bates.
3741
3742         * Scripts/webkitpy/common/checkout/scm/git.py:
3743         (Git._changes_files_for_commit): Strip blank lines instead of
3744         assuming there is always a blank line at the beginning of the
3745         list.
3746
3747 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
3748
3749         DRT and WKTR touch disk cache
3750         https://bugs.webkit.org/show_bug.cgi?id=138622
3751
3752         Reviewed by Geoffrey Garen.
3753
3754         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
3755         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
3756         because this function uses the shared cache.
3757
3758         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
3759         Create an empty shared cache to prevent a default one from being created on disk.
3760
3761 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
3762
3763         [CSS Grid Layout] Limit the size of explicit/implicit grid
3764         https://bugs.webkit.org/show_bug.cgi?id=136217
3765
3766         Reviewed by Andreas Kling.
3767
3768         Added a new unit test for the CSS parser. Right now it only checks
3769         that we properly clamp the maximum number of tracks on a grid to a
3770         maximum of 1 million.
3771
3772         * TestWebKitAPI/CMakeLists.txt:
3773         * TestWebKitAPI/PlatformEfl.cmake:
3774         * TestWebKitAPI/PlatformGTK.cmake:
3775         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3776         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
3777         (TestWebKitAPI::computeNumberOfTracks): Helper function.
3778         (TestWebKitAPI::TEST): Added a
3779         CSSPropertyParserTest.GridTrackLimits test case.
3780
3781 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3782
3783         webkitpy test fix after r175867
3784         https://bugs.webkit.org/show_bug.cgi?id=138607
3785
3786         Reviewed by Philippe Normand.
3787
3788         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
3789         (GDBCrashLogGeneratorTest.test_generate_crash_log):
3790
3791 2014-11-10  Philippe Normand  <pnormand@igalia.com>
3792
3793         webkitpy: demangle C++ symbols from crash log stderr
3794         https://bugs.webkit.org/show_bug.cgi?id=138565
3795
3796         Reviewed by Alexey Proskuryakov.
3797
3798         * Scripts/webkitpy/port/linux_get_crash_log.py:
3799         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
3800         with c++filt.
3801
3802 2014-11-10  Philippe Normand  <pnormand@igalia.com>
3803
3804         [GTK] fix up the GDB backtrace report tool
3805         https://bugs.webkit.org/show_bug.cgi?id=138564
3806
3807         Reviewed by Carlos Garcia Campos.
3808
3809         * Scripts/webkitpy/port/gtk.py:
3810         (GtkPort._get_crash_log): Match the process name reported by the
3811         driver with the GTK port WebProcess executable filename.
3812         * Scripts/webkitpy/port/linux_get_crash_log.py:
3813         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
3814         program.
3815         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
3816         pattern to workaround the 16 characters size limit of %e.
3817
3818 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
3819
3820         Unreviewed, moved myself to the list of committers.
3821
3822         * Scripts/webkitpy/common/config/contributors.json:
3823
3824 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3825
3826         [EFL] Fix the test font path after r175555.
3827
3828         Reviewed by Csaba Osztrogonác.
3829
3830         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
3831
3832 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
3833
3834         Fix the exception fuzz helper to generate targets in the correct range
3835         https://bugs.webkit.org/show_bug.cgi?id=138544
3836
3837         Reviewed by Filip Pizlo.
3838
3839         Currently, the script generates exception fuzz targets in the range of
3840         0..($checkCount-1). However, target 0 is never hit, while target 1 is
3841         always outside of the outermost try block of the tests, which therefore
3842         prints unexpected output and results in false failures when fired at.
3843         Additionally, target $checkCount is never generated.
3844
3845         This patch fixes the script to generate targets in the range of
3846         2..$checkCount.
3847
3848         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3849
3850 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
3851
3852         make-passwords-json.py should generarate everything needed for testing
3853         https://bugs.webkit.org/show_bug.cgi?id=138503
3854
3855         Reviewed by Ryosuke Niwa.
3856
3857         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
3858         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
3859         Additionally generate auth.json, credentials.cfg and committers.cfg too.
3860         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
3861         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3862         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
3863         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
3864
3865 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3866
3867         [GTK] generate-gtkdoc should ignore invalid files
3868         https://bugs.webkit.org/show_bug.cgi?id=138542
3869
3870         Reviewed by Darin Adler.
3871
3872         * gtk/generate-gtkdoc:
3873         (files_to_ignore.file_should_be_ignored): Return True to ignore
3874         invalid files.
3875
3876 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
3877
3878         Delete cookies between tests
3879         https://bugs.webkit.org/show_bug.cgi?id=138528
3880
3881         Reviewed by Sam Weinig.
3882
3883         * DumpRenderTree/mac/DumpRenderTree.mm:
3884         (resetWebPreferencesToConsistentValues):
3885         * WebKitTestRunner/TestController.cpp:
3886         (WTR::TestController::resetPreferencesToConsistentValues):
3887         Do it.
3888
3889         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3890         (WTR::InjectedBundle::beginTesting):
3891         Added a FIXME.
3892
3893 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3894
3895         [GTK] Run layout tests using the network process
3896         https://bugs.webkit.org/show_bug.cgi?id=138428
3897
3898         Reviewed by Martin Robinson.
3899
3900         Shared secondary process is the default in the GTK+ port, but we
3901         should run the tests using the network process to ensure
3902         everything works with the network process. In the future, the
3903         shared secondary process model might be a special case of multiple
3904         processes with 1 as maximum number of processes, but always using
3905         the network process.
3906
3907         * WebKitTestRunner/TestController.cpp:
3908         (WTR::TestController::initialize):
3909
3910 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3911
3912         [GTK] Allow to create a view with a related page in WTR
3913         https://bugs.webkit.org/show_bug.cgi?id=138501
3914
3915         Reviewed by Martin Robinson.
3916
3917         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3918         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
3919         related page to WKViewCreate.
3920         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3921         (WTR::PlatformWebView::PlatformWebView): Pass the given related
3922         page to WKViewCreate.
3923
3924 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3925
3926         WTR crashes after running a test when NetworkProcess enabled
3927         https://bugs.webkit.org/show_bug.cgi?id=138500
3928
3929         Reviewed by Alexey Proskuryakov.
3930
3931         WebNotificationProvider destructor is calling
3932         WKNotificationManagerSetProvider, but m_notificationManager is
3933         null because removeNotificationManager was already called.
3934
3935         * WebKitTestRunner/WebNotificationProvider.cpp:
3936         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
3937         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
3938
3939 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
3940
3941         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
3942         regarding incorrect call to PatchAnalysisTask.report_failure
3943         https://bugs.webkit.org/show_bug.cgi?id=138229
3944
3945         Reviewed by Daniel Bates.
3946
3947         * Scripts/webkitpy/common/net/layouttestresults.py:
3948         Makes sure test_results returns a list.
3949         (LayoutTestResults.test_results):
3950         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3951         Makes unit tests also check to make sure
3952         task.results_from_patch_test_run() and
3953         task.results_from_test_run_without_patch return instances of
3954         LayoutTestResults.
3955         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
3956         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3957         Condenses duplicate code into _should_defer_patch_or_throw, and
3958         removes the now-unused _clean_tree_results member.
3959         (PatchAnalysisTask.__init__):
3960         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
3961         (PatchAnalysisTask._should_defer_patch_or_throw):
3962         (PatchAnalysisTask._test_patch):
3963         (PatchAnalysisTask.results_from_patch_test_run):
3964         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
3965         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3966         Removes needless call to results_from_test_run_without_patch
3967         (AbstractEarlyWarningSystem._failing_tests_message):
3968         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3969         Changes order of test failure messages to be in the order that they
3970         appear.
3971         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
3972         * Scripts/webkitpy/tool/commands/queues.py:
3973         Removes needless call to results_from_test_run_without_patch.
3974         (CommitQueue._failing_tests_message):
3975         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3976         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
3977
3978 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
3979
3980         Unreviewed. Reorder my e-mail addresses in contributors.json
3981
3982         * Scripts/webkitpy/common/config/contributors.json:
3983
3984 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
3985
3986         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
3987         https://bugs.webkit.org/show_bug.cgi?id=138475
3988
3989         Reviewed by Ryosuke Niwa.
3990
3991         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
3992         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
3993         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
3994         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
3995
3996         * Scripts/webkitpy/common/checkout/scm/git.py:
3997         (Git._run_git_svn_find_rev):
3998         Add comment mentioning that svn_revisions need to begin with 'r'.
3999         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
4000         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
4001         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
4002
4003 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4004
4005         [GTK] Add context menu API to Web Process Extensions
4006         https://bugs.webkit.org/show_bug.cgi?id=138311
4007
4008         Reviewed by Gustavo Noronha Silva.
4009
4010         Add tests cases for WebKitWebPage::context-menu signal.
4011
4012         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
4013         (testContextMenuWebExtensionMenu):
4014         (testContextMenuWebExtensionNode):
4015         (beforeAll):
4016         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
4017         (serializeContextMenu):
4018         (serializeNode):
4019         (contextMenuCallback):
4020         (pageCreatedCallback):
4021
4022 2014-11-06  Commit Queue  <commit-queue@webkit.org>
4023
4024         Unreviewed, rolling out r175690.
4025         https://bugs.webkit.org/show_bug.cgi?id=138460
4026
4027         We are not ready to run layout tests using the network process
4028         yet (Requested by KaL on #webkit).
4029
4030         Reverted changeset:
4031
4032         "[GTK] Run layout tests using the network process"
4033         https://bugs.webkit.org/show_bug.cgi?id=138428
4034         http://trac.webkit.org/changeset/175690
4035
4036 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4037
4038         [GTK] Run layout tests using the network process
4039         https://bugs.webkit.org/show_bug.cgi?id=138428
4040
4041         Reviewed by Martin Robinson.
4042
4043         Shared secondary process is the default in the GTK+ port, but we
4044         should run the tests using the network process to ensure
4045         everything works with the network process. In the future, the
4046         shared secondary process model might be a special case of multiple
4047         processes with 1 as maximum number of processes, but always using
4048         the network process.
4049
4050         * WebKitTestRunner/TestController.cpp:
4051         (WTR::TestController::initialize):
4052
4053 2014-11-05  Dan Bernstein  <mitz@apple.com>
4054
4055         Remove the unused deletion UI feature
4056         https://bugs.webkit.org/show_bug.cgi?id=138442
4057
4058         Rubber-stamped by Alexey Proskuryakov.
4059
4060         * DumpRenderTree/mac/EditingDelegate.mm:
4061         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
4062         delegate method that’s been removed.
4063
4064 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
4065
4066         fast/dom/remove-body-during-body-replacement2.html fails on WK2
4067         https://bugs.webkit.org/show_bug.cgi?id=138334
4068
4069         Reviewed by Anders Carlsson.
4070
4071         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
4072         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
4073         -makeFirstResponder calls, which may or may not be needed for other reasons, but
4074         it also needs to reset internal focus explicitly.
4075
4076         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
4077         WebKit behavior appears wrong, but it matches Firefox.
4078
4079         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4080         (WTR::InjectedBundlePage::resetAfterTest):
4081
4082 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4083
4084         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
4085         https://bugs.webkit.org/show_bug.cgi?id=137862
4086
4087         Reviewed by Gustavo Noronha Silva.
4088
4089         Add a test case to check that WebKitWebResource::failed-with-tls-errors
4090         is emitted when a subresource load fails due to TLS errors.
4091
4092         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
4093         (TLSSubresourceTest::resourceLoadStartedCallback):
4094         (TLSSubresourceTest::TLSSubresourceTest):
4095         (TLSSubresourceTest::subresourceFailedCallback):
4096         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
4097         (TLSSubresourceTest::subresourceLoadStarted):
4098         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
4099         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
4100         (testSubresourceLoadFailedWithTLSErrors):
4101         (httpsServerCallback):
4102         (httpServerCallback):
4103         (beforeAll):
4104
4105 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
4106
4107         Build fix for some compiler versions.
4108
4109         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
4110         unhappy because this is a getter, and these shouldn't have side effects.
4111
4112 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
4113
4114         Add a method for performing cherrypick-merges.
4115         https://bugs.webkit.org/show_bug.cgi?id=138375
4116
4117         Reviewed by Ryosuke Niwa.
4118
4119         Adds support for cherrypick-merges.
4120
4121         * Scripts/webkitpy/common/checkout/scm/git.py:
4122         (Git.cherrypick_merge): Added.
4123
4124 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
4125
4126         Add a way to ascertain the SVN URL associated with a Git branch.
4127         https://bugs.webkit.org/show_bug.cgi?id=138374
4128
4129         Reviewed by Ryosuke Niwa.
4130
4131         The svn_url method returns the SVN URL associated with the current Git branch.
4132
4133         * Scripts/webkitpy/common/checkout/scm/git.py:
4134         (Git.svn_url): Added.
4135
4136 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
4137
4138         Add the ability to search for modifications that are staged for commit.
4139         https://bugs.webkit.org/show_bug.cgi?id=138373
4140
4141         Reviewed by Ryosuke Niwa and Daniel Bates.
4142
4143         This makes is easy to do identify files that require merge post-processing,
4144         in addition to stand-alone utility.
4145
4146         * Scripts/webkitpy/common/checkout/scm/git.py:
4147         (Git.modifications_staged_for_commit): Added.
4148
4149 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
4150
4151         Add a branch keyword argument to _run_git_svn_find_rev.
4152         https://bugs.webkit.org/show_bug.cgi?id=138372
4153
4154         Reviewed by Ryosuke Niwa.
4155
4156         The addition of this keyword argument allows clients to determine the Git hash
4157         of commits made on an SVN branch, provided that branch has been fetched locally.
4158
4159         * Scripts/webkitpy/common/checkout/scm/git.py:
4160         (Git._run_git_svn_find_rev):
4161         Add a branch keyword argument that is added to the end of the command, if present.
4162
4163 2014-11-04  Chris Dumez  <cdumez@apple.com>
4164
4165         Add ptr() method to Ref class
4166         https://bugs.webkit.org/show_bug.cgi?id=138361
4167
4168         Reviewed by Darin Adler.
4169
4170         Use the new Ref::ptr() method.
4171
4172         * TestWebKitAPI/Tests/WTF/Ref.cpp:
4173         (TestWebKitAPI::TEST):
4174
4175 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
4176
4177         [jhbuild] Make it possible to build GTK/EFL in same repository
4178         https://bugs.webkit.org/show_bug.cgi?id=137448
4179
4180         Reviewed by Martin Robinson.
4181
4182         * Scripts/webkitdirs.pm:
4183         (getJhbuildPath):
4184         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
4185         (getPlatformFontsPath):
4186         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4187         (WTR::getFontsPath):
4188         * jhbuild/jhbuild-wrapper:
4189         (determine_platform):
4190         (install_jhbuild):
4191         * jhbuild/jhbuildrc_common.py:
4192         (init):
4193
4194 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
4195
4196         [EFL] Bump LLVM to version 3.5.0
4197         https://bugs.webkit.org/show_bug.cgi?id=138312
4198
4199         Reviewed by Csaba Osztrogonác.
4200
4201         * efl/jhbuild.modules:
4202         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
4203         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
4204
4205 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
4206
4207         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
4208         https://bugs.webkit.org/show_bug.cgi?id=138257
4209
4210         Reviewed by Tim Horton.
4211         
4212         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
4213         the user to toggle region page overlays on and off. Two overlays are available,
4214         for the non-fast scrollable region, and the region of element with wheel
4215         event handlers.
4216
4217         * MiniBrowser/mac/SettingsController.h:
4218         * MiniBrowser/mac/SettingsController.m:
4219         (-[SettingsController _populateMenu]):
4220         (-[SettingsController validateMenuItem:]):
4221         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
4222         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
4223         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
4224         (-[SettingsController toggleDebugOverlay:]):
4225         (-[SettingsController debugOverlayVisible:]):
4226         * MiniBrowser/mac/WK2BrowserWindowController.m:
4227         (-[WK2BrowserWindowController didChangeSettings]):
4228
4229 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
4230
4231         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
4232         https://bugs.webkit.org/show_bug.cgi?id=138323
4233
4234         Reviewed by Zalan Bujtas.
4235
4236         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
4237
4238 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4239
4240         [ninja] Don't remove response files for verbose builds
4241         https://bugs.webkit.org/show_bug.cgi?id=137816
4242
4243         Reviewed by Csaba Osztrogonác.
4244
4245         * Scripts/webkitdirs.pm:
4246         (determineNinjaVersion):
4247         (buildCMakeGeneratedProject):
4248
4249 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
4250
4251         [GTK] Fix the build of FTL JIT
4252         https://bugs.webkit.org/show_bug.cgi?id=138298
4253
4254         Reviewed by Carlos Garcia Campos.
4255
4256         * gtk/jhbuild-optional.modules:
4257         Bump up LLVM version to 3.5.0 release and apply patches.
4258         * gtk/patches/llvm-elf-add-stackmaps.patch:
4259         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
4260         trunk.
4261         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
4262         Added. Ensures that PC-relative relocations in EH frames are not
4263         truncated to 32 bits on x86_64.
4264
4265 2014-10-31  Michael Saboff  <msaboff@apple.com>
4266
4267         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
4268         https://bugs.webkit.org/show_bug.cgi?id=138268
4269
4270         Reviewed by Andreas Kling.
4271
4272         Added a --arch and --os option to set or override the values that are
4273         normally computed based on examining the JavaScriptCore we want to test.
4274
4275         * Scripts/run-jsc-stress-tests:
4276
4277 2014-10-31  Dan Bernstein  <mitz@apple.com>
4278
4279         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
4280