Tools/ChangeLog

   1 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
   2
   3         Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
   4
   5         * Scripts/webkitpy/tool/commands/newcommitbot.py:
   6         (NewCommitBot.next_work_item):
   7
   8 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
   9
  10         WKR and webkitbot build fixes.
  11
  12         * Scripts/webkitpy/tool/bot/irc_command.py:
  13         (RollChromiumDEPS.execute):
  14         * Scripts/webkitpy/tool/commands/newcommitbot.py:
  15         (NewCommitBot.next_work_item):
  16
  17 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
  18
  19         roll-chromium-deps doesn't repeat the full name.
  20
  21         Rubber-stamped by Andreas Kling.
  22
  23         * Scripts/webkitpy/tool/bot/irc_command.py:
  24         (RollChromiumDEPS.execute):
  25
  26 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
  27
  28         Revert another erroneous change.
  29
  30         * Scripts/webkitpy/tool/commands/newcommitbot.py:
  31         (NewCommitBot.next_work_item):
  32
  33 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
  34
  35         Revert an erroneous change.
  36
  37         * Scripts/webkitpy/tool/commands/sheriffbot.py:
  38         (SheriffBot):
  39
  40 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
  41
  42         Some build fixes for WKR and webkitbot.
  43
  44         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
  45         (IRCBotTest.test_help):
  46         * Scripts/webkitpy/tool/commands/newcommitbot.py:
  47         (Agent):
  48         (Agent.__init__):
  49         (Agent.name):
  50         (NewCommitBot):
  51         (NewCommitBot.begin_work_queue):
  52         (NewCommitBot.next_work_item):
  53         * Scripts/webkitpy/tool/commands/sheriffbot.py:
  54         (SheriffBot):
  55
  56 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
  57
  58         Teach webkitbot and WKR how to respond to yt?
  59         https://bugs.webkit.org/show_bug.cgi?id=116775
  60
  61         Reviewed by Andreas Kling.
  62
  63         * Scripts/webkitpy/tool/bot/irc_command.py:
  64         (Hi): Fixed the usage string.
  65         (Hi.execute): Made it more generic so that it works in WKR.
  66         (YouThere): Added.
  67         (YouThere.execute): Added.
  68         * Scripts/webkitpy/tool/commands/newcommitbot.py:
  69
  70 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
  71
  72         Try to fix the EFL build.
  73
  74         * DumpRenderTree/efl/TestRunnerEfl.cpp:
  75         (TestRunner::setPageVisibility):
  76
  77 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
  78
  79         Unprefix Page Visibility API
  80         https://bugs.webkit.org/show_bug.cgi?id=102340
  81
  82         Reviewed by Tim Horton.
  83
  84         Rename "preview" state to "unloaded" state, and adjust the tests
  85         to test for it.
  86
  87         * DumpRenderTree/mac/TestRunnerMac.mm:
  88         (TestRunner::setPageVisibility):
  89         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
  90         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
  91         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
  92         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
  93         (TestWebKitAPI::didRunStep4InStateUnloaded):
  94         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
  95         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
  96         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
  97         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  98         (WTR::TestRunner::setPageVisibility):
  99
 100 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
 101
 102         Unreviewed build fix. Don't use new NRWT logic needed
 103         by Windows yet. Activate (and fix test) when we cut over.
 104
 105         * Scripts/webkitpy/port/driver.py:
 106         (Driver._setup_environ_for_driver):
 107         (Driver._start):
 108
 109 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
 110
 111         [Windows] Expose database storage and cache locations via preferences.
 112         https://bugs.webkit.org/show_bug.cgi?id=116729
 113
 114         Reviewed by Tim Horton.
 115
 116         Update DumpRenderTree to use CFPreferences to control where WebKit
 117         stores its local databases, URL caches, etc.
 118
 119         * DumpRenderTree/win/DumpRenderTree.cpp:
 120         (libraryPathForDumpRenderTree): Added.
 121         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
 122         * Scripts/webkitpy/port/base.py:
 123         (Port._driver_tempdir): Added (to allow port-specific overload).
 124         (Port._driver_tempdir_for_environment): Ditto
 125         * Scripts/webkitpy/port/driver.py:
 126         (Driver._setup_environ_for_driver): Use new overload to set
 127         environment variable.
 128         (Driver._start): Use new overload for temp directory location.
 129         * Scripts/webkitpy/port/win.py:
 130         (WinPort._driver_tempdir_for_environment): New overload to supply
 131         Windows path to DumpRenderTree environment (while still using
 132         cygwin paths for internal operations.
 133
 134 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 135
 136         Remove custom code for webkitAudioContext global constructor getter
 137         https://bugs.webkit.org/show_bug.cgi?id=116530
 138
 139         Reviewed by Geoffrey Garen.
 140
 141         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
 142         WebAudio feature instead of public ewk_view API since that API was
 143         removed.
 144
 145         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 146         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
 147         * DumpRenderTree/efl/TestRunnerEfl.cpp:
 148         (TestRunner::overridePreference):
 149
 150 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
 151
 152         Make team.html have each contributor's area of expertise
 153         https://bugs.webkit.org/show_bug.cgi?id=116737
 154
 155         Reviewed by Benjamin Poulain.
 156
 157         * Scripts/webkitpy/common/config/contributors.json:
 158         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
 159
 160         Changed formatting of the file because the lines are getting way to
 161         long, and I generated this, so it's easier if the formatting of the
 162         file is regular.
 163
 164 2013-05-24  Simon Pena  <simon.pena@samsung.com>
 165
 166         Update WTF::Vector pretty printers
 167         https://bugs.webkit.org/show_bug.cgi?id=116719
 168
 169         Reviewed by Anders Carlsson.
 170
 171         After r148891, WTF::Vector pretty printers were left outdated, as
 172         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
 173         one as a member. This patch updates the pretty printers so they work
 174         again.
 175
 176         * gdb/webkit.py:
 177         (WTFVectorPrinter.children):
 178         (WTFVectorPrinter.to_string):
 179
 180 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
 181
 182         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
 183         https://bugs.webkit.org/show_bug.cgi?id=116710
 184
 185         Reviewed by Mark Rowe.
 186
 187         * DumpRenderTree/mac/DumpRenderTree.mm:
 188         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
 189
 190 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
 191
 192         Add missing dependencies to deps script.
 193
 194         [GTK] Missing packages in install-dependencies script.
 195         https://bugs.webkit.org/show_bug.cgi?id=116632
 196
 197         Reviewed by Martin Robinson.
 198
 199         * gtk/install-dependencies:
 200
 201 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
 202
 203         [Windows] Unreviewed change for NRWT support.
 204
 205         * Scripts/webkitpy/port/win.py:
 206         (WinPort.default_child_processes): Added a default implementation
 207         that limits NRWT to a single instance.
 208
 209 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
 210
 211         Remove meaningless "test_uses_apache" from Python test cases.
 212         https://bugs.webkit.org/show_bug.cgi?id=38756
 213
 214         Reviewed by Ryosuke Niwa.
 215
 216         * Scripts/webkitpy/port/port_testcase.py:
 217         (PortTestCase.test_driver_cmd_line): Remove the meaningless
 218         "test_uses_apache" test case from the Python test infrastructure.
 219         It was hard-coded to true, even though not all ports use
 220         Apache.
 221
 222 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
 223
 224         [Windows] Update new-run-webkit-tests for Windows port.
 225         https://bugs.webkit.org/show_bug.cgi?id=38756
 226
 227         Reviewed by Ryosuke Niwa.
 228
 229         * Scripts/new-run-webkit-httpd:
 230         (run): Switch from 'chromium' to 'win'
 231         * Scripts/webkitpy/port/win.py:
 232         (WinPort): Add support methods for lighttpd server.
 233         (WinPort._uses_apache):
 234         (WinPort._path_to_lighttpd):
 235         (WinPort._path_to_lighttpd_modules):
 236         (WinPort._path_to_lighttpd_php):
 237
 238 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
 239
 240         Make default bug links in buildbot clickable
 241         https://bugs.webkit.org/show_bug.cgi?id=116673
 242
 243         Reviewed by Ryosuke Niwa.
 244
 245         Use changecommentlink of html.WebStatus to make the links clickable.
 246
 247         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 248
 249 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
 250
 251         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
 252         https://bugs.webkit.org/show_bug.cgi?id=116595
 253
 254         Temporarily skip this test.
 255
 256         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
 257         (TestWebKitAPI::TEST):
 258
 259 2013-05-22  Alex Christensen  <achristensen@apple.com>
 260
 261         Unreviewed.  Added myself to contributors.json.
 262
 263         * Scripts/webkitpy/common/config/contributors.json:
 264         Added myself.
 265
 266 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
 267
 268         [EFL][WK2] Add sub menus to MiniBrowser
 269         https://bugs.webkit.org/show_bug.cgi?id=114728
 270
 271         Reviewed by Christophe Dumez.
 272
 273         Elementary Ctxpopup widget API does not provide support for submenu item.
 274         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
 275         Elementary Menu widget.
 276
 277         * MiniBrowser/efl/main.c:
 278         (_Browser_Window):
 279         (on_window_resize):
 280         (window_free):
 281         (context_menu_item_selected_cb):
 282         (context_menu_populate):
 283         (on_context_menu_show):
 284         (on_context_menu_hide):
 285         (window_create):
 286
 287 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
 288
 289         [EFL] Add command line option to MiniBrowser to set cookies policy.
 290         https://bugs.webkit.org/show_bug.cgi?id=115028
 291
 292         Reviewed by Christophe Dumez.
 293
 294         Add command line option to MiniBrowser EFL to set cookies policy:
 295         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
 296         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
 297
 298         * MiniBrowser/efl/main.c:
 299         (elm_main):
 300
 301 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
 302
 303         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
 304         https://bugs.webkit.org/show_bug.cgi?id=116585
 305
 306         Reviewed by Alexey Proskuryakov.
 307
 308         willLoadURLRequest and willLoadDataRequest require the API version 6.
 309
 310         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
 311
 312 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
 313
 314         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
 315         https://bugs.webkit.org/show_bug.cgi?id=116516
 316
 317         Reviewed by Alexey Proskuryakov.
 318
 319         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
 320
 321         * DumpRenderTree/mac/DumpRenderTree.mm:
 322         (createWebViewAndOffscreenWindow): Match the ordering.
 323         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
 324
 325 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
 326
 327         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
 328         https://bugs.webkit.org/show_bug.cgi?id=116568
 329
 330         Reviewed by Anders Carlsson.
 331
 332         * WebKitTestRunner/WebNotificationProvider.cpp:
 333         (WTR::WebNotificationProvider::~WebNotificationProvider):
 334         * WebKitTestRunner/WebNotificationProvider.h:
 335         When the provider is destroyed, it should no longer be registered with the manager.
 336
 337         * WebKitTestRunner/GeolocationProviderMock.cpp:
 338         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
 339         * WebKitTestRunner/GeolocationProviderMock.h:
 340         I wasn't seeing a crash here, but this code has the same issue as notification
 341         provider, so applying the same fix.
 342
 343         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
 344         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
 345         destructor having fixed the above.
 346
 347 2013-05-21  Commit Queue  <commit-queue@webkit.org>
 348
 349         Unreviewed, rolling out r150386 and r150397.
 350         http://trac.webkit.org/changeset/150386
 351         http://trac.webkit.org/changeset/150397
 352         https://bugs.webkit.org/show_bug.cgi?id=116572
 353
 354         Broke a test; Alex is going to try again later. (Requested by
 355         thorton on #webkit).
 356
 357         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 358         (WTR::pathSuitableForTestResult):
 359         (WTR::dumpRequestDescriptionSuitableForTestResult):
 360         (WTR::dumpResponseDescriptionSuitableForTestResult):
 361         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
 362         (WTR::InjectedBundlePage::didInitiateLoadForResource):
 363         (WTR::InjectedBundlePage::willSendRequestForFrame):
 364         (WTR::InjectedBundlePage::didReceiveResponseForResource):
 365         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 366         (InjectedBundlePage):
 367
 368 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
 369
 370         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
 371
 372         * Scripts/webkitpy/tool/commands/suggestnominations.py:
 373         (AbstractCommitLogCommand._recent_commit_messages):
 374
 375 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
 376
 377         [GTK] [CMake] Add support for building WebKit2
 378         https://bugs.webkit.org/show_bug.cgi?id=116372
 379
 380         Reviewed by Gustavo Noronha Silva.
 381
 382         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
 383         * MiniBrowser/gtk/CMakeLists.txt: Added.
 384
 385 2013-05-21  Jessie Berlin  <jberlin@apple.com>
 386
 387         Revert r149635, it was too optimistic.
 388
 389         Rubber-stamped by Andreas Kling.
 390
 391         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
 392         #ifdefs in WebCore code outside of WebCore/platform.
 393
 394         * Scripts/webkitpy/style/checkers/cpp.py:
 395         (check_invalid_increment):
 396         (process_line):
 397         (CppChecker):
 398         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 399         (CppStyleTest.test_plain_integral_bitfields):
 400
 401 2013-05-21  Jer Noble  <jer.noble@apple.com>
 402
 403         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
 404
 405         * lldb/lldb_webkit.py:
 406         (WTFVectorProvider.num_children):
 407         (WTFVectorProvider.get_child_index):
 408         (WTFVectorProvider.get_child_at_index):
 409         (WTFVectorProvider.update):
 410
 411 2013-05-21  Jessie Berlin  <jberlin@apple.com>
 412
 413         Expose a way to know when forms are added to a page or when form controls are added to a form
 414         in the injected bundle
 415         https://bugs.webkit.org/show_bug.cgi?id=116334
 416
 417         Reviewed by Alexey Proskuryakov.
 418
 419         Add tests for the new callbacks.
 420
 421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 422         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
 423
 424         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
 425         (TestWebKitAPI::nullJavaScriptCallback):
 426         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
 427         being passed in for the callback.
 428         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
 429         After receiving the message that didAssociateFormControls callback was invoked from adding
 430         the form in the onload handler, tell the page to add a password field to the form, which
 431         should also invoke didAssociateFormControls callback.
 432         (TestWebKitAPI::setInjectedBundleClient):
 433         Register to receive messages.
 434         (TestWebKitAPI::TEST):
 435         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
 436         been invoked for both adding the form and for adding a password field to the form.
 437
 438         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
 439         (TestWebKitAPI::shouldNotifyOnFormChanges):
 440         Return true so the didAssociateFormControls callback is invoked.
 441         (TestWebKitAPI::didAssociateFormControls):
 442         Tell the UI process.
 443         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
 444         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
 445         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
 446
 447         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
 448         Add a form in response to the onload event. Add a button that will add the password field
 449         for manual testing.
 450
 451 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
 452
 453         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
 454         https://bugs.webkit.org/show_bug.cgi?id=106341
 455
 456         Reviewed by Martin Robinson.
 457
 458         Adds support for retrieving accessibility element at exact point.
 459
 460         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 461         (WTR::AccessibilityUIElement::elementAtPoint):
 462
 463 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
 464
 465         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
 466         https://bugs.webkit.org/show_bug.cgi?id=112913
 467
 468         Reviewed by Martin Robinson.
 469
 470         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
 471         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
 472         so the leak appears.
 473
 474         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
 475         (WTR):
 476         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 477         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
 478         (WTR::AccessibilityController::rootElement):
 479         (WTR):
 480         (WTR::AccessibilityController::focusedElement):
 481         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 482         (WTR::checkElementState):
 483         (WTR::indexRangeInTable):
 484         (WTR::alterCurrentValue):
 485         (WTR::AccessibilityUIElement::getChildren):
 486         (WTR::AccessibilityUIElement::getChildrenWithRange):
 487         (WTR::AccessibilityUIElement::childrenCount):
 488         (WTR::AccessibilityUIElement::indexOfChild):
 489         (WTR::AccessibilityUIElement::titleUIElement):
 490         (WTR::AccessibilityUIElement::parentElement):
 491         (WTR::AccessibilityUIElement::allAttributes):
 492         (WTR::AccessibilityUIElement::role):
 493         (WTR::AccessibilityUIElement::title):
 494         (WTR::AccessibilityUIElement::description):
 495         (WTR::AccessibilityUIElement::orientation):
 496         (WTR::AccessibilityUIElement::stringValue):
 497         (WTR::AccessibilityUIElement::language):
 498         (WTR::AccessibilityUIElement::x):
 499         (WTR::AccessibilityUIElement::y):
 500         (WTR::AccessibilityUIElement::width):
 501         (WTR::AccessibilityUIElement::height):
 502         (WTR::AccessibilityUIElement::intValue):
 503         (WTR::AccessibilityUIElement::minValue):
 504         (WTR::AccessibilityUIElement::maxValue):
 505         (WTR::AccessibilityUIElement::isEnabled):
 506         (WTR::AccessibilityUIElement::isFocused):
 507         (WTR::AccessibilityUIElement::isSelected):
 508         (WTR::AccessibilityUIElement::isExpanded):
 509         (WTR::AccessibilityUIElement::isChecked):
 510         (WTR::AccessibilityUIElement::rowCount):
 511         (WTR::AccessibilityUIElement::columnCount):
 512         (WTR::AccessibilityUIElement::rowIndexRange):
 513         (WTR::AccessibilityUIElement::columnIndexRange):
 514         (WTR::AccessibilityUIElement::cellForColumnAndRow):
 515         (WTR::AccessibilityUIElement::increment):
 516         (WTR::AccessibilityUIElement::decrement):
 517         (WTR::AccessibilityUIElement::press):
 518         (WTR::AccessibilityUIElement::documentEncoding):
 519         (WTR::AccessibilityUIElement::documentURI):
 520         (WTR::AccessibilityUIElement::isFocusable):
 521         (WTR::AccessibilityUIElement::isSelectable):
 522         (WTR::AccessibilityUIElement::isMultiSelectable):
 523         (WTR::AccessibilityUIElement::isVisible):
 524
 525 2013-05-20  Lucas Forschler  <lforschler@apple.com>
 526
 527     Rollout 150398.
 528
 529 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
 530
 531         [GTK] Fix concatenations of string literals that are not C++11-compliant
 532         https://bugs.webkit.org/show_bug.cgi?id=116449
 533
 534         Reviewed by Martin Robinson.
 535
 536         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
 537         is simply a matter of separating the string and the string literal that are being concatenated with a space.
 538
 539         * ImageDiff/gtk/ImageDiff.cpp:
 540         (printImage):
 541
 542 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
 543
 544         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
 545         https://bugs.webkit.org/show_bug.cgi?id=116450
 546
 547         Reviewed by Martin Robinson.
 548
 549         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
 550         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
 551         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
 552         TestWebKitAPI programs when compiling them.
 553
 554         * TestWebKitAPI/GNUmakefile.am:
 555
 556 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
 557
 558         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
 559         https://bugs.webkit.org/show_bug.cgi?id=116492
 560
 561         Reviewed by Dirk Pranke.
 562
 563         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
 564
 565         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
 566         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
 567         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
 568         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
 569         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
 570         to memory pressure on the machine.
 571
 572         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
 573         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
 574         for a subsequent patch just to make things easier to follow.
 575
 576         * Scripts/webkitpy/port/driver.py:
 577         (DriverProxy.__init__):
 578         (DriverProxy.run_test):
 579         (DriverProxy.has_crashed):
 580         (DriverProxy.stop):
 581
 582 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 583
 584         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
 585         https://bugs.webkit.org/show_bug.cgi?id=116423
 586
 587         Reviewed by Ryosuke Niwa.
 588
 589         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
 590
 591         * BuildSlaveSupport/build.webkit.org-config/config.json:
 592
 593 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
 594
 595         Remove remaining link-prerender code
 596         https://bugs.webkit.org/show_bug.cgi?id=116429
 597
 598         Reviewed by Darin Adler.
 599
 600         Link prerendering code was removed in r150356.
 601
 602         * Scripts/webkitperl/FeatureList.pm:
 603         * qmake/mkspecs/features/features.pri:
 604
 605 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
 606
 607         commit-queue should check for oops in changelog entries
 608         https://bugs.webkit.org/show_bug.cgi?id=116395
 609
 610         Reviewed by Martin Robinson.
 611
 612         Make changelog validation fail when it contains oops!.
 613
 614         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 615         (CommitQueueTask._validate_changelog):
 616         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 617         (CommitQueueTaskTest._run_through_task):
 618         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 619         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
 620         (ValidateChangeLogs.options):
 621         (ValidateChangeLogs._check_changelog_diff):
 622         (ValidateChangeLogs._changelog_contains_oops):
 623         (ValidateChangeLogs.run):
 624         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
 625         (ValidateChangeLogsTest._assert_start_line_produces_output):
 626         (ValidateChangeLogsTest.test_check_changelog_diff):
 627         (ValidateChangeLogsTest):
 628         (ValidateChangeLogsTest.test_changelog_contains_oops):
 629
 630 2013-05-20  Jessie Berlin  <jberlin@apple.com>
 631
 632         Expose a way to know when forms are added to a page or when form controls are added to a form
 633         in the injected bundle
 634         https://bugs.webkit.org/show_bug.cgi?id=116334
 635
 636         Reviewed by Alexey Proskuryakov.
 637
 638         Add tests for the new callbacks.
 639
 640         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 641         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
 642
 643         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
 644         (TestWebKitAPI::nullJavaScriptCallback):
 645         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
 646         being passed in for the callback.
 647         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
 648         After receiving the message that didAssociateFormControls callback was invoked from adding
 649         the form in the onload handler, tell the page to add a password field to the form, which
 650         should also invoke didAssociateFormControls callback.
 651         (TestWebKitAPI::setInjectedBundleClient):
 652         Register to receive messages.
 653         (TestWebKitAPI::TEST):
 654         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
 655         been invoked for both adding the form and for adding a password field to the form.
 656
 657         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
 658         (TestWebKitAPI::shouldNotifyOnFormChanges):
 659         Return true so the didAssociateFormControls callback is invoked.
 660         (TestWebKitAPI::didAssociateFormControls):
 661         Tell the UI process.
 662         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
 663         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
 664         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
 665
 666         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
 667         Add a form in response to the onload event. Add a button that will add the password field
 668         for manual testing.
 669
 670 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 671
 672         [EFL][JHBUILD] Make sure eet is built before evas
 673         https://bugs.webkit.org/show_bug.cgi?id=116440
 674
 675         Reviewed by Gyuyoung Kim.
 676
 677         Mark eet as a dependency of evas since evas requires eet to enable some of its
 678         functionality.
 679
 680         * efl/jhbuild.modules:
 681
 682 2013-05-20  Alex Christensen  <achristensen@apple.com>
 683
 684         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
 685         https://bugs.webkit.org/show_bug.cgi?id=116125
 686
 687         Reviewed by Tim Horton.
 688
 689         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 690         (WTR::pathSuitableForTestResult):
 691         Changed string operations to match _drt_descriptionSuitableForTestResult.
 692         (WTR::dumpRequestDescriptionSuitableForTestResult):
 693         (WTR::dumpResponseDescriptionSuitableForTestResult):
 694         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
 695         (WTR::InjectedBundlePage::didInitiateLoadForResource):
 696         (WTR::InjectedBundlePage::willSendRequestForFrame):
 697         (WTR::InjectedBundlePage::didReceiveResponseForResource):
 698         Pass the main frame's URL to pathSuitableForTestResult.
 699         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 700         Added WKBundlePageRef to willPerformClientRedirectForFrame.
 701
 702 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
 703
 704         fix w3c test importer unit tests after r150324
 705         https://bugs.webkit.org/show_bug.cgi?id=116459
 706
 707         Reviewed by Ryosuke Niwa.
 708
 709         This patch fixes the unit tests to not actually call out to
 710         'hg' (by using a mock executive) and also changes the real
 711         directory we crawl from Source/WebCore/css to
 712         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
 713         still change this to a mock filesystem, but that's a separate change.
 714
 715         * Scripts/webkitpy/w3c/test_importer.py:
 716         (main):
 717         (TestImporter.__init__):
 718         (TestImporter.load_changeset):
 719         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 720         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
 721         (TestImporterTest.test_import_dir_with_no_tests):
 722
 723 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 724
 725         Unreviewed EFL build fix.
 726
 727         Fix linking errors due to undefined symbols on Ubuntu 13.04.
 728
 729         * DumpRenderTree/efl/CMakeLists.txt:
 730         * EWebLauncher/CMakeLists.txt:
 731         * MiniBrowser/efl/CMakeLists.txt:
 732
 733 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 734
 735         [EFL] Reenabled INDEXED_DATABASE after r150344
 736         https://bugs.webkit.org/show_bug.cgi?id=116430
 737
 738         Reviewed by Gyuyoung Kim.
 739
 740         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
 741         build was fixed in r150344.
 742
 743         * Scripts/webkitperl/FeatureList.pm:
 744
 745 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
 746
 747         [EFL] init/shutdown should be paired in EWebLauncher
 748         https://bugs.webkit.org/show_bug.cgi?id=116427
 749
 750         Reviewed by Christophe Dumez.
 751
 752         Added ecore_file_shutdown() for cleanup of ecore_file.
 753         Removed edje_init and ecore_evas_init because it was in ewk_init().
 754
 755         * EWebLauncher/main.c:
 756         (main):
 757
 758 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
 759
 760         [EFL] Add command line option to MiniBrowser to set user agent
 761         https://bugs.webkit.org/show_bug.cgi?id=116387
 762
 763         Reviewed by Christophe Dumez.
 764
 765         We need this option to compare the rendering differences according to different user agents.
 766
 767         * MiniBrowser/efl/main.c:
 768         (window_create):
 769         (elm_main):
 770
 771 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
 772
 773         Unreviewed, addressing test-webkitpy failures after r150317.
 774
 775         * Scripts/webkitpy/w3c/test_converter.py:
 776         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
 777
 778 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
 779
 780         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
 781         https://bugs.webkit.org/show_bug.cgi?id=114554
 782
 783         Reviewed by Gyuyoung Kim.
 784
 785         Using variables as target names is very uncommon in CMake.
 786         The usual way to specify the name of the resulting binary
 787         is to set the OUTPUT_NAME target property.
 788
 789         * DumpRenderTree/efl/CMakeLists.txt:
 790         * EWebLauncher/CMakeLists.txt:
 791         * ImageDiff/CMakeLists.txt:
 792         * MiniBrowser/efl/CMakeLists.txt:
 793         * TestWebKitAPI/CMakeLists.txt:
 794         * WebKitTestRunner/CMakeLists.txt:
 795         * WebKitTestRunner/PlatformEfl.cmake:
 796         * WinCELauncher/CMakeLists.txt:
 797
 798 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 799
 800         Unreviewed EFL build fix.
 801
 802         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
 803         WK2 build after r150305.
 804
 805         * Scripts/webkitperl/FeatureList.pm:
 806
 807 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
 808
 809         [GTK] Parallel build fails if gtk-doc is enabled
 810         https://bugs.webkit.org/show_bug.cgi?id=116227
 811
 812         Reviewed by Martin Robinson.
 813
 814         * GNUmakefile.am:
 815         Don't use the 'all' target to generate the documentation.
 816         The prerequisites of this target must be files that need to be
 817         built _before_ the actual compilation of WebKit starts. Since the
 818         documentation depends on WebKit being built first, this means in
 819         practice that the code will be built in parallel with the
 820         generation of its dependencies, potentially making the build fail.
 821
 822 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 823
 824         Don't run hg.
 825
 826         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 827         (TestImporterTest):
 828
 829 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
 830
 831         Create a script to import W3C tests
 832         https://bugs.webkit.org/show_bug.cgi?id=111513
 833
 834         Reviewed by Ryosuke Niwa.
 835
 836         This patch attempts to re-land the 'import-w3c-tests'
 837         script and accompanying modules.  The tests and code have
 838         been cleaned up so that we do not log anything to stdout/stderr
 839         while running the tests (thanks to outputcapture) and do not
 840         write into the source tree while running the tests, and much
 841         but not all of the code has been converted over to using the webkitpy
 842
 843         * Scripts/import-w3c-tests: Added.
 844         * Scripts/webkitpy/w3c/__init__.py: Added.
 845         * Scripts/webkitpy/w3c/test_converter.py: Added.
 846         (W3CTestConverter):
 847         (W3CTestConverter.__init__):
 848         (W3CTestConverter.path_from_webkit_root):
 849         (W3CTestConverter.read_webkit_prefixed_css_property_list):
 850         (W3CTestConverter.convert_for_webkit):
 851         (W3CTestConverter.convert_css):
 852         (W3CTestConverter.convert_html):
 853         (W3CTestConverter.convert_testharness_paths):
 854         (W3CTestConverter.convert_prefixed_properties):
 855         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
 856         (W3CTestConverter.replace_tag):
 857         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
 858         (W3CTestConverterTest):
 859         (W3CTestConverterTest.fake_dir_path):
 860         (W3CTestConverterTest.test_read_prefixed_property_list):
 861         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
 862         (test_convert_for_webkit_harness_only):
 863         (test_convert_for_webkit_properties_only):
 864         (test_convert_for_webkit_harness_and_properties):
 865         (test_convert_test_harness_paths):
 866         (test_convert_prefixed_properties):
 867         (verify_conversion_happened):
 868         (verify_no_conversion_happened):
 869         (verify_test_harness_paths):
 870         (verify_prefixed_properties):
 871         (generate_test_content):
 872         * Scripts/webkitpy/w3c/test_importer.py: Added.
 873         (main):
 874         (parse_args):
 875         (validate_import_directory):
 876         (TestImporter):
 877         (TestImporter.__init__):
 878         (TestImporter.path_from_webkit_root):
 879         (TestImporter.do_import):
 880         (TestImporter.load_changeset):
 881         (TestImporter.find_importable_tests):
 882         (TestImporter.import_tests):
 883         (TestImporter.setup_destination_directory):
 884         (TestImporter.update_test_status):
 885         (TestImporter.remove_deleted_files):
 886         (TestImporter.write_import_log):
 887         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
 888         (TestImporterTest):
 889         (TestImporterTest.test_import_dir_with_no_tests):
 890         * Scripts/webkitpy/w3c/test_parser.py: Added.
 891         (TestParser):
 892         (TestParser.__init__):
 893         (TestParser.load_file):
 894         (TestParser.analyze_test):
 895         (TestParser.reference_links_of_type):
 896         (TestParser.is_jstest):
 897         (TestParser.support_files):
 898         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
 899         (TestParserTest):
 900         (TestParserTest.test_analyze_test_reftest_one_match):
 901         (test_analyze_test_reftest_multiple_matches):
 902         (test_analyze_test_reftest_match_and_mismatch):
 903         (test_analyze_test_reftest_with_ref_support_Files):
 904         (test_analyze_jstest):
 905         (test_analyze_pixel_test_all_true):
 906         (test_analyze_pixel_test_all_false):
 907         (test_analyze_non_html_file):
 908
 909 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 910
 911         Leaks builders exit early frequently
 912         https://bugs.webkit.org/show_bug.cgi?id=116355
 913
 914         Reviewed by Stephanie Lewis.
 915
 916         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
 917         we tolerate from 20 to 50.
 918
 919         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 920         (RunWebKitTests.start):
 921         * Scripts/webkitpy/port/mac.py:
 922         (MacPort.default_child_processes):
 923
 924 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
 925
 926         Remove chrome-channels command from the webkit-patch
 927         https://bugs.webkit.org/show_bug.cgi?id=116303
 928
 929         Reviewed by Ryosuke Niwa.
 930
 931         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
 932         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
 933         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
 934         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
 935         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
 936         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
 937
 938 2013-05-17  David Kilzer  <ddkilzer@apple.com>
 939
 940         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
 941         Part 3 of 3: <http://webkit.org/b/116247>
 942
 943         Reviewed by Benjamin Poulain.
 944
 945         * Scripts/filter-build-webkit: Change while() loop to for() loop
 946         to track $previousLine, then pass $previousLine into
 947         shouldIgnoreLine().
 948         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
 949         line that begins with four spaces if the previous line is a
 950         linker error message.
 951         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
 952         - Add "Ignored: " to test descriptions to document expected
 953           behavior.
 954         - Add comment blocks for various groups of tests.
 955         - Expand "Build settings" tests since we're changing the code in
 956           shouldIgnoreLine() that ignores those lines.
 957         - Add tests for undefined symbols error message.
 958         (description): Add.  Extract from global code.
 959
 960 2013-05-17  David Kilzer  <ddkilzer@apple.com>
 961
 962         Add tests for shouldIgnoreLine() in filter-build-webkit
 963         Part 2 of 3: <http://webkit.org/b/116247>
 964
 965         Reviewed by Benjamin Poulain.
 966
 967         * Scripts/filter-build-webkit:
 968         (shouldIgnoreLine): Add.  Extract code from global scope into
 969         subroutine to make it testable.
 970         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
 971         Tests shouldIgnoreLine() using output from a real build
 972         transcript.
 973
 974 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 975
 976         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
 977         https://bugs.webkit.org/show_bug.cgi?id=116341
 978
 979         Reviewed by Brady Eidson.
 980
 981         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
 982
 983 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
 984
 985         [Windows] Don't use pdevenv when building with VS2010.
 986         https://bugs.webkit.org/show_bug.cgi?id=116338.
 987
 988         Reviewed by Adam Roben.
 989
 990         * Scripts/webkitdirs.pm:
 991         (setupCygwinEnv): Check if we are using VS2005, and only use
 992         the 'pdevenv' hack if we are. Otherwise, just build with
 993         our standard project since it uses VS2010+'s native
 994         parallel building features.
 995
 996 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
 997
 998         Unreviewed. Disable accelerated compositing until we figure out why it does not work
 999         properly in the 64 bits release bot.
1000
1001         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1002         (resetDefaultsToConsistentValues):
1003
1004 2013-05-17  David Kilzer  <ddkilzer@apple.com>
1005
1006         Make filter-build-webkit testable using LoadAsModule
1007         Part 1 of 3: <http://webkit.org/b/116247>
1008
1009         Reviewed by Benjamin Poulain.
1010
1011         * Scripts/filter-build-webkit: Change global variables that are
1012         used in subroutines from 'my' to 'our' to make it possible to
1013         evaluate the script in a package context in LoadAsModule.pm.
1014
1015 2013-05-14  Sam Weinig  <sam@webkit.org>
1016
1017         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
1018         https://bugs.webkit.org/show_bug.cgi?id=116132
1019
1020         Reviewed by Anders Carlsson.
1021
1022         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
1023         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
1024
1025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1026         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
1027         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
1028         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1029
1030 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
1031
1032         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
1033         https://bugs.webkit.org/show_bug.cgi?id=114781
1034
1035         Reviewed by Christophe Dumez.
1036
1037         Add run_before_unload_confirm and
1038         Print the log message with "CONFIRM NAVIGATION: " in console.
1039
1040         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1041         (onBeforeUnloadConfirm):
1042         (drtViewAdd):
1043
1044 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
1045
1046         Fix Analyze ChangeLog's entry processing
1047         https://bugs.webkit.org/show_bug.cgi?id=116219
1048
1049         Reviewed by Ryosuke Niwa.
1050
1051         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1052         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
1053
1054 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
1055
1056         [Qt] UrlLoader::loadNext is broken in MiniBrowser
1057         https://bugs.webkit.org/show_bug.cgi?id=116099
1058
1059         Reviewed by Jocelyn Turcotte.
1060
1061         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
1062         are not available any more. So, UrlLoader::loadNext was broken
1063         because it failed to connect to those signals.
1064
1065         * MiniBrowser/qt/UrlLoader.cpp:
1066         (UrlLoader::UrlLoader):
1067         (UrlLoader::loadingChanged):
1068         * MiniBrowser/qt/UrlLoader.h:
1069         (UrlLoader):
1070
1071 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
1072
1073         [WebSocket] Update pywebsocket to r760
1074         https://bugs.webkit.org/show_bug.cgi?id=115863
1075
1076         Reviewed by Alexey Proskuryakov.
1077
1078         Version r760 supports a newer draft of message compression.
1079         We need this update to finish the permessage compression patch in
1080         bug 98840. This patch also fixes failing unit tests after the update.
1081
1082         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
1083         (StreamBase._read):
1084         (StreamBase._read.of):
1085         (StreamBase._write):
1086         (StreamBase.receive_bytes):
1087         (StreamBase._read_until):
1088         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
1089         (parse_frame):
1090         (StreamOptions.__init__):
1091         (Stream.__init__):
1092         (Stream._receive_frame_as_frame_object):
1093         (Stream._get_message_from_frame):
1094         (Stream._process_close_message):
1095         (Stream.close_connection):
1096         (Stream.get_last_received_opcode):
1097         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
1098         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
1099         (Dispatcher.do_extra_handshake):
1100         (Dispatcher.transfer_data):
1101         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
1102         (ExtensionProcessorInterface.__init__):
1103         (ExtensionProcessorInterface.request):
1104         (ExtensionProcessorInterface):
1105         (ExtensionProcessorInterface.name):
1106         (ExtensionProcessorInterface.check_consistency_with_other_processors):
1107         (ExtensionProcessorInterface.set_active):
1108         (ExtensionProcessorInterface.is_active):
1109         (ExtensionProcessorInterface._get_extension_response_internal):
1110         (ExtensionProcessorInterface.get_extension_response):
1111         (ExtensionProcessorInterface._setup_stream_options_internal):
1112         (ExtensionProcessorInterface.setup_stream_options):
1113         (_log_outgoing_compression_ratio):
1114         (_log_incoming_compression_ratio):
1115         (_parse_window_bits):
1116         (_AverageRatioCalculator):
1117         (_AverageRatioCalculator.__init__):
1118         (_AverageRatioCalculator.add_original_bytes):
1119         (_AverageRatioCalculator.add_result_bytes):
1120         (_AverageRatioCalculator.get_average_ratio):
1121         (DeflateFrameExtensionProcessor):
1122         (DeflateFrameExtensionProcessor.__init__):
1123         (DeflateFrameExtensionProcessor._get_extension_response_internal):
1124         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
1125         (DeflateFrameExtensionProcessor._outgoing_filter):
1126         (DeflateFrameExtensionProcessor._incoming_filter):
1127         (CompressionExtensionProcessorBase.for):
1128         (CompressionExtensionProcessorBase.__init__):
1129         (CompressionExtensionProcessorBase._get_extension_response_internal):
1130         (CompressionExtensionProcessorBase._setup_stream_options_internal):
1131         (PerFrameCompressExtensionProcessor):
1132         (PerMessageDeflateExtensionProcessor):
1133         (PerMessageDeflateExtensionProcessor.__init__):
1134         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
1135         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
1136         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
1137         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
1138         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
1139         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
1140         (PerMessageDeflateExtensionProcessor.set_bfinal):
1141         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
1142         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
1143         (_PerMessageDeflateFramer):
1144         (_PerMessageDeflateFramer.__init__):
1145         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
1146         (_PerMessageDeflateFramer._process_incoming_message):
1147         (_PerMessageDeflateFramer._process_outgoing_message):
1148         (_PerMessageDeflateFramer.setup_stream_options):
1149         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
1150         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
1151         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
1152         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
1153         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
1154         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
1155         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
1156         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
1157         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
1158         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
1159         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
1160         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
1161         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
1162         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
1163         (PerMessageCompressExtensionProcessor):
1164         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
1165         (MuxExtensionProcessor.__init__):
1166         (MuxExtensionProcessor.check_consistency_with_other_processors):
1167         (MuxExtensionProcessor):
1168         (MuxExtensionProcessor._get_extension_response_internal):
1169         (MuxExtensionProcessor._setup_stream_options_internal):
1170         (MuxExtensionProcessor.set_quota):
1171         (MuxExtensionProcessor.quota):
1172         (MuxExtensionProcessor.set_extensions):
1173         (MuxExtensionProcessor.extensions):
1174         (is_compression_extension):
1175         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
1176         (validate_subprotocol):
1177         (parse_host_header):
1178         (format_header):
1179         (check_request_line):
1180         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
1181         (Handshaker.do_handshake):
1182         (Handshaker._create_handshake_response):
1183         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
1184         (_validate_subprotocol):
1185         (_check_header_lines):
1186         (_build_location):
1187         (Handshaker.do_handshake):
1188         (Handshaker._set_subprotocol):
1189         (Handshaker._set_location):
1190         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
1191         (_create_dispatcher):
1192         (headerparserhandler):
1193         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
1194         (_create_add_channel_response):
1195         (_create_drop_channel):
1196         (_create_flow_control):
1197         (_create_new_channel_slot):
1198         (_create_fallback_new_channel_slot):
1199         (_MuxFramePayloadParser._read_number):
1200         (_MuxFramePayloadParser._read_size_and_contents):
1201         (_MuxFramePayloadParser._read_flow_control):
1202         (_MuxFramePayloadParser._read_new_channel_slot):
1203         (_LogicalConnection.__init__):
1204         (_LogicalConnection.write):
1205         (_LogicalConnection.on_write_data_done):
1206         (_LogicalConnection):
1207         (_LogicalConnection.on_writer_done):
1208         (_InnerMessage):
1209         (_InnerMessage.__init__):
1210         (_InnerMessageBuilder):
1211         (_InnerMessageBuilder.that):
1212         (_InnerMessageBuilder.__init__):
1213         (_InnerMessageBuilder._handle_first):
1214         (_InnerMessageBuilder._process_first_fragmented_control):
1215         (_InnerMessageBuilder._process_first_fragmented_message):
1216         (_InnerMessageBuilder._handle_fragmented_control):
1217         (_InnerMessageBuilder._reassemble_fragmented_control):
1218         (_InnerMessageBuilder._handle_fragmented_message):
1219         (_InnerMessageBuilder._reassemble_fragmented_message):
1220         (_InnerMessageBuilder.build):
1221         (_LogicalStream.__init__):
1222         (_LogicalStream._create_inner_frame):
1223         (_LogicalStream._write_inner_frame):
1224         (_LogicalStream.replenish_send_quota):
1225         (_LogicalStream.send_message):
1226         (_LogicalStream._receive_frame):
1227         (_LogicalStream._get_message_from_frame):
1228         (_LogicalStream.stop_sending):
1229         (_PhysicalConnectionWriter.__init__):
1230         (_PhysicalConnectionWriter._write_data):
1231         (_PhysicalConnectionWriter.run):
1232         (_PhysicalConnectionWriter.stop):
1233         (_Worker.run):
1234         (_MuxHandshaker.__init__):
1235         (_MuxHandshaker._create_stream):
1236         (_MuxHandshaker._create_handshake_response):
1237         (_HandshakeDeltaBase.create_headers):
1238         (_MuxHandler.start):
1239         (_MuxHandler.wait_until_done):
1240         (_MuxHandler.notify_write_data_done):
1241         (_MuxHandler._process_drop_channel):
1242         (_MuxHandler._process_logical_frame):
1243         (_MuxHandler.notify_reader_done):
1244         (_MuxHandler):
1245         (_MuxHandler.notify_writer_done):
1246         (_MuxHandler.fail_physical_connection):
1247         (_MuxHandler.fail_logical_channel):
1248         (use_mux):
1249         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
1250         (_StandaloneRequest.get_uri):
1251         (_StandaloneRequest.get_unparsed_uri):
1252         (_StandaloneRequest):
1253         (_StandaloneRequest.is_https):
1254         (_import_ssl):
1255         (_import_pyopenssl):
1256         (_StandaloneSSLConnection.for):
1257         (_StandaloneSSLConnection):
1258         (_StandaloneSSLConnection.__getattribute__):
1259         (_StandaloneSSLConnection.__setattr__):
1260         (_StandaloneSSLConnection.makefile):
1261         (_StandaloneSSLConnection.shutdown):
1262         (_StandaloneSSLConnection.recv):
1263         (WebSocketServer.__init__):
1264         (WebSocketServer._create_sockets):
1265         (WebSocketServer.handle_error):
1266         (WebSocketServer.get_request):
1267         (WebSocketServer.get_request.default_callback):
1268         (WebSocketRequestHandler.parse_request):
1269         (_build_option_parser):
1270         (_main):
1271         (_main.if):
1272         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
1273         (RepeatedXorMasker.__init__):
1274         (RepeatedXorMasker._mask_using_swig):
1275         (RepeatedXorMasker):
1276         (RepeatedXorMasker._mask_using_array):
1277         (_Deflater.compress_and_finish):
1278         (_RFC1979Deflater.filter):
1279         (DeflateSocket.send):
1280
1281 2013-05-16  Jonathan Liu  <net147@gmail.com>
1282
1283         Fix testing if program exists in PATH
1284         https://bugs.webkit.org/show_bug.cgi?id=116216
1285
1286         Reviewed by Jocelyn Turcotte.
1287
1288         functions.prf incorrectly uses win_cmd_shell to test whether to
1289         add .exe to the executable name when checking if it exists in
1290         the PATH environment variable. This works correctly when
1291         building using Windows Command Prompt but not under MSYS shell.
1292
1293         To resolve this, check the win32 platform scope instead of
1294         win_cmd_shell so that it correctly adds .exe to the executable
1295         name on Windows regardless of the shell used when testing if
1296         it exists in PATH.
1297
1298         * qmake/mkspecs/features/functions.prf:
1299
1300 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
1301
1302         Fix the hard-coded names of EWS bots that run tests.
1303
1304         * Scripts/webkitpy/tool/commands/queues.py:
1305         (CommitQueue.did_pass_testing_ews):
1306
1307 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1308
1309         [GTK] Build Xvfb with jhbuild
1310         https://bugs.webkit.org/show_bug.cgi?id=115907
1311
1312         Reviewed by Martin Robinson.
1313
1314         Build our own Xvfb so that we can avoid problems with the system Xvfb
1315         relying on symbols not present in our jhbuilt libraries such as pixman,
1316         and also to ensure we have the fix for a GLX module crasher.
1317
1318         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1319         (resetDefaultsToConsistentValues): enable accelerated compositing.
1320         * gtk/install-dependencies: list packages required for building Xvfb.
1321         * gtk/jhbuild.modules: add xserver as a jhbuild module.
1322         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
1323         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
1324         initializing the GLX module for Xvfb.
1325
1326 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1327
1328         [jhbuild] Should remove the sources directory as well when cleaning
1329         https://bugs.webkit.org/show_bug.cgi?id=116229
1330
1331         Reviewed by Martin Robinson.
1332
1333         * Scripts/update-webkit-libs-jhbuild:
1334         (cleanJhbuild): remove the Source directory as well when cleaning.
1335
1336 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
1337
1338         [EFL] Remove Intel Wk2 Buildbots from Master
1339         https://bugs.webkit.org/show_bug.cgi?id=116149
1340
1341         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
1342         since Gyuyoung Kim from Samsung plans to take over and maintain it.
1343
1344         Reviewed by Benjamin Poulain.
1345
1346         * BuildSlaveSupport/build.webkit.org-config/config.json:
1347
1348 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
1349
1350         [Windows] Update various build tools to understand VS2010 environment.
1351         https://bugs.webkit.org/show_bug.cgi?id=116169.
1352
1353         Reviewed by Anders Carlsson.
1354
1355         * Scripts/build-api-tests: Identify VS2010 environment.
1356         * Scripts/build-dumprendertree: Ditto.
1357         * Scripts/build-webkit: Ditto.
1358         * Scripts/webkitdirs.pm:
1359         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
1360         range of acceptable SDK's.
1361
1362 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
1363
1364         Allow http tests on Arch Linux
1365         https://bugs.webkit.org/show_bug.cgi?id=116155
1366
1367         Reviewed by Ryosuke Niwa.
1368
1369         * Scripts/webkitpy/port/base.py:
1370         (Port._is_arch_based): Added check for /etc/arch-release file.
1371         (Port._apache_config_file_name_for_platform): Call the check.
1372         * Scripts/webkitpy/port/port_testcase.py:
1373         (test_linux_distro_detection): Testcase added.
1374
1375 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
1376
1377         Remove a leftover v8 file from the watchlist
1378         https://bugs.webkit.org/show_bug.cgi?id=116158
1379
1380         Reviewed by Csaba Osztrogonác.
1381
1382         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
1383
1384 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
1385
1386         [GTK] Fails to build while generating gtkdoc
1387         https://bugs.webkit.org/show_bug.cgi?id=115612
1388
1389         Reviewed by Philippe Normand.
1390
1391         Fix typo in the prerequisites of docs-build.stamp.
1392
1393         * GNUmakefile.am:
1394
1395 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
1396
1397         Unreviewed, fixing the current test-webkitpy failure.
1398
1399         * Scripts/webkitpy/port/mac_unittest.py:
1400         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
1401         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
1402
1403 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
1404
1405         Fix build after r150090.
1406         https://bugs.webkit.org/show_bug.cgi?id=116129
1407
1408         Unreviewed build fix after r150090.
1409
1410         * WebKitTestRunner/TestInvocation.cpp:
1411         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1412
1413 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1414
1415         [Windows, others] Unreviewed build fix after r150090.
1416
1417         * DumpRenderTree/TestRunner.cpp:
1418         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
1419         doesn't exist on other platforms.
1420
1421 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
1422
1423         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
1424         https://bugs.webkit.org/show_bug.cgi?id=115889
1425
1426         Reviewed by Benjamin Poulain.
1427
1428         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1429         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1430
1431 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1432
1433         [Windows] Identify proper run environment for scripts.
1434         https://bugs.webkit.org/show_bug.cgi?id=116114
1435
1436         Reviewed by David Kilzer.
1437
1438         Determine (based on Visual Studio version) which path to use for
1439         executables (bin versus bin32).
1440
1441         * Scripts/webkitdirs.pm:
1442         (determineVisualStudioInstallDir): Added.
1443         (determineVisualStudioVersion): Added.
1444         (determineConfigurationProductDir): Modified to choose proper bin
1445         or bin32 directory.
1446         (visualStudioVersion): Added
1447         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
1448
1449 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1450
1451         [Mac] Add tests for secure event input
1452         https://bugs.webkit.org/show_bug.cgi?id=116121
1453
1454         Reviewed by Mark Rowe.
1455
1456         * DumpRenderTree/TestRunner.cpp:
1457         (getSecureEventInputIsEnabledCallback):
1458         (TestRunner::staticValues):
1459         Expose an accessor for current secure event input state.
1460
1461         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1462         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1463         (WTR::TestRunner::secureEventInputIsEnabled):
1464         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1465         * WebKitTestRunner/TestInvocation.cpp:
1466         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1467         Expose an accessor for current secure event input state. This has to be done in
1468         UI process, as this is where it's changed by WebKit.
1469
1470 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1471
1472         [Mac] Add a testing shim for secure event input functions
1473         https://bugs.webkit.org/show_bug.cgi?id=116122
1474
1475         Reviewed by Mark Rowe.
1476
1477         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
1478         Inject WebCore testing shim library to override system framework functions.
1479
1480 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1481
1482         [Windows] Switch to embedded manifest commands for launcher executables.
1483         https://bugs.webkit.org/show_bug.cgi?id=116109
1484
1485         Reviewed by Darin Adler.
1486
1487         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
1488         now-unused WinLauncher.exe.manifest file.
1489         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1490         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
1491         when building with VS2010 or newer.
1492
1493 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1494
1495         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
1496         https://bugs.webkit.org/show_bug.cgi?id=116079
1497
1498         Reviewed by David Kilzer.
1499
1500         * Scripts/old-run-webkit-tests:
1501         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
1502
1503 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
1504
1505         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
1506         https://bugs.webkit.org/show_bug.cgi?id=115921
1507
1508         Reviewed by Gustavo Noronha Silva.
1509
1510         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
1511         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
1512
1513 2013-05-13  Alex Christensen  <achristensen@apple.com>
1514
1515         Added testRunner.setPrinting.
1516         https://bugs.webkit.org/show_bug.cgi?id=42693
1517         rdar://problem/8213845
1518
1519         Reviewed by Darin Adler.
1520
1521         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1522         Added setPrinting JavaScript function.
1523         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1524         (WTR::InjectedBundlePage::dump):
1525         Dump the external representation for printing if setPrinting has been called.
1526         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1527         (WTR::TestRunner::isPrinting): Added.
1528         (WTR::TestRunner::setPrinting): Added.
1529         Added and initialized m_isPrinting member boolean.
1530
1531 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
1532
1533         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
1534         https://bugs.webkit.org/show_bug.cgi?id=116016
1535
1536         Reviewed by Dirk Pranke.
1537
1538         Same fix as in the upstream style checker, but without hg support.
1539         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
1540
1541         * Scripts/webkitpy/style/checkers/cpp.py:
1542         (FileInfo.repository_name):
1543
1544 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
1545
1546         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
1547         https://bugs.webkit.org/show_bug.cgi?id=115918
1548
1549         Reviewed by Gustavo Noronha Silva.
1550
1551         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
1552         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
1553         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
1554         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
1555         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
1556         problems.
1557
1558         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
1559         These are then used as dependencies for the archive creation rule as well as the list from which the archive
1560         file paths are constructed and then used to dump the member files from these archives. The member files are
1561         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
1562         successfully link.
1563
1564         * TestWebKitAPI/GNUmakefile.am:
1565
1566 2013-05-13  Anders Carlsson  <andersca@apple.com>
1567
1568         Remove UnusedParam.h
1569         https://bugs.webkit.org/show_bug.cgi?id=116029
1570
1571         Reviewed by Andreas Kling.
1572
1573         Stop including UnusedParam.h.
1574
1575         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1576         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1577
1578 2013-05-12  Commit Queue  <commit-queue@webkit.org>
1579
1580         Unreviewed, rolling out r149955.
1581         http://trac.webkit.org/changeset/149955
1582         https://bugs.webkit.org/show_bug.cgi?id=115990
1583
1584         Broke lots of tests (Requested by smfr on #webkit).
1585
1586         * Scripts/webkitpy/port/mac.py:
1587
1588 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1589
1590         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
1591         https://bugs.webkit.org/show_bug.cgi?id=115914
1592
1593         Reviewed by Martin Robinson.
1594
1595         * GtkLauncher/main.c:
1596         (createToolbar):
1597         * MiniBrowser/gtk/BrowserWindow.c:
1598         (_BrowserWindow):
1599         (browserWindowSetStatusText):
1600         (fullScreenMessageTimeoutCallback):
1601         (webViewEnterFullScreen):
1602         (webViewLeaveFullScreen):
1603         (browserWindowFinalize):
1604         (browserWindowConstructed):
1605         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1606         (WTR::EventSenderProxy::mouseScrollBy):
1607         (WTR::EventSenderProxy::continuousMouseScrollBy):
1608
1609 2013-05-11  Anders Carlsson  <andersca@apple.com>
1610
1611         Crash when terminating a process that has not been fully launched
1612         https://bugs.webkit.org/show_bug.cgi?id=115962
1613         <rdar://problem/13660916>
1614
1615         Reviewed by Andreas Kling.
1616
1617         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
1618         before the process has had a chance to be fully launched.
1619
1620         * TestWebKitAPI/GNUmakefile.am:
1621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1622         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
1623         (TestWebKitAPI):
1624         (TestWebKitAPI::didFinishLoadForFrame):
1625         (TestWebKitAPI::TEST):
1626         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1627
1628 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
1629
1630         Remove Mac OS X Leopard (10.5) support
1631         https://bugs.webkit.org/show_bug.cgi?id=107964
1632
1633         Reviewed by Ryosuke Niwa.
1634
1635         Removed the code for 10.5 and removed if-def for 10.6.
1636
1637         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1638         (convertMIMEType):
1639         (createXMLStringFromWebArchiveData):
1640         * DumpRenderTree/mac/TestRunnerMac.mm:
1641         (TestRunner::authenticateSession):
1642         (TestRunner::setTextDirection):
1643         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1644         (convertMIMEType):
1645         (createXMLStringFromWebArchiveData):
1646
1647 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
1648
1649         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
1650         https://bugs.webkit.org/show_bug.cgi?id=115935
1651
1652         Reviewed by Jer Noble.
1653
1654         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
1655         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
1656         to the new manifest file.
1657         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1658
1659 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
1660
1661         Fix some compiler warnings (miscellaneous)
1662         https://bugs.webkit.org/show_bug.cgi?id=80790
1663
1664         Reviewed by Rob Buis.
1665
1666         Fix the following warnings for BlackBerry:
1667         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
1668         used as truth value [-Wparentheses].
1669
1670         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1671         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1672
1673 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1674
1675         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
1676         https://bugs.webkit.org/show_bug.cgi?id=115928
1677
1678         Reviewed by Kenneth Rohde Christiansen.
1679
1680         WKViewSetThemePath was moved to WKViewEfl.h.
1681
1682         * TestWebKitAPI/efl/PlatformWebView.cpp:
1683
1684 2013-05-10  Andreas Kling  <akling@apple.com>
1685
1686         I accidentally the Java testing.
1687
1688         * Scripts/webkitpy/port/mac.py:
1689
1690 2013-05-10  Brian Holt  <brian.holt@samsung.com>
1691
1692         [GTK] Module Cairo fails to build under jhbuild
1693         https://bugs.webkit.org/show_bug.cgi?id=115854
1694
1695         Reviewed by Martin Robinson.
1696
1697         Make cairo depend on glib in jhbuild.modules.
1698
1699         * gtk/jhbuild.modules:
1700
1701 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1702
1703         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
1704         https://bugs.webkit.org/show_bug.cgi?id=115904
1705
1706         Reviewed by Martin Robinson.
1707
1708         * ImageDiff/gtk/ImageDiff.cpp:
1709         (main):
1710
1711 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
1712
1713         Add my new address to contributors.json. (Unreviewed)
1714
1715         * Scripts/webkitpy/common/config/contributors.json:
1716
1717 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1718
1719         Unreviewed. Move myself to the reviewers list.
1720
1721         * Scripts/webkitpy/common/config/contributors.json:
1722
1723 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1724
1725         Unreviewed. Add my email to a few watchlists.
1726
1727         * Scripts/webkitpy/common/config/watchlist:
1728
1729 2013-05-10  Simon Pena  <simon.pena@samsung.com>
1730
1731         Unicode support missing from string representation of Contributors in committers.py
1732         https://bugs.webkit.org/show_bug.cgi?id=115859
1733
1734         Reviewed by Darin Adler.
1735
1736         Contributors, in committers.py, provided a string representation in __str__ which
1737         didn't support unicode characters, so printing a contributor would fail in that case.
1738         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
1739         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
1740
1741         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
1742         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
1743         representation.
1744         (Contributor.__str__):
1745         (Contributor):
1746         (Contributor.__unicode__):
1747         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
1748         a contributor with unicode characters can be represented as a string.
1749         (CommittersTest):
1750         (CommittersTest.test_contributor_encoding):
1751
1752 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1753
1754         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
1755         https://bugs.webkit.org/show_bug.cgi?id=92371
1756
1757         Reviewed by Brent Fulgham.
1758
1759         Use JavaScriptThreading.cpp where the same functionality is
1760         implemented too. This reduces the dependency on the pthread
1761         library. Also replace assert() with WebKit ASSERT().
1762
1763         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1764         * DumpRenderTree/win/DumpRenderTree.cpp:
1765         (dumpHistoryItem):
1766         (dumpBackForwardList):
1767         * DumpRenderTree/win/DumpRenderTree.vcproj:
1768
1769 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1770
1771         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
1772         https://bugs.webkit.org/show_bug.cgi?id=92505
1773
1774         Reviewed by Brent Fulgham.
1775
1776         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1777         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
1778         (javaScriptThreadsMutex):
1779         (javaScriptThreads):
1780         (runJavaScriptThread):
1781         (startJavaScriptThreads):
1782         (stopJavaScriptThreads):
1783         * DumpRenderTree/pthreads: Removed.
1784         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
1785
1786 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1787
1788         Unreviewed. Update Simon Pena email on his behalf.
1789
1790         * Scripts/webkitpy/common/config/contributors.json:
1791
1792 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1793
1794         Add support for [NoInterfaceObject] Web IDL extended attribute
1795         https://bugs.webkit.org/show_bug.cgi?id=115714
1796
1797         Reviewed by Kentaro Hara.
1798
1799         Update BindingsTests.generate_supplemental_dependency() to pass an
1800         additional windowConstructorsFile argument to preprocess-idls.pl.
1801
1802         * Scripts/webkitpy/bindings/main.py:
1803         (BindingsTests.generate_supplemental_dependency):
1804         (BindingsTests.main):
1805
1806 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
1807
1808         [GTK][AC] Buildfix after r149694
1809         https://bugs.webkit.org/show_bug.cgi?id=115797
1810
1811         Reviewed by Gustavo Noronha Silva.
1812
1813         Add CLUTTER_LIBS for linking TestWebCore.
1814
1815         * TestWebKitAPI/GNUmakefile.am:
1816
1817 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1818
1819         [EFL] Remove unnecessary pkgs in EFL jhbuild
1820         https://bugs.webkit.org/show_bug.cgi?id=114908
1821
1822         Reviewed by Laszlo Gombos.
1823
1824         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
1825         handle them using jhbuild. We can reduce build time when using --update-efl.
1826
1827         * efl/jhbuild.modules:
1828
1829 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
1830
1831         [EFL] Disable SHADOW DOM feature in FeatureList.pm
1832         https://bugs.webkit.org/show_bug.cgi?id=115834
1833
1834         Reviewed by Gyuyoung Kim.
1835
1836         * Scripts/webkitperl/FeatureList.pm:
1837
1838 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1839
1840         Add Scheduler for Mac MtnLion 32bit Release builder.
1841
1842         Unreviewed.
1843
1844         * BuildSlaveSupport/build.webkit.org-config/config.json:
1845
1846 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
1847
1848         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
1849         https://bugs.webkit.org/show_bug.cgi?id=115808
1850
1851         Reviewed by Darin Adler.
1852
1853         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
1854         was left outdated after r127191, when the m_string member was changed
1855         from UString to String. This patch calls the right pretty printer for it.
1856
1857         * gdb/webkit.py:
1858         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
1859         WTFImplPrettyPrinter.
1860
1861 2013-05-08  Andy Estes  <aestes@apple.com>
1862
1863         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
1864         https://bugs.webkit.org/show_bug.cgi?id=115790
1865
1866         Reviewed by Alexey Proskuryakov.
1867
1868         Added two API tests:
1869
1870         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
1871         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
1872
1873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1874         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
1875         (TestWebKitAPI):
1876         (TestWebKitAPI::TEST):
1877         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
1878         (TestWebKitAPI):
1879         (TestWebKitAPI::decidePolicyForNavigationAction):
1880         (CustomProtocolInvalidSchemeTest):
1881         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
1882
1883 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1884
1885         Teach buildbot how to compile 32-bit on Mac.
1886
1887         Reviewed by Ryosuke Niwa.
1888
1889         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1890         (CompileWebKit.start):
1891         (ExtractTestResultsAndLeaks):
1892
1893 2013-05-08  Eli Fidler  <efidler@blackberry.com>
1894
1895         [BlackBerry] Fix usage of BlackBerry::Platform::String
1896         https://bugs.webkit.org/show_bug.cgi?id=115781
1897
1898         Reviewed by Rob Buis.
1899
1900         BlackBerry PRs 304193 and 327181
1901         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1902
1903         We currently have a problem where we're passing UTF-8 encoded data into
1904         the char* constructors of BlackBerry::Platform::String. This means the string
1905         thinks its data is not UTF-8.
1906
1907         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1908         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1909         (BlackBerry::WebKit::dumpHistoryItem):
1910         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1911         (TestRunner::setUserStyleSheetLocation):
1912         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1913         (LoadHTMLStringItem::invoke):
1914
1915 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
1916
1917         Tools: add new BlackBerry include dirs.
1918         https://bugs.webkit.org/show_bug.cgi?id=115514
1919
1920         Reviewed by Rob Buis.
1921
1922         iType include dirs are missing, and HarfBuzz needs to be fixed.
1923
1924         * Scripts/webkitdirs.pm:
1925         (blackberryCMakeArguments):
1926
1927 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1928
1929         [GTK] Plumb the Automake build system for the Battery Status API feature
1930         https://bugs.webkit.org/show_bug.cgi?id=115718
1931
1932         Reviewed by Martin Robinson.
1933
1934         * Scripts/webkitdirs.pm:
1935         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
1936         through the --(enable|disable)-battery-status flag passed to configure.
1937
1938 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
1939
1940         new-run-webkit-websocketserver doesn't work after Chromium removal
1941         https://bugs.webkit.org/show_bug.cgi?id=115816
1942
1943         Reviewed by Joseph Pecoraro.
1944
1945         Fix the bug by instantiating the correct port object.
1946
1947         * Scripts/new-run-webkit-websocketserver:
1948         (main):
1949
1950 2013-05-07  Lucas Forschler  <lforschler@apple.com>
1951
1952         Configure buildbot for 32bit builder.
1953         https://bugs.webkit.org/show_bug.cgi?id=115769
1954
1955         Reviewed by Ryosuke Niwa.
1956
1957         * BuildSlaveSupport/build.webkit.org-config/config.json:
1958
1959 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
1960
1961         Unreviewed. Update to show my apple.com address.
1962
1963         * Scripts/webkitpy/common/config/contributors.json: Added
1964         my apple.com e-mail address.
1965
1966 2013-05-08  David Kilzer  <ddkilzer@apple.com>
1967
1968         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
1969
1970         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1971         (concatenateAttributeAndValue): Switch to appendVector().
1972
1973 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1974
1975         [Qt][WTR] Fix the build on Mac after r149692
1976
1977         Unreviewed build fix.
1978
1979         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1980         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1981
1982 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1983
1984         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
1985         to the watchlist for Accessibility.
1986
1987         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
1988         * Scripts/webkitpy/common/config/watchlist: Added myself.
1989
1990 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1991
1992         [Qt] Build fails with clang
1993         https://bugs.webkit.org/show_bug.cgi?id=115741
1994
1995         Reviewed by Benjamin Poulain.
1996
1997         Since r149112 std::move is used in AtomicString for compilers that
1998         support rvalue references and this requires a standard library
1999         implementing c++11 move semantics.
2000         We only explicitely require c++11 for WebKit2, but since clang supports
2001         rvalue references the build of subtargets using AtomicString fails because
2002         of missing std::move.
2003         It is safe to add CONFIG += c++11 for the whole project when using clang
2004         since we explicitely disable c++11 for ANGLE that had probems with libc++.
2005
2006         * qmake/mkspecs/features/unix/default_pre.prf:
2007
2008 2013-05-08  Darin Adler  <darin@apple.com>
2009
2010         Fix one more place that needed to use adoptCF/NS
2011         https://bugs.webkit.org/show_bug.cgi?id=115778
2012
2013         Reviewed by Benjamin Poulain.
2014
2015         Not sure why I missed this code last time, but found a bit more code that needs
2016         to switch to the newer style adoptCF/NS.
2017
2018         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
2019         (convertWebResourceDataToString): Use adoptCF.
2020         (convertWebResourceResponseToDictionary): Ditto.
2021         (createXMLStringFromWebArchiveData): Ditto.
2022         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
2023         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
2024
2025 2013-05-08  Commit Queue  <commit-queue@webkit.org>
2026
2027         Unreviewed, rolling out r149271.
2028         http://trac.webkit.org/changeset/149271
2029         https://bugs.webkit.org/show_bug.cgi?id=115780
2030
2031         The mangled symbols are now enforced through LDFLAGS
2032         (Requested by zdobersek on #webkit).
2033
2034         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2035
2036 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
2037
2038         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
2039         https://bugs.webkit.org/show_bug.cgi?id=115636
2040
2041         Reviewed by Ryosuke Niwa.
2042
2043         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2044         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
2045         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
2046         while Chromium-specific, can't be removed just yet as there's more code that uses it.
2047
2048 2013-05-06  Darin Adler  <darin@apple.com>
2049
2050         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
2051         https://bugs.webkit.org/show_bug.cgi?id=115657
2052
2053         Reviewed by Sam Weinig.
2054
2055         This is similar to my last set of changes, but covers code that I missed with
2056         global replace using the Safari Xcode workspace.
2057
2058         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2059         (convertWebResourceDataToString):
2060         (convertWebResourceResponseToDictionary):
2061         (createXMLStringFromWebArchiveData):
2062         * DumpRenderTree/cg/ImageDiffCG.cpp:
2063         (createImageFromStdin):
2064         (createDifferenceImage):
2065         (main):
2066         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2067         (printPNG):
2068         (dumpBitmap):
2069         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2070         (BitmapContext::BitmapContext):
2071         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2072         (-[MockWebNotificationProvider init]):
2073         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2074         (createBitmapContext):
2075         * DumpRenderTree/mac/TestRunnerMac.mm:
2076         (TestRunner::addDisallowedURL):
2077         (TestRunner::applicationCacheDiskUsageForOrigin):
2078         (TestRunner::localStorageDiskUsageForOrigin):
2079         (TestRunner::clearApplicationCacheForOrigin):
2080         (TestRunner::deleteLocalStorageForOrigin):
2081         (TestRunner::copyDecodedHostName):
2082         (TestRunner::copyEncodedHostName):
2083         (TestRunner::queueLoad):
2084         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2085         (TestRunner::setMockGeolocationPositionUnavailableError):
2086         (TestRunner::setUserStyleSheetLocation):
2087         (TestRunner::setValueForUser):
2088         (TestRunner::overridePreference):
2089         (TestRunner::setPersistentUserStyleSheetLocation):
2090         (TestRunner::execCommand):
2091         (TestRunner::findString):
2092         (TestRunner::isCommandEnabled):
2093         (TestRunner::addOriginAccessWhitelistEntry):
2094         (TestRunner::removeOriginAccessWhitelistEntry):
2095         (TestRunner::addUserScript):
2096         (TestRunner::addUserStyleSheet):
2097         (TestRunner::evaluateInWebInspector):
2098         (TestRunner::evaluateScriptInIsolatedWorld):
2099         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2100         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
2101         (TestRunner::authenticateSession):
2102         (TestRunner::grantWebNotificationPermission):
2103         (TestRunner::denyWebNotificationPermission):
2104         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2105         (createCFURLResponseFromResponseData):
2106         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2107         (LoadItem::invoke):
2108         (LoadHTMLStringItem::invoke):
2109         (ScriptItem::invoke):
2110         * DumpRenderTree/win/DumpRenderTree.cpp:
2111         (substringFromIndex):
2112         (urlSuitableForTestResult):
2113         (lastPathComponent):
2114         (sharedCFURLCache):
2115         * DumpRenderTree/win/ImageDiffCairo.cpp:
2116         (createImageFromStdin):
2117         (main):
2118         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2119         (createBitmapContextFromWebView):
2120         * DumpRenderTree/win/TestRunnerWin.cpp:
2121         (TestRunner::setUserStyleSheetLocation):
2122         (TestRunner::setPersistentUserStyleSheetLocation):
2123         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2124         (TestWebKitAPI::TEST):
2125         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2126         (TestWebKitAPI::TEST):
2127         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2128         (TestWebKitAPI::TEST):
2129         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2130         (TestWebKitAPI::TEST):
2131         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2132         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2133         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2134         (TestWebKitAPI::createWindow):
2135         (TestWebKitAPI::TEST):
2136         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2137         (TestWebKitAPI::TEST):
2138         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
2139         (TestWebKitAPI::AcceptsFirstMouse::runTest):
2140         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2141         (TestWebKitAPI::TEST):
2142         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
2143         (TestWebKitAPI::TEST):
2144         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
2145         (TestWebKitAPI::TEST):
2146         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2147         (TestWebKitAPI::TEST):
2148         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
2149         (TestWebKitAPI::TEST):
2150         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2151         (TestWebKitAPI::TEST):
2152         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
2153         (TestWebKitAPI::TEST):
2154         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2155         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
2156         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2157         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
2158         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
2159         (TestWebKitAPI::TEST):
2160         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
2161         (TestWebKitAPI::TEST):
2162         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2163         (TestWebKitAPI::TEST):
2164         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
2165         (TestWebKitAPI::TEST):
2166         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
2167         (TestWebKitAPI::TEST):
2168         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2169         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2170         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2171         (TestWebKitAPI::TEST):
2172         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2173         (TestWebKitAPI::TEST):
2174         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
2175         (TestWebKitAPI::TEST):
2176         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2177         (TestWebKitAPI::TEST):
2178         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2179         (TestWebKitAPI::TEST):
2180         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2181         (TestWebKitAPI::TEST):
2182         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
2183         (TestWebKitAPI::TEST):
2184         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2185         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2186         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2187         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
2188         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2189         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
2190         (WTR::testPathFromURL):
2191         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2192         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2193         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2194         (WTR::createCGContextFromImage):
2195         (WTR::dumpBitmap):
2196         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2197         * WebKitTestRunner/mac/EventSenderProxy.mm:
2198         (WTR::EventSenderProxy::mouseScrollBy):
2199         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2200         (WTR::PlatformWebView::windowSnapshotImage):
2201         * WebKitTestRunner/win/TestControllerWin.cpp:
2202         (WTR::TestController::initializeTestPluginDirectory):
2203         Use adoptCF and adoptNS.
2204
2205 2013-05-07  Alex Christensen  <achristensen@apple.com>
2206
2207         Fix a memory leak introduced in r149692
2208         https://bugs.webkit.org/show_bug.cgi?id=115766
2209
2210         Reviewed by Mark Rowe.
2211
2212         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
2213         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
2214
2215         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2216         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2217         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
2218
2219 2013-05-07  Darin Adler  <darin@apple.com>
2220
2221         [Win] Fix storage leak in Windows DumpRenderTree
2222         https://bugs.webkit.org/show_bug.cgi?id=115651
2223
2224         Reviewed by Sam Weinig.
2225
2226         * DumpRenderTree/win/DumpRenderTree.cpp:
2227         (lastPathComponent): Added a missing call to adoptCF.
2228
2229 2013-05-07  Alex Christensen  <achristensen@apple.com>
2230
2231         fixed a memory leak introduced by bug 42324 by using a RetainPtr
2232         https://bugs.webkit.org/show_bug.cgi?id=115760
2233
2234         Reviewed by Tim Horton.
2235
2236         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2237         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2238         fixed memory leak, added UNUSED_PARAM macros
2239
2240 2013-05-07  Alex Christensen  <achristensen@apple.com>
2241
2242         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
2243         https://bugs.webkit.org/show_bug.cgi?id=42324
2244         <rdar://problem/8193633>
2245
2246         Reviewed by Tim Horton.
2247
2248         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2249         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
2250         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2251         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2252         Added dumpDOMAsWebArchive code that is called when dumping.
2253         (WTR::InjectedBundlePage::dump):
2254         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
2255         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2256         (InjectedBundlePage):
2257         Added dumpDOMAsWebArchive declaration.
2258         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
2259         (WTR::TestRunner::dumpDOMAsWebArchive):
2260         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
2261         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2262         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
2263         * Tools/WebKitTestRunner/cf: Added.
2264         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
2265         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
2266         (convertMIMEType):
2267         (convertWebResourceDataToString):
2268         (normalizeHTTPResponseHeaderFields):
2269         (normalizeWebResourceURL):
2270         (convertWebResourceResponseToDictionary):
2271         (compareResourceURLs):
2272         (createXMLStringFromWebArchiveData):
2273         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
2274         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
2275         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
2276         Copied from Tools/DumpRenderTree/mac for used functions.
2277         (createCFURLResponseFromResponseData):
2278         (supportedNonImageMIMETypes):
2279
2280 2013-05-07  Alex Christensen  <achristensen@apple.com>
2281
2282         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
2283         https://bugs.webkit.org/show_bug.cgi?id=115745
2284
2285         Reviewed by Tim Horton.
2286
2287         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2288         (compareResourceURLs):
2289         Updated style.
2290
2291 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
2292
2293         Add an 'isReadOnly' member to IDL parse tree structure
2294         https://bugs.webkit.org/show_bug.cgi?id=115704
2295
2296         Reviewed by Kentaro Hara.
2297
2298         Use newly added isReadOnly attribute.
2299
2300         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2301         (_generateHeaderFile):
2302         (_generateImplementationFile):
2303         (_staticValuesGetterImplementation):
2304
2305 2013-05-07  Anders Carlsson  <andersca@apple.com>
2306
2307         Remove AlwaysInline.h from WTF
2308         https://bugs.webkit.org/show_bug.cgi?id=115727
2309
2310         Reviewed by Brent Fulgham.
2311
2312         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
2313         to keep AlwaysInline.h around anymore.
2314
2315         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2316         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2317
2318 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
2319
2320         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
2321         https://bugs.webkit.org/show_bug.cgi?id=114808
2322
2323         Reviewed by Jocelyn Turcotte.
2324
2325         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
2326         (https://codereview.qt-project.org/#change,54234)
2327
2328         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2329         (WTR::WrapperWindow::handleStatusChanged):
2330
2331 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2332
2333         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
2334
2335         * Scripts/webkitpy/common/config/watchlist:
2336
2337 2013-05-06  Kangil Han  <kangil.han@samsung.com>
2338
2339         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
2340         https://bugs.webkit.org/show_bug.cgi?id=115645
2341
2342         Reviewed by Gyuyoung Kim.
2343
2344         To run performance tests in wk1, we need --no-timeout option implementation.
2345         So adopt it from gtk+ port.
2346
2347         * DumpRenderTree/efl/DumpRenderTree.cpp:
2348         (shouldSetWaitToDumpWatchdog):
2349         (parseCommandLineOptions):
2350         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
2351         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2352         (TestRunner::setWaitToDump):
2353
2354 2013-05-06  Commit Queue  <commit-queue@webkit.org>
2355
2356         Unreviewed, rolling out r149547.
2357         http://trac.webkit.org/changeset/149547
2358         https://bugs.webkit.org/show_bug.cgi?id=115682
2359
2360         Added unittests that fail on bots and spits out text into
2361         stdout (Requested by rniwa on #webkit).
2362
2363         * Scripts/import-w3c-tests: Removed.
2364         * Scripts/webkitpy/w3c/__init__.py: Removed.
2365         * Scripts/webkitpy/w3c/test_converter.py: Removed.
2366         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
2367         * Scripts/webkitpy/w3c/test_importer.py: Removed.
2368         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
2369         * Scripts/webkitpy/w3c/test_parser.py: Removed.
2370         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
2371
2372 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
2373
2374         [jhbuild] bump jhbuild version to take advantage of new improvements
2375         https://bugs.webkit.org/show_bug.cgi?id=115558
2376
2377         Reviewed by Martin Robinson.
2378
2379         One of the important improvements is jhbuild no longer fetches git
2380         repositories if they are already at the expected revision, which should
2381         make the EWS bots more robust to git servers unavailability.
2382
2383         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
2384
2385 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
2386
2387         [GTK] Add webkit_uri_scheme_request_finish_error
2388         https://bugs.webkit.org/show_bug.cgi?id=94316
2389
2390         Reviewed by Anders Carlsson.
2391
2392         * MiniBrowser/gtk/main.c:
2393         (miniBrowserErrorQuark): Add function to create a global quark for
2394         MiniBrowser.
2395         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
2396         function webkit_uri_scheme_request_finish_error().
2397
2398 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
2399
2400         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
2401         https://bugs.webkit.org/show_bug.cgi?id=113808
2402
2403         Reviewed by Rob Buis.
2404
2405         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
2406         to true for BlackBerry.
2407
2408         * Scripts/webkitperl/FeatureList.pm:
2409
2410 2013-05-06  Jessie Berlin  <jberlin@apple.com>
2411
2412         check-webkit-style should complain about a layering violation if platform-specific guards are
2413         used in WebCore outside of the platform directory
2414         https://bugs.webkit.org/show_bug.cgi?id=115567
2415
2416         Reviewed by Benjamin Poulain.
2417
2418         * Scripts/webkitpy/style/checkers/cpp.py:
2419         (check_for_webcore_platform_layering_violation):
2420         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
2421         (process_line):
2422         Add the check_for_webcore_platform_layering_violation.
2423         (CppChecker):
2424         List the new check.
2425
2426         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2427         (CppStyleTest.test_webcore_platform_layering_violation):
2428         Add tests.
2429
2430 2013-05-06  David Kilzer  <ddkilzer@apple.com>
2431
2432         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
2433         <http://webkit.org/b/115667>
2434
2435         Reviewed by Dirk Pranke.
2436
2437         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2438         (Bugzilla._check_create_bug_response): Update regex to work with
2439         Bugzilla 3.2.3 and 4.2.5.
2440         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2441         (test__check_create_bug_response): Add new test that covers both
2442         old and new <title> variations.
2443
2444 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2445
2446         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
2447         https://bugs.webkit.org/show_bug.cgi?id=115661
2448
2449         Reviewed by Ryosuke Niwa.
2450
2451         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
2452         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
2453         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
2454
2455         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2456         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2457
2458 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2459
2460         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
2461         https://bugs.webkit.org/show_bug.cgi?id=114603
2462
2463         Reviewed by Ryosuke Niwa.
2464
2465         * TestResultServer/generate_builders_json.py:
2466         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
2467         to represent these to be 'layout-test', for backwards compatibility.
2468         (main): Remove all the build.chromium.org masters.
2469         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
2470         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2471         (GenerateBuildersJsonTest):
2472         (GenerateBuildersJsonTest.test_generate_json_data):
2473         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
2474         test-running builders from the webkit.org master.
2475
2476 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2477
2478         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
2479         https://bugs.webkit.org/show_bug.cgi?id=114988
2480
2481         Reviewed by Ryosuke Niwa.
2482
2483         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
2484         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
2485         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
2486         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
2487         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
2488
2489 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2490
2491         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
2492         https://bugs.webkit.org/show_bug.cgi?id=114954
2493
2494         Reviewed by Ryosuke Niwa.
2495
2496         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2497         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
2498         modifier unions in the list of modifiers.
2499         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
2500         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
2501
2502 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2503
2504         [Flakiness Dashboard] Simplify builder-name-based platform recognition
2505         https://bugs.webkit.org/show_bug.cgi?id=114957
2506
2507         Reviewed by Ryosuke Niwa.
2508
2509         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2510         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
2511         (chromiumPlatform): Removed, unnecessary.
2512         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
2513         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
2514         the builder operates with debug builds, no webkit.org builders are named this way.
2515         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2516         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
2517
2518 2013-05-06  Andy Estes  <aestes@apple.com>
2519
2520         Added two files I neglected to commit in r149589.
2521
2522         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2523         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2524
2525 2013-05-04  Andy Estes  <aestes@apple.com>
2526
2527         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
2528         https://bugs.webkit.org/show_bug.cgi?id=115609
2529
2530         Reviewed by Oliver Hunt.
2531
2532         Added an API test.
2533
2534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2535         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2536         (+[TestDelegate shared]):
2537         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2538         (-[TestDelegate webView:createWebViewWithRequest:]):
2539         (TestWebKitAPI):
2540         (TestWebKitAPI::TEST):
2541         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2542
2543 2013-05-06  Antoine Quint  <graouts@apple.com>
2544
2545         Manage the presentation of the snapshotted plug-in using JavaScript
2546         https://bugs.webkit.org/show_bug.cgi?id=115548
2547
2548         Reviewed by Dean Jackson.
2549
2550         Take into account the new plugInExtraScript method added to support
2551         the injection of a JS file from the chrome client to customize the
2552         rendering of a snapshotted plug-in's shadow tree.
2553
2554         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2555         (WTR::InjectedBundlePage::InjectedBundlePage):
2556
2557 2013-05-05  Anders Carlsson  <andersca@apple.com>
2558
2559         Remove the Vector::append overload that takes a Vector
2560         https://bugs.webkit.org/show_bug.cgi?id=115535
2561
2562         Reviewed by Andreas Kling.
2563
2564         Use Vector::appendVector instead.
2565
2566         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2567         (concatenateAttributeAndValue):
2568         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2569         (WTR::concatenateAttributeAndValue):
2570
2571 2013-05-04  Sam Weinig  <sam@webkit.org>
2572
2573         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
2574         <rdar://problem/13702008>
2575         https://bugs.webkit.org/show_bug.cgi?id=115607
2576
2577         Reviewed by Benjamin Poulain.
2578
2579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2580         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
2581         (TestWebKitAPI::didFinishLoadForFrame):
2582         (TestWebKitAPI::TEST):
2583         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
2584
2585 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2586
2587         Unreviewed.
2588
2589         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
2590
2591 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
2592
2593         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
2594
2595         * Scripts/webkitpy/common/config/contributors.json:
2596
2597 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2598
2599         [GTK] Catch select.error exceptions in parse_output_lines
2600         https://bugs.webkit.org/show_bug.cgi?id=115253
2601
2602         Reviewed by Gustavo Noronha Silva.
2603
2604         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
2605         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
2606         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
2607         error code and the error message) and the loop is re-entered.
2608
2609         * gtk/common.py:
2610         (parse_output_lines):
2611
2612 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2613
2614         [GTK] Set up the TestWebCore in TestWebKitAPI
2615         https://bugs.webkit.org/show_bug.cgi?id=115237
2616
2617         Reviewed by Gustavo Noronha Silva.
2618
2619         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2620         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2621         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2622         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2623         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2624
2625         * TestWebKitAPI/GNUmakefile.am:
2626
2627 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
2628
2629         Create a script to import W3C tests
2630         https://bugs.webkit.org/show_bug.cgi?id=111513
2631
2632         Reviewed by Dirk Pranke.
2633
2634         Script to automate the import of W3C tests into WebKit.
2635         For the full description of how it works, see the comments
2636         at the top of test_importer.py.
2637
2638         * Scripts/import-w3c-tests: Added.
2639         * Scripts/webkitpy/w3c/__init__.py: Added.
2640         * Scripts/webkitpy/w3c/test_converter.py: Added.
2641         (TestConverter):
2642         (TestConverter.__init__):
2643         (TestConverter.load_prefixed_prop_list):
2644         (TestConverter.load_file):
2645         (TestConverter.convert_for_webkit):
2646         (TestConverter.convert_testharness_paths):
2647         (TestConverter.convert_prefixed_properties):
2648         (TestConverter.scrub_unprefixed_props):
2649         (TestConverter.replace_tag):
2650         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2651         (TestConverterTest):
2652         (TestConverterTest.testLoadPrefixedPropList):
2653         (TestConverterTest.test_convertForWebkitNothingToConvert):
2654         (test_convertForWebkitHarnessOnly):
2655         (test_convertForWebkitPropsOnly):
2656         (test_convertForWebkitHarnessAndProps):
2657         (test_convertTestHarnessPaths):
2658         (test_convertPrefixedProperties):
2659         (verifyTestHarnessPaths):
2660         (verifyPrefixedProperties):
2661         (generateTestContent):
2662         * Scripts/webkitpy/w3c/test_importer.py: Added.
2663         (main):
2664         (parse_args):
2665         (validate_import_directory):
2666         (TestImporter):
2667         (TestImporter.__init__):
2668         (TestImporter.do_import):
2669         (TestImporter.get_changeset):
2670         (TestImporter.scan_source_directory):
2671         (TestImporter.import_tests):
2672         (TestImporter.setup_destination_directory):
2673         (TestImporter.get_test_status):
2674         (TestImporter.remove_deleted_files):
2675         (TestImporter.write_import_log):
2676         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2677         (TestImporterTest):
2678         (TestImporterTest.test_ImportDirWithNoTests):
2679         * Scripts/webkitpy/w3c/test_parser.py: Added.
2680         (TestParser):
2681         (TestParser.__init__):
2682         (TestParser.load_file):
2683         (TestParser.analyze_test):
2684         (TestParser.get_reftests):
2685         (TestParser.is_jstest):
2686         (TestParser.get_support_files):
2687         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2688         (TestParserTest):
2689         (TestParserTest.test_analyzeTestReftestOneMatch):
2690         (test_analyzeTestReftestMultipleMatches):
2691         (test_analyzeTestReftestMatchAndMismatch):
2692         (test_analyzeTestReftestWithRefSupportFiles):
2693         (test_analyzeJSTest):
2694         (test_analyzePixelTestAllTrue):
2695         (test_analyzePixelTestAllFalse):
2696         (test_analyzeNonHTMLFile):
2697
2698 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2699
2700         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
2701
2702         * Scripts/webkitpy/common/config/contributors.json:
2703
2704 2013-05-02  Nico Weber  <thakis@chromium.org>
2705
2706         Remove a stale script file.
2707         https://bugs.webkit.org/show_bug.cgi?id=115521
2708
2709         Reviewed by Anders Carlsson.
2710
2711         This script was added in
2712         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
2713         Bakefile system that was removed in
2714         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
2715         script just asserts when it's run and is useless.
2716
2717         * Scripts/update-sources-list.py: Removed.
2718
2719 2013-05-01  Glenn Adams  <glenn@skynav.com>
2720
2721         [webkitpy] Need abstract base class for commands that analyze commit logs
2722         https://bugs.webkit.org/show_bug.cgi?id=115391
2723
2724         Reviewed by Benjamin Poulain.
2725
2726         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
2727         in preparation for adding two new commands that will reuse this functionality along with
2728         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
2729         https://bugs.webkit.org/show_bug.cgi?id=115388.
2730
2731         No new tests as this patch does not change existing functionality or behavior.
2732
2733         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2734         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
2735         (AbstractCommitLogCommand.__init__):
2736         (AbstractCommitLogCommand._init_options):
2737         (AbstractCommitLogCommand._parse_commit_message):
2738         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
2739         (SuggestNominations.__init__):
2740         (SuggestNominations._init_options):
2741
2742 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
2743
2744         Web Inspector: Fix check-inspector-strings script and fix localized strings
2745         https://bugs.webkit.org/show_bug.cgi?id=115495
2746
2747         Reviewed by Joseph Pecoraro.
2748
2749         * Scripts/check-inspector-strings:
2750
2751 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2752
2753         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
2754         https://bugs.webkit.org/show_bug.cgi?id=115470
2755
2756         Reviewed by Martin Robinson.
2757
2758         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
2759         not building either of the IOS, Windows or GTK-WK1 platforms.
2760
2761         Up until now the header was included for everything but the IOS and Windows platforms due to
2762         an incorrectly stated condition regarding the GTK platform.
2763
2764         * TestWebKitAPI/config.h:
2765
2766 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2767
2768         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
2769         https://bugs.webkit.org/show_bug.cgi?id=115469
2770
2771         Reviewed by Martin Robinson.
2772
2773         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
2774         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
2775         for the WebKit2 tests and the injected bundle required by them.
2776
2777         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
2778         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
2779         under the WebKit2 code).
2780
2781         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
2782         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
2783         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
2784
2785         * TestWebKitAPI/GNUmakefile.am:
2786
2787 2013-04-30  Glenn Adams  <glenn@skynav.com>
2788
2789         Unreviewed. Add myself to watchlist entries.
2790
2791         * Scripts/webkitpy/common/config/watchlist:
2792
2793 2013-04-30  Glenn Adams  <glenn@skynav.com>
2794
2795         [webkitpy] suggest-nominations doesn't count all qualified patches
2796         https://bugs.webkit.org/show_bug.cgi?id=115285
2797
2798         Reviewed by Benjamin Poulain.
2799
2800         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
2801         nomination. Improve commit log parsing.
2802
2803         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2804         (CommitLogError):
2805         (CommitLogError.__init__):
2806         (CommitLogMissingReviewer):
2807         (CommitLogMissingReviewer.__init__):
2808         (SuggestNominations):
2809         (SuggestNominations.__init__):
2810         (SuggestNominations._recent_commit_messages):
2811         (SuggestNominations._author_name_from_email):
2812         (SuggestNominations._contributor_from_email):
2813         (SuggestNominations._parse_commit_message):
2814         (SuggestNominations._count_commit):
2815         (SuggestNominations._count_recent_patches):
2816         (SuggestNominations._collect_nominations):
2817         (SuggestNominations._print_nominations):
2818         (SuggestNominations.execute):
2819         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2820         (_make_options):
2821         (test_recent_commit_messages):
2822         (test_basic):
2823
2824 2013-04-30  Commit Queue  <rniwa@webkit.org>
2825
2826         Unreviewed, rolling out r149309.
2827         http://trac.webkit.org/changeset/149309
2828         https://bugs.webkit.org/show_bug.cgi?id=115430
2829
2830         The patch does not build on WK1-only builds of the GTK port
2831         (Requested by zdobersek on #webkit).
2832
2833         * TestWebKitAPI/GNUmakefile.am:
2834
2835 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2836
2837         Stop using "in" keyword in IDL files
2838         https://bugs.webkit.org/show_bug.cgi?id=115418
2839
2840         Reviewed by Kentaro Hara.
2841
2842         Remove "in" keyword from IDL files as this is no longer part of the Web
2843         IDL specification.
2844
2845         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2846         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2847         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2848         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2849         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2850         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
2851         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2852         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2853
2854 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2855
2856         [EFL] Enable scaled cursors
2857         https://bugs.webkit.org/show_bug.cgi?id=106242
2858
2859         Reviewed by Gyuyoung Kim.
2860
2861         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
2862
2863         * Scripts/webkitperl/FeatureList.pm:
2864
2865 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2866
2867         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
2868         https://bugs.webkit.org/show_bug.cgi?id=115380
2869
2870         Reviewed by Kentaro Hara.
2871
2872         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
2873         keyword.
2874
2875         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2876         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2877
2878 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2879
2880         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
2881         https://bugs.webkit.org/show_bug.cgi?id=114684
2882
2883         Reviewed by Simon Hausmann.
2884
2885         Remove the ANGLE requirement for USE(3D_GRAPHICS).
2886         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
2887
2888         * qmake/mkspecs/features/features.prf:
2889
2890 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2891
2892         [GTK] Disable Shadow DOM feature
2893         https://bugs.webkit.org/show_bug.cgi?id=115374
2894
2895         Reviewed by Martin Robinson.
2896
2897         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
2898
2899         * Scripts/webkitperl/FeatureList.pm:
2900
2901 2013-04-29  Glenn Adams  <glenn@skynav.com>
2902
2903         [webkitpy] Add missing contributor email addresses
2904         https://bugs.webkit.org/show_bug.cgi?id=115394
2905
2906         Reviewed by Ryosuke Niwa.
2907
2908         * Scripts/webkitpy/common/config/contributors.json:
2909
2910 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
2911
2912         Remove all remaining Skia code
2913         https://bugs.webkit.org/show_bug.cgi?id=115263
2914
2915         Reviewed by Benjamin Poulain.
2916
2917         Remove all remaining references to Skia.
2918
2919         * Scripts/webkitdirs.pm:
2920         (blackberryCMakeArguments):
2921         * Scripts/webkitpy/common/config/contributionareas.py:
2922         * Scripts/webkitpy/common/config/watchlist:
2923
2924 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
2925
2926         Get rid of unused options in Tools/Scripts/webkit-build-directory
2927         https://bugs.webkit.org/show_bug.cgi?id=115383
2928
2929         Reviewed by Darin Adler.
2930
2931         * Scripts/webkit-build-directory:
2932
2933 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2934
2935         [WK2][Mac] Test with NetworkProcess enabled.
2936
2937         Fix the build for non-Mac.
2938
2939         * WebKitTestRunner/TestController.cpp:
2940         (WTR::TestController::initialize):
2941
2942 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2943
2944         [WK2][Mac] Test with NetworkProcess enabled.
2945
2946         Reviewed by Sam Weinig.
2947
2948         * WebKitTestRunner/TestController.cpp:
2949         (WTR::TestController::initialize):
2950
2951 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2952
2953         [GTK] Set up the TestWebCore in TestWebKitAPI
2954         https://bugs.webkit.org/show_bug.cgi?id=115237
2955
2956         Reviewed by Gustavo Noronha Silva.
2957
2958         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2959         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2960         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2961         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2962         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2963
2964         * TestWebKitAPI/GNUmakefile.am:
2965
2966 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2967
2968         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
2969         https://bugs.webkit.org/show_bug.cgi?id=115236
2970
2971         Reviewed by Gustavo Noronha Silva.
2972
2973         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
2974         under the TestWebKitAPI/Tests/JavaScriptCore directory.
2975
2976         * TestWebKitAPI/GNUmakefile.am:
2977
2978 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2979
2980         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
2981         https://bugs.webkit.org/show_bug.cgi?id=115323
2982
2983         Reviewed by Philippe Normand.
2984
2985         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
2986         Its presence enforces linkers to output mangled symbols when reporting linking failures
2987         due to unresolved references. People trying to fix the build can then simply copy
2988         the printed mangled symbol into the symbols.filter file instead of doing a manual build
2989         or connecting to the builders to discover the mangled version of the missing symbol.
2990
2991         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2992
2993 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2994
2995         Remove Chromium code from Tools/BuildSlaveSupport
2996         https://bugs.webkit.org/show_bug.cgi?id=115325
2997
2998         Reviewed by Benjamin Poulain.
2999
3000         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
3001         covering archiving test results and built products.
3002
3003         * BuildSlaveSupport/built-product-archive:
3004         (archiveBuiltProduct):
3005         (extractBuiltProduct):
3006         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
3007         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
3008         * BuildSlaveSupport/test-result-archive:
3009         (archiveTestResults):
3010
3011 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
3012
3013         Remove support for Chromium from webkitdirs.pm
3014         https://bugs.webkit.org/show_bug.cgi?id=115338
3015
3016         Reviewed by Darin Adler.
3017
3018         * Scripts/webkitdirs.pm:
3019         (determineBaseProductDir):
3020         (argumentsForConfiguration):
3021         (builtDylibPathForName):
3022         (determineIsQt):
3023         (isAppleWebKit):
3024
3025 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
3026
3027         Rename TestRunner's setAudioData to setAudioResult
3028         https://bugs.webkit.org/show_bug.cgi?id=115326
3029
3030         Reviewed by Darin Adler.
3031
3032         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
3033         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
3034         affected tests are adjusted accordingly.
3035
3036         * DumpRenderTree/qt/TestRunnerQt.cpp:
3037         (TestRunnerQt::setAudioResult):
3038         * DumpRenderTree/qt/TestRunnerQt.h:
3039         (TestRunnerQt):
3040         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3041         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3042         (WTR::TestRunner::setAudioResult):
3043         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3044         (TestRunner):
3045
3046 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
3047
3048         [WKTR] Tests dumping audio data shouldn't dump pixels
3049         https://bugs.webkit.org/show_bug.cgi?id=115270
3050
3051         Reviewed by Benjamin Poulain.
3052
3053         Prevent dumping the pixel output when Web Audio tests are dumping output data
3054         as the testing output. Pixel output in these tests has no real meaning and is
3055         as such unnecessary.
3056
3057         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3058         (WTR::TestRunner::setAudioData):
3059
3060 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3061
3062         [EFL] Unreviewed Intel bots fix after r149231.
3063
3064         * efl/jhbuild.modules: Disable the libxml Python bindings since the
3065         bots don't have Python's development files installed. libxml should
3066         detect this kind of thing better.
3067
3068 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
3069
3070         [EFL] Build break using jhbuild on ubuntu 13.04
3071         https://bugs.webkit.org/show_bug.cgi?id=115225
3072
3073         Reviewed by Gyuyoung Kim.
3074
3075         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
3076         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
3077         So this patch bumped libxml version to 2.9.1.
3078
3079         * efl/jhbuild.modules:
3080
3081 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
3082
3083         delete-stale-build-files does not clear .d files
3084         http://bugs.webkit.org/show_bug.cgi?id=115293
3085
3086         Reviewed by Ryosuke Niwa.
3087
3088         * BuildSlaveSupport/delete-stale-build-files:
3089         (main): Add .d to the file type list
3090
3091 2013-04-26  Roger Fong  <roger_fong@apple.com>
3092
3093         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
3094         Make the DebugSuffix configuration use _debug dependencies.
3095
3096         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3097         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
3098         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
3099         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3100         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3101         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3102         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
3103         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3104         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3105         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3106         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
3107         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3108         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3109         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3110         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3111         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
3112         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3113         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3114         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3115         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
3116         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3117         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3118         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3119         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3120         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3121         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3122         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
3123         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3124         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
3125         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
3126         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3127         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3128         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3129         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
3130         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3131         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3132         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3133         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3134         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3135         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3136         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3137         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3138         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3139         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
3140         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3141         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3142         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
3143         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3144         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3145         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3146         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3147         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3148         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3149         * win/AssembleBuildLogs/AssembleLogs.cmd:
3150         * win/record-memory/record-memory.vcxproj:
3151         * win/record-memory/record-memoryDebug.props:
3152         * win/record-memory/record-memoryDebugWinCairo.props:
3153         * win/record-memory/record-memoryProduction.props:
3154         * win/record-memory/record-memoryRelease.props:
3155         * win/record-memory/record-memoryReleaseWinCairo.props:
3156
3157 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
3158
3159         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
3160         https://bugs.webkit.org/show_bug.cgi?id=115233
3161
3162         Reviewed by Martin Robinson.
3163
3164         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
3165         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
3166         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
3167         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
3168         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
3169
3170         * TestWebKitAPI/GNUmakefile.am:
3171
3172 2013-04-25  Andy Estes  <aestes@apple.com>
3173
3174         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
3175         https://bugs.webkit.org/show_bug.cgi?id=115223
3176
3177         Reviewed by Darin Adler.
3178
3179         Added an API test.
3180
3181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3182         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
3183         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
3184         when it loads a request with a custom protocol.
3185         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
3186         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
3187         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
3188         miscellaneous cleanup.
3189         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
3190         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
3191         (+[TestProtocol canInitWithRequest:]):
3192         (+[TestProtocol canonicalRequestForRequest:]):
3193         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
3194         (+[TestProtocol scheme]):
3195         (-[TestProtocol startLoading]):
3196         (-[TestProtocol stopLoading]):
3197
3198 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
3199
3200         Remove the remaining Skia #ifdefs
3201         https://bugs.webkit.org/show_bug.cgi?id=114886
3202
3203         Reviewed by Benjamin Poulain.
3204
3205         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3206         (createBitmapContextFromWebView): Remove Skia #ifdef references.
3207
3208 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
3209
3210         [BlackBerry] Clean up load interface in WebPage
3211         https://bugs.webkit.org/show_bug.cgi?id=113267
3212
3213         Reviewed by Rob Buis.
3214
3215         Update DumpRenderTree with change of load() interface in WebPage.
3216         RIM Bug# 315535, internally reviewed by Joe Mason.
3217
3218         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3219         (BlackBerry::WebKit::DumpRenderTree::runTest):
3220
3221 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
3222
3223         Remove the HeapGraphSerializer unit test
3224         https://bugs.webkit.org/show_bug.cgi?id=115231
3225
3226         Reviewed by Andreas Kling.
3227
3228         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
3229         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
3230
3231         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
3232
3233 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3234
3235         Remove support for Chromium from build/update scripts
3236         https://bugs.webkit.org/show_bug.cgi?id=115218
3237
3238         Reviewed by Darin Adler.
3239
3240         * Scripts/build-webkit:
3241         (writeCongrats):
3242         * Scripts/update-webkit:
3243
3244 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3245
3246         Remove support for Chromium from api-test
3247         https://bugs.webkit.org/show_bug.cgi?id=115211
3248
3249         Reviewed by Dirk Pranke.
3250
3251         * Scripts/build-api-tests:
3252         * Scripts/run-api-tests:
3253         (isSupportedPlatform):
3254
3255 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3256
3257         Get rid of Chromium in build-dumprendertree
3258         https://bugs.webkit.org/show_bug.cgi?id=115212
3259
3260         Reviewed by Dirk Pranke.
3261
3262         * Scripts/build-dumprendertree:
3263
3264 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
3265
3266         Pass relatedPage when creating a page in WebKitTestRunner
3267         https://bugs.webkit.org/show_bug.cgi?id=115206
3268
3269         Reviewed by Geoffrey Garen.
3270
3271         To make sure that window.open() opens in the same process even when using multiple processes.
3272
3273         * WebKitTestRunner/PlatformWebView.h:
3274         * WebKitTestRunner/TestController.cpp:
3275         (WTR::TestController::createOtherPage):
3276         (WTR::TestController::createWebViewWithOptions):
3277         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3278         (WTR::PlatformWebView::PlatformWebView):
3279         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3280         (WTR::PlatformWebView::PlatformWebView):
3281         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3282         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
3283         (WTR::PlatformWebView::PlatformWebView):
3284         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3285         (WTR::PlatformWebView::PlatformWebView):
3286         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3287         (WTR::PlatformWebView::PlatformWebView):
3288
3289 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3290
3291         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
3292
3293         * Scripts/webkitpy/common/config/contributors.json:
3294
3295 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3296
3297         Build fix. Forgot to merge args.
3298
3299         * Scripts/webkitpy/tool/bot/irc_command.py:
3300         (Hi.execute):
3301
3302 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3303
3304         webkitbot should recognize its own nickname in greetings.
3305         https://bugs.webkit.org/show_bug.cgi?id=115196
3306
3307         Reviewed by Andreas Kling.
3308
3309         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
3310
3311         * Scripts/webkitpy/tool/bot/irc_command.py:
3312         (Hi.execute):
3313
3314 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
3315
3316         [GTK] Tools/gtk/install-dependencies added ragel dependency
3317         https://bugs.webkit.org/show_bug.cgi?id=115163
3318
3319         Reviewed by Xan Lopez.
3320
3321         The install-dependencies script was missing a dependency on ragel
3322         which is expected when building HarfBuzz.
3323
3324         * gtk/install-dependencies: Added a dependency on ragel for both
3325         apt and yum.
3326
3327 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
3328
3329         [GTK] Remove pango from optional jhbuild dependencies
3330         https://bugs.webkit.org/show_bug.cgi?id=115162
3331
3332         Reviewed by Martin Robinson.
3333
3334         Pango is not needed since revision r148293 that lowers the pango
3335         dependency to 1.30, which is available in most distributions.
3336
3337         * gtk/jhbuild-optional.modules: Removes description of pango module.
3338
3339 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3340
3341         Remove Chromium-specific cases from FeatureList.pm
3342         https://bugs.webkit.org/show_bug.cgi?id=115169
3343
3344         Reviewed by Andreas Kling.
3345
3346         * Scripts/webkitperl/FeatureList.pm:
3347
3348 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3349
3350         Remove checking chromium from run-webkit-tests
3351         https://bugs.webkit.org/show_bug.cgi?id=115139
3352
3353         Reviewed by Benjamin Poulain.
3354
3355         * Scripts/run-webkit-tests:
3356         (useNewRunWebKitTests):
3357
3358 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
3359
3360         Pixel tests in SVG are all broken in WK2
3361         https://bugs.webkit.org/show_bug.cgi?id=114218
3362
3363         Reviewed by Darin Adler.
3364
3365         Window snapshots in WebKitTestRunner on Mac are window-sized
3366         (800x600), which is wrong for the W3C SVG tests that require a
3367         480x360 snapshot.
3368
3369         Fix by resizing the window, as well as the web view in
3370         PlatformWebView::resizeTo() so that window snapshots are correctly
3371         sized.
3372
3373         Also do some drive-by cleanup of the window size constants in both
3374         DRT and WTR to remove magic numbers, and make the code more similar.
3375
3376         * DumpRenderTree/TestRunner.cpp:
3377         (TestRunner::setShouldPaintBrokenImage):
3378         * DumpRenderTree/TestRunner.h:
3379         * DumpRenderTree/efl/DumpRenderTree.cpp:
3380         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3381         (webInspectorShowWindow):
3382         * DumpRenderTree/mac/DumpRenderTree.mm:
3383         (createWebViewAndOffscreenWindow):
3384         (sizeWebViewForCurrentTest):
3385         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3386         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3387         (createPagedBitmapContext):
3388         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3389         (DumpRenderTree::DumpRenderTree):
3390         (DumpRenderTree::open):
3391         * DumpRenderTree/qt/TestRunnerQt.cpp:
3392         * DumpRenderTree/qt/TestRunnerQt.h:
3393         * DumpRenderTree/win/DumpRenderTree.cpp:
3394         (sizeWebViewForCurrentTest):
3395         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3396         * WebKitTestRunner/TestController.cpp:
3397         (WTR::TestController::resetStateToConsistentValues):
3398         * WebKitTestRunner/TestController.h:
3399         * WebKitTestRunner/TestInvocation.cpp:
3400         (WTR::sizeWebViewForCurrentTest):
3401         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3402         (WTR::PlatformWebView::PlatformWebView):
3403         (WTR::PlatformWebView::resizeTo):
3404
3405 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
3406
3407         [EFL] Fix build error after r148963.
3408         https://bugs.webkit.org/show_bug.cgi?id=115126
3409
3410         Reviewed by Laszlo Gombos.
3411
3412         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
3413
3414         * TestWebKitAPI/PlatformEfl.cmake:
3415
3416 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3417
3418         [GTK] Use stamp files for generate-forwarding-headers makefile rules
3419         https://bugs.webkit.org/show_bug.cgi?id=115118
3420
3421         Reviewed by Martin Robinson.
3422
3423         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
3424         forwarding generator rules and don't call it for soup since there
3425         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
3426
3427         * TestWebKitAPI/GNUmakefile.am:
3428         * WebKitTestRunner/GNUmakefile.am:
3429
3430 2013-04-24  Simon Pena  <simon.pena@samsung.com>
3431
3432         [GTK] Update build dependencies
3433         https://bugs.webkit.org/show_bug.cgi?id=115111
3434
3435         Reviewed by Martin Robinson.
3436
3437         The install-dependencies script was missing a dependency on EGL,
3438         which is expected when building Cairo.
3439
3440         * gtk/install-dependencies: Added a dependency on libegl1-mesa
3441         for both apt and yum.
3442
3443 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3444
3445         Remove the Chromium-specific helper from run_webkit_tests.py
3446         https://bugs.webkit.org/show_bug.cgi?id=114996
3447
3448         Reviewed by Dirk Pranke.
3449
3450         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3451         (parse_args):
3452
3453 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
3454
3455         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
3456         https://bugs.webkit.org/show_bug.cgi?id=114850
3457
3458         Reviewed by Andreas Kling.
3459
3460         Revision r148312 fixed WebPageProxy cleanup and also changed the process
3461         termination semantics when requested by the user so that a client is not
3462         notified of a crash anymore, since there was no crash anyway.
3463
3464         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
3465         relied on being notified of a crash after calling WKPageTerminate(). As
3466         a result of not being notified of such non-existent crash, the test would
3467         timeout right after making the terminate call.
3468
3469         This patch adds an InjectedBundle to be used for simulating a crash, by
3470         calling abort() upon receiving a "Crash" message, and thus we are able to
3471         keep testing the crash callback.
3472
3473         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
3474         had been disabled in revisions r148858 and r148855, since it was failing.
3475
3476         * TestWebKitAPI/PlatformEfl.cmake:
3477         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3478         (TestWebKitAPI::TEST):
3479         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
3480         (TestWebKitAPI):
3481         (WKViewClientWebProcessCallbacksTest):
3482         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
3483         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
3484
3485 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3486
3487         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
3488         https://bugs.webkit.org/show_bug.cgi?id=115095
3489
3490         Reviewed by Antonio Gomes.
3491
3492         Use different subfolders under DumpRenderTree Temp folder for every
3493         functionality (icon database, cache, localstorage, ...). This makes
3494         sure there is no conflict between the functionalities.
3495
3496         In EFL's case, libsoup cache was causing problems for the icon
3497         database if sharing the same folder.
3498
3499         * WebKitTestRunner/TestController.cpp:
3500         (WTR::TestController::initialize):
3501
3502 == Rolled over to ChangeLog-2013-04-24 ==