Add "VisibleOnly" key to search predicate
[WebKit-https.git] / Tools / ChangeLog
1 2013-06-04  Greg Hughes  <ghughes@apple.com>
2
3         Add "VisibleOnly" key to search predicate
4         https://bugs.webkit.org/show_bug.cgi?id=115491
5
6         Reviewed by Chris Fleizach.
7
8         Added support for accessibility clients to use the search predicate to find only visible elements
9
10         * DumpRenderTree/AccessibilityUIElement.cpp:
11         (uiElementForSearchPredicateCallback):
12         * DumpRenderTree/AccessibilityUIElement.h:
13         (AccessibilityUIElement):
14         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
15         (AccessibilityUIElement::uiElementForSearchPredicate):
16         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
17         (AccessibilityUIElement::uiElementForSearchPredicate):
18         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
19         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
20         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
21         (AccessibilityUIElement):
22         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
23         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
24         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
25
26 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
27
28         [Windows] Unreviewed build fix.  The last check-in lost CR/LF endings on the batch file,
29         causing build failure.
30
31         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
32         DOS-style CR/LF endings.
33
34 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
35
36         [Windows] Unreviewed test correction.
37
38         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
39         QuartzCore dll's, which are needed by TestWebKitAPI.
40         * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
41         with VS2010 will run when linked against VS2005 support libraries.
42
43 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
44
45         Automatically generate WorkerContext constructor attributes
46         https://bugs.webkit.org/show_bug.cgi?id=117183
47
48         Reviewed by Kentaro Hara.
49
50         Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
51         tests.
52
53         * Scripts/webkitpy/bindings/main.py:
54         (BindingsTests.generate_supplemental_dependency):
55         (BindingsTests.main):
56
57 2013-06-04  Ryuan Choi  <ryuan.choi@samsung.com>
58
59         [EFL] File dialog of MiniBrowser have broken background.
60         https://bugs.webkit.org/show_bug.cgi?id=117189
61
62         Reviewed by Christophe Dumez.
63
64         * MiniBrowser/efl/main.c:
65         (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
66
67 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
68
69         [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
70         https://bugs.webkit.org/show_bug.cgi?id=117184
71
72         Reviewed by Gyuyoung Kim.
73
74         Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
75         that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
76
77         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
78         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
79         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
80
81 2013-06-03  Simon Pena  <simon.pena@samsung.com>
82
83         validate-committer-lists script is now outdated and does not work
84         https://bugs.webkit.org/show_bug.cgi?id=115860
85
86         Reviewed by Brent Fulgham.
87
88         The script validate-committer-lists was outdated, still using the deprecated log
89         system and having the old addresses for the mailing lists, as well as still referring
90         to committers.py, after this was renamed to contributors.json. This patch fixes that
91         so it can be used again.
92
93         * Scripts/validate-committer-lists: Replace calls to log and error with the
94         new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
95         to committers.py, which should be contributors.json.
96         (CommitterListFromMailingList):
97         (CommitterListFromMailingList.check_for_emails_missing_from_list):
98         (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
99         (CommitterListFromGit._fill_in_emails_for_old_logins):
100         (CommitterListFromGit.print_committers_missing_from_committer_list):
101
102 2013-06-03  Dirk Pranke  <dpranke@chromium.org>
103
104         add a script to dump the tests run most recently by a given worker
105         https://bugs.webkit.org/show_bug.cgi?id=116571
106
107         Reviewed by Brent Fulgham.
108
109         The tests_run*.txt results files in layout-test-results/ were removed
110         in r137356, in favor of collecting more data about how the tests were
111         run and compressing it and storing it in stats.json. However, it was
112         nice to just be able to look at a flat text file.
113
114         This script will extract the tests run by a given worker from a
115         given stats.json file, and should help to address that.
116
117         * Scripts/dump-webkit-tests-run: Added.
118         (main):
119         (convert_trie_to_flat_paths):
120
121 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
122
123         [Windows] NRWT is not putting crash logs in proper place
124         https://bugs.webkit.org/show_bug.cgi?id=117098
125
126         Reviewed by Ryosuke Niwa.
127
128         Provide windows-specific overloads for various Port features needed to create and capture
129         crash logs.  This change makes it possible to view crash logs (when created) as part of the
130         summary report at the end of the NRWT run.
131
132         * Scripts/webkitpy/common/system/crashlogs.py:
133         (CrashLogs.find_newest_log): Add support for win32 crash logs
134         (CrashLogs._find_newest_log_win): Added
135         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
136         (make_mock_crash_report_win): Added
137         (CrashLogsTest.test_find_log_win): Added.
138         * Scripts/webkitpy/common/system/executive.py:
139         (Executive.running_pids): Add support for Cygwin win32 crash logs
140         * Scripts/webkitpy/common/system/executive_mock.py:
141         (MockExecutive.__init__):
142         * Scripts/webkitpy/common/system/filesystem_unittest.py:
143         (RealFileSystemTest.test_read_and_write_file): Add tests for
144         malformed ascii/utf8 handling (i.e., Windows log files)
145         * Scripts/webkitpy/port/base.py:
146         (Port.find_system_pid): Added
147         * Scripts/webkitpy/port/server_process.py:
148         (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
149         * Scripts/webkitpy/port/win.py:
150         (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
151         for user to hit enter.
152         (WinPort._get_crash_log): Added
153         (WinPort.look_for_new_crash_logs): Added
154         (WinPort.find_system_pid): Added
155         * Scripts/webkitpy/port/win_unittest.py:
156         (WinPortTest.test_get_crash_log): Added test
157
158 2013-06-03  Eduardo Lima Mitev  <elima@igalia.com>
159
160         [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
161         https://bugs.webkit.org/show_bug.cgi?id=116726
162
163         Reviewed by Gyuyoung Kim.
164
165         Current version of ATK in efl-ews environment is 2.4.0 and is taken from
166         the platform (it is not listed in jhbuild moduleset). That version is
167         old-ish and contain deprecated symbols and missing API, that are blocking
168         patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
169         moduleset, which is the same version the gtk port uses.
170
171         See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
172         why this is needed.
173
174         * efl/jhbuild.modules: Adds ATK module as dependency
175
176 2013-06-03  Erik van Pienbroek  <epienbro@fedoraproject.org>
177
178         [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
179         https://bugs.webkit.org/show_bug.cgi?id=117168
180
181         Reviewed by Martin Robinson.
182
183         The tool generate-gtkdoc internally calls pkg-config.
184         When cross-compiling it shouldn't use pkg-config, but
185         it should use the pkg-config which was detected by
186         the ./configure script (for example this can be
187         i686-w64-mingw32-pkg-config when cross-compiling)
188
189         * GNUmakefile.am:
190         * gtk/gtkdoc.py:
191         (PkgConfigGTKDoc.__init__):
192
193 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
194
195         [Windows] Unreviewed build fix.
196
197         * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
198         allow VS2010 builds to use VS2005 runtime libraries as needed.
199
200 2013-06-03  Roger Fong  <roger_fong@apple.com>
201
202         Nuke VS2005 files from the tree.
203         <rdar://problem/14042021>.
204
205         Rubberstamped by Brent Fulgham.
206
207         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
208         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
209         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
210         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
211         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
212         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
213         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
214         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
215         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
216         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
217         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
218         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
219         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
220         * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
221         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
222         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
223         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
224         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
225         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
226         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
227         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
228         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
229         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
230         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
231         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
232         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
233         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
234         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
235         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
236         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
237         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
238         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
239         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
240         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
241         * DumpRenderTree/win/ImageDiff.vcproj: Removed.
242         * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
243         * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
244         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
245         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
246         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
247         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
248         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
249         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
250         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
251         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
252         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
253         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
254         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
255         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
256         * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
257         * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
258         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
259         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
260         * Scripts/pdevenv: Removed.
261         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
262         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
263         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
264         * WebKitLauncherWin: Removed.
265         * WebKitLauncherWin/Resource.h: Removed.
266         * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
267         * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
268         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
269         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
270         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
271         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
272         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
273         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
274         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
275         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
276         * WebKitLauncherWin/webkit.ico: Removed.
277         * WinLauncher/WinLauncher.ico: Removed.
278         * WinLauncher/WinLauncher.rc: Removed.
279         * WinLauncher/WinLauncher.vcproj: Removed.
280         * WinLauncher/WinLauncherCommon.vsprops: Removed.
281         * WinLauncher/WinLauncherDebug.vsprops: Removed.
282         * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
283         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
284         * WinLauncher/WinLauncherLauncher.rc: Removed.
285         * WinLauncher/WinLauncherLauncher.vcproj: Removed.
286         * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
287         * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
288         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
289         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
290         * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
291         * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
292         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
293         * WinLauncher/WinLauncherLauncherResource.h: Removed.
294         * WinLauncher/WinLauncherPostBuild.cmd: Removed.
295         * WinLauncher/WinLauncherPreBuild.cmd: Removed.
296         * WinLauncher/WinLauncherProduction.vsprops: Removed.
297         * WinLauncher/WinLauncherRelease.vsprops: Removed.
298         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
299         * WinLauncher/small.ico: Removed.
300         * record-memory-win: Removed.
301         * record-memory-win/main.cpp: Removed.
302         * record-memory-win/record-memory-win-common.vsprops: Removed.
303         * record-memory-win/record-memory-win.vcproj: Removed.
304         * record-memory-win/record-memory-winDebug.vsprops: Removed.
305         * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
306         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
307         * record-memory-win/record-memory-winProduction.vsprops: Removed.
308         * record-memory-win/record-memory-winRelease.vsprops: Removed.
309         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
310
311 2013-06-03  Chris Fleizach  <cfleizach@apple.com>
312
313         AX: MathML multiscripts not exposed in Accessibility
314         https://bugs.webkit.org/show_bug.cgi?id=115069
315
316         Reviewed by Tim Horton.
317
318         Add methods to help output components of math multiscripts for accessibility.
319
320         * DumpRenderTree/AccessibilityUIElement.cpp:
321         (mathPostscriptsDescriptionCallback):
322         (mathPrescriptsDescriptionCallback):
323         (AccessibilityUIElement::getJSClass):
324         * DumpRenderTree/AccessibilityUIElement.h:
325         (AccessibilityUIElement):
326         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
327         (convertMathMultiscriptPairsToString):
328         (AccessibilityUIElement::mathPostscriptsDescription):
329         (AccessibilityUIElement::mathPrescriptsDescription):
330         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
331         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
332         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
333         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
334         (AccessibilityUIElement):
335         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
336         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
337         (WTR::_convertMathMultiscriptPairsToString):
338         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
339         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
340
341 2013-06-03  Commit Queue  <commit-queue@webkit.org>
342
343         Unreviewed, rolling out r151109.
344         http://trac.webkit.org/changeset/151109
345         https://bugs.webkit.org/show_bug.cgi?id=117145
346
347         "Plugins in WK2 aren't implemented yet." (Requested by
348         jturcotte on #webkit).
349
350         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
351         * qmake/mkspecs/features/features.prf:
352         * qmake/mkspecs/features/unix/default_pre.prf:
353
354 2013-05-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
355
356         [Qt] Re-enable plugins on Mac.
357         https://bugs.webkit.org/show_bug.cgi?id=116622
358
359         Reviewed by Tor Arne Vestbø.
360
361         Plugins on Mac were only enabled if !embedded but the later was set if
362         QPA is enabled, which is the default since Qt 5.0.
363
364         Remove references to 'embedded' and fix various build issues,
365         PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
366         months.
367
368         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
369         * qmake/mkspecs/features/features.prf:
370         * qmake/mkspecs/features/unix/default_pre.prf:
371
372 2013-06-03  Krzysztof Czech  <k.czech@samsung.com>
373
374         [GTK][WK2] accessibility/placeholder.html is failing
375         https://bugs.webkit.org/show_bug.cgi?id=106344
376
377         Reviewed by Gyuyoung Kim.
378
379         Adds support for retrieving attribute value.
380
381         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
382         (WTR::coreAttributeToAtkAttribute):
383         (WTR::AccessibilityUIElement::stringAttributeValue):
384
385 2013-06-01  Tim Horton  <timothy_horton@apple.com>
386
387         Add a preferred email address and "expertise" for me.
388
389         * Scripts/webkitpy/common/config/contributors.json:
390
391 2013-05-31  Roger Fong  <roger_fong@apple.com>
392
393         Unreviewed. Make windows test bots search in the correct directory for build output.
394
395         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
396         (RunWebKitTests.start):
397         * Scripts/webkitdirs.pm:
398         (determineConfigurationProductDir):
399
400 2013-05-31  Roger Fong  <roger_fong@apple.com>
401
402         Unreviewed. Windows build fix...
403
404         * BuildSlaveSupport/built-product-archive:
405         (createZip):
406
407 2013-05-31  Roger Fong  <roger_fong@apple.com>
408
409         Unreviewed. Windows build fix. One more time!
410
411         * BuildSlaveSupport/built-product-archive:
412         (archiveBuiltProduct):
413         (extractBuiltProduct):
414
415 2013-05-31  Roger Fong  <roger_fong@apple.com>
416
417         Unreviewed. Windows build fix.
418
419         * Scripts/build-webkit:
420
421 2013-05-31  Roger Fong  <roger_fong@apple.com>
422
423         Unreviewed. Windows build fix.
424
425         * Scripts/build-webkit:
426
427 2013-05-31  Roger Fong  <roger_fong@apple.com>
428
429         Make build-webkit output VCExpress 2010 build logs properly.
430         https://bugs.webkit.org/show_bug.cgi?id=117096
431
432         Reviewed by Brent Fulgham.
433
434         Make it so that output from VCExpress is always printed to console.
435         Get build log results from AssembleBuildLogs project output.
436         We don't need those old VCExpress scripts anymore either. 
437
438         * Scripts/build-webkit:
439         * Scripts/print-msvc-project-dependencies: Removed.
440         * Scripts/print-vse-failure-logs: Removed.
441
442 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
443
444         [Windows] Use WinLauncher to display LayoutTest results
445         https://bugs.webkit.org/show_bug.cgi?id=117085
446
447         Reviewed by Oliver Hunt.
448
449         * Scripts/webkitdirs.pm:
450         (runSafari): Use WinLauncher to display content
451         * WinLauncher/WinLauncher.cpp:
452         (dllLauncherEntryPoint): Check for URL argument.
453
454 2013-05-31  Roger Fong  <roger_fong@apple.com>
455
456         Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
457
458         * win/AssembleBuildLogs/AssembleLogs.cmd:
459
460 2013-05-31  Commit Queue  <commit-queue@webkit.org>
461
462         Unreviewed, rolling out r151022.
463         http://trac.webkit.org/changeset/151022
464         https://bugs.webkit.org/show_bug.cgi?id=117084
465
466         Also breaks build by introducing duplicate symbols (Requested
467         by bfulgham on #webkit).
468
469         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
470
471 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
472
473         [Windows] Unreviewed build fix to NRWT
474
475         * Scripts/webkitpy/port/win.py:
476         (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
477
478 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
479
480         [Windows] Unreviewed build fix after r151012
481
482         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
483         WTF library to support SHA tests
484
485 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
486
487         [Windows] Unreviewed build fix after r151012
488
489         * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
490         snprintf definition for Windows.
491
492 2013-05-31  Zan Dobersek  <zdobersek@igalia.com>
493
494         Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
495         https://bugs.webkit.org/show_bug.cgi?id=116445
496
497         Reviewed by Benjamin Poulain.
498
499         Add the MD5 and SHA1 unit tests that were previously located inside WTF.
500
501         * TestWebKitAPI/CMakeLists.txt:
502         * TestWebKitAPI/GNUmakefile.am:
503         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
504         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
506         * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
507         (TestWebKitAPI):
508         (TestWebKitAPI::expectMD5):
509         (TestWebKitAPI::TEST):
510         * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
511         (TestWebKitAPI):
512         (TestWebKitAPI::expectSHA1):
513         (TestWebKitAPI::TEST):
514         * TestWebKitAPI/Tests/WTF/WTF.pro:
515         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
516
517 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
518
519         [Windows] Unreviewed build correction.
520
521         * Scripts/webkitpy/port/win.py:
522         (WinPort.create_debugger_command_file): The directory needs to be
523         a string, not a temporary directory object.
524
525 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
526
527         [Windows] NRWT doesn't save crash logs on Apple's Windows port.
528         https://bugs.webkit.org/show_bug.cgi?id=76935
529
530         Reviewed by Ryosuke Niwa.
531
532         Extend the WinPort class with commands to set and clean up various registry
533         values needed to invoke the correct debugger to get crash files.
534
535         * Scripts/webkitpy/port/win.py:
536         (WinPort): Added global caches for registry keys and settings
537         (WinPort._ntsd_location): Added
538         (WinPort.create_debugger_command_file): Added
539         (WinPort.read_registry_string): Added
540         (WinPort.write_registry_string): Added
541         (WinPort.setup_crash_log_saving): Added
542         (WinPort.restore_crash_log_saving): Added
543         (WinPort.setup_test_run): Added overload to add registry settings.
544         (WinPort.clean_up_test_run): Added overload to clean up registry settings.
545
546 2013-05-30  Roger Fong  <roger_fong@apple.com>
547
548         Get rid of JavaScript exports file on AppleWin port.
549         https://bugs.webkit.org/show_bug.cgi?id=117050.
550
551         Reviewed by Darin Adler.
552
553         Start linking in WTF.lib now that it's a shared library.
554
555         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
556         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
557         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
558
559 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
560
561         Web Inspector: tests in PerformanceTests/inspector/ are timing out
562         https://bugs.webkit.org/show_bug.cgi?id=77024
563
564         Reviewed by Andreas Kling.
565
566         Remove inspector performance tests since they have been disabled for ages,
567         and they don't use the standard parser-style performance output.
568
569         It's adding a lot of code complexity to our infrastructure.
570
571         * Scripts/webkitpy/performance_tests/perftest.py:
572         (SingleProcessPerfTest.__init__):
573         (PerfTestFactory):
574         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
575         (TestPerfTestFactory.test_regular_test):
576         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
577         (TestDriver.run_test):
578         (MainTest.run_test):
579         (MainTest._tests_for_runner):
580         (MainTest.test_run_test_set_kills_drt_per_run):
581         (MainTest._test_run_with_json_output):
582         (MainTest):
583         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
584
585 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
586
587         Remove requires_http_server as Chromium Android was the only port that needed this
588         https://bugs.webkit.org/show_bug.cgi?id=117018
589
590         Reviewed by Benjamin Poulain.
591
592         Removed the unused code that existed for Chromium Android port.
593
594         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
595         (LayoutTestRunner.run_tests):
596         (LayoutTestRunner._handle_finished_test_list):
597         * Scripts/webkitpy/layout_tests/controllers/manager.py:
598         (Manager._run_tests):
599         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
600         (PerfTestsRunner._collect_tests):
601         (PerfTestsRunner.run):
602         * Scripts/webkitpy/port/base.py:
603         (Port.to.start_helper):
604         * Scripts/webkitpy/port/base_unittest.py:
605         (PortTest.test_build_path):
606
607 2013-05-29  Ruth Fong  <ruth_fong@apple.com>
608
609         prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
610         https://bugs.webkit.org/show_bug.cgi?id=113221
611
612         Reviewed by Ryosuke Niwa.
613
614         Teach prepare-Changelog to not list the names of modified namespaces, 
615         classes, or structs in C++ files. Thus, if a change is made 
616         within a namespace/class/struct yet outside a function, it will 
617         not be reflected in the ChangeLog entry. 
618         See https://bugs.webkit.org/show_bug.cgi?id=113221#c8 
619         for more details on how ChangeLog entries are affected.
620
621         * Scripts/prepare-ChangeLog:
622         (get_function_line_ranges_for_cpp): 
623         (delete_namespaces_from_ranges_for_cpp): Added.
624         (is_function_in_namespace): Added.
625         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
626         to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
627
628 2013-05-29  Praveen R Jadhav  <praveen.j@samsung.com>
629
630         Cleanup AudioSourceNode.idl from WebKit build.
631         https://bugs.webkit.org/show_bug.cgi?id=116905.
632
633         Reviewed by Darin Adler.
634
635         AudioSourceNode.idl is not part of WebAudio Specifications anymore.
636         AudioNode is inherited directly in all the audio source nodes.
637
638         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
639
640 2013-05-29  Andrew Lo  <anlo@rim.com>
641
642         Add Andrew Lo to contributors.json
643         https://bugs.webkit.org/show_bug.cgi?id=116981
644
645         Reviewed by Rob Buis.
646
647         Adding Andrew Lo to contributors.json.
648
649         * Scripts/webkitpy/common/config/contributors.json:
650
651 2013-05-29  Adenilson Cavalcanti  <cavalcantii@gmail.com>
652
653         Unreviewed. Adding myself as a committer.
654
655         * Scripts/webkitpy/common/config/contributors.json:
656
657 2013-05-29  Marcelo Lira  <marcelo.lira@openbossa.org>
658
659         [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
660         https://bugs.webkit.org/show_bug.cgi?id=116683
661
662         Reviewed by Noam Rosenthal.
663
664         A coordinates conversion test for WKViewUserViewportToContents was
665         added to WebKit2 API tests.
666
667         * TestWebKitAPI/PlatformEfl.cmake:
668         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
669         (TestWebKitAPI):
670         (TestWebKitAPI::TEST):
671
672 2013-05-29  Yong Li  <yong.li.webkit@outlook.com>
673
674         Unreviewed. Update my info.
675
676         * Scripts/webkitpy/common/config/contributors.json:
677
678 2013-05-29  Dongseong Hwang  <dongseong.hwang@intel.com>
679
680         Unreviewed. Add myself as committer in contributors.json.
681
682         * Scripts/webkitpy/common/config/contributors.json:
683
684 2013-05-29  Carlos Garcia Campos  <cgarcia@igalia.com>
685
686         Unreviewed. Fix make distcheck.
687
688         * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
689         DISTCLEANFILES.
690
691 2013-05-29  Mary Wu  <mawu@blackberry.com>
692
693         Unreviewed: update my email address in contributors.json.
694
695         * Scripts/webkitpy/common/config/contributors.json:
696
697 2013-05-29  Kalyan Kondapally  <kalyan.kondapally@intel.com>
698
699         Unreviewed: Adding myself to committers list.
700
701         * Scripts/webkitpy/common/config/contributors.json:
702
703 2013-05-28  Arpita Bahuguna  <a.bah@samsung.com>
704
705         Unreviewed: Adding myself to committers list.
706
707         * Scripts/webkitpy/common/config/contributors.json:
708
709 2013-05-28  Brent Fulgham  <bfulgham@webkit.org>
710
711         [Windows] Many CSS2.1 tests fail under NRWT.
712         https://bugs.webkit.org/show_bug.cgi?id=75707
713
714         Reviewed by Darin Adler.
715
716         * DumpRenderTree/win/DumpRenderTree.cpp:
717         (findFontFallback): Added
718         (addFontFallbackIfPresent): Added
719         (removeFontFallbackIfPresent): Added
720         (runTest): Set up/remove font fallbacks when needed.
721
722 2013-05-28  Brent Fulgham  <bfulgham@apple.com>
723
724         [Windows] NRWT reports failure for 'mac' test cases.
725         https://bugs.webkit.org/show_bug.cgi?id=116698
726
727         Reviewed by Ryosuke Niwa.
728
729         The Windows port falls back to the Mac port for many test results,
730         and so adds the mac and mac-wk2 to its set of fallbacks.
731         Unfortunately, NRWT thinks that this means that tests in these
732         folders should be executed, resulting in many failures on
733         Windows.
734
735         This change overloads the '_tests_for_other_platforms' method
736         to return a subset of the result fallback list so that we do
737         not attempt to execute Mac tests on Windows.
738
739         * Scripts/webkitpy/port/base.py:
740         (Port.test_search_path): Added. Defaults to just calling the
741         baseline_search_path method, which is how most ports behave.
742         (Port._test_for_other_platforms): Modified to call the new
743         test_search_path method.
744
745         * Scripts/webkitpy/port/win.py:
746         (WinPort.test_search_path): Added custom overload. Strips
747         out mac-specific test paths.
748
749 2013-05-28  Martin Robinson  <mrobinson@igalia.com>
750
751         Fix GTK+ CMake build
752
753         * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
754         library target is simply "WebKit2."
755
756 2013-05-28  Zan Dobersek  <zdobersek@igalia.com>
757
758         [webkitpy] Explicitly specify the reference file extensions
759         https://bugs.webkit.org/show_bug.cgi?id=116333
760
761         Reviewed by Benjamin Poulain.
762
763         Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
764         between valid reference files required by reftests and text baselines that have the same extension as
765         potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
766         that were until this change recognized as reference files).
767
768         Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
769
770         * Scripts/webkitpy/port/base.py:
771         (Port.reference_files): Iterate through the _supported_reference_extensions set.
772         (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
773         _supported_reference_extensions set, containing the extensions allowed for reference files.
774         (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
775         (Port._has_supported_extension): Use _supported_test_extensions.
776         * Scripts/webkitpy/port/base_unittest.py:
777         (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
778         Port.is_reference_html_file method.
779
780 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
781
782         Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
783
784         * Scripts/webkitpy/tool/commands/newcommitbot.py:
785         (NewCommitBot.next_work_item):
786
787 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
788
789         WKR and webkitbot build fixes.
790
791         * Scripts/webkitpy/tool/bot/irc_command.py:
792         (RollChromiumDEPS.execute):
793         * Scripts/webkitpy/tool/commands/newcommitbot.py:
794         (NewCommitBot.next_work_item):
795
796 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
797
798         roll-chromium-deps doesn't repeat the full name.
799
800         Rubber-stamped by Andreas Kling.
801
802         * Scripts/webkitpy/tool/bot/irc_command.py:
803         (RollChromiumDEPS.execute):
804
805 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
806
807         Revert another erroneous change.
808
809         * Scripts/webkitpy/tool/commands/newcommitbot.py:
810         (NewCommitBot.next_work_item):
811
812 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
813
814         Revert an erroneous change.
815
816         * Scripts/webkitpy/tool/commands/sheriffbot.py:
817         (SheriffBot):
818
819 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
820
821         Some build fixes for WKR and webkitbot.
822
823         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
824         (IRCBotTest.test_help):
825         * Scripts/webkitpy/tool/commands/newcommitbot.py:
826         (Agent):
827         (Agent.__init__):
828         (Agent.name):
829         (NewCommitBot):
830         (NewCommitBot.begin_work_queue):
831         (NewCommitBot.next_work_item):
832         * Scripts/webkitpy/tool/commands/sheriffbot.py:
833         (SheriffBot):
834
835 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
836
837         Teach webkitbot and WKR how to respond to yt?
838         https://bugs.webkit.org/show_bug.cgi?id=116775
839
840         Reviewed by Andreas Kling.
841
842         * Scripts/webkitpy/tool/bot/irc_command.py:
843         (Hi): Fixed the usage string.
844         (Hi.execute): Made it more generic so that it works in WKR.
845         (YouThere): Added.
846         (YouThere.execute): Added.
847         * Scripts/webkitpy/tool/commands/newcommitbot.py:
848
849 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
850
851         Try to fix the EFL build.
852         
853         * DumpRenderTree/efl/TestRunnerEfl.cpp:
854         (TestRunner::setPageVisibility):
855
856 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
857
858         Unprefix Page Visibility API
859         https://bugs.webkit.org/show_bug.cgi?id=102340
860
861         Reviewed by Tim Horton.
862         
863         Rename "preview" state to "unloaded" state, and adjust the tests
864         to test for it.
865
866         * DumpRenderTree/mac/TestRunnerMac.mm:
867         (TestRunner::setPageVisibility):
868         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
869         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
870         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
871         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
872         (TestWebKitAPI::didRunStep4InStateUnloaded):
873         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
874         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
875         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
876         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
877         (WTR::TestRunner::setPageVisibility):
878
879 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
880
881         Unreviewed build fix. Don't use new NRWT logic needed
882         by Windows yet. Activate (and fix test) when we cut over.
883
884         * Scripts/webkitpy/port/driver.py:
885         (Driver._setup_environ_for_driver):
886         (Driver._start):
887
888 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
889
890         [Windows] Expose database storage and cache locations via preferences.
891         https://bugs.webkit.org/show_bug.cgi?id=116729
892
893         Reviewed by Tim Horton.
894
895         Update DumpRenderTree to use CFPreferences to control where WebKit
896         stores its local databases, URL caches, etc.
897
898         * DumpRenderTree/win/DumpRenderTree.cpp:
899         (libraryPathForDumpRenderTree): Added.
900         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
901         * Scripts/webkitpy/port/base.py:
902         (Port._driver_tempdir): Added (to allow port-specific overload).
903         (Port._driver_tempdir_for_environment): Ditto
904         * Scripts/webkitpy/port/driver.py:
905         (Driver._setup_environ_for_driver): Use new overload to set
906         environment variable.
907         (Driver._start): Use new overload for temp directory location.
908         * Scripts/webkitpy/port/win.py:
909         (WinPort._driver_tempdir_for_environment): New overload to supply
910         Windows path to DumpRenderTree environment (while still using
911         cygwin paths for internal operations.
912
913 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
914
915         Remove custom code for webkitAudioContext global constructor getter
916         https://bugs.webkit.org/show_bug.cgi?id=116530
917
918         Reviewed by Geoffrey Garen.
919
920         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
921         WebAudio feature instead of public ewk_view API since that API was
922         removed.
923
924         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
925         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
926         * DumpRenderTree/efl/TestRunnerEfl.cpp:
927         (TestRunner::overridePreference):
928
929 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
930
931         Make team.html have each contributor's area of expertise
932         https://bugs.webkit.org/show_bug.cgi?id=116737
933
934         Reviewed by Benjamin Poulain.
935
936         * Scripts/webkitpy/common/config/contributors.json:
937         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
938         
939         Changed formatting of the file because the lines are getting way to
940         long, and I generated this, so it's easier if the formatting of the
941         file is regular.
942
943 2013-05-24  Simon Pena  <simon.pena@samsung.com>
944
945         Update WTF::Vector pretty printers
946         https://bugs.webkit.org/show_bug.cgi?id=116719
947
948         Reviewed by Anders Carlsson.
949
950         After r148891, WTF::Vector pretty printers were left outdated, as
951         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
952         one as a member. This patch updates the pretty printers so they work
953         again. 
954
955         * gdb/webkit.py:
956         (WTFVectorPrinter.children):
957         (WTFVectorPrinter.to_string):
958
959 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
960
961         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
962         https://bugs.webkit.org/show_bug.cgi?id=116710
963
964         Reviewed by Mark Rowe.
965
966         * DumpRenderTree/mac/DumpRenderTree.mm:
967         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
968
969 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
970
971         Add missing dependencies to deps script.
972
973         [GTK] Missing packages in install-dependencies script.
974         https://bugs.webkit.org/show_bug.cgi?id=116632
975
976         Reviewed by Martin Robinson.
977
978         * gtk/install-dependencies:
979
980 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
981
982         [Windows] Unreviewed change for NRWT support.
983
984         * Scripts/webkitpy/port/win.py:
985         (WinPort.default_child_processes): Added a default implementation
986         that limits NRWT to a single instance.
987
988 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
989
990         Remove meaningless "test_uses_apache" from Python test cases.
991         https://bugs.webkit.org/show_bug.cgi?id=38756
992
993         Reviewed by Ryosuke Niwa.
994
995         * Scripts/webkitpy/port/port_testcase.py:
996         (PortTestCase.test_driver_cmd_line): Remove the meaningless
997         "test_uses_apache" test case from the Python test infrastructure.
998         It was hard-coded to true, even though not all ports use
999         Apache.
1000
1001 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
1002
1003         [Windows] Update new-run-webkit-tests for Windows port.
1004         https://bugs.webkit.org/show_bug.cgi?id=38756
1005
1006         Reviewed by Ryosuke Niwa.
1007
1008         * Scripts/new-run-webkit-httpd:
1009         (run): Switch from 'chromium' to 'win'
1010         * Scripts/webkitpy/port/win.py:
1011         (WinPort): Add support methods for lighttpd server.
1012         (WinPort._uses_apache):
1013         (WinPort._path_to_lighttpd):
1014         (WinPort._path_to_lighttpd_modules):
1015         (WinPort._path_to_lighttpd_php):
1016
1017 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
1018
1019         Make default bug links in buildbot clickable
1020         https://bugs.webkit.org/show_bug.cgi?id=116673
1021
1022         Reviewed by Ryosuke Niwa.
1023
1024         Use changecommentlink of html.WebStatus to make the links clickable.
1025
1026         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1027
1028 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
1029
1030         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
1031         https://bugs.webkit.org/show_bug.cgi?id=116595
1032
1033         Temporarily skip this test.
1034
1035         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1036         (TestWebKitAPI::TEST):
1037
1038 2013-05-22  Alex Christensen  <achristensen@apple.com>
1039
1040         Unreviewed.  Added myself to contributors.json.
1041
1042         * Scripts/webkitpy/common/config/contributors.json:
1043         Added myself.
1044
1045 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1046
1047         [EFL][WK2] Add sub menus to MiniBrowser
1048         https://bugs.webkit.org/show_bug.cgi?id=114728
1049
1050         Reviewed by Christophe Dumez.
1051
1052         Elementary Ctxpopup widget API does not provide support for submenu item.
1053         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
1054         Elementary Menu widget.
1055
1056         * MiniBrowser/efl/main.c:
1057         (_Browser_Window):
1058         (on_window_resize):
1059         (window_free):
1060         (context_menu_item_selected_cb):
1061         (context_menu_populate):
1062         (on_context_menu_show):
1063         (on_context_menu_hide):
1064         (window_create):
1065
1066 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
1067
1068         [EFL] Add command line option to MiniBrowser to set cookies policy.
1069         https://bugs.webkit.org/show_bug.cgi?id=115028
1070
1071         Reviewed by Christophe Dumez.
1072
1073         Add command line option to MiniBrowser EFL to set cookies policy:
1074         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
1075         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
1076
1077         * MiniBrowser/efl/main.c:
1078         (elm_main):
1079
1080 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1081
1082         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
1083         https://bugs.webkit.org/show_bug.cgi?id=116585
1084
1085         Reviewed by Alexey Proskuryakov.
1086
1087         willLoadURLRequest and willLoadDataRequest require the API version 6.
1088
1089         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1090
1091 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1092
1093         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
1094         https://bugs.webkit.org/show_bug.cgi?id=116516
1095
1096         Reviewed by Alexey Proskuryakov.
1097
1098         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
1099
1100         * DumpRenderTree/mac/DumpRenderTree.mm:
1101         (createWebViewAndOffscreenWindow): Match the ordering.
1102         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
1103
1104 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
1105
1106         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
1107         https://bugs.webkit.org/show_bug.cgi?id=116568
1108
1109         Reviewed by Anders Carlsson.
1110
1111         * WebKitTestRunner/WebNotificationProvider.cpp:
1112         (WTR::WebNotificationProvider::~WebNotificationProvider):
1113         * WebKitTestRunner/WebNotificationProvider.h:
1114         When the provider is destroyed, it should no longer be registered with the manager.
1115
1116         * WebKitTestRunner/GeolocationProviderMock.cpp:
1117         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
1118         * WebKitTestRunner/GeolocationProviderMock.h:
1119         I wasn't seeing a crash here, but this code has the same issue as notification
1120         provider, so applying the same fix.
1121
1122         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1123         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
1124         destructor having fixed the above.
1125
1126 2013-05-21  Commit Queue  <commit-queue@webkit.org>
1127
1128         Unreviewed, rolling out r150386 and r150397.
1129         http://trac.webkit.org/changeset/150386
1130         http://trac.webkit.org/changeset/150397
1131         https://bugs.webkit.org/show_bug.cgi?id=116572
1132
1133         Broke a test; Alex is going to try again later. (Requested by
1134         thorton on #webkit).
1135
1136         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1137         (WTR::pathSuitableForTestResult):
1138         (WTR::dumpRequestDescriptionSuitableForTestResult):
1139         (WTR::dumpResponseDescriptionSuitableForTestResult):
1140         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1141         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1142         (WTR::InjectedBundlePage::willSendRequestForFrame):
1143         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1144         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1145         (InjectedBundlePage):
1146
1147 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1148
1149         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
1150
1151         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1152         (AbstractCommitLogCommand._recent_commit_messages):
1153
1154 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
1155
1156         [GTK] [CMake] Add support for building WebKit2
1157         https://bugs.webkit.org/show_bug.cgi?id=116372
1158
1159         Reviewed by Gustavo Noronha Silva.
1160
1161         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
1162         * MiniBrowser/gtk/CMakeLists.txt: Added.
1163
1164 2013-05-21  Jessie Berlin  <jberlin@apple.com>
1165
1166         Revert r149635, it was too optimistic.
1167
1168         Rubber-stamped by Andreas Kling.
1169
1170         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
1171         #ifdefs in WebCore code outside of WebCore/platform.
1172
1173         * Scripts/webkitpy/style/checkers/cpp.py:
1174         (check_invalid_increment):
1175         (process_line):
1176         (CppChecker):
1177         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1178         (CppStyleTest.test_plain_integral_bitfields):
1179
1180 2013-05-21  Jer Noble  <jer.noble@apple.com>
1181
1182         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
1183
1184         * lldb/lldb_webkit.py:
1185         (WTFVectorProvider.num_children):
1186         (WTFVectorProvider.get_child_index):
1187         (WTFVectorProvider.get_child_at_index):
1188         (WTFVectorProvider.update):
1189
1190 2013-05-21  Jessie Berlin  <jberlin@apple.com>
1191
1192         Expose a way to know when forms are added to a page or when form controls are added to a form
1193         in the injected bundle
1194         https://bugs.webkit.org/show_bug.cgi?id=116334
1195
1196         Reviewed by Alexey Proskuryakov.
1197
1198         Add tests for the new callbacks.
1199
1200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1201         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
1202
1203         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
1204         (TestWebKitAPI::nullJavaScriptCallback):
1205         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
1206         being passed in for the callback.
1207         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1208         After receiving the message that didAssociateFormControls callback was invoked from adding
1209         the form in the onload handler, tell the page to add a password field to the form, which
1210         should also invoke didAssociateFormControls callback.
1211         (TestWebKitAPI::setInjectedBundleClient):
1212         Register to receive messages.
1213         (TestWebKitAPI::TEST):
1214         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
1215         been invoked for both adding the form and for adding a password field to the form.
1216
1217         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
1218         (TestWebKitAPI::shouldNotifyOnFormChanges):
1219         Return true so the didAssociateFormControls callback is invoked.
1220         (TestWebKitAPI::didAssociateFormControls):
1221         Tell the UI process.
1222         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
1223         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1224         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
1225
1226         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
1227         Add a form in response to the onload event. Add a button that will add the password field
1228         for manual testing.
1229
1230 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
1231
1232         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
1233         https://bugs.webkit.org/show_bug.cgi?id=106341
1234
1235         Reviewed by Martin Robinson.
1236
1237         Adds support for retrieving accessibility element at exact point.
1238
1239         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1240         (WTR::AccessibilityUIElement::elementAtPoint):
1241
1242 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
1243
1244         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
1245         https://bugs.webkit.org/show_bug.cgi?id=112913
1246
1247         Reviewed by Martin Robinson.
1248
1249         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
1250         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
1251         so the leak appears.
1252
1253         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1254         (WTR):
1255         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1256         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1257         (WTR::AccessibilityController::rootElement):
1258         (WTR):
1259         (WTR::AccessibilityController::focusedElement):
1260         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1261         (WTR::checkElementState):
1262         (WTR::indexRangeInTable):
1263         (WTR::alterCurrentValue):
1264         (WTR::AccessibilityUIElement::getChildren):
1265         (WTR::AccessibilityUIElement::getChildrenWithRange):
1266         (WTR::AccessibilityUIElement::childrenCount):
1267         (WTR::AccessibilityUIElement::indexOfChild):
1268         (WTR::AccessibilityUIElement::titleUIElement):
1269         (WTR::AccessibilityUIElement::parentElement):
1270         (WTR::AccessibilityUIElement::allAttributes):
1271         (WTR::AccessibilityUIElement::role):
1272         (WTR::AccessibilityUIElement::title):
1273         (WTR::AccessibilityUIElement::description):
1274         (WTR::AccessibilityUIElement::orientation):
1275         (WTR::AccessibilityUIElement::stringValue):
1276         (WTR::AccessibilityUIElement::language):
1277         (WTR::AccessibilityUIElement::x):
1278         (WTR::AccessibilityUIElement::y):
1279         (WTR::AccessibilityUIElement::width):
1280         (WTR::AccessibilityUIElement::height):
1281         (WTR::AccessibilityUIElement::intValue):
1282         (WTR::AccessibilityUIElement::minValue):
1283         (WTR::AccessibilityUIElement::maxValue):
1284         (WTR::AccessibilityUIElement::isEnabled):
1285         (WTR::AccessibilityUIElement::isFocused):
1286         (WTR::AccessibilityUIElement::isSelected):
1287         (WTR::AccessibilityUIElement::isExpanded):
1288         (WTR::AccessibilityUIElement::isChecked):
1289         (WTR::AccessibilityUIElement::rowCount):
1290         (WTR::AccessibilityUIElement::columnCount):
1291         (WTR::AccessibilityUIElement::rowIndexRange):
1292         (WTR::AccessibilityUIElement::columnIndexRange):
1293         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1294         (WTR::AccessibilityUIElement::increment):
1295         (WTR::AccessibilityUIElement::decrement):
1296         (WTR::AccessibilityUIElement::press):
1297         (WTR::AccessibilityUIElement::documentEncoding):
1298         (WTR::AccessibilityUIElement::documentURI):
1299         (WTR::AccessibilityUIElement::isFocusable):
1300         (WTR::AccessibilityUIElement::isSelectable):
1301         (WTR::AccessibilityUIElement::isMultiSelectable):
1302         (WTR::AccessibilityUIElement::isVisible):
1303
1304 2013-05-20  Lucas Forschler  <lforschler@apple.com>
1305
1306     Rollout 150398.
1307     
1308 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
1309
1310         [GTK] Fix concatenations of string literals that are not C++11-compliant
1311         https://bugs.webkit.org/show_bug.cgi?id=116449
1312
1313         Reviewed by Martin Robinson.
1314
1315         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
1316         is simply a matter of separating the string and the string literal that are being concatenated with a space.
1317
1318         * ImageDiff/gtk/ImageDiff.cpp:
1319         (printImage):
1320
1321 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
1322
1323         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
1324         https://bugs.webkit.org/show_bug.cgi?id=116450
1325
1326         Reviewed by Martin Robinson.
1327
1328         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
1329         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
1330         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
1331         TestWebKitAPI programs when compiling them.
1332
1333         * TestWebKitAPI/GNUmakefile.am:
1334
1335 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1336
1337         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
1338         https://bugs.webkit.org/show_bug.cgi?id=116492
1339
1340         Reviewed by Dirk Pranke.
1341
1342         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
1343
1344         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
1345         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
1346         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
1347         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
1348         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
1349         to memory pressure on the machine.
1350
1351         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
1352         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
1353         for a subsequent patch just to make things easier to follow.
1354
1355         * Scripts/webkitpy/port/driver.py:
1356         (DriverProxy.__init__):
1357         (DriverProxy.run_test):
1358         (DriverProxy.has_crashed):
1359         (DriverProxy.stop):
1360
1361 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1362
1363         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
1364         https://bugs.webkit.org/show_bug.cgi?id=116423
1365
1366         Reviewed by Ryosuke Niwa.
1367
1368         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
1369
1370         * BuildSlaveSupport/build.webkit.org-config/config.json:
1371
1372 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
1373
1374         Remove remaining link-prerender code
1375         https://bugs.webkit.org/show_bug.cgi?id=116429
1376
1377         Reviewed by Darin Adler.
1378
1379         Link prerendering code was removed in r150356.
1380
1381         * Scripts/webkitperl/FeatureList.pm:
1382         * qmake/mkspecs/features/features.pri:
1383
1384 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1385
1386         commit-queue should check for oops in changelog entries
1387         https://bugs.webkit.org/show_bug.cgi?id=116395
1388
1389         Reviewed by Martin Robinson.
1390
1391         Make changelog validation fail when it contains oops!.
1392
1393         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1394         (CommitQueueTask._validate_changelog):
1395         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1396         (CommitQueueTaskTest._run_through_task):
1397         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1398         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1399         (ValidateChangeLogs.options):
1400         (ValidateChangeLogs._check_changelog_diff):
1401         (ValidateChangeLogs._changelog_contains_oops):
1402         (ValidateChangeLogs.run):
1403         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1404         (ValidateChangeLogsTest._assert_start_line_produces_output):
1405         (ValidateChangeLogsTest.test_check_changelog_diff):
1406         (ValidateChangeLogsTest):
1407         (ValidateChangeLogsTest.test_changelog_contains_oops):
1408
1409 2013-05-20  Jessie Berlin  <jberlin@apple.com>
1410
1411         Expose a way to know when forms are added to a page or when form controls are added to a form
1412         in the injected bundle
1413         https://bugs.webkit.org/show_bug.cgi?id=116334
1414
1415         Reviewed by Alexey Proskuryakov.
1416
1417         Add tests for the new callbacks.
1418
1419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1420         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
1421
1422         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
1423         (TestWebKitAPI::nullJavaScriptCallback):
1424         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
1425         being passed in for the callback.
1426         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1427         After receiving the message that didAssociateFormControls callback was invoked from adding
1428         the form in the onload handler, tell the page to add a password field to the form, which
1429         should also invoke didAssociateFormControls callback.
1430         (TestWebKitAPI::setInjectedBundleClient):
1431         Register to receive messages.
1432         (TestWebKitAPI::TEST):
1433         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
1434         been invoked for both adding the form and for adding a password field to the form.
1435
1436         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
1437         (TestWebKitAPI::shouldNotifyOnFormChanges):
1438         Return true so the didAssociateFormControls callback is invoked.
1439         (TestWebKitAPI::didAssociateFormControls):
1440         Tell the UI process.
1441         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
1442         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1443         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
1444
1445         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
1446         Add a form in response to the onload event. Add a button that will add the password field
1447         for manual testing.
1448
1449 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1450
1451         [EFL][JHBUILD] Make sure eet is built before evas
1452         https://bugs.webkit.org/show_bug.cgi?id=116440
1453
1454         Reviewed by Gyuyoung Kim.
1455
1456         Mark eet as a dependency of evas since evas requires eet to enable some of its
1457         functionality.
1458
1459         * efl/jhbuild.modules:
1460
1461 2013-05-20  Alex Christensen  <achristensen@apple.com>
1462
1463         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
1464         https://bugs.webkit.org/show_bug.cgi?id=116125
1465
1466         Reviewed by Tim Horton.
1467
1468         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1469         (WTR::pathSuitableForTestResult):
1470         Changed string operations to match _drt_descriptionSuitableForTestResult.
1471         (WTR::dumpRequestDescriptionSuitableForTestResult):
1472         (WTR::dumpResponseDescriptionSuitableForTestResult):
1473         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1474         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1475         (WTR::InjectedBundlePage::willSendRequestForFrame):
1476         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1477         Pass the main frame's URL to pathSuitableForTestResult.
1478         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1479         Added WKBundlePageRef to willPerformClientRedirectForFrame.
1480
1481 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
1482
1483         fix w3c test importer unit tests after r150324
1484         https://bugs.webkit.org/show_bug.cgi?id=116459
1485
1486         Reviewed by Ryosuke Niwa.
1487
1488         This patch fixes the unit tests to not actually call out to
1489         'hg' (by using a mock executive) and also changes the real
1490         directory we crawl from Source/WebCore/css to
1491         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
1492         still change this to a mock filesystem, but that's a separate change.
1493
1494         * Scripts/webkitpy/w3c/test_importer.py:
1495         (main):
1496         (TestImporter.__init__):
1497         (TestImporter.load_changeset):
1498         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1499         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1500         (TestImporterTest.test_import_dir_with_no_tests):
1501
1502 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1503
1504         Unreviewed EFL build fix.
1505
1506         Fix linking errors due to undefined symbols on Ubuntu 13.04.
1507
1508         * DumpRenderTree/efl/CMakeLists.txt:
1509         * EWebLauncher/CMakeLists.txt:
1510         * MiniBrowser/efl/CMakeLists.txt:
1511
1512 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1513
1514         [EFL] Reenabled INDEXED_DATABASE after r150344
1515         https://bugs.webkit.org/show_bug.cgi?id=116430
1516
1517         Reviewed by Gyuyoung Kim.
1518
1519         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
1520         build was fixed in r150344.
1521
1522         * Scripts/webkitperl/FeatureList.pm:
1523
1524 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
1525
1526         [EFL] init/shutdown should be paired in EWebLauncher
1527         https://bugs.webkit.org/show_bug.cgi?id=116427
1528
1529         Reviewed by Christophe Dumez.
1530
1531         Added ecore_file_shutdown() for cleanup of ecore_file.
1532         Removed edje_init and ecore_evas_init because it was in ewk_init().
1533
1534         * EWebLauncher/main.c:
1535         (main):
1536
1537 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
1538
1539         [EFL] Add command line option to MiniBrowser to set user agent
1540         https://bugs.webkit.org/show_bug.cgi?id=116387
1541
1542         Reviewed by Christophe Dumez.
1543
1544         We need this option to compare the rendering differences according to different user agents.
1545
1546         * MiniBrowser/efl/main.c:
1547         (window_create):
1548         (elm_main):
1549
1550 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
1551
1552         Unreviewed, addressing test-webkitpy failures after r150317.
1553
1554         * Scripts/webkitpy/w3c/test_converter.py:
1555         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
1556
1557 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
1558
1559         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
1560         https://bugs.webkit.org/show_bug.cgi?id=114554
1561
1562         Reviewed by Gyuyoung Kim.
1563
1564         Using variables as target names is very uncommon in CMake.
1565         The usual way to specify the name of the resulting binary
1566         is to set the OUTPUT_NAME target property.
1567
1568         * DumpRenderTree/efl/CMakeLists.txt:
1569         * EWebLauncher/CMakeLists.txt:
1570         * ImageDiff/CMakeLists.txt:
1571         * MiniBrowser/efl/CMakeLists.txt:
1572         * TestWebKitAPI/CMakeLists.txt:
1573         * WebKitTestRunner/CMakeLists.txt:
1574         * WebKitTestRunner/PlatformEfl.cmake:
1575         * WinCELauncher/CMakeLists.txt:
1576
1577 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1578
1579         Unreviewed EFL build fix.
1580
1581         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
1582         WK2 build after r150305.
1583
1584         * Scripts/webkitperl/FeatureList.pm:
1585
1586 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
1587
1588         [GTK] Parallel build fails if gtk-doc is enabled
1589         https://bugs.webkit.org/show_bug.cgi?id=116227
1590
1591         Reviewed by Martin Robinson.
1592
1593         * GNUmakefile.am:
1594         Don't use the 'all' target to generate the documentation.
1595         The prerequisites of this target must be files that need to be
1596         built _before_ the actual compilation of WebKit starts. Since the
1597         documentation depends on WebKit being built first, this means in
1598         practice that the code will be built in parallel with the
1599         generation of its dependencies, potentially making the build fail.
1600
1601 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
1602
1603         Don't run hg.
1604
1605         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1606         (TestImporterTest):
1607
1608 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
1609
1610         Create a script to import W3C tests
1611         https://bugs.webkit.org/show_bug.cgi?id=111513
1612
1613         Reviewed by Ryosuke Niwa.
1614
1615         This patch attempts to re-land the 'import-w3c-tests'
1616         script and accompanying modules.  The tests and code have
1617         been cleaned up so that we do not log anything to stdout/stderr
1618         while running the tests (thanks to outputcapture) and do not
1619         write into the source tree while running the tests, and much
1620         but not all of the code has been converted over to using the webkitpy
1621
1622         * Scripts/import-w3c-tests: Added.
1623         * Scripts/webkitpy/w3c/__init__.py: Added.
1624         * Scripts/webkitpy/w3c/test_converter.py: Added.
1625         (W3CTestConverter):
1626         (W3CTestConverter.__init__):
1627         (W3CTestConverter.path_from_webkit_root):
1628         (W3CTestConverter.read_webkit_prefixed_css_property_list):
1629         (W3CTestConverter.convert_for_webkit):
1630         (W3CTestConverter.convert_css):
1631         (W3CTestConverter.convert_html):
1632         (W3CTestConverter.convert_testharness_paths):
1633         (W3CTestConverter.convert_prefixed_properties):
1634         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
1635         (W3CTestConverter.replace_tag):
1636         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
1637         (W3CTestConverterTest):
1638         (W3CTestConverterTest.fake_dir_path):
1639         (W3CTestConverterTest.test_read_prefixed_property_list):
1640         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
1641         (test_convert_for_webkit_harness_only):
1642         (test_convert_for_webkit_properties_only):
1643         (test_convert_for_webkit_harness_and_properties):
1644         (test_convert_test_harness_paths):
1645         (test_convert_prefixed_properties):
1646         (verify_conversion_happened):
1647         (verify_no_conversion_happened):
1648         (verify_test_harness_paths):
1649         (verify_prefixed_properties):
1650         (generate_test_content):
1651         * Scripts/webkitpy/w3c/test_importer.py: Added.
1652         (main):
1653         (parse_args):
1654         (validate_import_directory):
1655         (TestImporter):
1656         (TestImporter.__init__):
1657         (TestImporter.path_from_webkit_root):
1658         (TestImporter.do_import):
1659         (TestImporter.load_changeset):
1660         (TestImporter.find_importable_tests):
1661         (TestImporter.import_tests):
1662         (TestImporter.setup_destination_directory):
1663         (TestImporter.update_test_status):
1664         (TestImporter.remove_deleted_files):
1665         (TestImporter.write_import_log):
1666         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
1667         (TestImporterTest):
1668         (TestImporterTest.test_import_dir_with_no_tests):
1669         * Scripts/webkitpy/w3c/test_parser.py: Added.
1670         (TestParser):
1671         (TestParser.__init__):
1672         (TestParser.load_file):
1673         (TestParser.analyze_test):
1674         (TestParser.reference_links_of_type):
1675         (TestParser.is_jstest):
1676         (TestParser.support_files):
1677         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
1678         (TestParserTest):
1679         (TestParserTest.test_analyze_test_reftest_one_match):
1680         (test_analyze_test_reftest_multiple_matches):
1681         (test_analyze_test_reftest_match_and_mismatch):
1682         (test_analyze_test_reftest_with_ref_support_Files):
1683         (test_analyze_jstest):
1684         (test_analyze_pixel_test_all_true):
1685         (test_analyze_pixel_test_all_false):
1686         (test_analyze_non_html_file):
1687
1688 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
1689
1690         Leaks builders exit early frequently
1691         https://bugs.webkit.org/show_bug.cgi?id=116355
1692
1693         Reviewed by Stephanie Lewis.
1694
1695         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
1696         we tolerate from 20 to 50.
1697
1698         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1699         (RunWebKitTests.start):
1700         * Scripts/webkitpy/port/mac.py:
1701         (MacPort.default_child_processes):
1702
1703 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
1704
1705         Remove chrome-channels command from the webkit-patch
1706         https://bugs.webkit.org/show_bug.cgi?id=116303
1707
1708         Reviewed by Ryosuke Niwa.
1709
1710         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
1711         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
1712         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
1713         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
1714         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
1715         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
1716
1717 2013-05-17  David Kilzer  <ddkilzer@apple.com>
1718
1719         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
1720         Part 3 of 3: <http://webkit.org/b/116247>
1721
1722         Reviewed by Benjamin Poulain.
1723
1724         * Scripts/filter-build-webkit: Change while() loop to for() loop
1725         to track $previousLine, then pass $previousLine into
1726         shouldIgnoreLine().
1727         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
1728         line that begins with four spaces if the previous line is a
1729         linker error message.
1730         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1731         - Add "Ignored: " to test descriptions to document expected
1732           behavior.
1733         - Add comment blocks for various groups of tests.
1734         - Expand "Build settings" tests since we're changing the code in
1735           shouldIgnoreLine() that ignores those lines.
1736         - Add tests for undefined symbols error message.
1737         (description): Add.  Extract from global code.
1738
1739 2013-05-17  David Kilzer  <ddkilzer@apple.com>
1740
1741         Add tests for shouldIgnoreLine() in filter-build-webkit
1742         Part 2 of 3: <http://webkit.org/b/116247>
1743
1744         Reviewed by Benjamin Poulain.
1745
1746         * Scripts/filter-build-webkit:
1747         (shouldIgnoreLine): Add.  Extract code from global scope into
1748         subroutine to make it testable.
1749         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
1750         Tests shouldIgnoreLine() using output from a real build
1751         transcript.
1752
1753 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
1754
1755         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
1756         https://bugs.webkit.org/show_bug.cgi?id=116341
1757
1758         Reviewed by Brady Eidson.
1759
1760         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1761
1762 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
1763
1764         [Windows] Don't use pdevenv when building with VS2010.
1765         https://bugs.webkit.org/show_bug.cgi?id=116338.
1766
1767         Reviewed by Adam Roben.
1768
1769         * Scripts/webkitdirs.pm:
1770         (setupCygwinEnv): Check if we are using VS2005, and only use
1771         the 'pdevenv' hack if we are. Otherwise, just build with
1772         our standard project since it uses VS2010+'s native
1773         parallel building features.
1774
1775 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1776
1777         Unreviewed. Disable accelerated compositing until we figure out why it does not work
1778         properly in the 64 bits release bot.
1779
1780         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1781         (resetDefaultsToConsistentValues):
1782
1783 2013-05-17  David Kilzer  <ddkilzer@apple.com>
1784
1785         Make filter-build-webkit testable using LoadAsModule
1786         Part 1 of 3: <http://webkit.org/b/116247>
1787
1788         Reviewed by Benjamin Poulain.
1789
1790         * Scripts/filter-build-webkit: Change global variables that are
1791         used in subroutines from 'my' to 'our' to make it possible to
1792         evaluate the script in a package context in LoadAsModule.pm.
1793
1794 2013-05-14  Sam Weinig  <sam@webkit.org>
1795
1796         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
1797         https://bugs.webkit.org/show_bug.cgi?id=116132
1798
1799         Reviewed by Anders Carlsson.
1800
1801         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
1802         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
1803
1804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1805         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
1806         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
1807         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1808
1809 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
1810
1811         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
1812         https://bugs.webkit.org/show_bug.cgi?id=114781
1813
1814         Reviewed by Christophe Dumez.
1815
1816         Add run_before_unload_confirm and
1817         Print the log message with "CONFIRM NAVIGATION: " in console.
1818
1819         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1820         (onBeforeUnloadConfirm):
1821         (drtViewAdd):
1822
1823 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
1824
1825         Fix Analyze ChangeLog's entry processing
1826         https://bugs.webkit.org/show_bug.cgi?id=116219
1827
1828         Reviewed by Ryosuke Niwa.
1829
1830         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1831         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
1832
1833 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
1834
1835         [Qt] UrlLoader::loadNext is broken in MiniBrowser
1836         https://bugs.webkit.org/show_bug.cgi?id=116099
1837
1838         Reviewed by Jocelyn Turcotte.
1839
1840         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
1841         are not available any more. So, UrlLoader::loadNext was broken
1842         because it failed to connect to those signals.
1843
1844         * MiniBrowser/qt/UrlLoader.cpp:
1845         (UrlLoader::UrlLoader):
1846         (UrlLoader::loadingChanged):
1847         * MiniBrowser/qt/UrlLoader.h:
1848         (UrlLoader):
1849
1850 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
1851
1852         [WebSocket] Update pywebsocket to r760
1853         https://bugs.webkit.org/show_bug.cgi?id=115863
1854
1855         Reviewed by Alexey Proskuryakov.
1856
1857         Version r760 supports a newer draft of message compression.
1858         We need this update to finish the permessage compression patch in
1859         bug 98840. This patch also fixes failing unit tests after the update.
1860
1861         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
1862         (StreamBase._read):
1863         (StreamBase._read.of):
1864         (StreamBase._write):
1865         (StreamBase.receive_bytes):
1866         (StreamBase._read_until):
1867         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
1868         (parse_frame):
1869         (StreamOptions.__init__):
1870         (Stream.__init__):
1871         (Stream._receive_frame_as_frame_object):
1872         (Stream._get_message_from_frame):
1873         (Stream._process_close_message):
1874         (Stream.close_connection):
1875         (Stream.get_last_received_opcode):
1876         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
1877         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
1878         (Dispatcher.do_extra_handshake):
1879         (Dispatcher.transfer_data):
1880         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
1881         (ExtensionProcessorInterface.__init__):
1882         (ExtensionProcessorInterface.request):
1883         (ExtensionProcessorInterface):
1884         (ExtensionProcessorInterface.name):
1885         (ExtensionProcessorInterface.check_consistency_with_other_processors):
1886         (ExtensionProcessorInterface.set_active):
1887         (ExtensionProcessorInterface.is_active):
1888         (ExtensionProcessorInterface._get_extension_response_internal):
1889         (ExtensionProcessorInterface.get_extension_response):
1890         (ExtensionProcessorInterface._setup_stream_options_internal):
1891         (ExtensionProcessorInterface.setup_stream_options):
1892         (_log_outgoing_compression_ratio):
1893         (_log_incoming_compression_ratio):
1894         (_parse_window_bits):
1895         (_AverageRatioCalculator):
1896         (_AverageRatioCalculator.__init__):
1897         (_AverageRatioCalculator.add_original_bytes):
1898         (_AverageRatioCalculator.add_result_bytes):
1899         (_AverageRatioCalculator.get_average_ratio):
1900         (DeflateFrameExtensionProcessor):
1901         (DeflateFrameExtensionProcessor.__init__):
1902         (DeflateFrameExtensionProcessor._get_extension_response_internal):
1903         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
1904         (DeflateFrameExtensionProcessor._outgoing_filter):
1905         (DeflateFrameExtensionProcessor._incoming_filter):
1906         (CompressionExtensionProcessorBase.for):
1907         (CompressionExtensionProcessorBase.__init__):
1908         (CompressionExtensionProcessorBase._get_extension_response_internal):
1909         (CompressionExtensionProcessorBase._setup_stream_options_internal):
1910         (PerFrameCompressExtensionProcessor):
1911         (PerMessageDeflateExtensionProcessor):
1912         (PerMessageDeflateExtensionProcessor.__init__):
1913         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
1914         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
1915         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
1916         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
1917         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
1918         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
1919         (PerMessageDeflateExtensionProcessor.set_bfinal):
1920         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
1921         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
1922         (_PerMessageDeflateFramer):
1923         (_PerMessageDeflateFramer.__init__):
1924         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
1925         (_PerMessageDeflateFramer._process_incoming_message):
1926         (_PerMessageDeflateFramer._process_outgoing_message):
1927         (_PerMessageDeflateFramer.setup_stream_options):
1928         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
1929         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
1930         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
1931         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
1932         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
1933         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
1934         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
1935         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
1936         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
1937         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
1938         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
1939         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
1940         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
1941         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
1942         (PerMessageCompressExtensionProcessor):
1943         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
1944         (MuxExtensionProcessor.__init__):
1945         (MuxExtensionProcessor.check_consistency_with_other_processors):
1946         (MuxExtensionProcessor):
1947         (MuxExtensionProcessor._get_extension_response_internal):
1948         (MuxExtensionProcessor._setup_stream_options_internal):
1949         (MuxExtensionProcessor.set_quota):
1950         (MuxExtensionProcessor.quota):
1951         (MuxExtensionProcessor.set_extensions):
1952         (MuxExtensionProcessor.extensions):
1953         (is_compression_extension):
1954         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
1955         (validate_subprotocol):
1956         (parse_host_header):
1957         (format_header):
1958         (check_request_line):
1959         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
1960         (Handshaker.do_handshake):
1961         (Handshaker._create_handshake_response):
1962         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
1963         (_validate_subprotocol):
1964         (_check_header_lines):
1965         (_build_location):
1966         (Handshaker.do_handshake):
1967         (Handshaker._set_subprotocol):
1968         (Handshaker._set_location):
1969         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
1970         (_create_dispatcher):
1971         (headerparserhandler):
1972         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
1973         (_create_add_channel_response):
1974         (_create_drop_channel):
1975         (_create_flow_control):
1976         (_create_new_channel_slot):
1977         (_create_fallback_new_channel_slot):
1978         (_MuxFramePayloadParser._read_number):
1979         (_MuxFramePayloadParser._read_size_and_contents):
1980         (_MuxFramePayloadParser._read_flow_control):
1981         (_MuxFramePayloadParser._read_new_channel_slot):
1982         (_LogicalConnection.__init__):
1983         (_LogicalConnection.write):
1984         (_LogicalConnection.on_write_data_done):
1985         (_LogicalConnection):
1986         (_LogicalConnection.on_writer_done):
1987         (_InnerMessage):
1988         (_InnerMessage.__init__):
1989         (_InnerMessageBuilder):
1990         (_InnerMessageBuilder.that):
1991         (_InnerMessageBuilder.__init__):
1992         (_InnerMessageBuilder._handle_first):
1993         (_InnerMessageBuilder._process_first_fragmented_control):
1994         (_InnerMessageBuilder._process_first_fragmented_message):
1995         (_InnerMessageBuilder._handle_fragmented_control):
1996         (_InnerMessageBuilder._reassemble_fragmented_control):
1997         (_InnerMessageBuilder._handle_fragmented_message):
1998         (_InnerMessageBuilder._reassemble_fragmented_message):
1999         (_InnerMessageBuilder.build):
2000         (_LogicalStream.__init__):
2001         (_LogicalStream._create_inner_frame):
2002         (_LogicalStream._write_inner_frame):
2003         (_LogicalStream.replenish_send_quota):
2004         (_LogicalStream.send_message):
2005         (_LogicalStream._receive_frame):
2006         (_LogicalStream._get_message_from_frame):
2007         (_LogicalStream.stop_sending):
2008         (_PhysicalConnectionWriter.__init__):
2009         (_PhysicalConnectionWriter._write_data):
2010         (_PhysicalConnectionWriter.run):
2011         (_PhysicalConnectionWriter.stop):
2012         (_Worker.run):
2013         (_MuxHandshaker.__init__):
2014         (_MuxHandshaker._create_stream):
2015         (_MuxHandshaker._create_handshake_response):
2016         (_HandshakeDeltaBase.create_headers):
2017         (_MuxHandler.start):
2018         (_MuxHandler.wait_until_done):
2019         (_MuxHandler.notify_write_data_done):
2020         (_MuxHandler._process_drop_channel):
2021         (_MuxHandler._process_logical_frame):
2022         (_MuxHandler.notify_reader_done):
2023         (_MuxHandler):
2024         (_MuxHandler.notify_writer_done):
2025         (_MuxHandler.fail_physical_connection):
2026         (_MuxHandler.fail_logical_channel):
2027         (use_mux):
2028         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
2029         (_StandaloneRequest.get_uri):
2030         (_StandaloneRequest.get_unparsed_uri):
2031         (_StandaloneRequest):
2032         (_StandaloneRequest.is_https):
2033         (_import_ssl):
2034         (_import_pyopenssl):
2035         (_StandaloneSSLConnection.for):
2036         (_StandaloneSSLConnection):
2037         (_StandaloneSSLConnection.__getattribute__):
2038         (_StandaloneSSLConnection.__setattr__):
2039         (_StandaloneSSLConnection.makefile):
2040         (_StandaloneSSLConnection.shutdown):
2041         (_StandaloneSSLConnection.recv):
2042         (WebSocketServer.__init__):
2043         (WebSocketServer._create_sockets):
2044         (WebSocketServer.handle_error):
2045         (WebSocketServer.get_request):
2046         (WebSocketServer.get_request.default_callback):
2047         (WebSocketRequestHandler.parse_request):
2048         (_build_option_parser):
2049         (_main):
2050         (_main.if):
2051         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
2052         (RepeatedXorMasker.__init__):
2053         (RepeatedXorMasker._mask_using_swig):
2054         (RepeatedXorMasker):
2055         (RepeatedXorMasker._mask_using_array):
2056         (_Deflater.compress_and_finish):
2057         (_RFC1979Deflater.filter):
2058         (DeflateSocket.send):
2059
2060 2013-05-16  Jonathan Liu  <net147@gmail.com>
2061
2062         Fix testing if program exists in PATH
2063         https://bugs.webkit.org/show_bug.cgi?id=116216
2064
2065         Reviewed by Jocelyn Turcotte.
2066
2067         functions.prf incorrectly uses win_cmd_shell to test whether to
2068         add .exe to the executable name when checking if it exists in
2069         the PATH environment variable. This works correctly when
2070         building using Windows Command Prompt but not under MSYS shell.
2071
2072         To resolve this, check the win32 platform scope instead of
2073         win_cmd_shell so that it correctly adds .exe to the executable
2074         name on Windows regardless of the shell used when testing if
2075         it exists in PATH.
2076
2077         * qmake/mkspecs/features/functions.prf:
2078
2079 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
2080
2081         Fix the hard-coded names of EWS bots that run tests.
2082
2083         * Scripts/webkitpy/tool/commands/queues.py:
2084         (CommitQueue.did_pass_testing_ews):
2085
2086 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2087
2088         [GTK] Build Xvfb with jhbuild
2089         https://bugs.webkit.org/show_bug.cgi?id=115907
2090
2091         Reviewed by Martin Robinson.
2092
2093         Build our own Xvfb so that we can avoid problems with the system Xvfb
2094         relying on symbols not present in our jhbuilt libraries such as pixman,
2095         and also to ensure we have the fix for a GLX module crasher.
2096
2097         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2098         (resetDefaultsToConsistentValues): enable accelerated compositing.
2099         * gtk/install-dependencies: list packages required for building Xvfb.
2100         * gtk/jhbuild.modules: add xserver as a jhbuild module.
2101         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
2102         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
2103         initializing the GLX module for Xvfb.
2104
2105 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2106
2107         [jhbuild] Should remove the sources directory as well when cleaning
2108         https://bugs.webkit.org/show_bug.cgi?id=116229
2109
2110         Reviewed by Martin Robinson.
2111
2112         * Scripts/update-webkit-libs-jhbuild:
2113         (cleanJhbuild): remove the Source directory as well when cleaning.
2114
2115 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
2116
2117         [EFL] Remove Intel Wk2 Buildbots from Master
2118         https://bugs.webkit.org/show_bug.cgi?id=116149
2119
2120         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
2121         since Gyuyoung Kim from Samsung plans to take over and maintain it.
2122
2123         Reviewed by Benjamin Poulain.
2124
2125         * BuildSlaveSupport/build.webkit.org-config/config.json:
2126
2127 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
2128
2129         [Windows] Update various build tools to understand VS2010 environment.
2130         https://bugs.webkit.org/show_bug.cgi?id=116169.
2131
2132         Reviewed by Anders Carlsson.
2133
2134         * Scripts/build-api-tests: Identify VS2010 environment.
2135         * Scripts/build-dumprendertree: Ditto.
2136         * Scripts/build-webkit: Ditto.
2137         * Scripts/webkitdirs.pm:
2138         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
2139         range of acceptable SDK's.
2140
2141 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
2142
2143         Allow http tests on Arch Linux
2144         https://bugs.webkit.org/show_bug.cgi?id=116155
2145
2146         Reviewed by Ryosuke Niwa.
2147
2148         * Scripts/webkitpy/port/base.py:
2149         (Port._is_arch_based): Added check for /etc/arch-release file.
2150         (Port._apache_config_file_name_for_platform): Call the check.
2151         * Scripts/webkitpy/port/port_testcase.py:
2152         (test_linux_distro_detection): Testcase added.
2153
2154 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
2155
2156         Remove a leftover v8 file from the watchlist
2157         https://bugs.webkit.org/show_bug.cgi?id=116158
2158
2159         Reviewed by Csaba Osztrogonác.
2160
2161         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
2162
2163 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
2164
2165         [GTK] Fails to build while generating gtkdoc
2166         https://bugs.webkit.org/show_bug.cgi?id=115612
2167
2168         Reviewed by Philippe Normand.
2169
2170         Fix typo in the prerequisites of docs-build.stamp.
2171
2172         * GNUmakefile.am:
2173
2174 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
2175
2176         Unreviewed, fixing the current test-webkitpy failure.
2177
2178         * Scripts/webkitpy/port/mac_unittest.py:
2179         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
2180         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
2181
2182 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
2183
2184         Fix build after r150090.
2185         https://bugs.webkit.org/show_bug.cgi?id=116129
2186
2187         Unreviewed build fix after r150090.
2188
2189         * WebKitTestRunner/TestInvocation.cpp:
2190         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2191
2192 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2193
2194         [Windows, others] Unreviewed build fix after r150090.
2195
2196         * DumpRenderTree/TestRunner.cpp:
2197         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
2198         doesn't exist on other platforms.
2199
2200 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
2201
2202         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
2203         https://bugs.webkit.org/show_bug.cgi?id=115889
2204
2205         Reviewed by Benjamin Poulain.
2206
2207         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2208         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2209
2210 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2211
2212         [Windows] Identify proper run environment for scripts.
2213         https://bugs.webkit.org/show_bug.cgi?id=116114
2214
2215         Reviewed by David Kilzer.
2216
2217         Determine (based on Visual Studio version) which path to use for
2218         executables (bin versus bin32).
2219
2220         * Scripts/webkitdirs.pm:
2221         (determineVisualStudioInstallDir): Added.
2222         (determineVisualStudioVersion): Added.
2223         (determineConfigurationProductDir): Modified to choose proper bin
2224         or bin32 directory.
2225         (visualStudioVersion): Added
2226         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
2227
2228 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
2229
2230         [Mac] Add tests for secure event input
2231         https://bugs.webkit.org/show_bug.cgi?id=116121
2232
2233         Reviewed by Mark Rowe.
2234
2235         * DumpRenderTree/TestRunner.cpp:
2236         (getSecureEventInputIsEnabledCallback):
2237         (TestRunner::staticValues):
2238         Expose an accessor for current secure event input state.
2239
2240         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2241         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2242         (WTR::TestRunner::secureEventInputIsEnabled):
2243         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2244         * WebKitTestRunner/TestInvocation.cpp:
2245         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2246         Expose an accessor for current secure event input state. This has to be done in
2247         UI process, as this is where it's changed by WebKit.
2248
2249 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
2250
2251         [Mac] Add a testing shim for secure event input functions
2252         https://bugs.webkit.org/show_bug.cgi?id=116122
2253
2254         Reviewed by Mark Rowe.
2255
2256         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
2257         Inject WebCore testing shim library to override system framework functions.
2258
2259 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2260
2261         [Windows] Switch to embedded manifest commands for launcher executables.
2262         https://bugs.webkit.org/show_bug.cgi?id=116109
2263
2264         Reviewed by Darin Adler.
2265
2266         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
2267         now-unused WinLauncher.exe.manifest file.
2268         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
2269         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
2270         when building with VS2010 or newer.
2271
2272 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2273
2274         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
2275         https://bugs.webkit.org/show_bug.cgi?id=116079
2276
2277         Reviewed by David Kilzer.
2278
2279         * Scripts/old-run-webkit-tests:
2280         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
2281
2282 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
2283
2284         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
2285         https://bugs.webkit.org/show_bug.cgi?id=115921
2286
2287         Reviewed by Gustavo Noronha Silva.
2288
2289         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
2290         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
2291
2292 2013-05-13  Alex Christensen  <achristensen@apple.com>
2293
2294         Added testRunner.setPrinting.
2295         https://bugs.webkit.org/show_bug.cgi?id=42693
2296         rdar://problem/8213845
2297
2298         Reviewed by Darin Adler.
2299
2300         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2301         Added setPrinting JavaScript function.
2302         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2303         (WTR::InjectedBundlePage::dump):
2304         Dump the external representation for printing if setPrinting has been called.
2305         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2306         (WTR::TestRunner::isPrinting): Added.
2307         (WTR::TestRunner::setPrinting): Added.
2308         Added and initialized m_isPrinting member boolean.
2309
2310 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
2311
2312         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
2313         https://bugs.webkit.org/show_bug.cgi?id=116016
2314
2315         Reviewed by Dirk Pranke.
2316
2317         Same fix as in the upstream style checker, but without hg support.
2318         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
2319
2320         * Scripts/webkitpy/style/checkers/cpp.py:
2321         (FileInfo.repository_name):
2322
2323 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
2324
2325         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
2326         https://bugs.webkit.org/show_bug.cgi?id=115918
2327
2328         Reviewed by Gustavo Noronha Silva.
2329
2330         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
2331         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
2332         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
2333         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
2334         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
2335         problems.
2336
2337         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
2338         These are then used as dependencies for the archive creation rule as well as the list from which the archive
2339         file paths are constructed and then used to dump the member files from these archives. The member files are
2340         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
2341         successfully link.
2342
2343         * TestWebKitAPI/GNUmakefile.am:
2344
2345 2013-05-13  Anders Carlsson  <andersca@apple.com>
2346
2347         Remove UnusedParam.h
2348         https://bugs.webkit.org/show_bug.cgi?id=116029
2349
2350         Reviewed by Andreas Kling.
2351
2352         Stop including UnusedParam.h.
2353
2354         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2355         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2356
2357 2013-05-12  Commit Queue  <commit-queue@webkit.org>
2358
2359         Unreviewed, rolling out r149955.
2360         http://trac.webkit.org/changeset/149955
2361         https://bugs.webkit.org/show_bug.cgi?id=115990
2362
2363         Broke lots of tests (Requested by smfr on #webkit).
2364
2365         * Scripts/webkitpy/port/mac.py:
2366
2367 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2368
2369         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
2370         https://bugs.webkit.org/show_bug.cgi?id=115914
2371
2372         Reviewed by Martin Robinson.
2373
2374         * GtkLauncher/main.c:
2375         (createToolbar):
2376         * MiniBrowser/gtk/BrowserWindow.c:
2377         (_BrowserWindow):
2378         (browserWindowSetStatusText):
2379         (fullScreenMessageTimeoutCallback):
2380         (webViewEnterFullScreen):
2381         (webViewLeaveFullScreen):
2382         (browserWindowFinalize):
2383         (browserWindowConstructed):
2384         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2385         (WTR::EventSenderProxy::mouseScrollBy):
2386         (WTR::EventSenderProxy::continuousMouseScrollBy):
2387
2388 2013-05-11  Anders Carlsson  <andersca@apple.com>
2389
2390         Crash when terminating a process that has not been fully launched
2391         https://bugs.webkit.org/show_bug.cgi?id=115962
2392         <rdar://problem/13660916>
2393
2394         Reviewed by Andreas Kling.
2395
2396         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
2397         before the process has had a chance to be fully launched.
2398
2399         * TestWebKitAPI/GNUmakefile.am:
2400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2401         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
2402         (TestWebKitAPI):
2403         (TestWebKitAPI::didFinishLoadForFrame):
2404         (TestWebKitAPI::TEST):
2405         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
2406
2407 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
2408
2409         Remove Mac OS X Leopard (10.5) support
2410         https://bugs.webkit.org/show_bug.cgi?id=107964
2411
2412         Reviewed by Ryosuke Niwa.
2413
2414         Removed the code for 10.5 and removed if-def for 10.6.
2415
2416         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2417         (convertMIMEType):
2418         (createXMLStringFromWebArchiveData):
2419         * DumpRenderTree/mac/TestRunnerMac.mm:
2420         (TestRunner::authenticateSession):
2421         (TestRunner::setTextDirection):
2422         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
2423         (convertMIMEType):
2424         (createXMLStringFromWebArchiveData):
2425
2426 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
2427
2428         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
2429         https://bugs.webkit.org/show_bug.cgi?id=115935
2430
2431         Reviewed by Jer Noble.
2432
2433         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
2434         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
2435         to the new manifest file.
2436         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
2437
2438 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
2439
2440         Fix some compiler warnings (miscellaneous)
2441         https://bugs.webkit.org/show_bug.cgi?id=80790
2442
2443         Reviewed by Rob Buis.
2444
2445         Fix the following warnings for BlackBerry:
2446         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
2447         used as truth value [-Wparentheses].
2448
2449         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2450         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2451
2452 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2453
2454         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
2455         https://bugs.webkit.org/show_bug.cgi?id=115928
2456
2457         Reviewed by Kenneth Rohde Christiansen.
2458
2459         WKViewSetThemePath was moved to WKViewEfl.h.
2460
2461         * TestWebKitAPI/efl/PlatformWebView.cpp:
2462
2463 2013-05-10  Andreas Kling  <akling@apple.com>
2464
2465         I accidentally the Java testing.
2466
2467         * Scripts/webkitpy/port/mac.py:
2468
2469 2013-05-10  Brian Holt  <brian.holt@samsung.com>
2470
2471         [GTK] Module Cairo fails to build under jhbuild
2472         https://bugs.webkit.org/show_bug.cgi?id=115854
2473
2474         Reviewed by Martin Robinson.
2475
2476         Make cairo depend on glib in jhbuild.modules.
2477
2478         * gtk/jhbuild.modules:
2479
2480 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2481
2482         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
2483         https://bugs.webkit.org/show_bug.cgi?id=115904
2484
2485         Reviewed by Martin Robinson.
2486
2487         * ImageDiff/gtk/ImageDiff.cpp:
2488         (main):
2489
2490 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
2491
2492         Add my new address to contributors.json. (Unreviewed)
2493
2494         * Scripts/webkitpy/common/config/contributors.json:
2495
2496 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2497
2498         Unreviewed. Move myself to the reviewers list.
2499
2500         * Scripts/webkitpy/common/config/contributors.json:
2501
2502 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2503
2504         Unreviewed. Add my email to a few watchlists.
2505
2506         * Scripts/webkitpy/common/config/watchlist:
2507
2508 2013-05-10  Simon Pena  <simon.pena@samsung.com>
2509
2510         Unicode support missing from string representation of Contributors in committers.py
2511         https://bugs.webkit.org/show_bug.cgi?id=115859
2512
2513         Reviewed by Darin Adler.
2514
2515         Contributors, in committers.py, provided a string representation in __str__ which
2516         didn't support unicode characters, so printing a contributor would fail in that case.
2517         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
2518         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
2519
2520         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
2521         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
2522         representation.
2523         (Contributor.__str__):
2524         (Contributor):
2525         (Contributor.__unicode__):
2526         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
2527         a contributor with unicode characters can be represented as a string.
2528         (CommittersTest):
2529         (CommittersTest.test_contributor_encoding):
2530
2531 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
2532
2533         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
2534         https://bugs.webkit.org/show_bug.cgi?id=92371
2535
2536         Reviewed by Brent Fulgham.
2537
2538         Use JavaScriptThreading.cpp where the same functionality is
2539         implemented too. This reduces the dependency on the pthread
2540         library. Also replace assert() with WebKit ASSERT().
2541
2542         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2543         * DumpRenderTree/win/DumpRenderTree.cpp:
2544         (dumpHistoryItem):
2545         (dumpBackForwardList):
2546         * DumpRenderTree/win/DumpRenderTree.vcproj:
2547
2548 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
2549
2550         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
2551         https://bugs.webkit.org/show_bug.cgi?id=92505
2552
2553         Reviewed by Brent Fulgham.
2554
2555         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2556         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
2557         (javaScriptThreadsMutex):
2558         (javaScriptThreads):
2559         (runJavaScriptThread):
2560         (startJavaScriptThreads):
2561         (stopJavaScriptThreads):
2562         * DumpRenderTree/pthreads: Removed.
2563         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
2564
2565 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
2566
2567         Unreviewed. Update Simon Pena email on his behalf.
2568
2569         * Scripts/webkitpy/common/config/contributors.json:
2570
2571 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2572
2573         Add support for [NoInterfaceObject] Web IDL extended attribute
2574         https://bugs.webkit.org/show_bug.cgi?id=115714
2575
2576         Reviewed by Kentaro Hara.
2577
2578         Update BindingsTests.generate_supplemental_dependency() to pass an
2579         additional windowConstructorsFile argument to preprocess-idls.pl.
2580
2581         * Scripts/webkitpy/bindings/main.py:
2582         (BindingsTests.generate_supplemental_dependency):
2583         (BindingsTests.main):
2584
2585 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
2586
2587         [GTK][AC] Buildfix after r149694
2588         https://bugs.webkit.org/show_bug.cgi?id=115797
2589
2590         Reviewed by Gustavo Noronha Silva.
2591
2592         Add CLUTTER_LIBS for linking TestWebCore.
2593
2594         * TestWebKitAPI/GNUmakefile.am:
2595
2596 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2597
2598         [EFL] Remove unnecessary pkgs in EFL jhbuild
2599         https://bugs.webkit.org/show_bug.cgi?id=114908
2600
2601         Reviewed by Laszlo Gombos.
2602
2603         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
2604         handle them using jhbuild. We can reduce build time when using --update-efl.
2605
2606         * efl/jhbuild.modules:
2607
2608 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
2609
2610         [EFL] Disable SHADOW DOM feature in FeatureList.pm
2611         https://bugs.webkit.org/show_bug.cgi?id=115834
2612
2613         Reviewed by Gyuyoung Kim.
2614
2615         * Scripts/webkitperl/FeatureList.pm:
2616
2617 2013-05-08  Lucas Forschler  <lforschler@apple.com>
2618
2619         Add Scheduler for Mac MtnLion 32bit Release builder.
2620         
2621         Unreviewed.
2622         
2623         * BuildSlaveSupport/build.webkit.org-config/config.json:
2624
2625 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
2626
2627         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
2628         https://bugs.webkit.org/show_bug.cgi?id=115808
2629
2630         Reviewed by Darin Adler.
2631
2632         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
2633         was left outdated after r127191, when the m_string member was changed
2634         from UString to String. This patch calls the right pretty printer for it.
2635
2636         * gdb/webkit.py:
2637         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
2638         WTFImplPrettyPrinter.
2639
2640 2013-05-08  Andy Estes  <aestes@apple.com>
2641
2642         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
2643         https://bugs.webkit.org/show_bug.cgi?id=115790
2644
2645         Reviewed by Alexey Proskuryakov.
2646
2647         Added two API tests:
2648
2649         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
2650         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
2651
2652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2653         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
2654         (TestWebKitAPI):
2655         (TestWebKitAPI::TEST):
2656         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
2657         (TestWebKitAPI):
2658         (TestWebKitAPI::decidePolicyForNavigationAction):
2659         (CustomProtocolInvalidSchemeTest):
2660         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
2661
2662 2013-05-08  Lucas Forschler  <lforschler@apple.com>
2663
2664         Teach buildbot how to compile 32-bit on Mac.
2665
2666         Reviewed by Ryosuke Niwa.
2667
2668         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2669         (CompileWebKit.start):
2670         (ExtractTestResultsAndLeaks):
2671
2672 2013-05-08  Eli Fidler  <efidler@blackberry.com>
2673
2674         [BlackBerry] Fix usage of BlackBerry::Platform::String
2675         https://bugs.webkit.org/show_bug.cgi?id=115781
2676
2677         Reviewed by Rob Buis.
2678
2679         BlackBerry PRs 304193 and 327181
2680         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
2681
2682         We currently have a problem where we're passing UTF-8 encoded data into
2683         the char* constructors of BlackBerry::Platform::String. This means the string
2684         thinks its data is not UTF-8.
2685
2686         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2687         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2688         (BlackBerry::WebKit::dumpHistoryItem):
2689         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2690         (TestRunner::setUserStyleSheetLocation):
2691         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
2692         (LoadHTMLStringItem::invoke):
2693
2694 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
2695
2696         Tools: add new BlackBerry include dirs.
2697         https://bugs.webkit.org/show_bug.cgi?id=115514
2698
2699         Reviewed by Rob Buis.
2700
2701         iType include dirs are missing, and HarfBuzz needs to be fixed.
2702
2703         * Scripts/webkitdirs.pm:
2704         (blackberryCMakeArguments):
2705
2706 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
2707
2708         [GTK] Plumb the Automake build system for the Battery Status API feature
2709         https://bugs.webkit.org/show_bug.cgi?id=115718
2710
2711         Reviewed by Martin Robinson.
2712
2713         * Scripts/webkitdirs.pm:
2714         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
2715         through the --(enable|disable)-battery-status flag passed to configure.
2716
2717 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
2718
2719         new-run-webkit-websocketserver doesn't work after Chromium removal
2720         https://bugs.webkit.org/show_bug.cgi?id=115816
2721
2722         Reviewed by Joseph Pecoraro.
2723
2724         Fix the bug by instantiating the correct port object.
2725
2726         * Scripts/new-run-webkit-websocketserver:
2727         (main):
2728
2729 2013-05-07  Lucas Forschler  <lforschler@apple.com>
2730
2731         Configure buildbot for 32bit builder.
2732         https://bugs.webkit.org/show_bug.cgi?id=115769
2733         
2734         Reviewed by Ryosuke Niwa.
2735
2736         * BuildSlaveSupport/build.webkit.org-config/config.json:
2737
2738 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
2739
2740         Unreviewed. Update to show my apple.com address.
2741
2742         * Scripts/webkitpy/common/config/contributors.json: Added
2743         my apple.com e-mail address.
2744
2745 2013-05-08  David Kilzer  <ddkilzer@apple.com>
2746
2747         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
2748
2749         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2750         (concatenateAttributeAndValue): Switch to appendVector().
2751
2752 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
2753
2754         [Qt][WTR] Fix the build on Mac after r149692
2755
2756         Unreviewed build fix.
2757
2758         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2759         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2760
2761 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
2762
2763         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
2764         to the watchlist for Accessibility.
2765
2766         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
2767         * Scripts/webkitpy/common/config/watchlist: Added myself.
2768
2769 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
2770
2771         [Qt] Build fails with clang
2772         https://bugs.webkit.org/show_bug.cgi?id=115741
2773
2774         Reviewed by Benjamin Poulain.
2775
2776         Since r149112 std::move is used in AtomicString for compilers that
2777         support rvalue references and this requires a standard library
2778         implementing c++11 move semantics.
2779         We only explicitely require c++11 for WebKit2, but since clang supports
2780         rvalue references the build of subtargets using AtomicString fails because
2781         of missing std::move.
2782         It is safe to add CONFIG += c++11 for the whole project when using clang
2783         since we explicitely disable c++11 for ANGLE that had probems with libc++.
2784
2785         * qmake/mkspecs/features/unix/default_pre.prf:
2786
2787 2013-05-08  Darin Adler  <darin@apple.com>
2788
2789         Fix one more place that needed to use adoptCF/NS
2790         https://bugs.webkit.org/show_bug.cgi?id=115778
2791
2792         Reviewed by Benjamin Poulain.
2793
2794         Not sure why I missed this code last time, but found a bit more code that needs
2795         to switch to the newer style adoptCF/NS.
2796
2797         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
2798         (convertWebResourceDataToString): Use adoptCF.
2799         (convertWebResourceResponseToDictionary): Ditto.
2800         (createXMLStringFromWebArchiveData): Ditto.
2801         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
2802         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
2803
2804 2013-05-08  Commit Queue  <commit-queue@webkit.org>
2805
2806         Unreviewed, rolling out r149271.
2807         http://trac.webkit.org/changeset/149271
2808         https://bugs.webkit.org/show_bug.cgi?id=115780
2809
2810         The mangled symbols are now enforced through LDFLAGS
2811         (Requested by zdobersek on #webkit).
2812
2813         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2814
2815 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
2816
2817         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
2818         https://bugs.webkit.org/show_bug.cgi?id=115636
2819
2820         Reviewed by Ryosuke Niwa.
2821
2822         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2823         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
2824         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
2825         while Chromium-specific, can't be removed just yet as there's more code that uses it.
2826
2827 2013-05-06  Darin Adler  <darin@apple.com>
2828
2829         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
2830         https://bugs.webkit.org/show_bug.cgi?id=115657
2831
2832         Reviewed by Sam Weinig.
2833
2834         This is similar to my last set of changes, but covers code that I missed with
2835         global replace using the Safari Xcode workspace.
2836
2837         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2838         (convertWebResourceDataToString):
2839         (convertWebResourceResponseToDictionary):
2840         (createXMLStringFromWebArchiveData):
2841         * DumpRenderTree/cg/ImageDiffCG.cpp:
2842         (createImageFromStdin):
2843         (createDifferenceImage):
2844         (main):
2845         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2846         (printPNG):
2847         (dumpBitmap):
2848         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2849         (BitmapContext::BitmapContext):
2850         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2851         (-[MockWebNotificationProvider init]):
2852         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2853         (createBitmapContext):
2854         * DumpRenderTree/mac/TestRunnerMac.mm:
2855         (TestRunner::addDisallowedURL):
2856         (TestRunner::applicationCacheDiskUsageForOrigin):
2857         (TestRunner::localStorageDiskUsageForOrigin):
2858         (TestRunner::clearApplicationCacheForOrigin):
2859         (TestRunner::deleteLocalStorageForOrigin):
2860         (TestRunner::copyDecodedHostName):
2861         (TestRunner::copyEncodedHostName):
2862         (TestRunner::queueLoad):
2863         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2864         (TestRunner::setMockGeolocationPositionUnavailableError):
2865         (TestRunner::setUserStyleSheetLocation):
2866         (TestRunner::setValueForUser):
2867         (TestRunner::overridePreference):
2868         (TestRunner::setPersistentUserStyleSheetLocation):
2869         (TestRunner::execCommand):
2870         (TestRunner::findString):
2871         (TestRunner::isCommandEnabled):
2872         (TestRunner::addOriginAccessWhitelistEntry):
2873         (TestRunner::removeOriginAccessWhitelistEntry):
2874         (TestRunner::addUserScript):
2875         (TestRunner::addUserStyleSheet):
2876         (TestRunner::evaluateInWebInspector):
2877         (TestRunner::evaluateScriptInIsolatedWorld):
2878         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2879         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
2880         (TestRunner::authenticateSession):
2881         (TestRunner::grantWebNotificationPermission):
2882         (TestRunner::denyWebNotificationPermission):
2883         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2884         (createCFURLResponseFromResponseData):
2885         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2886         (LoadItem::invoke):
2887         (LoadHTMLStringItem::invoke):
2888         (ScriptItem::invoke):
2889         * DumpRenderTree/win/DumpRenderTree.cpp:
2890         (substringFromIndex):
2891         (urlSuitableForTestResult):
2892         (lastPathComponent):
2893         (sharedCFURLCache):
2894         * DumpRenderTree/win/ImageDiffCairo.cpp:
2895         (createImageFromStdin):
2896         (main):
2897         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2898         (createBitmapContextFromWebView):
2899         * DumpRenderTree/win/TestRunnerWin.cpp:
2900         (TestRunner::setUserStyleSheetLocation):
2901         (TestRunner::setPersistentUserStyleSheetLocation):
2902         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2903         (TestWebKitAPI::TEST):
2904         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2905         (TestWebKitAPI::TEST):
2906         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2907         (TestWebKitAPI::TEST):
2908         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2909         (TestWebKitAPI::TEST):
2910         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2911         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2912         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2913         (TestWebKitAPI::createWindow):
2914         (TestWebKitAPI::TEST):
2915         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2916         (TestWebKitAPI::TEST):
2917         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
2918         (TestWebKitAPI::AcceptsFirstMouse::runTest):
2919         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2920         (TestWebKitAPI::TEST):
2921         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
2922         (TestWebKitAPI::TEST):
2923         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
2924         (TestWebKitAPI::TEST):
2925         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2926         (TestWebKitAPI::TEST):
2927         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
2928         (TestWebKitAPI::TEST):
2929         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2930         (TestWebKitAPI::TEST):
2931         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
2932         (TestWebKitAPI::TEST):
2933         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2934         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
2935         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2936         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
2937         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
2938         (TestWebKitAPI::TEST):
2939         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
2940         (TestWebKitAPI::TEST):
2941         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2942         (TestWebKitAPI::TEST):
2943         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
2944         (TestWebKitAPI::TEST):
2945         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
2946         (TestWebKitAPI::TEST):
2947         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2948         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2949         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2950         (TestWebKitAPI::TEST):
2951         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2952         (TestWebKitAPI::TEST):
2953         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
2954         (TestWebKitAPI::TEST):
2955         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2956         (TestWebKitAPI::TEST):
2957         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2958         (TestWebKitAPI::TEST):
2959         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2960         (TestWebKitAPI::TEST):
2961         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
2962         (TestWebKitAPI::TEST):
2963         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2964         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2965         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2966         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
2967         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2968         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
2969         (WTR::testPathFromURL):
2970         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2971         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2972         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2973         (WTR::createCGContextFromImage):
2974         (WTR::dumpBitmap):
2975         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2976         * WebKitTestRunner/mac/EventSenderProxy.mm:
2977         (WTR::EventSenderProxy::mouseScrollBy):
2978         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2979         (WTR::PlatformWebView::windowSnapshotImage):
2980         * WebKitTestRunner/win/TestControllerWin.cpp:
2981         (WTR::TestController::initializeTestPluginDirectory):
2982         Use adoptCF and adoptNS.
2983
2984 2013-05-07  Alex Christensen  <achristensen@apple.com>
2985
2986         Fix a memory leak introduced in r149692
2987         https://bugs.webkit.org/show_bug.cgi?id=115766
2988
2989         Reviewed by Mark Rowe.
2990
2991         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
2992         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
2993
2994         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2995         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2996         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
2997
2998 2013-05-07  Darin Adler  <darin@apple.com>
2999
3000         [Win] Fix storage leak in Windows DumpRenderTree
3001         https://bugs.webkit.org/show_bug.cgi?id=115651
3002
3003         Reviewed by Sam Weinig.
3004
3005         * DumpRenderTree/win/DumpRenderTree.cpp:
3006         (lastPathComponent): Added a missing call to adoptCF.
3007
3008 2013-05-07  Alex Christensen  <achristensen@apple.com>
3009
3010         fixed a memory leak introduced by bug 42324 by using a RetainPtr
3011         https://bugs.webkit.org/show_bug.cgi?id=115760
3012
3013         Reviewed by Tim Horton.
3014
3015         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3016         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3017         fixed memory leak, added UNUSED_PARAM macros
3018
3019 2013-05-07  Alex Christensen  <achristensen@apple.com>
3020
3021         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
3022         https://bugs.webkit.org/show_bug.cgi?id=42324
3023         <rdar://problem/8193633>
3024
3025         Reviewed by Tim Horton.
3026
3027         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3028         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
3029         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3030         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3031         Added dumpDOMAsWebArchive code that is called when dumping.        
3032         (WTR::InjectedBundlePage::dump):
3033         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
3034         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3035         (InjectedBundlePage):
3036         Added dumpDOMAsWebArchive declaration.
3037         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
3038         (WTR::TestRunner::dumpDOMAsWebArchive):
3039         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
3040         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3041         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
3042         * Tools/WebKitTestRunner/cf: Added.
3043         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
3044         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
3045         (convertMIMEType):
3046         (convertWebResourceDataToString):
3047         (normalizeHTTPResponseHeaderFields):
3048         (normalizeWebResourceURL):
3049         (convertWebResourceResponseToDictionary):
3050         (compareResourceURLs):
3051         (createXMLStringFromWebArchiveData):
3052         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
3053         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
3054         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
3055         Copied from Tools/DumpRenderTree/mac for used functions.
3056         (createCFURLResponseFromResponseData):
3057         (supportedNonImageMIMETypes):
3058
3059 2013-05-07  Alex Christensen  <achristensen@apple.com>
3060
3061         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
3062         https://bugs.webkit.org/show_bug.cgi?id=115745
3063
3064         Reviewed by Tim Horton.
3065
3066         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3067         (compareResourceURLs):
3068         Updated style.
3069
3070 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
3071
3072         Add an 'isReadOnly' member to IDL parse tree structure
3073         https://bugs.webkit.org/show_bug.cgi?id=115704
3074
3075         Reviewed by Kentaro Hara.
3076
3077         Use newly added isReadOnly attribute.
3078
3079         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3080         (_generateHeaderFile):
3081         (_generateImplementationFile):
3082         (_staticValuesGetterImplementation):
3083
3084 2013-05-07  Anders Carlsson  <andersca@apple.com>
3085
3086         Remove AlwaysInline.h from WTF
3087         https://bugs.webkit.org/show_bug.cgi?id=115727
3088
3089         Reviewed by Brent Fulgham.
3090
3091         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
3092         to keep AlwaysInline.h around anymore.
3093
3094         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3095         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3096
3097 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
3098
3099         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
3100         https://bugs.webkit.org/show_bug.cgi?id=114808
3101
3102         Reviewed by Jocelyn Turcotte.
3103
3104         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
3105         (https://codereview.qt-project.org/#change,54234)
3106
3107         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3108         (WTR::WrapperWindow::handleStatusChanged):
3109
3110 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3111
3112         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
3113
3114         * Scripts/webkitpy/common/config/watchlist:
3115
3116 2013-05-06  Kangil Han  <kangil.han@samsung.com>
3117
3118         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
3119         https://bugs.webkit.org/show_bug.cgi?id=115645
3120
3121         Reviewed by Gyuyoung Kim.
3122
3123         To run performance tests in wk1, we need --no-timeout option implementation.
3124         So adopt it from gtk+ port.
3125
3126         * DumpRenderTree/efl/DumpRenderTree.cpp:
3127         (shouldSetWaitToDumpWatchdog):
3128         (parseCommandLineOptions):
3129         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
3130         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3131         (TestRunner::setWaitToDump):
3132
3133 2013-05-06  Commit Queue  <commit-queue@webkit.org>
3134
3135         Unreviewed, rolling out r149547.
3136         http://trac.webkit.org/changeset/149547
3137         https://bugs.webkit.org/show_bug.cgi?id=115682
3138
3139         Added unittests that fail on bots and spits out text into
3140         stdout (Requested by rniwa on #webkit).
3141
3142         * Scripts/import-w3c-tests: Removed.
3143         * Scripts/webkitpy/w3c/__init__.py: Removed.
3144         * Scripts/webkitpy/w3c/test_converter.py: Removed.
3145         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
3146         * Scripts/webkitpy/w3c/test_importer.py: Removed.
3147         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
3148         * Scripts/webkitpy/w3c/test_parser.py: Removed.
3149         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
3150
3151 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
3152
3153         [jhbuild] bump jhbuild version to take advantage of new improvements
3154         https://bugs.webkit.org/show_bug.cgi?id=115558
3155
3156         Reviewed by Martin Robinson.
3157
3158         One of the important improvements is jhbuild no longer fetches git
3159         repositories if they are already at the expected revision, which should
3160         make the EWS bots more robust to git servers unavailability.
3161
3162         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
3163
3164 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
3165
3166         [GTK] Add webkit_uri_scheme_request_finish_error
3167         https://bugs.webkit.org/show_bug.cgi?id=94316
3168
3169         Reviewed by Anders Carlsson.
3170
3171         * MiniBrowser/gtk/main.c:
3172         (miniBrowserErrorQuark): Add function to create a global quark for
3173         MiniBrowser.
3174         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
3175         function webkit_uri_scheme_request_finish_error().
3176
3177 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
3178
3179         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
3180         https://bugs.webkit.org/show_bug.cgi?id=113808
3181
3182         Reviewed by Rob Buis.
3183
3184         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
3185         to true for BlackBerry.
3186
3187         * Scripts/webkitperl/FeatureList.pm:
3188
3189 2013-05-06  Jessie Berlin  <jberlin@apple.com>
3190
3191         check-webkit-style should complain about a layering violation if platform-specific guards are
3192         used in WebCore outside of the platform directory
3193         https://bugs.webkit.org/show_bug.cgi?id=115567
3194
3195         Reviewed by Benjamin Poulain.
3196
3197         * Scripts/webkitpy/style/checkers/cpp.py:
3198         (check_for_webcore_platform_layering_violation):
3199         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
3200         (process_line):
3201         Add the check_for_webcore_platform_layering_violation.
3202         (CppChecker):
3203         List the new check.
3204
3205         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3206         (CppStyleTest.test_webcore_platform_layering_violation):
3207         Add tests.
3208
3209 2013-05-06  David Kilzer  <ddkilzer@apple.com>
3210
3211         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
3212         <http://webkit.org/b/115667>
3213
3214         Reviewed by Dirk Pranke.
3215
3216         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3217         (Bugzilla._check_create_bug_response): Update regex to work with
3218         Bugzilla 3.2.3 and 4.2.5.
3219         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3220         (test__check_create_bug_response): Add new test that covers both
3221         old and new <title> variations.
3222
3223 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3224
3225         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
3226         https://bugs.webkit.org/show_bug.cgi?id=115661
3227
3228         Reviewed by Ryosuke Niwa.
3229
3230         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
3231         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
3232         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
3233
3234         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3235         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3236
3237 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3238
3239         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
3240         https://bugs.webkit.org/show_bug.cgi?id=114603
3241
3242         Reviewed by Ryosuke Niwa.
3243
3244         * TestResultServer/generate_builders_json.py:
3245         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
3246         to represent these to be 'layout-test', for backwards compatibility.
3247         (main): Remove all the build.chromium.org masters.
3248         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
3249         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
3250         (GenerateBuildersJsonTest):
3251         (GenerateBuildersJsonTest.test_generate_json_data):
3252         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
3253         test-running builders from the webkit.org master.
3254
3255 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3256
3257         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
3258         https://bugs.webkit.org/show_bug.cgi?id=114988
3259
3260         Reviewed by Ryosuke Niwa.
3261
3262         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
3263         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
3264         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
3265         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
3266         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
3267
3268 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3269
3270         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
3271         https://bugs.webkit.org/show_bug.cgi?id=114954
3272
3273         Reviewed by Ryosuke Niwa.
3274
3275         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3276         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
3277         modifier unions in the list of modifiers.
3278         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
3279         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
3280
3281 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3282
3283         [Flakiness Dashboard] Simplify builder-name-based platform recognition
3284         https://bugs.webkit.org/show_bug.cgi?id=114957
3285
3286         Reviewed by Ryosuke Niwa.
3287
3288         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3289         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
3290         (chromiumPlatform): Removed, unnecessary.
3291         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
3292         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
3293         the builder operates with debug builds, no webkit.org builders are named this way.
3294         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3295         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
3296
3297 2013-05-06  Andy Estes  <aestes@apple.com>
3298
3299         Added two files I neglected to commit in r149589.
3300
3301         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
3302         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
3303
3304 2013-05-04  Andy Estes  <aestes@apple.com>
3305
3306         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
3307         https://bugs.webkit.org/show_bug.cgi?id=115609
3308
3309         Reviewed by Oliver Hunt.
3310
3311         Added an API test.
3312
3313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3314         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
3315         (+[TestDelegate shared]):
3316         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3317         (-[TestDelegate webView:createWebViewWithRequest:]):
3318         (TestWebKitAPI):
3319         (TestWebKitAPI::TEST):
3320         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
3321
3322 2013-05-06  Antoine Quint  <graouts@apple.com>
3323
3324         Manage the presentation of the snapshotted plug-in using JavaScript
3325         https://bugs.webkit.org/show_bug.cgi?id=115548
3326
3327         Reviewed by Dean Jackson.
3328
3329         Take into account the new plugInExtraScript method added to support
3330         the injection of a JS file from the chrome client to customize the
3331         rendering of a snapshotted plug-in's shadow tree.
3332
3333         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3334         (WTR::InjectedBundlePage::InjectedBundlePage):
3335
3336 2013-05-05  Anders Carlsson  <andersca@apple.com>
3337
3338         Remove the Vector::append overload that takes a Vector
3339         https://bugs.webkit.org/show_bug.cgi?id=115535
3340
3341         Reviewed by Andreas Kling.
3342
3343         Use Vector::appendVector instead.
3344
3345         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3346         (concatenateAttributeAndValue):
3347         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3348         (WTR::concatenateAttributeAndValue):
3349
3350 2013-05-04  Sam Weinig  <sam@webkit.org>
3351
3352         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
3353         <rdar://problem/13702008>
3354         https://bugs.webkit.org/show_bug.cgi?id=115607
3355
3356         Reviewed by Benjamin Poulain.
3357
3358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3359         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
3360         (TestWebKitAPI::didFinishLoadForFrame):
3361         (TestWebKitAPI::TEST):
3362         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
3363
3364 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
3365
3366         Unreviewed.
3367
3368         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
3369
3370 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
3371
3372         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
3373
3374         * Scripts/webkitpy/common/config/contributors.json:
3375
3376 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
3377
3378         [GTK] Catch select.error exceptions in parse_output_lines
3379         https://bugs.webkit.org/show_bug.cgi?id=115253
3380
3381         Reviewed by Gustavo Noronha Silva.
3382
3383         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
3384         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
3385         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
3386         error code and the error message) and the loop is re-entered.
3387
3388         * gtk/common.py:
3389         (parse_output_lines):
3390
3391 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
3392
3393         [GTK] Set up the TestWebCore in TestWebKitAPI
3394         https://bugs.webkit.org/show_bug.cgi?id=115237
3395
3396         Reviewed by Gustavo Noronha Silva.
3397
3398         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
3399         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
3400         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
3401         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
3402         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
3403
3404         * TestWebKitAPI/GNUmakefile.am:
3405
3406 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
3407
3408         Create a script to import W3C tests
3409         https://bugs.webkit.org/show_bug.cgi?id=111513
3410
3411         Reviewed by Dirk Pranke.
3412
3413         Script to automate the import of W3C tests into WebKit. 
3414         For the full description of how it works, see the comments
3415         at the top of test_importer.py.
3416
3417         * Scripts/import-w3c-tests: Added.
3418         * Scripts/webkitpy/w3c/__init__.py: Added.
3419         * Scripts/webkitpy/w3c/test_converter.py: Added.
3420         (TestConverter):
3421         (TestConverter.__init__):
3422         (TestConverter.load_prefixed_prop_list):
3423         (TestConverter.load_file):
3424         (TestConverter.convert_for_webkit):
3425         (TestConverter.convert_testharness_paths):
3426         (TestConverter.convert_prefixed_properties):
3427         (TestConverter.scrub_unprefixed_props):
3428         (TestConverter.replace_tag):
3429         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
3430         (TestConverterTest):
3431         (TestConverterTest.testLoadPrefixedPropList):
3432         (TestConverterTest.test_convertForWebkitNothingToConvert):
3433         (test_convertForWebkitHarnessOnly):
3434         (test_convertForWebkitPropsOnly):
3435         (test_convertForWebkitHarnessAndProps):
3436         (test_convertTestHarnessPaths):
3437         (test_convertPrefixedProperties):
3438         (verifyTestHarnessPaths):
3439         (verifyPrefixedProperties):
3440         (generateTestContent):
3441         * Scripts/webkitpy/w3c/test_importer.py: Added.
3442         (main):
3443         (parse_args):
3444         (validate_import_directory):
3445         (TestImporter):
3446         (TestImporter.__init__):
3447         (TestImporter.do_import):
3448         (TestImporter.get_changeset):
3449         (TestImporter.scan_source_directory):
3450         (TestImporter.import_tests):
3451         (TestImporter.setup_destination_directory):
3452         (TestImporter.get_test_status):
3453         (TestImporter.remove_deleted_files):
3454         (TestImporter.write_import_log):
3455         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
3456         (TestImporterTest):
3457         (TestImporterTest.test_ImportDirWithNoTests):
3458         * Scripts/webkitpy/w3c/test_parser.py: Added.
3459         (TestParser):
3460         (TestParser.__init__):
3461         (TestParser.load_file):
3462         (TestParser.analyze_test):
3463         (TestParser.get_reftests):
3464         (TestParser.is_jstest):
3465         (TestParser.get_support_files):
3466         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
3467         (TestParserTest):
3468         (TestParserTest.test_analyzeTestReftestOneMatch):
3469         (test_analyzeTestReftestMultipleMatches):
3470         (test_analyzeTestReftestMatchAndMismatch):
3471         (test_analyzeTestReftestWithRefSupportFiles):
3472         (test_analyzeJSTest):
3473         (test_analyzePixelTestAllTrue):
3474         (test_analyzePixelTestAllFalse):
3475         (test_analyzeNonHTMLFile):
3476
3477 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3478
3479         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
3480
3481         * Scripts/webkitpy/common/config/contributors.json:
3482
3483 2013-05-02  Nico Weber  <thakis@chromium.org>
3484
3485         Remove a stale script file.
3486         https://bugs.webkit.org/show_bug.cgi?id=115521
3487
3488         Reviewed by Anders Carlsson.
3489
3490         This script was added in
3491         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
3492         Bakefile system that was removed in
3493         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
3494         script just asserts when it's run and is useless.
3495
3496         * Scripts/update-sources-list.py: Removed.
3497
3498 2013-05-01  Glenn Adams  <glenn@skynav.com>
3499
3500         [webkitpy] Need abstract base class for commands that analyze commit logs
3501         https://bugs.webkit.org/show_bug.cgi?id=115391
3502
3503         Reviewed by Benjamin Poulain.
3504
3505         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
3506         in preparation for adding two new commands that will reuse this functionality along with
3507         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
3508         https://bugs.webkit.org/show_bug.cgi?id=115388.
3509
3510         No new tests as this patch does not change existing functionality or behavior.
3511
3512         * Scripts/webkitpy/tool/commands/suggestnominations.py:
3513         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
3514         (AbstractCommitLogCommand.__init__):
3515         (AbstractCommitLogCommand._init_options):
3516         (AbstractCommitLogCommand._parse_commit_message):
3517         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
3518         (SuggestNominations.__init__): 
3519         (SuggestNominations._init_options):
3520
3521 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
3522
3523         Web Inspector: Fix check-inspector-strings script and fix localized strings
3524         https://bugs.webkit.org/show_bug.cgi?id=115495
3525
3526         Reviewed by Joseph Pecoraro.
3527
3528         * Scripts/check-inspector-strings:
3529
3530 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
3531
3532         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
3533         https://bugs.webkit.org/show_bug.cgi?id=115470
3534
3535         Reviewed by Martin Robinson.
3536
3537         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
3538         not building either of the IOS, Windows or GTK-WK1 platforms.
3539
3540         Up until now the header was included for everything but the IOS and Windows platforms due to
3541         an incorrectly stated condition regarding the GTK platform.
3542
3543         * TestWebKitAPI/config.h:
3544
3545 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
3546
3547         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
3548         https://bugs.webkit.org/show_bug.cgi?id=115469
3549
3550         Reviewed by Martin Robinson.
3551
3552         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
3553         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
3554         for the WebKit2 tests and the injected bundle required by them.
3555
3556         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
3557         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
3558         under the WebKit2 code).
3559
3560         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
3561         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
3562         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
3563
3564         * TestWebKitAPI/GNUmakefile.am:
3565
3566 2013-04-30  Glenn Adams  <glenn@skynav.com>
3567
3568         Unreviewed. Add myself to watchlist entries.
3569
3570         * Scripts/webkitpy/common/config/watchlist:
3571
3572 2013-04-30  Glenn Adams  <glenn@skynav.com>
3573
3574         [webkitpy] suggest-nominations doesn't count all qualified patches
3575         https://bugs.webkit.org/show_bug.cgi?id=115285
3576
3577         Reviewed by Benjamin Poulain.
3578
3579         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
3580         nomination. Improve commit log parsing.
3581
3582         * Scripts/webkitpy/tool/commands/suggestnominations.py:
3583         (CommitLogError):
3584         (CommitLogError.__init__):
3585         (CommitLogMissingReviewer):
3586         (CommitLogMissingReviewer.__init__):
3587         (SuggestNominations):
3588         (SuggestNominations.__init__):
3589         (SuggestNominations._recent_commit_messages):
3590         (SuggestNominations._author_name_from_email):
3591         (SuggestNominations._contributor_from_email):
3592         (SuggestNominations._parse_commit_message):
3593         (SuggestNominations._count_commit):
3594         (SuggestNominations._count_recent_patches):
3595         (SuggestNominations._collect_nominations):
3596         (SuggestNominations._print_nominations):
3597         (SuggestNominations.execute):
3598         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3599         (_make_options):
3600         (test_recent_commit_messages):
3601         (test_basic):
3602
3603 2013-04-30  Commit Queue  <rniwa@webkit.org>
3604
3605         Unreviewed, rolling out r149309.
3606         http://trac.webkit.org/changeset/149309
3607         https://bugs.webkit.org/show_bug.cgi?id=115430
3608
3609         The patch does not build on WK1-only builds of the GTK port
3610         (Requested by zdobersek on #webkit).
3611
3612         * TestWebKitAPI/GNUmakefile.am:
3613
3614 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3615
3616         Stop using "in" keyword in IDL files
3617         https://bugs.webkit.org/show_bug.cgi?id=115418
3618
3619         Reviewed by Kentaro Hara.
3620
3621         Remove "in" keyword from IDL files as this is no longer part of the Web
3622         IDL specification.
3623
3624         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3625         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
3626         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
3627         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3628         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3629         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
3630         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3631         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
3632
3633 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3634
3635         [EFL] Enable scaled cursors
3636         https://bugs.webkit.org/show_bug.cgi?id=106242
3637
3638         Reviewed by Gyuyoung Kim.
3639
3640         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
3641
3642         * Scripts/webkitperl/FeatureList.pm:
3643
3644 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3645
3646         Replace "Optional" extended attribute by proper Web IDL "optional" keyword