Migrate the remaining bots in EC2 to Google Compute Engine
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-12  Alan Cutter  <alancutter@chromium.org>
2
3         Migrate the remaining bots in EC2 to Google Compute Engine
4         https://bugs.webkit.org/show_bug.cgi?id=106005
5
6         Reviewed by Eric Seidel.
7
8         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
9
10         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
11         * EWSTools/boot.sh:
12         * EWSTools/build-repo.sh:
13         * EWSTools/start-queue.sh:
14
15 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
16
17         [chromium] move inspector related methods to TestRunner library
18         https://bugs.webkit.org/show_bug.cgi?id=106654
19
20         Reviewed by Adam Barth.
21
22         * DumpRenderTree/chromium/DRTTestRunner.cpp:
23         (DRTTestRunner::DRTTestRunner):
24         * DumpRenderTree/chromium/DRTTestRunner.h:
25         (DRTTestRunner):
26         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
27         (WebTestRunner::WebTestDelegate::showDevTools):
28         (WebTestRunner::WebTestDelegate::closeDevTools):
29         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
30         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
31         (WebTestRunner::TestRunner::TestRunner):
32         (WebTestRunner::TestRunner::showWebInspector):
33         (WebTestRunner):
34         (WebTestRunner::TestRunner::closeWebInspector):
35         (WebTestRunner::TestRunner::evaluateInWebInspector):
36         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
37         (TestRunner):
38         * DumpRenderTree/chromium/WebViewHost.cpp:
39         (WebViewHost::showDevTools):
40         (WebViewHost::closeDevTools):
41         (WebViewHost::evaluateInWebInspector):
42         * DumpRenderTree/chromium/WebViewHost.h:
43         (WebViewHost):
44
45 2013-01-11  Julie Parent  <jparent@chromium.org>
46
47         Builder should not be a valid parameter for stats dashboard
48         https://bugs.webkit.org/show_bug.cgi?id=106698
49
50         Reviewed by Dirk Pranke.
51         
52         Since builder is a dashboard specific parameter, dashboard_base
53         should not be handling it in handleValidHashParameterWrapper, rather,
54         each specific dashboard should in its handleValidHashParameter function.
55     
56         Note that the FIXME in dashboard_base about this was actually wrong -
57         we don't want to move it to g_crossDashboardState, because it isn't
58         actually cross dashboard state.
59         
60         In fact, flakiness and treemap have the code in 
61         handleValidHashParameter, but it is currently dead code because 
62         dashboard_base gets to it first.
63         
64         Added the proper handling to timeline_explorer, since builder is
65         valid there.
66
67         * TestResultServer/static-dashboards/dashboard_base.js:
68         * TestResultServer/static-dashboards/timeline_explorer.html:
69
70 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
71
72         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
73         https://bugs.webkit.org/show_bug.cgi?id=106688
74
75         Reviewed by Eric Seidel.
76
77         Update the regular expression used to strip the garbage at the beginning.
78
79         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
80         (RunWebKitTests.nrwt_log_message_regexp):
81
82 2013-01-11  Pratik Solanki  <psolanki@apple.com>
83
84         TestRunner leaks when running tests
85         https://bugs.webkit.org/show_bug.cgi?id=106683
86
87         Reviewed by Simon Fraser.
88
89         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
90         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
91         tests.
92
93         * DumpRenderTree/TestRunner.cpp:
94         (TestRunner::makeWindowObject):
95
96 2013-01-11  Julie Parent  <jparent@chromium.org>
97
98         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
99         https://bugs.webkit.org/show_bug.cgi?id=106247
100
101         Old code nulled out the loader instance when it completed loading and
102         then later used the fact that it was null to determine if it had loaded
103         or not.  This is not only unintuitive, but it also prevents using the
104         loader object later on.
105         
106         Added new method, used it, added unit test for it.
107         
108         Reviewed by Dirk Pranke.
109
110         * TestResultServer/static-dashboards/dashboard_base.js:
111         (resourceLoadingComplete):
112         (handleLocationChange):
113         * TestResultServer/static-dashboards/loader.js:
114         (.):
115         * TestResultServer/static-dashboards/loader_unittests.js:
116
117 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
118
119         Try CRLF to LF change in r139407 again.
120
121         * BuildSlaveSupport/delete-stale-build-files:
122         (main):
123         (webkitBuildDirectory):
124         * BuildSlaveSupport/kill-old-processes:
125         (main):
126
127 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
128
129         [GTK] Disable the unit tests timeout when running from make check
130         https://bugs.webkit.org/show_bug.cgi?id=106670
131
132         Reviewed by Philippe Normand.
133
134         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
135
136 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
137
138         Yet another unreviewed fix after r139431.
139
140         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
141         the correct order.
142
143 2013-01-11  Dan Carney  <dcarney@google.com>
144
145         [chromium] move some whitespace and resize related methods to TestRunner library
146         https://bugs.webkit.org/show_bug.cgi?id=106655
147
148         Reviewed by Jochen Eisinger.
149
150         * DumpRenderTree/chromium/DRTTestRunner.cpp:
151         (DRTTestRunner::DRTTestRunner):
152         * DumpRenderTree/chromium/DRTTestRunner.h:
153         (DRTTestRunner):
154         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
155         (WebKit):
156         (WebTestRunner::WebTestDelegate::setClientWindowRect):
157         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
158         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
159         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
160         (WebTestRunner::TestRunner::TestRunner):
161         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
162         (WebTestRunner):
163         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
164         (WebTestRunner::TestRunner::enableAutoResizeMode):
165         (WebTestRunner::TestRunner::disableAutoResizeMode):
166         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
167         (TestRunner):
168         * DumpRenderTree/chromium/WebViewHost.cpp:
169         (WebViewHost::setClientWindowRect):
170         * DumpRenderTree/chromium/WebViewHost.h:
171         (WebViewHost):
172
173 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
174
175         Unreviewed. Update my e-mail addresses.
176
177         * Scripts/webkitpy/common/config/committers.py:
178
179 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
180
181         Another unreviewed fix after r139431.
182
183         In a way, this is also a generic bug fix, since previously isEfl()
184         would fail when called from run-efl-tests and we thus did not use
185         jhbuild to run our tests. This now resulted in us calling
186         "jhbuild-wrapper run" without specifying a platform.
187
188         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
189         to work.
190
191 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
192
193         [Qt][WK1] Web Audio support
194         https://bugs.webkit.org/show_bug.cgi?id=106651
195
196         Reviewed by Jocelyn Turcotte.
197
198         Implements support for dumping audio data in DumpRenderTree.
199
200         Adds WebAudio to toggleable features in QtTestBrowser.
201
202         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
203         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
204
205         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
206         (WebCore::DumpRenderTree::dump):
207         * DumpRenderTree/qt/TestRunnerQt.cpp:
208         (TestRunner::reset):
209         (TestRunner::overridePreference):
210         (TestRunner::setAudioData):
211         * DumpRenderTree/qt/TestRunnerQt.h:
212         (TestRunner::shouldDumpAsAudio):
213         (TestRunner::audioData):
214         (TestRunner):
215         * QtTestBrowser/launcherwindow.cpp:
216         (LauncherWindow::applyPrefs):
217         (LauncherWindow::createChrome):
218         (LauncherWindow::toggleWebAudio):
219         * QtTestBrowser/launcherwindow.h:
220         (WindowOptions::WindowOptions):
221         (WindowOptions):
222         (LauncherWindow):
223         * qmake/mkspecs/features/features.prf:
224         * qmake/mkspecs/features/features.pri:
225
226 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
227
228         Unreviewed jhbuild-related fix after r139431.
229
230         * Scripts/webkitpy/layout_tests/port/efl.py:
231         (EflPort.__init__): Pass a string to set_option_default(), since
232         shlex.split() will be called on it later.
233
234 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
235
236         Unreviewed typo fixes after r139431.
237
238         * Scripts/run-javascriptcore-tests:
239
240 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
241
242         [jhbuild] Remove the "run-with-jhbuild" scripts.
243         https://bugs.webkit.org/show_bug.cgi?id=106572
244
245         Reviewed by Martin Robinson.
246
247         Both ports which use jhbuild were mostly duplicating the
248         `run-with-jhbuild' script in their own directories for no clear reason.
249
250         The script itself was just a thin wrapper around the `jhbuild-wrapper',
251         so just start using that directly and get rid of a useless middle man.
252
253         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
254         instead.
255
256         * Scripts/run-javascriptcore-tests:
257         * Scripts/run-launcher:
258         * Scripts/webkitdirs.pm:
259         (runAutogenForAutotoolsProjectIfNecessary):
260         (buildAutotoolsProject):
261         (jhbuildWrapperPrefixIfNeeded):
262         (generateBuildSystemFromCMakeProject):
263         (buildCMakeGeneratedProject):
264         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
265         (run):
266         * Scripts/webkitpy/layout_tests/port/efl.py:
267         (EflPort.__init__):
268         (EflPort._image_diff_command):
269         * efl/run-with-jhbuild: Removed.
270         * gtk/run-with-jhbuild: Removed.
271
272 2013-01-11  Alan Cutter  <alancutter@chromium.org>
273
274         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
275         https://bugs.webkit.org/show_bug.cgi?id=106636
276
277         Reviewed by Adam Barth.
278
279         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
280
281         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
282         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
283         * EWSTools/screen-config:
284         * EWSTools/start-queue.sh:
285
286 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
287
288         kill-old-processes and delete-stale-build-files use CRLF linebreaks
289         https://bugs.webkit.org/show_bug.cgi?id=106622
290
291         Reviewed by Simon Fraser.
292
293         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
294         Also escape clang\+\+ correctly in kill-old-processes.
295
296         * BuildSlaveSupport/delete-stale-build-files:
297         * BuildSlaveSupport/kill-old-processes:
298
299 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
300
301         Build fix after r139357. It was missing a comma.
302
303         * QueueStatusServer/model/queues.py:
304         (Queue):
305
306 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
307
308         Fixing AuthenticationError when running test-webkitpy as a non-committer.
309         https://bugs.webkit.org/show_bug.cgi?id=106420
310
311         Reviewed by Eric Seidel.
312
313         * Scripts/webkitpy/common/checkout/scm/git.py:
314         (Git.push_local_commits_to_server):
315         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
316         * Scripts/webkitpy/common/checkout/scm/svn.py:
317         (SVNRepository):
318         (SVNRepository.has_authorization_for_realm):
319
320 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
321
322         [EFL][jhbuild] Use tarballs for gstreamer instead of git
323         https://bugs.webkit.org/show_bug.cgi?id=106552
324
325         Reviewed by Laszlo Gombos.
326
327         Use tarballs for gstreamer instead of git in EFL's jhbuild
328         to work around intermittent network issues on our build
329         bots. Tarballs are fully cached and require no network
330         operation if their checksum matches.
331
332         * efl/jhbuild.modules:
333
334 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
335
336         Add Mac WK2 EWS bots
337         https://bugs.webkit.org/show_bug.cgi?id=106590
338
339         Reviewed by Adam Barth.
340
341         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
342         Also add a deprecated MacWK2Port class.
343
344         * QueueStatusServer/model/queues.py:
345         (Queue):
346         * Scripts/webkitpy/common/config/ports.py:
347         (DeprecatedPort.port):
348         (MacWK2Port):
349         (MacWK2Port.run_webkit_tests_command):
350         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
351         (MacEWS):
352         (MacWK2EWS):
353         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
354         (_test_ewses):
355
356 2013-01-10  Dan Carney  <dcarney@google.com>
357
358         [chromium] move webpermissionclient related methods to TestRunner library
359         https://bugs.webkit.org/show_bug.cgi?id=106548
360
361         Reviewed by Jochen Eisinger.
362
363         * DumpRenderTree/DumpRenderTree.gypi:
364         * DumpRenderTree/chromium/DRTTestRunner.cpp:
365         (DRTTestRunner::DRTTestRunner):
366         (DRTTestRunner::reset):
367         * DumpRenderTree/chromium/DRTTestRunner.h:
368         (DRTTestRunner):
369         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
370         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
371         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
372         (WebKit):
373         (WebTestRunner::WebTestRunner::webPermissions):
374         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
375         (WebTestRunner::TestRunner::TestRunner):
376         (WebTestRunner::TestRunner::setDelegate):
377         (WebTestRunner):
378         (WebTestRunner::TestRunner::reset):
379         (WebTestRunner::TestRunner::webPermissions):
380         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
381         (WebTestRunner::TestRunner::setImagesAllowed):
382         (WebTestRunner::TestRunner::setScriptsAllowed):
383         (WebTestRunner::TestRunner::setStorageAllowed):
384         (WebTestRunner::TestRunner::setPluginsAllowed):
385         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
386         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
387         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
388         (WebTestRunner):
389         (TestRunner):
390         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
391         (WebTestRunner):
392         (WebTestRunner::WebPermissions::WebPermissions):
393         (WebTestRunner::WebPermissions::~WebPermissions):
394         (WebTestRunner::WebPermissions::allowImage):
395         (WebTestRunner::WebPermissions::allowScriptFromSource):
396         (WebTestRunner::WebPermissions::allowStorage):
397         (WebTestRunner::WebPermissions::allowPlugins):
398         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
399         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
400         (WebTestRunner::WebPermissions::setImagesAllowed):
401         (WebTestRunner::WebPermissions::setScriptsAllowed):
402         (WebTestRunner::WebPermissions::setStorageAllowed):
403         (WebTestRunner::WebPermissions::setPluginsAllowed):
404         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
405         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
406         (WebTestRunner::WebPermissions::setDelegate):
407         (WebTestRunner::WebPermissions::setDumpCallbacks):
408         (WebTestRunner::WebPermissions::reset):
409         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
410         (WebTestRunner):
411         (WebPermissions):
412         * DumpRenderTree/chromium/TestShell.cpp:
413         (TestShell::initialize):
414         (TestShell::resetTestController):
415         (TestShell::createNewWindow):
416         * DumpRenderTree/chromium/TestShell.h:
417         (TestShell):
418         * DumpRenderTree/chromium/WebViewHost.cpp:
419         (WebViewHost::normalizeLayoutTestURL):
420         * DumpRenderTree/chromium/WebViewHost.h:
421         (WebViewHost):
422
423 2013-01-10  Alan Cutter  <alancutter@chromium.org>
424
425         Split EWS tool cold-boot.sh into modular components
426         https://bugs.webkit.org/show_bug.cgi?id=106527
427
428         Reviewed by Adam Barth.
429
430         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
431         Updated GCE bot build scripts to match.
432         Unable to test scripts directly as they depend on being in the repository to work!
433
434         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
435         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
436         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
437         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
438         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
439
440 2013-01-10  Julie Parent  <jparent@chromium.org>
441
442         Dashboard Cleanup: Do not generate the page if we are about to reload.
443         https://bugs.webkit.org/show_bug.cgi?id=106584
444
445         Reviewed by Dirk Pranke.
446
447         Move the logic to determine if we should generate the page into
448         parseParameters() since that is where we have the knowledge to
449         determine it, and return that value to handleLocationChange, 
450         rather than passing the changed parameters back to handleLocationChange
451         and having it make the decision.
452         
453         This is logically equivalent, save one case: when we are about to do
454         a reload, we know that there is no reason to generate the page.  Old
455         code was causing an extra page generation in this case.
456         
457         * TestResultServer/static-dashboards/dashboard_base.js:
458         (parseParameters):
459         (handleLocationChange):
460
461 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
462
463         [jhbuild] Use the "configure" script to build glib
464         https://bugs.webkit.org/show_bug.cgi?id=106569
465
466         Reviewed by Martin Robinson.
467
468         So far both EFL and GTK have been using autogen.sh to build glib.
469         While that does work most of the time, it's not really needed since
470         we are downloading and building stable releases from tarballs.
471         Additionally, autogen.sh fails to work with automake 1.13 due to the
472         usage of some macros that have been removed (this has already been
473         fixed in glib master).
474
475         * efl/jhbuild.modules:
476         * gtk/jhbuild.modules:
477
478 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
479
480         Changing tests to be consistent and use self.scm rather then recreating the scm object.
481         (Missed a couple)
482         https://bugs.webkit.org/show_bug.cgi?id=106536
483
484         Reviewed by Eric Seidel.
485
486         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
487
488 2013-01-10  Tony Chang  <tony@chromium.org>
489
490         Speed up supplemental dependency computation
491         https://bugs.webkit.org/show_bug.cgi?id=106503
492
493         Reviewed by Adam Barth.
494
495         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
496
497         * WebKitTestRunner/CMakeLists.txt:
498
499 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
500
501         Remove the ENABLE_ANIMATION_API feature define occurences
502         https://bugs.webkit.org/show_bug.cgi?id=106544
503
504         Reviewed by Simon Fraser.
505
506         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
507         feature define handling still lingers in various build systems and configurations
508         but is of no use, so it should be removed.
509
510         * Scripts/webkitperl/FeatureList.pm:
511         * qmake/mkspecs/features/features.pri:
512
513 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
514
515         [GTK] Add support for loading web process extensions
516         https://bugs.webkit.org/show_bug.cgi?id=105631
517
518         Reviewed by Gustavo Noronha Silva.
519
520         * MiniBrowser/gtk/GNUmakefile.am:
521         * MiniBrowser/gtk/main.c:
522         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
523         bundle lib from build dir.
524         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
525         located in WebProcess/InjectedBundle/API/gtk.
526         * gtk/generate-gtkdoc:
527         (get_webkit2_options): Scan also files in
528         WebProcess/InjectedBundle/API/gtk to generate API docs.
529         (get_webkit2_options.injected_bundle_src_path): Helper function to
530         build paths in WebProcess/InjectedBundle/API/gtk.
531
532 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
533
534         [EFL][WK2] Writing immediately to created windows (open) fails
535         https://bugs.webkit.org/show_bug.cgi?id=105276
536
537         Reviewed by Kenneth Rohde Christiansen.
538
539         Do not reset 'about:blank' url for the new pages in mini browser.
540
541         * MiniBrowser/efl/main.c:
542         (window_create):
543
544 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
545
546         Changing tests to be consistent and use self.scm rather then recreating the scm object.
547         https://bugs.webkit.org/show_bug.cgi?id=106536
548
549         Reviewed by Eric Seidel.
550
551         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
552
553 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
554
555         Converting to unittest2 so we can use assertItemsEqual, making tests
556         not dependent on order of items.
557         https://bugs.webkit.org/show_bug.cgi?id=106532
558
559         Before:
560         Ran 1733 tests in 38.385s
561         FAILED (failures=1, errors=22)
562
563         After:
564         Ran 1733 tests in 32.298s
565         FAILED (failures=0, errors=22)
566
567         Reviewed by Eric Seidel.
568
569         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
570         * Scripts/webkitpy/thirdparty/__init__.py:
571         (AutoinstallImportHook._install_unittest2):
572
573 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
574
575         [EFL] Add gstreamer 1.0.5 to jhbuild
576         https://bugs.webkit.org/show_bug.cgi?id=106178
577
578         Reviewed by Laszlo Gombos.
579
580         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
581
582         * efl/jhbuild.modules:
583
584 2013-01-09  Alan Cutter  <alancutter@chromium.org>
585
586         Updated parameters in GCE build scripts so they now work.
587         https://bugs.webkit.org/show_bug.cgi?id=106523
588
589         Reviewed by Adam Barth.
590
591         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
592         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
593         * EWSTools/cold-boot.sh:
594
595 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
596
597         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
598         https://bugs.webkit.org/show_bug.cgi?id=106520
599
600         Reviewed by James Robinson.
601
602         Part of a larger refactoring series. See tracking bug 82948.
603
604         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
605         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
606
607 2013-01-09  Julie Parent  <jparent@chromium.org>
608
609         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
610         https://bugs.webkit.org/show_bug.cgi?id=106514
611
612         This is old code, as these can no longer get out of sync.
613         permmaLinkURLHash is generated from currentState, which is set only
614         from the location.  The commment about how these can get out of sync
615         refers to a function that no longer exists.
616         
617         Reviewed by Dirk Pranke.
618
619         * TestResultServer/static-dashboards/dashboard_base.js:
620         (handleLocationChange):
621
622 2013-01-09  Julie Parent  <jparent@chromium.org>
623
624         Dashboard Cleanup: Reload the page as soon as we know we need to.
625         https://bugs.webkit.org/show_bug.cgi?id=106515
626
627         No need to continue parsing all of the data once we know that
628         we need to do a reload.
629         
630         Reviewed by Dirk Pranke.
631
632         * TestResultServer/static-dashboards/dashboard_base.js:
633         (parseParameters):
634
635 2013-01-09  Eric Seidel  <eric@webkit.org>
636
637         run-perf-tests --chromium-android --profile should show symbols for the kernel
638         https://bugs.webkit.org/show_bug.cgi?id=106498
639
640         Reviewed by Adam Barth.
641
642         Turns out this was easy, once I finally read the output from "perf report".
643         It appears there may be a bug in "perf record" on android, as it complains
644         about not being able to read from /proc/kallsyms even when
645         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
646         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
647         but rather just flip it to 0 long enough to grab the /proc/kallsyms
648         and then flip it back to whatever the device had.
649
650         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
651         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
652         to symbol names.  Its world-readable, but will return all 0s if you
653         don't have permission to see the kernel symbols.  kptr_restrict
654         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
655         1 is only a specific group, and 2 is "no one, not even root".
656         By default kptr_restrict is 2 on Android it seems.
657         More kptr_restrict docs: http://lwn.net/Articles/420403/
658
659         I also took this opportunity to clean up how the perf record command
660         was built for use/display in AndroidPerf.profile_after_exit and
661         change to always using long-form names for the arguments (to hopefully help readability).
662
663         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
664         (AndroidPerf.__init__):
665         (profile_after_exit):
666         (ChromiumAndroidDriver.__init__):
667         (ChromiumAndroidDriver._update_kallsyms_cache):
668         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
669
670 2013-01-09  Julie Parent  <jparent@chromium.org>
671
672         Dashboard cleanup: remove dead code.
673         https://bugs.webkit.org/show_bug.cgi?id=106509
674
675         Reviewed by Dirk Pranke.
676
677         * TestResultServer/static-dashboards/dashboard_base.js:
678         (parseParameters):
679
680 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
681
682         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
683         https://bugs.webkit.org/show_bug.cgi?id=105638
684
685         Reviewed by Martin Robinson.
686
687         The test was failing for two reasons:
688         - AccessibilityRenderObject::correspondingLabelForControlElement() was
689           not ignoring the ARIA labelled-by property
690         - AccessibilityController::accessibleElementById() was not implemented
691
692         Because getting an element by ID cannot be done in the UIProcess, the
693         decision was made to expose the element's ID as an accessible attribute
694         of the object.
695
696         In addition, fixing the bug in AccessibilityRenderObject made it possible
697         to eliminate the Gtk platform-specific expectations for another test.
698
699         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
700         (childElementById): Added. Walks the tree looking for the AtkObject
701         Attribute which exposes the HTML element's ID.
702         (AccessibilityController::accessibleElementById): Implemented.
703         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
704         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
705         when there is no title, as is done with the Mac port.
706         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
707         (WTR):
708         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
709         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
710         Attribute which exposes the HTML element's ID.
711         (WTR):
712         (WTR::AccessibilityController::accessibleElementById): Implemented.
713         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
714         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
715         even when there is no title, as is done with the Mac port.
716
717 2013-01-09  Gregg Tavares  <gman@google.com>
718
719         Add Gregg Tavares as a committer
720         https://bugs.webkit.org/show_bug.cgi?id=106492
721
722         Unreviewed.
723
724         * Scripts/webkitpy/common/config/committers.py:
725
726 2013-01-09  Roger Fong  <roger_fong@apple.com>
727
728         Enable seamless iFrames for Windows DRT.
729         https://bugs.webkit.org/show_bug.cgi?id=106468.
730
731         Rubberstamped by Timothy Horton.
732
733         * DumpRenderTree/win/DumpRenderTree.cpp:
734         (resetDefaultsToConsistentValues):
735
736 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
737
738         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
739         https://bugs.webkit.org/show_bug.cgi?id=93979
740
741         Reviewed by Benjamin Poulain.
742
743         Implement eventSender.scheduleAsynchronousKeyDown() in
744         WebKitTestRunner.
745
746         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
747         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
748         (WTR::createKeyDownMessageBody):
749         (WTR::EventSendingController::keyDown):
750         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
751         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
752         (EventSendingController):
753         * WebKitTestRunner/TestController.cpp:
754         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
755         (WTR::TestController::didReceiveMessageFromInjectedBundle):
756         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
757         * WebKitTestRunner/TestController.h:
758         (TestController):
759
760 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
761
762         [chromium] move resource load callback dumping to TestRunner library
763         https://bugs.webkit.org/show_bug.cgi?id=106449
764
765         Reviewed by Adam Barth.
766
767         * DumpRenderTree/chromium/DRTTestRunner.cpp:
768         (DRTTestRunner::DRTTestRunner):
769         (DRTTestRunner::reset):
770         * DumpRenderTree/chromium/DRTTestRunner.h:
771         (DRTTestRunner):
772         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
773         (WebKit):
774         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
775         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
776         (WebKit):
777         (WebTestProxyBase):
778         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
779         (WebTestRunner::WebTestProxy::willRequestResource):
780         (WebTestRunner::WebTestProxy::willSendRequest):
781         (WebTestRunner::WebTestProxy::didReceiveResponse):
782         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
783         (WebTestRunner::WebTestProxy::didFailResourceLoad):
784         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
785         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
786         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
787         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
788         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
789         (WebTestRunner::TestRunner::TestRunner):
790         (WebTestRunner::TestRunner::reset):
791         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
792         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
793         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
794         (WebTestRunner):
795         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
796         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
797         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
798         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
799         (TestRunner):
800         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
801         (WebTestRunner::WebTestProxyBase::reset):
802         (WebTestRunner):
803         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
804         (WebTestRunner::WebTestProxyBase::willRequestResource):
805         (WebTestRunner::WebTestProxyBase::willSendRequest):
806         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
807         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
808         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
809         * DumpRenderTree/chromium/WebViewHost.cpp:
810         (WebViewHost::willSendRequest):
811         (WebViewHost::makeURLErrorDescription):
812         (WebViewHost::reset):
813         * DumpRenderTree/chromium/WebViewHost.h:
814         (WebViewHost):
815
816 2013-01-09  Dan Carney  <dcarney@google.com>
817
818         [chromium] move dumpcreateview methods to testrunner library
819         https://bugs.webkit.org/show_bug.cgi?id=106434
820
821         Reviewed by Adam Barth.
822
823         * DumpRenderTree/chromium/DRTTestRunner.cpp:
824         (DRTTestRunner::DRTTestRunner):
825         (DRTTestRunner::reset):
826         * DumpRenderTree/chromium/DRTTestRunner.h:
827         (DRTTestRunner):
828         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
829         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
830         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
831         (WebTestRunner::TestRunner::TestRunner):
832         (WebTestRunner::TestRunner::reset):
833         (WebTestRunner::TestRunner::shouldDumpCreateView):
834         (WebTestRunner):
835         (WebTestRunner::TestRunner::dumpCreateView):
836         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
837         (TestRunner):
838
839 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
840
841         webkitpy cleanup: Merge additional_comment_text into comment_text
842         https://bugs.webkit.org/show_bug.cgi?id=106421
843
844         Reviewed by Adam Barth.
845
846         * Scripts/webkitpy/common/config/committervalidator.py:
847         (CommitterValidator.reject_patch_from_commit_queue):
848         (CommitterValidator.reject_patch_from_review_queue):
849         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
850         (Bugzilla.set_flag_on_attachment):
851         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
852         (MockBugzilla.set_flag_on_attachment):
853         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
854         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
855         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
856         * Scripts/webkitpy/tool/commands/queues_unittest.py:
857
858 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
859
860         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
861         https://bugs.webkit.org/show_bug.cgi?id=106464
862
863         Reviewed by Martin Robinson.
864
865         Current version in jhbuild.modules (2.26.0) is giving trouble to
866         when trying to build WebKitGTK from scratch, due to a segmentation
867         fault error in gdk-pixbuf-query-loader during the 'make'
868         phase. Raising the version to 2.26.5 fixes this issue.
869
870         * gtk/jhbuild.modules: Version raised, checksums updated.
871
872 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
873
874         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
875         https://bugs.webkit.org/show_bug.cgi?id=90968.
876
877         Reviewed by Csaba Osztrogonác.
878
879         Added functionality in DRT and WTR to use any timeout value while running
880         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
881         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
882         to indicate whether the current port supports setting timeout value
883         per test (it's False by default; I enabled it only on Qt).
884         Also corrected a typo in driver.py
885
886         * DumpRenderTree/DumpRenderTree.h:
887         (TestCommand::TestCommand):
888         (TestCommand):
889         * DumpRenderTree/DumpRenderTreeCommon.cpp:
890         (parseInputLine):
891         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
892         (WebCore::DumpRenderTree::processLine):
893         * Scripts/webkitpy/layout_tests/port/base.py:
894         (Port.supports_per_test_timeout):
895         * Scripts/webkitpy/layout_tests/port/driver.py:
896         (Driver.run_test):
897         (Driver._command_from_driver_input):
898         * Scripts/webkitpy/layout_tests/port/qt.py:
899         (QtPort.supports_per_test_timeout):
900         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
901         (WTR::InjectedBundle::InjectedBundle):
902         (WTR::InjectedBundle::didReceiveMessage):
903         (WTR::InjectedBundle::beginTesting):
904         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
905         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
906         (WTR::TestRunner::setCustomTimeout):
907         (WTR):
908         * WebKitTestRunner/InjectedBundle/TestRunner.h:
909         (TestRunner):
910         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
911         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
912         * WebKitTestRunner/TestController.cpp:
913         (WTR::TestController::TestController):
914         (WTR::TestController::getCustomTimeout):
915         (WTR):
916         (WTR::TestCommand::TestCommand):
917         (TestCommand):
918         (WTR::parseInputLine):
919         (WTR::TestController::runTest):
920         (WTR::TestController::runUntil):
921         * WebKitTestRunner/TestController.h:
922         (TestController):
923         * WebKitTestRunner/TestInvocation.cpp:
924         (WTR::TestInvocation::TestInvocation):
925         (WTR::TestInvocation::setCustomTimeout):
926         (WTR):
927         (WTR::TestInvocation::invoke):
928         * WebKitTestRunner/TestInvocation.h:
929         (TestInvocation):
930
931 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
932
933         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
934         https://bugs.webkit.org/show_bug.cgi?id=106290
935
936         Reviewed by Martin Robinson.
937
938         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
939         the macro isn't enabled.
940
941         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
942
943 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
944
945         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
946         https://bugs.webkit.org/show_bug.cgi?id=103653
947
948         Reviewed by Anders Carlsson.
949
950         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
951         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
952         client callback.
953
954         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
955         methods to the JavaScript API.
956         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
957         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
958         (WTR::TestRunner::setAuthenticationUsername): Ditto.
959         (WTR::TestRunner::setAuthenticationPassword): Ditto.
960         * WebKitTestRunner/InjectedBundle/TestRunner.h:
961         (TestRunner): Added new declarations for the above.
962         * WebKitTestRunner/TestController.cpp:
963         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
964         callback.
965         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
966         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
967         the authentication information passed from the InjectedBundle.
968         * WebKitTestRunner/TestController.h:
969         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
970         to communicate with the TestController.
971         (WTR::TestController::setAuthenticationUsername): Ditto.
972         (WTR::TestController::setAuthenticationPassword): Ditto.
973         (TestController):
974         * WebKitTestRunner/TestInvocation.cpp:
975         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
976         information from the InjectedBundle.
977         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
978         text to the TestInvocation text output.
979         * WebKitTestRunner/TestInvocation.h:
980         (TestInvocation): Added declaration for new method.
981
982 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
983
984         Add myself as a watcher for Web Geolocation
985
986         Unreviewed.
987
988         * Scripts/webkitpy/common/config/watchlist:
989
990 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
991
992         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
993         https://bugs.webkit.org/show_bug.cgi?id=106364
994
995         Reviewed by Eric Seidel.
996
997         When the setup_test_run method is called on the subclasses of the base Port
998         interface, the parent method should also be called via super(), despite the
999         parent method not doing anything at the moment.
1000
1001         The according calls to super() are required in the ChromiumPort, EflPort
1002         and GtkPort implementations.
1003
1004         * Scripts/webkitpy/layout_tests/port/chromium.py:
1005         (ChromiumPort.setup_test_run):
1006         * Scripts/webkitpy/layout_tests/port/efl.py:
1007         (EflPort.setup_test_run):
1008         * Scripts/webkitpy/layout_tests/port/gtk.py:
1009         (GtkPort.setup_test_run):
1010
1011 2013-01-08  Julie Parent  <jparent@chromium.org>
1012
1013         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
1014         https://bugs.webkit.org/show_bug.cgi?id=106356
1015
1016         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
1017         dashboard_base, assigned by Loader, and used only by dashboard_base to
1018         create error messages.  Moved the variables to be privates on the Loader
1019         object, moved error message creation to _getLoadingErrorMessages on the
1020         Loader object, and now pass the errors back to dashboard base via the
1021         resourceLoadingComplete callback.
1022         
1023         Also removed the now unused clearError function, it was only being used
1024         by unit tests to clean up global state.
1025         
1026         Reviewed by Dirk Pranke.
1027
1028         * TestResultServer/static-dashboards/dashboard_base.js:
1029         (resourceLoadingComplete):
1030         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1031         * TestResultServer/static-dashboards/loader.js:
1032         (.):
1033         * TestResultServer/static-dashboards/loader_unittests.js:
1034
1035 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1036
1037         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
1038         https://bugs.webkit.org/show_bug.cgi?id=106354
1039
1040         Reviewed by Eric Seidel.
1041
1042         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
1043         instead of those two inheriting from it. Also add a mock object of the
1044         sanitizer that's used in unit tests.
1045
1046         * Scripts/webkitpy/layout_tests/port/efl.py:
1047         (EflPort):
1048         (EflPort.__init__):
1049         (EflPort.setup_test_run):
1050         (EflPort.clean_up_test_run):
1051         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
1052         importing order.
1053         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
1054         * Scripts/webkitpy/layout_tests/port/gtk.py:
1055         (GtkPort):
1056         (GtkPort.__init__):
1057         (GtkPort.setup_test_run):
1058         (GtkPort.clean_up_test_run):
1059         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
1060         importing order.
1061         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
1062         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
1063         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
1064         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
1065         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
1066         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
1067         (PulseAudioSanitizerMock.unload_pulseaudio_module):
1068         (PulseAudioSanitizerMock.restore_pulseaudio_module):
1069
1070 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
1071
1072         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
1073         https://bugs.webkit.org/show_bug.cgi?id=106324
1074
1075         Reviewed by Adam Barth.
1076
1077         Since the frame load callbacks are part of the WebFrameClient, the
1078         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
1079         methods.
1080
1081         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1082         (DRTTestRunner::DRTTestRunner):
1083         (DRTTestRunner::reset):
1084         * DumpRenderTree/chromium/DRTTestRunner.h:
1085         (DRTTestRunner):
1086         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1087         (WebTestInterfaces):
1088         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1089         (WebKit):
1090         (WebTestProxyBase):
1091         (WebTestRunner):
1092         (WebTestRunner::WebTestProxy::WebTestProxy):
1093         (WebTestProxy):
1094         (WebTestRunner::WebTestProxy::didInvalidateRect):
1095         (WebTestRunner::WebTestProxy::didScrollRect):
1096         (WebTestRunner::WebTestProxy::scheduleComposite):
1097         (WebTestRunner::WebTestProxy::scheduleAnimation):
1098         (WebTestRunner::WebTestProxy::setWindowRect):
1099         (WebTestRunner::WebTestProxy::show):
1100         (WebTestRunner::WebTestProxy::didAutoResize):
1101         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
1102         (WebTestRunner::WebTestProxy::startDragging):
1103         (WebTestRunner::WebTestProxy::shouldBeginEditing):
1104         (WebTestRunner::WebTestProxy::shouldEndEditing):
1105         (WebTestRunner::WebTestProxy::shouldInsertNode):
1106         (WebTestRunner::WebTestProxy::shouldInsertText):
1107         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
1108         (WebTestRunner::WebTestProxy::shouldDeleteRange):
1109         (WebTestRunner::WebTestProxy::shouldApplyStyle):
1110         (WebTestRunner::WebTestProxy::didBeginEditing):
1111         (WebTestRunner::WebTestProxy::didChangeSelection):
1112         (WebTestRunner::WebTestProxy::didChangeContents):
1113         (WebTestRunner::WebTestProxy::didEndEditing):
1114         (WebTestRunner::WebTestProxy::registerIntentService):
1115         (WebTestRunner::WebTestProxy::dispatchIntent):
1116         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
1117         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
1118         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
1119         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
1120         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
1121         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
1122         (WebTestRunner::WebTestProxy::didReceiveTitle):
1123         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
1124         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
1125         (WebTestRunner::WebTestProxy::didFailLoad):
1126         (WebTestRunner::WebTestProxy::didFinishLoad):
1127         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
1128         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
1129         (WebTestRunner::WebTestProxy::didRunInsecureContent):
1130         (WebTestRunner::WebTestProxy::didDetectXSS):
1131         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1132         (WebTestRunner::WebTestRunner::setTestIsRunning):
1133         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
1134         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
1135         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
1136         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
1137         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
1138         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1139         (WebTestRunner::TestRunner::TestRunner):
1140         (WebTestRunner::TestRunner::reset):
1141         (WebTestRunner::TestRunner::setTestIsRunning):
1142         (WebTestRunner):
1143         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
1144         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
1145         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
1146         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
1147         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
1148         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
1149         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
1150         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
1151         (WebTestRunner::TestRunner::dumpTitleChanges):
1152         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1153         (TestRunner):
1154         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1155         (WebTestInterfaces::Internal):
1156         (WebTestRunner::WebTestInterfaces::Internal::webView):
1157         (WebTestRunner::WebTestInterfaces::Internal::Internal):
1158         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
1159         (WebTestRunner):
1160         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
1161         (WebTestRunner::WebTestInterfaces::setWebView):
1162         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
1163         (WebTestRunner::WebTestInterfaces::webView):
1164         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1165         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
1166         (WebTestRunner):
1167         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
1168         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
1169         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
1170         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
1171         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
1172         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1173         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
1174         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
1175         (WebTestRunner::WebTestProxyBase::didFailLoad):
1176         (WebTestRunner::WebTestProxyBase::didFinishLoad):
1177         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
1178         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
1179         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
1180         (WebTestRunner::WebTestProxyBase::didDetectXSS):
1181         * DumpRenderTree/chromium/TestShell.cpp:
1182         (TestShell::runFileTest):
1183         (TestShell::testFinished):
1184         * DumpRenderTree/chromium/TestShell.h:
1185         (TestShell):
1186         * DumpRenderTree/chromium/WebViewHost.cpp:
1187         (WebViewHost::didStartProvisionalLoad):
1188         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
1189         (WebViewHost::didFailProvisionalLoad):
1190         (WebViewHost::didCommitProvisionalLoad):
1191         (WebViewHost::didReceiveTitle):
1192         (WebViewHost::didFailLoad):
1193         (WebViewHost::didFinishLoad):
1194         * DumpRenderTree/chromium/WebViewHost.h:
1195         (WebViewHost):
1196
1197 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1198
1199         [GTK] Lower the default timeout value for WebKitTestRunner
1200         https://bugs.webkit.org/show_bug.cgi?id=106353
1201
1202         Reviewed by Dirk Pranke.
1203
1204         The default timeout value for WebKitTestRunner should be lowered.
1205         The current value (80 seconds) is irrational and just leads to producing
1206         text failures for layout tests that genuinely time out. This just leads
1207         to more deviation from the GTK WK1 port in terms of test expectations.
1208
1209         The value used is the same as when running the DumpRenderTree, that's
1210         6 seconds in release builds and 12 seconds in debug builds.
1211
1212         * Scripts/webkitpy/layout_tests/port/gtk.py:
1213         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1214         (GtkPortTest.test_default_timeout_ms):
1215
1216 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1217
1218         test-webkitpy shows failure output on my linux box
1219         https://bugs.webkit.org/show_bug.cgi?id=101261
1220
1221         Reviewed by Eric Seidel.
1222
1223         Mock out the PulseAudioSanitizer methods when creating testing instances
1224         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
1225         PulseAudio output when the sanitizer was trying to unload modules which
1226         were already unloaded by another unit test that was being run in parallel.
1227
1228         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1229         (EflPortTest):
1230         (EflPortTest.make_port):
1231         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1232         (GtkPortTest):
1233         (GtkPortTest.make_port):
1234
1235 2013-01-08  Julie Parent  <jparent@chromium.org>
1236
1237         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
1238         https://bugs.webkit.org/show_bug.cgi?id=106254
1239
1240         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
1241         only to figure out if we should call addBuilderLoadErrors during
1242         handleLocationChange, which was called when the loader completed and on
1243         any hash change, but we only ever wanted to call addBuilderLoadErrors
1244         on the initial loader load.  Moved the call of addBuilderLoadErrors to
1245         resourceLoadingComplete rather than handleLocationChange, so now we
1246         only call it when we want to, and the check can go away completely.
1247
1248         Reviewed by Dirk Pranke.
1249
1250         * TestResultServer/static-dashboards/dashboard_base.js:
1251         (addBuilderLoadErrors):
1252         (resourceLoadingComplete):
1253         (handleLocationChange):
1254         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1255
1256 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
1257
1258         Add aboxhall@chromium.org to accessibility watchlist.
1259
1260         Unreviewed.
1261
1262         * Scripts/webkitpy/common/config/watchlist:
1263
1264 2013-01-08  Dan Winship  <danw@gnome.org>
1265
1266         Add Apache 2.4 support for Fedora 18
1267         https://bugs.webkit.org/show_bug.cgi?id=104478
1268
1269         Reviewed by Martin Robinson.
1270
1271         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
1272         need a separate config.
1273
1274         * Scripts/webkitpy/layout_tests/port/base.py:
1275         (Port._apache_version):
1276         (Port._apache_config_file_name_for_platform):
1277         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1278         * Scripts/run-webkit-httpd:
1279         * Scripts/webkitperl/httpd.pm:
1280         (getApacheVersion):
1281         (getDefaultConfigForTestDirectory):
1282         (getHTTPDConfigPathForTestDirectory):
1283
1284 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1285
1286         Make the override-feature-defines script compatible with Python v3
1287         https://bugs.webkit.org/show_bug.cgi?id=105742
1288
1289         Reviewed by Martin Robinson.
1290
1291         Instead of printing output through a statement, use the print function and format
1292         the output using the str.format method. This makes the script runnable with Python v3.
1293
1294         * gtk/override-feature-defines:
1295         (adjust_feature_defines_makefile):
1296
1297 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
1298
1299         [Qt] Fix libxml2 config test
1300         https://bugs.webkit.org/show_bug.cgi?id=106317
1301
1302         Reviewed by Simon Hausmann.
1303
1304         Don't assume standard include/libxml2, libxml-2.0.pc should know
1305         where it's headers are.
1306
1307         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
1308
1309 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1310
1311         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
1312         https://bugs.webkit.org/show_bug.cgi?id=106195
1313
1314         Reviewed by Philippe Normand.
1315
1316         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
1317         to make the Python code compatible with Python 3. This includes modifying
1318         print statements, exception handling, dictionary iteration and
1319         byte-sequence-to-string conversion.
1320
1321         * gtk/common.py:
1322         (get_build_path):
1323         (pkg_config_file_variable):
1324         (gtk_version_of_pkg_config_file):
1325         * gtk/generate-gtkdoc:
1326         (print_missing_api):
1327         * gtk/gtkdoc.py:
1328         (GTKDoc.__init__):
1329         (GTKDoc._run_command):
1330
1331 2013-01-02  Steve Block  <steveblock@chromium.org>
1332
1333         Add chromium.org email address for Steve Block.
1334
1335         Unreviewed.
1336
1337         * Scripts/webkitpy/common/config/committers.py:
1338
1339 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
1340
1341         Rationalize closure call heuristics and profiling
1342         https://bugs.webkit.org/show_bug.cgi?id=106270
1343
1344         Reviewed by Oliver Hunt.
1345         
1346         Add ability to use display-profiler-output via a pipe, and add the ability to dump
1347         all generated code ('display *' or 'd *').
1348
1349         * Scripts/display-profiler-output:
1350
1351 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1352
1353         Sorted more xcodeproj files.
1354
1355         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1357         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1358
1359 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1360
1361         Sorted xcodeproj files.
1362
1363         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1364         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1365
1366 2013-01-07  Dan Bernstein  <mitz@apple.com>
1367
1368         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
1369         https://bugs.webkit.org/show_bug.cgi?id=106261
1370
1371         Reviewed by Simon Fraser.
1372
1373         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
1374
1375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1376         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
1377         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
1378         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
1379         (TestWebKitAPI):
1380         (TestWebKitAPI::TEST):
1381
1382 2013-01-07  Ojan Vafai  <ojan@chromium.org>
1383
1384         Add the Apple MountainLion bots to garden-o-matic.
1385         Eventually, we really should move away from hardcoding
1386         the list of bots.
1387
1388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1389
1390 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1391
1392         [chromium] move web audio related methods to testrunner library
1393         https://bugs.webkit.org/show_bug.cgi?id=106211
1394
1395         Reviewed by Adam Barth.
1396
1397         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1398         (DRTTestRunner::DRTTestRunner):
1399         (DRTTestRunner::reset):
1400         * DumpRenderTree/chromium/DRTTestRunner.h:
1401         (DRTTestRunner):
1402         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1403         (WebKit):
1404         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
1405         (WebTestRunner::WebTestRunner::audioData):
1406         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1407         (WebTestRunner::TestRunner::TestRunner):
1408         (WebTestRunner::TestRunner::reset):
1409         (WebTestRunner::TestRunner::shouldDumpAsAudio):
1410         (WebTestRunner):
1411         (WebTestRunner::TestRunner::audioData):
1412         (WebTestRunner::TestRunner::setAudioData):
1413         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1414         (TestRunner):
1415         * DumpRenderTree/chromium/TestShell.cpp:
1416         (TestShell::dump):
1417
1418 2013-01-07  Mike West  <mkwst@chromium.org>
1419
1420         Make the IFRAME_SEAMLESS flag runtime-enabled.
1421         https://bugs.webkit.org/show_bug.cgi?id=106213
1422
1423         Reviewed by Ojan Vafai.
1424
1425         * DumpRenderTree/chromium/TestShell.cpp:
1426         (TestShell::TestShell):
1427         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1428         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1429         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1430         (resetDefaultsToConsistentValues):
1431         * DumpRenderTree/mac/DumpRenderTree.mm:
1432         (resetDefaultsToConsistentValues):
1433         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1434         (WebCore::WebPage::resetSettings):
1435         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1436         (WTR::InjectedBundle::beginTesting):
1437             Ensure that seamless IFrames are enabled for layout tests in each of
1438             the ports that support seamless IFrames.
1439
1440 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1441
1442         [chromium] move dumpAsText and friends to the TestRunner library
1443         https://bugs.webkit.org/show_bug.cgi?id=106222
1444
1445         Reviewed by Adam Barth.
1446
1447         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
1448
1449         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1450         (DRTTestRunner::DRTTestRunner):
1451         (DRTTestRunner::reset):
1452         * DumpRenderTree/chromium/DRTTestRunner.h:
1453         (DRTTestRunner):
1454         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1455         (WebTestRunner::WebTestRunner::shouldDumpAsText):
1456         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
1457         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
1458         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
1459         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
1460         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
1461         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1462         (WebTestRunner::TestRunner::TestRunner):
1463         (WebTestRunner::TestRunner::reset):
1464         (WebTestRunner::TestRunner::shouldDumpAsText):
1465         (WebTestRunner):
1466         (WebTestRunner::TestRunner::setShouldDumpAsText):
1467         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
1468         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
1469         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
1470         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
1471         (WebTestRunner::TestRunner::dumpAsText):
1472         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
1473         (WebTestRunner::TestRunner::dumpChildFramesAsText):
1474         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1475         (TestRunner):
1476
1477 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1478
1479         Build fix attempt after r138810.
1480
1481         Apparently python 2.6 is really bad at floating point computation.
1482
1483         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1484         (MainTest.test_run_memory_test):
1485
1486 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1487
1488         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
1489         https://bugs.webkit.org/show_bug.cgi?id=106172
1490
1491         Reviewed by Tony Chang.
1492
1493         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
1494         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
1495         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
1496         test on perf-o-matic and perf. test's results page.
1497
1498         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
1499
1500         * Scripts/webkitpy/performance_tests/perftest.py:
1501         (PerfTestMetric): Added.
1502         (PerfTestMetric.__init__): Added.
1503         (PerfTestMetric.metric): Added.
1504         (PerfTestMetric.has_values): Added.
1505         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
1506         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
1507         conversions to be done on the client side (perf-o-matic and results page).
1508         (PerfTestMetric.append): Added.
1509         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
1510         a result for this metric.
1511         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
1512         (PerfTestMetric.compute_statistics): Moved from PerfTest.
1513
1514         (PerfTest._create_driver): Extracted from PerfTest.run.
1515         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
1516         as needed.
1517         (PerfTest._run_with_driver):
1518         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
1519         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
1520         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
1521
1522         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
1523         from other perf tests, there isn't much point in sharing the code here.
1524
1525         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
1526         statistics for the measured values.
1527
1528         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1529         (TestPerfTestMetric): Added.
1530         (TestPerfTestMetric.test_init_set_missing_unit): Added.
1531         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
1532         (TestPerfTestMetric.test_has_values): Added.
1533         (TestPerfTestMetric.test_append): Added.
1534         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
1535         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
1536
1537         (TestPerfTest._assert_results_are_correct): Updated as needed.
1538         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
1539         in PerfTest.run now after generating the results dictionary.
1540         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
1541
1542 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
1543
1544         Support size_t multiplication and division operators on LayoutUnit
1545         https://bugs.webkit.org/show_bug.cgi?id=83848
1546
1547         Reviewed by Emil A Eklund.
1548
1549         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1550         Added some simple tests for the new operators using size_t.
1551
1552 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1553
1554         [Qt] run-webkit-tests cleanup for parallel NRWT
1555         https://bugs.webkit.org/show_bug.cgi?id=106220
1556
1557         Reviewed by Dirk Pranke.
1558
1559         * Scripts/run-webkit-tests:
1560         (useNewRunWebKitTests):
1561         * Scripts/webkitpy/layout_tests/port/qt.py:
1562         (QtPort):
1563         (QtPort.default_child_processes):
1564
1565 2013-01-07  Philippe Normand  <pnormand@igalia.com>
1566
1567         Create a GStreamerAudio watchlist and add myself to it.
1568
1569         Unreviewed.
1570
1571         * Scripts/webkitpy/common/config/watchlist:
1572
1573 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
1574
1575         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
1576         Also removed the empty mac directory.
1577
1578         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
1579         * BuildSlaveSupport/download-built-product: Added property svn:executable.
1580         * BuildSlaveSupport/mac: Removed.
1581         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
1582
1583 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1584
1585         Add a script to delete stale zero-byte build files
1586         https://bugs.webkit.org/show_bug.cgi?id=106131
1587
1588         Reviewed by Tony Chang.
1589
1590         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
1591
1592         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1593         (DeleteStaleBuildFiles): Added.
1594         (Factory.__init__): Add DeleteStaleBuildFiles step.
1595         * BuildSlaveSupport/delete-stale-build-files: Added.
1596         (main): Delete zero-byte files except ones intentionally generated by our build process.
1597         (webkitBuildDirectory): Copied from build-product-archive.
1598
1599 2013-01-04  Michael Pruett  <michael@68k.org>
1600
1601         [GTK] Fix build error on GTK due to r138836
1602         https://bugs.webkit.org/show_bug.cgi?id=106154
1603
1604         Reviewed by Kentaro Hara.
1605
1606         * GNUmakefile.am:
1607
1608 2013-01-04  Dan Bernstein  <mitz@apple.com>
1609
1610         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
1611         https://bugs.webkit.org/show_bug.cgi?id=106121
1612
1613         Reviewed by Adele Peterson.
1614
1615         Added test for -[DOMTHMLTableCellElement _cellAbove].
1616
1617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1618         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
1619         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
1620         (TestWebKitAPI):
1621         (TestWebKitAPI::expectCellAboveCell):
1622         (TestWebKitAPI::TEST):
1623         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
1624
1625 2013-01-04  Eric Seidel  <eric@webkit.org>
1626
1627         FlakyTestReporter should be re-enabled and taught how to post patches
1628         https://bugs.webkit.org/show_bug.cgi?id=103839
1629
1630         Reviewed by Adam Barth.
1631
1632         This moves LayoutTestResultsReader off of the DeprecatedPort object.
1633         It also adds a real Port object to the EWS and CommitQueue objects
1634         using a new PatchProcessingQueue superclass.
1635         PatchProcessingQueue doesn't seem to be the cleanest insertion point
1636         but works for this purpose.
1637         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
1638         to resolve a FIXME.
1639
1640         This required some hacks/shiming between the non-specific "old"
1641         port names which the EWS system is currently using, and the new
1642         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
1643
1644         Hopefully this will fix the flaky test reporter and results uploading.
1645         Certainly it's another small step towards getting rid of the old ports.py
1646         infrastructure and making the NRWT Port class common webkitpy infrastructure.
1647
1648         Now that DeprecatedPort is no longer used for the results directory
1649         I removed all the explicit results-dir code which webkit-patch was using
1650         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
1651
1652         * Scripts/webkitpy/common/config/ports.py:
1653         (DeprecatedPort.run_perl_unittests_command):
1654         * Scripts/webkitpy/common/config/ports_mock.py:
1655         (MockPort.name):
1656         * Scripts/webkitpy/common/system/outputcapture.py:
1657         (OutputCapture.assert_outputs):
1658         * Scripts/webkitpy/layout_tests/port/apple.py:
1659         (ApplePort.determine_full_port_name):
1660         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1661         (LayoutTestResultsReader.__init__):
1662         (LayoutTestResultsReader):
1663         (LayoutTestResultsReader._read_file_contents):
1664         (LayoutTestResultsReader._create_layout_test_results):
1665         (LayoutTestResultsReader._create_unit_test_results):
1666         (LayoutTestResultsReader.results):
1667         (LayoutTestResultsReader.archive):
1668         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1669         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1670         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1671         (test_missing_unit_test_results_path):
1672         (test_layout_test_results):
1673         (test_archive_last_layout_test_results):
1674         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1675         (AbstractEarlyWarningSystem):
1676         (AbstractEarlyWarningSystem.__init__):
1677         (AbstractEarlyWarningSystem.begin_work_queue):
1678         (AbstractEarlyWarningSystem.run_command):
1679         * Scripts/webkitpy/tool/commands/queues.py:
1680         (AbstractPatchQueue.work_item_log_path):
1681         (PatchProcessingQueue):
1682         (PatchProcessingQueue._new_port_name_from_old):
1683         (PatchProcessingQueue.begin_work_queue):
1684         (PatchProcessingQueue._upload_results_archive_for_patch):
1685         (CommitQueue):
1686         (CommitQueue.begin_work_queue):
1687         (CommitQueue.run_command):
1688         (AbstractReviewQueue):
1689         (AbstractReviewQueue.__init__):
1690         (AbstractReviewQueue.begin_work_queue):
1691         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1692         (AbstractPatchQueueTest.test_next_patch):
1693         (PatchProcessingQueueTest):
1694         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
1695         * Scripts/webkitpy/tool/steps/runtests.py:
1696         (RunTests.run):
1697         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1698
1699 2013-01-04  Dana Jansens  <danakj@chromium.org>
1700
1701         [chromium] Remove lost-compositor-context layout tests
1702         https://bugs.webkit.org/show_bug.cgi?id=106089
1703
1704         Reviewed by James Robinson.
1705
1706         Remove the loseCompositorContext() test function.
1707
1708         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1709         (WebTestRunner::TestRunner::TestRunner):
1710         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1711         (TestRunner):
1712
1713 2013-01-04  Adam Klein  <adamk@chromium.org>
1714
1715         Remove ENABLE_MUTATION_OBSERVERS #define
1716         https://bugs.webkit.org/show_bug.cgi?id=105459
1717
1718         Reviewed by Ryosuke Niwa.
1719
1720         * Scripts/webkitperl/FeatureList.pm:
1721         * qmake/mkspecs/features/features.pri:
1722
1723 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1724
1725         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
1726         https://bugs.webkit.org/show_bug.cgi?id=106078
1727
1728         Reviewed by Tony Chang.
1729
1730         This patch updates values for individual iterations in dummy performance tests used in
1731         perftest_unittest.py and perftest_integrationtest.py so that they match up with
1732         statistics such as stdev and median reported in those tests. This change is required
1733         to resolve the bug 97510.
1734
1735         This patch also refactors integration tests by extracting *TestData classes that
1736         centralizes the definitions of each dummy performance test's text (DRT output),
1737         runner output, and parsed results (JSON) so that we may share more data between
1738         python tests.
1739
1740         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1741         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
1742         Use self.assertAlmostEqual when comparing the standard deviation.
1743         (MainTest.test_parse_output):
1744         (test_parse_output_with_failing_line):
1745         (test_parse_output_with_description): Use _assert_results_are_correct.
1746         (test_parse_output_with_subtests): Ditto.
1747
1748         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1749         (InspectorPassTestData): Extracted from tests below.
1750         (EventTargetWrapperTestData): Ditto.
1751         (SomeParserTestData): Ditto.
1752         (MemoryTestData): Ditto.
1753         (TestDriver.run_test): Moved test definitions out of the method.
1754         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
1755         (MainTest._load_output_json): Extracted from create_runner.
1756         (MainTest.create_runner):
1757         (MainTest.test_run_test_set_for_parser_tests):
1758         (MainTest.test_run_memory_test):
1759         (MainTest._test_run_with_json_output):
1760         (MainTest.test_run_with_json_output):
1761         (MainTest.test_run_with_description):
1762         (MainTest.test_run_generates_json_by_default):
1763         (MainTest.test_run_merges_output_by_default):
1764         (MainTest.test_run_respects_reset_results):
1765         (MainTest.test_run_generates_and_show_results_page):
1766         (MainTest.test_run_with_slave_config_json):
1767         (MainTest.test_run_with_multiple_repositories):
1768
1769 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
1770
1771         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
1772         https://bugs.webkit.org/show_bug.cgi?id=106045
1773
1774         Reviewed by Carlos Garcia Campos.
1775
1776         Update test results to confirm that compositions without preedits do not trigger
1777         a composition confirmation.
1778
1779         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
1780         (TestWebKitAPI::verifyCanceledComposition):
1781
1782 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
1783
1784         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
1785         https://bugs.webkit.org/show_bug.cgi?id=105958
1786
1787         Reviewed by Alexey Proskuryakov.
1788
1789         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
1790
1791         * WebKitTestRunner/mac/EventSenderProxy.mm:
1792         (KeyMappingEntry):
1793         (WTR):
1794         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
1795
1796 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
1797
1798         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
1799         https://bugs.webkit.org/show_bug.cgi?id=106073
1800
1801         Reviewed by Ryosuke Niwa.
1802
1803         Check that the element being compared to is not nil. 
1804         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
1805         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
1806         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
1807         sometimes before on parallel WebKitTestRunner runs.
1808
1809         * DumpRenderTree/AccessibilityUIElement.cpp:
1810         (AccessibilityUIElement::isEqual):
1811         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1812         (WTR::AccessibilityUIElement::isEqual):
1813
1814 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1815
1816         Downloads can be flaky, so try downloading multiple times.
1817         https://bugs.webkit.org/show_bug.cgi?id=105976
1818
1819         Reviewed by Eric Seidel.
1820
1821         * Scripts/webkitpy/common/system/autoinstall.py:
1822         (AutoInstaller._download_to_stream):
1823
1824 2013-01-03  Eric Seidel  <eric@webkit.org>
1825
1826         Rename Tool.port to deprecated_port in preparation for removing more callers
1827         https://bugs.webkit.org/show_bug.cgi?id=106076
1828
1829         Reviewed by Ryosuke Niwa.
1830
1831         This resolves a long-standing FIXME to rename this method. :)
1832
1833         * Scripts/webkitpy/tool/bot/botinfo.py:
1834         (BotInfo.summary_text):
1835         * Scripts/webkitpy/tool/bot/irc_command.py:
1836         (Rollout._update_working_copy):
1837         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1838         (LayoutTestResultsReader._create_layout_test_results):
1839         (LayoutTestResultsReader._create_unit_test_results):
1840         (LayoutTestResultsReader._results_directory):
1841         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1842         (test_missing_unit_test_results_path):
1843         * Scripts/webkitpy/tool/main.py:
1844         (WebKitPatch.deprecated_port):
1845         * Scripts/webkitpy/tool/mocktool.py:
1846         (MockTool.deprecated_port):
1847         * Scripts/webkitpy/tool/steps/build.py:
1848         (Build.build):
1849         * Scripts/webkitpy/tool/steps/checkstyle.py:
1850         (CheckStyle.run):
1851         * Scripts/webkitpy/tool/steps/commit.py:
1852         (Commit._check_test_expectations):
1853         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1854         (PrepareChangeLog.run):
1855         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1856         (PrepareChangeLogForDEPSRoll.run):
1857         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1858         (PrepareChangeLogForRevert.run):
1859         * Scripts/webkitpy/tool/steps/runtests.py:
1860         (RunTests.run):
1861         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1862         (StepsTest.test_runtests_args):
1863         * Scripts/webkitpy/tool/steps/update.py:
1864         (Update._update_command):
1865
1866 2013-01-03  Eric Seidel  <eric@webkit.org>
1867
1868         Add myself to the webkitpy watchlist.
1869
1870         Unreviewed.
1871
1872         * Scripts/webkitpy/common/config/watchlist:
1873
1874 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1875
1876         Cleanup perftest* tests and add a test for computing statistics
1877         https://bugs.webkit.org/show_bug.cgi?id=105685
1878
1879         Reviewed by Eric Seidel.
1880
1881         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
1882         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
1883
1884         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
1885
1886         * Scripts/webkitpy/performance_tests/perftest.py:
1887         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
1888         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
1889         accurate result for the mean.
1890         (PageLoadingPerfTest.run_single):
1891         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1892         (MainTest.test_compute_statistics):
1893         (MainTest.test_compute_statistics.compute_statistics): Added.
1894         (TestPageLoadingPerfTest.test_run): floatify values.
1895         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
1896         correctly recognizes them as integers.
1897
1898         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
1899         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
1900         (TestDriver): Moved out of MainTest.
1901         (MainTest): Got rid of assertWritten and all unit tests.
1902         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
1903         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1904         (MainTest.test_run_test_set_for_parser_tests):
1905         (MainTest.test_run_memory_test):
1906         (MainTest._test_run_with_json_output):
1907         (MainTest.test_run_generates_json_by_default):
1908         (MainTest.test_run_merges_output_by_default):
1909         (MainTest.test_run_respects_reset_results):
1910         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
1911         parsing output JSON files. Just verify that the output path is correct instead.
1912         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1913         (MainTest): Removed all integration tests.
1914         (MainTest.create_runner): Simplified.
1915
1916 2013-01-03  Julie Parent  <jparent@chromium.org>
1917
1918         Dashboard cleanup: remove usage of global g_defaultBuilderName
1919         https://bugs.webkit.org/show_bug.cgi?id=106043
1920
1921         Use now public defaultBuilder() from the BuilderGroup, rather
1922         than global variable.
1923
1924         Also eliminates the setup() and initBuilders() functions since we
1925         no longer need to track the global.
1926
1927         Reviewed by Adam Barth.
1928
1929         * TestResultServer/static-dashboards/builders.js:
1930         (BuilderGroup.prototype.defaultBuilder):
1931         (BuilderGroup.prototype.master):
1932         * TestResultServer/static-dashboards/dashboard_base.js:
1933         (parseParameters):
1934         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1935         (updateDefaultBuilderState):
1936         * TestResultServer/static-dashboards/loader.js:
1937         (.):
1938         * TestResultServer/static-dashboards/loader_unittests.js:
1939
1940 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1941
1942         Disable an intermittently failing unit test for now.
1943         The failure is tracked by the bug 106051.
1944
1945         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
1946         (TestWebKitAPI::TEST):
1947
1948 2013-01-03  Dan Bernstein  <mitz@apple.com>
1949
1950         No way to obtain a DOMNode given a JS wrapper for a Node
1951         https://bugs.webkit.org/show_bug.cgi?id=106033
1952
1953         Added a test for +[DOMNode _nodeFromJSWrapper:].
1954
1955         Reviewed by Sam Weinig.
1956
1957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1958         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
1959         (TestWebKitAPI):
1960         (TestWebKitAPI::TEST):
1961
1962 2013-01-03  Emil A Eklund  <eae@chromium.org>
1963
1964         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
1965         https://bugs.webkit.org/show_bug.cgi?id=105961
1966
1967         Reviewed by Levi Weintraub.
1968         
1969         Add tests for LayoutUnit::ceil and floor.
1970
1971         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1972         (TestWebKitAPI::TEST):
1973         (TestWebKitAPI):
1974
1975 2013-01-03  Julie Parent  <jparent@chromium.org>
1976
1977         Add unit test for default builder for the dashboards.
1978         https://bugs.webkit.org/show_bug.cgi?id=105972
1979
1980         Reviewed by Dirk Pranke.
1981
1982         * TestResultServer/static-dashboards/loader_unittests.js:
1983
1984 2013-01-03  Tony Chang  <tony@chromium.org>
1985
1986         Generate internal.settings from Settings.in
1987         https://bugs.webkit.org/show_bug.cgi?id=104740
1988
1989         Reviewed by Adam Barth.
1990
1991         * GNUmakefile.am: Compile new generated files on GTK+.
1992         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1993         with both extra_sources and add_output_to_sources=false will still
1994         compile the files in extra_sources. This makes it possible to compile
1995         InternalSettingsGenerated.cpp and not be confused by
1996         InternalSettingsGenerated.idl.
1997
1998 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
1999
2000         [style] WebIDL-reflecting uppercase enums reported as style violation
2001         https://bugs.webkit.org/show_bug.cgi?id=105832
2002
2003         Reviewed by Tony Chang.
2004
2005         Recognize the enum as WebIDL-reflecting one if there's a comment present that
2006         indicates this. In enums spanning over multiple lines, the comment is expected
2007         on the first line. In enums placed in one line, the comment is expected at the
2008         end of that line.
2009
2010         WebIDL-reflecting enum values are required to be written in uppercase and as such
2011         violate the common rule of these values being written in InterCaps. Annotating
2012         enums this way makes it possible to avoid false style violation reports.
2013
2014         The comment is of form '// Web(?:Kit)?IDL enum'.
2015
2016         * Scripts/webkitpy/style/checkers/cpp.py:
2017         (_EnumState.__init__):
2018         (_EnumState.process_clean_line):
2019         (check_enum_casing):
2020         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2021         (NoNonVirtualDestructorsTest.test_enum_casing):
2022
2023 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
2024
2025         Adding favicon.ico to the garden-o-matic.
2026         https://bugs.webkit.org/show_bug.cgi?id=105982
2027
2028         Reviewed by Adam Barth.
2029
2030         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
2032
2033 2013-01-03  Jonathan Liu  <net147@gmail.com>
2034
2035         [Qt] Fix library linking order
2036         https://bugs.webkit.org/show_bug.cgi?id=105818
2037
2038         Some Qt libraries are linked before the private static libraries
2039         that depend on them which results in QtWebKit failing to link.
2040
2041         Copy Qt module dependencies from QT to QT_PRIVATE when creating
2042         module to ensure the Qt libraries are linked after the private
2043         static libraries that depend on them.
2044
2045         Reviewed by Tor Arne Vestbø.
2046
2047         * qmake/mkspecs/features/default_post.prf:
2048
2049 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
2050
2051         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
2052         https://bugs.webkit.org/show_bug.cgi?id=102209
2053
2054         Reviewed by Gyuyoung Kim.
2055
2056         Set tooltip on the elm_window instead of ewk_view, and add delay to
2057         show the tooltip window.
2058
2059         Setting tooltip on the ewk_view makes elementary error message because
2060         ewk_view is not an elementary widget. To remove the error message,
2061         tooltip should be set on the elm_window.
2062
2063         Most browsers show the tooltip after a mouse pointer stays on an
2064         element object that has tooltip text.
2065         But elm_tooltip widget itself doesn't have delay or handle mouse
2066         events to show/hide.
2067
2068         So additional codes are added to show/hide tooltip widget along with
2069         mouse events.
2070           1) When a mouse pointer stays for a second on an element which has
2071              tooltip text, then tooltip widget is displayed.
2072           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
2073              widget.
2074
2075         * MiniBrowser/efl/main.c:
2076         (_Tooltip_Information):
2077         (_Browser_Window):
2078         (on_tooltip_show):
2079         (window_tooltip_hide):
2080         (window_tooltip_update):
2081         (on_mouse_in):
2082         (on_mouse_move):
2083         (on_mouse_out):
2084         (window_free):
2085         (on_tooltip_text_set):
2086         (on_tooltip_text_unset):
2087         (window_create):
2088
2089 2013-01-02  Tony Chang  <tony@chromium.org>
2090
2091         Unreviewed, rolling out r138661.
2092         http://trac.webkit.org/changeset/138661
2093         https://bugs.webkit.org/show_bug.cgi?id=104740
2094
2095         Compile problems on EFL
2096
2097         * GNUmakefile.am:
2098         * qmake/mkspecs/features/default_post.prf:
2099
2100 2013-01-02  Tony Chang  <tony@chromium.org>
2101
2102         Generate internal.settings from Settings.in
2103         https://bugs.webkit.org/show_bug.cgi?id=104740
2104
2105         Reviewed by Adam Barth.
2106
2107         * GNUmakefile.am: Compile new generated files on GTK+.
2108         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
2109         with both extra_sources and add_output_to_sources=false will still
2110         compile the files in extra_sources. This makes it possible to compile
2111         InternalSettingsGenerated.cpp and not be confused by
2112         InternalSettingsGenerated.idl.
2113
2114 2013-01-02  Adam Barth  <abarth@webkit.org>
2115
2116         Remove old-run-webkit-tests support from webkitpy
2117         https://bugs.webkit.org/show_bug.cgi?id=105619
2118
2119         Reviewed by Eric Seidel.
2120
2121         This patch removes support for webkitpy parsing the
2122         old-run-webkit-tests results format. There doesn't seem to be any
2123         reason to keep this code around anymore now that most bots have
2124         switched to new-run-webkit-tests.
2125
2126         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2127         (Builder.fetch_layout_test_results):
2128         * Scripts/webkitpy/common/net/layouttestresults.py:
2129         (path_for_layout_test):
2130         (LayoutTestResults.results_from_string):
2131         (LayoutTestResults):
2132         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2133         (LayoutTestResultsTest.test_results_from_string):
2134         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2135         (test_flaky_test_failure):
2136         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2137         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2138         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2139         (PatchAnalysisTask._test_patch):
2140         * Scripts/webkitpy/tool/commands/queuestest.py:
2141         (QueuesTest.assert_queue_outputs):
2142
2143 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
2144
2145         [Qt][WK2] Add simple UI to find text from page
2146         https://bugs.webkit.org/show_bug.cgi?id=96481
2147
2148         Reviewed by Jocelyn Turcotte.
2149
2150         Find bar that slides between navigation bar and WebView.
2151
2152         * MiniBrowser/qt/BrowserWindow.cpp:
2153         (BrowserWindow::toggleFind):
2154         * MiniBrowser/qt/BrowserWindow.h:
2155         (BrowserWindow):
2156         * MiniBrowser/qt/MiniBrowser.qrc:
2157         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2158         (MiniBrowserApplication::notify):
2159         * MiniBrowser/qt/icons/find.png: Added.
2160         * MiniBrowser/qt/qml/BrowserWindow.qml:
2161
2162 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
2163
2164         Regression(r138603): Caused 2 webkitpy tests to fail
2165         https://bugs.webkit.org/show_bug.cgi?id=105913
2166
2167         Reviewed by Kentaro Hara.
2168
2169         Fix 2 webkitpy tests that started to fail after
2170         r138603.
2171
2172         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2173         (IRCCommandTest._sheriff_test_data_url): Make sure the
2174         returned test file URL is valid no matter what the
2175         current working directory is.
2176         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2177         (IRCBotTest.test_help): Add "sheriffs" command to the
2178         list of available commands.
2179
2180 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
2181
2182         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
2183         https://bugs.webkit.org/show_bug.cgi?id=105897
2184
2185         Reviewed by Alexey Proskuryakov.
2186
2187         Dump in WebKitTestRunner the message that is expected by layout tests
2188         when the missing plugin button is clicked.
2189
2190         * WebKitTestRunner/TestController.cpp:
2191         (WTR::TestController::createWebViewWithOptions):
2192         (WTR::TestController::unavailablePluginButtonClicked):
2193         (WTR):
2194         * WebKitTestRunner/TestController.h:
2195         (TestController):
2196
2197 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
2198
2199         [EFL] Enable MHTML feature
2200         https://bugs.webkit.org/show_bug.cgi?id=105815
2201
2202         Reviewed by Laszlo Gombos.
2203
2204         Enable MHTML feature for EFL port by default.
2205
2206         * Scripts/webkitperl/FeatureList.pm:
2207
2208 2013-01-01  Alan Cutter  <alancutter@chromium.org>
2209
2210         sheriff-bot should know who the gardeners/sheriffs are
2211         https://bugs.webkit.org/show_bug.cgi?id=105698
2212
2213         Reviewed by Eric Seidel.
2214
2215         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
2216
2217         * Scripts/webkitpy/tool/bot/irc_command.py:
2218         (Current):
2219         (Current._retrieve_webkit_sheriffs):
2220         (Current.execute):
2221         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2222         (IRCCommandTest.test_current):
2223         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
2224         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
2225         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
2226         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
2227         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
2228
2229 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2230
2231         [GTK] Move ImageDiff to the Tools directory root
2232         https://bugs.webkit.org/show_bug.cgi?id=105421
2233
2234         Reviewed by Kenneth Rohde Christiansen.
2235
2236         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
2237         * GNUmakefile.am:
2238         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
2239
2240 2012-12-30  Mike West  <mkwst@chromium.org>
2241
2242         Add myself to watchlists for CSP and console logs.
2243         https://bugs.webkit.org/show_bug.cgi?id=105874
2244
2245         Reviewed by Dirk Pranke.
2246
2247         Because I really, really, really need more email.
2248
2249         * Scripts/webkitpy/common/config/committers.py:
2250             Add mkwst+watchlist@chromium.org as a contributor.
2251         * Scripts/webkitpy/common/config/watchlist:
2252             Create watchlist categories for 1) the various mechanisms used to
2253             generate console messages, and 2) CSP usage and files.
2254
2255 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2256
2257         [EFL] Enable TEMPLATE_ELEMENT feature
2258         https://bugs.webkit.org/show_bug.cgi?id=105865
2259         
2260         Reviewed by Laszlo Gombos.
2261
2262         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
2263
2264 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
2265
2266         Unreviewed GTK gardening of the unit tests.
2267
2268         Skip the TestInspectorServer unit test that's timing out completely.
2269
2270         * Scripts/run-gtk-tests:
2271         (TestRunner):
2272
2273 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
2274
2275         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
2276         https://bugs.webkit.org/show_bug.cgi?id=105855
2277
2278         Reviewed by Vsevolod Vlasov.
2279
2280         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
2281         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
2282
2283         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2284         (ReportMemoryUsageVisitor):
2285         (clang::AddMemberCallVisitor::VisitCallExpr):
2286         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2287         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
2288
2289 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
2290
2291         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
2292         https://bugs.webkit.org/show_bug.cgi?id=105852
2293
2294         Reviewed by Alexander Pavlov.
2295
2296         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2297         (clang):
2298         (AddMemberCallVisitor):
2299         (ReportMemoryUsageVisitor):
2300         (clang::ReportMemoryUsageAction::ParseArgs):
2301         (clang::AddMemberCallVisitor::VisitCallExpr):
2302         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2303         (clang::ReportMemoryUsageVisitor::emitWarning):
2304         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
2305         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
2306         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
2307
2308 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
2309
2310         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
2311         https://bugs.webkit.org/show_bug.cgi?id=105835
2312
2313         Reviewed by Dirk Pranke.
2314
2315         The BeautifulSoup module is a third-party import and as such we don't have much control
2316         over its testing. Because of that it should be omitted from code coverage checking.
2317
2318         * Scripts/webkitpy/test/main.py:
2319         (Tester._run_tests):
2320
2321 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
2322
2323         [GTK][WK2] Add support for IME Composition
2324         https://bugs.webkit.org/show_bug.cgi?id=65093
2325
2326         Reviewed by Carlos Garcia Campos.
2327
2328         Update unit tests for GtkInputMethodFilter to note whether or not an event
2329         was a fake event synthesized for composition purposes. This is now used
2330         for WebKit2.
2331
2332         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2333         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
2334         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
2335         (TestWebKitAPI::TEST):
2336         * gtk/generate-gtkdoc:
2337         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
2338         generation.
2339
2340 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
2341
2342         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
2343         https://bugs.webkit.org/show_bug.cgi?id=105800
2344
2345         Reviewed by Yury Semikhatsky.
2346
2347         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2348         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
2349         (clang):
2350
2351 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
2352
2353         Create a GTK build system watchlist and add myself to it
2354         https://bugs.webkit.org/show_bug.cgi?id=105769
2355
2356         Reviewed by Dirk Pranke.
2357
2358         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
2359         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
2360         omitted on purpose due to relatively high change rate they are exposed to.
2361
2362         The new watchlist would be of use to me as the GTK build system recently went
2363         through a series of changes that included a changed policy on adding configuration
2364         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
2365         mailing list about this change will be published later, but I'd also like to be
2366         notified of any pending changes to these files just so I can check the changes are
2367         in compliance with the new policy.
2368
2369         * Scripts/webkitpy/common/config/watchlist:
2370
2371 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
2372
2373         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
2374         As example ..../DevTools/src/third_party/WebKit
2375
2376         * Scripts/webkitpy/common/webkit_finder.py:
2377         (WebKitFinder.webkit_base):
2378
2379 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
2380
2381         [EFL][WK2] Refactor snapshot taking code
2382         https://bugs.webkit.org/show_bug.cgi?id=105687
2383
2384         Reviewed by Kenneth Rohde Christiansen.
2385
2386         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
2387         since the function was renamed to follow naming style.
2388
2389         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2390         (WTR::PlatformWebView::windowSnapshotImage):
2391
2392 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
2393
2394         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
2395         https://bugs.webkit.org/show_bug.cgi?id=105725
2396
2397         Reviewed by Yury Semikhatsky.
2398
2399         MemberType value names were adjusted according to Style Guide.
2400         Existing tests were extended with link type validation.
2401
2402         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2403
2404 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2405
2406         [BlackBerry] DRT - Crashed when running pixels tests
2407         https://bugs.webkit.org/show_bug.cgi?id=105711
2408
2409         RIM PR 270003
2410
2411         Reviewed by George Staikos.
2412
2413         Calling window->post() here will result in buffer swapping which is
2414         only allowed in UI thread now, and I found we don't need to call it
2415         for GL renderer.
2416
2417         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2418         (createBitmapContextFromWebView):
2419
2420 2012-12-22  Dan Winship  <danw@gnome.org>
2421
2422         Add a patch to fix libxml2 2.9.0 regression
2423         https://bugs.webkit.org/show_bug.cgi?id=104494
2424
2425         Reviewed by Martin Robinson.
2426
2427         * gtk/jhbuild.modules:
2428         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
2429
2430 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2431
2432         Unreviewed update of status to reviewer.
2433
2434         * Scripts/webkitpy/common/config/committers.py:
2435
2436 2012-12-23  Philippe Normand  <pnormand@igalia.com>
2437
2438         [GTK][jhbuild] Bump GStreamer to 1.0.4
2439         https://bugs.webkit.org/show_bug.cgi?id=105640
2440
2441         Reviewed by Martin Robinson.
2442
2443         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
2444
2445 2012-12-21  Nico Weber  <thakis@chromium.org>
2446
2447         chromium: webkit-build-directory doesn't handle ninja output dirs
2448         https://bugs.webkit.org/show_bug.cgi?id=105671
2449
2450         Reviewed by Daniel Bates.
2451
2452         Teach webkit-build-directory to detect the ninja build directory.
2453
2454         * Scripts/webkitdirs.pm:
2455         (determineBaseProductDir):
2456         (determineIsChromiumNinja):
2457
2458 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
2459
2460         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
2461         https://bugs.webkit.org/show_bug.cgi?id=95477
2462
2463         Reviewed by Sam Weinig.
2464
2465         Co-authored by Jia Pu.
2466
2467         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
2468         we can have consistent autocorrection behavior when running tests.
2469
2470         * DumpRenderTree/mac/DumpRenderTree.mm:
2471         (resetDefaultsToConsistentValues):
2472         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2473         (WTR::InjectedBundle::platformInitialize):
2474
2475 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
2476
2477         [GTK] Add WebKit1-specific TestExpectations file
2478         https://bugs.webkit.org/show_bug.cgi?id=97562
2479
2480         Reviewed by Dirk Pranke.
2481
2482         Implement the expectations_files method inside the GtkPort class that
2483         returns the list of the TestExpectations files the current test configuration
2484         requires. The method is implemented in a similar way as on the EFL port.
2485         A unit test is also added.
2486
2487         * Scripts/webkitpy/layout_tests/port/gtk.py:
2488         (GtkPort._search_paths):
2489         (GtkPort):
2490         (GtkPort.expectations_files):
2491         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2492         (GtkPortTest.test_expectations_files):
2493
2494 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2495
2496         [EFL] Enable feature option for the CSS sticky position
2497         https://bugs.webkit.org/show_bug.cgi?id=105630
2498
2499         Reviewed by Kenneth Rohde Christiansen.
2500
2501         Enable CSS sticky position feature by default for the
2502         EFL port. This feature option was added in r138252.
2503
2504         No new tests. Existing layout tests pass.
2505
2506         * Scripts/webkitperl/FeatureList.pm:
2507
2508 2012-12-21  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2509
2510         [WK2] REGRESSION(r138232): It made 4 tests timeout
2511         https://bugs.webkit.org/show_bug.cgi?id=105623
2512
2513         Reviewed by Kenneth Rohde Christiansen.
2514
2515         r138232 changed functionality so that empty text output
2516         no longer leads to a dump() call, which leads to a timeout.
2517         Instead do a text dump if there is text output or if there
2518         is no audio output.
2519
2520         * WebKitTestRunner/TestInvocation.cpp:
2521         (WTR::TestInvocation::dumpResults):
2522
2523 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2524
2525         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2526         https://bugs.webkit.org/show_bug.cgi?id=105309
2527
2528         On Windows the library name is Qt5WebKitWidgets as well.
2529         So r138136 should not have adjusted the library name for Windows.
2530
2531         Reviewed by Simon Hausmann.
2532
2533         * Scripts/webkitdirs.pm:
2534         (builtDylibPathForName):
2535
2536 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2537
2538         [Qt] Add new TestExpectations for qt-5.0-mac-wk2.
2539         https://bugs.webkit.org/show_bug.cgi?id=105424
2540
2541         This change will allow us to run a very specific
2542         subset of the available LayoutTests on a mac buildbot.
2543         The new baseline search path for mac will look as follows:
2544         qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
2545
2546         Reviewed by Dirk Pranke.
2547
2548         * Scripts/webkitpy/layout_tests/port/qt.py:
2549         (QtPort._search_paths):
2550         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2551         (QtPortTest):
2552
2553 2012-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2554
2555         [EFL] Build break with latest EFL libraries.
2556         https://bugs.webkit.org/show_bug.cgi?id=104827
2557
2558         Reviewed by Laszlo Gombos.
2559
2560         The eo EFL package is introduced and evas and ecore use it since 1.8.
2561         While introducing Eo, EFL changed several structures of Evas and Ecore
2562         from own specific class to Eo.
2563
2564         So, this patch adds FindEo and changes declaration of Evas, Evas_Object,
2565         Ecore_Timer to build with latest EFL libraries.
2566
2567         * DumpRenderTree/efl/CMakeLists.txt: Includes eo EFL library.
2568         * EWebLauncher/CMakeLists.txt: Ditto.
2569         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2570         * ImageDiff/PlatformEfl.cmake: Ditto.
2571         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
2572         * TestWebKitAPI/PlatformWebView.h: Modified declaration of Evas_Object.
2573         * WebKitTestRunner/InjectedBundle/TestRunner.h: Modified declaration of Ecore_Timer.
2574         * WebKitTestRunner/PlatformEfl.cmake: Includes eo EFL library.
2575         * WebKitTestRunner/PlatformWebView.h: Modified declaration of Evas_Object.
2576
2577 2012-12-20  Dirk Pranke  <dpranke@chromium.org>
2578
2579         TestExpectation fallback is broken
2580         https://bugs.webkit.org/show_bug.cgi?id=105583
2581
2582         Reviewed by Ryosuke Niwa.
2583
2584         When I added support for the -wk2 in port names, it looks
2585         like I broke the way we computed the list of TestExpectations
2586         files so that the implementation-version directory was left out :(.
2587         Fixed and cleaned up the tests.
2588
2589         * Scripts/webkitpy/layout_tests/port/base.py:
2590         (Port.expectations_files):
2591         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2592         (TestWebKitPort.__init__):
2593         (PortTestCase.test_skipped_directories_for_symbols):
2594         (test_skipped_directories_for_features):
2595         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
2596         (test_skipped_tests_for_unsupported_features_empty_test_list):
2597         (test_skipped_layout_tests):
2598         (test_expectations_files):
2599
2600 2012-12-20  Anders Carlsson  <andersca@apple.com>
2601
2602         Don't include WebKit2 headers when building TestWebKitAPI on windows
2603         https://bugs.webkit.org/show_bug.cgi?id=105582
2604
2605         Reviewed by Tim Horton.
2606
2607         * TestWebKitAPI/config.h:
2608         * TestWebKitAPI/win/main.cpp:
2609
2610 2012-12-20  Ryosuke Niwa  <rniwa@webkit.org>
2611
2612         REGRESSION(r133820?): SimplifyMarkupTest API test asserts
2613         https://bugs.webkit.org/show_bug.cgi?id=105370
2614
2615         Reviewed by Simon Fraser.
2616
2617         Re-enable the test.
2618
2619         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2620         (TestWebKitAPI::TEST):
2621
2622 2012-12-20  Nico Weber  <thakis@chromium.org>
2623
2624         chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
2625         https://bugs.webkit.org/show_bug.cgi?id=105498
2626
2627         Reviewed by Dirk Pranke.
2628
2629         Use the newest binary available rather than an than always picking one
2630         build directory over another based on iteration order.
2631
2632         * Scripts/webkitpy/layout_tests/port/chromium.py:
2633         (ChromiumPort._static_build_path):
2634         Check for timestamps.
2635         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2636         (ChromiumMacPortTest.test_build_path_timestamps):
2637         Test that out / xcodebuild selection happens based on timestamps
2638         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2639         (ChromiumWinPortTest.test_build_path_timestamps):
2640         Test that out / build selection happens based on timestamps
2641
2642 2012-12-19  Simon Fraser  <simon.fraser@apple.com>
2643
2644         Lots of sticky tests failing in WK2
2645         https://bugs.webkit.org/show_bug.cgi?id=105464
2646
2647         Reviewed by Beth Dakin.
2648
2649         WebKitTestRunner had a race between snapshotting in the UI process,
2650         and resettting after the test in the web process. InjectedBundle::done()
2651         was a bad place to call page()->resetAfterTest(), because of this race;
2652         it could reset the scroll position before the UI snapshot had been obtained.
2653         
2654         Fix by moving the call to page()->resetAfterTest() into didReceiveMessage(),
2655         for the "Reset" message which will come in before the next test.
2656
2657         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2658         (WTR::InjectedBundle::didReceiveMessage):
2659         (WTR::InjectedBundle::done):
2660
2661 2012-12-19  Filip Pizlo  <fpizlo@apple.com>
2662
2663         DFG speculation checks that take JumpList should consolidate OSRExits
2664         https://bugs.webkit.org/show_bug.cgi?id=105401
2665
2666         Reviewed by Oliver Hunt.
2667
2668         Update the profiler to understand that an OSR exit may have multiple
2669         candidate exit sites.
2670
2671         * Scripts/display-profiler-output:
2672
2673 2012-12-20  Eric Seidel  <eric@webkit.org>
2674
2675         EWSes do not need to dump build/test logs when things pass
2676         https://bugs.webkit.org/show_bug.cgi?id=105402
2677
2678         Reviewed by Dirk Pranke.
2679
2680         When we were first writing the commit-queue and EWS system
2681         and running them locally, we thought it was important to see the
2682         build/test output as it happened.  Now these queues have been running
2683         for years, and we don't use this feature anymore.  So this patch
2684         makes us stop tee-ing the output directly to stdout, and instead
2685         only print any output from commands when they fail.
2686
2687         I also added some logging when we execute each command
2688         since we are no longer printing the command output itself.
2689         This should make it much easier to see errors with the EWS
2690         system itself, now that all the passing-build output is removed.
2691
2692         This required updating a zillion unittests, since we have a bunch of
2693         "integration" style testing of the queue-bots.  Many of the unittests for the bots were
2694         already approximating this behavior by using a "logging" Executive.
2695         I disabled logging in those cases to avoid redundant logging in those tests.
2696
2697         * Scripts/webkitpy/common/system/executive.py:
2698         (Executive.command_for_printing):
2699         (Executive.run_command):
2700         * Scripts/webkitpy/common/system/executive_mock.py:
2701         (MockExecutive.command_for_printing):
2702         (MockExecutive.run_command):
2703         * Scripts/webkitpy/common/system/executive_unittest.py:
2704         (ExecutiveTest.test_auto_stringify_args):
2705         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2706         (EarlyWarningSytemTest._default_expected_logs):
2707         (_test_ews):
2708         (_test_ewses):
2709         * Scripts/webkitpy/tool/commands/queues.py:
2710         (AbstractQueue.run_webkit_patch):
2711         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2712         (AbstractQueueTest._assert_run_webkit_patch):
2713         (CommitQueueTest.test_commit_queue):
2714         (test_rollout):
2715         (test_rollout_lands):
2716         (test_manual_reject_during_processing):
2717         (StyleQueueTest.test_style_queue_with_style_exception):
2718         (test_style_queue_with_watch_list_exception):
2719
2720 2012-12-20  Dominic Mazzoni  <dmazzoni@google.com>
2721
2722         AX: support clickPoint in DRT for chromium
2723         https://bugs.webkit.org/show_bug.cgi?id=97359
2724
2725         Reviewed by Chris Fleizach.
2726
2727         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2728         several more tests can pass.
2729
2730         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2731         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2732         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2733         (WebTestRunner):
2734         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2735         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2736         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2737         (AccessibilityUIElement):
2738
2739 2012-12-20  Dan Bernstein  <mitz@apple.com>
2740
2741         prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense
2742         https://bugs.webkit.org/show_bug.cgi?id=99268
2743
2744         Reviewed by Alexey Proskuryakov.
2745
2746         * Scripts/prepare-ChangeLog:
2747         (generateNewChangeLogs): Removed the "Additional information of the change" line.
2748
2749 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2750
2751         Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate
2752
2753         * Scripts/run-gtk-tests:
2754         (TestRunner):
2755
2756 2012-12-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2757
2758         [Qt] Move ImageDiff to the Tools directory root
2759         https://bugs.webkit.org/show_bug.cgi?id=105420
2760
2761         Reviewed by Tor Arne Vestbø.
2762
2763         Moved ImageDiff from outside DumpRenderTree because it is also a
2764         dependency when running pixel tests for WebKit2.
2765
2766         * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
2767         * ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
2768         * Tools.pro:
2769
2770 2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
2771
2772         [GTK] Remove the --enable-unstable-features configuration option
2773         https://bugs.webkit.org/show_bug.cgi?id=105327
2774
2775         Reviewed by Martin Robinson.
2776
2777         Add a missing feature option for the CSS sticky position feature.
2778
2779         * Scripts/webkitperl/FeatureList.pm:
2780
2781 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2782
2783         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
2784
2785         * Scripts/run-gtk-tests:
2786         (TestRunner):
2787
2788 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2789
2790         [EFL] MiniBrowser does not play Infinite Gangnam Style
2791         https://bugs.webkit.org/show_bug.cgi?id=103531
2792
2793         Reviewed by Kenneth Rohde Christiansen.
2794
2795         For EFL we would like this feature to be built by default.
2796
2797         * Scripts/webkitperl/FeatureList.pm:
2798
2799 2012-12-20  Csaba Osztrogonác  <ossy@webkit.org>
2800
2801         [Qt] EWS bots should call qmake always
2802         https://bugs.webkit.org/show_bug.cgi?id=90049
2803
2804         Reviewed by Simon Hausmann.
2805
2806         * Scripts/webkitdirs.pm:
2807         (buildQMakeProjects):
2808
2809 2012-12-20  Jochen Eisinger  <jochen@chromium.org>
2810
2811         [chromium] fix stray printf in TestRunner's WebTestProxy
2812         https://bugs.webkit.org/show_bug.cgi?id=105515
2813
2814         Reviewed by Ryosuke Niwa.
2815
2816         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2817         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
2818
2819 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2820
2821         [WK2] WebAudio WKTR support
2822         https://bugs.webkit.org/show_bug.cgi?id=95084
2823
2824         Reviewed by Kenneth Rohde Christiansen.
2825
2826         Implementing audio data dump support for WebKitTestRunner,
2827         by adding the API to the IDL, enabling IPC for transferring
2828         the audio data as bytebuffer and dumping it according
2829         to run-webkit-tests script's expectations.
2830         This enables audio testing on WebKit2 ports.
2831         Based on initial wip-patch from Philippe Normand - thanks.
2832
2833         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
2834         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
2835         (WTR::TestRunner::setAudioData):
2836         (WTR):
2837         * WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
2838         (TestRunner):
2839         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
2840         (WTR::InjectedBundle::done):
2841         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
2842         (WTR::InjectedBundle::setAudioResult):
2843         (InjectedBundle):
2844         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2845         (WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
2846         * WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
2847         (WTR::TestInvocation::dumpResults):
2848         (WTR):
2849         (WTR::TestInvocation::dumpAudio):
2850         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
2851         * WebKitTestRunner/TestInvocation.h:
2852         (TestInvocation):
2853
2854 2012-12-20  Alberto Garcia  <agarcia@igalia.com>
2855
2856         [GTK] Count failed and timed out tests separately
2857         https://bugs.webkit.org/show_bug.cgi?id=105448
2858
2859         Reviewed by Carlos Garcia Campos.
2860
2861         Display the number of tests that fail, time out and are skipped
2862         separately in the buildbot page.
2863
2864         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2865         (RunGtkAPITests.commandComplete):
2866         (RunGtkAPITests.evaluateCommand):
2867         (RunGtkAPITests.getText2):
2868         * Scripts/run-gtk-tests:
2869         (TestRunner.run_tests):
2870
2871 2012-12-19  Ryosuke Niwa  <rniwa@webkit.org>
2872
2873         PerfTest.parse_output does too much
2874         https://bugs.webkit.org/show_bug.cgi?id=105391
2875
2876         Reviewed by Tony Chang.
2877
2878         Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
2879         Also moved the code to output test results into PerfTest._run_with_driver.
2880
2881         * Scripts/webkitpy/performance_tests/perftest.py:
2882         (PerfTest.__init__): Added _description.
2883         (PerfTest.description): Added.
2884         (PerfTest._run_with_driver): Moved the code to output test description and test results.
2885         (PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
2886         (PerfTest.parse_output): Removed the code to output test results. Return test results and description
2887         respectively. Also removed the code that allowed some tests to omit values since all tests report each
2888         iteration now since r136492.
2889         (PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
2890         (ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
2891         regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
2892         get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
2893         (ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
2894         (PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
2895         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2896         (MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
2897         Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
2898         (MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
2899         so that it's not string-concatenated with the next line.
2900         (MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
2901         (MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.
2902
2903 2012-12-19  Alexis Menard  <alexis@webkit.org>
2904
2905         Implement CSS parsing for CSS transitions unprefixed.
2906         https://bugs.webkit.org/show_bug.cgi?id=104804
2907
2908         Reviewed by Dean Jackson.
2909
2910         Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
2911         to cover the work of unprefixing Transforms, Animations and 
2912         Transitions. It will let the possibility of each ports to turn it off 
2913         in their release branches until we're confident that these CSS 
2914         properties are ready to be unprefixed.
2915
2916         * Scripts/webkitperl/FeatureList.pm:
2917         * qmake/mkspecs/features/features.pri:
2918
2919 2012-12-19  Julien Chaffraix  <jchaffraix@webkit.org>
2920
2921         2 clampTo unit tests are failing
2922         https://bugs.webkit.org/show_bug.cgi?id=105253
2923
2924         Reviewed by Emil A Eklund.
2925
2926         Removed clampToUnsigned as it was actually testing exactly what
2927         clampToUnsignedLong was doing. Also made clampToIntFloat more robust
2928         to precision loss (fix suggested by Emil).
2929
2930         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2931
2932 2012-12-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2933
2934         [EFL] Move ImageDiff to the Tools directory root
2935         https://bugs.webkit.org/show_bug.cgi?id=105305
2936
2937         Reviewed by Laszlo Gombos.
2938
2939         We previously moved this directory from the DRT directory to
2940         efl/ImageDiff. The major reason for doing so was because ImageDiff does
2941         not depend on DumpRenderTree but for legacy reasons was living inside the
2942         DRT folder, even though it is needed when running pixel tests for WK2.
2943
2944         Now we are moving to Tool directory root as other ports agreed to do the same.
2945
2946         * CMakeLists.txt:
2947         * ImageDiff/CMakeLists.txt: Added.
2948         * ImageDiff/PlatformEfl.cmake: Added.
2949         * ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
2950         * efl/ImageDiff/CMakeLists.txt: Removed.
2951
2952 2012-12-19  Zeno Albisser  <zeno@webkit.org>
2953
2954         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2955         https://bugs.webkit.org/show_bug.cgi?id=105309
2956
2957         The version number is only used as a part
2958         of the library name on Linux.
2959
2960         Reviewed by Kenneth Rohde Christiansen.
2961
2962         * Scripts/webkitdirs.pm:
2963         (builtDylibPathForName):
2964
2965 2012-12-19  Alberto Garcia  <agarcia@igalia.com>
2966
2967         [GTK] Tests that time out are not considered as failures.
2968         https://bugs.webkit.org/show_bug.cgi?id=105318
2969
2970         Reviewed by Martin Robinson.
2971
2972         Fix parsing of the GTK API tests log files.
2973
2974         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2975         (RunGtkAPITests.commandComplete):
2976
2977 2012-12-18  Ilya Tikhonovsky  <loislo@chromium.org>
2978
2979         Unreviewed, rolling out r138061.
2980         https://bugs.webkit.org/show_bug.cgi?id=105396
2981
2982         Original patch:
2983         http://trac.webkit.org/changeset/138061
2984         https://bugs.webkit.org/show_bug.cgi?id=97359
2985
2986         It is crashing on Debug bots
2987
2988         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2989         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2990         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2991         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2992         (AccessibilityUIElement):
2993
2994 2012-12-18  Alice Liu  <alice.liu@apple.com>
2995
2996         Test for https://bugs.webkit.org/show_bug.cgi?id=105106
2997         Add SPI to WebKit1 WebFrame for hit testing
2998
2999         Reviewed by Dan Bernstein.
3000
3001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
3002         * TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
3003         (TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
3004         Then hit-tests at three points, expecting to hit the two divs and body element. 
3005
3006 2012-12-18  Alice Liu  <alice.liu@apple.com>
3007
3008         Test for https://bugs.webkit.org/show_bug.cgi?id=105262
3009         Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
3010
3011         Reviewed by Anders Carlsson.
3012
3013         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
3014         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
3015         (TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
3016         Loads html with a single div element. In an isolated world, creates a property on that node.
3017         Also, in the standard world, creates a different property on that node.  Then tests for 4 things:
3018             - Existence of the isolated property in the isolated world.
3019             - Existence of the standard property in the standard world.
3020             - Non-existence of the isolated property in the standard world.
3021             - Non-existence of the standard property in the isolated world.
3022
3023 2012-12-18  Simon Fraser  <simon.fraser@apple.com>
3024
3025         Disable the SimplifyMarkup API test, wich asserts in debug builds.
3026         Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.
3027         
3028         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
3029         (TestWebKitAPI::TEST):
3030
3031 2012-12-18  Joseph Pecoraro  <pecoraro@apple.com>
3032
3033         [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
3034         https://bugs.webkit.org/show_bug.cgi?id=104279
3035
3036         Reviewed by David Kilzer.
3037
3038         Add a build phase script that checks a framework's header files for
3039         Platform.h and Compiler.h macros. Also add some tests for the script.
3040
3041         * Scripts/check-for-inappropriate-macros-in-external-headers: Added.
3042         Script to be used in build phases to check for inappropriate macros in headers.
3043
3044         * Scripts/test-webkitruby: Added.
3045         Script that can be used to run all webkitruby tests.
3046
3047         * Scripts/test-webkit-scripts:
3048         Also run the ruby tests.
3049
3050         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
3051         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
3052         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
3053         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
3054         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
3055         Tests for the new script.
3056
3057 2012-12-18  Dominic Mazzoni  <dmazzoni@google.com>
3058
3059         AX: support clickPoint in DRT for chromium
3060         https://bugs.webkit.org/show_bug.cgi?id=97359
3061
3062         Reviewed by Chris Fleizach.
3063
3064         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
3065         several more tests can pass.
3066
3067         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3068         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
3069         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
3070         (WebTestRunner):
3071         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
3072         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
3073         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
3074         (AccessibilityUIElement):
3075
3076 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3077
3078         Build fix after r138045.
3079
3080         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3081         (PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
3082         is not explicitly specified. The condition was backwards but never matched so we
3083         always ran the test regardless of whether it's listed in the skipped list or not.
3084         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3085         (test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.
3086
3087 2012-12-18  Emil A Eklund  <eae@chromium.org>
3088
3089         TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
3090         https://bugs.webkit.org/show_bug.cgi?id=105332
3091         
3092         Reviewed by Levi Weintraub.
3093         
3094         Create new test suite for LayoutUnit tests as the KURL tests are
3095         of the incompatible TEST_F type.
3096
3097         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3098         (TestWebKitAPI):
3099         (TestWebKitAPI::TEST_F):
3100
3101 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3102
3103         Running a skipped test with run-perf-tests could alert the user
3104         https://bugs.webkit.org/show_bug.cgi?id=105219
3105
3106         Reviewed by Eric Seidel.
3107
3108         Force run skipped performance tests explicitly specified in the command line.
3109         Also warn the user when the specified paths don't exist.
3110
3111         * Scripts/webkitpy/layout_tests/port/base.py:
3112         (Port.relative_test_filename):
3113         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3114         (PerfTestsRunner._parse_args):
3115         (PerfTestsRunner._collect_tests):
3116         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3117         (test_collect_tests_with_skipped_list_and_files):
3118
3119 2012-12-18  Yaron Friedman  <yfriedman@chromium.org>
3120
3121         Chrome Android java output is too verbose
3122         https://bugs.webkit.org/show_bug.cgi?id=105247
3123
3124         Reviewed by Tony Chang.
3125
3126         Pass -quiet to ant to suppress extraneous output.
3127
3128         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3129         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3130
3131 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3132
3133         Consider removing --pause-before-testing option
3134         https://bugs.webkit.org/show_bug.cgi?id=105248
3135
3136         Reviewed by Eric Seidel.
3137
3138         Remove --pause-before-testing option.
3139
3140         * Tools/Scripts/webkitpy/layout_tests/port/driver.py:
3141         (DriverProxy.start): Removed.
3142         * Scripts/webkitpy/performance_tests/perftest.py:
3143         (PerfTest.__init__):
3144         (PerfTest.test_path): Renamed from path_or_url.
3145         (PerfTest.run):
3146         (PerfTest): Removed "driver" argument.
3147         (PerfTest._run_with_driver):
3148         (PerfTest.run_single):
3149         (ChromiumStylePerfTest.__init__):
3150         (PageLoadingPerfTest.__init__):
3151         (PageLoadingPerfTest.run_single):
3152         (PageLoadingPerfTest._run_with_driver): Renamed from run so that PerfTest.run can create a driver for us.
3153         (ReplayPerfTest.__init__):
3154         (ReplayPerfTest.prepare):
3155         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3156         (TestPageLoadingPerfTest.test_run):
3157         (TestPageLoadingPerfTest.test_run_with_memory_output):
3158         (TestPageLoadingPerfTest.test_run_with_bad_output):
3159         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3160         (PerfTestsRunner._parse_args):
3161         (PerfTestsRunner._run_tests_set): Removed the code to create a driver and pause before running the test.
3162         (PerfTestsRunner._run_single_test): Removed "driver" argument.
3163         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3164         (run_test):
3165         (test_run_test_pause_before_testing): Removed.
3166
3167 2012-12-18  Alberto Garcia  <agarcia@igalia.com>
3168
3169         [GTK] Tests that time out are not considered as failures.
3170         https://bugs.webkit.org/show_bug.cgi?id=105318
3171
3172         Reviewed by Martin Robinson.
3173
3174         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3175         (RunGtkAPITests.commandComplete):
3176         Consider log lines that end with TIMEOUT as errors.
3177
3178         * Scripts/run-gtk-tests:
3179         (TestRunner.run_tests):
3180         Consider timeouts as failures when returning the number of failed
3181         tests.
3182
3183 2012-12-18  Pravin D  <pravin.d@samsung.com>
3184
3185         Unreviewed, adding secondary email.
3186
3187         * Scripts/webkitpy/common/config/committers.py:
3188
3189 2012-12-18  Pravin D  <pravin.d@samsung.com>
3190
3191         Unreviewed, promoting myself to committer's list.
3192
3193         * Scripts/webkitpy/common/config/committers.py:
3194
3195 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3196
3197         [EFL] ImageDiff does not build on WebKit2 only builds
3198         https://bugs.webkit.org/show_bug.cgi?id=105288
3199
3200         Reviewed by Kenneth Rohde Christiansen.
3201
3202         Moved ImageDiff to the efl/ folder inside Tools/ (so we don't pollute
3203         the folder with things which are EFL-specific.
3204
3205         ImageDiff will be built by default now regardless of WebKit API flavor
3206         you choose.
3207
3208         * CMakeLists.txt:
3209         * DumpRenderTree/efl/CMakeLists.txt:
3210         * efl/ImageDiff/CMakeLists.txt: Added.
3211         * efl/ImageDiff/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/efl/ImageDiff.cpp.
3212
3213 2012-12-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3214
3215         [EFL][WK2] When creating new windows, use the opener's context
3216         https://bugs.webkit.org/show_bug.cgi?id=105283
3217
3218         Reviewed by Laszlo Gombos.
3219
3220         Use the context of the opener if exists.
3221
3222         * MiniBrowser/efl/main.c:
3223         (on_key_down):
3224         (on_window_create):
3225         (window_create):
3226         (elm_main):
3227
3228 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3229
3230         [EFL][WK2] Gardening of TestWebKitAPI tests
3231         https://bugs.webkit.org/show_bug.cgi?id=105268
3232
3233         Reviewed by Kenneth Rohde Christiansen.
3234
3235         Some tests were marked as failing but are passing and the newly added
3236         LayoutUnit should have it's own binary because it conflicts with the
3237         fixture used by KURL and is failing on the bots because of that.
3238
3239         * TestWebKitAPI/CMakeLists.txt:
3240         * TestWebKitAPI/PlatformEfl.cmake:
3241
3242 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
3243
3244         [chromium] move webintent related methods to TestRunner library
3245         https://bugs.webkit.org/show_bug.cgi?id=105164
3246
3247         Reviewed by Darin Fisher.
3248
3249         Also deleted the unused deliveredIntentFailure and
3250         deliveredIntentResult methods.
3251
3252         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3253         (DRTTestRunner::DRTTestRunner):
3254         * DumpRenderTree/chromium/DRTTestRunner.h:
3255         (DRTTestRunner):
3256         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3257         (WebKit):
3258         (WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest):
3259         (WebTestRunner::WebTestDelegate::currentWebIntentRequest):
3260         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3261         (WebKit):
3262         (WebTestProxyBase):
3263         (WebTestRunner::WebTestProxy::registerIntentService):
3264         (WebTestRunner::WebTestProxy::dispatchIntent):
3265         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3266         (WebTestRunner::TestRunner::TestRunner):
3267         (WebTestRunner::TestRunner::sendWebIntentResponse):
3268         (WebTestRunner):
3269         (WebTestRunner::TestRunner::deliverWebIntent):
3270         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3271         (TestRunner):
3272         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3273         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3274         (WebTestRunner::WebTestProxyBase::registerIntentService):
3275         (WebTestRunner):
3276         (WebTestRunner::WebTestProxyBase::dispatchIntent):
3277         * DumpRenderTree/chromium/WebViewHost.cpp:
3278         (WebViewHost::setCurrentWebIntentRequest):
3279         (WebViewHost::currentWebIntentRequest):
3280         * DumpRenderTree/chromium/WebViewHost.h:
3281         (WebKit):
3282         (WebViewHost):
3283
3284 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
3285
3286         [chromium] move editing callback dumping to the WebTestProxy
3287         https://bugs.webkit.org/show_bug.cgi?id=105013
3288
3289         Reviewed by Darin Fisher.
3290
3291         To decide whether or not to dump the editing callbacks, the WebTestProxy
3292         needs to query the TestRunner. For this purpose, I introduce a
3293         WebTestRunner class that just exposes the shouldDumpEditingCallbacks
3294         method. In contrast to e.g. WebEventSender, the WebTestRunner is just
3295         an interface, and it is not owned by the WebTestInterfaces, but the
3296         embedder of the TestRunner library must provide it. This will change
3297         once all TestRunner methods are in the library.
3298
3299         * DumpRenderTree/DumpRenderTree.gypi:
3300         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3301         (DRTTestRunner::DRTTestRunner):
3302         (DRTTestRunner::reset):
3303         * DumpRenderTree/chromium/DRTTestRunner.h:
3304         (DRTTestRunner):
3305         (DRTTestRunner::taskList):
3306         (DRTTestRunner::WorkQueue::taskList):
3307         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3308         (WebTestRunner):
3309         (WebTestInterfaces):
3310         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3311         (WebKit):
3312         (WebTestRunner):
3313         (WebTestProxyBase):
3314         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3315         (WebTestRunner::WebTestProxy::shouldEndEditing):
3316         (WebTestRunner::WebTestProxy::shouldInsertNode):
3317         (WebTestRunner::WebTestProxy::shouldInsertText):
3318         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3319         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3320         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3321         (WebTestRunner::WebTestProxy::didBeginEditing):
3322         (WebTestRunner::WebTestProxy::didChangeSelection):
3323         (WebTestRunner::WebTestProxy::didChangeContents):
3324         (WebTestRunner::WebTestProxy::didEndEditing):
3325         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
3326         (WebTestRunner):
3327         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
3328         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3329         (WebTestRunner::TestRunner::TestRunner):
3330         (WebTestRunner::TestRunner::~TestRunner):
3331         (WebTestRunner):
3332         (WebTestRunner::TestRunner::reset):
3333         (WebTestRunner::TestRunner::shouldDumpEditingCallbacks):
3334         (WebTestRunner::TestRunner::dumpEditingCallbacks):
3335         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3336         (TestRunner):
3337         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3338         (WebTestRunner::WebTestInterfaces::Internal::testRunner):
3339         (WebTestRunner::WebTestInterfaces::Internal::setTestRunner):
3340         (WebTestInterfaces::Internal):
3341         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3342         (WebTestRunner::WebTestInterfaces::testRunner):
3343         (WebTestRunner):
3344         (WebTestRunner::WebTestInterfaces::setTestRunner):
3345         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3346         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3347         (WebTestRunner):
3348         (WebTestRunner::WebTestProxyBase::shouldBeginEditing):
3349         (WebTestRunner::WebTestProxyBase::shouldEndEditing):
3350         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
3351         (WebTestRunner::WebTestProxyBase::shouldInsertText):
3352         (WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
3353         (WebTestRunner::WebTestProxyBase::shouldDeleteRange):
3354         (WebTestRunner::WebTestProxyBase::shouldApplyStyle):
3355         (WebTestRunner::WebTestProxyBase::didBeginEditing):
3356         (WebTestRunner::WebTestProxyBase::didChangeSelection):
3357         (WebTestRunner::WebTestProxyBase::didChangeContents):
3358         (WebTestRunner::WebTestProxyBase::didEndEditing):
3359         * DumpRenderTree/chromium/TestShell.cpp:
3360         (TestShell::initialize):
3361         (TestShell::createNewWindow):
3362         * DumpRenderTree/chromium/WebViewHost.cpp:
3363         (WebViewHost::shouldBeginEditing):
3364         (WebViewHost::shouldEndEditing):
3365         (WebViewHost::shouldInsertNode):
3366         (WebViewHost::shouldInsertText):
3367         (WebViewHost::shouldChangeSelectedRange):
3368         (WebViewHost::shouldDeleteRange):
3369         (WebViewHost::shouldApplyStyle):
3370         * DumpRenderTree/chromium/WebViewHost.h:
3371         (WebViewHost):
3372
3373 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3374
3375         [chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences
3376         https://bugs.webkit.org/show_bug.cgi?id=105154
3377
3378         Reviewed by Tony Chang.
3379
3380         If the settings are modified directly, the embedder can't keep track of
3381         them and might accidentially override the changed settings.
3382
3383         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3384         (WebPreferences):
3385         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3386         (WebTestRunner::TestRunner::TestRunner):
3387         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
3388         (WebTestRunner):
3389         (WebTestRunner::TestRunner::setMinimumTimerInterval):
3390         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3391         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3392         (TestRunner):
3393         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3394         (WebTestRunner::WebPreferences::reset):
3395         (WebTestRunner::WebPreferences::applyTo):
3396
3397 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3398
3399         Unreviewed unit test skipping.
3400
3401         Filed https://bugs.webkit.org/show_bug.cgi?id=105253 to re-enable them.
3402
3403         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3404         (TestWebKitAPI):
3405         (TestWebKitAPI::TEST):
3406
3407 2012-12-17  Dean Jackson  <dino@apple.com>
3408
3409         Unreviewed. Add Silvia Pfeiffer to contributor list.
3410
3411         * Scripts/webkitpy/common/config/committers.py:
3412
3413 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3414
3415         build.webkit.org - add more google windows bots
3416         https://bugs.webkit.org/show_bug.cgi?id=105225
3417
3418         Reviewed by Eric Seidel.
3419
3420         Adds two more windows bots (google-windows-3, a builder, and
3421         google-windows-4, a tester) for the Chromium configs.
3422
3423         * BuildSlaveSupport/build.webkit.org-config/config.json:
3424
3425 2012-12-17  Eric Seidel  <eric@webkit.org>
3426
3427         Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100)
3428         https://bugs.webkit.org/show_bug.cgi?id=105217
3429
3430         Reviewed by Dirk Pranke.
3431
3432         Previously --profile would fail strangely if find_unused_filename returned None
3433         (which would happen as soon as we had 100 report files).
3434         Now we'll search through 1000 filenames before giving up (and assert if we failed to find one).
3435         I also made some minor cleanups to the output of perf, and tried to make the
3436         commands more self-documenting by using long-names for args.
3437
3438         * Scripts/webkitpy/common/system/profiler.py:
3439         (SingleFileOutputProfiler.__init__):
3440         (Perf.attach_to_pid):
3441         (Perf.profile_after_exit):
3442
3443 2012-12-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3444
3445         Unreviewed, rolling out r137198.
3446         http://trac.webkit.org/changeset/137198
3447         https://bugs.webkit.org/show_bug.cgi?id=105212
3448
3449         This patch is causing API behavior compatibility problems
3450         (Requested by zdobersek on #webkit).
3451
3452         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3453         (willSendRequestCallback):
3454
3455 2012-12-17  Elliott Sprehn  <esprehn@chromium.org>
3456
3457         Unreviewed. Adding myself to committers list.
3458
3459         * Scripts/webkitpy/common/config/committers.py:
3460
3461 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3462
3463         nrwt: shuffle code around for cleanup in run_webkit_tests.py
3464         https://bugs.webkit.org/show_bug.cgi?id=105078
3465
3466         Reviewed by Ojan Vafai.
3467
3468         This patch reorders functions so that run_webkit_tests can be
3469         understood in a top-down matter better, and to make things slightly
3470         more sensible when I merge manager.py into it.
3471
3472         Also, this adds tests for the actual main() routine, which had several
3473         bugs get through testing a week or two ago.
3474
3475         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3476         (main):
3477         (parse_args):
3478         (_set_up_derived_options):
3479         (run):
3480         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3481         (RunTest):
3482         (RunTest.test_no_http_tests):
3483         (PortTest.disabled_test_mac_lion):
3484         (MainTest):
3485         (MainTest.test_exception_handling):
3486         (MainTest.test_exception_handling.interrupting_run):
3487         (MainTest.test_exception_handling.successful_run):
3488         (MainTest.test_exception_handling.successful_run.FakeRunDetails):
3489         (MainTest.test_exception_handling.exception_raising_run):
3490
3491 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3492
3493         webkitpy: move --lint-test-files code into its own module
3494         https://bugs.webkit.org/show_bug.cgi?id=105077
3495
3496         Reviewed by Eric Seidel.
3497
3498         It really didn't need to be in run_webkit_tests.py anymore.
3499         This patch adds a new lint-test-expectations scripts to Tools/Scripts;
3500         rwt --lint-test-files is still supported for backwards compatibility
3501         for now.
3502
3503         * Scripts/lint-test-expectations: Added.
3504         * Scripts/webkitpy/layout_tests/lint_test_expectations.py: Added.
3505         (lint):
3506         (main):
3507         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: Added.
3508         (FakePort):
3509         (FakePort.__init__):
3510         (FakePort.test_configuration):
3511         (FakePort.expectations_dict):
3512         (FakePort.skipped_layout_tests):
3513         (FakePort.all_test_configurations):
3514         (FakePort.configuration_specifier_macros):
3515         (FakePort.get_option):
3516         (FakeFactory):
3517         (FakeFactory.__init__):
3518         (FakeFactory.get):
3519         (FakeFactory.all_port_names):
3520         (LintTest):
3521         (LintTest.test_all_configurations):
3522         (LintTest.test_lint_test_files):
3523         (LintTest.test_lint_test_files__errors):
3524         (MainTest):
3525         (MainTest.test_success):
3526         (MainTest.test_success.interrupting_lint):
3527         (MainTest.test_success.successful_lint):
3528         (MainTest.test_success.exception_raising_lint):
3529         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3530         (main):
3531         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3532         (StreamTestingMixin.assertNotEmpty):
3533
3534 2012-12-17  Adam Klein  <adamk@chromium.org>
3535
3536         build-webkit: rename --template-tag to --template-element to match ENABLE #define name
3537         https://bugs.webkit.org/show_bug.cgi?id=105072
3538
3539         Reviewed by Laszlo Gombos.
3540
3541         * Scripts/webkitperl/FeatureList.pm:
3542
3543 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3544
3545         Add some unit testing for WTF::clampTo* functions
3546         https://bugs.webkit.org/show_bug.cgi?id=105060
3547
3548         Reviewed by Emil A Eklund.
3549
3550         The new tests are targeted at clamping to int / unsigned and float as those are
3551         the one explicitely exposed through more dedicated functions (like clampToInteger,
3552         clampToPositiveInteger and clampToFloat).
3553
3554         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3555
3556 2012-12-17  Eric Seidel  <eric@webkit.org>
3557
3558         rpt --profile --chromium-android throws exception
3559         https://bugs.webkit.org/show_bug.cgi?id=105061
3560
3561         Reviewed by Daniel Bates.
3562
3563         Somehow popen(args) got turned into popen(*args) at some point,
3564         which caused my new stringify code to fail when args was passed by name.
3565         Fixed and tested.
3566
3567         * Scripts/webkitpy/common/system/executive.py:
3568         (Executive._stringify_args):
3569         (Executive):
3570         (Executive.popen):
3571         * Scripts/webkitpy/common/system/executive_unittest.py:
3572         (ExecutiveTest.test_popen_args):
3573
3574 2012-12-17  Mark Pilgrim  <pilgrim@chromium.org>
3575
3576         Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
3577         https://bugs.webkit.org/show_bug.cgi?id=105054
3578
3579         Reviewed by Jochen Eisinger.
3580
3581         Part of a refactoring series; see tracking bug 82948.
3582
3583         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3584         (NotificationPresenter::show):
3585         * DumpRenderTree/chromium/Task.cpp:
3586         (postTask):
3587         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
3588
3589 2012-12-17  Emil A Eklund  <eae@chromium.org>
3590
3591         Clamp values in LayoutUnit::operator/ when SATURATED_LAYOUT_ARITHMETIC is enabled
3592         https://bugs.webkit.org/show_bug.cgi?id=104955
3593
3594         Reviewed by Julien Chaffraix.
3595
3596         Add tests for LayoutUnit.
3597
3598         * TestWebKitAPI/CMakeLists.txt:
3599         * TestWebKitAPI/ForwardingHeaders: Added.
3600         * TestWebKitAPI/ForwardingHeaders/WebCore: Added.
3601         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Added.
3602         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3603         * TestWebKitAPI/TestWebKitAPI.gypi:
3604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3605         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Added.
3606         (TestWebKitAPI):
3607         (TestWebKitAPI::TEST):
3608         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3609
3610 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3611
3612         [chromium] removed unused preferences from testRunner.overridePreference
3613         https://bugs.webkit.org/show_bug.cgi?id=105169
3614
3615         Reviewed by Tony Chang.
3616
3617         Most notably this removes the code related to font family maps which is
3618         now handled via window.internals.settings
3619
3620         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3621         (WebPreferences):
3622         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3623         (WebTestRunner::TestRunner::overridePreference):
3624         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3625         (TestRunner):
3626         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3627         (WebTestRunner: